[Bug 648100] Review Request: ghc-xml - A simple XML library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=648100
Jens Petersen changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Jens Petersen 2011-01-06 01:51:35 EST
---
Sorry "soon" became 2011... :-/
I note that xml-1.3.7/Text/XML/Light/Lexer.hs is missing a (license) header.
It would be good to ask to author to add one.
Here is the review:
+:ok, NA: not applicable
MUST Items:
[+] MUST: rpmlint output
ghc-xml.src: W: strange-permission ghc-xml.spec 0640L
ghc-xml.src: W: strange-permission xml-1.3.7.tar.gz 0640L
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
ghc-xml-prof.x86_64: E: devel-dependency ghc-xml-devel
ghc-xml-prof.x86_64: W: no-documentation
ghc-xml-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-7.0.1/xml-1.3.7/libHSxml-1.3.7_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
These are ok.
[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release
fc2d7e1a321b4393dd444b16ab6ba669 xml-1.3.7.tar.gz
[+] MUST: must successfully compile and build into binary rpms on one main arch
http://koji.fedoraproject.org/koji/taskinfo?taskID=2701815
[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
Package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 523877] Review Request: CBFlib - crystallography binary format library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523877 tjyuviaej changed: What|Removed |Added CC||tjyuviaej+cr...@gmail.com --- Comment #29 from tjyuviaej 2011-01-05 23:04:09 EST --- drel.py is called at the line 8471 in src/cbf.c (line number from 0.9.1.1rc2 tarball). And drel.py (src/drel.py) python script imports CifFile and StarFile which are provided by PyCifRW. I'm afraid that this means CBFlib requires PyCifRW which has a unique license. I have a private package for PyCifRW and can submit it for package preview. However I don't know how to request the assessment of new licenses. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542045] Review Request: php-htmlpurifier - standards-compliant HTML filter library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542045 Bug 542045 depends on bug 576032, which changed state. Bug 576032 Summary: Review Request: php-channel-htmlpurifier - Adds htmlpurifier project channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=576032 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #11 from David Nalley 2011-01-05 22:00:33 EST --- Version bump for this vulnerability http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-2479 SPEC: http://ke4qqq.fedorapeople.org/php-htmlpurifier-htmlpurifer.spec SRPM: http://ke4qqq.fedorapeople.org/php-htmlpurifier-htmlpurifier-4.2.0-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662301] Review Request: plotdrop - A minimal GNOME front-end to Gnuplot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662301 --- Comment #6 from Mohamed El Morabity 2011-01-05 18:56:34 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #19 from Martin Gieseking 2011-01-05 18:09:14 EST --- (In reply to comment #18) > Of course, I understand this. But consider the point of someone who developed > the utility for free, has done already most of the packaging, has done an > informal review on another package, has submitted a bug report and a relative > patch to fix it. Everything for free. Yes, sure. I'm also an upstream developer and a Fedora packager. All this work is done in my spare time and offered for free too. This is probably true for most of the Fedora people. So you're in good company. > If this is the only solution, then I could do that. But what's wrong with the > latest release ? What prevents it from being pushed in ? No, it's not the only solution. The point is that you can't open a review request for someone else. If a package is approved, it's assigned to the person who created the review request. This person is responsible for the package and has to maintain it, i.e request git distro branches, create koji builds, push the builds to the update server etc. Thus, simply speaking, it's not possible that someone else pushes the package of this ticket into Fedora. So, one aspect that prevents your latest release from being added to Fedora is that you're not sponsored yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #18 from Guido Trentalancia 2011-01-05 17:18:50 EST --- (In reply to comment #17) > (In reply to comment #16) > > So I really expect someone to push this package, as it > > is now beginning to take more time for packaging and other collateral stuff > > than it took to develop the utility itself ! > > Sorry, Guido, but it doesn't work this way. Preparing clean packages is as > important as developing working program code. Of course, I understand this. But consider the point of someone who developed the utility for free, has done already most of the packaging, has done an informal review on another package, has submitted a bug report and a relative patch to fix it. Everything for free. And in the end, the utility can be just fetched from the Internet as it is (tar archive, GNU packaging), built and installed on the fly on any recent distribution... Also, the latest release (1.3.2-6) looks fine to me. It adheres to Packaging Guidelines, it builds and installs fine on Fedora. > Thus, it can take some time to get a package approved. If it is just a matter of waiting, then that's fine to me. > Joining the packager group requires that you're willing to invest time in > preparing and maintaining packages and that you have an understanding of the > packaging guidelines. The latter is usually shown by doing some informal > reviews of other packager's submissions. I have no interest at the moment for joining the packager or maintainer group other than what relates this package. For example, I am already doing upstream testing of most Linux stuff. > BTW, if you don't have the time and/or don't want to maintain this package > yourself, you can also add your utility to the package wishlist > (http://fedoraproject.org/wiki/PackageMaintainers/WishList) and wait for some > other packager to pick it. If this is the only solution, then I could do that. But what's wrong with the latest release ? What prevents it from being pushed in ? If there is something else that I can do in a reasonably short time, I will do. Otherwise if it's too complicated, then we'd better leave it to the WishList or let somebody pick this request and follow up... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634621] Review Request: mingw32-qpid-cpp - MinGW Windows AMQP daemons and libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634621 --- Comment #11 from Lon Hohberger 2011-01-05 17:03:11 EST --- ACCEPT based on comment #9. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634621] Review Request: mingw32-qpid-cpp - MinGW Windows AMQP daemons and libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634621 Andrew Beekhof changed: What|Removed |Added CC||and...@beekhof.net Flag|fedora-cvs- |fedora-cvs? --- Comment #10 from Andrew Beekhof 2011-01-05 16:54:48 EST --- Whanks lon, re-requesting CVS New Package SCM Request === Package Name: mingw32-qpid-cpp Short Description: MinGW Windows AMQP daemons and libraries Owners: beekhof, tross Branches: f14 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634621] Review Request: mingw32-qpid-cpp - MinGW Windows AMQP daemons and libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634621
--- Comment #9 from Lon Hohberger 2011-01-05 16:52:20 EST ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Done, See comment #3.
MUST: The package must be named according to the Package Naming Guidelines .
PASS, however, note that the package is prefixed with "mingw32-" consistent
with other packages destined for use in the MinGW environment.
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
PASS; matches.
MUST: The package must meet the Packaging Guidelines .
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
PASS; License is ASL 2.0
MUST: The License field in the package spec file must match the actual license.
PASS; verified from upstream tarball.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
PASS; LICENSE / notice is included in %doc in the current spec file
noted in comment #1.
MUST: The spec file must be written in American English.
PASS
MUST: The spec file for the package MUST be legible.
PASS
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
PASS; verified with sha256sum:
http://people.apache.org/~robbie/qpid/0.8/RC3/qpid-0.8.tar.gz
970755a17a16e4ad879c7529f648266e9667db54944f55b1f66f96497412dd37
against Andrew's source rpm:
970755a17a16e4ad879c7529f648266e9667db54944f55b1f66f96497412dd37
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
PASS; package compiles in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2703449
MUST: If the package does not successfully compile...
PASS
MUST: All build dependencies must be listed in BuildRequires, except...
PASS.
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
PASS / N/A. Package has no locale data.
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
PASS / N/A.
MUST: Packages must NOT bundle copies of system libraries.
PASS
MUST: If the package is designed to be relocatable...
N/A
MUST: A package must own all directories that it creates.
PASS
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
PASS; see build output
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
PASS; only one files section and no duplicate files reported
during build
MUST: Each package must consistently use macros.
PASS
MUST: The package must contain code, or permissable content.
PASS; package contains source code.
MUST: Large documentation files must go in a -doc subpackage.
N/A
MUST: If a package includes something as %doc ...
PASS
MUST: Header files must be in a -devel package.
PASS - EXCEPTION: mingw32 development-oriented packages
apparently are not required to meed this criteria.
Libraries, development libraries, and headers were
all in a single package. (Ex: mingw32-qt, mingw32-tk)
MUST: Static libraries must be in a -static package.
PASS - EXCEPTION: mingw32 development-oriented packages
apparently are not required to meet this criteria.
Libraries, development libraries, and headers were
all in a single package. (Ex: mingw32-qt, mingw32-tk)
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
PASS - EXCEPTION: mingw32 development-oriented packages
apparently are not required to meet this criteria.
Libraries, development libraries, and headers were
all in a single package. (Ex: mingw32-qt, mingw32-tk)
MUST: In the vast majority of cases, devel packages...
PASS; no -devel package.
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
PASS; no .la libtool archives.
MUST: Packages containing GUI applications.
PASS; no GUI application; this is a development library.
MUST: Packages must not own files or directories already owned by other
packages.
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #17 from Martin Gieseking 2011-01-05 16:34:46 EST --- (In reply to comment #16) > So I really expect someone to push this package, as it > is now beginning to take more time for packaging and other collateral stuff > than it took to develop the utility itself ! Sorry, Guido, but it doesn't work this way. Preparing clean packages is as important as developing working program code. Thus, it can take some time to get a package approved. As Jason already mentioned, the initial sponsoring process can delay the approval of the first package because there are quite a few new contributers waiting to get sponsored (see http://fedoraproject.org/PackageReviewStatus/NEW.html for example). Joining the packager group requires that you're willing to invest time in preparing and maintaining packages and that you have an understanding of the packaging guidelines. The latter is usually shown by doing some informal reviews of other packager's submissions. Personally, I'm pretty busy with my job at the moment, and I still have two contributors waiting for my sponsorship which also takes time. So I'm currently not able to sponsor you. BTW, if you don't have the time and/or don't want to maintain this package yourself, you can also add your utility to the package wishlist (http://fedoraproject.org/wiki/PackageMaintainers/WishList) and wait for some other packager to pick it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646663] Rename review: drupal -> drupal6, F15+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646663 Sven Lankes changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Sven Lankes 2011-01-05 16:22:18 EST --- I've finally gotten around to actually try the update. It worked as expected. I agree that a provides isn't needed here - the new package isn't going to be a drop-in replacement anyway. So - no scary new rpmlint warnings, the versioning is sane - this rename review is approved. Sorry for the delay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 539693] Review Request: plowsahre - command-line downloader/uploader for some of the most popular file-sharing websites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539693 Thibault North changed: What|Removed |Added Status|NEW |ASSIGNED CC||thibault.no...@gmail.com AssignedTo|nob...@fedoraproject.org|thibault.no...@gmail.com --- Comment #2 from Thibault North 2011-01-05 16:20:43 EST --- I'll take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596138] Review Request: NSS-GUI - A graphical user interface for NSS security databases
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=596138
--- Comment #9 from Jason Tibbitts 2011-01-05 16:18:30 EST
---
Just noticed this when going over old review tickets. Perhaps I can answer a
few questions:
The package can still be included in the Fedora 14 repositories; we won't stop
that for quite some time yet.
Reviews are mostly about packaging, but the process does not entirely bypass
all consideration of the software itself. For example, it is important that it
actually work and not open up massive security holes.
Even though it's a small package, it still needs a bit of work. Did you ever
run rpmlint over the srpm and resulting binary rpms? It's expected that you do
so.
nss-gui.x86_64: W: no-documentation
nss-gui.x86_64: W: no-manual-page-for-binary nss-gui
It might be nice to have some documentation. It would also be nice to have
some indication of the license.
nss-gui-debuginfo.x86_64: E: debuginfo-without-sources
This generally indicates a build problem and indeed it seems that the compiler
is not being called with the proper flags. You'll need to figure out how to
pass %optflags or $RPM_OPT_FLAGS. Looks like this will involve Makefile
patching as the included makefile doesn't seem to pay attention to anything.
The use of macros in the spec is inconsistent. Generally you should just not
use %{__rm} and such unless for some reason you really like pointless typing,
but if you really do want to use those macros then you also need to use %{__cp}
and %{__make} and such.
The description could use a bit less cryptic, I think. If this is end-user
software then some additional explanation is warranted. Perhaps that's why you
haven't attracted any reviewers; they can't figure out what it's supposed to
do.
The software doesn't seem to work for me. I built in mock for x86_64 rawhide
and installed it on a rawhide VM; nss-gui fails to start:
Error: Platform version '2.0b7' is not compatible with
minVersion >= 1.9
maxVersion <= 1.9.2.*
At the least that indicates that some dependencies are off.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652573] Review Request: ghc-zip-archive - Haskell zip-archive library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652573 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System 2011-01-05 16:19:35 EST --- ghc-zip-archive-0.1.1.6-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ghc-zip-archive'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ghc-zip-archive-0.1.1.6-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596138] Review Request: nss-gui - A graphical user interface for NSS security databases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596138 Jason Tibbitts changed: What|Removed |Added Summary|Review Request: NSS-GUI - A |Review Request: nss-gui - A |graphical user interface|graphical user interface |for NSS security databases |for NSS security databases -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526100] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526100 Jason Tibbitts changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|fedora-review?, | |needinfo?(michel+...@sylves | |tre.me) | Last Closed||2011-01-05 15:59:05 --- Comment #6 from Jason Tibbitts 2011-01-05 15:59:05 EST --- At this point I'd suggest that anyone else who wishes to submit this package simply do so in a new ticket and mark this one as a duplicate. This ticket should have been closed due to inactivity ages ago. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529181] Review Request: nautilus-flickr-uploader - Simple GUI to upload pics to Flickr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529181 Jason Tibbitts changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526100] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526100 Cristian Ciupitu changed: What|Removed |Added Flag||needinfo?(michel+...@sylves ||tre.me) --- Comment #5 from Cristian Ciupitu 2011-01-05 15:48:37 EST --- I need this package as well because Satchmo[1] depends on it. I'm not a sponsor, but I'll gladly review the SPEC once it's clear who's the packager. [1] http://www.satchmoproject.com/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637402] Review Request: sqlninja - A tool for SQL server injection and takeover
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637402 Michal Ambroz changed: What|Removed |Added CC||re...@seznam.cz Alias||sqlninja -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: lastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 --- Comment #10 from Jochen Schmitt 2011-01-05 15:42:53 EST --- You may create a SCM-Admin request for your package now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: lastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 Jochen Schmitt changed: What|Removed |Added Summary|Review Request: |Review Request: lastfmlib - |liblastfmlib - library | library providing |providing implementation of |implementation of LastFm |LastFm Submission Protocol |Submission Protocol -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667207] Review Request: avoision - Arcade style game of evade and capture
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667207 --- Comment #2 from Tom "spot" Callaway 2011-01-05 15:34:32 EST --- Well, I did mark this bug as depending on Radius-Engine (bz 667205), and mention that explicitly above... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #16 from Guido Trentalancia 2011-01-05 15:35:03 EST --- And I forgot, I have also reported a bug and proposed a patch to fix it for an important APRS package. So I really expect someone to push this package, as it is now beginning to take more time for packaging and other collateral stuff than it took to develop the utility itself ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #15 from Guido Trentalancia 2011-01-05 15:29:18 EST --- Ok, I have just uploaded the latest release 1.3.2-6 to: http://iz6rdb.trentalancia.com/en/ax_emergency_listen-1.3.2-6.src.rpm Everything should be sorted in the best manner. There were rpmlint warnings about: ax_emergency_listen.i386: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/ax_emergency_listen ax_emergency_listen.i386: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/ax_emergency_listen ax_emergency_listen.i386: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ax_emergency_listen which obviously are in conflict with the Packaging Guidelines, but I preferred to keep rpmlint silent. At the end, it's just exactly the same either ways, as those lines are now empty. Do you need anything about ways to get this package sponsored and finally getting it pushed into the distribution ? I have also done a little bit of an informal review for another package, so should I just keep waiting ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609295] Review Request: python-cement - CLI Application Framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609295 BJ Dierkes changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609295] Review Request: python-cement - CLI Application Framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609295 --- Comment #14 from BJ Dierkes 2011-01-05 15:26:45 EST --- New Package SCM Request === Package Name: python-cement Short Description: CLI Application Framework for Python Owners: derks Branches: f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #14 from Martin Gieseking 2011-01-05 15:22:07 EST --- (In reply to comment #13) > - Fixed the init script and the spec for the chkconfig issue (rel 6), although > in truth it's not a "network listening" thing, it has nothing to do with > network interfaces, not even the ax25 ones (which could well be inactive), it > just deals with the serial interface to which, supposedly, a TNC is connected; > and also, have a look below... OK. As far as I understand the guideline text, it doesn't matter whether the service listens to network ports or not. When using the snippets, you're usually on the safe side. > - The very last issue, from my understanding, is about the manual page being > compressed using gzip rather than bz2 and possibly this is something to do > with the fact that I am using rpmlint from upstream. Yes, sorry. I didn't read the message carefully enough. :) > But then, have a look at what happens with the binary package after removing > completely %post and %postun: Why did you remove %post and %postun? They should be present (together with %preun) as they are in the spec file snippets given at http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscript_packaging > and after re-adding %post and %postun: > > ax_emergency_listen.i386: W: no-default-runlevel > /etc/rc.d/init.d/ax_emergency_listen > ax_emergency_listen.i386: W: missing-lsb-keyword Default-Stop in > /etc/rc.d/init.d/ax_emergency_listen Since you haven't posted the latest version yet, I can't say anything about the origin of these warnings. They are probably related to missing parameters in the header of the init script. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634621] Review Request: mingw32-qpid-cpp - MinGW Windows AMQP daemons and libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634621 Andrew Beekhof changed: What|Removed |Added AssignedTo|and...@beekhof.net |l...@redhat.com --- Comment #8 from Andrew Beekhof 2011-01-05 15:09:38 EST --- Lon, apparently comment #4 was insufficient. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 --- Comment #12 from Fedora Update System 2011-01-05 15:07:32 EST --- kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661832] Review Request: kdevelop-pg-qt - A parser generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661832 --- Comment #15 from Fedora Update System 2011-01-05 15:07:56 EST --- kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-01-05 15:03:58 --- Comment #8 from Rex Dieter 2011-01-05 15:03:58 EST --- Thanks! imported/built for rawhide now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-01-05 15:03:29 --- Comment #9 from Rex Dieter 2011-01-05 15:03:29 EST --- Thanks! imported/built for rawhide now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 --- Comment #13 from Fedora Update System 2011-01-05 15:08:01 EST --- kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661832] Review Request: kdevelop-pg-qt - A parser generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661832 --- Comment #14 from Fedora Update System 2011-01-05 15:07:27 EST --- kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661832] Review Request: kdevelop-pg-qt - A parser generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661832 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 --- Comment #9 from Dan Vratil 2011-01-05 15:03:44 EST --- My FAS username is progdan. Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 Jochen Schmitt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Jochen Schmitt 2011-01-05 14:42:05 EST --- Good: - BR automake and autoconf was remove from SPEC file + Local build works fine + Koji build works fine. *** APPROVED *** Please let me know your FAS userid, so I can sponsor your. If you have any issues don't hastle to contact me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529181] Review Request: nautilus-flickr-uploader - Simple GUI to upload pics to Flickr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529181 Juanjo changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2011-01-05 14:34:25 --- Comment #19 from Juanjo 2011-01-05 14:34:25 EST --- I withdraw my review request. It's been more than a year since I opened this ticket and my personal situation at the moment has changed (and it's quite busy). I feel slightly disappointed with the whole process, but anyway I'll try to join the Fedora packaging forces in the future when my day to day is less crazy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #13 from Guido Trentalancia 2011-01-05 14:30:18 EST --- Hi Martin, thanks again for your thoughtful comments ! - Fixed the third issue (in rel 6), very good point I had forgotten that ! - Fixed the init script and the spec for the chkconfig issue (rel 6), although in truth it's not a "network listening" thing, it has nothing to do with network interfaces, not even the ax25 ones (which could well be inactive), it just deals with the serial interface to which, supposedly, a TNC is connected; and also, have a look below... - The very last issue, from my understanding, is about the manual page being compressed using gzip rather than bz2 and possibly this is something to do with the fact that I am using rpmlint from upstream. Anyway, something not to bother with... But then, have a look at what happens with the binary package after removing completely %post and %postun: ax_emergency_listen.i386: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/ax_emergency_listen ax_emergency_listen.i386: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/ax_emergency_listen ax_emergency_listen.i386: W: no-default-runlevel /etc/rc.d/init.d/ax_emergency_listen ax_emergency_listen.i386: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ax_emergency_listen and after re-adding %post and %postun: ax_emergency_listen.i386: W: no-default-runlevel /etc/rc.d/init.d/ax_emergency_listen ax_emergency_listen.i386: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/ax_emergency_listen I have just followed the Guidelines and your suggestions. Of course, rpmlint on the SRPMS is clean. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 646663] Rename review: drupal -> drupal6, F15+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646663 Jon Ciesla changed: What|Removed |Added Blocks||667447 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666572] Review Request: zyGrib - Visualization of meteo data from files in GRIB Format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666572 --- Comment #3 from Pavel Zhukov 2011-01-05 13:40:04 EST --- Corrected SRPM and spec: http://repo.pclinuxos.su/fedora/rpm/zyGrib.spec http://repo.pclinuxos.su/fedora/rpm/zyGrib-3.9.8-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526100] Review Request: django-registration - A user-registration application for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526100 Arun SAG changed: What|Removed |Added CC||saga...@gmail.com --- Comment #4 from Arun SAG 2011-01-05 13:33:34 EST --- ping. I intend to use this package for my personal project, I'd like to see this in Fedora. If the submitter is OK i am ready to take this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 --- Comment #7 from Dan Vratil 2011-01-05 13:37:39 EST --- Fixed and version bumped. Spec URL: http://www.tepsonic.org/files/fedora/lastfmlib.spec SRPM URL: http://www.tepsonic.org/files/fedora/lastfmlib-0.4.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666763 --- Comment #12 from Martin Gieseking 2011-01-05 13:19:05 EST --- (In reply to comment #10) > - Don't know what's wrong with permissions set to 664 (or 644) on the source > archive ??? I suggest just to change the file permissions to 644 in the srpm. It makes rpmlint happy and doesn't hurt as install assigns the proper permissions anyway. > - Why should I strip binaries ? To loose debugging information when at the end > it is compiled with it ? You should not strip the binaries manually. rpmbuild does that automatically when creating the debuginfo package. Obviously, your rpmbuild utility behaves a bit different. > - What's wrong with the config file being place in /etc/sysconfig (is there a > list of known config files somewhere, that is not listing mine ?) ? config files must be marked with %config(noreplace) or plain %config. See http://fedoraproject.org/wiki/PackagingGuidelines#Configuration_files > - Fixed the init script with empty Required-Start and Required-Stop; in the > end, the only thing that is required is that the (kiss) interface has been > configured with kissattach or something equivalent to that; it doesn't even > need the network interface to be up (such as ax0); OK. You should also have a look at http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscript_packaging and adapt the iniscript and the spec file accordingly. > - It's really pointless to provide a manual page for the daemonizer script > (by the way, do you have any better idea on how to "daemonize" without > touching the source files ?); The warning about the missing manpage can be ignored, of course. > - The service is enabled by default, otherwise ? Who decides what is good and > what is bad ? The Fedora guidelines want the packagers not to start services by default. See http://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we > - Manual page not compressed in bzip2 ?? No idea. You don't even have got > that, Martin. Something to do with upstream rpmlint 1.0 that I am using. Fedora's rpmbuild compresses manpages by default. So no action is required here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663092 --- Comment #9 from Magnus Tuominen 2011-01-05 13:17:53 EST --- Created attachment 471919 --> https://bugzilla.redhat.com/attachment.cgi?id=471919 fix to combobox Uploading patch to fix KDE bug #261971 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666572] Review Request: zyGrib - Visualization of meteo data from files in GRIB Format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666572 --- Comment #2 from landgraf 2011-01-05 13:07:02 EST --- 1) Fixed 2) Ok. I cannot upload zyGrib-maps rpm today, because there is very slow Internet speed. I'll upload it in Monday. 3) Fixed 4) Fixed. There isn't README file in sources. I put it separately. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656408] Review Request: perl-Class-Load - A working (require "Class::Name") and more
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656408 --- Comment #12 from Fedora Update System 2011-01-05 12:58:50 EST --- perl-Class-Load-0.06-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656408] Review Request: perl-Class-Load - A working (require "Class::Name") and more
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656408 --- Comment #13 from Fedora Update System 2011-01-05 12:59:11 EST --- perl-Class-Load-0.06-3.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665560] Review Request: rubygem-mail - A Really Ruby Mail Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665560 Mamoru Tasaka changed: What|Removed |Added Depends on||667465 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665560] Review Request: rubygem-mail - A Really Ruby Mail Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665560 --- Comment #4 from Mamoru Tasaka 2011-01-05 11:54:40 EST --- Sorry for delay. For treetop dependency, I filed bug 667465 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 452521] Review Request: perl-Coro - Coroutine process abstraction
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452521 --- Comment #4 from Nicolas Chauvet (kwizart) 2011-01-05 11:51:51 EST --- Thx, that's alright for me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 452521] Review Request: perl-Coro - Coroutine process abstraction
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452521 Petr Pisar changed: What|Removed |Added Status|NEW |CLOSED CC||ppi...@redhat.com Resolution||DUPLICATE Last Closed||2011-01-05 11:46:41 --- Comment #3 from Petr Pisar 2011-01-05 11:46:41 EST --- I'm sorry for hijacking your package. I created the package independently. It's in F15 now. I added you as co-maintainer. I excluded the perl(EV) dependency because it's optional. Once the perl-EV emerges in Fedora (I hope it's possible to compile it against libev. However libev must be upgraded first---bug #667164.), it can be reenabled. *** This bug has been marked as a duplicate of bug 667171 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667171] Review Request: perl-Coro - The only real threads in perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667171 Petr Pisar changed: What|Removed |Added CC||kwiz...@gmail.com --- Comment #7 from Petr Pisar 2011-01-05 11:46:41 EST --- *** Bug 452521 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667171] Review Request: perl-Coro - The only real threads in perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667171 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Coro-5.25-1.fc15 Resolution||RAWHIDE Last Closed||2011-01-05 11:37:57 --- Comment #6 from Petr Pisar 2011-01-05 11:37:57 EST --- Thank you for review and repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664204] Review Request: perl-BackPAN-Index - Interface to the BackPAN index
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664204 Iain Arnell changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664204] Review Request: perl-BackPAN-Index - Interface to the BackPAN index
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664204 --- Comment #6 from Iain Arnell 2011-01-05 11:32:44 EST --- New Package CVS Request === Package Name: perl-BackPAN-Index Short Description: Interface to the BackPAN index Owners: iarnell cweyl Branches: f13 f14 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665395] Review Request: firewalld - A firewall daemon with D-BUS interface providing a dynamic firewall
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665395 Thomas Woerner changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|kars...@redhat.com Flag||fedora-cvs? --- Comment #6 from Thomas Woerner 2011-01-05 11:23:46 EST --- New Package SCM Request === Package Name: firewalld Short Description: A firewall daemon with D-BUS interface providing a dynamic firewall Owners: twoerner Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638647] Review Request: mom - Dynamically manage system resources on virtualization hosts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638647 Adam Litke changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Adam Litke 2011-01-05 11:18:49 EST --- New Package SCM Request === Package Name: mom Short Description: Dynamically manage system resources on virtualization hosts Owners: aglitke Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667416 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED CC||d...@danny.cz AssignedTo|nob...@fedoraproject.org|d...@danny.cz Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609295] Review Request: python-cement - CLI Application Framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609295 Jason Tibbitts changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Jason Tibbitts 2011-01-05 11:13:39 EST --- Thanks, looks good. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667171] Review Request: perl-Coro - The only real threads in perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667171 --- Comment #5 from Jason Tibbitts 2011-01-05 11:10:27 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665395] Review Request: firewalld - A firewall daemon with D-BUS interface providing a dynamic firewall
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665395 --- Comment #5 from Jason Tibbitts 2011-01-05 11:09:28 EST --- This ticket is not assigned to anyone. It should be assigned to the reviewer. Also, it is too early to request f15 branches. Please fix these issues and re-raise the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665676] Review Request: wordpress-plugin-defaults - defaults plugin for WordPress
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665676 --- Comment #3 from Jason Tibbitts 2011-01-05 11:09:50 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664810] Review Request: perl-Regexp-IPv6 - Regular expression for IPv6 addresses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664810 --- Comment #4 from Jason Tibbitts 2011-01-05 11:08:05 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 --- Comment #8 from Jason Tibbitts 2011-01-05 11:10:49 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 --- Comment #7 from Jason Tibbitts 2011-01-05 11:11:11 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634621] Review Request: mingw32-qpid-cpp - MinGW Windows AMQP daemons and libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634621 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs- --- Comment #7 from Jason Tibbitts 2011-01-05 11:06:44 EST --- A few problems here: I don't see any review at all. The ticket is assigned to the person who owns the package. It should be assigned to the reviewer. Whoever actually reviewed this, please assign the ticket to yourself and provide some proper review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591365] Review Request: libexplain - Library functions to explain system call errors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591365 --- Comment #11 from Jason Tibbitts 2011-01-05 11:03:44 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 --- Comment #11 from Jason Tibbitts 2011-01-05 11:07:42 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571816 --- Comment #13 from Jason Tibbitts 2011-01-05 11:03:28 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620385] Review Request: BEDTools - A flexible suite of utilities for comparing genomic features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620385 --- Comment #22 from Fedora Update System 2011-01-05 10:58:46 EST --- BEDTools-2.10.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/BEDTools-2.10.1-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 --- Comment #6 from Jochen Schmitt 2011-01-05 10:44:12 EST --- Good: + remove empty TODO file * Local build works fine * Package contains no patches * Files permissions are ok on %files and %doc stanza Bad: - Please remove the BRs to automake and autoconf. Automake is only requires, if you make a patch to the Makefile.am file and want to recreate the makefile.in file. autoconf is only required, if you want to patch the configure.ac or configure.in file and recreating the configure script. Please bump the release number of your package, if you are uploading a new release of your package for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer backend for phonon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Rex Dieter 2011-01-05 10:15:15 EST --- New Package SCM Request === Package Name: phonon-backend-gstreamer Short Description: Gstreamer backend for phonon Owners: rdieter than ltinkl jreznik thomasj kkofler Branches: f13 f14 InitialCC: tuxbrewr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Rex Dieter 2011-01-05 10:17:06 EST --- New Package SCM Request === Package Name: phonon-backend-xine Short Description: Xine phonon backend Owners: rdieter than ltinkl jreznik thomasj kkofler Branches: f13 f14 InitialCC: tuxbrewr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 --- Comment #7 from Rex Dieter 2011-01-05 10:16:55 EST --- update description for consistency, New Package SCM Request === Package Name: phonon-backend-gstreamer Short Description: Gstreamer phonon backend Owners: rdieter than ltinkl jreznik thomasj kkofler Branches: f13 f14 InitialCC: tuxbrewr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 Rex Dieter changed: What|Removed |Added Summary|Review Request: |Review Request: |phonon-backend-gstreamer - |phonon-backend-gstreamer - |Gstreamer backend for |Gstreamer phonon backend |phonon | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer backend for phonon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 Jaroslav Reznik changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Jaroslav Reznik 2011-01-05 10:03:37 EST --- Thanks. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667416] New: Review Request: util-linux - rename from util-linux-ng
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: util-linux - rename from util-linux-ng https://bugzilla.redhat.com/show_bug.cgi?id=667416 Summary: Review Request: util-linux - rename from util-linux-ng Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: k...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://kzak.fedorapeople.org/review/util-linux.spec SRPM URL: http://kzak.fedorapeople.org/review/util-linux-2.19-0.1.fc15.src.rpm Spec file diff (upgrade from v2.18 to v2.19 and rename): http://kzak.fedorapeople.org/review/2.18-to-2.19-spec.diff Description: the upstream project has been renamed back to util-linux. Please, review changes in the spec file (especially proper Provides: and Obsoletes: setting). Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 Jaroslav Reznik changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Jaroslav Reznik 2011-01-05 10:02:18 EST --- Thanks. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer backend for phonon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 --- Comment #4 from Rex Dieter 2011-01-05 09:39:34 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-gstreamer.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-gstreamer-4.4.4-0.3.20110104.fc13.src.rpm %changelog * Wed Jan 05 2011 Rex Dieter - 2:4.4.4-0.3.20110104 - %%doc COPYING.LIB - add comment on pnonon-gstreamer_snapshot.sh usage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 --- Comment #4 from Rex Dieter 2011-01-05 09:40:19 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine-4.4.4-0.3.20110104.fc13.src.rpm %changelog * Wed Jan 05 2011 Rex Dieter - 4.4.4-0.3.20110104 - %%doc COPYING.LIB - add comment on pnonon-xine_snapshot.sh usage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667403] New: Review Request: perl-Dist-CheckConflicts - Declare version conflicts for your dist
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Dist-CheckConflicts - Declare version conflicts for your dist https://bugzilla.redhat.com/show_bug.cgi?id=667403 Summary: Review Request: perl-Dist-CheckConflicts - Declare version conflicts for your dist Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: p...@city-fan.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Dist-CheckConflicts/branches/fedora/perl-Dist-CheckConflicts.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Dist-CheckConflicts/perl-Dist-CheckConflicts-0.02-2.fc15.src.rpm Description: One shortcoming of the CPAN clients that currently exist is that they have no way of specifying conflicting downstream dependencies of modules. This module attempts to work around this issue by allowing you to specify conflicting versions of modules separately, and deal with them after the module is done installing. For instance, say you have a module Foo, and some other module Bar uses Foo. If Foo were to change its API in a non-backwards-compatible way, this would cause Bar to break until it is updated to use the new API. Foo can't just depend on the fixed version of Bar, because this will cause a circular dependency (because Bar is already depending on Foo), and this doesn't express intent properly anyway - Foo doesn't use Bar at all. The ideal solution would be for there to be a way to specify conflicting versions of modules in a way that would let CPAN clients update conflicting modules automatically after an existing module is upgraded, but until that happens, this module will allow users to do this manually. This package is needed for Package::Stash 0.20. It is compatible with EPEL-4 once its dependencies List::MoreUtils, Sub::Exporter and its dependencies Data::OptList, Params::Util, Sub::Install and Package::Generator are available - I am working on getting these built now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 --- Comment #3 from Jaroslav Reznik 2011-01-05 09:24:39 EST --- Name: ok Summary: ok Release and version: ok, snapshot Group: ok License: ok URL: ok Source: not ok, document phonon_snaphost.sh usage to obtain snapshot tarballs, strange permissions, see rpmlint output BuildRequires: ok Obsoletes/Provides: ok Description: ok Post sections: ok Consistent usage of macros: ok Documentation: not ok, please include COPYING.LIB Phonon backends directiories owned by Phonon package (required): ok RPMLint phonon-backend-xine.src: W: spelling-error Summary(en_US) backend -> backed, backbend, back end phonon-backend-xine.src: W: spelling-error %description -l en_US backend -> backed, backbend, back end phonon-backend-xine.src: W: strange-permission phonon-xine_snapshot.sh 0775L phonon-backend-xine.src: W: invalid-url Source0: phonon-xine-4.4.4-20110104.tar.bz2 phonon-backend-xine.x86_64: W: no-documentation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer backend for phonon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 --- Comment #3 from Jaroslav Reznik 2011-01-05 09:27:54 EST --- Name: ok Summary: ok Release and version: ok, snapshot Group: ok License: ok URL: ok Source: not ok, document phonon_snaphost.sh usage to obtain snapshot tarballs, strange permissions, see rpmlint output BuildRequires: ok Obsoletes/Provides: ok Description: ok Post sections: ok Consistent usage of macros: ok Documentation: not ok, please include COPYING.LIB phonon-gstreamer.src: W: spelling-error Summary(en_US) backend -> backed, backbend, back end phonon-gstreamer.src: W: spelling-error %description -l en_US backend -> backed, backbend, back end phonon-gstreamer.src: W: strange-permission phonon-gstreamer_snapshot.sh 0775L phonon-gstreamer.src: W: invalid-url Source0: phonon-gstreamer-4.4.4-20110104.tar.bz2 phonon-gstreamer.x86_64: W: no-documentation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Rex Dieter 2011-01-05 09:23:18 EST --- New Package SCM Request === Package Name: kdevelop-php Short Description: Php language plugin for KDevelop Owners: rdieter than ltinkl thomasj kkofler Branches: f13 f14 InitialCC: rnovacek tuxbrewr -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667221] Review Request: phonon-backend-xine - Xine phonon backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667221 Rex Dieter changed: What|Removed |Added Summary|Review Request: phonon-xine |Review Request: |- Xine phonon backend |phonon-backend-xine - Xine ||phonon backend Alias|phonon-xine |phonon-backend-xine --- Comment #2 from Rex Dieter 2011-01-05 09:14:09 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine-4.4.4-0.2.20110104.fc13.src.rpm %changelog * Wed Jan 05 2011 Rex Dieter - 4.4.4-0.2.20110104 - phonon-backend-xine -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667220] Review Request: phonon-backend-gstreamer - Gstreamer backend for phonon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667220 Rex Dieter changed: What|Removed |Added Summary|Review Request: |Review Request: |phonon-gstreamer - |phonon-backend-gstreamer - |Gstreamer backend for |Gstreamer backend for |phonon |phonon --- Comment #2 from Rex Dieter 2011-01-05 09:15:38 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-gstreamer.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-gstreamer-4.4.4-0.2.20110104.fc13.src.rpm %changelog * Wed Jan 05 2011 Rex Dieter - 2:4.4.4-0.2.20110104 - phonon-backend-gstreamer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 205062] Review Request: perl-Sub-Install - Install subroutines into packages easily
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=205062 --- Comment #4 from Fedora Update System 2011-01-05 08:59:53 EST --- perl-Sub-Install-0.924-1.el4.1 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Sub-Install-0.924-1.el4.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 Jaroslav Reznik changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Jaroslav Reznik 2011-01-05 08:51:06 EST --- I'm going to approve this package with current license resolution as GPLv3+ and comment in SPEC file, update it once upstream releases fixed tarballs to GPLv2+. Thanks. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664204] Review Request: perl-BackPAN-Index - Interface to the BackPAN index
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=664204
Petr Pisar changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Petr Pisar 2011-01-05 08:00:08 EST ---
Spec file changes:
--- perl-BackPAN-Index.spec 2010-12-19 08:31:43.0 +0100
+++ perl-BackPAN-Index.spec.1 2011-01-05 06:43:19.0 +0100
@@ -1,6 +1,6 @@
Name: perl-BackPAN-Index
Version:0.39
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Interface to the BackPAN index
License:GPL+ or Artistic
Group: Development/Libraries
@@ -16,12 +16,16 @@
BuildRequires: perl(DBD::SQLite) >= 1.25
BuildRequires: perl(DBIx::Class) >= 0.08109
BuildRequires: perl(DBIx::Class::Schema::Loader) >= 0.05003
+BuildRequires: perl(File::Path)
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(File::Spec::Unix)
BuildRequires: perl(LWP::Simple)
BuildRequires: perl(Module::Build)
BuildRequires: perl(parent)
BuildRequires: perl(Path::Class) >= 0.17
BuildRequires: perl(Test::Compile) >= 0.11
BuildRequires: perl(Test::More) >= 0.90
+BuildRequires: perl(URI::file)
Requires: perl(CLASS) >= 1.00
Requires: perl(Class::Accessor::Fast)
Requires: perl(DBD::SQLite) >= 1.25
@@ -33,7 +37,10 @@
# Parse::BACKPAN::Packages is deprecated in favor of BackPAN::Index
Obsoletes: perl-Parse-BACKPAN-Packages <= 0.35
-%{?perl_default_filter}
+%{?perl_default_filter:
+%filter_from_requires /perl(CLASS)$/d;/perl(Path::Class)$/d
+%perl_default_filter
+}
%description
This downloads, caches and parses the BackPAN index into a local database
@@ -64,6 +71,10 @@
%{_mandir}/man3/*
%changelog
+* Wed Jan 05 2011 Iain Arnell 0.39-2
+- additional buildrequires for dual-lived modules
+- filter underspecified requires
+
* Sun Dec 19 2010 Iain Arnell 0.39-1
- Specfile autogenerated by cpanspec 1.78.
- obsoletes perl-Parse-BACKPAN-Packages
> FIX: BuildRequire perl(File::Spec) (t/lib/TestUtils.pm:6) as it can dual-live
> in the future (http://search.cpan.org/~smueller/PathTools/).
+BuildRequires: perl(File::Spec)
Ok.
> FIX: BuildRequire perl(File::Path) (t/lib/TestUtils.pm:7) as it can dual-live
> in the future (http://search.cpan.org/~dland/File-Path/).
>
+BuildRequires: perl(File::Path)
Ok.
> FIX: BuildRequire perl(URI::file) (t/lib/TestUtils.pm:28)
+BuildRequires: perl(URI::file)
Ok.
> FIX: BudilRequire perl(File::Spec::Unix) (t/lib/TestUtils.pm:29)
>
+BuildRequires: perl(File::Spec::Unix)
Ok.
> TODO: Filter underspecified perl(CLASS) Requires.
> TODO: Filter underspecified perl(Path::Class) Requires.
>
+%filter_from_requires /perl(CLASS)$/d;/perl(Path::Class)$/d
$ rpm -pq --requires ../RPMS/noarch/perl-BackPAN-Index-0.39-2.fc14.noarch.rpm |
sort |uniq -c |xclip -in
1 perl(App::Cache) >= 0.37
1 perl(Archive::Extract)
1 perl(autodie)
1 perl(BackPAN::Index)
1 perl(BackPAN::Index::Role::AsHash)
1 perl(BackPAN::Index::Schema)
1 perl(base)
1 perl(Class::Accessor::Fast)
1 perl(CLASS) >= 1.00
1 perl(CPAN::DistnameInfo) >= 0.09
1 perl(DBD::SQLite) >= 1.25
1 perl(DBIx::Class::Schema::Loader) >= 0.05003
1 perl(DBIx::Class) >= 0.08109
1 perl(File::Basename)
1 perl(File::stat)
1 perl(LWP::Simple)
1 perl(:MODULE_COMPAT_5.12.2)
1 perl(parent)
1 perl(Path::Class) >= 0.17
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
2 rpmlib(VersionedDependencies) <= 3.0.3-1
Binary requires Ok.
>
> Package does not build in F15
> (http://koji.fedoraproject.org/koji/taskinfo?taskID=2700482) because of bug in
> perl-DBI.
> POSTPONE: This review will be suspended until fix of the perl-DBI in F15.
>
Package builds in F14
(http://koji.fedoraproject.org/koji/getfile?taskID=2702183&name=build.log).
Problem in F15 is just a temporary issue. Ok.
Resolution: Package APPROVED.
Notice: Build for F15 after fixing perl-DBI (emerging perl-Core).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571416] Review Request: GiGi-0.6.0 - C++ OpenGL GUI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571416 --- Comment #19 from Adam Tkac 2011-01-05 07:52:47 EST --- (In reply to comment #18) > (In reply to comment #16) > > That's weird. Can you please tell me which Fedora do you use for building? > > I'm > > building FreeOrion (from svn) on rawhide and those modules are not needed. > > F14 ... well, maybe those files got in as part of some boost update in between > F14 and current rawhide - out of curiousity, could you take a look which > package provides Config.cmake and Util.cmake? There are no Config.cmake or Util.cmake installed but build simple works without them. Not sure what was changed between F14 and rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665331] Review Request: perl-Imager - Perl extension for Generating 24 bit Images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665331 --- Comment #3 from Robin Lee 2011-01-05 07:35:51 EST --- (In reply to comment #2) And rebuild an SRPM since md5sum not matched. Others are not blocking issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666633] Review Request: liblastfmlib - library providing implementation of LastFm Submission Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=33 Dan Vratil changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) |667226 Depends on|667226 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667226] Review Request: tepsonic - A simple, fast and lightweight Qt audio player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667226 Dan Vratil changed: What|Removed |Added Blocks|33 | Depends on||33 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657403
--- Comment #7 from Marc-Andre Lureau 2011-01-05
07:18:15 EST ---
(In reply to comment #6)
> Full review done:
>
>
> Some minor nitpicks / should fix items:
> - The Group tag for the main package should be: System Environment/Libraries
done
> - "Requires: %{name} = %{version}" should be dropped
done
> - The %description for the main package talks about a gtk client and
> libraries,
> but the gtk client is part of the tools package
done: "Client libraries for SPICE desktop servers."
> - Likewise the %description for tools does not mention the gtk client
done: "Simple clients for interacting with SPICE servers."
> - The "Requires: %{name} = %{version}" does not specify the release in the
> package, when subpackages depend on other packages in the same SRPM the
> requires should specify the full NEVR (name epoch version release) like the
> Requires in the devel sub package
fixed, for spice-gtk-python
> - The prefered form for the defattr is:
> %defattr(-,root,root,-)
> rather then:
> %defattr(-, root, root)
done
> - There is no need to specify dir owner ship and the files inside it if
> you want the package to own the dir and all files, for example this:
> %dir %{_includedir}/spice-client-glib/
> %{_includedir}/spice-client-glib/*.h
> Can be written simply as:
> %{_includedir}/spice-client-glib
> Likewise for spice-client-gtk, also you could consider using
> wildcards, condensing the %files devel to:
> %{_libdir}/libspice-client-g*.so
> %{_includedir}/spice-client-g*
> %{_libdir}/pkgconfig/spice-client-g*.pc
> %{_datadir}/gir-1.0/SpiceClientG*-1.0.gir
> %doc %{_datadir}/gtk-doc/html/*
done
http://fedorapeople.org/gitweb?p=elmarco/public_git/spice-gtk.git;a=commitdiff;h=59051f0de1772fadf1fd5ad6661d595585148279;hp=16c5fea8350282425bfe4d36ce4d4c5a9e381304
The SRPM is actually made from a git snapshot of version 0.3.20, which has a
broken python module bug.
I propose we wait until 0.4 release.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571416] Review Request: GiGi-0.6.0 - C++ OpenGL GUI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571416 --- Comment #18 from Karel Volný 2011-01-05 07:04:17 EST --- (In reply to comment #16) > That's weird. Can you please tell me which Fedora do you use for building? I'm > building FreeOrion (from svn) on rawhide and those modules are not needed. F14 ... well, maybe those files got in as part of some boost update in between F14 and current rawhide - out of curiousity, could you take a look which package provides Config.cmake and Util.cmake? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571416] Review Request: GiGi-0.6.0 - C++ OpenGL GUI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571416 --- Comment #17 from Adam Tkac 2011-01-05 06:46:21 EST --- (In reply to comment #15) > (In reply to comment #13) > > Wow, you can always count on your upstreams to do completely bizarre > > things. > > well, seems to me that it is just a matter of changing one line in > http://gigi.svn.sourceforge.net/viewvc/gigi/trunk/GG/CMakeLists.txt?revision=878&view=markup > > I've reported upstream bug, let's see if it gets resolved: > https://sourceforge.net/tracker/?func=detail&aid=3137299&group_id=84040&atid=571538 Thanks for it, upstream bumped version to 0.8.0. New spec + SRPM (it incorporates changes suggested in comment #13): http://atkac.fedorapeople.org/GiGi.spec http://atkac.fedorapeople.org/GiGi-0.8.0-0.2.20110103svn1035.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571416] Review Request: GiGi-0.6.0 - C++ OpenGL GUI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571416 --- Comment #16 from Adam Tkac 2011-01-05 06:42:23 EST --- (In reply to comment #12) > (In reply to comment #10) > > For FreeOrion :) > > well, in that case you should also include the cmake modules that FreeOrion > uses ;-) That's weird. Can you please tell me which Fedora do you use for building? I'm building FreeOrion (from svn) on rawhide and those modules are not needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667171] Review Request: perl-Coro - The only real threads in perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667171 Petr Pisar changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Petr Pisar 2011-01-05 06:28:25 EST --- New Package SCM Request === Package Name: perl-Coro Short Description: The only real threads in perl Owners: ppisar mmaslano psabata kwizart Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
