[Bug 678714] Review Request: rhythmbox-radio-browser - Internet radio browser plugin for rhythmbox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678714 --- Comment #2 from Gianluca Sforna 2011-02-19 03:00:52 EST --- Forgot to mention, currently does not work with 0.13.3 (recently updated in F14). Works fine with previous version (0.13.1). Reported upstream: https://github.com/segler-alex/rhythmbox-radio-browser/issues#issue/21 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 486757] Review Request: divine-mc - Multi-core model checking system for proving specifications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486757 Milos Jakubicek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX Last Closed||2011-02-19 05:28:33 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: Ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666943
--- Comment #4 from Christoph Wickert 2011-02-19
05:27:15 EST ---
> - According to COPYING.extras, some of the icons are licensed under GPLv2
> only.
> Thus, the License tag should be "GPLv3+ and GPLv2".
fixed
> - The macro file texinfo.tex shouldn't be packaged as it's of no use here.
removed
> - If you want to maintain ignuit for EPEL < 6 too, you must use scrollkeeper
> rather than rarian (and call scrollkeeper-update in %post/%postun).
I have started doing this, but it ended in a mess:
- RHEL < 6 doesn't know the gconf macros, so I'd need to use some "%if
0%{?fedora} || 0%{?rhel} >= 6 ... %else ... %endif" voodoo.
- EPEL 4 needs an additional "killall -HUP gconfd-2 > /dev/null || :"
- RHEL < 6 doesn't have %posttrans, I'd need to change the icon-cache
scriptets.
In the end the nested conditionals became longer than the current spec and I
have no intentions to maintain this in EPEL anyway, so I decided it's not worth
the effort.
I also switched from desktop-file-validate to desktop-file-install to remove
"Encoding" (obsolete) and "MimeType" (empty) from the desktop file.
SRPM: http://cwickert.fedorapeople.org/review/ignuit-0.0.16-2.fc16.src.rpm
SPEC: http://cwickert.fedorapeople.org/review/ignuit.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 165572] Review Request: perl-Devel-StackTrace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=165572 --- Comment #10 from Fedora Update System 2011-02-19 05:58:52 EST --- perl-Devel-StackTrace-1.22-1.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Devel-StackTrace-1.22-1.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674007] Review Request: openni-primesense - PrimeSensor/Kinect Modules for OpenNI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674007 --- Comment #4 from Tim Niemueller 2011-02-19 06:14:19 EST --- (In reply to comment #3) > openni-primesense.x86_64: E: setuid-binary /usr/bin/XnSensorServer root 04755L > openni-primesense.x86_64: E: non-standard-executable-perm > /usr/bin/XnSensorServer 04755L > > Why does the sensor server binary need a setuid bit? Device permissions > should > be handled by the udev rule, is there some other reason it needs to be there? That is, indeed, not required anymore. Fixed, it had to be that way before I used the udev rules and I had changed that locally already. > openni-primesense.x86_64: W: log-files-without-logrotate /var/log/primesense > > If there are going to be logs accumulating, you should have a rule to rotate > and delete them every so often. It looks like XnSensorServer is creating a > folder called XnSensorServer under /var/log/primesense, but I can't get it to > add any logfiles. I think they are overwritten, and to use them you need to configure them from your application within OpenNI. The XnSensorServer is started automatically once you request the corresponding device node. > A few other things: > > * The udev rules file mixes ATTRS and SYSFS. SYSFS generates a lot of warning > messages at bootup, you should switch to using ATTRS consistently. Fixed. It's the way it came from ROS. > * The package has a udev rule, so it needs a Requires: on udev Done. > * LibJPEG is bundled with openni-primesense, in Source/External. This should > be removed in setup. Done. Uncovered an explicit "include ". Really, how do companies survive that have programmers doing stuff like this, and producing code with a virtually infinite number of warnings. Well, it works nevertheless... > * The README file doesn't contain any useful end-user information, it's just > instructions for building and installing. You don't need to include it as > documentation. Removed. Spec file changed in place, new SRPM is at http://fedorapeople.org/~timn/robotics/openni-primesense-5.0.0.25-0.2.git894cea01.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=648023
Tim Niemueller changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Tim Niemueller 2011-02-19 06:31:10 EST
---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
(+) rpmlint is not silent, some messages can be ignored:
- Source URL: You can append the file name to the Github URL and then you
have a valid source URL. It will work to download the file this way. But
content and tarball name differ, cf. recent discussion on fedora-devel and
http://support.github.com/discussions/repos/4565-sha-in-download-filename-does-not-match-directory
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (ASL
2.0).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
# sha256sum ../../SOURCES/basho-erlang_js-erlang_js-0.5.0-0-g5350ed2.tar.gz
5dbe617c22a89e888aaa576df9adedd0bf3c78e6eecf07a88ee48e48aba609b9
../../SOURCES/basho-erlang_js-erlang_js-0.5.0-0-g5350ed2.tar.gz
Github Download is currently down and I cannot download the tarball myself.
Since I have reviewed packages by Peter before I trust him that the package
contains the pristine source file.
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
You use $RPM_BUILD_ROOT as a variable, but macros for everything else.
Consider changing this, but since this is what rpmdev-newspec creates by
default I consider this to be acceptable.
+ The package contains code, or permissible content.
+ No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Looks very good. Unit tests make me confident it works although I cannot try it
myself. The macro usage is a little spot, but nothing that stops this review
from succeeding. The README file does not contain any real information to use
the package, only that you shouldn't try on Windows and building instructions.
It can be omitted from %doc section.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: Ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 Martin Gieseking changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Martin Gieseking 2011-02-19 06:55:25 EST --- OK, thanks for the additional information. I didn't expect that adapting the spec to EPEL < 6 would become this complex. In this case I'd skipped it too. :) The package looks good now, and thus is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #23 from Fedora Update System 2011-02-19 06:57:52 EST --- emacs-color-theme-6.6.0-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/emacs-color-theme-6.6.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671884] Review Request: erlang-cluster_info - Cluster info/postmortem inspector for Erlang applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=671884
--- Comment #6 from Tim Niemueller 2011-02-19 07:14:23 EST
---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- rpmlint is not silent, some messages can be ignored:
- erlang-cluster_info.spec: W: invalid-url Source0:
https://download.github.com/hibari-cluster-info-d077716.tar.gz HTTP Error 404:
Not Found
- erlang-cluster_info.src: W: invalid-url Source0:
https://download.github.com/hibari-cluster-info-d077716.tar.gz HTTP Error 404:
Not Found
Please verify and correct the download URLs, but this maybe related to the
Github problems I was seeing in the other review earlier.
- erlang-cluster_info.x86_64: E: explicit-lib-dependency erlang-stdlib
That is fine.
- erlang-cluster_info.x86_64: E: no-binary
Well, there just is none.
- erlang-cluster_info.x86_64: W: only-non-binary-in-usr-lib
There actually is binary data in the beam files.
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (ASL
2.0).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
# sha256sum ../SOURCES/hibari-cluster-info-d077716.tar.gz
519358519387c8bd37928ead542940ff9af22e9135f85dee96dd19f6d7635ada
../SOURCES/hibari-cluster-info-d077716.tar.gz
The mentioned download URL seems to not exist, I could not find a hint on
hibari's github page either. The tag tarball download is disfunctional atm
(Github seems to have a problem).
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
You use $RPM_BUILD_ROOT as a variable, but macros for everything else.
Consider changing this, but since this is what rpmdev-newspec creates by
default I consider this to be acceptable.
+ The package contains code, or permissible content.
+ No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Looks good, but the source URL issue must be fixed before approving. You can
also just name the tarball and provide git instructions on how to create the
tarball, or wget the github URL as you did for erlang-js. Take the macro
consistency into consideration, but the current state is acceptable to me if
you want to keep it as it is.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 Peter Lemenkov changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Peter Lemenkov 2011-02-19 07:27:05 EST --- Thanks! New Package SCM Request === Package Name: erlang-js Short Description: A Friendly Erlang to Javascript Binding Owners: peter Branches: F-14 F-15 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: Ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 Christoph Wickert changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Christoph Wickert 2011-02-19 07:53:47 EST --- Thanks for the review! New Package SCM Request === Package Name: ignuit Short Description: Memorization aid based on the Leitner flashcard system Owners: cwickert fab Branches: f13 f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 Thom Carlin changed: What|Removed |Added CC||bugzilla.a...@gmail.com Flag||needinfo?(ti...@math.uh.edu ||) --- Comment #42 from Thom Carlin 2011-02-19 08:07:49 EST --- Jason, any word on licensing? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676188 --- Comment #6 from Martin Gieseking 2011-02-19 08:09:52 EST --- Brendan, the package looks good now. I just recommend to insert some blank lines to increase legibility (before %prep and between the %changelog entries), but that's only cosmetic. If you don't have a sponsor yet, I can sponsor you if you're willing to do some informal reviews of other packager's submissions. Since you've already commented on a couple of packages, you shouldn't have too many difficulties with it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623868] Review Request: abattis-cantarell-fonts - Contemporary humanist sans-serif font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623868 Mohamed El Morabity changed: What|Removed |Added CC||pikachu.2...@gmail.com --- Comment #27 from Mohamed El Morabity 2011-02-19 08:23:23 EST --- Is it possible to make this font available also for Fedora 13 and 14? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678680] Review Request: transifex-client - Command line tool for Transifex translation management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678680 --- Comment #2 from Domingo Becker 2011-02-19 08:37:56 EST --- Ok, I choose the pre-release. The only rpmlint warning is the lack of man page. Spec URL: http://beckerde.fedorapeople.org/transifex/transifex-client.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/transifex-client-0.4.2-0.2.226a185088efhg.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 --- Comment #3 from Mohamed El Morabity 2011-02-19 08:45:30 EST --- Thanks for your review. The obsolete code is generated by rpmdev-newspec. Anyway here is a cleaned version: Spec URL: http://melmorabity.fedorapeople.org/packages/jgoodies-common/jgoodies-common.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/jgoodies-common/jgoodies-common-1.1.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Tim Niemueller changed: What|Removed |Added Blocks||676159 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 Tim Niemueller changed: What|Removed |Added Depends on||678774 --- Comment #7 from Tim Niemueller 2011-02-19 09:33:50 EST --- License updated. Added patch to build against new system-wide libscs, please see review bug #678774 and consider taking this as well. Thanks! Spec changed in place, new SRPM is at http://fedorapeople.org/~timn/misc/crlibm-1.0-0.2.beta4.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] New: Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libscs - Software Carry-Save Multiple-Precision Library https://bugzilla.redhat.com/show_bug.cgi?id=678774 Summary: Review Request: libscs - Software Carry-Save Multiple-Precision Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: t...@niemueller.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~timn/misc/libscs.spec SRPM URL: http://fedorapeople.org/~timn/misc/libscs-1.4.1-1.fc14.src.rpm Description: The Software Carry-Save (SCS) Library is a fast and lightweight multiple-precision library. Website: http://www.ens-lyon.fr/LIP/Arenaire/Ware/SCSLib/ Koji:https://koji.fedoraproject.org/koji/taskinfo?taskID=2851117 rpmlint: libscs.src: W: spelling-error %description -l en_US denormals -> de normals, de-normals, normals libscs.x86_64: W: spelling-error %description -l en_US denormals -> de normals, de-normals, normals - False positives libscs.x86_64: W: no-manual-page-for-binary scs_test_accuracy libscs.x86_64: W: no-manual-page-for-binary scs_test_timing - No man pages available for the test programs 3 packages and 1 specfiles checked; 0 errors, 7 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675122] Review Request: php-pear-Auth-Yubico - Authentication class for verifying Yubico OTP tokens
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=675122
Remi Collet changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com
--- Comment #1 from Remi Collet 2011-02-19 09:37:19
EST ---
Quick notes.
You must use
BuildRequires:php-pear >= 1:1.4.9-1.2
Because this is the first "working" version which provides the needed macros
used in the spec. (see PHP Guidelines) A upper version is acceptable (when
required by upstream), not a lower.
The stuff in %build should go in %prep (%build will be empty)
%file should be more explicit (wildcard can introduce issues)
%{pear_xmldir}/%{name}.xml
%{pear_phpdir}/Auth
Everything else seems ok.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #1 from Tim Niemueller 2011-02-19 09:55:00 EST --- Just after posting I discovered a typo in the configure line, causing the library to be built without MPFR support and thus rendering scs_test_accuracy disfunctional. Spec changed in place, new SRPM is at http://fedorapeople.org/~timn/misc/libscs-1.4.1-2.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 --- Comment #3 from Tim Niemueller 2011-02-19 10:00:30 EST --- I have modified the postun script to print a reminder that the user should be deleted if no longer used. Updated spec in place, new SRPM is at http://fedorapeople.org/~timn/bitten/bitten-0.6b3-0.2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675388] Review Request: xmlada - full XML stack for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675388 --- Comment #12 from Björn Persson 2011-02-19 11:11:01 EST --- The URL given as Source0 gives me a 404. If you can't find a direct download URL, then put only the filename in SourceX and give download instructions in a comment. http://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677043] Review Request: deheader - tool to find unnecesary includes in C/C++ source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677043 --- Comment #3 from Patryk Obara 2011-02-19 12:03:26 EST --- 1) Removed 2) Fixed; cool, I didn't know, that doc files don't need to be installed under buildroot :) 3) Fixed 4) Right :) man file is conveniently generated in tarball already. Removed %install and BuildRequires Updated specfile and srpm: http://dl.dropbox.com/u/420606/fedora-packages/deheader.spec http://dl.dropbox.com/u/420606/fedora-packages/deheader-0.6-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 Jason Tibbitts changed: What|Removed |Added Blocks||182235(FE-Legal) Flag|needinfo?(ti...@math.uh.edu | |) | --- Comment #43 from Jason Tibbitts 2011-02-19 12:17:36 EST --- Any word on the licensing wouldn't come from me, sorry. I should have blocked FE-Legal, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678230] Review Request: kmldonkey - Cross-platform graphical user interface for Mldonkey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678230 --- Comment #6 from Jason Tibbitts 2011-02-19 13:42:39 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 --- Comment #5 from Jason Tibbitts 2011-02-19 13:41:01 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 219950] Review Request: perl-Pod-Spell - A formatter for spellchecking Pod
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=219950 --- Comment #7 from Jason Tibbitts 2011-02-19 13:40:41 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: Ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 --- Comment #7 from Jason Tibbitts 2011-02-19 13:42:21 EST --- The requested package name does not match the name in the ticket summary. Please fix whichever is wrong and re-raise the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 Alexander Kurtakov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Alexander Kurtakov 2011-02-19 13:44:36 EST --- Thanks, looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 219950] Review Request: perl-Pod-Spell - A formatter for spellchecking Pod
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=219950 --- Comment #8 from Fedora Update System 2011-02-19 14:00:48 EST --- perl-Pod-Spell-1.01-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Pod-Spell-1.01-2.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
Patryk Obara changed:
What|Removed |Added
CC||dreamer@gmail.com
--- Comment #4 from Patryk Obara 2011-02-19 14:13:15
EST ---
(This is not normal review, because I am novice packager, but a bit of of
feedback):
1) You're missing %doc in your files section, maybe fill it like this:
%files
%defattr(-,root,root,-)
%doc COPYING AUTHORS ChangeLog NEWS README THANKS
it will take named files from unpacked tarball and place it correctly in
%{_docdir}/%{name}-%{version}, where they belong :)
You completely have to do it at least for COPYING file.
2) I don't think you need
%attr(755,root,root) before %{_bindir}/*
make install should already take care of that
3) (aesthetics, it doesn't really matter ;))
- add/remove some spaces before values for fields: Name,Release and Requires -
to make all values start in same column
- remove unneeded multiple spaces after Requires fields
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 Mohamed El Morabity changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Mohamed El Morabity 2011-02-19 14:07:11 EST --- New Package SCM Request === Package Name: jgoodies-common Short Description: Common library shared by JGoodies libraries and applications Owners: melmorabity Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 --- Comment #6 from Jason Tibbitts 2011-02-19 15:19:15 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 Christoph Wickert changed: What|Removed |Added Summary|Review Request: Ignuit -|Review Request: ignuit - |Memorization aid based on |Memorization aid based on |the Leitner flashcard |the Leitner flashcard |system |system Flag||fedora-cvs? --- Comment #8 from Christoph Wickert 2011-02-19 15:21:33 EST --- Sorry about that, clearly my fault. But I really don't understand why you cannot look into the spec. Takes probably less time than writing that additional comment. New Package SCM Request === Package Name: ignuit Short Description: Memorization aid based on the Leitner flashcard system Owners: cwickert fab Branches: f13 f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 --- Comment #9 from Jason Tibbitts 2011-02-19 15:33:31 EST --- Because the script which processes these tickets does not have access to the spec file, and because I'm simply not going to guess as to which spelling you actually want. Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667207] Review Request: avoision - Arcade style game of evade and capture
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667207
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
Bug 667207 depends on bug 667205, which changed state.
Bug 667205 Summary: Review Request: radius-engine - A Lua based real-time 2D
graphics game engine
https://bugzilla.redhat.com/show_bug.cgi?id=667205
What|Old Value |New Value
Status|NEW |ASSIGNED
Status|ASSIGNED|MODIFIED
Status|MODIFIED|ON_QA
Resolution||ERRATA
Status|ON_QA |CLOSED
--- Comment #3 from Martin Gieseking 2011-02-19
15:47:03 EST ---
The package fails to build in mock because BR: zip is missing (required to
create %{_datadir}/avoision/avoision.zip).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676941
Patryk Obara changed:
What|Removed |Added
CC||dreamer@gmail.com
--- Comment #1 from Patryk Obara 2011-02-19 15:47:39
EST ---
(This is not normal review, because I am novice packager, but a bit of of
feedback):
1) host files somewhere other than 4shared.com - it's impossible to download
them using wget :(
Public dropbox dir or hosting files on http://fedorapeople.org would work
better :)
2) Source0 url: better use:
http://eiskaltdc.googlecode.com/files/eiskaltdcpp-%{version}.tar.bz2
3) unfortunately, %build step failed for me:
CMake Error at /usr/share/cmake/Modules/FindOpenSSL.cmake:93 (MESSAGE):
Could NOT find OpenSSL
Call Stack (most recent call first):
CMakeLists.txt:70 (find_package)
4) I don't think you need this:
%install
rm -rf %{buildroot}
buildroot is always cleaned before %install step
5) Why does %dir do? I can't find it in guidelines/documentation anywhere - I
don't think it's necessary.
6) change %doc to
%doc COPYING LICENSE
You could also add ChangeLog files in doc
7) update date in %changelog, it says February 2010 ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678809] New: Review Request: seeks - A web-search proxy that provides a meta-search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: seeks - A web-search proxy that provides a meta-search engine https://bugzilla.redhat.com/show_bug.cgi?id=678809 Summary: Review Request: seeks - A web-search proxy that provides a meta-search engine Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: sebastien.willm...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: ftp://ks28905.kimsufi.com/pub/rpms/seeks-0.3.2-2/seeks.spec SRPM URL: ftp://ks28905.kimsufi.com/pub/rpms/seeks-0.3.2-2/seeks-0.3.2-2.fc14.src.rpm Description: Seeks is a free and open P2P design and application for enabling social web search. Its specific purpose is to regroup users whose queries are similarso they can share both the query results and their experience on these results.On this basis, Seeks allows for true real-time, decentralized, web search to emerge. http://www.seeks-project.info/site/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678809] Review Request: seeks - A web-search proxy that provides a meta-search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678809 --- Comment #1 from Sébastien Willmann 2011-02-19 15:56:12 EST --- This is my first package, so I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678809] Review Request: seeks - A web-search proxy that provides a meta-search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678809 Sébastien Willmann changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678128] Review Request: cdw - Front-end for tools used for burning data CD/DVD
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678128
--- Comment #5 from Sergio Belkin 2011-02-19 15:59:16 EST ---
(In reply to comment #4)
> (This is not normal review, because I am novice packager, but a bit of of
> feedback):
Thanks Patryk for your time.
>
> 1) You're missing %doc in your files section, maybe fill it like this:
>
> %files
> %defattr(-,root,root,-)
> %doc COPYING AUTHORS ChangeLog NEWS README THANKS
Done!
Updated files:
Spec URL: http://dl.dropbox.com/u/14217893/cdw.spec
SRPM URL: http://dl.dropbox.com/u/14217893/cdw-0.6.0-4.fc16.src.rpm
>
> it will take named files from unpacked tarball and place it correctly in
> %{_docdir}/%{name}-%{version}, where they belong :)
> You completely have to do it at least for COPYING file.
>
> 2) I don't think you need
> %attr(755,root,root) before %{_bindir}/*
>
> make install should already take care of that
Yes it should, I don't think that it was harmful, however, I've removed :)
>
> 3) (aesthetics, it doesn't really matter ;))
> - add/remove some spaces before values for fields: Name,Release and Requires -
> to make all values start in same column
> - remove unneeded multiple spaces after Requires fields
I've fixed that too, now spec file looks great, doesn't it?
Thanks again you say that you're novice, but the suggestions were quite
usefuel. I look forward for your review and sponsorship, if you need that I fix
anything else, let me know. Cheers
rpmlint output:
[sergio@peque tmp]$ for i in cdw-0.6.0-4*rpm ~/rpmbuild/SPECS/UpTools.spec;
do echo "rpmlint -i -v $i:" && rpmlint -i -v $i;done
rpmlint -i -v cdw-0.6.0-4.fc16.i686.rpm:
cdw.i686: I: checking
cdw.i686: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v cdw-0.6.0-4.fc16.src.rpm:
cdw.src: I: checking
cdw.src: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds)
cdw.src: I: checking-url http://downloads.sourceforge.net/cdw/cdw-0.6.0.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v cdw-0.6.0-4.fc16.x86_64.rpm:
cdw.x86_64: I: checking
cdw.x86_64: I: checking-url http://cdw.sourceforge.net/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -i -v /home/sergio/rpmbuild/SPECS/UpTools.spec:
/home/sergio/rpmbuild/SPECS/UpTools.spec: I: checking-url
http://www.palermo.edu/ingenieria/UpTools-8.5.4.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpm -qlp output:
rpm -qlp cdw-0.6.0-4.fc16.i686.rpm:
/usr/bin/cdw
/usr/share/doc/cdw-0.6.0
/usr/share/doc/cdw-0.6.0/AUTHORS
/usr/share/doc/cdw-0.6.0/COPYING
/usr/share/doc/cdw-0.6.0/ChangeLog
/usr/share/doc/cdw-0.6.0/NEWS
/usr/share/doc/cdw-0.6.0/README
/usr/share/doc/cdw-0.6.0/THANKS
/usr/share/man/man1/cdw.1.gz
rpm -qlp cdw-0.6.0-4.fc16.src.rpm:
cdw-0.6.0.tar.gz
cdw.spec
rpm -qlp cdw-0.6.0-4.fc16.x86_64.rpm:
/usr/bin/cdw
/usr/share/doc/cdw-0.6.0
/usr/share/doc/cdw-0.6.0/AUTHORS
/usr/share/doc/cdw-0.6.0/COPYING
/usr/share/doc/cdw-0.6.0/ChangeLog
/usr/share/doc/cdw-0.6.0/NEWS
/usr/share/doc/cdw-0.6.0/README
/usr/share/doc/cdw-0.6.0/THANKS
/usr/share/man/man1/cdw.1.gz
Thanks again
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 --- Comment #8 from Fedora Update System 2011-02-19 16:08:13 EST --- erlang-js-0.5.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/erlang-js-0.5.0-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 --- Comment #6 from Fedora Update System 2011-02-19 16:07:58 EST --- erlang-js-0.5.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-js-0.5.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 --- Comment #7 from Fedora Update System 2011-02-19 16:08:06 EST --- erlang-js-0.5.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/erlang-js-0.5.0-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675388] Review Request: xmlada - full XML stack for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675388 --- Comment #13 from Pavel Zhukov 2011-02-19 16:53:44 EST --- Fix python deps Fix Source tag New build: http://landgraf.fedorapeople.org/packages/requested/xmlada/xmlada.spec http://landgraf.fedorapeople.org/packages/requested/xmlada/xmlada-3.2.1-6.fc14.src.rpm Koji *OK http://koji.fedoraproject.org/koji/taskinfo?taskID=2851675 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 513320] Review Request: boxbackup - A fast, secure and automatic online backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513320 --- Comment #24 from Stewart Adam 2011-02-19 17:30:00 EST --- SPEC: http://firewing.fedorapeople.org/pub/SPECS/boxbackup.spec SRPM: http://firewing.fedorapeople.org/pub/SRPMS/boxbackup-0.11-0.4.rc8.fc14.src.rpm I have changed the License tag to "Box Backup GPL", which is the name upstream gave for the GPLv2-like license with the linking exceptions for OpenSSL and MS VSS. This makes rpmlint output a new warning: boxbackup.src: W: invalid-license Box Backup GPL Although I believe we can ignore this as spot gave the OK. Perhaps we ask him to look it over quickly again just to be sure? As for the ownership of /etc/boxbackup, the troublesome part is that both the client and the server packages store their files in sub-directories of /etc/boxbackup so I've made both packages own it. rpmlint also complains about this: boxbackup.x86_64: W: non-standard-uid /etc/boxbackup boxbackup boxbackup.x86_64: E: non-standard-dir-perm /etc/boxbackup 0700L I've done used nonstandard permissions (boxbackup:root 0700) to prevent outside users from taking peeks at the backup configuration (for either the client or server) or from gaining access to the certificates/encryption keys. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678809] Review Request: seeks - A web-search proxy that provides a meta-search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678809 --- Comment #2 from Sébastien Willmann 2011-02-19 17:29:21 EST --- Note: the author of the docbook patch is Mohamed El Morabity. He helped me a lot for my first package (not only with this patch). Thanks to him :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676941 --- Comment #2 from Patryk Obara 2011-02-19 17:51:38 EST --- Actually, I was wrong about point (4). By looking at different reviews I see that is required after all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678554] Review Request: iceplayer - a simple media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678554 --- Comment #13 from Mario Blättermann 2011-02-19 18:08:53 EST --- The changelog is not for changes to the packaged application itself. It is for your changes to the package, actually. We expect entries such as the following: - Added BuildRequires - Removed empty files from %%doc That's what we really need here. And every time you change the spec file, please add an appropriate changelog entry and increase the version number. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 --- Comment #8 from Tim Niemueller 2011-02-19 18:11:30 EST --- Another update, delete scs_lib in prep stage, modify patch to make sure system header files are used. Adapt for the unavailability of the scs_private.h header file. Spec changed in place, new SRPM is at http://fedorapeople.org/~timn/misc/crlibm-1.0-0.3.beta4.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676941 Jussi Lehtola changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #3 from Jussi Lehtola 2011-02-19 18:16:36 EST --- (In reply to comment #2) > Actually, I was wrong about point (4). By looking at different reviews I see > that is required after all. It is not required, the reviews you have looked at have been performed incorrectly, were done a long time ago or were targeting EPEL. http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 --- Comment #10 from Fedora Update System 2011-02-19 18:21:34 EST --- ignuit-0.0.16-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ignuit-0.0.16-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 --- Comment #12 from Fedora Update System 2011-02-19 18:22:11 EST --- ignuit-0.0.16-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ignuit-0.0.16-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 --- Comment #11 from Fedora Update System 2011-02-19 18:21:50 EST --- ignuit-0.0.16-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ignuit-0.0.16-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676941] Review Request: eiskaltdcpp-gtk - GTK+ frontend to DC++ client library eiskaltdcpp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676941
--- Comment #4 from Patryk Obara 2011-02-19 18:30:32
EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Actually, I was wrong about point (4). By looking at different reviews I see
> > that is required after all.
>
> It is not required, the reviews you have looked at have been performed
> incorrectly, were done a long time ago or were targeting EPEL.
I was misguided by last comment in this, quite recent, review:
https://bugzilla.redhat.com/show_bug.cgi?id=673919
(there is no mention in there, that it targets EPEL)
> At the beginning of %install, each package MUST run rm -rf %{buildroot} - OK
Thanks for clarification, Jussi :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677043] Review Request: deheader - tool to find unnecesary includes in C/C++ source files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=677043
--- Comment #4 from Patryk Obara 2011-02-19 18:43:40
EST ---
$ rpmlint deheader-0.6-1.fc13.noarch.rpm
deheader.noarch: W: spelling-error %description -l en_US cohesions -> cohesion,
cohesion's, cohesion s
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
I think word is properly used in context ("many cohesions").
$ rpm -qlp deheader-0.6-1.fc13.noarch.rpm
/usr/bin/deheader
/usr/share/doc/deheader-0.6
/usr/share/doc/deheader-0.6/COPYING
/usr/share/doc/deheader-0.6/NEWS
/usr/share/doc/deheader-0.6/README
/usr/share/man/man1/deheader.1.gz
I don't see area for improvement in this small specfile any more ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 --- Comment #7 from Fedora Update System 2011-02-19 19:38:09 EST --- jgoodies-common-1.1.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/jgoodies-common-1.1.1-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676146 --- Comment #3 from Jon Stanley 2011-02-19 19:46:01 EST --- Sorry, thought that I had replied here awhile back. I've taken care of everything in the review I think, spec location is the same. New SRPM: http://jstanley.fedorapeople.org/trace-gui-1.0.4-2.fc13.src.rpm The requirement for trace-cmd is now versioned, and the version requirement on 1.0.4 is in order to keep in sync with RHEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676146] Review request: trace-gui - GUI tools from trace-cmd
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676146
Christoph Wickert changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Christoph Wickert 2011-02-19
20:22:32 EST ---
OK, makes sense. The new package looks good:
OK - $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/trace-gui-*
trace-gui.src: W: spelling-error Summary(en_US) cmd -> cm, cd, cad
trace-gui.src: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.src: W: spelling-error %description -l en_US cmd -> cm, cd, cad
trace-gui.src: W: spelling-error %description -l en_US debugfs -> debugs,
debuggers, debugged
trace-gui.x86_64: W: spelling-error Summary(en_US) cmd -> cm, cd, cad
trace-gui.x86_64: W: summary-not-capitalized C trace-cmd is a user interface to
Ftrace
trace-gui.x86_64: W: spelling-error %description -l en_US cmd -> cm, cd, cad
trace-gui.x86_64: W: spelling-error %description -l en_US debugfs -> debugs,
debuggers, debugged
trace-gui.x86_64: W: no-manual-page-for-binary trace-graph
trace-gui.x86_64: W: no-manual-page-for-binary kernelshark
trace-gui.x86_64: W: no-manual-page-for-binary trace-view
3 packages and 0 specfiles checked; 0 errors, 11 warnings.
OK - MUST: package meets the Packaging Guidelines
OK - MUST: The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly validated with
desktop-file-validate in the %install section
OK - not latest stable version, but should be in sync with 1.0.4 from RHEL
OK - SourceURL valid
OK - Compiler not flags ok
Two minor things:
- When using "install", add -p to preserve timestamps, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
- Please add an icon to the desktop file. As the package doesn't have an icon
of it's own, I suggest something generic like "application-x-executable",
"applications-development" or "applications-engineering". These are provided by
all icon themes.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675976 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System 2011-02-19 23:12:47 EST --- jgoodies-common-1.1.1-2.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jgoodies-common'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/jgoodies-common-1.1.1-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2011-02-19 23:12:41 EST --- erlang-js-0.5.0-2.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-js'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-js-0.5.0-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666943] Review Request: ignuit - Memorization aid based on the Leitner flashcard system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666943 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System 2011-02-19 23:12:35 EST --- ignuit-0.0.16-2.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ignuit'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ignuit-0.0.16-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675388] Review Request: xmlada - full XML stack for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675388 --- Comment #14 from Dmitrij S. Kryzhevich 2011-02-20 00:56:36 EST --- No changes. +1 to comment #12. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Dmitrij S. Kryzhevich changed: What|Removed |Added Status|NEW |ASSIGNED CC||kr...@land.ru AssignedTo|nob...@fedoraproject.org|kr...@land.ru --- Comment #2 from Dmitrij S. Kryzhevich 2011-02-20 02:01:20 EST --- Why do you move "#include " in scslib-1.4.1/tests/test_accuracy.c? Suggestion: make "%doc DocsDev/html" to get html subfolder in -devel. Are the test programs required? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #3 from Dmitrij S. Kryzhevich 2011-02-20 02:55:24 EST --- One more. libscs-devel must Require mpfr-devel and gmp-devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
