[Bug 652629] Review Request: erlang-riak_kv - Riak Key/Value Store
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652629 Bug 652629 depends on bug 648023, which changed state. Bug 648023 Summary: Review Request: erlang-js - A Friendly Erlang to Javascript Binding https://bugzilla.redhat.com/show_bug.cgi?id=648023 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||RAWHIDE Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648023] Review Request: erlang-js - A Friendly Erlang to Javascript Binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648023 Peter Lemenkov changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||RAWHIDE Last Closed||2011-02-20 03:26:33 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675388] Review Request: xmlada - full XML stack for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675388 --- Comment #15 from Pavel Zhukov 2011-02-20 04:32:01 EST --- I'm sorry. Correct links. http://landgraf.fedorapeople.org/packages/requested/xmlada/xmlada.spec http://landgraf.fedorapeople.org/packages/requested/xmlada/xmlada-3.2.1-7.fc14.src.rpm -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 --- Comment #9 from Dmitrij S. Kryzhevich 2011-02-20 04:47:20 EST --- Hm. Looks like crlibm use scslib not fully correctly with private header. Ok. 1) Makefile.am contain string "SUBDIRS = $(MAYBE_SCS) . tests" which broke building (tried to add scs subdir). Changing it to "SUBDIRS = . tests". But: 2) Tests are compiled, but not used both during prepearation and in final rpm. Removal their compilation leads to at least removal tbx_timing.h header from patch. What is good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 --- Comment #4 from Tim Niemueller 2011-02-20 05:46:22 EST --- (In reply to comment #2) > Why do you move "#include " in scslib-1.4.1/tests/test_accuracy.c? Because it is required to get a macro defined in gmp.h, which consequently makes mpfr_out_str available. > Suggestion: make "%doc DocsDev/html" to get html subfolder in -devel. Since the HTML documentation is the only thing packaged as %doc it only adds on more meaningless level of hierarchy. > Are the test programs required? They provide valuable run-time data specific to the host system the application is running on, therefore they should be shipped with the library afaik. > One more. libscs-devel must Require mpfr-devel and gmp-devel. Added. Spec changed in place, new SRPM is at http://fedorapeople.org/~timn/misc/libscs-1.4.1-3.fc14.src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 --- Comment #10 from Tim Niemueller 2011-02-20 05:45:29 EST --- (In reply to comment #9) > Hm. Looks like crlibm use scslib not fully correctly with private header. Ok. Yeah, one author, similar macros, included lib, that's simply a consequence. > 1) Makefile.am contain string "SUBDIRS = $(MAYBE_SCS) . tests" which broke > building (tried to add scs subdir). Changing it to "SUBDIRS = . tests". But: Looks as if you built without the libscs-devel installed. Did you use the latest one posted, this contains the BR. If libscs-devel is installed MAYBE_SCS is empty. I have added this do have a chance to get this included uptsream, i.e. you can build with and without system-wide syslib. But the non-sys-wide is not fully working yet, but this is irrelevant for the package, where we only need the case w/sys-wide. > 2) Tests are compiled, but not used both during prepearation and in final rpm. > Removal their compilation leads to at least removal tbx_timing.h header from > patch. What is good. Good point, eliminating tests altogether would be a good thing. I would like to make that a configure flag later on, again, to get this included upstream. But for now the current state should be fine once we find what your compilation error in 1) was. This shouldn't be a blocker on the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674730] Review Request: qt-gstreamer - C++ bindings for GStreamer with a Qt-style API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674730
Mohamed El Morabity changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Mohamed El Morabity 2011-02-20
06:13:43 EST ---
Sorry for being long... The package looks quite good, here is its review:
MUST: rpmlint must be run on every package.
->OK, no warning
MUST: The package must be named according to the Package Naming Guidelines.
->OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
->OK
MUST: The package must meet the Packaging Guidelines.
->OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
->OK
MUST: The License field in the package spec file must match the actual license.
->OK
MUST: If (and only if) the source package includes the text of the license(s)
in
its own file, then that file, containing the text of the license(s) for
the package must be included in %doc.
->OK
MUST: The spec file must be written in American English.
->OK
MUST: The spec file for the package MUST be legible.
->OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
->OK, md5sum = d2507a8084973fa9956d792c20013977
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
->OK, see Koji links above
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
->N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional.
->OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
->N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files
(not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
->OK
MUST: Packages must NOT bundle copies of system libraries.
->OK
MUST: If the package is designed to be relocatable, the packager must state
this
fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
->N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does
create that directory.
>OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
->OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
->OK
MUST: Each package must consistently use macros.
->OK
MUST: The package must contain code, or permissable content.
->OK
MUST: Large documentation files must go in a -doc subpackage.
->N/A
MUST: If a package includes something as %doc, it must not affect the runtime
of
the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
->OK
MUST: Header files must be in a -devel package.
->OK
MUST: Static libraries must be in a -static package.
->N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
->OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
->OK
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
->OK
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
->N/A
MUST: Packages must not own files or directories already owned by other
packages.
->OK
MUST: All filenames in rpm packages must be valid UTF-8.
->OK
This package is APPROVED.
Just a (small) note: maybe you could add the examples/ folder in the sources as
%doc, it may be useful for qt-gstreamer beginners. It's not mandatory of
course, just a suggestion.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bu
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678774
Dmitrij S. Kryzhevich changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #5 from Dmitrij S. Kryzhevich 2011-02-20 06:23:34
EST ---
(In reply to comment #4)
> Because it is required to get a macro defined in gmp.h, which consequently
> makes mpfr_out_str available.
Hm. The order of #include influences on the result. Greate.
> Since the HTML documentation is the only thing packaged as %doc it only adds
> on
> more meaningless level of hierarchy.
Ok.
> They provide valuable run-time data specific to the host system the
> application
> is running on, therefore they should be shipped with the library afaik.
Ok.
Review ===
+ rpmlint was run on the source rpm and all binary rpms the build produces.
+ The package was named according to the Package Naming Guidelines.
+ The spec file name matchs the base package %{name}.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license LGPLv2+.
+ The License field in the package spec file must match the actual license.
+ File, containing the text of the license(s) for the package is included in
%doc.
+ The spec file must is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matchs the upstream source.
+ The package is successfully compiled and build into binary rpms on at least
one primary architecture.
+ All build dependencies must are listed in BuildRequires.
+ Binary RPM package calls ldconfig in %post and %postun.
+ Packages do NOT bundle copies of system libraries.
+ A package owns all directories that it creates.
+ A package do not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ Package consistently uses macros.
+ The package contains code, or permissable content.
* No localization.
* No large documentaion.
+ Everything included as %doc do not affect the runtime of the application.
+ Header files are in a -devel package.
* No static libraries.
+ Library files that end in .so (without suffix) are in a -devel package.
+ Devel packages requires the base package in proper way.
+ Packages do NOT contain any .la libtool archives.
* Not a GUI application.
+ Packages do not own files or directories already owned by other packages.
+ All filenames in rpm packages must be valid UTF-8.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676159
Dmitrij S. Kryzhevich changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #11 from Dmitrij S. Kryzhevich 2011-02-20 06:36:56
EST ---
(In reply to comment #10)
> Looks as if you built without the libscs-devel installed. Did you use the
> latest one posted, this contains the BR.
I built with system libscs. And on the next try it works. Think, I done
something wrong previuos time. Ok now. No blockers any more.
Review ===
+ rpmlint was run on the source rpm and all binary rpms the build produces.
+ The package was named according to the Package Naming Guidelines.
+ The spec file name matchs the base package %{name}.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license LGPLv2+.
+ The License field in the package spec file must match the actual license.
+ File, containing the text of the license(s) for the package is included in
%doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matchs the upstream source.
+ The package is successfully compiled and build into binary rpms on at least
one primary architecture.
+ All build dependencies are listed in BuildRequires.
+ Binary RPM package calls ldconfig in %post and %postun.
+ Packages do not bundle copies of system libraries.
+ A package owns all directories that it creates.
+ A package do not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ Package consistently uses macros.
+ The package contains code, or permissable content.
* No localization.
* No large documentaion.
+ Everything included as %doc do not affect the runtime of the application.
+ Header files are in a -devel package.
* No static libraries.
+ Library files that end in .so (without suffix) are in a -devel package.
+ Devel package requires the base package in proper way.
+ Packages do NOT contain any .la libtool archives.
* Not a GUI application.
+ Packages do not own files or directories already owned by other packages.
+ All filenames in rpm packages must be valid UTF-8.
All good. I think, I could set review to "+" before getting "git done" for
libscs.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671884] Review Request: erlang-cluster_info - Cluster info/postmortem inspector for Erlang applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671884 --- Comment #7 from Peter Lemenkov 2011-02-20 07:19:22 EST --- (In reply to comment #6) > Looks good, but the source URL issue must be fixed before approving. You can > also just name the tarball and provide git instructions on how to create the > tarball, or wget the github URL as you did for erlang-js. Done (added notes on how to get the tarball): http://peter.fedorapeople.org/erlang-cluster_info.spec http://peter.fedorapeople.org/erlang-cluster_info-0.1.0-0.3.20101229gitd077716.fc15.src.rpm Seems that GitHub's hosting service became quite unstable recently. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Peter Lemenkov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Peter Lemenkov 2011-02-20 07:31:05 EST --- OK, looks good now. I can't find any other issues, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678855] New: Review Request: rpyc - A Transparent, Symmetrical Python Library for Distributed-Computing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rpyc - A Transparent, Symmetrical Python Library for Distributed-Computing https://bugzilla.redhat.com/show_bug.cgi?id=678855 Summary: Review Request: rpyc - A Transparent, Symmetrical Python Library for Distributed-Computing Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://dl.dropbox.com/u/3488676/python-rpyc.spec SRPM URL: http://dl.dropbox.com/u/3488676/python-rpyc-3.0.7-1.src.rpm Description: RPyC, or Remote Python Call, is a transparent and symmetrical python library for remote procedure calls, clustering and distributed-computing. RPyC makes use of object-proxying, a technique that employs python's dynamic nature, to overcome the physical boundaries between processes and computers, so that remote objects can be manipulated as if they were local. This is my first package, and I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634911] Review Request: nodejs - Evented I/O for v8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634911 --- Comment #19 from Lubomir Rintel 2011-02-20 07:36:10 EST --- * Addressed the module directory issue (in accordance with FHS) * Correctly installing the include files * Added comments to patches SPEC: http://v3.sk/~lkundrak/SPECS/nodejs.spec SRPM: http://v3.sk/~lkundrak/SRPMS/nodejs-0.4.1-1.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671884] Review Request: erlang-cluster_info - Cluster info/postmortem inspector for Erlang applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671884 Tim Niemueller changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Tim Niemueller 2011-02-20 08:52:38 EST --- Looks good now. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674009] Review Request: bitten - A continuous integration plugin for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674009 Tim Niemueller changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Tim Niemueller 2011-02-20 08:57:36 EST --- Thanks for the thorough review. New Package SCM Request === Package Name: bitten Short Description: A continuous integration plugin for Trac Owners: timn Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 Tim Niemueller changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Tim Niemueller 2011-02-20 08:57:30 EST --- Thanks for the thorough review. New Package SCM Request === Package Name: crlibm Short Description: Correctly Rounded mathematical library Owners: timn Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678774] Review Request: libscs - Software Carry-Save Multiple-Precision Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678774 Tim Niemueller changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Tim Niemueller 2011-02-20 08:57:23 EST --- Thanks for the thorough review. New Package SCM Request === Package Name: libscs Short Description: Software Carry-Save Multiple-Precision Library Owners: timn Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674730] Review Request: qt-gstreamer - C++ bindings for GStreamer with a Qt-style API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674730 nucleo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from nucleo 2011-02-20 09:30:16 EST --- (In reply to comment #2) > Just a (small) note: maybe you could add the examples/ folder in the sources > as > %doc, it may be useful for qt-gstreamer beginners. It's not mandatory of > course, just a suggestion. All examples available in "API Documentation" on QtGStreamer site. > This package is APPROVED. Thank you for review. New Package SCM Request === Package Name: qt-gstreamer Short Description: C++ bindings for GStreamer with a Qt-style API Owners: nucleo Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677089] Review Request: php-pear-XML-RPC2 - XML-RPC client/server library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677089 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678889] New: Review Request: serdisplib - Library to drive serial displays with built-in controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: serdisplib - Library to drive serial displays with built-in controllers https://bugzilla.redhat.com/show_bug.cgi?id=678889 Summary: Review Request: serdisplib - Library to drive serial displays with built-in controllers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: hdego...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.fedoraproject.org/~jwrdegoede/serdisplib.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/serdisplib-1.97.9-1.fc15.src.rpm Description: serdisplib started as a library to drive serial displays with built-in controllers. beginning with version 1.95 support was added for parallel driven displays. anyhow: the name 'serdisplib' will not change. The serial in "serial display" characterizes the way of how the data is transferred to the display controller: data is sent bit by bit using a single input line. several (few) other lines are controlling things like timing (clock), data or command, ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 667208] Review Request: fbg2 - A falling block stacking game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667208 Martin Gieseking changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #2 from Martin Gieseking 2011-02-20 11:23:43 EST --- The package doesn't build in mock/koji because of a missing BR: zip: http://koji.fedoraproject.org/koji/taskinfo?taskID=2852534 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] New: Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames https://bugzilla.redhat.com/show_bug.cgi?id=678887 Summary: Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: hdego...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.fedoraproject.org/~jwrdegoede/libst2205.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/libst2205-1.4.3-1.fc15.src.rpm Description: It is possible to flash digital photo frames with the st2205 chip-sets with a modified firmware, which allows one to display real time images on the display of the frame from a PC. This package contains a library for accessing the display from the PC, for st2205 frames with the hacked firmware. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678855] Review Request: rpyc - A Transparent, Symmetrical Python Library for Distributed-Computing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678855 Thomas Spura changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678891] New: Review Request: lcd4linux - Display system state on an external LCD display
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: lcd4linux - Display system state on an external LCD display https://bugzilla.redhat.com/show_bug.cgi?id=678891 Summary: Review Request: lcd4linux - Display system state on an external LCD display Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: hdego...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.fedoraproject.org/~jwrdegoede/lcd4linux.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/lcd4linux-0.11-0.1.svn1143.fc15.src.rpm Description: LCD4Linux is a small program that grabs information from the kernel and some subsystems and displays it on an external liquid crystal display. Note that this package requires libst2205, and serdisplib which are currently both under review as well: 678887 - Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames 678889 - Review Request: serdisplib - Library to drive serial displays with built-in controllers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677089] Review Request: php-pear-XML-RPC2 - XML-RPC client/server library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=677089
Haïkel Guémar changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Haïkel Guémar 2011-02-20 11:29:22
EST ---
php-pear-XML-RPC2 (PHP noarch package)
all relevant MUST and SHOULD points are listed here.
Must: rplint on src.rpm and binary rpms OK
$ rpmlint -iv php-pear-XML-RPC2-1.0.6-1.fc14.src.rpm
php-pear-XML-RPC2.src: I: checking
php-pear-XML-RPC2.src: I: checking-url http://pear.php.net/package/XML_RPC2
(timeout 10 seconds)
php-pear-XML-RPC2.src: I: checking-url
http://pear.php.net/get/XML_RPC2-1.0.6.tgz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint -iv php-pear-XML-RPC2-1.0.6-1.fc14.noarch.rpm
php-pear-XML-RPC2.noarch: I: checking
php-pear-XML-RPC2.noarch: I: checking-url http://pear.php.net/package/XML_RPC2
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST: package is named accordingly to general and PHP specific naming
guidelines. OK
MUST: spec file name matches %{name} OK
MUST: package meet general and PHP/PEAR packaging guidelines. OK
MUST: package is licensed under a fedora compliant license (LGPLv2+) OK
MUST: spec is written in legible american english. OK
MUST: provided and upstream sources checksums match. OK
provided sources: a7ac54a9d89257dd4f2a4f20c88d9f8ee5b77a03
upstream sources: a7ac54a9d89257dd4f2a4f20c88d9f8ee5b77a03
MUST: compilation tested on all supported platforms (x86 and x86_64) for F14
under mock. OK
Note: not difficult since this is a noarch package ;)
MUST: package doesn't bundle third party libraries. OK
MUST: package owns created directories (and only them). OK
MUST: files are not listed twice. OK
MUST: files permissions are properly set. OK
MUST: consistent use of macros. OK
MUST: only ships permissible content. OK
MUST: doc is properly handled. OK
MUST: filenames are valid UTF-8. OK
SHOULD: package functions as described. OK
Note: i was able to build a minimal XML-RPC client (thanks to XML_RPC2
documentation) and it worked as expected.
General and php/PEAR specific guidelines are respected, as for the files
excluded, an upstream ticket has been opened and it doesn't seem to prevent it
from working.
Hereby, i grant this package my approval to join Fedora packages collection.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 513320] Review Request: boxbackup - A fast, secure and automatic online backup system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513320 Jason Tibbitts changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #25 from Jason Tibbitts 2011-02-20 11:36:32 EST --- Well, we don't invent new license tags without going through legal. Generally we'd use "GPLv2 with exceptions" for that kind of thing but if you think it deserves a new tag, we'll block FE-Legal again and see what spot says. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676853] Review Request: goocanvasmm2 - goocanvasmm2 goodness for Gtk3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676853 Remi Collet changed: What|Removed |Added CC||fed...@famillecollet.com AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677089] Review Request: php-pear-XML-RPC2 - XML-RPC client/server library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677089 Remi Collet changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Remi Collet 2011-02-20 11:51:57 EST --- Thanks for the review New Package SCM Request === Package Name: php-pear-XML-RPC2 Short Description: XML-RPC client/server library Owners: remi Branches: f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678692] Review Request: drupal6-theme-ninesixty - 960 Grid System (960.gs) theme for Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678692 David Nalley changed: What|Removed |Added Status|NEW |ASSIGNED CC||da...@gnsa.us AssignedTo|nob...@fedoraproject.org|da...@gnsa.us Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676853] Review Request: goocanvasmm2 - goocanvasmm2 goodness for Gtk3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676853 --- Comment #1 from Haïkel Guémar 2011-02-20 12:43:31 EST --- mock build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2852654 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678692] Review Request: drupal6-theme-ninesixty - 960 Grid System (960.gs) theme for Drupal 6
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678692
David Nalley changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from David Nalley 2011-02-20 12:43:06 EST ---
Hi Paul:
OK: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
MUST: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
FIX: The License field in the package spec file must match the actual license.
[3]
In README.txt (and the css source files) there is acknowledgement that some
portions of the package are GPL (really GPL+) and MIT licensed.
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
<-- see the link for more details, but I think that means that license field
should read GPLv2 and GPL+ or MIT with a comment denoting the delineation.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK: The spec file must be written in American English. [5]
OK: The spec file for the package MUST be legible. [6]
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[ke4qqq@L1012001 SOURCES]$ md5sum ninesixty-6.x-1.0.tar.gz*
064b869256c0fa8b1826830ed433d7d8 ninesixty-6.x-1.0.tar.gz
064b869256c0fa8b1826830ed433d7d8 ninesixty-6.x-1.0.tar.gz.1
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
NA: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
NA: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
NA: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun. [10]
OK: Packages must NOT bundle copies of system libraries.[11]
NA: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker. [12]
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. [13]
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
OK: Each package must consistently use macros. [16]
OK: The package must contain code, or permissable content. [17]
NA: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. [18]
NA: Header files must be in a -devel package. [19]
NA: Static libraries must be in a -static package. [20]
NA: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [19]
NA: In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{rel
[Bug 678889] Review Request: serdisplib - Library to drive serial displays with built-in controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678889 --- Comment #1 from Tim Lauridsen 2011-02-20 13:01:17 EST --- I will review this bug -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678889] Review Request: serdisplib - Library to drive serial displays with built-in controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678889 Tim Lauridsen changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678891] Review Request: lcd4linux - Display system state on an external LCD display
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678891 Tim Lauridsen changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678889] Review Request: serdisplib - Library to drive serial displays with built-in controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678889 Tim Lauridsen changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Tim Lauridsen changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #1 from Tim Lauridsen 2011-02-20 13:00:33 EST --- I will review this bug -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678889] Review Request: serdisplib - Library to drive serial displays with built-in controllers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678889 Tim Lauridsen changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Tim Lauridsen changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678891] Review Request: lcd4linux - Display system state on an external LCD display
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678891 --- Comment #1 from Tim Lauridsen 2011-02-20 13:02:22 EST --- I will review this bug -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678891] Review Request: lcd4linux - Display system state on an external LCD display
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678891 Tim Lauridsen changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678891] Review Request: lcd4linux - Display system state on an external LCD display
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678891 Tim Lauridsen changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Tim Lauridsen changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] New: Review Request: activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: activitymanager - KDE plasma activity manager applet https://bugzilla.redhat.com/show_bug.cgi?id=678910 Summary: Review Request: activitymanager - KDE plasma activity manager applet Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: magnus.tuomi...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://magnu5.fedorapeople.org/review/activitymanager/SPECS/activitymanager.spec SRPM URL: http://magnu5.fedorapeople.org/review/activitymanager/SRPMS/activitymanager-0.5-1.fc14.src.rpm Description: Lightweight plasmoid to manage your activities effectively. Can start, stop, switch between, clone, edit and remove activities. rpmlint -iv activitymanager.spec activitymanager.spec: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -iv activitymanager-0.5-1.fc14.src.rpm activitymanager.src: I: checking activitymanager.src: W: spelling-error %description -l en_US plasmoid -> plasmid, plasmodium, plasmolytic The value of this tag appears to be misspelled. Please double-check. activitymanager.src: I: checking-url http://kde-apps.org/content/show.php?content=136278 (timeout 10 seconds) activitymanager.src: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677043] Review Request: deheader - tool to find unnecesary includes in C/C++ source files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677043 Patryk Obara changed: What|Removed |Added Alias||deheader -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678889] Review Request: serdisplib - Library to drive serial displays with built-in controllers
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678889
Tim Lauridsen changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Tim Lauridsen 2011-02-20 13:25:09 EST ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Buildroot is correct (EPEL5 & Fedora < 10)
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] : MUST - Package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
[x] : MUST - Each %files section contains %defattr
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install.
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
%makeinstall is justified, no DESTDIR support
[x] : MUST - Package is named according to the Package Naming Guidelines.
[!] : MUST - Rpmlint output is silent.
rpmlint serdisplib-1.97.9-1.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint serdisplib-1.97.9-1.fc15.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint serdisplib-debuginfo-1.97.9-1.fc15.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint serdisplib-devel-1.97.9-1.fc15.x86_64.rpm
serdisplib-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint serdisplib-tools-1.97.9-1.fc15.x86_64.rpm
serdisplib-tools.x86_64: W: summary-not-capitalized C serdisplib tools
(testserdisp, multidisplay)
serdisplib-tools.x86_64: W: no-documentation
serdisplib-tools.x86_64: W: no-manual-page-for-binary l4m132c_tool
serdisplib-tools.x86_64: W: no-manual-page-for-binary multidisplay
serdisplib-tools.x86_64: W: no-manual-page-for-binary testserdisp
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
MD5SUM this package : 130552ec60d01e974712a60274f34de7
MD5SUM upstream package : 130552ec60d01e974712a60274f34de7
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x] : MUST - Spec file is legible and written in American English.
[x] : MUST - Spec uses macros instead of hard-coded directory names.
[x] : MUST - Package consistently uses macros.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[-] : MUST - The spec file handles locales properly.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - License field in the package spec file matches the actual license.
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License file installed when any subpackage combination is
installed.
[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Compiler flags are appropriate.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - ldconfig called in %post and %postun if required.
[x] : MUST - Package must own all directories that it c
[Bug 551763] Review Request: lua-sec - Lua binding for OpenSSL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551763 Adam Goode changed: What|Removed |Added Flag|needinfo?(a...@spicenitz.or | |g) | --- Comment #9 from Adam Goode 2011-02-20 13:30:17 EST --- There have been no changes: IPv6 is still not supported, and luasec is still a fork of luasocket. I consider both of these blockers for this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: Pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676544
--- Comment #12 from Mamoru Tasaka 2011-02-20
13:53:08 EST ---
Some notes:
* Unwanted automated call of autotools
- build.log shows that autotools scripts are automatically called
after configure script is executed manually:
---
33 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.wH1fI6
46 + ./configure --build=i386-redhat-linux-gnu
--host=i386-redhat-linux-gnu --program-prefix= --disable-dependency-tracking
--prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin
--sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include
--libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var
--sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info
148 + make -j16
149 CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh
/builddir/build/BUILD/pidgin-logviewer-0.2/config/missing --run aclocal-1.11 -I
m4
218 /bin/sh ./config.status --recheck
369 rm -f stamp-h1
370 touch config.h.in
371 cd . && /bin/sh ./config.status config.h
372 config.status: creating config.h
373 config.status: config.h is unchanged
374 make all-recursive
---
This is not desirable because automated call of autotool methods
may produce unwanted (or broken) scripts and anyway it should not
be needed. Please fix this (usually timestamps on some files
are wrong).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: Pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676544 --- Comment #13 from Mamoru Tasaka 2011-02-20 13:55:10 EST --- Then: Praveen, do you have another review request submission or have tried to do pre-review of other person's review request (at least one)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: Pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676544 --- Comment #14 from Praveen Kumar 2011-02-20 14:04:21 EST --- (In reply to comment #13) > Then: > Praveen, do you have another review request submission or have tried > to do pre-review of other person's review request (at least one)? I have a another review request https://bugzilla.redhat.com/show_bug.cgi?id=627637 Thanks for reviewing.Soon I will fix those unwanted calls of autotools. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 Sergio Belkin changed: What|Removed |Added CC||seb...@gmail.com --- Comment #2 from Sergio Belkin 2011-02-20 14:06:07 EST --- Hi Hans I am (still) not member of packaging group, however I hope my review be useful: AFAIK these are non-fatal errors: 1. BuildRoot is not needed anymore. 2. The same goes for clean section. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag The following is a fatal error, sorry for my insolenece taking into account that I'm not still of packaging group... 3. I don't know if I miss something but I see that koji is failing trying to compile the package: main.c:25:16: fatal error: gd.h: No such file or directory The same applies for mock. You should add BuildRequieres: gd-devel Also, is failing to find st2205.h, fix the %build section accordingly. Greets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676544 Mamoru Tasaka changed: What|Removed |Added Summary|Review Request: |Review Request: |Pidgin-logviewer - User|pidgin-logviewer - User |friendly and intuitive way |friendly and intuitive way |of viewing chat logs in |of viewing chat logs in |Pidgin |Pidgin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678887] Review Request: libst2205 - Library for accessing the display of hacked st2205 photo frames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678887 --- Comment #3 from Hans de Goede 2011-02-20 14:22:59 EST --- Sergio, Thanks for the feedback, here is a fixed version: Spec URL: http://people.fedoraproject.org/~jwrdegoede/libst2205.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/libst2205-1.4.3-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678891] Review Request: lcd4linux - Display system state on an external LCD display
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678891 Sergio Belkin changed: What|Removed |Added CC||seb...@gmail.com --- Comment #2 from Sergio Belkin 2011-02-20 14:33:08 EST --- Hi Hans, I am (still) not member of packaging group, but I think that serdisplib-devel is missing from BuildRequires, ok, currently is still not on fedora repos, however that should be there (in BuildRequires), shouldn't it? Take a look http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires Have a nice day -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555018] Review Request: gnac - An audio converter for GNOME (first package, seeking sponsor)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555018 --- Comment #24 from Christoph Wickert 2011-02-20 16:12:55 EST --- Tylon, are you still with us? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627637] Review Request: qroneko - A front end of crontab application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627637 Mamoru Tasaka changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Status Whiteboard|StalledSubmitter| Flag||fedora-review? --- Comment #7 from Mamoru Tasaka 2011-02-20 16:29:18 EST --- Some notes: * Clean up of old miscs - Please clean up old miscs no longer needed on Fedora, like * BuildRoot tag * "rm -rf $RPM_BUILD_ROOT" at the top of %install * %clean * $RPM_BUILD_ROOT vs %buildroot / coding style - Please choose to use one style, not both. https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - Also, using both "install -d" and "mkdir" seems a bit confusing, I recommend to use one style. * Timestamp - When using "cp" or "install" commands, please add "-p" option to keep timestamp on installed files. https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Path - Would you explain why you want to install "qroneko" binary to %_sbindir, not under %_bindir? (it seems that qroneko can be lauched as normal user). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678924] New: Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm https://bugzilla.redhat.com/show_bug.cgi?id=678924 Summary: Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: emmanuel.sey...@club-internet.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS-1.004-1.fc14.src.rpm Description: This module implements the same interface as Math::Random::ISAAC in C and can be used as a drop-in replacement. This is the recommended implementation of the module, based on Bob Jenkins' reference implementation in C. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678925] Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678925 Emmanuel Seyman changed: What|Removed |Added Blocks||678924 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678924] Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678924 Emmanuel Seyman changed: What|Removed |Added Depends on||678925 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678925] New: Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm https://bugzilla.redhat.com/show_bug.cgi?id=678925 Summary: Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: emmanuel.sey...@club-internet.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC/perl-Math-Random-ISAAC.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC/perl-Math-Random-ISAAC-1.004-1.fc14.src.rpm Description: As with other Pseudo-Random Number Generator (PRNG) algorithms like the Mersenne Twister (see Math::Random::MT), this algorithm is designed to take some seed information and produce seemingly random results as output. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678929] New: Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources https://bugzilla.redhat.com/show_bug.cgi?id=678929 Summary: Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: emmanuel.sey...@club-internet.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.parinux.org/~seyman/fedora/perl-Crypt-Random-Source/perl-Crypt-Random-Source.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Crypt-Random-Source/perl-Crypt-Random-Source-0.07-1.fc14.src.rpm Description: This module provides implementations for a number of byte oriented sources of random data. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627637] Review Request: qroneko - A front end of crontab application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627637 --- Comment #8 from Mamoru Tasaka 2011-02-20 17:08:57 EST --- Additional notes: * Desktop file - "#!/usr/bin/env xdg-open" is not needed. - "Application" in Categories item is deprecated and should be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678931] New: Review Request: perl-Math-Random-Secure - Cryptographically-secure, cross-platform replacement for rand()
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Math-Random-Secure - Cryptographically-secure, cross-platform replacement for rand() https://bugzilla.redhat.com/show_bug.cgi?id=678931 Summary: Review Request: perl-Math-Random-Secure - Cryptographically-secure, cross-platform replacement for rand() Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: emmanuel.sey...@club-internet.fr QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-Secure/perl-Math-Random-Secure.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-Secure/perl-Math-Random-Secure-0.06-1.fc14.src.rpm Description: This module is intended to provide a cryptographically-secure replacement for Perl's built-in rand function. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678929] Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678929 Emmanuel Seyman changed: What|Removed |Added Blocks||678931 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678925] Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678925 Emmanuel Seyman changed: What|Removed |Added Blocks||678931 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678931] Review Request: perl-Math-Random-Secure - Cryptographically-secure, cross-platform replacement for rand()
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678931 Emmanuel Seyman changed: What|Removed |Added Depends on||678929, 678925 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] Review Request: activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=678910
nucleo changed:
What|Removed |Added
CC||alekc...@googlemail.com
--- Comment #1 from nucleo 2011-02-20 18:12:02 EST ---
kde-plasma- prefix used by convention for all plasma applets
So kde-plasma-activitymanager will be more more correct name.
No need to run desktop-file-validate for files in %{_datadir}/kde4/services/
%{buildroot} and $RPM_BUILD_ROOT should not be mixed in one spec.
Why you added explicit Requires: kdebase-workspace ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662604 --- Comment #11 from Christoph Wickert 2011-02-20 18:15:42 EST --- I'm incredibly sorry, this completely dropped of my radar. :( >From a packaging point of view, the package is fine now: OK - MUST: package meets the Packaging Guidelines OK - MUST: handles locales properly with %find_lang OK - MUST: owns all directories that it creates OK - MUST: package does not own files or directories already owned by other packages Some minor notes on the changelog: - mention version and release - mention your changes - use one blank line between al changelog entries A proper changelog would look like this: %changelog * Mon Dec 20 2010 Truong Anh Tuan - 0.5.1-2 - Fix file and directory ownership (#662604) - Use %%find_lang macro for locales * Mon Dec 13 2010 Truong Anh Tuan - 0.5.1-1 - Initial release 0.5.1 getting from upstream If you use a macro in a comment/changelog, you need to escape it with a second %. If you fix a but, add the number at the More about changelogs can be found at https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs I am really sorry I cannot approve this package because it still doesn't build in Fedora 15. Did you contact the developers and showed them the build.log? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 Christoph Wickert changed: What|Removed |Added Flag||needinfo?(d...@ribalba.de) --- Comment #7 from Christoph Wickert 2011-02-20 18:17:02 EST --- Didi, are you still there? Please respond to this review request, otherwise I think Ankur should take over. I'd like to see this package in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 671884] Review Request: erlang-cluster_info - Cluster info/postmortem inspector for Erlang applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671884 Peter Lemenkov changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Peter Lemenkov 2011-02-20 19:11:09 EST --- Thanks! New Package SCM Request === Package Name: erlang-cluster_info Short Description: Cluster info/postmortem inspector for Erlang applications Owners: peter Branches: f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662604 --- Comment #12 from Truong Anh Tuan 2011-02-20 19:58:17 EST --- (In reply to comment #11) > I am really sorry I cannot approve this package because it still doesn't build > in Fedora 15. Did you contact the developers and showed them the build.log? It's a compatibility issue. I am working with upstream developer to get it built fine on Fedora 15. I will also update all others. Rgds, Tuan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662604 Daiki Ueno changed: What|Removed |Added CC||du...@redhat.com --- Comment #13 from Daiki Ueno 2011-02-20 20:15:37 EST --- (In reply to comment #12) > It's a compatibility issue. I am working with upstream developer to get it > built fine on Fedora 15. FWIW, I created a patch for ibus-unikey to use the ibus-1.4 API, which is in Fedora 15: http://ueno.fedorapeople.org/ibus-unikey/ibus-unikey-ibus-1.4.patch You may also find SRPM and spec there: http://ueno.fedorapeople.org/ibus-unikey/ Since actually ibus-1.4 has not released in upstream yet, I maintain internal patches for ibus-hangul and ibus-m17n for Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678955] New: Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL https://bugzilla.redhat.com/show_bug.cgi?id=678955 Summary: Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: m...@blagblagblag.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://repos.fedorapeople.org/repos/jebba/reprap/opencsg.spec SRPM URL: http://repos.fedorapeople.org/repos/jebba/reprap/14/SRPMS/opencsg-1.3.1-0.fc14.src.rpm Description: OpenCSG is a library that does image-based CSG rendering using OpenGL. CSG is short for Constructive Solid Geometry and denotes an approach to model complex 3D-shapes using simpler ones. I.e., two shapes can be combined by taking the union of them, by intersecting them, or by subtracting one shape of the other. The most basic shapes, which are not result of such a CSG operation, are called primitives. Primitives must be solid, i.e., they must have a clearly defined interior and exterior. By construction, a CSG shape is also solid then. Image-based CSG rendering (also z-buffer CSG rendering) is a term that denotes algorithms for rendering CSG shapes without an explicit calculation of the geometric boundary of a CSG shape. Such algorithms use frame-buffer settings of the graphics hardware, e.g., the depth and stencil buffer, to compose CSG shapes. OpenCSG implements a variety of those algorithms, namely the Goldfeather algorithm and the SCS algorithm, both of them in several variants. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] Review Request: activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678910 --- Comment #2 from Magnus Tuominen 2011-02-21 00:14:51 EST --- Thanks for the comments, fixed build and spec: BR changed to kdeplasma-addons-devel and Requires removed. http://magnu5.fedorapeople.org/review/kde-plasma-activitymanager/SPECS/kde-plasma-activitymanager.spec http://magnu5.fedorapeople.org/review/kde-plasma-activitymanager/SRPMS/kde-plasma-activitymanager-0.5-2.fc14.src.rpm rpmlint -iv kde-plasma-activitymanager.spec kde-plasma-activitymanager.spec: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -iv kde-plasma-activitymanager-0.5-2.fc14.src.rpm kde-plasma-activitymanager.src: I: checking kde-plasma-activitymanager.src: W: spelling-error %description -l en_US plasmoid -> plasmid, plasmodium, plasmolytic The value of this tag appears to be misspelled. Please double-check. kde-plasma-activitymanager.src: I: checking-url http://kde-apps.org/content/show.php?content=136278 (timeout 10 seconds) kde-plasma-activitymanager.src: I: checking-url http://kde-apps.org/CONTENT/content-files/136278-activitymanager-0.5.tar.bz2 (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627637] Review Request: qroneko - A front end of crontab application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627637 --- Comment #9 from Praveen Kumar 2011-02-21 01:20:52 EST --- Fixed all the issue which Mr. Mamoru Tasaka pointed out, here is updated spec file and srpm SPEC URL: http://kumarpraveen.fedorapeople.org/qroneko/qroneko.spec SRPM URL: http://kumarpraveen.fedorapeople.org/qroneko/qroneko-0.5.4-4.fc14.src.rpm 1.rpmlint output: $ rpmlint qroneko.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. 2.md5sum output: $ md5sum ../SOURCES/qroneko-0.5.4.tar.gz ../../Downloads/qroneko-0.5.4.tar.gz 5e2e20d9ce40e076cbe79d64a21f6e6b ../SOURCES/qroneko-0.5.4.tar.gz 5e2e20d9ce40e076cbe79d64a21f6e6b ../../Downloads/qroneko-0.5.4.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637360] Review Request: ghc-parameterized-data - Parameterized data library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637360 --- Comment #9 from Fedora Update System 2011-02-21 02:25:29 EST --- ghc-parameterized-data-0.1.5-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637360] Review Request: ghc-parameterized-data - Parameterized data library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637360 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-parameterized-data-0.1. ||5-2.fc13 Resolution||ERRATA Last Closed||2011-02-21 02:25:36 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678980] New: openscad - Creates solid 3D CAD objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: openscad - Creates solid 3D CAD objects https://bugzilla.redhat.com/show_bug.cgi?id=678980 Summary: openscad - Creates solid 3D CAD objects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: m...@blagblagblag.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://repos.fedorapeople.org/repos/jebba/reprap/openscad.spec SRPM URL: http://repos.fedorapeople.org/repos/jebba/reprap/14/SRPMS/openscad-2011.02.20git-0.fc14.src.rpm Description: OpenSCAD is a software for creating solid 3D CAD objects. Unlike most free software for creating 3D models (such as the famous application Blender) it does not focus on the artistic aspects of 3D modelling but instead on the CAD aspects. OpenSCAD provides two main modelling techniques: First there is constructive solid geometry (aka CSG) and second there is extrusion of 2D outlines. As data exchange format format for this 2D outlines Autocad DXF files are used. Besides DXF files OpenSCAD can read and create 3D models in the STL and OFF file formats. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674006] Review Request: openni - Library for human-machine Natural Interaction
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674006 --- Comment #12 from Fedora Update System 2011-02-21 02:29:35 EST --- openni-1.0.0.25-0.3.git4c9ff978.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637360] Review Request: ghc-parameterized-data - Parameterized data library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637360 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-parameterized-data-0.1. |ghc-parameterized-data-0.1. |5-2.fc13|5-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637360] Review Request: ghc-parameterized-data - Parameterized data library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637360 --- Comment #10 from Fedora Update System 2011-02-21 02:30:00 EST --- ghc-parameterized-data-0.1.5-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674006] Review Request: openni - Library for human-machine Natural Interaction
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674006 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||openni-1.0.0.25-0.3.git4c9f ||f978.fc14 Resolution||ERRATA Last Closed||2011-02-21 02:29:41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678980] Review Request: openscad - Creates solid 3D CAD objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678980 jebba changed: What|Removed |Added Depends on||678955 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678955] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678955 jebba changed: What|Removed |Added Blocks||678980 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678980] Review Request: openscad - Creates solid 3D CAD objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678980 jebba changed: What|Removed |Added Summary|openscad - Creates solid 3D |Review Request: openscad - |CAD objects |Creates solid 3D CAD ||objects -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
