[Bug 680593] New: Review Request: perl-Browser-Open - Open a browser in a given URL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Browser-Open - Open a browser in a given URL Alias: perl-Browser-Open https://bugzilla.redhat.com/show_bug.cgi?id=680593 Summary: Review Request: perl-Browser-Open - Open a browser in a given URL Product: Fedora Version: rawhide Platform: Unspecified URL: http://search.cpan.org/dist/Browser-Open/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: iarn...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~iarnell/review/perl-Browser-Open.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Browser-Open-0.03-1.fc16.src.rpm Description: The functions optionally exported by this module allows you to open URLs in the user browser. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2868892 *rt-0.10_01 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675542] Review Request:perl-Hash-MoreUtils - Provide the stuff missing in Hash::Util
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675542 Iain Arnell changed: What|Removed |Added CC||iarn...@gmail.com --- Comment #1 from Iain Arnell 2011-02-26 01:40:25 EST --- As I mentioned in bug #675529, I really wouldn't bother with using Test-CheckManifest. It only adds additional build-time complexity without providing any meaningful test coverage. I would much rather see this packaged in the normal way and simply skip t/manifest.t. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518441] Review Request: ike - Shrew Soft VPN Client For Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518441 Andrew Colin Kissa changed: What|Removed |Added Flag|needinfo?(and...@topdog.za. | |net)| --- Comment #30 from Andrew Colin Kissa 2011-02-26 01:43:30 EST --- Rudi The libs are required by the binaries so putting them in a devel package is not really an option as the binaries will not work without the libs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675529] Review Request: perl-Test-CheckManifest - Check if your Manifest matches your distro
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675529 Iain Arnell changed: What|Removed |Added Status|NEW |ASSIGNED CC||iarn...@gmail.com AssignedTo|nob...@fedoraproject.org|iarn...@gmail.com Flag||fedora-review+ --- Comment #1 from Iain Arnell 2011-02-26 01:36:16 EST --- + source files match upstream. f9898f6aa5ef1cb7eddb3e9caba736b2 Test-CheckManifest-1.22.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. - description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. Artistic 2.0 (confirmed upstream at https://rt.cpan.org/Public/Bug/Display.html?id=65467) + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2868872 + package installs properly. + rpmlint has no meaningful complaints: perl-Test-CheckManifest.noarch: W: spelling-error Summary(en_US) distro -> distr, bistro, distr o perl-Test-CheckManifest.noarch: W: spelling-error %description -l en_US distro -> distr, bistro, distr o perl-Test-CheckManifest.src: W: spelling-error Summary(en_US) distro -> distr, bistro, distr o perl-Test-CheckManifest.src: W: spelling-error %description -l en_US distro -> distr, bistro, distr o 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + final provides and requires are sane: perl(Test::CheckManifest) = 1.22 perl-Test-CheckManifest = 1.22-1.fc16 = perl(Carp) perl(Cwd) perl(File::Basename) perl(File::Find) perl(File::Spec) perl(:MODULE_COMPAT_5.12.3) perl(strict) perl(Test::Builder) perl(warnings) + %check is present and all tests pass. PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_load.t .. ok t/01_selftest.t .. ok t/98_boilerplate.t ... ok t/99_pod.t ... ok t/99_pod_coverage.t .. ok All tests successful. Files=5, Tests=15, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.27 cusr 0.04 csys = 0.35 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. The extra sub-directory is indeed necessary for tests to pass (but is such a PITA that I wouldn't recommend actually BuildRequiring this for other packages). Description is incredibly weak. How about: This package checks whether the Manifest file matches the distro or not. To match a distro the Manifest has to name all files that come along with the distribution. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665081] Review Request: perl-Starlet - Simple, high-performance PSGI/Plack HTTP server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665081 Iain Arnell changed: What|Removed |Added Status|NEW |ASSIGNED CC||iarn...@gmail.com AssignedTo|nob...@fedoraproject.org|iarn...@gmail.com Flag||fedora-review+ Bug 665081 depends on bug 664910, which changed state. Bug 664910 Summary: Review Request: perl-Plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit) https://bugzilla.redhat.com/show_bug.cgi?id=664910 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED Bug 665081 depends on bug 664982, which changed state. Bug 664982 Summary: Review Request: perl-Parallel-Prefork - Simple prefork server framework https://bugzilla.redhat.com/show_bug.cgi?id=664982 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED Bug 665081 depends on bug 665005, which changed state. Bug 665005 Summary: Review Request: perl-Server-Starter - Superdaemon for hot-deploying server programs https://bugzilla.redhat.com/show_bug.cgi?id=665005 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #1 from Iain Arnell 2011-02-26 00:55:32 EST --- + source files match upstream. 222eff2e8e5d69a44a8a3935fb8837cd Starlet-0.13.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2868586 + package installs properly. + rpmlint has no complaints: perl-Starlet.src: W: spelling-error %description -l en_US Prefork -> Preform, Proreform, Prefatory 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + final provides and requires are sane: perl(Plack::Handler::Starlet) perl(Plack::Server::Standalone::Prefork::Server::Starter) = 0.07 perl(Starlet) = 0.13 perl-Starlet = 0.13-1.fc16 perl(Starlet::Server) = perl >= 0:5.008_001 perl(base) perl(Carp) perl(constant) perl(HTTP::Date) perl(HTTP::Status) perl(IO::Socket::INET) perl(List::Util) perl(:MODULE_COMPAT_5.12.3) perl(Parallel::Prefork) perl(Plack) perl(Plack::Handler::Starlet) perl(Plack::HTTPParser) perl(Plack::TempBuffer) perl(Plack::Util) perl(POSIX) perl(Server::Starter) perl(Socket) perl(Starlet) perl(Starlet::Server) perl(strict) perl(Time::HiRes) perl(Try::Tiny) perl(warnings) + %check is present and all tests pass. All tests successful. Files=4, Tests=94, 4 wallclock secs ( 0.03 usr 0.01 sys + 1.10 cusr 0.22 csys = 1.36 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. I think the description is a little weak. If it were mine, I would rewrite it, but it's up to you: Starlet is a standalone HTTP/1.0 server with support for keep-alive, prefork, graceful shutdown, hot deploy, fast HTTP processing, and is suitable for running HTTP application servers behind a reverse proxy. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678230] Review Request: kmldonkey - Cross-platform graphical user interface for Mldonkey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678230 --- Comment #9 from Fedora Update System 2011-02-26 00:16:44 EST --- Package kmldonkey-2.0.5-3.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kmldonkey-2.0.5-3.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/kmldonkey-2.0.5-3.fc15 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678230] Review Request: kmldonkey - Cross-platform graphical user interface for Mldonkey
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678230 --- Comment #10 from Fedora Update System 2011-02-26 00:17:16 EST --- Package kmldonkey-2.0.5-3.fc14: * should fix your issue, * was pushed to the Fedora 14 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kmldonkey-2.0.5-3.fc14' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/kmldonkey-2.0.5-3.fc14 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677693] Review Request: tintin - TinTin++, aka tt++, is a free MUD client.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677693 Fedora Update System changed: What|Removed |Added Fixed In Version||tintin-2.00.5-4.fc14 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677693] Review Request: tintin - TinTin++, aka tt++, is a free MUD client.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677693 --- Comment #18 from Fedora Update System 2011-02-25 22:59:23 EST --- tintin-2.00.5-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518441] Review Request: ike - Shrew Soft VPN Client For Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518441 Ruediger Landmann changed: What|Removed |Added Flag||fedora-review?, ||needinfo?(and...@topdog.za. ||net) --- Comment #29 from Ruediger Landmann 2011-02-25 19:41:57 EST --- Andrew -- rpmlint shows some problems: $ rpmlint /home/rlandmann/rpmbuild/RPMS/x86_64/ike-2.1.7-3.fc14.x86_64.rpm ike.x86_64: E: executable-marked-as-config-file /etc/logrotate.d/ike ike.x86_64: W: spurious-executable-perm /etc/logrotate.d/ike ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libith.so ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/liblog.so ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libip.so ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libike.so ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libpfk.so ike.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libidb.so ike.x86_64: W: service-default-enabled /etc/rc.d/init.d/iked 1 packages and 0 specfiles checked; 1 errors, 8 warnings. Please update the spec file so that you: * install /etc/logrotate.d/ike with mode 644 * put the .so files in a -devel subpackage I agree with your reasoning about having the service enabled and ready to use on installation. When you've rebuilt the SRPM to address the above points, verify the rpmlint output and I'll complete this review. Cheers Rudi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679613] Review Request: python-flask - A microframework for Python based on Werkzeug, Jinja 2 and good intentions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679613 --- Comment #8 from Jason Tibbitts 2011-02-25 19:24:07 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676188 --- Comment #16 from Jason Tibbitts 2011-02-25 19:23:33 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-02-25 18:19:21 EST --- spatialite-tools-2.4.0-0.2.RC4.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spatialite-tools'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/spatialite-tools-2.4.0-0.2.RC4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674692] Review Request: python-pyramid - The Pyramid web application framework, a Pylons project
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674692 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System 2011-02-25 18:19:35 EST --- python-pyramid-1.0-1.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-pyramid'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-pyramid-1.0-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System 2011-02-25 18:18:51 EST --- esniper-2.24.0-6.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update esniper'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/esniper-2.24.0-6.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662257] Review Request: php-pear-CodeGen-PECL - Tool to generate PECL extensions from an XML description
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662257 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-02-25 18:17:05 EST --- php-pear-CodeGen-PECL-1.1.3-3.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pear-CodeGen-PECL'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675798] Review Request: liblzf - Small data compression library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675798 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2011-02-25 18:18:15 EST --- liblzf-3.6-2.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update liblzf'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/liblzf-3.6-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680308] Review Request: php-pear-MDB2-Schema - XML based database schema manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680308
Ruediger Landmann changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Ruediger Landmann 2011-02-25
17:45:51 EST ---
Looks nice and clean to me Nick
ACCEPT
- = N/A
/ = Check
! = Problem
? = Not evaluated
[/] Rpmlint output is clean:
$ rpmlint SPECS/php-pear-MDB2-Schema.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint
/home/rlandmann/rpmbuild/SRPMS/php-pear-MDB2-Schema-0.8.5-1.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint
/home/rlandmann/rpmbuild/RPMS/noarch/php-pear-MDB2-Schema-0.8.5-1.fc14.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[/] Package is named according to the Package Naming Guidelines.
[/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[/] Package meets the Packaging Guidelines including the Language specific
items
[/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[/] License field in the package spec file matches the actual license.
License type: BSD
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[/] Spec file is legible and written in American English.
[/] Sources used to build the package matches the upstream source, as provided
in the spec URL.
$ md5sum ~/Download/MDB2_Schema-0.8.5.tgz
80512a099d79927a122d9baa8cef1bb4
/home/rlandmann/Download/MDB2_Schema-0.8.5.tgz
$ md5sum SOURCES/MDB2_Schema-0.8.5.tgz
80512a099d79927a122d9baa8cef1bb4 SOURCES/MDB2_Schema-0.8.5.tgz
[/] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2867767
[/] Package is not known to require ExcludeArch
[/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly (with the %find_lang macro)
[-] ldconfig called in %post and %postun if required.
[/] Package does not bundle copies of system libraries
[/] Package is not relocatable.
[/] Package must own all directories that it creates.
[/] Package does not contain duplicates in %files.
[/] Permissions on files are set properly
[/] %files section includes a %defattr(...) line
[/] Package consistently uses macros.
[-] Large documentation files are in a -doc subpackage, if required.
[/] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -static subpackage, if present.
[-] Development .so files in -devel subpackage, if present.
[-] -devel packages require base package with full versioning.
[/] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[/] Package does not own files or directories owned by other packages.
[/] Filenames are valid UTF-8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626175] Review Request: DeTex - is a filter program that removes the LaTeX control sequences from tex files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626175 --- Comment #9 from Christoph Wickert 2011-02-25 16:07:39 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665995] Review Request: fmit - Free Music Instrument Tuner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665995 --- Comment #37 from Fedora Update System 2011-02-25 16:01:40 EST --- Package fmit-0.99.2-1.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fmit-0.99.2-1.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/fmit-0.99.2-1.fc15 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680268] Review Request: cputnik - Dockapp which displays cpu and memory usage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680268 --- Comment #6 from Martin Gieseking 2011-02-25 15:48:34 EST --- Please also drop the BuildRoot field as it's not required any longer either. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #14 from Fedora Update System 2011-02-25 15:36:48 EST --- Package esniper-2.24.0-6.fc14: * should fix your issue, * was pushed to the Fedora 14 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing esniper-2.24.0-6.fc14' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/esniper-2.24.0-6.fc14 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #15 from Fedora Update System 2011-02-25 15:36:56 EST --- Package esniper-2.24.0-6.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing esniper-2.24.0-6.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/esniper-2.24.0-6.fc15 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680268] Review Request: cputnik - Dockapp which displays cpu and memory usage
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680268
--- Comment #5 from Martin Gieseking 2011-02-25
15:32:34 EST ---
(In reply to comment #3)
> cd is required here, because the Makefile resides in /src.
There's also a Makefile in the base directory that calls make for src/.
However, both variants work here anyway.
But please shorten the install line as mentioned in comment #2. If you build
inside of src/ your probably have to prepend "src/" to %{name}.
> I have changed it. However, the modern »apps« as known from the »app stores«
> are female. But »Dockapp« means »Dockable applet«, and this is not female.
Ah, right. Now that you mention it, I'm convinced. :)
> Grrr, in German we have thirteen cases of the English »the«, it's sometimes
> difficult...
Yes, indeed. Especially, if you have to choose a gender for foreign words...
(In reply to comment #4)
> Another question: A dockapp is a graphical application. That's why I have
> actually to add a *.desktop file to make it available from the menus.
According to the guidelines, only GUI applications require a .desktop file.
Dockapps don't fall into this category to me. The following old thread seems to
confirm that:
http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00332.html
Maybe you should ask on the packaging mailing list to get a reconfirmation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676188 Brendan Jones changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Brendan Jones 2011-02-25 15:03:23 EST --- New Package SCM Request === Package Name: qmidiarp Short Description: An arpeggiator, sequencer and MIDI LFO for ALSA Owners: bsjones Branches: f13 f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650283] Review Request: rubygem-rspec-core - Rspec-2 runner and formatters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650283 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-02-25 14:48:59 --- Comment #10 from Mamoru Tasaka 2011-02-25 14:48:59 EST --- Rebuilt for all branches, submitted push requests for F-15/14/13, closing. Thank you for the review and git procedure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650283] Review Request: rubygem-rspec-core - Rspec-2 runner and formatters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650283 Bug 650283 depends on bug 650280, which changed state. Bug 650280 Summary: Review Request: rubygem-rspec-mocks - Rspec-2 doubles (mocks and stubs) https://bugzilla.redhat.com/show_bug.cgi?id=650280 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650282] Review Request: rubygem-rspec-expectations - Rspec-2 expectations (should and matchers)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650282 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-02-25 14:48:12 --- Comment #6 from Mamoru Tasaka 2011-02-25 14:48:12 EST --- Rebuilt for all branches, submitted push requests for F-15/14/13, closing. Thank you for the review and git procedure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650280] Review Request: rubygem-rspec-mocks - Rspec-2 doubles (mocks and stubs)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650280 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-02-25 14:47:41 --- Comment #6 from Mamoru Tasaka 2011-02-25 14:47:41 EST --- Rebuilt for all branches, submitted push requests for F-15/14/13, closing. Thank you for the review and git procedure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 650283] Review Request: rubygem-rspec-core - Rspec-2 runner and formatters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650283 Bug 650283 depends on bug 650282, which changed state. Bug 650282 Summary: Review Request: rubygem-rspec-expectations - Rspec-2 expectations (should and matchers) https://bugzilla.redhat.com/show_bug.cgi?id=650282 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680268] Review Request: cputnik - Dockapp which displays cpu and memory usage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680268 --- Comment #4 from Mario Blättermann 2011-02-25 14:41:47 EST --- Another question: A dockapp is a graphical application. That's why I have actually to add a *.desktop file to make it available from the menus. But in fact, nobody starts a dockapp from the menu. In almost all cases it will be added to a startup script. What should I do here? The less examples in the repos don't have *.desktop files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680268] Review Request: cputnik - Dockapp which displays cpu and memory usage
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680268
--- Comment #3 from Mario Blättermann 2011-02-25 14:31:08
EST ---
(In reply to comment #1)
> Few comments:
> - Please read http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> You SHOULD NOT point bash to BuildRequirements
Removed.
> - libXpm-devel depends on libx11-devel and libXext-devel.
No, mock build fails without libXext-devel.
> - If you plan build package for EPEL you must add %clean section. If not, you
> can remove BuildRoot section:
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Don't know if I should provide a dockapp package for EPEL.
(In reply to comment #2)
> Some additional notes:
>
> - please use macros and variables consistently:
> $RPM_BUILD_ROOT and $RPM_OPT_FLAGS or
> %{buildroot} and %{optflags}
>
> - you can simplify the %build section by using the single line
> make CFLAGS='%{optflags}' %{?_smp_mflags}
> (cd is not required here, and the given LIB dir doesn't exist in Fedora)
>
cd is required here, because the Makefile resides in /src.
> - in the %install section, install the binary with
> install -m 755 %{name} %{buildroot}%{_bindir}
>
> - The 3 additional folders %_iconsdir, %_iconsdir, and %_lconsdir are not
> used.
> The corresponding installs should therefore be dropped.
>
Removed.
> - please also set the file permissions of the source tarball to 644
>
Done.
> - personally, I'd prefer a German summary like this:
> "Dockapp zur Anzeige von Prozessorlast und Speicherverbrauch"
> Something similar could also be used in the %description to avoid
> mentioning
> the grammatical gender of "Dockapp" which is female rather than neuter to my
> feeling. :)
I have changed it. However, the modern »apps« as known from the »app stores«
are female. But »Dockapp« means »Dockable applet«, and this is not female.
Grrr, in German we have thirteen cases of the English »the«, it's sometimes
difficult...
Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/cputnik.spec
SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/cputnik-0.2.0-2.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679613] Review Request: python-flask - A microframework for Python based on Werkzeug, Jinja 2 and good intentions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679613 Dan Young changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Dan Young 2011-02-25 14:10:38 EST --- New Package SCM Request === Package Name: python-flask Short Description: A micro-framework for Python based on Werkzeug, Jinja 2 and good intentions Owners: dyoung Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #13 from Jason Tibbitts 2011-02-25 14:06:46 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 Volker Fröhlich changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Volker Fröhlich 2011-02-25 13:44:27 EST --- New Package SCM Request === Package Name: esniper Short Description: A lightweight console application for sniping eBay auctions Owners: volter Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676392] Review Request: foghorn - DBus signal to SNMP trap service
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676392
Jesse Keating changed:
What|Removed |Added
Flag||needinfo?(roh...@redhat.com
||)
--- Comment #2 from Jesse Keating 2011-02-25 13:29:51 EST
---
Working through the spec I have come comments:
The summary mentions the package name, that's redundant info.
In the requires section you're manually adding requires for some things that
get picked up by library level autorequires. This is duplicate data that just
bloats the rpm databases and should be removed. Manual Requires lines should
only be there for things that the rpmbuild process doesn't automatically
discover.
Why do you have an ExclusiveArch setup? There is no comment in the spec to
explain it.
The init script is not properly "installed" by using chkconfig, please see
https://fedoraproject.org/wiki/Packaging:SysVInitScript for the current
guidelines.
On to the rest of the review...
rpmlint has this to say:
foghorn.x86_64: W: unexpanded-macro dependency glib2 >= %{glib_version}
%{glib_version}
I noticed this in the requires, looks like your macro use isn't correct here.
glib vs glib2
foghorn.x86_64: W: name-repeated-in-summary C Foghorn
I mentioned this above.
foghorn.x86_64: E: description-line-too-long C Foghorn listens for specific
DBUS signals and translates those signals to SNMP traps.
Keep these lines trimmed to 80 chars or less.
foghorn.x86_64: E: zero-length /usr/share/doc/foghorn-0.1.2/README
Don't include it if it's empty, or put something in it upstream.
foghorn.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/dbus-foghorn.conf
I believe this file needs to be marked as a config file.
foghorn.x86_64: E: zero-length /usr/share/doc/foghorn-0.1.2/NEWS
Same thing I wrote about the README file applies here.
foghorn.x86_64: E: init-script-without-chkconfig-postin
/etc/rc.d/init.d/foghorn
foghorn.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/foghorn
I mentioned this above about the init script.
foghorn.x86_64: W: incoherent-subsys /etc/rc.d/init.d/foghorn $prog
You can ignore this, because of the use of the variable "$prog"
foghorn.spec:29: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 1)
Please don't mix tabs and spaces :)
I looked over the licensing and looked at the source files, that all looks OK
Spec name is OK
Upstream tarball matches the tarball in the srpm
Everything else looks fine, please correct the issues listed above.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657908
Martin Gieseking changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review+
--- Comment #11 from Martin Gieseking 2011-02-25
13:27:59 EST ---
OK, the package looks good now.
$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
esniper.x86_64: W: no-manual-page-for-binary snipe
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
There's no manpage available for snipe, so the warning can be ignored.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- BSD (two-clause variant)
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum esniper-2-24-0.tgz*
aae4b24cc37b9bbb6ba78e017e127ded esniper-2-24-0.tgz
aae4b24cc37b9bbb6ba78e017e127ded esniper-2-24-0.tgz.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, ...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.
Package APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676392] Review Request: foghorn - DBus signal to SNMP trap service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676392 Jesse Keating changed: What|Removed |Added Status|NEW |ASSIGNED CC||jkeat...@redhat.com AssignedTo|nob...@fedoraproject.org|jkeat...@redhat.com Flag||fedora-review? --- Comment #1 from Jesse Keating 2011-02-25 12:56:25 EST --- Taking this review (and sponsorship). Comments to follow soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652598] Review Request: erlang-riak_core - Distributed systems infrastructure used by Riak
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652598 --- Comment #2 from Peter Lemenkov 2011-02-25 12:45:07 EST --- Ver. 0.14.1: http://peter.fedorapeople.org/erlang-riak_core.spec http://peter.fedorapeople.org/erlang-riak_core-0.14.1-1.fc15.src.rpm It's finally ready for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680488] New: Review Request: erlang-basho_stats - Basic Erlang statistics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: erlang-basho_stats - Basic Erlang statistics library https://bugzilla.redhat.com/show_bug.cgi?id=680488 Summary: Review Request: erlang-basho_stats - Basic Erlang statistics library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lemen...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://peter.fedorapeople.org/erlang-basho_stats.spec SRPM URL: http://peter.fedorapeople.org/erlang-basho_stats-1.0.1-1.fc15.src.rpm Description: Basic Erlang statistics library. This is one of the requirements for the Riak. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #10 from Volker Fröhlich 2011-02-25 12:42:01 EST --- Argh! Deleted the wrong line. http://www.geofrogger.net/review/esniper.spec http://www.geofrogger.net/review/esniper-2.24.0-6.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680488] Review Request: erlang-basho_stats - Basic Erlang statistics library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680488 Peter Lemenkov changed: What|Removed |Added Blocks||652598 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652598] Review Request: erlang-riak_core - Distributed systems infrastructure used by Riak
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652598 Peter Lemenkov changed: What|Removed |Added Depends on||680488 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680473] Review Request: ghc-ForSyDe - Formal System Design methodology
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680473 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #9 from Martin Gieseking 2011-02-25 12:24:14 EST --- The definition of INSTALL is still missing. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #8 from Volker Fröhlich 2011-02-25 12:11:20 EST --- Thank you! http://www.geofrogger.net/review/esniper.spec http://www.geofrogger.net/review/esniper-2.24.0-5.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668052] Review Request: libtpms - Library providing Trusted Platform Module (TPM) functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668052 --- Comment #15 from Jason Tibbitts 2011-02-25 12:05:55 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665995] Review Request: fmit - Free Music Instrument Tuner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665995 --- Comment #36 from Jason Tibbitts 2011-02-25 12:05:35 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680473] Review Request: ghc-ForSyDe - Formal System Design methodology
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680473 Shakthi Kannan changed: What|Removed |Added CC||fedora-haskell-list@redhat. ||com --- Comment #1 from Shakthi Kannan 2011-02-25 12:08:28 EST --- Output of rpmlint: $ rpmlint ghc-ForSyDe.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-ForSyDe-3.1.1-1.fc14.src.rpm ghc-ForSyDe.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ghc-ForSyDe-3.1.1-1.fc14.i686.rpm ghc-ForSyDe.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ghc-ForSyDe-devel-3.1.1-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-ForSyDe-prof-3.1.1-1.fc14.i686.rpm ghc-ForSyDe-prof.i686: E: devel-dependency ghc-ForSyDe-devel ghc-ForSyDe-prof.i686: W: no-documentation ghc-ForSyDe-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/ForSyDe-3.1.1/libHSForSyDe-3.1.1_p.a 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Successful Koji build for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2866759 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680473] New: Review Request: ghc-ForSyDe - Formal System Design methodology
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ghc-ForSyDe - Formal System Design methodology https://bugzilla.redhat.com/show_bug.cgi?id=680473 Summary: Review Request: ghc-ForSyDe - Formal System Design methodology Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: shakthim...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://shakthimaan.fedorapeople.org/SPECS/ghc-ForSyDe.spec SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/ghc-ForSyDe-3.1.1-1.fc14.src.rpm Description: A Formal System Design methodology package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665995] Review Request: fmit - Free Music Instrument Tuner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665995 Damian Wrobel changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225670] Merge Review: cups
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225670 --- Comment #6 from Tim Waugh 2011-02-25 10:57:42 EST --- (In reply to comment #5) > cups.src:259: W: macro-in-comment %patch28 > cups.src: W: patch-not-applied Patch28: cups-gnutls-gcrypt-threads.patch > ^^^ please apply the patch or remove it Gone. > cups.x86_64: W: obsolete-not-provided LPRng > ^^^ I think LPRng should be provided The history behind this is in bug #148757. > cups.x86_64: W: file-not-utf8 /usr/share/doc/cups-1.4.3/CREDITS.txt > ^^^ Please convert this file to UTF-8 during build process. `man 1 iconv` is > your friend I believe it is now UTF-8 upstream. > cups-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libcupscgi.so.1 > exit@GLIBC_2.2.5 > ^^^ Please explain why it is acceptable (for example self-implemented stack > protector > is a good reason to call exit inside library) This shared library is only used internally by CUPS (it is used by several of the CGI handlers). It is simply to share code between CUPS programs. > cups-lpd.x86_64: W: spelling-error %description -l en_US provices > cups-php.x86_64: W: spelling-error %description -l en_US provices > ^^^ Probably typos Both fixed. > The PIE problem: I've removed --enable-pie from the configure options as this is (sort of) done automatically upstream. The upstream build process is not sophisticated enough to handle passing exactly the right parameters. It uses -fPIC (not -fPIE) when compiling, which Jakub assures me is simply slightly less efficient that -fPIE in some cases. Indeed, the resulting executables behave as PIEs and seem to have the correct ELF flags set. The upstream discussion about it is here: http://cups.org/str.php?L3691 Please take a look at cups-1.4.6-6.fc14. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679613] Review Request: python-flask - A microframework for Python based on Werkzeug, Jinja 2 and good intentions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679613 --- Comment #6 from Toshio Ernie Kuratomi 2011-02-25 10:58:39 EST --- (In reply to comment #3) > > Also, I'd appreciate some feedback on how I'm building the docs. Upstream uses > Sphinx, which is apparently D/Ling from the web at build time for "intersphinx > inventory". My understanding is that koji builds are not allowed network > access, nor do we want any external sources anyways. It's not clear to me that > these are "sources" in the traditional sense. I'm considering patching out > this > function, although I frankly don't think I yet fully understand the > ramifications of just nuking it entirely or letting it timeout if network > access is denied: > intersphinx allows sphinx to create links in documentation between sites. So, for instance, if the documentation you're building references a function from the python stdlib, the sphinx can create a link for that function that points to docs.python.org. I have a package, python-kitchen, that uses intersphinx and it builds in the build system fine so I think letting that timeout is fine. The only effect should be that the generated documentation won't link to external documents. sphinx should not fail the build just because it can't retrieve the objects.inv file. If this package doesn't build in koji because f sphinx, let me know and I'll look into it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679820] Review Request: drupal7 - An open-source content-management platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679820 Jason Tibbitts changed: What|Removed |Added Summary|Review: drupal7 - An |Review Request: drupal7 - |open-source |An open-source |content-management platform |content-management platform -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673589 --- Comment #28 from Ralf Corsepius 2011-02-25 10:07:03 EST --- 2 details: * I'd recommend to append --disable-silent-rules to %configure This makes build logs much better readable (You could drop the make V=1, then) * The *-devel package applies libstdc++ => Please add Requires: libstdc++-devel Another detail I do not understand: ... checking for mysql_close in -lmysqlclient... no checking for mysqlclient library with -L/lib64... no checking for mysqlclient library with -L/lib... no checking for mysqlclient library with -L/usr/lib64... no checking for mysqlclient library with -L/usr/lib... no checking for mysqlclient library with -L/usr/local/lib64... no checking for mysqlclient library with -L/usr/local/lib... no checking for mysqlclient library with -L/usr/local/lib64/mysql... no checking for mysqlclient library with -L/usr/lib64/mysql... yes checking mysql/mysql.h usability... yes checking mysql/mysql.h presence... yes checking for mysql/mysql.h... yes 2 issues with this: 1. ".lmysqlclient... no" At least Fedora 14 has "mysql_close in -lmysqlclient" # nm -sD /usr/lib64/mysql/libmysqlclient.so | grep mysql_close 0039e5450580 T mysql_close 2. The lib../usr/lib... iteration. This a pretty questionable way to check for a library. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668052] Review Request: libtpms - Library providing Trusted Platform Module (TPM) functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668052 Stefan Berger changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Stefan Berger 2011-02-25 10:03:45 EST --- New Package SCM Request === Package Name: libtpms Short Description: Library providing TPM functionality for VMs. Targeted for integration into Qemu. Owners: stefanberger Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=197688 --- Comment #14 from Fedora Update System 2011-02-25 09:40:42 EST --- inotify-tools-3.13-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/inotify-tools-3.13-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657908] Review Request: esniper - A lightweight console application for sniping eBay auctions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657908 --- Comment #7 from Martin Gieseking 2011-02-25 09:42:23 EST --- Hi Volker, the package looks almost fine. Please preserve the timestamp of the manpage. You can accomplish this by extending the iconv line this way: iconv -f iso8859-1 -t utf-8 esniper.1 > esniper.1.conv \ && touch -r esniper.1 esniper.1.conv \ && mv esniper.1.conv esniper.1 Also, append INSTALL="install -p" to "make install". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638425] Review Request: nawk - "The one true awk" descended from UNIX V7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638425 --- Comment #28 from Fedora Update System 2011-02-25 09:39:02 EST --- nawk-20100523-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nawk-20100523-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680368] Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680368 --- Comment #4 from Jason Tibbitts 2011-02-25 09:34:24 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635875] Review Request: mawk - An interpreter for the AWK programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635875 --- Comment #21 from Fedora Update System 2011-02-25 09:32:13 EST --- mawk-1.3.4-4.20100625.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mawk-1.3.4-4.20100625.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678929] Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678929 --- Comment #4 from Jason Tibbitts 2011-02-25 09:34:04 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678925] Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678925 --- Comment #3 from Jason Tibbitts 2011-02-25 09:33:43 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 179237] Review Request: swaks - A command-line SMTP transaction tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=179237 --- Comment #16 from Fedora Update System 2011-02-25 09:22:41 EST --- swaks-20100211.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/swaks-20100211.0-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676544] Review Request: pidgin-logviewer - User friendly and intuitive way of viewing chat logs in Pidgin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676544 --- Comment #18 from Praveen Kumar 2011-02-25 09:19:36 EST --- (In reply to comment #17) > One of workarounds is to execute > $ touch -r configure configure.ac Makefile.in */Makefile.in aclocal.m4 > config.h.in > before calling %configure. Thanks for suggestion Fix automated unwanted calls. Here is updated spec and srpm SPEC URL : http://kumarpraveen.fedorapeople.org/pidgin-logviewer/pidgin-logviewer.spec SRPM URL : http://kumarpraveen.fedorapeople.org/pidgin-logviewer/pidgin-logviewer-0.2-7.20110225svn14.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 179237] Review Request: swaks - A command-line SMTP transaction tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=179237 --- Comment #14 from Fedora Update System 2011-02-25 09:19:42 EST --- swaks-20100211.0-4.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/swaks-20100211.0-4.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 179237] Review Request: swaks - A command-line SMTP transaction tester
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=179237 --- Comment #15 from Fedora Update System 2011-02-25 09:21:50 EST --- swaks-20100211.0-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/swaks-20100211.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680423] Review Request: drupal6-authfas - Drupal 6 module for authentication via a Fedora Account System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680423 Paul W. Frields changed: What|Removed |Added Blocks||662103(InsightReviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672845] Review Request: rubygem-net-ping - Net::Ping rubygem library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672845 --- Comment #5 from Lukáš Zapletal 2011-02-25 09:16:19 EST --- Waiting for the upstream. https://github.com/djberg96/net-ping/pull/3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680423] Review Request: drupal6-authfas - Drupal 6 module for authentication via a Fedora Account System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680423 --- Comment #1 from Paul W. Frields 2011-02-25 09:10:22 EST --- $ rpmlint rpmbuild/SPECS/drupal6-authfas.spec rpmbuild/SRPMS/drupal6-authfas-0.2.1-1.fc14.src.rpm rpmbuild/RPMS/noarch/drupal6-authfas-0.2.1-1.fc14.noarch.rpm drupal6-authfas.src: W: spelling-error Summary(en_US) Drupal -> Drupelet, Drupe, Druidical drupal6-authfas.noarch: W: spelling-error Summary(en_US) Drupal -> Drupelet, Drupe, Druidical 2 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680423] New: Review Request: drupal6-authfas - Drupal 6 module for authentication via a Fedora Account System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: drupal6-authfas - Drupal 6 module for authentication via a Fedora Account System https://bugzilla.redhat.com/show_bug.cgi?id=680423 Summary: Review Request: drupal6-authfas - Drupal 6 module for authentication via a Fedora Account System Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pfrie...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://pfrields.fedorapeople.org/packages/SPECS/drupal6-authfas.spec SRPM URL: http://pfrields.fedorapeople.org/packages/SRPMS/drupal6-authfas-0.2.1-1.fc14.src.rpm Description: This module allows Drupal 6 users to be authenticated via an instance of the Fedora Account System (FAS). Each Drupal role can also be mapped to a group in FAS, and group memberships are updated for a user before the session starts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668052] Review Request: libtpms - Library providing Trusted Platform Module (TPM) functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668052 --- Comment #13 from Stefan Berger 2011-02-25 08:43:58 EST --- Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679820] Review: drupal7 - An open-source content-management platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679820 Jon Ciesla changed: What|Removed |Added Summary|Rename review: drupal7 - |Review: drupal7 - An |An open-source |open-source |content-management platform |content-management platform --- Comment #3 from Jon Ciesla 2011-02-25 08:20:22 EST --- glibc, obviously. :) Corrected, finger_FAIL. License tag corrected. SPEC: http://zanoni.jcomserv.net/fedora/drupal7/drupal7.spec SRPM: http://zanoni.jcomserv.net/fedora/drupal7/drupal7-7.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676188 Martin Gieseking changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #14 from Martin Gieseking 2011-02-25 07:59:09 EST --- OK. The package is ready now. Package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673589 Sergio Belkin changed: What|Removed |Added Attachment #480140|0 |1 is obsolete|| --- Comment #27 from Sergio Belkin 2011-02-25 07:51:15 EST --- Created attachment 480982 --> https://bugzilla.redhat.com/attachment.cgi?id=480982 Fixes the original spec made it known to bugzilla (Release 8) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673589
--- Comment #26 from Sergio Belkin 2011-02-25 07:48:39 EST
---
(In reply to comment #25)
***The new and corrected files***
Spec URL: http://dl.dropbox.com/u/14217893/UpTools.spec
Spec URL: http://dl.dropbox.com/u/14217893/UpTools-8.5.4-8.fc16.src.rpm
***Below, the comments to Mamoru comments***
> Some notes:
>
> * Macros
> https://fedoraproject.org/wiki/Packaging/RPMMacros
> - Please use macros properly. For example. /usr/bin should be
> replaced by %{_bindir}
> ! By the way, "/usr/bin/" part before iconv is just redundant.
Thanks Mamoru!
Firstly:
You're right. Just I thought that the complete path it was better. Fixed (i.e.
removed "/usr/bin/")
>
> * Compilation flags
> - Would you explain why "-Wno-deprecated" is needed (i.e.
> why do you want to suppress warnings?)
Because we were using hash_map and hash_set, now it is using through %configure
option unordered_map and unordered_set headers instead, AFAIK hash_* are
deprecated since gcc 4.3 but in tarball we preferred to be conservative.
>
> * Parallel make
> https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
> - Support parallel make if possible. If impossible, please write
> some comments on the spec file about it.
Oops. Fixed.
>
> * Timestamps
> https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
> - When installing files with "install" or "cp" commands, please
> add "-p" option to keep timestamps on installed files:
Fixed too.
>
> * %defattr
> - Now we prefer to use %defattr(-,root,root,-)
Oops. Fixed!
>
> * Dependency
> - UpSsl.h under %_includedir/UpTools contains:
> -
> 50 #ifndef USE_YASSL
> 51 #include
> 52 #include
> 53 #include
> 54 #include
> -
> looks like "Requires: openssl-devel%{?_isa}" is also needed
> on -devel subpackage
> ! By the way, I prefer to write one Requires per one line
> because
> - It is easier to read
> - It makes diff output smaller and more readable when Requires
> items changed.
About of "Requires per one line" I agree completely with you, in fact, before
it was one per line, but I thought that it was needed making so, and about
openssl-devel as Requires, I was taking into account that, so yum would resolve
the missing package:
rpm -qR mysql-devel | grep openssl
openssl-devel(x86-32)
and
repoquery -R mysql-devel
libmysqlclient.so.16
libmysqlclient_r.so.16
mysql(x86-32) = 5.1.55-1.fc14
openssl-devel(x86-32)
Anyway, I've added it :)
>
> * Messages on scriptlets
> - Generally showing messages (especially non-error messages)
> when executing scriptlets (%post and so on) is forbidden.
> Instruction for creating example executables or so should be
> written and be installed as a file, and should not appear
> during scriptlets are executed.
Yup. Removed :)
>
> * Miscs
> - Why do you want to list each example files under doc/tests
> explicitly? (i.e. please use glob)
Just the will to work in excess :)
Using glob now!
>
> - Also are there any reason you don't want to use %name-devel directory
> under %_defaultdocdir?
Thanks! It was an error. Fixed
> Allowing to use such directory and using
> %doc in the spec file is much simpler and easier to read.
Yes is it. I've rearranged that properly.
Thanks Mamoru, your advices helped me a lot.
Please could you give me your review and sponsorship.
Thanks in advance!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680368] Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680368 Stanislav Ochotnicky changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Stanislav Ochotnicky 2011-02-25 07:40:03 EST --- New Package SCM Request === Package Name: decentxml Short Description: XML parser optimized for round-tripping and code reuse Owners: sochotni Branches: f15 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680368] Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680368
Alexander Kurtakov changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Alexander Kurtakov 2011-02-25
07:22:44 EST ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
decentxml.noarch: W: spelling-error %description -l en_US whitespace -> white
space, white-space, whites pace
decentxml.noarch: W: non-conffile-in-etc /etc/maven/fragments/decentxml
Not a problem.
decentxml.src: W: invalid-url Source0: decentxml-1.3.tar.xz
Request to upstream to provide source tarball is made.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: BSD
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[-] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_to_maven_depmap call which resolves to the pom
file (use "JPP." and "JPP-" correctly)
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why
it's needed in a comment
[x] Package uses %update_maven_depmap in %post/%postun
[x] Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
=== Issues ===
1. Not a big issue but due to assembly plugin tied to the package stage there
is no need to run javadoc:javadoc. The assembly plugin run is putting the
javadoc in target/apidocs not in target/site/apidocs. Change if you like it but
it reduces the build time significantly for me.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675726] Review Request: cdm - Very minimalistic display manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675726 Mikhail Kulemin changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-02-25 07:03:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615508] Review Request: nut-nutrition - A nutritional Software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615508 Ankur Sinha changed: What|Removed |Added Status Whiteboard|NotReady| --- Comment #7 from Ankur Sinha 2011-02-25 06:51:54 EST --- Hi! Fresh spec: http://ankursinha.fedorapeople.org/nut/nut-nutrition.spec Fresh SRPM: http://ankursinha.fedorapeople.org/nut/nut-nutrition-15.7-3.fc16.src.rpm Mock build results etc can be found here: http://ankursinha.fedorapeople.org/nut/ Thanks! Regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676188] Review Request: qmidiarp - an arpeggiator, sequencer and MIDI LFO for ALSA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676188 --- Comment #13 from Brendan Jones 2011-02-25 06:46:53 EST --- No problem! Changed here: http://bsjones.fedorapeople.org/qmidiarp-0.3.9-6.fc14.src.rpm http://bsjones.fedorapeople.org/qmidiarp.spec -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 --- Comment #10 from Fedora Update System 2011-02-25 06:15:38 EST --- spatialite-tools-2.4.0-0.2.RC4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/spatialite-tools-2.4.0-0.2.RC4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 --- Comment #9 from Fedora Update System 2011-02-25 06:15:31 EST --- spatialite-tools-2.4.0-0.2.RC4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spatialite-tools-2.4.0-0.2.RC4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 --- Comment #11 from Fedora Update System 2011-02-25 06:15:46 EST --- spatialite-tools-2.4.0-0.2.RC4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/spatialite-tools-2.4.0-0.2.RC4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680368] Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680368 Alexander Kurtakov changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #1 from Alexander Kurtakov 2011-02-25 06:03:21 EST --- I'll do this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 --- Comment #8 from Volker Fröhlich 2011-02-25 05:56:07 EST --- I wrote to the author on a better description. But he didn't respond yet. I already started making builds now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675726] Review Request: cdm - Very minimalistic display manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675726 --- Comment #16 from Fedora Update System 2011-02-25 05:03:33 EST --- cdm-0.5.3-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/cdm-0.5.3-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675726] Review Request: cdm - Very minimalistic display manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675726 --- Comment #15 from Fedora Update System 2011-02-25 04:54:59 EST --- cdm-0.5.3-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/cdm-0.5.3-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678925] Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678925 Emmanuel Seyman changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Emmanuel Seyman 2011-02-25 04:58:10 EST --- (In reply to comment #1) > > The wrong-script-end-of-line-encoding should be fixed in %prep: sed -i > 's/\r//' examples/*.pl Fixed. > APPROVED with that one minor tweak. Thanks, Ian! New Package SCM Request === Package Name: perl-Math-Random-ISAAC Short Description: Perl interface to the ISAAC PRNG algorithm Owners: eseyman Branches: f14 f15 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675726] Review Request: cdm - Very minimalistic display manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675726 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627637] Review Request: qroneko - A front end of crontab application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627637 Mamoru Tasaka changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-02-25 04:51:53 --- Comment #18 from Mamoru Tasaka 2011-02-25 04:51:53 EST --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680368] New: Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: decentxml - XML parser optimized for round-tripping and code reuse https://bugzilla.redhat.com/show_bug.cgi?id=680368 Summary: Review Request: decentxml - XML parser optimized for round-tripping and code reuse Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: socho...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://sochotni.fedorapeople.org/packages/decentxml.spec SRPM URL: http://sochotni.fedorapeople.org/packages/decentxml-1.3-1.fc14.src.rpm Description: XML parser optimized for round-tripping and code reuse with main features being: * Allows 100% round-tripping, even for weird whitespace between attributes in the start tag or in the end tag * Suitable for building editors and filters which want/need to preserve the original file layout as much as possible * Error messages have line and column information * Easy to reuse individual components * XML 1.1 compatible -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680368] Review Request: decentxml - XML parser optimized for round-tripping and code reuse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680368 Stanislav Ochotnicky changed: What|Removed |Added Blocks||652183(FE-JAVASIG) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678929] Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678929 Emmanuel Seyman changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Emmanuel Seyman 2011-02-25 04:42:12 EST --- Thanks for the review, Ian. New Package SCM Request === Package Name: perl-Crypt-Random-Source Short Description: Get weak or strong random data from pluggable sources Owners: eseyman Branches: f14 f15 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664417] Review Request: spatialite-tools - A set of useful CLI tools for spatialite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664417 --- Comment #7 from Martin Gieseking 2011-02-25 04:29:39 EST --- Volker, what's the status of this package? There are no related builds yet. Did you just forget it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668052] Review Request: libtpms - Library providing Trusted Platform Module (TPM) functionality
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668052 --- Comment #12 from Tomas Mraz 2011-02-25 03:35:19 EST --- I have also added you to the Fedora packager group and sponsored you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662257] Review Request: php-pear-CodeGen-PECL - Tool to generate PECL extensions from an XML description
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662257 --- Comment #11 from Fedora Update System 2011-02-25 03:24:20 EST --- php-pear-CodeGen-PECL-1.1.3-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 680268] Review Request: cputnik - Dockapp which displays cpu and memory usage
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680268
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #2 from Martin Gieseking 2011-02-25
03:27:55 EST ---
Some additional notes:
- please use macros and variables consistently:
$RPM_BUILD_ROOT and $RPM_OPT_FLAGS or
%{buildroot} and %{optflags}
- you can simplify the %build section by using the single line
make CFLAGS='%{optflags}' %{?_smp_mflags}
(cd is not required here, and the given LIB dir doesn't exist in Fedora)
- in the %install section, install the binary with
install -m 755 %{name} %{buildroot}%{_bindir}
- The 3 additional folders %_iconsdir, %_iconsdir, and %_lconsdir are not used.
The corresponding installs should therefore be dropped.
- please also set the file permissions of the source tarball to 644
- personally, I'd prefer a German summary like this:
"Dockapp zur Anzeige von Prozessorlast und Speicherverbrauch"
Something similar could also be used in the %description to avoid mentioning
the grammatical gender of "Dockapp" which is female rather than neuter to my
feeling. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
