[Bug 674188] Review Request: libzeitgeist - Library to access zeitgeist; needed by synapse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674188
--- Comment #21 from Renich Bon Ciric 2011-03-22
02:20:59 EDT ---
(In reply to comment #20)
Im sorry; here they are:
spec: http://renich.fedorapeople.org/SPECS/libzeitgeist.spec
srpm: http://renich.fedorapeople.org/SRPMS/libzeitgeist-0.3.6.1.fc14.src.rpm
> For -3:
> * %{?_isa} specific dependency
> - As said in the comment 14, -devel subpackage should have
> "%{name}%{?_isa} = %{version}-%{release}"
Ok, changed it on the summary and requires too.
> - And it is very likely that "Requires: zeitgeist" should be
> %{_isa} specific.
I think not; since zeitgeist is .noarch ;)
> * %check
> - So please fix %check failure or rescue it so that rpmbuild
> on koji succeeds.
Working on this at the time of writing. I will disable the test as soon as I
figure out how.
No idea of why it builds with rpmbuild and not in mock/koji... some missing dep
perhaps? been checking configure.ac but... I dunno... still on it...
> * %doc attribute
> - As said in the comment 16, "%doc" attribute on
> %{_datadir}/gtk-doc/html/foo is not needed.
Woops... sorry... finally understood ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 Ralf Corsepius changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #6 from Ralf Corsepius 2011-03-22 02:20:07 EDT --- (In reply to comment #5) > Thanks for the quick work! > > Actually, there's one last step we should take, and that's to include a copy > of > the GPL with the package. (Second dot point in comment #2) Doing so is not mandatory in Fedora. Legally, it's questionable, because a Fedora packager added license file isn't legally binding to upstream (only upstream can do this). > From the email, it sounds like it's unlikely that upstream will generate a new > tarball for us, so instead could you please contact them again and: > > * attach a copy of the GPLv1 (not any other version) to the email Are you sure? This GPLv1 is dead for more than a decade. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689685] New: Review Request: Anchorman - The recording-studio-in-a-box
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Anchorman - The recording-studio-in-a-box https://bugzilla.redhat.com/show_bug.cgi?id=689685 Summary: Review Request: Anchorman - The recording-studio-in-a-box Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: wm...@wm161.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://tdfischer.fedorapeople.org/anchorman.spec SRPM URL: http://tdfischer.fedorapeople.org/anchorman-0.0.1-1.fc14.src.rpm Description, from my spec file: > Ever wanted to run your own recording studio? Need to handle multiple streams > of > audio, video, and possibly even subtitles? Anchorman can't do that. Yet. > However, it can stream a webcam to an icecast server. Included is support for > suspending/resuming the stream when the device is inserted/removed. Anchorman is a small program that waits for a webcam to be attached. Once attached, the camera stream is sent off to an icecast or shoutcast server for broadcasting. The stream stops once the camera is removed. This is my first package (and first release of anchorman), so I need a sponsor. More features will be coming to anchorman when I have the time to write them. In case it isn't clear, I am upstream for anchorman. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689685] Review Request: Anchorman - The recording-studio-in-a-box
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689685 Trever Fischer changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662604 --- Comment #14 from Truong Anh Tuan 2011-03-22 01:20:53 EDT --- Hi there, Thanks. You patch is great. I updated the .spec file to get the patch and recompiled the package successfully. So, please review the updated src and spec file for me. Hope it is good enough now. P.S. the files have been moved to sub-folder so their locations are: http://tuanta.fedorapeople.org/ibus-unikey/ibus-unikey.spec http://tuanta.fedorapeople.org/ibus-unikey/ibus-unikey-0.5.1-4.fc15.src.rpm Rgds, Tuan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673030] Review Request: perl-Locale-US - Two letter codes for state identification in the United States and vice versa
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673030
--- Comment #6 from Iain Arnell 2011-03-22 00:02:38 EDT ---
(In reply to comment #4)
> Why not ship kruft2codes.pl as %doc rather than just deleting it, since it's
> mentioned in the POD?
> May as well fix the mis-spellings too:
> https://rt.cpan.org/Public/Bug/Display.html?id=62218
Yes, will do for both.
> Is %{?perl_default_filter} actually needed?
Probably not, but I see no harm in having it in most packages.
> APPROVED.
Thanks for the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673030] Review Request: perl-Locale-US - Two letter codes for state identification in the United States and vice versa
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673030 --- Comment #5 from Iain Arnell 2011-03-21 23:57:10 EDT --- New Package SCM Request === Package Name: perl-Locale-US Short Description: Two letter codes for state identification in the United States and vice versa Owners: iarnell Branches: f13 f14 f15 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673030] Review Request: perl-Locale-US - Two letter codes for state identification in the United States and vice versa
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673030 Iain Arnell changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579449] Review Request: emacs-common-riece - Yet Another IRC Client for Emacs and XEmacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579449 Fedora Update System changed: What|Removed |Added Fixed In Version||emacs-common-riece-7.0.3-1. ||fc15 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518441] Review Request: ike - Shrew Soft VPN Client For Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518441 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ike-2.1.7-4.fc15 Resolution||ERRATA Last Closed||2011-03-21 23:50:24 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579449] Review Request: emacs-common-riece - Yet Another IRC Client for Emacs and XEmacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579449 --- Comment #13 from Fedora Update System 2011-03-21 23:50:04 EDT --- emacs-common-riece-7.0.3-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518441] Review Request: ike - Shrew Soft VPN Client For Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518441 --- Comment #40 from Fedora Update System 2011-03-21 23:50:18 EDT --- ike-2.1.7-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634052] Review Request: ghc-ConfigFile - configuration file library for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634052 --- Comment #12 from Fedora Update System 2011-03-21 23:43:49 EDT --- ghc-ConfigFile-1.0.6-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634052] Review Request: ghc-ConfigFile - configuration file library for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634052 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-ConfigFile-1.0.6-4.fc15 Resolution||ERRATA Last Closed||2011-03-21 23:43:54 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688408 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System 2011-03-21 23:29:57 EDT --- xfce4-cpufreq-plugin-1.0.0-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683552 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System 2011-03-21 23:29:46 EDT --- mysql-connector-python-0.3.2-2.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637402] Review Request: sqlninja - A tool for SQL server injection and takeover
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637402 --- Comment #16 from Arun SAG 2011-03-21 23:24:31 EDT --- (In reply to comment #15) > @Arun, > > The software would be still useful without the binaries ? Yes! The software supports multiple modes, one of the mode is upload mode. Binaries are required for only upload mode. If the user wants to use upload mode, he can manually download these binaries. Also please look into the scripts directory, the files under the scripts directory qualify as a binary? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523034 --- Comment #12 from Kevin Fenzi 2011-03-21 23:15:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688659] Review Request: thunarx-python - Python bindings for the Thunar Extension Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688659 --- Comment #8 from Kevin Fenzi 2011-03-21 23:18:36 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688659] Review Request: thunarx-python - Python bindings for the Thunar Extension Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688659 Balaji G changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Balaji G 2011-03-21 23:12:05 EDT --- New Package SCM Request === Package Name: thunarx-python Short Description: Python bindings for the Thunar Extension Framework Owners: balajig8 kevin Branches: f14 f15 el6 InitialCC: baz Cheers, - Balaji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688659] Review Request: thunarx-python - Python bindings for the Thunar Extension Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688659 --- Comment #6 from Balaji G 2011-03-21 23:00:34 EDT --- Kevin, Thanks for the review again and hopefully i believe this should be ok. Have uploaded the spec and SRPMs in the same location as above. Cheers, - Balaji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523034 Ruben Kerkhof changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Ruben Kerkhof 2011-03-21 22:55:32 EDT --- New Package SCM Request === Package Name: python-setuptools_trial Short Description: Setuptools plugin that makes unit tests execute with trial instead of pyunit Owners: ruben Branches: f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688659] Review Request: thunarx-python - Python bindings for the Thunar Extension Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688659 Kevin Fenzi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Kevin Fenzi 2011-03-21 22:42:00 EDT --- Thanks for the fixes! 1. This still isn't quite right... this has the 'or any later version', so it should be 'LGPLv2+' as the License tag. 2, 3, 4, 5 all look good and fixed. 6. rpmlint now says: thunarx-python.src: W: invalid-license LGPL thunarx-python.x86_64: W: invalid-license LGPL thunarx-python-debuginfo.x86_64: W: invalid-license LGPL which should be fixed by the License change. ;) You forgot to change the Release at the top from 1 to 2. ;) Fix those two things and I think everything looks good. You can do those two changes before importing the package. This package is APPROVED. I'll go ahead and sponsor you and you can continue the process from: https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner once I've added you to the packager group. Welcome to the fun! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674008
--- Comment #27 from Rosen Diankov 2011-03-21
21:36:36 EDT ---
for the *_INSTALL_DIR stuff, perhaps we can append it with "CACHE PATH". For
example:
set(OPENRAVE_OCTAVE_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}/share/openrave/octave"
CACHE PATH)
i think this would still enable you to set new paths from the command line.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 --- Comment #26 from Rosen Diankov 2011-03-21 21:13:14 EDT --- I have a couple of questions about your patches: 1. why are you doing if(NOT OPENRAVE_OCTAVE_INSTALL_DIR) if(NOT OPENRAVE_PLUGINS_INSTALL_DIR) 2. What happens to local installs when force-installing openravepy in the python site-packages? 3. Would it be better to do a pkg-config thing for crlibm instead of searching for the include files? 4. sympy has local changes which i'm still waiting for them to be integrated in the official releases (i've opened up issues), so don't use the default sympy over the local one in openrave. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689639] Review Request: assimp - Open Asset Import Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689639 Jason Tibbitts changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Last Closed||2011-03-21 21:04:37 --- Comment #1 from Jason Tibbitts 2011-03-21 21:04:37 EDT --- *** This bug has been marked as a duplicate of bug 635511 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 Bug 674008 depends on bug 689639, which changed state. Bug 689639 Summary: Review Request: assimp - Open Asset Import Library https://bugzilla.redhat.com/show_bug.cgi?id=689639 What|Old Value |New Value Resolution||DUPLICATE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635511] Review Request: assimp - Library to import various 3D model formats into applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635511 Jason Tibbitts changed: What|Removed |Added CC||t...@niemueller.de --- Comment #26 from Jason Tibbitts 2011-03-21 21:04:37 EDT --- *** Bug 689639 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 Tim Niemueller changed: What|Removed |Added Depends on||689639 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689639] Review Request: assimp - Open Asset Import Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689639 Tim Niemueller changed: What|Removed |Added Blocks||674008 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689639] New: Review Request: assimp - Open Asset Import Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: assimp - Open Asset Import Library https://bugzilla.redhat.com/show_bug.cgi?id=689639 Summary: Review Request: assimp - Open Asset Import Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: t...@niemueller.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~timn/misc/assimp.spec SRPM URL: http://fedorapeople.org/~timn/misc/assimp-2.0.863-1.fc14.src.rpm Description: Open Asset Import Library (short name: Assimp) is a portable Open Source library to import various well-known 3D model formats in a uniform manner. Assimp aims at providing a full asset conversion pipeline for use in game engines and real-time rendering systems of any kind but is not limited to this audience. URL: http://assimp.sourceforge.net/ Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2930209 rpmlint: assimp.src: W: invalid-url Source0: assimp--2.0.863-sdk.tar.bz2 - I'm repacking the source file to strip several megabytes of binary Windows DLLs we really don't need to ship. This creates a tarball (instead of the original ZIP) which is much better compressed using bzip2. assimp.x86_64: W: shared-lib-calls-exit /usr/lib64/libassimp.so.2.0.0 exit@GLIBC_2.2.5 - This is in the assert function and intended. There is no release switch to turn this off for productive builds. assimp.x86_64: W: no-manual-page-for-binary assimp - There is none assimp-devel.x86_64: W: no-documentation - Might later generate doxygen documentation, but not required for the start. 3 packages and 0 specfiles checked; 0 errors, 4 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 --- Comment #24 from Tim Niemueller 2011-03-21 19:57:25 EDT --- Thanks for applying. Maybe you can make it a 2.3.1 or something. I'm currently looking into assimp. Please let that be the last dependency for a while ;-) Yes, there are a few more things for OpenRAVE. I'll attach the patch to this ticket and happily drop it once you integrated it. I think there are no controversial things in there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 --- Comment #25 from Tim Niemueller 2011-03-21 19:58:10 EDT --- Created attachment 486706 --> https://bugzilla.redhat.com/attachment.cgi?id=486706 Patch for upstreaming by Rosen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637402] Review Request: sqlninja - A tool for SQL server injection and takeover
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637402 --- Comment #15 from Hicham HAOUARI 2011-03-21 19:51:35 EDT --- @Arun, The software would be still useful without the binaries ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689629] Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689629
Cristian Ciupitu changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|cristian.ciup...@yahoo.com
Flag||fedora-review?
--- Comment #4 from Cristian Ciupitu 2011-03-21
19:44:28 EDT ---
· MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.^[1]
gnome-tweak-tool.noarch: W: no-manual-page-for-binary gnome-tweak-tool
· MUST: The package must be named according to the Package Naming Guidelines .
OK
· MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. ^[2] .
OK
· MUST: The package must meet the Packaging Guidelines .
OK
· MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
TODO
· MUST: The License field in the package spec file must match the actual
license. ^[3]
TODO
· MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.^[4]
TODO
· MUST: The spec file must be written in American English. ^[5]
OK
· MUST: The spec file for the package MUST be legible. ^[6]
OK
· MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK
· MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. ^[7]
OK (koji scratch build)
· MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. ^[8]
N/A
· MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
· MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.^[9]
N/A
· MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. ^[10]
N/A
· MUST: Packages must NOT bundle copies of system libraries.^[11]
OK
· MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. ^[12]
N/A
· MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. ^[13]
OK
· MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)^[14]
OK
· MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. ^[15]
OK
· MUST: Each package must consistently use macros. ^[16]
OK
· MUST: The package must contain code, or permissable content. ^[17]
OK
· MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). ^[18]
OK
· MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. ^[18]
OK
· MUST: Header files must be in a -devel package. ^[19]
N/A
· MUST: Static libraries must be in a -static package. ^[20]
N/A
· MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. ^[19]
N/A
· MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} ^[21]
N/A
· MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.^[20]
N/A
· MUST: P
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 --- Comment #23 from Rosen Diankov 2011-03-21 19:42:50 EDT --- hi tim, I just patched up collada-dom with your patches (r849), thanks! I'll see if i can create a tarball within the day. OpenRAVE should already detect the COLLADA external library. Also, I just patched it OpenRAVE to also use LIB_SUFFIX (r2185). was there any other patches you created for openrave? i couldn't download the sprm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688408 --- Comment #10 from Fedora Update System 2011-03-21 19:37:28 EDT --- xfce4-cpufreq-plugin-1.0.0-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/xfce4-cpufreq-plugin-1.0.0-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688408 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688408 --- Comment #8 from Fedora Update System 2011-03-21 19:36:59 EDT --- xfce4-cpufreq-plugin-1.0.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/xfce4-cpufreq-plugin-1.0.0-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688408 --- Comment #9 from Fedora Update System 2011-03-21 19:37:22 EDT --- xfce4-cpufreq-plugin-1.0.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/xfce4-cpufreq-plugin-1.0.0-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689629] Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689629 --- Comment #3 from Michel Alexandre Salim 2011-03-21 19:19:41 EDT --- Per Cristian's suggestion on IRC, use %configure. Also, now validates desktop file. Spec URL: http://salimma.fedorapeople.org/specs/gnome/gnome-tweak-tool.spec SRPM URL: http://salimma.fedorapeople.org/specs/gnome/gnome-tweak-tool-2.91.92-2.fc15.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2930116 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689629] Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689629 --- Comment #2 from Michel Alexandre Salim 2011-03-21 18:57:35 EDT --- Apologies, I was replacing the file because I found a missing runtime requirement. File should be fixed now, or get the SRPM and noarch.rpm from Koji. Koji build result (F-15, noarch): http://koji.fedoraproject.org/koji/taskinfo?taskID=2930056 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689629] Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689629 Cristian Ciupitu changed: What|Removed |Added CC||cristian.ciup...@yahoo.com --- Comment #1 from Cristian Ciupitu 2011-03-21 18:51:59 EDT --- I think that the .src.rpm is broken: [ciupicri@hermes tmp]$ rpmlint gnome-tweak-tool-2.91.92-1.fc15.src.rpm (none): E: error while reading /tmp/gnome-tweak-tool-2.91.92-1.fc15.src.rpm: error reading package header -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689629] New: Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization https://bugzilla.redhat.com/show_bug.cgi?id=689629 Summary: Review Request: gnome-tweak-tool - A tool for advanced GNOME 3 customization Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: michel+...@sylvestre.me QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://salimma.fedorapeople.org/specs/gnome/gnome-tweak-tool.spec SRPM URL: http://salimma.fedorapeople.org/specs/gnome/gnome-tweak-tool-2.91.92-1.fc15.src.rpm Description: GNOME Tweak Tool is an application for changing the advanced settings of GNOME 3. Features: * Support shell theme change and installation * Tweak GTK+ theme * Tweak the user-interface and title bar fonts * Tweak icons in menus and buttons * Tweak behavior on laptop lid close * Tweak shell font size * Tweak file manager desktop icons * Tweak title bar click action NOTE: license is not declared. Setting the license field provisionally to GPL+ first, but I'll try and get in touch with author. Feel free to start the review in the meantime -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689627] New: Review Request: python-MyProxyClient - Python implementation of the myproxy client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-MyProxyClient - Python implementation of the myproxy client https://bugzilla.redhat.com/show_bug.cgi?id=689627 Summary: Review Request: python-MyProxyClient - Python implementation of the myproxy client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: steve.tray...@cern.ch QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://cern.ch/straylen/rpms/python-MyProxyClient/python-MyProxyClient.spec SRPM URL:http://cern.ch/straylen/rpms/python-MyProxyClient/python-MyProxyClient-1.2.2-1.fc14.src.rpm Description: Python implementation of the client interface to the MyProxy credential management service (http://grid.ncsa.illinois.edu/myproxy/) This package contains API documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 Ruediger Landmann changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||182235(FE-Legal) AssignedTo|nob...@fedoraproject.org|r.landm...@redhat.com Flag||fedora-review? --- Comment #5 from Ruediger Landmann 2011-03-21 18:18:48 EDT --- Thanks for the quick work! Actually, there's one last step we should take, and that's to include a copy of the GPL with the package. (Second dot point in comment #2) >From the email, it sounds like it's unlikely that upstream will generate a new tarball for us, so instead could you please contact them again and: * attach a copy of the GPLv1 (not any other version) to the email * ask upstream if they're OK with you including a copy of that document in the Fedora package. We've just had a similar situation arise with another perl module, and the advice above is based on what I got from Spot on legal list.[0] Cheers, Rudi [0] http://lists.fedoraproject.org/pipermail/legal/2011-March/001584.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 Eric Christensen changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #9 from Eric Christensen 2011-03-21 18:18:45 EDT --- Again, sorry for the delay in reviewing this. All MUSTs were met. It would still be a good idea to include a copy of the license in the source and, of course, documentation is always a good thing. But everything looks good! Let me know if I can help you with anything else. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=676175
Eric Christensen changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #8 from Eric Christensen 2011-03-21
18:16:31 EDT ---
OK* MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.[1]
OK* MUST: The package must be named according to the Package Naming
Guidelines .
OK* MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption. [2] .
OK* MUST: The package must meet the Packaging Guidelines .
OK* MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
OK* MUST: The License field in the package spec file must match the actual
license. [3]
NA* MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
OK* MUST: The spec file must be written in American English. [5]
OK* MUST: The spec file for the package MUST be legible. [6]
OK* MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK* MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture. [7]
OK* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
OK* MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK* MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
OK* MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. [10]
OK* MUST: Packages must NOT bundle copies of system libraries.[11]
OK* MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
OK* MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. [13]
OK* MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)[14]
OK* MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line. [15]
OK* MUST: Each package must consistently use macros. [16]
OK* MUST: The package must contain code, or permissable content. [17]
OK* MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). [18]
OK* MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. [18]
NA* MUST: Header files must be in a -devel package. [19]
NA* MUST: Static libraries must be in a -static package. [20]
NA* MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [19]
NA* MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]
OK* MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[20]
OK* MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install
[Bug 689588] Review Request: python-polygon - Handling of polygonal shapes in 2D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689588 Thomas Spura changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Status Whiteboard|NotReady| Last Closed||2011-03-21 18:08:20 --- Comment #4 from Thomas Spura 2011-03-21 18:08:20 EDT --- Next vpython version will make polygon optional. -> closing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689600] Review Request: TTFQuery - Query the system to find installed fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689600 Thomas Spura changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Last Closed||2011-03-21 18:08:48 --- Comment #1 from Thomas Spura 2011-03-21 18:08:48 EDT --- next vpython version will make this optional -> closing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682353] Review Request: wmtop - Mini graphical version of the CPU monitoring utility top
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682353 --- Comment #12 from Jason Tibbitts 2011-03-21 17:54:48 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 687987] Review Request: plymouth-theme-hot-dog - Plymouth Happy Hot Dog Theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=687987 Christoph Wickert changed: What|Removed |Added CC||cwick...@fedoraproject.org --- Comment #3 from Christoph Wickert 2011-03-21 17:51:24 EDT --- Please use %global instead of %define. Other than that the spec looks good and beefy miracle can save our souls soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689432] Review Request: collada-dom - COLLADA Document Object Model Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689432 --- Comment #1 from Tim Niemueller 2011-03-21 17:06:09 EDT --- New koji build, a dependency was wrong before (changed files in place): http://koji.fedoraproject.org/koji/taskinfo?taskID=2929514 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675646] Review Request: perl-Log-Any-Adapter - Tell Log::Any where to send its logs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675646 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Log-Any-Adapter-0.03-1 |perl-Log-Any-Adapter-0.03-1 |.fc13 |.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675646] Review Request: perl-Log-Any-Adapter - Tell Log::Any where to send its logs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675646 --- Comment #11 from Fedora Update System 2011-03-21 17:00:34 EDT --- perl-Log-Any-Adapter-0.03-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676159] Review Request: crlibm - Correctly Rounded mathematical library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676159 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System 2011-03-21 16:59:33 EDT --- crlibm-1.0-0.4.beta4.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675646] Review Request: perl-Log-Any-Adapter - Tell Log::Any where to send its logs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675646 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Log-Any-Adapter-0.03-1 |perl-Log-Any-Adapter-0.03-1 |.fc15 |.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675689] Review Request: perl-Test-Log-Dispatch - Test what you are logging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675689 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Test-Log-Dispatch-0.03 |perl-Test-Log-Dispatch-0.03 |-2.fc15 |-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675689] Review Request: perl-Test-Log-Dispatch - Test what you are logging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675689 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-Test-Log-Dispatch-0.03 |perl-Test-Log-Dispatch-0.03 |-2.fc13 |-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 669010] Review Request: libfap - C port of Ham::APRS::FAP APRS Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=669010 Fedora Update System changed: What|Removed |Added Fixed In Version|libfap-1.0-3.fc14 |libfap-1.0-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675646] Review Request: perl-Log-Any-Adapter - Tell Log::Any where to send its logs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675646 --- Comment #10 from Fedora Update System 2011-03-21 17:00:07 EDT --- perl-Log-Any-Adapter-0.03-1.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 669010] Review Request: libfap - C port of Ham::APRS::FAP APRS Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=669010 --- Comment #18 from Fedora Update System 2011-03-21 16:56:04 EDT --- libfap-1.0-3.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689588] Review Request: python-polygon - Handling of polygonal shapes in 2D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689588 Thomas Spura changed: What|Removed |Added Status Whiteboard||NotReady --- Comment #3 from Thomas Spura 2011-03-21 16:55:06 EDT --- I just send upstream a note about this and asked, if upstream can delete gpc and build a own polygon module... Leaving open, till final decision from upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675689] Review Request: perl-Test-Log-Dispatch - Test what you are logging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675689 --- Comment #10 from Fedora Update System 2011-03-21 16:55:37 EDT --- perl-Test-Log-Dispatch-0.03-2.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675689] Review Request: perl-Test-Log-Dispatch - Test what you are logging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675689 --- Comment #11 from Fedora Update System 2011-03-21 16:56:36 EDT --- perl-Test-Log-Dispatch-0.03-2.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 687987] Review Request: plymouth-theme-hot-dog - Plymouth Happy Hot Dog Theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=687987 --- Comment #2 from David Nalley 2011-03-21 16:45:44 EDT --- Source0 isn't a proper URL GPL isn't a valid license tag. Those are the only problems I see at the moment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689600] New: Review Request: TTFQuery - Query the system to find installed fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: TTFQuery - Query the system to find installed fonts https://bugzilla.redhat.com/show_bug.cgi?id=689600 Summary: Review Request: TTFQuery - Query the system to find installed fonts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: toms...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://tomspur.fedorapeople.org/review/TTFQuery.spec SRPM URL: http://tomspur.fedorapeople.org/review/TTFQuery-1.0.1-1.fc15.src.rpm Description: TTFQuery builds on the FontTools package to allow the Python programmer to accomplish a number of tasks: * query the system to find installed fonts * retrieve metadata about any TTF font file (even those not yet installed) o abstract family type o proper font name o glyph outlines * build simple metadata registries for run-time font matching scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2929820 $ rpmlint ~/rpmbuild/RPMS/noarch/TTFQuery-1.0.1-1.fc15.noarch.rpm ~/rpmbuild/SRPMS/TTFQuery-1.0.1-1.fc15.src.rpm TTFQuery.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal TTFQuery.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689588] Review Request: python-polygon - Handling of polygonal shapes in 2D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689588 --- Comment #2 from Jason Tibbitts 2011-03-21 16:48:54 EDT --- The General Polygon Clipping library is non-free and not acceptable for Fedora due to its restriction to noncommercial use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 523034] Review Request: python-setuptools_trial - Setuptools plugin that makes unit tests execute with trial instead of pyunit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523034 Toshio Ernie Kuratomi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Toshio Ernie Kuratomi 2011-03-21 16:37:40 EDT --- All blockers fixed. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689588] Review Request: python-polygon - Handling of polygonal shapes in 2D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689588 --- Comment #1 from Thomas Spura 2011-03-21 16:37:36 EDT --- https://fedorahosted.org/fpc/ticket/74 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689588] New: Review Request: python-polygon - Handling of polygonal shapes in 2D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-polygon - Handling of polygonal shapes in 2D https://bugzilla.redhat.com/show_bug.cgi?id=689588 Summary: Review Request: python-polygon - Handling of polygonal shapes in 2D Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: toms...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://tomspur.fedorapeople.org/review/python-polygon.spec SRPM URL: http://tomspur.fedorapeople.org/review/python-polygon-2.0.3-1.fc15.src.rpm Description: Polygon is a python package that handles polygons in 2D. It contains Python bindings for gpc, the excellent General Polygon Clipping Library by Alan Murta and some extensions written in C and pure Python. With Polygon you may handle complex polygonal areas in Python in a very intuitive way. Polygons are simple Python objects, clipping operations are bound to standard operators like +, -, \|, & and ^. TriStrips can be constructed from Polygons with a single statement. Functions to compute the area, center point, convex hull and much more are included. $ rpmlint ~/rpmbuild/RPMS/x86_64/python-polygon-* ~/rpmbuild/SRPMS/python-polygon-2.0.3-1.fc15.src.rpm python-polygon.x86_64: W: spelling-error %description -l en_US gpc -> GP python-polygon.x86_64: W: invalid-license LGPL python-polygon-debuginfo.x86_64: W: invalid-license LGPL python-polygon.src: W: spelling-error %description -l en_US gpc -> GP python-polygon.src: W: invalid-license LGPL 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Send a private mail to the author about the license version, for the moment it's only LGPL everywhere in the tarball. Another issue is that polygon uses a private copy of gpc, requesting a exception from FPC (will post link here). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683552 --- Comment #8 from Fedora Update System 2011-03-21 15:11:15 EDT --- mysql-connector-python-0.3.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mysql-connector-python-0.3.2-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683552 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683552 --- Comment #10 from Fedora Update System 2011-03-21 15:12:00 EDT --- mysql-connector-python-0.3.2-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mysql-connector-python-0.3.2-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683552 --- Comment #9 from Fedora Update System 2011-03-21 15:11:38 EDT --- mysql-connector-python-0.3.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mysql-connector-python-0.3.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530910] Review Request: hyena - Hyena is a library of GUI and non-GUI C# code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530910 --- Comment #8 from Claudio Rodrigo Pereyra DIaz 2011-03-21 15:04:25 EDT --- I just update to upstream version 0.5 please check spec and src.rpm Spec URL: http://elsupergomez.fedorapeople.org/SPECS/hyena.spec SRPM URL: http://elsupergomez.fedorapeople.org/SRPMS/hyena-0.5-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682353] Review Request: wmtop - Mini graphical version of the CPU monitoring utility top
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682353 Mario Blättermann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Mario Blättermann 2011-03-21 14:59:42 EDT --- New Package SCM Request === Package Name: wmtop Short Description: Mini graphical version of the CPU monitoring utility top Owners: mariobl Branches: f14 f15 InitialCC: mariobl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684006] Review Request: perl-XML-Rules - API layer for XML::Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #2 from Bill Pemberton 2011-03-21 14:56:00 EDT --- package and spec updated to address the quibbles. I use this rpm locally on EPEL-5, so yes, I'd expect to build it for EPEL-5 repo. Spec URL: http://wfp.fedorapeople.org/perl-XML-Rules.spec SRPM URL: http://wfp.fedorapeople.org/perl-XML-Rules-1.10-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573910] Review Request: dcmtk - Offis DICOM Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573910 --- Comment #26 from Per Inge Mathisen 2011-03-21 14:51:50 EDT --- It is great to see activity on this again! I tried building the src rpm on Fedora 13, and that worked, but on install I got this: bash-4.1# rpm -Uvh rpmbuild/RPMS/x86_64/dcmtk-3.6.0-2.fc13.x86_64.rpm error: Failed dependencies: libdcmdsig.so()(64bit) is needed by dcmtk-3.6.0-2.fc13.x86_64 libijg12.so()(64bit) is needed by dcmtk-3.6.0-2.fc13.x86_64 libijg16.so()(64bit) is needed by dcmtk-3.6.0-2.fc13.x86_64 libijg8.so()(64bit) is needed by dcmtk-3.6.0-2.fc13.x86_64 liblibi2d.so()(64bit) is needed by dcmtk-3.6.0-2.fc13.x86_64 Not sure why. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682353] Review Request: wmtop - Mini graphical version of the CPU monitoring utility top
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682353 --- Comment #10 from Mario Blättermann 2011-03-21 14:55:20 EDT --- (In reply to comment #9) > The package looks good. I'd just replace "cpu" with "CPU" as suggested by the > spell checker. That's not a blocker though. > OK, I will change it before I feed Koji with the Git content. Many thanks for your review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688605] Review Request: perl-WWW-RobotRules - Database of robots.txt-derived permissions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688605 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-WWW-RobotRules-6.01-1. ||fc16 Resolution||RAWHIDE Last Closed||2011-03-21 13:50:52 --- Comment #6 from Petr Pisar 2011-03-21 13:50:52 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
Red Hat Bugzilla Change Password Request
You have (or someone impersonating you has) requested to change your Red Hat Bugzilla password. To complete the change, visit the following link: https://bugzilla.redhat.com/token.cgi?t=hoSjrDm7ux&a=cfmpw If you are not the person who made this request, or you wish to cancel this request, visit the following link: https://bugzilla.redhat.com/token.cgi?t=hoSjrDm7ux&a=cxlpw If you do nothing, the request will lapse after 3 days (on March 24, 2011 at 14:29 EDT) or when you log in successfully. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 --- Comment #4 from Jan Klepek 2011-03-21 13:58:00 EDT --- license fixed, attached email from Spec URL: http://hpejakle.fedorapeople.org/packages/perl-NetPacket-SpanningTree.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/perl-NetPacket-SpanningTree-0.01-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688886] Review Request: kflickr - Standalone Flickr Uploader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=66 --- Comment #2 from Jan Klepek 2011-03-21 13:59:10 EDT --- updated Spec URL: http://hpejakle.fedorapeople.org/packages/kflickr.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/kflickr-20100817-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573910] Review Request: dcmtk - Offis DICOM Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573910 --- Comment #25 from Mario Ceresa 2011-03-21 13:48:13 EDT --- Done: http://mrceresa.fedorapeople.org/dcmtk-3.6.0-2.fc14.src.rpm http://mrceresa.fedorapeople.org/dcmtk.spec I'll give myself a pat on the shoulder now :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688597] Review Request: perl-Net-HTTP - Low-level HTTP connection (client)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688597 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Net-HTTP-6.00-1.fc16 Resolution||RAWHIDE Last Closed||2011-03-21 13:39:22 --- Comment #6 from Petr Pisar 2011-03-21 13:39:22 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688590] Review Request: perl-HTTP-Negotiate - Choose a variant to serve
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688590 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-HTTP-Negotiate-6.00-1. ||fc16 Resolution||RAWHIDE Last Closed||2011-03-21 13:34:08 --- Comment #5 from Petr Pisar 2011-03-21 13:34:08 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 554647] Review Request: wbfs-manager - Manager for Nintendo RAW File System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554647 Tom "spot" Callaway changed: What|Removed |Added Blocks||182235(FE-Legal) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688580] Review Request: perl-HTTP-Daemon - Simple HTTP server class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688580 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-HTTP-Daemon-6.00-1.fc1 ||6 Resolution||RAWHIDE Last Closed||2011-03-21 13:28:00 --- Comment #5 from Petr Pisar 2011-03-21 13:28:00 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678678] Review Request: rubygem-vte - Ruby binding of vte
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678678 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-03-21 13:26:20 --- Comment #10 from Mamoru Tasaka 2011-03-21 13:26:20 EDT --- Built, push request submitted. Thank you for the review and git procedure, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678676] Review Request: rubygem-gtksourceview2 - Ruby binding of gtksourceview-2.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678676 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-03-21 13:27:14 --- Comment #6 from Mamoru Tasaka 2011-03-21 13:27:14 EDT --- Built, push request submitted. Thank you for the review and git procedure, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676392] Review Request: foghorn - DBus signal to SNMP trap service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676392 Jesse Keating changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jesse Keating 2011-03-21 13:27:36 EDT --- Looks good. I would remove the period after the summary though, just a warning from rpmlint. I'm approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 687987] Review Request: plymouth-theme-hot-dog - Plymouth Happy Hot Dog Theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=687987 David Nalley changed: What|Removed |Added Status|NEW |ASSIGNED CC||da...@gnsa.us AssignedTo|nob...@fedoraproject.org|da...@gnsa.us Flag||fedora-review? --- Comment #1 from David Nalley 2011-03-21 12:48:09 EDT --- /me is shocked that no one has yet taken this on in the week proceeding. Allow me to do the honors for the Beefy Miracle :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688536] Review Request: perl-HTTP-Cookies - HTTP cookie jars
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688536 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-HTTP-Cookies-6.00-1.fc ||16 Resolution||RAWHIDE Last Closed||2011-03-21 13:22:08 --- Comment #5 from Petr Pisar 2011-03-21 13:22:08 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673030] Review Request: perl-Locale-US - Two letter codes for state identification in the United States and vice versa
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673030
Paul Howarth changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||p...@city-fan.org
AssignedTo|nob...@fedoraproject.org|p...@city-fan.org
Flag||fedora-review+
--- Comment #4 from Paul Howarth 2011-03-21 12:39:21 EDT ---
rpmlint output:
perl-Locale-US.noarch: W: spelling-error Summary(en_US) versa -> avers, verse,
verst
perl-Locale-US.noarch: W: spelling-error %description -l en_US versa -> avers,
verse, verst
perl-Locale-US.src: W: spelling-error Summary(en_US) versa -> avers, verse,
verst
perl-Locale-US.src: W: spelling-error %description -l en_US versa -> avers,
verse, verst
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
These warnings are due to deficiencies in the US English dictionary and can
be dismissed.
Review checklist:
- package and spec file naming OK
- package meets guidelines
- license is OK for Fedora and matches upstream
- spec file written in English and is legible
- source tarball matches upstream
- package builds fine in mock for Rawhide (x86_64)
- buildreqs OK
- no locales, libraries, devel files etc. to concern us
- package not intended to be relocatable
- directory ownership is fine
- no duplicate files
- permissions fine
- macro usage is consistent
- code, not content
- no large docs
- not a GUI app
- works fine as part of Moose test suite
Requires:
perl(:MODULE_COMPAT_5.12.3)
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
perl >= 0:5.006001
perl(Exporter)
perl(strict)
perl(warnings)
rpmlib(PayloadIsXz) <= 5.2-1
Provides:
perl(Locale::US) = 1.2
perl-Locale-US = 1.2-2.fc16
Why not ship kruft2codes.pl as %doc rather than just deleting it, since it's
mentioned in the POD?
May as well fix the mis-spellings too:
https://rt.cpan.org/Public/Bug/Display.html?id=62218
Is %{?perl_default_filter} actually needed?
No blockers here.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688659] Review Request: thunarx-python - Python bindings for the Thunar Extension Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688659 --- Comment #4 from Balaji G 2011-03-21 13:00:28 EDT --- Kevin, Thanks a lot for your exhaustive review comments and for your patience to look through my work. I have uploaded the SPEC and the SRPM to the location http://balajig8.fedorapeople.org/packages/thunarx-python.spec http://balajig8.fedorapeople.org/packages/thunarx-python-0.2.3-1.fc14.src.rpm Thanks, Cheers, - Balaji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689488] New: Review Request: vcftools - VCF file manipulation tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: vcftools - VCF file manipulation tools https://bugzilla.redhat.com/show_bug.cgi?id=689488 Summary: Review Request: vcftools - VCF file manipulation tools Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bl...@verdurin.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://verdurin.fedorapeople.org/reviews/vcftools/vcftools.spec SRPM URL: http://verdurin.fedorapeople.org/reviews/vcftools/vcftools-0.1.4a-1.fc16.src.rpm Description: A program package designed for working with VCF files, such as those generated by the 1000 Genomes Project. The aim of VCFtools is to provide methods for working with VCF files: validating, merging, comparing and calculate some basic population genetic statistics. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689488] Review Request: vcftools - VCF file manipulation tools
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=689488
--- Comment #1 from Adam Huffman 2011-03-21 12:30:53 EDT
---
There are two errors found by rpmlint:
vcftools.src:35: E: hardcoded-library-path in %{buildroot}/usr/lib/FaSlice.pm
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
vcftools.src:36: E: hardcoded-library-path in %{buildroot}/usr/lib/Vcf.pm
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
This is because some of the installation paths are hardcoded in the Makefiles,
so I had to move files in the .spec. If it's preferable to patch the Makefile,
let me know.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674188] Review Request: libzeitgeist - Library to access zeitgeist; needed by synapse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674188
--- Comment #20 from Mamoru Tasaka 2011-03-21
12:15:34 EDT ---
Again, please post (write) also the URL of new srpm every time you
upload the new one, not only the URL of your spec file.
For -3:
* %{?_isa} specific dependency
- As said in the comment 14, -devel subpackage should have
"%{name}%{?_isa} = %{version}-%{release}"
- And it is very likely that "Requires: zeitgeist" should be
%{_isa} specific.
* %check
- So please fix %check failure or rescue it so that rpmbuild
on koji succeeds.
* %doc attribute
- As said in the comment 16, "%doc" attribute on
%{_datadir}/gtk-doc/html/foo is not needed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 673116] Review Request: perl-Test-Perl-Critic-Progressive - Gradually enforce coding standards
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673116 --- Comment #2 from Petr Pisar 2011-03-21 12:15:43 EDT --- Updated package published on: Spec URL: http://ppisar.fedorapeople.org/perl-Test-Perl-Critic-Progressive/perl-Test-Perl-Critic-Progressive.spec SRPM URL: http://ppisar.fedorapeople.org/perl-Test-Perl-Critic-Progressive/perl-Test-Perl-Critic-Progressive-0.03-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
