[Bug 690328] Review Request: be - Bugs Everywhere, a distributed bug tracker

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690328

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||be-1.0.0-2.fc15
 Resolution||ERRATA
Last Closed||2011-03-30 01:40:02

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 690328] Review Request: be - Bugs Everywhere, a distributed bug tracker

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690328

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 01:39:57 EDT ---
be-1.0.0-2.fc15 has been pushed to the Fedora 15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691635] Review Request: ppm - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691635

--- Comment #10 from elad el...@doom.co.il 2011-03-30 01:58:50 EDT ---
Please note that the mobile-broadband-provider-info package contains xml files
that ppm reads to get data about your provider. rpm is not smart enough to
figure it out alone.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691894] Review Request: pyrit - A GPGPU-driven WPA/WPA2-PSK key cracker

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691894

elad el...@doom.co.il changed:

   What|Removed |Added

 CC||el...@doom.co.il

--- Comment #1 from elad el...@doom.co.il 2011-03-30 02:03:31 EDT ---
I'll do an unofficial review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691894] Review Request: pyrit - A GPGPU-driven WPA/WPA2-PSK key cracker

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691894

--- Comment #2 from elad el...@doom.co.il 2011-03-30 02:30:47 EDT ---
+ = OK
- = NA
? = issue

+ Package meets naming guidelines
+ Spec file matches base package name.
+ Spec has consistent macro usage.
+ Meets Packaging Guidelines.
? License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output. (looks like bogus output to me):
pyrit.x86_64: W: spelling-error %description -l en_US pre - per, ore, pee
pyrit.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/cpyrit/_cpyrit_cpu.so
_cpyrit_cpu.so()(64bit)
pyrit.x86_64: W: no-manual-page-for-binary pyrit
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ final provides and requires are sane

SHOULD Items:

- Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1.I'm not sure, probably I'm wrong, but GPLv3 with openssl exception is not
listed here: https://fedoraproject.org/wiki/Licensing

Not an issue, but I think you should fix it:
The hyphen after many-core in the description is unnecessary. Also I think
you should mention that this package only provide CPU support, and not GPUGPU
(there are CUDA and OpenCL support sub-packages available upstream, but can not
be used in fedora because no free driver currently implements those features)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691541] Review Request: icedtea-web - Additional Java components for OpenJDK

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691541

--- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2011-03-30 
02:36:41 EDT ---
Omair, you should set fedora-review flag to ? when starting review and to +
when package is approved. I've changed the bug status to assigned which also
must be done by the reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691997] New: Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts

https://bugzilla.redhat.com/show_bug.cgi?id=691997

   Summary: Review Request: nhn-nanum-fonts - Nanum family of
Korean TrueType fonts
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: du...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://ueno.fedorapeople.org/nhn-nanum-fonts/nhn-nanum-fonts.spec
SRPM URL:
http://ueno.fedorapeople.org/nhn-nanum-fonts/nhn-nanum-fonts-3.010-1.fc14.src.rpm
Description:
Nanum fonts are collection of commonly-used Myeongjo and Gothic Korean
font families, designed by Sandoll Communication and Fontrix. The
publisher is NHN Corporation.

Font description page:
https://fedoraproject.org/wiki/NHN_Nanum_fonts

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688777] Review Request: postfix-policyd-spf-perl - Postfix SMTPd policy server for SPF checking

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688777

--- Comment #2 from Bojan Smojver bo...@rexursive.com 2011-03-30 02:50:53 EDT 
---
Fixed install and buildroot. Man page made it into Debian
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=236701), but not yet
upstream. So, maybe in one of the follow up releases?

Thanks for reviewing!

New files here:

ftp://ftp.rexursive.com/pub/postfix-policyd-spf-perl/postfix-policyd-spf-perl.spec
ftp://ftp.rexursive.com/pub/postfix-policyd-spf-perl/postfix-policyd-spf-perl-2.007-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #24 from elad el...@doom.co.il 2011-03-30 03:11:23 EDT ---
I did another unofficial review: bug #691894

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691972] Review Request: zanata-python-client - library and client for working with Zanata server

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691972

Ding-Yi Chen dc...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|dc...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 672561] Review Request: perl-Perl-Critic-Pulp - Some add-on perlcritic policies

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672561

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review+

--- Comment #2 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 03:40:11 
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2959749
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides ~/Downloads/perl-Perl-Critic-Pulp-46-1.fc16.noarch.rpm 
perl(Perl::Critic::Policy::CodeLayout::RequireFinalSemicolon) = 46
perl(Perl::Critic::Policy::Compatibility::ConstantPragmaHash) = 46
perl(Perl::Critic::Policy::Compatibility::Gtk2Constants) = 46
perl(Perl::Critic::Policy::Compatibility::PerlMinimumVersionAndWhy) = 46
perl(Perl::Critic::Policy::Compatibility::PodMinimumVersion) = 46
perl(Perl::Critic::Policy::Compatibility::ProhibitUnixDevNull) = 46
perl(Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup) = 46
perl(Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup::Parser)  
perl(Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup) = 46
perl(Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup::Parser)  
perl(Perl::Critic::Policy::Documentation::RequireEndBeforeLastPod) = 46
perl(Perl::Critic::Policy::Miscellanea::TextDomainPlaceholders) = 46
perl(Perl::Critic::Policy::Miscellanea::TextDomainUnused) = 46
perl(Perl::Critic::Policy::Modules::ProhibitModuleShebang) = 46
perl(Perl::Critic::Policy::Modules::ProhibitPOSIXimport) = 46
perl(Perl::Critic::Policy::Modules::ProhibitUseQuotedVersion) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ConstantBeforeLt) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::NotWithCompare) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitBarewordDoubleColon) =
46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyCommas) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitFiletest_f) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitNullStatements) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitUnknownBackslash) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::RequireNumericVersion) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral) = 46
perl(Perl::Critic::Pulp) = 46
perl(Perl::Critic::Pulp::PodMinimumVersionViolation)  
perl(Perl::Critic::Pulp::PodParser)  
perl(Perl::Critic::Pulp::Utils) = 46
perl(Perl::MinimumVersion)  
perl(Pod::MinimumVersion) = 46
perl(Pod::MinimumVersion::Parser)  
perl(Pod::MinimumVersion::Report)  
perl-Perl-Critic-Pulp = 46-1.fc16

rpm -qp --requires ~/Downloads/perl-Perl-Critic-Pulp-46-1.fc16.noarch.rpm |
sort
perl = 0:5.005
perl = 0:5.006
perl(base)  
perl(constant)  
perl(Exporter)  
perl(IO::String) = 1.02
perl(List::MoreUtils) = 0.24
perl(List::Util)  
perl(:MODULE_COMPAT_5.12.3)  
perl(overload)  
perl(Perl::Critic) = 1.084
perl(Perl::Critic::Policy) = 1.084
perl(Perl::Critic::Pulp)  
perl(Perl::Critic::Pulp::PodParser)  
perl(Perl::Critic::Pulp::Utils)  
perl(Perl::Critic::Utils) = 1.100
perl(Perl::Critic::Utils::PPI)  
perl(Perl::Critic::Violation)  
perl(Pod::MinimumVersion)  
perl(Pod::Parser)  
perl(POSIX)  
perl(PPI) = 1.208
perl(PPI::Document)  
perl(Scalar::Util)  
perl(strict)  
perl(Test::More)  

[Bug 684511] Review Request: perl-DBIx-Class-Cursor-Cached - Cursor class with built-in caching support

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684511

--- Comment #5 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 04:00:48 
EDT ---
It looks like --skipdeps are not needed at the moment
http://koji.fedoraproject.org/koji/getfile?taskID=2959800name=build.log

Using --skipdeps is better than redirect to /dev/null, which is also used in
talkative Perl builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688546] Review Request: doxygenfilter - A Perl-based input filter for doxygen to allow it to be used with Perl files.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688546

--- Comment #2 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 04:23:07 
EDT ---
Also Vendor is Fedora in case we are providing it as rpm. 
From guidelines:
The Vendor tag should not be used. It is set automatically by the build
system. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688546] Review Request: doxygenfilter - A Perl-based input filter for doxygen to allow it to be used with Perl files.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688546

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com

--- Comment #1 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 04:21:27 
EDT ---
- rpmlint FAIL
rpmlint ~/Downloads/doxygenfilter-1.10-4.noarch.rpm 
W: incoherent-version-in-changelog 1.10-3 ['1.10-4', '1.10-4']
E: script-without-shebang /usr/share/perl5/vendor_perl/DoxyGen/VBFilter.pm
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines FAIL
- package must be licensed with Fedora approved license FAIL
- license field must match actual license FAIL
- text of the license in its own file must be included in %doc FAIL
- sources must match the upstream source OK
 d5be1fe6750dfc358896d5995347dc2dd6bc71fe
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2959808
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

There are few packaging errors:
 * rpmlint error must be fixed.
 * license is not GPL+. See any file in doxygen filter, where is stated same as
Perl, which was decided by our legal as GPL+ or Artistic. Problem could be that
packager of source tarball and spec file decided license as GPL. Details about
licences https://fedoraproject.org/wiki/Licensing#Good_Licenses_2
 * license is not installed in docs
 * macros in specfile are not incorrect, but the way how are they used is more
common in Mandriva. Some of them could be problematic in future, so I'll attach
patch of spec file.

The biggest problem is in my opinion license.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 691972] Review Request: zanata-python-client - library and client for working with Zanata server

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691972

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691027

--- Comment #6 from Hushan Jia h...@redhat.com 2011-03-30 04:39:09 EDT ---
Hi, I just do a informal review:
https://bugzilla.redhat.com/show_bug.cgi?id=691153#c2
Are you willing to be my sponsor?

Thanks,
Hushan

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688546] Review Request: doxygenfilter - A Perl-based input filter for doxygen to allow it to be used with Perl files.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688546

--- Comment #3 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 04:35:08 
EDT ---
Created attachment 488687
  -- https://bugzilla.redhat.com/attachment.cgi?id=488687
proposal of rewritten spec file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review+

--- Comment #1 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 04:49:16 
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2959854
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides ~/Downloads/perl-Gtk2-SourceView-1.000-1.fc16.i686.rpm 
perl(Gtk2::SourceView) = 1.000
perl-Gtk2-SourceView = 1.000-1.fc16
perl-Gtk2-SourceView(x86-32) = 1.000-1.fc16

rpm -qp --requires ~/Downloads/perl-Gtk2-SourceView-1.000-1.fc16.i686.rpm |
sort
libart_lgpl_2.so.2  
libatk-1.0.so.0  
libcairo.so.2  
libc.so.6  
libc.so.6(GLIBC_2.1.3)  
libc.so.6(GLIBC_2.4)  
libfontconfig.so.1  
libfreetype.so.6  
libgdk_pixbuf-2.0.so.0  
libgdk-x11-2.0.so.0  
libgio-2.0.so.0  
libglib-2.0.so.0  
libgmodule-2.0.so.0  
libgnomecanvas-2.so.0  
libgnomeprint-2-2.so.0  
libgnomeprintui-2-2.so.0  
libgobject-2.0.so.0  
libgthread-2.0.so.0  
libgtksourceview-1.0.so.0  
libgtk-x11-2.0.so.0  
libm.so.6  
libpango-1.0.so.0  
libpangocairo-1.0.so.0  
libpangoft2-1.0.so.0  
libpng12.so.0  
librt.so.1  
libxml2.so.2  
libz.so.1  
perl = 0:5.008
perl(Exporter)  
perl(Gnome2::Print)  
perl(Gtk2)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(warnings)  
perl(XSLoader)  
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(PayloadIsXz) = 5.2-1
rtld(GNU_HASH)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 691317] Review Request: libmash - Mash is a small library for using real 3D models within a Clutter scene

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691317

elad el...@doom.co.il changed:

   What|Removed |Added

 CC||el...@doom.co.il

--- Comment #2 from elad el...@doom.co.il 2011-03-30 04:54:16 EDT ---
I'll do an unofficial review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691317] Review Request: libmash - Mash is a small library for using real 3D models within a Clutter scene

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691317

--- Comment #3 from elad el...@doom.co.il 2011-03-30 04:58:01 EDT ---
I'll not do an unofficial review, because I can't install all the build
dependencies, mirrors give me 404 error... Sorry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678196] Review Request: perl-String-Errf - Simple sprintf-like dialect

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678196

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com
   Flag||fedora-review+

--- Comment #1 from Marcela Mašláňová mmasl...@redhat.com 2011-03-30 05:13:55 
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2959891
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides perl-String-Errf-0.006-1.fc16.noarch.rpm 
perl(String::Errf) = 0.006
perl-String-Errf = 0.006-1.fc16
rpm -qp --requires perl-String-Errf-0.006-1.fc16.noarch.rpm 
perl(:MODULE_COMPAT_5.12.3)  
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
perl(base)  
perl(Carp)  
perl(Params::Util)  
perl(Scalar::Util)  
perl(strict)  
perl(String::Formatter) = 0.102081
perl(Sub::Exporter)  
perl(Time::Piece)  
perl(warnings)  
rpmlib(PayloadIsXz) = 5.2-1

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 690580] Review Request: perl-Perl-Critic-More - Supplemental policies for Perl::Critic

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690580

--- Comment #1 from Petr Sabata psab...@redhat.com 2011-03-30 05:09:40 EDT ---
Package: perl-Perl-Critic-More
Version: 1.000
Release: 1.fc16
Sources: Perl-Critic-More-1.000.tar.gz
Patches: 
--
Package successfully built locally.
Package successfully built in mock, fedora-rawhide-x86_64.
Package successfully built in mock, fedora-rawhide-i386.
Package successfully built in koji, dist-rawhide.

MUST items:
[  OK  ] Package does NOT include pre-built binaries or libraries
[  OK  ] Spec file is legible and written in American english
[  OK  ] Package successfully builds on at least one supported primary
architecture
[  --  ] All ExcludeArch tags valid, referencing proper bug reports
[  OK  ] Package obeys FHS (with _libexecdir and /srv exceptions)
[  OK  ] No errors reported by rpmlint
[  OK  ] Changelog present and properly formatted
[  OK  ] Package does NOT include Packager, Vendor, Copyright or PreReq tags
[  OK  ] Source tags are working URLs and sources match upstream or justified
otherwise
[  OK  ] Requires correct or justified otherwise
[  OK  ] BuildRequires correct or justified otherwise
[  OK  ] All file names are in proper UTF-8 encoding
[  OK  ] All plain text failes are in proper UTF-8 encoding
[  --  ] Large documentation files are located in doc subpackage
[  OK  ] All documentation prefixed with %doc
[  OK  ] Documentation is NOT executable
[  OK  ] No files in %doc are needed at run-time
[  --  ] Compiler flags honor Fedora defaults or are justified
[  --  ] Package generates useful debuginfo packages
[  --  ] Header files are placed in devel subpackage
[  --  ] Unversioned shared libraries are placed in devel subpackage
[  --  ] Pkgconfig files are placed in devel subpackage
[  --  ] Full-versioned Requires of the base package in subpackages
[  --  ] Package calls ldconfig in post and postun sections for all
subpackages, if applicable
[  --  ] Static libraries are provided by static subpackage
[  OK  ] Package contains no static executables unless approved by FESCo
[  OK  ] Package does NOT bundle any system libraries
[  --  ] RPath not used for anything besides internal libraries
[  --  ] All config files are marked noreplace or justified otherwise
[  OK  ] No config files are located under /usr
[  --  ] Package contains a SystemV-compatible initscript
[  --  ] A GUI application installs a proper desktop file
[  --  ] All desktop files are installed by desktop-file-install or justified
otherwise
[  OK  ] Package consistently uses macros
[  --  ] makeinstall macro is used only if make install DESTDIR=%{buildroot}
does NOT work
[  --  ] Macros in Summary and description are expandable at build-time
[  --  ] globals used in place of defines
[  --  ] Locales handled correctly -- package requires gettext and uses
find_lang, if applicable
[  --  ] Scriptlets are sane
[  OK  ] Package is not relocatable unless justified
[  OK  ] Package contains only acceptable code or content
[  OK  ] Package owns all the files and directories it creates, installs and/or
uses unless those are already owned by another package
[  OK  ] files sections do NOT contain duplicate files except for licenses
[  OK  ] All files sections use defattr or justify otherwise
[  OK  ] Package does NOT cause any conflicts
[  OK  ] Package does NOT contain kernel modules
[  OK  ] Package does NOT bundle fonts or other general purpose data
[ NOTE ] Final Requires and Provides are sane

SHOULD items:
[  OK  ] The Summary does NOT end with a period
[  OK  ] Package does NOT include BuildRoot tag, clean section or buildroot
removal in install section
[  OK  ] Package should preserve files timestamps
[  OK  ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio,
diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info,
make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip,
util-linux-ng, which or xz
[  OK  ] Description does NOT consist of lines longer than 80 characters
[  --  ] Package uses parallel make
[  --  ] In case of a web application, package installs date into /usr/share
instead of /var/www
[  --  ] All patches have a comment or an upstream bug link
[  --  ] Package installs manpages for all executables
[  OK  ] Package contains check section and all tests pass
[  ??  ] Package works as expected

NOTES:
--
Filter out perl(Readonly) underspecified dependency.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691597] Review Request: libopkele - A C++ implementation of the OpenID decentralized identity system

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691597

--- Comment #4 from Hushan Jia h...@redhat.com 2011-03-30 05:11:27 EDT ---
I will do an informal review. thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #25 from elad el...@doom.co.il 2011-03-30 06:57:15 EDT ---
How many unofficial reviews do I still need to do?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 692069] New: Review Request: pps-tools - LinuxPPS user-space tools

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pps-tools - LinuxPPS user-space tools

https://bugzilla.redhat.com/show_bug.cgi?id=692069

   Summary: Review Request: pps-tools - LinuxPPS user-space tools
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mlich...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://mlichvar.fedorapeople.org/tmp/pps-tools.spec
SRPM URL:
http://mlichvar.fedorapeople.org/tmp/pps-tools-0-0.1.20100413git74c32c.fc14.src.rpm
Description: This package includes the LinuxPPS user-space tools.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 692069] Review Request: pps-tools - LinuxPPS user-space tools

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=692069

--- Comment #1 from Miroslav Lichvar mlich...@redhat.com 2011-03-30 07:06:28 
EDT ---
The -devel subpackage contains only one file, the timepps.h header and there
are no dependencies, maybe it could go to the main package?

The header file is a build requirement for ntp, chrony and gpsd packages, which
currently include their own copy of the file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 656421] Review Request: gedit-collaboration - Gedit's support for collaborative editing in gedit

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656421

Matej Cepl mc...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||CANTFIX
   Flag|needinfo?(mc...@redhat.com) |
Last Closed||2011-03-30 07:08:18

--- Comment #3 from Matej Cepl mc...@redhat.com 2011-03-30 07:08:18 EDT ---
Giving up on this. If anybody wants to take it over, my last src.rpm is
http://mcepl.fedorapeople.org/rpms/gedit-collaboration-0.0-1.0.git39f6912.fc14.src.rpm,
but versions of libraries required and available don't match, and I don't have
time to play with it anymore.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684511] Review Request: perl-DBIx-Class-Cursor-Cached - Cursor class with built-in caching support

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684511

--- Comment #6 from Ralf Corsepius rc040...@freenet.de 2011-03-30 07:29:31 
EDT ---
--skipdeps prevents Module::AutoInstall from trying to load modules from CPAN,
in cases a module is missing or an installed module is insufficient.

I.e. the purpose of --skipdeps here is to prevent M:AI from contacting CPAN and
from trying to go interactive in cases it diagnoses a package's requirements
are not fulfilled.

This package goes interactive when a package dep is missing 
(BR: perl(DB::SQLite) commented out):

+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
*** Module::AutoInstall version 1.03
*** Checking for Perl dependencies...
[Core Features]
- DBD::SQLite  ...missing. (would need 1.25)
- Test::More   ...loaded. (0.98)
- Cache::FileCache ...loaded. (0)   
- DBIx::Class  ...loaded. (0.08127 = 0.08100)
- Digest::SHA1 ...loaded. (2.13)
- Carp::Clan   ...loaded. (6.04 = 6.0)
== Auto-install the 1 mandatory module(s) from CPAN? [Y/n] y
*** Dependencies will be installed the next time you type 'make'.
(You may need to do that as the 'root' user.)
*** Module::AutoInstall configuration finished.  
Checking if your kit is complete...
Looks good
Warning: prerequisite DBD::SQLite 1.25 not found.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680593] Review Request: perl-Browser-Open - Open a browser in a given URL

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680593

Petr Sabata psab...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||psab...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #26 from Hans de Goede hdego...@redhat.com 2011-03-30 07:59:29 
EDT ---
(In reply to comment #21)
 The problem with packaging software with dead upstream is that I'll have to
 handle all bugs myself, and I don't know enough C or C++.
 I'm trying to find a way to make stopmotion use gstreamer instead of vgrabbj,
 but I haven't succeeded yet.  
 Although I use stopmotion and it works well for my usage, it has many bugs and
 problems. I would fork it an continue working on it (I have a lot of ideas on
 how to improve it) but I don't have the programming skills to do so.
 
 Therefore I think it's better if I'll drop vgrabbj (which is only used for
 stopmotion) and stopmotion...

Ok, that (dropping them) is fine with me.

(In reply to comment #25)
 How many unofficial reviews do I still need to do?

Hi, none you've done plenty! Sorry if I've been unclear about that. As said in
comment #20 I hope to make time to do an official review of gnome thumbnailer
soon, and I'll look at your unofficial reviews then too!

The only thing we are waiting for atm is for me to have / make some time for
this.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #27 from elad el...@doom.co.il 2011-03-30 08:07:48 EDT ---
(In reply to comment #26)
 (In reply to comment #21)
  The problem with packaging software with dead upstream is that I'll have to
  handle all bugs myself, and I don't know enough C or C++.
  I'm trying to find a way to make stopmotion use gstreamer instead of 
  vgrabbj,
  but I haven't succeeded yet.  
  Although I use stopmotion and it works well for my usage, it has many bugs 
  and
  problems. I would fork it an continue working on it (I have a lot of ideas 
  on
  how to improve it) but I don't have the programming skills to do so.
  
  Therefore I think it's better if I'll drop vgrabbj (which is only used for
  stopmotion) and stopmotion...
 
 Ok, that (dropping them) is fine with me.
 
 (In reply to comment #25)
  How many unofficial reviews do I still need to do?
 
 Hi, none you've done plenty! Sorry if I've been unclear about that. As said in
 comment #20 I hope to make time to do an official review of gnome thumbnailer
 soon, and I'll look at your unofficial reviews then too!
 
 The only thing we are waiting for atm is for me to have / make some time for
 this.
 
 Regards,
 
 Hans

Thanks! ☺

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688777] Review Request: postfix-policyd-spf-perl - Postfix SMTPd policy server for SPF checking

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688777

--- Comment #3 from Carl Thompson fed...@red-dragon.com 2011-03-30 09:15:07 
EDT ---
Unable to retreive src rpm:

Connecting to ftp.rexursive.com|150.101.121.179|:21... connected.
Logging in as anonymous ... 
Error in server greeting.
Retrying.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

--- Comment #2 from Michal Ambroz re...@seznam.cz 2011-03-30 09:22:55 EDT ---
Hello Carl,
thank you for feedback. I address the issues and upload new package at the
evening.

? MUST: The package MUST successfully compile and build into binary rpms on at
Sorry for that - I will review dev dependencies once again.

- MUST: If the package is designed to be relocatable, the packager must state
MA: Packageis not designed as relocatable and doesn't contain Prefix


? MUST: A package must own all directories that it creates. If it does not
I will add dir %{_datadir}/openvas. Expect modified version uploaded this
evening.
I will not change to openvas-%{version} as the directory is used by other
openvas
packages as well and there is not a stong link to the version


- MUST: Header files must be in a -devel package.
there are no header files


- MUST: Static libraries must be in a -static package.
there are no static libraries
main binary openvasmd is linked dynamically


- MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
not applicable

- MUST: In the vast majority of cases, devel packages must require the base
not applicable - this is not devel package

- MUST: Packages must NOT contain any .la libtool archives, these must be
not applicable - doesn't contain .la archives

- MUST: Packages containing GUI applications must include a %{name}.desktop
not applicable - doesn't contain GUI application

? SHOULD: If the source package does not include license text(s) as a separate
Not applicable - the package does include license text

- SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
Not applicable - translation is not available now.

- SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
Not applicable - this is standalone module of openvas and is not tightly
limited for usage of all packages of the same version. 
Version specific requirement for compiled library is computed automatically
during
build as recommended by the packagin guideline:
Packages must not contain explicit Requires on libraries except when
absolutely necessary. 

- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
not applicable - .pc files not included in the binary package

- SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
I will add as this dependency was not detected by RPM, it is within /usr/bin
and explicit linking whole library is prohibited by the packaging guideline
Requires:   /usr/bin/xsltproc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 692131] Review Request: sflphone - SIP/IAX2 compatible enterprise-class softphone for multi-way conferencing

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=692131

PRABIN KUMAR DATTA linux.n@gmail.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 561484] Review Request: jruby - Pure Java implementation of the Ruby interpreter

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561484

Bug 561484 depends on bug 691979, which changed state.

Bug 691979 Summary: Update Request: Update felix-osgi-core to version to  
=1.5.0
https://bugzilla.redhat.com/show_bug.cgi?id=691979

   What|Old Value   |New Value

 Resolution||WONTFIX
 Status|NEW |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691541] Review Request: icedtea-web - Additional Java components for OpenJDK

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691541

Omair Majid oma...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review?

--- Comment #5 from Omair Majid oma...@redhat.com 2011-03-30 10:36:20 EDT ---
(In reply to comment #4)
 Omair, you should set fedora-review flag to ? when starting review and to +
 when package is approved. I've changed the bug status to assigned which also
 must be done by the reviewer.

Sorry, I wasnt aware of that. Done now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

Thomas Moschny thomas.mosc...@gmx.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Thomas Moschny thomas.mosc...@gmx.de 2011-03-30 10:57:10 
EDT ---
Many thanks for the review!

New Package SCM Request
===
Package Name: perl-Gtk2-SourceView
Short Description: Perl wrappers for the GtkSourceView widget
Owners: thm
Branches: f13 f14 f15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

--- Comment #8 from Michal Schmidt mschm...@redhat.com 2011-03-30 11:09:48 
EDT ---
Looks quite good to me. I am still worried about the optflags though. I do not
think getting them from Qt is sufficient.
Consider a situation when standard Fedora optflags change and a mass-rebuild is
done to apply the change to all packages. I don't think in such a rebuild
anything would guarantee that qconf is built after Qt. So it might end up still
using the old optflags.
Or a simpler case - someone might reasonably put custom optflags into his
~/.rpmmacros and then rebuild the package expecting his flags to apply. If the
build used Qt's optflags instead, it would not work as expected.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691317] Review Request: libmash - Mash is a small library for using real 3D models within a Clutter scene

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691317

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||michel+...@sylvestre.me
 AssignedTo|nob...@fedoraproject.org|michel+...@sylvestre.me
   Flag||fedora-review?

--- Comment #4 from Michel Alexandre Salim michel+...@sylvestre.me 2011-03-30 
11:12:26 EDT ---
Will take the review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691027

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

 CC||michel+...@sylvestre.me
   Flag||needinfo?(fabian@bernewirel
   ||ess.net)

--- Comment #7 from Michel Alexandre Salim michel+...@sylvestre.me 2011-03-30 
11:20:28 EDT ---
Fabian, are you doing a formal review and sponsoring? Just checking, because
the review flag is still not set. Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684429] Review Request: linux-wbfs-manager - A WBFS manager for Linux using GTK+

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684429

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 CC||l...@jcomserv.net
   Flag|needinfo?(l...@jcomserv.net |
   |)   |

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-03-30 11:27:00 EDT ---
WRT the name, I'd go with wbfs-manager, don't rename the binary, but go with
WBFS Manager in the .desktop file which is missing and is needed if this is a
graphical application, which it seems to be. 

It might also be nice to change the Description as follows from:

This is yet another graphic WBFS manager for Linux. It uses libwbfs from 
Kwiirk and caristat (available from the authors at 
http://github.com/kwiirk/wbfs/tree/master). 


to:

This is yet another graphic WBFS(Explode acronym here so we know what is stands
for) manager for Linux. It uses libwbfs from 
Kwiirk and caristat (available from the authors at 
http://github.com/kwiirk/wbfs/tree/master).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 613001] Review Request: Heimdal - Alternative Kerberos implementation

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=613001

--- Comment #25 from Orion Poplawski or...@cora.nwra.com 2011-03-30 11:25:01 
EDT ---
* Wed Mar 30 2011 Orion Poplawksi or...@cora.nwra.com - 1.4.1rc2-2
- Move includes to /usr/include/heimdal
- Use more macros in configure command

http://www.cora.nwra.com/~orion/fedora/heimdal-1.4.1rc2-1.fc14.src.rpm
http://www.cora.nwra.com/~orion/fedora/heimdal.spec

Interesting that krb5-appl-clients uses /usr/kerberos still.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670127

Bill Nottingham nott...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #17 from Bill Nottingham nott...@redhat.com 2011-03-30 11:40:24 
EDT ---
OK, that works for me. Lucas - if you want to slap a GPLv3 copyright
boilerplate on some of the other source files, it would make the situation
cleaner for future releases.

In any case, approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632874] Review Request: freedup - Links substantially identical, duplicate files to save file system space

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632874

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 CC||l...@jcomserv.net

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-03-30 11:36:57 EDT ---
The GPL+ tag is OK if that's what's really the case.

WRT the patent-encumbered media files, they are expressly forbidden:

https://fedoraproject.org/wiki/Packaging/Guidelines#Code_Vs_Content

Remove and build from a modified tarball to prevent redistribution in the SRPM:

https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670127

Bill Nottingham nott...@redhat.com changed:

   What|Removed |Added

 AssignedTo|mcla...@redhat.com  |nott...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

--- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2011-03-30 11:57:56 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 656421] Review Request: gedit-collaboration - Gedit's support for collaborative editing in gedit

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656421

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 Blocks||201449(FE-DEADREVIEW)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688035] Review Request: perl-CHI - Unified cache handling interface

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688035

--- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2011-03-30 11:58:12 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678196] Review Request: perl-String-Errf - Simple sprintf-like dialect

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678196

--- Comment #2 from Iain Arnell iarn...@gmail.com 2011-03-30 12:11:25 EDT ---
New Package SCM Request
===
Package Name: perl-String-Errf
Short Description: Simple sprintf-like dialect
Owners: iarnell
Branches: f13 f14 f15
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678196] Review Request: perl-String-Errf - Simple sprintf-like dialect

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678196

Iain Arnell iarn...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

--- Comment #3 from Carl Thompson fed...@red-dragon.com 2011-03-30 12:13:03 
EDT ---
the - ones you don't have to worry about because they are not applicable, only
the ? ones.

Just update the bug when you get the dependencies tied up and get a new rpm and
spec up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

--- Comment #21 from Carl Thompson fed...@red-dragon.com 2011-03-30 12:24:02 
EDT ---
Package Change Request
==
Package Name: perl-Net-SSH-Expect
New Branches: el5 el6
Owners: redragon

Extending to epel 5/6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

Carl Thompson fed...@red-dragon.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678196] Review Request: perl-String-Errf - Simple sprintf-like dialect

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678196

--- Comment #3 from Jason Tibbitts ti...@math.uh.edu 2011-03-30 12:42:27 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

--- Comment #22 from Jason Tibbitts ti...@math.uh.edu 2011-03-30 12:42:47 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691027

Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag|needinfo?(fabian@bernewirel |
   |ess.net)|

--- Comment #8 from Fabian Affolter fab...@bernewireless.net 2011-03-30 
13:33:07 EDT ---
Well, I'm not a sponsor. So the review is informal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

--- Comment #10 from Ivan Romanov dr...@land.ru 2011-03-30 15:49:28 EDT ---
Also you can see into psi.spec. It don't use %{optflags} too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688922] Review Request: python-cli - A CLI construction toolkit for Python

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688922

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 16:00:26 EDT ---
python-cli-1.1-1.fc14 has been pushed to the Fedora 14 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 565949] Review Request: perl-VOMS-Lite - Perl extension for VOMS Attribute certificate creation

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565949

--- Comment #33 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 15:55:22 EDT ---
perl-VOMS-Lite-0.14-1.fc14 has been pushed to the Fedora 14 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683552

--- Comment #12 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 15:55:43 EDT ---
mysql-connector-python-0.3.2-2.fc13 has been pushed to the Fedora 13 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 565949] Review Request: perl-VOMS-Lite - Perl extension for VOMS Attribute certificate creation

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565949

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||perl-VOMS-Lite-0.14-1.fc14
 Resolution||ERRATA
Last Closed||2011-03-30 15:55:31

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683552

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||mysql-connector-python-0.3.
   ||2-2.fc13
 Resolution||ERRATA
Last Closed||2011-03-30 15:55:48

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683552

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 16:02:34 EDT ---
mysql-connector-python-0.3.2-2.fc14 has been pushed to the Fedora 14 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683552] Review Request: mysql-connector-python - MySQL Connector/Python

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683552

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|mysql-connector-python-0.3. |mysql-connector-python-0.3.
   |2-2.fc13|2-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688663] Review Request: PyXB - Python XML Schema Bindings

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688663

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 16:04:01 EDT ---
PyXB-1.1.2-1.fc14 has been pushed to the Fedora 14 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

--- Comment #11 from Michal Schmidt mschm...@redhat.com 2011-03-30 16:16:22 
EDT ---
I had a look at the generated Makefile after ./configure. It seems that passing
the optflags is easy. Just do:

make %{?_smp_mflags} CFLAGS=%{optflags} CXXFLAGS=%{optflags}

(If there's only C++ code, then CFLAGS can be dropped, but I'd leave it there
just in case.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

--- Comment #12 from Michal Schmidt mschm...@redhat.com 2011-03-30 16:20:17 
EDT ---
(In reply to comment #9)
 Anyway if i use qconf for creating Makefile i haven't way to specify opt flags
 for my project. And in that case I need to add the same feature into qconf.
 What say?

It does not allow overriding of CFLAGS and CXXFLAGS? That would be a problem
indeed. But it's out of the scope of this package review.

(In reply to comment #10)
 Also you can see into psi.spec. It don't use %{optflags} too.

You have found a bug in psi.spec then :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 692257] New: Review Request: oct2spec - Python script to generate Octave package spec file

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: oct2spec - Python script to generate Octave package 
spec file

https://bugzilla.redhat.com/show_bug.cgi?id=692257

   Summary: Review Request: oct2spec - Python script to generate
Octave package spec file
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: or...@cora.nwra.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://www.cora.nwra.com/~orion/fedora/oct2spec.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/oct2spec-1.0.0-1.fc14.src.rpm
Description:
oct2spec is a small python tool that generates spec file for Octave pacakges.
It can work from a package name, URL, or a tarball.
oct2spec provides oct2rpm which generates rpm for Octave packages using the 
oct2spec API.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-03-30 
17:34:49 EDT ---
perl-Gtk2-SourceView-1.000-1.fc14 has been submitted as an update for Fedora
14.
https://admin.fedoraproject.org/updates/perl-Gtk2-SourceView-1.000-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

--- Comment #4 from Fedora Update System upda...@fedoraproject.org 2011-03-30 
17:34:34 EDT ---
perl-Gtk2-SourceView-1.000-1.fc15 has been submitted as an update for Fedora
15.
https://admin.fedoraproject.org/updates/perl-Gtk2-SourceView-1.000-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-03-30 
17:34:42 EDT ---
perl-Gtk2-SourceView-1.000-1.fc13 has been submitted as an update for Fedora
13.
https://admin.fedoraproject.org/updates/perl-Gtk2-SourceView-1.000-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691027

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|michel+...@sylvestre.me
   Flag||fedora-review?

--- Comment #9 from Michel Alexandre Salim michel+...@sylvestre.me 2011-03-30 
17:43:44 EDT ---
Thanks; taking it then

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 683150] Review Request: yad - Display graphical dialogs from shell scripts or command line

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683150

--- Comment #4 from Elder Marco elderma...@gmail.com 2011-03-30 18:02:32 EDT 
---
Updated (new upstream release):

SPEC URL:
http://eldermarco.fedorapeople.org/files/specs/yad.spec

SRPM URL:
http://eldermarco.fedorapeople.org/files/srpms/yad-0.10.0-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 658164] Review Request: python-asciitable - Extensible ASCII table reader and writer

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=658164

--- Comment #3 from Sergio Pascual sergio.pa...@gmail.com 2011-03-30 18:14:59 
EDT ---
A python3 package would require python3-numpy, that doesn't exist AFAIK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688777] Review Request: postfix-policyd-spf-perl - Postfix SMTPd policy server for SPF checking

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688777

--- Comment #4 from Bojan Smojver bo...@rexursive.com 2011-03-30 18:22:02 EDT 
---
(In reply to comment #3)
 Unable to retreive src rpm:
 
 Connecting to ftp.rexursive.com|150.101.121.179|:21... connected.
 Logging in as anonymous ... 
 Error in server greeting.
 Retrying.

Sorry, my ISP was having some trouble. Please give it another try.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 692281] New: Review Request: hotot - Lightweight open source micro blogging client

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hotot -  Lightweight  open source micro blogging 
client

https://bugzilla.redhat.com/show_bug.cgi?id=692281

   Summary: Review Request: hotot -  Lightweight  open source
micro blogging client
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: methe...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://sundaram.fedorapeople.org/packages/hotot.spec
SRPM URL:
http://sundaram.fedorapeople.org/packages/hotot-0.9.5-1.20110331hg.fc15.src.rpm

Description: 
Hotot, is a lightweight  open source micro blogging client, coding using 
Python language and designed for Linux.  It depends less but supports more. 

Features:
   * OAuth and Basic Auth is supported.
   * Socks Proxy and Http Proxy.
   * Support API Proxy.
   * Support Twitter Search and content filter.
   * Keyboard shortcuts.
   * Extension System.
   * Native notify system. it supports Gnome  KDE SC.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

--- Comment #4 from Michal Ambroz re...@seznam.cz 2011-03-30 19:05:48 EDT ---
Hello,
here is the updated package:

Spec URL: http://rebus.fedorapeople.org/SPECS/openvas-manager.spec
SRPM URL:
http://rebus.fedorapeople.org/SRPMS/openvas-manager-2.0.2-2.fc14.src.rpm

Thank you
Michal Ambroz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670127

Cosimo Cecchi ccec...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #18 from Cosimo Cecchi ccec...@redhat.com 2011-03-30 19:46:25 EDT 
---
New Package SCM Request
===
Package Name: the-board
Short Description: A space for placing daily records in your GNOME desktop
Owners: cosimoc
Branches: f15
InitialCC: cosimoc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

--- Comment #5 from Carl Thompson fed...@red-dragon.com 2011-03-30 19:58:05 
EDT ---
Unable to retrieve src.rpm

rpmlint returns a warning so you know:

rpmlint openvas-manager.spec 
openvas-manager.spec:26: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab:
line 1)
openvas-manager.spec: W: invalid-url Source0:
http://wald.intevation.org/frs/download.php/858/openvas-manager-2.0.2.tar.gz
urlopen error timed out
0 packages and 1 specfiles checked; 0 errors, 2 warnings.


You used many tabs but on line 26 you used spaces.  Not a blocker in my opinion
but we do need to be able to pull down the src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

--- Comment #23 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 20:04:02 EDT ---
perl-Net-SSH-Expect-1.09-5.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/perl-Net-SSH-Expect-1.09-5.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

--- Comment #24 from Fedora Update System upda...@fedoraproject.org 
2011-03-30 20:04:10 EDT ---
perl-Net-SSH-Expect-1.09-5.el5 has been submitted as an update for Fedora EPEL
5.
https://admin.fedoraproject.org/updates/perl-Net-SSH-Expect-1.09-5.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691972] Review Request: zanata-python-client - library and client for working with Zanata server

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691972

--- Comment #1 from Ding-Yi Chen dc...@redhat.com 2011-03-30 20:48:27 EDT ---
1. In Field Summary: Replace Flies with Zanata
2. In Field URL: (optional) you may consider use github project page of
zanata-python-client
3. Duplicated: Requires: python-httplib2, please remove the unneeded one.
4. For users who have installed flies-python-client, we need Provides and
Obsoletes to helping them to do the conversion. Specifically, add two
following lines:

   Provides:   flies-python-client = %{version}-%{release}
   Obsoletes:  flies-python-client  1.3

5. In changelog section, both version and release should be provided:
   That is,  1.2.0-1, not 1.2.0

Regards.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 670127] Review Request: the-board - A space for placing daily records in your GNOME desktop

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670127

--- Comment #19 from Jason Tibbitts ti...@math.uh.edu 2011-03-30 20:52:38 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662604

--- Comment #21 from Truong Anh Tuan tua...@iwayvietnam.com 2011-03-30 
21:01:37 EDT ---
Thanks for your helps, Daiki Ueno.
My submitted SCM request has been approved. However, I will submit a change
request soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

--- Comment #13 from Ivan Romanov dr...@land.ru 2011-03-30 21:29:44 EDT ---
I don't shure that it proper to give %{opflags} for Makefile. 
I have tryed to use make %{?_smp_mflags} CFLAGS=%{optflags}
CXXFLAGS=%{optflags} and get error.
+ make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' 'CXXFLAGS=-O2
-g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic'
g++ -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore
-I/usr/include/QtXml -I/usr/include -I. -o stringhelp.o src/stringhelp.cpp
g++ -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore
-I/usr/include/QtXml -I/usr/include -I. -o qconf.o src/qconf.cpp
src/qconf.cpp: In function 'int main(int, char**)':
src/qconf.cpp:1327:22: error: 'DATADIR' was not declared in this scope
make: *** [qconf.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.PI7KfG (%build)

Also I compared CXXFLAGS and %{opflags}. It's different. 
[taurus@lix qconf-1.4]$ grep CXXFLAGS Makefile 
CXXFLAGS  = -pipe -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fstack-protect
[taurus@lix qconf-1.4]$ rpm -E '%{optflags}'
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691972] Review Request: zanata-python-client - library and client for working with Zanata server

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691972

--- Comment #2 from Ding-Yi Chen dc...@redhat.com 2011-03-30 22:03:39 EDT ---
6. It's good to keep flies as a command, just make it a wrapper to execute
zanata

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678196] Review Request: perl-String-Errf - Simple sprintf-like dialect

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678196

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678196] Review Request: perl-String-Errf - Simple sprintf-like dialect

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678196

--- Comment #4 from Fedora Update System upda...@fedoraproject.org 2011-03-30 
23:08:01 EDT ---
perl-String-Errf-0.006-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-String-Errf-0.006-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684511] Review Request: perl-DBIx-Class-Cursor-Cached - Cursor class with built-in caching support

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684511

--- Comment #7 from Iain Arnell iarn...@gmail.com 2011-03-30 23:41:21 EDT ---
Upstream agrees that DBIx::Class = 0.08124 is indeed a requirement for this
package, and released new version with the necessary change.


Spec URL:
http://fedorapeople.org/~iarnell/review/perl-DBIx-Class-Cursor-Cached.spec
SRPM URL:
http://fedorapeople.org/~iarnell/review/perl-DBIx-Class-Cursor-Cached-1.001001-1.fc16.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2962504

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684416] Review Request: perl-Gtk2-SourceView - Perl wrappers for the GtkSourceView widget

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684416

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-03-30 
23:52:36 EDT ---
perl-Gtk2-SourceView-1.000-1.fc15 has been pushed to the Fedora 15 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684511] Review Request: perl-DBIx-Class-Cursor-Cached - Cursor class with built-in caching support

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684511

--- Comment #8 from Iain Arnell iarn...@gmail.com 2011-03-30 23:53:56 EDT ---
(In reply to comment #6)
 --skipdeps prevents Module::AutoInstall from trying to load modules from CPAN,
 in cases a module is missing or an installed module is insufficient.
 
 I.e. the purpose of --skipdeps here is to prevent M:AI from contacting CPAN 
 and
 from trying to go interactive in cases it diagnoses a package's requirements
 are not fulfilled.
 
 This package goes interactive when a package dep is missing 
 (BR: perl(DB::SQLite) commented out):

And with f13 CPAN.pm, it doesn't just go interactive; CPAN will go through its
setup process and under mock, gets stuck in a loop (when asking for CPAN
mirror, if memory serves).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 613001] Review Request: Heimdal - Alternative Kerberos implementation

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=613001

--- Comment #26 from Ken Dreyer ktdre...@ktdreyer.com 2011-03-31 00:13:51 EDT 
---

(In reply to comment #23)
 - Heimdal installs a couple items in different locations than MIT does (e.g.
 /usr/sbin/kadmin vs. /usr/bin/kadmin).  Should these be aligned?

Yeah, kadmin and ktutil can move from /usr/sbin to /usr/bin. These don't
require local root access, and this matches krb5-workstation's layout.

(In reply to comment #25)
 * Wed Mar 30 2011 Orion Poplawksi or...@cora.nwra.com - 1.4.1rc2-2

Thanks. We can also now drop Source4 and 5, heimdal.sh and heimdal.csh, from
profile.d in heimdal-libs.

I'm looking over http://fedoraproject.org/wiki/Packaging:Alternatives, and I
guess if we ever want this to work fully we'll need nalin to agree to use
alternatives in MIT as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688035] Review Request: perl-CHI - Unified cache handling interface

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688035

--- Comment #11 from Ralf Corsepius rc040...@freenet.de 2011-03-31 00:19:16 
EDT ---
Package has been imported and been built for rawhide.

All other release will have to wait until Fedora QA's delay queue releases
other packages this package depends upon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662604

--- Comment #22 from Fedora Update System upda...@fedoraproject.org 
2011-03-31 01:14:53 EDT ---
ibus-unikey-0.5.1-5.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ibus-unikey-0.5.1-5.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662604

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662604

--- Comment #23 from Fedora Update System upda...@fedoraproject.org 
2011-03-31 01:16:13 EDT ---
ibus-unikey-0.5.1-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ibus-unikey-0.5.1-5.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 687942] Review Request: mysql-sandbox - Quick painless install of side by side MySQL server in isolation

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=687942

--- Comment #5 from Andrew Garner andrew.gar...@rackspace.com 2011-03-31 
01:19:52 EDT ---
I ran into an obscure conflict with this mysql-sandbox rpm and another
fedora/rhel package:
# rpm -Uhv mysql-sandbox-3.0.17-3.el5.noarch.rpm 
Preparing...### [100%]
file /usr/bin/sb from install of mysql-sandbox-3.0.17-3.el5.noarch
conflicts with file from package lrzsz-0.12.20-22.1.x86_64

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691997] Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691997

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-03-31 01:54:48 EDT 
---
Review:
+ koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=2962531
+ source verified as (sha1sum)
1cbfffdf8e5f81915642340560fb2ca7c1d08ef5  NanumFont_TTF_ALL.zip
1cbfffdf8e5f81915642340560fb2ca7c1d08ef5  ../SOURCES/NanumFont_TTF_ALL.zip
+ packaging looks fine.

Suggestion
1) If -common subpackage does not contain any files then it should be dropped.
2) Also, NanumPen.ttf and NanumBrush.ttf fonts contain 1.100 version while
other fonts have 3.010 version. We can also create versioned subpackages for
those 2 fonts.
3) If this is going to be packaged for Fedora 13 onwards then drop %clean
section and cleanup of buildroot in %install.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 691276] Review Request: thai-arundina-fonts - Thai fonts aiming at Latin glyph size compatibility

2011-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691276

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-03-31 01:56:27 EDT 
---
Review:
+ koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=2962502
+ source verified as (sha1sum)
01222656c139ce973f0778826fc05eafc7985843  thaifonts-arundina-0.1.2.tar.gz
01222656c139ce973f0778826fc05eafc7985843 
../SOURCES/thaifonts-arundina-0.1.2.tar.gz
+ packaging looks fine.

Suggestion
1) If this is going to be packaged for Fedora 13 onwards then drop %clean
section and cleanup of buildroot in %install.
2) fontconfig files should be added.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >