[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693425 --- Comment #21 from Panos Christeas 2011-04-11 03:08:04 EDT --- ACK. The remarks are being considered, as can be seen at: http://git.hellug.gr/?p=xrg/openerp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=695022
Fabian Affolter changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #3 from Fabian Affolter 2011-04-11
03:09:37 EDT ---
Just some quick comments:
- The website and the LICENSE.txt claims that the license is LGPL and not GPL.
- There are examples in the source. Wouldn't it be a good idea to put those
examples in a subpackage?
- The '%{!?python_sitearch:...' line is not needed.
- I don't think that console.py needs 755. Removing the shebang can calm
rpmlint down.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694950] Review Request: torrent-search - A torrent searching graphical application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694950 --- Comment #2 from Praveen Kumar 2011-04-11 03:22:12 EDT --- Thanks for suggestions, Here is updated spec and srpm urls Spec URL: http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search.spec SRPM URL: http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search-0.9.2-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695232] Review Request: go_filebench - A model based file system workload generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695232 Hushan Jia changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695232] Review Request: go_filebench - A model based file system workload generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695232 Hushan Jia changed: What|Removed |Added Flag||needinfo?(michel+fdr@sylves ||tre.me) --- Comment #3 from Hushan Jia 2011-04-11 03:59:12 EDT --- Hi Michel, This is my second package, could you please help to review this? Thanks, Hushan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619355] Review Request: python26-numpy - A fast multidimensional array facility for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619355 --- Comment #14 from Steve Traylen 2011-04-11 04:02:10 EDT --- Sorry, any comment. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #31 from elad 2011-04-11 04:18:42 EDT --- Done. New SRPM: http://elad.fedorapeople.org/gnome-exe-thumbnailer-0.7-1.fc15.src.rpm I had to change %u to %i in the thumbnailer file to make it work, here is the new file: http://elad.fedorapeople.org/gnome-exe-thumbnailer.thumbnailer SPEC remains http://elad.fedorapeople.org/gnome-exe-thumbnailer.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676853] Review Request: goocanvasmm2 - goocanvasmm2 goodness for Gtk3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676853 Haïkel Guémar changed: What|Removed |Added Status|NEW |CLOSED Resolution||CURRENTRELEASE Last Closed||2011-04-11 05:20:45 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 677300] Review Request: gtksourceviewmm3 - A C++ wrapper for gtksourceview3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677300 Haïkel Guémar changed: What|Removed |Added Status|NEW |CLOSED Resolution||CURRENTRELEASE Last Closed||2011-04-11 05:20:20 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695232] Review Request: go_filebench - A model based file system workload generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695232 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|michel+...@sylvestre.me Flag|needinfo?(michel+fdr@sylves |fedora-review? |tre.me) | --- Comment #4 from Michel Alexandre Salim 2011-04-11 05:54:34 EDT --- Sure; taking this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674008] Review Request: openrave - Open Robotics Automation Virtual Environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 --- Comment #38 from Rosen Diankov 2011-04-11 06:06:50 EDT --- We've started getting all release/package related scripts inside the 'release' folder: https://openrave.svn.sourceforge.net/svnroot/openrave/trunk/release currently there is a windows installer and publishing to sourceforge. i'm not sure how the fedora core stuff works, but i would be more than happy to put a script that generates the fedora core spec, rpm files, and publishes it to fedora core. i can give you commit permissions so you can manage this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693664] Review Request: supybot-gribble - Cross-platform support bot based on supybot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693664 --- Comment #5 from David Riches 2011-04-11 06:10:01 EDT --- Thanks for this.. Sure, I think the package name suggested makes loads of sense. Also, "install" works for me As far as the conflict is concerned, because gribble is an enhanced supybot, many of the plugins located in /usr/lib/python*/site-packages/supybot/plugins/* are different/patched. So it does indeed conflict. There's also no reason you would want both on the same system, apart from possibly testing the differences I suppose. Sadly, renaming supybot just wouldn't cut it ;-( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645484] Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645484 David Riches changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from David Riches 2011-04-11 06:07:19 EDT --- New Package SCM Request === Package Name: django-mptt Short Description: Utilities for implementing Modified Preorder Tree Traversal Owners: dcr226 Branches: f13 f14 f15 el5 el6 InitialCC: herlo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695281] New: Review Request: perl-Devel-EnforceEncapsulation - Find access violations to blessed objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Devel-EnforceEncapsulation - Find access violations to blessed objects https://bugzilla.redhat.com/show_bug.cgi?id=695281 Summary: Review Request: perl-Devel-EnforceEncapsulation - Find access violations to blessed objects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: p...@city-fan.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Devel-EnforceEncapsulation/branches/fedora/perl-Devel-EnforceEncapsulation.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Devel-EnforceEncapsulation/perl-Devel-EnforceEncapsulation-0.50-3.fc16.src.rpm Description Encapsulation is the practice of creating subroutines to access the properties of a class instead of accessing those properties directly. The advantage of good encapsulation is that the author is permitted to change the internal implementation of a class without breaking its usage. Object-oriented programming in Perl is most commonly implemented via blessed hashes. This practice makes it easy for users of a class to violate encapsulation by simply accessing the hash values directly. Although less common, the same applies to classes implemented via blessed arrays, scalars, filehandles, etc. This module is a hack to block those direct accesses. If you try to access a hash value of an object from its own class, or a superclass or subclass, all goes well. If you try to access a hash value from any other package, an exception is thrown. The same applies to the scalar value of a blessed scalar, entry in a blessed array, etc. To be clear: this class is NOT intended for strict enforcement of encapsulation. If you want bullet-proof encapsulation, use inside-out objects or the like. Instead, this module is intended to be a development or debugging aid in catching places where direct access is used against classes implemented as blessed hashes. To repeat: the encapsulation enforced here is a hack and is easily circumvented. Please use this module for good (finding bugs), not evil (making life harder for downstream developers). This package is used in the author tests of Perl::Critic. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672455] Review Request: perl-AnyEvent-DBus - Adapt Net::DBus to AnyEvent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672455 Mathieu Bridon changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE Last Closed||2011-04-11 06:36:06 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691081] Review Request: erlang-erlzmq2 - Erlang binding for ZeroMQ
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691081
--- Comment #8 from Peter Lemenkov 2011-04-11 06:41:57 EDT
---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
work ~/Desktop: rpmlint erlang-erlzmq2-*
erlang-erlzmq2.src:67: W: macro-in-%changelog %{git_tag}
erlang-erlzmq2.src:70: W: macro-in-%changelog %{git_tag}
erlang-erlzmq2.src:74: W: macro-in-%changelog %{git_tag}
erlang-erlzmq2.src:77: W: macro-in-%changelog %{git_tag}
erlang-erlzmq2.src:81: W: macro-in-%changelog %{git_tag}
erlang-erlzmq2.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab:
line 4)
^^ this should be fixed (use real values instead of macros)
erlang-erlzmq2.src: W: invalid-url Source0: zeromq-erlzmq2-a2b0693.tar.gz
^^ that's ok, however I advise you to add a description on how to obtain the
tarball ( wget --no-check-certificate
https://github.com/zeromq/erlzmq2/tarball/a2b0693 )
erlang-erlzmq2.x86_64: E: explicit-lib-dependency erlang-stdlib
^^^ That's ok for now.
3 packages and 0 specfiles checked; 1 errors, 7 warnings.
work ~/Desktop:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines. I have the only proposal -
please, invoke "rebar compile" with "-v" switch to raise verbosity level.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
- The License field in the package spec file MUST match the actual license (MIT
and BSD, see c_src/vector.[ch] sources)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum zeromq-erlzmq2-a2b0693.tar.gz*
d6487a3c02d2ea379a959a92af0c497cdd174ea1ffacceedebd2030e167e1445
zeromq-erlzmq2-a2b0693.tar.gz
d6487a3c02d2ea379a959a92af0c497cdd174ea1ffacceedebd2030e167e1445
zeromq-erlzmq2-a2b0693.tar.gz.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
- The package MUST own all directories that it creates. You missed the only one
- %{_libdir}/erlang/lib/%{real_name}-%{version}/include .
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No C header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Please fix/comment issues mentioned above and I'll continue.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692537] Review Request: librep - An embeddable LISP environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692537 Peter Lemenkov changed: What|Removed |Added Flag||needinfo?(b...@bbbs.net) --- Comment #10 from Peter Lemenkov 2011-04-11 07:07:31 EDT --- Ping. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692537] Review Request: librep - An embeddable LISP environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692537 Kim B. Heino changed: What|Removed |Added Flag|needinfo?(b...@bbbs.net) | --- Comment #11 from Kim B. Heino 2011-04-11 07:17:13 EDT --- Sorry for delay. There's a small patch that has to be added to librep-0.91.1 (just committed to upstream). And compiled emacs lisp... I'll try to do that today or tomorrow... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #32 from elad 2011-04-11 07:25:15 EDT --- Bugfix: add missing dependency to make sure gnome-exe-thumnailer would not fail when trying to display the version of exe files. New SRPM: http://elad.fedorapeople.org/gnome-exe-thumbnailer-0.7-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690282
--- Comment #21 from Alexander Kurtakov 2011-04-11
08:28:09 EDT ---
(In reply to comment #19)
> Re: 17, fixed 2, 3, 4, 5 and 6. Not sure what you intend for 1, I'm an
> experienced packager but not of Java bits, so I may need some handholding. :)
>
1. means instead of
install -pm 0644 build/%{name}.jar \
%{buildroot}%{_libdir}/%{name}/%{name}-%{version}.jar
to do
install -pm 0644 build/%{name}.jar \
%{buildroot}%{_libdir}/%{name}/%{name}.jar
and dropping the symlinking after that.
Same for javadocs.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 --- Comment #22 from Alexander Kurtakov 2011-04-11 08:29:58 EDT --- About the build failure I don't have time to track it now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674114] Review Request: rhino-appjet - JavaScript for Java as modified by Appjet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674114 --- Comment #5 from Alexander Kurtakov 2011-04-11 09:17:38 EDT --- Well, if you give me some unresolvable reasons why appjet requires its own framework you might convince me. But I don't see any reason to not move to latest rhino even if the patches are unavoidable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692733] Review Request: openvas-cli - Command-line tool to drive OpenVAS Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692733 Michal Ambroz changed: What|Removed |Added Blocks||563471(FE-SECLAB) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694139] Review Request: openvas-gsd - Greenbone Security Desktop client application for OpenVAS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694139 Michal Ambroz changed: What|Removed |Added Blocks||563471(FE-SECLAB) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691619 Michal Ambroz changed: What|Removed |Added Blocks||563471(FE-SECLAB) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693126] Review Request: openvas-administrator - Administrator Module for the Open Vulnerability Assessment System (OpenVAS)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693126 Michal Ambroz changed: What|Removed |Added Blocks||563471(FE-SECLAB) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563471 Michal Ambroz changed: What|Removed |Added Depends on||691619(openvas-manager), ||693126(openvas-admin), ||692733(openvas-cli), ||694139(openvas-gsd) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668098] Review Request: rubygem-tzinfo - Ruby library that uses the standard tz (Olson) database to provide daylight savings aware transformations between times in different time zones.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668098 --- Comment #9 from Minnikhanov 2011-04-11 09:38:37 EDT --- New Package SCM Request === Package Name: rubygem-tzinfo Short Description: Ruby library that uses the standard tz (Olson) database to provide daylight savings aware transformations between times in different time zones. Owners: minn Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690360] Review Request: weave - Firefox Registration/Sync Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690360 --- Comment #8 from Chris Tyler 2011-04-11 09:38:01 EDT --- Justin, you should be using upstream's tarballs directly (pristine sources) and do any stripping/processing in your %prep section. There's two reasons for this: first, it relieves you of the responsibility of serving that tarball indefinitely, and secondly, it makes it easier to see how the software is different from the upstream version (or confirm that it is not). Either list two sources (e.g., Source0 and Source1) with the URLs for each of the tarballs, or separate this into two packages, one for the reg-server and one for the sync-server. Whether it makes sense to go with one package (and two sources) or two packages is best determined by the answer to this question: is there any foreseeable circumstance under which you would use one server but not the other? My suggestion about aliases was this: you want to provide the 'least surprise' to the sysadmin installing your package. I recommend that the Alias lines in the httpd weave.conf file be commented out (have a '#' at the start of each line) so that the weave server doesn't automatically start serving as soon as it is installed (or more likely and worse yet: it doesn't start serving when installed, but does start installing after the next boot or httpd restart). After all, the sysadmin has to configure the DB connection, and may also want to do virtual host configuration, etc. In your README, include instructions to uncomment those lines *after* the DB configuration has been performed. (Note that other web app packages such as mediawiki take this approach). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693231] Review Request: gedit-collaboration - collaboration plugin for gedit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693231 --- Comment #3 from Tomáš Bžatek 2011-04-11 09:46:09 EDT --- Tested build in koji, compiles fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=2993057 rpmlint says: gedit-collaboration.src: W: invalid-url URL: http://project.gnome.org/gedit -- do we have better URL? other than git repo? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668098] Review Request: rubygem-tzinfo - Ruby library that uses the standard tz (Olson) database to provide daylight savings aware transformations between times in different time zones.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668098 --- Comment #10 from Minnikhanov 2011-04-11 09:58:23 EDT --- (In reply to comment #9) > New Package SCM Request > === > Package Name: rubygem-tzinfo > Short Description: Ruby library that uses the standard tz (Olson) database to > provide daylight savings aware transformations between times in different time > zones. > Owners: minn > Branches: f15 > InitialCC: Sorry. Not need. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693231] Review Request: gedit-collaboration - collaboration plugin for gedit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693231 Tomáš Bžatek changed: What|Removed |Added Attachment #489990|0 |1 is obsolete|| --- Comment #4 from Tomáš Bžatek 2011-04-11 10:08:39 EDT --- Created attachment 491244 --> https://bugzilla.redhat.com/attachment.cgi?id=491244 Updated spec file * Corrected license (GPLv3) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693231] Review Request: gedit-collaboration - collaboration plugin for gedit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693231 Tomáš Bžatek changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693231] Review Request: gedit-collaboration - collaboration plugin for gedit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=693231
Tomáš Bžatek changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|tbza...@redhat.com
--- Comment #5 from Tomáš Bžatek 2011-04-11 10:09:54 EDT
---
Package review:
> MUST: rpmlint must be run on the source rpm and all binary rpms the build
> produces. The output should be posted in the review.[1]
OK, apart from the errors posted above, no further issues reported
> MUST: The package must be named according to the Package Naming Guidelines .
OK
> MUST: The spec file name must match the base package %{name}, in the format
> %{name}.spec unless your package has an exemption.
OK
> MUST: The package must meet the Packaging Guidelines
OK
> MUST: The package must be licensed with a Fedora approved license and meet
> the Licensing Guidelines .
OK
> MUST: The License field in the package spec file must match the actual
> license.
OK, GPLv3 as stated in COPYING. Sources don't have license header except of
gedit-collaboration-plugin.c which states GPLv2+
> MUST: If (and only if) the source package includes the text of the license(s)
> in its own file, then that file, containing the text of the license(s) for
> the package must be included in %doc.[4]
OK
> MUST: The spec file must be written in American English.
OK, looks that way.
> MUST: The spec file for the package MUST be legible.
OK, formatting is fine
> MUST: The sources used to build the package must match the upstream source,
> as provided in the spec URL. Reviewers should use md5sum for this task. If no
> upstream URL can be specified for this package, please see the Source URL
> Guidelines for how to deal with this.
OK, verified
> MUST: The package MUST successfully compile and build into binary rpms on at
> least one primary architecture.
OK, tested in koji, see above
> MUST: If the package does not successfully compile, build or work on an
> architecture, then those architectures should be listed in the spec in
> ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
> bugzilla, describing the reason that the package does not compile/build/work
> on that architecture. The bug number MUST be placed in a comment, next to the
> corresponding ExcludeArch line.
OK, none needed.
> MUST: All build dependencies must be listed in BuildRequires, except for any
> that are listed in the exceptions section of the Packaging Guidelines ;
> inclusion of those as BuildRequires is optional. Apply common sense.
OK, checked.
> MUST: The spec file MUST handle locales properly. This is done by using the
> %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden
OK, macro used.
> MUST: Every binary RPM package (or subpackage) which stores shared library
> files (not just symlinks) in any of the dynamic linker's default paths, must
> call ldconfig in %post and %postun.
Libraries present but not in ld search paths, these are private to gedit and
loaded in runtime.
> MUST: Packages must NOT bundle copies of system libraries.
OK
> MUST: If the package is designed to be relocatable, the packager must state
> this fact in the request for review, along with the rationalization for
> relocation of that specific package. Without this, use of Prefix: /usr is
> considered a blocker.
OK, none
> MUST: A package must own all directories that it creates. If it does not
> create a directory that it uses, then it should require a package which does
> create that directory.
OK
> MUST: A Fedora package must not list a file more than once in the spec file's
> %files listings. (Notable exception: license texts in specific situations)
OK
> MUST: Permissions on files must be set properly. Executables should be set
> with executable permissions, for example. Every %files section must include a
> %defattr(...) line.
OK
> MUST: Each package must consistently use macros.
OK
> MUST: The package must contain code, or permissable content.
OK
> MUST: Large documentation files must go in a -doc subpackage. (The definition
> of large is left up to the packager's best judgement, but is not restricted
> to size. Large can refer to either size or quantity).
OK, no extra docs.
> MUST: If a package includes something as %doc, it must not affect the runtime
> of the application. To summarize: If it is in %doc, the program must run
> properly if it is not present.
OK
> MUST: Header files must be in a -devel package.
OK, none
> MUST: Static libraries must be in a -static package.
OK, none
> MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
> then library files that end in .so (without suffix) must go in a -devel
> package.
OK, again libraries are private to gedit and are not versioned
> MUST: In the vast majority of cas
[Bug 693231] Review Request: gedit-collaboration - collaboration plugin for gedit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693231 --- Comment #6 from Ignacio Casal Quinteiro (nacho) 2011-04-11 10:27:17 EDT --- It works perfect for me :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556128] Review Request: ff-utils - Utilities to test force feedback of input device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556128 --- Comment #11 from Michal Ambroz 2011-04-11 11:06:12 EDT --- I am sorry guys - I totally forgot about this package. Updated package can be found at: SPEC: http://rebus.fedorapeople.org/SPECS/ff-utils.spec SRPM: http://rebus.fedorapeople.org/SRPMS/ff-utils-2.4.21-4.fc14.src.rpm - added manpages from debian joystick package - added patch as suggested by Didier > Your spec state license GPLv2+, > but http://sourceforge.net/projects/libff/ > state License: GNU Library or Lesser General Public License (LGPL) In my opinion the license in distributed code really matters and there is GPLv2+ in all 4 source files. Here is log from Koji scratch build for i686 and x86_64 for the rawhid - seems to be fine. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2993182 Watching tasks (this may be safely interrupted)... 2993182 build (dist-f16, ff-utils-2.4.21-4.fc14.src.rpm): open (ppc08.phx2.fedoraproject.org) 2993184 buildArch (ff-utils-2.4.21-4.fc14.src.rpm, i686): free 2993183 buildArch (ff-utils-2.4.21-4.fc14.src.rpm, x86_64): free 2993184 buildArch (ff-utils-2.4.21-4.fc14.src.rpm, i686): free -> open (x86-10.phx2.fedoraproject.org) 2993183 buildArch (ff-utils-2.4.21-4.fc14.src.rpm, x86_64): free -> open (x86-15.phx2.fedoraproject.org) 2993183 buildArch (ff-utils-2.4.21-4.fc14.src.rpm, x86_64): open (x86-15.phx2.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 2993184 buildArch (ff-utils-2.4.21-4.fc14.src.rpm, i686): open (x86-10.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 2993182 build (dist-f16, ff-utils-2.4.21-4.fc14.src.rpm): open (ppc08.phx2.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619355] Review Request: python26-numpy - A fast multidimensional array facility for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619355 Jason Tibbitts changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|ti...@math.uh.edu |nob...@fedoraproject.org Flag|fedora-review? | --- Comment #15 from Jason Tibbitts 2011-04-11 11:14:06 EDT --- Looks like you need a review before I'll be able to provide one. Hopefully you can find someone else to do this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632912 Michal Ambroz changed: What|Removed |Added CC||re...@seznam.cz Flag|needinfo?(re...@seznam.cz) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632912 --- Comment #10 from Michal Ambroz 2011-04-11 11:18:07 EDT --- Hello Mamoru, I am sorry - I forgot abuot the package. I will incorporate your suggestions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651521] Review Request: qtwebkit - Qt WebKit bindings
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=651521
Orion Poplawski changed:
What|Removed |Added
CC||or...@cora.nwra.com
--- Comment #1 from Orion Poplawski 2011-04-11 11:17:37
EDT ---
It builds on EL6 with this change:
%if !0%{?rhel}
%{_qt4_importdir}/QtWebKit/
%endif
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693798] Review Request: octave-image - Image processing for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693798 Orion Poplawski changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Orion Poplawski 2011-04-11 11:20:55 EDT --- New Package SCM Request === Package Name: octave-image Short Description: Image processing for Octave Owners: orion Branches: f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693200] Review Request: php-bartlett-PHP-Reflect - Adds the ability to reverse-engineer PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693200 --- Comment #1 from Remi Collet 2011-04-11 11:25:10 EDT --- Update to 0.6.0 https://github.com/remicollet/remirepo/commit/5fca676221adcfcebd434e3e19b218a3330fd6b2 SRPM URL: http://remi.fedorapeople.org/php-bartlett-PHP-Reflect-0.6.0-1.remi.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693493] Review Request: thunderbird-lightning - The calendar extension to Thunderbird
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693493 --- Comment #10 from Orion Poplawski 2011-04-11 12:01:54 EDT --- Thanks. Unpacking the xpi is necessary for proper debuginfo generation. * Mon Apr 11 2011 Orion Poplawski 1.0-0.41.b3pre - Fix debuginfo builds - Remove official branding sections http://www.cora.nwra.com/~orion/fedora/thunderbird-lightning.spec http://www.cora.nwra.com/~orion/fedora/thunderbird-lightning-1.0-0.41.b3pre.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695058] Review Request: transgui - An App to remotely control a Transmission Bit-Torrent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695058 Fabian Affolter changed: What|Removed |Added CC||fab...@bernewireless.net --- Comment #1 from Fabian Affolter 2011-04-11 13:05:24 EDT --- Please see [1] because according to your spec file you are working with a snapshot. [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633063] Review Request: python-txamqp - A Python library for communicating with AMQP peers and brokers using Twisted
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633063 Lubomir Rintel changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review+ --- Comment #1 from Lubomir Rintel 2011-04-11 12:29:01 EDT --- * Package named in accordance with Python guidelines * Latest version packaged * Source package checksum matches * Uses approved license * License tag correct * SPEC file clean and legible * Filelist sane * Provides/Requires correct * Builds fine in mock * RPMLint quiet APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694864] Review Request: php-pecl-gearman - PHP wrapper to libgearman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694864 --- Comment #5 from Paul Whalen 2011-04-11 12:26:17 EDT --- Thanks for the review Chris. Those issues are now fixed and new srpm and spec file are available here: http://scotland.proximity.on.ca/paulwhalen/php-pecl-gearman-0.7.0-3.fc14.src.rpm http://scotland.proximity.on.ca/paulwhalen/php-pecl-gearman.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645484] Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645484 --- Comment #12 from Jason Tibbitts 2011-04-11 13:34:09 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651591] Review Request: partiwm - partitioning window manager and related tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651591 Chris Tyler changed: What|Removed |Added Flag||needinfo?(a...@redhat.com) --- Comment #5 from Chris Tyler 2011-04-11 12:26:19 EDT --- Any action on this? Would love to see this package ship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693798] Review Request: octave-image - Image processing for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693798 --- Comment #7 from Jason Tibbitts 2011-04-11 13:38:41 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645484] Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645484 --- Comment #13 from Jason Tibbitts 2011-04-11 13:38:27 EDT --- I went ahead and processed this, but did anyone notice that the URL in the above-linked spec is incorrect? All you get is a note that the software has moved to github. https://github.com/django-mptt/django-mptt/ is probably a better URL to use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693608] Review Request: icinga - System Monitoring Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693608 --- Comment #1 from Chris Tyler 2011-04-11 12:53:42 EDT --- rpmlint is throwing 72 errors and 2646 warnings on your files - please clean that up before review. Most of these are due to file being owned by nagios (most should be owned by root:root). Use the -i option to get verbose information about any errors which seem unclear. Also, I noticed that your package is trying to own /etc/httpd/conf.d which is owned by httpd. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645484] Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645484 --- Comment #14 from David Riches 2011-04-11 13:44:58 EDT --- Awesome, thanks!! I'll update the spec now.. Cheers Dave -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 --- Comment #51 from Jon Ciesla 2011-04-11 14:03:37 EDT --- SRPM: http://zanoni.jcomserv.net/fedora/lzma-sdk/lzma-sdk-4.6.5-3.fc14.src.rpm SPEC: http://zanoni.jcomserv.net/fedora/lzma-sdk/lzma-sdk.spec D'oh! Thanks! Fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 --- Comment #23 from Jon Ciesla 2011-04-11 14:16:31 EDT --- Ok, gotcha. I fixed #21. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690328] Review Request: be - Bugs Everywhere, a distributed bug tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690328 --- Comment #16 from Fedora Update System 2011-04-11 14:21:35 EDT --- be-1.0.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690328] Review Request: be - Bugs Everywhere, a distributed bug tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690328 Fedora Update System changed: What|Removed |Added Fixed In Version|be-1.0.0-2.el5 |be-1.0.0-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690328] Review Request: be - Bugs Everywhere, a distributed bug tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690328 --- Comment #17 from Fedora Update System 2011-04-11 14:21:47 EDT --- be-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690328] Review Request: be - Bugs Everywhere, a distributed bug tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690328 Fedora Update System changed: What|Removed |Added Fixed In Version|be-1.0.0-2.fc14 |be-1.0.0-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 David Riches changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695058] Review Request: transgui - An App to remotely control a Transmission Bit-Torrent client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695058 --- Comment #2 from Praveen Kumar 2011-04-11 14:36:39 EDT --- Thanks for reminding, updated spec and srpm url :- Spec URL: http://kumarpraveen.fedorapeople.org/transgui/transgui.spec SRPM URL: http://kumarpraveen.fedorapeople.org/transgui/transgui-3.1-2.20110410svn604.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694864] Review Request: php-pecl-gearman - PHP wrapper to libgearman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694864 --- Comment #6 from Chris Tyler 2011-04-11 14:55:24 EDT --- Initial review looks good, recommend for approval by a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694864] Review Request: php-pecl-gearman - PHP wrapper to libgearman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694864 Dennis Gilmore changed: What|Removed |Added Status|NEW |ASSIGNED Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nob...@fedoraproject.org|den...@ausil.us Flag||fedora-review? --- Comment #7 from Dennis Gilmore 2011-04-11 15:00:28 EDT --- I will review and sponsor Paul -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668240] Review Request: clapham - Railroad diagram generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668240 --- Comment #4 from Eric Smith 2011-04-11 15:09:32 EDT --- No word from upstream yet. I've changed it to GPLv2 with a comment explaining the reason. I also added comments about the patches. Thanks for the suggestions. Spec URL: http://fedorapeople.org/~brouhaha/clapham/clapham.spec SRPM URL: http://fedorapeople.org/~brouhaha/clapham/clapham-0.1.003-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694864] Review Request: php-pecl-gearman - PHP wrapper to libgearman
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694864
--- Comment #8 from Dennis Gilmore 2011-04-11 15:33:11 EDT ---
couple of things
%setup should be
%setup -q -n gearman-%{version}
without doing all the mv stuff
build failed for me on f15
+ install -m 644 package.xml
/builddir/build/BUILDROOT/php-pecl-gearman-0.7.0-3.fc15.x86_64/usr/share/pear/.pkgxml/php-pecl-gearman.xml
install: cannot stat `package.xml': No such file or directory
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #19 from Jason Tibbitts 2011-04-11 15:36:29 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #18 from David Riches 2011-04-11 15:36:01 EDT --- Package Change Request == Package Name: django-simple-captcha New Branches: el5 el6 Owners: dcr226 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652083] Rename Request: racket - A Scheme-based programming language and environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652083 Julian Aloofi changed: What|Removed |Added CC||julian.fed...@googlemail.co ||m --- Comment #2 from Julian Aloofi 2011-04-11 15:52:59 EDT --- Is this request dead? https://bugzilla.redhat.com/show_bug.cgi?id=676124 was opened recently, and plt-scheme is orphaned in all branches. Should this be closed as a duplicate of bug 676124 ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636819
Hans de Goede changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #33 from Hans de Goede 2011-04-11 16:08:22
EDT ---
And here is the long promised full review:
Good:
=
- rpmlint checks return:
gnome-exe-thumbnailer.src: W: spelling-error %description -l en_US py -> pt,
p, y
gnome-exe-thumbnailer.noarch: W: spelling-error %description -l en_US py ->
pt, p, y
gnome-exe-thumbnailer.noarch: W: no-manual-page-for-binary
gnome-exe-thumbnailer.sh
These can be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needs work:
===
- rpmlint says:
gnome-exe-thumbnailer.noarch: W: empty-%pre
gnome-exe-thumbnailer.noarch: W: empty-%post
gnome-exe-thumbnailer.noarch: W: empty-%preun
This can simply be fixed by moving the "%if 0%{?fedora} < 15"
above the %pre / %post / %preun
- %pre is in a weird place in the specfile, normally all installation
scripts (be it pre or post) are put between the %clean and the
%files section in the file
- %post / %preun are in a bit of a weird place either, not as weird as
%pre thoug. But normally they are after %clean instead of before it
- Please put a blank line in the changelog before each data-name-version line
(except for the first). And prefix / itemize items below the
data-name-version line with "- ". IE change:
* Sun Sep 26 2010 Elad Alfassa - 0.6-3
Fix typo.
* Sun Sep 26 2010 Elad Alfassa - 0.6-2
Mark schemas file as config file
* Sun Sep 26 2010 Elad Alfassa - 0.6-1
More spec file fixes
* Thu Sep 23 2010 Elad Alfassa - 0.6-0
Version update, some general spec file fixes.
* Sun Jul 25 2010 Elad Alfassa - 0.3-1
initial build
to:
* Sun Sep 26 2010 Elad Alfassa - 0.6-3
- Fix typo.
* Sun Sep 26 2010 Elad Alfassa - 0.6-2
- Mark schemas file as config file
* Sun Sep 26 2010 Elad Alfassa - 0.6-1
- More spec file fixes
* Thu Sep 23 2010 Elad Alfassa - 0.6-0
- Version update, some general spec file fixes.
* Sun Jul 25 2010 Elad Alfassa - 0.3-1
-initial build
- Release should start at 1 after a version bump, not 0. This is not something
to fix retroactively but to keep in mind for the next time upstream
releases a new version.
All the need work items are rather small things, so all in all this looks good.
Based on your informal reviews as well as your withdrawn submission for 2 more
packages I'm ready to sponsor you as soon as a new gnome-exe-thumbnailer fixing
the mentioned (small) issues are fixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 --- Comment #24 from Alexander Kurtakov 2011-04-11 16:20:37 EDT --- Where? I'm looking at the spec posted earlier and it's not fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694864] Review Request: php-pecl-gearman - PHP wrapper to libgearman
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694864 --- Comment #9 from Paul Whalen 2011-04-11 16:30:09 EDT --- Thanks Dennis, those issues are now fixed. http://scotland.proximity.on.ca/paulwhalen/php-pecl-gearman.spec http://scotland.proximity.on.ca/paulwhalen/php-pecl-gearman-0.7.0-4.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 --- Comment #6 from Adam Huffman 2011-04-11 16:39:34 EDT --- New version incorporating latest upstream release which clarifies the licencing position (now GPLv2 or later) at: http://verdurin.fedorapeople.org/reviews/yoshimi/yoshimi.spec http://verdurin.fedorapeople.org/reviews/yoshimi/yoshimi-0.060.9-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691997] Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691997 --- Comment #8 from Fedora Update System 2011-04-11 16:56:27 EDT --- nhn-nanum-fonts-3.010-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692395] Review Request: nhn-nanum-gothic-coding-fonts - Nanum Gothic Coding family of Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692395 --- Comment #8 from Fedora Update System 2011-04-11 16:56:41 EDT --- nhn-nanum-gothic-coding-fonts-1.500-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692395] Review Request: nhn-nanum-gothic-coding-fonts - Nanum Gothic Coding family of Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692395 Fedora Update System changed: What|Removed |Added Fixed In Version|nhn-nanum-gothic-coding-fon |nhn-nanum-gothic-coding-fon |ts-1.500-1.fc15 |ts-1.500-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691276] Review Request: thai-arundina-fonts - Thai fonts aiming at Latin glyph size compatibility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691276 Fedora Update System changed: What|Removed |Added Fixed In Version|thai-arundina-fonts-0.1.2-2 |thai-arundina-fonts-0.1.2-2 |.fc15 |.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694864] Review Request: php-pecl-gearman - PHP wrapper to libgearman
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694864
Dennis Gilmore changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #10 from Dennis Gilmore 2011-04-11 16:56:59 EDT
---
looks cleaner now
sources match upstream
sha512sum gearman-0.7.0.tgz fedora/SOURCES/gearman-0.7.0.tgz
0ba0779cf5b22744488b8c78d5a2479a9910a9f5f8a192c6487e1109bef2a8ab4a8821917b9f04ee0c2df9ad54c15bf3b549f970c9c62fb579a9cd15e1125fd4
gearman-0.7.0.tgz
0ba0779cf5b22744488b8c78d5a2479a9910a9f5f8a192c6487e1109bef2a8ab4a8821917b9f04ee0c2df9ad54c15bf3b549f970c9c62fb579a9cd15e1125fd4
fedora/SOURCES/gearman-0.7.0.tgz
rpmlint /var/lib/mock/fedora-15-x86_64/result
php-pecl-gearman.x86_64: W: private-shared-object-provides
/usr/lib64/php/modules/gearman.so gearman.so()(64bit)
php-pecl-gearman.src: W: spelling-error Summary(en_US) libgearman -> Lieberman
php-pecl-gearman.src: W: spelling-error %description -l en_US libgearman ->
Lieberman
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
of those the only one we could look at removing is the provides on
gearman.so()(64bit)
only tweak i can see would be nice is to use the %{version} macro in the
sourceurl but that is minor and not worth nitpicking.
approved
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691276] Review Request: thai-arundina-fonts - Thai fonts aiming at Latin glyph size compatibility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691276 --- Comment #10 from Fedora Update System 2011-04-11 16:58:22 EDT --- thai-arundina-fonts-0.1.2-2.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691997] Review Request: nhn-nanum-fonts - Nanum family of Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691997 Fedora Update System changed: What|Removed |Added Fixed In Version|nhn-nanum-fonts-3.010-1.fc1 |nhn-nanum-fonts-3.010-1.fc1 |5 |4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 --- Comment #7 from Martin Gieseking 2011-04-11 17:01:41 EDT --- Thanks for clarifying the license issue. However, there are still some files under GPLv3+, so the resulting binary is under GPLv3+ as well (GPLv2+ and GPLv3+ = GPLv3+). Therefore, file COPYING should also contain the GPLv3 license text (currently still GPLv2). The latter isn't a blocker though, but please don't add COPYING to the package as long as it contains the wrong license text. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 --- Comment #8 from Adam Huffman 2011-04-11 17:27:26 EDT --- I should notify upstream about this then? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694998] Review Request: cufflinks - RNA-Seq transcript assembly, differential expression/regulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694998 Adam Huffman changed: What|Removed |Added Blocks||505154(FE-SCITECH) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505154] Tracker: Review Requests for Science and Technology related packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505154 Adam Huffman changed: What|Removed |Added Depends on||694998 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694950] Review Request: torrent-search - A torrent searching graphical application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694950
--- Comment #3 from Fabian Affolter 2011-04-11
17:36:19 EDT ---
Koji build failed:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2994517
See also rpmlint output:
[fab@laptop023 SRPMS]$ rpmlint torrent-search-0.9.2-2.fc14.src.rpm
torrent-search.src:47: W: libdir-macro-in-noarch-package (main package)
%{_libdir}/bonobo/servers/TorrentSearch_Applet.server
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691081] Review Request: erlang-erlzmq2 - Erlang binding for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691081 --- Comment #9 from Mikhail Kulemin 2011-04-11 17:48:10 EDT --- Fixes: * git tags in changelog * BSD license in spec * missing dir in %files section * comment about downloading upstream sources * verbose rebar output Update sources from latest commit (with bugfix in it) Koji build ok: https://koji.fedoraproject.org/koji/taskinfo?taskID=2994533 SPEC: http://mkulemin.fedorapeople.org/packages/erlang-erlzmq2.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694950] Review Request: torrent-search - A torrent searching graphical application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694950 --- Comment #4 from Fabian Affolter 2011-04-11 17:48:23 EDT --- (In reply to comment #1) > - There is stuff for zsh. Wouldn't it be a good idea to put this in a > subpackage? Put the zsh stuff in zsh subpackage of torrent-search. - torrent-search is a gui application but rpmbuild is not picking up. The website claims that GTK is needed for the gui. - Consider to remove the shebangs of the files in the %prep section instead of chmod in the %install section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 --- Comment #9 from Brendan Jones 2011-04-11 17:51:19 EDT --- I've noticed Ubuntu packages this with a GPLv2+ with exceptions, the exceptions being all those file which are GPLv3. Not sure if this is correct or indeed any help here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 640455] Review Request: python-pyro - Pyro is short for PYthon Remote Objects.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=640455
--- Comment #12 from Haïkel Guémar 2011-04-11 18:50:53
EDT ---
As promised, i finished reviewing your package today
python-pyro (python package)
MUST: rpmlint must be run on src.rpm and rpm: OK
$ rpmlint -iv python-pyro-4.3-1.fc14.noarch.rpm
python-pyro.noarch: I: checking
python-pyro.noarch: I: checking-url
http://www.xs4all.nl/~irmen/pyro4/index.html (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint -iv python-pyro-4.3-1.fc14.src.rpm
python-pyro.src: I: checking
python-pyro.src: I: checking-url http://www.xs4all.nl/~irmen/pyro4/index.html
(timeout 10 seconds)
python-pyro.src: I: checking-url
http://www.xs4all.nl/~irmen/pyro4/download/Pyro4-4.3.tar.gz (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Note: the summary - PYthon Remote Objects - is acceptable since it represents
the name of the package
MUST: package named accordingly to package naming guidelines: OK
MUST: spec file name match %{name}: OK
MUST: licensed according a Fedora compliant license: OK (MIT - license file
included)
MUST: License field in spec match actual license: OK
MUST: spec in legible american english: OK
MUST: sources provided match upstream's OK
provided sources sha1sum: 8d654e0fa662b9bdab325c836dbd0af349370f93
upstream sources sha1sum: 8d654e0fa662b9bdab325c836dbd0af349370f93
MUST: package sucessfully compiles on at least one primary architecture (all of
them: x86 and x86_64 under mock for fedora-devel)
MUST: all build dependencies are listed in BR: OK
MUST: package does not list a file more than once in %files section: OK
MUST: permissions are properly set: OK
MUST: package consistenly uses macros: OK
MUST: package contains permissable content: OK
MUST: all filenames are valid UTF-8: OK
SHOULD: the module provided works (tested with python 2.7 and a self-hacked
version on python 3.2): OK
Though it is not mandatory, adding python3 support is strongly recommended
especially when it's supported by upstream which is the case for python-pyro >=
4.3
Since, it's trivial to add python3 support in python-pyro and everything is OK,
my blessing will be given as soon as it's added (Think of it as a good deed to
push forward python3).
===> Here's a modified version of python-pyro.spec with a working python3
support, feel free to use it as a basis.
http://hguemar.fedorapeople.org/reviewer/python-pyro/python-pyro.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632912 --- Comment #11 from Michal Ambroz 2011-04-11 19:42:25 EDT --- Updated package: SPEC: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-3.fc14.src.rpm - added suggested patch - split doc package - enabled %check Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632912 Michal Ambroz changed: What|Removed |Added Version|13 |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632919] Review Request: rubygem-anemone - Anemone web-spider framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632919 Michal Ambroz changed: What|Removed |Added Version|13 |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632919] Review Request: rubygem-anemone - Anemone web-spider framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632919 --- Comment #4 from Michal Ambroz 2011-04-11 20:07:37 EDT --- Updated package: SPEC: http://rebus.fedorapeople.org/SPECS/rubygem-anemone.spec SRPM: http://rebus.fedorapeople.org/SRPMS/rubygem-anemone-0.5.0-3.fc14.src.rpm - fixed doc package and explicit dependency as suggested Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664150] Review Request: ghc-monads-fd - Monad classes, using functional dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664150 --- Comment #2 from Jens Petersen 2011-04-11 21:47:34 EDT --- What is this for? :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 Clint Savage changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #13 from Clint Savage 2011-04-11 22:14:55 EDT --- Package Change Request == Package Name: fpaste-server New Branches: rawhide, el5 forgot to ask for el5 and rawhide branch, nothing else. Thanks, Clint -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 541463] Review Request: garmin-sync - Download data from Garmin fitness computers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541463 --- Comment #11 from Tony Breeds 2011-04-11 22:34:13 EDT --- (In reply to comment #10) > As far as I can tell, there have still been no post-F12 builds of this > package. > If there's something I can help you with, please let me know. Otherwise I > guess I'll go ahead and get this re-orphaned and blocked. Well 4 months certainly doesn't count as "soon" but I've done the import locally. I need to get a f15 branch created and then get rel-eng to unblock it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 541463] Review Request: garmin-sync - Download data from Garmin fitness computers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541463 Tony Breeds changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #12 from Tony Breeds 2011-04-11 22:35:51 EDT --- Package Change Request == Package Name: garmin-sync New Branches: f15 Owners: tbreeds -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 Bobby Powers changed: What|Removed |Added CC||bo...@laptop.org --- Comment #17 from Bobby Powers 2011-04-11 23:06:16 EDT --- bump. v 0.15 has been released. It would be sweet to get this in f16. Let me know if I can help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694950] Review Request: torrent-search - A torrent searching graphical application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694950
--- Comment #5 from Praveen Kumar 2011-04-11
23:06:41 EDT ---
(In reply to comment #4)
> (In reply to comment #1)
> > - There is stuff for zsh. Wouldn't it be a good idea to put this in a
> > subpackage?
>
> Put the zsh stuff in zsh subpackage of torrent-search.
Done
> - torrent-search is a gui application but rpmbuild is not picking up. The
> website claims that GTK is needed for the gui.
Done
> - Consider to remove the shebangs of the files in the %prep section instead of
> chmod in the %install section.
Here do you mean only python files which are in install section?
Can you please tell me if the package is noarch then what macro should i use
instead of %{_libdir} ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 --- Comment #15 from Fedora Update System 2011-04-12 00:15:31 EDT --- fpaste-server-0.1-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/fpaste-server-0.1-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 --- Comment #14 from Fedora Update System 2011-04-12 00:11:55 EDT --- fpaste-server-0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fpaste-server-0.1-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 --- Comment #16 from Fedora Update System 2011-04-12 00:16:35 EDT --- fpaste-server-0.1-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fpaste-server-0.1-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
