[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661436 --- Comment #51 from Fedora Update System 2011-04-23 01:22:59 EDT --- rubygem-heroku-1.20.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-heroku-1.20.1-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661436 --- Comment #50 from Fedora Update System 2011-04-23 01:22:51 EDT --- rubygem-heroku-1.20.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-heroku-1.20.1-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661436 --- Comment #49 from Fedora Update System 2011-04-23 01:22:41 EDT --- rubygem-heroku-1.20.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-heroku-1.20.1-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 --- Comment #19 from Fedora Update System 2011-04-22 23:58:59 EDT --- fpdns-0.9.3-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 Fedora Update System changed: What|Removed |Added Fixed In Version|fpdns-0.9.3-1.fc13 |fpdns-0.9.3-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693608] Review Request: icinga - System Monitoring Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693608 --- Comment #2 from Mike Kirton 2011-04-22 23:45:43 EDT --- Sorry about that, here are some updated versions of the files. Spec URL: http://matrix.senecac.on.ca/~mkirton/SBR/latest/icinga.spec SRPM URL: http://matrix.senecac.on.ca/~mkirton/SBR/latest/icinga-1.3.1-4.fc14.src.rpm SOURCE URL: http://sourceforge.net/projects/icinga/files/icinga/1.3.1/icinga-1.3.1.tar.gz/download Please note that while rpmlint throws a "subsys-not-used" error, it is actually being used and rpmlint is simply not detecting it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666726] Review Request: amide - A Medical Image Data Examiner:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666726 --- Comment #19 from Susmit 2011-04-22 23:37:54 EDT --- Thanks for the heads up, but xmedcon is still not. I am not sure is that would be useful without it. Andy? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698362] Review Request: writetype - Light word processor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698362 --- Comment #5 from PRABIN KUMAR DATTA 2011-04-22 23:23:52 EDT --- Updated (Added upstream License):- Spec URL: http://prabindatta.fedorapeople.org/SPECS/writetype.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/writetype-1.2.130-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 --- Comment #6 from Fedora Update System 2011-04-22 18:16:25 EDT --- perl-CPAN-Changes-0.17-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-CPAN-Changes-0.17-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 --- Comment #5 from Fedora Update System 2011-04-22 18:16:17 EDT --- perl-CPAN-Changes-0.17-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-CPAN-Changes-0.17-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 --- Comment #4 from Fedora Update System 2011-04-22 18:16:10 EDT --- perl-CPAN-Changes-0.17-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-CPAN-Changes-0.17-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 687875] Review Request: aarddict - Multi-platform dictionary and offline Wikipedia reader
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=687875
--- Comment #10 from PRABIN KUMAR DATTA 2011-04-22
18:08:37 EDT ---
/--
[FIX] MUST: The License field in the package spec file must match the
actual license
You have this as GPLv3+ in the spec, but all of the code has GPLv3 headers, and
not GPLv3+.
--/
Updated
/--
[ ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task. If no upstream URL can be specified for this package,
please see the Source URL Guidelines for how to deal with this.
It appears that upstream has since updated release 0.9.2, and the 0.9.1
download link included in the spec no longer works.
--/
Upgraded to version 0.9.2. Also, I have sent a mail to upstream about this
problem.
/--
[FIX] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. If you feel that your
packaged GUI application does not need a .desktop file, you must put
a comment in the spec file with your explanation.
Look at the output of the desktop-file-validate that you run against the
.desktop file.
--/
Updated
/--
Also, explain to me why you are removing the shebangs in the __init__.py files?
I am not saying it's wrong, just curious as to the why.
--/
Actually, I received an error message from rpmlint i.e.
//..
aarddict.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/aarddict/__init__.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
..//
After this, I had two options:
1. change the permission of __init__.py file from 644 to 755, if required to be
executed?
or
2. remove the shebang, if not required?
I took a test case that "shebang is not required" and followed few steps to
verify my test case which are:
1. I manually checked if there is/are anywhere in the code __init__.py is
executed. (something like ./__init__.py) [succeeded ]
2. removed shebang and build it and then install rpm file. [succeeded ]
3. added .arr file to dictionary
a) added WordNet 1.7[succeeded ]
b) added WordNet 3.0[succeeded ]
c) added Wikipedia (simple)- dated 20101026-1 [succeeded ]
4. Consult with upstream.
//---Attached a part of mail's reply from upstream
Shebang in aarddict/__init__.py simply provides another way of
launching aarddict ui or command line operations which I found useful
at some point (I believe it was handy on Windows where other methods
didn't work) - in any case regular users should have no need for this.
-//
Updated files:
SPECS :http://prabindatta.fedorapeople.org/SPECS/aarddict.spec
SRPMS: http://prabindatta.fedorapeople.org/SRPMS/aarddict-0.9.2-1.fc14.src.rpm
//-
Note:
Today I was doing further testing on my package and found another problem in
it.
After conversation with elad661, tibbs and nirik on IRC channel #fedora-devel.
I have send a mail to upstream requesting them to place locale and icons files
in standard locations and I hope for a quick reply from him.
tibbs has also created a ticket on this issue
https://fedorahosted.org/fpc/ticket/79
-//
Thank You!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 --- Comment #18 from Fedora Update System 2011-04-22 17:20:05 EDT --- fpdns-0.9.3-1.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 Fedora Update System changed: What|Removed |Added Fixed In Version|fpdns-0.9.3-1.el5 |fpdns-0.9.3-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 Fedora Update System changed: What|Removed |Added Fixed In Version|fpdns-0.9.3-1.fc14 |fpdns-0.9.3-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 --- Comment #17 from Fedora Update System 2011-04-22 17:19:08 EDT --- fpdns-0.9.3-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System 2011-04-22 17:18:01 EDT --- postler-0.1.1-4.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695281] Review Request: perl-Devel-EnforceEncapsulation - Find access violations to blessed objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695281 Paul Howarth changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Paul Howarth 2011-04-22 16:51:28 EDT --- New Package SCM Request === Package Name: perl-Devel-EnforceEncapsulation Short Description: Find access violations to blessed objects Owners: pghmcfc Branches: F-15 EL-6 InitialCC: perl-sig Thanks for the review again Marcela. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678442] Review Request: os-prober - Probes disks on the system for installed operating systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678442 --- Comment #8 from Hedayat Vatankhah 2011-04-22 16:32:40 EDT --- You should not install src.rpm package. Instead, build the src.rpm using rpmbuild command: rpmbuild -bb os-prober-1.42-2.fc14.src.rpm Then, it'll build appropriate RPM packages inside ~/rpmbuild/RPMS or /usr/src/redhat/RPMS (IIRC), and you can install generated rpm packages then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||fpdns-0.9.3-1.el4 Resolution||ERRATA Last Closed||2011-04-22 13:52:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 Fedora Update System changed: What|Removed |Added Fixed In Version|fpdns-0.9.3-1.el6 |fpdns-0.9.3-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691027 Fedora Update System changed: What|Removed |Added Fixed In Version|n2n-2.0.1-3.el6 |n2n-2.0.1-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691027 Fedora Update System changed: What|Removed |Added Fixed In Version|n2n-2.0.1-3.fc15|n2n-2.0.1-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 --- Comment #16 from Fedora Update System 2011-04-22 13:54:10 EDT --- fpdns-0.9.3-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 --- Comment #14 from Fedora Update System 2011-04-22 13:52:41 EDT --- fpdns-0.9.3-1.el4 has been pushed to the Fedora EPEL 4 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691027 --- Comment #35 from Fedora Update System 2011-04-22 13:53:07 EDT --- n2n-2.0.1-3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 Fedora Update System changed: What|Removed |Added Fixed In Version|fpdns-0.9.3-1.el4 |fpdns-0.9.3-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691027 --- Comment #34 from Fedora Update System 2011-04-22 13:52:55 EDT --- n2n-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 672418] Review Request: fpdns - Fingerprint DNS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672418 --- Comment #15 from Fedora Update System 2011-04-22 13:53:20 EDT --- fpdns-0.9.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691096] Review Request: iperf3 - Measurement tool for TCP/UDP bandwidth performance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691096 Kevin Fenzi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Kevin Fenzi 2011-04-22 12:44:57 EDT --- Everything looks good to me here now, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699025] New: Review Request: jchardet - Automatic charset detection algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jchardet - Automatic charset detection algorithm https://bugzilla.redhat.com/show_bug.cgi?id=699025 Summary: Review Request: jchardet - Automatic charset detection algorithm Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: or...@cora.nwra.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://www.cora.nwra.com/~orion/fedora/jchardet.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/jchardet-1.1-1.fc14.src.rpm Description: jchardet is a java port of the source from Mozilla's automatic charset detection algorithm. The original author is Frank Tang. What is available here is the java port of that code. The original source in C++ can be found from http://lxr.mozilla.org/mozilla/source/intl/chardet/. More information can be found at http://www.mozilla.org/projects/intl/chardet.html. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651521] Review Request: qtwebkit - Qt WebKit bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651521 --- Comment #3 from Jaroslav Reznik 2011-04-22 11:10:18 EDT --- Name: ok (upstream) Group: ok License: ok URL: ok Sources: ok, custom prepared, documented Summary/description: not sure "Qt WebKit bindings" makes sense here, maybe "Qt WebKit browser engine" sounds better Patches: ok BRs, reqs: ok Provides, obsoletes: please, provide qt-webkit SMP Flags: ok, present Ldconfig snippets: ok, present File attributes: ok Consistent macro usage: ok Devel package: ok, with correct Conflicts, Obsoletes. Is it enough to provide qt4-webkit-devel and not qt-webkit-devel? Package builds in Koji: ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=3019200 rpmlint output: rpmlint qtwebkit-2.1-2.fc16.src.rpm qtwebkit.src: W: invalid-url Source0: qtwebkit-developers-qtwebkit-qtwebkit-2.1.0.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint qtwebkit-2.1-2.fc16.x86_64.rpm qtwebkit.x86_64: W: obsolete-not-provided qt-webkit > please fix qtwebkit.x86_64: W: no-documentation > ok 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698264] Review Request: perl-TryCatch - First class try catch semantics for Perl, without source filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698264 Bug 698264 depends on bug 698251, which changed state. Bug 698251 Summary: Review Request: perl-B-Hooks-OP-PPAddr - Hook into opcode execution https://bugzilla.redhat.com/show_bug.cgi?id=698251 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698251] Review Request: perl-B-Hooks-OP-PPAddr - Hook into opcode execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698251 Marcela Mašláňová changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-04-22 10:58:50 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678442] Review Request: os-prober - Probes disks on the system for installed operating systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678442 Mehdi Fattahi changed: What|Removed |Added CC||mah@gmail.com --- Comment #7 from Mehdi Fattahi 2011-04-22 10:47:20 EDT --- Trying to install the RPM I got the following error message: mahdi@mahdi-TECRA-A8 Downloads$ sudo rpm -Uvh os-prober-1.42-2.fc14.src.rpm 1:os-prober warning: user hedayat does not exist - using root warning: group hedayat does not exist - using root warning: user hedayat does not exist - using root) warning: group hedayat does not exist - using root -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 --- Comment #3 from Jason Tibbitts 2011-04-22 10:29:42 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698251] Review Request: perl-B-Hooks-OP-PPAddr - Hook into opcode execution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698251 --- Comment #3 from Jason Tibbitts 2011-04-22 10:29:22 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697139] Review Request: apache-commons-email - Apache Commons Email Package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697139 --- Comment #4 from Jason Tibbitts 2011-04-22 10:26:10 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697779] Review Request: rubygem-file-tail - File::Tail for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697779 --- Comment #11 from Jason Tibbitts 2011-04-22 10:27:51 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697778] Review Request: rubygem-formtastic - A Rails form builder plugin with semantically rich and accessible markup
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697778 --- Comment #16 from Jason Tibbitts 2011-04-22 10:27:22 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697780 --- Comment #9 from Jason Tibbitts 2011-04-22 10:28:08 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693117] Review Request: drupal6-backup_migrate - Database backup, restore, and migrate module for Drupal 6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693117 --- Comment #5 from Jason Tibbitts 2011-04-22 10:24:58 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697767] Review Request: rubygem-spruz - Useful tools library in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697767 --- Comment #9 from Jason Tibbitts 2011-04-22 10:26:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694692] Review Request: perl-Devel-Trace - Print out each line before it is executed (like sh -x)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694692 --- Comment #4 from Jason Tibbitts 2011-04-22 10:25:19 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691027 --- Comment #33 from Jason Tibbitts 2011-04-22 10:24:34 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED Bug 690954 depends on bug 690953, which changed state. Bug 690953 Summary: Review Request: dexter - Address Book that goes hand in hand with Postler https://bugzilla.redhat.com/show_bug.cgi?id=690953 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #19 from Fedora Update System 2011-04-22 08:48:50 EDT --- postler-0.1.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/postler-0.1.1-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690954] Review Request: postler - An ultra simple desktop mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #18 from Fedora Update System 2011-04-22 08:48:41 EDT --- postler-0.1.1-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/postler-0.1.1-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698953] New: Review Request: Brazilian Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Brazilian Portuguese dictionaries for Aspell https://bugzilla.redhat.com/show_bug.cgi?id=698953 Summary: Review Request: Brazilian Portuguese dictionaries for Aspell Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: jsafr...@redhat.com ReportedBy: varek...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://people.redhat.com/varekova/aspell-pt_BR.spec SRPM URL: http://people.redhat.com/varekova/aspell-pt_BR-20090702-1.fc13.src.rpm The upstream of Portuguese dictionary split the dictionary to two parts this bug is for the European Portuguese part. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698952] New: Review Request: European Portuguese dictionaries for Aspell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: European Portuguese dictionaries for Aspell https://bugzilla.redhat.com/show_bug.cgi?id=698952 Summary: Review Request: European Portuguese dictionaries for Aspell Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: jsafr...@redhat.com ReportedBy: varek...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://people.redhat.com/varekova/aspell-pt_PT.spec SRPM URL: http://people.redhat.com/varekova/aspell-pt_PT-20070510-1.fc13.src.rpm The upstream of Portuguese dictionary split the dictionary to two parts this bug is for the European Portuguese part. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651521] Review Request: qtwebkit - Qt WebKit bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651521 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695281] Review Request: perl-Devel-EnforceEncapsulation - Find access violations to blessed objects
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=695281
Marcela Mašláňová changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Marcela Mašláňová 2011-04-22 07:07:54
EDT ---
- rpmlint OK
perl-Devel-EnforceEncapsulation.noarch: W: spelling-error %description -l en_US
filehandles -> file handles, file-handles, mishandles
perl-Devel-EnforceEncapsulation.src: W: spelling-error %description -l en_US
filehandles -> file handles, file-handles, mishandles
perl-Devel-EnforceEncapsulation.src: E: unknown-key GPG#b56a8bac
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=3018370
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679133] Review Request: starcal - A desktop calendar with Gregorian, Jalali and Hijri support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679133 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698681] Review Request: grilo - Content discovery framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698681
--- Comment #3 from Peter Lemenkov 2011-04-22 05:17:39 EDT
---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- rpmlint is NOT silent
work ~: rpmlint Desktop/grilo-*
grilo.src: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
^^^ that's ok - just a false positive
grilo.src: W: no-url-tag
^^^ Please, add "Url: http://live.gnome.org/Grilo"; line.
grilo.src:57: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 57)
^^^ cosmetic
grilo.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
^^^ false positive
grilo.x86_64: W: no-url-tag
^^^ see above.
grilo.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/grl-inspect
['/usr/lib64']
grilo.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libgrlnet-0.1.so.0.0.0 ['/usr/lib64']
grilo.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/grilo-test-ui
['/usr/lib64']
grilo.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libgrlnet-0.1.so.0.0.0
grilo.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libgrlnet-0.1.so.0.0.0
grilo.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libgrilo-0.1.so.0.0.0
grilo.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libgrilo-0.1.so.0.0.0
^^^ This MUST be fixed. Just add the following lines:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
grilo.x86_64: W: no-manual-page-for-binary grl-inspect
grilo.x86_64: W: no-manual-page-for-binary grilo-test-ui
^^ that's ok
grilo-debuginfo.x86_64: W: no-url-tag
grilo-devel.x86_64: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
grilo-devel.x86_64: W: no-url-tag
grilo-vala.x86_64: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
^^^ see above.
grilo-vala.x86_64: W: non-standard-group Development/Other
^^^ Please use group value from /usr/share/doc/rpm-*/GROUPS
grilo-vala.x86_64: W: no-url-tag
5 packages and 0 specfiles checked; 7 errors, 13 warnings.
work ~:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license
(LGPLv2.1 or later).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum grilo-0.1.15.tar.bz2*
4276337b56f09c3a448a26e0f41a72812b72faa0e4dbdcc9ab1a314e2c5c7264
grilo-0.1.15.tar.bz2
4276337b56f09c3a448a26e0f41a72812b72faa0e4dbdcc9ab1a314e2c5c7264
grilo-0.1.15.tar.bz2.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
- The package stores shared library files in some of the dynamic linker's
default paths, so it MUST call ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are stored in a -devel package.
0 No static libraries.
+ The pkgconfig(.pc) files are stored in a -devel package and necessary runtime
requirement is picked up automatically.
+ The library file(s) that end in .so (without suffix) is(are) stored in a
-devel package.
+ The -devel package requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+/- The package owns all directories that it creates but it also owns files or
directories already owned by other packages. Well, frankly speaking I'd rather
treat this as an issue, but it seems that it's a common situation for
GTK-related apps due to their complex mutual relations. Namely these
directories have multiple owners:
/usr/lib/girepository-1.0/
/usr/share/gir-1.0/
/usr/share/gtk-doc/
/usr/share/gtk-doc/html/
Keeping in mind that we've got a policy about directories, belonging to
packages w
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 Paul Howarth changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Paul Howarth 2011-04-22 04:58:49 EDT --- New Package SCM Request === Package Name: perl-CPAN-Changes Short Description: Read and write Changes files Owners: pghmcfc Branches: F-13 F-14 F-15 InitialCC: perl-sig No EPEL branches due to needing perl 5.10 and perl(version) 0.79 (EL-6 has 0.77, but perhaps there will be an update in EL-6.1?). Thanks for the review Marcela. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698681] Review Request: grilo - Content discovery framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698681 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov 2011-04-22 04:33:42 EDT --- I'll review it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698681] Review Request: grilo - Content discovery framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698681 --- Comment #2 from Peter Lemenkov 2011-04-22 04:34:17 EDT --- Koji scratchbuild for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3018189 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698301
Marcela Mašláňová changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Marcela Mašláňová 2011-04-22 04:22:06
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=3018178
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
rpm -qp --provides ../RPMS/noarch/perl-CPAN-Changes-0.16-1.fc14.noarch.rpm
perl(CPAN::Changes) = 0.16
perl(CPAN::Changes::Release)
perl(Test::CPAN::Changes)
perl-CPAN-Changes = 0.16-1.fc14
rpm -qp --requires ../RPMS/noarch/perl-CPAN-Changes-0.16-1.fc14.noarch.rpm
perl(:MODULE_COMPAT_5.12.3)
perl(CPAN::Changes)
perl(CPAN::Changes::Release)
perl(Scalar::Util)
perl(Test::Builder)
perl(Text::Wrap)
perl(strict)
perl(version)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695281] Review Request: perl-Devel-EnforceEncapsulation - Find access violations to blessed objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695281 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666726] Review Request: amide - A Medical Image Data Examiner:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666726 Peter Lemenkov changed: What|Removed |Added CC||lemen...@gmail.com Depends on||573910(dcmtk) --- Comment #18 from Peter Lemenkov 2011-04-22 04:00:25 EDT --- DCMTK is available in Fedora finally, so it's time to continue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573910] Review Request: dcmtk - Offis DICOM Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573910 Peter Lemenkov changed: What|Removed |Added Blocks||666726 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698301] Review Request: perl-CPAN-Changes - Read and write Changes files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698301 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
