[Bug 648247] Review Request: ghc-tagged - Newtype wrappers for phantom types

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648247

--- Comment #1 from Jens Petersen peter...@redhat.com 2011-05-06 02:16:04 EDT 
---
This is needed by feldspar-language-0.4.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648247] Review Request: ghc-tagged - Newtype wrappers for phantom types

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648247

Shakthi Kannan shakthim...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||shakthim...@gmail.com
 AssignedTo|nob...@fedoraproject.org|shakthim...@gmail.com

--- Comment #2 from Shakthi Kannan shakthim...@gmail.com 2011-05-06 02:23:51 
EDT ---
Can you please update this to 0.2 version?

  http://hackage.haskell.org/package/tagged-0.2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524992] Review Request: toppler - platform game

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

--- Comment #28 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 02:57:30 EDT ---
toppler-1.1.5-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/toppler-1.1.5-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524992] Review Request: toppler - platform game

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

--- Comment #27 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 02:57:22 EDT ---
toppler-1.1.5-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/toppler-1.1.5-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524992] Review Request: toppler - platform game

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524992] Review Request: toppler - platform game

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

--- Comment #26 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 02:57:15 EDT ---
toppler-1.1.5-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/toppler-1.1.5-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524992] Review Request: toppler - platform game

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

--- Comment #25 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 02:57:04 EDT ---
toppler-1.1.5-1.el5.1 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/toppler-1.1.5-1.el5.1

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700833] Review Request: colorgcc - Script to colorize the terminal output of gcc, g++, cc, c++

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700833

--- Comment #5 from Martin Cermak mcer...@redhat.com 2011-05-06 02:56:56 EDT 
---
 Needs work:
 ---
 - Please use the full URL for Source0

 - The license tag should be GPL+, per:
   http://fedoraproject.org/wiki/Licensing
   See the GPL (no version) table

 - If you're not adding a %clean, nor cleaning the buildroot in %install, you
 should not specify a buildroot at all, so drop:
 BuildRoot:  %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)

 - A bitter way to handle %prep would be:
 %prep
 %setup -q -c -T
 cp -p %{SOURCE0} .
 %patch0 -p1
   You can then also drop the cd %{name}-%{version} from %install

This should be resolved in colorgcc-1.3.2-2:

Spec URL: http://www.physics.muni.cz/~cermak/colorgcc-1.3.2-2/colorgcc.spec
SRPM URL:
http://www.physics.muni.cz/~cermak/colorgcc-1.3.2-2/colorgcc-1.3.2-2.fc14.src.rpm
Patch0 URL:
http://www.physics.muni.cz/~cermak/colorgcc-1.3.2-2/colorgcc-1.3.2-invocation.patch

$ rpmlint colorgcc.spec
colorgcc.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint colorgcc-1.3.2-2.fc14.src.rpm
colorgcc.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint colorgcc-1.3.2-2.fc14.noarch.rpm
colorgcc.noarch: W: no-documentation
colorgcc.noarch: W: no-manual-page-for-binary color-gcc
colorgcc.noarch: W: no-manual-page-for-binary color-g++
colorgcc.noarch: W: no-manual-page-for-binary color-cc
colorgcc.noarch: W: no-manual-page-for-binary color-ccache
colorgcc.noarch: W: no-manual-page-for-binary color-c++
1 packages and 0 specfiles checked; 0 errors, 6 warnings.


 Hmm, is there an easy way to call ccache instead of gcc within colorgcc?
 Currently I have this for calling colorgcc:
 $ ll /usr/local/bin/
 insgesamt 0
 lrwxrwxrwx. 1 root root 15 15. Mai 2010  cc - /usr/bin/ccache
 lrwxrwxrwx. 1 root root 15 15. Mai 2010  g++ - /usr/bin/ccache
 lrwxrwxrwx. 1 root root 15 15. Mai 2010  gcc - /usr/bin/ccache

 Replacing that link to color-gcc will unfortunately disable ccache...

On a fresh F14 system, ccache is called transparently if you call gcc:

$ strace -eexecve -f gcc hello.c 21 | grep ^execve | grep -v ENOENT
execve(/usr/lib64/ccache/gcc, [gcc, hello.c], [/* 33 vars */]) = 0
execve(/usr/bin/gcc, [/usr/bin/gcc, hello.c], [/* 34 vars */]) = 0

So I just removed absolute paths pointing to compiler binaries from colorgcc.
Now it should work as expected if you have ccache installed:

$ strace -eexecve -f color-gcc hello.c 21 | grep ^execve | grep -v ENOENT
execve(/usr/bin/color-gcc, [color-gcc, hello.c], [/* 33 vars */]) = 0
execve(/usr/lib64/ccache/gcc, [gcc, hello.c], [/* 33 vars */]) = 0
execve(/usr/bin/gcc, [/usr/bin/gcc, hello.c], [/* 34 vars */]) = 0

And also if you haven't:

trace -eexecve -f color-gcc hello.c 21 | grep ^execve | grep -v ENOENT
execve(/usr/bin/color-gcc, [color-gcc, hello.c], [/* 33 vars */]) = 0
execve(/usr/bin/gcc, [gcc, hello.c], [/* 33 vars */]) = 0

And I also provided the color-ccache link:

$ rpm -ql colorgcc
/usr/bin/color-c++
/usr/bin/color-cc
/usr/bin/color-ccache
/usr/bin/color-g++
/usr/bin/color-gcc

Hope I didn't miss something. What remains is to set up some nice aliases... :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

Steve Traylen steve.tray...@cern.ch changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #6 from Steve Traylen steve.tray...@cern.ch 2011-05-06 03:01:47 
EDT ---
So other than 

1) Fix Add %{?_isa} where appropriate.

which can be done before import APPROVED.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701237] Review Request: perl-Test-Trap - Trap exit codes, exceptions, output, etc

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701237

--- Comment #6 from Petr Sabata psab...@redhat.com 2011-05-06 03:10:16 EDT ---
Thank you for the repo and the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #7 from Martin Cermak mcer...@redhat.com 2011-05-06 04:30:58 EDT 
---
I belive pal-0.4.3-2 contains all the requested fixes:

Spec URL: http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal.spec
SRPM URL:
http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal-0.4.3-2.fc14.src.rpm

+ rpmlint pal.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

+ rpmlint pal-0.4.3-2.fc14.src.rpm
pal.src: W: spelling-error %description -l en_US gcal - gal, cal, goal
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ rpmlint pal-debuginfo-0.4.3-2.fc14.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ rpmlint pal-0.4.3-2.fc14.x86_64.rpm
pal.x86_64: W: spelling-error %description -l en_US gcal - gal, cal, goal
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Hans, please, review my changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684835

--- Comment #11 from Michal Fojtik mfoj...@redhat.com 2011-05-06 04:34:41 EDT 
---
Ah I'm sorry I copypasted wrong request

New Package CVS Request
===
Package Name: deltacloud-core
Short Description: Deltacloud REST API server
Owners: mfojtik
Branches: F-14 F-15 EL-5 EL-6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698576

Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #8 from Hans de Goede hdego...@redhat.com 2011-05-06 04:39:29 EDT 
---
Looks good now, approved! If you can go and create a fas account (if you've not
done so already) and tell me your fas username, I'll add you to the packager
group and sponsor you, see:
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

Kalev Lember ka...@smartlink.ee changed:

   What|Removed |Added

 CC||ka...@smartlink.ee

--- Comment #24 from Kalev Lember ka...@smartlink.ee 2011-05-06 05:10:41 EDT 
---
Could you please rebase the rpm changelog on top of the current
mingw32-filesystem (and keep rebasing it when there are new changes to
mingw32-filesystem)? It's a bit hard to see right now what changes were
accidental and what was intended. When importing the rename into Fedora, I
think the changes should apply cleanly on the existing package, without
rewriting much of the (Fedora package's) history.

Comparing the package to the existing mingw32-filesystem, the following
symlinks are no longer there. Is it intentional?
/usr/bin/mingw32-cmake
/usr/bin/mingw32-make
/usr/bin/mingw32-pkg-config
/usr/bin/mingw32-qmake-qt4


 Obsoletes:  cross-filesystem = 67-1

= comparision doesn't work as intended here, it's better to use 'Obsoletes:   
  cross-filesystem  67-2' to take into account the .fcXX prefixes in release.


 Requires:   setup
 Requires:   rpm
 Requires:   rpmlint = 0.85-2

These requires should surely be in the -scripts subpackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700571] Review Request: spindown - Daemon that can spindown idle disks

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700571

--- Comment #5 from Hans de Goede hdego...@redhat.com 2011-05-06 05:22:13 EDT 
---
Much better now, almost there.

Needs work:
- You're installing the example config file as /etc/spindown.conf now,
  no need to include at is as %doc then
- Thanks for doing the new initscript, but I'm afraid it needs some work:
  Must Fix:
  - The LSB HEADER is entirely empty, fill in the Short Description and
Description and remove all the other lines.
  - statuspipe=/tmp/spindown.status
Is vulnerable to symlinks attacks, please make this
/var/run/spindown.status
instead
  - the $prog in status -p /var/run/spindownd.pid $prog must be $exec
  - start() is missing a return $retval at the end

  Should fix:
  - Given that you've effectively written a new script, please add it as
Source1: (without an url) and then in $setup do:
cp -p %{SOURCE1} .
Rather then making it a hard to read patch. This will also make
making future changes to it a lot easier.
  - Drop the unused RETVAL variable
  - Please use a pidfile variable (like lockfile and statuspipe) rather then
writing out /var/run/spindownd.pid in full everywhere
  - This part:
echo -n $Starting $prog: 
if [ $UID -ne 0 ] ; then   
failure
echo -e \nUser has insufficient privilege.
exit 4
fi
if [ ! -x $exec ]; then
failure
echo -e \nDaemon binary not executable.
exit 5
fi
if [ ! -f $config ]; then
failure
echo -e \nConfig file missing.
exit 6
fi

Deviates from how most Fedora init scripts do it, please change this to:

[ $UID -eq 0 ] || exit 4
[ -x $exec ] || exit 5
[ -f $config ] || exit 6
echo -n $Starting $prog: 

  - You can likely (and if it works should) write this bit:

$exec -d -f $statuspipe -c $config -p /var/run/spindownd.pid;
retval=$?
[ $retval -eq 0 ]  success || failure
echo

As:

daemon $exec -d -f $statuspipe -c $config -p /var/run/spindownd.pid;
retval=$?
echo

  - stop() can be simplified to just:
stop() {
echo -n $Stopping $prog: 
killproc -p /var/run/spindownd.pid $exec
retval=$?
echo
[ $retval -eq 0 ]  rm -f $lockfile
return $retval
}

  - judging from the old initscript reload should be:
reload() {
killproc -p /var/run/spindownd.pid $exec -HUP
}

And force_reload should then call reload rather then restart

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

   Flag|needinfo?(erik-fedora@vanpi |
   |enbroek.nl) |

--- Comment #25 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 
2011-05-06 06:22:33 EDT ---
Thank you both for reviewing this!

Michael:
Upstream for this package is the Fedora MinGW SIG. We don't have a separate VCS
as we use the Fedora VCS for this

The FSF rpmlint warnings have just been fixed

I've kept the %clean and BuildRoot lines in so this package can also be built
on EL-6. Perhaps those lines can be dropped for EL-6 packages as well, but I
couldn't find any documentation about that yet.

Kalev:
This diverge in changelog history was caused by the fact that a long time ago
(back in May 2010) I forked the mingw32 toolchain to add mingw-w64 support.
Recently I tried to merge everything back together but apparently some things
got lost. I've just re-added the wrapper scripts you mentioned. Wrapper scripts
for the mingw-w64 part have also just been added. 

The original changelog has also been merged now

The obsoletes and requires tags should be good now


Spec URL:
http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-70-1.fc15.src.rpm

* Fri May 06 2011 Erik van Pienbroek epien...@fedoraproject.org - 70-1
- Use the correct FSF-address in some scripts
- Moved some Requires tags to the mingw-filesystem-scripts subpackage
- Fixed the Obsoletes tags
- Re-added the wrapper scripts mingw32-cmake, mingw32-make,
  mingw32-pkg-config and mingw32-qmake-qt4
- Added the wrapper scripts mingw32-cmake, mingw64-make,
  mingw64-pkg-config, i686-w64-mingw32-pkg-config,
  x86_64-w64-mingw32-pkg-config and mingw64-qmake-qt4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

--- Comment #12 from Martin Gieseking martin.giesek...@uos.de 2011-05-06 
06:17:21 EDT ---
OK, in this case, Denis should open a new review request ticket and close this
one as a duplicate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701237] Review Request: perl-Test-Trap - Trap exit codes, exceptions, output, etc

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701237

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701237] Review Request: perl-Test-Trap - Trap exit codes, exceptions, output, etc

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701237

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-05-06 
06:39:15 EDT ---
perl-Test-Trap-0.2.1-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Test-Trap-0.2.1-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701237] Review Request: perl-Test-Trap - Trap exit codes, exceptions, output, etc

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701237

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-05-06 
06:38:58 EDT ---
perl-Test-Trap-0.2.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Test-Trap-0.2.1-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

--- Comment #26 from Kalev Lember ka...@smartlink.ee 2011-05-06 07:07:37 EDT 
---
The Provides: mingw32() and Provides: mingw64() would probably look better in
alphabetical order.


Sorry for not noticing it earlier, but the Requires: setup, rpm, rpmlint and
BuildRequires: rpmlint were all dropped from mingw32-filesystem a while ago:
http://pkgs.fedoraproject.org/gitweb/?p=mingw32-filesystem.git;a=commit;h=d8bcc2f5ac2ba0cde140fe0682286dfaf5c2a2fb
http://pkgs.fedoraproject.org/gitweb/?p=mingw32-filesystem.git;a=commit;h=7034ac899f074b4bed02090fb271ecb10d7266fb

I think the rationale for NOT Requiring 'setup' and 'rpm' was that these are
all so low level packages that they are in all Fedora installations and
therefore it's not worth requiring them, similar to not requiring the
'filesystem' package.

With rpmlint there's a different story. Rpmlint used to be required dependency
because we install a file in /etc/rpmlint/. However, directory ownership
guidelines were updated a while ago and now it's perfectly fine to have
multiple directory ownership on /etc/rpmlint/ in order to avoid needlessly
dragging in the rpmlint package.
http://fedoraproject.org/wiki/PackagingGuidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function


I'd suggest the following changes:

-BuildRequires:  rpmlint = 0.85-2

-Requires:   setup
-Requires:   rpm
-Requires:   rpmlint = 0.85-2

+%dir %{_sysconfdir}/rpmlint
 %config(noreplace) %{_sysconfdir}/rpmlint/mingw-rpmlint.config

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 690580] Review Request: perl-Perl-Critic-More - Supplemental policies for Perl::Critic

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690580

--- Comment #19 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 07:30:29 EDT ---
perl-Perl-Critic-More-1.000-1.fc15 has been submitted as an update for Fedora
15.
https://admin.fedoraproject.org/updates/perl-Perl-Critic-More-1.000-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700571] Review Request: spindown - Daemon that can spindown idle disks

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700571

--- Comment #6 from Martin Cermak mcer...@redhat.com 2011-05-06 08:27:30 EDT 
---
Created spindown-0.4.0-3.fc14 addressing the aforementioned issues, see [1]. 
I hope it'll be fine now. Please review.

---
[1] http://www.physics.muni.cz/~cermak/spindown-0.4.0-3/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

--- Comment #27 from Michael Cronenworth m...@cchtml.com 2011-05-06 08:47:02 
EDT ---
(In reply to comment #26)
 +%dir %{_sysconfdir}/rpmlint
  %config(noreplace) %{_sysconfdir}/rpmlint/mingw-rpmlint.config

Thanks for the help, Kalev.

I think for the rpmlint folder simply:
%{_sysconfdir}/rpmlint
is enough. (no %dir)

After the above fixes are applied I'll give it one more review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #9 from Martin Cermak mcer...@redhat.com 2011-05-06 09:11:38 EDT 
---
Great, thanks! My fas username is mcermak. What should I do next?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700571] Review Request: spindown - Daemon that can spindown idle disks

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700571

Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Hans de Goede hdego...@redhat.com 2011-05-06 09:17:50 EDT 
---
(In reply to comment #6)
 Created spindown-0.4.0-3.fc14 addressing the aforementioned issues, see [1]. 
 I hope it'll be fine now. Please review.
 
 ---
 [1] http://www.physics.muni.cz/~cermak/spindown-0.4.0-3/

Hi,

Thanks, looks good now: approved.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700833] Review Request: colorgcc - Script to colorize the terminal output of gcc, g++, cc, c++

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700833

Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #6 from Hans de Goede hdego...@redhat.com 2011-05-06 09:29:35 EDT 
---
Looks good now: approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #10 from Hans de Goede hdego...@redhat.com 2011-05-06 09:26:54 
EDT ---
Hi,

(In reply to comment #9)
 Great, thanks! My fas username is mcermak. What should I do next?

I've just added you to the packager group and sponsored you, the next steps,
are described here:
http://fedoraproject.org/wiki/PackageMaintainers/Join

The first thing to do is request creation of git and bugzilla modules for your
approved packages, see:
http://fedoraproject.org/wiki/Package_SCM_admin_requests

Note that it may take up to an hour for your newer packager rights to propagate
to all servers, and you won't be able to set the fedora-cvs flag until you've
those rights.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700667] Review Request python26-crypto

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700667

--- Comment #9 from Andy Grimm agr...@gmail.com 2011-05-06 09:44:35 EDT ---
Created attachment 497358
  -- https://bugzilla.redhat.com/attachment.cgi?id=497358
Revised Simplifications

All of your suggestions make sense; the reason I left pythonver from the
original recipe was to keep things as similar as possible to the python-crypto
master (it might make merges easier later).  Rather than remove it and alter
the %install section, I replaced pybasever with pythonver in this similar
patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

Jerry James loganje...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #7 from Jerry James loganje...@gmail.com 2011-05-06 11:20:07 EDT 
---
New Package SCM Request
===
Package Name: openfst
Short Description: Weighted finite-state transducer library
Owners: jjames
Branches: f14 f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

--- Comment #28 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 
2011-05-06 11:21:56 EDT ---
For the rpmlint folder I didn't use one global %{_sysconfdir}/rpmlint entry as
the file which is placed in that folder isn't a regular file, but a %config
file.

Spec URL:
http://svn.openftd.org/svn/fedora_cross/mingw-filesystem/mingw-filesystem.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw-filesystem-71-1.fc15.src.rpm

* Fri May 06 2011 Erik van Pienbroek epien...@fedoraproject.org - 71-1
- Dropped the BR and R for setup, rpm and rpmlint as they aren't needed anymore
- Own the folder %{_sysconfdir}/rpmlint (to avoid dependency on rpmlint)
- Sorted the list with mingw32(xxx) and mingw64(xxx) provides for improved
readability

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663925

--- Comment #7 from Takanori MATSUURA t.mat...@gmail.com 2011-05-06 11:38:12 
EDT ---
Thank you for reviewing.

Spec URL:
http://t-matsuu.sakura.ne.jp/mock/autoconf-archive/autoconf-archive.spec
SRPM URL:
http://t-matsuu.sakura.ne.jp/mock/autoconf-archive/autoconf-archive-2011.04.12-0.fc14.src.rpm


(In reply to comment #5)
 [!] : SHOULD - SourceX / PatchY prefixed with %{name}.
 Source0:
 ftp://ftp.gnu.org/gnu/autoconf-archive/autoconf-archive-%{version}.tar.xz
 (autoconf-archive-%{version}.tar.xz)

Fixed. Thanks.


 [!] : SHOULD - Latest version is packaged.

Updated to 2011.04.12.


 [!] : SHOULD - Scriptlets must be sane, if used.

Fixed %post and %preun scriptlets.


 [?] : SHOULD - Packages should try to preserve timestamps of original 
 installed files.

Added  INSTALL=install -p for make install.


 Issues:
 [!] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
 this can be ignored, I think

I never added Packager tag in the spec file.
I'm afraid it has been added by your setting.


 [!] : MUST - License field in the package spec file matches the actual 
 license.
 Does COPYING.EXCEPTION need to be included?
 Some of the files in build-aux imply GPLv3+

License field has been updated to GPLv3+ with exceptions.


 [!] : MUST - Package installs properly.
 Message when installing on F14:
 
 install-info: Is a directory for /usr/share/info

Fixed %post and %preun scriptlets.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702692] New: Review Request: perl-Test-CheckChanges - Check that the Changes file matches the distribution

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Test-CheckChanges - Check that the Changes file 
matches the distribution

https://bugzilla.redhat.com/show_bug.cgi?id=702692

   Summary: Review Request: perl-Test-CheckChanges - Check that
the Changes file matches the distribution
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@city-fan.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Test-CheckChanges/branches/fedora/perl-Test-CheckChanges.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Test-CheckChanges/perl-Test-CheckChanges-0.14-2.fc16.src.rpm

Description:

This module checks that your Changes file has an entry for the current version
of the Module being tested. The version information for the distribution being
tested is taken out of the Build data, or if that is not found, out of the
Makefile. It then attempts to open, in order, a file with the name Changes or
CHANGES. The Changes file is then parsed for version numbers. If one and only
one of the version numbers matches, the test passes; otherwise the test fails.
A message with the current version is printed if the test passes; otherwise
diagnostic messages are printed to help explain the failure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

Michael Cronenworth m...@cchtml.com changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #29 from Michael Cronenworth m...@cchtml.com 2011-05-06 11:48:32 
EDT ---
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3054732

Rpmlint:
$ rpmlint mingw-filesystem mingw-filesystem-scripts mingw32-filesystem
mingw64-filesystem
mingw-filesystem.noarch: W: obsolete-not-provided cross-filesystem
mingw-filesystem.noarch: W: no-documentation
mingw-filesystem-scripts.noarch: W: obsolete-not-provided
cross-filesystem-scripts
mingw-filesystem-scripts.noarch: W: only-non-binary-in-usr-lib
mingw-filesystem-scripts.noarch: E: incorrect-fsf-address
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: no-documentation
mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-qmake-qt4
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-cmake
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-configure
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: dangling-symlink
/usr/bin/i686-w64-mingw32-pkg-config /usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-pkg-config
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-make
/usr/libexec/mingw-scripts
mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-make
mingw32-filesystem.noarch: W: no-manual-page-for-binary
i686-w64-mingw32-pkg-config
mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-qmake-qt4
mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-cmake
mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-configure
mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-pkg-config
mingw64-filesystem.noarch: W: no-documentation
mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-qmake-qt4
/usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-configure
/usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-make
/usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-pkg-config
/usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-cmake
/usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: dangling-symlink
/usr/bin/x86_64-w64-mingw32-pkg-config /usr/libexec/mingw-scripts
mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-pkg-config
mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-make
mingw64-filesystem.noarch: W: no-manual-page-for-binary
x86_64-w64-mingw32-pkg-config
mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-qmake-qt4
mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-cmake
mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-configure
4 packages and 0 specfiles checked; 1 errors, 30 warnings.

Looks like there's still one FSF address issue. The man pages are obvious dupes
of native tools so they aren't required. It looks good to me.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702699] New: Review Request: mingw32-libffi - MinGW Windows Foreign Function Interface library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mingw32-libffi - MinGW Windows Foreign Function 
Interface library

https://bugzilla.redhat.com/show_bug.cgi?id=702699

   Summary: Review Request: mingw32-libffi - MinGW Windows Foreign
Function Interface library
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ka...@smartlink.ee
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://kalev.fedorapeople.org/mingw32-libffi.spec
SRPM URL: http://kalev.fedorapeople.org/mingw32-libffi-3.0.9-1.fc15.src.rpm
Description:
The `libffi' library provides a portable, high level programming
interface to various calling conventions.  This allows a programmer to
call any function specified by a call interface description at run time.

This package contains the MinGW Windows cross compiled libffi library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702699] Review Request: mingw32-libffi - MinGW Windows Foreign Function Interface library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702699

Kalev Lember ka...@smartlink.ee changed:

   What|Removed |Added

 CC||fedora-mingw@lists.fedorapr
   ||oject.org

--- Comment #1 from Kalev Lember ka...@smartlink.ee 2011-05-06 12:03:23 EDT 
---
libffi is a required dependency for building glib 2.29.4.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3054790

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702103] Review Request: python-osmgpsmap - Python bindings for osm-gps-map GTK+ widget

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702103

Paul Franklin (RHlists) pf.rhli...@gmail.com changed:

   What|Removed |Added

 CC||pf.rhli...@gmail.com

--- Comment #1 from Paul Franklin (RHlists) pf.rhli...@gmail.com 2011-05-06 
12:02:28 EDT ---
Do you have a scratch build for this one also, like 701982?
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700667] Review Request python26-crypto

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700667

Andy Grimm agr...@gmail.com changed:

   What|Removed |Added

 Blocks||702677

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 664912] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664912

--- Comment #4 from Jason Tibbitts ti...@math.uh.edu 2011-05-06 12:56:58 EDT 
---
Anything happening here?  It appears that this is holding up the last
dependency for rt4.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 674115] Review Request: yuicompressor-appjet - JavaScript minifier

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674115

Ian Weller i...@ianweller.org changed:

   What|Removed |Added

 CC||i...@ianweller.org

--- Comment #3 from Ian Weller i...@ianweller.org 2011-05-06 13:47:38 EDT ---
Version 2.4.6 was released from upstream on 04/15/2011

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701031] Review Request: zeitgeist-datahub - The zeitgeist engine data logger

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701031

Mario Blättermann mari...@freenet.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #9 from Mario Blättermann mari...@freenet.de 2011-05-06 13:59:20 
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3054989

$ rpmlint -v *
zeitgeist-datahub.i686: I: checking
zeitgeist-datahub.i686: W: spelling-error %description -l en_US plugins - plug
ins, plug-ins, plugging
zeitgeist-datahub.i686: I: checking-url http://launchpad.net/zeitgeist-datahub
(timeout 10 seconds)
zeitgeist-datahub.i686: W: non-conffile-in-etc
/etc/xdg/autostart/zeitgeist-datahub.desktop
zeitgeist-datahub.src: I: checking
zeitgeist-datahub.src: W: spelling-error %description -l en_US plugins - plug
ins, plug-ins, plugging
zeitgeist-datahub.src: I: checking-url http://launchpad.net/zeitgeist-datahub
(timeout 10 seconds)
zeitgeist-datahub.src: I: checking-url
http://launchpad.net/zeitgeist-datahub/0.7/0.7.0/+download/zeitgeist-datahub-0.7.0.tar.gz
(timeout 10 seconds)
zeitgeist-datahub-debuginfo.i686: I: checking
zeitgeist-datahub-debuginfo.i686: I: checking-url
http://launchpad.net/zeitgeist-datahub (timeout 10 seconds)
zeitgeist-datahub.spec: I: checking-url
http://launchpad.net/zeitgeist-datahub/0.7/0.7.0/+download/zeitgeist-datahub-0.7.0.tar.gz
(timeout 10 seconds)
3 packages and 1 specfiles checked; 0 errors, 3 warnings.


-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
LGPLv3+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
ebf822fc4aafbfe93784db60e1f9917a  zeitgeist-datahub-0.7.0.tar.gz
ebf822fc4aafbfe93784db60e1f9917a  zeitgeist-datahub-0.7.0.tar.gz.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available, see above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
The provided *.desktop file is not used in the usual way, to provide
application launchers. It resides in the /etc/xdg/autostart folder and is for
other purposes
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a
separate file from 

[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

--- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2011-05-06 14:10:40 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684835

--- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2011-05-06 14:11:07 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 673784] Rename Request: mingw32-filesystem - mingw-filesystem - Cross compiler base filesystem and environment

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673784

Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #30 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 
2011-05-06 14:31:42 EDT ---
New Package SCM Request
===
Package Name: mingw-filesystem
Short Description: MinGW cross compiler base filesystem and environment
Owners: epienbro rjones kalev
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702692] Review Request: perl-Test-CheckChanges - Check that the Changes file matches the distribution

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702692

Mario Blättermann mari...@freenet.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mari...@freenet.de
 AssignedTo|nob...@fedoraproject.org|mari...@freenet.de
   Flag||fedora-review?

--- Comment #1 from Mario Blättermann mari...@freenet.de 2011-05-06 15:06:23 
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3055110

$ rpmlint -v *
perl-Test-CheckChanges.noarch: I: checking
perl-Test-CheckChanges.noarch: I: checking-url
http://search.cpan.org/dist/Test-CheckChanges/ (timeout 10 seconds)
perl-Test-CheckChanges.src: I: checking
perl-Test-CheckChanges.src: I: checking-url
http://search.cpan.org/dist/Test-CheckChanges/ (timeout 10 seconds)
perl-Test-CheckChanges.src: E: unknown-key GPG#b56a8bac
perl-Test-CheckChanges.src: I: checking-url
http://search.cpan.org/CPAN/authors/id/G/GA/GAM/Test-CheckChanges-0.14.tar.gz
(timeout 10 seconds)
perl-Test-CheckChanges.spec: I: checking-url
http://search.cpan.org/CPAN/authors/id/G/GA/GAM/Test-CheckChanges-0.14.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

No errors so far. The mentioned error comes from the srpm which is signed with
an unknown GPG key, doesn't matter.

The package perl-test-simple is available in F14 as v0.98. Do we really need
the patch here? Which current distros (Fedora and EPEL) ships an older version
than 0.88?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 702692] Review Request: perl-Test-CheckChanges - Check that the Changes file matches the distribution

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702692

--- Comment #2 from Paul Howarth p...@city-fan.org 2011-05-06 15:14:28 EDT ---
Fedora 10 (and hence EPEL 4/5) have versions older than that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702699] Review Request: mingw32-libffi - MinGW Windows Foreign Function Interface library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702699

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

 CC||t.sai...@alumni.ethz.ch

--- Comment #2 from Thomas Sailer t.sai...@alumni.ethz.ch 2011-05-06 15:13:21 
EDT ---
What is exactly the difference compared with:
https://bugzilla.redhat.com/show_bug.cgi?id=641727

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 641727] Review Request: mingw32-libffi: portable foreign function interface library for Fedora MinGW

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641727

Kalev Lember ka...@smartlink.ee changed:

   What|Removed |Added

 CC||ka...@smartlink.ee

--- Comment #14 from Kalev Lember ka...@smartlink.ee 2011-05-06 15:21:40 EDT 
---
*** Bug 702699 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702699] Review Request: mingw32-libffi - MinGW Windows Foreign Function Interface library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702699

Kalev Lember ka...@smartlink.ee changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE
Last Closed||2011-05-06 15:21:40

--- Comment #3 from Kalev Lember ka...@smartlink.ee 2011-05-06 15:21:40 EDT 
---
Oh, looks like it's indeed already in. Thanks.

*** This bug has been marked as a duplicate of bug 641727 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-05-06 
16:08:49 EDT ---
openfst-1.2.7-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/openfst-1.2.7-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 16:08:57 EDT ---
openfst-1.2.7-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/openfst-1.2.7-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

Michael Schwendt mschwe...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mschwe...@gmail.com
 AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Michael Schwendt mschwe...@gmail.com 2011-05-06 16:30:03 
EDT ---
 License:GPLv3

The included file COPYING is GPLv2. The source files include GPLv2 headers.
Upstream web page says GPLv3, so please ask them to clarify.


 Name:   osm-gps-map
 Group:  Development/Libraries

The group for library base packages typically is System
Environment/Libraries.


 Summary:A Gtk+ widget for displaying OpenStreetMap tiles

I still think we should get rid of even more A, An, The articles at the
beginning of these summaries. It makes a better reading during installation and
in package installer tools.

Your summary for the -devel package also doesn't start with The. ;)


 %description
 A Gtk+ widget (and Python bindings) ...

The Python bindings are not included in this package, but in a separate one.


 %doc AUTHORS COPYING README

What about file NEWS?


 %files devel
 %doc COPYING

It is not necessary to duplicate that file in the subpackage.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing


 make %{?_smp_mflags}

Consider using

  make V=1 %{?_smp_mflags}

so the build output is less silent and e.g. shows full compiler flags.


 osm-gps-map v0.7.3
 Prefix... : /usr
 libsoup.. : 2.4
 Introspection support : no
 gtk-doc documentation : no

$ grep -i introspec build.log 
checking for gobject-introspection... no
Introspection support : no

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 678855] Review Request: python-rpyc - A Transparent, Symmetrical Python Library for Distributed-Computing

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678855

Dan Kenigsberg dan...@cs.technion.ac.il changed:

   What|Removed |Added

 CC||dan...@cs.technion.ac.il
   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697836

Volker Fröhlich volke...@gmx.at changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich volke...@gmx.at 2011-05-06 18:44:39 EDT 
---
Just some comments:

Please include the license file. The postal addresses of the FSF are outdated
in several files.

Use -p on the install commands, at least for the scripts. One of the scripts
uses the samtools binary, so you'll need an explicit Require on that, as RPM
will only install samtools-libs

Besides the first part of the package description is pretty generic, it says,
it would contain instructions. I can't see any and especially the mmseq binary
is especially sparse on saying anything. Why does the description not have the
word Haplotype?

Why did you choose to not install the Perl script?

You might want to add -b .name_of_the_patch to the patch macros. Please also
comment on the patches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 684429] Review Request: wbfs-manager - A WBFS manager for Linux using GTK+

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684429

Randall Randy Berry randyn3...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #6 from Randall Randy Berry randyn3...@gmail.com 2011-05-06 
18:46:38 EDT ---
Looks like issues have been addressed.

== APPROVED ==

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 684429] Review Request: wbfs-manager - A WBFS manager for Linux using GTK+

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684429

David Riches davi...@ultracar.co.uk changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #7 from David Riches davi...@ultracar.co.uk 2011-05-06 19:33:36 
EDT ---
New Package SCM Request
===
Package Name: wbfs-manager
Short Description: A WBFS manager for Linux using GTK+
Owners: dcr226
Branches: f13 f14 f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 682704] Review Request: uwsgi - Fast, self-healing, application container server

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682704

Steve Milner smil...@redhat.com changed:

   What|Removed |Added

 CC||smil...@redhat.com

--- Comment #2 from Steve Milner smil...@redhat.com 2011-05-06 21:20:04 EDT 
---
Thank you for submitting this package for review! I've been waiting for someone
to be interested in taking it on.

Some prereview data:
* New version has been released since originally posted
* SRPM builds fine on x86_64.
* rpmlint output. Only possible issue is the line ending whicah can be fixed
with %{__sed} -i 's/\r//' uwsgi-wiki-doc*.txt:
$ rpmlint /home/steve/rpmbuild/RPMS/x86_64/uwsgi-0.9.6.8-1.fc14.x86_64.rpm
uwsgi.x86_64: W: spelling-error %description -l en_US interprocess - inter
process, inter-process, interpreters
uwsgi.x86_64: W: spelling-error %description -l en_US preforking - preforming,
preform, preferring
uwsgi.x86_64: W: spelling-error %description -l en_US evented - evened,
vented, e vented
uwsgi.x86_64: W: spelling-error %description -l en_US coroutine - co routine,
co-routine, subroutine
uwsgi.x86_64: W: spelling-error %description -l en_US uGreen - u Green, Green,
green
uwsgi.x86_64: W: spelling-error %description -l en_US xml - XML, cml, ml
uwsgi.x86_64: W: spelling-error %description -l en_US ini - uni, in, ii
uwsgi.x86_64: W: spelling-error %description -l en_US yaml - yam, amyl, yams
uwsgi.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/uwsgi-0.9.6.8/uwsgi-wiki-doc-v15.txt
uwsgi.x86_64: W: no-manual-page-for-binary uwsgi
1 packages and 0 specfiles checked; 0 errors, 10 warnings.
* Sources match:
4a9b8bef52e2ff60fab645d595d1128e  ../SOURCES/uwsgi-0.9.6.8.tar.gz
4a9b8bef52e2ff60fab645d595d1128e  uwsgi-0.9.6.8.tar.gz

I think it would be very helpful to add a subpackage or a sibling package for
the apache2 uwsgi module. For the heck of it I'm attaching a sibling package
spec based on yours :-).

Thanks for working on this package, and good luck with the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 682704] Review Request: uwsgi - Fast, self-healing, application container server

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682704

--- Comment #3 from Steve Milner smil...@redhat.com 2011-05-06 21:22:45 EDT 
---
Created attachment 497471
  -- https://bugzilla.redhat.com/attachment.cgi?id=497471
mod_uwsgi spec file

mod_uwsgi spec for completeness.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 694651] Review Request: IBSimu - Ion beam simulator

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694651

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 21:33:23 EDT ---
IBSimu-1.0.4-4.el5 has been pushed to the Fedora EPEL 5 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 668863] Review Request: dolphin-connector - Simple MySQL C API wrapper for C++

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668863

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|dolphin-connector-1.0-4.fc1 |dolphin-connector-1.2-1.el6
   |3   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 694651] Review Request: IBSimu - Ion beam simulator

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694651

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|IBSimu-1.0.4-4.el6  |IBSimu-1.0.4-4.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 668863] Review Request: dolphin-connector - Simple MySQL C API wrapper for C++

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668863

--- Comment #29 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 21:32:16 EDT ---
dolphin-connector-1.2-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702103] Review Request: python-osmgpsmap - Python bindings for osm-gps-map GTK+ widget

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702103

--- Comment #2 from Jeffrey C. Ollie j...@ocjtech.us 2011-05-06 21:31:16 EDT 
---
No, I won't be able to do a scratch build until osm-gps-map has been reviewed
and then added to the koji build root.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524992] Review Request: toppler - platform game

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #29 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 21:31:39 EDT ---
toppler-1.1.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 681976] Review Request: openfst - weighted finite-state transducer library

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681976

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 22:49:01 EDT ---
openfst-1.2.7-1.fc14 has been pushed to the Fedora 14 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

--- Comment #21 from Fedora Update System upda...@fedoraproject.org 
2011-05-06 22:51:53 EDT ---
openvas-manager-2.0.3-1.fc14 has been pushed to the Fedora 14 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version|openvas-manager-2.0.2-2 |openvas-manager-2.0.3-1.fc1
   ||4
 Resolution||ERRATA
Last Closed||2011-05-06 22:51:59

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701494] Review Request: wlmproxy - An advanced proxy for the MSN Messenger protocol

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701494

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-05-06 
22:55:28 EDT ---
wlmproxy-0.1.2-2.fc14 has been pushed to the Fedora 14 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701237] Review Request: perl-Test-Trap - Trap exit codes, exceptions, output, etc

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701237

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-05-06 
22:55:46 EDT ---
perl-Test-Trap-0.2.1-1.fc14 has been pushed to the Fedora 14 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701982] Review Request: osm-gps-map - A Gtk+ widget for displaying OpenStreetMap tiles

2011-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701982

--- Comment #2 from Jeffrey C. Ollie j...@ocjtech.us 2011-05-07 00:18:04 EDT 
---
Michael, I've addressed your comments.  For now, if the source says GPLv2
that's what I'll go with.  I'll work with upstream to clarify in the future.  I
also explicitly disabled gobject introspection because it doesn't compile
correctly on F15 and from what I can tell isn't that interesting on F14.

Here's a new scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3055990

and a link to the new SRPM:

http://jcollie.fedorapeople.org/osm-gps-map-0.7.3-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review