[Bug 604971] Review Request: jwm - Joe's Window Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604971 --- Comment #11 from Germán Racca 2011-05-20 23:06:55 EDT --- (In reply to comment #10) > Any news about this? I'm waiting for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706565] New: Review Request: sheepdog - The Sheepdog Distributed Storage System for KVM/QEMU
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sheepdog - The Sheepdog Distributed Storage System for KVM/QEMU https://bugzilla.redhat.com/show_bug.cgi?id=706565 Summary: Review Request: sheepdog - The Sheepdog Distributed Storage System for KVM/QEMU Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: da...@gnsa.us QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://ke4qqq.fedorapeople.org/sheepdog.spec SRPM URL: http://ke4qqq.fedorapeople.org/sheepdog-0.2.2-2.fc14.src.rpm Description: This package contains the Sheepdog server, and command line tool which offer a distributed object storage system for KVM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #14 from Fedora Update System 2011-05-20 19:45:47 EDT --- mod_flvx-0-0.1.20100525git.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #13 from Fedora Update System 2011-05-20 19:45:28 EDT --- mod_flvx-0-0.1.20100525git.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #12 from Fedora Update System 2011-05-20 19:45:10 EDT --- mod_flvx-0-0.1.20100525git.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #9 from Fedora Update System 2011-05-20 19:44:02 EDT --- mod_flvx-0-0.1.20100525git.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #10 from Fedora Update System 2011-05-20 19:44:26 EDT --- mod_flvx-0-0.1.20100525git.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #11 from Fedora Update System 2011-05-20 19:44:50 EDT --- mod_flvx-0-0.1.20100525git.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mod_flvx-0-0.1.20100525git.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706310] Need EPEL-6 branches for LTSP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706310 --- Comment #5 from Kevin Fenzi 2011-05-20 18:43:25 EDT --- done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 --- Comment #5 from Kevin Fenzi 2011-05-20 18:34:49 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 --- Comment #7 from Kevin Fenzi 2011-05-20 18:32:41 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706421 --- Comment #5 from Kevin Fenzi 2011-05-20 18:35:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706070] Review Request: keytool-maven-plugin - A plugin that wraps the keytool program and allows to manipulate keystores
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706070 --- Comment #6 from Kevin Fenzi 2011-05-20 18:33:06 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706400 --- Comment #7 from Kevin Fenzi 2011-05-20 18:34:23 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549593 --- Comment #14 from Rahul Sundaram 2011-05-20 18:31:16 EDT --- umm. why am I being listed as a owner for the EL6 branch. I don't even own the other Fedora branches anymore. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 --- Comment #8 from Kevin Fenzi 2011-05-20 18:28:20 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #11 from Kevin Fenzi 2011-05-20 18:30:00 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609817] Review Request: dojo - Modular JavaScript toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609817 --- Comment #12 from Kevin Fenzi 2011-05-20 18:26:43 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549593 --- Comment #13 from Kevin Fenzi 2011-05-20 18:25:49 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 204258] Review Request: mousepad - A simple text editor for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=204258 --- Comment #7 from Kevin Fenzi 2011-05-20 18:23:54 EDT --- We agreed to not do this one at this time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706310] Need EPEL-6 branches for LTSP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706310 Warren Togami changed: What|Removed |Added Summary|Need EPEL-6 branches of |Need EPEL-6 branches for |mkelfimage wraplinux|LTSP --- Comment #4 from Warren Togami 2011-05-20 18:21:57 EDT --- Sorry, found another missing package. =( Package Change Request == Package Name: pyserial New Branches: el6 Owners: wtogami -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533167 --- Comment #18 from Kevin Fenzi 2011-05-20 18:24:43 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700199] Review Request: tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700199 --- Comment #12 from Ivan Afonichev 2011-05-20 18:10:46 EDT --- Spec URL: https://github.com/vanaf/tomcat7-fedora/blob/master/tomcat.spec SRPM URL: http://baldr.sgu.ru/rpm/tomcat-7.0.14-2.fc14.src.rpm - Fixed http source link - Securify some permissions - Added licenses for el-api and servlet-api - Added dependency on jpackage-utils for the javadoc subpackage Permissions: Tomcat surely needs to write to /etc/tomcat/Catalina/* (tomcat copies here context.xmls from META-INF from webapps) /var/cache/tomcat/* /var/lib/tomcat/webapps/* /var/log/tomcat/* for some webapps I think it also need permission to write to /usr/share/tomcat other users I think shouldn't be able to view /etc/tomcat/tomcat-users.xml and maybe /var/cache/tomcat/* /var/log/tomcat/* But some permissions are still not standart because of the owner root. I am not sure whether it is needed for some reason or not. I we set user tomcat as owner many of this permissions could become standart. incoherent-subsys: I researched /usr/share/rpmlint/InitScriptCheck.py It seems that rpmlint isn't able to resolve $(basename $0) in /etc/init.d/tomcat to 'tomcat', because of that this warning happens -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698681] Review Request: grilo - Content discovery framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698681 --- Comment #11 from Fedora Update System 2011-05-20 16:56:13 EDT --- grilo-0.1.15-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698681] Review Request: grilo - Content discovery framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698681 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||grilo-0.1.15-2.fc15 Resolution||ERRATA Last Closed||2011-05-20 16:56:18 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 --- Comment #18 from nucleo 2011-05-20 15:44:22 EDT --- Bad news: 1. license patch broken (build failed). 2. translations missing in 2.0.1 sources (but they are in 2.0.0-final). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 651521] Review Request: qtwebkit - Qt WebKit bindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651521 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-05-20 15:11:08 --- Comment #9 from Rex Dieter 2011-05-20 15:11:08 EDT --- imported, built for rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 Fedora Update System changed: What|Removed |Added Fixed In Version|fpaste-server-0.1-3.fc14|fpaste-server-0.1-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561484] Review Request: jruby - Pure Java implementation of the Ruby interpreter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561484 --- Comment #14 from Mo Morsi 2011-05-20 14:16:30 EDT --- I'll get back to this (hopefully for the last time :-p) next week -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 Fedora Update System changed: What|Removed |Added Fixed In Version|protobuf-c-0.15-2.fc14 |protobuf-c-0.15-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 676175] Review Request: fpaste-server - Fedora Pastebin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676175 --- Comment #26 from Fedora Update System 2011-05-20 13:56:28 EDT --- fpaste-server-0.1-3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694568] Review Request: python-testtools - Extensions to the Python unit testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694568 Fedora Update System changed: What|Removed |Added Fixed In Version|python-testtools-0.9.8-2.fc |python-testtools-0.9.8-2.el |15 |6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 Rex Dieter changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706400 Rex Dieter changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|wm...@wm161.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694568] Review Request: python-testtools - Extensions to the Python unit testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694568 --- Comment #10 from Fedora Update System 2011-05-20 13:54:44 EDT --- python-testtools-0.9.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 --- Comment #35 from Fedora Update System 2011-05-20 13:54:58 EDT --- protobuf-c-0.15-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701845] Review Request: shunit2 - A xUnit based unit testing for Unix shell scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701845 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System 2011-05-20 13:54:08 EDT --- shunit2-2.1.6-3.el6 has been pushed to the Fedora EPEL 6 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553606] Review Request: kde-plasma-birthday-reminder - Birthday Reminder Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553606 --- Comment #7 from Alain PORTAL 2011-05-20 13:35:00 EDT --- Probably not as I'm still with a F12... But I'll re-open it if I need. Thanks Rex. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629744] Review Request: sparkleshare - sharing work made easy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629744 --- Comment #5 from Alex Hudson (Fedora Address) 2011-05-20 13:06:14 EDT --- Hey all, Thanks for the congrats Aidan, much appreciated ;) I've rebuilt the latest sparkleshare for f13/14/15: http://repos.fedorapeople.org/repos/alexh/sparkleshare/ The F15 SRPM/spec is the latest. The python stuff I'm in two minds about at the moment. I've fixed the problems - basically, nautilus-python-devel wants to see extensions in the python 3 folder, whether or not the extension will work from there, I have no idea - I couldn't get the extension to work on gnome 2 yet. The B-R on python-devel 2 and 3 is what the Python SIG say you should do - I need to do more testing with it, I think it's correct but obviously without getting the extension working... I think this package is basically ready for review, with an eye for this going into F16 but possibly F15 too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553606] Review Request: kde-plasma-birthday-reminder - Birthday Reminder Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553606 --- Comment #6 from Rex Dieter 2011-05-20 12:56:38 EDT --- See comment #3 "Do you still wish to pursue this?" If so, please do re-open this submission, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553606] Review Request: kde-plasma-birthday-reminder - Birthday Reminder Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553606 --- Comment #5 from Alain PORTAL 2011-05-20 12:50:21 EDT --- (In reply to comment #4) > let's close this out, ad it's been over a year hearing from reporter. Why do you want to hear me as I never heard any reviewer??? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678910 Rex Dieter changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Rex Dieter 2011-05-20 11:45:50 EDT --- naming: ok sources: ok $ md5sum *.bz2 7592bf60fafcb465fe75cd987a037ffc 136278-activitymanager-0.5.tar.bz2 builds/installs: ok licensing: ok , though looking through the sources looks like GPLv2+ scriptlets: n/a Otherwise fairly small and simple, looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=443310 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #12 from Orion Poplawski 2011-05-20 11:43:04 EDT --- Package Change Request == Package Name: xfwm4-theme-nodoka New Branches: el6 Owners: cwickert mso InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549593 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #12 from Orion Poplawski 2011-05-20 11:40:54 EDT --- Package Change Request == Package Name: tumbler New Branches: el6 Owners: sundaram cwickert kevin InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 204258] Review Request: mousepad - A simple text editor for Xfce
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=204258 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com Flag||fedora-cvs? --- Comment #6 from Orion Poplawski 2011-05-20 11:38:51 EDT --- Package Change Request == Package Name: mousepad New Branches: el6 Owners: kevin InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Rex Dieter 2011-05-20 11:32:50 EDT --- New Package SCM Request === Package Name: libmygpo-qt Short Description: Qt Library that wraps the gopper.net Web API Owners: rdieter Branches: f14 f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632056] Review Request: libsocialweb-qt - Qt4 API for libsocialweb client DBUS interface
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632056
Rex Dieter changed:
What|Removed |Added
Version|14 |rawhide
Flag|fedora-review? |fedora-review+
--- Comment #4 from Rex Dieter 2011-05-20 11:31:09 EDT
---
$ rpmlint *.rpm x86_64/*.rpm
libsocialweb-qt.src: W: invalid-url Source0: libsocialweb-qt-0.1.2.tar.bz2
libsocialweb-qt.x86_64: E: incorrect-fsf-address
/usr/share/doc/libsocialweb-qt-0.1.2/COPYING
libsocialweb-qt-debuginfo.x86_64: W: hidden-file-or-dir
/usr/src/debug/libsocialweb-qt-0.1.2/.moc
libsocialweb-qt-debuginfo.x86_64: W: hidden-file-or-dir
/usr/src/debug/libsocialweb-qt-0.1.2/.moc
libsocialweb-qt-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 1 errors, 4 warnings.
mostly harmless
Naming: ok
License: ok
Sources: meh, though hard to verify as-is. :-/
Builds/installs: ok, though
1. SHOULD: use versioned BuildRequires: rest-devel >= 0.7
2. SHOULD: move
sed -i 's|LIBDIR = .*$|LIBDIR = %{_libdir}|' libsocialweb-qt.pro
to %prep section, instead of %build
macros: ok
scriptlets: ok
I won't consider those SHOULD items blockers, but please do address them prior
to doing any official builds.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=706421
Stanislav Ochotnicky changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Stanislav Ochotnicky 2011-05-20
10:56:06 EDT ---
OK: rpmlint must be run on every package. The output should be posted in
the review.
wmname.src: W: spelling-error %description -l en_US hostname -> host name,
host-name, hostage
wmname.src: W: spelling-error %description -l en_US reparenting -> re
parenting, re-parenting, parenting
wmname.x86_64: W: spelling-error %description -l en_US hostname -> host name,
host-name, hostage
wmname.x86_64: W: spelling-error %description -l en_US reparenting -> re
parenting, re-parenting, parenting
wmname.x86_64: W: no-manual-page-for-binary wmname
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Would be nice to have a man page I guess. Not a requirement though.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
-: All independent sub-packages have License of their own (if it exists)
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
-: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
-: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
OK: Packages must NOT bundle copies of system libraries.
-: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
-: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
-: Header files must be in a -devel package.
-: Static libraries must be in a -static package.
-: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package.
-: In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
OK: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
-: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
OK: Packages must not own files or directories already owned by other packages.
The rule of th
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 Jaroslav Reznik changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Jaroslav Reznik 2011-05-20 11:21:48 EDT --- Thanks Rex => APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632056] Review Request: libsocialweb-qt - Qt4 API for libsocialweb client DBUS interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632056 --- Comment #3 from Rex Dieter 2011-05-20 11:18:50 EDT --- Looks like rest >= 0.7 is required, I'm seeing the following trying to build this on my f14 box against rest-0.6.4-2.fc14.1.x86_64 Package rest-0.7 was not found in the pkg-config search path. Perhaps you should add the directory containing `rest-0.7.pc' to the PKG_CONFIG_PATH environment variable No package 'rest-0.7' found Package rest-0.7 was not found in the pkg-config search path. Perhaps you should add the directory containing `rest-0.7.pc' to the PKG_CONFIG_PATH environment variable No package 'rest-0.7' found Package rest-0.7 was not found in the pkg-config search path. Perhaps you should add the directory containing `rest-0.7.pc' to the PKG_CONFIG_PATH environment variable No package 'rest-0.7' found Package rest-extras-0.7 was not found in the pkg-config search path. Perhaps you should add the directory containing `rest-extras-0.7.pc' to the PKG_CONFIG_PATH environment variable No package 'rest-extras-0.7' found Package rest-extras-0.7 was not found in the pkg-config search path. Perhaps you should add the directory containing `rest-extras-0.7.pc' to the PKG_CONFIG_PATH environment variable No package 'rest-extras-0.7' found Package rest-extras-0.7 was not found in the pkg-config search path. Perhaps you should add the directory containing `rest-extras-0.7.pc' to the PKG_CONFIG_PATH environment variable No package 'rest-extras-0.7' found -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678910] Review Request: kde-plasma-activitymanager - KDE plasma activity manager applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678910 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Alias||activitymanager Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632056] Review Request: libsocialweb-qt - Qt4 API for libsocialweb client DBUS interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632056 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Alias||libsocialweb-qt Flag||fedora-review? --- Comment #2 from Rex Dieter 2011-05-20 11:09:47 EDT --- I can take a stab at it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553606] Review Request: kde-plasma-birthday-reminder - Birthday Reminder Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553606 Rex Dieter changed: What|Removed |Added Status|NEW |CLOSED Resolution||NOTABUG Last Closed||2011-05-20 11:08:48 --- Comment #4 from Rex Dieter 2011-05-20 11:08:48 EDT --- let's close this out, ad it's been over a year hearing from reporter. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626122] Review Request: libqmf - Qt Messaging Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626122 Rex Dieter changed: What|Removed |Added Alias||libqmf -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706421 Petr Sabata changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Petr Sabata 2011-05-20 11:03:00 EDT --- New Package SCM Request === Package Name: wmname Short Description: Prints/sets the EWMH WM name property Owners: psabata Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=706421
--- Comment #3 from Petr Sabata 2011-05-20 11:01:47 EDT ---
(In reply to comment #2)
> OK: rpmlint must be run on every package. The output should be posted in
> the review.
>
> wmname.src: W: spelling-error %description -l en_US hostname -> host name,
> host-name, hostage
> wmname.src: W: spelling-error %description -l en_US reparenting -> re
> parenting, re-parenting, parenting
> wmname.x86_64: W: spelling-error %description -l en_US hostname -> host name,
> host-name, hostage
> wmname.x86_64: W: spelling-error %description -l en_US reparenting -> re
> parenting, re-parenting, parenting
> wmname.x86_64: W: no-manual-page-for-binary wmname
> 3 packages and 0 specfiles checked; 0 errors, 5 warnings.
>
> Would be nice to have a man page I guess. Not a requirement though.
I might write one in the future. The tools is fairly easy to use even without
it, though.
>
> OK: The package must be named according to the Package Naming Guidelines .
> OK: The spec file name must match the base package %{name}, in the format
> %{name}.spec unless your package has an exemption. .
> OK: The package must meet the Packaging Guidelines .
> OK: The package must be licensed with a Fedora approved license and meet the
> Licensing Guidelines .
> OK: The License field in the package spec file must match the actual license.
> OK: If (and only if) the source package includes the text of the license(s) in
> its own file, then that file, containing the text of the license(s) for the
> package must be included in %doc.
> -: All independent sub-packages have License of their own (if it exists)
> OK: The spec file must be written in American English.
> OK: The spec file for the package MUST be legible.
> OK: The sources used to build the package must match the upstream source, as
> provided in the spec URL. Reviewers should use md5sum for this task. If no
> upstream URL can be specified for this package, please see the Source URL
> Guidelines for how to deal with this.
> OK: The package MUST successfully compile and build into binary rpms on at
> least one primary architecture.
> OK: All build dependencies must be listed in BuildRequires, except for any
> that
> are listed in the exceptions section of the Packaging Guidelines ; inclusion
> of
> those as BuildRequires is optional. Apply common sense.
> -: The spec file MUST handle locales properly. This is done by using the
> %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
> -: Every binary RPM package (or subpackage) which stores shared library files
> (not just symlinks) in any of the dynamic linker's default paths, must call
> ldconfig in %post and %postun.
> OK: Packages must NOT bundle copies of system libraries.
> -: If the package is designed to be relocatable, the packager must state this
> fact in the request for review, along with the rationalization for relocation
> of that specific package. Without this, use of Prefix: /usr is considered a
> blocker.
> OK: A package must own all directories that it creates. If it does not create
> a
> directory that it uses, then it should require a package which does create
> that
> directory.
> OK: A Fedora package must not list a file more than once in the spec file's
> %files listings.
> OK: Permissions on files must be set properly. Executables should be set with
> executable permissions, for example. Every %files section must include a
> %defattr(...) line.
> OK: Each package must consistently use macros.
> OK: The package must contain code, or permissable content.
> -: Large documentation files must go in a -doc subpackage. (The definition of
> large is left up to the packager's best judgement, but is not restricted to
> size. Large can refer to either size or quantity).
> OK: If a package includes something as %doc, it must not affect the runtime of
> the application. To summarize: If it is in %doc, the program must run properly
> if it is not present.
> -: Header files must be in a -devel package.
> -: Static libraries must be in a -static package.
> -: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
> then
> library files that end in .so (without suffix) must go in a -devel package.
> -: In the vast majority of cases, devel packages must require the base package
> using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
> OK: Packages must NOT contain any .la libtool archives, these must be removed
> in the spec if they are built.
> -: Packages containing GUI applications must include a %{name}.desktop file,
> and that file must be properly installed with desktop-file-install in the
> %install section. If you feel that your packaged GUI application does not need
> a .desktop file, you must put a comment in the spec file with your
> explanation.
> OK: Packages must not own files or directori
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 --- Comment #4 from Rex Dieter 2011-05-20 10:57:07 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/libmygpo-qt/libmygpo-qt.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/libmygpo-qt/libmygpo-qt-1.0.2-2.fc14.src.rpm %changelog * Fri May 20 2011 Rex Dieter 1.0.2-2 - drop kde deps/macros, this is a qt-only library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706432] New: Review Request: aggregate - IPv4 CIDR prefix aggregator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: aggregate - IPv4 CIDR prefix aggregator https://bugzilla.redhat.com/show_bug.cgi?id=706432 Summary: Review Request: aggregate - IPv4 CIDR prefix aggregator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: yan...@declera.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://declera.com/~yaneti/aggregate/aggregate.spec SRPM URL: http://declera.com/~yaneti/aggregate/aggregate-1.6-1.fc16.src.rpm Description: aggregate takes a list of prefixes in conventional format on stdin, and performs two optimizations to attempt to reduce the length of the prefix list. The separate -ios package is for the perl dependency. rpmlint output: aggregate.x86_64: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate aggregate.x86_64: W: spelling-error %description -l en_US stdin -> stein, stain, stdio aggregate.x86_64: W: spelling-error %description -l en_US optimizations -> optimization, optimization's, optimization s aggregate-ios.x86_64: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate aggregate-ios.x86_64: W: spelling-error %description -l en_US stdin -> stein, stain, stdio 4 packages and 0 specfiles checked; 0 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #10 from Kalev Lember 2011-05-20 10:52:12 EDT --- If you're building for el6, I believe it needs the %clean section: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=679401
--- Comment #6 from Jaroslav Reznik 2011-05-20 10:44:13
EDT ---
(In reply to comment #5)
> licensing: OK
>
> scriptlets: OK
>
> naming: OK
>
> URL provided doesn't work for me, please find something better. Not a
> blocker.
>
> rpmlint: clean, OK
>
> builds/installs OK
>
> In a perfect world, I'd like to see comment #3 addressed too, wrt keeping
> library naming more consistent, using something from trever's .spec he showed
> us earlier today:
> %build
> echo 'yes' | \
> ./configure -library
>
> echo "QTSOAP_LIBNAME = \$\$qtLibraryTarget(qtsoap)" >> common.pri
> echo "VERSION=%{version}" >> common.pri
>
> qmake-qt4
>
> make %{?_smp_mflags}
>
>
> But, I'll leave it up to you on how best to resolve that (with some potential
> upstream poking). not a blocker.
>
>
>
> Otherwise, looks good, APPROVED
There's no upstream anymore but I'll try to incorporate this change into my
fedora qt-soap branch.
Thanks for review, good spot guys.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 Jon Ciesla changed: What|Removed |Added Flag||fedora-cvs? --- Comment #33 from Jon Ciesla 2011-05-20 10:43:07 EDT --- New Package SCM Request === Package Name: jogl Short Description: Java bindings for OpenGL Owners: limb Branches: F-15 F-14 InitialCC: Awesome, thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706421 Stanislav Ochotnicky changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com AssignedTo|nob...@fedoraproject.org|socho...@redhat.com Flag||fedora-review? --- Comment #1 from Stanislav Ochotnicky 2011-05-20 10:43:06 EDT --- I'll review this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 Bastien Nocera changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Bastien Nocera 2011-05-20 10:39:14 EDT --- New Package SCM Request === Package Name: grilo-plugins Short Description: Plugins for the Grilo framework Owners: hadess Branches: f15 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #8 from Bastien Nocera 2011-05-20 10:37:16 EDT --- grilo-0.1.15-3.fc16 is built, so I'll add it to the same update. http://people.fedoraproject.org/~hadess/grilo/grilo-plugins.spec and http://people.fedoraproject.org/~hadess/grilo/grilo-plugins-0.1.15-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 --- Comment #3 from Jaroslav Reznik 2011-05-20 10:38:47 EDT --- Name: ok Summary: ok Version & release: ok License: ok URL: ok Sources: ok, md5sum 6f88444c82e9840638ec16e366457dd7 Patch: review ok BRs: not ok, please drop kde-filesystem and replace cmake_kde4 with plain cmake Description: I don't like the URL there but it's up to you... Devel package: ok Ldconfig: ok Consistent macro usage: ok .so in -devel: ok Builds: locally, scratch build as attached rpmlint libmygpo-qt-1.0.2-1.fc15.src.rpm libmygpo-qt.src: W: spelling-error Summary(en_US) gpodder -> plodder, prodder, doddery libmygpo-qt.src: W: spelling-error %description -l en_US gpodder -> plodder, prodder, doddery 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ok Please fix the BRs issue and I'll approve it as it's really very simple library. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 Alexander Kurtakov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #32 from Alexander Kurtakov 2011-05-20 10:34:06 EDT --- Looks good. Finally this saga comes to an end. Now on to scilab. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698692
Kalev Lember changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Kalev Lember 2011-05-20 10:22:32 EDT
---
Fedora review grilo-plugins-0.1.15-3.src.rpm 2011-05-20
+ OK
! needs attention
koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3083534
$ rpmlint grilo-plugins \
grilo-plugins-0.1.15-3.src.rpm \
grilo-plugins-debuginfo-0.1.15-3.x86_64.rpm
grilo-plugins.src: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
grilo-plugins.src: W: spelling-error %description -l en_US fm -> FM, Fm, gm
grilo-plugins.src: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
grilo-plugins.x86_64: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
grilo-plugins.x86_64: W: spelling-error %description -l en_US fm -> FM, Fm, gm
grilo-plugins.x86_64: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
3 packages and 0 specfiles checked; 0 errors, 6 warnings.
+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
29efa89f3842787c21271a7513a9a1ab grilo-plugins-0.1.15.tar.bz2
29efa89f3842787c21271a7513a9a1ab Download/grilo-plugins-0.1.15.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
! Package currently doesn't own all directories it creates,
but it's going to be fixed in grilo package as per comment #4
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
It's a plugin package, not applicable.
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Remaining issues:
- add the missing directories to grilo package;
- take a look at comment #6 if you want to remove BuildRoot and %clean
- I'd suggest to add the %{?dist} macro to Release
These can all be fixed before importing the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 --- Comment #17 from Jaroslav Reznik 2011-05-20 10:21:14 EDT --- (In reply to comment #13) > Stable release available > ftp://ftp.kde.org/pub/kde/stable/kamoso/2.0.1/src/kamoso-2.0.1.tar.bz2 > Also afiestas going to fix license, so then I can add this pacth to 2.0.1 and > change license to GPLv2+. > So URL for now will be https://projects.kde.org/projects/kdereview/kamoso/? Thanks! For URL - I think the KDE project URL is better but it's going to change soon (hopefully) so I'm ok with kde-apps one too. It's up to you. Maybe use that kdereview one and comment it as TODO to be changed soon. Please update package to 2.0.1 with the license fix and I'll approve this package, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #6 from Kalev Lember 2011-05-20 10:21:40 EDT --- (In reply to comment #4) > > 1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of > > %install > > section, the whole %clean section, and the %defattr lines are no longer > > needed > > in current Fedora releases and you could remove them, if you want to. > > Done. I'm just nitpicking here, it's not very important, but ... looks like you missed the the BuildRoot definition near the top of the spec file and the %clean section, these can also be removed. > > 4) The source URL currently looks like this: [...] > Pretty much every single GNOME tarball has that exact same problem. Yeah. If we can figure out a good way to do it, it's something that other GNOME packages could also use. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690282] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 --- Comment #31 from Jon Ciesla 2011-05-20 10:22:19 EDT --- SPEC: http://zanoni.jcomserv.net/fedora/jogl/jogl.spec SRPM: http://zanoni.jcomserv.net/fedora/jogl/jogl-1.1.1a-5.fc14.src.rpm Addressed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706421] New: Review Request: wmname - Prints/sets the EWMH WM name property
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: wmname - Prints/sets the EWMH WM name property https://bugzilla.redhat.com/show_bug.cgi?id=706421 Summary: Review Request: wmname - Prints/sets the EWMH WM name property Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: psab...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://psabata.fedorapeople.org/pkgs/wmname/wmname.spec SRPM URL: http://psabata.fedorapeople.org/pkgs/wmname/wmname-0.1-1.fc14.src.rpm Description: wmname prints/sets the window manager name property of the root window similar to how hostname(1) behaves. wmname is a nice utility to fix problems with JDK versions and other broken programs assuming a reparenting window manager for instance. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688886] Review Request: kflickr - Standalone Flickr Uploader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=66 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Alias||kflickr Flag||fedora-review? --- Comment #8 from Rex Dieter 2011-05-20 10:16:23 EDT --- I can review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706310] Need EPEL-6 branches of mkelfimage wraplinux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706310 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi 2011-05-20 10:19:09 EDT --- done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679401] Review Request: qtsoap - The Simple Object Access Protocol Qt-based client side library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679401 Rex Dieter changed: What|Removed |Added Alias||qtsoap -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703488] Review Request: libmygpo-qt - Qt Library that wraps the gpodder.net Web API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703488 Rex Dieter changed: What|Removed |Added Alias||libmygpo-qt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 Jaroslav Reznik changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jaroslav Reznik 2011-05-20 10:11:27 EDT --- New Package SCM Request === Package Name: prison Short Description: A Qt-based barcode abstraction library Owners: jreznik rdieter Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 --- Comment #3 from Jaroslav Reznik 2011-05-20 10:05:25 EDT --- Just a simple cosmetic change as rdieter pointed out on IRC. Spec URL: http://rezza.hofyland.cz/fedora/packages/prison/prison.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/prison/prison-1.0-2.fc14.src.rpm Thanks Rex for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 Rex Dieter changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter 2011-05-20 10:03:22 EDT --- naming: ok sources: ok 8baac61506e37a31482a0df4a5d02cd2 prison-1.0.tar.gz macros: ok scriptlets: ok builds/installs: ok licensing: ok Otherwise, fairly simple pkg, with no other issues. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] New: Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: prison - A Qt-based barcode abstraction library https://bugzilla.redhat.com/show_bug.cgi?id=706409 Summary: Review Request: prison - A Qt-based barcode abstraction library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jrez...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://rezza.hofyland.cz/fedora/packages/prison/prison.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/prison/prison-1.0-1.fc14.src.rpm Description: Prison is a Qt-based barcode abstraction layer/library that provides an uniform access to generation of barcodes with data. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3083456 rpmlint prison-* prison.x86_64: W: spelling-error Summary(en_US) barcode -> bar code, bar-code, barcarole prison.x86_64: W: spelling-error %description -l en_US barcode -> bar code, bar-code, barcarole prison.x86_64: W: spelling-error %description -l en_US barcodes -> bar codes, bar-codes, barcaroles prison-devel.x86_64: W: no-documentation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 Rex Dieter changed: What|Removed |Added Blocks||656997(kde-reviews) Alias||prison -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706400 Rex Dieter changed: What|Removed |Added Alias||libqzeitgeist -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591192] Review Request: dh-make - Tool that converts source archives into Debian package source
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591192 Miroslav Suchý changed: What|Removed |Added Flag||needinfo?(kanarip@kanarip.c ||om) --- Comment #12 from Miroslav Suchý 2011-05-20 09:47:34 EDT --- Ping. Oron, can you close this BZ, since the review is done? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706409] Review Request: prison - A Qt-based barcode abstraction library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706409 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu QAContact|extras...@fedoraproject.org |rdie...@math.unl.edu Flag||fedora-review? --- Comment #1 from Rex Dieter 2011-05-20 09:49:25 EDT --- I can review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706400 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Rex Dieter 2011-05-20 09:46:08 EDT --- New Package SCM Request === Package Name: libqzeitgeist Short Description: Qt Zeitgeist Library Owners: rdieter tdfischer Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556128] Review Request: ff-utils - Utilities to test force feedback of input device
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556128
Miroslav Suchý changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #12 from Miroslav Suchý 2011-05-20 09:44:10 EDT
---
rpmlint errors:
ff-utils-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ff-utils/ffmvforce.c
ff-utils-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ff-utils/ffset.c
ff-utils-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ff-utils/fftest.c
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
tested in: f16/koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=3083368
[!] Rpmlint output:
see above
[x] Package is not relocatable.
[x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
$ md5sum ff-utils.tar.bz2 ../SOURCES/ff-utils.tar.bz2
37f5197aa38362cac1364d3d9f409912 ff-utils.tar.bz2
37f5197aa38362cac1364d3d9f409912 ../SOURCES/ff-utils.tar.bz2
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[x] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
2.4.21
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: koji scratch build
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on:koji scratch build
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[-] %check is present and the tests pass
I would say that the rpmlint error is not blocking, but please contact upstream
and fix the FSF address.
*** APPROVED ***
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533167 Karel Klíč changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from Karel Klíč 2011-05-20 09:42:04 EDT --- New Package SCM Request === Package Name: emacs-ecb Short Description: Emacs Code Browser Owners: kklic Branches: f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698692 --- Comment #5 from Bastien Nocera 2011-05-20 09:41:56 EDT --- http://people.fedoraproject.org/~hadess/grilo/grilo-plugins.spec http://people.fedoraproject.org/~hadess/grilo/grilo-plugins-0.1.15-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533167 --- Comment #16 from Karel Klíč 2011-05-20 09:41:06 EDT --- Thank you for the review, I'm glad for it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698692
--- Comment #4 from Bastien Nocera 2011-05-20 09:41:27 EDT
---
(In reply to comment #3)
> Taking for review.
>
> 1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of
> %install
> section, the whole %clean section, and the %defattr lines are no longer needed
> in current Fedora releases and you could remove them, if you want to.
Done.
> 2) You are removing %{_libdir}/grilo-0.1/*.a in %install section after
> building
> them, but it might be cleaner to avoid building the static libs in the first
> place. Does configure --disable-static work for this package?
That works indeed.
> 3) Some of the directories aren't owned by any package and that would cause
> empty directories to be left behind when uninstalling the package.
> Either (a) grilo, or (b) all grilo's plugin packages should own these dirs:
> %{_libdir}/grilo-0.1/
> %{_datadir}/grilo-0.1/
> %{_datadir}/grilo-0.1/plugins/
I'll add those directories in grilo itself.
> 4) The source URL currently looks like this:
> http://ftp.gnome.org/pub/GNOME/sources/grilo-plugins/0.1/grilo-plugins-%{version}.tar.bz2
>
> It might be nice to automatically figure out the '0.1' directory name, so that
> it would only be necessary to update the Version: field when building updates.
> I have used shell scripting in a some packages to accomplish that; not sure if
> it's something you'd want to use here.
Pretty much every single GNOME tarball has that exact same problem.
> At the top of the spec file I've put this:
> # first two digits of version
> %define release_version %(echo %{version} | awk -F. '{print $1"."$2}')
>
> ... and in the Source0 tag, instead of the hardcoded '0.1' goes
> %{release_version} macro.
But I've done that now.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=706400
Trever Fischer changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Trever Fischer 2011-05-20 09:38:16 EDT ---
> URL: https://gitorious.org/kde-zeitgeist/libqzeitgeist
As a heads up, we've moved it to
http://projects.kde.org/projects/kdesupport/libqzeitgeist. That can be fixed
for next release though.
> BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
Your build root looks unusual to me, since it deviates from the one I'm used to
seeing in /etc/rpmdevtools/spectemplate-lib.spec. I'm also still in the stone
age and running fedora 14 ;)
Other than those two, its a quick and simple package and works like it says on
the tin.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706400 --- Comment #5 from Rex Dieter 2011-05-20 09:40:06 EDT --- I guess an explicit buildroot is not needed on modern fedora systems, so I'll just drop that piece. And, I'll update the URL prior to doing any official builds, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=698692
Kalev Lember changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||ka...@smartlink.ee
AssignedTo|nob...@fedoraproject.org|ka...@smartlink.ee
Flag||fedora-review?
--- Comment #3 from Kalev Lember 2011-05-20 09:35:11 EDT
---
Taking for review.
1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of %install
section, the whole %clean section, and the %defattr lines are no longer needed
in current Fedora releases and you could remove them, if you want to.
2) You are removing %{_libdir}/grilo-0.1/*.a in %install section after building
them, but it might be cleaner to avoid building the static libs in the first
place. Does configure --disable-static work for this package?
3) Some of the directories aren't owned by any package and that would cause
empty directories to be left behind when uninstalling the package.
Either (a) grilo, or (b) all grilo's plugin packages should own these dirs:
%{_libdir}/grilo-0.1/
%{_datadir}/grilo-0.1/
%{_datadir}/grilo-0.1/plugins/
4) The source URL currently looks like this:
http://ftp.gnome.org/pub/GNOME/sources/grilo-plugins/0.1/grilo-plugins-%{version}.tar.bz2
It might be nice to automatically figure out the '0.1' directory name, so that
it would only be necessary to update the Version: field when building updates.
I have used shell scripting in a some packages to accomplish that; not sure if
it's something you'd want to use here.
At the top of the spec file I've put this:
# first two digits of version
%define release_version %(echo %{version} | awk -F. '{print $1"."$2}')
... and in the Source0 tag, instead of the hardcoded '0.1' goes
%{release_version} macro.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609817] Review Request: dojo - Modular JavaScript toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609817 Andrew Colin Kissa changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Andrew Colin Kissa 2011-05-20 09:31:31 EDT --- Miroslav, Thanks for the review, New Package SCM Request === Package Name: dojo Short Description: Modular JavaScript toolkit Owners: topdog Branches: f13 f14 f15 el5 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 Robert Scheck changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Robert Scheck 2011-05-20 09:33:54 EDT --- Trever, thank you very much for the review. New Package SCM Request === Package Name: mod_flvx Short Description: FLV progressive download streaming for the Apache HTTP Server Owners: robert Branches: el4 el5 el6 f13 f14 f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688121 Trever Fischer changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Trever Fischer 2011-05-20 09:23:30 EDT --- I suppose that since other packages (especially the critical fcgid) are doing it, that sets a precedent. Approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 609817] Review Request: dojo - Modular JavaScript toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609817 Miroslav Suchý changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Miroslav Suchý 2011-05-20 09:24:11 EDT --- Hmmm, yes you are right. And if I have installed boa, then the dir /etc/httpd/conf.d will does not exist I would say if somebody will have to use it with something else, he must install httpd and disable that service and manualy configure it for its own server. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706400] Review Request: libqzeitgeist - Qt Zeitgeist Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706400 Trever Fischer changed: What|Removed |Added CC||wm...@wm161.net Flag||fedora-review? --- Comment #2 from Trever Fischer 2011-05-20 09:17:22 EDT --- I can review. Bonus: I'm upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705108] Review Request: shinken - python monitoring tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #2 from David Hannequin 2011-05-20 09:20:41 EDT --- Hi, Unitdir macro is defined in the file /etc/rpm/macros.systemd. I corrected the other errors before putting a new spec file. Best regard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
