[Bug 707885] Review Request: rubygem-bson - Ruby implementation of BSON
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707885 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-05-30 02:45:04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707613
--- Comment #9 from Ankur Sinha 2011-05-30 00:55:33
EDT ---
(In reply to comment #7)
> Hi Ankur!
>
> Here it goes the review: +/!/- mean ok/bad/does not apply
>
> ! MUST: rpmlint must be run on the source rpm and all binary rpms the build
> produces. The output should be posted in the review.
>
> rpmlint in not silent:
>
> [mario@shadow rpmbuild]$ rpmlint SRPMS/dcm4che-test-2.6-1.fc15.src.rpm
> RPMS/noarch/dcm4che-test-2.6-1.fc15.noarch.rpm
> RPMS/noarch/dcm4che-test-javadoc-2.6-1.fc15.noarch.rpm
> dcm4che-test.src: W: invalid-license GPLv2.0
> dcm4che-test.src: W: invalid-license LGPLv2.1
> dcm4che-test.src: W: invalid-url Source0: dcm4che2-test-2.6.tar.gz
> dcm4che-test.noarch: W: invalid-license GPLv2.0
> dcm4che-test.noarch: W: invalid-license LGPLv2.1
> dcm4che-test.noarch: W: no-documentation
> dcm4che-test.noarch: W: non-conffile-in-etc /etc/maven/fragments/dcm4che-test
> dcm4che-test-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java
> docs, Java-docs, Avocados
> dcm4che-test-javadoc.noarch: W: invalid-license GPLv2.0
> dcm4che-test-javadoc.noarch: W: invalid-license LGPLv2.1
> dcm4che-test-javadoc.noarch: E: script-without-shebang
> /usr/share/javadoc/dcm4che-test/apidocs/javadoc.sh
>
>
> Please consider:
> - use recognized license names (rpmlint -i will give you the names)
Corrected.
> - mark /etc/maven/fragments/dcm4che-test as a conf-file, if you feel it
> correct
I checked up another java package spec. maven fragments are not marked as conf
files it looks like.
>
> ! MUST: The package must be named according to the Package Naming Guidelines .
>
> Why do you not call the package dcm4che2-test instead of dcm4che-test?
the "2" in "dcm4che2" stands for versioning. It's not a lot of use including it
in the name. dcm4che2-2 is redundant IMO?
>
> Moreover, as it is a svn checkout, I think it should be named accordingly.
> However I understand that this is tagged as a stable release, so it's your
> decision.
>
Corrected.
> + MUST: The spec file name must match the base package %{name}, in the format
> %{name}.spec unless your package has an exemption.
> + MUST: The package must meet the Packaging Guidelines .
> + MUST: The package must be licensed with a Fedora approved license and meet
> the Licensing Guidelines .
>
> ! MUST: The License field in the package spec file must match the actual
> license.
>
> Please use a name recognized by rpmlint
>
Corrected.
> - MUST: If (and only if) the source package includes the text of the
> license(s)
> in its own file, then that file, containing the text of the license(s) for the
> package must be included in %doc.
> + MUST: The spec file must be written in American English.
> + MUST: The spec file for the package MUST be legible.
>
> ! MUST: The sources used to build the package must match the upstream source,
> as provided in the spec URL. Reviewers should use md5sum for this task. If no
> upstream URL can be specified for this package, please see the Source URL
> Guidelines for how to deal with this.
>
> They differs:
>
> [mario@shadow dcm4che2]$ svn co
> https://dcm4che.svn.sourceforge.net/svnroot/dcm4che/dcm4che2-test/tags/dcm4che2-test-2.6
> [mario@shadow dcm4che2]$ tar -cvzf dcm4che2-test-2.6.tar.gz dcm4che2-test-2.6/
> [mario@shadow dcm4che2]$ md5sum dcm4che2-test-2.6.tar.gz
> 9023b1143b1089fbaaedb752dfb8139a dcm4che2-test-2.6.tar.gz
>
> [mario@shadow dcm4che2]$ md5sum
> /home/mario/rpmbuild/SOURCES/dcm4che2-test-2.6.tar.gz
> 07e709c479df9301324053e2d605309f
> /home/mario/rpmbuild/SOURCES/dcm4che2-test-2.6.tar.gz
>
I've done a fresh svn export and made the tar. This shouldn't happen now.
>
> + MUST: The package MUST successfully compile and build into binary rpms on at
> least one primary architecture.
>
> The package successfully builds in koji:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3098038
>
> - MUST: If the package does not successfully compile, build or work on an
> architecture, then those architectures should be listed in the spec in
> ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
> bugzilla, describing the reason that the package does not compile/build/work
> on
> that architecture. The bug number MUST be placed in a comment, next to the
> corresponding ExcludeArch line.
> + MUST: All build dependencies must be listed in BuildRequires, except for any
> that are listed in the exceptions section of the Packaging Guidelines ;
> inclusion of those as BuildRequires is optional. Apply common sense.
> - MUST: The spec file MUST handle locales properly. This is done by using the
> %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
> - MUST: Every binary RPM package (or subpackage) which stores shared library
> files (not just symlinks) in any of the dynam
[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533167 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||emacs-ecb-2.40.1-0.4.cvs201 ||01021.fc15 Resolution||ERRATA Last Closed||2011-05-29 19:22:34 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533167 --- Comment #22 from Fedora Update System 2011-05-29 19:22:24 EDT --- emacs-ecb-2.40.1-0.4.cvs20101021.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684429] Review Request: wbfs-manager - A WBFS manager for Linux using GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684429 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||wbfs-manager-0.1.12-1.fc13 Resolution||ERRATA Last Closed||2011-05-29 19:20:16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684429] Review Request: wbfs-manager - A WBFS manager for Linux using GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684429 --- Comment #15 from Fedora Update System 2011-05-29 19:20:10 EDT --- wbfs-manager-0.1.12-1.fc13 has been pushed to the Fedora 13 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 187843] Review Request: phpMyAdmin - Web based MySQL browser written in php
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=187843 Robert Scheck changed: What|Removed |Added Flag||fedora-cvs? --- Comment #37 from Robert Scheck 2011-05-29 17:52:14 EDT --- As far as I can see, our pkgdb isn't able to update the short description, so let's do it here: Package Change Request == Package Name: phpMyAdmin Short Description: Handle the administration of MySQL over the World Wide Web -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 Mario Ceresa changed: What|Removed |Added CC||dw...@infradead.org Component|Package Review |0x Flag|fedora-review? | --- Comment #21 from Mario Ceresa 2011-05-29 17:02:22 EDT --- Just a note for me to remember where new rpms are: http://koji.fedoraproject.org/koji/taskinfo?taskID=3099422 This should fix the permission problems, some more sonames and the dcmtk, minizip and shapelib issues. I'll continue to work on the problem with the installation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705108] Review Request: shinken - python monitoring tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #7 from David Hannequin 2011-05-29 16:46:20 EDT --- Hi, What do you mean "What about the unit tests?" ? Shinken RPMs work fine and i tested on Fedora 15. You can see -> http://hvad.fedorapeople.org/fedora/shinken/shinken.txt. Best regard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708842] New: Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences https://bugzilla.redhat.com/show_bug.cgi?id=708842 Summary: Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mgold...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://goldmann.fedorapeople.org/package_review/jansi/1/jansi.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jansi/1/jansi-1.5-1.fc16.src.rpm Description: Jansi is a small java library that allows you to use ANSI escape sequences in your Java console applications. It implements ANSI support on platforms which don't support it like Windows and provides graceful degradation for when output is being sent to output devices which cannot support ANSI sequences. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708842] Review Request: jansi - Jansi is a java library for generating and interpreting ANSI escape sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708842 Marek Goldmann changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||708669, 708836 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708836] Review Request: jansi-native - Jansi Native implements the JNI Libraries used by the Jansi project.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708836 Marek Goldmann changed: What|Removed |Added Blocks||708842 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705108] Review Request: shinken - python monitoring tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #6 from Volker Fröhlich 2011-05-29 16:16:16 EDT --- The buildroot definition is also unnecessary then. Please take a look at the result of licensecheck: ... shinken/contactdowntime.py: AGPL (v3 or later) shinken/bin.py: AGPL (v3 or later) shinken/db_oracle.py: AGPL (v3 or later) shinken/log.py: AGPL (v3 or later) ... All the files say AGPLv3+ -- not AGPLv3. Why don't you include FROM_NAGIOS_TO_SHINKEN? Is it not relevant to users of Shinken? With "changelog" I meant what's inside the spec file. Just by looking at the changelog "you fixed something and you replaced some macro". Just put it there like you put it above. What about the unit tests? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708836] New: Review Request: jansi-native - Jansi Native implements the JNI Libraries used by the Jansi project.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jansi-native - Jansi Native implements the JNI Libraries used by the Jansi project. https://bugzilla.redhat.com/show_bug.cgi?id=708836 Summary: Review Request: jansi-native - Jansi Native implements the JNI Libraries used by the Jansi project. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mgold...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://goldmann.fedorapeople.org/package_review/jansi-native/1/jansi-native.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jansi-native/1/jansi-native-1.1-1.fc16.src.rpm Description: Jansi is a small java library that allows you to use ANSI escape sequences in your Java console applications. It implements ANSI support on platforms which don't support it like Windows and provides graceful degradation for when output is being sent to output devices which cannot support ANSI sequences. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708836] Review Request: jansi-native - Jansi Native implements the JNI Libraries used by the Jansi project.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708836 Marek Goldmann changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||708670, 708669 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 Marek Goldmann changed: What|Removed |Added Blocks||708836 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708820] New: Review Request: python-async - A framework to process interdependent tasks in a pool of workers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-async - A framework to process interdependent tasks in a pool of workers https://bugzilla.redhat.com/show_bug.cgi?id=708820 Summary: Review Request: python-async - A framework to process interdependent tasks in a pool of workers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jkeat...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://jkeating.fedorapeople.org/review/python-async.spec SRPM URL: http://jkeating.fedorapeople.org/review/python-async-0.6.1-1.gite91b469.fc14.src.rpm Description: Async aims to make writing asyncronous processing easier. It provides a task-graph with interdependent tasks that communicate using blocking channels, allowing to delay actual computations until items are requested. Tasks will automatically be distributed among 0 or more threads for the actual computation. A scratch build was done at http://koji.fedoraproject.org/koji/taskinfo?taskID=3099332 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708826] New: Review Request: python-gitdb - A pure-Python git object database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-gitdb - A pure-Python git object database https://bugzilla.redhat.com/show_bug.cgi?id=708826 Summary: Review Request: python-gitdb - A pure-Python git object database Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jkeat...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://jkeating.fedorapeople.org/review/python-gitdb.spec SRPM URL: http://jkeating.fedorapeople.org/review/python-gitdb-0.5.2-1.git17d9d13.fc16.src.rpm Description: GitDB allows you to access bare git repositories for reading and writing. It aims at allowing full access to loose objects as well as packs with performance and scalability in mind. It operates exclusively on streams, allowing to operate on large objects with a small memory footprint. A scratch build was done at http://koji.fedoraproject.org/koji/taskinfo?taskID=3099400 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 --- Comment #13 from Fedora Update System 2011-05-29 14:41:41 EDT --- pydf-9-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pydf-9-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 Clint Savage changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-05-29 14:44:52 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664912] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664912 --- Comment #7 from Josh 2011-05-29 14:40:41 EDT --- (In reply to comment #6) > Yeap. It's possible not to specify version for perl(HTML::TreeBuilder::XPath). Does that mean the package is now approved since both FIX items have been resolved? Looking forward to getting rt4 packaged! Thanks, -josh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 --- Comment #12 from Fedora Update System 2011-05-29 14:40:58 EDT --- pydf-9-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/pydf-9-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 --- Comment #11 from Fedora Update System 2011-05-29 14:40:00 EDT --- pydf-9-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pydf-9-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 --- Comment #10 from Fedora Update System 2011-05-29 14:37:28 EDT --- pydf-9-3.el5.1 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/pydf-9-3.el5.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701347 Kalev Lember changed: What|Removed |Added Summary|Review Request: |Review Request: |mingw32-gtkmm30 - MinGW |mingw-gtkmm30 - MinGW |Windows C++ interface for |Windows C++ interface for |the GTK+ library|the GTK+ library --- Comment #4 from Kalev Lember 2011-05-29 13:51:44 EDT --- mingw32-gtk3 is imported and built, so it's no longer blocking this review. * Sun May 29 2011 Kalev Lember - 3.0.1-2 - Renamed the base package to mingw-gtkmm30 as per updated guidelines - Use the automatic dep extraction available in mingw32-filesystem 68 Spec URL: http://kalev.fedorapeople.org/mingw-gtkmm30.spec SRPM URL: http://kalev.fedorapeople.org/mingw-gtkmm30-3.0.1-2.fc15.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3099122 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708670] Review Request: hawtjni - Code generator that produces the JNI code needed to implement java native methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708670 --- Comment #1 from Marek Goldmann 2011-05-29 13:44:22 EDT --- Updated spec and srpm files to include maven-hawtjni-plugin: Spec URL: http://goldmann.fedorapeople.org/package_review/hawtjni/2/hawtjni.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/hawtjni/2/hawtjni-1.1-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705108] Review Request: shinken - python monitoring tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #5 from David Hannequin 2011-05-29 13:29:06 EDT --- Hi, I want to package Shinken only in Fedora 15 and higher. I now use %global instead of %define. There is no patch for this release but I keep in mind your remark about the - b of the patch command. I removed the macro commands to install and others. FROM_NAGIOS_TO_SHINKEN the file is not included in the RPM. I do not understand your comment. The files are specific to Fedora fedora folder. New spec file and SRPM : Spec URL: http://hvad.fedorapeople.org/fedora/shinken/shinken.spec SRPM URL: http://hvad.fedorapeople.org/fedora/shinken/shinken-0.6.4-2.fc15.src.rpm Best regard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700815] Review Request: mingw-gtk3 - MinGW Windows GTK+ library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700815 Kalev Lember changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||mingw-gtk3-3.0.10-1.fc16 Resolution||NEXTRELEASE Last Closed||2011-05-29 11:58:19 --- Comment #16 from Kalev Lember 2011-05-29 11:58:19 EDT --- As discussed on the mailing list [1], I fixed mingw32-filesystem macros to produce mingw32- prefixed debuginfo subpackages. It's a transparent change and spec files don't need any modifications. [1] http://lists.fedoraproject.org/pipermail/mingw/2011-May/003708.html mingw-gtk3-3.0.10-1.fc16 imported and built for rawhide, closing the ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 701347] Review Request: mingw32-gtkmm30 - MinGW Windows C++ interface for the GTK+ library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701347 Bug 701347 depends on bug 700815, which changed state. Bug 700815 Summary: Review Request: mingw-gtk3 - MinGW Windows GTK+ library https://bugzilla.redhat.com/show_bug.cgi?id=700815 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 --- Comment #9 from Jason Tibbitts 2011-05-29 11:22:04 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 --- Comment #12 from Jason Tibbitts 2011-05-29 11:21:42 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=707613
Peter Lemenkov changed:
What|Removed |Added
CC||lemen...@gmail.com
--- Comment #8 from Peter Lemenkov 2011-05-29 11:21:48 EDT
---
(In reply to comment #2)
> Hi Ankur!
> - if it is taken from a svn checkout, shouldn't it be named accordingly?
> (http://fedoraproject.org/wiki/Packaging:NamingGuidelines). Something like
> dcm4chee-test-2.6-MMDDsvn?
Correct. The versioning scheme is wrong. It must indicate that it was built
feom SCM snapshot. The %{release} field should contain something like this:
0..MMDDsvn%{svn_rev}
Note the leading zero before actual rpm release number.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 696052] Review Request: texlive-tetex-cmsuper - The CM-Super font set
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=696052
Mohamed El Morabity changed:
What|Removed |Added
Flag|needinfo?(pikachu.2014@gmai |
|l.com) |
--- Comment #6 from Mohamed El Morabity 2011-05-29
11:02:18 EDT ---
Sorry for this late answer, the promotion of the Fedora 15 release took me much
time ^^
The job you've done with this new version is really impressive! We are near to
approve this package :)
Just some comments anyway:
* in %post, you can summarize all the updmap-sys calls with a for loop:
%post -n %{texfontpkg}
texhash
conffile="$(texconfig-sys conf | grep updmap.cfg)"
if [ "$1" -eq "1" ]; then
for map_file in cm-super-{t1,t2a,t2b,t2c,ts1,x2}; do
updmap-sys --quiet --nohash --cnffile ${conffile} --enable Map
$map_file
done
fi
You can do the same in %postun
* Don't forget to install the type1ec.sty package file provided in the archive
(in %{buildroot}%{texfonts}/tex/latex/%{fontpkg}/).
* In the tex-cm-super subpackage, you can remove the following Provides:
Provides: tetex-font-cm-super = %{version}-%{release}
It was a legacy from the time when TeX packages not part of teTeX where name
tetex-something instead of tex-something nowadays.
> 2. I'm not sure if these fonts are required in /usr/share/fonts at all, since
> the use for them outside of TeX seems to be very limited.
These fonts can be used outside the TeX world, as for the LGC ones. So they
should be available to anyone wanting to use such fonts without using LaTeX.
> Also please note, that installation of ctan-cm-super-*-fonts-* packages may
> cause BIG X11 hangups (up to dozens of seconds). Don't know if this can be
> fixed, seems to be Gnome/X11 issue, not the font packages.
It comes probably from the post-actions automatically added to the font
packages (call of fc-cache). Since these packages contain a huge number of
fonts to be analysed, this may be understable.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700962] Review Request: pydf - Fully colorized df clone written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700962 Clint Savage changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Clint Savage 2011-05-29 10:46:36 EDT --- New Package SCM Request === Package Name: pydf Short Description: Fully colorized df clone written in python Owners: herlo Branches: f15, f14, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 Adam Huffman changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Adam Huffman 2011-05-29 10:42:26 EDT --- New Package SCM Request === Package Name: mmseq Short Description: Haplotype and isoform specific expression estimation for RNA-seq Owners: verdurin Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690919] Review Request: aswvdial - Dockapp for wvdial
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 Robert Scheck changed: What|Removed |Added CC||red...@linuxnetz.de --- Comment #10 from Robert Scheck 2011-05-29 10:44:22 EDT --- Yes, you're completely right, Martin. I'm very sorry for the licensing thing, Mario. And please don't forget to apply the opt. flags (as mentioned in comment #9) by using the same style as in the rest of the spec file: http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567086
--- Comment #20 from Peter Lemenkov 2011-05-29 10:37:53
EDT ---
Great work!
Unfortunately there are still some remaining issues.
+/- rpmlint is NOT silent:
sulaco ~/Desktop: rpmlint vxl-*
vxl.src:108: W: macro-in-comment %{_docdir}
vxl.src:108: W: macro-in-comment %{name}
vxl.src:109: W: macro-in-comment %{_docdir}
vxl.src:109: W: macro-in-comment %{name}
^^^ these should be ignored (harmless)
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libbrct.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvil.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libnetlib.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libv3p_netlib.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvil1.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvul.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvgl_algo.so.1.14.0
exit@GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libmvl.so.1.14.0
exit@GLIBC_2.2.5
^^^ these ones indicates a flaw in the library's API design (the library
shouldn't call exit but rather return error code to the main application
allowing it to clean up stuff). This is not a blocker (you can't do much here)
but I advise you to notice upstream about this.
vxl.x86_64: W: no-manual-page-for-binary octree
^^^ as said - no man-page for the particular binary. Let's hope that someone
will write this man-page sometime.
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+double.3-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/algo/Templates/vgl_orient_box_3d_operators+double-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/Templates/vgl_infinite_line_3d+double-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/bsta_von_mises.h
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vnl/io/Templates/vnl_io_vector_fixed+float.2-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/gel/mrc/vpgl/bgeo/bgeo_sun_pos.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/Templates/vgl_infinite_line_3d+float-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_gaussian_sphere+double.2-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vil/Templates/vil_image_view+vil_rgb+bool--.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/algo/Templates/vgl_orient_box_3d_operators+float-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vil/Templates/vil_image_view+vil_rgba+bool--.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vil/Templates/vil_rgb+bool-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+float.3-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+double.2-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/Templates/vgl_infinite_line_3d+int-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+float.2-.cxx
vxl-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/bsta_von_mises.txx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/vgl_infinite_line_3d.h
vxl-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/vxl-1.14.0/core/vgl/vgl_infinite_line_3d.txx
^^^ Please fix permissions on source files during %prep stage to suppress these
messages.
vxl-devel.x86_64: E: invalid-soname /usr/lib64/libexpat.so libexpat.so
^^^ that sounds like an issue - still no soname for this and several other
libraries. They are *not* a symlinks to the corresponding libraries with a
suffix. Namely:
- libexpat.so
- libmvl2.so
- libvepl2.so
And there is another one possible issue - some libraries have too generic names
(libexpat.so.* and many others) and might interfere with other ones. Could you,
please, put them under dedicated directory? Under something like
%{_libdir}/%{name} (with corresponding /etc/ld.so.conf.d/*.conf file). I'm open
for suggestions here.
vxl-devel.x86_64: W: no-documentation
^^^ may be omitted - we have a separate package for docs.
5 packages and 0 specfiles checked; 3 errors, 31 warnings.
sulaco ~/Desktop:
- Bundled library - v3
[Bug 706705] Review Request: libmtag-python - Simple python bindings for libmtag music tagging library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706705 Hans de Goede changed: What|Removed |Added Status|NEW |ASSIGNED Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com Flag||fedora-review? --- Comment #1 from Hans de Goede 2011-05-29 09:06:10 EDT --- Taking this one, I'll also sponsor Felipe once this review is done Full review done: Good: - rpmlint checks return: rpmlint rpmbuild/SRPMS/libmtag-python-0.3.1-1.fc15.src.rpm rpmbuild/RPMS/x86_64/libmtag-python-* libmtag-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libmtag.so libmtag.so()(64bit) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. These can all be ignored - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: === -package does not meet naming guidelines, python modules should be called python-name rather then name-python, see: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 So the package (and the specfile) should be named python-libmtag, I realize this contradicts what upstream does, but Fedora names all python modules this way for consistency -There is no clear license info available in the upstream source tarbal, please ask upstream (I think that may mean asking yourself :) to add a LICENSE file and proper copyright headers to the source files. -Please include NEWS in the %doc files -It is ok to include the egginfo file in the Fedora package, see: http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns But if you consider it not useful to have it is ok to leave it out too -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #15 from Hans de Goede 2011-05-29 08:59:06 EDT --- Correction to previous comment, the license is LGPLv2, which is mentioned correctly in the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571019] Review Request: libmtag - An advanced C music tagging library with a simple API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 Hans de Goede changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag||fedora-review+ --- Comment #14 from Hans de Goede 2011-05-29 08:55:35 EDT --- Full review done (again): Good: - rpmlint checks return: rpmlint rpmbuild/SRPMS/libmtag-0.3.6-1.fc15.src.rpm rpmbuild/RPMS/x86_64/libmtag-* libmtag.src: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end libmtag.x86_64: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end libmtag-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. These can all be ignored - package meets naming guidelines - package meets packaging guidelines - license (GPLv2) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Approved! I'll sponsor you once python-libmtag is also approved, removing the needsponsor blocker -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708765] New: Review Request: Frogr - Flickr Remote Organizer for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Frogr - Flickr Remote Organizer for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=708765 Summary: Review Request: Frogr - Flickr Remote Organizer for GNOME Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mari...@freenet.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/frogr.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/frogr-0.5-1.fc15.src.rpm Description: Frogr intends to be a complete GNOME application to remotely manage a flickr account from the desktop. It uses flickcurl, from Dave Beckett to communicate with the server through the publicly available flickr REST API. The program doesn't provide all the expected features yet, seems it needs additional libraries which are not requested during the build process. Stay tuned, I try to find them out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644711] Review Request: diaser - disk based backup volume accumulator, replication and management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 Damian L Brasher changed: What|Removed |Added Flag||needinfo? --- Comment #7 from Damian L Brasher 2011-05-29 08:30:12 EDT --- I am about to start a new Linux SA II role, will take a few weeks to get organised. A new semi-production DIASER instance will be created within the next two months for use by IEF. Choosing DIASER dependencies for reciprocal Fedora package review would be an efficient use of time, suggestions welcome. Dependencies include: perl-Net-SSH-Perl, perl-Net-SFTP, perl-AppConfig, perl-TermReadKey, perl-Data-Password -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 --- Comment #19 from nucleo 2011-05-29 08:29:37 EDT --- I fixed typo in patch (the same fix as in git) http://nucleo.fedorapeople.org/pkg-reviews/kamoso/2.0/kamoso-2.0-license-fix.patch 2.0-final have translations, so I decided to build it for now instead of 2.0.1. License changed to GPLv2+. Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/kamoso/2.0/kamoso.spec SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/kamoso/2.0/kamoso-2.0-1.fc15.src.rpm $ rpmlint kamoso-2.0-1.fc15.i686.rpm kamoso-2.0-1.fc15.src.rpm kamoso-2.0-1.fc15.x86_64.rpm kamoso-debuginfo-2.0-1.fc15.i686.rpm kamoso-debuginfo-2.0-1.fc15.x86_64.rpm kamoso.i686: W: spelling-error Summary(en_US) webcam -> web cam, web-cam, became kamoso.i686: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became kamoso.i686: W: no-manual-page-for-binary kamoso kamoso.i686: W: no-manual-page-for-binary kamosoPluginTester kamoso.src: W: spelling-error Summary(en_US) webcam -> web cam, web-cam, became kamoso.src: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became kamoso.x86_64: W: spelling-error Summary(en_US) webcam -> web cam, web-cam, became kamoso.x86_64: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became kamoso.x86_64: W: no-manual-page-for-binary kamoso kamoso.x86_64: W: no-manual-page-for-binary kamosoPluginTester 5 packages and 0 specfiles checked; 0 errors, 10 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708711] Review Request: nomnom - The graphical video download tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #2 from Nicoleau Fabien 2011-05-29 07:23:28 EDT --- Updated : Spec URL: http://rpms.nicoleau-fabien.net/SPECS/nomnom.spec SRPM URL: http://rpms.nicoleau-fabien.net/SRPMS/nomnom-0.1.3-2.fc15.src.rpm %changelog * Sun May 29 2011 Nicoleau Fabien 0.1.3-2 - Only use RPM_BUILD_ROOT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708663] Review Request: ConozcoNicaragua - Geographycal Activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708663 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no Summary|Review Request: |Review Request: | - <1>|ConozcoNicaragua - ||Geographycal Activity for ||Sugar -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 --- Comment #19 from Mario Ceresa 2011-05-29 05:51:37 EDT --- Hi again, fixed around 70 missing sonames, re-enabled parallel build and added some missing dirs: http://mrceresa.fedorapeople.org/vxl-1.14.0-1.fc15.src.rpm http://mrceresa.fedorapeople.org/vxl.spec Here it is the koji link: http://koji.fedoraproject.org/koji/taskinfo?taskID=3098791 If it succeed, I think the package is ready for the review (all major blocker should be fixed) Best, Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705104] Review Request: freediams - Pharmaceutical Drugs Prescriptor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705104
--- Comment #6 from Ankur Sinha 2011-05-29 03:33:04
EDT ---
Hi Volker!
Thank you for the comments!
(In reply to comment #5)
> I can't rebuild your source package. Something is wrong with your qmake
> options, it seems.
Uhm, I just rebuilt it in mock and it built correctly.
>
> Your package bundles quazip, which is already in Fedora. Please delete it in
> the prep section and make your package use the system's version.
I missed this! I'll take care of it.
>
> Usually the files section starts with the main package and not with a
> sub-package.
Okay. I'll rearrange the spec file.
>
> Harmonize on either using %{buildroot} or $RPM_BUILD_ROOT.
Done.
>
> Please pay attention to the translations. See
> http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
>
> The description of the data package is wrong. It doesn't contain architecture
> independent documentation, but data. Besides that, you should make the
> sub-package Noarch, to yield an advantage.
Okay.
>
> The package includes some tests. Can you run them in a check section?
Okay.
>
> License and readme file belong to the main package. The install file should
> not
> be included.
Okay.
I'll rebuild the spec with the changes and upload a new srpm soon.
Thanks again!
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
