[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 Fedora Update System changed: What|Removed |Added Fixed In Version|kamoso-2.0.2-1.fc15 |kamoso-2.0.2-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 --- Comment #28 from Fedora Update System 2011-06-11 00:32:35 EDT --- kamoso-2.0.2-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698590 Fedora Update System changed: What|Removed |Added Fixed In Version|drupal6-features-1.0-3.fc15 |drupal6-features-1.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698590 --- Comment #17 from Fedora Update System 2011-06-11 00:32:18 EDT --- drupal6-features-1.0-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674082] Review Request: mchange-commons - A collection of general purpose utilities for c3p0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674082 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System 2011-06-11 00:31:35 EDT --- mchange-commons-0.2-0.3.20110130hg.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665877] Review Request: freeDiameter - a Diameter protocol open implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665877 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-06-11 00:28:36 EDT --- freeDiameter-1.1.0-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703719] Review Request: spice-xpi - mozilla extension for spice client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703719 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-06-11 00:28:18 EDT --- spice-xpi-2.5-2.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711777] Review Request: perl-Test-Spec - Write tests in a declarative specification style
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711777 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System 2011-06-11 00:24:02 EDT --- perl-Test-Spec-0.31-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706701] Review Request: perl-Test-Pod-Content - Test a Pod's content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706701 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System 2011-06-11 00:25:28 EDT --- perl-Test-Pod-Content-0.0.5-2.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710115] Review Request: jlatexmath - Implementation of LaTeX math mode wrote in Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710115 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System 2011-06-11 00:23:56 EDT --- jlatexmath-0.9.6-2.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705798] Review Request: perl-Data-Hexify - Perl extension for hexdumping arbitrary data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705798 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System 2011-06-11 00:23:42 EDT --- perl-Data-Hexify-1.00-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655954] Review Request: drupal6-token - Tokens are small bits of text that can be placed into larger documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655954 Fedora Update System changed: What|Removed |Added Fixed In Version|drupal6-token-1.15-5.el5|drupal6-token-1.16-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655954] Review Request: drupal6-token - Tokens are small bits of text that can be placed into larger documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655954 --- Comment #15 from Fedora Update System 2011-06-11 00:21:07 EDT --- drupal6-token-1.16-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698590 Fedora Update System changed: What|Removed |Added Fixed In Version||drupal6-features-1.0-3.fc15 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698590 --- Comment #16 from Fedora Update System 2011-06-11 00:19:07 EDT --- drupal6-features-1.0-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711873] Review Request: trytond-account-stock-continental - account-stock-continental module for Tryton
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711873 --- Comment #3 from Cristian Ciupitu 2011-06-10 22:32:59 EDT --- You forgot to put the right src.rpm link :-) I'll assume it's http://fedora.danny.cz/tryton/trytond-account-stock-continental-2.0.0-2.fc16.src.rpm . The LICENSE file does say that it's GPLv2 and not v3 and COPYRIGHT file mentions that the license text is published FSF, so I don't see a showstopper in this. As far as I can see it, if someone want the text of the GPLv3 license he/she can get it from FSF. Regarding doc I must admit that the 2 %doc lines look odd, but nevertheless I consider the spec fine. The koji scratch build is at http://koji.fedoraproject.org/koji/taskinfo?taskID=3124948 . After I or someone else tests the package, I'll approve it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711872] Review Request: trytond-account-stock-anglo-saxon - account-stock-anglo-saxon module for Tryton
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711872 --- Comment #4 from Cristian Ciupitu 2011-06-10 22:22:05 EDT --- The LICENSE file does say that it's GPLv2 and not v3 and COPYRIGHT files mentions that the license text is published FSF, so I don't see a showstopper in this. Regarding doc I must admit that the 2 %doc lines look odd, but nevertheless I consider the spec fine. The koji scratch build is at http://koji.fedoraproject.org/koji/taskinfo?taskID=3124945 . After I or someone else tests the package, I'll approve it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555655] Review Request: sslstrip - tool that provides a demonstration of HTTPS stripping attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555655 manuel wolfshant changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from manuel wolfshant 2011-06-10 20:08:07 EDT --- Only remaining word from rpmlint is: [wolfy@wolfy tmp]$ rpmlint sslstrip*rpm sslstrip.noarch: W: spelling-error %description -l en_US Marlinspike -> Marlin spike, Marlin-spike, Marlinespike sslstrip.noarch: W: spelling-error %description -l en_US favicon -> falcon, faction, favorite sslstrip.src: W: spelling-error %description -l en_US Marlinspike -> Marlin spike, Marlin-spike, Marlinespike sslstrip.src: W: spelling-error %description -l en_US favicon -> falcon, faction, favorite 2 packages and 0 specfiles checked; 0 errors, 4 warnings. which is obviously a false alert. Everything seems fine now [*] so the package is APPROVED [*] - builds fine in koji - works as expected - no regressions compared to previous versions. PS 1. you'll get bonus points for including this tool in EPEL :) 2. please inform the upstream author that the file DnsCache.py does not include the license info -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555655] Review Request: sslstrip - tool that provides a demonstration of HTTPS stripping attacks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555655 --- Comment #7 from Adam Miller 2011-06-10 19:25:08 EDT --- Spec URL: http://maxamillion.fedorapeople.org/sslstrip.spec SRPM URL: http://maxamillion.fedorapeople.org/sslstrip-0.9-2.fc15.src.rpm Fixed up the permissions, that was a complete oversight on my part. Sorry about the python-twisted-web dep miss, I just got lucky/unlucky and had that already installed on the machine I tested on. Also a major goof, fixed now. Many thanks for the review! -AdamM -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712522] Review Request: eclipse-wtp-common - Common Web Tools Platform utilities and infrastructure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712522 --- Comment #1 from Severin Gehwolf 2011-06-10 18:44:14 EDT --- After a quick glance at the .spec file it appears there are some missing requires. Are you sure gef, etc. aren't also runtime requirements? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712522] New: Review Request: eclipse-wtp-common - Common Web Tools Platform utilities and infrastructure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: eclipse-wtp-common - Common Web Tools Platform utilities and infrastructure https://bugzilla.redhat.com/show_bug.cgi?id=712522 Summary: Review Request: eclipse-wtp-common - Common Web Tools Platform utilities and infrastructure Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: arobi...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://arobinso.fedorapeople.org/eclipse-wtp-common.spec SRPM URL: http://arobinso.fedorapeople.org/eclipse-wtp-common-3.2.4-1.fc15.src.rpm Description: Contains the features of the Web Tools Platform Eclipse extension that are used outside of web tooling including Facet APIs, Validation, the Snippets View, and an Extensible URI Resolver. Hello all. I just packaged this and would appreciate a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 --- Comment #6 from Severin Gehwolf 2011-06-10 15:51:09 EDT --- Adding Andrew, so he can learn a few things as comments fly by :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603346] Review Request: php-voms-admin - Web based interface to control VOMS parameters written in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603346 --- Comment #10 from Mattias Ellert 2011-06-10 15:42:51 EDT --- (In reply to comment #8) > The package now works correctly and the review issues are fixed. > > Setting fedora-review+. Thank you for the review. I'll investigate the SELinux issues. > I have also found an upstream issue, but I haven't found the appropriate bug > tracker, so filing it here: Upstream bug tracker is http://bugzilla.nordugrid.org/ → Product: Contributed software → Component: pva New Package SCM Request === Package Name: php-voms-admin Short Description: Web based interface to control VOMS parameters written in PHP Owners: ellert Branches: f14 f15 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603346] Review Request: php-voms-admin - Web based interface to control VOMS parameters written in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603346 --- Comment #9 from Lev Shamardin 2011-06-10 14:47:46 EDT --- And almost forgot another missing documentation/packaing(?) minor, but still important point: this package is useless without SSL with certificates peer authentication, so README.Fedora should include 1. Notice about this requirement. 2. Example configuration for mod_ssl. Also probably it would be a good idea to include a universal configuration snippet into /etc/http/conf.d/pva.conf, something like ... SSLRequireSSL SSLVerifyClient require SSLVerifyDepth 10 # or other appropriate number GnuTLSClientVerify require SSLVerifyDepth 10 # not sure about this directive ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 603346] Review Request: php-voms-admin - Web based interface to control VOMS parameters written in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603346 Lev Shamardin changed: What|Removed |Added Status|NEW |ON_DEV Flag||fedora-review+ --- Comment #8 from Lev Shamardin 2011-06-10 14:27:54 EDT --- The package now works correctly and the review issues are fixed. Review items which were not ok, but are fixed now: + MUST: rpmlint errors: no errors, only spelling warnings. + SHOULD: Package core functionality appears to work in most cases. + SHOULD: Package contains manual pages for binaries/scripts. Setting fedora-review+. Please consider providing a package also for the EPEL tree. I could be a co-maintainer if you wish. There are some future points which could be done better: 1. The package could provide a SELinux module/subpackage, conforming to https://fedoraproject.org/wiki/SELinux_Policy_Modules_Packaging_Draft. Under SELinux it needs two things to operate properly: a) setsebool -P httpd_can_sendmail 1 b) proper context on /var/www/pva/mail-copies, setroubleshootd suggests semanage fcontext -a -t httpd_sys_rw_content_t '/var/www/pva/mail-copies' restorecon -v '/var/www/pva/mail-copies' 2. Upstream provides no documentation on package configuration. Consider adding notices about editing /etc/pva/addvo.conf and /etc/pva/config.inc after installation into README.Fedora. I have also found an upstream issue, but I haven't found the appropriate bug tracker, so filing it here: pva-addvo fails to add a new vo, if there is more than one copy (or symlink) of VO administrator's CA in /etc/grid-security/certificates: this causes an incorrect CAID inside the pva-addvo, which can not only point at a wrong CA, but also to a missing CA id. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710101] Review Request: mingw-libjpeg-turbo - MinGW Windows Libjpeg-turbo library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710101 Erik van Pienbroek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-06-10 13:26:20 --- Comment #11 from Erik van Pienbroek 2011-06-10 13:26:20 EDT --- Package has been imported and build for rawhide successfully. Closing ticket -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712447] Review Request: PyQtMobility - Python bindings for Qt Mobility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712447 Kevin Kofler changed: What|Removed |Added Summary|Review Request: PyQtMoblity |Review Request: |- Python bindings for Qt|PyQtMobility - Python |Mobility|bindings for Qt Mobility -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697836] Review Request: mmseq - Haplotype and isoform specific expression estimation for RNA-seq
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 Adam Huffman changed: What|Removed |Added Status|NEW |ON_QA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711058 --- Comment #26 from Mario Santagiuliana 2011-06-10 12:43:22 EDT --- OK, I update all package and spec file: http://marionline.fedorapeople.org/packages/SPECS/akonadi-googledata.spec http://marionline.fedorapeople.org/packages/ Hope now is ok :) :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711606] Review Request: gnome-shell-extension-mediaplayers - A gnome-shell extension to control mediaplayers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711606 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711606] Review Request: gnome-shell-extension-mediaplayers - A gnome-shell extension to control mediaplayers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711606 --- Comment #5 from Fedora Update System 2011-06-10 12:41:15 EDT --- gnome-shell-extension-mediaplayers-0-0.1.git259f96e.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gnome-shell-extension-mediaplayers-0-0.1.git259f96e.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712447] Review Request: PyQtMoblity - Python bindings for Qt Mobility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712447 Rex Dieter changed: What|Removed |Added CC||jrez...@redhat.com Blocks||656997(kde-reviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712447] New: Review Request: PyQtMoblity - Python bindings for Qt Mobility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: PyQtMoblity - Python bindings for Qt Mobility https://bugzilla.redhat.com/show_bug.cgi?id=712447 Summary: Review Request: PyQtMoblity - Python bindings for Qt Mobility Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rdie...@math.unl.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://rdieter.fedorapeople.org/rpms/PyQtMobility/PyQtMobility.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/PyQtMobility/PyQtMobility-1.0.1-1.fc15.src.rpm Description: Python bindings for Qt Mobility -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711848] Review Request: kmetronome - KDE MIDI Metronome using ALSA Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711848 --- Comment #2 from Robin Lee 2011-06-10 12:24:28 EDT --- I have request co-maintainership on drumstick. OK, I will remove BR alsa-lib-devel in next update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711848] Review Request: kmetronome - KDE MIDI Metronome using ALSA Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711848 --- Comment #1 from Kevin Kofler 2011-06-10 12:05:42 EDT --- This shares the drumstick library with my kmid2 package. If you want to comaintain drumstick, just apply for it in pkgdb. (You can also comaintain kmid2 if you want.) Your kmetronome.spec looks good at a first glance, but that's not a formal review: I or somebody else will have to run through the complete review checklist before approving it. One remark: Are you sure the direct "BuildRequires: alsa-lib-devel" is needed? I think drumstick-devel should be sufficient. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711058
--- Comment #25 from Rex Dieter 2011-06-10 11:32:53 EDT
---
that works, but I'd prefer something like:
%build
mkdir -p %{_target_platform}
pushd %{_target_platform}
%{cmake_kde4} ..
popd
make %{?_smp_mflags} -C %{_target_platform}
%install
rm -rf %{buildroot}
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
to match the template in
http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=712203
--- Comment #5 from Andrew Overholt 2011-06-10 11:31:02
EDT ---
Thanks, this submission looks pretty good! Below is the review. The items
with an [!] need attention. Also see a few notes at the bottom.
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
rpmlint gives a few warnings which can be fixed by adding -q to %setup. The
other two are okay to ignore since you say how to reproduce the source in the
.spec.
$ rpmlint /home/overholt/rpmbuild/SRPMS/eclipse-mercurial-1.8.1-1.fc15.src.rpm
eclipse-mercurial.src:33: W: setup-not-quiet
eclipse-mercurial.src:34: W: setup-not-quiet
eclipse-mercurial.src: W: invalid-url Source1:
com.vectrace.mercurialeclipse-feature.tar.bz2
eclipse-mercurial.src: W: invalid-url Source0: eclipse-mercurial-1.8.1.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
rpmlint also gives an error on the resulting binary package. This should be
fixed in your source .tar.bz2 for the feature.
$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/eclipse-mercurial-1.8.1-1.fc15.noarch.rpm
eclipse-mercurial.noarch: E: non-standard-dir-perm
/usr/share/eclipse/dropins/mercurial/eclipse/features/com.vectrace.mercurialeclipse_0.1.1
0775L
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: EPL
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: 59de59ca556b2bb93dfc11df62b088d9
MD5SUM upstream package (what I generated): 1370eba31ae047b7657c70b6ee04b905
- these don't match but a recursive diff on the content doesn't show any
differences so I'm okay with this
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[!] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[-] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[-] Javadoc documentation files are generated and included in -javadoc
subpackage
[-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[-] Packages have proper BuildRequires/Requires on jpackage-utils
[-] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
=== Final Notes ===
1. Don't forget to bump the Release in your .spec with each change you make
(and add a %changelog comment each time). Also, please post URLs to the new
.spec and .src.rpm each time.
2. Lines are <= 80 character except for the unzip line in %install; please fix
3. Please make the qualifier match the upstream one: v201104191217. Look into
a few other Eclipse plugin .spec files to see how this is done
(-DforceContextQualifier=).
4. I see a feature in the upstream p2 repository:
mercurialeclipse.feature.group=1.8.1.v201104191217. Can you ask them if they'd
like to distribute such a feature?
5. As for the feature you've created, it's fine but I'd like to see a comment
in the .spec about how you generated it, why it's necessary, etc. Just for
future maintainability.
--
Configure bugmai
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711058
--- Comment #24 from Mario Santagiuliana 2011-06-10
11:12:01 EDT ---
Sorry, should be:
%build
%{cmake_kde4}
%cmake
?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711058
--- Comment #23 from Mario Santagiuliana 2011-06-10
11:08:42 EDT ---
I just update all the files...maybe is a cached problem with the browser?
The build section is:
%build
%{cmake_kde4}
Should be:
%build
%{cmake_kde4}
make
?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711058
--- Comment #22 from Rex Dieter 2011-06-10 10:58:26 EDT
---
close, though only your src.rpm was updated. :)
I notice now that your
%build
section lacks any 'make' directive, and didn't follow the %{cmake_kde4}
template I referenced either. Please check that again.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711058 --- Comment #21 from Mario Santagiuliana 2011-06-10 10:46:17 EDT --- 1. Change 2. Dropped 3. Change 4. Done 5. Added 6. Removed And I change source to source0. Updated packages here: http://marionline.fedorapeople.org/packages/SPECS/akonadi-googledata.spec http://marionline.fedorapeople.org/packages/ Can you check the new spec and packages? Thank you very much! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711873] Review Request: trytond-account-stock-continental - account-stock-continental module for Tryton
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711873 Dan Horák changed: What|Removed |Added Flag|needinfo?(d...@danny.cz) | --- Comment #2 from Dan Horák 2011-06-10 10:14:38 EDT --- Updated Spec URL: http://fedora.danny.cz/tryton/trytond-account-stock-continental.spec Updated SRPM URL: http://fedora.danny.cz/tryton/trytond-account-stock-continental-2.0.0-1.fc16.src.rpm ChangeLog: - include doc directory as %doc - the LICENSE text will updated by upstream in next release, binding is what's written in the COPYRIGHT file (IANAL) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711872] Review Request: trytond-account-stock-anglo-saxon - account-stock-anglo-saxon module for Tryton
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711872 Dan Horák changed: What|Removed |Added Flag|needinfo?(d...@danny.cz) | --- Comment #3 from Dan Horák 2011-06-10 10:11:44 EDT --- Updated Spec URL: http://fedora.danny.cz/tryton/trytond-account-stock-anglo-saxon.spec Updated SRPM URL: http://fedora.danny.cz/tryton/trytond-account-stock-anglo-saxon-2.0.0-2.fc16.src.rpm ChangeLog: - include doc directory as %doc - the LICENSE text will updated by upstream in next release, binding is what's written in the COPYRIGHT file (IANAL) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 --- Comment #4 from minoo ziaei 2011-06-10 09:54:25 EDT --- (In reply to comment #3) Removed those lines too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706357] Review Request: lsw - Prints all window titles of DISPLAY to standard output
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706357 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2011-06-10 09:34:56 EDT --- lsw-0.2-1.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690919] Review Request: aswvdial - Dockapp for wvdial
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690919 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System 2011-06-10 09:33:52 EDT --- aswvdial-1.7-4.fc15 has been pushed to the Fedora 15 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707819] Review Request: DSDP - Software for semidefinite programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707819 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System 2011-06-10 09:32:16 EDT --- DSDP-5.8-2.fc14 has been pushed to the Fedora 14 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712404] New: Review Request : ghc-data-accessor-template - A library for accessing and manipulating fields of records
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request : ghc-data-accessor-template - A library for accessing and manipulating fields of records https://bugzilla.redhat.com/show_bug.cgi?id=712404 Summary: Review Request : ghc-data-accessor-template - A library for accessing and manipulating fields of records Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lakshminaras2...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com, fedora-haskell-l...@redhat.com Depends on: 662272 Estimated Hours: 0.0 Classification: Fedora Story Points: --- SPEC file : http://narasim.fedorapeople.org/package_reviews/ghc-data-accessor-template.spec SRPM file : http://narasim.fedorapeople.org/package_reviews/ghc-data-accessor-template-0.2.1.7-1.fc14.src.rpm rpmlint output: ghc-data-accessor-template-prof.i686: E: devel-dependency ghc-data-accessor-template-devel Your package has a dependency on a devel package but it's not a devel package itself. ghc-data-accessor-template-prof.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. ghc-data-accessor-template-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/data-accessor-template-0.2.1.7/libHSdata-accessor-template-0.2.1.7_p.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. 4 packages and 1 specfiles checked; 1 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705376] Review Request: perl-MIME-Lite-HTML - Provide routine to transform a HTML page in a MIME-Lite mail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705376 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-MIME-Lite-HTML-1.23-2. |perl-MIME-Lite-HTML-1.23-2. |el6 |fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705376] Review Request: perl-MIME-Lite-HTML - Provide routine to transform a HTML page in a MIME-Lite mail
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705376 --- Comment #13 from Fedora Update System 2011-06-10 09:27:53 EDT --- perl-MIME-Lite-HTML-1.23-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662272] Review Request: ghc-utility-ht - Helper functions for Lists, Maybes, Tuples, Functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662272 Lakshmi Narasimhan changed: What|Removed |Added Blocks||712404 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712404] Review Request : ghc-data-accessor-template - A library for accessing and manipulating fields of records
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712404 --- Comment #1 from Lakshmi Narasimhan 2011-06-10 09:28:41 EDT --- Required for yi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711848] Review Request: kmetronome - KDE MIDI Metronome using ALSA Sequencer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711848 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||656997(kde-reviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711058
--- Comment #20 from Rex Dieter 2011-06-10 08:56:41 EDT
---
I'm going to be a little more picky than usual, since this is your first
package.
comments: MUST => required fixes before I'll approve, SHOULD => items I'd like
to see addressed, but not required if you'd rather not for whatever reason.
Naming: ok
Sources: ok
483bb82d4492ff20edb64d3d4edc02eb akonadi-googledata-1.2.0.tar.bz2
thought I would still recommend calling it Source0, even if it's the only one.
Scriptlets: n/a, ok
$ rpmlint *.rp x86_64/*.rpm
^C^C^C^C[rdieter1@math-110 akonadi-googledata]$ rpmlint *.rpm x86_64/*.rpm
akonadi-googledata.src: W: spelling-error %description -l en_US kde -> ked, de,
ode
akonadi-googledata.src: W: spelling-error %description -l en_US google ->
Google, goggle, googly
akonadi-googledata.src: W: spelling-error %description -l en_US joe -> Joe,
hoe, jor
akonadi-googledata.src: W: invalid-license LGPL v2.1
akonadi-googledata.src: W: invalid-license later
akonadi-googledata.src: W: invalid-url Source0:
http://libgcal.googlecode.com/files/akonadi-googledata-1.2.0.tar.bz2 HTTP Error
404: Not Found
akonadi-googledata.x86_64: W: spelling-error %description -l en_US kde -> ked,
de, ode
akonadi-googledata.x86_64: W: spelling-error %description -l en_US google ->
Google, goggle, googly
akonadi-googledata.x86_64: W: spelling-error %description -l en_US joe -> Joe,
hoe, jor
akonadi-googledata.x86_64: W: invalid-license LGPL v2.1
akonadi-googledata.x86_64: W: invalid-license later
akonadi-googledata.x86_64: W: no-manual-page-for-binary akonadi_gcal_resource
akonadi-googledata.x86_64: W: no-manual-page-for-binary
akonadi_googledata_resource
akonadi-googledata-debuginfo.x86_64: W: invalid-license LGPL v2.1
akonadi-googledata-debuginfo.x86_64: W: invalid-license later
3 packages and 0 specfiles checked; 0 errors, 15 warnings.
most of these are harmless, I'll address license below.
1. MUST: licensing: not ok, should use
License: LGPLv2+
per http://fedoraproject.org/wiki/Licensing#Software_License_List
2. SHOULD drop useless definition of... %global kde4_version
3. MUST
I'd recommend using %{_cmake_kde4} macro, instead of %cmake, see
http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
for an example/template.
4. SHOULD (getting really picky, this is mostly cosmetic, but...), I
personally prefer to put build deps 1 per line like:
BuildRequires: akonadi-devel
BuildRequires: gettext
...
which makes reading pkg diffs later easier to parse when items are
added/removed
5. SHOULD even though boost-devel is already pulled in via indirect
dependencies (kdepimlibs-devel), this package does explicitly check-for and use
it directly, so I'd recommend adding
BuildRequires: boost-devel
6. SHOULD drop more items that are deprecated (ie, not needed) with recent
fedora/rpm releases including:
Group: tag
and
%defattr(...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 --- Comment #7 from Jon Ciesla 2011-06-10 08:51:25 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 Jiri Moskovcak changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 --- Comment #6 from Jiri Moskovcak 2011-06-10 08:41:47 EDT --- New Package SCM Request === Package Name: libreport Short Description: Generic library for reporting various problems to the different ticketing systems Owners: vda npajkovs mtoman mlichvar kklic jmoskovc Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712273] Review Request: ghc-pointedlist - A zipper-like comonad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712273 --- Comment #1 from Lakshmi Narasimhan 2011-06-10 08:29:11 EDT --- Downgrading version to 0.3.5 for yi Spec file : http://narasim.fedorapeople.org/package_reviews/ghc-pointedlist.spec SRPM file : http://narasim.fedorapeople.org/package_reviews/ghc-pointedlist-0.3.5-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 703152] Review Request: ghc-rosezipper - Generic zipper implementation for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703152 --- Comment #2 from Lakshmi Narasimhan 2011-06-10 08:27:13 EDT --- Downgrading the version to 0.1 Spec file : http://narasim.fedorapeople.org/package_reviews/ghc-rosezipper.spec SRPM file : http://narasim.fedorapeople.org/package_reviews/ghc-rosezipper-0.1-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 --- Comment #5 from Jon Ciesla 2011-06-10 08:21:25 EDT --- WARNING: "dvlasenk" is not a valid FAS account. Can you correct, please, and then re-set the cvs flag? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711058] Review Request: akonadi-googledata - Google contacts and calendar akonadi resource
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711058 --- Comment #19 from Mario Santagiuliana 2011-06-10 07:45:10 EDT --- Thank you Rex. Should I do other things for this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 Jiri Moskovcak changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Jiri Moskovcak 2011-06-10 07:37:27 EDT --- New Package SCM Request === Package Name: libreport Short Description: Generic library for reporting various problems to the different ticketing systems Owners: dvlasenk npajkovs mtoman mlichvar kklic jmoskovc Branches: f15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706701] Review Request: perl-Test-Pod-Content - Test a Pod's content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706701 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706701] Review Request: perl-Test-Pod-Content - Test a Pod's content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706701 --- Comment #7 from Fedora Update System 2011-06-10 07:04:44 EDT --- perl-Test-Pod-Content-0.0.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Test-Pod-Content-0.0.5-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 Dan Horák changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Dan Horák 2011-06-10 06:49:44 EDT --- All issues are fixed now, package is APPROVED source archive is updated, but version not bumped, new sha1sum is 886fbf4e2d977865c644e257688ecad1c8c7f782 libreport-2.0.2.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711873] Review Request: trytond-account-stock-continental - account-stock-continental module for Tryton
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711873
Cristian Ciupitu changed:
What|Removed |Added
Flag||needinfo?(d...@danny.cz)
--- Comment #1 from Cristian Ciupitu 2011-06-10
06:41:32 EDT ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
OK, alhough it might be a good idea not to package the tests if possible.
$ rpmlint trytond-account-stock-continental*
trytond-account-stock-continental.noarch: W: summary-not-capitalized C
account-stock-continental module for Tryton
trytond-account-stock-continental.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/trytond/modules/account_stock_continental/tests/test_account_stock_continental.py
0644L /usr/bin/env
trytond-account-stock-continental.src: W: summary-not-capitalized C
account-stock-continental module for Tryton
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
MUST: The package must be named according to the Package Naming Guidelines .
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK
MUST: The package must meet the Packaging Guidelines .
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK
MUST: The License field in the package spec file must match the actual license.
[3]
OK, but please ask upstream to update the LICENSE file. It has the text for
GPLv2 right now.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK
MUST: The spec file must be written in American English. [5]
OK
MUST: The spec file for the package MUST be legible. [6]
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
OK http://koji.fedoraproject.org/koji/taskinfo?taskID=3123075
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
N/A
MUST: Packages must NOT bundle copies of system libraries.[11]
OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]
OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]
OK
MUST: Each package must consistently use macros. [16]
OK
MUST: The package must contain code, or permissable content. [17]
OK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
OK
MUST: Header files must be in a -devel package. [19]
N/A
MUST: Static libraries must be in a -static package. [20]
N/A
MUST: If a package conta
[Bug 711872] Review Request: trytond-account-stock-anglo-saxon - account-stock-anglo-saxon module for Tryton
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711872
Cristian Ciupitu changed:
What|Removed |Added
Flag||needinfo?(d...@danny.cz)
--- Comment #2 from Cristian Ciupitu 2011-06-10
06:41:35 EDT ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
OK, although it might be a good idea not to package the tests if possible.
$ rpmlint trytond-account-stock-anglo-saxon*
trytond-account-stock-anglo-saxon.noarch: W: summary-not-capitalized C
account-stock-anglo-saxon module for Tryton
trytond-account-stock-anglo-saxon.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/trytond/modules/account_stock_anglo_saxon/tests/test_account_stock_anglo_saxon.py
0644L /usr/bin/env
trytond-account-stock-anglo-saxon.src: W: summary-not-capitalized C
account-stock-anglo-saxon module for Tryton
MUST: The package must be named according to the Package Naming Guidelines .
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK
MUST: The package must meet the Packaging Guidelines .
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK
MUST: The License field in the package spec file must match the actual license.
[3]
OK, but please ask upstream to update the LICENSE file. It has the text for
GPLv2 right now.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK
MUST: The spec file must be written in American English. [5]
OK
MUST: The spec file for the package MUST be legible. [6]
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
OK http://koji.fedoraproject.org/koji/taskinfo?taskID=3123077
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
N/A
MUST: Packages must NOT bundle copies of system libraries.[11]
OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]
OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]
OK
MUST: Each package must consistently use macros. [16]
OK
MUST: The package must contain code, or permissable content. [17]
OK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK. By the way the doc directory is not packaged
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
OK
MUST: Header files must be in a -devel package. [19]
N/A
MUST: Static libraries must be in a -static package. [20]
N/A
MUST: If a package contains library
[Bug 675557] Review Request: matreshka - set of Ada libraries to help to develop information systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675557 Pavel Zhukov changed: What|Removed |Added Blocks||712332 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711873] Review Request: trytond-account-stock-continental - account-stock-continental module for Tryton
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711873 Cristian Ciupitu changed: What|Removed |Added CC||cristian.ciup...@yahoo.com AssignedTo|nob...@fedoraproject.org|cristian.ciup...@yahoo.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711872] Review Request: trytond-account-stock-anglo-saxon - account-stock-anglo-saxon module for Tryton
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711872 Cristian Ciupitu changed: What|Removed |Added CC||cristian.ciup...@yahoo.com AssignedTo|nob...@fedoraproject.org|cristian.ciup...@yahoo.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710115] Review Request: jlatexmath - Implementation of LaTeX math mode wrote in Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710115 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710115] Review Request: jlatexmath - Implementation of LaTeX math mode wrote in Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710115 --- Comment #11 from Fedora Update System 2011-06-10 04:23:14 EDT --- jlatexmath-0.9.6-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/jlatexmath-0.9.6-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710045] Review Request:ghc-MonadCatchIO-mtl - Monad-transformer for Control.Exception
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710045 --- Comment #6 from Shakthi Kannan 2011-06-10 03:29:24 EDT --- Upstream has added LICENSE file and released 0.3.0.3. Updated: SPEC: http://shakthimaan.fedorapeople.org/SPECS/ghc-MonadCatchIO-mtl.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src.rpm $ rpmlint ghc-MonadCatchIO-mtl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-devel-0.3.0.3-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-prof-0.3.0.3-1.fc14.i686.rpm ghc-MonadCatchIO-mtl-prof.i686: E: devel-dependency ghc-MonadCatchIO-mtl-devel ghc-MonadCatchIO-mtl-prof.i686: W: no-documentation ghc-MonadCatchIO-mtl-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/MonadCatchIO-mtl-0.3.0.3/libHSMonadCatchIO-mtl-0.3.0.3_p.a 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Successful Koji builds for F-14, F-15, F-16 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=3122915 http://koji.fedoraproject.org/koji/taskinfo?taskID=3122905 http://koji.fedoraproject.org/koji/taskinfo?taskID=3122908 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
