[Bug 705104] Review Request: freediams - Pharmaceutical Drugs Prescriptor

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705104

--- Comment #12 from Ankur Sinha sanjay.an...@gmail.com 2011-06-15 01:54:35 
EDT ---
I've mailed upstream to clarify some of the issues:

https://fedorahosted.org/pipermail/medical-sig/2011-June/000187.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713361] New: Review Request: ghc-pcre-light - Haskell binding to pcre

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ghc-pcre-light - Haskell binding to pcre

https://bugzilla.redhat.com/show_bug.cgi?id=713361

   Summary: Review Request: ghc-pcre-light - Haskell binding to
pcre
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: peter...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://petersen.fedorapeople.org/ghc-pcre-light/ghc-pcre-light.spec
SRPM URL:
http://petersen.fedorapeople.org/ghc-pcre-light/ghc-pcre-light-0.4-3.fc15.src.rpm
Description: Perl5 compatible regular expressions library for Haskell

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709949] Review Request: highlighting-kate - Source code highlighting tool and library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709949

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Depends on||713361

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662259] Review Request: git-annex - Manage files with git, without checking their contents in

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662259

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Depends on||713361

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713361] Review Request: ghc-pcre-light - Haskell binding to pcre

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713361

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Blocks||662259(git-annex),
   ||709949(highlighting-kate)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709949] Review Request: highlighting-kate - Source code highlighting tool and library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709949

Bug 709949 depends on bug 662258, which changed state.

Bug 662258 Summary: Review Request: ghc-pcre-light - A regex library for Perl 5 
compatible regular expressions
https://bugzilla.redhat.com/show_bug.cgi?id=662258

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662259] Review Request: git-annex - Manage files with git, without checking their contents in

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662259

Bug 662259 depends on bug 662258, which changed state.

Bug 662258 Summary: Review Request: ghc-pcre-light - A regex library for Perl 5 
compatible regular expressions
https://bugzilla.redhat.com/show_bug.cgi?id=662258

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||DUPLICATE
Last Closed||2011-06-15 02:01:42

--- Comment #15 from Jens Petersen peter...@redhat.com 2011-06-15 02:01:42 
EDT ---


*** This bug has been marked as a duplicate of bug 713361 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709949] Review Request: highlighting-kate - Source code highlighting tool and library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=709949

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Depends on|662258(ghc-pcre-light)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662259] Review Request: git-annex - Manage files with git, without checking their contents in

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662259

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Depends on|662258(ghc-pcre-light)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Blocks|662259(git-annex),  |
   |709949(highlighting-kate)   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713361] Review Request: ghc-pcre-light - Haskell binding to pcre

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713361

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 CC||maths...@gmail.com

--- Comment #1 from Jens Petersen peter...@redhat.com 2011-06-15 02:01:42 EDT 
---
*** Bug 662258 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662277] Review Request: hledger-vty - A hledger add-on command providing a full-window console interface

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662277

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Blocks|634048(Haskell-pkg-reviews) |

--- Comment #1 from Jens Petersen peter...@redhat.com 2011-06-15 02:19:14 EDT 
---
Removing for now from Haskell-pkg-reviews since it has not been ready
for a while and still depends on a stack of unreviewed packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 630206] Review Request: ghc-hledger-lib - Core types and utilities for working with hledger data

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630206

--- Comment #9 from Jens Petersen peter...@redhat.com 2011-06-15 02:20:41 EDT 
---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 662283] Review Request: hledger-web - A hledger add-on command providing a web interface

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662283

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Blocks|634048(Haskell-pkg-reviews) |

--- Comment #3 from Jens Petersen peter...@redhat.com 2011-06-15 02:22:17 EDT 
---
Removing for now from bug 634048 since it is still not ready
and depends on hledger and huge yesod stack which are still to be reviewed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 630216] Review Request: ghc-vector-space - Vector affine spaces, linear maps, and derivatives

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630216

--- Comment #5 from Jens Petersen peter...@redhat.com 2011-06-15 02:24:37 EDT 
---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707002

Eric Maeker eric.mae...@gmail.com changed:

   What|Removed |Added

 CC||eric.mae...@gmail.com

--- Comment #2 from Eric Maeker eric.mae...@gmail.com 2011-06-15 02:49:59 EDT 
---
Hi Ankur,

Thanks for this great work. We are greatly pleased to be included in Fedora
Medical and in Fedora in general.

Just some comments on the presentation:
- license is mainly GPLv3 + LGPL (for some parts)
- need Qt v4.6.2 at least

For the spec:
- in order to create the translation add in the %build tag (before the qmake
step)
lrelease global_resources/translations/*.ts
- LOWERED_APPNAME=FreeMedForms  -- needs to be lowered ;) so
LOWERED_APPNAME=freemedforms. Then libs and plugs should be installed in
%{_libdir}/freemedforms

I saw a problem with rpath, 0.5.9~alpha2 should solve it (idem for the debian
packages).

There should be a small issue with the version numbering (because the version
is parsed in the code). Can't you use 0.5.9~alpha1 instead of 0.5.9-0.1.alpha1
? Otherwise I need to patch the 0.5.9~alpha2 code ;)

Can you add a link to our main website: http://www.freemedforms.com/

Fell free to contact us at any time for any question at
freemedfo...@googlegroups.com

Thanks for your work
Eric Maeker

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

Petr Sabata psab...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||psab...@redhat.com
 AssignedTo|nob...@fedoraproject.org|psab...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711762] Review Request: osc - openSUSE Build Service Commander

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711762

Jerome Soyer sai...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #10 from Jerome Soyer sai...@gmail.com 2011-06-15 03:29:23 EDT ---
New Package SCM Request
===
Package Name: osc
Short Description: openSUSE Build Service Commander
Owners: saispo
Branches: f14 f15 el5 el6
InitialCC: saispo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683463] Review Request: trafficserver - Apache Traffic Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683463

--- Comment #7 from Zhao Yongming ming@gmail.com 2011-06-15 04:29:25 EDT 
---
Bumped to new stable release 3.0.0, uploaded in
http://zymlinux.net/trafficserver/rpm/3.0.0-2/

http://zymlinux.net/trafficserver/rpm/3.0.0-2/trafficserver-3.0.0-2.fc16.src.rpm
http://zymlinux.net/trafficserver/rpm/3.0.0-2/trafficserver-3.0.0-2.fc16.x86_64.rpm
http://zymlinux.net/trafficserver/rpm/3.0.0-2/trafficserver-devel-3.0.0-2.fc16.x86_64.rpm

and here is the rpmlint output:

[root@unknown-10-62-163-x SPECS]# rpmlint
/root/rpmbuild/RPMS/x86_64/trafficserver-3.0.0-2.fc16.x86_64.rpm
trafficserver.x86_64: I: enchant-dictionary-not-found en_US
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_cop
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_shell
trafficserver.x86_64: W: unstripped-binary-or-object
/usr/lib64/trafficserver/libtsutil.so.3.0.0
trafficserver.x86_64: W: unstripped-binary-or-object
/usr/lib64/trafficserver/libtsmgmt.so.3.0.0
trafficserver.x86_64: W: unstripped-binary-or-object
/usr/lib64/trafficserver/plugins/conf_remap.so
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_sac
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_server
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_logcat
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_manager
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_line
trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_logstats
trafficserver.x86_64: W: hidden-file-or-dir
/etc/trafficserver/body_factory/default/.body_factory_info
trafficserver.x86_64: W: log-files-without-logrotate /var/log/trafficserver
trafficserver.x86_64: W: no-manual-page-for-binary traffic_shell
trafficserver.x86_64: W: no-manual-page-for-binary traffic_line
trafficserver.x86_64: W: no-manual-page-for-binary traffic_server
trafficserver.x86_64: W: no-manual-page-for-binary traffic_manager
trafficserver.x86_64: W: no-manual-page-for-binary traffic_sac
trafficserver.x86_64: W: no-manual-page-for-binary traffic_cop
trafficserver.x86_64: W: no-manual-page-for-binary traffic_logstats
trafficserver.x86_64: W: no-manual-page-for-binary traffic_logcat
trafficserver.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
trafficserver.x86_64: W: service-default-enabled /etc/init.d/trafficserver
1 packages and 0 specfiles checked; 0 errors, 23 warnings.
[root@unknown-10-62-163-x SPECS]# rpmlint
/root/rpmbuild/RPMS/x86_64/trafficserver-devel-3.0.0-2.fc16.x86_64.rpm
trafficserver-devel.x86_64: I: enchant-dictionary-not-found en_US
trafficserver-devel.x86_64: W: no-documentation
trafficserver-devel.x86_64: W: no-manual-page-for-binary tsxs
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[root@unknown-10-62-163-x SPECS]# ls
distcache.spec  trafficserver-3.0.0.spec  trafficserver.spec
[root@unknown-10-62-163-x SPECS]# rpmlint
/root/rpmbuild/SRPMS/trafficserver-3.0.0-2.fc16.src.rpm
trafficserver.src: I: enchant-dictionary-not-found en_US
trafficserver.src:34: W: macro-in-comment %patch9
trafficserver.src:35: W: macro-in-comment %patch10
trafficserver.src:36: W: macro-in-comment %patch1001
trafficserver.src:47: W: macro-in-comment %find_lang
trafficserver.src:47: W: macro-in-comment %{name}
trafficserver.src:68: W: macro-in-comment %attr
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
[root@unknown-10-62-163-x SPECS]#

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

Tim Lauridsen t...@rasmil.dk changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

--- Comment #1 from Tim Lauridsen t...@rasmil.dk 2011-06-15 04:45:02 EDT ---
I will review this package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

Tim Lauridsen t...@rasmil.dk changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

Tim Lauridsen t...@rasmil.dk changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|t...@rasmil.dk

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

--- Comment #1 from Petr Sabata psab...@redhat.com 2011-06-15 04:53:39 EDT ---
Package: perl-Language-Functional
Version: 0.04
Release: 1.fc15
Sources: Language-Functional-0.04.tar.gz
Patches: perl-Language-Functional-0.04-Fix-any-and-all-on-infinite-list.patch
--
Package successfully built locally.
Package successfully built in mock, fedora-15-x86_64.
Package successfully built in mock, fedora-15-i386.
Package successfully built in koji, dist-rawhide.

MUST items:
[  OK  ] Package does NOT include pre-built binaries or libraries
[  OK  ] Spec file is legible and written in American english
[  OK  ] Package successfully builds on at least one supported primary
architecture
[  --  ] All ExcludeArch tags valid, referencing proper bug reports
[  OK  ] Package obeys FHS (with _libexecdir and /srv exceptions)
[  OK  ] No errors reported by rpmlint
[  OK  ] Changelog present and properly formatted
[  OK  ] Package does NOT include Packager, Vendor, Copyright or PreReq tags
[  OK  ] Source tags are working URLs and sources match upstream or justified
otherwise
[  OK  ] Requires correct or justified otherwise
[ FAIL ] BuildRequires correct or justified otherwise
[  OK  ] All file names are in proper UTF-8 encoding
[  OK  ] All plain text failes are in proper UTF-8 encoding
[  --  ] Large documentation files are located in doc subpackage
[  OK  ] All documentation prefixed with %doc
[  OK  ] Documentation is NOT executable
[  OK  ] No files in %doc are needed at run-time
[  --  ] Compiler flags honor Fedora defaults or are justified
[  --  ] Package generates useful debuginfo packages
[  --  ] Header files are placed in devel subpackage
[  --  ] Unversioned shared libraries are placed in devel subpackage
[  --  ] Pkgconfig files are placed in devel subpackage
[  --  ] Full-versioned Requires of the base package in subpackages
[  --  ] Package calls ldconfig in post and postun sections for all
subpackages, if applicable
[  --  ] Static libraries are provided by static subpackage
[  OK  ] Package contains no static executables unless approved by FESCo
[  OK  ] Package does NOT bundle any system libraries
[  --  ] RPath not used for anything besides internal libraries
[  --  ] All config files are marked noreplace or justified otherwise
[  OK  ] No config files are located under /usr
[  --  ] Package contains a SystemV-compatible initscript
[  --  ] A GUI application installs a proper desktop file
[  --  ] All desktop files are installed by desktop-file-install or justified
otherwise
[  --  ] Package consistently uses macros
[  --  ] makeinstall macro is used only if make install DESTDIR=%{buildroot}
does NOT work
[  --  ] Macros in Summary and description are expandable at build-time
[  --  ] globals used in place of defines
[  --  ] Locales handled correctly -- package requires gettext and uses
find_lang, if applicable
[  --  ] Scriptlets are sane
[  OK  ] Package is not relocatable unless justified
[  OK  ] Package contains only acceptable code or content
[  OK  ] Package owns all the files and directories it creates, installs and/or
uses unless those are already owned by another package
[  OK  ] files sections do NOT contain duplicate files except for licenses
[  OK  ] Package does NOT cause any conflicts
[  OK  ] Package does NOT contain kernel modules
[  OK  ] Package does NOT bundle fonts or other general purpose data
[  OK  ] Final Requires and Provides are sane

SHOULD items:
[  OK  ] The Summary does NOT end with a period
[  OK  ] Package does NOT include BuildRoot tag, clean section or buildroot
removal in install section
[  OK  ] Package should preserve files timestamps
[  OK  ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio,
diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info,
make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip,
util-linux-ng, which or xz
[  OK  ] Description does NOT consist of lines longer than 80 characters
[  OK  ] Package uses parallel make
[  --  ] In case of a web application, package installs date into /usr/share
instead of /var/www
[  OK  ] All patches have a comment or an upstream bug link
[  --  ] Package installs manpages for all executables
[ NOTE ] Package contains check section and all tests pass
[  ??  ] Package works as expected

NOTES:
--
1. [ FAIL ] Missing BuildRequires: perl(vars)
2. [ NOTE ] The patch is required for tests to pass and enhances the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712909] Review Request: rubygem-POpen4 - Open4 cross-platform

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712909

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Blocks||705504

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710912] Review Request: octave-control - Control systems for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710912

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710903] Review Request: octave-miscellaneous - Miscellaneous functions for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710903

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710912] Review Request: octave-control - Control systems for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710912

--- Comment #3 from Thomas Sailer t.sai...@alumni.ethz.ch 2011-06-15 06:08:09 
EDT ---
Thanks for the review!

I've marked the license file as %doc, removed BuildRoot and made the
description more sensible.

http://sailer.fedorapeople.org/octave-control-2.0.2-2.fc15.src.rpm
http://sailer.fedorapeople.org/octave-control.spec

New Package SCM Request
===
Package Name: octave-control
Short Description: Control systems for Octave
Owners: sailer
Branches: f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710902] Review Request: octave-struct - Structure handling for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710902

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710914] Review Request: octave-quaternion - Quaternion package for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710914

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #3 from Thomas Sailer t.sai...@alumni.ethz.ch 2011-06-15 06:13:27 
EDT ---
Thanks for the review!

I've marked the license text and the .ps file as %doc, and removed the
BuildRoot.

http://sailer.fedorapeople.org/octave-quaternion-1.0.0-2.fc15.src.rpm
http://sailer.fedorapeople.org/octave-quaternion.spec

New Package SCM Request
===
Package Name: octave-quaternion
Short Description: Quaternion package for Octave
Owners: sailer
Branches: f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710911] Review Request: octave-audio - Audio for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710911

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #3 from Thomas Sailer t.sai...@alumni.ethz.ch 2011-06-15 06:21:25 
EDT ---
Thanks for the review!

I've marked the license text as %doc, removed the buildroot and rewrote the
package description.

http://sailer.fedorapeople.org/octave-audio-1.1.4-2.fc15.src.rpm
http://sailer.fedorapeople.org/octave-audio.spec

New Package SCM Request
===
Package Name: octave-audio
Short Description: Audio for Octave
Owners: sailer
Branches: f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710909] Review Request: octave-symbolic - Symbolic computations for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710909

Thomas Sailer t.sai...@alumni.ethz.ch changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #3 from Thomas Sailer t.sai...@alumni.ethz.ch 2011-06-15 06:27:00 
EDT ---
Thank you for the quick review!

I've marked the license text as %doc, removed the buildroot, ensured there is
one dependency per BR line, and added a small patch comment.

http://sailer.fedorapeople.org/octave-symbolic-1.0.9-2.fc15.src.rpm
http://sailer.fedorapeople.org/octave-symbolic.spec

New Package SCM Request
===
Package Name: octave-symbolic
Short Description: Symbolic computations for Octave
Owners: sailer
Branches: f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707002

--- Comment #3 from Ankur Sinha sanjay.an...@gmail.com 2011-06-15 06:34:27 
EDT ---
(In reply to comment #2)
 Hi Ankur,

Hi Eric!

 
 Thanks for this great work. We are greatly pleased to be included in Fedora
 Medical and in Fedora in general.

Thank you for taking time out to give us these hints :D

 
 Just some comments on the presentation:
 - license is mainly GPLv3 + LGPL (for some parts)

Corrected.

 - need Qt v4.6.2 at least

Yes. I'm building against 4.7.2:
[root@ankur ~]# repoquery qt-devel
qt-devel-1:4.7.2-8.fc15.i686


 
 For the spec:
 - in order to create the translation add in the %build tag (before the qmake
 step)
 lrelease global_resources/translations/*.ts
 - LOWERED_APPNAME=FreeMedForms  -- needs to be lowered ;) so
 LOWERED_APPNAME=freemedforms. Then libs and plugs should be installed in
 %{_libdir}/freemedforms

Corrected. 

 
 I saw a problem with rpath, 0.5.9~alpha2 should solve it (idem for the debian
 packages).

I'll update the package once you release alpha2 :)

 
 There should be a small issue with the version numbering (because the version
 is parsed in the code). Can't you use 0.5.9~alpha1 instead of 0.5.9-0.1.alpha1
 ? Otherwise I need to patch the 0.5.9~alpha2 code ;)

Uhm, I'll have to ask around. From the guidelines, it should be 0.1.alpha2.
Are you sure the versioning of the rpm has an affect on the package? I haven't
changed the versioning in the build anywhere. It's only for the rpm. 

 
 Can you add a link to our main website: http://www.freemedforms.com/
 

Added :)

 Fell free to contact us at any time for any question at
 freemedfo...@googlegroups.com

I just joined the google groups :)

 
 Thanks for your work
 Eric Maeker

I noticed that freemedforms also bundles quazip. However, the version bundled
has a global.h file, which the latest quazip does not have:

http://sourceforge.net/projects/quazip/files%2Fquazip%2F0.4.1%2Fquazip-0.4.1.tar.gz/download

What version of quazip is being used here? Is this include from quazip, or a
modification required only for freemedforms? 

In the meantime, I cannot build freemedforms :/ (due to the missing global.h
file in the fedora quazip libraries)

[root@ankur ~]# repoquery -l quazip-devel quazip | egrep \.h$
/usr/include/quazip/JlCompress.h
/usr/include/quazip/quaadler32.h
/usr/include/quazip/quachecksum32.h
/usr/include/quazip/quacrc32.h
/usr/include/quazip/quazip.h
/usr/include/quazip/quazipfile.h
/usr/include/quazip/quazipfileinfo.h
/usr/include/quazip/quazipnewinfo.h
/usr/include/quazip/JlCompress.h
/usr/include/quazip/quaadler32.h
/usr/include/quazip/quachecksum32.h
/usr/include/quazip/quacrc32.h
/usr/include/quazip/quazip.h
/usr/include/quazip/quazipfile.h
/usr/include/quazip/quazipfileinfo.h
/usr/include/quazip/quazipnewinfo.h


Thank you Eric :)

Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683463] Review Request: trafficserver - Apache Traffic Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683463

--- Comment #8 from Jan-Frode Myklebust janfr...@tanso.net 2011-06-15 
06:31:57 EDT ---

I'm interested in this for RHEL6/EPEL6, so that's were I'm testing now.

Can't you just delete all the noise from the specfile:

-# we need to deal with the -unstable suffix:
-#Patch9:trafficserver-fix-wccp-support.patch
-#Patch10:   trafficserver_wccp_virtual_destructor.patch
-#Patch1001: trafficserver_ssdtier.patch
-#%patch9 -p1 -b .patch9
-#%patch10 -p1 -b .patch10
-#%patch1001 -p1 -b .patch1001
-#%find_lang %{name}
-# man pages conflicts with man-pages-zh_CN-1.5
-#%attr(0644, root, root) /usr/share/man/man1/*

[janfrode@RHEL6 SPECS]$ rpmlint trafficserver.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.


I'm not seeing the unstripped-binary warnings on RHEL6, so there it's looking
quite good:

$ rpmlint /home/janfrode/rpmbuild/SRPMS/trafficserver-3.0.0-2.oc3.src.rpm
trafficserver.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint
/home/janfrode/rpmbuild/RPMS/x86_64/trafficserver-3.0.0-2.oc3.x86_64.rpm
trafficserver.x86_64: I: enchant-dictionary-not-found en_US
trafficserver.x86_64: W: incoherent-version-in-changelog 3.0.0-2
['3.0.0-2.oc3', '3.0.0-2.oc3']
trafficserver.x86_64: W: hidden-file-or-dir
/etc/trafficserver/body_factory/default/.body_factory_info
trafficserver.x86_64: W: log-files-without-logrotate /var/log/trafficserver
trafficserver.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
trafficserver.x86_64: W: service-default-enabled /etc/init.d/trafficserver
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
$ rpmlint
/home/janfrode/rpmbuild/RPMS/x86_64/trafficserver-debuginfo-3.0.0-2.oc3.x86_64.rpm
trafficserver-debuginfo.x86_64: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint
/home/janfrode/rpmbuild/RPMS/x86_64/trafficserver-devel-3.0.0-2.oc3.x86_64.rpm
trafficserver-devel.x86_64: I: enchant-dictionary-not-found en_US
trafficserver-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683463] Review Request: trafficserver - Apache Traffic Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683463

--- Comment #9 from Jan-Frode Myklebust janfr...@tanso.net 2011-06-15 
07:01:24 EDT ---
To fix the man-page conflict, maybe you can just exclude the 2-3 generically
named man-pages, and keep the rest ?

mkdir -p $RPM_BUILD_ROOT/usr/share/man/man1
cp doc/man/*.1 $RPM_BUILD_ROOT/usr/share/man/man1/
rm -f $RPM_BUILD_ROOT/usr/share/man/man1/enable.1
rm -f $RPM_BUILD_ROOT/usr/share/man/man1/disable.1
rm -f $RPM_BUILD_ROOT/usr/share/man/man1/exit.1

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 649495] Review Request: openstack-nova - OpenStack Compute (nova)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649495

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 CC||mru...@matthias-runge.de

--- Comment #19 from Matthias Runge mru...@matthias-runge.de 2011-06-15 
07:11:31 EDT ---
is this a duplicate of bug #707199 ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 707199] Review Request: openstack-nova - OpenStack Compute (nova)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707199

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 CC||mru...@matthias-runge.de

--- Comment #2 from Matthias Runge mru...@matthias-runge.de 2011-06-15 
07:13:20 EDT ---
looks like a duplicate of 

https://bugzilla.redhat.com/show_bug.cgi?id=649495

Are you going to request reviews for  the other specs mentioned on the
gitgub-page too?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712949] Review Request: gnome-online-accounts - Provide online accounts information

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712949

Bastien Nocera bnoc...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-06-15 07:27:01

--- Comment #9 from Bastien Nocera bnoc...@redhat.com 2011-06-15 07:27:01 EDT 
---
Done in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683463] Review Request: trafficserver - Apache Traffic Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683463

--- Comment #10 from Jan-Frode Myklebust janfr...@tanso.net 2011-06-15 
07:26:33 EDT ---
It was suggested on #epel to rather rename these conflicting man-pages, and
leave a not about it in README.fedora:

mkdir -p $RPM_BUILD_ROOT/usr/share/man/man1
cp doc/man/*.1 $RPM_BUILD_ROOT/usr/share/man/man1/
mv $RPM_BUILD_ROOT/usr/share/man/man1/enable.1
$RPM_BUILD_ROOT/usr/share/man/man1/ts-enable.1
mv $RPM_BUILD_ROOT/usr/share/man/man1/disable.1
$RPM_BUILD_ROOT/usr/share/man/man1/ts-disable.1
mv $RPM_BUILD_ROOT/usr/share/man/man1/exit.1
$RPM_BUILD_ROOT/usr/share/man/man1/ts-exit.1
cat EOF  README.fedora
The man-pages for enable, disable and exit was renamed to ts-enable, 
ts-disable and ts-exit to avoid conflicts with other man-pages.
EOF

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 649495] Review Request: openstack-nova - OpenStack Compute (nova)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649495

--- Comment #20 from Fabian Deutsch fabian.deut...@gmx.de 2011-06-15 07:59:13 
EDT ---
I suppose both specs were developed at a different time, but without knowledge
of each other.

bug #707199 looks much more mature.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

--- Comment #3 from Tim Lauridsen t...@rasmil.dk 2011-06-15 08:02:28 EDT ---
Issues:
[!] : MUST - Rpmlint output is silent.

rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm
   

gnome-shell-extension-pidgin.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
   


rpmlint
gnome-shell-extension-pidgin-debuginfo-0-0.1.git4ca78b1.fc16.i686.rpm
   

gnome-shell-extension-pidgin-debuginfo.i686: E:
description-line-too-long C This package provides debug information for package
gnome-shell-extension-pidgin.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
   


rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.src.rpm
   

gnome-shell-extension-pidgin.src: W: invalid-url Source0:
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
   


[!] : MUST - Development .so files in -devel subpackage, if present.
gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm :
/usr/lib/purple-2/libgnomeshell.so

Looks ok, this is a plugin not at development lib.

[!] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
Makefile.gnomeShellPidgin :
  MD5SUM this package : 52fd5b3e0fe1afe78c0119408a17d2fe
  MD5SUM upstream package : upstream source not found
gnome-shell-extensions-pidgin-License.txt :
  MD5SUM this package : d3ea637572fb8f52b510a60876c6f218
  MD5SUM upstream package : upstream source not found
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2 :
  MD5SUM this package : 2267235a4e7efdd73a2557b107cd9e64
  MD5SUM upstream package : upstream source not found
/home/tim/tmp/reviewhelper/712971/gnomeShellPidgin.c :
  MD5SUM this package : 09c4edcd6a1ce1c7008d942862cf7562
  MD5SUM upstream package : 09c4edcd6a1ce1c7008d942862cf7562

 Should be OK, this is a git checkout and the other files is license and a
Makefile to get it build


[!] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.

Little unsure if the Source3 license file should be installed and put into %DOC
?

Let me know what you think about the Source3 issue and I will approve it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710912] Review Request: octave-control - Control systems for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710912

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:02:29 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

--- Comment #2 from Tim Lauridsen t...@rasmil.dk 2011-06-15 08:00:47 EDT ---

Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - Fully versioned dependency in subpackages, if present.
[-] : MUST - Header files in -devel subpackage, if present.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - License file installed when any subpackage combination is
installed.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - Static libraries in -static subpackage, if present.
[!] : MUST - Rpmlint output is silent.

rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm
   

gnome-shell-extension-pidgin.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
   


rpmlint
gnome-shell-extension-pidgin-debuginfo-0-0.1.git4ca78b1.fc16.i686.rpm
   

gnome-shell-extension-pidgin-debuginfo.i686: E:
description-line-too-long C This package provides debug information for package
gnome-shell-extension-pidgin.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
   


rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.src.rpm
   

gnome-shell-extension-pidgin.src: W: invalid-url Source0:
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
   


[!] : MUST - Development .so files in -devel subpackage, if present.
gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm :
/usr/lib/purple-2/libgnomeshell.so

[!] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
Makefile.gnomeShellPidgin :
  MD5SUM this package : 52fd5b3e0fe1afe78c0119408a17d2fe
  MD5SUM upstream package : upstream source not found
gnome-shell-extensions-pidgin-License.txt :
  MD5SUM this package : d3ea637572fb8f52b510a60876c6f218
  MD5SUM upstream package : upstream source not found
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2 :
  MD5SUM this package : 2267235a4e7efdd73a2557b107cd9e64
  MD5SUM upstream package : upstream source not found
/home/tim/tmp/reviewhelper/712971/gnomeShellPidgin.c :
  MD5SUM this package : 09c4edcd6a1ce1c7008d942862cf7562
  MD5SUM upstream package : 09c4edcd6a1ce1c7008d942862cf7562

[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[-] : MUST - Large documentation files are in a -doc subpackage, if required.
[!] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the 

[Bug 710907] Review Request: octave-specfun - Specfun for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710907

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:01:28 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710911] Review Request: octave-audio - Audio for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710911

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:02:10 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710902] Review Request: octave-struct - Structure handling for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710902

--- Comment #8 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:00:31 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710909] Review Request: octave-symbolic - Symbolic computations for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710909

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:01:50 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710903] Review Request: octave-miscellaneous - Miscellaneous functions for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710903

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:00:57 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711762] Review Request: osc - openSUSE Build Service Commander

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711762

--- Comment #11 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:03:24 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710914] Review Request: octave-quaternion - Quaternion package for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710914

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:02:46 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

Petr Sabata psab...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Petr Sabata psab...@redhat.com 2011-06-15 08:08:07 EDT ---
(In reply to comment #1)
 (...)
 1. [ FAIL ] Missing BuildRequires: perl(vars)

Never mind; apparently this has never been a separate package.

Approving.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

Steven Dake sd...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|sd...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

Steven Dake sd...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Steven Dake sd...@redhat.com 2011-06-15 08:25:09 EDT ---
oz seems to make sense from a project name perspective.  Maybe Chris has a
different viewpoint.  I will provide review of this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

--- Comment #3 from Petr Pisar ppi...@redhat.com 2011-06-15 08:32:55 EDT ---
New Package SCM Request
===
Package Name: perl-Language-Functional 
Short Description: Module which makes Perl slightly more functional
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-06-15 08:42:18 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713443] New: Review Request: yelp-tools - Create, manage, and publish documentation for Yelp

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: yelp-tools - Create, manage, and publish documentation 
for Yelp

https://bugzilla.redhat.com/show_bug.cgi?id=713443

   Summary: Review Request: yelp-tools - Create, manage, and
publish documentation for Yelp
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: z...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://zeenix.fedorapeople.org/yelp-tools.spec
SRPM URL: http://zeenix.fedorapeople.org/yelp-tools-3.1.4-1.fc16.src.rpm
Description:
yelp-tools is a collection of scripts and build utilities to help create,
manage, and publish documentation for Yelp and the web. Most of the heavy
lifting is done by packages like yelp-xsl and itstool. This package just
wraps things up in a developer-friendly way.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #2 from Steven Dake sd...@redhat.com 2011-06-15 09:28:45 EDT ---
MUST review:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1] 

FAIL: there are a few problems in the rpmlint results.  This is a BLOCKER.

the source rpm

[sdake@beast Downloads]$ rpmlint oz*src.rpm
oz.src: W: non-standard-group Development
oz.src: W: invalid-url Source0: oz-0.4.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

the rpm:

[sdake@beast noarch]$ rpmlint oz*
oz.noarch: W: non-standard-group Development
oz.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/oz/guesttools/icicle-nc 0644L /bin/bash
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

1. Source0 should be a full url.  I recommend:
I recommend:
Source0:
http://repos.fedorahosted.org/repos/aeolus/oz/0.4.0/tarball/%{name}-%{version}.tar.gz
2. Group should either be Development Tools or Development Libraries.
3. icicle-nc should have its permissions set to 755.

MUST: The package must be named according to the Package Naming Guidelines .

PASS: the package is named according to package naming guidelines.

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .

PASS: The spec file name matches the base package name.

MUST: The package must meet the Packaging Guidelines .

PASS: package meets packaging guidelines.

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .

PASS: The package is licensed under lgplv2.1 which is an approved license.
MUST: The License field in the package spec file must match the actual license.
[3]

FAIL: The COPYING file and header files indicate the code is licensed under
lgplv2.1, however, spec file indicates code licensed under lgplv2

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]

PASS: package contains a license file and that license file in %do section

MUST: The spec file must be written in American English. [5]

PASS: spec file written in English

MUST: The spec file for the package MUST be legible. [6]

PASS: spec file is very legible

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

The source0 package should be the upstream package location including url.

upstream package:

from SRC RPM:

FAIL - md5sums do not match this is a BLOCKER

[sdake@beast Downloads]$ md5sum oz-0.4.0.tar.gz
cd1639af62509c677c95d94705042772  oz-0.4.0.tar.gz

md5sum [sdake@beast SOURCES]$ md5sum oz-0.4.0.tar.gz
d2f774e97ca5ac0c34b9f07b6ea1bd01  oz-0.4.0.tar.gz

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]

PASS - I personally built on x86_64

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]

PASS - this is a noarch python package

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

PASS - I built on clean cloned f15 VM that are expected in the build root.  I
then installed python (build requires) and package builds properly.

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]

PASS - no locale functionality is included upstream.

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]

PASS - this package is python only (noarch) and does not have shared objects

MUST: Packages must NOT bundle copies of system libraries.[11]

PASS - no system libraries are bundled by package.

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]

PASS - no request for relocate functionality.

[Bug 713461] New: Review Request: tomahawk - The Social Music Player

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: tomahawk - The Social Music Player

https://bugzilla.redhat.com/show_bug.cgi?id=713461

   Summary: Review Request: tomahawk - The Social Music Player
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rdie...@math.unl.edu
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/tomahawk/tomahawk-0.1.0-3.20110614.fc14.src.rpm
Description:
Stop chasing your music across different machines, services and
websites. It's time to take the work out of play. If the song you want
to listen to is in your local library, it just plays. If the song is on
a remote machine, it just plays. If the song is on the web, or available
from your subscription service, it just plays. By abstracting a piece
of content's metadata from its file location, users can easily share
playlists, listening history and more. It's sort of like Wonka Vision,
Tomahawk will reassemble it on the other side. OK, maybe that's not a
good analogy... but it's just as delicious.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713461] Review Request: tomahawk - The Social Music Player

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713461

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||656997(kde-reviews)

--- Comment #1 from Rex Dieter rdie...@math.unl.edu 2011-06-15 09:33:31 EDT 
---
$ rpmlint *.rpm x86_64/*.rpm
tomahawk.src: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
tomahawk.src: W: spelling-error %description -l en_US playlists - play lists,
play-lists, playlets
tomahawk.src:12: W: macro-in-comment %{version}
tomahawk.src:17: W: macro-in-comment %{version}
tomahawk.src:17: W: macro-in-comment %{snap}
tomahawk.src:34: W: unversioned-explicit-provides bundled(qtweetlib)
tomahawk.src: W: invalid-url Source0: tomahawk-0.1-20110614.tar.bz2
tomahawk.x86_64: W: spelling-error %description -l en_US metadata - meta data,
meta-data, metatarsus
tomahawk.x86_64: W: spelling-error %description -l en_US playlists - play
lists, play-lists, playlets
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_sipzeroconf.so
libtomahawk_sipzeroconf.so
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawk_portfwd.so
libtomahawk_portfwd.so
tomahawk.x86_64: E: invalid-soname /usr/lib64/libtomahawklib.so
libtomahawklib.so
tomahawk.x86_64: W: shared-lib-calls-exit /usr/lib64/libtomahawklib.so
exit@GLIBC_2.2.5
tomahawk.x86_64: W: no-manual-page-for-binary tomahawk
tomahawk-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/tomahawk-0.1/x86_64-redhat-linux-gnu/thirdparty/liblastfm2/src/lastfm/AbstractType
3 packages and 0 specfiles checked; 4 errors, 11 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #3 from Steven Dake sd...@redhat.com 2011-06-15 09:33:10 EDT ---
Summary of MUST review blockers:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1] 

FAIL: there are a few problems in the rpmlint results.  This is a BLOCKER.

the source rpm

[sdake@beast Downloads]$ rpmlint oz*src.rpm
oz.src: W: non-standard-group Development
oz.src: W: invalid-url Source0: oz-0.4.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

the rpm:

[sdake@beast noarch]$ rpmlint oz*
oz.noarch: W: non-standard-group Development
oz.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/oz/guesttools/icicle-nc 0644L /bin/bash
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

1. Source0 should be a full url.  I recommend:
I recommend:
Source0:
http://repos.fedorahosted.org/repos/aeolus/oz/0.4.0/tarball/%{name}-%{version}.tar.gz
2. Group should either be Development Tools or Development Libraries.
3. icicle-nc should have its permissions set to 755.MUST: rpmlint must be run
on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1] 

FAIL: there are a few problems in the rpmlint results.  This is a BLOCKER.

the source rpm

[sdake@beast Downloads]$ rpmlint oz*src.rpm
oz.src: W: non-standard-group Development
oz.src: W: invalid-url Source0: oz-0.4.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

the rpm:

[sdake@beast noarch]$ rpmlint oz*
oz.noarch: W: non-standard-group Development
oz.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/oz/guesttools/icicle-nc 0644L /bin/bash
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

1. Source0 should be a full url.  I recommend:
I recommend:
Source0:
http://repos.fedorahosted.org/repos/aeolus/oz/0.4.0/tarball/%{name}-%{version}.tar.gz
2. Group should either be Development Tools or Development Libraries.
3. icicle-nc should have its permissions set to 755.


MUST: The License field in the package spec file must match the actual license.
[3]

FAIL: The COPYING file and header files indicate the code is licensed under
lgplv2.1, however, spec file indicates code licensed under lgplv2
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

The source0 package should be the upstream package location including url.

upstream package:

from SRC RPM:
FAIL - md5sums do not match this is a BLOCKER

[sdake@beast Downloads]$ md5sum oz-0.4.0.tar.gz
cd1639af62509c677c95d94705042772  oz-0.4.0.tar.gz

md5sum [sdake@beast SOURCES]$ md5sum oz-0.4.0.tar.gz
d2f774e97ca5ac0c34b9f07b6ea1bd01  oz-0.4.0.tar.gz

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]

FAIL - icicle-nc is not set with execute permissions - THIS IS A BLOCKER

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #4 from Steven Dake sd...@redhat.com 2011-06-15 09:36:52 EDT ---
Pádraig,

Please resolve the failing MUST review items in comment #3.  The differing
md5sums are particularly troubling.  If you have made changes to the source
tree, I'd recommend requesting upstream to release a new tarball.

Further review is blocked until MUST items are resolved.

Regards
-steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #5 from Chris Lalancette clala...@redhat.com 2011-06-15 09:38:19 
EDT ---
(In reply to comment #1)
 oz seems to make sense from a project name perspective.  Maybe Chris has a
 different viewpoint.  I will provide review of this package.

Yeah, I would go with oz as the package name.  Although this is part of the
aeolus project, my feeling is that oz has use outside of the project.

Pádraig, once you fix the issues that Steve found, I would appreciate patches
to the .spec file upstream.  At least then we can keep it mostly in-sync with
what is in Fedora.

Thanks,
Chris Lalancette

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713212] Review Request: perl-Language-Functional - Module which makes Perl slightly more functional

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713212

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Language-Functional-0.
   ||04-1.fc16
 Resolution||RAWHIDE
Last Closed||2011-06-15 09:35:37

--- Comment #5 from Petr Pisar ppi...@redhat.com 2011-06-15 09:35:37 EDT ---
Thank you for the review and the repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712566] Review Request: gnome-shell-theme-tron-legacy - the tron-legacy gnome-shell theme

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712566

Bastien Nocera bnoc...@redhat.com changed:

   What|Removed |Added

 CC||bnoc...@redhat.com

--- Comment #1 from Bastien Nocera bnoc...@redhat.com 2011-06-15 09:42:50 EDT 
---
Drive-by comment, using either copyrighted material, or trademark names without
the holders' consent probably will make this package unsuitable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 704239] Review Request: python-yolk - Command-line tool querying PyPI and Python packages installed on your system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=704239

--- Comment #7 from Jerome Soyer sai...@gmail.com 2011-06-15 10:40:38 EDT ---
I will send a mail upstream for more information about the test.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 712566] Review Request: gnome-shell-theme-tron-legacy - the tron-legacy gnome-shell theme

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712566

Tim Lauridsen t...@rasmil.dk changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||CANTFIX
Last Closed||2011-06-15 10:39:19

--- Comment #2 from Tim Lauridsen t...@rasmil.dk 2011-06-15 10:39:19 EDT ---
Yes, this is a problem, Tron is a trademark of Disney, so this package is not
suitable for Fedora.

I will close the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688121

--- Comment #19 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:54:17 EDT ---
mod_flvx-0-0.1.20100525git.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 609817] Review Request: dojo - Modular JavaScript toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609817

--- Comment #22 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:55:01 EDT ---
dojo-1.6.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688121

--- Comment #20 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:55:25 EDT ---
mod_flvx-0-0.1.20100525git.el5 has been pushed to the Fedora EPEL 5 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663925

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|autoconf-archive-2011.04.12 |autoconf-archive-2011.04.12
   |-1.fc14 |-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688121

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|mod_flvx-0-0.1.20100525git. |mod_flvx-0-0.1.20100525git.
   |el6 |el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 609817] Review Request: dojo - Modular JavaScript toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609817

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|dojo-1.6.0-1.fc13   |dojo-1.6.0-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688121

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|mod_flvx-0-0.1.20100525git. |mod_flvx-0-0.1.20100525git.
   |fc13|el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 609817] Review Request: dojo - Modular JavaScript toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609817

--- Comment #23 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:58:09 EDT ---
dojo-1.6.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663925

--- Comment #22 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:57:57 EDT ---
autoconf-archive-2011.04.12-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698590

--- Comment #18 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:56:28 EDT ---
drupal6-features-1.0-3.el5 has been pushed to the Fedora EPEL 5 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698590

--- Comment #19 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:58:34 EDT ---
drupal6-features-1.0-3.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663925

--- Comment #21 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:56:51 EDT ---
autoconf-archive-2011.04.12-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688121

--- Comment #21 from Fedora Update System upda...@fedoraproject.org 
2011-06-15 10:58:51 EDT ---
mod_flvx-0-0.1.20100525git.el4 has been pushed to the Fedora EPEL 4 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698590

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|drupal6-features-1.0-3.fc14 |drupal6-features-1.0-3.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 663925] Review Request: autoconf-archive - The Autoconf Macro Archive

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663925

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|autoconf-archive-2011.04.12 |autoconf-archive-2011.04.12
   |-1.el6  |-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 688121] Review Request: mod_flvx - FLV progressive download streaming for the Apache HTTP Server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688121

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|mod_flvx-0-0.1.20100525git. |mod_flvx-0-0.1.20100525git.
   |el5 |el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 609817] Review Request: dojo - Modular JavaScript toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609817

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|dojo-1.6.0-1.el5|dojo-1.6.0-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 698590] Review Request: drupal6-features - Provides feature management for Drupal

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698590

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|drupal6-features-1.0-3.el5  |drupal6-features-1.0-3.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #6 from Pádraig Brady p...@draigbrady.com 2011-06-15 11:04:19 EDT 
---
The md5sum discrepancies are because there is no usable (noarch) upstream
tarball yet. I wanted to clarify things before asking chris to release (0.4.1).

Note I'll be using ...fedorapeople... rather than ...fedorahosted... for the
URL, as the latter doesn't seem to exist at the moment.

Patch to aeolus-devel coming up...

thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 707002] Review Request: FreeMedForms - An open Electronic Medical Record Manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707002

--- Comment #4 from Ankur Sinha sanjay.an...@gmail.com 2011-06-15 11:10:40 
EDT ---
I've built and tested it. It works :)

A scratch build for x86_64 is here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3132734

Updated spec:
http://ankursinha.fedorapeople.org/freemedforms/freemedforms.spec

Updated srpm:
http://ankursinha.fedorapeople.org/freemedforms/freemedforms-0.5.9-0.1.alpha1.fc15.src.rpm

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713508] New: Review Request: rubygem-oauth - OAuth Core Ruby implementation

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-oauth - OAuth Core Ruby implementation

https://bugzilla.redhat.com/show_bug.cgi?id=713508

   Summary: Review Request: rubygem-oauth - OAuth Core Ruby
implementation
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: vondr...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
  Story Points: ---


Spec URL: http://people.redhat.com/vondruch/rubygem-oauth.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-oauth-0.4.4-1.fc16.src.rpm

Description: 
This is a RubyGem for implementing both OAuth clients and servers
in Ruby applications.

See the OAuth specs http://oauth.net/core/1.0/ 

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3132936

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713508] Review Request: rubygem-oauth - OAuth Core Ruby implementation

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713508

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Blocks||705516

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #7 from Chris Lalancette clala...@redhat.com 2011-06-15 11:31:10 
EDT ---
(In reply to comment #6)
 The md5sum discrepancies are because there is no usable (noarch) upstream
 tarball yet. I wanted to clarify things before asking chris to release 
 (0.4.1).
 
 Note I'll be using ...fedorapeople... rather than ...fedorahosted... for the
 URL, as the latter doesn't seem to exist at the moment.
 
 Patch to aeolus-devel coming up...
 
 thanks!

Hm.  I might suggest that you just use the 0.4.0 release directly (i.e. the
arch-specific one).  Yes, it sucks a bit that it is arch-specific, but when I
release 0.5.0, we can then upgrade to that and move it to noarch[1].

Another option is to use the 0.4.0 release tarball, but put the noarch patch in
as a specfile patch on top of that.  It makes me a bit nervous, though; that is
a big change, and I haven't yet run that patch through my full functional
tests.

Chris Lalancette

[1] Given the number of fixes that are coming into oz lately, it looks like
I'll probably do a 0.5.0 bugfix release sooner rather than later.  So it may
not be all that long.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #8 from Steven Dake sd...@redhat.com 2011-06-15 12:06:46 EDT ---
yup fedorapeople is the current url that comes up with you click download. 
mistype on my part.  thanks for catching !

In reply to comment #6, an RPM source tarball must be pristine matching exactly
what upstream releases.  Many automated tools use the upstream source tarball
for their internal consistency and security checks.  Patches on top of that
that are distro specific but not merged upstream are allowed (but highly
discouraged and usually limited in scope to things like init scripts etc). 
Patches on top of a source tarball as separate patch# lines that are merged
into the declared upstream repo are fine (this was chris's second option).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710911] Review Request: octave-audio - Audio for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710911

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710907] Review Request: octave-specfun - Specfun for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710907

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710914] Review Request: octave-quaternion - Quaternion package for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710914

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710909] Review Request: octave-symbolic - Symbolic computations for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710909

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710902] Review Request: octave-struct - Structure handling for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710902

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-06-15 
12:32:29 EDT ---
octave-control-2.0.2-2.fc15,octave-symbolic-1.0.9-2.fc15,octave-audio-1.1.4-2.fc15,octave-quaternion-1.0.0-2.fc15,octave-miscellaneous-1.0.11-2.fc15,octave-specfun-1.0.9-2.fc15,octave-struct-1.0.9-3.fc15
has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/octave-control-2.0.2-2.fc15,octave-symbolic-1.0.9-2.fc15,octave-audio-1.1.4-2.fc15,octave-quaternion-1.0.0-2.fc15,octave-miscellaneous-1.0.11-2.fc15,octave-specfun-1.0.9-2.fc15,octave-struct-1.0.9-3.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710902] Review Request: octave-struct - Structure handling for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710902

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710912] Review Request: octave-control - Control systems for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710912

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710907] Review Request: octave-specfun - Specfun for Octave

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710907

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-06-15 
12:32:34 EDT ---
octave-control-2.0.2-2.fc15,octave-symbolic-1.0.9-2.fc15,octave-audio-1.1.4-2.fc15,octave-quaternion-1.0.0-2.fc15,octave-miscellaneous-1.0.11-2.fc15,octave-specfun-1.0.9-2.fc15,octave-struct-1.0.9-3.fc15
has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/octave-control-2.0.2-2.fc15,octave-symbolic-1.0.9-2.fc15,octave-audio-1.1.4-2.fc15,octave-quaternion-1.0.0-2.fc15,octave-miscellaneous-1.0.11-2.fc15,octave-specfun-1.0.9-2.fc15,octave-struct-1.0.9-3.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review