[Bug 690728] Review Request: Nitrate - A test case management system written in Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690728 --- Comment #38 from Yuguang Wang yuw...@redhat.com 2011-06-16 02:36:11 EDT --- Wow, no bundled libraries allowed! I need to remove them from the source, need some configuration work to do. (In reply to comment #36) Seems it has some bundled libraries: ./tcms/core/lib/odfpy = provided by package: odfpy.noarch ./tcms/core/lib/django-pagination = provided by package: django-pagination.noarch http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries (In reply to comment #35) I changed Django from 1.2.3 to 1.2.5 Ok, but the question was: (why) do you need to specify the version there? Current Fedora has version 1.3. ;) I suggest not to specify the version or if you want to safeguard with a minimum safe django version use =. The easiest is just to drop the version unless it is absolutely needed. I haven't tested it in 1.3 or higher, we're using 1.2.5 currently, I'm worrying about the compatibility issues.. I'll have some test and give a minimum version if possible :) and fixed the issues you mentioned in comment 31 So you need mod_python? mod_python is not necessary for the package itself, it's needed during the deployment. I think remove this package is ok, I'll do that. https://fedoraproject.org/wiki/PackagingDrafts/JavaScript As I said before I would like to see a declaration of all the third-party (javascript) libraries being used by nitrate, where they come from, and their license. Did you look at the tinymce review? (bug 608574) This library is large and certainly should be packaged separately. Since the above referenced package review seems to have stalled perhaps you could help to get the package into Fedora. (In reply to comment #36) ./tcms/core/lib/odfpy = provided by package: odfpy.noarch ./tcms/core/lib/django-pagination = provided by package: django-pagination.noarch okay I'll do that. Seems there's still some work to do, will update after all these problems fixed. Thanks for your help on this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710905] Review Request: octave-optim - Optimization for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710905 --- Comment #2 from Thomas Sailer t.sai...@alumni.ethz.ch 2011-06-16 02:53:44 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=3133932 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690728] Review Request: Nitrate - A test case management system written in Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690728 --- Comment #39 from Jens Petersen peter...@redhat.com 2011-06-16 03:07:30 EDT --- (In reply to comment #38) mod_python is not necessary for the package itself, it's needed during the deployment. I think remove this package is ok, I'll do that. Ok thanks for explanation. Well if it is needed to use the package normally you can leave it in, otherwise if it is optional then better to remove the dependency. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683463] Review Request: trafficserver - Apache Traffic Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683463 --- Comment #11 from Zhao Yongming ming@gmail.com 2011-06-16 03:41:45 EDT --- http://zymlinux.net/trafficserver/rpm/3.0.0-3/ http://zymlinux.net/trafficserver/rpm/3.0.0-3/trafficserver-3.0.0-3.fc16.src.rpm http://zymlinux.net/trafficserver/rpm/3.0.0-3/trafficserver-3.0.0-3.fc16.x86_64.rpm http://zymlinux.net/trafficserver/rpm/3.0.0-3/trafficserver-devel-3.0.0-3.fc16.x86_64.rpm updates the man-pages and cleanup spec file, thanks Jan-Frode Myklebust janfr...@tanso.net [root@unknown-10-62-163-x rpmbuild]# rpmlint SRPMS/trafficserver-3.0.0-3.fc16.src.rpm RPMS/x86_64/trafficserver-devel-3.0.0-3.fc16.x86_64.rpm RPMS/x86_64/trafficserver-3.0.0-3.fc16.x86_64.rpm trafficserver.src: I: enchant-dictionary-not-found en_US trafficserver-devel.x86_64: W: no-documentation trafficserver-devel.x86_64: W: no-manual-page-for-binary tsxs trafficserver.x86_64: W: unstripped-binary-or-object /usr/lib64/trafficserver/plugins/conf_remap.so trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_shell trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_sac trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_logstats trafficserver.x86_64: W: unstripped-binary-or-object /usr/lib64/trafficserver/libtsutil.so.3.0.0 trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_server trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_line trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_logcat trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_cop trafficserver.x86_64: W: unstripped-binary-or-object /usr/lib64/trafficserver/libtsmgmt.so.3.0.0 trafficserver.x86_64: W: unstripped-binary-or-object /usr/bin/traffic_manager trafficserver.x86_64: W: hidden-file-or-dir /etc/trafficserver/body_factory/default/.body_factory_info trafficserver.x86_64: W: manual-page-warning /usr/share/man/man1/config_clock.1.gz 53: warning: macro `..' not defined trafficserver.x86_64: W: manual-page-warning /usr/share/man/man1/config_logging.1.gz 89: warning: macro `SScustom' not defined (possibly missing space after `SS') trafficserver.x86_64: W: log-files-without-logrotate /var/log/trafficserver trafficserver.x86_64: W: no-manual-page-for-binary traffic_server trafficserver.x86_64: W: no-manual-page-for-binary traffic_manager trafficserver.x86_64: W: no-manual-page-for-binary traffic_line trafficserver.x86_64: W: no-manual-page-for-binary traffic_sac trafficserver.x86_64: W: no-manual-page-for-binary traffic_cop trafficserver.x86_64: W: no-manual-page-for-binary traffic_logstats trafficserver.x86_64: W: no-manual-page-for-binary traffic_logcat trafficserver.x86_64: W: one-line-command-in-%postun /sbin/ldconfig trafficserver.x86_64: W: service-default-enabled /etc/init.d/trafficserver 3 packages and 0 specfiles checked; 0 errors, 26 warnings. [root@unknown-10-62-163-x rpmbuild]# -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713677] Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713677 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Alias||klt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713677] New: Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker. https://bugzilla.redhat.com/show_bug.cgi?id=713677 Summary: Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: sanjay.an...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://ankursinha.fedorapeople.org/klt/klt.spec SRPM URL: http://ankursinha.fedorapeople.org/klt/klt-1.3.4-1.fc15.src.rpm Description: KLT is an implementation, in the C programming language, of a feature tracker for the computer vision community. The source code is in the public domain, available for both commercial and non-commercial use. The tracker is based on the early work of Lucas and Kanade, was developed fully by Tomasi and Kanade, and was explained clearly in the paper by Shi and Tomasi. Later, Tomasi proposed a slight modification which makes the computation symmetric with respect to the two images -- the resulting equation is derived in the unpublished note by myself. Briefly, good features are located by examining the minimum eigenvalue of each 2 by 2 gradient matrix, and features are tracked using a Newton-Raphson method of minimizing the difference between the two windows. Multi-resolution tracking allows for relatively large displacements between images. The affine computation that evaluates the consistency of features between non-consecutive frames was implemented by Thorsten Thormaehlen several years after the original code and documentation were written. rpmlint output: [ankur@ankur SRPMS]$ rpmlint ../SPECS/klt.spec klt-1.3.4-1.fc15.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm klt.src: W: spelling-error %description -l en_US Multi - Mulch, Mufti klt.src: W: spelling-error %description -l en_US affine - caffeine, fine klt.i686: E: devel-dependency klt-devel klt.i686: W: spelling-error %description -l en_US Multi - Mulch, Mufti klt.i686: W: spelling-error %description -l en_US affine - caffeine, fine klt.i686: E: no-binary klt.src: W: spelling-error %description -l en_US Multi - Mulch, Mufti klt.src: W: spelling-error %description -l en_US affine - caffeine, fine ^^^ Ignorable klt-debuginfo.i686: E: empty-debuginfo-package ^^^ Not sure why this is still happening. All the .o files are there :/ klt-devel.i686: W: no-documentation ^^^ Separate documentation folder 6 packages and 1 specfiles checked; 3 errors, 7 warnings. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713677] Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713677 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Blocks||567086(vxl) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567086
Ankur Sinha sanjay.an...@gmail.com changed:
What|Removed |Added
CC||sanjay.an...@gmail.com
Depends on||713677(klt)
--- Comment #24 from Ankur Sinha sanjay.an...@gmail.com 2011-06-16 04:19:19
EDT ---
Hello,
An informal review :D
+ OK
- NA
? ISSUE
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
? Meets Packaging Guidelines.
There's the issue of bundled libraries. Most of them have been removed. On the
ones that are still present:
netlib: is heavily modified and therefore should not be removed
QV: Some parts of this appear to have been used in the package. The qv library
is now obsolete and it's routines have probably been made a part of Inventor.
(We've asked the Inventor maintainer to please look into it)
Since QV is obsolete, it's unlikely that there will be a duplication of the
library (It's been dead for a while now). IMO, it's okay to let these files be
in the package.
There are some more bundles:
./contrib/conversions/
^^^
I haven't been found anything online regarding the source either. The README
says that it's only a couple of routines, and not the entire library. Think
this one can be counted as an internal library too.
./contrib/gel/vgel/kl/
^^^
I did find the source of KLT here, and therefore I think we need to unbundle
it:
http://www.ces.clemson.edu/~stb/klt/
I've submitted a review request here:
https://bugzilla.redhat.com/show_bug.cgi?id=713677
It's a simple package, shouldn't take more than 20 mins to review I'm hoping
that will serve the purpose. If it does not, keeping the bundle is the only way
to go.
./contrib/oul/oufgl/
^^^
The only results that I get on googling these two appear to be from the VXL
source tree. It mentions Otago University Frame Grabber Library but I cannot
find the source anywhere online. I did one of the developers' homepage here:
http://www.cs.otago.ac.nz/staffpriv/mccane/software.html
As you'll see, he is the developer of vxl as well. I don't think oufgl is
intended for any other use and is therefore an internal library here. If in
future, there is a source release of the library, we can package it separately
and unbundle it from vxl.
Please feel free to add any more info on these bundles if you come across any.
+ License
+ License field in spec matches
^^^
You might want to check on this. Grepping the directory for LGPL does give some
output. :
[ankur@ankur vxl-1.14.0]$ egrep -nri LGPL *
Binary file contrib/gel/vifa/tests/cam0013.tif matches
contrib/brl/bbas/bil/algo/bil_edt.h:37:// Implementation influenced by the LTI
lib, which is licensed under LGPL:
contrib/brl/b3p/shapelib/shpopen.c:11: * or at the option of the licensee under
the LGPL (see LICENSE.LGPL). This
contrib/brl/b3p/shapelib/shptree.c:11: * or at the option of the licensee under
the LGPL (see LICENSE.LGPL). This
contrib/brl/b3p/shapelib/dbfopen.c:11: * or at the option of the licensee under
the LGPL (see LICENSE.LGPL). This
contrib/brl/b3p/shapelib/shapefil.h:13: * or at the option of the licensee
under the LGPL (see LICENSE.LGPL). This
Please do double check this.
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
? Package has a correct %clean section.
Not required any more. You can get rid of it.
? Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Not required any more. You can get rid of it.
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
+ Headers/static libs in -devel subpackage.
+ Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
+ .so files in -devel subpackage.
+ -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.
^^
[ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
../SPECS/vxl.spec vxl-1.14.0-1.fc15.src.rpm
vxl.i686: W: shared-lib-calls-exit /usr/lib/libv3p_netlib.so.1.14.0
exit@GLIBC_2.0
vxl.i686: W: shared-lib-calls-exit /usr/lib/libvil.so.1.14.0
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 --- Comment #25 from Peter Lemenkov lemen...@gmail.com 2011-06-16 04:30:12 EDT --- Hello! (In reply to comment #24) Hello, An informal review :D Ankur, please, reassign this ticket to yourself - I don;t have free time to compolete the review in the next week or two. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 --- Comment #26 from Mario Ceresa mrcer...@gmail.com 2011-06-16 04:35:34 EDT --- Hi all! @Ankur: thanks a lot for your input! I'll review klt and agree that the other libs should stay bundled. I'm not familiar with the final provides and requires are sane: and review-req-check parts. What exactly should I do here? @Peter: ok thank you for bringing me so far :) Best, Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713677] Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713677 Mario Ceresa mrcer...@gmail.com changed: What|Removed |Added CC||mrcer...@gmail.com AssignedTo|nob...@fedoraproject.org|mrcer...@gmail.com Flag||fedora-review? --- Comment #1 from Mario Ceresa mrcer...@gmail.com 2011-06-16 04:38:07 EDT --- I'll review it! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 --- Comment #27 from Ankur Sinha sanjay.an...@gmail.com 2011-06-16 04:42:49 EDT --- Hi Peter, (In reply to comment #25) Hello! (In reply to comment #24) Hello, An informal review :D Ankur, please, reassign this ticket to yourself - I don;t have free time to compolete the review in the next week or two. I'll do that :) Thanks, (In reply to comment #26) Hi all! @Ankur: thanks a lot for your input! I'll review klt and agree that the other libs should stay bundled. I'm not familiar with the final provides and requires are sane: and review-req-check parts. What exactly should I do here? Hi Mario, You need to just look at the list and see if the requires and provides are what they should be ;) review-req-check is just an alias: alias review-req-check='for i in *rpm; do echo == $i ==; echo Provides:; rpm -qp --provides $i | sed /rpmlib.*/d ; echo ; echo Requires:; rpm -qp --requires $i | sed /rpmlib.*/d; echo; done'$ @Peter: ok thank you for bringing me so far :) Best, Mario Thanks for taking klt Mario, Thanks Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713584
Elad Alfassa el...@doom.co.il changed:
What|Removed |Added
CC||el...@doom.co.il
AssignedTo|nob...@fedoraproject.org|el...@doom.co.il
Flag||fedora-review?
--- Comment #1 from Elad Alfassa el...@doom.co.il 2011-06-16 05:04:49 EDT ---
I'll do the review.
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
6a2549ac55216cbb62dc2079b6dc4f46 cogl-1.7.0.tar.bz2
- Package needs ExcludeArch
- BuildRequires correct
+ Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
+ Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
+ .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
+ -devel package Requires: %{name} = %{version}-%{release}
+ .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
? No rpmlint output.
[elad@elephant SRPMS]$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/cogl-*
cogl.src: W: spelling-error %description -l en_US backends - back ends,
back-ends, backhands
cogl.src: W: spelling-error %description -l en_US drm - rm, dram, dorm
cogl.x86_64: W: spelling-error %description -l en_US backends - back ends,
back-ends, backhands
cogl.x86_64: W: spelling-error %description -l en_US drm - rm, dram, dorm
cogl.x86_64: W: shared-lib-calls-exit /usr/lib64/libcogl.so.0.0.0
exit@GLIBC_2.2.5
cogl.x86_64: E: incorrect-fsf-address /usr/share/doc/cogl-1.7.0/COPYING
cogl-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 1 errors, 6 warnings.
Spelling errors and the no-documentation error can be ignored, but please fix
the FSF address (and submit a patch to upsteam with the fix)
+ final provides and requires are sane:
cogl-1.7.0-1.fc16.src.rpm
=
cairo-devel
glib2-devel
gobject-introspection-devel
gtk-doc
libXcomposite-devel
libXdamage-devel
libXext-devel
libXfixes-devel
mesa-libGL-devel
pango-devel
pkgconfig
rpmlib(FileDigests) = 4.6.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
cogl-1.7.0-1.fc16.x86_64.rpm
libcogl-pango.so.0()(64bit)
libcogl.so.0()(64bit)
cogl = 1.7.0-1.fc16
cogl(x86-64) = 1.7.0-1.fc16
=
/sbin/ldconfig
/sbin/ldconfig
libGL.so.1()(64bit)
libX11.so.6()(64bit)
libXcomposite.so.1()(64bit)
libXdamage.so.1()(64bit)
libXext.so.6()(64bit)
libXfixes.so.3()(64bit)
libc.so.6()(64bit)
libc.so.6(GLIBC_2.11)(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.7)(64bit)
libcairo.so.2()(64bit)
libcogl.so.0()(64bit)
libdl.so.2()(64bit)
libdl.so.2(GLIBC_2.2.5)(64bit)
libdrm.so.2()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
libpthread.so.0()(64bit)
libpthread.so.0(GLIBC_2.2.5)(64bit)
librt.so.1()(64bit)
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rtld(GNU_HASH)
rpmlib(PayloadIsXz) = 5.2-1
cogl-debuginfo-1.7.0-1.fc16.x86_64.rpm
cogl-debuginfo = 1.7.0-1.fc16
cogl-debuginfo(x86-64) = 1.7.0-1.fc16
=
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadIsXz) = 5.2-1
cogl-devel-1.7.0-1.fc16.x86_64.rpm
pkgconfig(cogl-1.0) = 1.7.0
pkgconfig(cogl-2.0-experimental) = 2.0.0
pkgconfig(cogl-gl-1.0) = 1.7.0
pkgconfig(cogl-pango-1.0) = 1.7.0
pkgconfig(cogl-pango-2.0-experimental) = 1.7.0
cogl-devel = 1.7.0-1.fc16
cogl-devel(x86-64) = 1.7.0-1.fc16
=
/usr/bin/pkg-config
cogl = 1.7.0-1.fc16
fontconfig-devel
glib2-devel
gobject-introspection-devel
libcogl-pango.so.0()(64bit)
libcogl.so.0()(64bit)
mesa-libGL-devel
pango-devel
pkgconfig
pkgconfig(cogl-1.0)
pkgconfig(gl)
pkgconfig(glib-2.0)
pkgconfig(libdrm)
pkgconfig(pangocairo) = 1.20
pkgconfig(x11)
pkgconfig(xcomposite) = 0.4
pkgconfig(xdamage)
pkgconfig(xext)
[Bug 713690] New: Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module https://bugzilla.redhat.com/show_bug.cgi?id=713690 Summary: Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mfoj...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec SRPM URL: rubygem-rbvmomi-1.2.3-1.fc14.src.rpm Description: Rightscale::HttpConnection is a robust HTTP(S) library. It implements a retry algorithm for low-level network errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #1 from Michal Fojtik mfoj...@redhat.com 2011-06-16 05:14:32 EDT --- (In reply to comment #0) Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec SRPM URL: rubygem-rbvmomi-1.2.3-1.fc14.src.rpm Description: Rightscale::HttpConnection is a robust HTTP(S) library. It implements a retry algorithm for low-level network errors. Sorry, URL for SRPM is: http://mifo.sk/tmp/packages/rubygem-rbvmomi-1.2.3-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689961] Review Request: lego-udevrules - Provide access to LEGO robots and controller boards
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689961 Elad Alfassa el...@doom.co.il changed: What|Removed |Added CC||el...@doom.co.il --- Comment #2 from Elad Alfassa el...@doom.co.il 2011-06-16 05:13:32 EDT --- (In reply to comment #1) I don't see any blocking issues here, so were I a package maintainer, I would declare this package APPROVED. Well, you are wrong. the package MUST contain a license file (unless it's public domain). It also must have a build section. Also, The user creation in %pre is not according to the guidelines, see https://fedoraproject.org/wiki/Packaging:UsersAndGroups Furthermore, it seems you get the sources directly from that git repository. why? Upstream doesn't release tarballs? if so, the version tag should be according to these guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Peter Robinson pbrobin...@gmail.com 2011-06-16 05:19:44 EDT --- Issues: 1. Wrong FSF address in copying, cogl.x86_64: E: incorrect-fsf-address /usr/share/doc/cogl-1.7.0/COPYING, please report upstream (and submit a patch to fix it). I've already reported this upstream to the author. As the COPYING file is included they will update it in GIT and we'll get the fix in a new release. 2. Why is the package named cogl but the description (of doc) says clutter? Looks like you copied some parts from clutter's spec file and forgot to change some parts. Fixed (I maintain clutter as well and this has been split out of clutter). http://pbrobinson.fedorapeople.org/cogl-1.7.0-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #2 from Michal Fojtik mfoj...@redhat.com 2011-06-16 05:22:13 EDT --- Revision 2: - Added Provides and Obsoletes - Fixed changelog Spec URL: http://mifo.sk/tmp/packages/rubygem-http_connection.spec SRPM URL: http://mifo.sk/tmp/packages/rubygem-rbvmomi-1.2.3-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #3 from Michal Fojtik mfoj...@redhat.com 2011-06-16 05:23:43 EDT --- Sorry for the link chaos, is still morning for me ;-) http://mifo.sk/tmp/packages/rubygem-http_connection-1.4.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 --- Comment #3 from Elad Alfassa el...@doom.co.il 2011-06-16 05:33:51 EDT --- the -devel summary is still Summary: Clutter development environment Is it right? Also, please update the spec and not just the srpm next time, to make it easier on reviewers. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713701] New: Review Request: tamil-typing-booster - Tamil typing booster table for ibus indic table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: tamil-typing-booster - Tamil typing booster table for ibus indic table https://bugzilla.redhat.com/show_bug.cgi?id=713701 Summary: Review Request: tamil-typing-booster - Tamil typing booster table for ibus indic table Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: psatp...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://pravins.fedorapeople.org/tamil-typing-booster.spec SRPM URL: http://pravins.fedorapeople.org/tamil-typing-booster-0.0.1-1.fc15.src.rpm Description: Tamil typing booster table for ibus indic table scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3134391 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713126] Review Request: harfbuzz - Text shaping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713126 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Kalev Lember ka...@smartlink.ee 2011-06-16 05:52:18 EDT --- New Package SCM Request === Package Name: harfbuzz Short Description: Text shaping library Owners: kalev mclasen Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693425] Review Request: openerp - OpenERP business application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693425 --- Comment #57 from Panos Christeas x...@hellug.gr 2011-06-16 05:51:52 EDT --- Note, I have published a new set of specs/SRPMS/lints at: http://members.hellug.gr/xrg/Redhat/openerp-official/SPECS/openerp-client.spec http://members.hellug.gr/xrg/Redhat/openerp-official/SPECS/openerp-server.spec http://members.hellug.gr/xrg/Redhat/openerp-official/SRPMS/openerp-client-6.0.2-6.fc14.src.rpm http://members.hellug.gr/xrg/Redhat/openerp-official/SRPMS/openerp-server-6.0.2-6.fc14.src.rpm and http://members.hellug.gr/xrg/Redhat/openerp-official/lints/ ... Getting closer... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713126] Review Request: harfbuzz - Text shaping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713126 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Kalev Lember ka...@smartlink.ee 2011-06-16 05:50:36 EDT --- (In reply to comment #2) I think hb-view is probably better off in the -devel package ? Isn't that mostly a debug/demo thing ? I don't think it is interesting for most people who just install the library because pango is (going to) depend on it. Good idea, I'll move it to -devel when importing the new package. Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 --- Comment #4 from Peter Robinson pbrobin...@gmail.com 2011-06-16 05:56:18 EDT --- (In reply to comment #3) the -devel summary is still Summary: Clutter development environment Is it right? Fixed. Also, please update the spec and not just the srpm next time, to make it easier on reviewers. I do update the spec every time but as its not versioned like the NVR of the srpm the URL doesn't change. If your not seeing the updates its because your browser is cacheing the file. SRPM: http://pbrobinson.fedorapeople.org/cogl-1.7.0-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 Elad Alfassa el...@doom.co.il changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Elad Alfassa el...@doom.co.il 2011-06-16 06:02:13 EDT --- OK, APPROVED. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Peter Robinson pbrobin...@gmail.com 2011-06-16 06:22:58 EDT --- Thanks! New Package GIT Request === Package Name: cogl Short Description: A library for using 3D graphics hardware to draw pretty pictures Owners: pbrobinson Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713690
VÃt Ondruch vondr...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||vondr...@redhat.com
Flag||fedora-review+
--- Comment #4 from VÃt Ondruch vondr...@redhat.com 2011-06-16 06:29:31 EDT
---
I am taking this for review.
According the guidelines for package renaming [1], your provides and obsoletes
have to contain correct versions:
Provides: rubygem(%{gemname}) = %{version}
Provides: rubygem-right_http_connection = %{version}
Obsoletes: rubygem-right_http_connection 1.4.1-1
Also comment that this provides should be removed according to the guidelines
would have sense. And don't forget to retire the old package.
Otherwise, the package looks good = APPROVED
[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713581] Review Request: sar2 - An open source helicopter simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713581 Elad Alfassa el...@doom.co.il changed: What|Removed |Added CC||el...@doom.co.il AssignedTo|nob...@fedoraproject.org|el...@doom.co.il Flag||fedora-review? --- Comment #1 from Elad Alfassa el...@doom.co.il 2011-06-16 07:31:36 EDT --- I'll do the review. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713677] Review Request: klt - An implementation of the Kanade-Lucas-Tomasi feature tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713677 --- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2011-06-16 07:41:58 EDT --- I've removed the debuginfo package and commented on the spec. All srpms and specs are updated :) http://ankursinha.fedorapeople.org/klt/klt.spec http://ankursinha.fedorapeople.org/klt/klt-1.3.4-1.fc15.src.rpm Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713581] Review Request: sar2 - An open source helicopter simulator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713581
Elad Alfassa el...@doom.co.il changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Elad Alfassa el...@doom.co.il 2011-06-16 07:55:27 EDT ---
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistent macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
f91efe02165f371bd2ba8cb452a29677 sar2-2.3.0.tar.bz2
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
+ Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
+ Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
+ No rpmlint output.
+ final provides and requires are sane:
[elad@elephant result]$ for i in sar*rpm; do echo $i; rpm -qp --provides $i;
echo =; rpm -qp --requires $i; echo; done
sar2-2.3.0-1.fc16.src.rpm
=
scons
desktop-file-utils
libX11-devel
libSM-devel
libXi-devel
libXmu-devel
SDL-devel
SDL_image-devel
openal-soft-devel
freealut-devel
mesa-libGLU-devel
mesa-libGL-devel
libICE-devel
libXpm-devel
libvorbis-devel
libXext-devel
rpmlib(FileDigests) = 4.6.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
sar2-2.3.0-1.fc16.x86_64.rpm
sar2 = 2.3.0-1.fc16
sar2(x86-64) = 2.3.0-1.fc16
=
libGL.so.1()(64bit)
libGLU.so.1()(64bit)
libICE.so.6()(64bit)
libSDL-1.2.so.0()(64bit)
libSM.so.6()(64bit)
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXmu.so.6()(64bit)
libXpm.so.4()(64bit)
libalut.so.0()(64bit)
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.7)(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libopenal.so.1()(64bit)
libpthread.so.0()(64bit)
libpthread.so.0(GLIBC_2.2.5)(64bit)
libstdc++.so.6()(64bit)
libvorbisfile.so.3()(64bit)
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rtld(GNU_HASH)
rpmlib(PayloadIsXz) = 5.2-1
sar2-debuginfo-2.3.0-1.fc16.x86_64.rpm
sar2-debuginfo = 2.3.0-1.fc16
sar2-debuginfo(x86-64) = 2.3.0-1.fc16
=
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadIsXz) = 5.2-1
SHOULD Items:
+ Should build in mock.
- Should build on all supported archs
+ Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
All good, APPROVED
--
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713122] Review Request: flyback - Aplle's Timemachine for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713122 --- Comment #4 from Heiko Adams info-2...@fedora-blog.de 2011-06-16 08:02:33 EDT --- Update: Spec URL: https://dl.dropbox.com/s/zjkybrv5vywsgod/flyback.spec?dl=1 SRPM URL: https://dl.dropbox.com/s/sabesc4eb8aafay/flyback-0.6.5-2.fc15.src.rpm?dl=1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713126] Review Request: harfbuzz - Text shaping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713126 --- Comment #6 from Jon Ciesla l...@jcomserv.net 2011-06-16 08:19:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713584] Review Request: cogl - A library for using 3D graphics hardware to draw pretty pictures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713584 --- Comment #7 from Jon Ciesla l...@jcomserv.net 2011-06-16 08:19:45 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713443] Review Request: yelp-tools - Create, manage, and publish documentation for Yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713443 --- Comment #3 from Zeeshan Ali z...@redhat.com 2011-06-16 08:46:00 EDT --- Thanks for the quick review. Just uploaded the new SRPM and SPEC to the same URLs. Let me know if I missed something. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710517] Review Request: gnome-shell-extension-remove-accessibility-icon - A gnome-shell extension for removing the accessibility icon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710517 --- Comment #11 from Robert 'Bob' Jensen b...@fedoraunity.org 2011-06-16 08:57:17 EDT --- yum search returns the following short description gnome-shell-extension-remove-accessibility-icon.noarch : A gnome-shell extensions for removing the accessibility icon extensions should be changed to extension. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] New: Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libgcal - A library to access google calendar events and contacts https://bugzilla.redhat.com/show_bug.cgi?id=713741 Summary: Review Request: libgcal - A library to access google calendar events and contacts Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@marionline.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://marionline.fedorapeople.org/packages/SPECS/libgcal.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/libgcal-0.9.6-3.fc14.src.rpm Description: This is a library to access google calendar events and contacts, its purpose is - provide easy access to available events/contacts - enable common operations: add, delete, edit - have few dependencies (up until now, only requires libcurl and libxml) It implements Google Data API 2.0 and is tested on Linux and MacOSX. I become today the new package mantainer for this software. I need a new review for this spec file bacause it wasn't update in the last 3 month. There was a problem with the spec file in fedora git repository and the spec file in the src rpm for fedora 14. For fedora 15 the package was rebuild. With this new spec I merge the two spec file, delete the line that doesn't respect the fedora guidelines and resolve bug #659959 . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712017] Review Request: libreport - Generic library for reporting various problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712017 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-06-16 09:14:20 EDT --- libreport-2.0.3-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libreport-2.0.3-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Blocks||659959 Flag||fedora-review? --- Comment #1 from Rex Dieter rdie...@math.unl.edu 2011-06-16 09:30:50 EDT --- I can help (re)review this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 --- Comment #2 from Mario Santagiuliana fed...@marionline.it 2011-06-16 09:39:38 EDT --- Hi Rex thank you for your help! :) I forgot to remove the clean section. Like I said I can't support EPEL because I don't have it and I only use Fedora. Thank you! I'm waiting your reply :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713741
--- Comment #3 from Rex Dieter rdie...@math.unl.edu 2011-06-16 09:49:24 EDT
---
confirmed bug #659959 is fixed.
comments:
1. Looks like this one has a similar problem that akonadi-googledata had, :)
%build section is pretty sparse. I'd suggest modifying to something like:
%build
%{cmake} .
make %{?_smp_mflags}
%install
rm -rf %{buildroot}
make install/fast DESTDIR=$RPM_BUILD_ROOT
2. %files has some excessive globs, imo, I'd suggest tracking lib soname at
least, replace
%files
...
%{_libdir}/*.so.*
with
%files
...
%{_libdir}/libgcal.so.0*
3. -devel can drop
Requires: pkgconfig
pkgconfig-related depenendencies are handled automatically by rpm these days.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Michal Fojtik mfoj...@redhat.com 2011-06-16 10:07:46 EDT --- Thanks for an review Vit! I'll fix that before importing this package. New Package CVS Request === Package Name: rubygem-http_connection Short Description: RightScale's robust HTTP/S connection module Owners: mfojtik Branches: F-14 F-15 EL-5 EL-6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 --- Comment #4 from Mario Santagiuliana fed...@marionline.it 2011-06-16 10:11:41 EDT --- 1) Change; 2) Fix 3) If I understand correctly now should be ok 4) I remove the %clear section Could you check it now? I update the spec file: http://marionline.fedorapeople.org/packages/SPECS/libgcal.spec And srpm: http://marionline.fedorapeople.org/packages/SRPMS/ P.S. I will use my email account for fedora in changelog, using my personal email can confuse people, I think. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http-connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #6 from Jon Ciesla l...@jcomserv.net 2011-06-16 10:11:33 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642995] Review Request: rubygem-deltacloud-client - Deltacloud REST Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642995 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-06-16 10:15:36 EDT --- rubygem-deltacloud-client-0.3.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-deltacloud-client-0.3.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713741
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #5 from Rex Dieter rdie...@math.unl.edu 2011-06-16 10:25:57 EDT
---
small cosmetic issue, 2. should be
%{_libdir}/libgcal.so.0*
not just
%{_libdir}/libgcal.so.*
that way we can track the lib soname closer, and be alerted when/if that ever
changes (ie, builds will fail).
I'll trust you to fix that prior to doing any builds...
APPROVED.
go ahead and apply your changes to git, and close this when that's done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 --- Comment #6 from Mario Santagiuliana fed...@marionline.it 2011-06-16 11:26:23 EDT --- Thank you very much, spec file updated and I push in fedora git the new spec file. I'm building the packages and then I'm pushing to bodhi. Then I will close this bug :) Thank you very much! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-06-16 11:31:32 EDT --- libgcal-0.9.6-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libgcal-0.9.6-5.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713741] Review Request: libgcal - A library to access google calendar events and contacts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713741 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-06-16 11:33:40 EDT --- libgcal-0.9.6-5.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libgcal-0.9.6-5.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709328 --- Comment #16 from Ivan Romanov dr...@land.ru 2011-06-16 11:43:16 EDT --- (In reply to comment #11) The rpmlint output is 548 lines long, that's why I've attached it. Some initial issues: The License declaration GPLv2+1 doesn't exist. The file src/main.cpp is GPLv2+. What does the additional 1 mean? This is jusr misspeling. Actually it used GPLv2, LGPLv2 and BeerWare licenses. Where do you've got the skins, icons and themes from? I don't see any licensing info about them. This difficult question. Developers of Psi+ don't care about license cleaning. Sad but true. I trying to find sources of this resources. And moreover, why do you use them as additional sources and split them again into subpackages? In my mind, it would be better to package them separately, because the main package doesn't need them mandatory. Often this resources updates. By this reason I always build one common package. It's more comfortable for me. It's difficult to wathcing for updates resources. You can qt-devel drop from BuildRequires, the qtwebkit-devel depends on it anyway. Old version of Fedora haven't qtwebkit-devel package. While I want to have a compatible with it. psi-plus.desktop isn't properly installed, look here: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Oh damn :(. Sources have a psi.desktop file. When is bening installed this file copying with name psi-plus.desktop in application dir. I don't know what I should do in such case. Is maybe desktop-file-validate can help me? The FSF address is incorrect in the source files. Not worth a patch, but worth a upstream bug report tough. I have talk with Rion (upstream developer). It don't interesting for him. If you would call %configure instead of ./configure, you could drop the four lines which define the macros for install locations. I might use only ./configure. It non-auntoconf ./configure. qconf-qt4 generates non-compatible ./configure script. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709328 --- Comment #17 from Ivan Romanov dr...@land.ru 2011-06-16 11:46:50 EDT --- (In reply to comment #12) Maybe RPMFusion or similiar is a better place for such a package if there are licence issues. Fedora won't accept any package with any non-free content in it. Atm Russian Fedora provide this package. I don't want to use RPMFussion or any other similar Repo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709328 --- Comment #18 from Ivan Romanov dr...@land.ru 2011-06-16 11:52:10 EDT --- (In reply to comment #14) I don't see any reason why someone should use both psi and psi-plus in parallel. In my opinion, psi-plus obsoletes psi. Conflicts don't allowed in Fedora distribution. It's very uncomfortable when one package server as a noise to other. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=709328
--- Comment #19 from Ivan Romanov dr...@land.ru 2011-06-16 11:53:50 EDT ---
(In reply to comment #15)
Could you provide for each source an url where it is from?
snip
Source0:
http://koji.russianfedora.ru/storage/psi-plus/%{name}-%{version}-20110530svn3954.tar.bz2
Source1:iconsets.tar.bz2
Source2:language_ru.tar.bz2
Source3:skins.tar.bz2
Source4:themes.tar.bz2
/snip
It haven't url. I got it all from https://psi-dev.googlecode.com/svn/trunk/.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713443] Review Request: yelp-tools - Create, manage, and publish documentation for Yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713443 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #4 from Matthias Clasen mcla...@redhat.com 2011-06-16 12:02:56 EDT --- Thanks, you've addressed all my points. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712562] Review Request: gnome-shell-theme-deviantart - the deviantart gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712562 --- Comment #3 from Tim Lauridsen t...@rasmil.dk 2011-06-16 12:55:28 EDT --- Created attachment 505102 -- https://bugzilla.redhat.com/attachment.cgi?id=505102 theme preview -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ubuntu-ambiance - the ubuntu-ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #2 from Tim Lauridsen t...@rasmil.dk 2011-06-16 13:14:22 EDT --- Created attachment 505103 -- https://bugzilla.redhat.com/attachment.cgi?id=505103 theme artwork No logo here, so it should be ok ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ubuntu-ambiance - the ubuntu-ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #4 from Tim Lauridsen t...@rasmil.dk 2011-06-16 13:19:35 EDT --- I will rename it from *-ubuntu-ambiance to *-ambiance, it should solve the potential Ubuntu trademark thing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712562] Review Request: gnome-shell-theme-deviantart - the deviantart gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712562 --- Comment #5 from Tom spot Callaway tcall...@redhat.com 2011-06-16 13:17:46 EDT --- It is not clear to me whether this theme includes the background shown in the preview, as that is using the name and the logo. Assuming that this theme is just icons (and color settings), as shown in #2, the preview would need to be redone. I would prefer a naming that wasn't at all related to the deviantart trademark, since there is no affiliation (if there is affiliation, please point me to the documentation). Also, it would be nice to know that these icons are original artwork, not taken from the deviantart website. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ubuntu-ambiance - the ubuntu-ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #3 from Tim Lauridsen t...@rasmil.dk 2011-06-16 13:18:00 EDT --- Created attachment 505105 -- https://bugzilla.redhat.com/attachment.cgi?id=505105 theme preview The theme preview contains big whales, but it don't look like something trademarked. But they can be replace with screendump done on a fedora F15 default wallpaper if needed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712567] Review Request: gnome-shell-theme-ubuntu-ambiance - the ubuntu-ambiance gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712567 --- Comment #5 from Tom spot Callaway tcall...@redhat.com 2011-06-16 13:20:33 EDT --- Rename it and redo the preview, and we should be fine. I was going to suggest purple-people-eater, but ambience is also acceptable. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712562] Review Request: gnome-shell-theme-deviantart - the deviantart gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712562 --- Comment #2 from Tim Lauridsen t...@rasmil.dk 2011-06-16 12:52:45 EDT --- Created attachment 505101 -- https://bugzilla.redhat.com/attachment.cgi?id=505101 Theme art work -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713443] Review Request: yelp-tools - Create, manage, and publish documentation for Yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713443 --- Comment #6 from Jon Ciesla l...@jcomserv.net 2011-06-16 12:53:02 EDT --- Git done (by process-git-requests). No need to request f16 branch, f16==devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713443] Review Request: yelp-tools - Create, manage, and publish documentation for Yelp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713443 Zeeshan Ali z...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Zeeshan Ali z...@redhat.com 2011-06-16 12:46:55 EDT --- New Package SCM Request === Package Name: yelp-tools Short Description: Create, manage, and publish documentation for Yelp Owners: zeenix Branches: f16 InitialCC: mclasen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712562] Review Request: gnome-shell-theme-deviantart - the deviantart gnome-shell theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712562 --- Comment #4 from Tim Lauridsen t...@rasmil.dk 2011-06-16 12:58:59 EDT --- The is not logos in the theme artwork (See #2) But there is in the the preview screen dump (#3) but i can replace that with one with out any logos. I can rename the package to gnome-shell-theme-da would that solve the legal issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713126] Review Request: harfbuzz - Text shaping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713126 Kalev Lember ka...@smartlink.ee changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||harfbuzz-0.6.0-2.fc16 Resolution||NEXTRELEASE Last Closed||2011-06-16 14:07:27 --- Comment #7 from Kalev Lember ka...@smartlink.ee 2011-06-16 14:07:27 EDT --- Package imported and built; closing the ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705426] Review Request: blender25 - 3D modeling, animation, rendering and post-production
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705426 --- Comment #5 from Jochen Schmitt joc...@herr-schmitt.de 2011-06-16 14:03:32 EDT --- I'm maeding point a. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619355] Review Request: python26-numpy - A fast multidimensional array facility for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619355 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 --- Comment #11 from minoo ziaei mzi...@redhat.com 2011-06-16 14:21:46 EDT --- (In reply to comment #10) /usr/share/eclipse/dropins/mylyn/eclipse/features/org.eclipse.mylyn_feature_3.5.1.v20110422-0200/ epl-v10.html feature.properties feature.xml license.html p2.inf Files were added. Just one question about license.html. There is an existing license file in upstream. You can find it here: http://mziaei1.fedorapeople.org/LICENSE Is this file enough for the %doc in .spec file or should I add the usual license.html (which you mentioned in the feature) to the plugin feature and the .spec file as well? Thanks, Here are the update files: Spec URL: http://mziaei1.fedorapeople.org/eclipse-mercurial/eclipse-mercurial.spec SRPM URL: http://mziaei1.fedorapeople.org/eclipse-mercurial/eclipse-mercurial-1.8.1-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619355] Review Request: python26-numpy - A fast multidimensional array facility for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619355 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2011-06-16 14:21:51 EDT --- python26-numpy-1.5.1-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python26-numpy-1.5.1-5.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |rubygem-http-connection - |rubygem-http_connection - |RightScale's robust HTTP/S |RightScale's robust HTTP/S |connection module |connection module -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-06-16 14:35:19 EDT --- rubygem-http_connection-1.4.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-06-16 14:42:29 EDT --- rubygem-http_connection-1.4.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713690] Review Request: rubygem-http_connection - RightScale's robust HTTP/S connection module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713690 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-06-16 14:59:37 EDT --- rubygem-http_connection-1.4.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-http_connection-1.4.1-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713920] New: Review Request: csparse - Sparse Matrix software library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: csparse - Sparse Matrix software library https://bugzilla.redhat.com/show_bug.cgi?id=713920 Summary: Review Request: csparse - Sparse Matrix software library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tcall...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://www.auroralinux.org/people/spot/review/new/csparse.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/csparse-3.0.1-1.fc15.src.rpm Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3135401. Description: CSparse is a small yet feature-rich sparse matrix package written specifically for the book Direct Methods for Sparse Linear Systems. The purpose of the package is to demonstrate a wide range of sparse matrix algorithms in as concise a code as possible. *** Packager's Note: This is a dependency for naev, also pending review. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] New: Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: heybuddy - identi.ca and status.net client https://bugzilla.redhat.com/show_bug.cgi?id=713923 Summary: Review Request: heybuddy - identi.ca and status.net client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: info-2...@fedora-blog.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: https://dl.dropbox.com/s/oqch96tll8f22j8/heybuddy.spec?dl=1 SRPM URL: https://dl.dropbox.com/s/iob12rnmgokd0an/heybuddy-0.2.2bzr-1.20110616.fc15.src.rpm?dl=1 Description: heybuddy is supposed to be a light/feature free client for the identi.ca microblogging site. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713925] Review Request: naev - 2D space trading and combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713925 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Depends on||713920 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713920] Review Request: csparse - Sparse Matrix software library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713920 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks||713925 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 --- Comment #12 from Andrew Overholt overh...@redhat.com 2011-06-16 15:18:28 EDT --- Sorry, Minoo, I shouldn't have suggested you ship a copy of the EPL in your feature. Referencing the LICENSE as it's included in the plugin is the correct thing to do. You can get rid of this line: %doc com.vectrace.mercurialeclipse-feature/epl-v10.html and drop that file from your feature. It also might be a good idea to add a version to the tarball of your feature. Something like com.vectrace.mercurialeclipse-feature-0.0.1.tar.bz2 might be good (make the version equal what's in your feature.xml). Otherwise, we're good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713925] New: Review Request: naev - 2D space trading and combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: naev - 2D space trading and combat game https://bugzilla.redhat.com/show_bug.cgi?id=713925 Summary: Review Request: naev - 2D space trading and combat game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tcall...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://www.auroralinux.org/people/spot/review/new/naev.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/naev-0.5.0-1.fc15.src.rpm Description: Naev is a 2D space trading and combat game. Naev is played from a top-down perspective, featuring fast-paced combat, many ships, a large variety of equipment and a large galaxy to explore. The game is highly open-ended, letting you proceed at your own pace. ** Packager note: This package depends on csparse (bz 713920) ** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 --- Comment #13 from minoo ziaei mzi...@redhat.com 2011-06-16 16:08:16 EDT --- (In reply to comment #12) It also might be a good idea to add a version to the tarball of your feature. Something like com.vectrace.mercurialeclipse-feature-0.0.1.tar.bz2 might be good (make the version equal what's in your feature.xml). Removed the EPL. I've changed the feature version to the same of the upstream version(1.8.1), is that fine? Thanks, Update files: Spec URL: http://mziaei1.fedorapeople.org/eclipse-mercurial/eclipse-mercurial.spec SRPM URL: http://mziaei1.fedorapeople.org/eclipse-mercurial/eclipse-mercurial-1.8.1-5.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #14 from Andrew Overholt overh...@redhat.com 2011-06-16 16:44:55 EDT --- Yes, 1.8.1 is fine. APPROVED You can request the git repo now. I'll sponsor you ... I forget exactly what needs to happen now in this situation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712203] Review Request: eclipse-mercurial - Mercurial plugin for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712203 --- Comment #15 from minoo ziaei mzi...@redhat.com 2011-06-16 17:13:46 EDT --- New Package SCM Request === Package Name: eclipse-mercurial Short Description: Eclipse Interaction with Mercurial Repositories Owners: mziaei1 overholt Branches: f15 InitialCC: overholt jerboaa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713923 Veeti Paananen veeti.paana...@rojekti.fi changed: What|Removed |Added CC||veeti.paana...@rojekti.fi --- Comment #1 from Veeti Paananen veeti.paana...@rojekti.fi 2011-06-16 17:29:11 EDT --- I'm still looking to get sponsored myself, but I have 2 comments. 1) You need to add the following in order to use desktop-file-install: BuildRequires: desktop-file-utils The build fails in mock because of this. 2) I'm not sure about the language package subpackages either: I don't think that they should be in subpackages, but you should ask someone more knowledgeable. As for the language files, see this: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713923 --- Comment #2 from Veeti Paananen veeti.paana...@rojekti.fi 2011-06-16 17:30:24 EDT --- Oh, and are you sure that the package summary Git based backup software is correct? :p -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713923 --- Comment #3 from Heiko Adams info-2...@fedora-blog.de 2011-06-16 17:51:44 EDT --- Okay, I've added desktop-file-utils to BuildRequires and fixed the summary. CopyPaste Specfiles is evil ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713923 Julian Aloofi julian.fed...@googlemail.com changed: What|Removed |Added CC||julian.fed...@googlemail.co ||m --- Comment #4 from Julian Aloofi julian.fed...@googlemail.com 2011-06-16 18:03:38 EDT --- Heiko, I'm willing to take this, we need a nice pino replacement in the repos ;) Are you already a packager? If yes, what's your FAS account name? :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713963] New: Review Request: rpkg - Utility for interacting with rpm+git packaging systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rpkg - Utility for interacting with rpm+git packaging systems https://bugzilla.redhat.com/show_bug.cgi?id=713963 Summary: Review Request: rpkg - Utility for interacting with rpm+git packaging systems Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jkeat...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://jkeating.fedorapeople.org/review/rpkg.spec SRPM URL: http://jkeating.fedorapeople.org/review/rpkg-1.0-1.f14.src.rpm Description: A tool for managing RPM package sources in a git repository -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705585] Review Request: fflas-ffpack - Finite field linear algebra subroutines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705585 --- Comment #7 from Jerry James loganje...@gmail.com 2011-06-16 18:21:21 EDT --- Thomas, what else do I need to do to move this forward? Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620112] Review Request: udpxy - UDP-to-HTTP multicast traffic relay daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620112 --- Comment #14 from Ivan Afonichev ivan.afonic...@gmail.com 2011-06-16 18:24:46 EDT --- Spec URL: https://github.com/vanaf/udpxy-fedora/blob/e30a09b88cfe3582f0416ed90a71a9a49ef630af/udpxy.spec SRPM URL: http://baldr.sgu.ru/rpm/udpxy-1.0.19-2.fc15.src.rpm - init script reverted for compatibility - options moved to sysconfdir - systemd type now 'forking' I think it's better for options to stay at /etc/sysconfig then in .service file Build with patch(1.0.19-3) is not yet published, it will be published shortly after patch will be submitted to upstream -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713923 --- Comment #5 from Heiko Adams info-2...@fedora-blog.de 2011-06-16 18:36:33 EDT --- I'm not yet a packager. I'm just a noob knocking on the door -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620112] Review Request: udpxy - UDP-to-HTTP multicast traffic relay daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620112 --- Comment #15 from Ivan Afonichev ivan.afonic...@gmail.com 2011-06-16 18:38:05 EDT --- Spec URL: https://github.com/vanaf/udpxy-fedora/blob/fc54a06c2ee2ca79260880f2d62b8503b9ec25a0/udpxy.spec SRPM URL: http://baldr.sgu.ru/rpm/udpxy-1.0.19-3.fc15.src.rpm Content-type header addition patch added. https://sourceforge.net/tracker/?func=detailaid=3317594group_id=214718atid=1030796 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713923] Review Request: heybuddy - identi.ca and status.net client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713923 --- Comment #6 from Heiko Adams info-2...@fedora-blog.de 2011-06-16 18:58:29 EDT --- Updated spec-file and srpm: Spec URL: https://dl.dropbox.com/s/oqch96tll8f22j8/heybuddy.spec?dl=1 SRPM URL: https://dl.dropbox.com/s/dx4de4f28ufy5v6/heybuddy-0.2.2bzr-2.20110616.fc15.src.rpm?dl=1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 620112] Review Request: udpxy - UDP-to-HTTP multicast traffic relay daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620112 --- Comment #16 from nucleo alekc...@googlemail.com 2011-06-16 19:19:10 EDT --- SysV initscripts are now considered obsolete for Fedora 15+ https://fedoraproject.org/wiki/PackagingGuidelines#Systemd So I would prefer to not add init script. Using /etc/sysconfig is also obsolete. All options should be set now in unit file. https://fedoraproject.org/wiki/Packaging:Systemd#Support_for_.2Fetc.2Fsysconfig_files It is should be clear what status of patch in upstream is it accepted or rejected, so I will wait for udpxy author reply http://sourceforge.net/tracker/?func=detailaid=3317594group_id=214718atid=1030796 Contacting author directly by sending e-mail (see README file) also may clarify is your patch will be accepted. Your udpxy.service with Type=forking actually not working: udpxy.service - UDP-to-HTTP multicast traffic relay daemon Loaded: loaded (/lib/systemd/system/udpxy.service) Active: inactive (dead) since Fri, 17 Jun 2011 01:44:05 +0300; 1s ago Process: 2403 ExecStart=/usr/bin/udpxy $OPTIONS (code=exited, status=0/SUCCESS) Main PID: 2404 (code=exited, status=0/SUCCESS) Service also dead with Type=forking if replace $OPTIONS with -S -p 4022: udpxy.service - UDP-to-HTTP multicast traffic relay daemon Loaded: loaded (/lib/systemd/system/udpxy.service) Active: inactive (dead) since Fri, 17 Jun 2011 02:00:00 +0300; 6s ago Process: 2760 ExecStart=/usr/bin/udpxy -S -p 4022 (code=exited, status=0/SUCCESS) Main PID: 2761 (code=exited, status=0/SUCCESS) CGroup: name=systemd:/system/udpxy.service But service runs well with Type=singe and do not run as daemon option. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713984] New: Review Request: python-fastimport - Python parser for fastimport (VCS interchange format)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-fastimport - Python parser for fastimport (VCS interchange format) https://bugzilla.redhat.com/show_bug.cgi?id=713984 Summary: Review Request: python-fastimport - Python parser for fastimport (VCS interchange format) Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dcall...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: --- Spec URL: http://fedorapeople.org/~dcallagh/python-fastimport/python-fastimport.spec SRPM URL: http://repos.fedorapeople.org/repos/dcallagh/bzr-fastimport/fedora-15/SRPMS/python-fastimport-0.9.0-1.fc15.src.rpm Description: This is the Python parser that was originally developed for bzr-fastimport, but extracted so it can be used by other projects. This library is a dependency for the very useful bzr fastimport plugin, which makes interoperability between bzr and git (and other VCS tools) possible. I will be filing a review request for bzr-fastimport too. Build log from mock is here: http://fedorapeople.org/~dcallagh/python-fastimport/build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713984] Review Request: python-fastimport - Python parser for fastimport (VCS interchange format)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713984 Dan Callaghan dcall...@redhat.com changed: What|Removed |Added Depends on||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713984] Review Request: python-fastimport - Python parser for fastimport (VCS interchange format)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713984 Dan Callaghan dcall...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on|177841(FE-NEEDSPONSOR) | --- Comment #1 from Dan Callaghan dcall...@redhat.com 2011-06-16 20:32:12 EDT --- Oops, I think I got the FE-NEEDSPONSOR dependency around the wrong way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713990] Review Request: bzr-fastimport - Bzr plugin for fast loading of data from other VCS tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713990 Dan Callaghan dcall...@redhat.com changed: What|Removed |Added Depends on||713984 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
