[Bug 688183] Review Request: iceplayer - A simple music player for Linux

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688183

--- Comment #15 from Mike Ma zht...@gmail.com 2011-07-02 02:32:21 EDT ---
Hi, Elder.

Thanks for your comments.

My computer can't connect to Internet now, so I can't edit the spec file.
(sorry. but I'll modify it later.)

Well, this software is in Chinese, and doesn't have i18n now.
If that is a problem, can I close the Review Request? (I think FedoraPeople is
enough.)

Thank you.

PS, NEWS and THANKS are empty files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 668794] Review Request: pgsphere -Spherical data types, functions, and operators for PostgreSQL

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668794

--- Comment #7 from Sergio Pascual sergio.pa...@gmail.com 2011-07-02 03:23:41 
EDT ---
I have removed buildroot, %clean and %defattr

sparse.c and .h have an exception in its license 

As a special exception, you may create a larger work that contains
   part or all of the Bison parser skeleton and distribute that work
   under terms of your choice, so long as that work isn't itself a
   parser generator using the skeleton or a modified version thereof
   as a parser skeleton.  Alternatively, if you modify or redistribute
   the parser skeleton itself, you may (at your option) remove this
   special exception, which will cause the skeleton and the resulting
   Bison output files to be licensed under the GNU General Public
   License without this special exception.

So I think these files are also under the license of the main package.

(Very good catch anyway)

New files:

http://guaix.fis.ucm.es/~spr/pgsphere.spec
http://guaix.fis.ucm.es/~spr/pgsphere-1.1.1-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693200] Review Request: php-bartlett-PHP-Reflect - Adds the ability to reverse-engineer PHP

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693200

--- Comment #4 from Remi Collet fed...@famillecollet.com 2011-07-02 03:34:45 
EDT ---
Update to 1.0.0, stable version (with documentation)
https://github.com/remicollet/remirepo/commit/d6a546173038e145481a3e1433b049f66da004ea

SRPM:
http://rpms.famillecollet.com/SRPMS/php-bartlett-PHP-Reflect-1.0.0-1.remi.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693664] Review Request: supybot-gribble - Cross-platform support bot based on supybot

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693664

--- Comment #27 from Fedora Update System upda...@fedoraproject.org 
2011-07-02 04:23:04 EDT ---
supybot-gribble-0.83.4.1-6.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/supybot-gribble-0.83.4.1-6.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 713320] Review Request: oz - Library and utilities for automated guest OS installs

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713320

--- Comment #12 from Pádraig Brady p...@draigbrady.com 2011-07-02 05:28:55 
EDT ---
Updated srpm for review:

Spec URL: http://www.pixelbeat.org/patches/oz.spec
SRPM URL: http://www.pixelbeat.org/patches/oz-0.5.0-1.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #14 from Fabian Affolter fab...@bernewireless.net 2011-07-02 
05:38:32 EDT ---
Thanks Roy. 

For me it doesn't work on Fedora 15 with the latest svn checkout...
./configure: line 4450: `$as_echo $as_me: WARNING: Libtool does not cope well
with whitespace in \`pwd\` 2;} ;;'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715180] Review Request: freemat - A free environment for rapid engineering, scientific prototyping and data processing

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2011-07-02 05:39:24 
EDT ---
(In reply to comment #1)
 One file is licensed as GPLv3+. Please ask upstream and also inform them of 
 the
 wrong address, though that is not a blocker.

Emailed upstream. What file is this please? I can't find it. :/

 
 FreeMat is available under the GPL license. -- That part of the description
 is useless.

dropped.

 
 Drop all the -vs. rpmbuild shows everything by default. Add -f to your last
 rm.

mock will show the command, but not verbose execution of rm.

 
 The description text sounds a lot like in this example:
 http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description
 

removed concerned portion

 Please do as rpmlint says and correct the line ends with something like:
 
 http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding
 
 rpmlint -I can help, if you don't understand what an error is about.
 

corrected. 

 Also mend that:
 
 freemat.i686: W: devel-file-in-non-devel-package
 /usr/share/FreeMat-4.1/toolbox/test/addArrays.c

It's a test file for users that the package installs. I think we can let it be. 

 
 Either define a Buildroot tag, if you want to put this package to EPEL 5, or
 drop: rm -rf $RPM_BUILD_ROOT

dropped

 
 The defattr line is unneeded.

dropped

 
 Can you probably generate the current documentation?

I've tried, but been unable to. I've informed upstream of this. Whenever they
generate the new doc, I'll push a new build.

 
 Really delete the bundled libs. Currently there is a pound sign in front of 
 it.

deleted

 
 CMake informs about:
 
 -- Could NOT find Boost

It isn't causing the build to fail, so I guess it's okay. I will clarify with
upstream though.

 Compiler optimization may lead to broken Lapack build. 
 If release build produces incorrect results (e.g. svd(rand(4)) is all NaN) 
 you should to disable optimization when compiling dlamch.c and slamch.c
 
 Did you make sure that's fine?

I'm using the fedora lapack package so this is irrelevant IMO. 

rpmlint output:
[ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
freemat.i686: W: devel-file-in-non-devel-package
/usr/share/FreeMat-4.1/toolbox/test/addArrays.c
freemat.i686: E: incorrect-fsf-address
/usr/share/FreeMat-4.1/toolbox/general/license.m
freemat.i686: E: incorrect-fsf-address /usr/share/doc/freemat-20110620/COPYING
freemat.i686: W: no-manual-page-for-binary FreeMat
freemat.src: W: invalid-url Source0: freemat.tar.gz
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/HandleList.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/DebugStream.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/src/main.cpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/src/application.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/SymbolTable.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libGraphics/HandleFigure.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/src/FuncTerminal.cpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libXP/HistoryWidget.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/src/Terminal.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/Token.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libGraphics/RenderEngine.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/Exception.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libXP/DataTable.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/NTuple.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/src/DumbTerminal.cpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/Array.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/Stream.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libXP/QTTerm.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libFreeMat/FunctionDef.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/libs/libXP/StackTool.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/freemat/FreeMat/src/FuncMode.hpp
freemat-debuginfo.i686: E: incorrect-fsf-address

[Bug 715180] Review Request: freemat - A free environment for rapid engineering, scientific prototyping and data processing

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #3 from Volker Fröhlich volke...@gmx.at 2011-07-02 06:15:52 EDT 
---
$ licensecheck -R *|grep v3

freemat/FreeMat/tools/vtkwrap/vtkParse.tab.c: GPL (v3 or later)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 715180] Review Request: freemat - A free environment for rapid engineering, scientific prototyping and data processing

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #4 from Volker Fröhlich volke...@gmx.at 2011-07-02 06:19:12 EDT 
---
But you can forget about it: https://bugzilla.redhat.com/show_bug.cgi?id=668794

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 715180] Review Request: freemat - A free environment for rapid engineering, scientific prototyping and data processing

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #5 from Ankur Sinha sanjay.an...@gmail.com 2011-07-02 06:43:21 
EDT ---
http://ankursinha.fedorapeople.org/freemat/freemat-20110620-0.2svn4185.fc15.src.rpm

http://ankursinha.fedorapeople.org/freemat/freemat.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715503] Review Request: elmer-meshgen2d - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715503

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Blocks||715620(elmer-fem)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715496] Review Request: elmer-matc - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715496

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Blocks||715620(elmer-fem)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715498] Review Request: elmer-hutiter - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715498

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Blocks||715620(elmer-fem)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715314] Review Request: metis - A set of serial programs for partitioning graphs, partitioning finite element meshes, and producing fill reducing orderings for sparse matrices

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715314

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Blocks|715620(elmer-fem)   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715619] Review Request: elmer-elmergrid - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715619

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Blocks||715620(elmer-fem)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715618] Review Request: elmer-eio - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715618

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Blocks||715620(elmer-fem)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716344] Review Request: elmer - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716344

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||CANTFIX
Last Closed||2011-07-02 06:49:33

--- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2011-07-02 06:49:33 
EDT ---
Okay. I'll do that. 

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715620] Review Request: elmer-fem - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715620

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 Depends on|715314(metis)   |715619(elmer-elmergrid),
   ||715618(elmer-eio),
   ||715503(elmer-meshgen2d),
   ||715498(elmer-hutiter),
   ||715496(elmer-matc)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693204] Review Request: php-bartlett-PHP-CompatInfo - Find out version and the extensions required for a piece of code to run

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693204

--- Comment #2 from Remi Collet fed...@famillecollet.com 2011-07-02 07:29:00 
EDT ---
Update to 2.0.0 finale
https://github.com/remicollet/remirepo/commit/701ddd926a582d1e58122ebc0895a79b9ccd5e37

SRPM :
http://rpms.famillecollet.com/SRPMS/php-bartlett-PHP-CompatInfo-2.0.0-1.remi.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #15 from Jon Burgess jburgess...@googlemail.com 2011-07-02 
08:58:35 EDT ---
The configure error above seems to be triggered by this change in
osm2pgsql-configure.patch:

 dnl Make sure we have libtool installed
-AM_PROG_LIBTOOL
+m4_pattern_allow(AM_PROG_LIBTOOL)

I guess this was done to workaround libtool not being available? Adding it as a
build requirement sounds like the correct thing to do instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

Tim Lauridsen t...@rasmil.dk changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #5 from Tim Lauridsen t...@rasmil.dk 2011-07-02 09:31:18 EDT ---
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 682544] Review request: gargoyle - multi-format interactive fiction interpreter

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682544

--- Comment #12 from Carlo Teubner ct.spamma...@gmail.com 2011-07-02 09:38:32 
EDT ---
Thanks Tom. I've emailed Andrew Plotkin, asking him to consider changing the
license to standard open source license anyway. I've changed the License tag in
the spec file to Glulxe as per your recommendation at
http://lists.fedoraproject.org/pipermail/legal/2011-June/001684.html;
unsurprisingly I now get

gargoyle.x86_64: W: invalid-license Glulxe

I've changed the permissions of generate-tarball.sh to 0755 and rpmlint is
still complaining:

gargoyle.src: W: strange-permission generate-tarball.sh 0755L

Regarding the incorrect-fsf-address issue, I've filed
http://code.google.com/p/garglk/issues/detail?id=153 with Gargoyle.

As for the bundling issue, I'm fairly certain that nothing can be done about
this upstream, but I'm reaching out to the maintainer for a comment on this.

I've also repackaged this for Fedora 15.

To see my (minimal) changes to the spec file:

https://github.com/c4rlo/gargoyle-fedora/commit/9135af177e218b0e6b3909ab13a1db5cc6977c81
https://github.com/c4rlo/gargoyle-fedora/commit/603e8c05238a497cbb06457dab1856279a1f9a6f

Latest files:

http://carlolab.appspot.com/files/gargoyle.spec
http://carlolab.appspot.com/files/gargoyle-2010.1-4.fc15.src.rpm
http://carlolab.appspot.com/files/gargoyle-2010.1-4.fc15.x86_64.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711547

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com

--- Comment #12 from Richard Shaw hobbes1...@gmail.com 2011-07-02 10:09:19 
EDT ---
I can't sponsor you but I can suggest some fixes to your spec.

You still need to update your License tag per comment 5.

You don't need BuildRoot unless you're planning on building for EPEL = 5

You don't need %clean unless you're planning on building for EPEL, in fact
leaving it in without the accompanying rm -rf %{buildroot} is worse.

You don't need rm -rf %{buildroot} in %install unless you're planning to
build for EPEL = 5.

I assume that since you're manually installing the binary that this package
lacks a make install target?

All of your %doc items can be listed space separated on one line.

You need to add one empty line between your changelog entries, e.g.:

%changelog
* Mon Jun 26 2011 Ryan H. Lewis m...@ryanlewis.net 1.0-3
- Added ChangeLog

* Mon Jun 9 2011 Ryan H. Lewis m...@ryanlewis.net 1.0-2
- Fixes https://bugzilla.redhat.com/show_bug.cgi?id=711547#c5

* Mon Jun 7 2011 Ryan H. Lewis m...@ryanlewis.net 1.0-1
- Created initial spec file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714408

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ke...@scrye.com
   Flag||fedora-review?

--- Comment #2 from Kevin Fenzi ke...@scrye.com 2011-07-02 10:11:29 EDT ---
I'd be happy to review this package and look at sponsoring you. ;) 

Look for a full review hopefully later today.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716777] Review Request: perl-Crypt-RC4 - Perl implementation of the RC4 encryption algorithm

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716777

Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||emmanuel.seyman@club-intern
   ||et.fr
 AssignedTo|nob...@fedoraproject.org|emmanuel.seyman@club-intern
   ||et.fr
   Flag||fedora-review?

--- Comment #1 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 
2011-07-02 11:02:17 EDT ---
Taking.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715620] Review Request: elmer-fem - Open Source Finite Element Software for Multiphysical Problems

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715620

--- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2011-07-02 11:09:15 
EDT ---
Dropped. I've rebuilt it without metis. I've mailed upstream to clarify some of
the rpmlint errors (rpath and file placement etc.).

Should have a new srpm soon. Upstream is incredibly responsive :)

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 668794] Review Request: pgsphere -Spherical data types, functions, and operators for PostgreSQL

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668794

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #8 from Jon Ciesla l...@jcomserv.net 2011-07-02 11:26:01 EDT ---
Ok, everything looks good now, thanks.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716777] Review Request: perl-Crypt-RC4 - Perl implementation of the RC4 encryption algorithm

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716777

Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 
2011-07-02 11:30:50 EDT ---
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3175738

 [x] Rpmlint output:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default is used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
4ca59a7e58ac9597c3b4f3f46ea22629  Crypt-RC4-2.02.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3175738
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
No tests included with module. :-(

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #3 from Kevin Fenzi ke...@scrye.com 2011-07-02 11:56:39 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (OFL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
72b228695f1ad8ac0e3824a1e7edb313  league-gothic.zip
72b228695f1ad8ac0e3824a1e7edb313  ../SOURCES/league-gothic.zip
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Not a blocker, but you might add to the description. Reading just what you
have
makes it sound like this is a public domain font from 1903, but in fact the
second
paragraph upstream says: We decided to make our own version, and contribute 
it to the Open Source Type Movement. It’s free, not only in price, but in
freedom
So, perhaps a note that this is a version of that font? 

2. Might ask upstream if they could include a copy of the OFL in their zip
file?
(Not a blocker, but nice to have). 

3. rpmlint says: 

tlomt-league-gothic-fonts.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Which can be ignored. 

Fix up the description and I think we are good to go...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714231

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|ke...@scrye.com
   Flag||fedora-review?

--- Comment #1 from Kevin Fenzi ke...@scrye.com 2011-07-02 12:05:03 EDT ---
I'd be happy to review this. Look for a full review in a bit here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 718415] New: Review Request: sushi - A quick previewer for the Nautilus

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sushi - A quick previewer for the Nautilus

https://bugzilla.redhat.com/show_bug.cgi?id=718415

   Summary: Review Request: sushi - A quick previewer for the
Nautilus
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: el...@doom.co.il
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://elad.fedorapeople.org/reviews/sushi.spec
SRPM URL: http://elad.fedorapeople.org/reviews/sushi-0.0.3-1.fc16.src.rpm
Description: This is sushi, a quick previewer for the Nautilus, the GNOME
desktop file manager.
It is part of gnome 3.2 file previewing feature,
https://live.gnome.org/ThreePointOne/Features/FilePreviewing

rpmlint output:
[elad@elephant result]$ rpmlint *rpm
sushi.x86_64: W: no-manual-page-for-binary sushi
sushi-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701079

--- Comment #9 from Mario Blättermann mari...@freenet.de 2011-07-02 12:28:19 
EDT ---
Many thanks for your review!

(In reply to comment #8)
 Package looks good. Please do inform upstream about the incorrect FSF address
 when you can. 

As I already wrote, upstream is dead. But there is a software pool for
Windowmaker dockapps at http://www.dockapps.org. I will leave a comment there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714231

--- Comment #2 from Kevin Fenzi ke...@scrye.com 2011-07-02 12:29:42 EDT ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
a436f07cd3be24ae99ff33b748c6c664  SemanticMediaWiki1.5.6.tgz
a436f07cd3be24ae99ff33b748c6c664  ../SOURCES/SemanticMediaWiki1.5.6.tgz

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. (It's
MIT). 
Also, there's only one file that says GPLv2 or later. So, I would say the
License here
should be: GPL+ and GPLv2+ and MIT 

2. rpmlint says: 
mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff
- spin off, spin-off, Spinoza
mediawiki116-semantic.noarch: E: incorrect-fsf-address
/usr/share/doc/mediawiki116-semantic-1.5.6/COPYING
mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff -
spin off, spin-off, Spinoza

You might mail them about updating COPYING, others can be ignored. 

So, I think once the License is cleared up we are good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701079

Mario Blättermann mari...@freenet.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #10 from Mario Blättermann mari...@freenet.de 2011-07-02 12:31:51 
EDT ---
New Package SCM Request
===
Package Name: wmSun
Short Description: Rise/Set time of Sun in a dockapp
Owners: mariobl
Branches: f15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 693200] Review Request: php-bartlett-PHP-Reflect - Adds the ability to reverse-engineer PHP

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693200

--- Comment #5 from Remi Collet fed...@famillecollet.com 2011-07-02 12:52:34 
EDT ---
For now, only userguide.html is generated.

I'm working with upstream to see if we can fixe the index.txt to generate the
full documentation (current version requires asciidoc = 8.6.5, fedora only
have very old 8.4.5)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716756] Review Request: perl-HTML-FormatText-WithLinks - HTML to text conversion with links as footnotes

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716756

Mario Blättermann mari...@freenet.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Mario Blättermann mari...@freenet.de 2011-07-02 12:48:45 
EDT ---
-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
264a1436883d20b81e669c65a1f97367  HTML-FormatText-WithLinks-0.14.tar.gz
264a1436883d20b81e669c65a1f97367 
HTML-FormatText-WithLinks-0.14.tar.gz.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permisseable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it. Don't know how to test it on my
system.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.



PACKAGE APPROVED



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701079

--- Comment #11 from Jon Ciesla l...@jcomserv.net 2011-07-02 12:53:59 EDT ---
Git done (by process-git-requests).

Ankur, in the future, please assign reviews you are working on to yourself. 
Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717681] Review Request: python26-argparse - Optparse inspired command line parser for Python

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717681

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
13:27:24 EDT ---
Package python26-argparse-1.2.1-3.el5, packagedb-cli-1.0.0-6.el5:
* should fix your issue,
* was pushed to the Fedora EPEL 5 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing python26-argparse-1.2.1-3.el5
packagedb-cli-1.0.0-6.el5'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/python26-argparse-1.2.1-3.el5,packagedb-cli-1.0.0-6.el5
then log in and leave karma (feedback).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708690] Review Request: apicaro-0.1.050511 - API, for icaro, robotics software

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708690

Guillermo Gómez guillermo.go...@gmail.com changed:

   What|Removed |Added

 CC||guillermo.go...@gmail.com

--- Comment #2 from Guillermo Gómez guillermo.go...@gmail.com 2011-07-02 
13:36:18 EDT ---
If you need sponsor please adjust accordingly:
http://rpmdev.proyectofedora.org/projects/rpmfed/wiki/C%C3%B3mo_crear_solicitud_de_revisi%C3%B3n_bugzilla
(spanish doc)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701079

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|sanjay.an...@gmail.com

--- Comment #12 from Ankur Sinha sanjay.an...@gmail.com 2011-07-02 13:40:52 
EDT ---
(In reply to comment #11)
 Git done (by process-git-requests).
 
 Ankur, in the future, please assign reviews you are working on to yourself. 
 Thank you!

OH!! I somehow forgot. Won't happen again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712560] Review Request: gnome-shell-extension-theme-selector - extension for review change gnome-shell themes

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712560

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
15:24:51 EDT ---
gnome-shell-extension-theme-selector-0.9-3.fc15 has been pushed to the Fedora
15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712565] Review Request: gnome-shell-theme-smooth-inset - the smooth-inset gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712565

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
15:24:20 EDT ---
gnome-shell-theme-smooth-inset-1.0-1.fc15 has been pushed to the Fedora 15
stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712565] Review Request: gnome-shell-theme-smooth-inset - the smooth-inset gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712565

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gnome-shell-theme-smooth-in
   ||set-1.0-1.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:24:25

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712560] Review Request: gnome-shell-extension-theme-selector - extension for review change gnome-shell themes

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712560

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gnome-shell-extension-theme
   ||-selector-0.9-3.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:24:57

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712563] Review Request: gnome-shell-theme-gaia - the gaia gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712563

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
15:24:08 EDT ---
gnome-shell-theme-gaia-1.0-1.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 705585] Review Request: fflas-ffpack - Finite field linear algebra subroutines

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705585

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2011-07-02 15:25:49 EDT ---
fflas-ffpack-1.4.1-2.fc15 has been pushed to the Fedora 15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712564] Review Request: gnome-shell-theme-orta - the orta gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712564

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
15:25:23 EDT ---
gnome-shell-theme-orta-1.0-1.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712561

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
15:23:53 EDT ---
gnome-shell-theme-atolm-1.0-1.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712564] Review Request: gnome-shell-theme-orta - the orta gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712564

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gnome-shell-theme-orta-1.0-
   ||1.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:25:28

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712561] Review Request: gnome-shell-theme-atolm - the atolm gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712561

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gnome-shell-theme-atolm-1.0
   ||-1.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:23:59

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712690] Review Request: gnome-shell-theme-dark-glass - Dark Glass gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712690

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gnome-shell-theme-dark-glas
   ||s-1.0-1.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:26:10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712563] Review Request: gnome-shell-theme-gaia - the gaia gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712563

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gnome-shell-theme-gaia-1.0-
   ||1.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:24:12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 712690] Review Request: gnome-shell-theme-dark-glass - Dark Glass gnome-shell theme

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712690

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-07-02 
15:26:04 EDT ---
gnome-shell-theme-dark-glass-1.0-1.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617340] Review Request: throttle - copy stdin to stdout at the specified speed (or lower)

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617340

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #24 from Fedora Update System upda...@fedoraproject.org 
2011-07-02 15:27:04 EDT ---
throttle-1.2-4.fc15 has been pushed to the Fedora 15 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 705585] Review Request: fflas-ffpack - Finite field linear algebra subroutines

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705585

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||fflas-ffpack-1.4.1-2.fc15
 Resolution||ERRATA
Last Closed||2011-07-02 15:25:56

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701079

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701079

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2011-07-02 15:41:53 EDT ---
wmSun-1.03-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/wmSun-1.03-4.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 668794] Review Request: pgsphere -Spherical data types, functions, and operators for PostgreSQL

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668794

Sergio Pascual sergio.pa...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #9 from Sergio Pascual sergio.pa...@gmail.com 2011-07-02 16:46:14 
EDT ---
New Package SCM Request
===
Package Name: pgsphere
Short Description: Spherical data types, functions and operators for PostgreSQL
Owners: sergiopr
Branches: F-15 F-14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 718430] New: Review Request: unknown-horizons : FE-NEEDSPONSOR - a 2D RTS game written in python which uses the fife engine

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: unknown-horizons : FE-NEEDSPONSOR - a 2D RTS game 
written in python which uses the fife engine

https://bugzilla.redhat.com/show_bug.cgi?id=718430

   Summary: Review Request: unknown-horizons : FE-NEEDSPONSOR - a
2D RTS game written in python which uses the fife
engine
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: nmo.marq...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL:
http://nmarques.fedorapeople.org/packages/unknown-horizons/unknown-horizons.spec
SRPM URL:
http://nmarques.fedorapeople.org/packages/unknown-horizons/unknown-horizons-2011.2-df776e7.fc15.src.rpm

Description: Unknown Horizons is a 2D real-time strategy simulation with an
emphasis on economy and city building. Expand your small settlement to a strong
and wealthy colony, collect taxes and supply your inhabitants with valuable
goods. Increase your power with a well balanced economy and with strategic
trade and diplomacy.



Hi all,

I've been packaging this for openSUSE since the last release and also made it
available for Fedora using the openSUSE Build Service. Some people in Unknown
Horizons forum[1] have requested if I could submit for Fedora, so I'm
submitting this package according to the best I could with the available
information for review. So far upstream as been kind and helpful and we have a
good relation.

I have some doubts about the Licence fields, and I would request that someone
could please verify the Licensing (and any other issue). I'm available to
maintain this package in the future and keep it updated, though I don't plans
for further enrollment with Fedora besides this package.

Feedback will be most welcomed (srpm is finishing uploading). As this is my
first package I assume I need a sponsor (FE-NEEDSPONSOR).

NM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 668794] Review Request: pgsphere -Spherical data types, functions, and operators for PostgreSQL

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668794

--- Comment #10 from Jon Ciesla l...@jcomserv.net 2011-07-02 17:01:38 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #4 from Khusro Jaleel kernelj...@kerneljack.com 2011-07-02 
18:44:14 EDT ---
Thanks, Kevin. I have updated the description field now and uploaded a new
.src.rpm with an incremented Release tag of 2. You will find it below:

SRPM: http://kerneljack.com/rpms/tlomt-league-gothic-fonts-1.0-2.fc15.src.rpm
SPEC: http://kerneljack.com/rpms/tlomt-league-gothic-fonts.spec
Koji scratch build against Rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=3176288

Please let me know if this is ok, thanks again for the help. I'm going to
package up another font soon!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715119] Review Request: gnome-encfs - Makes using encfs easier

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715119

Elder Marco elderma...@gmail.com changed:

   What|Removed |Added

 CC||elderma...@gmail.com

--- Comment #3 from Elder Marco elderma...@gmail.com 2011-07-02 20:17:32 EDT 
---
Hi, just a few comments,

* The License field must be GPLv3+ (see the source file provided by upstream)

* Currently, the correct version is 0.1. (See the source file provided by
upstream)

* Add each dependency on a single line:
Requires: python
Requires: gnome-python2-gnomekeyring
Requires: fuse-encfs

It's more readable.

* %setup -q -n gnome-encfs
This line could be:
%setup -q -n %{name}

* %{__install} -m 755 gnome-encfs
%{buildroot}%{_datadir}/%{name}/gnome-encfs.py
And This line could be:
%{__install} -m 755 %{name} %{buildroot}%{_datadir}/%{name}/%{name}.py

But,

* You don't need the file gnome-encfs (Source1). Just install gnome-encfs (from
tarball) in %{buildroot}%{_bindir}

rpmlint:
$ rpmlint
/var/lib/mock/fedora-15-x86_64/result/gnome-encfs-23hg-1.20110621.fc15.* 
gnome-encfs.noarch: W: spelling-error %description -l en_US keyring - keying,
key ring, key-ring
gnome-encfs.noarch: W: spelling-error %description -l en_US login - loin,
logic, lo gin
gnome-encfs.noarch: W: spelling-error %description -l en_US autostart - auto
start, auto-start, autos tart
gnome-encfs.noarch: W: no-manual-page-for-binary gnome-encfs
gnome-encfs.src: W: spelling-error %description -l en_US keyring - keying, key
ring, key-ring
gnome-encfs.src: W: spelling-error %description -l en_US login - loin, logic,
lo gin
gnome-encfs.src: W: spelling-error %description -l en_US autostart - auto
start, auto-start, autos tart
gnome-encfs.src: W: invalid-url Source0: gnome-encfs.tar.gz
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 471805] Review Request: aespipe - AES-based encryption tool for tar/cpio and loop-aes images

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471805

--- Comment #43 from Fedora Update System upda...@fedoraproject.org 
2011-07-02 20:33:53 EDT ---
aespipe-2.4c-0.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/aespipe-2.4c-0.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715127] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715127

--- Comment #6 from Olivier Samyn c...@oleastre.be 2011-07-02 20:43:23 EDT ---
New version at:
http://www.oleastre.be/fedora/abcMIDI/4/abcMIDI.spec
http://www.oleastre.be/fedora/abcMIDI/4/abcMIDI-20110610-4.fc15.src.rpm

I simplified the make calls, and I bumped the package version up to 4.
I added, in the changelog, package versions 2 and 3 to reflect the changes made
on the 28th of June.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711547

--- Comment #13 from Ryan H. Lewis (rhl) m...@ryanlewis.net 2011-07-02 
21:54:02 EDT ---
all fixed, not sure why the licence tag ended up 'unfixed' again, but I did fix
that once...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711547

Ryan H. Lewis (rhl) m...@ryanlewis.net changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 702103] Review Request: python-osmgpsmap - Python bindings for osm-gps-map GTK+ widget

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702103

--- Comment #8 from Jeffrey C. Ollie j...@ocjtech.us 2011-07-02 23:42:22 EDT 
---
Spec URL: http://jcollie.fedorapeople.org/python-osmgpsmap.spec
SRPM URL: http://jcollie.fedorapeople.org/python-osmgpsmap-0.7.3-3.fc15.src.rpm

* Sat Jul  2 2011 Jeffrey C. Ollie j...@ocjtech.us - 0.7.3-3
- Filter private shared library provides
- use setup rather than setup0
- drop defattr
- Drop buildroot
- Drop clean section
- Use name of library rather than wildcard
- Add COPYING file to doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716756] Review Request: perl-HTML-FormatText-WithLinks - HTML to text conversion with links as footnotes

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716756

Ruediger Landmann r.landm...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Ruediger Landmann r.landm...@redhat.com 2011-07-03 
01:26:29 EDT ---
Many thanks for the review Mario!

New Package SCM Request
===
Package Name: perl-HTML-FormatText-WithLinks
Short Description: HTML to text conversion with links as footnotes
Owners: rlandmann
Branches: f14 f15 el6
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 700346] Review Request: perl-Barcode-Code128 - Generate CODE 128 bar codes

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700346

--- Comment #13 from Iain Arnell iarn...@gmail.com 2011-07-03 01:33:42 EDT ---
Sorry for the delay. I've only just noticed that you're in the account system
now. You should be able to continue now and import and build your packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716615] Review Request: php-zipstream - zipstream-php

2011-07-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716615

Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

 CC||fed...@famillecollet.com
 AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com
   Flag||fedora-review+

--- Comment #1 from Remi Collet fed...@famillecollet.com 2011-07-03 01:53:41 
EDT ---
=== FORMAL REVIEW ===
 -=N/A  x=Check  !=Problem,  ?=Not evaluated

=== REQUIRED ITEMS ===
 [x] Rpmlint output:
ok
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the PHP specific items
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type: MIT
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [ ] Sources used to build the package matches the upstream source, as provided
in the spec URL.
 md5sum : ef9de52d725c642f13e27a6c975d0774  zipstream-php-0.2.2.tar.gz
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: f15 (noarch)
 [-] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [-] Packages don't bundle copies of system librarie
 [-] Package is not relocatable.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages with %{?_isa}, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] All filenames in rpm packages must be valid UTF-8
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Final requires
php-common = 5.1.2
 [x] Final provides
php-zipstream = 0.2.2-1.fc15
 [x] Latest version is packaged.
 [-] If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it. 
 [-] The description and summary sections in the package spec file should
contain
 translations for supported Non-English languages, if available.
 [-] Reviewer should test that the package builds in mock.
 Tested on: Koji 
 http://koji.fedoraproject.org/koji/taskinfo?taskID=3176670
 [-] The package should compile and build into binary rpms on all supported
architectures.
 Tested on: 
 [x] Package functions as described.
 [-] If scriptlets are used, those scriptlets must be sane. 
 [ ] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin 
 consider requiring the package which provides the file instead of the file
itself. 
 [-] your package should contain man pages for binaries/scripts. 
 If it doesn't, work with upstream to add them where they make sense.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] %check is present and the tests pass


$ phpci print --report=extension /usr/share/php/zipstream/zipstream.php
---
PHP COMPAT INFO EXTENSION SUMMARY
---
  EXTENSIONPECL   VERSION COUNT
---
  Core4.0.0  16
  date4.0.0   2
  hash   1.0  5.1.2   4
  pcre