[Bug 720254] Review Request: perl-Unicode-Casing - Perl extension to override system case changing functions

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720254

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Unicode-Casing-0.07-1.
   ||fc16
 Resolution||RAWHIDE
Last Closed||2011-07-13 03:22:19

--- Comment #4 from Petr Pisar  2011-07-13 03:22:19 EDT ---
Thank you for the review and the repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720901] New: Review Request: eclipse-avr - Eclipse AVR plugin

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: eclipse-avr - Eclipse AVR plugin

https://bugzilla.redhat.com/show_bug.cgi?id=720901

   Summary: Review Request: eclipse-avr - Eclipse AVR plugin
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: vladimir.kostadi...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://dev.technogamma.biz/eclipse-avr/SPECS/eclipse-avr.spec
SRPM URL:
http://dev.technogamma.biz/eclipse-avr/SRPMS/eclipse-avr-2.3.4-1.fc15.src.rpm
Description: The Eclipse AVR plugin enables you to develop, build, debug and
program AVR devices.
Includes AVR Toolchain and AVRDude (InSystem Programmer).

That's my first package, so I'm looking for a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=252108

--- Comment #43 from Rahul Sundaram  2011-07-13 04:09:57 
EDT ---

Do a scratch build via koji or a mock build locally.  Run rpmlint on the spec
file,  srpm and binary rpm.  In particular the changelog should be something
along the lines of

* Tue Jul 12 2011 Oded Arbel  - 0.90-2

Dist tag shouldn't be explicitly specified in the changelog.   Meanwhile  I
have filed a request to sponsor you

https://fedorahosted.org/fesco/ticket/643

I recommend you create a profile page in the Fedora wiki and drop a note in the
ticket with your Fedora account system name.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720901] Review Request: eclipse-avr - Eclipse AVR plugin

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720901

Vladimir Kostadinov  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720664] Review Request: django-threaded-multihost - Enable multi-site awareness in Django apps

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720664

Rahul Sundaram  changed:

   What|Removed |Added

 CC||methe...@gmail.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #6 from Rahul Sundaram  2011-07-13 04:14:06 EDT 
---
Package Change Request
==
Package Name: django-threaded-multihost
New Branches: el6
Owners: sundaram pjp
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720435] Review Request: epson-inkjet-printer-escpr - Drivers for Epson inkjet printers

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720435

Michal Nowak  changed:

   What|Removed |Added

 CC||mno...@redhat.com

--- Comment #1 from Michal Nowak  2011-07-13 04:26:08 EDT ---
(In reply to comment #0)

> epson-inkjet-printer-escpr.src:73: E: hardcoded-library-path in
> /usr/lib/cups/filter/epson-*

Not good. Look here (https://fedoraproject.org/wiki/Packaging/RPMMacros) for
info how to create a valid path via RPM macros.

> epson-inkjet-printer-escpr.src: W: invalid-url Source0:
> epson-inkjet-printer-escpr-1.0.4-1lsb3.2.tar.gz

Place correct URI here, e.g.: http://.../source.tar.gz

> epson-inkjet-printer-escpr.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib/cups/filter/epson-escpr ['/usr/lib64']

Look into packaging guidelines for other tips on how to remove RPATH.

> epson-inkjet-printer-escpr-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/epson-inkjet-printer-escpr-1.0.4/lib/escpr_sp.h

I suggest you work with upstream to change the address -- but I guess it's
acceptable for Fedora as it is now.

I doubt the version & release fields are OK. I suggest you change the version
to "1.0.4-1lsb3.2" and release to "1".

> %defattr(-,root,root)

A bit old-style, I suggest to use %defattr(-,root,root, -).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=239933

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #7 from Petr Pisar  2011-07-13 04:50:20 EDT ---
Package Change Request
==
Package Name: perl-Danga-Socket
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 245655] Review Request: perl-Gearman - Distributed job system

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=245655

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #10 from Petr Pisar  2011-07-13 04:52:34 EDT ---
Package Change Request
==
Package Name: perl-Gearman
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688499] Review Request: cabal-dev - Haskell package sandboxing tool

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688499

--- Comment #3 from Jens Petersen  2011-07-13 04:52:30 EDT 
---
I'd like to ask bos if he is still using this package.
I have only tried lightly a few times but I am not fully convinced yet
if this is really the optimal approach to avoiding cabal breakage.
It may be more useful for developers than packagers though say.
So there may well be a legitimate use-case for it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 246356] Review Request: perl-Gearman-Client-Async - Asynchronous Client for the Gearman distributed job system

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=246356

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #12 from Petr Pisar  2011-07-13 04:53:15 EDT ---
Package Change Request
==
Package Name: perl-Gearman-Client-Async
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 240699] Review Request: perl-MogileFS-Client - Client library for the MogileFS distributed file system

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=240699

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #13 from Petr Pisar  2011-07-13 04:55:21 EDT ---
Package Change Request
==
Package Name: perl-MogileFS-Client
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 245697] Review Request: perl-Gearman-Server - Function call "router" and load balancer

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=245697

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #7 from Petr Pisar  2011-07-13 04:54:28 EDT ---
Package Change Request
==
Package Name: perl-Gearman-Server
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 539693] Review Request: plowshare - command-line downloader/uploader for some of the most popular file-sharing websites

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539693

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|ERRATA  |
   Flag|fedora-cvs+ |fedora-cvs?
   Keywords||Reopened

--- Comment #43 from Pavel Alexeev (aka Pahan-Hubbitus)  
2011-07-13 04:55:48 EDT ---
Please new branch F-15.

Package change SCM Request
===
Package Name: plowshare
Short Description: command-line downloader/uploader for some of the most
popular file-sharing websites
Owners: hubbitus,eldermarco
Branches: F-15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 245419] Review Request: perl-MogileFS-Utils - Utilities for MogileFS

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=245419

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #5 from Petr Pisar  2011-07-13 04:56:46 EDT ---
Package Change Request
==
Package Name: perl-MogileFS-Utils
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 239369] Review Request: perl-Sys-Syscall - Access system calls that Perl doesn't normally provide access to

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=239369

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #7 from Petr Pisar  2011-07-13 04:58:59 EDT ---
Package Change Request
==
Package Name: perl-Sys-Syscall
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 252104] Review Request: perl-Perlbal-XS-HTTPHeaders - Perlbal extension for processing HTTP headers

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=252104

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #9 from Petr Pisar  2011-07-13 04:58:03 EDT ---
Package Change Request
==
Package Name: perl-Perlbal-XS-HTTPHeaders
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 252257] Review Request: perl-mogilefs-server - Server part of the MogileFS distributed filesystem

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=252257

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #27 from Petr Pisar  2011-07-13 05:06:07 EDT ---
Package Change Request
==
Package Name: perl-mogilefs-server
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 608574] Review Request: tinymce - Web based Javascript HTML WYSIWYG editor control

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608574

He Rui  changed:

   What|Removed |Added

   Flag||needinfo?(ngomp...@gmail.co
   ||m)

--- Comment #12 from He Rui  2011-07-13 05:22:26 EDT ---
Really appreciated for the hard work of Tim and Neal! For next step, Neal,
basically can you please:

1. set the bug flag:

fedora-cvs -> ?

2. add a comment:

New Package SCM Request
===
Package Name: 
Short Description: 
Owners: 
Branches: 
InitialCC: 


The detailed guidance can be found at:
http://fedoraproject.org/wiki/Package_SCM_admin_requests 

Correct me if I got anything wrong. Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 456009] Review Request: python-jinja2 - General purpose template engine

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456009

--- Comment #12 from Thomas Moschny  2011-07-13 05:58:55 
EDT ---
???

- python-jinja2  is part of RHEL6
- it would have been nice to ask me beforehand as I'm already maintaining it in
EPEL5.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720435] Review Request: epson-inkjet-printer-escpr - Drivers for Epson inkjet printers

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720435

--- Comment #2 from Jussi Lehtola  2011-07-13 06:27:18 
EDT ---
(In reply to comment #1)
> (In reply to comment #0)
> > epson-inkjet-printer-escpr.src:73: E: hardcoded-library-path in
> > /usr/lib/cups/filter/epson-*
> 
> Not good. Look here (https://fedoraproject.org/wiki/Packaging/RPMMacros) for
> info how to create a valid path via RPM macros.

It's hardcoded, since the filters are architecture independent and are placed
in /usr/lib even on 64-bit systems. Otherwise I would have of course used
%{_libdir}.

> > epson-inkjet-printer-escpr.src: W: invalid-url Source0:
> > epson-inkjet-printer-escpr-1.0.4-1lsb3.2.tar.gz
> 
> Place correct URI here, e.g.: http://.../source.tar.gz

If you read the note, upstream doesn't release source tarballs.

I have now switched to using the source rpm as the source, which is a bit more
messy than with the extracted tarball.

> > epson-inkjet-printer-escpr-debuginfo.x86_64: E: incorrect-fsf-address
> > /usr/src/debug/epson-inkjet-printer-escpr-1.0.4/lib/escpr_sp.h
> 
> I suggest you work with upstream to change the address -- but I guess it's
> acceptable for Fedora as it is now.
> 
> I doubt the version & release fields are OK. I suggest you change the version
> to "1.0.4-1lsb3.2" and release to "1".

Please note
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release

> > %defattr(-,root,root)
> 
> A bit old-style, I suggest to use %defattr(-,root,root, -).

These are equivalent, but I have changed the style.

rpmlint is now at (omitting the fsf-address errors)
epson-inkjet-printer-escpr.src:2: E: hardcoded-library-path in
/usr/lib/cups/filter
epson-inkjet-printer-escpr-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 21 errors, 1 warnings.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/epson-inkjet-printer-escpr.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/epson-inkjet-printer-escpr-1.0.4-2.1lsb3.2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719108

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719108

--- Comment #4 from Fedora Update System  2011-07-13 
06:31:14 EDT ---
drupal6-mobile_tools-2.3-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/drupal6-mobile_tools-2.3-2.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 456009] Review Request: python-jinja2 - General purpose template engine

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456009

--- Comment #13 from Rahul Sundaram  2011-07-13 06:40:55 
EDT ---
I must have overlooked that.  I will get the branch removed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719108

--- Comment #5 from Fedora Update System  2011-07-13 
06:43:07 EDT ---
drupal6-mobile_tools-2.3-2.el5 has been submitted as an update for Fedora EPEL
5.
https://admin.fedoraproject.org/updates/drupal6-mobile_tools-2.3-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

Jan F. Chadima  changed:

   What|Removed |Added

 CC||jchad...@redhat.com
 AssignedTo|nob...@fedoraproject.org|jchad...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699697

--- Comment #9 from Fedora Update System  2011-07-13 
07:15:49 EDT ---
drupal6-diff-2.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/drupal6-diff-2.1-2.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699697

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

--- Comment #2 from Jan F. Chadima  2011-07-13 07:17:22 
EDT ---
Created attachment 512635
  --> https://bugzilla.redhat.com/attachment.cgi?id=512635
source rpm rpmlint output

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

--- Comment #1 from Jan F. Chadima  2011-07-13 07:16:15 
EDT ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
OK: Warnings are the missing documentation and non stripped binaries.
rpmlint outputs are attached.

MUST: The package must be named according to the Package Naming Guidelines.
OK: The package name is according all naming guidelines.

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The spec file name match the requested name.

MUST: The package must meet the Packaging Guidelines.
? OK: The package mostly fits all guidelines there are some exceptions found by
the rpmlint.  

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
FAIL: The license is inconsistent, mentions GPLv2, which is incompatible with.
It is basically a non-commercial-only license.

MUST: The License field in the package spec file must match the actual license.
FAIL: The GPLv2 is mentioned in the spec file, the above licence is in the
package.

I reccomend to work with le...@lists.fedoraproject.org to solve the licensing
problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

--- Comment #3 from Jan F. Chadima  2011-07-13 07:18:08 
EDT ---
Created attachment 512636
  --> https://bugzilla.redhat.com/attachment.cgi?id=512636
binary rpms rpmlint output

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699697

--- Comment #10 from Fedora Update System  
2011-07-13 07:34:38 EDT ---
drupal6-diff-2.1-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/drupal6-diff-2.1-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693118

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719338] Review Request: kruler - A screen ruler and color measurement tool

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719338

Jaroslav Reznik  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jrez...@redhat.com
 AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 716469] Review Request: rubygem-rhc - Openshift Express Client Tools

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716469

Guillermo Gómez  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|CURRENTRELEASE  |
   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 719341] Review Request: ksnapshot - A screen capture utility

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719341

Jaroslav Reznik  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jrez...@redhat.com
 AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720901] Review Request: eclipse-avr - Eclipse AVR plugin

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720901

Alexander Kurtakov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||akurt...@redhat.com
 AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Alexander Kurtakov  2011-07-13 
07:58:16 EDT ---
I would do this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693118

--- Comment #7 from Fedora Update System  2011-07-13 
07:59:50 EDT ---
drupal6-admin_menu-1.8-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/drupal6-admin_menu-1.8-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=239933

--- Comment #8 from Jason Tibbitts  2011-07-13 08:07:14 EDT 
---
The requested branches already exist.  Just what are you requesting here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693118

--- Comment #8 from Fedora Update System  2011-07-13 
08:07:08 EDT ---
drupal6-admin_menu-1.8-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/drupal6-admin_menu-1.8-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 239933] Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=239933

Petr Sabata  changed:

   What|Removed |Added

 CC||psab...@redhat.com

--- Comment #9 from Petr Sabata  2011-07-13 08:11:49 EDT ---
(In reply to comment #8)
> The requested branches already exist.  Just what are you requesting here?

Petr requested the addition of perl-sig to the CC list in those branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719338] Review Request: kruler - A screen ruler and color measurement tool

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719338

Jaroslav Reznik  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #1 from Jaroslav Reznik  2011-07-13 08:33:30 
EDT ---
Name: ok
Summary: ok
License: ok
URL: ok
Sources: ok (md5sum 41a3a37063db03a99da96fb7f37a9916)
BRs: ok
Conflicts: ok

I expect these two lines are just garbage (ctrl+c/ctrl+v from kolourpaint spec)

## unpackaged files
rm -fv %{buildroot}%{_kde4_libdir}/libkolourpaint_lgpl.so

Macros usage consistent: ok
Desktop file validation: ok
Icons cache update: ok
Docs: ok but same as other kgraphics packages - no license file

Please remove the two garbage lines in SPEC before import...

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719341] Review Request: ksnapshot - A screen capture utility

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719341

Jaroslav Reznik  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #1 from Jaroslav Reznik  2011-07-13 08:55:04 
EDT ---
Name: ok
Summary and description: ok
License: ok
URL: ok
Sources: ok (md5sum 6b2f29bc823c0238c5d97ce027e37ef8)
BRs: ok
Conflicts: ok
Macros usage consistent: ok
Desktop file validation: ok
Icons cache update: ok

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 675050] Review Request: cloudfs - Cloud Filesystem

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675050

--- Comment #18 from Kaleb KEITHLEY  2011-07-13 08:53:26 
EDT ---
New Spec and SRPM addresses all the issues in C14 above including as much of
the rpmlint noise as is practical. For now I don't propose to fix the remaining
rpmlint 'noise issues'.

Spec URL: http://cloudfs.org/dist/0.7/cloudfs.spec
SRPM URL: http://cloudfs.org/dist/0.7/cloudfs-0.7-3.fc15.src.rpm

successful builds in mock, and koji
https://koji.fedoraproject.org/koji/taskinfo?taskID=3196323 (i386)
https://koji.fedoraproject.org/koji/taskinfo?taskID=3196316 (x86_64)

% rpmlint SPECS/cloudfs.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
% rpmlint SRPMS/cloudfs-0.7-3.fc15.src.rpm 
cloudfs.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
%  rpmlint RPMS/x86_64/cloudfs-0.7-3.fc15.x86_64.rpm 
cloudfs.x86_64: I: enchant-dictionary-not-found en_US
cloudfs.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/glusterfs/3.2.1/xlator/features/libmaprbtree.so
cloudfs.x86_64: W: log-files-without-logrotate /var/log/cloudfs
cloudfs.x86_64: W: no-manual-page-for-binary cfs_stop_volume.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_add_directory.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_add_volume.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_list_vols.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_add_tenant.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_rm_volume.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_mount.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_start_volume.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_delete_tenant.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_add_node.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_enable_tenant.py
cloudfs.x86_64: W: no-manual-page-for-binary cfs_list_tenants.py
cloudfs.x86_64: W: incoherent-subsys /etc/init.d/cloudfsd $prog
1 packages and 0 specfiles checked; 0 errors, 15 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

--- Comment #4 from Jan F. Chadima  2011-07-13 09:03:34 
EDT ---
I apologize for the inaccurate data, the license type is FLOSS, therefore
admissible.
This particular license but is not mentioned in the list of compatible licenses
and should be further explored,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720901] Review Request: eclipse-avr - Eclipse AVR plugin

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720901

--- Comment #2 from Alexander Kurtakov  2011-07-13 
09:06:17 EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
eclipse-avr.noarch: E: description-line-too-long C The Eclipse AVR plugin
enables you to develop, build, debug and program AVR devices.
Please limit to the 80 symbol.

eclipse-avr.noarch: W: invalid-license GPL
Looking at the sources the license should be GPLv3+ . See
http://fedoraproject.org/wiki/Licensing#SoftwareLicenses

eclipse-avr.noarch: W: no-documentation
Please include the license
R2.3.4.20100807/de.innot.avreclipse-feature/licence.html and
R2.3.4.20100807/de.innot.avreclipse-feature/releasenotes.txt

eclipse-avr.noarch: W: hidden-file-or-dir
/usr/share/eclipse/dropins/avr/eclipse/plugins/de.innot.avreclipse.plugin.source_0.0.0/src/de.innot.avreclipse.doc_0.0.0/.project
eclipse-avr.noarch: W: hidden-file-or-dir
/usr/share/eclipse/dropins/avr/eclipse/plugins/de.innot.avreclipse.source_0.0.0/src/de.innot.avreclipse.doc_0.0.0/.project
That's not a problem.
[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[!]  License field in the package spec file matches the actual license.
License type: GPLv3+
[!]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[-]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[-]  Javadoc documentation files are generated and included in -javadoc
subpackage
[-]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[-]  Packages have proper BuildRequires/Requires on jpackage-utils
[-]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[-]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[-]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[-]  pom files has correct add_to_maven_depmap call which resolves to the pom
file (use "JPP." and "JPP-" correctly)

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.


=== Issues ===
1. Fix license tag to GPLv3+.
2. Add license and releasenotes as %doc
3. Fix line lenght.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720989] Review Request: python-setuptools_hg - Setuptools plugin for finding files under Mercurial version control

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720989

Praveen Kumar  changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720989] New: Review Request: python-setuptools_hg - Setuptools plugin for finding files under Mercurial version control

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-setuptools_hg - Setuptools plugin for finding 
files under Mercurial version control

https://bugzilla.redhat.com/show_bug.cgi?id=720989

   Summary: Review Request: python-setuptools_hg - Setuptools
plugin for finding files under Mercurial version
control
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: kumarpraveen.nit...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL:
http://kumarpraveen.fedorapeople.org/setuptools-hg/python-setuptools_hg.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/setuptools-hg/python-setuptools_hg-0.2.1-1.fc15.src.rpm
Description: setuptools_hg is a plugin for setuptools that enables setuptools
to find files under the Mercurial version control system.
It uses the Mercurial Python library by default and falls back to use the
command line program ``hg``. That's especially useful inside virtualenvs
that don't have access to the system wide installed Mercurial lib (e.g. when
created with ``--no-site-packages``).

koji build 
http://koji.fedoraproject.org/koji/taskinfo?taskID=3196523

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720121] Review Request: GoFigure2 - a software for visualizing, processing and analysing of bioimages

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720121

Arnaud Gelas  changed:

   What|Removed |Added

 CC||arnaud_ge...@hms.harvard.ed
   ||u

--- Comment #1 from Arnaud Gelas  2011-07-13 
10:06:24 EDT ---
Ankur,

I am one of the main developer of GoFigure2, we are also working on fixing this
issue with recent cmake version. We plan to make a new release (which will fix
this issue) within the 10 next days or so.

Thanks,
Arnaud

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

Ankur Sinha  changed:

   What|Removed |Added

  Alias||OpenNL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720998] New: Review Request: OpenNL - A library for solving sparse linear systems

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: OpenNL - A library for solving sparse linear systems

https://bugzilla.redhat.com/show_bug.cgi?id=720998

   Summary: Review Request: OpenNL - A library for solving sparse
linear systems
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: sanjay.an...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://ankursinha.fedorapeople.org/opennl/OpenNL.spec
SRPM URL: http://ankursinha.fedorapeople.org/opennl/OpenNL-3.2.1-1.fc15.src.rpm
Description: 
OpenNL (Open Numerical Library) is a library for solving sparse linear systems,
especially designed for the Computer Graphics community. The goal for OpenNL is
to be as small as possible, while offering the subset of functionalities
required by this application field. The Makefiles of OpenNL can generate a
single .c + .h file, very easy to integrate in other projects. The distribution
includes an implementation of our Least Squares Conformal Maps parameterization
method.

New version: OpenNL 3.2.1, includes support for CUDA and Fermi architecture
(Concurrent Number Cruncher and Nathan Bell's ELL formats)


OpenNL offers the following set of functionalities:

Efficient sparse matrix data structure (for non-symmetric and symmetric
matrices)
Iterative builder for sparse linear system
Iterative builder for sparse least-squares problems
Iterative solvers: conjugate gradient, BICGStab, GMRES
Preconditionners: Jacobi, SSOR
Iterative solver on the GPU (Concurrent Number Cruncher and Nathan Bell's
ELL)
Sparse direct solvers: OpenNL can be linked with SuperLU
Simple demo program with LSCM (Least Squares Conformal Maps)


=

[ankur@ankur SRPMS]$ rpmlint  -i /var/lib/mock/fedora-rawhide-i386/result/*.rpm
OpenNL.i686: W: spelling-error %description -l en_US functionalities ->
functionalists, functionality, functionalist
The value of this tag appears to be misspelled. Please double-check.

OpenNL.i686: W: spelling-error %description -l en_US parameterization ->
characterization, computerization, polymerization
The value of this tag appears to be misspelled. Please double-check.

OpenNL.src: W: spelling-error %description -l en_US functionalities ->
functionalists, functionality, functionalist
The value of this tag appears to be misspelled. Please double-check.

OpenNL.src: W: spelling-error %description -l en_US parameterization ->
characterization, computerization, polymerization
The value of this tag appears to be misspelled. Please double-check.

OpenNL-devel.i686: E: zero-length
/usr/share/doc/OpenNL-devel-3.2.1/examples/DATA/example_2.mtx
OpenNL-devel.i686: E: zero-length
/usr/share/doc/OpenNL-devel-3.2.1/examples/DATA/example_1.mtx
4 packages and 0 specfiles checked; 2 errors, 4 warnings.

Empty files are for the examples.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720121] Review Request: GoFigure2 - a software for visualizing, processing and analysing of bioimages

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720121

--- Comment #2 from Ankur Sinha  2011-07-13 10:15:38 
EDT ---
Hi Arnaud,

Thanks!

I'll update the package once the new release is out.

Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 548522] Review Request: autotest-client - Autotest is a framework for fully automated testing

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548522

James Laska  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||mkri...@redhat.com
 Resolution||WONTFIX
Last Closed||2011-07-13 10:16:03

--- Comment #12 from James Laska  2011-07-13 10:16:03 EDT ---
I'm closing this request for now.  Autotest will likely come back for review
soon when we are able to resolve the FHS issues.  When it does, we can either
reopen this request, or start a new review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 643140] Review Request: autokey - A desktop automation utility

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=643140

--- Comment #24 from Raghu Udiyar  2011-07-13 10:19:05 
EDT ---
Confirmed that the licence is GPLv3 and upstream has agreed to :

a. Mention the licence explicitly in the README
b. Use a standard source directory, i.e autokey-version.tar.gz , previously the
tar ball unpacked to a "build" directory, trivial but a good change.

Koji build of the latest package : 

http://koji.fedoraproject.org/koji/taskinfo?taskID=3196600

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721043] New: Review Request: pragha - Lightweight GTK+ music manager

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pragha - Lightweight GTK+ music manager

https://bugzilla.redhat.com/show_bug.cgi?id=721043

   Summary: Review Request: pragha - Lightweight GTK+ music
manager
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: cwick...@fedoraproject.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://cwickert.fedorapeople.org/review/pragha.spec
SRPM URL: http://cwickert.fedorapeople.org/review/pragha-0.97.0-1.fc16.src.rpm
Description: Pragha is is a lightweight GTK+ music manager that aims to be
fast, bloat-free, and light on memory consumption. It is written completely in
C and GTK+. 

Pragha is a fork of Consonance Music Manager, discontinued by the original 
author.

Note: I maintain an older version of this package in rpmfusion. As 0.9x is a
port to gstreamer it no longer requires any forbidden items and we can move it
over to Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721057] New: Review Request: rubygem-sass - A powerful but elegant CSS compiler that makes CSS fun again

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-sass - A powerful but elegant CSS compiler 
that makes CSS fun again

https://bugzilla.redhat.com/show_bug.cgi?id=721057

   Summary: Review Request: rubygem-sass - A powerful but elegant
CSS compiler that makes CSS fun again
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://mo.morsi.org/files/aeolus/rubygem-sass.spec
SRPM URL:
http://mo.morsi.org/files/aeolus/rubygem-sass-3.1.4-1.fc15.src.rpm

Description: 

Sass makes CSS fun again. Sass is an extension of CSS3, adding
nested rules, variables, mixins, selector inheritance, and more.
It's translated to well-formatted, standard CSS using the 
command line tool or a web-framework plugin.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721059] New: Review Request: rubygem-dynamic_form - DynamicForm holds a few helper methods to help you deal with your Rails3 models

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-dynamic_form -  DynamicForm holds a few helper 
methods to help you deal with your Rails3 models

https://bugzilla.redhat.com/show_bug.cgi?id=721059

   Summary: Review Request: rubygem-dynamic_form -  DynamicForm
holds a few helper methods to help you deal with your
Rails3 models
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/rubygem-dynamic_form.spec
SRPM:
http://mo.morsi.org/files/aeolus/rubygem-dynamic_form-1.1.4-1.fc15.src.rpm


Summary:
DynamicForm holds a few helper methods to help you deal with your Rails3
models. It includes the stripped out methods from Rails 2; error_message_on
and error_messages_for. It also brings in the functionality of the 
custom-err-messages plugin, which provides more flexibility over your model
error messages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721061] New: Review Request: rubygem-sunspot - Library for expressive, powerful interaction with the Solr search engine

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-sunspot - Library for expressive, powerful 
interaction with the Solr search engine

https://bugzilla.redhat.com/show_bug.cgi?id=721061

   Summary: Review Request: rubygem-sunspot - Library for
expressive, powerful interaction with the Solr search
engine
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/rubygem-sunspot.spec
SRPM:
http://mo.morsi.org/files/aeolus/rubygem-sunspot-1.2.1-1.fc15.src.rpm


Summary:
Sunspot is a library providing a powerful, all-ruby API for the Solr search
engine. Sunspot manages the configuration of persistent Ruby classes for
search and indexing and exposes Solr's most powerful features through a
collection of DSLs. Complex search operations can be performed without
hand-writing any boolean queries or building Solr parameters by hand.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721062] New: Review Request: rubygem-sunspot_rails - Rails integration for the Sunspot Solr search library

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-sunspot_rails - Rails integration for the 
Sunspot Solr search library

https://bugzilla.redhat.com/show_bug.cgi?id=721062

   Summary: Review Request: rubygem-sunspot_rails - Rails
integration for the Sunspot Solr search library
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/rubygem-sunspot-rails.spec
SRPM:
http://mo.morsi.org/files/aeolus/rubygem-sunspot_rails-1.2.1-1.fc15.src.rpm


Summary:
Sunspot::Rails is an extension to the Sunspot library for Solr search.
Sunspot::Rails adds integration between Sunspot and ActiveRecord, including
defining search and indexing related methods on ActiveRecord models
themselves,
running a Sunspot-compatible Solr instance for development and test
environments, and automatically commit Solr index changes at the end of each
Rails request

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721063] New: Review Request: rubygem-factory_girl_rails - factory_girl_rails provides integration between factory_girl and rails 3

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-factory_girl_rails - factory_girl_rails 
provides integration between factory_girl and rails 3

https://bugzilla.redhat.com/show_bug.cgi?id=721063

   Summary: Review Request: rubygem-factory_girl_rails -
factory_girl_rails provides integration between
factory_girl and rails 3
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/rubygem-factory_girl_rails.spec
SRPM:
http://mo.morsi.org/files/aeolus/rubygem-factory_girl_rails-1.0.1-1.fc15.src.rpm

Summary:
factory_girl_rails provides integration between
factory_girl and rails 3 (currently just automatic factory definition
loading)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721066] New: Review Request: rubygem-image_factory_console - QMF Console for Aeolus Image Factory

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-image_factory_console - QMF Console for Aeolus 
Image Factory

https://bugzilla.redhat.com/show_bug.cgi?id=721066

   Summary: Review Request: rubygem-image_factory_console - QMF
Console for Aeolus Image Factory
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/rubygem-image_factory_console.spec
SRPM:
http://mo.morsi.org/files/aeolus/rubygem-image_factory_console-0.4.0-1.fc15.src.rpm

Summary:
QMF Console for Aeolus Image Factory

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721069] New: Review Request: rubygem-aeolus-cli - Commandline interface for working with the Aeolus cloud suite

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-aeolus-cli - Commandline interface for working 
with the Aeolus cloud suite

https://bugzilla.redhat.com/show_bug.cgi?id=721069

   Summary: Review Request: rubygem-aeolus-cli - Commandline
interface for working with the Aeolus cloud suite
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/rubygem-aeolus-cli.spec
SRPM: http://mo.morsi.org/files/aeolus/rubygem-aeolus-cli-0.0.1-1.fc15.src.rpm

Summary:
Commandline interface for working with the Aeolus cloud suite

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

--- Comment #20 from Fedora Update System  
2011-07-13 12:20:35 EDT ---
perl-Term-Animation-2.6-7.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Term-Animation-2.6-7.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 708532] Review Request: perl-Term-Animation - ASCII sprite animation framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708532

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721078] New: Review Request: aeolus-conductor - A web UI for managing cloud instances.

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: aeolus-conductor - A web UI for managing cloud 
instances.

https://bugzilla.redhat.com/show_bug.cgi?id=721078

   Summary: Review Request: aeolus-conductor - A web UI for
managing cloud instances.
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mmo...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec: http://mo.morsi.org/files/aeolus/aeolus-conductor.spec
SRPM: http://mo.morsi.org/files/aeolus/aeolus-conductor-0.3.0-1.fc15.src.rpm

Description:
The Aeolus Conductor, a web UI for managing cloud instances.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721057] Review Request: rubygem-sass - A powerful but elegant CSS compiler that makes CSS fun again

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721057

Chris Lalancette  changed:

   What|Removed |Added

 CC||clala...@redhat.com
 AssignedTo|nob...@fedoraproject.org|clala...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688316] Review Request: rubygem-logging - A flexible and extendable logging library for Ruby

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688316

Chris Lalancette  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-07-13 13:36:11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688322] Review Request: rubygem-webby - Awesome static website creation and management!

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688322

Bug 688322 depends on bug 688316, which changed state.

Bug 688316 Summary: Review Request: rubygem-logging - A flexible and extendable 
logging library for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=688316

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 688223] Review Request: libdeltacloud - C API for accessing deltacloud

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688223

Chris Lalancette  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-07-13 13:36:50

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721057] Review Request: rubygem-sass - A powerful but elegant CSS compiler that makes CSS fun again

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721057

Chris Lalancette  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Chris Lalancette  2011-07-13 13:46:28 
EDT ---
Initial review:

1)  There are a few lines in there that have trailing whitespace (like
Requires: ruby); not a huge problem, but nice to clean up.
2)  The license is wrong; the spec says GPLv2+ or Ruby (which I know is the
default gem2rpm output), but the actual license of the gem is MIT.

[clalance@localhost SPECS]$ rpmlint
rubygem-sass-3.1.4-1.fc14.noarch.rpmrubygem-sass.noarch: W: spelling-error
%description -l en_US mixins -> mixing, mix ins, mix-ins
rubygem-sass.noarch: W: file-not-utf8
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/templates/_imported_charset_ibm866.sass
rubygem-sass.noarch: W: file-not-utf8
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/results/import_charset_1_8.css
rubygem-sass.noarch: W: file-not-utf8
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/results/import_charset_ibm866.css
rubygem-sass.noarch: W: file-not-utf8
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/css2sass_test.rbc
rubygem-sass.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/results/warn_imported.css
rubygem-sass.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/results/warn.css
rubygem-sass.noarch: W: file-not-utf8
/usr/lib/ruby/gems/1.8/gems/sass-3.1.4/test/sass/engine_test.rbc
rubygem-sass.noarch: W: no-manual-page-for-binary sass-convert
rubygem-sass.noarch: W: no-manual-page-for-binary sass
1 packages and 0 specfiles checked; 2 errors, 8 warnings.

I think we can ignore the "not-utf8" warnings and the "no manpage" warnings,
but we should probably remove the zero-length files.

[  OK  ] MUST: rpmlint must be run on every package
[  OK  ] MUST: The package must be named according to the Package Naming 
 Guidelines
[  OK  ] MUST: The spec file name must match the base package %{name} [...]
[  OK  ] MUST: The package must meet the Packaging Guidelines
The Source of the package must be the full URL to the released Gem archive
See: http://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gems
http://fedoraproject.org/wiki/Packaging:SourceURL

[  OK  ] MUST: The package must be licensed with a Fedora approved license
 and meet the Licensing Guidelines
[ FAIL ] MUST: The License field in the package spec file must match the 
 actual license
[  OK  ] MUST: If (and only if) the source package includes the text of the 
 license(s) in its own file, then that file, containing the text of 
 the license(s) for the package must be included in %doc
[  OK  ] MUST: The spec file must be written in American English.
[  OK  ] MUST: The spec file for the package MUST be legible.
[  OK  ] MUST: The sources used to build the package must match the
upstream 
 source, as provided in the spec URL. Reviewers should use md5sum for 
 this task. If no upstream URL can be specified for this package, 
 please see the Source URL Guidelines for how to deal with this.
[  OK  ] MUST: The package MUST successfully compile and build into binary 
 rpms on at least one primary architecture
[  N/A ] MUST: If the package does not successfully compile, build or work on 
 an architecture, then those architectures should be listed in the 
 spec in ExcludeArch. Each architecture listed in ExcludeArch MUST 
 have a bug filed in bugzilla, describing the reason that the package 
 does not compile/build/work on that architecture. The bug number MUST 
 be placed in a comment, next to the corresponding ExcludeArch line
[  OK  ] MUST: All build dependencies must be listed in BuildRequires, except 
 for any that are listed in the exceptions section of the Packaging 
 Guidelines ; inclusion of those as BuildRequires is optional. Apply 
 common sense.
[  N/A ] MUST: The spec file MUST handle locales properly. This is done by 
 using the %find_lang macro. Using %{_datadir}/locale/* is strictly 
 forbidden
[  N/A ] MUST: Every binary RPM package (or subpackage) which stores shared 
 library files (not just symlinks) in any of the dynamic linker's 
 default paths, must call ldconfig in %post and %postun.
[  N/A ] MUST: If the package is designed to be relocatable, the packager must 
 state this fact in the request for review, along with the 
 rationalization for relocation of that specific package. Without 
 this, use of Prefix: /usr is considered a blocker.
[  OK  ] MUST: A package must own all directories that it creates. If it does 
 not create a directory that it uses, then

[Bug 717768] Review Request: iwhd - image warehouse daemon

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717768

Chris Lalancette  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-07-13 13:52:06

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720040] Review Request: pugixml - A light-weight C++ XML processing library

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720040

Ankur Sinha  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sanjay.an...@gmail.com
 AssignedTo|nob...@fedoraproject.org|sanjay.an...@gmail.com
  Alias||pugixml
   Flag||fedora-review?

--- Comment #2 from Ankur Sinha  2011-07-13 14:00:19 
EDT ---
I'm taking this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720411] Review Request: OpenImageIO - Library for reading and writing images

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720411

Ankur Sinha  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sanjay.an...@gmail.com
 AssignedTo|nob...@fedoraproject.org|sanjay.an...@gmail.com
  Alias||OpenImageIO
   Flag||fedora-review?

--- Comment #3 from Ankur Sinha  2011-07-13 14:00:46 
EDT ---
I'm taking this one too :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717645] Review Request: rubygem-compass-960-plugin - Compass compatible Sass port of 960.gs

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717645

Chris Lalancette  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-07-13 14:09:15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721059] Review Request: rubygem-dynamic_form - DynamicForm holds a few helper methods to help you deal with your Rails3 models

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721059

Chris Lalancette  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||clala...@redhat.com
 AssignedTo|nob...@fedoraproject.org|clala...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

Ankur Sinha  changed:

   What|Removed |Added

 Blocks||721112(vmtk)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721112] Review Request: vmtk - The Vascular Modeling Toolkit

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721112

Ankur Sinha  changed:

   What|Removed |Added

 Blocks||673841(fedora-medical)
 Depends on||720998(OpenNL)
  Alias||vmtk

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721112] New: Review Request: vmtk - The Vascular Modeling Toolkit

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: vmtk - The Vascular Modeling Toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=721112

   Summary: Review Request: vmtk - The Vascular Modeling Toolkit
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: sanjay.an...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://ankursinha.fedorapeople.org/vmtk/vmtk.spec
SRPM URL: http://ankursinha.fedorapeople.org/vmtk/vmtk-0.9.0-1.fc15.src.rpm

Description: 
== Segmentation of vascular segments (or other anatomical structures) from
medical
images:

Gradient-based 3D level sets segmentation. A new gradient computation
modality based on upwind finite differences allows the segmentation of small
(down to 1.2 pixels/diameter) vessels.
Interactive level sets initialization based on the Fast Marching Method.
This includes a brand new method for selecting a vascular segment comprised
between two points automatically ignoring side branches, no parameters
involved.
Segmenting a complex vascular tract comes down to selecting the endpoints of a
branch, letting level sets by attracted to gradient peaks with the sole
advection term turned on, repeating the operation for all the branches and
merging everything in a single model. 

== Geometric analysis and surface data processing of 3D models of blood vessels
(and tubular objects in general)((The key algorithms have been published on
medical imaging journals. You can find a complete reference to publications at
David Steinman's and Luca Antiga's homepages)):

Compute centerlines and maximal inscribed sphere radius of branching
tubular
structures given their polygonal surface representation
Split surface models into their constitutive branches based on centerline
geometry
Compute centerline-based geometric quantities (such as bifurcation angles,
planarity, symmetry, branch curvature, tortuosity) and surface-based geometric
quantities (such as distance to centerlines, surface curvature, deviation from
tangency to maximal inscribed spheres)
Robustly map branches to a rectangular parametric space
Generate rectangular patches based on the parametric mapping for
statistical
analysis of geometric and CFD data over populations. 

== Scripts, I/O tools and simple algorithms to easily work with images and
meshes:

Read and write a number of image, surface and volume mesh formats. Includes
a DICOM series reader with auto-flipping capabilities, Netgen mesh format
reader, libMesh xda mesh format writer, Tetgen mesh generator wrapper, FIDAP
FDNEUT mesh format reader and writer and a Newtetr input file generator
Display images and meshes
Incapsulate several VTK classes and make them available as pipeable scripts
(e.g. Marching Cubes, surface smoothing, clipping, normal computation,
connectivity, subdivision, distance between surfaces, ICP registration)
Add cylindrical extensions to surface model boundaries as a preprocessing
step for CFD simulations.
Generate boundary layers of prismatic elements with varying thickness for
CFD 

=

Some rpmlint issues. Fixing and uploading a new version in a day or two.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721063] Review Request: rubygem-factory_girl_rails - factory_girl_rails provides integration between factory_girl and rails 3

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721063

Chris Lalancette  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||clala...@redhat.com
 AssignedTo|nob...@fedoraproject.org|clala...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721059] Review Request: rubygem-dynamic_form - DynamicForm holds a few helper methods to help you deal with your Rails3 models

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721059

--- Comment #1 from Chris Lalancette  2011-07-13 14:44:49 
EDT ---
Initial review:

1)  There are a few lines in there that have trailing whitespace (like
Requires: ruby); not a huge problem, but nice to clean up.
2)  The license is wrong; the spec says GPLv2+ or Ruby (which I know is the
default gem2rpm output), but the actual license of the gem is MIT.

[  OK  ] MUST: rpmlint must be run on every package
[  OK  ] MUST: The package must be named according to the Package Naming 
 Guidelines
[  OK  ] MUST: The spec file name must match the base package %{name} [...]
[  OK  ] MUST: The package must meet the Packaging Guidelines
The Source of the package must be the full URL to the released Gem archive
See: http://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gems
http://fedoraproject.org/wiki/Packaging:SourceURL

[  OK  ] MUST: The package must be licensed with a Fedora approved license
 and meet the Licensing Guidelines
[ FAIL ] MUST: The License field in the package spec file must match the 
 actual license
[  OK  ] MUST: If (and only if) the source package includes the text of the 
 license(s) in its own file, then that file, containing the text of 
 the license(s) for the package must be included in %doc
[  OK  ] MUST: The spec file must be written in American English.
[  OK  ] MUST: The spec file for the package MUST be legible.
[  OK  ] MUST: The sources used to build the package must match the
upstream 
 source, as provided in the spec URL. Reviewers should use md5sum for 
 this task. If no upstream URL can be specified for this package, 
 please see the Source URL Guidelines for how to deal with this.
[  OK  ] MUST: The package MUST successfully compile and build into binary 
 rpms on at least one primary architecture
[  N/A ] MUST: If the package does not successfully compile, build or work on 
 an architecture, then those architectures should be listed in the 
 spec in ExcludeArch. Each architecture listed in ExcludeArch MUST 
 have a bug filed in bugzilla, describing the reason that the package 
 does not compile/build/work on that architecture. The bug number MUST 
 be placed in a comment, next to the corresponding ExcludeArch line
[  OK  ] MUST: All build dependencies must be listed in BuildRequires, except 
 for any that are listed in the exceptions section of the Packaging 
 Guidelines ; inclusion of those as BuildRequires is optional. Apply 
 common sense.
[  N/A ] MUST: The spec file MUST handle locales properly. This is done by 
 using the %find_lang macro. Using %{_datadir}/locale/* is strictly 
 forbidden
[  N/A ] MUST: Every binary RPM package (or subpackage) which stores shared 
 library files (not just symlinks) in any of the dynamic linker's 
 default paths, must call ldconfig in %post and %postun.
[  N/A ] MUST: If the package is designed to be relocatable, the packager must 
 state this fact in the request for review, along with the 
 rationalization for relocation of that specific package. Without 
 this, use of Prefix: /usr is considered a blocker.
[  OK  ] MUST: A package must own all directories that it creates. If it does 
 not create a directory that it uses, then it should require a package 
 which does create that directory.
[  OK  ] MUST: A package must not contain any duplicate files in the %files 
 listing.
[  OK  ] MUST: Permissions on files must be set properly. Executables should 
 be set with executable permissions, for example.
[  OK  ] MUST: Each package must consistently use macros.
[  OK  ] MUST: The package must contain code, or permissable content.
[  OK  ] MUST: Large documentation files must go in a -doc subpackage. (The 
 definition of large is left up to the packager's best judgement, but 
 is not restricted to size. Large can refer to either size or 
 quantity).
[  OK  ] MUST: If a package includes something as %doc, it must not affect the 
 runtime of the application. To summarize: If it is in %doc, the 
 program must run properly if it is not present.
[  N/A ] MUST: Header files must be in a -devel package.
[  N/A ] MUST: Static libraries must be in a -static package.
[  N/A ] MUST: Packages containing pkgconfig(.pc) files must 'Requires: 
 pkgconfig' (for directory ownership and usability).
[  N/A ] MUST: If a package contains library files with a suffix (e.g. 
 libfoo.so.1.1), then library files that end in .so (without suffix) 
 must go in a -devel package.
[  N/A ] MUST: In the vast majority of cases, devel packages must require the 
 base package using a fully versioned dependency: Requires: %{na

[Bug 721063] Review Request: rubygem-factory_girl_rails - factory_girl_rails provides integration between factory_girl and rails 3

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721063

--- Comment #1 from Chris Lalancette  2011-07-13 14:58:05 
EDT ---
Initial review:

1)  There are a few lines in there that have trailing whitespace (like
Requires: ruby); not a huge problem, but nice to clean up.
2)  The license is wrong; the spec says GPLv2+ or Ruby (which I know is the
default gem2rpm output), but the actual license of the gem is MIT.

[clalance@localhost SPECS]$ rpmlint
rubygem-factory_girl_rails-1.0.1-1.fc14.noarch.rpm
rubygem-factory_girl_rails.noarch: W: summary-not-capitalized C
factory_girl_rails provides integration between factory_girl and rails 3
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

We can probably change that summary to "Provides integration between
factory_girl and rails 3"

[  OK  ] MUST: rpmlint must be run on every package
[  OK  ] MUST: The package must be named according to the Package Naming 
 Guidelines
[  OK  ] MUST: The spec file name must match the base package %{name} [...]
[  OK  ] MUST: The package must meet the Packaging Guidelines
The Source of the package must be the full URL to the released Gem archive
See: http://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gems
http://fedoraproject.org/wiki/Packaging:SourceURL

[  OK  ] MUST: The package must be licensed with a Fedora approved license
 and meet the Licensing Guidelines
[ FAIL ] MUST: The License field in the package spec file must match the 
 actual license
[  OK  ] MUST: If (and only if) the source package includes the text of the 
 license(s) in its own file, then that file, containing the text of 
 the license(s) for the package must be included in %doc
[  OK  ] MUST: The spec file must be written in American English.
[  OK  ] MUST: The spec file for the package MUST be legible.
[  OK  ] MUST: The sources used to build the package must match the
upstream 
 source, as provided in the spec URL. Reviewers should use md5sum for 
 this task. If no upstream URL can be specified for this package, 
 please see the Source URL Guidelines for how to deal with this.
[  OK  ] MUST: The package MUST successfully compile and build into binary 
 rpms on at least one primary architecture
[  N/A ] MUST: If the package does not successfully compile, build or work on 
 an architecture, then those architectures should be listed in the 
 spec in ExcludeArch. Each architecture listed in ExcludeArch MUST 
 have a bug filed in bugzilla, describing the reason that the package 
 does not compile/build/work on that architecture. The bug number MUST 
 be placed in a comment, next to the corresponding ExcludeArch line
[  OK  ] MUST: All build dependencies must be listed in BuildRequires, except 
 for any that are listed in the exceptions section of the Packaging 
 Guidelines ; inclusion of those as BuildRequires is optional. Apply 
 common sense.
[  N/A ] MUST: The spec file MUST handle locales properly. This is done by 
 using the %find_lang macro. Using %{_datadir}/locale/* is strictly 
 forbidden
[  N/A ] MUST: Every binary RPM package (or subpackage) which stores shared 
 library files (not just symlinks) in any of the dynamic linker's 
 default paths, must call ldconfig in %post and %postun.
[  N/A ] MUST: If the package is designed to be relocatable, the packager must 
 state this fact in the request for review, along with the 
 rationalization for relocation of that specific package. Without 
 this, use of Prefix: /usr is considered a blocker.
[  OK  ] MUST: A package must own all directories that it creates. If it does 
 not create a directory that it uses, then it should require a package 
 which does create that directory.
[  OK  ] MUST: A package must not contain any duplicate files in the %files 
 listing.
[  OK  ] MUST: Permissions on files must be set properly. Executables should 
 be set with executable permissions, for example.
[  OK  ] MUST: Each package must consistently use macros.
[  OK  ] MUST: The package must contain code, or permissable content.
[  OK  ] MUST: Large documentation files must go in a -doc subpackage. (The 
 definition of large is left up to the packager's best judgement, but 
 is not restricted to size. Large can refer to either size or 
 quantity).
[  OK  ] MUST: If a package includes something as %doc, it must not affect the 
 runtime of the application. To summarize: If it is in %doc, the 
 program must run properly if it is not present.
[  N/A ] MUST: Header files must be in a -devel package.
[  N/A ] MUST: Static libraries must be in a -static package.
[  N/A ] MUST: Packages containing pkgconfig(.pc) files must 'Requires: 
 pkgconfig' (

[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

Richard Shaw  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

Richard Shaw  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

Richard Shaw  changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719108

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #6 from Fedora Update System  2011-07-13 
15:25:06 EDT ---
drupal6-mobile_tools-2.3-2.fc15 has been pushed to the Fedora 15 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699697

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #11 from Fedora Update System  
2011-07-13 15:25:56 EDT ---
drupal6-diff-2.1-2.fc15 has been pushed to the Fedora 15 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693118

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #9 from Fedora Update System  2011-07-13 
15:28:37 EDT ---
drupal6-admin_menu-1.8-1.fc15 has been pushed to the Fedora 15 testing
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721144] Review Request: imagefactory - System image generation tool

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721144

Chris Lalancette  changed:

   What|Removed |Added

 Depends on||717966

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717966] Review Request: python-psphere - vSphere SDK for Python

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717966

Chris Lalancette  changed:

   What|Removed |Added

 Blocks||721144

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721144] New: Review Request: imagefactory - System image generation tool

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: imagefactory - System image generation tool

https://bugzilla.redhat.com/show_bug.cgi?id=721144

   Summary: Review Request: imagefactory - System image generation
tool
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: clala...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://people.redhat.com/clalance/imagefactory/imagefactory.spec
SRPM URL:
http://people.redhat.com/clalance/imagefactory/imagefactory-0.3.1-1.fc14.src.rpm

Description:
imagefactory is a daemon that listens for build requests via QMF.  When
a build request is received, imagefactory will build the requested image
for the requested target.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

--- Comment #5 from Avesh Agarwal  2011-07-13 17:00:48 EDT 
---
I have see some other packages with GPLv2 license too in Fedora. So I am
wondering what should I explore further if it is admissble?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693118

--- Comment #10 from Fedora Update System  
2011-07-13 17:04:23 EDT ---
drupal6-admin_menu-1.8-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-admin_menu-1.8-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699697

Peter Borsa  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2011-07-13 17:25:13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 699697] Review Request: drupal6-diff - Show diff-type changes in Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699697

--- Comment #12 from Fedora Update System  
2011-07-13 17:21:38 EDT ---
drupal6-diff-2.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-diff-2.1-2.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 693118] Review Request: drupal6-admin_menu - Theme-independent administration interface for Drupal 6

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693118

Peter Borsa  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2011-07-13 17:24:59

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719108

Peter Borsa  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2011-07-13 17:34:38

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 719108] Review Request: drupal6-mobile_tools - The Mobile Tools module provides some tools to assist in making a site mobile

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719108

--- Comment #7 from Fedora Update System  2011-07-13 
17:33:23 EDT ---
drupal6-mobile_tools-2.3-2.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/drupal6-mobile_tools-2.3-2.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 717019] Review Request: tncfhh - An open source implementation of the Trusted Network Connect (TNC) framework

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717019

--- Comment #6 from Steve Grubb  2011-07-13 17:39:58 EDT ---
http://fedoraproject.org/wiki/Licensing#Good_Licenses
GPLv2 is the identifier and its acceptable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721174] New: Review Request: cryptominisat - SAT solver

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cryptominisat - SAT solver

https://bugzilla.redhat.com/show_bug.cgi?id=721174

   Summary: Review Request: cryptominisat - SAT solver
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: loganje...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://jjames.fedorapeople.org/cryptominisat/cryptominisat.spec
SRPM URL:
http://jjames.fedorapeople.org/cryptominisat/cryptominisat-2.9.1-1.fc15.src.rpm
Description: CryptoMiniSat is a SAT solver that aims to become a premiere SAT
solver with all the features and speed of successful SAT solvers, such as
MiniSat and PrecoSat.  The long-term goals of CryptoMiniSat are to be an
efficient sequential, parallel and distributed solver.  There are solvers that
are good at one or the other, e.g. ManySat (parallel) or PSolver (distributed),
but we wish to excel at all.

This package is a prerequisite to upgrading stp to the latest version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 721179] New: Review Request: rubygem-extlib - Support library for DataMapper and Merb

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-extlib - Support library for DataMapper and 
Merb

https://bugzilla.redhat.com/show_bug.cgi?id=721179

   Summary: Review Request: rubygem-extlib - Support library for
DataMapper and Merb
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: shawn.st...@rogers.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---


Spec URL: http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib.spec
SRPM URL:
http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib-0.9.13-1.fc16.src.rpm
Description: Support library for DataMapper and Merb

Please note: This package is marked as expired/blocked in Fedora 15+, It will
be needed for me to build OpenNebula which I am also going to be submitting
along with some other rubygems to come (see other review requests coming soon).

This package is currently in EPEL5/6.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 715180] Review Request: freemat - A free environment for rapid engineering, scientific prototyping and data processing

2011-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

Rich Mattes  changed:

   What|Removed |Added

 CC||richmat...@gmail.com

--- Comment #8 from Rich Mattes  2011-07-13 19:32:24 EDT 
---
I have a few comments as well.

1. The boost build dep isn't doing anything in its current form.  FreeMat is
looking for the math_c99 component, and CMake can't find it.  The latest SVN
version has a fix in CMakeLists.txt that doesn't specify the math_c99 component
on UNIX systems.  This should probably be ported, or else a newer snapshot
should be used.

2. This RPM doesn't install.  None of the included shared libraries that are
built end up in the final RPM, as they all lack INSTALL sections in
CMakeLists.txt (or link everything statically, depending on the choice below)

3. The library names are very generic, especially libGraphics.so.  If you do
end up installing them to %{_libdir}, you might want to prefix their names with
something unique like freemat.  Or, you can do what Mandriva seems to be doing,
and use the flag -DBUILD_SHARED_LIBS=OFF to link all of the libs into the
FreeMat executable

4. The package is in violation of the package naming guidelines at
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
Since the SVN trunk is a pre-release of version 4.1 (according to the root
CMakeLists.txt) the package version should be called
freemat-4.1-0.3.20110620svn  Also, according to the guidelines, the package
name should match the upstream project and tarball name, both of which are
"FreeMat"  The binary being installed is also capitalized.  I think it should
be capitalized, even if it seems like the mandriva package uses an all
lowercase "freemat"

5. This package would benefit greatly from a .desktop file since it's
installing a graphical application.  You can add one and submit it upstream for
consideration.

6. It looks like blas.ini is required at runtime to figure out which BLAS
implementation should be used (you'll want to use ATLAS).  Mandriva has a patch
that installs blas.ini to /usr/share/freemat and changes the source to look
there for it.  I believe we should do the same.

7. I don't think it's necessary to separate the .m files in the toolbox into a
separate -data package.  The freemat language is interpreted and depends on the
functions in the .m files for basic functionality.  I guess it's not hurting
anything since the main package requires the -data package, but the .m files
are vital for the program's basic functionality.

8. You might want to copy the PDF Source1 instead of moving it.  At least in my
case, usually run rpmbuild -ba from ~/rpmbuild/SPECS, and moving the source
file generates a file not found error after the first build attempt.

For reference, when I talk about the mandriva package, I'm looking at the SRPM
at http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/freemat/current/

There's also a discussion thread at
http://groups.google.com/group/freemat-devel/browse_thread/thread/b9f3b48ac200aec5#
that might be relevant

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


  1   2   >