[Bug 724878] New: Review Request: TexStudio - A feature-rich editor for LaTeX documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: TexStudio - A feature-rich editor for LaTeX documents https://bugzilla.redhat.com/show_bug.cgi?id=724878 Summary: Review Request: TexStudio - A feature-rich editor for LaTeX documents Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: johannes.l...@googlemail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- This is a re-review due to a rename of TexmakerX to TexStudio. Spec URL: http://hannes.fedorapeople.org/texstudio.spec SRPM URL: http://hannes.fedorapeople.org/texstudio-2.2-1.fc15.src.rpm Scratch Build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=3221879 Description: Texstudio, formerly known as TexmakerX is a fork of the LaTeX IDE TexMaker and gives you an environment where you can easily create and manage LaTeX documents. It provides modern writing support, like interactive spell checking, code folding and syntax highlighting. Also it serves as a starting point from where you can easily run all necessary LaTeX tools. You can run it on Windows, Unix/Linux, BSD and MacOSX systems and modify it if you want, since it is licensed under the GPL. Although TexStudio has a lot of additional features, it tries to be like an improved version of Texmaker, so it keeps it look&feel. rpmlint texstudio.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] New: Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing https://bugzilla.redhat.com/show_bug.cgi?id=724883 Summary: Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: olivier.sal...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://osallou.genouest.org/biomaj/biomaj.spec SRPM URL: http://osallou.genouest.org/biomaj/biomaj-1.1.0-1.fc15.src.rpm Description: This is a first upload of the Biomaj package on Fedora and I search for a sponsor to do so. BioMAJ downloads remote data banks check their status and apply transformation workflows, with consistent state,to provide ready-to-use data to biologists and bioinformaticians. For example, it can transform original fasta files to blast indexes. It is very flexible and post-processes can be extended very easily. BioMAJ is already packaged on Debian. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=724883
Pierre-YvesChibon changed:
What|Removed |Added
CC||pin...@pingoured.fr
Blocks||177841(FE-NEEDSPONSOR)
--- Comment #1 from Pierre-YvesChibon 2011-07-22 04:18:05
EDT ---
I happen to be bioinformaticien, french and sponsor, so let's have a look.
First comments at first glance:
* Please split the lines in your spec. It doesn't fit in my 19" screen. We
normally don't make line longer than 80 characters
* Use %global instead of %define:
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
* Why do you redefine %{name}, %{version} ? (first lines)
* I would prefer to see a direct link to upstream's sources. They want to see
who is using their tool, but they won't be able to with the tool in debian or
Fedora. So as soon as they accept to have their tool packaged, this
"registration" system is rather pointless.
* this is associated with the invalid source0 that rpmlint shows
* your %clean section looks strange to me
* Some comments in %file are not necessary anymore
* on %prep, you might want to use pushd and popd rather then cd ../../
The full output from rpmlint on all the rpm:
$ rpmlint biomaj-1.1.0-1.fc15.src.rpm
biomaj.src: W: spelling-error %description -l en_US workflows -> work flows,
work-flows, workloads
biomaj.src: W: spelling-error %description -l en_US bioinformaticians ->
transformations
biomaj.src: W: spelling-error %description -l en_US fasta -> fasts, fast, pasta
biomaj.src: W: invalid-license BSD with attribution
biomaj.src: W: strange-permission Deb2Fedora.sh 0755L
biomaj.src:24: W: macro-in-comment %{name}
biomaj.src:24: W: macro-in-comment %{name}
biomaj.src:24: W: macro-in-comment %{version}
biomaj.src:74: W: macro-in-comment %__cp
biomaj.src:82: W: macro-in-comment %{nonConfigFiles}
biomaj.src:105: W: macro-in-comment %dir
biomaj.src:106: W: macro-in-comment %dir
biomaj.src:107: W: macro-in-comment %dir
biomaj.src:108: W: macro-in-comment %dir
biomaj.src: W: invalid-url Source0: /biomaj-1.1.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 15 warnings.
$ rpmlint /home/pierrey/rpmbuild/RPMS/noarch/biomaj-1.1.0-1.fc15.noarch.rpm
biomaj.noarch: W: spelling-error %description -l en_US bioinformaticians ->
transformations
biomaj.noarch: W: spelling-error %description -l en_US fasta -> fasts, fast,
pasta
biomaj.noarch: W: invalid-license BSD with attribution
biomaj.noarch: W: hidden-file-or-dir
/usr/share/biomaj/lib/vendor/commons-cli2/src/test/data/.hidden.txt
biomaj.noarch: W: log-files-without-logrotate /var/log/biomaj
biomaj.noarch: W: class-path-in-manifest /usr/share/biomaj/lib/biomaj.jar
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
I believe some can be fixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] New: Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework https://bugzilla.redhat.com/show_bug.cgi?id=724901 Summary: Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: vondr...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://people.redhat.com/vondruch/rubygem-rails_warden.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-rails_warden-0.5.5-1.fc16.src.rpm Description: A gem that provides authentication via the Warden framework Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3222030 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724901 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724901 Vít Ondruch changed: What|Removed |Added Blocks||705520 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 706934] Review Request: rubygem-rspec-rails - RSpec-2 for Rails-3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706934 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-22 04:52:59 --- Comment #13 from Vít Ondruch 2011-07-22 04:52:59 EDT --- Rails were fixed and Mo built the package, so it should be already in Rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=724901
Marcela Mašláňová changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Marcela Mašláňová 2011-07-22 05:06:26
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
resolvedeps-f16 rubygem-rails_warden-0.5.5-1.fc16.src.rpm
Binary dependencies resolvable. Ok.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693664] Review Request: supybot-gribble - Cross-platform support bot based on supybot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693664 --- Comment #28 from Fedora Update System 2011-07-22 05:30:58 EDT --- supybot-gribble-0.83.4.1-8.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/supybot-gribble-0.83.4.1-8.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #3 from Pierre-YvesChibon 2011-07-22 05:42:57 EDT --- (In reply to comment #2) > I have updated spec and source according to remarks. Files are updated on > remote site (same url) We normally update the %changelog to reflect the changes made to the spec file. > For Source, upstream archive is not named according expected format. I cannot > really change this, (quite a mess to maintain different source package for > different distributions). So I define, as proposed in Fedora policy, the file > name. URL to use and script to apply are defined in comments and Source1 Could you elaborate on this ? What is the format ? You don't have to maintain source package for each distro, just one with the correct installer (ant/pom/setup.py/makefile/install.sh), then it is up to the packager. Also, looking at the sources quickly, you seem to embed apache-commons-cli instead of using the one on the system. This is not allowed (bundle library). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714141] Review Request: rubygem-multipart - Add multipart (file upload) support to Net::HTTP::Post
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714141 --- Comment #2 from Vít Ondruch 2011-07-22 05:49:01 EDT --- Thank you for your review! New Package SCM Request === Package Name: rubygem-multipart Short Description: Add multipart (file upload) support to Net::HTTP::Post Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724901 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Vít Ondruch 2011-07-22 05:47:44 EDT --- Thank you for your review! New Package SCM Request === Package Name: rubygem-rails_warden Short Description: A gem that provides authentication via the Warden framework Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715570] Review Request: rubygem-multipart-post - Creates a multipart form post accessory for Net::HTTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715570 Marcela Mašláňová changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #2 from osallou 2011-07-22 05:18:53 EDT --- I have updated spec and source according to remarks. Files are updated on remote site (same url) All warning are not removed, cause some are software intrisic or spelling unknown For Source, upstream archive is not named according expected format. I cannot really change this, (quite a mess to maintain different source package for different distributions). So I define, as proposed in Fedora policy, the file name. URL to use and script to apply are defined in comments and Source1 Thanks for review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724914] New: Review Request: cookxml - Dynamic XML data binding tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: cookxml - Dynamic XML data binding tool https://bugzilla.redhat.com/show_bug.cgi?id=724914 Summary: Review Request: cookxml - Dynamic XML data binding tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mgold...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://goldmann.fedorapeople.org/package_review/cookxml/cookxml.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/cookxml/cookxml-3.0.2-1.fc15.src.rpm Description: CookXml is a powerful general purpose dynamic XML data binding tool. It is designed to be easy to use and easily extensible. $ rpmlint cookxml.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint cookxml-3.0.2-1.fc15.src.rpm cookxml.src: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=356 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724914] Review Request: cookxml - Dynamic XML data binding tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724914 Marek Goldmann changed: What|Removed |Added Blocks||652183(FE-JAVASIG) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721078] Review Request: aeolus-conductor - A web UI for managing cloud instances.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721078 --- Comment #8 from Jon Ciesla 2011-07-22 06:02:44 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #4 from osallou 2011-07-22 06:05:00 EDT --- Hi, for changelog, I though that changes were made only after first upload. For source, the source on our server is named biomaj_1.1.0.orig.tar.gz, and unzipped directory is named biomaj_1.1.0. In SPEC , it expects biomaj-1.1.0 (dash, not underscore): when building rpm it takes the source file, unzip it and goes to biomaj-1.1.0, so it fails. So I have to rename directory to biomaj-1.1.0 using Def2Fedora script. At least, regarding commons-cli, this is not exact. We embed commons-cli2 which is not packaged (and will never be as project is orphan). Future version will remove this dependency to use commons-cli from system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723792] Review Request: python-flask-sqlalchemy - Adds sqlalchemy support to flask application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723792 --- Comment #7 from Jon Ciesla 2011-07-22 06:07:19 EDT --- Already exists, please submit a Package Change request instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723859] Review Request: python-webassets - Media asset management for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723859 --- Comment #6 from Jon Ciesla 2011-07-22 06:08:07 EDT --- Already exists, please submit a Package Change request instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712909] Review Request: rubygem-POpen4 - Open4 cross-platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712909 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Vít Ondruch 2011-07-22 06:07:10 EDT --- Thank you for your review! New Package SCM Request === Package Name: rubygem-POpen4 Short Description: Open4 cross-platform Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724901 --- Comment #3 from Jon Ciesla 2011-07-22 06:09:23 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714141] Review Request: rubygem-multipart - Add multipart (file upload) support to Net::HTTP::Post
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714141 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=724883
--- Comment #5 from Pierre-YvesChibon 2011-07-22 06:12:57
EDT ---
(In reply to comment #4)
> Hi,
> for changelog, I though that changes were made only after first upload.
All the changes on the spec :)
> For source, the source on our server is named biomaj_1.1.0.orig.tar.gz, and
> unzipped directory is named biomaj_1.1.0.
> In SPEC , it expects biomaj-1.1.0 (dash, not underscore): when building rpm it
> takes the source file, unzip it and goes to biomaj-1.1.0, so it fails. So I
> have to rename directory to biomaj-1.1.0 using Def2Fedora script.
This is not a problem, just use %prep -n %{name}_%{version} and you are done.
> At least, regarding commons-cli, this is not exact. We embed commons-cli2
> which
> is not packaged (and will never be as project is orphan). Future version will
> remove this dependency to use commons-cli from system.
I am not sure it is possible/acceptable.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 --- Comment #10 from Mark McLoughlin 2011-07-22 06:12:36 EDT --- Sorry to drag this out further, but: 1) The Source URL doesn't seem to work. It does seem to work after you follow this: http://github.com/aeolusproject/aeolus-image/tarball/v0.0.1 but then it gets deleted after a while 2) "The Source of the package must be the full URL to the released Gem archive" http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Gems I had expected we'd build a gem from the v0.0.1 tag in git, upload it somewhere (fedorapeople perhaps) and use that as the Source URL 3) The License is "GPLv2+ or Ruby" - should just be GPLv2+, right? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721066] Review Request: rubygem-imagefactory-console - QMF Console for Aeolus Image Factory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721066 --- Comment #11 from Mark McLoughlin 2011-07-22 06:15:33 EDT --- I'm not the reviewer, but I think my rubygem-aeolus-image comments apply here too: https://bugzilla.redhat.com/show_bug.cgi?id=721069#c10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712909] Review Request: rubygem-POpen4 - Open4 cross-platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712909 --- Comment #3 from Jon Ciesla 2011-07-22 06:22:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714141] Review Request: rubygem-multipart - Add multipart (file upload) support to Net::HTTP::Post
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714141 --- Comment #3 from Jon Ciesla 2011-07-22 06:22:31 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724914] Review Request: cookxml - Dynamic XML data binding tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724914 Marek Goldmann changed: What|Removed |Added Blocks||724924 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Marek Goldmann changed: What|Removed |Added Blocks||652183(FE-JAVASIG) Depends on||724914 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] New: Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: cookcc - Lexer and Parser Generator https://bugzilla.redhat.com/show_bug.cgi?id=724924 Summary: Review Request: cookcc - Lexer and Parser Generator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mgold...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://goldmann.fedorapeople.org/package_review/cookcc/1/cookcc.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/cookcc/1/cookcc-0.3.3-1.fc15.src.rpm Description: CookCC is a lexer and parser (LALR (1)) generator project, combined. It is written in Java, but the target languages can vary. $ rpmlint cookcc-0.3.3-1.fc15.src.rpm cookcc.src: I: enchant-dictionary-not-found en_US cookcc.src: W: invalid-url Source0: cookcc-0.3.3.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ./cookcc.spec ./cookcc.spec: W: invalid-url Source0: cookcc-0.3.3.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724901] Review Request: rubygem-rails_warden - A gem that provides authentication via the Warden framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724901 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-22 06:28:44 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723575] Review Request: libpki - Easy-to-use PKI library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=723575
--- Comment #1 from Michael Schwendt 2011-07-22 06:28:33
EDT ---
Not a full review:
> %global with_doc 1
%bcond_without doc 1
is more flexible and mighty as a default. With it you could simply toggle the
%with_doc macro when building, e.g. rpmbuild --without doc ...
> # Remove unneeded files.
>
> rm -rf "${RPM_BUILD_ROOT}%{_datadir}/libpki"
Something like this asks for an explanation in a spec file comment. It is
obvious that "rm -rf" removes an entire tree, but the _why_ isn't answered.
What files are in there and why are they unneeded?
> #---
> %post
> #---
>
> /sbin/ldconfig
>
>
> #---
> %postun
> #---
>
> /sbin/ldconfig
Caution! Here you create shell scripts that contain your long '#...' lines,
because there is no way yet to decide which comment is part of the script or
just the spec file. Take a look at e.g. the rpm -qp --scripts libpki-*rpm
output of the built packages. If you really want to execute just ldconfig,
prefer running it directly with an automatic dependency on its path instead of
/bin/sh:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
> %{_bindir}/pki-cert
> %{_bindir}/pki-crl
> %{_bindir}/pki-derenc
> %{_bindir}/pki-query
> %{_bindir}/pki-request
> %{_bindir}/pki-siginfo
> %{_bindir}/pki-tool
> %{_bindir}/pki-xpair
> %{_bindir}/url-tool
Very generic names that bear a high risk of causing conflicts with other/future
packages, especially if these tools are shipped within a library package.
Just the '-' in 'pki-' and 'url-' currently creates an own namespace. However,
the 'pki' and 'url' prefix is in use already:
$ repoquery --whatprovides /usr/bin/pki\*
pki-console-0:9.0.2-1.fc15.noarch
procps-0:3.2.8-19.20110302git.fc15.x86_64
pki-setup-0:9.0.9-1.fc15.noarch
pki-setup-0:9.0.7-1.fc15.noarch
procps-0:3.2.8-21.20110302git.fc15.x86_64
librapi-0:0.15.1-1.fc15.i686
librapi-0:0.15.1-1.fc15.x86_64
pki-silent-0:9.0.7-1.fc15.noarch
pki-console-0:9.0.3-1.fc15.noarch
pki-silent-0:9.0.9-1.fc15.noarch
$ yum list pki-\*|wc -l
21
$ repoquery --whatprovides /usr/bin/url\*
gridsite-clients-0:1.7.15-4.fc15.x86_64
python-urlgrabber-0:3.9.1-10.fc15.noarch
urlwatch-0:1.12-1.fc15.noarch
urlview-0:0.9-8.fc15.x86_64
gridsite-clients-0:1.7.9-2.fc15.x86_64
Even if this library's tools plan to occupy the 'pki-' namespace for
executables like this (and not the 'libpki-' namespace), it would be better to
move these files into a libpki-tools or libpki-utils package, so the tools
remain optional whereas the library package might be dragged in as a dependency
of something.
$ libpki-config --cflags
-I/usr/include/libxml2 -DLINUX
The libpki-devel package is missing a dependency on libxml2-devel as pki.h and
several other headers include libxml headers, but the pkgconfig file explicitly
depends on libxml-2.0.pc.
Further, libpki.pc is broken (which also explains why the automatic .pc file
dep has not been added by rpmbuild):
$ cat /usr/lib64/pkgconfig/libpki.pc |grep libdir
libdir=/usr/lib
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723575] Review Request: libpki - Easy-to-use PKI library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723575 --- Comment #2 from Michael Schwendt 2011-07-22 06:37:04 EDT --- The deeper look at the pkgconfig problem: $ pkg-config --cflags libpki Package openssl-0.9.8 was not found in the pkg-config search path. Perhaps you should add the directory containing `openssl-0.9.8.pc' to the PKG_CONFIG_PATH environment variable Package 'openssl-0.9.8', required by 'libpki', not found $ cat /usr/lib64/pkgconfig/libpki.pc|grep ^Req Requires: libxml-2.0 openssl-0.9.8 $ ls /usr/lib64/pkgconfig/openssl.pc /usr/lib64/pkgconfig/openssl.pc $ rpm -q openssl-devel openssl-devel-1.0.0d-1.fc15.x86_64 $ pkg-config --print-requires libpki $ That's why the pkgconfig dep generation fails. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712909] Review Request: rubygem-POpen4 - Open4 cross-platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712909 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-22 06:41:38 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #6 from osallou 2011-07-22 06:53:08 EDT --- Hi, I have updated code on web site (with changelog). I fixed the Source issue help with your command to avoid Deb2Fedora stuff. regarding commons-cli2, this is what we do on Debian. The apache-commons-cli2 is Apache2 license, and can as such be delivered with the code. It is used as an internal library, with original source code. The library is built with the rest of the code at package built. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 714141] Review Request: rubygem-multipart - Add multipart (file upload) support to Net::HTTP::Post
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714141 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-22 07:02:05 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #7 from Pierre-YvesChibon 2011-07-22 07:05:47 EDT --- The changelog format is wrong. You need to increase the release and make a proper entry in the changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724936] Review Request: python-mock - A Python Mocking and Patching Library for Testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724936 Praveen Kumar changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721066] Review Request: rubygem-imagefactory-console - QMF Console for Aeolus Image Factory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721066 --- Comment #12 from Mark McLoughlin 2011-07-22 07:06:12 EDT --- Mo, see https://fedorahosted.org/pipermail/aeolus-devel/2011-July/003431.html You want to use http://repos.fedorapeople.org/repos/aeolus/imagefactory-console/0.4.0/gem/imagefactory-console-0.4.0.gem -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 --- Comment #11 from Mark McLoughlin 2011-07-22 07:06:08 EDT --- Mo, see https://fedorahosted.org/pipermail/aeolus-devel/2011-July/003431.html You want to use http://repos.fedorapeople.org/repos/aeolus/aeolus-image/0.0.1/gem/aeolus-image-0.0.1.gem -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724936] New: Review Request: python-mock - A Python Mocking and Patching Library for Testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-mock - A Python Mocking and Patching Library for Testing https://bugzilla.redhat.com/show_bug.cgi?id=724936 Summary: Review Request: python-mock - A Python Mocking and Patching Library for Testing Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kumarpraveen.nit...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://kumarpraveen.fedorapeople.org/mock/python-mock.spec SRPM URL: http://kumarpraveen.fedorapeople.org/mock/python-mock-0.7.2-1.fc15.src.rpm Description: Mock is a Python module that provides a core mock class. It removes the need to create a host of stubs throughout your test suite. After performing an action, you can make assertions about which methods / attributes were used and arguments they were called with. You can also specify return values and set needed attributes in the normal way. koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3222412 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723991 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #8 from osallou 2011-07-22 07:14:16 EDT --- updated to release 2 with according src.rpm. (with spec file) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #9 from Alexander Kurtakov 2011-07-22 07:16:17 EDT --- In Fedora we are more strict about bundling libraries - in short it's forbidden unless you receive an exception from FPC (Fedora Packaging Committee). See https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries for details and https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries for details. Bundling libraries is doing so much harm that it should be really forbidden without exceptions if you ask me. If you intend to remove the bundled library and to use the system one please do it sooner. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 711350] Review Request: jboss-parent - JBoss Parent POM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=711350 --- Comment #7 from Marek Goldmann 2011-07-22 07:20:43 EDT --- And a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3222447 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715570] Review Request: rubygem-multipart-post - Creates a multipart form post accessory for Net::HTTP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715570
Marcela Mašláňová changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #1 from Marcela Mašláňová 2011-07-22 07:24:08
EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
resolvedeps-f16 ~/Downloads/rubygem-multipart-post-1.1.2-1.fc16.noarch.rpm
Binary dependencies resolvable. Ok.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #1 from Alexander Kurtakov 2011-07-22 07:27:33 EDT --- No javadoc subpackage? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724914] Review Request: cookxml - Dynamic XML data binding tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724914 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #1 from Alexander Kurtakov 2011-07-22 07:27:03 EDT --- No javadoc subpackage? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715570] Review Request: rubygem-multipart-post - Creates a multipart form post accessory for Net::HTTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715570 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Vít Ondruch 2011-07-22 07:33:23 EDT --- Thank you for your review! New Package SCM Request === Package Name: rubygem-multipart-post Short Description: Creates a multipart form post accessory for Net::HTTP Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #10 from osallou 2011-07-22 07:36:19 EDT --- So I will wait for next release of the software. I cannot simply fix current version to so. Can I keep this request open in the meanwhile and ping again once new release is available? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=723991
--- Comment #1 from Jaroslav Reznik 2011-07-22 07:43:17
EDT ---
Name: ok
Summary: ok
Source: not ok, please provide full sources url if not generated manually (and
then it should be documented)
License: ok
Obsoletes: should be versioned, see rpmlint output
Url: ok
Group: ok but not needed anymore in Fedora
Requires: not ok, please do not use explicit requires (unless it's runtime
dependency not autogenerated by rpm depsolver), ok for scriptlets, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Requires
BuildRequires: ok but qmf-devel is now qpid-qmf-devel (still provides
qmf-devel)
Description: ok
Build: please use parallel make if possible, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - otherwise
document it in comment that it's not possible to use it
Build: scratch build failed, see
http://koji.fedoraproject.org/koji/taskinfo?taskID=3222416
Macros usage consistency: inconsistent %{buildroot} and $RPM_BUILD_ROOT used
together, see http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
Doc: ok
%defattr is not needed explicitely anymore in rpm 4.4+
rpmlint libvirt-qmf-0.3.0-1.fc15.src.rpm
libvirt-qmf.src: W: spelling-error Summary(en_US) QPid -> QP id, QP-id, Quid
libvirt-qmf.src: W: spelling-error %description -l en_US qpid -> quid, tepid,
cupid
libvirt-qmf.src:9: W: unversioned-explicit-obsoletes libvirt-qpid
libvirt-qmf.src: W: invalid-url Source0: libvirt-qmf-0.3.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724942] New: Review Request: libmodbus - A Modbus library written in C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: libmodbus - A Modbus library written in C https://bugzilla.redhat.com/show_bug.cgi?id=724942 Summary: Review Request: libmodbus - A Modbus library written in C Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: stephane.raimba...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://copyleft.free.fr/data/libmodbus.spec SRPM URL: http://copyleft.free.fr/data/libmodbus-3.0.1-1.src.rpm Description: libmodbus is a free software library to send/receive data with a device which respects the Modbus protocol. This library can use a serial port or an Ethernet connection. The functions included in the library have been derived from the Modicon Modbus Protocol Reference Guide which can be obtained from Schneider at www.schneiderautomation.com. The license of libmodbus is LGPL v2.1 or later and the licence of programs in tests directory is GPL v3. The documentation is available under the Creative Commons Attribution-ShareAlike License 3.0 (Unported) (http://creativecommons.org/licenses/by-sa/3.0/). The official website is http://www.libmodbus.org. The library is written in C and designed to run on Linux, Mac OS X, FreeBSD and QNX and Windows. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724883 --- Comment #11 from Pierre-YvesChibon 2011-07-22 07:44:14 EDT --- Of course, no problem :) In the mean while, normally to become fedora packager we ask a candidate to show their understanding of the guidelines. The easiest way to do that is to perform some un-official review (since you are not a packager, you cannot approve a package) and eventually submit another review request. Please mention on this ticket which bugs you have reviewed and if you submit another review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724942] Review Request: libmodbus - A Modbus library written in C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724942 Stéphane Raimbault changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from Stéphane Raimbault 2011-07-22 07:50:55 EDT --- It's my first package and I'm seeking a sponsor. I'm the maintainer of libmodbus project. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715570] Review Request: rubygem-multipart-post - Creates a multipart form post accessory for Net::HTTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715570 --- Comment #3 from Jon Ciesla 2011-07-22 07:51:55 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715570] Review Request: rubygem-multipart-post - Creates a multipart form post accessory for Net::HTTP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715570 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-22 08:18:17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721078] Review Request: aeolus-conductor - A web UI for managing cloud instances.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721078 Mo Morsi changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||RAWHIDE Last Closed||2011-07-22 08:20:35 --- Comment #9 from Mo Morsi 2011-07-22 08:20:35 EDT --- Pushed to rawhide and built. Closing this out -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724942] Review Request: libmodbus - A Modbus library written in C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724942 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #2 from Peter Lemenkov 2011-07-22 08:22:29 EDT --- I'll review it (and will sponsor you) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 --- Comment #12 from Mo Morsi 2011-07-22 08:36:51 EDT --- OK updated Source0 to reflect released gem (we should push this to rubygems.org) Updated: Spec: http://mo.morsi.org/files/aeolus/rubygem-aeolus-image.spec SRPM: http://mo.morsi.org/files/aeolus/rubygem-aeolus-image-0.0.1-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721066] Review Request: rubygem-imagefactory-console - QMF Console for Aeolus Image Factory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721066 --- Comment #13 from Mo Morsi 2011-07-22 08:39:24 EDT --- Updated Source0 url to reflect gem (this should be pushed to rubygems.org as well) Updated SPEC: http://mo.morsi.org/files/aeolus/rubygem-imagefactory-console.spec Updated SRPM: http://mo.morsi.org/files/aeolus/rubygem-imagefactory-console-0.4.0-5.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724924] Review Request: cookcc - Lexer and Parser Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724924 --- Comment #2 from Marek Goldmann 2011-07-22 08:44:04 EDT --- (In reply to comment #1) > No javadoc subpackage? Correct, build script doesn't build them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724942] Review Request: libmodbus - A Modbus library written in C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=724942
--- Comment #3 from Peter Lemenkov 2011-07-22 08:44:31 EDT
---
Few notes:
* Packager field should be removed as per Fedora Policy.
* This line should be removed - "Provides: libmodbus=%{version}"
* Missing BuildRequires: xmlto, asciidoc
* Please, remove [ "%{buildroot}" != "/" ] && %{__rm} -rf %{buildroot} .Ether
drop them entirely (it added by rpmbuild automatically nowadays) or simplify
these lines up to "rm -rf %{buildroot}".
* Move make check into its own section from %install
%check
make check
* Don't use %makeinstall macro. Use make install DESTDIR=$RPM_BUILD_ROOT
instead
* Don't mix make and %{_make} - it's not an issue, it just looks ugly.
* One more proposal to %post and %postup sections. You should simplify them as
following:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
This will save you two additional bash invocations during build.
* *.la files cannot be packaged at all. Remove it at the end of the %install
section.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724859] NewLisp - Package Review - Lisp-like general scripting language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724859 Peter Lemenkov changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724914] Review Request: cookxml - Dynamic XML data binding tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724914 --- Comment #2 from Marek Goldmann 2011-07-22 08:55:19 EDT --- (In reply to comment #1) > No javadoc subpackage? This package doesn't even provide a build script in source distribution. I took relevant bits from code repository: http://cookxml.svn.sourceforge.net/viewvc/cookxml/trunk/build.xml?revision=HEAD&view=markup which still doesn't provide javadoc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700862] Review Request: wmcalc - Calculator in a WindowMaker dockapp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700862 --- Comment #9 from Mario Blättermann 2011-07-22 09:05:09 EDT --- Many thanks for your review! I've changed the files once again to reflect your review: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmcalc.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/wmcalc-0.3-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700862] Review Request: wmcalc - Calculator in a WindowMaker dockapp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700862 Mario Blättermann changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Mario Blättermann 2011-07-22 09:07:26 EDT --- New Package SCM Request === Package Name: wmcalc Short Description: Calculator in a WindowMaker dockapp Owners: mariobl Branches: f15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700862] Review Request: wmcalc - Calculator in a WindowMaker dockapp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700862 --- Comment #11 from Jon Ciesla 2011-07-22 09:09:21 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 713508] Review Request: rubygem-oauth - OAuth Core Ruby implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713508 Marcela Mašláňová changed: What|Removed |Added Flag||fedora-review+ --- Comment #2 from Marcela Mašláňová 2011-07-22 09:28:57 EDT --- I didn't find anything against env in Packaging Guidelines. I believe it was suggested don't use env, but it has pros and cons. Also patching every ruby file, which contain env will be inconvenient. Ruby is used to use more versions of rubygems, so it's probably common practice for Ruby packaging. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 Mark McLoughlin changed: What|Removed |Added AssignedTo|mar...@redhat.com |mmo...@redhat.com Flag|fedora-review? |fedora-review+ --- Comment #13 from Mark McLoughlin 2011-07-22 09:56:23 EDT --- (In reply to comment #12) > OK updated Source0 to reflect released gem (we should push this to > rubygems.org) Could you give me some pointers on aeolus-devel on how to do the rubygems.org piece? Thanks > Updated: > Spec: http://mo.morsi.org/files/aeolus/rubygem-aeolus-image.spec > SRPM: > http://mo.morsi.org/files/aeolus/rubygem-aeolus-image-0.0.1-4.fc15.src.rpm Yay! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724991] New: Review Request: Smoke Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Smoke Generator https://bugzilla.redhat.com/show_bug.cgi?id=724991 Summary: Review Request: Smoke Generator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: t...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://than.fedorapeople.org/rawhide/smokegen.spec SRPM URL: http://rdieter.fedorapeople.org/rawhide/smokegen-4.6.95-1.fc15.src.rpm Description: Smoke Generator Split packaging for smokegen. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724991] Review Request: Smoke Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724991 --- Comment #1 from Ngo Than 2011-07-22 10:20:50 EDT --- Spec URL: http://than.fedorapeople.org/rawhide/smokegen.spec SRPM URL: http://than.fedorapeople.org/rawhide/smokegen-4.6.95-1.fc15.src.rpm Description: Smoke Generator Split packaging for smokegen. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 --- Comment #15 from Mo Morsi 2011-07-22 10:25:37 EDT --- Sorry, didn't copy all of the request template New Package SCM Request === Package Name: rubygem-aeolus-image Short Description: Commandline interface for working with the Aeolus cloud suite Owners: mmorsi Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 Mo Morsi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Mo Morsi 2011-07-22 10:24:45 EDT --- New Package SCM Request === Package Name: rubygem-aeolus-image Short Description: Commandline interface for working with the Aeolus cloud suite Owners: mmorsi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722192] Review Request: Pan-0.135.i686.fc14 - Pan 5th June 2011
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722192 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722192] Review Request: Pan-0.135.i686.fc14 - Pan 5th June 2011
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722192 --- Comment #5 from Fedora Update System 2011-07-22 10:48:12 EDT --- pan-0.135-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pan-0.135-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724991] Review Request: Smoke Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724991 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724991] Review Request: smokegen - Smoke Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724991 Jaroslav Reznik changed: What|Removed |Added Summary|Review Request: Smoke |Review Request: smokegen - |Generator |Smoke Generator -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725006] New: Bindings for Qt libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Bindings for Qt libraries https://bugzilla.redhat.com/show_bug.cgi?id=725006 Summary: Bindings for Qt libraries Product: Fedora Version: rawhide Platform: All OS/Version: All Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: t...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://than.fedorapeople.org/rawhide/smokeqt.spec SRPM URL: http://than.fedorapeople.org/rawhide/smokeqt-4.6.95-1.fc15.src.rpm Description: Bindings for Qt libraries Split packaging for smokeqt. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725006] smokeqt - Bindings for Qt libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725006 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Summary|Bindings for Qt libraries |smokeqt - Bindings for Qt ||libraries Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725008] New: Review Request: smokekde, Bindings for KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: smokekde, Bindings for KDE libraries https://bugzilla.redhat.com/show_bug.cgi?id=725008 Summary: Review Request: smokekde, Bindings for KDE libraries Product: Fedora Version: rawhide Platform: All OS/Version: All Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: t...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://than.fedorapeople.org/rawhide/smokekde.spec SRPM URL: http://than.fedorapeople.org/rawhide/smokekde-4.6.95-1.fc15.src.rpm Description: Bindings for KDE libraries Split packaging for smokekde. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725006] Review Request: smokeqt - Bindings for Qt libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725006 Ngo Than changed: What|Removed |Added Summary|smokeqt - Bindings for Qt |Review Request: smokeqt - |libraries |Bindings for Qt libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725008] Review Request: smokekde, Bindings for KDE libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725008 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720864] Review Request: gadmin-httpd - Apache GUI tool - First package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720864 Nathan Owe changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724859] NewLisp - Package Review - Lisp-like general scripting language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724859 --- Comment #2 from Nathan Owe 2011-07-22 11:06:43 EDT --- Thanks, and also while I remember rpmlint didn't give a error on the SPEC/SRPM/RPM except missing enchant-dictiionary-not-found en_US, from which I heard installing it on my system will fix that error. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722812] Review Request: worker - X11 File manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722812 Nathan Owe changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 721069] Review Request: rubygem-aeolus-image - Commandline interface for working with the Aeolus cloud suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 --- Comment #16 from Jon Ciesla 2011-07-22 11:21:54 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724991] Review Request: smokegen - Smoke Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724991 --- Comment #2 from Jaroslav Reznik 2011-07-22 11:22:48 EDT --- Name: ok, matches upstream Summary: ok Group: ok, but not needed anymore License: not ok, LGPLv2 and GPLv2+ (according to discussion with Rex - legal wants us to list all licenses included in tarball) Url: not ok, redirects to Techbase and no article can be found there Source: ok (md5sum dd8dc0f9fb8e2fe5294075855be524a4) Obsoletes/Provides: ok?, smokegen was part of kdebindings (can all smoke* related packages provide kdebindigs?) Description: could be, I'd like to provide more information there, not a blocker Ldconfig: ok Docs: ok, just ping upstream for proper COPYING Shouldn't we have smokegen-devel? The same way as original kdebindings had it? Group, BuildRoot, clean section, defattrs not needed anymore rpmlint rpmlint smokegen-4.6.95-1.fc15.src.rpm smokegen.src: W: invalid-url URL: http://developer.kde.org/language-bindings/ HTTP Error 404: Not Found > fix pls smokegen.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.95/src/smokegen-4.6.95.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 2 warnings. > ok, we will have stable soon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724991] Review Request: smokegen - Smoke Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724991 Jaroslav Reznik changed: What|Removed |Added Blocks||656997(kde-reviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723991 --- Comment #2 from Zane Bitter 2011-07-22 11:36:28 EDT --- Updated files: SRPM: http://zaneb.fedorapeople.org/libvirt-qmf-0.3.0-1/libvirt-qmf-0.3.0-1.8d0b22.fc15.src.rpm Spec: http://zaneb.fedorapeople.org/libvirt-qmf-0.3.0-1/libvirt-qmf-0.3.0-1.8d0b22.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723991 Jaroslav Reznik changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Jaroslav Reznik 2011-07-22 11:56:53 EDT --- Thanks Zane, looks ok for me, just one thing - we should probably also Provide libvirt-qpid (in case something depends on it). It's not he must and I'm not sure if anything is using libvirt-qpid at all now. For upgrade paths Obsoletes are ok. http://fedoraproject.org/wiki/Upgrade_paths_—_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F Otherwise APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722993] Review Request: kate - Advanced Text Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722993 Jaroslav Reznik changed: What|Removed |Added Status|NEW |ASSIGNED CC||jrez...@redhat.com AssignedTo|nob...@fedoraproject.org|jrez...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724878] Review Request: TexStudio - A feature-rich editor for LaTeX documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724878 Martin Gieseking changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #1 from Martin Gieseking 2011-07-22 12:06:32 EDT --- Hannes, here are some initial comments: - Please use the original spelling "TeXstudio" in the %description. - The tarball bundles a couple of libraries: * hunspell (present in Fedora) * qtsingleapplication (present in Fedora) * qcodeedit (not present in Fedora) As linking bundled libraries is not permitted in Fedora, you have to patch the sources so that the separately packaged libraries are used. If this is not possible due to some reason, you might want to ask FPC for a bundled library exception. http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries - The license of TeXstudio is GPLv2+, the bundled qtsingleapplication is GPLv3. If you get a bundled library exception, the license of the binary would be GPLv3. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723991 --- Comment #4 from Zane Bitter 2011-07-22 12:15:15 EDT --- Thanks Jaroslav. After some discussion on IRC, we have decided not to Provide libvirt-qpid. Since libvirt-qmf is not backward compatible, now seems like the best time to provide a clean break. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722812] Review Request: worker - X11 File manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722812 --- Comment #7 from Martin Gieseking 2011-07-22 12:19:57 EDT --- Nathan, have you already been sponsored or aren't you interested in submitting this package any longer? I just noticed you removed the FE-NEEDSPONSOR blocker but can't find you in the packager group yet. If you don't want to join the group any longer, please close this ticket as NOTABUG. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723991 Zane Bitter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Zane Bitter 2011-07-22 12:21:55 EDT --- New Package SCM Request === Package Name: libvirt-qmf Short Description: matahari agent for libvirt Owners: zaneb Branches: InitialCC: matahari-maint -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722812] Review Request: worker - X11 File manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722812 --- Comment #8 from Nathan Owe 2011-07-22 12:30:51 EDT --- Thanks for asking. It seems that lemenkov is going to review my other package review and sponsor me as well http://bugzilla.redhat.com/show_bug.cgi?id=724859 I am currently correcting the issues in the package as mentioned. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723991 --- Comment #6 from Jon Ciesla 2011-07-22 12:32:28 EDT --- Git done (by process-git-requests). Ignored InitialCC, not a valid FAS account. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722812] Review Request: worker - X11 File manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722812 Martin Gieseking changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) --- Comment #9 from Martin Gieseking 2011-07-22 12:47:05 EDT --- OK, thanks for the clarification. In this case I readd the FE-NEEDSPONSOR blocker. It should stay active until the sponsoring process is finished because this prevents a premature approval of the package. Peter will possibly review this package as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720864] Review Request: gadmin-httpd - Apache GUI tool - First package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720864 Nathan Owe changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
