[Bug 732430] Review Request: perl-Classic-Perl - Selectively reinstate deleted Perl features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732430 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Classic-Perl-0.02-0.1. ||a.fcf17 Resolution||RAWHIDE Last Closed||2011-08-23 02:38:53 --- Comment #4 from Petr Pisar ppi...@redhat.com 2011-08-23 02:38:53 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730069] Review Request: perl-indirect - Lexically warn about using the indirect object syntax
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730069 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730069] Review Request: perl-indirect - Lexically warn about using the indirect object syntax
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730069 --- Comment #3 from Iain Arnell iarn...@gmail.com 2011-08-23 02:44:01 EDT --- New Package SCM Request === Package Name: perl-indirect Short Description: Lexically warn about using the indirect object syntax Owners: iarnell Branches: f14 f15 f16 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730047] Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730047 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-08-23 02:58:27 EDT --- perl-Hash-FieldHash-0.10-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Hash-FieldHash-0.10-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730047] Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730047] Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730047 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-08-23 02:58:35 EDT --- perl-Hash-FieldHash-0.10-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Hash-FieldHash-0.10-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730047] Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730047 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-08-23 02:58:19 EDT --- perl-Hash-FieldHash-0.10-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Hash-FieldHash-0.10-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732636] New: Review Request: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=732636 Summary: Review Request: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: spec info here SRPM URL: srpm info here Description: Just like node.js' fs module, but it does an incremental back-off when EMFILE is encountered. Useful in asynchronous situations where one needs to try to open lots and lots of files. (npm dependency) $ rpmlint SPECS/nodejs-graceful-fs.spec SPECS/nodejs-graceful-fs.spec: W: no-%build-section SPECS/nodejs-graceful-fs.spec: W: invalid-url Source0: isaacs-node-graceful-fs-9d7cd98.tar.gz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint RPMS/noarch/nodejs-graceful-fs-1.0.0-1.fc15.noarch.rpm nodejs-graceful-fs.noarch: W: spelling-error %description -l en_US js - dis, ks, j nodejs-graceful-fs.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732636 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732636] Review Request: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732636 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562366] Review request: zinnia - online handwriting recognition system with machine learning
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562366 --- Comment #36 from Peng Wu p...@redhat.com 2011-08-23 03:27:15 EDT --- Package Change Request == Package Name: zinnia New Branches: el6 Owners: pwu InitialCC: liangsuilong i18n-team petersen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562366] Review request: zinnia - online handwriting recognition system with machine learning
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562366 Peng Wu p...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732639] Review Request: nodejs-slide-flow-control - A flow control library that fits in a slideshow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732639 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731980] Review Request: python-novaclient - Python API and CLI for OpenStack Nova
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731980 Mark McLoughlin mar...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-08-23 03:34:17 --- Comment #7 from Mark McLoughlin mar...@redhat.com 2011-08-23 03:34:17 EDT --- Built now in rawhide and f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707199] Review Request: openstack-nova - OpenStack Compute (nova)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707199 Bug 707199 depends on bug 731980, which changed state. Bug 731980 Summary: Review Request: python-novaclient - Python API and CLI for OpenStack Nova https://bugzilla.redhat.com/show_bug.cgi?id=731980 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732639] New: Review Request: nodejs-slide-flow-control - A flow control library that fits in a slideshow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nodejs-slide-flow-control - A flow control library that fits in a slideshow https://bugzilla.redhat.com/show_bug.cgi?id=732639 Summary: Review Request: nodejs-slide-flow-control - A flow control library that fits in a slideshow Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-slide-flow-control.spec SRPM URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-slide-flow-control-1.1.3-1.fc15.src.rpm Description: Provides simple, easy callbacks for node.js. $ rpmlint SPECS/nodejs-slide-flow-control.spec SPECS/nodejs-slide-flow-control.spec: W: no-%build-section SPECS/nodejs-slide-flow-control.spec: W: invalid-url Source0: isaacs-slide-flow-control-1.1.3-0-g53a6c97.tar.gz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint RPMS/noarch/nodejs-slide-flow-control-1.1.3-1.fc15.noarch.rpm nodejs-slide-flow-control.noarch: W: spelling-error Summary(en_US) slideshow - sideshow, slide show, slide-show nodejs-slide-flow-control.noarch: W: spelling-error %description -l en_US js - dis, ks, j nodejs-slide-flow-control.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 707199] Review Request: openstack-nova - OpenStack Compute (nova)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707199 Bug 707199 depends on bug 731966, which changed state. Bug 731966 Summary: Review Request: openstack-glance - OpenStack Image Service https://bugzilla.redhat.com/show_bug.cgi?id=731966 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731966] Review Request: openstack-glance - OpenStack Image Service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731966 Mark McLoughlin mar...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-08-23 03:34:02 --- Comment #14 from Mark McLoughlin mar...@redhat.com 2011-08-23 03:34:02 EDT --- Built now in rawhide and f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732639 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732643 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732643] Review Request: nodejs-rimraf - A deep deletion module for node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732643 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732643] New: Review Request: nodejs-rimraf - A deep deletion module for node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nodejs-rimraf - A deep deletion module for node.js https://bugzilla.redhat.com/show_bug.cgi?id=732643 Summary: Review Request: nodejs-rimraf - A deep deletion module for node.js Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-rimraf.spec SRPM URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-rimraf-1.0.3-1.fc15.src.rpm Description: A deep deletion module for node.js (like `rm -rf`). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732651] New: Review Request: sshpass - Non-interactive ssh authentication utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sshpass - Non-interactive ssh authentication utility https://bugzilla.redhat.com/show_bug.cgi?id=732651 Summary: Review Request: sshpass - Non-interactive ssh authentication utility Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mcer...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.physics.muni.cz/~cermak/sshpass/sshpass.spec SRPM URL: http://www.physics.muni.cz/~cermak/sshpass/sshpass-1.05-1.fc15.src.rpm Description: Hello, please review this package submission for me. It will help me developing a handy rh internal tool. This package is already included in Debian, but not yet in Fedora. Thanks. Sshpass is a tool for non-interactively performing password authentication with SSH's so called interactive keyboard password authentication. Most user should use SSH's more secure public key authentication instead. $ rpmlint sshpass.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint sshpass-1.05-1.fc15.src.rpm sshpass.src: W: invalid-url URL: http://sshpass.sourceforge.net HTTP Error 403: Forbidden sshpass.src: W: invalid-url Source0: http://downloads.sourceforge.net/sshpass/sshpass-1.05.tar.gz urlopen error [Errno -2] Name or service not known 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint sshpass-1.05-1.fc15.x86_64.rpm sshpass.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net HTTP Error 403: Forbidden 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732650 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732650] Review Request: nodejs-proto-list - A list of objects bound by prototype chain
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732650 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732650] New: Review Request: nodejs-proto-list - A list of objects bound by prototype chain
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nodejs-proto-list - A list of objects bound by prototype chain https://bugzilla.redhat.com/show_bug.cgi?id=732650 Summary: Review Request: nodejs-proto-list - A list of objects bound by prototype chain Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-proto-list.spec SRPM URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-proto-list-1.0.0-1.fc15.src.rpm Description: A list of objects bound by prototype chain. Used for the Node.js package manager (npm) configuration. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732650] Review Request: nodejs-proto-list - A list of objects bound by prototype chain
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732650 --- Comment #1 from T.C. Hollingsworth tchollingswo...@gmail.com 2011-08-23 04:20:47 EDT --- $ rpmlint SPECS/nodejs-proto-list.spec SPECS/nodejs-proto-list.spec: W: no-%build-section SPECS/nodejs-proto-list.spec: W: invalid-url Source0: isaacs-proto-list-1.0.0-0-ge1f8f25.tar.gz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint RPMS/noarch/nodejs-proto-list-1.0.0-1.fc15.noarch.rpm nodejs-proto-list.noarch: W: spelling-error %description -l en_US js - dis, ks, j nodejs-proto-list.noarch: W: spelling-error %description -l en_US npm - pm, rpm, ppm nodejs-proto-list.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732655] New: Review Request: nodejs-ini - An INI parser/serializer for node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nodejs-ini - An INI parser/serializer for node.js https://bugzilla.redhat.com/show_bug.cgi?id=732655 Summary: Review Request: nodejs-ini - An INI parser/serializer for node.js Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-ini.spec SRPM URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-ini-1.0.0-1.fc15.src.rpm Description: An INI file parser and serializer for node.js. (the last npm dependency) $ rpmlint SRPMS/nodejs-ini-1.0.0-1.fc15.src.rpm nodejs-ini.src: W: spelling-error Summary(en_US) serializer - serialize, serializes, serialized nodejs-ini.src: W: spelling-error Summary(en_US) js - dis, ks, j nodejs-ini.src: W: spelling-error %description -l en_US serializer - serialize, serializes, serialized nodejs-ini.src: W: spelling-error %description -l en_US js - dis, ks, j nodejs-ini.src: W: no-%build-section nodejs-ini.src: W: invalid-url Source0: isaacs-ini-1.0.0-0-gbad4c06.tar.gz 1 packages and 0 specfiles checked; 0 errors, 6 warnings. $ rpmlint RPMS/noarch/nodejs-ini-1.0.0-1.fc15.noarch.rpm nodejs-ini.noarch: W: spelling-error Summary(en_US) serializer - serialize, serializes, serialized nodejs-ini.noarch: W: spelling-error Summary(en_US) js - dis, ks, j nodejs-ini.noarch: W: spelling-error %description -l en_US serializer - serialize, serializes, serialized nodejs-ini.noarch: W: spelling-error %description -l en_US js - dis, ks, j nodejs-ini.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732655 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732655] Review Request: nodejs-ini - An INI parser/serializer for node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732655 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732651 Martin Cermak mcer...@redhat.com changed: What|Removed |Added Blocks||710081 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732660 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732660] Review Request: nodejs-which - A JavaScript implementation of the 'which' command
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732660 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs) --- Comment #1 from T.C. Hollingsworth tchollingswo...@gmail.com 2011-08-23 04:50:19 EDT --- $ rpmlint SPECS/nodejs-which.spec SPECS/nodejs-which.spec: W: no-%build-section SPECS/nodejs-which.spec: W: invalid-url Source0: isaacs-node-which-1.0.0-0-g3a6bbd8.tar.gz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint RPMS/noarch/nodejs-which-1.0.0-1.fc15.noarch.rpm nodejs-which.noarch: W: only-non-binary-in-usr-lib nodejs-which.noarch: W: no-manual-page-for-binary which.nodejs 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732660] New: Review Request: nodejs-which - A JavaScript implementation of the 'which' command
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: nodejs-which - A JavaScript implementation of the 'which' command https://bugzilla.redhat.com/show_bug.cgi?id=732660 Summary: Review Request: nodejs-which - A JavaScript implementation of the 'which' command Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-which.spec SRPM URL: http://www.u.arizona.edu/~tchol/fedora/nodejs-which-1.0.0-1.fc15.src.rpm Description: A JavaScript implementation of the 'which' command. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732651 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731519] Review Request: spacenavd - A free, compatible alternative for 3Dconnexion's input drivers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731519 Jóhann B. Guðmundsson johan...@hi.is changed: What|Removed |Added CC||johan...@hi.is --- Comment #9 from Jóhann B. Guðmundsson johan...@hi.is 2011-08-23 05:42:09 EDT --- Nope not really (In reply to comment #8) Thanks! It's funny. I just finished trying out a systemd based version of my package based on Lennart's input. I like the StandardError on yours so I'll definitely use that. As far as the target, mulit-user would work but I chose graphical since there is really no use for this outside of a graphical environment. Is there a reason to choose multi-user that I'm not aware of? Not really the graphical target pulls in the multi user one but you are right we really should tie desktop only service to the graphical.target ( or create a specific desktop target for that). I also noticed spacenavd could be started in a non daemon mode if you need/want a unit file for that this should suffice.. [Unit] Description=3Dconnexion Input Devices Userspace Driver After=syslog.target [Service] ExecStart=/usr/bin/spacenavd -d StandardError=syslog [Install] WantedBy=graphical.target -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732651
--- Comment #1 from Petr Pisar ppi...@redhat.com 2011-08-23 05:48:06 EDT ---
Formal notice: Reports in Package Review component should stick on review
template. I.e. spec URL, SPRM, URL, and Description. Additional text should
follow after these three items.
Source tar ball is original. Ok.
TODO: Uppercase `ssh' in Summary if this tool works (or should work) with other
SSH implementations providing SSH client under different name than `ssh'.
FIXME: COPYING delivers GPLv2 and main.c states GPLv2+, but AUTHORS says GPLv2
only. Correct License tag or ask upstream for clarification.
TODO: Normalize home page URL. I.e. append slash.
TODO: Correct spelling in Description. Namely leading word `Sshpass' is name of
the tool and the tool, package, and even project is called `sshpass'. You can
remove the beginning completely (Sshpass is a) to obey orthographic rules.
Remove the abbreviated possession 's from SSH's as it can be used only to
possess to life entities. The `SSH' becomes attribute automatically per English
syntax rules.
TODO: Add %{?_smp_mflags} argument to `make' command to utilize parallel
building, if the Makefile is not broken. (I know there is only one source file
now, but it can help if upstream decides to use more source files.)
TODO: Remove useless %defattr macro in %files section as this is implicit.
FIX: Package as documentation (macro %doc) files: AUTHORS, ChangeLog, NEWS.
$ rpmlint sshpass.spec ../SRPMS/sshpass-1.05-1.fc15.src.rpm
../RPMS/x86_64/sshpass-*
sshpass-debuginfo.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net
HTTP Error 403: Forbidden
sshpass-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/sshpass-1.05/main.c
sshpass.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net HTTP Error
403: Forbidden
3 packages and 1 specfiles checked; 1 errors, 2 warnings.
TODO: Notify upstream to fix FSF address. You can link to
http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
rpmlint Ok.
$ rpm -q -lv -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm
-rwxr-xr-x1 rootroot11192 srp 23 11:35
/usr/bin/sshpass
-rw-r--r--1 rootroot 2192 srp 23 11:35
/usr/share/man/man1/sshpass.1.gz
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm |sort
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6()(64bit)
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(PayloadIsXz) = 5.2-1
rtld(GNU_HASH)
Binary requires Ok.
$ rpm -q --provides -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm |sort
sshpass(x86-64) = 1.05-1.fc15
sshpass = 1.05-1.fc15
Binary provides Ok.
Binary dependencies resolvable. Ok.
Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3294476). Ok.
Otherwise package is in line with Fedora packaging guidelines.
Please correct all `FIX' prefixed issues, consider fixing `TODO' prefixed items
and provide new spec file.
Resolution: Package NOT approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 690728] Review Request: Nitrate - A test case management system written in Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690728 --- Comment #56 from Yuguang Wang yuw...@redhat.com 2011-08-23 06:47:02 EDT --- Package updated: https://fedorahosted.org/nitrate/browser/trunk/nitrate/nitrate.spec https://fedorahosted.org/releases/n/i/nitrate/nitrate-3.3.5-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732598] Review Request: nodejs-minimatch - JavaScript glob matcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732598 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732585] Review Request: nodejs-nopt - Node.js option parsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732585 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732655] Review Request: nodejs-ini - An INI parser/serializer for node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732655 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732643] Review Request: nodejs-rimraf - A deep deletion module for node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732643 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732583] Review Request: nodejs-abbrev - Abbreviation calculator for Node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732583 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732650] Review Request: nodejs-proto-list - A list of objects bound by prototype chain
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732650 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732660] Review Request: nodejs-which - A JavaScript implementation of the 'which' command
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732660 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732579] Review Request: nodejs-semver - The semantic versioner for npm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732579 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732636] Review Request: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732636 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732590] Review Request: nodejs-uuid - RFC4122v4 UUID generator for Node.js
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732590 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732639] Review Request: nodejs-slide-flow-control - A flow control library that fits in a slideshow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732639 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732597] Review Request: nodejs-lru-cache - A cache object that deletes the least recently used items
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732597 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||732704 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732704] Review Request: npm - Node.js Package Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732704 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||732552(nodejs), 732660, ||732655, 732650, 732643, ||732639, 732636, 732598, ||732597, 732590, 732585, ||732583, 732579 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732704] New: Review Request: npm - Node.js Package Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: npm - Node.js Package Manager https://bugzilla.redhat.com/show_bug.cgi?id=732704 Summary: Review Request: npm - Node.js Package Manager Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tchollingswo...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.u.arizona.edu/~tchol/fedora/npm.spec SRPM URL: http://www.u.arizona.edu/~tchol/fedora/npm-1.0.26-1.fc15.src.rpm Description: npm is a package manager for node.js. You can use it to install and publish your node programs. It manages dependencies and does other cool stuff. $ rpmlint SPECS/npm.spec SPECS/npm.spec: W: no-%build-section SPECS/npm.spec: W: invalid-url Source0: isaacs-npm-v1.0.26-0-g1f81f07.tar.gz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint RPMS/noarch/npm-1.0.26-1.fc15.noarch.rpm # NPM needs uncompressed copies of the man page for npm help to work npm.noarch: W: manpage-not-compressed gz /usr/lib/nodejs/npm/man1/* npm.noarch: W: spelling-error Summary(en_US) js - dis, ks, j npm.noarch: W: spelling-error %description -l en_US js - dis, ks, j npm.noarch: W: only-non-binary-in-usr-lib # works fine when installed npm.noarch: W: dangling-relative-symlink /usr/share/doc/npm-1.0.26/rm.md ./uninstall.md npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-folders.1.gz 138: warning: macro `Consider' not defined # works fine when installed npm.noarch: W: dangling-symlink /usr/bin/npm /usr/lib64/../lib/nodejs/npm/bin/npm.js npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-help-search.1.gz 4: warning: macro `SH' not defined npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-help-search.1.gz 15: warning: macro `P' not defined npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-help-search.1.gz 25: warning: macro `SS' not defined npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-help-search.1.gz 27: warning: macro `IP' not defined npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-global.1.gz 138: warning: macro `Consider' not defined 1 packages and 0 specfiles checked; 0 errors, 69 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 726131] Review Request: yourls - your own url shortening service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726131 --- Comment #12 from Martin Krizek mkri...@redhat.com 2011-08-23 07:41:01 EDT --- (In reply to comment #11) ... - Since the yourls archive doesn't contain a license file, ask upstream to add one to a future release. http://code.google.com/p/yourls/issues/detail?id=911 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732651
--- Comment #2 from Martin Cermak mcer...@redhat.com 2011-08-23 07:50:11 EDT
---
Formal notice: Reports in Package Review component should stick on review
template. I.e. spec URL, SPRM, URL, and Description. Additional text should
follow after these three items.
Source tar ball is original. Ok.
TODO: Uppercase `ssh' in Summary if this tool works (or should work) with
other SSH implementations providing SSH client under different name than
`ssh'.
Uppercased.
FIXME: COPYING delivers GPLv2 and main.c states GPLv2+, but AUTHORS says GPLv2
only. Correct License tag or ask upstream for clarification.
Changed licence in specfile to GPLv2.
TODO: Normalize home page URL. I.e. append slash.
Slash appended.
TODO: Correct spelling in Description. Namely leading word `Sshpass' is
name of
the tool and the tool, package, and even project is called `sshpass'. You can
remove the beginning completely (Sshpass is a) to obey orthographic rules.
Agreed. Removed.
Remove the abbreviated possession 's from SSH's as it can be used only to
possess to life entities. The `SSH' becomes attribute automatically per
English syntax rules.
Text slightly rewritten to satisfy this.
TODO: Add %{?_smp_mflags} argument to `make' command to utilize parallel
building, if the Makefile is not broken. (I know there is only one source file
now, but it can help if upstream decides to use more source files.)
Fixed.
TODO: Remove useless %defattr macro in %files section as this is implicit.
Removed.
FIX: Package as documentation (macro %doc) files: AUTHORS, ChangeLog, NEWS.
Added.
$ rpmlint sshpass.spec ../SRPMS/sshpass-1.05-1.fc15.src.rpm
../RPMS/x86_64/sshpass-*
sshpass-debuginfo.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net
HTTP Error 403: Forbidden
sshpass-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/sshpass-1.05/main.c
sshpass.x86_64: W: invalid-url URL: http://sshpass.sourceforge.net HTTP Error
403: Forbidden
3 packages and 1 specfiles checked; 1 errors, 2 warnings.
TODO: Notify upstream to fix FSF address. You can link to
http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
rpmlint Ok.
$ rpm -q -lv -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm
-rwxr-xr-x1 rootroot11192 srp 23 11:35
/usr/bin/sshpass
-rw-r--r--1 rootroot 2192 srp 23 11:35
/usr/share/man/man1/sshpass.1.gz
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm |sort
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6()(64bit)
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(PayloadIsXz) = 5.2-1
rtld(GNU_HASH)
Binary requires Ok.
$ rpm -q --provides -p ../RPMS/x86_64/sshpass-1.05-1.fc15.x86_64.rpm |sort
sshpass(x86-64) = 1.05-1.fc15
sshpass = 1.05-1.fc15
Binary provides Ok.
Binary dependencies resolvable. Ok.
Package builds in F17
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3294476). Ok.
Otherwise package is in line with Fedora packaging guidelines.
Please correct all `FIX' prefixed issues, consider fixing `TODO' prefixed
items and provide new spec file.
Resolution: Package NOT approved.
I belive all mentioned issues are addressed in the specfile now. Please, review
again. Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715180] Review Request: FreeMat - A free environment for rapid engineering, scientific prototyping and data processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715180 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Depends on|727301 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715180] Review Request: FreeMat - A free environment for rapid engineering, scientific prototyping and data processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715180 --- Comment #28 from Rich Mattes richmat...@gmail.com 2011-08-23 08:08:27 EDT --- My apologies for not posting earlier, I just got back from a two week vacation. I've just built it and tested FreeMat in an F16 alpha virtual machine, and some serious issues remain: 1. You can't relocate blas.ini without telling FreeMat where to find it in its new place. There's a patch in the Mandriva package that handles this: basically you have to edit libs/libMath/libDynBlas/blas_dyn_link.cpp and change the location of the ini file in the BlasWrapper::LoadLib function. 2. The .desktop file is broken. It's trying to execute freemat, not FreeMat. Less important, but something to look into: there's no icon for the .desktop file. 3. FreeMat fails to start for me (F16 alpha TC5, build located at [1]). I will try rebuilding it locally and re-installing, but the koji build gives me the following output: $ FreeMat QGtkStyle was unable to detect the current GTK+ theme. RESCAN!!! Segmentation fault (core dumped) The backtrace shows that it's crashing somewhere inside libQtGui.so.4. Have you tried running this program on an F16 system at all? [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=3293825 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 726131] Review Request: yourls - your own url shortening service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726131 --- Comment #13 from Martin Krizek mkri...@redhat.com 2011-08-23 08:06:12 EDT --- (In reply to comment #11) Here's the formal review. The package is almost ready. There are two things left that need to be fixed: - The package contains several files under different licenses, so we have a multiple licensing scenario here: * yourls files: GPL+ * GeoIP files: LGPLv2+ * JQuery files: MIT or GPLv2 = the License field should look like this: GPL+ and LGPLv2+ and (MIT or GPLv2) Also, add a comment about the multiple licensing scenario and the corresponding files above the License field. - Some of the doc files have DOS line endings (see rpmlint output). You can fix this by adding the following loop to the %prep section: for f in *.txt; do sed 's/\r//' $f $f.new touch -r $f $f.new mv $f.new $f done Fixed: $ rpmlint rpmbuild/SPECS/yourls.spec rpmbuild/SRPMS/yourls-1.5-4.fc15.src.rpm rpmbuild/RPMS/noarch/yourls-1.5-4.fc15.noarch.rpm rpmbuild/SPECS/yourls.spec: W: invalid-url Source0: http://yourls.googlecode.com/files/yourls-1.5.zip HTTP Error 404: Not Found yourls.src: W: invalid-url Source0: http://yourls.googlecode.com/files/yourls-1.5.zip HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Spec URL: http://mkrizek.fedorapeople.org/yourls.spec SRPM URL: http://mkrizek.fedorapeople.org/yourls-1.5-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732651] Review Request: sshpass - Non-interactive ssh authentication utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732651 --- Comment #3 from Martin Cermak mcer...@redhat.com 2011-08-23 08:15:35 EDT --- FIXME: COPYING delivers GPLv2 and main.c states GPLv2+, but AUTHORS says GPLv2 only. Correct License tag or ask upstream for clarification. Changed licence in specfile to GPLv2. Upstream notified. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 715180] Review Request: FreeMat - A free environment for rapid engineering, scientific prototyping and data processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=715180 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #29 from Ankur Sinha sanjay.an...@gmail.com 2011-08-23 08:15:53 EDT --- (In reply to comment #28) My apologies for not posting earlier, I just got back from a two week vacation. I've just built it and tested FreeMat in an F16 alpha virtual machine, and some serious issues remain: 1. You can't relocate blas.ini without telling FreeMat where to find it in its new place. There's a patch in the Mandriva package that handles this: basically you have to edit libs/libMath/libDynBlas/blas_dyn_link.cpp and change the location of the ini file in the BlasWrapper::LoadLib function. Hrm, I had referred to the mandriva patches. I thought I had made this change. I'll go recheck. 2. The .desktop file is broken. It's trying to execute freemat, not FreeMat. Less important, but something to look into: there's no icon for the .desktop file. Corrected. I'll also submit a fresh desktop file to the upstream tracker. 3. FreeMat fails to start for me (F16 alpha TC5, build located at [1]). I will try rebuilding it locally and re-installing, but the koji build gives me the following output: $ FreeMat QGtkStyle was unable to detect the current GTK+ theme. RESCAN!!! Segmentation fault (core dumped) The backtrace shows that it's crashing somewhere inside libQtGui.so.4. Have you tried running this program on an F16 system at all? [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=3293825 I'll have to report this issue upstream. I haven't had the chance of testing the f16 rpm, I won't get my f16 system up until later this week. Thanks for the prompt comment. I've cancelled the cvs request. I'll request it again once the issues are fixed. Regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732737] New: Review Request: python-signalfd - Python bindings to the Linux signalfd library/system call
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-signalfd - Python bindings to the Linux signalfd library/system call https://bugzilla.redhat.com/show_bug.cgi?id=732737 Summary: Review Request: python-signalfd - Python bindings to the Linux signalfd library/system call Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jla...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://jlaska.fedorapeople.org/repos/review/python-signalfd.spec SRPM URL: http://jlaska.fedorapeople.org/repos/review/python-signalfd-0.1-1.fc15.src.rpm Description: Provides python bindings for sigprocmask(2) and signalfd(2) == rpmlint output == python-signalfd.src: W: spelling-error %description -l en_US sigprocmask python-signalfd.x86_64: W: spelling-error %description -l en_US sigprocmask 3 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562366] Review request: zinnia - online handwriting recognition system with machine learning
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562366 --- Comment #37 from Jon Ciesla l...@jcomserv.net 2011-08-23 09:01:12 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 --- Comment #14 from Jon Ciesla l...@jcomserv.net 2011-08-23 09:05:38 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730069] Review Request: perl-indirect - Lexically warn about using the indirect object syntax
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730069 --- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-08-23 09:08:58 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #5 from Jon Ciesla l...@jcomserv.net 2011-08-23 09:10:28 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730047] Review Request: perl-Hash-FieldHash - Lightweight field hash implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-08-23 09:32:43 EDT --- perl-Hash-FieldHash-0.10-2.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 Matěj Cepl mc...@redhat.com changed: What|Removed |Added Depends on||732213 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226505] Merge Review: ttcp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226505
Ondrej Vasik ova...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Ondrej Vasik ova...@redhat.com 2011-08-23 09:43:42 EDT ---
[WARN] MUST: rpmlint must be run on the source rpm and all binary rpms the
build
produces. The output should be posted in the review.
$ rpmlint ttcp-1.12-23.fc17.src.rpm i686/ttcp-1.12-23.fc17.i686.rpm ttcp.spec
ttcp.i686: W: manual-page-warning /usr/share/man/man1/ttcp.1.gz 55: warning:
`Ex' not defined
ttcp.i686: W: manual-page-warning /usr/share/man/man1/ttcp.1.gz 57: warning:
`Ee' not defined
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Old manpage contains a few occurences of probably deprecated manpage macros.
Probably could be fixed based on
http://www.catb.org/~esr/doclifter/prepatch/ttcp.1.patch
[OK] MUST: The package must be named according to the Package Naming
Guidelines.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines.
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
$ sha256sum ttcp.c ttcp.c.1
e630a95788efacfee226dff3550e58ed908987ef96817efc8ad4862657a60c3b ttcp.c
e630a95788efacfee226dff3550e58ed908987ef96817efc8ad4862657a60c3b ttcp.c.1
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[OK] MUST: All build dependencies must be listed in BuildRequires.
[N/A] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[N/A] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: Large documentation files must go in a -doc subpackage.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[N/A] MUST: Header files must be in a -devel package.
[N/A] MUST: Static libraries must be in a -static package.
[N/A] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[N/A] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[N/A] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[N/A] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[N/A] MUST: Packages must not own files or directories already owned by other
packages.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
[N/A] SHOULD: If the source package does not include license text(s) as a
separate file from
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 Matěj Cepl mc...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mc...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731898] Review Request: opendkim - DKIM library and milter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731898 Matt Domsch matt_dom...@dell.com changed: What|Removed |Added Flag||fedora-review? --- Comment #19 from Matt Domsch matt_dom...@dell.com 2011-08-23 09:47:26 EDT --- pkgconfig should be a BuildRequires, not a Requires. http://fedoraproject.org/wiki/Packaging:UsersAndGroups notes need to Requires(pre): shadow-utils also. This also notes that the user and group should not be removed on uninstall. (see the %preun section) I'll start the formal review next. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705363] Review Request: spacewalk-web - Spacewalk Web site packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705363 --- Comment #10 from Miroslav Suchý msu...@redhat.com 2011-08-23 09:54:30 EDT --- SPEC: http://miroslav.suchy.cz/fedora/spacewalk-web/spacewalk-web.spec SRPM: http://miroslav.suchy.cz/fedora/spacewalk-web/spacewalk-web-1.6.16-1.fc15.src.rpm I fixed description and discussed in upstream the PXT::Config problem and we decided to leave it only in spacewalk-base-minimal as spacewalk-pxt require it anyway in these days. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678728] Review Request: synce-connector - Connection framework and dccm-implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678728 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE Last Closed||2011-08-23 09:58:19 --- Comment #15 from Andreas Bierfert andreas.bierf...@lowlatency.de 2011-08-23 09:58:19 EDT --- Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732758] Review Request: perl-SOAP-Transport-TCP - SOAP::Transport::TCP Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732758 --- Comment #1 from Petr Sabata psab...@redhat.com 2011-08-23 10:07:21 EDT --- This package is needed by the new SOAP::Lite 0.714. They require each other, hence this package uses the %perl_bootstrap macro. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732758] New: Review Request: perl-SOAP-Transport-TCP - SOAP::Transport::TCP Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-SOAP-Transport-TCP - SOAP::Transport::TCP Perl module https://bugzilla.redhat.com/show_bug.cgi?id=732758 Summary: Review Request: perl-SOAP-Transport-TCP - SOAP::Transport::TCP Perl module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: psab...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://psabata.fedorapeople.org/pkgs/perl-SOAP-Transport-TCP/perl-SOAP-Transport-TCP.spec SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-SOAP-Transport-TCP/perl-SOAP-Transport-TCP-0.715-1.fc15.src.rpm Description: The classes provided by this module implement direct TCP/IP communications methods for both clients and servers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731898] Review Request: opendkim - DKIM library and milter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731898 --- Comment #20 from Steve Jenkins st...@stevejenkins.com 2011-08-23 10:13:22 EDT --- (In reply to comment #19) pkgconfig should be a BuildRequires, not a Requires. That's what I get for staying up late. :) Fixed. http://fedoraproject.org/wiki/Packaging:UsersAndGroups notes need to Requires(pre): shadow-utils also. Added. This also notes that the user and group should not be removed on uninstall. (see the %preun section) Removed from %preun. I'll start the formal review next. Party on! :) New SRPM and spec: http://packages.stevejenkins.com/opendkim/2.4.2/working/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226359] Merge Review: rdist
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226359 --- Comment #3 from Lukáš Nykrýn lnyk...@redhat.com 2011-08-23 10:18:08 EDT --- %clean section and rm at the start of %install section are no longer necessary. So it will maybe good to remove them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731898] Review Request: opendkim - DKIM library and milter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731898
--- Comment #21 from Matt Domsch matt_dom...@dell.com 2011-08-23 10:19:35 EDT
---
Review:
* rpmlint: see below
* name: OK
* spec file name matches: OK
* packaging guidelines: OK
* licensed: OK
* license tag: change to BSD and Sendmail
* license in %doc: OK
* english spec: OK
* legible spec: OK
* sources match upstream: OK
* builds on one arch: OK
* exclusivearch?: OK
* BuildRequires: OK (after fixing pkgconfig noted above)
* locales: OK (N/A)
* shared libs invoke ldconfig: OK
* no system libs: OK
* relocatable?: OK (N/A)
* owns dirs: OK
* no files more than once: OK
* permissions: (re-check)
* macros: OK
* code or content: OK
* large docs: OK (N/A)
* docs don't affect runtime: OK
* headers in -devel: OK
* static libs in -static: OK (N/A)
* .so in -devel: OK
* -devel requires fully versioned base package: Needs to be fixed
* No .la files: OK
* desktop file: OK (N/A)
* directory ownership: OK
* UTF-8 filenames: OK
$ rpmlint SPECS/opendkim.spec SRPMS/opendkim-2.4.2-3.fc14.src.rpm RPMS/x86_64/*
SPECS/opendkim.spec:67: W: macro-in-comment %{_docdir}
SPECS/opendkim.spec:67: W: macro-in-comment %{name}
SPECS/opendkim.spec:67: W: macro-in-comment %{version}
SPECS/opendkim.spec:67: W: macro-in-comment %{name}
SPECS/opendkim.spec:75: W: macro-in-comment %{_docdir}
SPECS/opendkim.spec:75: W: macro-in-comment %{name}
SPECS/opendkim.spec:75: W: macro-in-comment %{version}
SPECS/opendkim.spec:107: W: macro-in-comment %{_localstatedir}
SPECS/opendkim.spec:107: W: macro-in-comment %{name}
SPECS/opendkim.spec:128: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:128: W: macro-in-comment %{name}
SPECS/opendkim.spec:133: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:133: W: macro-in-comment %{name}
SPECS/opendkim.spec:137: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:137: W: macro-in-comment %{name}
SPECS/opendkim.spec:140: W: macro-in-comment %{_sysconfdir}
SPECS/opendkim.spec:140: W: macro-in-comment %{name}
opendkim.src: W: spelling-error %description -l en_US sendmail - send mail,
send-mail, Sendai
opendkim.src:67: W: macro-in-comment %{_docdir}
opendkim.src:67: W: macro-in-comment %{name}
opendkim.src:67: W: macro-in-comment %{version}
opendkim.src:67: W: macro-in-comment %{name}
opendkim.src:75: W: macro-in-comment %{_docdir}
opendkim.src:75: W: macro-in-comment %{name}
opendkim.src:75: W: macro-in-comment %{version}
opendkim.src:107: W: macro-in-comment %{_localstatedir}
opendkim.src:107: W: macro-in-comment %{name}
opendkim.src:128: W: macro-in-comment %{_sysconfdir}
opendkim.src:128: W: macro-in-comment %{name}
opendkim.src:133: W: macro-in-comment %{_sysconfdir}
opendkim.src:133: W: macro-in-comment %{name}
opendkim.src:137: W: macro-in-comment %{_sysconfdir}
opendkim.src:137: W: macro-in-comment %{name}
opendkim.src:140: W: macro-in-comment %{_sysconfdir}
opendkim.src:140: W: macro-in-comment %{name}
libopendkim.x86_64: E: postin-without-ldconfig /usr/lib64/libopendkim.so.5.0.1
libopendkim.x86_64: E: non-empty-%post /sbin/ldconfig
libopendkim-devel.x86_64: W: no-version-dependency-on
libopendkim/libopendkim-libs/liblibopendkim 2.4.2
opendkim.x86_64: W: spelling-error %description -l en_US sendmail - send mail,
send-mail, Sendai
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-genzone
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-stats
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/sbin/opendkim
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-testkey
['/usr/lib64']
opendkim.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/opendkim-testadsp
['/usr/lib64']
opendkim.x86_64: W: non-standard-uid /etc/opendkim/keys opendkim
opendkim.x86_64: W: non-standard-gid /etc/opendkim/keys opendkim
opendkim.x86_64: W: non-standard-uid /var/run/opendkim opendkim
opendkim.x86_64: W: non-standard-gid /var/run/opendkim opendkim
opendkim.x86_64: W: dangerous-command-in-%preun userdel
opendkim.x86_64: W: service-default-enabled /etc/rc.d/init.d/opendkim
opendkim.x86_64: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/opendkim
opendkim-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L
opendkim-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/opendkim-2.4.2 0775L
5 packages and 1 specfiles checked; 9 errors, 44 warnings.
The above macro-in-comment bits can be solved using %%{_foo} if necessary in
the comment sections.
Ignore spelling error.
postin-without-ldconfig and non-empty-post are odd; worth looking into, but
they should be OK...
no-version-dependency: caught above on review, needs fixing.
rpath: ugh. Needs fixing.
http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath
non-standard-uid/gid: OK.
dangerous command userdel: caught above, needs fixing.
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 --- Comment #4 from Matěj Cepl mc...@redhat.com 2011-08-23 10:38:44 EDT --- Built on Fedora 16 with other v8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732552
--- Comment #3 from Matěj Cepl mc...@redhat.com 2011-08-23 10:37:09 EDT ---
+ MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ./nodejs-0.4.11-1.fc15.src.rpm RPMS/*/nodejs*.rpm\
|grep -v spelling-error|grep -v '^\s*$'
nodejs-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 13 warnings.
+ MUST: The package must be named according to the Package Naming Guidelines.
There is a conflict with already existing package node, so rename is allowed.
+ MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
? MUST: The package must meet the Packaging Guidelines.
* I don't know if it is my English as a second language or what, but I don't
understand this
# some partially generated docs in the tarball gum up the works
rm -rf doc/api/api
What's going on?
* mv doc/nodejs.1.gz %{buildroot}%{_mandir}/man1/
please don't mv, do rather cp -p ... instead. There could be an issue with
SELinux labels, ownerships etc. corrupted.
* failing tests
# Fails 5 tests ATM
# known upstream: https://github.com/joyent/node/pull/1021
##%%check
##cd build
##ctest
Not reason to break the review, but couldn't you just switch off just the
specific tests (renaming the file with test should help or something)?
* %doc %{_mandir}/man1/nodejs.1.gz
No, it is not %doc. %doc should be README.md, LICENSE etc., not manpage.
+ MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
+ MUST: The License field in the package spec file must match the actual
license.
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
+ MUST: The spec file must be written in American English.
+ MUST: The spec file for the package MUST be legible.
+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
MD5SUM: ac4c3eaa0667d5e3eacf56fd26a4eadc
+ MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
+ MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
Isn't this nodejs still dependent on v8 from the repo outside of Fedora? This
package review is blocked by bug 732213 where we need to resolve this mess.
+ MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
no locales
+ MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
+ MUST: Packages must NOT bundle copies of system libraries.
+ MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
+ MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
+ MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
+ MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
+ MUST: Each package must consistently use macros.
+ MUST: The package must contain code, or permissable content.
+ MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
+ MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
+ MUST: Header files must
[Bug 732577] Review Request: c-icap - An icap server implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732577 --- Comment #1 from Nathan Owe ndowen...@gmail.com 2011-08-23 10:51:55 EDT --- *** Bug 732591 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732591] Review Request: c-icap - An icap server implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732591 Nathan Owe ndowen...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Last Closed||2011-08-23 10:51:55 --- Comment #1 from Nathan Owe ndowen...@gmail.com 2011-08-23 10:51:55 EDT --- Somehow package review request got double submitted. *** This bug has been marked as a duplicate of bug 732577 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-08-23 11:01:28 EDT --- perl-Digest-Perl-MD5-1.8-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Digest-Perl-MD5-1.8-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-08-23 11:02:08 EDT --- perl-Digest-Perl-MD5-1.8-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Digest-Perl-MD5-1.8-2.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-08-23 11:01:46 EDT --- perl-Digest-Perl-MD5-1.8-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Digest-Perl-MD5-1.8-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-08-23 11:01:58 EDT --- perl-Digest-Perl-MD5-1.8-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Digest-Perl-MD5-1.8-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-08-23 11:01:14 EDT --- perl-Digest-Perl-MD5-1.8-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Digest-Perl-MD5-1.8-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732484] Review Request: perl-Digest-Perl-MD5 - Perl implementation of Ron Rivest's MD5 Algorithm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732484 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-08-23 11:01:36 EDT --- perl-Digest-Perl-MD5-1.8-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Digest-Perl-MD5-1.8-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732552 --- Comment #5 from Matěj Cepl mc...@redhat.com 2011-08-23 11:12:41 EDT --- But in koji this doesn't build http://koji.fedoraproject.org/koji/taskinfo?taskID=3295369 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728956] Review Request: php-virt-control - PHP-based virtual machine controller tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728956 --- Comment #4 from Remi Collet fed...@famillecollet.com 2011-08-23 11:12:02 EDT --- Created attachment 519478 -- https://bugzilla.redhat.com/attachment.cgi?id=519478 Fix version check Same error with php-libvirt 0.4.4 The attached patched seems to solve this issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728956] Review Request: php-virt-control - PHP-based virtual machine controller tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728956 --- Comment #5 from Remi Collet fed...@famillecollet.com 2011-08-23 11:23:06 EDT --- I still not able to run this app. The INSTALL file provided is absolutely irrelevant (configure/make/install) Please provide an minimal howto. After filing the data/mysql_conn.php, I get a blank page. About packaging, data/mysql_conn.php must go to a subfolder of /etc/ and be tagged as %config. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731898] Review Request: opendkim - DKIM library and milter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731898 Todd Lyons tly...@ivenue.com changed: What|Removed |Added CC||tly...@ivenue.com --- Comment #22 from Todd Lyons tly...@ivenue.com 2011-08-23 11:21:51 EDT --- Matt, the OpenDKIM package builds its own libtool (./libtool built from m4/libtool.m4) and uses it by default. This package-provided libtool attempts to auto-detect system library paths and ends up deciding it's /lib and /usr/lib. Thus anything that links to /lib64 and /usr/lib64 (which opendkim does) will end up using rpath to add to the dynamic loader search path. In testing we found that this was only an issue on x86_64. That was the reason for the %ifarch logic around the %define LIBTOOL macro (because it works properly on i386 arch). Since we added BuildRequires: libtool to the spec file and know that libtool will always be present for the build for all arches, the %ifarch then could be dropped and a simple: %define LIBTOOL=LIBTOOL=`which libtool` will take care of finding /usr/bin/libtool, which has the rpaths hard coded to /lib64 and /usr/lib64 on x86_64. Then pass that to the Makefile by appending %LIBTOOL to %make and make install commands. If you do not pass that LIBTOOL override, it will use the ./libtool and screw up the rpaths. Without doing it this way, you get the rpath errors as above. Regards...Todd Lyons -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732552
--- Comment #6 from T.C. Hollingsworth tchollingswo...@gmail.com 2011-08-23
12:04:28 EDT ---
Thank you for taking this on, and all your other help!
(In reply to comment #3)
* I don't know if it is my English as a second language or what, but I don't
understand this
# some partially generated docs in the tarball gum up the works
rm -rf doc/api/api
What's going on?
Your English is fine, it's mine that leaves a little to be desired. ;-)
Upstream ships API docs in doc/api in Markdown format, which are turned into
HTML by make doc. Unfortunately, they also shipped partially generated ones
in doc/api/api, and make doc tries to convert those too, but fails because
they're not markdown. I rewrote that comment to be more clear.
* mv doc/nodejs.1.gz %{buildroot}%{_mandir}/man1/
please don't mv, do rather cp -p ... instead. There could be an issue with
SELinux labels, ownerships etc. corrupted.
Fixed.
* failing tests
# Fails 5 tests ATM
# known upstream: https://github.com/joyent/node/pull/1021
##%%check
##cd build
##ctest
Not reason to break the review, but couldn't you just switch off just the
specific tests (renaming the file with test should help or something)?
I have identified and disabled the broken tests and re-enabled %check.
* %doc %{_mandir}/man1/nodejs.1.gz
No, it is not %doc. %doc should be README.md, LICENSE etc., not manpage.
Fixed.
Isn't this nodejs still dependent on v8 from the repo outside of Fedora? This
package review is blocked by bug 732213 where we need to resolve this mess.
(In reply to comment #5)
But in koji this doesn't build
http://koji.fedoraproject.org/koji/taskinfo?taskID=3295369
Actually, it builds fine with the V8 currently in the main Fedora repo.
http-parser was breaking the build. When I force the bundled http-parser, it
builds fine on Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3295572
It also builds fine locally with the RPM you pushed to bodhi yesterday.
--
Spec: http://www.u.arizona.edu/~tchol/fedora/nodejs.spec
SRPM: http://www.u.arizona.edu/~tchol/fedora/nodejs-0.4.11-2.fc15.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719103] Review Request: mex - Media centre application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719103
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #2 from Volker Fröhlich volke...@gmx.at 2011-08-23 12:13:59 EDT
---
rpmlint mex-0.1.4-1.fc17.x86_64.rpm
mex.x86_64: W: spelling-error Summary(en_US) centre - center, cent re, cent-re
mex.x86_64: W: spelling-error %description -l en_US centre - center, cent re,
cent-re
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/40mex-recommended.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/100mex-debug.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/20mex-gnome-dvb.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/40mex-queue.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/00mex-search.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/20mex-tracker.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/20mex-upnp.so ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex-webremote
['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex ['/usr/lib64']
mex.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/mex/plugins/50mex-dbusinput.so ['/usr/lib64']
mex.x86_64: E: incorrect-fsf-address /usr/share/doc/mex-0.1.4/COPYING
mex.x86_64: E: postun-without-ldconfig /usr/lib64/libmex-0.2.so.0.0.0
mex.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmex-0.2.so
mex.x86_64: W: no-manual-page-for-binary mex-webremote
mex.x86_64: W: no-manual-page-for-binary mex-debug
mex.x86_64: W: no-manual-page-for-binary mex
Get rid of the rpaths. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath
Please contact the developer, so he can update the license file with the one up
to date. You may opt to correct the address in the package.
Libs in standard directories need an ldconfig run. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
You'll need a devel sub-package:
http://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
Installing files to /usr/share/icons, you need this scriptlet:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Use the name macro instead of mex.
Try to break the %configure line.
You can drop the defattr line. It's not necessary.
If you don't plan to go for EPEL5 or older, drop the clean section and the rm
in the install section. If you want to go for EPEL5, define the buildroot.
Be more specific in your file section. For instance: all binaries start with
%{name}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732737] Review Request: python-signalfd - Python bindings to the Linux signalfd library/system call
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732737 Douglas Schilling Landgraf dougsl...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dougsl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 708115] Review Request: python-atfork - Provides an API to register pre and post callbacks when forking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708115 Douglas Schilling Landgraf dougsl...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dougsl...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730888] Review Request: nagios-plugins-rhev - Nagios Plugin to monitor RHEV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730888 James Laska jla...@redhat.com changed: What|Removed |Added CC||jla...@redhat.com AssignedTo|nob...@fedoraproject.org|jla...@redhat.com --- Comment #1 from James Laska jla...@redhat.com 2011-08-23 12:43:44 EDT --- Taking ownership for package review ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 731898] Review Request: opendkim - DKIM library and milter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731898
--- Comment #23 from Steve Jenkins st...@stevejenkins.com 2011-08-23 12:50:54
EDT ---
(In reply to comment #21)
The above macro-in-comment bits can be solved using %%{_foo} if necessary in
the comment sections.
Those are from the comments that the echoed config file, so I want those
variables to be parsed. Is it OK to leave these warnings?
Ignore spelling error.
I awlays do.
postin-without-ldconfig and non-empty-post are odd; worth looking into, but
they should be OK...
You're right - from what I Googled on the subject, the postin-without-ldconfig
rpmlint error was benign in most cases. However, Google returned absolutely
ZERO results for rpmlint 'non-empty-post' or rpmlint 'non-empty-%post' Is
rmplint complaining that the output of that %post wasn't empty, when it
expected it to be?
Also, my rpmlint output isn't showing these errors (on an i686 FC box). I'm
running v1.2. Are you running a newer version?
no-version-dependency: caught above on review, needs fixing.
Is this something that needs to be fixed in the spec file or the upstream?
rpath: ugh. Needs fixing.
http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath
Mmmmyeeeahhh. Ugh. This is what the ifarch funkiness in the original
version of the spec file was for. Refer to Todd's comments above. I've added
the LIBTOOL stuff back in so that it forces the use of the system's libtool
instead of the one in the source.
non-standard-uid/gid: OK.
dangerous command userdel: caught above, needs fixing.
You must have grabbed the spec before I had a chance to upload that change
based on your feedback earlier this morning. That *should* be fixed, as I
removed the group and user delete.
service-default-enabled: needs fixing by patching initscript
missing-lsb-keyword: needs fixing by patching initscript
Got rid of the missing-lsb-keyword, but the service-default-enabled is still
hanging around. Can you give me a nudge toward what might be causing that?
non-standard-dir-perm: ignore, it's a bug in rpmlint. :-)
Freebie! Yay!
File permissions show /usr/share/doc/*/convert_keylist.sh is marked
executable.
In %install, chmod it 0644.
Fixed.
API documentation currently in /usr/share/doc/libopendkim-2.4.2/*.html should
only be in the -devel subpackage, not in both.
Looking in to this.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732419] Review Request: esteid-browser-plugin - Estonian ID card digital signing browser plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732419 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2011-08-23 13:30:58 EDT --- Thanks, looks good to me now. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732419] Review Request: esteid-browser-plugin - Estonian ID card digital signing browser plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732419 Kalev Lember kalevlem...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Kalev Lember kalevlem...@gmail.com 2011-08-23 13:47:12 EDT --- New Package SCM Request === Package Name: esteid-browser-plugin Short Description: Estonian ID card digital signing browser plugin Owners: kalev Branches: f14 f15 f16 InitialCC: sander85 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
