[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=748180 Peter Gordon changed: What|Removed |Added Status|ASSIGNED|NEW CC||pe...@thecodergeek.com AssignedTo|pe...@thecodergeek.com |nob...@fedoraproject.org Flag|fedora-review? | --- Comment #8 from Peter Gordon 2011-11-14 02:25:49 EST --- Ack, I'm sorry Christian. Stuff with family/friends/work has just kept cropping up and I've not had time to do this properly. I'll leave it open for another wanting QA-er to take care of. (I should have done this sooner, my apologies.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719908 Bohuslav Kabrda changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Bohuslav Kabrda 2011-11-14 02:02:25 EST --- Everything looks fine now, package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 746754] Review request: pdfcrack - A Password Recovery Tool for PDF-files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746754 pjp changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 746754] Review request: pdfcrack - A Password Recovery Tool for PDF-files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746754 --- Comment #27 from pjp 2011-11-14 00:04:14 EST --- New Package SCM Request === Package Name: pdfcrack Short Description: A password recovery tool for PDF files. Owners: pjp Branches: f14 f15 f16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753677] New: Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area https://bugzilla.redhat.com/show_bug.cgi?id=753677 Summary: Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: heday...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y.spec SRPM URL: www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y-0-0.1.src.rpm Description: This is the extension to remove accessibility from status area, rewritten for gnome 3.2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753676] New: Review Request: gnome-shell-extention-netspeed -an internet speed indicator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnome-shell-extention-netspeed -an internet speed indicator https://bugzilla.redhat.com/show_bug.cgi?id=753676 Summary: Review Request: gnome-shell-extention-netspeed -an internet speed indicator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: heday...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed.spec SRPM URL: http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed-0-0.1.src.rpm Description: This is a simple gnome-shell extension to display speed of internet and speed of each device (upload + download) separately as well -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 740846] Review Request: espresso - Extensible Simulation Package for Research on Soft matter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=740846 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||espresso-3.0.2-2.fc16 Resolution||ERRATA Last Closed||2011-11-13 19:50:07 --- Comment #17 from Fedora Update System 2011-11-13 19:50:07 EST --- espresso-3.0.2-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732205] Review Request: airsched - C++ Simulated Airline Schedule Manager Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732205 Fedora Update System changed: What|Removed |Added Fixed In Version|airsched-0.1.2-1.fc15 |airsched-0.1.2-1.fc16 --- Comment #21 from Fedora Update System 2011-11-13 19:51:00 EST --- airsched-0.1.2-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750461] Review Request: php-phpunit-PHP-Invoker - Utility class for invoking callables with a timeout
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750461 Fedora Update System changed: What|Removed |Added Fixed In Version|php-phpunit-PHP-Invoker-1.0 |php-phpunit-PHP-Invoker-1.0 |.0-3.fc16 |.0-3.fc15 --- Comment #11 from Fedora Update System 2011-11-13 19:51:30 EST --- php-phpunit-PHP-Invoker-1.0.0-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 740846] Review Request: espresso - Extensible Simulation Package for Research on Soft matter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=740846 Fedora Update System changed: What|Removed |Added Fixed In Version|espresso-3.0.2-2.fc16 |espresso-3.0.2-2.fc15 --- Comment #18 from Fedora Update System 2011-11-13 19:52:47 EST --- espresso-3.0.2-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732205] Review Request: airsched - C++ Simulated Airline Schedule Manager Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732205 Fedora Update System changed: What|Removed |Added Fixed In Version|airsched-0.1.3-2.fc14 |airsched-0.1.2-1.fc15 --- Comment #20 from Fedora Update System 2011-11-13 19:49:59 EST --- airsched-0.1.2-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732146] Review Request: simfqt - C++ Simulated Fare Quote System Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732146 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System 2011-11-13 19:51:38 EST --- simfqt-0.1.2-1.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750461] Review Request: php-phpunit-PHP-Invoker - Utility class for invoking callables with a timeout
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750461 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-phpunit-PHP-Invoker-1.0 ||.0-3.fc16 Resolution||ERRATA Last Closed||2011-11-13 19:51:18 --- Comment #10 from Fedora Update System 2011-11-13 19:51:18 EST --- php-phpunit-PHP-Invoker-1.0.0-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730970] Review Request: jhdf5 - Java HDF5 Object Package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730970 Fedora Update System changed: What|Removed |Added Fixed In Version|jhdf5-2.7-5.fc16|jhdf5-2.7-5.fc15 --- Comment #21 from Fedora Update System 2011-11-13 19:52:26 EST --- jhdf5-2.7-5.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730970] Review Request: jhdf5 - Java HDF5 Object Package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730970 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jhdf5-2.7-5.fc16 Resolution||ERRATA Last Closed||2011-11-13 19:50:37 --- Comment #20 from Fedora Update System 2011-11-13 19:50:37 EST --- jhdf5-2.7-5.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732205] Review Request: airsched - C++ Simulated Airline Schedule Manager Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732205 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||airsched-0.1.3-2.fc14 Resolution||ERRATA Last Closed||2011-11-13 19:48:59 --- Comment #19 from Fedora Update System 2011-11-13 19:48:59 EST --- airsched-0.1.3-2.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556128] Review Request: ff-utils - Utilities to test force feedback of input device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556128 --- Comment #18 from Michal Ambroz 2011-11-13 19:28:36 EST --- Pushing to devel, F16, F15. Tested to be working on F16 with : Bus 008 Device 003: ID 046d:c218 Logitech, Inc. Logitech RumblePad 2 USB FC16 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3511964 FC15 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3511972 (In reply to comment #15) > Just needed this and would like to see it included. Should be available soon in the updates-testing of F15 and F16 or you can download the package directly from the koji build system. Please can you test ? Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705426] Review Request: blender25 - 3D modeling, animation, rendering and post-production
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705426 --- Comment #15 from Richard Shaw 2011-11-13 17:55:52 EST --- Jochen, Since it looks like you're already building 2.60+ on newer branches, I assume this review request is dead? Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 656892] Review Request: ghc-augeas - Haskell bindings for the augeas library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656892 --- Comment #10 from JudeNagurney 2011-11-13 17:51:31 EST --- Thanks for the feedback. I've updated the spec file based on your comments and pushed the spec file and SRPM to the following locations: Spec URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec SRPM URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas-0.5.1-1.fc15.src.rpm Please let me know if there's anything else I should be doing. Thanks ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751925] Review Request: python-tables - Hierarchical datasets in Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751925 --- Comment #8 from Thibault North 2011-11-13 16:18:55 EST --- Hi Brendan, Thanks for that. I will contact upstream and see what can be done about that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750997] Review Request: Scilab - Numerical Analysis toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750997 --- Comment #8 from Jon Ciesla 2011-11-13 15:21:22 EST --- Summary name and SCM request name don't match, please correct one or the other. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556128] Review Request: ff-utils - Utilities to test force feedback of input device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556128 --- Comment #17 from Jon Ciesla 2011-11-13 15:20:38 EST --- Git done (by process-git-requests). Removed rawhide, ==devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556128] Review Request: ff-utils - Utilities to test force feedback of input device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556128 Michal Ambroz changed: What|Removed |Added Flag|needinfo?(re...@seznam.cz) |fedora-cvs? --- Comment #16 from Michal Ambroz 2011-11-13 14:56:56 EST --- New Package SCM Request === Package Name: ff-utils Short Description: Utilities to test force feedback of input device Owners: rebus Branches: rawhide F16 F15 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695058] Review Request: transgui - An App to remotely control a Transmission Bit-Torrent client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=695058
Martin Gieseking changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review?
--- Comment #21 from Martin Gieseking 2011-11-13
14:44:35 EST ---
The package looks almost fine. You should have reset the Release number to 1,
though. ;)
- The debuginfo package is still empty (see rpmlint output below). You can
also check the one from this koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3511426
- If you want to add a manpage to your package, you can use this one from
Ubuntu: http://manpages.ubuntu.com/manpages/natty/man1/transgui.1.html
- As you probably don't want to build the package for EPEL < 6, you can drop
the %defattr line in %files. It's no longer required.
$ rpmlint ./transgui-*.rpm
transgui.src: W: invalid-url Source0:
https://transmisson-remote-gui.googlecode.com/files/transgui-3.2-src.zip HTTP
Error 404: Not Found
transgui.x86_64: W: no-manual-page-for-binary transgui
transgui-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 1 errors, 2 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum transgui-3.2-src.zip*
39904b86e8772060758e0fae9215f777 transgui-3.2-src.zip
39904b86e8772060758e0fae9215f777 transgui-3.2-src.zip.upstream
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
EPEL <= 5 only:
[X] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[X] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel shoul
[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749885 --- Comment #18 from Pavel Alexeev (aka Pahan-Hubbitus) 2011-11-13 13:57:19 EST --- Yes, but highly appreciated: https://fedoraproject.org/wiki/PackageMaintainers/WhyUpstream -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750997] Review Request: Scilab - Numerical Analysis toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750997 Clément DAVID changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Clément DAVID 2011-11-13 13:01:28 EST --- New Package SCM Request === Package Name: scilab Short Description: Scientific software package for numerical computations Owners: davidcl Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753517] Review Request: hoard - scalable memory allocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753517 --- Comment #1 from Ryan H. Lewis (rhl) 2011-11-13 12:45:57 EST --- Hi, I modified the spec file a bit to stop rpmlint from complaining as much: Spec URL: http://fedorapeople.org/~rhl/hoard/hoard.spec SRPM URL: http://fedorapeople.org/~rhl/hoard/hoard-371-2.fc16.src.rpm another successful scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3511368 $ rpmlint -v hoard-371-2.fc16.src.rpm hoard.src: I: checking hoard.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable hoard.src: W: spelling-error %description -l en_US allocator -> allocate, locator, calculator hoard.src: W: spelling-error %description -l en_US malloc -> mallow hoard.src: I: checking-url http://www.cs.umass.edu/~emery/hoard (timeout 10 seconds) hoard.src: I: checking-url http://www.cs.umass.edu/~emery/hoard/hoard-3.7.1/hoard-371.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint -v hoard.spec hoard.spec: I: checking-url http://www.cs.umass.edu/~emery/hoard/hoard-3.7.1/hoard-371.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753597] Review Request: yazpp - C++ API for YAZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753597 --- Comment #2 from Ryan H. Lewis (rhl) 2011-11-13 12:47:50 EST --- I forgot to include the scratch build this of course succesfully builds in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=3511373 Since this package requires yaz v4.2.8 or later it will currently only build in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753596] Review Request: yazpp - C++ API for YAZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753596 Ryan H. Lewis (rhl) changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Last Closed||2011-11-13 12:40:08 --- Comment #1 from Ryan H. Lewis (rhl) 2011-11-13 12:40:08 EST --- *** This bug has been marked as a duplicate of bug 753597 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753597] Review Request: yazpp - C++ API for YAZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753597 --- Comment #1 from Ryan H. Lewis (rhl) 2011-11-13 12:40:08 EST --- *** Bug 753596 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753596] New: Review Request: yazpp - C++ API for YAZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: yazpp - C++ API for YAZ https://bugzilla.redhat.com/show_bug.cgi?id=753596 Summary: Review Request: yazpp - C++ API for YAZ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: m...@ryanlewis.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://fedorapeople.org/~rhl/yazpp/yazpp.spec SRPM URL: yazpp-1.2.7-2.fc16.src.rpm Description: YAZ++ is an application programming interface (API) to YAZ which supports the development of Z39.50/SRW/SRU client and server applications using C++. Like YAZ, it supports Z39.50-2003 (version 3) as well as SRW/SRU version 1.1 in both the client and server roles. YAZ++ includes an implementation of the ZOOM C++ binding and a generic client/server API based on the Observer/Observable design pattern. Hey guys, just packaged this up. It works against the latest rawhide version of yaz, and is the latest version of yazpp. I would appreciate a review. $ rpmlint -v yazpp.spec yazpp.spec: I: checking-url http://ftp.indexdata.dk/pub/yazpp/yazpp-1.2.7.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v yazpp-1.2.7-2.fc16.src.rpm yazpp.src: I: checking yazpp.src: I: checking-url http://www.indexdata.dk/yazplusplus/ (timeout 10 seconds) yazpp.src: I: checking-url http://ftp.indexdata.dk/pub/yazpp/yazpp-1.2.7.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 744339] Review Request: dieharder - Random number generator tester and timer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=744339
Richard Shaw changed:
What|Removed |Added
CC||hobbes1...@gmail.com
--- Comment #9 from Richard Shaw 2011-11-13 12:28:08 EST
---
I never thought I would say this, but I think you have too many comments in
your spec file. It's actually hurting legibility.
You don't have to comment every line... Comments are for unusual situations
that require explanation.
Some tips:
1. The release tag should start with 1, not 0.
2. If you're not going to build for EL 5 you can remove the following from your
spec file:
- Buildroot:
- %clean entirely
- rm -rf %{buildroot} from %install
- %defattr from %files
3. The devel subpackage should be arch specific. Change:
Requires: %{name} = %{version}-%{release}
to
Requires: %{name}%{?_isa} = %{version}-%{release}
4. Leave the "*" off of:
%{_includedir}/%{name}/*
If you don't then the "dieharder" directory will not be owned by the package as
it should be. You can leave the trailing "/".
That's all I can think of right now.
Richard
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753597] New: Review Request: yazpp - C++ API for YAZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: yazpp - C++ API for YAZ https://bugzilla.redhat.com/show_bug.cgi?id=753597 Summary: Review Request: yazpp - C++ API for YAZ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: m...@ryanlewis.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://fedorapeople.org/~rhl/yazpp/yazpp.spec SRPM URL: http://fedorapeople.org/~rhl/yazpp/yazpp-1.2.7-2.fc16.src.rpm Description: YAZ++ is an application programming interface (API) to YAZ which supports the development of Z39.50/SRW/SRU client and server applications using C++. Like YAZ, it supports Z39.50-2003 (version 3) as well as SRW/SRU version 1.1 in both the client and server roles. YAZ++ includes an implementation of the ZOOM C++ binding and a generic client/server API based on the Observer/Observable design pattern. Hey guys, just packaged this up. It works against the latest rawhide version of yaz, and is the latest version of yazpp. I would appreciate a review. $ rpmlint -v yazpp.spec yazpp.spec: I: checking-url http://ftp.indexdata.dk/pub/yazpp/yazpp-1.2.7.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v yazpp-1.2.7-2.fc16.src.rpm yazpp.src: I: checking yazpp.src: I: checking-url http://www.indexdata.dk/yazplusplus/ (timeout 10 seconds) yazpp.src: I: checking-url http://ftp.indexdata.dk/pub/yazpp/yazpp-1.2.7.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749885 --- Comment #17 from Kevin Kofler 2011-11-13 12:16:25 EST --- > Please send patches to upstream author (may be except libidn system usage > which > must have comment what it Fedora related only) and add comments on appropriate > bugreports. Upstreaming patches and/or commenting on their upstream status is a SHOULD, not a MUST. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753583] Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753583 --- Comment #2 from Ignacio Casal Quinteiro (nacho) 2011-11-13 11:19:47 EST --- And here is the build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3511303 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753583] Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753583 --- Comment #1 from Ignacio Casal Quinteiro (nacho) 2011-11-13 11:05:16 EST --- Here is the rpmlint output: nacho@ansalon:~/checkout/fedora$ rpmlint gedit-code-assistance.spec ~/rpmbuild/RPMS/x86_64/gedit-code-assistance-0.1.1-1.fc16.x86_64.rpm ~/rpmbuild/RPMS/x86_64/gedit-code-assistance-debuginfo-0.1.1-1.fc16.x86_64.rpm ~/rpmbuild/SRPMS/gedit-code-assistance-0.1.1-1.fc16.src.rpm gedit-code-assistance.x86_64: W: summary-not-capitalized C gedit plugin for code assistance for C, C++ and Objective-C gedit-code-assistance.src: W: summary-not-capitalized C gedit plugin for code assistance for C, C++ and Objective-C 3 packages and 1 specfiles checked; 0 errors, 2 warnings. These warnings are fine as it is gedit and not Gedit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753583] New: Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C https://bugzilla.redhat.com/show_bug.cgi?id=753583 Summary: Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: i...@gnome.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://people.gnome.org/~icq/gedit-code-assistance.spec SRPM URL: http://people.gnome.org/~icq/gedit-code-assistance-0.1.1-1.fc16.src.rpm Description: gedit code assistance is a plugin for gedit which provides code assistance for C, C++ and Objective-C by utilizing clang. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753577] Review Request: gmsh - finite element grid generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753577 Alexey Vasyukov changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753577] New: Review Request: gmsh - finite element grid generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gmsh - finite element grid generator https://bugzilla.redhat.com/show_bug.cgi?id=753577 Summary: Review Request: gmsh - finite element grid generator Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: vasyu...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://dl.dropbox.com/u/4532412/RPMS/gmsh.spec SRPM URL: http://dl.dropbox.com/u/4532412/RPMS/gmsh-2.5.0-4.fc16.src.rpm Description: Gmsh is a 3D finite element grid generator with a build-in CAD engine and post-processor. Gmsh is built around four modules: geometry, mesh, solver and post-processing. Gmsh has GUI and CLI and can be used as a library for 3rd party programs. Hi folks, I've packaged Gmsh and need a review. This is my first package, so I need a sponsor. I did my best to meet Fedora packaging guidelines, but would really appreciate detailed review. The main question I'd like to advice about - how to split gmsh into subpackages correctly. Gmsh is organized like this: - Separate binary that needs nothing to run properly - Shared library that is required for linking 3rd party programs only - Headers, demos, tutorials I decided to split it this way: - gmsh package with binary - gmsh-libs with shared libraries - gmsh-devel with headers and symlinks to so-files, it requires gmsh-libs (not gmsh) - gmsh-demos with tutorials and so on Does it look reasonable? rpmlint has nothing against it, but I'd really appreciate human advice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=749885
--- Comment #16 from Pavel Alexeev (aka Pahan-Hubbitus)
2011-11-13 09:16:11 EST ---
Legend:
+ - Ok.
- - Error.
+/- - It item acceptable, but I strongly recommend enhancement.
= - N/A.
== MUST Items ==
[+/-] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint *.spec *.rpm
iris.spec:75: W: configure-without-libdir-spec
iris.spec:25: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 25)
Both trivial to fix, please do that.
iris.spec: W: invalid-url Source0: iris-1.0.0-20110904.tar.gz
iris.src:75: W: configure-without-libdir-spec
iris.src:25: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 25)
iris.src: W: invalid-url Source0: iris-1.0.0-20110904.tar.gz
iris-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/iris-1.0.0/src/xmpp/.moc
iris-debuginfo.i686: W: hidden-file-or-dir
/usr/src/debug/iris-1.0.0/src/xmpp/.moc
Is it .moc needed??
iris-devel.i686: W: no-documentation
qjdns.i686: W: summary-not-capitalized C a simple DNS implementation that can
perform normal as well as Multicast DNS queries
qjdns.i686: E: summary-too-long C a simple DNS implementation that can perform
normal as well as Multicast DNS queries
Also easy to deal.
qjdns.i686: W: spelling-error %description -l en_US Multicast -> Multics,
Simulcast
qjdns.i686: W: spelling-error %description -l en_US mdnsd -> madness
qjdns-devel.i686: W: no-dependency-on qjdns/qjdns-libs/libqjdns
Dependency missing?
qjdns-devel.i686: W: no-documentation
6 packages and 1 specfiles checked; 1 errors, 14 warnings.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[-] MUST: The package must meet the Packaging Guidelines.
Please send patches to upstream author (may be except libidn system usage which
must have comment what it Fedora related only) and add comments on appropriate
bugreports.
[-] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
src/xmpp/base and src/xmpp/base64 need clarification. Do you receive answer
from author?
Also still there question about mixed copyrights of Barracuda Networks and
Justin Karneges. May we threat it as one author, or they parts of code just
borrowed??
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[-] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Please provide exact revision in checkout comment instruction and in version
instead of date to be able reproduce tarball.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[=] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[=] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[=] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[+] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[-] MUST: Packages must NOT bundle copies of system libraries.
See before, some parts still needs clarification.
[=] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more
[Bug 749885] Review Request: iris - A library for working with the XMPP/Jabber protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749885 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|pa...@hubbitus.info Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=748180
--- Comment #7 from Theodore Lee 2011-11-13 08:23:14 EST ---
Right, I guess I'll take a shot at helping out with a review (just informal at
this point, unless Peter wants to hand it over). This is my first package
review aside from the practice reviews I did when applying to be a packager,
and I don't have much experience with the Mono guidelines, so apologies for any
mistakes.
MUST Items
==
OK - rpmlint must be run on all rpms
$ rpmlint dbus-sharp-glib-0.5.0-1.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint dbus-sharp-glib-0.5.0-1.fc16.x86_64.rpm
dbus-sharp-glib-devel-0.5.0-1.fc16.x86_64.rpm
dbus-sharp-glib.x86_64: E: no-binary
dbus-sharp-glib.x86_64: W: only-non-binary-in-usr-lib
dbus-sharp-glib-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
After install:
$ rpmlint dbus-sharp-glib
dbus-sharp-glib.x86_64: E: no-binary
dbus-sharp-glib.x86_64: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
These errors seem to be the usual ones seen with mono packages, nothing
significant.
OK - Package must meet naming guidelines
OK - Spec file name must match base package name
OK - Package must meet packaging guidelines
OK - Package must meet licensing guidelines
OK - License tag must match actual license
OK - Any license files must be in %doc
OK - Spec file must be in American English
OK - Spec file must be legible
OK - Sources must match upstream
$ sha1sum dbus-sharp-glib-0.5.0.tar.gz dbus-sharp-glib-0.5.0.tar.gz.fedora
bff1d3e8def9f5c7f956adffdef3a860a05e0e95 dbus-sharp-glib-0.5.0.tar.gz
bff1d3e8def9f5c7f956adffdef3a860a05e0e95 dbus-sharp-glib-0.5.0.tar.gz.fedora
OK - Package must build on at least one primary arch
OK - Arches that the package doesn't build on must be excluded with a relevant
bug
In this case mono simply isn't available on some arches, so I don't think this
is a blocking issue.
OK - All necessary build dependencies must be in BuildRequires
N/A - Locales must be handled properly
N/A - Binary rpms containing libraries must call ldconfig
OK - Package must not bundle system libraries
N/A - Relocatable packages must have rationalization
OK - Package must own all directories it creates
OK - Package must not list a file more than once in %files
OK - Files must have correct permissions
OK - Macros must be consistent
OK - Package must contain code or permissible content
N/A - Large documentation files must be in a -doc subpackage
OK - %doc files must not affect program operation
N/A - Header files must be in a -devel subpackage
N/A - Static libraries must be in a -static package
N/A - Library files that end in .so must go in a -devel package
OK - -devel packages must require the base package using a fully versioned
dependency
OK - Package must NOT contain any .la libtool archives
N/A - Packages containing GUI applications must include a %{name}.desktop file
OK - Packages must not own files or directories already owned by other packages
OK - All filenames in rpm packages must be valid UTF-8
SHOULD Items
N/A - If the package is missing license text in a separate file, the packager
should query upstream for it
N/A - Description and summary should contain translations if available
OK - Package should build in mock
OK - Package should build on all supported architectures
Koji scratch build seems okay:
https://koji.fedoraproject.org/koji/taskinfo?taskID=3511249
OK - Package should function as described
Built and used banshee-2.2 against this, and it seems to be working well.
N/A - Scriptlets should be sane
N/A - Non-devel subpackages should require the base package with a full version
OK - pkgconfig files should be placed appropriately
N/A - File dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
should require package instead
N/A - Binaries/scripts should have man pages
Mono-specific Items
===
OK - DLLs must be registered with gacutil
OK - .pc files must be in a -devel package
OK - Empty -debuginfo packages must not be built
OK - Package must NOT contain any pre-compiled .dll or .exe files
OK - Package must NOT contain .dll files from other projects
OK - Package should not redefine _libdir
Issues
==
1) There's no link to a tracking bug for the architectures that this package
doesn't build on. However, this is something that covers pretty much all mono
packages, so I don't think that's too important.
2) The main package description is missing a full stop, and the description for
the -devel package should probably mention GLib at some point.
I don't see any blocking issues though, but I'm sure I missed something. =)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on
[Bug 746754] Review request: pdfcrack - A Password Recovery Tool for PDF-files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746754 --- Comment #26 from Richard Shaw 2011-11-13 08:18:51 EST --- You'll have to reset the cvs flag if you want them to do anything but be sure you're not hitting this issue instead: https://admin.fedoraproject.org/updates/FEDORA-2011-15612 The SRPM name probably needs to match the git repo name but I don't believe that's absolutely required of the source archive. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=748180 Christian Krause changed: What|Removed |Added Blocks||714359 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753452] Review Request: netris - A FOSS variant of tetris that includes a networked multiplayer mode and runs through the terminal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753452 --- Comment #5 from Dominic Prittie 2011-11-13 05:33:57 EST --- Ok it shouldn't be a problem to replace all instances of t*tr*s with an adequate description. I understand the potential legal issues with a game like this, but I am hoping in this instance it won't be much of an issue since this game has been around for a long time and has been included in repositories for Debian and many of its derivatives, including Ubuntu. Thank you for your interest, any further advice to bring this package up to scratch would be much appreciated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732146] Review Request: simfqt - C++ Simulated Fare Quote System Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732146 --- Comment #7 from Fedora Update System 2011-11-13 04:13:13 EST --- simfqt-0.1.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/simfqt-0.1.2-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732146] Review Request: simfqt - C++ Simulated Fare Quote System Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732146 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732146] Review Request: simfqt - C++ Simulated Fare Quote System Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732146 --- Comment #8 from Fedora Update System 2011-11-13 04:14:03 EST --- simfqt-0.1.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/simfqt-0.1.2-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732146] Review Request: simfqt - C++ Simulated Fare Quote System Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732146 --- Comment #6 from Fedora Update System 2011-11-13 04:12:32 EST --- simfqt-0.1.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/simfqt-0.1.2-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 285801] Review Request: simias - Collection-Oriented Data Storage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=285801 --- Comment #38 from Peter van Ieperen 2011-11-13 03:59:45 EST --- I forgot to say, i've been building the client. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 285801] Review Request: simias - Collection-Oriented Data Storage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=285801 Peter van Ieperen changed: What|Removed |Added CC||p.v.iepe...@globe-nl.net --- Comment #37 from Peter van Ieperen 2011-11-13 03:30:23 EST --- I managed to build it, since iFolder is widely used within our company. I've been building ifolder and simias since fedora 12. You can find the packages here: http://rpm.globe-nl.net/fedora/release I haven't added the source rpms for 15 and 16 yet, but will do so later on. The specs-files I used are based on the specs-files from OpenSuSE. So if I can help with something, please don't hasitate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=748180 --- Comment #6 from Theodore Lee 2011-11-13 03:21:06 EST --- I'm hardly qualified to do a review of this package, but I suppose it's worth noting that I used the SRPM submitted for this review to help build Banshee 2.2 for my own use. I can happily report that this package compiles correctly in mock, and that Banshee seems to be working correctly when compiled against it. =) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
