[Bug 730970] Review Request: jhdf5 - Java HDF5 Object Package

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730970

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Blocks|652183(FE-JAVASIG)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749132] Review Request: dpm-dsi - Disk Pool Manager (DPM) plugin to GridFTP

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749132

--- Comment #37 from Ricardo Rocha rocha.po...@gmail.com 2011-11-14 03:25:27 
EST ---
EL5/EL6 look ok, but there seems to be a dependency missing in FC16/64.

https://admin.fedoraproject.org/updates/dpm-dsi-1.8.2-4.fc16

AutoQA: depcheck test FAILED on x86_64. Result log:
http://autoqa.fedoraproject.org/results/231613-autotest/virt06.qa.fedoraproject.org/depcheck/results
/dpm-dsi-1.8.2-4.fc16.html (results are informative only)


Looking deeper:
http://autoqa.fedoraproject.org/results/231613-autotest/virt06.qa.fedoraproject.org/depcheck/results/dpm-dsi-1.8.2-4.fc16.html

SKIPBROKEN: dpm-dsi-1.8.2-4.fc16.i686 from pending has depsolving problems
SKIPBROKEN:  -- Package: dpm-dsi-1.8.2-4.fc16.i686 (pending)
  -- Requires: globus-gridftp-server-progs(x86-32) [view »]


It seems to try to build both the 64 and 32 versions, meaning it should also
depend on the globus(32) libraries. Probably removing the ${_isa} from the
dependency will do the trick, i'll have a look.

I wonder why it does not fail in EL5/EL6? Anything obvious changed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 556128] Review Request: ff-utils - Utilities to test force feedback of input device

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556128

--- Comment #19 from Miroslav Suchý msu...@redhat.com 2011-11-14 03:44:29 EST 
---
Michal, if you put BZ number to Bodhi:
https://admin.fedoraproject.org/updates/ff-utils-2.4.21-4.fc16
then it will move this BZ automatically to ON_QA and when pushed to stable to
CLOSED CURRENT RELEASE.
If you omit it you have to switch this BZ manually. 

Can you please update either the update or switch this BZ manually?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=748180

--- Comment #9 from Theodore Lee theo...@gmail.com 2011-11-14 03:46:00 EST ---
If there are no objections I'd be happy to take this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753577] Review Request: gmsh - finite element grid generator

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753577

--- Comment #2 from Alexey Vasyukov vasyu...@gmail.com 2011-11-14 04:04:10 
EST ---
Dan, many thanks for comments.

 - system copy of the ANN library (from the ann package)
 must be used instead of the copy in contrib/ANN

Ok. I'll work on it.

 - sources contains mpeg encoder which is a patented thing

Ok. Got the issue. I'll just remove mpeg - it does not affect core
functionality.

 - contrib/tetgen contains a non-commercial only clause

Metis has also similar non-commercial only clause. I disabled them both in
CMake configure. Is it not enough? Should I remove them completely from
sources?

 - the contrib dir contains stuff that could/should exists as separate packages

Ok. I'll re-check it. Could you advice which packages require attention?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 742166] Review Request: wmctrl - X Window Manager command-line tool

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742166

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Jens Petersen peter...@redhat.com 2011-11-14 04:16:48 EST 
---
Sorry, Jon


Package Change Request
==
Package Name: wmctrl
New Branches: f16 el6
Owners: petersen

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 656892] Review Request: ghc-augeas - Haskell bindings for the augeas library

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656892

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

  Status Whiteboard|notready cabal2spec |

--- Comment #11 from Jens Petersen peter...@redhat.com 2011-11-14 05:01:22 
EST ---
Thanks for updating I think I can review this for you as sponsor
if you can clean up a little more:

We usually put the summary and description in common_summary
and common_description.

Please remember to bump the release number and add a new changelog
entry when you update the package.

You should use _bindir and _datadir instead of explicitly writing
/usr/bin and /usr/share.

You can add (doc) files under the %file sections
but you need to be careful since secondary archs
don't have shared libraries (ie base subpackage).


If you are serious about packaging it would also help
if you looked at some other packages that need reviewing
and posted comments on them - feel free to put links here
to any reviews you have looked over.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717502

--- Comment #22 from Guillermo Gómez guillermo.go...@gmail.com 2011-11-14 
05:17:14 EST ---
(In reply to comment #20)
 (In reply to comment #18)
  Any progress here?
 
 The last changes are here: 02-Nov
 http://lletelier.fedorapeople.org/i4uc/
 
 i wait next steps.

Please include links to srpm/spec plus rpmlint output (must be a habit)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683218] Review Request: drizzle7 - A Lightweight SQL Database for Cloud and Web

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683218

Felix Kaechele fe...@fetzig.org changed:

   What|Removed |Added

 CC||fe...@fetzig.org

--- Comment #5 from Felix Kaechele fe...@fetzig.org 2011-11-14 06:06:31 EST 
---
Any news here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751411] Review Request: bash-modules - Modules for bash

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751411

--- Comment #4 from Volodymyr M. Lisivka vlisi...@gmail.com 2011-11-14 
08:24:31 EST ---
Ping.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752829] Review Request: glue-validator - A validation framework for GLUE 2.0 information

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752829

--- Comment #4 from laurence.fi...@cern.ch 2011-11-14 09:04:37 EST ---
I have addressed the issue mentioned. Here is the new version

Spec URL: http://lfield.web.cern.ch/lfield/glue-validator.spec
SRPM URL: http://lfield.web.cern.ch/lfield/glue-validator-1.0.0-1.el5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753188] Review Request: R-rtracklayer - R interface to genome browsers and their annotation tracks

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753188

--- Comment #2 from Tom spot Callaway tcall...@redhat.com 2011-11-14 
09:34:09 EST ---
Jim Kent, the upstream copyright holder for those files, has given permission
via email to use/modify/distribute them under the terms of the BSD license.

New SPEC: http://spot.fedorapeople.org/R-rtracklayer.spec
New SRPM: http://spot.fedorapeople.org/R-rtracklayer-1.14.1-2.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753188] Review Request: R-rtracklayer - R interface to genome browsers and their annotation tracks

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753188

Pierre-YvesChibon pin...@pingoured.fr changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Pierre-YvesChibon pin...@pingoured.fr 2011-11-14 09:43:21 
EST ---
Ok this package is then approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 746754] Review request: pdfcrack - A Password Recovery Tool for PDF-files.

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=746754

--- Comment #28 from Richard Shaw hobbes1...@gmail.com 2011-11-14 09:48:50 
EST ---
FYI, since the package has already been setup once you may need to use the
change format instead of the new package format[1], but Jon will know for
sure.

Richard

[1]
http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753188] Review Request: R-rtracklayer - R interface to genome browsers and their annotation tracks

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753188

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Tom spot Callaway tcall...@redhat.com 2011-11-14 
10:27:31 EST ---
New Package SCM Request
===
Package Name: R-rtracklayer
Short Description: R interface to genome browsers and their annotation tracks
Owners: spot
Branches: f15 f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719908

--- Comment #9 from Jon Ciesla l...@jcomserv.net 2011-11-14 10:46:47 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 742166] Review Request: wmctrl - X Window Manager command-line tool

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742166

--- Comment #5 from Jon Ciesla l...@jcomserv.net 2011-11-14 10:48:05 EST ---
Git done (by process-git-requests).

NP.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 739798] Review Request: pcp-gui - Visualization tools for the Performance Co-Pilot toolkit

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739798

Frank Ch. Eigler f...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|f...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 746754] Review request: pdfcrack - A Password Recovery Tool for PDF-files.

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=746754

--- Comment #29 from Jon Ciesla l...@jcomserv.net 2011-11-14 10:54:10 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753188] Review Request: R-rtracklayer - R interface to genome browsers and their annotation tracks

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753188

--- Comment #5 from Jon Ciesla l...@jcomserv.net 2011-11-14 10:54:42 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 746754] Review request: pdfcrack - A Password Recovery Tool for PDF-files.

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=746754

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

 CC||l...@jcomserv.net

--- Comment #30 from Jon Ciesla l...@jcomserv.net 2011-11-14 10:55:14 EST ---
Not sure what happened but it just wasn't there at all.  It is now, sans f14
branch since we're not doing new f14 branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 738744] Review Request: rubygem-execjs - A package for the execjs Ruby gem

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738744

Bug 738744 depends on bug 719908, which changed state.

Bug 719908 Summary: Review Request: rubygem-multi_json - A gem to provide 
swappable JSON backends
https://bugzilla.redhat.com/show_bug.cgi?id=719908

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719908

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-11-14 11:21:45

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 745510] Review Request: vdsm - Virtual Desktop Server Manager

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=745510

--- Comment #15 from Federico Simoncelli fsimo...@redhat.com 2011-11-14 
11:40:14 EST ---
Spec URL: http://people.redhat.com/fsimonce/vdsm/vdsm.spec
SRPM URL:
http://people.redhat.com/fsimonce/vdsm/vdsm-4.9.1-0.git31.039976c.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 739798] Review Request: pcp-gui - Visualization tools for the Performance Co-Pilot toolkit

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739798

Frank Ch. Eigler f...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||needinfo?(mgoodwin@redhat.c
   ||om)

--- Comment #2 from Frank Ch. Eigler f...@redhat.com 2011-11-14 11:42:35 EST 
---
FAIL MUST: rpmlint, tested on F15 x86-64 build:
   [root@very]~/rpmbuild# rpmlint SRPMS/pcp-gui-1.5.1-1.fc15.src.rpm 
   [1 packages and 0 specfiles checked; 0 errors, 0 warnings.
   [[root@very]~/rpmbuild# rpmlint RPMS/x86_64/pcp-*
   [pcp-gui.x86_64: E: standard-dir-owned-by-package
/usr/share/man/man1
   [pcp-gui.x86_64: E: standard-dir-owned-by-package /var/lib
   [pcp-gui.x86_64: E: incorrect-fsf-address
/usr/libexec/pcp/bin/pmsnap
   [pcp-gui-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pcp-gui-1.5.1/src/chart/main.cpp
   [pcp-gui-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pcp-gui-1.5.1/src/chart/pmchart.cpp
   [pcp-gui-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pcp-gui-1.5.1/src/chart/namespace.cpp
   [3 packages and 0 specfiles checked; 6 errors, 0 warnings.
PASS MUST: The spec file name must match the base package.
FAIL MUST: No gross violations of Packaging:Guidelines seen.
   Minor stuff: run desktop-file-install on pmchart.desktop.
PASS MUST: The package must be licensed with a Fedora approved license 
PASS MUST: The License field in the package spec file must match the actual
license.
   (COPYING file includes all licenses).
PASS MUST: [License file included in %doc]
PASS MUST: The spec file must be written in American English
PASS MUST: The spec file for the package MUST be legible
PASS MUST: The sources used to build the package must match the upstream source
PASS MUST: The package MUST successfully compile and build into binary rpms
PASS MUST: If the package does not successfully compile, build or work on an
architecture -- none found
PASS MUST: All build dependencies must be listed in BuildRequires, 
PASS MUST: The spec file MUST handle locales properly -- package not i18n'd
PASS MUST: Every binary RPM package (or subpackage) which stores shared library
files -- none
PASS MUST: Packages must NOT bundle copies of system libraries.
PASS MUST: If the package is designed to be relocatable, the packager must
state this fact
PASS MUST: A package must own all directories that it creates. 
PASS MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
PASS MUST: Permissions on files must be set properly -- no gross errors seen
PASS MUST: MUST: Each package must consistently use macros -- minimal use
PASS MUST: The package must contain code, or permissable content
PASS MUST: Large documentation files must go in a -doc subpackage.
   NB: it's named pcp-doc rather than pcp-gui-doc.
PASS MUST: If a package includes something as %doc, it must not affect the
runtime of the application. -- apparently
PASS MUST: Header files must be in a -devel package -- none
PASS MUST: Static libraries must be in a -static package. 
PASS MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1) - -devel -- none
PASS MUST: In the vast majority of cases, devel packages must require [...] -
none
PASS MUST: Packages must NOT contain any .la libtool
FAIL MUST: Packages containing GUI applications must include a %{name}.desktop
file,
   Package's pmchart.desktop needs to be desktop-file-install'd
FAIL MUST: Packages must not own files or directories already owned by other
packages.
   Same as rpmlint errors at top.
PASS MUST: All filenames in rpm packages must be valid UTF-8.

OK   SHOULD: If the source package does not include license text(s) [...]
OK   SHOULD: The description and summary sections in the package spec file
should contain translations -- n/a
KO   SHOULD: The reviewer should test that the package builds in mock -- tested
on f15 native system only
KO   SHOULD: The package should compile and build into binary rpms on all
supported architectures
OK   SHOULD: The reviewer should test that the package functions as described.
-- smoke-tested
OK   SHOULD: If scriptlets are used, those scriptlets must be sane -- no
scriptlets
OK   SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency
 NB: pcp-gui  pcp-doc subpackage not mutually required
OK   SHOULD: The placement of pkgconfig(.pc) files depends -- none
OK   SHOULD: If the package has file dependencies outside -- no /file
dependencies
OK   SHOULD: your package should contain man 

[Bug 750997] Review Request: scilab - Scientific software package for numerical computations

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=750997

Clément DAVID c.davi...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: Scilab -|Review Request: scilab -
   |Numerical Analysis toolkit  |Scientific software package
   ||for numerical computations

Bug 750997 depends on bug 730970, which changed state.

Bug 730970 Summary: Review Request: jhdf5 - Java HDF5 Object Package
https://bugzilla.redhat.com/show_bug.cgi?id=730970

   What|Old Value   |New Value

 Resolution||ERRATA
 Status|ON_QA   |CLOSED

--- Comment #9 from Clément DAVID c.davi...@gmail.com 2011-11-14 12:28:21 EST 
---
New Package SCM Request
===
Package Name: scilab
Short Description: Scientific software package for numerical computations
Owners: davidcl
Branches: f15 f16 el6
InitialCC:

Thanks for your remark, I prefer to keep the lowercase version and the
description from the spec file (as in comment #7).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 638786] Review Request: guessencoding - Guess encoding of files and return configured reader

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638786

--- Comment #4 from Tomas Radej tra...@redhat.com 2011-11-14 12:51:50 EST ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output: 
guessencoding.noarch: W: spelling-error %description -l en_US encodings -
encoding, encoding s, recordings
guessencoding.noarch: W: no-documentation
guessencoding.src: W: spelling-error %description -l en_US encodings -
encoding, encoding s, recordings
guessencoding.src: W: invalid-url Source0: guessencoding-1.4.tar.gz
guessencoding-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java
docs, Java-docs, Avocados
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[!]  Buildroot definition is not present  BuildRoot def is present
[x]  Package is licensed with an open-source compatible license and meets other
 legal requirements as defined in the legal section of Packaging
 Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
 License type: ASL 2.0
[-]  If (and only if) the source package includes the text of the license(s) in
 its own file, then that file, containing the text of the license(s) for
the
 package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
 in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[!]  File sections do not contain %defattr(-,root,root,-) unless changed with
 good reason 
[x]  Permissions on files are set properly.
[!]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
 (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
 mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
 application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
 subpackage
[!]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
  Folder copied is apidocs, should apidocs/*
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[!]  If package uses tarball from VCS include comment how to re-create that
 tarball (svn export URL, git clone URL, ...)
  Should contain line # tar caf guessencoding-1.4.tar.gz guessencoding-1.4
[-]  If source tarball includes bundled jar/class files these need to be
 removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
 building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
 %{_datadir}/maven2/poms
[-]  If package uses -Dmaven.test.skip=true explain why it was needed in a
 comment 
[-]  If package uses custom depmap -Dmaven.local.depmap.file=* explain why
 it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
 jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.

*** ISSUES ***
- BuildRoot def is present
- DefAttr is present
- Clean section is present
- Folder copied is apidocs, should apidocs/*
- Should contain line # tar caf guessencoding-1.4.tar.gz guessencoding-1.4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org

[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717502

--- Comment #23 from Larry Letelier larry.letel...@gmail.com 2011-11-14 
12:58:32 EST ---
(In reply to comment #22)
 (In reply to comment #20)
  (In reply to comment #18)
   Any progress here?
  
  The last changes are here: 02-Nov
  http://lletelier.fedorapeople.org/i4uc/
  
  i wait next steps.
 
 Please include links to srpm/spec plus rpmlint output (must be a habit)

Dear Guillermo,

The rpmlint/srpm file was uploaded here:

http://lletelier.fedorapeople.org/i4uc/

Thanks,
--LL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 638786] Review Request: guessencoding - Guess encoding of files and return configured reader

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638786

--- Comment #5 from Orion Poplawski or...@cora.nwra.com 2011-11-14 13:04:57 
EST ---
(In reply to comment #4)
 
 *** ISSUES ***
 - Folder copied is apidocs, should apidocs/*

Nope, this is correct.  Others fixed:

* Mon Nov 14 2011 Orion Poplawski or...@cora.nwra.com 1.4-2
- Drop BuildRoot, defattr, clean
- Add comment for tar generation

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752993] gnome-dictionary - A dictionary application for GNOME

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752993

Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(mcla...@redhat.co |
   |m)  |

--- Comment #2 from Matthias Clasen mcla...@redhat.com 2011-11-14 13:38:15 
EST ---
Hey, I've uploaded new spec and srpm to the same place.

Changes:
- added Obsoletes
- added %doc content
- fixed up scriplets

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717502

--- Comment #24 from Guillermo Gómez guillermo.go...@gmail.com 2011-11-14 
14:11:42 EST ---
I know the files are there (spec/srpm), however, if for any reason rpmlint
outuput goes removed from such host, then there will be no evidence here about
it.

So just as a habit, please put here explicit links to both spec and srpm file
and include here the rmplint output :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717502

--- Comment #25 from Guillermo Gómez guillermo.go...@gmail.com 2011-11-14 
14:25:00 EST ---
Specific:

[!] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.

Please review: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

It is not simply enough to just include the .desktop file in the package, one
MUST run desktop-file-install OR desktop-file-validate in %install (and have
BuildRequires: desktop-file-utils), to help ensure .desktop file safety and
spec-compliance.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751925] Review Request: python-tables - Hierarchical datasets in Python

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751925

--- Comment #9 from Thibault North thibault.no...@gmail.com 2011-11-14 
14:46:41 EST ---
Hi Brendan,

According to upstream, Toshio's suggestion was good: remove lrucache.py and get
rid of the AFL license.
A patch was sent upstream.

Here is an updated build. In the %prep section, that file is removed along with
its license. Is that good enough for this version of PyTables? Or do we need to
remove lrucache.py from the tarball ?

Spec URL: http://tnorth.fedorapeople.org/python-tables.spec
SRPM URL: http://tnorth.fedorapeople.org/python-tables-2.3.1-3.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753900] New: Review Request: abi-compliance-checker - An ABI Compliance Checker

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: abi-compliance-checker - An ABI Compliance Checker

https://bugzilla.redhat.com/show_bug.cgi?id=753900

   Summary: Review Request: abi-compliance-checker - An ABI
Compliance Checker
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: hobbes1...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---


Spec URL:
http://hobbes1069.fedorapeople.org/abi-compliance-checker/abi-compliance-checker.spec
SRPM
http://hobbes1069.fedorapeople.org/abi-compliance-checker/abi-compliance-checker-1.95.9-1.fc15.src.rpm

Description:
A tool for checking backward binary compatibility of a shared C/C++ library. It
checks for changes in calling stack, changes in v-table, removed symbols, etc.

rpmlint output:
$ rpmlint SRPMS/abi-compliance-checker-1.95.9-1.fc15.src.rpm
RPMS/noarch/abi-compliance-checker-1.95.9-1.fc15.noarch.rpm
abi-compliance-checker.src:27: W: rpm-buildroot-usage %prep sed -i
s,\$PREFIX/share/\$TOOL_SNAME,%{buildroot}%{perl_vendorlib}/\$TOOL_SNAME,g
Makefile.pl
abi-compliance-checker.noarch: E: zero-length
/usr/share/perl5/vendor_perl/abi-compliance-checker/modules/RulesSrc.xml
abi-compliance-checker.noarch: W: no-manual-page-for-binary
abi-compliance-checker
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

rpm-buildroot-usage: Necessary because the makefile does not support DESTDIR.
zero-length: I assume the file may not stay empty in the future.
no-manual-page-for-binary: I will query upstream for a man page.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753911] New: Review Request: django-profiles - A fairly simple user-profile management application for Django

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: django-profiles - A fairly simple user-profile 
management application for Django

https://bugzilla.redhat.com/show_bug.cgi?id=753911

   Summary: Review Request: django-profiles - A fairly simple
user-profile management application for Django
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mru...@matthias-runge.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---


Spec URL: http://www.matthias-runge.de/fedora/django-profiles.spec
SRPM URL:
http://www.matthias-runge.de/fedora/django-profiles-0.2-1.fc16.src.rpm
Description: 
A fairly simple user-profile management application for
Django, designed to make the management of site-specific user
profiles as painless as possible. It requires a functional
installation of Django 1.0 or newer and provides a useful complement
to `django-registration`, but has no other dependencies.


--- 
[mrunge@sofja SPECS]$ rpmlint ./django-profiles.spec
../SRPMS/django-profiles-0.2-1.fc16.src.rpm
../RPMS/noarch/django-profiles-0.2-1.fc16.noarch.rpm 
./django-profiles.spec: W: invalid-url Source0: django-profiles.tar.bz2
django-profiles.src: W: invalid-url Source0: django-profiles.tar.bz2
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683218] Review Request: drizzle7 - A Lightweight SQL Database for Cloud and Web

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683218

--- Comment #6 from BJ Dierkes wdier...@rackspace.com 2011-11-14 15:56:21 EST 
---
There has been a shortage of development resources upstream... meaning,
development has slowed drastically as of several months ago.  There have been
no followup  releases to the stable branch which has kept me from moving
forward with this package in Fedora/EPEL.  The next GA release is around the
corner so it makes sense just to wait for that release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744433] Review Request: libquvi - A cross-platform library for parsing flash media stream

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744433

Nicoleau Fabien nicoleau.fab...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2011-11-14 16:14:39

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749132] Review Request: dpm-dsi - Disk Pool Manager (DPM) plugin to GridFTP

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749132

--- Comment #38 from Steve Traylen steve.tray...@cern.ch 2011-11-14 16:31:22 
EST ---
Did a bit more digging.

So 32 bit packages make it into the 64 repository if they end in a '-devel'.
Of course they pull in all their dependencies as well. So when 

globus-gridftp-server-devel.i686  is selected it pulls in 
globus-gridftp-server.i686 but not globus-gridftp-server-progs.i686.

So that's why its missing but as mentioned why would you ever want this
progs package at 32 bit on a 64 bit machine.

Drop the %{_isa} tag and it should go way.

why no epel6 error, simple autoqa is not running :-)
and epel5 %{?_isa} is  anyway.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751925] Review Request: python-tables - Hierarchical datasets in Python

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751925

--- Comment #11 from Thibault North thibault.no...@gmail.com 2011-11-14 
16:34:44 EST ---
Thank you Brendan.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744339] Review Request: dieharder - Random number generator tester and timer

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744339

--- Comment #10 from Jiri Hladky hladky.j...@gmail.com 2011-11-14 16:34:36 
EST ---
Hi Richard,

thanks for your comments.

I have cleaned-up a SPEC file a little bit, removing some unnecessary
comments:-) 

 1. The release tag should start with 1, not 0.

I didn't know that, fixed.

 2. If you're not going to build for EL 5 you can remove the following from 
 your
spec file:
My intention was to provide rpm for EPEL-5, EPEL-6. The developer has stated
that he has used RHEL and Fedora to develop the software. I think it woould be
nice to provide packages for RHEL.

 3. The devel subpackage should be arch specific.
Fixed.

 4. Leave the * off of.
Fixed.

I have uploaded new version of SPEC file and source rpm to this location:

Spec URL: http://jhladky.fedorapeople.org/dieharder.spec
SRPM URL: http://jhladky.fedorapeople.org/dieharder-3.31.1-1.fc16.src.rpm

Thanks
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 751925] Review Request: python-tables - Hierarchical datasets in Python

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751925

--- Comment #12 from Thibault North thibault.no...@gmail.com 2011-11-14 
16:36:07 EST ---
New Package SCM Request
===
Package Name: python-tables
Short Description: Hierarchical datasets in Python
Owners: tnorth
Branches: f15 f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744339] Review Request: dieharder - Random number generator tester and timer

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744339

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com
   Flag||fedora-review?

--- Comment #11 from Richard Shaw hobbes1...@gmail.com 2011-11-14 16:50:50 
EST ---
Ok, I went ahead and built the package, which was successfuly on my Fedora 15
x86_64 system, so that's good. 

A couple of things:

1. Here's the rpmlint output of the installed package. There's things rpmlint
can catch here that it can't from just checking the package:

$ rpmlint dieharder
dieharder.x86_64: I: enchant-dictionary-not-found en_US
dieharder.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdieharder.so.3.31.1 /usr/lib64/libgslcblas.so.0
dieharder.x86_64: W: shared-lib-calls-exit /usr/lib64/libdieharder.so.3.31.1
exit@GLIBC_2.2.5
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

In this case it caught an unused shared library dependency (see below). This
isn't a showstopper but should be reported upstream. The configure script
probably just needs to be tweaked. 

$ rpmlint -I unused-direct-shlib-dependency
unused-direct-shlib-dependency:
The binary contains unused direct shared library dependencies.  This may
indicate gratuitously bloated linkage; check that the binary has been linked
with the intended shared libraries only.

2. You don't need the * glob in %files for %{_bindir}/%{name} since there's
nothing else to glob.

I'll start the full review when I get a chance. Perhaps tonight or tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744339] Review Request: dieharder - Random number generator tester and timer

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744339

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 743615] Review Request: nagios-plugins-openmanage - Nagios plugin to monitor hardware health on Dell servers

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=743615

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org

--- Comment #3 from Thomas Spura toms...@fedoraproject.org 2011-11-14 
16:50:01 EST ---
(In reply to comment #2)
 (In reply to comment #1)
  Would be nice if you could create a FAS account and do a koji scratch build.
 
 Yes, I will.

Any news here? :)

As you are searching for a sponsor and this is your only review request so far,
have you done some informal review requests yet?

For more information on how to get sponsored see:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Submitting_quality_new_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698692

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version||grilo-plugins-0.1.15-4.fc15
 Resolution|NEXTRELEASE |ERRATA

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2011-11-14 17:24:40 EST ---
grilo-plugins-0.1.15-4.fc15, grilo-0.1.15-3.fc15 has been pushed to the Fedora
15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744349] Review Request: python-rtslib - python lib to configure TCM/LIO kernel target

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744349

--- Comment #2 from Andy Grover agro...@redhat.com 2011-11-14 17:32:37 EST ---
Updated spec URL:
http://fedorapeople.org/gitweb?p=grover/public_git/python-rtslib.git;a=blob;f=python-rtslib.spec;h=58ab9c5f68fec5b9b8e6b8295097714eecb31cdf;hb=3e5f448a6b0436a88f836be1f4a4765e71cdeff2

Updated SRPM URL:
http://grover.fedorapeople.org/srpms/python-rtslib-1.99.1.git644eece-8.el6.src.rpm

Changed checkout instructions to use gzip -n option, hopefully this will help
create a tarball with identical bits:

758c519cad364f290320918719db71ea  rtslib-1.99.1.git644eece.tar.gz

Fixed other issues, thanks as always!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737286] Review Request: salt - A parallel remote execution system

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737286

--- Comment #2 from Thomas Spura toms...@fedoraproject.org 2011-11-14 
17:38:45 EST ---
Ping, any news here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 719103] Review Request: media-explorer - Media centre application

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719103

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||media-explorer-0.3.2-1.fc16
 Resolution||ERRATA
Last Closed||2011-11-14 17:28:29

--- Comment #27 from Fedora Update System upda...@fedoraproject.org 
2011-11-14 17:28:29 EST ---
media-explorer-0.3.2-1.fc16 has been pushed to the Fedora 16 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753577] Review Request: gmsh - finite element grid generator

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753577

--- Comment #3 from Alexey Vasyukov vasyu...@gmail.com 2011-11-14 17:40:23 
EST ---
I wrote patches and made some changes to Spec.

Regarding the issues mentioned:
- ANN library - fixed by patch, using system ANN now
- MPEG - disabled just as Tetgen and Metis

Regarding contrib directory. It contains:
- ANN - unmodified ANN - replaced with system copy of ANN
- bamg - modified bamg
- Chaco - modified Chaco
- DiscreteIntegration - separate sub-module of Gmsh itself
- Fl_Tree - modified Fl_Tree widget for FLTK UI
- gmm - unmodified GMM - replaced with system copy of GMM
- kbipack - separate sub-module of Gmsh itself
- MathEx - unmodified MathEx, part of SSCILIB - Fedora does not ship SSCILIB
- Metis - disabled in our build
- mpeg_encode - disabled in our build
- NativeFileChooser - modified NativeFileChooser widget for FLTK UI
- Netgen - modified Netgen
- Tetgen - disabled in our build

Contrib dir summary:
- ANN, gmm - replaced with system copies
- Metis, mpeg_encode, Tetgen - disabled
- DiscreteIntegration, kbipack - sub-modules of Gmsh itself
- bamg, Chaco, Fl_Tree, NativeFileChooser, Netgen - modified, derived works
- MathEx - unmodified, not in Fedora


New spec: http://dl.dropbox.com/u/4532412/RPMS/gmsh.spec
New SRPM: http://dl.dropbox.com/u/4532412/RPMS/gmsh-2.5.0-5.fc16.src.rpm

Summary of changes:
* Mon Nov 14 2011 Alexey Vasyukov vasyu...@gmail.com - 2.5.0-5
- Disable MPEG support because of patent issues
- Add patch to use system ANN instead of built-in one
- Add patch to use system GMM instead of built-in one
- Update CMake soname patch to avoid hardcoded numbers

+ rpmlint output (incorrect-fsf-address, spurious-executable-perm,
shared-lib-calls-exit) reported upstream


The questions:

#1 There are 3 'bad' components - MPEG with patent issues plus Tetgen and Metis
with non-commercial only clause. I disabled them now with CMake options. Is it
enough or should I remove support for them completely from sources?

#2 How to deal with contrib dir correctly? I guess, I should package MathEx
(SSCILIB) separately and leave derived works (dirs bamg/, Chaco/, Fl_Tree/,
NativeFileChooser/, Netgen/) in contribs. Is it so?

Any comments and/or suggestions?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753513] Review Request: minetest - Multiplayer infinite-world block sandbox with survival mode

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753513

--- Comment #1 from Aleksandra Bookwar al...@bookwar.info 2011-11-14 17:50:34 
EST ---
I've fixed the %clean section and %defattr according to guidelines.

New URLs:

Spec URL: https://raw.github.com/RussianFedora/minetest/fedora/minetest.spec
SRPM URL:
http://koji.russianfedora.ru/koji/getfile?taskID=16122name=minetest-0.3.1-4.gitbc0e5c0.fc16.src.rpm

$ rpmlint minetest
minetest.x86_64: W: spelling-error Summary(en_US) Multiplayer - Multiplier,
Multiplexer
minetest.x86_64: W: spelling-error %description -l en_US multiplayer -
multiplier, multiplexer
minetest.x86_64: W: no-documentation
minetest.x86_64: W: no-manual-page-for-binary minetest
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpmlint minetest-server
minetest-server.x86_64: W: spelling-error Summary(en_US) multiplayer -
multiplier, multiplexer
minetest-server.x86_64: W: spelling-error %description -l en_US multiplayer -
multiplier, multiplexer
minetest-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/minetest
minetest-server.x86_64: W: non-standard-uid /var/lib/minetest minetest
minetest-server.x86_64: W: non-standard-gid /var/lib/minetest minetest
minetest-server.x86_64: W: no-manual-page-for-binary minetestserver
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

$ rpmlint ~/rpmbuild/SRPMS/minetest-0.3.1-4.gitbc0e5c0.fc16.src.rpm 
minetest.src: W: spelling-error Summary(en_US) Multiplayer - Multiplier,
Multiplexer
minetest.src: W: spelling-error %description -l en_US multiplayer -
multiplier, multiplexer
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=748180

Theodore Lee theo...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|theo...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 689056] Review Request: lmd - Linux Malware Detecter

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=689056

--- Comment #8 from Mark McKinstry mmcki...@nexcess.net 2011-11-14 20:35:26 
EST ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 748180] Review Request: dbus-sharp-glib - C# bindings for D-Bus glib main loop integration

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=748180

Theodore Lee theo...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #10 from Theodore Lee theo...@gmail.com 2011-11-14 20:34:55 EST 
---
Okay, I'll take over this review.

MUST Items
==

OK - rpmlint must be run on all rpms

$ rpmlint dbus-sharp-glib-0.5.0-1.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint dbus-sharp-glib-0.5.0-1.fc16.x86_64.rpm
dbus-sharp-glib-devel-0.5.0-1.fc16.x86_64.rpm
dbus-sharp-glib.x86_64: E: no-binary
dbus-sharp-glib.x86_64: W: only-non-binary-in-usr-lib
dbus-sharp-glib-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

After install:
$ rpmlint dbus-sharp-glib
dbus-sharp-glib.x86_64: E: no-binary
dbus-sharp-glib.x86_64: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

These errors seem to be the usual ones seen with mono packages, nothing
significant.

OK - Package must meet naming guidelines
OK - Spec file name must match base package name
OK - Package must meet packaging guidelines
OK - Package must meet licensing guidelines
OK - License tag must match actual license
OK - Any license files must be in %doc
OK - Spec file must be in American English
OK - Spec file must be legible
OK - Sources must match upstream

$ sha1sum dbus-sharp-glib-0.5.0.tar.gz dbus-sharp-glib-0.5.0.tar.gz.fedora
bff1d3e8def9f5c7f956adffdef3a860a05e0e95  dbus-sharp-glib-0.5.0.tar.gz
bff1d3e8def9f5c7f956adffdef3a860a05e0e95  dbus-sharp-glib-0.5.0.tar.gz.fedora

OK - Package must build on at least one primary arch
OK - Arches that the package doesn't build on must be excluded with a relevant
bug

In this case mono simply isn't available on some arches, so I don't think this
is a blocking issue.

OK - All necessary build dependencies must be in BuildRequires
N/A - Locales must be handled properly
N/A - Binary rpms containing libraries must call ldconfig
OK - Package must not bundle system libraries
N/A - Relocatable packages must have rationalization
OK - Package must own all directories it creates
OK - Package must not list a file more than once in %files
OK - Files must have correct permissions
OK - Macros must be consistent
OK - Package must contain code or permissible content
N/A - Large documentation files must be in a -doc subpackage
OK - %doc files must not affect program operation
N/A - Header files must be in a -devel subpackage
N/A - Static libraries must be in a -static package
N/A - Library files that end in .so must go in a -devel package
OK - -devel packages must require the base package using a fully versioned
dependency
OK - Package must NOT contain any .la libtool archives
N/A - Packages containing GUI applications must include a %{name}.desktop file
OK - Packages must not own files or directories already owned by other packages
OK - All filenames in rpm packages must be valid UTF-8

SHOULD Items


N/A - If the package is missing license text in a separate file, the packager
should query upstream for it
N/A - Description and summary should contain translations if available
OK - Package should build in mock
OK - Package should build on all supported architectures

Koji scratch build seems okay:
https://koji.fedoraproject.org/koji/taskinfo?taskID=3511249

OK - Package should function as described

Built and used banshee-2.2 against this, and it seems to be working well.

N/A - Scriptlets should be sane
N/A - Non-devel subpackages should require the base package with a full version
OK - pkgconfig files should be placed appropriately
N/A - File dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
should require package instead
N/A - Binaries/scripts should have man pages

Mono-specific Items
===

OK - DLLs must be registered with gacutil
OK - .pc files must be in a -devel package
OK - Empty -debuginfo packages must not be built
OK - Package must NOT contain any pre-compiled .dll or .exe files
OK - Package must NOT contain .dll files from other projects
OK - Package should not redefine _libdir

Issues
==

1) There's no link to a tracking bug for the architectures that this package
doesn't build on. However, this is something that covers pretty much all mono
packages, so I don't think that's too important.

2) The main package description is missing a full stop, and the description for
the -devel package should probably mention GLib at some point.

None of these issues are blocking, so I think this package can be ACCEPTED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 750139] Review Request: lv2-mdala-plugins - LV2 port of the MDA VST plugins

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=750139

--- Comment #1 from Brendan Jones brendan.jones...@gmail.com 2011-11-14 
23:43:18 EST ---
A minor update

SPEC: http://bsjones.fedorapeople.org/lv2-mdala-plugins.spec
SRPM:
http://bsjones.fedorapeople.org/lv2-mdala-plugins-0-0.2.svn3580.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737286] Review Request: salt - A parallel remote execution system

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737286

--- Comment #3 from Clint Savage her...@gmail.com 2011-11-14 23:44:52 EST ---
Indeed there is news. I am working on packaging up 0.9.3 this week. I've been a
bit under water with the dayjob, but I think I've found some time to update
this ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 754004] New: Review Request: lv2-abGate - an LV2 Noise Gate plugin

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lv2-abGate - an LV2 Noise Gate plugin

https://bugzilla.redhat.com/show_bug.cgi?id=754004

   Summary: Review Request: lv2-abGate - an LV2 Noise Gate plugin
   Product: Fedora
   Version: 16
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: brendan.jones...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---


A simple LV2 noise gate plugin for use in hosts that support LV2

SPEC: http://bsjones.fedorapeople.org/lv2-abGate.spec
SRPM: http://bsjones.fedorapeople.org/lv2-abGate-1.1.3-1.fc16.src.rpm

RPMLINT:
rpmlint /home/bsjones/rpmbuild/SRPMS/lv2-abGate-1.1.3-1.fc16.src.rpm
/home/bsjones/rpmbuild/RPMS/x86_64/lv2-abGate*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753677] Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753677

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-11-15 01:03:18 EST 
---
Review:-
+ koji build -http://koji.fedoraproject.org/koji/taskinfo?taskID=3514553
+ rpmlint on package gave
gnome-shell-extension-noa11y.noarch: W: no-version-in-last-changelog
gnome-shell-extension-noa11y.noarch: W: invalid-url URL Note
gnome-shell-extension-noa11y.noarch: W: no-documentation
gnome-shell-extension-noa11y.noarch: W: empty-%postun
gnome-shell-extension-noa11y.src: W: no-version-in-last-changelog
gnome-shell-extension-noa11y.src: W: invalid-url URL Note
gnome-shell-extension-noa11y.src: E: invalid-spec-name
gnome-shell-extension-noa11y.src:2: W: mixed-use-of-spaces-and-tabs (spaces:
line 2, tab: line 1)
gnome-shell-extension-noa11y.src: W: invalid-url Source0:
noa...@hedayaty.gmail.com.tar.gz
2 packages and 0 specfiles checked; 1 errors, 8 warnings.

suggestions:
1) you don't need now following in current active Fedora releases.
%defattr (-,root,root,-)

and in %install
rm -rf %{buildroot}

2) add the version-release information in changelog like
* Sun Nov 13 2011 Amir Hedayaty hedayaty AT gmail DOT com- 0-0.1
- Initial package for Fedora

3) you can remove warning mixed-use-of-spaces-and-tabs by using command
sed -e 's|\t| |g' gnome-shell-extension-noa11y.spec

3) I see you have wrong spec file added in srpm. you added
gnome-shell-extension-no11y.spec whereas it should be
gnome-shell-extension-noa11y.spec

4) you don't need %postun in spec file. remove that.

5) Host your tarball on some server and use that download url in URL of spec.


submit a new SPEC and SRPM by fixing above issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753676] Review Request: gnome-shell-extention-netspeed -an internet speed indicator

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753676

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-11-15 01:07:22 EST 
---
Review:-
+ koji build -http://koji.fedoraproject.org/koji/taskinfo?taskID=3514555
+ rpmlint on package gave
gnome-shell-extension-netspeed.noarch: W: no-version-in-last-changelog
gnome-shell-extension-netspeed.noarch: W: invalid-url URL Note
gnome-shell-extension-netspeed.noarch: W: no-documentation
gnome-shell-extension-netspeed.noarch: W: empty-%postun
gnome-shell-extension-netspeed.src: W: no-version-in-last-changelog
gnome-shell-extension-netspeed.src: W: invalid-url URL Note
gnome-shell-extension-netspeed.src:2: W: mixed-use-of-spaces-and-tabs (spaces:
line 2, tab: line 1)
gnome-shell-extension-netspeed.src: W: invalid-url Source0:
netsp...@hedayaty.gmail.com.tar.gz
2 packages and 0 specfiles checked; 0 errors, 8 warnings.


suggestions:
1) you don't need now following in current active Fedora releases.
%defattr (-,root,root,-)

and in %install
rm -rf %{buildroot}

2) add the version-release information in changelog like
* Sun Nov 13 2011 Amir Hedayaty hedayaty AT gmail DOT com- 0-0.1
- Initial package for Fedora

3) you can remove warning mixed-use-of-spaces-and-tabs by using command
sed -e 's|\t| |g' gnome-shell-extension-netspeed.spec

3) I see you have wrong spec file added in srpm. you added
gnome-shell-extension-no11y.spec whereas it should be
gnome-shell-extension-noa11y.spec

4) you don't need %postun in spec file. remove that.

5) Host your tarball on some server and use that download url in URL of spec.


submit a new SPEC and SRPM by fixing above issues.


Add some document files in upstream tarball that tells how to install this
extension as well as license information and its text in a separate file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 750997] Review Request: scilab - Scientific software package for numerical computations

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=750997

Clément DAVID c.davi...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753911] Review Request: django-profiles - A fairly simple user-profile management application for Django

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753911

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-11-15 01:59:46 EST 
---
Review:-
+ koji build -http://koji.fedoraproject.org/koji/taskinfo?taskID=3514594
+ rpmlint on package gave
django-profiles.src: W: invalid-url Source0: django-profiles.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source matches upstream (sha1sum) as
5a94560b95f64dc3b786701647876484  django-profiles.tar.bz2
5a94560b95f64dc3b786701647876484  ../SOURCES/django-profiles.tar.bz2
+ Follows packaging guidelines.

suggestions:
1) you don't need now following in current active Fedora releases.
%defattr (-,root,root,-)

and in %install
rm -rf $RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753911] Review Request: django-profiles - A fairly simple user-profile management application for Django

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753911

--- Comment #2 from Matthias Runge mru...@matthias-runge.de 2011-11-15 
02:13:31 EST ---
Parag,

thank you for your review. I'd need this for epel 6, too, so I keep both
sections.

Source URL: I was unable to create a something conveniant file name, since
there has been a 0.2 release some time ago, followed by a patch, which is
absolutely useful. So I fetched the latest version from repository (called
default.tar.bz2). default.tar.bz2 is not a useful name of a file, I think. So I
noted, how I retrieved the file, a md5sum to verify, the right file was
retrieved and named the file how in a way more usable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 754023] New: Review Request: Mumpot - GTK mapping application

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Mumpot - GTK mapping application

https://bugzilla.redhat.com/show_bug.cgi?id=754023

   Summary: Review Request: Mumpot - GTK mapping application
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: volke...@gmx.at
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---


Spec URL: http://www.geofrogger.net/review/mumpot.spec
SRPM URL: http://www.geofrogger.net/review/mumpot-0.6-1.fc16.src.rpm

Description:

Mumpot is a GTK mapping application with simple editing features
(for editing OpenStreetMap data) mainly (but not only) for use 
with mobile Linux equipped devices, tested on a GPE installation
on an iPAQ2200 and on the Openmoko platform.

Mumpot can connect to a GPS, which provides NMEA-Data. It can down-
and upload OSM data and also search for shortest paths.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 752836] Review Request: perl-Class-Field - Class Field Accessor Generator

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752836

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+

--- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-11-15 02:23:40 EST 
---
Review:-
+ koji build -http://koji.fedoraproject.org/koji/taskinfo?taskID=3514609
+ rpmlint on package gave
perl-Class-Field.src: W: spelling-error %description -l en_US const - cons,
cont, cost
perl-Class-Field.noarch: W: spelling-error %description -l en_US const - cons,
cont, cost
+ Source match with upstream as (sha1sum)
908a42ded2f16a5066313a8cd20ed41a6de599b8  Class-Field-0.15.tar.gz
908a42ded2f16a5066313a8cd20ed41a6de599b8  ../SOURCES/Class-Field-0.15.tar.gz
+ Follows packaging guidelines.
+ make test shows
All tests successful.
Files=3, Tests=14,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.08 cusr  0.01
csys =  0.12 CPU)
+ Package  perl-Class-Field-0.15-1.fc17.noarch
  Provides: perl(Class::Field) = 0.15
  Requires: perl = 0:5.006001 perl(Encode) perl(Exporter) perl(base)
perl(strict) perl(utf8) perl(warnings)


Suggestions:
1) you don't need to specify following
BuildRequires:  perl = 1:5.6.1

2) For the active fedora releases you can remove following from spec
 a) buildroot
 b) cleaning of buildroot in %install
 c) %clean section
 d) %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 710386] Review Request: gnome-shell-extension-system-monitor-applet - A Gnome shell system monitor extension

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710386

Rahul Sundaram methe...@gmail.com changed:

   What|Removed |Added

 CC||methe...@gmail.com

--- Comment #34 from Rahul Sundaram methe...@gmail.com 2011-11-15 02:36:24 
EST ---

No.  Go ahead

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753676] Review Request: gnome-shell-extention-netspeed -an internet speed indicator

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753676

--- Comment #2 from Amir Hedayaty heday...@gmail.com 2011-11-15 02:42:24 EST 
---
Thanks for feedback here are the new urls:

Spec URL:
http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed.spec
SRPM URL:
http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed-3.2.0-1.src.rpm


This extension was something which was missing from gnome 3.0, I wrote this a
while ago, now it is in a better shape I guess now I share share it with other
users. I am looking for getting feedback/patches from fedora users.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753677] Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area

2011-11-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753677

--- Comment #2 from Amir Hedayaty heday...@gmail.com 2011-11-15 02:40:06 EST 
---
Thanks for the feedback I hope the issue are fixed!
Here are the new urls:

Spec URL:
www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y.spec
SRPM URL:
www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y-3.2.0-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review