[Bug 683463] Review Request: trafficserver - Apache Traffic Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683463 --- Comment #38 from Jan-Frode Myklebust janfr...@tanso.net 2011-12-08 03:41:37 EST --- Updated to upstream release v3.0.2. Also added a small patch to correct condrestart() in initscript (fixed in v3.1). http://blag.tanso.net/code/ats/v3.0.2-0/trafficserver.spec http://blag.tanso.net/code/ats/v3.0.2-0/trafficserver-3.0.2-0.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754137] Review Request: nagios-plugins-bdii - Nagios Probe for the BDII
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754137 --- Comment #21 from laurence.fi...@cern.ch 2011-12-08 05:37:29 EST --- The description is consistent with other nagios plugins rpm -qli nagios-plugins-ldap Description: Provides check_ldap support for Nagios. rpm -qli nagios-plugins-http Description: Provides check_http support for Nagios. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760835] Review Request: wto - WebTv Orange standalone client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760835 Matthieu Saulnier casper.le.fan...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||ERRATA Last Closed||2011-12-08 05:17:13 --- Comment #2 from Matthieu Saulnier casper.le.fan...@gmail.com 2011-12-08 05:17:13 EST --- Okay I'll submit it for rpm-fusion repository, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728504] Review Request: jboss-sasl - SASL Provider for J2SE
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728504
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com
Flag||fedora-review?
--- Comment #7 from Alexander Kurtakov akurt...@redhat.com 2011-12-08
05:14:20 EST ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[-]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
rpmlint jboss-sasl-1.0.0-0.1.Beta9.fc17.src.rpm
jboss-sasl.src: W: invalid-url Source0: jboss-sasl-1.0.0.Beta9.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fine.
rpmlint jboss-sasl-1.0.0-0.1.Beta9.fc17.noarch.rpm
jboss-sasl.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint jboss-sasl-javadoc-1.0.0-0.1.Beta9.fc17.noarch.rpm
jboss-sasl-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java
docs, Java-docs, Avocados
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Not blockers.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
jboss-sasl-1.0.0.Beta9.tar.xz :
MD5SUM this package : f244597acf6bd61bdabcd4ff7ffb74f4
MD5SUM upstream package : upstream source not found
Instructions for generation given.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
upstream.
[-]: SHOULD SourceX is a working URL.
[x]: SHOULD Description
[Bug 752223] Review Request: racoon2 - an implementation of key management system for IPsec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752223 --- Comment #35 from Matěj Cepl mc...@redhat.com 2011-12-08 04:08:15 EST --- bug 753354 is related -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749299] Review Request: lcgdm-dav - HTTP/DAV frontend to the DPM/LFC services
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=749299
--- Comment #13 from Ricardo Rocha rocha.po...@gmail.com 2011-12-08 06:09:12
EST ---
Hi.
(In reply to comment #11)
Hi,
The explicit
%if %{?fedora}%{!?fedora:0} = 10 || %{?rhel}%{!?rhel:0} = 6
BuildRequires: libcurl-devel
%else
BuildRequires: curl-devel
%endif
on devel package is not needed, it's there on the main package which
is good enough.
Removed.
Regarding the static html files
/var/www/css
/var/www/css/lcgdm-dav.css
/var/www/icons
/var/www/icons/dpm20.png
these are a web application so move them to
/usr/share/lcgdm-dav
and update alias to use them.
http://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications
In fact they were there before, i just thought it would be better in /var/www
(should have double checked the guidelines). Moved to /usr/share/lcgdm-dav as
suggested.
Also the httpd configuration takes of the web server with
Location /
DAV dpm
/Location
so now everything is dpmdav regardless of what else is installed.
could this be restricted to some default path prefix?
Changed to:
Location /dpm
DAVBase /dpm
which only enables the app for /dpm paths, and add /dpm to any relative path so
that we build the full DPM namespace when contacting the nameserver.
It works... the only disadvantage is that you can only start the listing from
/dpm, you cannot list / anymore - not very serious though, as /dpm is mandated
for all installations.
Also the configuration contains:
ProxyCache /var/proxycache
this directory does not exist but more importantly it if is needed
it should be in /var/lib/lcgdpm-dav or something.
This is hard-coded in the gridsite delegation cgi, nothing we can do about it
(i can submit a bug though). This is an optional feature though, it won't be
used if no gridsite-delegation is installed.
In addition:
- scriplets reload httpd now
- modules are loaded conditionally
But for the modules even conditional loading is not perfect, as for example SSL
is loaded by lcgdm-dav (triggered first and it has to be there for the
lcgdm-dav provider to be able to load), but ssl.conf does not conditionally
load, so you still get the warning.
I don't think renaming the conf file to zlcgdm-dav.conf is a very good idea to
prevent this - other people would do the same and it wouldn't look very nice.
New spec and src rpm:
http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav.spec
http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav-0.5.3-1.src.rpm
Koji builds as soon as koji works again.
Thanks,
Ricardo
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761094] Review Request: asn1c - An ASN.1 Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761094 Jakub Hrozek jhro...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761094] Review Request: asn1c - An ASN.1 Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761094 Jakub Hrozek jhro...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Jakub Hrozek jhro...@redhat.com 2011-12-08 07:20:43 EST --- I see one issue with the package - it creates both /usr/share/doc/asn1c-0.9.21/ and /usr/share/doc/asn1c/ with contents that look the same to me. Other than that, this package is OK. The sheer number of rpmlint warnings can't be avoided in this case, the code needs to be available at runtime in order for asn1c to work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755484] Review Request: maven-toolchains-plugin - Maven plugin for sharing configuration across projects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755484 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mgold...@redhat.com AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com Flag||fedora-review? --- Comment #5 from Marek Goldmann mgold...@redhat.com 2011-12-08 06:21:14 EST --- I'll take it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #16 from Mo Morsi mmo...@redhat.com 2011-12-08 06:50:24 EST ---
(In reply to comment #15)
Ack! Sorry I keep finding stuff :)
1. There's no documentation in the main package. I would include a line like
this, with our without the PDF depending on if it's relevant:
%files
%doc CHANGELOG LICENSE README docs/paper.pdf
... rest of %files section ...
Done
2. Do we need python2 if we're building with python3?
If not change your BuildRequires to:
%if 0%{?with_python3}
BuildRequires: python3-devel
%else
BuildRequires: python2-devel
%endif # if with_python3
I believe the original way is the correct way. At least every package I've seen
does not conditionalize the BR: python2-devel and it is this way in the
guidelines as well
http://fedoraproject.org/wiki/Packaging:Python
BTW also fixed the DEFAULT_SNAPFILE bug (this will be shipped in the first
release after this RPM gets into Fedora, though you can manually apply the fix
for now if you want)
https://github.com/movitto/snap/commit/7a53119b1d5bd048a4ddfbdf5bf9962f3d5699dc
New uploads:
New Spec: http://mo.morsi.org/files/rpms/snap.spec
New SRPM: http://mo.morsi.org/files/rpms/snap-0.5-6.fc15.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] New: Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: ibus-european-table - Predictive text for european languages https://bugzilla.redhat.com/show_bug.cgi?id=761474 Summary: Review Request: ibus-european-table - Predictive text for european languages Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: apa...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL:https://github.com/gnuman/fedora_package/blob/master/ibus-european-table.spec SRPM URL: https://github.com/gnuman/fedora_package/blob/master/ibus-european-table-1.1.0-1.fc15.src.rpm Description: The ibus-european-table predict the text so that typing makes easy for user -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757156] Review Request: perl-Env-C - Get/Set/Unset Environment Variables on the C level
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=757156
--- Comment #10 from Paul Howarth p...@city-fan.org 2011-12-08 06:56:24 EST
---
(In reply to comment #8)
OK, here is the quoted discussion with the upstream package author. Lines
prefixed with are mine, and lines prefixed with : are written by the
package author:
: : Personally, I don't really care which exact of the free-as-a-beer
: : license is used, GPL, Artistic XYZ, or whatever you'd like it to be.
:
:OK. So the same terms as Perl itself would be OK with you?
: [...]
:So if you say the same terms as Perl itself or Artistic 2.0
: or Artistic clarified is OK with you, I would be able to package
: Env::C for Fedora.
:
: Yes, either of the above works. I doubt I'll release a new version of
: the module just to tweak this, unless it's really important. Perhaps
: you can just quote this communication as a proof.
Is it sufficient to have it this way and keep License: Artistic 2.0
in the spec file?
Yes, but include the email from the author saying this is OK as one of the %doc
files in the package. That's what happened a while back for perl-NetAddr-IP,
which had the same issue.
http://pkgs.fedoraproject.org/gitweb/?p=perl-NetAddr-IP.git;a=blob;f=License_of_perl-NetAddr-IP.txt;h=661544743aa94efa0c8e55501ffb6a755c5dd921;hb=b803a15fae9080ce0fd35bbdaab73fd168d0d275
(In reply to comment #9)
Re: comment #7
Regarding your plans for participation in Fedora, do you see yourself
sticking
to perl modules or might you have other things to bring in in the future?
I want to contribute packages which I need myself, but recently everything I
have needed was already packaged except some Perl modules. So for now, I will
stick with Perl modules. (context: I have been building RPM packages for at
least 12 years now, does anybody here remember Red Hat Contrib|Net, the early
community packaging effort for Red Hat Linux?).
The issue here is that perl module packages tend to be very formulaic and
generally don't need much tweaking from what you get out of cpanspec. As a
result, package submissions of perl modules don't provide much insight into
your understanding of packaging in general or the Fedora guidelines in
particular. The usual approach to demonstrating this understanding is to do
unofficial reviews of other packages like Willington did for this one (though
preferably not just perl modules).
Are there any more leaf packages, that don't have any non-Fedora
dependencies?
E.g. perl-TeX-Encode, perl-Scalar-String, perl-IO-Socket-Multicast,
perl-Data-Integer, perl-Data-Float, or perl-DBD-ODBC.
If there's any of those with anything unusual about them, submit that, else
pick one at random for now.
Also, they all currently have
the problem mentioned in comment #1 (directory ownership of
%{perl_vendorarch}... as created by cpanspec).
This is more a matter of taste.
Well, perhaps the Packaging:Perl wiki page should be modified to not have this
requirements then? (I cannot check the exact wording as Fedora wiki currently
says 503 Service Unavailable for me).
Maybe the wording could be clearer. The guideline is talking about which
directories must be owned by the package, by way of some sample %files entries.
The important bit is the directory ownership rather than the implementation
though.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761474] Review Request: ibus-european-table - Predictive text for european languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761474 anish apa...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 697247] Review Request: gsmartcontrol - Graphical user interface for smartctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697247 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2011-12-08 07:58:44 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732480] Review Request: gofer - An extensible, light weight, universal python agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732480 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Blocks|743402 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745993] Review Request: rubygem-useragent - HTTP User Agent parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745993 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Blocks|743402 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 730227] Review Request: jboss-transaction-1.1-api - Transaction 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730227 --- Comment #10 from Marek Goldmann mgold...@redhat.com 2011-12-08 08:51:27 EST --- Rich? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741900] Review Request: grinder - A tool for synchronizing repositories and their contents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741900 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Blocks|743402 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588428] Review Request: rubygem-addressable - Improved URI/URL handling
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588428 --- Comment #18 from Mo Morsi mmo...@redhat.com 2011-12-08 08:04:23 EST --- ping? Can we get this into Fedora / close this out now. Thanks alot. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760897] Review Request: libeasyfc - Easy configuration generator interface for fontconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760897 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2011-12-08 08:03:59 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #17 from Richard Shaw hobbes1...@gmail.com 2011-12-08 09:28:50
EST ---
2. Do we need python2 if we're building with python3?
If not change your BuildRequires to:
%if 0%{?with_python3}
BuildRequires: python3-devel
%else
BuildRequires: python2-devel
%endif # if with_python3
I believe the original way is the correct way. At least every package I've
seen
does not conditionalize the BR: python2-devel and it is this way in the
guidelines as well
http://fedoraproject.org/wiki/Packaging:Python
I think the section of the python guidelines you're referring to are if you're
building for *BOTH* python2 and python3[1]. I believe in your case it's an
either/or, so it shuold be conditionalized.
Let me know if that is not the case.
BTW also fixed the DEFAULT_SNAPFILE bug (this will be shipped in the first
release after this RPM gets into Fedora, though you can manually apply the fix
for now if you want)
https://github.com/movitto/snap/commit/7a53119b1d5bd048a4ddfbdf5bf9962f3d5699dc
Is there any reason not to include this fix as a patch?
Richard
[1] http://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||CURRENTRELEASE Last Closed||2011-12-08 07:44:59 --- Comment #10 from Mo Morsi mmo...@redhat.com 2011-12-08 07:44:59 EST --- Closing this out as this is now in Fedora -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761559] New: Review Request: filelight - Graphical Disk Usage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: filelight - Graphical Disk Usage https://bugzilla.redhat.com/show_bug.cgi?id=761559 Summary: Review Request: filelight - Graphical Disk Usage Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rdie...@math.unl.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/filelight.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/filelight-4.7.90-1.fc16.src.rpm Description: Filelight allows you to quickly understand exactly where your diskspace is being used by graphically representing your file system. prior to kde-4.7.80, this was included in kdeutils module, but is now split out into a separate tarball and rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761559] Review Request: filelight - Graphical Disk Usage
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761559 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||656997(kde-reviews) Alias||filelight -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439337] Review Request: python-sphinx - Python documentation generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439337 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #21 from Michel Alexandre Salim michel+...@sylvestre.me 2011-12-08 10:27:27 EST --- Dan Radez is requesting this package for EPEL 6; I've tested that python-sphinx 1.0.x works fine there. Package Change Request == Package Name: python-sphinx New Branches: el6 Owners: salimma radez InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741900] Review Request: grinder - A tool for synchronizing repositories and their contents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741900 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED Last Closed||2011-12-08 09:42:12 --- Comment #4 from Mo Morsi mmo...@redhat.com 2011-12-08 09:42:12 EST --- I'm closing this out as it turns out we don't need this for aeolus. Anyone who would like to see grinder in Fedora is more than welcome to re-open and use my package as the basis for further development. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749299] Review Request: lcgdm-dav - HTTP/DAV frontend to the DPM/LFC services
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749299 --- Comment #14 from Ricardo Rocha rocha.po...@gmail.com 2011-12-08 09:40:56 EST --- Hi again. Here's another version with the fixes discussed offline. http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav.spec http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav-0.5.4-1.src.rpm Fixes done: - lcgdm-dav.conf renamed to zlcgdm-dav.conf to make sure it's loaded in order (following other packages doing the same way) - SSL* directives commented out (with instructions on how to enable them) - removed scriptlets (i gave up :-) and followed the others not doing it) Thanks, Ricardo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439337] Review Request: python-sphinx - Python documentation generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439337 --- Comment #22 from Jon Ciesla limburg...@gmail.com 2011-12-08 10:29:40 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439337] Review Request: python-sphinx - Python documentation generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439337 --- Comment #23 from Michel Alexandre Salim michel+...@sylvestre.me 2011-12-08 11:17:00 EST --- Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695233] Review Request: alien - Converter between the rpm, dpkg, stampede slp, and Slackware tgz file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695233 --- Comment #3 from Sergio Monteiro Basto ser...@serjux.com 2011-12-08 11:24:39 EST --- I want have this package too. Thanks, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #19 from Richard Shaw hobbes1...@gmail.com 2011-12-08 11:51:06 EST --- Ok, last question I hope until I do the full guideline checks... How did you include the fix? I was looking for a Patch0: ... and %patch0 ... in the spec file but it's not there. Also, I noticed you're using github. I'm not a git expert but I've noticed other projects use the tags for released versions, so in your case I would expect to see a 0.5.0 release tagged, then you would generate a patch. For instance, if you created a tag snap-0.5.0 you could use something like: git diff -p --stat snap-0.5.0 7a53119b1d5bd048a4ddfbdf5bf9962f3d5699dc snap-snapfile.patch Of course, do it first without the so you can make sure it's what you meant. If you've already included the fix, maybe just bump the patch rev and call it 0.5.1. Then you would reset your Release: tag back to 1 (but keep all the changelog history) Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890
--- Comment #18 from Mo Morsi mmo...@redhat.com 2011-12-08 11:34:49 EST ---
(In reply to comment #17)
2. Do we need python2 if we're building with python3?
If not change your BuildRequires to:
%if 0%{?with_python3}
BuildRequires: python3-devel
%else
BuildRequires: python2-devel
%endif # if with_python3
I believe the original way is the correct way. At least every package I've
seen
does not conditionalize the BR: python2-devel and it is this way in the
guidelines as well
http://fedoraproject.org/wiki/Packaging:Python
I think the section of the python guidelines you're referring to are if you're
building for *BOTH* python2 and python3[1]. I believe in your case it's an
either/or, so it shuold be conditionalized.
Let me know if that is not the case.
Makes sense. Done
BTW also fixed the DEFAULT_SNAPFILE bug (this will be shipped in the first
release after this RPM gets into Fedora, though you can manually apply the
fix
for now if you want)
https://github.com/movitto/snap/commit/7a53119b1d5bd048a4ddfbdf5bf9962f3d5699dc
Is there any reason not to include this fix as a patch?
Included the patch in the release / new rpm
Updated submission:
New Spec: http://mo.morsi.org/files/rpms/snap.spec
New SRPM: http://mo.morsi.org/files/rpms/snap-0.5-7.fc15.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761619] New: Review Request: cross-binutils - Multiple cross-build binutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: cross-binutils - Multiple cross-build binutils https://bugzilla.redhat.com/show_bug.cgi?id=761619 Summary: Review Request: cross-binutils - Multiple cross-build binutils Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dhowe...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Spec URL: http://people.redhat.com/~dhowells/cross/cross-binutils.spec SRPM URL: http://people.redhat.com/~dhowells/cross/cross-binutils-2.22-1.fc16.src.rpm Description: I've taken the Fedora 16 binutils specfile and modified it greatly so that it builds a cross-build binutils for each of the Linux kernel arches (barring cris, which doesn't build, and unicore, which doesn't seem to exist) and packages each one up in its own binary RPM (named binutils-arch-linux-gnu). The packages are configures with --program-prefix=arch-linux-gnu-. Note that the name passed to --target may not match the program prefix. For example, binutils-parisc-linux-gnu contains, amongst other things, parisc-linux-gnu-ar, and was build for target hppa-linux. As the manual pages and help files for each instance of the assembler, linker, objdump, objcopy, etc. are exactly the same, these are emitted into the core binary RPM and symlinked from the arch RPMs to save installation space and a dependency is emplaced. I would appreciate a review so that I can get this into Fedora Extra. Many thanks, David -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757866] Review Request: kde-printer-applet - KDE printer applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757866 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Summary|Review Request: |Review Request: |printer-applet - KDE|kde-printer-applet - KDE |printer applet |printer applet Alias|printer-applet |kde-printer-applet --- Comment #1 from Rex Dieter rdie...@math.unl.edu 2011-12-08 13:13:14 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet-4.7.90-1.fc16.src.rpm update to 4.7.90, renamed to kde-printer-applet -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626122] Review Request: libqmf - Qt Messaging Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626122 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 663092] Review Request: oxygen-gtk - Oxygen GTK theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663092 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661832] Review Request: kdevelop-pg-qt - A parser generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661832 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553606] Review Request: kde-plasma-birthday-reminder - Birthday Reminder Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553606 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 674738] Review Request: kamoso - Application for taking pictures and videos from a webcam
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674738 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719334] Review Request: kcolorchooser - A color chooser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719334 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719325] Review Request: libkexiv2 - An Exiv2 wrapper library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719325 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661833] Review Request: kdevelop-php - Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661833 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719323] Review Request: libkipi - Common plugin infrastructure for KDE image applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719323 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757242] Review Request: analitza - Library of mathematical features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757242 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757242] Review Request: analitza - Library of mathematical features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757242 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2011-12-08 13:17:43 --- Comment #6 from Rex Dieter rdie...@math.unl.edu 2011-12-08 13:17:43 EST --- imported -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719324] Review Request: libkdcraw - A C++ interface around LibRaw library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719324 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 604031] Review Request: kde-plasma-kprayertime - Displays Islamic prayer Time
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604031 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 668001] Review Request: nepomukcontroller - Applet to control the Nepomuk file indexer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668001 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719335] Review Request: kgamma - A monitor calibration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719335 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719327] Review Request: libksane - SANE Library interface for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719327 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719328] Review Request: gwenview - An image viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719328 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758223] Review Request: kaccessible - An accessibility bridge plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758223 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||758278(kmouth) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719341] Review Request: ksnapshot - A screen capture utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719341 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719332] Review Request: kamera - Digital camera support for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719332 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719337] Review Request: kolourpaint - An easy-to-use paint program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719337 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758278] Review Request: kmouth - A program that speaks for you
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758278 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Depends on||758223(kaccessible) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719343] Review Request: svgpart - SVG plugin for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719343 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719339] Review Request: ksaneplugin - KDE scan service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719339 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719342] Review Request: okular - A document viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719342 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 719338] Review Request: kruler - A screen ruler and color measurement tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719338 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|656997(kde-reviews) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758223] Review Request: kaccessible - An accessibility bridge plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758223 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||758234(kmag) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758234] Review Request: kmag - A screen magnifier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758234 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Depends on||758223(kaccessible) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758223] Review Request: kaccessible - An accessibility bridge plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758223 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks|656997(kde-reviews) | Alias||kaccessible -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759779] Review Request: rachota - Straightforward timetracking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759779 --- Comment #3 from Sébastien Willmann sebastien.willm...@gmail.com 2011-12-08 14:48:01 EST --- The program crashes sometimes on startup. I'm trying to fix this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #20 from Mo Morsi mmo...@redhat.com 2011-12-08 15:09:56 EST --- Agreed, will tag the release once all the changes to make the package fedora compliant are said and done. Would like to hold off on tagging the release until then though (yes a little backwards than normally done, but it keeps things cleaner / simpler). In any case shouldn't be a blocker for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588428] Review Request: rubygem-addressable - Improved URI/URL handling
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588428 --- Comment #19 from Shawn Starr shawn.st...@rogers.com 2011-12-08 15:06:25 EST --- Will push to git and build -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #21 from Richard Shaw hobbes1...@gmail.com 2011-12-08 15:20:19 EST --- Yup, not a blocker, just needed to know what your plan was. Full review to follow. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #22 from Richard Shaw hobbes1...@gmail.com 2011-12-08 15:32:31 EST --- +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: Good [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: GPLv3 [+] license field matches the actual license: Actual source is GPLv3. [+] license file is included in %doc: LICENSE [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches (b11447108c0cc0e2eb1cd249693bcde7) [+] package builds on at least one primary arch: Tested F15 x86_64 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [N] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [N] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [+] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [+] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches: Tested x86_64 [+] package functions as described: [+] sane scriptlets [+] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [+] package contains man pages for binaries/scripts *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC||jussi.leht...@iki.fi --- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2011-12-08 15:42:11 EST --- FYI, I did some work on this package in the summer, and got upstream to fix a bunch of review blockers in the package (IIRC including license boilerplates that were missing). However I did not submit it into review as I was not sure if it would have any use, since the program quite specialized. Anyway, the spec file I created (should comply to all Fedora standards) is available at http://theory.physics.helsinki.fi/~jzlehtol/rpms/ergo.spec Fabien: do you use ErgoSCF yourself? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760645] Review Request: ergo - A quantum chemistry program for large-scale self-consistent field calculations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760645 --- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi 2011-12-08 15:49:06 EST --- Also, I might be interested in sponsoring you. It'd be nice to have some help in managing scientific software in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #23 from Mo Morsi mmo...@redhat.com 2011-12-08 17:07:33 EST --- Great! Thanks alot for the review New Package SCM Request === Package Name: snap Short Description: A modular cross-platform system backup/restoration utility Owners: mmorsi Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753513] Review Request: minetest - Multiplayer infinite-world block sandbox with survival mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753513 --- Comment #14 from Aleksandra Bookwar al...@bookwar.info 2011-12-08 18:05:58 EST --- Ok, here are new URLs with fixed %docs: Spec URL: https://raw.github.com/RussianFedora/minetest/fedora/minetest.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=17871name=minetest-0.3.1-6.fc16.src.rpm And my FAS account is bookwar -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765625] New: Review Request: python-pymodbus - A Modbus Protocol Stack in Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-pymodbus - A Modbus Protocol Stack in Python https://bugzilla.redhat.com/show_bug.cgi?id=765625 Summary: Review Request: python-pymodbus - A Modbus Protocol Stack in Python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: c...@plauener.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://chkr.fedorapeople.org/review/python-pymodbus.spec SRPM URL: http://chkr.fedorapeople.org/review/python-pymodbus-0.9.0-1.fc16.src.rpm Description: Pymodbus is a full Modbus protocol implementation using twisted for its asynchronous communications core. The library currently supports the following: Client Features * Full read/write protocol on discrete and register * Most of the extended protocol (diagnostic/file/pipe/setting/information) * TCP, UDP, Serial ASCII, Serial RTU, and Serial Binary * asynchronous(powered by twisted) and synchronous versions * Payload builder/decoder utilities Server Features * Can function as a fully implemented Modbus server * TCP, UDP, Serial ASCII, Serial RTU, and Serial Binary * asynchronous(powered by twisted) and synchronous versions * Full server control context (device information, counters, etc) * A number of backing contexts (database, redis, a slave device) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753513] Review Request: minetest - Multiplayer infinite-world block sandbox with survival mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753513 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #15 from Jon Ciesla limburg...@gmail.com 2011-12-08 18:43:41 EST --- You can actually just put doc/ in the %docs section rather than individually listing files, but that's up to you. APPROVED, and I've sponsored you. Feel free to contact me with questions, etc. You can now also go back and do official reviews on the packages you started on, if you're so inclined. I'm sure the submitters would appreciate it. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755890] Review Request: Snap A modular cross-platform system backup/restore utility
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #24 from Jon Ciesla limburg...@gmail.com 2011-12-08 18:49:18 EST --- Summary name is Snap, SCM request name is snap, they should match. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753513] Review Request: minetest - Multiplayer infinite-world block sandbox with survival mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753513 Aleksandra Bookwar al...@bookwar.info changed: What|Removed |Added Flag||fedora-cvs? --- Comment #16 from Aleksandra Bookwar al...@bookwar.info 2011-12-08 19:32:13 EST --- Thanks, Jon! New Package SCM Request === Package Name: minetest Short Description: Multiplayer infinite-world block sandbox with survival mode Owners: bookwar Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760177] Review Request: knot - Authoritative DNS server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760177
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #3 from Volker Fröhlich volke...@gmx.at 2011-12-08 20:06:58 EST
---
You're not a packager yet, as far as I can see. If I'm correct, you'll need a
sponsor:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
* You can drop -n %{name}-%{version}, because that's the default
* rm -rf %{buildroot}/* should not be necessary, except you're aiming for EPEL
5 (then you'd also needed the buildroot definition)
* The sharedstatedir can replace %{_var}/lib/
* You should preserve the timestamp on the service file
* Ldconfig is not necessary, as there are no libraries in this package
* Optflags are not honoured by the compiler
* Please be a bit more precise in the changelog
* You can use the name macro in Source0 and 1
* You haven't removed %doc from the man pages
* Include COPYING, AUTHORS, RELNOTES and KNOWN_ISSUES
* License is GPLv3+, not GPLv3
* Defining prefix, sysconfdir, etc. once should be enough (make/make install)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741142] znc-infobot PackageReview - Infobot plugin for ZNC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741142 Nick Bebout n...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE Last Closed||2011-12-08 20:18:42 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753513] Review Request: minetest - Multiplayer infinite-world block sandbox with survival mode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753513 --- Comment #17 from Jon Ciesla limburg...@gmail.com 2011-12-08 20:28:34 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759855] Review Request: sslh - A SSL/SSH multiplexer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=759855
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #4 from Volker Fröhlich volke...@gmx.at 2011-12-08 20:26:36 EST
---
* License is GPLv2+, not GPL
* Please put Name before Summary
* You can use the name macro in Source0
* If you're not out for EPEL 5, you can drop buildroot, clean section and the
rm in the install section, see:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag
* Include the README file using %doc
* Don't gzip the man page on your own, rpmbuild takes care of it.
* Drop defattr and correct permissions in the install section, if necessary
* I suppose, you'll need to follow the guidelines for systemd:
http://fedoraproject.org/wiki/Packaging:Systemd
* %{_sysconfdir}/sysconfig/sslh -- Really?
* Use the optflags:
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
[makerpm@desktop SPECS]$ rpmlint
/home/makerpm/rpmbuild/RPMS/x86_64/sslh-1.10-1.fc16.x86_64.rpm
sslh.x86_64: W: spelling-error Summary(en_US) ssl - isl, sol, ssh
sslh.x86_64: W: summary-not-capitalized C ssl/ssh multiplexer
sslh.x86_64: W: invalid-license GPL
sslh.x86_64: W: conffile-without-noreplace-flag /etc/rc.d/init.d/sslh
sslh.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/sslh
sslh.x86_64: W: service-default-enabled /etc/rc.d/init.d/sslh
sslh.x86_64: W: no-reload-entry /etc/rc.d/init.d/sslh
sslh.x86_64: E: subsys-not-used /etc/rc.d/init.d/sslh
1 packages and 0 specfiles checked; 2 errors, 6 warnings.
[makerpm@desktop SPECS]$ rpmlint
/home/makerpm/rpmbuild/RPMS/x86_64/sslh-debuginfo-1.10-1.fc16.x86_64.rpm
sslh-debuginfo.x86_64: W: invalid-license GPL
sslh-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/sslh-1.10/common.h
sslh-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/sslh-1.10/common.c
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760177] Review Request: knot - Authoritative DNS server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760177 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #4 from Jon Ciesla limburg...@gmail.com 2011-12-08 20:28:00 EST --- Actually, freshly sponsored, by yours truly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759747] Review Request: sk1libs - Universal vector graphics translator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=759747
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich volke...@gmx.at 2011-12-08 20:42:31 EST
---
* Doesn't build on my machine:
src/pycms/_pycms.c:21:18: fatal error: lcms.h: No such file or directory
* The tarball seems to bundle a couple of other Python modules. They should be
removed in the prep section.
* You can drop -n sk1libs-%{version}, as it's the default.
* Defattr is no longer necessary
* Defining python_sitearch is not necessary for Fedora anymore. If you're going
for EPEL 5, it is necessary, but only for EPEL:
http://fedoraproject.org/wiki/Packaging:Python#Macros
Drop the clean section and the rm in the install section in that case.
Otherwise define buildroot:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758734] Review Request: fatrat-subtitlesearch - FatRat plugin enabling OpenSubtitles.org and Sublight.si integration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758734 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #1 from Volker Fröhlich volke...@gmx.at 2011-12-08 21:01:27 EST --- * Package doesn't build on F16 * Beta must be in release, not version: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages * Drop the version requirement on Qt, we don't have versions older than 4.5 * The files indicate GPLv2, not v2+ * You can use the name macro in Source0 and in the files section * Please add a comment on what your patch does and why you're deleting _docdir -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 695233] Review Request: alien - Converter between the rpm, dpkg, stampede slp, and Slackware tgz file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695233 --- Comment #4 from Dmitrij S. Kryzhevich kr...@land.ru 2011-12-08 21:48:53 EST --- But nobody wants to review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765651] New: Review Request: asterisk-gui - Graphical interface for Asterisk configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: asterisk-gui - Graphical interface for Asterisk configuration https://bugzilla.redhat.com/show_bug.cgi?id=765651 Summary: Review Request: asterisk-gui - Graphical interface for Asterisk configuration Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: casper.le.fan...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fantom.fedorapeople.org/asterisk-gui.spec SRPM URL: http://fantom.fedorapeople.org/asterisk-gui-2.0-1.20111208svn5218.fc16.src.rpm Description: Asterisk GUI is a framework for the creation of graphical interfaces for configuring Asterisk. Some sample graphical interfaces for specific vertical markets are included for reference or for actual use and extension. Hello, I'm submiting this new package. Have a nice day. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765652] New: Review Request: bvi - Display-oriented editor for binary files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: bvi - Display-oriented editor for binary files https://bugzilla.redhat.com/show_bug.cgi?id=765652 Summary: Review Request: bvi - Display-oriented editor for binary files Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: casper.le.fan...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fantom.fedorapeople.org/bvi.spec SRPM URL: http://fantom.fedorapeople.org/bvi-1.3.2-1.fc16.src.rpm Description: The bvi is a display-oriented editor for binary files, based on the vi text-editor. If you are familiar with vi, just start the editor and begin to edit! A bmore program is also included in the package. Hello, I'm submiting this new package. Have a nice day. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765653] New: Review Request: filebench - File system and storage benchmark
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: filebench - File system and storage benchmark https://bugzilla.redhat.com/show_bug.cgi?id=765653 Summary: Review Request: filebench - File system and storage benchmark Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: casper.le.fan...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fantom.fedorapeople.org/filebench.spec SRPM URL: http://fantom.fedorapeople.org/filebench-1.4.9.1-1.fc16.src.rpm Description: Filebench is a file system and storage benchmark that allows to generate a large variety of workloads. Unlike typical benchmarks it is very flexible and allows to minutely specify (any) applications' behavior using extensive Workload Model Language (WML). Filebench uses loadable workload personalities to allow easy emulation of complex applications (e.g., mail, web, file, and database servers). Filebench is quick to set up and easy to use compared to deploying real applications. Hello, I'm submiting this new package. Have a nice day. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765666] New: Review Request: mate-doc-utils - Documentation utilities for MATE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mate-doc-utils - Documentation utilities for MATE https://bugzilla.redhat.com/show_bug.cgi?id=765666 Summary: Review Request: mate-doc-utils - Documentation utilities for MATE Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@brouhaha.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fedorapeople.org/~brouhaha/mate/mate-doc-utils.spec SRPM URL: http://fedorapeople.org/~brouhaha/mate/mate-corba-1.0.0-1.2012gitebd4a9bf6a.fc14.src.rpm Description: mate-doc-utils is a collection of documentation utilities for the MATE project. Notably, it contains utilities for building documentation and all auxiliary files in your source tree. Note: MATE is a fork of GNOME 2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765667] New: Review Request: mate-corba - A high-performance CORBA Object Request Broker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mate-corba - A high-performance CORBA Object Request Broker https://bugzilla.redhat.com/show_bug.cgi?id=765667 Summary: Review Request: mate-corba - A high-performance CORBA Object Request Broker Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@brouhaha.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fedorapeople.org/~brouhaha/mate/mate-corba.spec SRPM URL: http://fedorapeople.org/~brouhaha/mate/mate-corba-1.0.0-1.2012gitebd4a9bf6a.fc14.src.rpm Description: mate-corba is a high-performance CORBA (Common Object Request Broker Architecture) ORB (object request broker). It allows programs to send requests and receive replies from other programs, regardless of the locations of the two programs. CORBA is an architecture that enables communication between program objects, regardless of the programming language they're written in or the operating system they run on. Note: MATE is a fork of GNOME 2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765652] Review Request: bvi - Display-oriented editor for binary files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765652 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added CC||pikachu.2...@gmail.com Flag||needinfo? --- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-09 01:28:11 EST --- $ rpmlint ../RPMS/x86_64/bvi-debuginfo-1.3.2-1.fc16.x86_64.rpm bvi-debuginfo.x86_64: E: empty-debuginfo-package 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Don't submit packages without any unjustified rpmlint error. bmore.help is not a documentation file, it contains the help summary for bmore, displayed using the 'h' key. As a result, this file can't be considered to be as an optional one, you can't move it where you want without any consequence. Please explain *why* you want to move this file elsewhere. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 765653] Review Request: filebench - File system and storage benchmark
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765653 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED CC||pikachu.2...@gmail.com Resolution||WONTFIX Last Closed||2011-12-09 01:32:22 --- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-09 01:32:22 EST --- https://admin.fedoraproject.org/pkgdb/acls/name/filebench -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
