[Bug 694479] Review Request: pcl - Library for point cloud processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694479 --- Comment #9 from Tim Niemueller t...@niemueller.de 2011-12-24 04:52:56 EST --- Thanks for the review Rich. I have uploaded the new version 1.3.1-2 which fixes the issues, especially the docs issue. Thanks for pointing this out, I just missed it. Additionally I have sorted out the OpenNI problems and published a new OpenNI (and PrimeSense) update. It is tagged for the next four days into the buildroot of f15 and f16. I have done scratch builds on both, f15 and f16. The OpenNI updates will land in f15/f16 updates before pcl, so I think this is no longer a reason not to complete this review. I added a short comment why there are no .desktop files in the spec file (I did this after the scratch builds hence it is only in the spec, not in the srpms). New SRPM is at http://fedorapeople.org/~timn/robotics/pcl-1.3.1-2.fc15.src.rpm, spec file changed in place. Scratch builds: f15: https://koji.fedoraproject.org/koji/taskinfo?taskID=3604183 f16: https://koji.fedoraproject.org/koji/taskinfo?taskID=3604194 I hope these takes the pcl package to an acceptable state. Merry Christmas/happy holidays. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694479] Review Request: pcl - Library for point cloud processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694479 --- Comment #9 from Tim Niemueller t...@niemueller.de 2011-12-24 04:52:56 EST --- Thanks for the review Rich. I have uploaded the new version 1.3.1-2 which fixes the issues, especially the docs issue. Thanks for pointing this out, I just missed it. Additionally I have sorted out the OpenNI problems and published a new OpenNI (and PrimeSense) update. It is tagged for the next four days into the buildroot of f15 and f16. I have done scratch builds on both, f15 and f16. The OpenNI updates will land in f15/f16 updates before pcl, so I think this is no longer a reason not to complete this review. I added a short comment why there are no .desktop files in the spec file (I did this after the scratch builds hence it is only in the spec, not in the srpms). New SRPM is at http://fedorapeople.org/~timn/robotics/pcl-1.3.1-2.fc15.src.rpm, spec file changed in place. Scratch builds: f15: https://koji.fedoraproject.org/koji/taskinfo?taskID=3604183 f16: https://koji.fedoraproject.org/koji/taskinfo?taskID=3604194 I hope these takes the pcl package to an acceptable state. Merry Christmas/happy holidays. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 621416] Review Request: libgeotiff -- GeoTIFF format library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621416 --- Comment #36 from Volker Fröhlich volke...@gmx.at 2011-12-24 06:44:08 EST --- Yes, it's only about the data. I can't say anything about Balint's proposal though. I'll try to start an appeal to Osgeo to find a sustainable solution to that problem. I contacted Debian's maintainer as a first step, as they suffer from the same problem. Debian has an -epsg sub-package, so removing the data seems to be possible, but is not desireable, I fear. Libtiff 4.0 was announced yesterday as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709328 --- Comment #29 from Raphael Groner raph...@web.de 2011-12-24 08:22:37 EST --- (In reply to comment #28) What for is need libicu-devel? From koji build.log: Unable to load library icui18n Cannot load library icui18n: (libicui18n.so.46: cannot open shared object file: No such file or directory) $ yum info libicu Name : libicu Zusammenfassung : International Components for Unicode - libraries URL: http://www.icu-project.org/ Lizenz : MIT and UCD and Public Domain Beschreibung : The International Components for Unicode (ICU) libraries provide : robust and full-featured Unicode services on a wide variety of : platforms. ICU supports the most current version of the Unicode : standard, and they provide support for supplementary Unicode : characters (needed for GB 18030 repertoire support). : As computing environments become more heterogeneous, software : portability becomes more important. ICU lets you produce the same : results across all the various platforms you support, without : sacrificing performance. It offers great flexibility to extend : and customize the supplied services. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770152
--- Comment #3 from Christophe Fergeau cferg...@redhat.com 2011-12-24
10:02:39 EST ---
The patch to lower the gtk+ version needs to be dropped, it's just a local hack
and is unneeded in rawhide.
I looked at fixing the issue you pointed out, but only found occurrences of
RPM_BUILD_ROOT, no %{buildroot}, and no %optflags/RPM_OPT_FLAGS. Did I miss
something, or would you prefer that I use %{buildroot}?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770152 --- Comment #4 from Adam Huffman bl...@verdurin.com 2011-12-24 10:48:18 EST --- Yes, just for consistency with the other tags. It's a minor thing but does help readability. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752311] Review Request: gitso - A front-end to reverse VNC connections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752311 --- Comment #2 from Cédric OLIVIER cedric.oliv...@free.fr 2011-12-24 11:15:24 EST --- Thanks a lot for your comments : I have made an update : SRPM URL : http://cedric.olivier.free.fr/rpms/gitso-0.6-2/gitso-0.6-2.fc16.src.rpm Spec URL : http://cedric.olivier.free.fr/rpms/gitso-0.6-2/gitso.spec * I have removed python_sitelib_macro, and python-devel buildrequires and python, wxGTK requires. SRPM successfully rebuild with mock. * Changing install destination. * Removing MimeType was an error when removing deprecated entries in desktop file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752311] Review Request: gitso - A front-end to reverse VNC connections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752311 --- Comment #3 from Cédric OLIVIER cedric.oliv...@free.fr 2011-12-24 13:00:07 EST --- Sorry, this previous version doesn't work. You can find here a updated functional version : SRPM URL : http://cedric.olivier.free.fr/rpms/gitso-0.6-3/gitso-0.6-3.fc16.src.rpm Spec URL : http://cedric.olivier.free.fr/rpms/gitso-0.6-3/gitso.spec * I have removed patch2, due to install directory change -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751217] Review Request: drupal7-features_plumber - Remove unwanted components from your Drupal Features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751217 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:41:37 EST --- New Package SCM Request === Package Name: drupal7-features_plumber Short Description: The Features Plumber UI module adds check boxes to the feature create form, and un-checking these detected components will cause them to be removed from the actual generated export. Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745333] Review Request: drupal7-migrate - The migrate module provides a flexible framework for migrating content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745333 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:43:03 EST --- New Package SCM Request === Package Name: drupal7-migrate Short Description: The migrate module provides a flexible framework for migrating content into Drupal from other sources Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745328] Review Request: drupal7-menu_token - Menu Token provides tokens, that could be used in title or path
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745328 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:44:26 EST --- New Package SCM Request === Package Name: drupal7-menu_token Short Description: Menu Token module provides tokens, that could be used in title or in path of menu items (links). Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745322] Review Request: drupal7-locale_cookie - Keeps track of the language by means of a cookie
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745322 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745323] Review Request: drupal7-markdown - Provides Markdown filter integration for Drupal input formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745323 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:45:50 EST --- New Package SCM Request === Package Name: drupal7-markdown Short Description: Provides Markdown filter integration for Drupal input formats. The Markdown syntax is designed to co-exist with HTML, so you can set up input formats with both HTML and Markdown support. It is also meant to be as human-readable as possible when left as source. Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745322] Review Request: drupal7-locale_cookie - Keeps track of the language by means of a cookie
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745322 --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:47:24 EST --- New Package SCM Request === Package Name: drupal7-locale_cookie Short Description: This module adds a new method for language detection to Drupal 7, it keeps track of the language by means of a cookie, so the language is preserved no matter of the user is logged in or not. It also works for recurring users. Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745320] Review Request: drupal7-libraries - The common denominator for all Drupal components and external libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745320 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:49:44 EST --- New Package SCM Request === Package Name: drupal7-libraries Short Description: Drupal 7 only has built-in support for non-external libraries via hook_library(). But it is only suitable for drupal.org projects that bundle their own library; i.e., the module author is the creator and vendor of the library. Libraries API should be used for externally developed and distributed libraries. A simple example would be a third-party jQuery plugin. Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745317] Review Request: drupal7-jquery_update - Updates the version of jQuery to 1.5.2 and jQuery UI 1.8.11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745317 Scott Dodson sdod...@sdodson.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Scott Dodson sdod...@sdodson.com 2011-12-24 13:51:19 EST --- New Package SCM Request === Package Name: drupal7-jquery_update Short Description: Upgrades the version of jQuery in Drupal core to a newer version of jQuery. Drupal 7 to jQuery 1.5.2 and jQuery UI 1.8.11 Owners: sdodson Branches: fc15, fc16, el5, el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768545] Review Request: blktap - blktap user space utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768545 David Nalley da...@gnsa.us changed: What|Removed |Added Flag|needinfo?(da...@gnsa.us)| --- Comment #2 from David Nalley da...@gnsa.us 2011-12-24 14:04:06 EST --- Good catch - I took the spec file from upstream old release. The code (with one exception) is licensed under the three-clause BSD license, and is noted at the beginning of each source file. There is a small section of code that is licensed LGPLv2+. I've changed the license section to reflect this. SPEC URL: http://ke4qqq.fedorapeople.org/blktap.spec SRPM URL: http://ke4qqq.fedorapeople.org/blktap-2.0.90-2.git20111216.62de90d.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709328 --- Comment #30 from Raphael Groner raph...@web.de 2011-12-24 15:33:59 EST --- (In reply to comment #29) (In reply to comment #28) What for is need libicu-devel? The dependency to libicu is a (potential) bug in Qt package. Please take a look at bug #759923 for more information. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728815] Review Request: trademgen - C++ Simulated Travel Demand Generation Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728815 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|trademgen-0.2.2-1.fc16 |trademgen-0.2.2-1.fc15 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-12-24 15:52:07 EST --- trademgen-0.2.2-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749756] Review Request: zita-at1 - autotuner for JACK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749756 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|zita-at1-0.2.3-4.fc16 |zita-at1-0.2.3-4.fc15 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-12-24 15:52:49 EST --- zita-at1-0.2.3-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728815] Review Request: trademgen - C++ Simulated Travel Demand Generation Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728815 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||trademgen-0.2.2-1.fc16 Resolution||ERRATA Last Closed||2011-12-24 15:50:44 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-12-24 15:50:44 EST --- trademgen-0.2.2-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749753] Review Request: clxclient - a C++ X windows library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749753 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|zita-rev1-0.2.1-4.fc16 |clxclient-3.6.1-5.fc15 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-12-24 15:51:59 EST --- clxclient-3.6.1-5.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749757] Review Request: zita-rev1 - Proaudio reverb for JACK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|zita-rev1-0.2.1-4.fc16 |zita-rev1-0.2.1-4.fc15 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-12-24 15:53:01 EST --- zita-rev1-0.2.1-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769922] Review Request: trac-navadd-plugin - Allows the addition of custom items
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769922 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Kevin Fenzi ke...@scrye.com 2011-12-24 16:49:37 EST --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Not a blocker, but you might ask upstream to include a copy of the BSD license with the package. 2. rpmlint says: trac-navadd-plugin.noarch: W: no-documentation trac-navadd-plugin.src: W: invalid-url Source0: trac-navadd-plugin-0.9.svn11020.tar.gz Both can be ignored. I don't see any blockers here, so this package is APPROVED. I'm happy to co-maintain if you like. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770134] Review Request: trac-workflowadmin-plugin - Web interface for workflow administration for Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770134 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Kevin Fenzi ke...@scrye.com 2011-12-24 17:08:14 EST --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Not a blocker, but you might ask upstream to include a copy of the BSD license with the package. 2. rpmlint says: trac-workflowadmin-plugin.noarch: W: spelling-error Summary(en_US) workflow - work flow, work-flow, workforce trac-workflowadmin-plugin.noarch: W: spelling-error %description -l en_US workflow - work flow, work-flow, workforce trac-workflowadmin-plugin.noarch: W: no-documentation trac-workflowadmin-plugin.src: W: spelling-error Summary(en_US) workflow - work flow, work-flow, workforce trac-workflowadmin-plugin.src: W: spelling-error %description -l en_US workflow - work flow, work-flow, workforce trac-workflowadmin-plugin.src: W: invalid-url Source0: trac-workflowadmin-plugin-0.12.svn11020.tar.gz all can be ignored. I don't see any blockers here, so this package is APPROVED. Happy to co-maintain. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694479] Review Request: pcl - Library for point cloud processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694479 Rich Mattes richmat...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|richmat...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694479] Review Request: pcl - Library for point cloud processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694479 Rich Mattes richmat...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|richmat...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694479] Review Request: pcl - Library for point cloud processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694479 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Rich Mattes richmat...@gmail.com 2011-12-24 17:17:27 EST --- I've reviewed and tested your changes. The documentation packaging issue and specfile comments are taken care of, and the pending openni update+buildroot override take care of the primary arch build requirement. With these changes, this package is APPROVED. Happy holidays to you too! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 694479] Review Request: pcl - Library for point cloud processing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694479 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Rich Mattes richmat...@gmail.com 2011-12-24 17:17:27 EST --- I've reviewed and tested your changes. The documentation packaging issue and specfile comments are taken care of, and the pending openni update+buildroot override take care of the primary arch build requirement. With these changes, this package is APPROVED. Happy holidays to you too! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699316] Review Request: inkscape-textext - Textext is an extension for Inkscape that allows adding LaTeX-generated editable text objects to the SVG drawings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699316 --- Comment #4 from Willington Vega wv...@wvega.com 2011-12-24 17:42:40 EST --- Hi Ryan, thank you for your feedback. Here are the outputs from rpmlint -v for the latest SPEC file and SRPM (comment 2): rpmlint -v SPECS/inkscape-textext.spec SPECS/inkscape-textext.spec: I: checking-url https://bitbucket.org/pv/textext/get/9260a2461344.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -v SRPMS/inkscape-textext-0.4.4-2.20091127hg.fc15.src.rpm inkscape-textext.src: I: checking inkscape-textext.src: I: checking-url http://pav.iki.fi/software/textext/ (timeout 10 seconds) inkscape-textext.src: I: checking-url https://bitbucket.org/pv/textext/get/9260a2461344.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. And here is the link to Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3604835 I've been reading those wiki pages lately while doing some informal reviews. I'm still learning though. Links to informal reviews: https://bugzilla.redhat.com/show_bug.cgi?id=757156#c1 https://bugzilla.redhat.com/show_bug.cgi?id=769096#c1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699316] Review Request: inkscape-textext - Textext is an extension for Inkscape that allows adding LaTeX-generated editable text objects to the SVG drawings
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699316
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
CC||pikachu.2...@gmail.com
--- Comment #5 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-24
18:04:20 EST ---
Some comments:
- About the Requires: don't rely on texlive-latex, but rather on
tex(latex), as explained here:
http://fedoraproject.org/wiki/Packaging_tricks#Installing_TeX_files_.28unvetted.29
If one day Fedora decides to switch to another (La)TeX distribution (it already
happened once, from teTeX to TeXLive), there will be no need to fix the
Requires on TeX tools, thanks to this virtual Provides.
- There's an extra underscore after Inkscape in the description.
- You can remove the BuildRoot tag, as well as all build root cleaning stuff.
You can also remove the %defattr macro in %files:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- There is a stable version 0.4.4, but you packaged a developement version one.
Could you justify your choice?
- You can remove python-lxml from the Requires, it is already required by
inkscape.
- About this line:
%attr(644,root,root) %{_datadir}/inkscape/extensions/textext.inx
If you need to fix the rights of some installed file, you'd better using the
install in %install: you can use the following line instead of cp:
install -pm 0644 textext.py %{buildroot}%{_datadir}/inkscape/extensions/
- Don't forget to set the Group tag for this package. You can use the same than
inkscape, that is to say:
Group: Applications/Productivity
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699316] Review Request: inkscape-textext - Textext is an extension for Inkscape that allows adding LaTeX-generated editable text objects to the SVG drawings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699316 --- Comment #6 from Ryan H. Lewis (rhl) m...@ryanlewis.net 2011-12-24 20:59:22 EST --- Hi, sorry, please rpmlint -v the actual rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 747765] Review Request: apache-log4j-extras - Apache Extras Companion for Apache log4j
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747765 --- Comment #4 from David Nalley da...@gnsa.us 2011-12-24 22:53:50 EST --- I've moved to maven (and I am reminded how much I dislike (and don't grok) maven). A couple of notes - currently this only builds in rawhide - and given that this is a dependency for something that I am intending including in F17 only, that works for me. SPEC URL: http://ke4qqq.fedorapeople.org/apache-log4j-extras.spec SRPM URL: http://ke4qqq.fedorapeople.org/apache-log4j-extras-1.1-3.fc16.src.rpm Here's a koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3604922 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745320] Review Request: drupal7-libraries - The common denominator for all Drupal components and external libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745320 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:20:07 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745317] Review Request: drupal7-jquery_update - Updates the version of jQuery to 1.5.2 and jQuery UI 1.8.11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745317 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:19:29 EST --- Git done (by process-git-requests). f15 and f16, not fc15 and fc16. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745323] Review Request: drupal7-markdown - Provides Markdown filter integration for Drupal input formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745323 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:21:35 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745328] Review Request: drupal7-menu_token - Menu Token provides tokens, that could be used in title or path
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745328 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:22:10 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751217] Review Request: drupal7-features_plumber - Remove unwanted components from your Drupal Features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751217 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:24:13 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745333] Review Request: drupal7-migrate - The migrate module provides a flexible framework for migrating content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745333 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:23:29 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745322] Review Request: drupal7-locale_cookie - Keeps track of the language by means of a cookie
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745322 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-24 23:20:43 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 699316] Review Request: inkscape-textext - Textext is an extension for Inkscape that allows adding LaTeX-generated editable text objects to the SVG drawings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699316 --- Comment #7 from Willington Vega wv...@wvega.com 2011-12-25 00:03:22 EST --- Hello Mohamed, thank you for your comments. I applied the changes you suggested and created new SPEC, SRPM and RPM. http://files.wvega.com/fedora/inkscape-textext/inkscape-textext.spec http://files.wvega.com/fedora/inkscape-textext/inkscape-textext-0.4.4-3.20091127hg.fc15.src.rpm previous SPEC file can be found at: http://files.wvega.com/fedora/inkscape-textext/inkscape-textext-0.4.4-2.spec (In reply to comment #5) - There is a stable version 0.4.4, but you packaged a developement version one. Could you justify your choice? The snapshot from 2009-11-27 is the version I started using and inspired me to create the package. The stable version 0.4.4 was released about a year before, on 2008-10-04, and I honestly never tested it because the development version just worked. I thought it would be good to include the latest changes in the package, which seems to add some fixes. I can start testing the stable version and see how it works if that's a better approach. (In reply to comment #6) Hi, sorry, please rpmlint -v the actual rpm. Below is koji scratch build info and the rpmlint -v output for the updated SPEC, SRPM and RPM: Koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=3604960 rpmlint output: rpmlint -v SPECS/inkscape-textext.spec SPECS/inkscape-textext.spec: I: checking-url https://bitbucket.org/pv/textext/get/9260a2461344.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -v SRPMS/inkscape-textext-0.4.4-3.20091127hg.fc15.src.rpm inkscape-textext.src: I: checking inkscape-textext.src: I: checking-url http://pav.iki.fi/software/textext/ (timeout 10 seconds) inkscape-textext.src: I: checking-url https://bitbucket.org/pv/textext/get/9260a2461344.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -v RPMS/noarch/inkscape-textext-0.4.4-3.20091127hg.fc15.noarch.rpm inkscape-textext.noarch: I: checking inkscape-textext.noarch: I: checking-url http://pav.iki.fi/software/textext/ (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thank you all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
