[Bug 755275] Review Request: CSSLint - Detecting potential problems in CSS code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755275 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Parag AN(पराग) panem...@gmail.com 2011-12-29 03:30:46 EST --- + koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=3608918 + rpmlint on rpms gave csslint.src: W: spelling-error %description -l en_US pluggable - plug gable, plug-gable, plugged csslint.src: W: strange-permission csslint.sh 0755L csslint.noarch: W: spelling-error %description -l en_US pluggable - plug gable, plug-gable, plugged csslint.noarch: W: no-manual-page-for-binary csslint 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + source verified as b7ce5887073a08c4c6a08022ef43c2126737e0f7 v0.8.5 b7ce5887073a08c4c6a08022ef43c2126737e0f7 ../SOURCES/stubbornella-csslint-v0.8.5-0-g0394212.tar.gz APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770806] New: Review Request: gmm - Library to operate on sparse and dense matrices and vectors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gmm - Library to operate on sparse and dense matrices and vectors https://bugzilla.redhat.com/show_bug.cgi?id=770806 Summary: Review Request: gmm - Library to operate on sparse and dense matrices and vectors Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: shakthim...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://shakthimaan.fedorapeople.org/SPECS/gmm.spec SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/gmm-4.1-1.fc15.src.rpm Description: Gmm provides some basic types of sparse and dense matrices and vectors. It provides some generic operations on them copy - addition, multiplication, sub-vector and sub-matrices, solvers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770806] Review Request: gmm - Library to operate on sparse and dense matrices and vectors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770806 Shakthi Kannan shakthim...@gmail.com changed: What|Removed |Added CC||shakthim...@gmail.com --- Comment #1 from Shakthi Kannan shakthim...@gmail.com 2011-12-29 04:11:25 EST --- $ rpmlint gmm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint gmm-4.1-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint gmm-4.1-1.fc15.x86_64.rpm gmm.x86_64: E: no-binary gmm.x86_64: E: incorrect-fsf-address /usr/share/doc/gmm-4.1/COPYING 1 packages and 0 specfiles checked; 2 errors, 0 warnings. $ rpmlint gmm-devel-4.1-1.fc15.x86_64.rpm gmm-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Successful Koji builds for F15, F16, F17 and EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3608935 http://koji.fedoraproject.org/koji/taskinfo?taskID=3608938 http://koji.fedoraproject.org/koji/taskinfo?taskID=3608941 http://koji.fedoraproject.org/koji/taskinfo?taskID=3608944 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769173] Review Request: english-typing booster - typing booster for english language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769173 --- Comment #1 from anish apa...@redhat.com 2011-12-29 04:44:22 EST --- updated links SRPM:- http://anishpatil.fedorapeople.org/english-typing-booster-0.0.1-1.fc15.src.rpm Spec File:- http://anishpatil.fedorapeople.org/english-typing-booster.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770695] Review Request: bengali-typing-booster - Bengali typing booster tables for ibus indic table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770695 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2011-12-29 04:57:06 EST --- Review:- + koij scratch build (f17) - http://koji.fedoraproject.org/koji/taskinfo?taskID=3609003 + rpmlint on rpms gave bengali-typing-booster.src: W: spelling-error Summary(en_US) ibus - ibis, bus, i bus bengali-typing-booster.src: W: spelling-error Summary(en_US) indic - indict, indie, indicate bengali-typing-booster.src: W: spelling-error %description -l en_US probhat - prob hat, prob-hat, probate bengali-typing-booster.src: W: spelling-error %description -l en_US inscript - in script, in-script, inscription bengali-typing-booster-inscript.noarch: W: spelling-error Summary(en_US) ibus - ibis, bus, i bus bengali-typing-booster-inscript.noarch: W: spelling-error Summary(en_US) indic - indict, indie, indicate bengali-typing-booster-phonetic.noarch: W: spelling-error Summary(en_US) ibus - ibis, bus, i bus bengali-typing-booster-phonetic.noarch: W: spelling-error Summary(en_US) indic - indict, indie, indicate bengali-typing-booster-probhat.noarch: W: spelling-error Summary(en_US) ibus - ibis, bus, i bus bengali-typing-booster-probhat.noarch: W: spelling-error Summary(en_US) indic - indict, indie, indicate 4 packages and 0 specfiles checked; 0 errors, 10 warnings. + Source verified with upstream as (sha1sum) 7699942cae79db49b1e89bd1719b98a166e1ed07 bengali-typing-booster-0.9.0.tar.gz 7699942cae79db49b1e89bd1719b98a166e1ed07 ../SOURCES/bengali-typing-booster-0.9.0.tar.gz + rest looks following packaging guidelines. APPRVOED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770695] Review Request: bengali-typing-booster - Bengali typing booster tables for ibus indic table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770695 Pravin Satpute psatp...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770695] Review Request: bengali-typing-booster - Bengali typing booster tables for ibus indic table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770695 --- Comment #2 from Pravin Satpute psatp...@redhat.com 2011-12-29 05:51:57 EST --- thanks Parag for review New Package SCM Request === Package Name: bengali-typing-booster Short Description: Bengali typing booster tables for ibus indic table Owners: pravins Branches: f15,f16 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770837] Review Request: sphinx 2.0.3 - Sphinx full-text search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770837 --- Comment #1 from Jakub Jedelsky jakub.jedel...@gmail.com 2011-12-29 07:36:24 EST --- rpmlint SPECS/sphinx.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/sphinx-2.0.3-1.fc16.src.rpm sphinx.src: W: name-repeated-in-summary C Sphinx sphinx.src: W: strange-permission sphinx.init 0755L -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770721] Review Request: substance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770721 --- Comment #2 from Sven s.bau...@gmx.net 2011-12-29 10:49:02 EST --- Thanks, that helped me really good ;). I worked a bit at this package, but now I have another strange error I can't explain: During build with the new SPEC at the end of the %install stage, I get the following error: Fehler: Erstellen des Archivs fehlgeschlagen bei der Datei /home/makerpm/rpmbuild/SOURCES/kirillcool-substance-58d3873.zip: cpio: Ungültige Magic What does invalid magic mean? I really thank you for helping me ;). Greetings Sven -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770174
--- Comment #4 from Hans de Goede hdego...@redhat.com 2011-12-29 10:27:03 EST
---
(In reply to comment #3)
Thank you Hans, I think I've corrected the issues you pointed out.
Thanks, I see you addressed all the mentioned issues, still I would like to see
one more revision, to address 2 small things with how you fixed things:
1) It is usual for %post[un|trans] scripts to be added to the spec file before
%files, so please move all three to above %files
2) The way you fixed the executable .desktop file is a bit non standard, it
works, but the usual way to fix things like this would be to add:
chmod -x %{buildroot}%{_kde4_datadir}/applications/kde4/%{name}.desktop
To %install (after the make install)
I saw that in /usr/share/applications/kde4 there are many .desktop files with
permission set to 755, so I thought it was a false positive from rpmlint... at
least for KDE apps
No rpmlint is right to warn, it is not like you can do:
/usr/share/applications/kde4/kde-partitionmanager.desktop
And have it do something, like you can do ie:
/bin/ls
And have it do something, so the file should not be marked executable. If more
kde4 packages are doing this then I say BAD kde4 ! :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678980] Review Request: openscad - Creates solid 3D CAD objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678980 Jeff Moe (jebba) m...@blagblagblag.org changed: What|Removed |Added Status|NEW |CLOSED Resolution||CANTFIX Last Closed||2011-12-29 13:33:08 --- Comment #17 from Jeff Moe (jebba) m...@blagblagblag.org 2011-12-29 13:33:08 EST --- Thanks. I'm resigning from this. Sorry I didn't get it completed. Feel free to take it over, I'm closing out this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 679273] Review Request: repsnapper - Software for controlling the RepRap 3D printer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679273 Jeff Moe (jebba) m...@blagblagblag.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX Last Closed||2011-12-29 13:35:12 --- Comment #4 from Jeff Moe (jebba) m...@blagblagblag.org 2011-12-29 13:35:12 EST --- repsnapper is already ancient history in the reprap world. It has been replaced by Printrun/Pronterface. There is no point in packaging this anymore (even if I had gotten it done). Closing it out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678955] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678955 Jeff Moe (jebba) m...@blagblagblag.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CANTFIX Last Closed||2011-12-29 13:31:53 --- Comment #17 from Jeff Moe (jebba) m...@blagblagblag.org 2011-12-29 13:31:53 EST --- That looks doable. I am resigning from this though. I apologize for not getting this done. Feel free to take over. I'll close this out so a new one can get started. Sorry for your time, but it looks like you are making some progress on it. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770781] Review Request: jboss-logging-spi - JBoss Logging Programming Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770781 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added CC||mgold...@redhat.com --- Comment #1 from Marek Goldmann mgold...@redhat.com 2011-12-29 13:14:49 EST --- This jar shouldn't be packaged. Every package that requires jboss-logging-spi should use instead jboss-logging v3 (already packaged). This should be a drop-in replacement. I highly recommend to close this review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742388] Review Request: polybori - Framework for Boolean Rings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742388 --- Comment #10 from Jerry James loganje...@gmail.com 2011-12-29 14:42:12 EST --- OK, sorry to be dense on the script issue. You're right: even though rpmlint thinks that script is noarch, it really is arch-specific. I've rearranged the packages slightly; briefly polybori = polybori-ipbori and polybori-libs = polybori. I also changed the Requires to reflect the new layout, and the ipbori dependency you noted in comment 9. I also made polybori-docs be noarch. Spec URL: http://jjames.fedorapeople.org/polybori/polybori.spec SRPM URL: http://jjames.fedorapeople.org/polybori/polybori-0.8.0-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770755] Review Request: gnome-shell-extension-calc - A simple calculator in the search overview
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770755
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||pikachu.2...@gmail.com
AssignedTo|nob...@fedoraproject.org|pikachu.2...@gmail.com
--- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-29
05:22:27 EST ---
I will review this package. Some comments for now:
- about these lines:
# The source for this package was pulled from upstream's git. Use the
# following commands to generate the tarball:
# git clone git://github.com/eonpatapon/gnome-shell-extension-calc.git
# tar -czvf gnome-shell-extension-calc-2fca097.tar.gz
gnome-shell-extension-calc
Source0: %{name}-%{git}.tar.gz
The command you give here to retrieve the source always gets the latest commit
in the Git repository. You'd better give the way to obtain the sources
*corresponding to the packaged commit*, as follows:
$ git clone git://github.com/eonpatapon/gnome-shell-extension-calc.git
$ cd gnome-shell-extension-calc/
$ git archive --format=tar --prefix=%{name}-%{git}/ %{git} | xz
../%{name}-%{git}.tar.xz
(I used xz instead of gzip to have smaller archives).
Anyway, all of this is useless since you can retrieve from Github an archive of
any commit you want. You can have a look a the
gnome-shell-extension-icon-manager spec file as an example:
http://pkgs.fedoraproject.org/gitweb/?p=gnome-shell-extension-icon-manager.git;a=blob_plain;f=gnome-shell-extension-icon-manager.spec;hb=f16
- about the license: the header comments in the extension.js file indicate a
GPLv3 (or more) license:
https://github.com/eonpatapon/gnome-shell-extension-calc/blob/master/extension.js
You should update the License tag of your spec file to GPLv2+.
- %clean target and buildroot cleaning are not required anymore, you can remove
them from your spec file:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770721] Review Request: substance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770721 --- Comment #3 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-29 10:52:54 EST --- Could you post the current spec file, as well as the src.rpm one, which leads to this error? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678980] Review Request: openscad - Creates solid 3D CAD objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678980 Bug 678980 depends on bug 678955, which changed state. Bug 678955 Summary: Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL https://bugzilla.redhat.com/show_bug.cgi?id=678955 What|Old Value |New Value Resolution||CANTFIX Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770721] Review Request: substance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770721 --- Comment #4 from Sven s.bau...@gmx.net 2011-12-29 11:14:44 EST --- The SPEC is located over here: http://dl.dropbox.com/u/3351272/Stuff/substance/SPECS/substance.spec (maybe my upload wasn't fast enough) ;). I don't get an src.rpm or a binary rpm because of this error. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770837] Review Request: sphinx 2.0.3 - Sphinx full-text search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770837 Jakub Jedelsky jakub.jedel...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728302 --- Comment #13 from Mario Santagiuliana fed...@marionline.it 2011-12-29 13:08:01 EST --- I update the spec file: SPEC: http://marionline.fedorapeople.org/packages/SPECS/pjproject.spec SRPM: http://marionline.fedorapeople.org/packages/SRPMS/pjproject-1.10-5.fc16.src.rpm I don't understand the point 5. I will update the package with new release (1.12) as soon as possible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770837] New: Review Request: sphinx 2.0.3 - Sphinx full-text search engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sphinx 2.0.3 - Sphinx full-text search engine https://bugzilla.redhat.com/show_bug.cgi?id=770837 Summary: Review Request: sphinx 2.0.3 - Sphinx full-text search engine Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jakub.jedel...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://static.stderr.cz/rpms/sphinx-2.0.3/sphinx.spec SRPM URL: http://static.stderr.cz/rpms/sphinx-2.0.3/sphinx-2.0.3-1.fc16.src.rpm Description: Sphinx is a free, open-source full-text search engine, designed with indexing database content in mind. Important: I know that there is a sphinx package (last stable version 0.9.9) in Fedora, but it's quite different and old (from '09). I don't know if there can be new name for this package (sphinx2) or make it compatible with old one or just make this as update for existing package. I will be very happy if I can find a sponsor :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754137] Review Request: nagios-plugins-bdii - Nagios Probe for the BDII
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754137 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nagios-plugins-bdii-1.0.14- |nagios-plugins-bdii-1.0.14- |1.fc16 |1.el6 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2011-12-29 17:00:00 EST --- nagios-plugins-bdii-1.0.14-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767305] Review Request: litmus - WebDAV server compliance test suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767305 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|litmus-0.13-3.fc16 |litmus-0.13-3.el5 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-12-29 16:59:47 EST --- litmus-0.13-3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767305] Review Request: litmus - WebDAV server compliance test suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767305 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|litmus-0.13-3.el5 |litmus-0.13-3.el6 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-12-29 17:00:52 EST --- litmus-0.13-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 754137] Review Request: nagios-plugins-bdii - Nagios Probe for the BDII
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754137 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nagios-plugins-bdii-1.0.14- |nagios-plugins-bdii-1.0.14- |1.el6 |1.el5 --- Comment #31 from Fedora Update System upda...@fedoraproject.org 2011-12-29 17:01:31 EST --- nagios-plugins-bdii-1.0.14-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759803] Review Request: tclap - Templatized command-line argument parser for C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759803 Spencer Jackson spencerandrewjack...@yahoo.com changed: What|Removed |Added CC||spencerandrewjackson@yahoo. ||com --- Comment #2 from Spencer Jackson spencerandrewjack...@yahoo.com 2011-12-29 17:45:35 EST --- Hmm. I don't believe tclap is suitable for packaging, as it appears that tclap is already in the Fedora repository... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718502] Review Request: Temperature.app - Window Maker applet which fetches local temperature information
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718502
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #10 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-29
17:50:11 EST ---
Here is the review:
+:ok, =:needs attention, -:needs fixing
MUST Items:
[-] MUST: rpmlint must be run on every package.
Temperature.app.src: I: enchant-dictionary-not-found de
Temperature.app.src: W: invalid-url URL:
http://www.dockapps.windowmaker.org/file.php/id/86 urlopen error [Errno -2]
Name or service not known
Temperature.app.src: W: invalid-url Source0:
http://www.dockapps.windowmaker.org/download.php/id/816/Temperature.app-1.5.tar.gz
urlopen error [Errno -2] Name or service not known
Temperature.app.x86_64: W: invalid-url URL:
http://www.dockapps.windowmaker.org/file.php/id/86 urlopen error [Errno -2]
Name or service not known
Temperature.app.x86_64: W: spurious-executable-perm
/usr/share/man/man1/Temperature.app.1.gz
Temperature.app.x86_64: E: incorrect-fsf-address
/usr/share/doc/Temperature.app-1.5/COPYING
Temperature.app-debuginfo.x86_64: W: invalid-url URL:
http://www.dockapps.windowmaker.org/file.php/id/86 urlopen error [Errno -2]
Name or service not known
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Xpm.cc
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Xpm.h
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Temperature.h
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Temperature.cc
Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/Temperature.app-1.5/Main.cc
3 packages and 0 specfiles checked; 6 errors, 5 warnings.
The warnings can be safely ignored, except the one about the permissions on
Temperature.app; fix it as below in %install:
install -D -p -m 644 %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1
The source URL must be fixed too : it has no « www » in fact.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
MD5 sum=e8d294085ebbe062f0d7b02dfb1d1071 OK
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[+] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without
[Bug 683591] Review Request: tclap - Templatized Command Line Argument Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683591 Eric Smith e...@brouhaha.com changed: What|Removed |Added CC||e...@brouhaha.com --- Comment #24 from Eric Smith e...@brouhaha.com 2011-12-29 18:32:42 EST --- *** Bug 759803 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 683591] Review Request: tclap - Templatized Command Line Argument Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683591 Eric Smith e...@brouhaha.com changed: What|Removed |Added CC||e...@brouhaha.com --- Comment #24 from Eric Smith e...@brouhaha.com 2011-12-29 18:32:42 EST --- *** Bug 759803 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759803] Review Request: tclap - Templatized command-line argument parser for C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759803 Eric Smith e...@brouhaha.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE Last Closed||2011-12-29 18:32:42 --- Comment #3 from Eric Smith e...@brouhaha.com 2011-12-29 18:32:42 EST --- Hmmm, couldn't find it when I looked. I must have botched my search somehow. Closing as duplicate. *** This bug has been marked as a duplicate of bug 683591 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767838] Review Request: libclastfm - Unofficial C-API for the Last.fm web service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767838 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||libclastfm-0.4-0.1.20111214 ||gitcc78dde5.fc16 Resolution|NEXTRELEASE |ERRATA --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-12-29 19:58:02 EST --- libclastfm-0.4-0.1.20111214gitcc78dde5.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710904] Review Request: octave-communications - Communications for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710904 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||octave-communications-1.1.0 ||-2.fc15 Resolution||ERRATA Last Closed||2011-12-29 19:57:37 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-12-29 19:57:37 EST --- octave-communications-1.1.0-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710904] Review Request: octave-communications - Communications for Octave
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710904 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|octave-communications-1.1.0 |octave-communications-1.1.0 |-2.fc15 |-2.fc16 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-12-29 19:58:56 EST --- octave-communications-1.1.0-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710917] Review Request: vmpk - Virtual MIDI Piano Keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||vmpk-0.4.0-4.fc15 Resolution||ERRATA Last Closed||2011-12-29 19:59:50 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2011-12-29 19:59:50 EST --- vmpk-0.4.0-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 700353] Review Request: perl-HTTP-OAI - API for the OAI-PMH
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700353 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||perl-HTTP-OAI-3.27-1.fc16 Resolution|NEXTRELEASE |ERRATA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-12-29 19:59:40 EST --- perl-HTTP-OAI-3.27-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728823] Review Request: django-tinymce - TinyMCE form field editor for Django applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728823 --- Comment #20 from Jon Ciesla limburg...@gmail.com 2011-12-29 20:04:04 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770695] Review Request: bengali-typing-booster - Bengali typing booster tables for ibus indic table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770695 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-29 20:05:25 EST --- Git done (by process-git-requests). Parag, please take ownership of review BZs, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770695] Review Request: bengali-typing-booster - Bengali typing booster tables for ibus indic table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770695 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|panem...@gmail.com --- Comment #4 from Parag AN(पराग) panem...@gmail.com 2011-12-29 20:16:59 EST --- Thanks Jon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770765] Review Request: python3-modgrammar - Modular grammar-parsing engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770765
Spencer Jackson spencerandrewjack...@yahoo.com changed:
What|Removed |Added
CC||spencerandrewjackson@yahoo.
||com
--- Comment #1 from Spencer Jackson spencerandrewjack...@yahoo.com 2011-12-29
23:44:33 EST ---
I'm not able to give you a formal review, but I was able to look over your
package and go over the checklist. I hope this helps!
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[makerpm@khezef rpmbuild]$ rpmlint SPECS/python3-modgrammar.spec
RPMS/noarch/python3-modgrammar-0.8-2.fc16.noarch.rpm
SRPMS/python3-modgrammar-0.8-2.fc16.src.rpm python3-modgrammar
python3-modgrammar.noarch: W: spelling-error %description -l en_US parsers -
parser, parses, parers
python3-modgrammar.src: W: spelling-error %description -l en_US parsers -
parser, parses, parers
python3-modgrammar.noarch: W: spelling-error %description -l en_US parsers -
parser, parses, parers
3 packages and 1 specfiles checked; 0 errors, 3 warnings.
MUST: The package must be named according to the Package Naming Guidelines .
OK. Name contains only ASCII characters. Name 'modgrammar' matches with
upstream project, python3 prefix correctly attached. Specfile correctly named.
Version is numeric, so version and release tags are trivially correct. There
does exist a doc subdirectory full of rst files in the source tarball. Consider
packaging it? There's ~70K of unprocessed documentation so maybe consider a doc
subpackage?
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK.
MUST: The package must meet the Packaging Guidelines .
FIXME. BSD is a valid license. No external components, or included 3rd party
components. Spec is legible. Built successfully on x86_64. Doesn't install
anything outside of %{python3_sitelib}, thus adhering to the LHS. Tags used
correctly. No Requires are used. egg-info is installed as documentation. Google
indicates this folder is used for pkg_resources? It probably shouldn't be
documentation... http://fedoraproject.org/wiki/Packaging:Python_Eggs has an
example of it... Also looks like you have a few unowned directories.
%{python3_sitelib}/modgrammar-0.8-py3.2.egg-info/,
%{python3_sitelib}/modgrammar/__pycache__/, and %{python3_sitelib}/modgrammar/
don't belong to your package, and they should. Maybe use a wildcard in
%{python3_sitelib} to grab everything? The patch should have a comment
describing its upstream status. Test suite should be invoked in a %check
section.
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
FIXME. BSD is an approved license. Source package does not contain the text of
the license. Contact upstream and ask for this to be corrected. Note that the
license is not contained in the source files.
MUST: The License field in the package spec file must match the actual license.
Unknown. setup.py says 'BSD' but that doesn't tell us what kind of BSD...
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
It doesn't.
MUST: The spec file must be written in American English.
OK.
MUST: The spec file for the package MUST be legible.
OK.
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK. Sources and upstream source have md5sum 74c8db3b4276bb49a2c11934ada33762.
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK. Built on x86_64
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
NA I do not have access to any other architectures. But it's noarch, so that
should be alright.
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
[Bug 770765] Review Request: python3-modgrammar - Modular grammar-parsing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770765 --- Comment #2 from Spencer Jackson spencerandrewjack...@yahoo.com 2011-12-30 00:25:30 EST --- Alright, I think I figured it out. The python bytecode compilation scripts checks for existence of python2, and silently dies if it doesn't find it. Your package has no dependency on python2, runtime or otherwise, so it never pulls it into the mock environment. I opened up https://bugzilla.redhat.com/show_bug.cgi?id=770909 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770174] Review Request: kde-partitionmanager - GUI for managing disk partitions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770174
Robin Lee robinlee.s...@gmail.com changed:
What|Removed |Added
CC||robinlee.s...@gmail.com
--- Comment #5 from Robin Lee robinlee.s...@gmail.com 2011-12-30 00:48:07 EST
---
* For proper Requires:, consider using before the %description section this
code instead of Requires kde-filesystem[1]:
%{?_kde4_macros_api:Requires: kde4-macros(api) = %{_kde4_macros_api} }
[1] http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
