[Bug 724936] Review Request: python-mock - A Python Mocking and Patching Library for Testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724936 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added AssignedTo|satya.komarag...@gmail.com |kumarpraveen.nitdgp@gmail.c ||om -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724936] Review Request: python-mock - A Python Mocking and Patching Library for Testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724936 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA | Keywords||Reopened -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 781260] Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781260 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2012-03-18 03:09:55 EDT --- leechcraft-0.5.60-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526014] Review Request:kprof - Profiling results viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526014 --- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:10:49 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 525412] Review Request: mediaproxy - NAT traversal solution for compatible SIP-routers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525412 --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:10:08 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 781260] Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781260 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2012-03-18 04:11:36 EDT --- leechcraft-0.5.60-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569693] Review Request: php-phpcaptcha - Securimage captcha library for PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569693 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:13:25 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526451] Review Request: crunchyfrog - A multi-engine SQL client and database front-end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526451 --- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:16:16 EDT --- ping? Is there any progress? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627362] Review Request: sx - extract and analyzes sos reports
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627362 --- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:15:31 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 550277] Review Request: x2goclient-cli - A command-line client for the x2go system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550277 --- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:12:46 EDT --- Ping? Fabian, do you plan import package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 781260] Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781260 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2012-03-18 04:12:32 EDT --- leechcraft-0.5.60-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542045] Review Request: php-htmlpurifier - standards-compliant HTML filter library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542045 --- Comment #28 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:11:49 EDT --- ping? Do you plan import that package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606073] Review Request: xmount - A on-the-fly convert for multiple hard disk image types
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606073 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 04:14:51 EDT --- Can I help you with that? What kind of troubles you are experience? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 781260] Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781260 --- Comment #29 from Fedora Update System upda...@fedoraproject.org 2012-03-18 04:55:53 EDT --- leechcraft-0.5.60-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 781260] Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781260 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2012-03-18 04:56:39 EDT --- leechcraft-0.5.60-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802037] Review Request: php-pecl-amqp - Communicate with any AMQP compliant server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802037 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Status|NEW |ASSIGNED CC||pa...@hubbitus.info AssignedTo|nob...@fedoraproject.org|pa...@hubbitus.info Flag||fedora-review? Bug 802037 depends on bug 802035, which changed state. Bug 802035 Summary: Review Request: librabbitmq - Client library and command line tools for AMPQ https://bugzilla.redhat.com/show_bug.cgi?id=802035 What|Old Value |New Value Status|NEW |MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2012-03-18 05:04:58 EDT --- I'll review that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804185] Review Request: python-django-tastypie - A flexible and capable API layer for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=804185 --- Comment #2 from Cédric OLIVIER cedric.oliv...@free.fr 2012-03-18 05:08:47 EDT --- According to the original package release, you can find an added check section and documentation subpackage. SPEC : http://cquad.dyndns.org/hg/python-django-tastypie/raw-file/92c5859ce2fd/SPECS/python-django-tastypie.spec SRPM : http://cquad.dyndns.org/hg/python-django-tastypie/raw-file/92c5859ce2fd/SRPMS/python-django-tastypie-0.9.11-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804185] Review Request: python-django-tastypie - A flexible and capable API layer for Django
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=804185 --- Comment #3 from Cédric OLIVIER cedric.oliv...@free.fr 2012-03-18 05:37:56 EDT --- An update with removing bundled egg-info : SPEC : http://cquad.dyndns.org/hg/python-django-tastypie/raw-file/06f545a9cafd/SPECS/python-django-tastypie.spec SRPMS : http://cquad.dyndns.org/hg/python-django-tastypie/raw-file/06f545a9cafd/SRPMS/python-django-tastypie-0.9.11-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 803089] Review Request: whenjobs - Replacement for cron with dependencies
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=803089
--- Comment #4 from Richard W.M. Jones rjo...@redhat.com 2012-03-18 05:55:22
EDT ---
(In reply to comment #1)
Let me start the review, but I am not a ocaml specialist.
1) %{_libdir}/whenjobs/ is unowned, you should add %dir %{_libdir}/whenjobs/
in
the %files section
Fixed.
2) given that this requires f17 to be built, I think you can remove %defattr (
unless the plan is to backport to EL 5, but I doubt )
Fixed.
3) same goes for %clean and the rm -Rf $RPMBUILDROOT at the start of %install,
if I am not wrong, so you can remove them ( no need to keep unused cruft )
Fixed.
4) per https://fedoraproject.org/wiki/Packaging/Guidelines#File_Dependencies
,
could you change the requires on /usr/bin/ocamlc to the package name ?
same goes for the buildRequires on perl-doc.
My reading of that section is that dependencies on /usr/bin/* are
permitted. I'd prefer to keep them because the program does in
fact run those binaries, like /usr/bin/ocamlc, so it seems more logical
to depend on the binaries, not the packages (which might change in future).
5) nitpicking, but
BuildRequires: pcre-devel, ocaml-pcre-devel
is better on 2 lines, as this ease review of a potential changes. But that's
not blocking for the review.
Fixed.
6) shouldn't whenjobsd be start at boot, with a systemd file ? ( given your
blog posts and the use case, this sound logical to me, but maybe I missed
something )
No, the daemon is started by each user that requires it.
7) you detect if the bytecode is created or not at the beggining of the spec,
but do not act on it as explained on :
https://fedoraproject.org/wiki/Packaging:OCaml#Bytecode-only_architectures
So either there is something missing, or something not used, or something
magic
I would bet on the 1st, but maybe that's the 3rd
This is actually an upstream problem. I need to add all the
upstream Makefile rules so that whenjobs can be compiled as
native code. It was just easier to use bytecode compilation,
and since it's not very performance-sensitive I didn't bother
much about it. One benefit of fixing this upstream is that we
wouldn't need the prelink stuff (because prelink doesn't break
native-compiled programs).
(In reply to comment #2)
and one last one, the release do not have %{?dist}.
Fixed!
I have just pushed the changes to the upstream git repo for now:
http://git.annexia.org/?p=whenjobs.git;a=commitdiff;h=7e01f4e655c5ceadbb571f4ded19427b41ae2933
since item #7 needs a big amount of upstream work to fix properly.
Hopefully I can get some time to do that this week.
Thanks for the initial review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684006] Review Request: perl-XML-Rules - API layer for XML::Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Paul Howarth p...@city-fan.org changed: What|Removed |Added Version|rawhide |17 Flag|fedora-review+ |fedora-review? --- Comment #16 from Paul Howarth p...@city-fan.org 2012-03-18 06:37:03 EDT --- Bill, you only seem to have done a build for Rawhide; is there some problem with doing the builds for f16/f17? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 791363] Review Request: perl-XML-DTDParser - Quick and dirty DTD parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791363 --- Comment #8 from Paul Howarth p...@city-fan.org 2012-03-18 06:39:13 EDT --- Bill, you only seem to have done a build for Rawhide; is there some problem with doing the f16/f17 builds? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655496] Review Request: cambozola - A viewer for multipart jpeg streams
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655496 Cédric OLIVIER cedric.oliv...@free.fr changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 655496] Review Request: cambozola - A viewer for multipart jpeg streams
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655496 --- Comment #17 from Cédric OLIVIER cedric.oliv...@free.fr 2012-03-18 06:36:49 EDT --- Package Change Request == Package Name: cambozola New Branches: el6 Owners: cquad -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 485586] Review Request: perl-Test-Kwalitee - Test the Kwalitee of a distribution before you release it
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485586 Paul Howarth p...@city-fan.org changed: What|Removed |Added CC||p...@city-fan.org Flag|fedora-cvs+ |fedora-cvs? --- Comment #8 from Paul Howarth p...@city-fan.org 2012-03-18 06:58:04 EDT --- Package Change Request == Package Name: perl-Test-Kwalitee New Branches: el5 Owners: pghmcfc InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=798071
--- Comment #3 from Michael Scherer m...@zarb.org 2012-03-18 07:06:45 EDT ---
Indeed, you cannot edit the post. Think of it like a mailing list more than
like a forum :)
1) I think, but I am not sure, that it would be better to use exec in the last
part of the helper script :
export GNOME_DESKTOP_SESSION_ID=needed
%{_sbindir}/%{name}
this way, you have only one process in the process table, and not 2, this is
cleaner.
2) if you use consolehelper, I think you should have a requires on usermode.
Even if this is installed by default on graphical desktop ( being required by
firstboot ), it can be removed.
3) the license should be present in a %doc :
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
4) the requires is on python, I think you should tell if this is version 2 or
3.
I need to go, so I will add some remarks later ( once I have done enough
research too )
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 461303] Review Request: perl-Data-Section - Read multiple hunks of data out of your DATA section
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461303 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-03-18 07:46:43 EDT --- perl-Data-Section-0.101621-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Data-Section-0.101621-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739263] Review Request: sugar-bounce - Fast paced 3D action game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739263 --- Comment #8 from Kalpa Welivitigoda callka...@gmail.com 2012-03-18 08:31:43 EDT --- Sorry incorrect srpm link, here is the correct one Spec URL: http://callkalpa.fedorapeople.org/sugar-bounce/sugar-bounce.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-bounce/sugar-bounce-7-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739263] Review Request: sugar-bounce - Fast paced 3D action game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739263 --- Comment #7 from Kalpa Welivitigoda callka...@gmail.com 2012-03-18 08:30:07 EDT --- fixed the issues Spec URL: http://callkalpa.fedorapeople.org/sugar-bounce/sugar-bounce.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-bounce/sugar-bounce-7-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 461307] Review Request: perl-Software-License Packages that provide templated software licenses
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461307 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2012-03-18 08:47:12 EDT --- perl-Software-License-0.103004-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Software-License-0.103004-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737293] Review Request: python-django - A high-level Python Web framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737293
--- Comment #22 from Matthias Runge mru...@matthias-runge.de 2012-03-18
09:17:46 EDT ---
python-django-1.3.1-8:
patched tests to work without internet connection
koji-scratchbuild
http://koji.fedoraproject.org/koji/taskinfo?taskID=3905954
-- success!
SRPM: http://www.matthias-runge.de/fedora/python-django-1.3.1-8.fc17.src.rpm
SPEC: http://www.matthias-runge.de/fedora/python-django.spec
I'd change the file-list at least to remove the asterisk at the end of the
following line (to contain the dir, not only the contents):
%{python_sitelib}/django/bin/profiling/*
I've found some unowned directories under %{python_sitelib}/django on my
filesystem.
Thoughts?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 426542] Review Request: perl-Module-CPANTS-Analyse - Generate Kwalitee ratings for a distribution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=426542 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2012-03-18 09:57:51 EDT --- perl-Module-CPANTS-Analyse-0.85-11.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Module-CPANTS-Analyse-0.85-11.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783071] Review Request: diet - A computational servers toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783071 --- Comment #4 from Haïkel Guémar karlthe...@gmail.com 2012-03-18 10:01:05 EDT --- 1. Since the website is maintained by the research team, no data should be used for any commercial use. I'll forward your concern about the lack of privacy policy. 2. 3. fixed 4. i guess, this is a mirror failure http://koji.fedoraproject.org/koji/taskinfo?taskID=3906057 5. fixed updated spec and src.rpm: http://hguemar.fedorapeople.org/diet/diet.spec http://hguemar.fedorapeople.org/diet/diet-2.8.0-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 392261] Review Request: perl-File-Find-Rule-Perl - Common rules for searching for Perl things
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=392261 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-03-18 10:33:03 EDT --- perl-File-Find-Rule-Perl-1.09-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-File-Find-Rule-Perl-1.09-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 392271] Review Request: perl-Perl-MinimumVersion - Find a minimum required version of perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=392271 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-03-18 11:06:38 EDT --- perl-Perl-MinimumVersion-1.20-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Perl-MinimumVersion-1.20-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798254] Review Request: perl-Config-Validator - Schema based configuration validation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798254 Steve Traylen steve.tray...@cern.ch changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch Flag||fedora-review+ --- Comment #1 from Steve Traylen steve.tray...@cern.ch 2012-03-18 11:16:32 EDT --- Hi, A very standard perl module: perl license. You have a buildroot, please drop if not targeting EPEL5. rpmlint is clean. /home/steve/reviews/798254/Config-Validator-0.3.tar.gz : MD5SUM this package : 166eb178a709e890853b3e08aa272c88 MD5SUM upstream package : 166eb178a709e890853b3e08aa272c88 APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802037] Review Request: php-pecl-amqp - Communicate with any AMQP compliant server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=802037
Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2012-03-18 11:27:39 EDT ---
Package Review
==
Key:
- = N/A
+ = Pass
! = Fail
? = Not evaluated
C/C++
[+]: MUST Header files in -devel subpackage, if present.
[+]: MUST Package does not contain any libtool archives (.la)
[+]: MUST Package does not contain kernel modules.
[+]: MUST Package contains no static executables.
[+]: MUST Rpath absent or only used for internal libs.
[-]: MUST Package is not relocatable.
[+]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
There it is module.
Generic
[+]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[+]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[+]: MUST %build honors applicable compiler flags or justifies otherwise.
[+]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[+]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[+]: MUST Package contains no bundled libraries.
[+]: MUST Changelog in prescribed format.
[+]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[+]: MUST Sources contain only permissible code or content.
[+]: MUST %config files are marked noreplace or the reason is justified.
[+]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[+]: MUST Macros in Summary, %description expandable at SRPM build time.
[+]: MUST Package requires other packages for directories it uses.
[+]: MUST Package uses nothing in %doc for runtime.
[+]: MUST Package is not known to require ExcludeArch.
[+]: MUST Permissions on files are set properly.
[+]: MUST Package does not contain duplicates in %files.
[+]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[+]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[+]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[+]: MUST License field in the package spec file matches the actual license.
[+]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[+]: MUST Package is named according to the Package Naming Guidelines.
[+]: MUST No %config files under /usr.
[+]: MUST Package does not generate any conflict.
[+]: MUST Package obeys FHS, except libexecdir and /usr/target.
[+]: MUST Package must own all directories that it creates.
[+]: MUST Package does not own files or directories owned by other packages.
[+]: MUST Package installs properly.
[-]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
rpmlint php-pecl-amqp-1.0.1-2.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint php-pecl-amqp-1.0.1-2.fc18.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint php-pecl-amqp-debuginfo-1.0.1-2.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[+]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/pasha/SOFT/Review/php-pecl-amqp/802037/amqp-1.0.1.tgz :
MD5SUM this package : d5b4a85551a03e0754c6cf01a5ad5200
MD5SUM upstream package : d5b4a85551a03e0754c6cf01a5ad5200
[+]: MUST Spec file is legible and written in American English.
[+]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[+]: MUST File names are valid UTF-8.
[+]: MUST Useful -debuginfo package or justification otherwise.
[+]: SHOULD Reviewer should test that the package builds in mock.
[+]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[+]: SHOULD Dist tag is present.
[+]: SHOULD No file requires outside of /etc,
[Bug 794725] Review Request: txw2 - Typed XML writer for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794725 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-03-18 11:35:49 EDT --- txw2-20110809-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/txw2-20110809-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 803531] Review Request: DMitry - network information gathering tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=803531 Yanchuan Nian ycn...@ymail.com changed: What|Removed |Added CC||ycn...@ymail.com --- Comment #3 from Yanchuan Nian ycn...@ymail.com 2012-03-18 12:02:08 EDT --- hi, Is it a package that you write from scratch? just some comments here 1) If the version is non-numeric, it is better to include the additional non-numeric characters in the release field. Maybe the package guidelines changed after the package's initial build. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Version_Tag 2)If there are no additional BuildRequires and Requires, the Comments can be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798071 --- Comment #4 from Jon Chiappetta jonc_mail...@yahoo.ca 2012-03-18 12:09:10 EDT --- I added a usermode requires in the spec file, changed the exec in the helper shell script and added a new GPL license file to the doc files section. Regarding the Python version 2 requirement, I can't seem to find a package that matches anything with the name python2, python-2, python2-devel and so on so I'm not sure how to specify that. I put these changes in the release 2 of the package I posted above. Thanks again for your time, Jon Chiappetta -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 790628] Review Request: Adobe Source Libraries - General Purpose Addon for Boost and STL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790628 --- Comment #27 from Alec Leamas leamas.a...@gmail.com 2012-03-18 12:15:55 EDT --- Now, that was a a review remark worth waiting for! Everything becomes just so much simpler. Blushing... New links: http://dl.dropbox.com/u/17870887/adobe-6/adobe-source-libraries.spec http://dl.dropbox.com/u/17870887/adobe-6/adobe-source-libraries-1.0.43-6.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801092] Review Request: sumwars - a hack and slash role playing game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801092 Martin Preisler mprei...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from Martin Preisler mprei...@redhat.com 2012-03-18 12:14:28 EDT --- New Package SCM Request === Package Name: sumwars Short Description: Hack and slash top-down view RPG game Owners: mpreisle Branches: f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802037] Review Request: php-pecl-amqp - Communicate with any AMQP compliant server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802037 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Remi Collet fed...@famillecollet.com 2012-03-18 13:09:54 EDT --- Thanks for the review New Package SCM Request === Package Name: php-pecl-amqp Short Description: Communicate with any AMQP compliant server Owners: remi Branches: f16 f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784457] Review Request: systemd-ui - UI Tools for systemd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784457 --- Comment #5 from Kay Sievers k...@redhat.com 2012-03-18 13:24:31 EDT --- New version: http://people.freedesktop.org/~kay/systemd-ui.spec http://people.freedesktop.org/~kay/systemd-ui-1.tar.xz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787713] Review request: free-solid - A 3D collision detection C++ library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787713 --- Comment #10 from Alec Leamas leamas.a...@gmail.com 2012-03-18 13:38:33 EDT --- Martin: The spec link doesn't work, permission denied. Volker: Hm... ltmain is part of libtool. As I understand the error message, autoreconf doesn't find libtool's /usr/share/libtool/config/ltmain.sh (?). Have you really libtool installed on your machine? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 803531] Review Request: DMitry - network information gathering tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=803531 --- Comment #4 from Anthony Sasadeusz sasad...@umbc.edu 2012-03-18 13:46:11 EDT --- No I didn't write it from scratch. I picked up the orphaned package. I made changes to the version for the build and also cleaned up the commenting. Here are the new files: http://home.comcast.net/~asasadeusz/DMitry/DMitry.spec http://home.comcast.net/~asasadeusz/DMitry/DMitry-1.3-0.1a.fc16.src.rpm Here is the koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3906696 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789390] Review Request: aeolus - a synthesized organ for ALSA/JACK
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=789390
Ankur Sinha sanjay.an...@gmail.com changed:
What|Removed |Added
Version|16 |rawhide
Flag||fedora-review?
--- Comment #1 from Ankur Sinha sanjay.an...@gmail.com 2012-03-18 14:09:59
EDT ---
Review:
[+] OK
[-] NA
[?] Issue
[+] Package meets naming and packaging guidelines
[+] Spec file matches base package name.
[+] Spec has consistant macro usage.
[?] Meets Packaging Guidelines.
|
+ Needs to be looked at again once the current issues are corrected.
[?] License
|
+ There is no licence information at all in the stops tar. How does one know
what license the content is under?
[?] License field in spec matches
|
+ Shouldn't the license be GPLv2+ (the plus?) and the license of the stops
content? All the source files appear to be GPLv2+, not just GPLv2.
[+] License file included in package
|
+ No license included in the stops tar
[+] Spec in American English
[+] Spec is legible.
[+] Sources match upstream md5sum:
[ankur@ankur SPECS]$ md5sum aeolus-0.8.4.tar.bz2 stops-0.3.0.tar.bz2
../SOURCES/aeolus-0.8.4.tar.bz2 ../SOURCES/stops-0.3.0.tar.bz2
0dcbfb2ab386419f306e1d947815163a aeolus-0.8.4.tar.bz2
2a7b1cae820408fa1cc655800d08d88f stops-0.3.0.tar.bz2
0dcbfb2ab386419f306e1d947815163a ../SOURCES/aeolus-0.8.4.tar.bz2
2a7b1cae820408fa1cc655800d08d88f ../SOURCES/stops-0.3.0.tar.bz2
[ankur@ankur SPECS]$
- Package needs ExcludeArch
[?] BuildRequires correct
|
+ Fails to build in mock:
DEBUG: tiface.cc:24:31: fatal error: readline/readline.h: No such file or
directory.
You are missing a BR. Probably one of the following:
[root@ankur ~]# repoquery '*/readline/readline.h' -f
mingw32-readline-0:5.2-8.fc15.noarch
readline-devel-0:6.2-2.fc16.i686
compat-readline5-devel-0:5.2-18.fc15.i686
readline-devel-0:6.2-2.fc16.x86_64
compat-readline5-devel-0:5.2-18.fc15.x86_64
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
[+] Package has %defattr and permissions on files is good.
[?] Package is code or permissible content.
|
+ Need to confirm contents of the stop tar.
- Doc subpackage needed/used.
[+] Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
[+] Package is a GUI app and has a .desktop file
[?] Package compiles and builds on at least one arch.
|
+ Fails to build on a mock fedora-rawhide-x86_64 configuration.
The following will be checked once the package builds correctly :)
- Package has no duplicate files in %files.
- Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
- No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk and
anything provided by glibc.)
SHOULD Items:
- Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
- Should have dist tag
- Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
---
Issues:
1. Package does not build
2. Licensing missing for the stops data
3. I see you've added a Requires: %{name}-stops there. What is that for? Did
you forget to make a %{name}-stops subpackage in the spec?
There may be more issues, but we'll look at them once the above are solved.
Thanks,
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789390] Review Request: aeolus - a synthesized organ for ALSA/JACK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789390 --- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2012-03-18 14:11:11 EDT --- The license files have incorrect FSF addresses too. Please request upstream to correct this in the next release of the software. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798254] Review Request: perl-Config-Validator - Schema based configuration validation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798254 Massimo Paladin massimo.pala...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Massimo Paladin massimo.pala...@gmail.com 2012-03-18 14:34:12 EDT --- New Package SCM Request === Package Name: perl-Config-Validator Short Description: This module allows to perform schema based configuration validation Owners: mpaladin Branches: f16 f17 el5 el6 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784457] Review Request: systemd-ui - UI Tools for systemd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784457 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Michal Schmidt mschm...@redhat.com 2012-03-18 14:34:22 EDT --- Looks good now. Just remember to update the version of systemd-gtk that is provided/obsoleted to the latest one. Package approved. Proceed with a SCM request: http://fedoraproject.org/wiki/Package_SCM_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784457] Review Request: systemd-ui - UI Tools for systemd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784457 Kay Sievers k...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Kay Sievers k...@redhat.com 2012-03-18 14:44:25 EDT --- New Package SCM Request === Package Name: systemd-ui Short Description: Graphical front-end for systemd Owners: systemd-maint Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787020] Review Request: trafficserver - Apache Traffic Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787020 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2012-03-18 16:16:16 EDT --- trafficserver-3.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trafficserver-3.0.3-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 761319] Review Request: gtkd - It is a D binding and OO wrapper of GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=761319 MERCIER Jonathan bioinfornat...@gmail.com changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|WONTFIX | Keywords||Reopened -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787020] Review Request: trafficserver - Apache Traffic Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787020 --- Comment #18 from Jan-Frode Myklebust janfr...@tanso.net 2012-03-18 16:27:33 EDT --- Bill, FYI: I fixed the proxy.config.proxy_name to default to FIXME.example.com (didn't want to mess with post install scripts for this), and pointed default proxy.config.ssl.server.cert.path and proxy.config.ssl.server.private_key.path to your suggested /etc/pki locations. Also have gotten upstream to change the initscript to use traffic_line -x on reloads, but this isn't included in this package (fixed in v3.1)... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783071] Review Request: diet - A computational servers toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783071 --- Comment #5 from Michael Scherer m...@zarb.org 2012-03-18 16:37:52 EDT --- I guess you should add a comment to explain how to get the tarball. I also guess the password can be placed as a comment ( especially since the form is asking lot of unrelated questions for a packager ). I am planning to ask the question to the FPC, but do not let that be blocking ( since logservice seems to be behind the same form, so I guess that's not blocking ). I just received the password by mail, so let's test and push the review forward. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783071] Review Request: diet - A computational servers toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783071 Michael Scherer m...@zarb.org changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|m...@zarb.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783071] Review Request: diet - A computational servers toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783071 --- Comment #6 from Michael Scherer m...@zarb.org 2012-03-18 17:17:21 EDT --- Guidelines ask to enable the test. I see there is a directory Cmake/tests, and it does look like unit tests, have you tried to enable them ? Also, the COPYING file is a BSD one ( and a old one, dating back to 2003 , I guess the software was licensed again ), while the license is listed as CeCILL in the spec. So I guess you should also ship the 2nd license too. And the source code do not really help on that, since they didn't fill the field License in the comments. The only file saying the code is under CeCILL is ./src/utils/batch/EucaLib/soapC.c. While I know that CeCILL is more or less the blessed licence for french research community ( since it was done for that ), I think you should warn upstream to clearly say it on the website, on documentation, etc ( as I didn't found anything regarding that ). In both case ( IE BSD or CeCILL ), that's free software so that should be ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798071 --- Comment #5 from Michael Scherer m...@zarb.org 2012-03-18 18:17:41 EDT --- On f16, i see that python rpm provides python2 : $ rpm -q --provides python Distutils python(abi) = 2.7 python(abi) = 2.7 python-abi = 2.7 python-argparse = 2.7.2-5.2.fc16 python-ctypes = 1.0.1 python-hashlib = 20081120 python-sqlite = 2.3.2 python-uuid = 1.31 python2 = 2.7.2 python = 2.7.2-5.2.fc16 python(x86-64) = 2.7.2-5.2.fc16 And for the desktop file, the guideline requires you to either run desktop-file-install, or desktop-file-validate, to make sure the file is correct : https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 803089] Review Request: whenjobs - Replacement for cron with dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=803089 --- Comment #5 from Michael Scherer m...@zarb.org 2012-03-18 18:21:42 EDT --- For the rpmlint warning about prelink file, I filled https://bugzilla.redhat.com/show_bug.cgi?id=804452 , since your concern about this not being a configuration file is valid. And have you considered filling a RFE for rpm to not strip ocaml software compiled with -custom ? Regarding point 4, that's indeed valid to have that and I will not force you, but that's not convenient for users ( at least for those with a more contrained environment than you and me, for example, in a small vm where parsing a 35 mo xml file can be problematic ). As I doubt the ocaml compiler will move a lot in the future ( or this would break a lot more software than just whenjobs ), I think you could use directly the package without trouble. But again, it is up to you. Should I wait for newer version of whejobs for the formal review ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542580] Review Request: statusnet - Open Source microblogging platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542580 Michael Scherer m...@zarb.org changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #17 from Michael Scherer m...@zarb.org 2012-03-18 18:39:57 EDT --- ( also, I set this as NEW so it can still appear in the list of review request ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542580] Review Request: statusnet - Open Source microblogging platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542580 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #16 from Michael Scherer m...@zarb.org 2012-03-18 18:36:36 EDT --- A few comments : - you should drop %defattr and %clean, unless you plan to backport to EPEL 5 - %check seems to be empty, so maybe you can drop this - since laconica is not in fedora repository ( and long forgotten ), maybe this is not needed to provide it - why is there user creation, if it doesn't serve to anything ( ie, that's a php software, and I didn't see any cron job or reason to think anything would use it ) - Requiring mysql-server is IMHO wrong, since the sql server can be on another server. On the other hand, I didn't found any guideline against that. - BuildRoot can also be removed - rm -rf %buildroot can be removed at the beggining of %install -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798738] Review request: mysqlenum - is an automatic blind SQL injection tool.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798738 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #10 from Michael Scherer m...@zarb.org 2012-03-18 18:48:02 EDT --- I think you should split the patch in 2 separate patchs, and add a comment about when you have sent them upstream ( and of course, sending them upstream ). See https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751652] Review Request: rippit - The no-nonsense multimedia ripper.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751652 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #3 from Michael Scherer m...@zarb.org 2012-03-18 19:00:25 EDT --- Ricardo, since you are now a packager, would you mind taking the review, or I can take it ? ( since you did the hard work, I think it would be fair for you to finish it, but if you are too busy, I can take care of it ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626004 --- Comment #18 from Roy Rankin rran...@ihug.com.au 2012-03-18 19:38:56 EDT --- I do not see the issue that Fabian sees. With the last patch to osm2pgsql-configure.patch removed and BuildRequires: libtool the package built for my both in mock and on a development system with required dependencies. I have done a pre-review and could quickly approve the package when Fabian provides a package content that builds. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=798071 --- Comment #6 from Jon Chiappetta jonc_mail...@yahoo.ca 2012-03-18 20:01:58 EDT --- Ahhh, my mistake, I was running the wrong command in trying to find the real pointer to python2. I added the desktop-file-install command along with it's suggested buildrequires line in the release 2 package again. I also did a mock rebuild for Fedora 16 x86_64 to make sure the package still built successfully :). I'm learning a lot about properly packaging software given this simple python script so this is fun so far! Thanks, Jon Chiappetta -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728837] Review Request: xml2dict - Use attributes of dictionary to access xml elements.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728837 --- Comment #26 from Yuguang Wang yuw...@redhat.com 2012-03-18 22:52:39 EDT --- Hello, license updated according to the author, spec file srpm: http://yuwang.fedorapeople.org/xml2dict.spec http://yuwang.fedorapeople.org/xml2dict-0-0.3.2008.6.1.src.rpm rpmlint: [yuwang@yuwang specs(master)]$ rpmlint /home/yuwang/rpmbuild/SRPMS/xml2dict-0-0.3.2008.6.1.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. koji scratch build successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=3907929 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728837] Review Request: xml2dict - Use attributes of dictionary to access xml elements.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728837
--- Comment #27 from Yuguang Wang yuw...@redhat.com 2012-03-18 22:56:42 EDT
---
(In reply to comment #24)
I removed the %{python_sitelib}/xml2dict in %files section.
3) but your installation looks strange. What is need to create empty directory
install -d $RPM_BUILD_ROOT%{python_sitelib}/xml2dict
but If the above line is removed, there'd be build error, I've no idea why.
btw, there's no empty directory {python_sitelib}/xml2dict after installation.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800720] Review Request: resteasy - Framework for RESTful Web services and Java applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800720 --- Comment #8 from Ade Lee a...@redhat.com 2012-03-18 22:57:06 EDT --- Juan, Resolved all of the above, using your suggestion for the %install section. Spec URL: http://vakwetu.fedorapeople.org/resteasy/resteasy.spec SRPM Url: http://vakwetu.fedorapeople.org/resteasy/resteasy-2.3.2-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785592] Review Request: python-setproctitle - Python module to customize a process title
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785592 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-setproctitle-1.1.3-2 ||.fc17 Resolution||ERRATA Last Closed||2012-03-18 23:34:31 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-03-18 23:34:31 EDT --- python-setproctitle-1.1.3-2.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
