[Bug 806594] Review Request: python-django-notification - User notification management for the Django web framework

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806594

--- Comment #3 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
03:17:37 EDT ---
oopsie, good catch.

Updated SPEC:
http://www.matthias-runge.de/fedora/python-django-notification.spec
Updated SRPM:
http://www.matthias-runge.de/fedora/python-django-notification-0.2-2.fc16.src.rpm

@@ -3,7 +3,7 @@

 Name:   python-django-notification
 Version:0.2
-Release:1%{?dist}
+Release:2%{?dist}
 Summary:User notification management for the Django web framework

 Group:  Development/Languages
@@ -16,6 +16,10 @@
 BuildRequires:  python-setuptools
 Requires:   python-django

+Provides:   %{pkgname} = %{version}-%{release}
+# latest release for django-notification is 0.1.2-6
+Obsoletes:  %{pkgname}  %{obs_ver}
+
 %description
 Many sites need to notify users when certain events have occurred and to
 allow configurable options as to how those notifications are to be received.
@@ -46,6 +50,9 @@
 %{python_sitelib}/django_notification-%{version}-py?.?.egg-info

 %changelog
+* Mon Mar 26 2012 Matthias Runge mru...@matthias-runge.de - 0.2-2
+- obsolete old package
+
 * Sat Mar 24 2012 Matthias Runge mru...@matthias-runge.de - 0.2-1
 - package renamed to python-django-notification
 - update to version 0.2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

--- Comment #2 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
03:24:31 EDT ---
oopsie, embarrassing for me.

Updated SPEC: http://www.matthias-runge.de/fedora/python-django-pagination.spec
Updated SRPM:
http://www.matthias-runge.de/fedora/python-django-pagination-1.0.5-9.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806594] Review Request: python-django-notification - User notification management for the Django web framework

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806594

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Michael Scherer m...@zarb.org 2012-03-26 03:49:07 EDT ---
So with this addition, the package is good to be sent.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805416] Review Request: croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

--- Comment #2 from Parag pnem...@redhat.com 2012-03-26 04:04:29 EDT ---
updated both the things:
1) package is updated at same location (no release bump yet)
2) https://fedoraproject.org/wiki/Croscore_fonts

koji scratch build for f18 -
koji.fedoraproject.org/koji/taskinfo?taskID=3931981

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806594] Review Request: python-django-notification - User notification management for the Django web framework

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806594

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
04:03:58 EDT ---
Thanks for your review!

New Package SCM Request
===
Package Name: python-django-notification
Short Description: User notification management for the Django web framework
Owners: mrunge
Branches: devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722956] Review Request: relevation - Command-line search for Revelation Password Manager files

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722956

Matthias Saou matth...@saou.eu changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #7 from Matthias Saou matth...@saou.eu 2012-03-26 04:05:30 EDT ---
New Package SCM Request
===
Package Name: relevation
Short Description: Command-line search for Revelation Password Manager files
Owners: thias
Branches: f16 f17 el5 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #3 from Miroslav Suchý msu...@redhat.com 2012-03-26 04:06:39 EDT 
---
Updated:
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin-1.8.1-1.fc16.src.rpm
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin.spec

Please note that I'm member of upstream. Therefore I created new release (as I
put those changes directly to upstream) and not put it in spec as patch.

 - for a fedora rpm, BuildRoot is no longer needed, same goes for %defattr, and
%clean, and cleaning of %install

We build the package for EPEL and mainly EPEL5 as well. And there there it is
needed. It is easier to maintain the spec file when we can leave it there (and
it makes no harm of Fedora). But if you insinst on that I can make separate
spec for Fedora and for EPEL.

 you should consider using packages rather than filedesps
fixed

 you should use %global, not %define for %rhnroot
fixed

 you should also ( IMHO ) place requires on 1 line each, as it permit to have
easier to read diff when sending patch
That is only two perl packages. Somebody in past decided that it would be nice
to have perl packages together. I do not think it is necessary, but if you see
it as blocker, I can change it.

 the file spacewalk-service look like a init script, and recent fedora use
 systemd, so the file should be converted
 http://fedoraproject.org/wiki/Packaging:Systemd
It looks like init script, but it is not.
Spacewalk server is layered application and is build on top of several services
(jabberd, httpd, tomcat6, osad-dispatcher, postgresql...). And since usually
Spacewalk server is run on dedicated machine and these services are run just
because Spacewalk server - if sysadmin want to restart Spacewalk, he would have
to write:
service tomcat6 stop
service httpd stop 
...
service  httpd start
service  tomcat6 start
which means: he has to enumerate all services which Spacewalk requires, not
forget single one and do it in correct order.
To make it easy for sysadmin, we provide spacewalk-service script, which can do
that.
But it does *not* start those service during boot. And neither stop those
services during shutdown. Each of those services still has its own
initd/systemd script.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #4 from Miroslav Suchý msu...@redhat.com 2012-03-26 04:10:25 EDT 
---
I forgot that in previous comment:
 Also, there is no file to give the license of the tarball
Fixed as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

--- Comment #3 from Michael Scherer m...@zarb.org 2012-03-26 04:15:34 EDT ---
It seems that there is a newer version :
http://pypi.python.org/pypi/django-pagination

( same url ).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] New: Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-restkit - Restkit is an HTTP resource kit for 
Python

https://bugzilla.redhat.com/show_bug.cgi?id=806777

   Summary: Review Request: python-restkit - Restkit is an HTTP
resource kit for Python
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: bkab...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://bkabrda.fedorapeople.org/pkgs/restkit/python-restkit.spec
SRPM URL:
http://bkabrda.fedorapeople.org/pkgs/restkit/python-restkit-4.1.2-1.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3931986
Description: Restkit is a full HTTP client using pure socket calls and its own
HTTP parser. It's not based on httplib or urllib2.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mru...@matthias-runge.de
 AssignedTo|nob...@fedoraproject.org|mru...@matthias-runge.de
   Flag||fedora-review?

--- Comment #1 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
04:35:57 EDT ---
Taking this one

(if anybody else is faster than me, just do the review!)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713313] Review Request: msktutil - Program for interoperability with Active Directory

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713313

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #38 from Michael Scherer m...@zarb.org 2012-03-26 04:33:38 EDT ---
Ok

So a few notes :
- Source0: https://msktutil.googlecode.com/files/msktutil-0.4.1.tar.bz2

I would use %version there

- I think you can clean the call to autoconf ( look cleaner, at least without
the syntaxic coloration 

And I will start the formal review shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #5 from Michael Scherer m...@zarb.org 2012-03-26 04:40:05 EDT ---
No, neither buildroot or package on the same line are blocking.

I will start the formal review soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802182] Review Request: ironjacamar - Java Connector Architecture 1.6 implementation

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802182

--- Comment #4 from Juan Hernández juan.hernan...@redhat.com 2012-03-26 
04:50:58 EDT ---
The package doesn't build in Koji. I think that it is using ivy and trying to
download artifacts from the web, which will never work in Koji. The failed Koji
build is here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3932036

And the relevant error message in build.log is the following:

+ ant -Dbrew nexus clean docs
Buildfile: /builddir/build/BUILD/ironjacamar-1.0.9.Final/build.xml
[mkdir] Created dir: /builddir/.ivy2/cache/org.apache.ivy/jars
  [get] Getting:
https://repository.apache.org/content/repositories/releases/org/apache/ivy/ivy/2.2.0/ivy-2.2.0.jar
  [get] To: /builddir/.ivy2/cache/org.apache.ivy/jars/ivy-2.2.0.jar
  [get] Error getting
https://repository.apache.org/content/repositories/releases/org/apache/ivy/ivy/2.2.0/ivy-2.2.0.jar
to /builddir/.ivy2/cache/org.apache.ivy/jars/ivy-2.2.0.jar
BUILD FAILED
/builddir/build/BUILD/ironjacamar-1.0.9.Final/build.xml:292:
java.net.UnknownHostException: repository.apache.org
 at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:178)
 at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:391)
 at java.net.Socket.connect(Socket.java:579)
 at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:612)
 at sun.security.ssl.BaseSSLSocketImpl.connect(BaseSSLSocketImpl.java:160)
 at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
 at sun.net.www.http.HttpClient.openServer(HttpClient.java:388)
 at sun.net.www.http.HttpClient.openServer(HttpClient.java:483)
 at sun.net.www.protocol.https.HttpsClient.init(HttpsClient.java:278)
 at sun.net.www.protocol.https.HttpsClient.New(HttpsClient.java:335)
 at
sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(AbstractDelegateHttpsURLConnection.java:191)
 at
sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:928)
 at
sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:177)
 at
sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:153)
 at org.apache.tools.ant.taskdefs.Get$GetThread.openConnection(Get.java:660)
 at org.apache.tools.ant.taskdefs.Get$GetThread.get(Get.java:579)
 at org.apache.tools.ant.taskdefs.Get$GetThread.run(Get.java:569)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 738746] Review Request: rubygem-coffee-script-source - A package for the coffee-script-source Ruby gem

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738746

--- Comment #10 from Bohuslav Slavek Kabrda bkab...@redhat.com 2012-03-26 
04:58:38 EDT ---
Hi Fotios, any progress on this? We will need this for new rails in F18, so it
would be great to have it ASAP.
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

--- Comment #4 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
05:11:54 EDT ---
(In reply to comment #3)
 It seems that there is a newer version :
 http://pypi.python.org/pypi/django-pagination
 
 ( same url ).

and another oopsie. How could I missed that? Only excuse is, upstream's web
page http://code.google.com/p/django-pagination/ didn't lists it yet. Good
catch!

Apparently, support for other languages was dropped.

SPEC: http://www.matthias-runge.de/fedora/python-django-pagination.spec
SRPM:
http://www.matthias-runge.de/fedora/python-django-pagination-1.0.7-1.fc16.src.rpm



[mrunge@mrungexp SPECS]$ diff -u python-django-pagination.spec-9 
python-django-pagination.spec
--- python-django-pagination.spec-9 2012-03-26 10:38:26.879608320 +0200
+++ python-django-pagination.spec 2012-03-26 11:01:04.398612372 +0200
@@ -1,14 +1,15 @@
 %global pkgname django-pagination
 %global obs_ver 1.0.5-8
 Name:   python-django-pagination
-Version:1.0.5
-Release:9%{?dist}
+Version:1.0.7
+Release:1%{?dist}
 Summary:Django pagination tools

 Group:  Development/Languages
 License:BSD
 URL:http://code.google.com/p/%{pkgname}/
-Source0:   
http://django-pagination.googlecode.com/files/%{pkgname}-%{version}.tar.gz
+Source0:   
http://pypi.python.org/packages/source/d/%{pkgname}/%{pkgname}-%{version}.tar.gz
+#md5=43353a0b3344e5b10a9a83248a6dc24a

 BuildArch:  noarch
 BuildRequires:  python2-devel 
@@ -24,7 +25,7 @@

 %prep
 %setup -q -n %{pkgname}-%{version}
-find -name '._*' -exec rm {} \;
+rm -rf django_pagionation.egg-info

 %build
 %{__python} setup.py build
@@ -32,14 +33,16 @@
 %install
 %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT

-%find_lang django

-%files -f django.lang
+%files
 %doc CONTRIBUTORS.txt LICENSE.txt docs/*
 %{python_sitelib}/pagination
 %{python_sitelib}/django_pagination-%{version}-py?.?.egg-info

 %changelog
+* Mon Mar 26 2012 Matthias Runge mru...@matthias-runge.de - 1.0.7-1
+- update to version 1.0.7
+
 * Mon Mar 26 2012 Matthias Runge mru...@matthias-runge.de - 1.0.5-9
 - obsolete old package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #6 from Michael Scherer m...@zarb.org 2012-03-26 05:14:47 EDT ---
The directory /var/lib/rhn is already owned by spacewalk-config, but according
to the policy, the current way is ok ( unless spacewalk-config end somehow in
the dependency chain of spacewalk-admin, but it doesn't seems to be the case, i
am just mentioning to be complete ).

So that's ok, according to
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

However, it seems that the package requires sudo, and nothing use it in the
script, is this correct ?

The same goes for restorecon, I didn't found where it is needed in the current
tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483045

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #20 from Petr Pisar ppi...@redhat.com 2012-03-26 05:20:31 EDT ---
Package Change Request
==
Package Name: perl-Test-Unit-Lite
Branches: f15 f16 f17
Owners: 
InitialCC: perl-sig

Please add perl-sig user with watch* permissions only to all Fedora branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

--- Comment #5 from Michael Scherer m...@zarb.org 2012-03-26 05:28:01 EDT ---
There seems to be a django-pagination-1.0.7/._setup.py file, but that's not
blocking ( on the other hand, I do not know why you wanted to remove them in
the first place, so maybe it is important for you, but that's not blocking for
the review )

And there is a typo on : 
rm -rf django_pagionation.egg-info

( pagination, not pagionation )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #7 from Miroslav Suchý msu...@redhat.com 2012-03-26 05:48:26 EDT 
---
You are correct. Usage of restorecon in this package has been removed year ago.
And sudo even earlier. I will remove those requires completely.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #8 from Miroslav Suchý msu...@redhat.com 2012-03-26 05:56:11 EDT 
---
Updated:
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin-1.8.2-1.fc16.src.rpm
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

--- Comment #6 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
06:26:13 EDT ---
You're right. Dropped that file and fixed typo.

SPEC: http://www.matthias-runge.de/fedora/python-django-pagination.spec
SRPM:
http://www.matthias-runge.de/fedora/python-django-pagination-1.0.7-2.fc16.src.rpm

[mrunge@mrungexp SPECS]$ diff -u python-django-pagination.spec-1
python-django-pagination.spec
--- python-django-pagination.spec-1 2012-03-26 12:13:34.624625269 +0200
+++ python-django-pagination.spec 2012-03-26 12:16:49.903625842 +0200
@@ -2,7 +2,7 @@
 %global obs_ver 1.0.5-8
 Name:   python-django-pagination
 Version:1.0.7
-Release:1%{?dist}
+Release:2%{?dist}
 Summary:Django pagination tools

 Group:  Development/Languages
@@ -25,7 +25,10 @@

 %prep
 %setup -q -n %{pkgname}-%{version}
-rm -rf django_pagionation.egg-info
+rm -rf django_pagination.egg-info
+
+# remove a unneeded file from mac
+rm -f ._setup.py

 %build
 %{__python} setup.py build
@@ -40,7 +43,7 @@
 %{python_sitelib}/django_pagination-%{version}-py?.?.egg-info

 %changelog
-* Mon Mar 26 2012 Matthias Runge mru...@matthias-runge.de - 1.0.7-1
+* Mon Mar 26 2012 Matthias Runge mru...@matthias-runge.de - 1.0.7-2
 - update to version 1.0.7

 * Mon Mar 26 2012 Matthias Runge mru...@matthias-runge.de - 1.0.5-9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 730314] Review Request: jboss-invocation - JBoss Invocation API

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730314

--- Comment #11 from Tomas Radej tra...@redhat.com 2012-03-26 06:30:31 EDT ---
Sorry,the files aren't there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 667790] Review Request: python-audioprocessing - Python audio processing suite

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=667790

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||INSUFFICIENT_DATA
Last Closed||2012-03-26 06:33:08

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Michael Scherer m...@zarb.org 2012-03-26 07:21:59 EDT ---

Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
 Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm  4.4
 Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.

[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.
/home/misc/checkout/git/FedoraReview/src/806562/django-pagination-1.0.7.tar.gz
:
  MD5SUM this package : 43353a0b3344e5b10a9a83248a6dc24a
  MD5SUM upstream package : 43353a0b3344e5b10a9a83248a6dc24a

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
 upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
 architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
 files.
[x]: SHOULD Spec use %global instead of %define.


 Python 
[x]: MUST Module list python2-devel or python3-devel as BuildRequires
[x]: MUST Python egg is built from source

Issues:
See:

[Bug 806665] Review Request: mosh - Mobile shell that supports roaming and intelligent local echo

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806665

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|m...@zarb.org
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800930] Review Request: redeclipse - Multiplayer FPS game based on Cube2

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800930

--- Comment #37 from Martin Erik Werner martinerikwer...@gmail.com 2012-03-26 
07:24:54 EDT ---
Ah, ok, then I'll stick with what I have (-1.2-fs).

Also noticed the client/server bins was getting stripped in the %install phase:
- 1.2-8
- Set flags for make install to avoid strip and get a useful -debuginfo

spec URL: http://arand.fedorapeople.org/12/redeclipse.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806665] Review Request: mosh - Mobile shell that supports roaming and intelligent local echo

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806665

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 CC||m...@zarb.org

--- Comment #1 from Michael Scherer m...@zarb.org 2012-03-26 07:25:09 EDT ---
Hi,

2 notes :
- can you put every BuildRequires/Requires on a single line, as this ease
review of patch later ? ( not blocking for review )

- rm -rf $RPM_BUILD_ROOT is no longer needed in %install since some time, so it
should be removed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Matthias Runge mru...@matthias-runge.de 2012-03-26 
07:48:00 EDT ---
Thanks a lot!

New Package SCM Request
===
Package Name: python-django-pagination
Short Description: Django pagination tools 
Owners: mrunge
Branches: devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591190] Review Request: debhelper - Helper programs for debian/rules

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591190

--- Comment #16 from Jeroen van Meeuwen kana...@kanarip.com 2012-03-26 
08:13:42 EDT ---
New SRPM:
http://hosted.kolabsys.com/~vanmeeuwen/debhelper-9.20120322-1.fc16.src.rpm
New SPEC: http://hosted.kolabsys.com/~vanmeeuwen/debhelper.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 483045] Review Request: perl-Test-Unit-Lite - Unit testing without external dependencies

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483045

--- Comment #21 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:18:50 EDT 
---
Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 235954] Review Request: perl-Test-use-ok - Alternative to Test::More::use_ok

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=235954

--- Comment #12 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:17:45 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798079] Review Request: vaildns - DNS and DNSSEC zone file validator:q

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798079

--- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:21:33 EDT 
---
Summary and SCM request package names don't match, please correct.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722956] Review Request: relevation - Command-line search for Revelation Password Manager files

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722956

--- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:20:21 EDT 
---
Git done (by process-git-requests).

Reviewer, please take ownership of review BZs, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806557] Review Request: python-django-followit - A django app that allows users to follow django model objects

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806557

--- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:23:59 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722956] Review Request: relevation - Command-line search for Revelation Password Manager files

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722956

Kalev Lember kalevlem...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|kalevlem...@gmail.com
  QAContact|kalevlem...@gmail.com   |extras...@fedoraproject.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

--- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:24:19 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806594] Review Request: python-django-notification - User notification management for the Django web framework

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806594

--- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-03-26 08:24:36 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722956] Review Request: relevation - Command-line search for Revelation Password Manager files

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722956

--- Comment #9 from Matthias Saou matth...@saou.eu 2012-03-26 08:30:12 EDT ---
Thanks Kalev for the review, and thanks Jon for the Git setup!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805416] Review Request: croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

--- Comment #3 from Nicolas Mailhot nicolas.mail...@laposte.net 2012-03-26 
08:34:42 EDT ---
Please add a google foundry prefix and the fontconfig rules to subsititute for
arial/tnr  liberation (the inverse rules probably need addition to liberation
too)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722956] Review Request: relevation - Command-line search for Revelation Password Manager files

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722956

--- Comment #10 from Kalev Lember kalevlem...@gmail.com 2012-03-26 08:41:13 
EDT ---
No problem, happy to help move this along.

By the way, the initial import
http://pkgs.fedoraproject.org/gitweb/?p=relevation.git;a=commitdiff;h=5e230e01a87e26435874b32027317144f8140472
had Matthias Saou http://freshrpms.net/ as the email address in %changelog.
Did you mean to replace it with Matthias Saou matth...@saou.eu as was done
in the updated spec file?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804055] Review Request: spring-ldap - Java library for simplifying LDAP operations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804055

Asaf Shakarchi a...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||a...@redhat.com
 AssignedTo|nob...@fedoraproject.org|a...@redhat.com
   Flag||fedora-review?

--- Comment #3 from Asaf Shakarchi a...@redhat.com 2012-03-26 08:44:36 EDT ---
I am taking this for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 722956] Review Request: relevation - Command-line search for Revelation Password Manager files

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722956

--- Comment #11 from Matthias Saou matth...@saou.eu 2012-03-26 08:50:58 EDT 
---
(In reply to comment #10)
 No problem, happy to help move this along.
 
 By the way, the initial import
 http://pkgs.fedoraproject.org/gitweb/?p=relevation.git;a=commitdiff;h=5e230e01a87e26435874b32027317144f8140472
 had Matthias Saou http://freshrpms.net/ as the email address in 
 %changelog.
 Did you mean to replace it with Matthias Saou matth...@saou.eu as was done
 in the updated spec file?

Oops, nope. It's the spec vs. srpm difference you pointed out... I didn't think
it was going to affect me, as I always import files manually, but this time I
decided to try the fedpkg import command using the srpm for the first time.

I'll change that now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 658754] Review Request: CUBRID - a very fast and reliable open source SQL database server.

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=658754

--- Comment #2 from Esen Sagynov esen.sagy...@nhn.com 2012-03-26 09:03:15 EDT 
---
The files have been moved to the following folder:
http://sourceforge.net/projects/cubrid/files/CUBRID-8.4.1/Linux/

The source code can be downloaded from:
http://sourceforge.net/projects/cubrid/files/CUBRID-8.4.1/Linux/CUBRID-8.4.1.1018.src.tar.gz/download

or

http://sourceforge.net/projects/cubrid/files/CUBRID-8.4.1/Linux/CUBRID-8.4.1.1018-el5.src.rpm/download

The spec file is located at:
http://sourceforge.net/projects/cubrid/files/CUBRID-8.4.1/Linux/cubrid.spec/download

We have managed in the meantime by using the src.tar.gz file in the above link
and the cubrid.spec file to create cubrid yum packages for fedora 13-16 and
centos 6.0 and above. Users can install cubrid, php-cubrid and python-cubrid by
running the command specified in:
http://www.cubrid.org/yum_repository

and then yum install cubrid.

The question that remains is what do we need to do to obtain CUBRID's
submission into the official yum repositories ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591332] Review Request: debconf - Debian configuration management system

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591332

Jeroen van Meeuwen kana...@kanarip.com changed:

   What|Removed |Added

   Flag|needinfo?(kanarip@kanarip.c |
   |om) |

--- Comment #8 from Jeroen van Meeuwen kana...@kanarip.com 2012-03-26 
09:07:21 EDT ---
New SRPM: http://hosted.kolabsys.com/~vanmeeuwen/debconf-1.5.42-1.fc16.src.rpm
New SPEC: http://hosted.kolabsys.com/~vanmeeuwen/debconf.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 235954] Review Request: perl-Test-use-ok - Alternative to Test::More::use_ok

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=235954

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2012-03-26 09:17:03 EDT ---
perl-Test-use-ok-0.02-13.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Test-use-ok-0.02-13.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591332] Review Request: debconf - Debian configuration management system

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591332

--- Comment #9 from Miroslav Suchý msu...@redhat.com 2012-03-26 09:26:59 EDT 
---
[!]: MUST Each %files section contains %defattr if rpm  4.4
 Note: defattr() present in %files section. This is OK if packaging
 for EPEL5. Otherwise not needed

You have:
%files
%defattr(-,root,root,-)

but:
%files doc
%doc samples/

You should be consistent. %defattr is not needed, so I would recomend to remove
it from that first %files section.


Spelling error:
debconf-i18n.noarch: W: spelling-error Summary(en_US) supoort - support
debconf.src: W: spelling-error %description -l en_US debian - Debian


debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ar/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ast/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/bg/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/bn/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/bs/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ca/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/cs/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/da/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/de/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/dz/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/el/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/eo/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/es/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/eu/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/fi/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/fr/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/gl/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/he/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/hu/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/id/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/it/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ja/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/km/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ko/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ku/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/mr/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/nb/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ne/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/nl/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/nn/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/pa/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/pl/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/pt/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/pt_BR/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ro/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/ru/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/sk/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/sl/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/sv/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/th/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/tl/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/tr/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/uk/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/vi/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/zh_CN/LC_MESSAGES/debconf.mo
debconf-i18n.noarch: W: file-not-in-%lang
/usr/share/locale/zh_TW/LC_MESSAGES/debconf.mo
1 packages and 0 specfiles checked; 0 errors, 49 warnings.

Please use %find_lang:
http://fedoraproject.org/wiki/Packaging:Guidelines#Why_do_we_need_to_use_.25find_lang.3F

debconf.noarch: E: zero-length

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

Avi Alkalay avibra...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591332] Review Request: debconf - Debian configuration management system

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591332

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

  Status Whiteboard|BuildFails  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

--- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-03-26 09:37:26 EDT 
---
Please submit an SCM request when setting the cvs flag, but not until you're
sponsored and the package is approved.  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

--- Comment #12 from Avi Alkalay avibra...@gmail.com 2012-03-26 09:37:12 EDT 
---
New Package SCM Request
===
Package Name: perl-WWW-Google-Contacts
Short Description: Use Perl to access, list and edit Google Contacts
Owners: aviram
Branches: f16 f17 el6
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711899] Review Request: opendnssec - DNSSEC key and zone management software

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711899

--- Comment #16 from Jon Ciesla limburg...@gmail.com 2012-03-26 09:40:07 EDT 
---
rpmlint:

opendnssec.spec:7: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

opendnssec.spec:7: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

Fix before import.

Lots of non-standard uid/gid errors, expected with custom user.

You're missing an -m on line 49 for install, which results in a spurious 0755
dir in the buildroot, and no unitdir, though unitdir is in the final RPM.

One other issue, the sources refer to a LICENSE file that's not there.

So it's just the install, the commented macros, and the LICENSE file.  Mock
build is good. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] New: Review Request: tiny-cdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: tiny-cdb - Utility and library for manipulating 
constant databases

https://bugzilla.redhat.com/show_bug.cgi?id=806926

   Summary: Review Request: tiny-cdb - Utility and library for
manipulating constant databases
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: tcall...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://spot.fedorapeople.org/tinycdb.spec
SRPM URL: http://spot.fedorapeople.org/tinycdb-0.77-4.fc17.src.rpm
Description: 
tinycdb is a small, fast and reliable utility and subroutine library for
creating and reading constant databases. The database structure is tuned
for fast reading.
Koji Rawhide Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3933211

Please note: This package was previously retired in Fedora due to FTBFS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806677] Review Request: jboss-web - JBoss Web Server

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806677

Juan Hernández juan.hernan...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||juan.hernan...@redhat.com
 AssignedTo|nob...@fedoraproject.org|juan.hernan...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Juan Hernández juan.hernan...@redhat.com 2012-03-26 
10:11:51 EDT ---
I am taking this for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591332] Review Request: debconf - Debian configuration management system

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591332

--- Comment #10 from Miroslav Suchý msu...@redhat.com 2012-03-26 09:32:47 EDT 
---
Also it is better instead of:
 %{_mandir}/fr/man1/debconf-escape.1.gz
to write:
 %{_mandir}/fr/man1/debconf-escape.1*

It can save you a bit of work when either Fedora or upstream change compression
format.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

Avi Alkalay avibra...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #14 from Avi Alkalay avibra...@gmail.com 2012-03-26 10:19:08 EDT 
---
The package was approved at Comment 6
(https://bugzilla.redhat.com/show_bug.cgi?id=800102#c6)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804659] Review Request: cdi-api - APIs for JSR-299: Contexts and Dependency Injection for Java EE

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804659

--- Comment #4 from Asaf Shakarchi a...@redhat.com 2012-03-26 10:29:34 EDT ---
Thanks,

Spec URL:
http://asaf.fedorapeople.org/rpms/cdi-api/1.0-3.SP4/cdi-api.spec

SRPM URL:
http://asaf.fedorapeople.org/rpms/cdi-api/1.0-3.SP4/cdi-api-1.0-3.SP4.fc18.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

--- Comment #15 from Jon Ciesla limburg...@gmail.com 2012-03-26 10:41:35 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804659] Review Request: cdi-api - APIs for JSR-299: Contexts and Dependency Injection for Java EE

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804659

Juan Hernández juan.hernan...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #5 from Juan Hernández juan.hernan...@redhat.com 2012-03-26 
10:45:08 EDT ---
Asaf, it looks good now.


*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591389] Review Request: po-debconf - Tool for managing templates file translations with gettext

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591389

--- Comment #11 from Jeroen van Meeuwen kana...@kanarip.com 2012-03-26 
11:06:40 EDT ---
Problem corrected by a newer version of the debconf package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tiny-cdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rdie...@math.unl.edu
 AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu
   Flag||fedora-review?

--- Comment #1 from Rex Dieter rdie...@math.unl.edu 2012-03-26 11:02:04 EDT 
---
i'll give it a whirl

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 658754] Review Request: CUBRID - a very fast and reliable open source SQL database server.

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=658754

--- Comment #3 from Michael Scherer m...@zarb.org 2012-03-26 11:14:20 EDT ---
As i suppose you already found the documentation on
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers since
you followed it so far, you need to find someone to sponsor you, and to produce
a spec file compliant for fedora. 

I can do help to see if the spec is compliant, but I cannot sponsor you ( I am
not a sponsor ), so I can only direct you to 
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group 

Maybe try to see on fedora-devel mailling list, or on irc ?

For the spec :
- Vendor:%{cubrid_vendor}
- Packager:  

both should be removed from the spec, if submitted to fedora

- the %description should be improved

- there should be a systemd file

- the %postun should not remove the configuration, and in fact, there is lots
of thing that should not be done in %postun or %post and that your spec do

( for example, removing the config in /etc/curbic is a big no as it prevent
upgrade :/ )

there is lots of thing to fix, and so I would suggest to take a ook at the
packaging policy, to try to understand them, etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tiny-cdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Rex Dieter rdie...@math.unl.edu 2012-03-26 11:22:00 EDT 
---
scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3933487

$ rpmlint *.src.rpm tinycdb tinycdb-devel
tinycdb.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcdb.so.1
linux-vdso.so.1
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
(mostly harmless)

SHOULD: please add comment near sed in %prep to explain it's purpose (it's only
~%95 obvious at first glance).

Naming: ok

Licensing: ok

Sources: ok
$ md5sum *.gz
c00e5fb96c30356ac3b67b2ab5d5641b  tinycdb_0.77.tar.gz

macros: ok

scriplets: ok

-devel deps: ok

The rest is fairly simple, and clean.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #9 from Michael Scherer m...@zarb.org 2012-03-26 11:40:12 EDT ---

Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
 Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[!]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm  4.4
 Note: defattr() present in %files section. This is OK if packaging
 for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
 Note: Licenses found: UNKNOWN For detailed output of licensecheck see
 file: /home/misc/checkout/git/FedoraReview/src/737972/licensecheck.txt
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint spacewalk-admin-1.8.2-1.fc18.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint spacewalk-admin-1.8.2-1.fc18.noarch.rpm

spacewalk-admin.noarch: W: no-manual-page-for-binary rhn-generate-pem.pl
spacewalk-admin.noarch: W: no-manual-page-for-binary rhn-deploy-ca-cert.pl
spacewalk-admin.noarch: W: no-manual-page-for-binary rhn-install-ssl-cert.pl
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
 upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
 architectures.
[x]: SHOULD 

[Bug 806926] Review Request: tiny-cdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #3 from Tom spot Callaway tcall...@redhat.com 2012-03-26 
11:37:50 EDT ---
Package Change Request
==
Package Name: tiny-cdb
New Branches: F16 F17
Owners: spot
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804659] Review Request: cdi-api - APIs for JSR-299: Contexts and Dependency Injection for Java EE

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804659

--- Comment #6 from Asaf Shakarchi a...@redhat.com 2012-03-26 11:45:30 EDT ---
New Package SCM Request
===
Package Name: cdi-api
Short Description: APIs for JSR-299: Contexts and Dependency Injection for Java
EE
Owners: asaf
Branches: f17
InitialCC: goldmann

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|m...@zarb.org
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804659] Review Request: cdi-api - APIs for JSR-299: Contexts and Dependency Injection for Java EE

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804659

Asaf Shakarchi a...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804659] Review Request: cdi-api - APIs for JSR-299: Contexts and Dependency Injection for Java EE

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804659

--- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-03-26 11:59:53 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tiny-cdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

--- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-03-26 12:06:10 EDT 
---
Should be a New Package Request, not Change.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 730314] Review Request: jboss-invocation - JBoss Invocation API

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730314

--- Comment #12 from Marek Goldmann mgold...@redhat.com 2012-03-26 12:10:36 
EDT ---
Now they're in place. I missed them in my workflow, sorry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tinycdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

Summary|Review Request: tiny-cdb -  |Review Request: tinycdb -
   |Utility and library for |Utility and library for
   |manipulating constant   |manipulating constant
   |databases   |databases

--- Comment #5 from Rex Dieter rdie...@math.unl.edu 2012-03-26 12:12:22 EDT 
---
should be Package Name: tinycdb
I guess, which does match an existing one (adjusting Summary to match)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806677] Review Request: jboss-web - JBoss Web Server

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806677

--- Comment #2 from Juan Hernández juan.hernan...@redhat.com 2012-03-26 
12:32:37 EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:

Output of rpmlint of the source package:

$ rpmlint jboss-web-7.0.13-1.fc18.src.rpm
jboss-web.src: E: description-line-too-long C JBoss Web Server is an enterprise
ready web server designed for medium and large applications, based on Tomcat.
jboss-web.src: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP Error
403: Forbidden
jboss-web.src:60: W: macro-in-comment %{_javadocdir}
jboss-web.src:60: W: macro-in-comment %{name}
jboss-web.src:61: W: macro-in-comment %{_javadocdir}
jboss-web.src:61: W: macro-in-comment %{name}
jboss-web.src: W: invalid-url Source0: jboss-web-7.0.13.Final.tar.xz
1 packages and 0 specfiles checked; 1 errors, 6 warnings.

Output of rpmlint of the binary packages:

$ rpmlint jboss-web-7.0.13-1.fc18.noarch.rpm
jboss-web-doc-7.0.13-1.fc18.noarch.rpm jboss-web.noarch: E:
description-line-too-long C JBoss Web Server is an enterprise ready web server
designed for medium and large applications, based on Tomcat.
jboss-web.noarch: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP Error
403: Forbidden
jboss-web-doc.noarch: W: invalid-url URL: http://www.jboss.org/jbossweb HTTP
Error 403: Forbidden
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

URL warnings are acceptable.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3933281

[x]  Buildroot definition is not present

[!]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].

Some of the source files state in their license header that they are covered by
CDDL or GPLv2+ or ASL 2.0, which are known to be imcompatible. This affects
most of the files in the java/javax directory. See for example the file
java/javax/servlet/ServletContextListener.java.

[!]  License field in the package spec file matches the actual license.

The license in the spec file is LGPLv3+ but the package contains files with a
mix of licenses. Some examples:

LGPLv2.1+: java/org/jboss/servlet/http/HttpEventFilterChain.java
LGPLv2+: java/org/jboss/web/php/PhpThread.java
ASL 2.0: java/org/apache/jasper/*
LGPLv2.1+ or ASL 2.0: java/org/apache/naming/resources/ProxyDirContext.java
MIT: java/org/apache/tomcat/util/json/JSONTokener.java
CDDL or LGPLv2+: java/javax/servlet/ServletContainerInitializer.java 

[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.

Checked using a recursive diff of the sources, which gives output like this:

diff --recursive --unified
t/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java
t2/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java
---
t/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java
2011-10-11 17:29:56.0 +0200
+++
t2/jboss-web-7.0.13.Final/java/org/apache/catalina/authenticator/AuthenticatorBase.java
2011-10-11 17:29:56.818919000 +0200
@@ -70,7 +70,7 @@
  * requests.  Requests of any other type will simply be passed
  * through.
  *
  * @author Craig R. McClanahan
- * @version $Revision: 1848 $ $Date: 2011-10-11 11:29:56 -0400
  (Tue, 11 Oct 2011) $
+ * @version $Revision: 1848 $ $Date: 2011-10-11 17:29:56 +0200
(Tue, 11 Oct 2011) $
  */

These differences are acceptable, as they appear due to distinct time zones and
subversion quirks.

[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other
packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable 

[Bug 761319] Review Request: gtkd - It is a D binding and OO wrapper of GTK+

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=761319

MERCIER Jonathan bioinfornat...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #37 from MERCIER Jonathan bioinfornat...@gmail.com 2012-03-26 
12:54:08 EDT ---
New Package SCM Request
===
Package Name: gtkd
Short Description: It is a D binding and OO wrapper of GTK+
Owners: bioinfornatics
Branches: f17
InitialCC: bioinfornatics

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806677] Review Request: jboss-web - JBoss Web Server

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806677

--- Comment #3 from Anthony Sasadeusz sasad...@umbc.edu 2012-03-26 12:58:57 
EDT ---
Okay, I will work on it. Thanks for the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 761319] Review Request: gtkd - It is a D binding and OO wrapper of GTK+

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=761319

--- Comment #38 from Jon Ciesla limburg...@gmail.com 2012-03-26 13:06:32 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

Avi Alkalay avibra...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2012-03-26 13:02:50

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798079] Review Request: validns - DNS and DNSSEC zone file validator

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798079

Paul Wouters pwout...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: vaildns -   |Review Request: validns -
   |DNS and DNSSEC zone file|DNS and DNSSEC zone file
   |validator:q |validator

--- Comment #7 from Paul Wouters pwout...@redhat.com 2012-03-26 13:09:17 EDT 
---
Fixed title of the bug here

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798079] Review Request: validns - DNS and DNSSEC zone file validator

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798079

Paul Wouters pwout...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798079] Review Request: validns - DNS and DNSSEC zone file validator

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798079

--- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-03-26 13:23:06 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804055] Review Request: spring-ldap - Java library for simplifying LDAP operations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804055

Asaf Shakarchi a...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Asaf Shakarchi a...@redhat.com 2012-03-26 13:26:49 EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:

Output of rpmlint of the source package:


$ rpmlint spring-ldap-1.3.1-1.fc18.src.rpm
spring-ldap.src: I: enchant-dictionary-not-found en_US
spring-ldap.src: W: invalid-url Source0: spring-ldap-1.3.1.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

The warning is acceptable.


Output of rpmlint of the binary packages:

$ rpmlint spring-ldap-1.3.1-1.fc18.noarch.rpm
spring-ldap.noarch: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.

http://koji.fedoraproject.org/koji/taskinfo?taskID=3925805

[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: ASL 2.0
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.

Sources are equal and verified by using a recursive diff.

[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other
packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[x]  If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-]  If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.

Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=3933996


It looks good now.


*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 800102] Review Request: perl-WWW-Google-Contacts - Use Perl to access, list and edit Google Contacts

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800102

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800265] Review Request: perl-Net-Google-Spreadsheets - Perl module for using Google Spreadsheets API

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800265

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800284] Review Request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800284

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

 CC||ktdre...@ktdreyer.com
 Blocks|177841(FE-NEEDSPONSOR)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800105] Review Request: perl-Net-Google-Calendar - Programmatic access to Google's Calendar API

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800105

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

 CC||ktdre...@ktdreyer.com
 Blocks|177841(FE-NEEDSPONSOR)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tinycdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #6 from Tom spot Callaway tcall...@redhat.com 2012-03-26 
13:27:44 EDT ---
Package Change Request
==
Package Name: tinycdb
New Branches: F16 F17
Owners: spot
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760154] Review Request: xcb-util-keysyms - Standard X key constants and keycodes conversion on top of libxcb

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760154

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com

--- Comment #4 from Tom spot Callaway tcall...@redhat.com 2012-03-26 
13:26:57 EDT ---
Friendly ping! This is needed to resolve some broken F17 dependencies. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804055] Review Request: spring-ldap - Java library for simplifying LDAP operations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804055

Juan Hernández juan.hernan...@redhat.com changed:

   What|Removed |Added

 Blocks|652183(FE-JAVASIG)  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804055] Review Request: spring-ldap - Java library for simplifying LDAP operations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804055

Juan Hernández juan.hernan...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Juan Hernández juan.hernan...@redhat.com 2012-03-26 
13:32:09 EDT ---
New Package SCM Request
===
Package Name: spring-ldap
Short Description: Java library for simplifying LDAP operations
Owners: jhernand
Branches: f17
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804055] Review Request: spring-ldap - Java library for simplifying LDAP operations

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804055

--- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-03-26 13:59:08 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tinycdb - Utility and library for manipulating constant databases

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

--- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-03-26 14:01:26 EDT 
---
Git done (by process-git-requests).

Unretired devel, take ownership of devel and f15.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802377] Review Request: perl-Env-Sanctify - Lexically scoped sanctification of %ENV

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802377

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2012-03-26 14:00:02 EDT ---
perl-Env-Sanctify-1.06-1.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802377] Review Request: perl-Env-Sanctify - Lexically scoped sanctification of %ENV

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802377

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2012-03-26 14:00:56 EDT ---
perl-Env-Sanctify-1.06-1.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785727] Review Request: ocaml-camlimages - OCaml image processing library

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785727

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|ocaml-camlimages-4.0.1-2.fc |ocaml-camlimages-4.0.1-2.fc
   |16  |15

--- Comment #21 from Fedora Update System upda...@fedoraproject.org 
2012-03-26 13:57:06 EDT ---
ocaml-camlimages-4.0.1-2.fc15 has been pushed to the Fedora 15 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785727] Review Request: ocaml-camlimages - OCaml image processing library

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785727

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|ocaml-camlimages-4.0.1-2.fc |ocaml-camlimages-4.0.1-2.fc
   |15  |16

--- Comment #22 from Fedora Update System upda...@fedoraproject.org 
2012-03-26 14:01:06 EDT ---
ocaml-camlimages-4.0.1-2.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711899] Review Request: opendnssec - DNSSEC key and zone management software

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711899

--- Comment #18 from Paul Wouters pwout...@redhat.com 2012-03-26 13:16:20 EDT 
---
Jon Ciesla: if you took over the review, can you set the review flag to + for
me, so I can requst the SCM?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711899] Review Request: opendnssec - DNSSEC key and zone management software

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711899

Paul Wouters pwout...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #21 from Paul Wouters pwout...@redhat.com 2012-03-26 13:59:34 EDT 
---
New Package SCM Request
===
Package Name: opendnssec
Short Description: DNSSEC key and zone management software
Owners: pwouters
Branches: f16 f17 el5 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798202] Review Request: python-ldappool - A connection pool for python-ldap

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798202

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-03-26 
14:20:31 EDT ---
python-ldappool-1.0-0.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-ldappool-1.0-0.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798202] Review Request: python-ldappool - A connection pool for python-ldap

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798202

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 711899] Review Request: opendnssec - DNSSEC key and zone management software

2012-03-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711899

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #19 from Jon Ciesla limburg...@gmail.com 2012-03-26 13:38:16 EDT 
---
Ok, that's fine, fix it if required by later revelations.  Thanks!

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >