[Bug 782560] Review Request: rubygem-ruby-shadow - *nix Shadow Password Module
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=782560
--- Comment #27 from Bohuslav "Slavek" Kabrda 2012-04-10
01:55:02 EDT ---
Hi Todd,
to answer your questions:
- gem_extdir is part of the new guidelines, which are in somehow inconsistent
state with how we have actually packaged Ruby and Rubygems. To make a long
story short, gem_extdir translates to
%{_libdir}/gems/exts/%{gem_name}-%{version} and from the example specfile:
"
# If there are C extensions, mv them to the extdir.
# You should replace REQUIRE_PATHS with the first value of the require_paths
field in
# the gemspec file. It will typically be either "lib" or "ext". For instance:
# s.require_paths = ["lib"]
mkdir -p %{buildroot}%{gem_extdir}/REQUIRE_PATHS
mv %{buildroot}%{gem_instdir}/REQUIRE_PATHS/shared_object.so
%{buildroot}%{gem_extdir}/REQUIRE_PATHS/
"
- Could you please add a comment to specfile, that would point to a place,
where the author explicitly claims that this library is available under public
domain?
Thanks!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664155] Review Request: ghc-data-accessor-monads-fd - A package to access state in monads-fd State Monad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664155 Bug 664155 depends on bug 664150, which changed state. Bug 664150 Summary: Review Request: ghc-monads-fd - Monad classes, using functional dependencies https://bugzilla.redhat.com/show_bug.cgi?id=664150 What|Old Value |New Value Resolution||WONTFIX Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #39 from Fedora Update System 2012-04-10 01:07:25 EDT --- smb4k-1.0.1-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/smb4k-1.0.1-5.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664150] Review Request: ghc-monads-fd - Monad classes, using functional dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664150 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2012-04-10 01:01:30 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #38 from Fedora Update System 2012-04-10 00:53:19 EDT --- smb4k-1.0.1-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/smb4k-1.0.1-5.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808336] Review Request: dia-gnomeDIAicons - Beautiful icon set for dia diagram editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808336 --- Comment #18 from Arthur Buliva 2012-04-10 00:39:42 EDT --- I don't know why the option is still disabled after all these days :-( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710031] Review Request: ghc-Agda - Dependently typed functional programming language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710031 Bug 710031 depends on bug 782000, which changed state. Bug 782000 Summary: Review Request: ghc-hashtables - Mutable hash tables in the ST monad https://bugzilla.redhat.com/show_bug.cgi?id=782000 What|Old Value |New Value Status|MODIFIED|ON_QA Status|ON_QA |CLOSED Resolution||ERRATA --- Comment #6 from Jens Petersen 2012-04-10 00:36:42 EDT --- Update to 2.3.0.1 release for ghc-7.4.1: Spec: http://petersen.fedorapeople.org/reviews/ghc-Agda/ghc-Agda.spec SRPM: http://petersen.fedorapeople.org/reviews/ghc-Agda/ghc-Agda-2.3.0.1-1.fc16.src.rpm Builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3975851 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #37 from Fedora Update System 2012-04-10 00:23:18 EDT --- smb4k-1.0.1-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/smb4k-1.0.1-5.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783825 --- Comment #31 from Brendan Jones 2012-04-10 00:14:49 EDT --- (In reply to comment #30) > On the other hand, my biggest concern was not the above scenario exactly. It > is > not uncommon that Qt updates come with ABI incompatibility. In such > circumstances, the Fedora-KDE SIG works well-coordinated to rebuild all Qt > dependant packages. If you filter out the Qt dependency from suil, they will > not know about the existence of it. The suil maintainer (that will be you > until > you give it up) will need to follow all the ABI related changes in the > underlying toolkit Qt and has to coordinate manually with the Qt updates at > all > times. > A similar argument applies for gtk rebuilds (although admittedly I don't have > much experinence with gtk), or any other toolkit that will be supported by > suil > in the future. Sure, understand that this is a real concern. > > Are you sure do you want to walk that road? Shall we ask this in the > Fedora-packaging list perhaps? What is so bad about dragging in the toolkits > (seriously)? Attached (part of) a discussion on IRC with #lv2. Sure, I understand what you are saying. Whilst both toolkits are *likely* to be present anyway I can also envision a scenario whereby this may not be the case (e.g. a remix on an embedded device) I could package without the requires, make a note of it in the spec file and revisit again if presented with a requirement to remove the unnecessary dependencies. Although it does irk me to go against upstream's recommendations -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783825 --- Comment #32 from Brendan Jones 2012-04-10 00:15:53 EDT --- Created attachment 576375 --> https://bugzilla.redhat.com/attachment.cgi?id=576375 #lv2 IRC discussion excerpt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664150] Review Request: ghc-monads-fd - Monad classes, using functional dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664150 Jens Petersen changed: What|Removed |Added Status Whiteboard||notready -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 712659] Review Request: yi - An extensible text editor written in Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=712659 Jens Petersen changed: What|Removed |Added Depends on|664155 | Bug 712659 depends on bug 756386, which changed state. Bug 756386 Summary: Review Request: ghc-unordered-containers - Efficient hashing-based container types https://bugzilla.redhat.com/show_bug.cgi?id=756386 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED Bug 712659 depends on bug 664221, which changed state. Bug 664221 Summary: Review Request: ghc-cautious-file - Provides ways to write a file cautiously https://bugzilla.redhat.com/show_bug.cgi?id=664221 What|Old Value |New Value Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664150] Review Request: ghc-monads-fd - Monad classes, using functional dependencies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664150 --- Comment #11 from Jens Petersen 2012-04-09 23:48:06 EDT --- yi-0.6.5.0 no longer requires data-accessor-monads-fd. I suggest closing this WONTFIX. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664155] Review Request: ghc-data-accessor-monads-fd - A package to access state in monads-fd State Monad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664155 Jens Petersen changed: What|Removed |Added Blocks|712659(yi) | --- Comment #5 from Jens Petersen 2012-04-09 23:50:30 EDT --- As of 0.6.5, yi no longer needs data-accessor-monads-fd. Probably this can be closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783825 --- Comment #30 from Orcan Ogetbil 2012-04-09 23:31:09 EDT --- Thanks for the explanation. Do you have any links for the discussions? Please correct me if I am wrong: If gtk and Qt are the only supported toolkits by suil, then the plugin will drag in the Qt and the host will drag in gtk, or vice versa. Since both gtk and Qt will be dragged in in either case, it does not matter if the toolkit dependencies of suil are filtered out or not. However the story changes if suil supports more than these 2 toolkits (which is not the case for the time being). On the other hand, my biggest concern was not the above scenario exactly. It is not uncommon that Qt updates come with ABI incompatibility. In such circumstances, the Fedora-KDE SIG works well-coordinated to rebuild all Qt dependant packages. If you filter out the Qt dependency from suil, they will not know about the existence of it. The suil maintainer (that will be you until you give it up) will need to follow all the ABI related changes in the underlying toolkit Qt and has to coordinate manually with the Qt updates at all times. A similar argument applies for gtk rebuilds (although admittedly I don't have much experinence with gtk), or any other toolkit that will be supported by suil in the future. Are you sure do you want to walk that road? Shall we ask this in the Fedora-packaging list perhaps? What is so bad about dragging in the toolkits (seriously)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810033] Review Request: python-virtualenvwrapper - Enhancements to virtualenv
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810033 --- Comment #3 from Ralph Bean 2012-04-09 22:44:37 EDT --- That patch got merged in upstream and a new version was released. Here is an updated RPM for the latest version that also contains a patch for the rpmlint issues. SPEC: http://threebean.org/rpm/python-virtualenvwrapper.spec SRPM: http://threebean.org/rpm/python-virtualenvwrapper-3.2-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806536] Review Request: ghc-resourcet - Deterministic allocation and freeing of scarce resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806536 --- Comment #4 from Fedora Update System 2012-04-09 22:45:26 EDT --- ghc-resourcet-0.3.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-resourcet-0.3.2-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806536] Review Request: ghc-resourcet - Deterministic allocation and freeing of scarce resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806536 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806536] Review Request: ghc-resourcet - Deterministic allocation and freeing of scarce resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806536 --- Comment #6 from Fedora Update System 2012-04-09 22:45:46 EDT --- ghc-resourcet-0.3.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-resourcet-0.3.2-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806536] Review Request: ghc-resourcet - Deterministic allocation and freeing of scarce resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806536 --- Comment #5 from Fedora Update System 2012-04-09 22:45:36 EDT --- ghc-resourcet-0.3.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-resourcet-0.3.2-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693126] Review Request: openvas-administrator - Administrator Module for the Open Vulnerability Assessment System (OpenVAS)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693126 --- Comment #4 from Michal Ambroz 2012-04-09 22:40:10 EDT --- SPEC: http://rebus.fedorapeople.org/SPECS/openvas-administrator.spec SRPM: http://rebus.fedorapeople.org/SRPMS/openvas-administrator-1.1.2-2.fc17.src.rpm Updated from sysv init scripts to systemd init scripts. Scratch build for rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=3975807 Scratch build for f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3975814 Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810382] Review Request: python-txzmq - Twisted bindings for ZeroMQ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810382 --- Comment #3 from Ralph Bean 2012-04-09 22:22:39 EDT --- Updated the spec and SRPM. SPEC: http://threebean.org/rpm/python-txzmq.spec SRPM: http://threebean.org/rpm/python-txzmq-0.3.1-2.fc17.src.rpm - Changed BuildRequires python-devel to python2-devel. - Dropped the %defattr macro . - Patched to disable the EPGM test. libpgm isn't packaged for fedora yet. - Added %check section to run nosetests. The spelling errors coming from rpmlint are false positives, I think. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 --- Comment #4 from Ralph Bean 2012-04-09 20:49:13 EDT --- Sorry, the SRPM link is wrong. It is actually: http://threebean.org/rpm/python-txws-0.7-3.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810386] Review Request: python-txws - Twisted WebSockets wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810386 --- Comment #3 from Ralph Bean 2012-04-09 20:46:56 EDT --- * No plans to support EPEL5. I removed the %defattr * rpmlint output is now silent except for the macro-in-comment line that the reviewer allowed. * Requested that upstream add a LICENSE file in the future - https://github.com/MostAwesomeDude/txWS/pull/10 The latest version of the specfile and RPM can be found here: SPEC: http://threebean.org/rpm/python-txws.spec SRPM: http://threebean.org/rpm/python-txws-0.7-3.f17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807113] Review Request: zanata-util - Helper scripts for using Zanata
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807113 --- Comment #16 from Fedora Update System 2012-04-09 20:45:35 EDT --- zanata-util-0.2.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/zanata-util-0.2.3-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807017] Review Request: ovirt-engine - Management server for Open Virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807017 Steven Dake changed: What|Removed |Added CC||sd...@redhat.com --- Comment #8 from Steven Dake 2012-04-09 20:27:14 EDT --- Ofer, If your going to review this package, please 1. assign it to yourself (click take button) 2. place into the ASSIGNED state so Juan knows you are taking responsibility for reviewing his package. 3 Set "fedora-review" flag to ? to indicate you are currently reviewing the package. Regards -steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 430603] Review Request: clex - A free file manager with a full-screen user interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=430603 --- Comment #35 from Jason Tibbitts 2012-04-09 18:40:26 EDT --- Nobody is going to re-review a ticket in this state. I only happened to see it by chance. If you would like a re-review, please file a new review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810010] Review Request: genders - file based database for cluster managment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810010 --- Comment #4 from David Brown 2012-04-09 17:52:14 EDT --- I've updated the genders.spec and src.rpm to remove the rhel checks entirely and now it builds fine on RHEL with EPEL and rpmlint shows more warnings about groups not specified. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810336] Review Request: ga - Global Arrays Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810336 --- Comment #7 from David Brown 2012-04-09 17:53:11 EDT --- I've run rpmlint in the resulting rpms from mock and cleaned up quite a bit of cruft from the original ga.spec so please check it out again. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806446] Re-Review Request: musique (replacing minitunes) - A music player designed by and for people that love music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806446 Gregor Tätzner changed: What|Removed |Added CC||gre...@freenet.de AssignedTo|nob...@fedoraproject.org|gre...@freenet.de --- Comment #3 from Gregor Tätzner 2012-04-09 17:09:48 EDT --- I'm going to take this review first look: - remove gcc-c++ build req it's not necessary - add icon scriptlets http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache - install or validate the desktop file - did you actually test the translation? In the past we had some problems with software from this upstream. If you want to see how it's done right have a look at minitube (from rpmfusion) - remove INSTALL file from doc - users just install the package :) - and have a look at the remove-qtsingleapp patch in minitube. musique is bundling the same lib too and this is not allowed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768538] Review Request: why3 - Software verification platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768538 Jon Ciesla changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com Flag||fedora-review? Bug 768538 depends on bug 754245, which changed state. Bug 754245 Summary: Review Request: ocaml-menhir - LR(1) parser generator for OCaml https://bugzilla.redhat.com/show_bug.cgi?id=754245 What|Old Value |New Value Status|NEW |MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #1 from Jon Ciesla 2012-04-09 16:18:17 EDT --- Good: - rpmlint checks return: why3.src: W: spelling-error %description -l en_US provers -> proves, rovers, proverbs The value of this tag appears to be misspelled. Please double-check. Ignore. why3-emacs.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. why3-emacs-el.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. why3-xemacs.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. why3-xemacs-el.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. why3.x86_64: W: no-manual-page-for-binary why3-cpulimit Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3ml Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3config Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3bench Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3 Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3realize Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3replayer Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3doc Each executable in standard binary directories should have a man page. why3.x86_64: W: no-manual-page-for-binary why3ide Each executable in standard binary directories should have a man page. why3-all.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. why3-coq.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Fix if possbile, examine at least. - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2 with exceptions ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR Mock rawhide build fails, missing BuildRequires on sqlite-devel. After that it's fine. - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Comment on why debuginfo is disabled, or enable it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807476] Review Request:ima-evm-utils -IMA/EVM support utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807476 Paul Wouters changed: What|Removed |Added Summary|Review Request:evm-utils|Review |-IMA/EVM support utilities |Request:ima-evm-utils ||-IMA/EVM support utilities -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #15 from Dan Horák 2012-04-09 15:47:51 EDT --- Created attachment 576293 --> https://bugzilla.redhat.com/attachment.cgi?id=576293 diff between sigil and upstream libtidy Hans, I'm working on the review again, sorry for the delays. These are the changes between sigil and upstream version of libtidy. The good thing is that it doesn't change ABI or API in an incompatible way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 746795] Review Request: io Programming Language - Io is a prototype-based programming language inspired by Smalltalk, Self, NewtonScript, Act1, LISP and Lua.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746795 Jon Ciesla changed: What|Removed |Added Status|NEW |CLOSED Resolution||ERRATA Last Closed||2012-04-09 15:22:38 --- Comment #4 from Jon Ciesla 2012-04-09 15:22:38 EDT --- Please contact me if you'd like your changes integrated into the existing Fedora IO-Language rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226223] Merge Review: ORBit2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226223
Jon Ciesla changed:
What|Removed |Added
CC||limburg...@gmail.com
AssignedTo|mtas...@fedoraproject.org |limburg...@gmail.com
--- Comment #9 from Jon Ciesla 2012-04-09 14:41:04 EDT
---
Fresh review:
- rpmlint checks return:
ORBit2.spec:389: W: macro-in-%changelog %{_datadir}
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build. Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted. Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.
ORBit2.spec:551: W: macro-in-%changelog %files
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build. Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted. Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.
ORBit2.spec:551: W: macro-in-%changelog %{prefix}
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build. Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted. Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.
Trivial to fix.
Some no man page and wrong fsf address errors, fix if feasible.
- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2+ and GPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
So trivial things, and Parag's comments on patches.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225989] Merge Review: libbonobo
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225989
Jon Ciesla changed:
What|Removed |Added
CC|dav...@redhat.com |
--- Comment #3 from Jon Ciesla 2012-04-09 14:24:20 EDT
---
- rpmlint checks return:
libbonobo.spec:25: W: unversioned-explicit-obsoletes bonobo-activation
libbonobo.spec:42: W: unversioned-explicit-obsoletes bonobo-activation-devel
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing. This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.
Fix.
libbonobo.spec:72: E: hardcoded-library-path in
%{_prefix}/lib/bonobo-2.0/samples/bonobo-echo-2
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
libbonobo.spec:87: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
libbonobo.spec:106: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
libbonobo.spec:107: E: hardcoded-library-path in %{_prefix}/lib/bonobo
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
Fix.
libbonobo.spec: W: %ifarch-applied-patch Patch0: libbonobo-multishlib.patch
A patch is applied inside an %ifarch block. Patches must be applied on all
architectures and may contain necessary configure and/or code patch to be
effective only on a given arch.
Fix if possible.
Ignorable spelling error.
libbonobo.x86_64: W: self-obsoletion bonobo-activation obsoletes
bonobo-activation = 2.32.1-2.fc18
The package obsoletes itself. This is known to cause errors in various tools
and should thus be avoided, usually by using appropriately versioned Obsoletes
and/or Provides and avoiding unversioned ones.
libbonobo-devel.x86_64: W: self-obsoletion bonobo-activation-devel obsoletes
bonobo-activation-devel = 2.32.1-2.fc18
The package obsoletes itself. This is known to cause errors in various tools
and should thus be avoided, usually by using appropriately versioned Obsoletes
and/or Provides and avoiding unversioned ones.
Fix.
libbonobo.x86_64: W: conffile-without-noreplace-flag
/etc/bonobo-activation/bonobo-activation-config.xml
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
Fix if reasonable.
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ and LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
So it's just the rpmlitn bits, let me know if you want me to commit anything.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #35 from Fedora Update System 2012-04-09 14:25:20 EDT --- smb4k-1.0.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/smb4k-1.0.1-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #34 from Fedora Update System 2012-04-09 14:24:10 EDT --- smb4k-1.0.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/smb4k-1.0.1-4.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #36 from Fedora Update System 2012-04-09 14:26:14 EDT --- smb4k-1.0.1-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/smb4k-1.0.1-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225748] Merge Review: festival
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225748
Jon Ciesla changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||limburg...@gmail.com
AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com
Flag||fedora-review?
--- Comment #1 from Jon Ciesla 2012-04-09 14:16:58 EDT
---
- rpmlint checks return:
festival.spec:212: W: unversioned-explicit-provides festival-voice
festival.spec:213: W: unversioned-explicit-provides festvox-kallpc16k
festival.spec:221: W: unversioned-explicit-provides festival-voice
festival.spec:222: W: unversioned-explicit-provides festvox-kedlpc16k
festival.spec:230: W: unversioned-explicit-provides festival-voice
festival.spec:238: W: unversioned-explicit-provides festival-voice
festival.spec:246: W: unversioned-explicit-provides festival-voice
festival.spec:254: W: unversioned-explicit-provides festival-voice
festival.spec:262: W: unversioned-explicit-provides festival-voice
festival.spec:270: W: unversioned-explicit-provides festival-voice
festival.spec:278: W: unversioned-explicit-provides festival-voice
festival.spec:286: W: unversioned-explicit-provides festival-voice
The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing. This may cause update
problems and will make versioned dependencies, obsoletions and conflicts on
the provided thing useless -- make the Provides versioned if possible.
Should be fixed.
festival.spec:1080: W: macro-in-%changelog %{festivalversion}
festival.spec:1157: W: macro-in-%changelog %{_bindir}
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build. Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted. Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.
Trivial to fix.
festival.spec:746: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line
746)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
Trivial to fix.
Lots of no-manpage, wrong end of line encoding, no-shebang or spurious
executable perms.
festival-devel.x86_64: W: no-dependency-on festival/festival-libs/libfestival
festival-lib.x86_64: E: explicit-lib-dependency festival-speechtools-libs
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
Fix.
festival-speechtools-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libestbase.so.1.2.96.1 exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
festival-speechtools-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libestools.so.1.2.96.1 exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
festival-speechtools-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libeststring.so.1.2 exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
Should be fixed if at all possible.
- package meets naming guidelines
- package meets packaging guidelines
- license ( MIT and GPL+ and TCL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
Though it's ancient. . . and the doc versions still don't match.
- package compiles on d
[Bug 225989] Merge Review: libbonobo
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225989
Jon Ciesla changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||dav...@redhat.com,
||limburg...@gmail.com
AssignedTo|nob...@fedoraproject.org|limburg...@gmail.com
Flag||fedora-review?
Bug 225989 depends on bug 226223, which changed state.
Bug 226223 Summary: Merge Review: ORBit2
https://bugzilla.redhat.com/show_bug.cgi?id=226223
What|Old Value |New Value
Status|NEEDINFO|ASSIGNED
--- Comment #1 from Jon Ciesla 2012-04-09 14:14:57 EDT
---
- rpmlint checks return:
festival.spec:212: W: unversioned-explicit-provides festival-voice
festival.spec:213: W: unversioned-explicit-provides festvox-kallpc16k
festival.spec:221: W: unversioned-explicit-provides festival-voice
festival.spec:222: W: unversioned-explicit-provides festvox-kedlpc16k
festival.spec:230: W: unversioned-explicit-provides festival-voice
festival.spec:238: W: unversioned-explicit-provides festival-voice
festival.spec:246: W: unversioned-explicit-provides festival-voice
festival.spec:254: W: unversioned-explicit-provides festival-voice
festival.spec:262: W: unversioned-explicit-provides festival-voice
festival.spec:270: W: unversioned-explicit-provides festival-voice
festival.spec:278: W: unversioned-explicit-provides festival-voice
festival.spec:286: W: unversioned-explicit-provides festival-voice
The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing. This may cause update
problems and will make versioned dependencies, obsoletions and conflicts on
the provided thing useless -- make the Provides versioned if possible.
Should be fixed.
festival.spec:1080: W: macro-in-%changelog %{festivalversion}
festival.spec:1157: W: macro-in-%changelog %{_bindir}
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build. Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted. Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.
Trivial to fix.
festival.spec:746: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line
746)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
Trivial to fix.
Lots of no-manpage, wrong end of line encoding, no-shebang or spurious
executable perms.
festival-devel.x86_64: W: no-dependency-on festival/festival-libs/libfestival
festival-lib.x86_64: E: explicit-lib-dependency festival-speechtools-libs
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
Fix.
festival-speechtools-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libestbase.so.1.2.96.1 exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
festival-speechtools-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libestools.so.1.2.96.1 exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
festival-speechtools-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libeststring.so.1.2 exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
a
[Bug 225989] Merge Review: libbonobo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225989 --- Comment #2 from Jon Ciesla 2012-04-09 14:16:11 EDT --- Sorry, wrong bug. . .ignore that comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808254] Review Request: twirssi - Allows you to post to Twitter from Irssi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808254 --- Comment #14 from Fedora Update System 2012-04-09 13:59:52 EDT --- twirssi-2.5.1-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/twirssi-2.5.1-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808254] Review Request: twirssi - Allows you to post to Twitter from Irssi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808254 --- Comment #13 from Fedora Update System 2012-04-09 13:52:42 EDT --- twirssi-2.5.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/twirssi-2.5.1-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808254] Review Request: twirssi - Allows you to post to Twitter from Irssi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808254 --- Comment #12 from Fedora Update System 2012-04-09 13:45:10 EDT --- twirssi-2.5.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/twirssi-2.5.1-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 --- Comment #9 from Fedora Update System 2012-04-09 13:27:28 EDT --- perl-WWW-Shorten-3.03-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-WWW-Shorten-3.03-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 --- Comment #21 from Fedora Update System 2012-04-09 13:26:42 EDT --- perl-NetPacket-SpanningTree-0.01-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-NetPacket-SpanningTree-0.01-5.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 --- Comment #20 from Fedora Update System 2012-04-09 13:26:32 EDT --- perl-NetPacket-SpanningTree-0.01-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-NetPacket-SpanningTree-0.01-5.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 --- Comment #19 from Fedora Update System 2012-04-09 13:17:11 EDT --- perl-NetPacket-SpanningTree-0.01-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-NetPacket-SpanningTree-0.01-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 --- Comment #8 from Fedora Update System 2012-04-09 13:19:06 EDT --- perl-WWW-Shorten-3.03-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-WWW-Shorten-3.03-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573917] Review Request: perl-NetPacket-SpanningTree - Assemble and disassemble IEEE 802.1D Spanning Tree protocol packets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573917 --- Comment #18 from Fedora Update System 2012-04-09 13:16:59 EDT --- perl-NetPacket-SpanningTree-0.01-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-NetPacket-SpanningTree-0.01-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 --- Comment #7 from Fedora Update System 2012-04-09 13:12:33 EDT --- perl-WWW-Shorten-3.03-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-WWW-Shorten-3.03-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751609] Review Request: ghc-fingertree - Haskell package provides generic finger-tree structure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751609 --- Comment #3 from Lakshmi Narasimhan 2012-04-09 13:15:16 EDT --- Hi Heherson, Any update on this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619228] Review Request: shellinaboxd - AJAX based terminal emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619228 Lakshmipathi changed: What|Removed |Added CC||lakshmipath...@gmail.com --- Comment #10 from Lakshmipathi 2012-04-09 13:09:00 EDT --- > package and so on? If so, where should the selinux policy go? > > -Robin Hi Robin, Could you please let me know where I can get the SELinux policy for shellinaboxd? Is it already available with Fedora? Thanks for help. -Lakshmipathi.G -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 791363] Review Request: perl-XML-DTDParser - Quick and dirty DTD parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791363 --- Comment #15 from Fedora Update System 2012-04-09 13:07:33 EDT --- perl-XML-DTDParser-2.01-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-XML-DTDParser-2.01-4.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810939] New: Review Request: perl-bareword-filehandles - Disables bareword filehandles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-bareword-filehandles - Disables bareword filehandles https://bugzilla.redhat.com/show_bug.cgi?id=810939 Summary: Review Request: perl-bareword-filehandles - Disables bareword filehandles Product: Fedora Version: rawhide Platform: Unspecified URL: http://search.cpan.org/dist/bareword-filehandles/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: iarn...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fedorapeople.org/~iarnell/review/perl-bareword-filehandles.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-bareword-filehandles-0.003-1.fc18.src.rpm Description: This module lexically disables the use of bareword filehandles with builtin functions, except for the special builtin filehandles STDIN, STDOUT, STDERR, ARGV, ARGVOUT and DATA. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3974798 *rt-0.10_02 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810937] New: Review Request: perl-multidimensional - Disables multidimensional array emulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-multidimensional - Disables multidimensional array emulation https://bugzilla.redhat.com/show_bug.cgi?id=810937 Summary: Review Request: perl-multidimensional - Disables multidimensional array emulation Product: Fedora Version: rawhide Platform: Unspecified URL: http://search.cpan.org/dist/multidimensional/ OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: iarn...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://fedorapeople.org/~iarnell/review/perl-multidimensional.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-multidimensional-0.010-1.fc16.src.rpm Description: Perl's multidimensional array emulation stems from the days before the language had references, but these days it mostly serves to bite you when you typo a hash slice by using the $ sigil instead of @. This module lexically makes using multidimensional array emulation a fatal error at compile time. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3974725 *rt-0.10_02 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 791363] Review Request: perl-XML-DTDParser - Quick and dirty DTD parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791363 --- Comment #14 from Fedora Update System 2012-04-09 12:59:47 EDT --- perl-XML-DTDParser-2.01-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-XML-DTDParser-2.01-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810928] Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810928 --- Comment #1 from David Riches 2012-04-09 12:53:19 EDT --- rpmlint output: [david@puppet rpmbuild]$ rpmlint SPECS/sticky-notes.spec SPECS/sticky-notes.spec: W: invalid-url Source0: sticky-notes-20120407git.tar 0 packages and 1 specfiles checked; 0 errors, 1 warnings. [david@puppet rpmbuild]$ rpmlint SRPMS/sticky-notes-20120407git-1.fc16.src.rpm sticky-notes.src: W: invalid-url Source0: sticky-notes-20120407git.tar 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [david@puppet rpmbuild]$ rpmlint RPMS/noarch/sticky-notes-20120407git-1.fc16.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Koji: F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3974692 F16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3974676 F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=3974693 Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3974694 Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810928] New: Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application https://bugzilla.redhat.com/show_bug.cgi?id=810928 Summary: Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: davi...@ultracar.co.uk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://www.dcr226.co.uk/sticky-notes.spec SRPM URL: http://www.dcr226.co.uk/sticky-notes-20120407git-1.fc16.src.rpm Description: Sticky notes is a free and open source paste-bin application. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 --- Comment #12 from Jon Ciesla 2012-04-09 12:41:30 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810926] New: Review Request: rubygem-qpid - Ruby bindings for the Qpid messaging framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-qpid - Ruby bindings for the Qpid messaging framework https://bugzilla.redhat.com/show_bug.cgi?id=810926 Summary: Review Request: rubygem-qpid - Ruby bindings for the Qpid messaging framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: dpie...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-qpid-0.16.0-1.fc16.src.rpm Description: Qpid is an enterprise messaging framework. This package provides Ruby language bindings based on that framework. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810417 Paul Wouters changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Paul Wouters 2012-04-09 12:31:16 EDT --- Will do, thanks! New Package SCM Request === Package Name: geome Short Description: Obtain your geolocation data from Google using NetworkManager Owners: pwouters Branches: f16 f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 791363] Review Request: perl-XML-DTDParser - Quick and dirty DTD parser
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=791363
--- Comment #13 from Paul Howarth 2012-04-09 12:26:35 EDT
---
Something I missed in the review:
The directory %{perl_vendorlib}/XML/ should be owned by the package, and it
isn't.
Please change in the %%files list:
%{perl_vendorlib}/XML/DTDParser.pm
to:
%{perl_vendorlib}/XML/
(this is one of 119 perl module packages I found with this type of problem)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 803149] Review Request: pyrasite - Code injection and monitoring of running Python processes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=803149 Jan Kratochvil changed: What|Removed |Added Blocks||804694 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810010] Review Request: genders - file based database for cluster managment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810010 --- Comment #3 from David Brown 2012-04-09 11:44:10 EDT --- Okay updated the genders.spec and src.rpm in the links above to include some of the fixes. The command rpmlint shows no errors and only a couple of warnings. I'm not sure how to ignore the autogenerated libfoo.so provides for the python and perl packages. Thanks for checking out the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #33 from Rex Dieter 2012-04-09 10:28:54 EDT --- See http://fedoraproject.org/wiki/PackageMaintainers/Join#Submit_Package_as_Update_in_Bodhi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #32 from Sergio Monteiro Basto 2012-04-09 10:14:52 EDT --- smb4k built also for f17, f16 and f15. Now, shouldn't appears on pending for updates ? https://admin.fedoraproject.org/updates/F17/pending https://admin.fedoraproject.org/updates/F16/pending https://admin.fedoraproject.org/updates/F15/pending Thanks to all, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705108] Review Request: shinken - python monitoring tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705108 --- Comment #15 from David Hannequin 2012-04-09 09:41:08 EDT --- Hi, New spec file and SRPM with fix : Spec URL: http://hvad.fedorapeople.org/fedora/shinken/shinken.spec SRPM URL: http://hvad.fedorapeople.org/fedora/shinken/shinken-1.0.1-1.fc16.src.rpm I update from upstream and fix some issues. Sorry but shinken isn't compatible with python 3. Best regard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810875] New: Review Request: guayadeque - Audio player and organizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: guayadeque - Audio player and organizer
https://bugzilla.redhat.com/show_bug.cgi?id=810875
Summary: Review Request: guayadeque - Audio player and
organizer
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: unspecified
Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: vitop...@gmail.com
QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Descripition : Guayadeque is a music management program designed for all music
enthusiasts. It is Full Featured Linux media player that can easily manage
large collections and uses the Gstreamer media framework. More information?
http://guayadeque.org
Hi , I packaged guayadeque and it works for me .
This is the spec file, I have tried to adhere to Fedora guidelines , I don't
get rpmlint errors.
I post this in case this is useful to someone that want as me guayadeque in
Fedora.
Fedora rocks!
Name: guayadeque
Version: 0.3.5
Release: 1%{?dist}
Summary: A music organizer and player with a lot of features
License: GPLv+3
URL: http://sourceforge.net/projects/guayadeque
Source0: %{name}-%{version}.tar.bz2
BuildRequires: cmake
BuildRequires: wxGTK
BuildRequires: wxGTK-devel
BuildRequires: taglib-devel
BuildRequires: gnutls-devel
BuildRequires: dbus-devel
BuildRequires: gstreamer-devel
BuildRequires: flac-devel
BuildRequires: libgpod-devel
BuildRequires: subversion
BuildRequires: subversion-devel
%description
Guayadeque is a music management program designed for all music enthusiasts. It
is Full Featured Linux media player that can easily manage large collections
and uses the Gstreamer media framework. More information? http://guayadeque.org
%prep
%setup -q
%build
./build
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
%find_lang %{name}
%files -f %{name}.lang
%defattr(-,root,root)
%doc LICENSE README
%{_bindir}/guayadeque
%{_datadir}/guayadeque/equalizers.default.conf
%{_datadir}/guayadeque/guayadeque.default.conf
%{_datadir}/guayadeque/lyrics_sources.xml
%{_datadir}/applications/guayadeque.desktop
%{_datadir}/pixmaps/guayadeque.png
%changelog
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] Review Request: python3-dateutil - Powerful extensions to the standard datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810859 --- Comment #4 from Jon Ciesla 2012-04-09 09:28:42 EDT --- Sounds rational to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] Review Request: python3-dateutil - Powerful extensions to the standard datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810859 --- Comment #3 from Thomas Spura 2012-04-09 09:09:48 EDT --- (In reply to comment #2) > Is there a compelling reason to do this as a > separate SRPM and not simply a subpackage of python-dateutil? On the webpage is mentioned that 2.0 version is for Python >= 3.0: http://labix.org/python-dateutil#head-2f49784d6b27bae60cde1cff6a535663cf87497b Ignoring that, I tried to get it working with python2, but without success... The testsuite fails badly because of many, many unicode vs strings errors and I don't think it makes sense to get it working somehow with python2 because upstream doesn't support it... To redo it, just change "_thread" to "thread" and run the test.py with python2, e.g.: ERROR: testZoneInfoFileStart1 (__main__.TZTest) -- Traceback (most recent call last): File "test.py", line 3888, in testZoneInfoFileStart1 self.assertEqual(datetime(2003, 4, 6, 1, 59, tzinfo=tz).tzname(), "EST") TypeError: tzinfo.tzname() must return None or a string, not 'unicode' -- Ran 478 tests in 0.819s FAILED (errors=456) (In reply to comment #2) > Has there been discussion of this? Not yet, but I hope the reason from above is enough to have a separate package... :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] Review Request: python3-dateutil - Powerful extensions to the standard datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810859 --- Comment #2 from Jon Ciesla 2012-04-09 08:58:53 EDT --- This is the same upstream. Is there a compelling reason to do this as a separate SRPM and not simply a subpackage of python-dateutil? https://fedoraproject.org/wiki/Packaging:Python#Common_SRPM_vs_split_SRPMs Has there been discussion of this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] Review Request: python3-dateutil - Powerful extensions to the standard datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810859 Thomas Spura changed: What|Removed |Added CC||jspal...@gmail.com, ||limburg...@gmail.com Blocks||753210 --- Comment #1 from Thomas Spura 2012-04-09 08:44:59 EDT --- CC'ing maintainers of python-dateutil and using #753210 as python3-matplotlib tracker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] New: Review Request: python3-dateutil - Powerful extensions to the standard datetime module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python3-dateutil - Powerful extensions to the standard datetime module https://bugzilla.redhat.com/show_bug.cgi?id=810859 Summary: Review Request: python3-dateutil - Powerful extensions to the standard datetime module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: toms...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://tomspur.fedorapeople.org/review/python3-dateutil.spec SRPM URL: http://tomspur.fedorapeople.org/review/python3-dateutil-2.0-1.fc16.src.rpm DIFF to python2-dateutil: http://tomspur.fedorapeople.org/review/python3-dateutils-vs-python2-dateutils.patch Description: The dateutil module provides powerful extensions to the standard datetime module available in Python 2.3+. $ rpmlint /home/tom/rpmbuild/SRPMS/python3-dateutil-2.0-1.fc16.src.rpm /home/tom/rpmbuild/RPMS/noarch/python3-dateutil-2.0-1.fc16.noarch.rpm python3-dateutil.src: W: spelling-error Summary(en_US) datetime -> date time, date-time, daytime python3-dateutil.src: W: spelling-error %description -l en_US datetime -> date time, date-time, daytime python3-dateutil.src:16: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 16) python3-dateutil.noarch: W: spelling-error Summary(en_US) datetime -> date time, date-time, daytime python3-dateutil.noarch: W: spelling-error %description -l en_US datetime -> date time, date-time, daytime 2 packages and 0 specfiles checked; 0 errors, 5 warnings. This package is needed for python3-matplotlib. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810028] Review Request: perl-WWW-Shorten - Interface to URL shortening sites
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810028 --- Comment #6 from Jon Ciesla 2012-04-09 08:32:42 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799651] Review Request: smb4k - The SMB/CIFS Share Browser for KDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799651 --- Comment #31 from Jon Ciesla 2012-04-09 08:30:47 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806536] Review Request: ghc-resourcet - Deterministic allocation and freeing of scarce resources
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806536 --- Comment #3 from Jon Ciesla 2012-04-09 08:31:24 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787977] Review Request: ghc-data-reify - converts recursive data structures into graphs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787977 --- Comment #6 from Jon Ciesla 2012-04-09 08:22:33 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787972] Review Request: ghc-dotgen - Simple interface to build .dot graph files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787972 --- Comment #5 from Jon Ciesla 2012-04-09 08:19:50 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810676] Review Request: aws - Ada Web Server (Web framework for Ada)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810676 Björn Persson changed: What|Removed |Added Status|NEW |ASSIGNED CC||bj...@xn--rombobjrn-67a.se AssignedTo|nob...@fedoraproject.org|bj...@xn--rombobjrn-67a.se Flag||fedora-review? --- Comment #2 from Björn Persson 2012-04-09 07:34:52 EDT --- This is what I see at first glance: · The license differs between the main package and the -devel subpackage. Is that really true? If not, please remove the license field from the subpackage. · The -devel subpackage lacks a dependency on fedora-gnat-project-common. · The version field says 2.10.0 but in the changelog it says 2.8.0. · I think the URL field should point to a page that describes AWS, that is http://libre.adacore.com/libre/tools/AWS/ instead of Adacore's front page. · According to the copyright notices in aws.gpr and template_parser.gpr those files were written by Adacore. Is that true? If so, why are they in aws-fedora.tgz and not in aws-gpl-2.10.0-src.tgz? I'll have a closer look later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783825 --- Comment #29 from Brendan Jones 2012-04-09 04:06:18 EDT --- Hi Orcan, I have discussed this with Dave Robillard and some of the other Fedora devs and after a lengthy discussion this was considered the best way to satisfy the intentions/purpose of the library. The suil package was designed not to depend on either toolkit. So if we have a Qt host and a Gtk plugin, then the Qt dependencies are provided by the host and the Gtk dependencies are provided by the plugin. The host cannot know at runtime what toolkit it maybe required to use to instantiate a plugin and shouldn't be expected to require both. The filtered requires ensures that only the toolkit of the host is pulled in. This may be advantageous where it is not desirable to pull in libraries unnecessarily. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810417] Review Request: geome - Obtain your geolocation data from Google using NetworkManager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=810417
Gregor Tätzner changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #10 from Gregor Tätzner 2012-04-09 03:17:26 EDT
---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/greg/projects/Review/810417/geome-1.1.tar.gz :
MD5SUM this package : 9c125ec0a3ca0fc7771103ad0c6cfb69
MD5SUM upstream package : 9c125ec0a3ca0fc7771103ad0c6cfb69
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[!]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
APPROVED
minor issue:
Can you add the -p option to the install command (preserves timestamps)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail be
