[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 Mattia Meneguzzo hal8...@hotmail.it changed: What|Removed |Added Flag|needinfo?(hal8600@hotmail.i | |t) | --- Comment #23 from Mattia Meneguzzo hal8...@hotmail.it 2012-05-04 02:21:18 EDT --- (In reply to comment #22) Mattia, what's your FAS username? My user name on the Fedora Account System is odysseus. Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815521] Review Request: python-django-extra-form-fields - Additional form fields for Django applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=815521
--- Comment #5 from Matthias Runge mru...@matthias-runge.de 2012-05-04
02:53:53 EDT ---
yepp, I got it.
Fact is, BSD license is wrong. I'll contact upstream to correct the license
field on pypi-page: http://pypi.python.org/pypi/django-extra-form-fields/0.0.1
[mrunge@mrungexp django-extra-form-fields-0.0.1]$ licensecheck -r .
./ez_setup.py: *No copyright* UNKNOWN
./django_extra_form_fields/conf.py: *No copyright* UNKNOWN
./django_extra_form_fields/default_settings.py: *No copyright* UNKNOWN
./django_extra_form_fields/fields.py: *No copyright* UNKNOWN
./django_extra_form_fields/__init__.py: *No copyright* UNKNOWN
./setup.py: *No copyright* UNKNOWN
License says: This program is free software: you can redistribute it and/or
modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
COPYING is a copy of GPLv3
Name: python-django-extra-form-fields
Version:0.0.1
-Release:3%{?dist}
+Release:4%{?dist}
Summary:Additional form fields for Django applications
-License:BSD
+License:GPLv3+
URL:http://pypi.python.org/pypi/django-extra-form-fields/0.0.1
Source0:
http://pypi.python.org/packages/source/d/%{pkgname}/%{pkgname}-%{version}.tar.gz
@@ -48,6 +48,9 @@
%changelog
+* Fri May 04 2012 Matthias Runge mru...@matthias-runge.de - 0.0.1-4
+- corrected license field to GPLv3+
+
* Mon Apr 23 2012 Matthias Runge mru...@matthias-runge.de - 0.0.1-3
- package renamed to python-django-extra-form-fields
Updated
SPEC: http://www.matthias-runge.de/fedora/python-django-extra-form-fields.spec
SRPM:
http://www.matthias-runge.de/fedora/python-django-extra-form-fields-0.0.1-4.fc16.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #14 from Jindrich Novy jn...@redhat.com 2012-05-04 03:59:03 EDT --- Koji scratch build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=4052074 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816962] Review Request: fest-assert - FEST Fluent Assertions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816962 Mario Torre neug...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Mario Torre neug...@redhat.com 2012-05-04 04:18:11 EDT --- New Package SCM Request === Package Name: fest-assert Short Description: FEST Fluent Assertions Owners: neugens omajid rkennke jvanalte Branches: f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817436] Review Request: bonesi - The DDoS Botnet Simulator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817436
--- Comment #3 from Mathieu Bridon boche...@fedoraproject.org 2012-05-04
05:06:58 EDT ---
(In reply to comment #2)
- Using macros in the URL is not very handy for copy-and-paste.
I don't want to change the Source0 URL
$ spectool -S bonesi.spec
Source0: https://bonesi.googlecode.com/files/bonesi-0.2.0.tar.gz
- As far as I know is it not needed to mark man pages as %doc.
Right, I keep forgetting about this, thanks.
- Include README and License in %doc
Oops, no idea how I missed that, good catch!
- Consider to add the example file 50k-bots, browserlist.txt, and urllist.txt
Good idea.
Spec URL: http://bochecha.fedorapeople.org/packages/bonesi.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/bonesi-0.2.0-2.fc17.src.rpm
$ rpmlint bonesi*.{spec,rpm}
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817436] Review Request: bonesi - The DDoS Botnet Simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817436 --- Comment #4 from Mathieu Bridon boche...@fedoraproject.org 2012-05-04 05:10:36 EDT --- (In reply to comment #3) (In reply to comment #2) - Using macros in the URL is not very handy for copy-and-paste. I don't want to change the Source0 URL I sent to early, I hadn't finished my sentence... What I meant is: I don't want to change it every time there is an update. Plus, you can use spectool for that: $ spectool -S bonesi.spec Source0: https://bonesi.googlecode.com/files/bonesi-0.2.0.tar.gz Sorry if that sounded harsh, it was only missing a few words. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812059] Review Request: python-tw2-jqplugins-flot - jQuery flot (plotting) for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812059 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||michel+...@sylvestre.me Flag||fedora-review? --- Comment #3 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-04 06:20:13 EDT --- Taking this review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811750] Review Request: python-tw2-jqplugins-gritter - jQuery gritter (growl-like popups) for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811750 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||michel+...@sylvestre.me Flag||fedora-review? --- Comment #3 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-04 06:19:49 EDT --- Taking this review and #812059; could you swap with https://bugzilla.redhat.com/show_bug.cgi?id=787193 ? Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815098] Review Request: maven-processor-plugin - maven-processor-plugin Maven Mojo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815098 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||815101 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815428] Review Request: perl-Module-Manifest-Skip - MANIFEST.SKIP Manangement for Modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815428 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com AssignedTo|nob...@fedoraproject.org|psab...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #15 from Michael Schwendt mschwe...@gmail.com 2012-05-04 06:40:44 EDT --- Then comment 12 and comment 13 hold true. [...] A look at the built rpms also confirms the inconsistencies: $ rpmls -p libdb4-java-4.8.30-1.fc18.x86_64.rpm|grep lib64 -rwxr-xr-x /usr/lib64/libdb_java-4.8.so lrwxrwxrwx /usr/lib64/libdb_java-4.8_g.so lrwxrwxrwx /usr/lib64/libdb_java-4.so lrwxrwxrwx /usr/lib64/libdb_java.so Compared with your 'XXX Nuke...' comment in the spec you here include both the unversioned development-only symlink as well as the major-version-only symlink to the library. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808884] Review Request: perl-Data-Clone - Polymorphic data cloning
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808884 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Stanislav Ochotnicky socho...@redhat.com 2012-05-04 07:19:39 EDT --- All looks good now. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811732] Review Request: python-tw2-jquery - jQuery for ToscaWidgets2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811732
Neil Horman nhor...@redhat.com changed:
What|Removed |Added
Flag||needinfo?(rb...@redhat.com)
--- Comment #10 from Neil Horman nhor...@redhat.com 2012-05-04 07:21:27 EDT
---
I'm referring to this:
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
I was under the impression that part of the requirement was that we create the
locale files so that strings could be translated after packaging
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816488] Review Request: perl-Test-Dir - Some simple tests on directories and folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816488 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Alec Leamas leamas.a...@gmail.com 2012-05-04 07:50:11 EDT --- Thanks for the review. And for the lesson on licensing... New Package SCM Request === Package Name: xlwt Short Description: Spreadsheet python library Owners: leamas Branches: f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808884] Review Request: perl-Data-Clone - Polymorphic data cloning
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808884 --- Comment #1 from Petr Pisar ppi...@redhat.com 2012-05-04 08:05:18 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/Data/Clone.pm. Ok. License verified from lib/Data/Clone.pm. Ok. Description verified from lib/Data/Clone.pm. Ok. Package compiles XS code, the architecture specific BuildArch is Ok. All releases provides perl(Test::More) = 0.88, nonqualified build-require is Ok. All releases provides perl(Test::Release) = 0.03, nonqualified build-require is Ok. FIX: Build-require `perl(inc::Module::Install)' (Makefile.PL:3) instead of `perl(ExtUtils::MakeMaker)'. TODO: Consider removing bundled Perl modules under inc/ and build-requiring appropriate modules like Module::Install::AuthorTests. Otherwise you need explicitly build-require all dependencies of inc/* code. FIX: Build-require modules used by code under inc/ (ExtUtils::Manifest, YAML::Tiny, etc.). I really recommend unbundling inc/*. TODO: Build-require `perl(threads)' for optional tests (t/10_threads.t:4). TODO: Build-require `perl(constant)' which can dual-live in the future (t/10_threads.t:4). All tests pass. Ok. $ rpmlint perl-Data-Clone.spec ../SRPMS/perl-Data-Clone-0.003-1.fc18.src.rpm ../RPMS/x86_64/perl-Data-Clone-* perl-Data-Clone.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/auto/Data/Clone/data_clone.h 3 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm drwxr-xr-x2 rootroot0 May 4 13:51 /usr/lib64/perl5/vendor_perl/Data -rw-r--r--1 rootroot 5187 Jan 15 2011 /usr/lib64/perl5/vendor_perl/Data/Clone.pm drwxr-xr-x2 rootroot0 May 4 13:51 /usr/lib64/perl5/vendor_perl/auto/Data drwxr-xr-x2 rootroot0 May 4 13:51 /usr/lib64/perl5/vendor_perl/auto/Data/Clone -rwxr-xr-x1 rootroot14688 May 4 13:51 /usr/lib64/perl5/vendor_perl/auto/Data/Clone/Clone.so -rw-r--r--1 rootroot 365 Jan 15 2011 /usr/lib64/perl5/vendor_perl/auto/Data/Clone/data_clone.h drwxr-xr-x2 rootroot0 May 4 13:51 /usr/share/doc/perl-Data-Clone-0.003 -rw-r--r--1 rootroot 291 Jan 15 2011 /usr/share/doc/perl-Data-Clone-0.003/Changes -rw-r--r--1 rootroot 505 Jan 15 2011 /usr/share/doc/perl-Data-Clone-0.003/README -rw-r--r--1 rootroot 3680 May 4 13:51 /usr/share/man/man3/Data::Clone.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.11)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl = 0:5.008_001 2 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(parent) 1 perl(strict) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 1 rtld(GNU_HASH) TODO: Do not explicitly run-require auto-discovered perl(Exporter). $ rpm -q --provides -p ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(Data::Clone) = 0.003 1 perl-Data-Clone = 0.003-1.fc18 1 perl-Data-Clone(x86-64) = 0.003-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052488). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816488] Review Request: perl-Test-Dir - Some simple tests on directories and folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816488 --- Comment #2 from Petr Pisar ppi...@redhat.com 2012-05-04 08:09:03 EDT --- New Package SCM Request === Package Name: perl-Test-Dir Short Description: Some simple tests on directories and folders Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816488] Review Request: perl-Test-Dir - Some simple tests on directories and folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816488 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810937] Review Request: perl-multidimensional - Disables multidimensional array emulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810937 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810619] Review Request: hop - A web development kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810619 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:22:13 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816488] Review Request: perl-Test-Dir - Some simple tests on directories and folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816488 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:24:11 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813594] Review Request: pwauth - External plugin for mod_authnz_external authenticator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813594 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:23:44 EDT --- Please include an SCM request when setting the SCM flag. Thanks! http://fedoraproject.org/wiki/Package_SCM_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818589] Review Request: fest-swing-junit - FEST Swing JUnit support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818589 Omair Majid oma...@redhat.com changed: What|Removed |Added CC||oma...@redhat.com AssignedTo|nob...@fedoraproject.org|oma...@redhat.com Flag||fedora-review? --- Comment #1 from Omair Majid oma...@redhat.com 2012-05-04 08:22:17 EDT --- I will take this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816962] Review Request: fest-assert - FEST Fluent Assertions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816962 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:24:59 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Comment #16 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:28:28 EDT --- Good catches, Michael, this will teach me to work on reviews while extremely busy. Temporarily un-approved. The Obsoletes/Provides most definitely need fixing, and I share Michael's curiosity about the unversioned links, etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 --- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:29:00 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818547] Review Request: python-versiontools - Smart replacement for plain tuple used in __version__
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818547 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:29:24 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810937] Review Request: perl-multidimensional - Disables multidimensional array emulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810937 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar ppi...@redhat.com 2012-05-04 08:35:34 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/multidimensional.pm. Ok. License verified from lib/multidimensional.pm and LICENSE. Ok. Description verified from lib/multidimensional.pm. Ok. Package use XS code, architecture specific BuildArch is Ok. TODO: If you patched out Lexical::SealRequireHints because of new enough perl, you could remove `perl = 0:5.008' build-require. All releases provides perl(Test::More) = 0.88, nonqualified dependency is Ok. All releases provides perl(Test::Pod::Coverage) = 1.08, nonqualified dependency is Ok. All releases provides perl(Test::Pod) = 1.41, nonqualified dependency is Ok. All tests pass. Ok. $ rpmlint perl-multidimensional.spec ../SRPMS/perl-multidimensional-0.010-1.fc18.src.rpm ../RPMS/x86_64/perl-multidimensional-* perl-multidimensional.src: W: spelling-error %description -l en_US sigil - vigil perl-multidimensional.src: W: spelling-error %description -l en_US lexically - lexical, exotically, allergically perl-multidimensional.x86_64: W: spelling-error %description -l en_US sigil - vigil perl-multidimensional.x86_64: W: spelling-error %description -l en_US lexically - lexical, exotically, allergically 3 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm drwxr-xr-x2 rootroot0 May 4 14:27 /usr/lib64/perl5/vendor_perl/auto/multidimensional -rwxr-xr-x1 rootroot 6104 May 4 14:27 /usr/lib64/perl5/vendor_perl/auto/multidimensional/multidimensional.so -rw-r--r--1 rootroot 1861 May 4 14:27 /usr/lib64/perl5/vendor_perl/multidimensional.pm drwxr-xr-x2 rootroot0 May 4 14:27 /usr/share/doc/perl-multidimensional-0.010 -rw-r--r--1 rootroot 1243 Jan 27 13:34 /usr/share/doc/perl-multidimensional-0.010/Changes -rw-r--r--1 rootroot18407 Jan 27 13:34 /usr/share/doc/perl-multidimensional-0.010/LICENSE -rw-r--r--1 rootroot 323 Jan 27 13:34 /usr/share/doc/perl-multidimensional-0.010/README -rw-r--r--1 rootroot 2296 May 4 14:27 /usr/share/man/man3/multidimensional.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(B::Hooks::OP::Check) = 0.19 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(multidimensional) = 0.010 1 perl-multidimensional = 0.010-1.fc18 1 perl-multidimensional(x86-64) = 0.010-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052566). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 --- Comment #24 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-04 08:41:26 EDT --- OK, you're sponsored. Feel free to request a repository for your package now -- and don't hesitate to email if you have any packaging question. Cheers (and thanks for packaging this, my Eclipse, Emacs, and Qt programs finally fit into my desktop) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810939] Review Request: perl-bareword-filehandles - Disables bareword filehandles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810939 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #17 from Jindrich Novy jn...@redhat.com 2012-05-04 08:43:41 EDT --- Packages are now updated. The nonversioned and major versioned libraries are now gone. Jon, Obsoletes is intentionally broken so that libdb users will need to decide whether they need libdb4 or libdb. db4 and compat-db will be gone so no need to provide/obsolete them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818547] Review Request: python-versiontools - Smart replacement for plain tuple used in __version__
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818547 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2012-05-04 08:49:40 EDT --- python-versiontools-1.9.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-versiontools-1.9.1-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817436] Review Request: bonesi - The DDoS Botnet Simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817436 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Fabian Affolter m...@fabian-affolter.ch 2012-05-04 08:51:20 EDT --- I'm totally fine with Source0 and macros there. I was taking about the URL to the projects website. I see no further blocker, package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818547] Review Request: python-versiontools - Smart replacement for plain tuple used in __version__
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818547 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816488] Review Request: perl-Test-Dir - Some simple tests on directories and folders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816488 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Test-Dir-1.014-1.fc18 Resolution||RAWHIDE Last Closed||2012-05-04 08:52:05 --- Comment #4 from Petr Pisar ppi...@redhat.com 2012-05-04 08:52:05 EDT --- Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817022] Review Request: perl-Test-Apocalypse - Apocalypse's favorite tests bundled into a simple interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817022 Bug 817022 depends on bug 816488, which changed state. Bug 816488 Summary: Review Request: perl-Test-Dir - Some simple tests on directories and folders https://bugzilla.redhat.com/show_bug.cgi?id=816488 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 --- Comment #25 from Mattia Meneguzzo hal8...@hotmail.it 2012-05-04 08:55:17 EDT --- (In reply to comment #24) OK, you're sponsored. Feel free to request a repository for your package now -- and don't hesitate to email if you have any packaging question. Thank you very much! Cheers (and thanks for packaging this, my Eclipse, Emacs, and Qt programs finally fit into my desktop) You're welcome. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #18 from Jon Ciesla limburg...@gmail.com 2012-05-04 08:59:16 EDT --- If this is replacing something, it needs to Obsolete/Provide properly. https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818943] New: Review Request: jtds - SQL Server and Sybase JDBC driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jtds - SQL Server and Sybase JDBC driver https://bugzilla.redhat.com/show_bug.cgi?id=818943 Summary: Review Request: jtds - SQL Server and Sybase JDBC driver Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: spec info here SRPM URL: srpm info here Description: TDS is an open source 100% pure Java (type 4) JDBC 3.0 driver for Microsoft SQL Server (6.5, 7, 2000,2005, and 2008) and Sybase (10, 11, 12, 15). jTDS is based on FreeTDS and is currently the fastest production-ready JDBC driver for SQL Server and Sybase. jTDS is 100% JDBC 3.0 compatible, supporting forward-only and scrollable/updateable ResultSets, concurrent (completely independent) Statements and implementing all the DatabaseMetaData and ResultSetMetaData methods. tested on http://koji.fedoraproject.org/koji/taskinfo?taskID=4052676 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #19 from Jindrich Novy jn...@redhat.com 2012-05-04 09:11:06 EDT --- These policies do not fit to the purpose of this new package. Many libdb dependent packages have dependencies to db4 (and db4-devel) just because the package just needs libdb and package maintainers do not know there exist libdb package which ships non-obsolete version. Note it is properly communicated on fedora-devel. The plan is to remove compat-db and db4 and introduce libdb4 package which will break deps of all db4* packages so that maintainers are to decide whether they need libdb ver. 4 or 5 and rebuild their package against one of these. If libdb4 correctly obsoletes db4 and compat-db then nothing happens and we end up with dozens of packages dependent on obsolete libdb for no reason shipping libdb4 forever. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #20 from Jon Ciesla limburg...@gmail.com 2012-05-04 09:15:54 EDT --- If we want everyone to move to libdb and get off db4, why ship libdb4 at all? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818943] Review Request: jtds - SQL Server and Sybase JDBC driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818943 --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2012-05-04 09:19:54 EDT --- No links to the spec and srpm! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #21 from Jindrich Novy jn...@redhat.com 2012-05-04 09:25:34 EDT --- The reason is that there still might be good reasons for keeping libdb4 in cases such as openldap, build problems against libdb5, compatibility, etc. It should be the case only of minority of libdb dependent packages but it is still worth doing. This step of introduction of libdb4 is necessary because if I just remove compat-db and db4 I would likely make some apps unrebuildable and need to introduce libdb4 anyway. Also, some third parties (apps not present in Fedora) might still require libdb4. If it turns out libdb4 is not needed I will happily dead-package it as soon as it proves true. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #22 from Michael Schwendt mschwe...@gmail.com 2012-05-04 09:30:58 EDT --- Not true. You could simply follow the guidelines nevertheless, | If a package supersedes/replaces an existing package without being | a compatible enough replacement as defined in above, use only the | Obsoletes from above. and _either_ add these Obsoletes (_only_ Obsoletes, no Provides!) tags to the new libdb4 packages _or_ your libdb packages. Doing the latter would have the benefit of nuking installed db4* packages, if they are not needed anymore in dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810939] Review Request: perl-bareword-filehandles - Disables bareword filehandles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810939 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar ppi...@redhat.com 2012-05-04 09:32:07 EDT --- Source file is original. Ok. URL and Source0 are usable Ok. Summary verified from lib/bareword/filehandles.pm. Ok. License verified from lib/bareword/filehandles.pm and LICENSE. Ok. Description verified from lib/bareword/filehandles.pm. Ok. Package uses XS code, architecture specific BuilArch is Ok. All releases provide perl(Test::Pod::Coverage) = 1.08, nonqualified dependency is Ok. All releases provide perl(Test::Pod) = 1.41, nonqualified dependency is Ok. TODO: If you have patched Lexical::SealRequireHints dependency out, then you could remove `perl = 0:5.008001' build-require. All tests pass. Ok. $ rpmlint perl-bareword-filehandles.spec ../SRPMS/perl-bareword-filehandles-0.003-1.fc18.src.rpm ../RPMS/x86_64/perl-bareword-filehandles-* perl-bareword-filehandles.src: W: spelling-error %description -l en_US lexically - lexical, exotically, allergically perl-bareword-filehandles.src: W: spelling-error %description -l en_US builtin - built in, built-in, built perl-bareword-filehandles.x86_64: W: spelling-error %description -l en_US lexically - lexical, exotically, allergically perl-bareword-filehandles.x86_64: W: spelling-error %description -l en_US builtin - built in, built-in, built perl-bareword-filehandles.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-bareword-filehandles-0.003/LICENSE 3 packages and 1 specfiles checked; 1 errors, 4 warnings. TODO: Correct `builtin' spelling. TODO: Report to upstream out-dated FSF address $ rpm -q -lv -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm drwxr-xr-x2 rootroot 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword drwxr-xr-x2 rootroot0 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword/filehandles -rwxr-xr-x1 rootroot10216 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword/filehandles/filehandles.so drwxr-xr-x2 rootroot0 May 4 15:22 /usr/lib64/perl5/vendor_perl/bareword -rw-r--r--1 rootroot 1815 May 4 15:22 /usr/lib64/perl5/vendor_perl/bareword/filehandles.pm drwxr-xr-x2 rootroot0 May 4 15:22 /usr/share/doc/perl-bareword-filehandles-0.003 -rw-r--r--1 rootroot 356 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/Changes -rw-r--r--1 rootroot18291 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/LICENSE -rw-r--r--1 rootroot 316 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/README -rw-r--r--1 rootroot 2245 May 4 15:22 /usr/share/man/man3/bareword::filehandles.3pm.gz File layout is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(B::Hooks::OP::Check) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(bareword::filehandles) = 0.003 1 perl-bareword-filehandles = 0.003-1.fc18 1 perl-bareword-filehandles(x86-64) = 0.003-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052725). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #23 from Michael Schwendt mschwe...@gmail.com 2012-05-04 09:32:31 EDT --- Dependencies, which still want/need to build with db4 _explicitly_, will continue to work, and may continue to build after updating their BuildRequires from db4-* to libdb4-* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816967] Review Request: fest-swing - FEST Swing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816967 --- Comment #6 from Mario Torre neug...@redhat.com 2012-05-04 09:35:01 EDT --- I updated the stuff: http://neugens.fedorapeople.org/fest-swing/fest-swing.spec http://neugens.fedorapeople.org/fest-swing/fest-swing-1.2.1-5.fc16.src.rpm I could not find a better way to pack the sources, upstream doesn't provide them. I could just as well store them on my own server, or build from the maven central stored jar (but this means I have to duplicate the build code and directory layout for something that is not upstream anyway, so I don't think makes any sense). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816927] Review Request: fest-reflect - FEST Reflection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816927 Mario Torre neug...@redhat.com changed: What|Removed |Added AssignedTo|jon.vanal...@redhat.com |oma...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #24 from Michael Schwendt mschwe...@gmail.com 2012-05-04 09:35:22 EDT --- The plan is to remove compat-db and db4 and introduce libdb4 package which will break deps of all db4* packages That won't work out completely, btw because so far, your libdb4* builds don't break deps, at least not the automatic deps on SONAMEs. Just any explicit [Build]Requires. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #25 from Jon Ciesla limburg...@gmail.com 2012-05-04 09:39:45 EDT --- I understand the impetus, but instead of breaking lots of things, would it not be friendlier to do a repoquery, file some bugs, and do some test builds against libdb5? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818964] New: Review Request: StaxMate - StaxMate
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: StaxMate - StaxMate https://bugzilla.redhat.com/show_bug.cgi?id=818964 Summary: Review Request: StaxMate - StaxMate Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://gil.fedorapeople.org/staxmate.spec SRPM URL: http://gil.fedorapeople.org/staxmate-2.0.1-1.fc16.src.rpm Description: StaxMate is a light-weight framework that adds convenience to streaming XML-processing without significant additional overhead. It builds on top of a Stax (JSR-173) compliant XML processors such as Woodstox or Sjsxp (default Stax implementation of JDK 1.6) and offers two basic abstractions: Cursors, which build on XMLStreamReaders and Output objects, which build on XMLStreamWriters. tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4052749 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816927] Review Request: fest-reflect - FEST Reflection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816927 Mario Torre neug...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Mario Torre neug...@redhat.com 2012-05-04 09:42:15 EDT --- I added a dependency on jpackage-utils: http://neugens.fedorapeople.org/fest-reflect/fest-reflect.spec http://neugens.fedorapeople.org/fest-reflect/fest-reflect-1.3-6.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #27 from Jindrich Novy jn...@redhat.com 2012-05-04 09:45:19 EDT --- (In reply to comment #25) I understand the impetus, but instead of breaking lots of things, would it not be friendlier to do a repoquery, file some bugs, and do some test builds against libdb5? Nope. The problem is that Fedora is also a bit weird from the Berkeley DB package naming. jbj named the packages very inconveniently. No other distro has db4 or compat-db. Most of them just have libdb or libdbX. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811739] Review Request: python-tw2-jqplugins-ui - jQuery UI for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811739 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-05-04 09:45:30 EDT --- Waiting on -jquery to settle down a bit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818943] Review Request: jtds - SQL Server and Sybase JDBC driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818943 --- Comment #2 from gil cattaneo punto...@libero.it 2012-05-04 09:44:02 EDT --- Spec URL: http://gil.fedorapeople.org/jtds.spec SRPM URL: http://gil.fedorapeople.org/jtds-1.2.5-1.fc16.src.rpm sorry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #26 from Jindrich Novy jn...@redhat.com 2012-05-04 09:42:43 EDT --- (In reply to comment #24) The plan is to remove compat-db and db4 and introduce libdb4 package which will break deps of all db4* packages That won't work out completely, btw because so far, your libdb4* builds don't break deps, at least not the automatic deps on SONAMEs. Just any explicit [Build]Requires. ;) True but what it's important here is that package maintainer will not be able to rebuild his package just with BR: db4-devel so he will need to adjust it manually, i.e. select either libdb or libdb4. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818589] Review Request: fest-swing-junit - FEST Swing JUnit support
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818589
--- Comment #2 from Omair Majid oma...@redhat.com 2012-05-04 09:53:43 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
fest-swing-junit.src: W: invalid-url Source0: fest-swing-junit-1.2.1.tar.bz2
Okay. Upstream does not publish a source-only tarball.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[!] Package meets the Packaging Guidelines[2].
Could you add some more details to, and clarify, the description (especially as
contained in the spec file itself). A very brief explanation of the word FEST
would be nice too.
[!] Package successfully compiles and builds into binary rpms.
Some dependencies are not yet included in fedora.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type:
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[-] Sources used to build the package matches the upstream source, as provided
in the spec URL.
Upstream does not publish source tarballs.
[!] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
Missing BuildRequires: java-devel
Since we are not running tests, perhaps we can leave the fest-test dependency
out? (I am assuming that since it's only listed as BuildRequires that it's
needed for a test).
Just a nit: you might want to use junit rather than junit4 as a dependency -
just to make things clearer. The junit4 package was removed in F17 and junit
provides junit4.
[!] Package must own all directories that it creates or must require other
packages for directories it uses.
Missing Requires: jpackage-utils (needed for /usr/share/java/)
[x] Package does not contain duplicates in %files.
Duplicate license file is fine.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[!] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
There is an unnecessary rm -rf at the end of %install
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[-] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[!] Packages have proper BuildRequires/Requires on jpackage-utils
Missing Requires on jpackage-utils.
[x] Javadoc subpackages have Require: jpackage-utils
[-] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[!] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
Tests are being skipped without any comment. I guess it's because of test
dependencies that can not be packaged due to licensing reasons?
[-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[-] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
Exact dep on other fest-* packages is okay.
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[!] Reviewer should test that the package builds in mock.
Can't
[Bug 812132] Review Request: python-lvm - Python module to use LVM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812132 --- Comment #5 from David Cantrell dcantr...@redhat.com 2012-05-04 09:59:43 EDT --- Correct, pyparted exposes the libparted API to Python programs. libparted just deals with creating partitions on physical devices. Functionality beyond that, for example, things that build on top of LVM physical volumes, are out of scope for libparted. Are pyparted and python-lvm complimentary, yes. I'll try to work in a review today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812132] Review Request: python-lvm - Python module to use LVM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812132 David Cantrell dcantr...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|dcantr...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816927] Review Request: fest-reflect - FEST Reflection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816927 Omair Majid oma...@redhat.com changed: What|Removed |Added AssignedTo|oma...@redhat.com |jon.vanal...@redhat.com --- Comment #8 from Omair Majid oma...@redhat.com 2012-05-04 10:05:49 EDT --- Assigning this back to Jon, who has started the official review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810619] Review Request: hop - A web development kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810619 --- Comment #10 from Jerry James loganje...@gmail.com 2012-05-04 10:07:42 EDT --- (In reply to comment #8) Thanks. I'm requesting the f17 branch only, as scheme2js is still working in f16, and I'm assuming you don't want to push bigloo 3.8 there. Yes, that's right. I should have created the buildroot override for you. Sorry about that. It's a good thing you can take care of that yourself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799521] Review Request: azove - Another Zero-One Vertex Enumeration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799521 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Jerry James loganje...@gmail.com 2012-05-04 10:16:31 EDT --- Michael, are you having some kind of problem with this review? Is there something I can do to help? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818991] New: Review Request: evolution-tray - Tray plugin for evolution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: evolution-tray - Tray plugin for evolution https://bugzilla.redhat.com/show_bug.cgi?id=818991 Summary: Review Request: evolution-tray - Tray plugin for evolution Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jonas.rebm...@googlemail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://jor.netne.net/files/evolution-tray.spec SRPM URL: http://jor.netne.net/files/evolution-tray-0.0.8-1.fc16.src.rpm Description: This plugin puts evolution in tray (notification area). While in tray evolution in minimized and it's windows skip the pager. You can restore evolution on any workspace. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810619] Review Request: hop - A web development kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810619 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-05-04 10:23:39 EDT --- hop-2.3.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/hop-2.3.0-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810619] Review Request: hop - A web development kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810619 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818589] Review Request: fest-swing-junit - FEST Swing JUnit support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818589 --- Comment #3 from Roman Kennke rken...@redhat.com 2012-05-04 10:23:54 EDT --- Thanks for review. I addressed all the mentioned issues: Spec URL: http://rkennke.fedorapeople.org/fest-swing-junit/2/fest-swing-junit.spec SRPM URL: http://rkennke.fedorapeople.org/fest-swing-junit/2/fest-swing-junit-1.2.1-2.fc16.src.rpm Regarding issue #2, we will have to wait until fest-swing is in, the rest should be in Fedora already. Ok now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816699] Review Request: rubygem-redcarpet - A fast, safe and extensible Markdown to (X)HTML parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816699 Matt Hicks mhi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816699] Review Request: rubygem-redcarpet - A fast, safe and extensible Markdown to (X)HTML parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816699 --- Comment #3 from Matt Hicks mhi...@redhat.com 2012-05-04 10:30:48 EDT --- New Package SCM Request === Package Name: rubygem-redcarpet Short Description: RedCarpet is a fast, safe and extensible Markdown to (X)HTML parser. Owners: matthicksj Branches: f16 f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #28 from Michael Schwendt mschwe...@gmail.com 2012-05-04 10:37:42 EDT --- he will need to adjust it manually, i.e. select either libdb or libdb4. Which is okay. And the lazy packager will simply s/db4/libdb4/ in the BuildRequires and stick to db4 instead of evaluating whether v5 could be used instead. ;) Anyway: You must add the Obsoletes (for all [sub]packages) to either libdb4* or libdb*. Upgrade path sanity. Else you introduce implicit conflicts with old and already installed db4* packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Ralph Bean rb...@redhat.com 2012-05-04 11:04:57 EDT --- New Package SCM Request === Package Name: python-tw2-sqla Short Description: SQLAlchemy database layer for ToscaWidgets2 Owners: ralph Branches: f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819008] New: Review Request: waterbearlang-waterbear - Waterbear is a toolkit for making programming more accessible and fun.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: waterbearlang-waterbear - Waterbear is a toolkit for making programming more accessible and fun. https://bugzilla.redhat.com/show_bug.cgi?id=819008 Summary: Review Request: waterbearlang-waterbear - Waterbear is a toolkit for making programming more accessible and fun. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: agre...@learn.senecac.on.ca QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://newzealand.proximity.on.ca/waterbear/waterbearlang-waterbear.spec SRPM URL: http://newzealand.proximity.on.ca/waterbear/waterbearlang-waterbear-1.0-5.fc16.src.rpm Description: Waterbear is a toolkit for making programming more accessible and fun. Having a visual language means you don't have to focus on learning a syntax to start programming. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816699] Review Request: rubygem-redcarpet - A fast, safe and extensible Markdown to (X)HTML parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816699 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-05-04 11:03:09 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811769] Review Request: python-tw2-dynforms - Dynamic forms for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811769 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Ralph Bean rb...@redhat.com 2012-05-04 11:04:18 EDT --- New Package SCM Request === Package Name: python-tw2-dynforms Short Description: Dynamic forms for ToscaWidgets2 Owners: ralph Branches: f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810619] Review Request: hop - A web development kit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810619 --- Comment #12 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-04 11:03:37 EDT --- (In reply to comment #10) (In reply to comment #8) Thanks. I'm requesting the f17 branch only, as scheme2js is still working in f16, and I'm assuming you don't want to push bigloo 3.8 there. Yes, that's right. I should have created the buildroot override for you. Sorry about that. It's a good thing you can take care of that yourself. No problem -- if you had created it before the review is done it might have expired (and Bodhi is a bit fussy when that happens - you need to find the original override and renew it, you can't create a new one!) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817270] Review Request: python-spiffgtkwidgets - Collection of useful Gtk widgets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817270 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||rb...@redhat.com AssignedTo|nob...@fedoraproject.org|rb...@redhat.com Flag||fedora-review? --- Comment #2 from Ralph Bean rb...@redhat.com 2012-05-04 11:03:01 EDT --- I'll take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819012] New: Review Request: sonar-update-center - Sonar :: Update Center
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sonar-update-center - Sonar :: Update Center https://bugzilla.redhat.com/show_bug.cgi?id=819012 Summary: Review Request: sonar-update-center - Sonar :: Update Center Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://gil.fedorapeople.org/sonar-update-center.spec SRPM URL: http://gil.fedorapeople.org/sonar-update-center-1.2-1.fc16.src.rpm Description: Update center for Sonar. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817981] Review Request: ratpoints - Find rational points on hyperelliptic curves
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817981
Jerry James loganje...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||loganje...@gmail.com
AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com
Flag||fedora-review?
--- Comment #1 from Jerry James loganje...@gmail.com 2012-05-04 11:10:16 EDT
---
I'll take this review. Here are a some initial comments in advance of a full
review.
You don't need BuildRequires: gzip. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2. Also, is
help2man actually used in the build? It doesn't seem to be, in which case you
can also drop BuildRequires: help2man.
Use %global instead of %define: see
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define.
Unless you plan to build this package for EPEL 5, you can remove the defattr()
statements from the %files sections. Those statements became optional with the
release of rpm 4.4.
Looking at the source code shows that USE_SSE really means that SSE2
instructions can be emitted into the binary. This is fine for x86_64, but is
not fine for %{ix86}. Some CPUs in that class do not support SSE2. You have 2
options for that platform: (1) don't build with SSE2 support at all, or (2)
build 2 shared libraries, one without SSE2 support in %{_libdir}, and one with
SSE2 support in %{_libdir}/sse2. On CPUs with SSE2 support, ld.so will pick up
the library in %{_libdir}/sse2 at runtime. You can see examples of doing this
in the atlas, gmp, gmp-ecm, and m4ri packages, among others.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811732] Review Request: python-tw2-jquery - jQuery for ToscaWidgets2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811732
Ralph Bean rb...@redhat.com changed:
What|Removed |Added
Flag|needinfo?(rb...@redhat.com) |
--- Comment #11 from Ralph Bean rb...@redhat.com 2012-05-04 11:15:54 EDT ---
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
I interpret the above section to mean that %find_lang is only necessary if the
upstream package already contains locale files. The packager must handle
locale files with %find_lang, not by declaring %{_datadir}/locale/* in the
%files section.
python-tw2-jquery doesn't have any locale files to begin with. To generate
them, the upstream package would have to be internationalized, which would be a
major effort.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819012] Review Request: sonar-update-center - Sonar :: Update Center
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819012 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends on||818989 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811750] Review Request: python-tw2-jqplugins-gritter - jQuery gritter (growl-like popups) for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811750 --- Comment #4 from Ralph Bean rb...@redhat.com 2012-05-04 11:16:25 EDT --- Sure thing! I've taken it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787193] Review Request: vala0.14 - vala compiler, API level 0.14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787193 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||rb...@redhat.com AssignedTo|nob...@fedoraproject.org|rb...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #29 from Jindrich Novy jn...@redhat.com 2012-05-04 11:17:58 EDT --- OK, thanks for for your opinions guys. Maybe I was too harsh to see libdb4 in rawhide ASAP ;-) I will add the Obsoletes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811732] Review Request: python-tw2-jquery - jQuery for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811732 Neil Horman nhor...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+, ||needinfo?(rb...@redhat.com) --- Comment #12 from Neil Horman nhor...@redhat.com 2012-05-04 11:19:20 EDT --- Ok, I can get behind that, especially since it seems to be the set precedent (I've sampled other python packages, and they seem to agree with your interpretation). So ACK from me on this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816012] Review Request: python-virtualenvcontext - Switch virtualenvs with a python context manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816012 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added CC||leamas.a...@gmail.com AssignedTo|nob...@fedoraproject.org|leamas.a...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-05-04 11:30:13 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811769] Review Request: python-tw2-dynforms - Dynamic forms for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811769 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-05-04 11:29:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819015] New: Review Request: picocontainer2 - Java library implementing the Dependency Injection pattern
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: picocontainer2 - Java library implementing the Dependency Injection pattern https://bugzilla.redhat.com/show_bug.cgi?id=819015 Summary: Review Request: picocontainer2 - Java library implementing the Dependency Injection pattern Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://gil.fedorapeople.org/picocontainer2.spec SRPM URL: http://gil.fedorapeople.org/picocontainer2-2.14.1-1.fc16.src.rpm Description: PicoContainer is a highly embeddable full service Inversion of Control (IoC) container for components honour the Dependency Injection pattern. It can be used as a lightweight alternative to Sun's J2EE patterns for web applications or general solutions. Despite it being very compact in size (the core is ~128K and it has no mandatory dependencies outside the JDK), PicoContainer supports different dependency injection types (Constructor, Setter, Annotated Field and Method) and offers multiple lifecycle and monitoring strategies. tested on http://koji.fedoraproject.org/koji/taskinfo?taskID=4053270 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816014] Review Request: python-tgscheduler - Turbogears2 Scheduler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816014 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-05-04 11:35:29 EDT --- python-tgscheduler-1.6.3-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-tgscheduler-1.6.3-4.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816014] Review Request: python-tgscheduler - Turbogears2 Scheduler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816014 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mgold...@redhat.com AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819021] New: Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR) https://bugzilla.redhat.com/show_bug.cgi?id=819021 Summary: Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR) Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://gil.fedorapeople.org/jboss-jaxr-1.0-api.spec SRPM URL: http://gil.fedorapeople.org/jboss-jaxr-1.0-api-1.0.2-1.fc16.src.rpm Description: JSR 93: Java(TM) API for XML Registries 1.0 (JAXR). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] New: Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API https://bugzilla.redhat.com/show_bug.cgi?id=819020 Summary: Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://gil.fedorapeople.org/jboss-j2eemgmt-1.1-api.spec SRPM URL: http://gil.fedorapeople.org/jboss-j2eemgmt-1.1-api-1.0.1-1.fc16.src.rpm Description: JSR-77: Java (TM) EE Management 1.1 API -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773470] Review Request: muffin - Window and compositing manager based on Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773470 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE Last Closed||2012-05-04 11:41:51 --- Comment #11 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-04 11:41:51 EDT --- Leigh, for your next package, please make your initial update reference the review request, so the request gets closed automatically once the package hits stable. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] New: Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: shrinkwrap - A simple mechanism to assemble Java archives https://bugzilla.redhat.com/show_bug.cgi?id=819022 Summary: Review Request: shrinkwrap - A simple mechanism to assemble Java archives Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: punto...@libero.it QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://gil.fedorapeople.org/shrinkwrap.spec SRPM URL: http://gil.fedorapeople.org/shrinkwrap-1.1.0-0.1.alpha.1.fc16.src.rpm Description: Shrinkwrap provides a simple mechanism to assemble archives like JARs, WARs, and EARs with a friendly, fluent API. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815720] Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815720 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mgold...@redhat.com AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mgold...@redhat.com AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 790560] Review Request: vinci - Algorithms for volume computation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=790560
Ralph Bean rb...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #6 from Ralph Bean rb...@redhat.com 2012-05-04 11:46:23 EDT ---
PACKAGE IS APPROVED
I only ask that you notify upstream that their FSF address is out of date:
http://lists.fedoraproject.org/pipermail/legal/2011-August/001701.html
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint vinci-debuginfo-1.0.5-2.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint vinci-1.0.5-2.fc18.src.rpm
vinci.src: W: spelling-error %description -l en_US polytope - polythene
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint vinci-1.0.5-2.fc18.i686.rpm
vinci.i686: W: spelling-error %description -l en_US polytope - polythene
vinci.i686: E: incorrect-fsf-address /usr/share/doc/vinci-1.0.5/COPYING
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/threebean/790560/vinci-1.0.5.tar.gz :
MD5SUM this package : 685eb2ddd2999d5439030f5e03653e05
MD5SUM upstream package : 685eb2ddd2999d5439030f5e03653e05
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Dist tag is present.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package
[Bug 816014] Review Request: python-tgscheduler - Turbogears2 Scheduler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816014 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-05-04 11:47:27 EDT --- python-tgscheduler-1.6.3-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tgscheduler-1.6.3-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||drupal6-views_bonus-1.1-4.e ||l6 Resolution||ERRATA Last Closed||2012-05-04 11:58:26 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2012-05-04 11:58:26 EDT --- drupal6-views_bonus-1.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
