[Bug 818256] Review Request: mingw-spice-gtk - client libraries for SPICE desktop servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818256 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added CC||fedora-mingw@lists.fedorapr ||oject.org AssignedTo|fedora-mingw@lists.fedorapr |nob...@fedoraproject.org |oject.org | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817271] Review Request:openerp-server -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817271 --- Comment #4 from Alec Leamas leamas.a...@gmail.com 2012-05-08 02:09:13 EDT --- Thanks for input. However, note the 'NotReady' whiteboard status: this is a work in progress not ready for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819670] Review Request: mingw-llvm - MinGW LLVM libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819670 --- Comment #1 from Eric Smith e...@brouhaha.com 2012-05-08 03:15:49 EDT --- Updated to fix optimization flags. Not sure why the debuginfo isn't picking up the sources; could use some help with that. Spec URL: http://fedorapeople.org/~brouhaha/mingw-llvm/mingw-llvm.spec SRPM URL: http://fedorapeople.org/~brouhaha/mingw-llvm/mingw-llvm-3.0-2.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819670] Review Request: mingw-llvm - MinGW LLVM libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819670 --- Comment #2 from Eric Smith e...@brouhaha.com 2012-05-08 03:19:14 EDT --- Here's the Koji scratch build for F17 for 3.0-2: http://koji.fedoraproject.org/koji/taskinfo?taskID=4061825 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 --- Comment #1 from Marek Goldmann mgold...@redhat.com 2012-05-08 03:19:44 EDT --- Any chance you could downgrade to latest stable 1.0.0? https://github.com/shrinkwrap/shrinkwrap/tree/1.0.0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 Mattia Meneguzzo mattia.meneguzzo+fed...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 --- Comment #36 from Mattia Meneguzzo mattia.meneguzzo+fed...@gmail.com 2012-05-08 03:27:00 EDT --- OK, I've been able to change my login email address and to set the fedora-cvs flag. For the new package SCM request, go to comment #26. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815720] Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815720 gil cattaneo punto...@libero.it changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from gil cattaneo punto...@libero.it 2012-05-08 03:30:46 EDT --- New Package SCM Request === Package Name: jboss-jaxr-1.0-api Short Description: Java(TM) API for XML Registries 1.0 (JAXR) Owners: gil Branches: f16 f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819456
--- Comment #1 from Marek Goldmann mgold...@redhat.com 2012-05-08 03:37:12
EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
$ rpmlint SPECS/jbossws-common.spec
SPECS/jbossws-common.spec: W: invalid-url Source0:
jbossws-common-2.0.4.GA.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint SRPMS/jbossws-common-2.0.4-1.fc17.src.rpm
jbossws-common.src: I: enchant-dictionary-not-found en_US
jbossws-common.src: W: invalid-url URL: http://www.jboss.org/jbossws HTTP Error
403: Forbidden
jbossws-common.src: W: invalid-url Source0: jbossws-common-2.0.4.GA.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: LGPLv2+
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: 058147a20936d938c36bd9d5c63e66d5
MD5SUM upstream package: 1c9221c3dde542c9d3fd6df88f6327a5
SVN export.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[x] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[!] Reviewer should test that the package builds in mock.
Tested on:
https://koji.fedoraproject.org/koji/taskinfo?taskID=4062320
=== Issues ===
1. Package fails to build, please add maven-dependency-plugin to BR.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819591] Package Review: cvsps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819591 --- Comment #1 from Ville Skyttä ville.sky...@iki.fi 2012-05-08 03:49:39 EDT --- (In reply to comment #0) NO package meets versioning guidelines. Pre-version should be marked as b.1 instead of b1. This is incorrect, b1 is fine here as it's preceded by 0.x. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 --- Comment #2 from gil cattaneo punto...@libero.it 2012-05-08 03:59:14 EDT --- Spec URL: http://gil.fedorapeople.org/jboss-j2eemgmt-1.1-api.spec SRPM URL: http://gil.fedorapeople.org/jboss-j2eemgmt-1.1-api-1.0.1-2.fc16.src.rpm - add maven and maven-enforcer-plugin to BR -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783064] Review Request: python-omniORB - A robust high performance CORBA ORB for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783064 --- Comment #7 from Jaromír Talíř jaromir.ta...@seznam.cz 2012-05-08 03:59:36 EDT --- Is there any progress in having python-omniorb in Fedora together with the rest of omniorb packages? Any help needed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 --- Comment #2 from Krzysztof Daniel kdan...@redhat.com 2012-05-08 04:35:01 EDT --- Spec URL: http://kdaniel.fedorapeople.org/jacoco/v2/jacoco.spec SRPM URL: http://kdaniel.fedorapeople.org/jacoco/v2/jacoco-0.5.7-0.2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 --- Comment #2 from gil cattaneo punto...@libero.it 2012-05-08 04:39:31 EDT --- Spec URL: http://gil.fedorapeople.org/shrinkwrap.spec SRPM URL: http://gil.fedorapeople.org/shrinkwrap-1.0.0-1.fc16.src.rpm - revert to 1.0.0 (latest stable) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Marek Goldmann mgold...@redhat.com 2012-05-08 04:41:13 EDT --- *** APPROVED *** Note for the future: please make sure you don't overwrite the files you're posting in the review and you post link to the right files (link to spec file is wrong). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817268] Review Request: python-faces - Python project management tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817268 --- Comment #8 from Alec Leamas leamas.a...@gmail.com 2012-05-08 04:44:27 EDT --- Robin: did you forget to set the fedora-review flag to '?'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 gil cattaneo punto...@libero.it changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from gil cattaneo punto...@libero.it 2012-05-08 04:51:05 EDT --- New Package SCM Request === Package Name: jboss-j2eemgmt-1.1-api Short Description: Java EE Management 1.1 API Owners: gil Branches: f16 f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819022
Marek Goldmann mgold...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Marek Goldmann mgold...@redhat.com 2012-05-08 05:10:27
EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
$ rpmlint SPECS/shrinkwrap.spec
SPECS/shrinkwrap.spec: W: invalid-url Source0: shrinkwrap-1.0.0.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint SRPMS/shrinkwrap-1.0.0-1.fc17.src.rpm
shrinkwrap.src: I: enchant-dictionary-not-found en_US
shrinkwrap.src: W: invalid-url URL: http://www.jboss.org/shrinkwrap/ HTTP Error
403: Forbidden
shrinkwrap.src: W: invalid-url Source0: shrinkwrap-1.0.0.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint RPMS/noarch/shrinkwrap-1.0.0-1.fc17.noarch.rpm
shrinkwrap.noarch: I: enchant-dictionary-not-found en_US
shrinkwrap.noarch: W: invalid-url URL: http://www.jboss.org/shrinkwrap/ HTTP
Error 403: Forbidden
shrinkwrap.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: ASL 2.0
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: 12a861a091ebedfeb830ece9b4e516de
MD5SUM upstream package: 12a861a091ebedfeb830ece9b4e516de
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[x] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
Tested on:
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 --- Comment #3 from Krzysztof Daniel kdan...@redhat.com 2012-05-08 05:10:36 EDT --- Spec URL: http://kdaniel.fedorapeople.org/jacoco/v3/jacoco.spec SRPM URL: http://kdaniel.fedorapeople.org/jacoco/v3/jacoco-0.5.7-0.2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 --- Comment #4 from Krzysztof Daniel kdan...@redhat.com 2012-05-08 05:18:09 EDT --- SRPM URL: http://kdaniel.fedorapeople.org/jacoco/v3/jacoco-0.5.7-0.3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816926] Review Request: fest-util - FEST Util
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816926 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-05-08 05:23:32 EDT --- fest-util-1.2.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fest-util-1.2.0-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816926] Review Request: fest-util - FEST Util
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816926 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED Bug 816926 depends on bug 816264, which changed state. Bug 816264 Summary: Review Request: fest-common - Fixtures for Easy Software Testing https://bugzilla.redhat.com/show_bug.cgi?id=816264 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819528
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2012-05-08
05:45:52 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[-]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
jacoco-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java docs,
Java-docs, Avocados
Fine.
jacoco.noarch: W: hidden-file-or-dir /usr/share/doc/jacoco-0.5.7/doc/.resources
jacoco.noarch: W: hidden-file-or-dir /usr/share/doc/jacoco-0.5.7/doc/.resources
jacoco.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/jacoco-0.5.7/doc/.resources/doc.css
jacoco-maven-plugin.noarch: W: summary-ended-with-dot C A Jacoco plugin for
maven.
Fix these.
jacoco-maven-plugin.noarch: W: no-documentation
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
Package has no sources or they are generated by developer
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0:
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 --- Comment #2 from Patryk Obara dreamer@gmail.com 2012-05-08 05:54:20 EDT --- maven-dependency-plugin added, nothing else changed: Spec URL: http://dreamertan.fedorapeople.org/srpm/jbossws-common/1/jbossws-common.spec SRPM URL: http://dreamertan.fedorapeople.org/srpm/jbossws-common/1/jbossws-common-2.0.4-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 Patryk Obara dreamer@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|dreamer@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 Patryk Obara dreamer@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dreamer@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 gil cattaneo punto...@libero.it changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from gil cattaneo punto...@libero.it 2012-05-08 06:13:40 EDT --- New Package SCM Request === Package Name: shrinkwrap Short Description: A simple mechanism to assemble Java archives Owners: gil Branches: f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806680
--- Comment #9 from Marek Goldmann mgold...@redhat.com 2012-05-08 06:14:38
EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
$ rpmlint SPECS/bouncycastle-pg.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/bouncycastle-pg-1.46-5.fc17.src.rpm
bouncycastle-pg.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint RPMS/noarch/bouncycastle-pg-1.46-5.fc17.noarch.rpm
bouncycastle-pg.noarch: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type: MIT
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: f7189c81b3a0492acc5d21e5d342dba9
MD5SUM upstream package: f7189c81b3a0492acc5d21e5d342dba9
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[!] Package uses %global not %define
Use %global.
[-] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
1.47 is available, but I assume we need to stick with the version availabe in
Fedora.
[x] Reviewer should test that the package builds in mock.
Tested on:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4062541
=== Issues ===
1. Use %global instead %define
=== Final Notes ===
1. We're only interested at this point in F17+, so it's safe to remove the
checks for fedora version. Please consider removing those checks.
2. Consider removing Requires requirement from javadoc subpackage:
Requires: %{name} = %{version}-%{release}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 --- Comment #6 from Krzysztof Daniel kdan...@redhat.com 2012-05-08 06:22:12 EDT --- Spec URL: http://kdaniel.fedorapeople.org/jacoco/v4/jacoco.spec SRPM URL: http://kdaniel.fedorapeople.org/jacoco/v4/jacoco-0.5.7-0.4.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 --- Comment #7 from Krzysztof Daniel kdan...@redhat.com 2012-05-08 06:23:16 EDT --- jacoco.noarch: W: hidden-file-or-dir /usr/share/doc/jacoco-0.5.7/doc/.resources is how upstream packages doc, I do not want change that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Marek Goldmann mgold...@redhat.com 2012-05-08 06:24:06 EDT --- *** APPROVED *** Small side note: in the future bump the release with every change and add an entry to changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 --- Comment #4 from Patryk Obara pob...@redhat.com 2012-05-08 06:34:55 EDT --- New Package SCM Request === Package Name: jbossws-common Short Description: Common classes for JBoss Webservices Owners: dreamertan Branches: f17 InitialCC: goldmann -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 --- Comment #10 from gil cattaneo punto...@libero.it 2012-05-08 06:34:37 EDT --- Spec URL: http://gil.fedorapeople.org/bouncycastle-pg.spec SRPM URL: http://gil.fedorapeople.org/bouncycastle-pg-1.46-6.fc16.src.rpm - used %%global instead %%define - removed the checks for fedora version - removed requirement from javadoc subpackage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812059] Review Request: python-tw2-jqplugins-flot - jQuery flot (plotting) for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812059 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 06:40:41 EDT --- Everything looks good -- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 --- Comment #37 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 06:39:19 EDT --- The SCM request is processed automatically, I believe -- could you just comment again with the request? I'm not sure it works if the request is in a preceding comment. Thanks :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811750] Review Request: python-tw2-jqplugins-gritter - jQuery gritter (growl-like popups) for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811750 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 06:41:38 EDT --- Looks good -- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 Patryk Obara pob...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 --- Comment #38 from Mattia Meneguzzo mattia.meneguzzo+fed...@gmail.com 2012-05-08 06:50:30 EDT --- New Package SCM Request === Package Name: zukitwo Short Description: The Zukitwo themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4, created by lassekongo83. Owners: odysseus Branches: f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Marek Goldmann mgold...@redhat.com 2012-05-08 06:55:25 EDT --- *** APPROVED *** A note: in the future please don't overwrite files after fixing review issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Alexander Kurtakov akurt...@redhat.com 2012-05-08 06:56:59 EDT --- (In reply to comment #7) jacoco.noarch: W: hidden-file-or-dir /usr/share/doc/jacoco-0.5.7/doc/.resources is how upstream packages doc, I do not want change that. Fine by me. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Krzysztof Daniel kdan...@redhat.com 2012-05-08 07:01:01 EDT --- New Package SCM Request === Package Name: jacoco Short Description:Java Code Coverage for Eclipse Owners: kdaniel, akurtakov Branches: f17 InitialCC: kdaniel, akurtakov -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805487] Review Request: logback - A Java logging library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805487 Bug 805487 depends on bug 806669, which changed state. Bug 806669 Summary: Review Request: janino - An embedded Java compiler https://bugzilla.redhat.com/show_bug.cgi?id=806669 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #12 from Marek Goldmann mgold...@redhat.com 2012-05-08 06:57:33 EDT --- Hi Mary, any chance to kick a build for F17/Rawhide? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 gil cattaneo punto...@libero.it changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from gil cattaneo punto...@libero.it 2012-05-08 06:59:49 EDT --- New Package SCM Request === Package Name: bouncycastle-pg Short Description: Bouncy Castle OpenPGP API Owners: gil Branches: f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810937] Review Request: perl-multidimensional - Disables multidimensional array emulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810937 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810939] Review Request: perl-bareword-filehandles - Disables bareword filehandles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810939 --- Comment #2 from Iain Arnell iarn...@gmail.com 2012-05-08 07:10:45 EDT --- New Package SCM Request === Package Name: perl-bareword-filehandles Short Description: Disables bareword filehandles Owners: iarnell Branches: f16 f17 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810939] Review Request: perl-bareword-filehandles - Disables bareword filehandles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810939 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810937] Review Request: perl-multidimensional - Disables multidimensional array emulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810937 --- Comment #2 from Iain Arnell iarn...@gmail.com 2012-05-08 07:10:35 EDT --- New Package SCM Request === Package Name: perl-multidimensional Short Description: Disables multidimensional array emulation Owners: iarnell Branches: f16 f17 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] New: Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: luarocks - A deployment and management system for Lua modules https://bugzilla.redhat.com/show_bug.cgi?id=819844 Summary: Review Request: luarocks - A deployment and management system for Lua modules Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: michel+...@sylvestre.me QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://salimma.fedorapeople.org/specs/funpl/luarocks.spec SRPM URL: http://salimma.fedorapeople.org/specs/funpl/luarocks-2.0.8-1.fc17.src.rpm Description: LuaRocks allows you to install Lua modules as self-contained packages called rocks, which also contain version dependency information. This information is used both during installation, so that when one rock is requested all rocks it depends on are installed as well, and at run time, so that when a module is required, the correct version is loaded. LuaRocks supports both local and remote repositories, and multiple local rocks trees. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #1 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 07:32:54 EDT --- note: there's a previous, apparently abandoned review at https://bugzilla.redhat.com/show_bug.cgi?id=577514 -- will check there if the packager want to collaborate, and if not, close it as a duplicate -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 Mattia Meneguzzo mattia.meneguzzo+fed...@gmail.com changed: What|Removed |Added Flag|fedora-cvs? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 Mattia Meneguzzo mattia.meneguzzo+fed...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817278] Review Request: jdiff - An HTML Report of API Differences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817278 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||817560 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817278] Review Request: jdiff - An HTML Report of API Differences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817278 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mgold...@redhat.com AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815720] Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815720 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:36:59 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:33:18 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810939] Review Request: perl-bareword-filehandles - Disables bareword filehandles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810939 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:35:29 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810937] Review Request: perl-multidimensional - Disables multidimensional array emulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810937 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:35:09 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752169 --- Comment #39 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:32:57 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:41:48 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:40:41 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:41:07 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 --- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:47:24 EDT --- dreamertan, your FAS email and BZ email do not match, please correct and re-set the fedora-cvs flag. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:44:29 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com --- Comment #14 from Jon Ciesla limburg...@gmail.com 2012-05-08 08:45:34 EDT --- No worries, I removed xlwt from git, retired it in pkgdb, and created python-xlwt. In the future, though, stick to the template for SCM requests, the one in #12 confused our tool a bit. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819678] Review Request: cmake28 - A package of CMake 2.8.x for EL6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819678 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||hobbes1...@gmail.com AssignedTo|nob...@fedoraproject.org|hobbes1...@gmail.com Flag||fedora-review? --- Comment #2 from Richard Shaw hobbes1...@gmail.com 2012-05-08 09:13:53 EDT --- I'll take this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806680] Review Request: bouncycastle-pg - Bouncy Castle OpenPGP API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806680 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814965
Patryk Obara pob...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Patryk Obara pob...@redhat.com 2012-05-08 09:30:33 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
$ rpmlint SPECS/hibernate-jpamodel.spec
(none): E: no installed packages by name hibernate-jpamodel.spec
0 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SRPMS/hibernate-jpamodelgen-1.2.0-1.fc16.src.rpm
hibernate-jpamodelgen.src: W: spelling-error %description -l en_US metamodel -
meta model, meta-model, metamorphose
hibernate-jpamodelgen.src: W: invalid-url URL:
http://www.hibernate.org/subprojects/jpamodelgen.html HTTP Error 403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 2 warning
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines[2].
[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot definition is not present
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x] License field in the package spec file matches the actual license.
License type:
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: ab24abf614ee36a55027d25669aec94b
MD5SUM upstream package: ab24abf614ee36a55027d25669aec94b
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates or must require other
packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x] Permissions on files are set properly.
[x] Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc
subpackage
[x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[-] If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be
removed prior to building
[x] All filenames in rpm packages must be valid UTF-8.
[x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x] If package contains pom.xml files install it (including depmaps) even when
building with ant
[x] pom files has correct add_maven_depmap
=== Maven ===
[x] Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[x] If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-] If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x] Package DOES NOT use %update_maven_depmap in %post/%postun
[x] Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Avoid having BuildRequires on exact NVR unless necessary
[x] Package has BuildArch: noarch (if possible)
[x] Latest version is packaged.
[x] Reviewer should test that the package builds in mock.
Tested on:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4062793
=== Final Notes ===
1. In %build:
[WARNING] File encoding has not been set, using platform encoding
ANSI_X3.4-1968, i.e. build is platform dependent!
You can avoid these warnings by passing -Dproject.build.sourceEncoding=UTF-8
[Bug 819678] Review Request: cmake28 - A package of CMake 2.8.x for EL6
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819678
--- Comment #3 from Richard Shaw hobbes1...@gmail.com 2012-05-08 09:40:23 EDT
---
Quick spec review:
1. I see some things that are no longer needed like BuildRoot:, rm -rf
$RPM_BUILD_ROOT in %install, %clean, and %defattr in %files but I'm assuming
that these are in the Fedora cmake package so I guess it's not worth deviating
from their package.
2. Should the Require for the -gui package be arch dependent? i.e.:
Requires: %{name} = %{version}-%{release}
to
Requires: %{name}${?_isa} = %{version}-%{release}
There's a lot of rpmlint output but I'm assuming it's largely the same as the
regular cmake package in Fedora. The only two things I think should be fixed
are:
cmake28.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 24)
cmake28.x86_64: E: non-executable-script
/usr/share/cmake28/Modules/SquishRunTestCase.sh 0644L /bin/sh
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819456] Review Request: jbossws-common - Common classes for JBoss Webservices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819456 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-05-08 09:43:52 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815720] Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815720 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819020] Review Request: jboss-j2eemgmt-1.1-api - Java EE Management 1.1 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819020 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-05-08 09:56:30 EDT --- jboss-j2eemgmt-1.1-api-1.0.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jboss-j2eemgmt-1.1-api-1.0.1-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815720] Review Request: jboss-jaxr-1.0-api - Java(TM) API for XML Registries 1.0 (JAXR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815720 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2012-05-08 09:53:45 EDT --- jboss-jaxr-1.0-api-1.0.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jboss-jaxr-1.0-api-1.0.2-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 gil cattaneo punto...@libero.it changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 --- Comment #2 from gil cattaneo punto...@libero.it 2012-05-08 10:03:15 EDT --- New Package SCM Request === Package Name: hibernate-jpamodelgen Short Description: Hibernate JPA 2 Metamodel Generator Owners: gil Branches: f16 f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817271] Review Request:openerp-server -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817271 Bug 817271 depends on bug 818264, which changed state. Bug 818264 Summary: Review Request: xlwt - Spreadsheet python library https://bugzilla.redhat.com/show_bug.cgi?id=818264 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added CC||jspal...@gmail.com --- Comment #16 from Alec Leamas leamas.a...@gmail.com 2012-05-08 10:06:08 EDT --- *** Bug 613766 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added CC||tho...@duboucher.eu --- Comment #2 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 10:05:14 EDT --- *** Bug 577514 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818264] Review Request: xlwt - Spreadsheet python library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818264 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-05-08 10:05:04 --- Comment #15 from Alec Leamas leamas.a...@gmail.com 2012-05-08 10:05:04 EDT --- In the future, let's assume I'll never, ever submit such a request as comment #12 again :( - and thus stick to the template. Build OK for rawhide, F16, F17. I don't intend to build for F15. Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 --- Comment #3 from gil cattaneo punto...@libero.it 2012-05-08 10:03:35 EDT --- New Package SCM Request === Package Name: hibernate-jpamodelgen Short Description: Hibernate JPA 2 Metamodel Generator Owners: gil Branches: f17 InitialCC: java-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 --- Comment #4 from Jon Ciesla limburg...@gmail.com 2012-05-08 10:11:10 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819893] Review Request: mingw-gsl - MinGW Windows port of the GNU Scientific Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819893 nucleo alekc...@googlemail.com changed: What|Removed |Added CC||fedora-mingw@lists.fedorapr ||oject.org Alias||mingw-gsl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819893] New: Review Request: mingw-gsl - MinGW Windows port of the GNU Scientific Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mingw-gsl - MinGW Windows port of the GNU Scientific Library https://bugzilla.redhat.com/show_bug.cgi?id=819893 Summary: Review Request: mingw-gsl - MinGW Windows port of the GNU Scientific Library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: alekc...@googlemail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: --- Spec URL: http://nucleo.fedorapeople.org/pkg-reviews/mingw-gsl/mingw-gsl.spec SRPM URL: http://nucleo.fedorapeople.org/pkg-reviews/mingw-gsl/mingw-gsl-1.15-1.fc17.src.rpm Description: The GNU Scientific Library (GSL) is a collection of routines for numerical analysis, written in C. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819893] Review Request: mingw-gsl - MinGW Windows port of the GNU Scientific Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819893 --- Comment #1 from nucleo alekc...@googlemail.com 2012-05-08 10:14:18 EDT --- Package builds in mock. See http://nucleo.fedorapeople.org/pkg-reviews/mingw-gsl/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819022] Review Request: shrinkwrap - A simple mechanism to assemble Java archives
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819022 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-05-08 10:29:10 EDT --- shrinkwrap-1.0.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/shrinkwrap-1.0.0-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805487] Review Request: logback - A Java logging library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805487 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2012-05-08 10:41:09 EDT --- logback-1.0.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/logback-1.0.1-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805487] Review Request: logback - A Java logging library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805487 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662269] Review Request: dpic - A compiler for the pic language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662269 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |ASSIGNED CC|fedora-package-review@redha |package-review@lists.fedora |t.com |project.org AssignedTo|nob...@fedoraproject.org|ti...@math.uh.edu Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666190] Reviews Request: libofetion - Library files of Openfetion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666190 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added CC|fedora-package-review@redha |package-review@lists.fedora |t.com |project.org Status Whiteboard||AwaitingSubmitter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814965] Review Request: hibernate-jpamodelgen - Hibernate JPA 2 Metamodel Generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814965 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2012-05-08 11:04:13 EDT --- hibernate-jpamodelgen-1.2.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/hibernate-jpamodelgen-1.2.0-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 790805] Review Request: lcg-util - Command line tools for wlcg data management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790805 Ricardo Rocha rocha.po...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 790805] Review Request: lcg-util - Command line tools for wlcg data management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790805 Ricardo Rocha rocha.po...@gmail.com changed: What|Removed |Added CC||rocha.po...@gmail.com AssignedTo|nob...@fedoraproject.org|rocha.po...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 638459] Review Request: mosquitto - An Open Source MQTT v3 Broker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638459 --- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2012-05-08 12:50:30 EDT --- Anyone still want this to go in? The needed fixes are pretty minor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819528] Review Request: jacoco - Java Code Coverage for Eclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819528 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-05-08 12:52:15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819338] Review Request: linux-user-chroot - Helper program for calling chroot(2) as non-root
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819338 Colin Walters walt...@redhat.com changed: What|Removed |Added Blocks||819951 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819951] Review Request: ostree - Linux-based operating system develop/build/deploy tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819951 Colin Walters walt...@redhat.com changed: What|Removed |Added Depends on||819338 --- Comment #1 from Colin Walters walt...@redhat.com 2012-05-08 13:01:02 EDT --- Depends on linux-user-chroot in bug 819338 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
