[Bug 816071] Review Request: f3 - Utility to test for fake flash drives and cards
https://bugzilla.redhat.com/show_bug.cgi?id=816071 Volker Fröhlich changed: What|Removed |Added Flags||needinfo?(e...@brouhaha.com ||) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822881] Review Request: perl-Task-Kensho-Exceptions - A Glimpse at an Enlightened Perl (Exceptions)
https://bugzilla.redhat.com/show_bug.cgi?id=822881 Jitka Plesnikova changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jitka Plesnikova --- New Package SCM Request === Package Name: perl-Task-Kensho-Exceptions Short Description: A Glimpse at an Enlightened Perl (Exceptions) Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824057] Review Request: fcitx-hangul - Hangul Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824057 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824061] Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824061 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|ke...@scrye.com |panem...@gmail.com Flags||fedora-review? --- Comment #4 from Parag AN(पराग) --- Kevin, I will help the submitter with this package review like I did for his other fcitx-* package reviews. Taking this for review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784156] Review Request: uwsgi - Fast, self-healing, application container server
https://bugzilla.redhat.com/show_bug.cgi?id=784156 --- Comment #32 from Mitch Davis --- I fetched the .src.rpm and it rebuilt under F16 very easily. There's no systemd/initd support. I have been working on that for myself. I gave up on systemd because I couldn't get it to work. Initd is close to working in emperor mode. Anyone like work work on this with me? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824218] New: Review Request: polly - twitter client
https://bugzilla.redhat.com/show_bug.cgi?id=824218 Bug ID: 824218 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: polly - twitter client Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: aal...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://alvesadrian.fedorapeople.org/polly.spec SRPM URL: http://alvesadrian.fedorapeople.org/polly-0.93.4-1.fc16.src.rpm Description: Polly is a Linux Twitter client designed for managing multiple columns of multiple accounts, purposefully keeping them separated instead of merged. Fedora Account System Username: alvesadrian -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784156] Review Request: uwsgi - Fast, self-healing, application container server
https://bugzilla.redhat.com/show_bug.cgi?id=784156 --- Comment #31 from Jorge A Gallegos --- This was intended to go with f17, however there is a test koji build for f16 I did before submitting it for f17. http://koji.fedoraproject.org/koji/buildinfo?buildID=301059 You can also just rebuild the .src.rpm, since I did all the testing in a f16 box -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #28 from Athmane Madjoudj --- New upstream release (7.3): SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.3-9.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4095451 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821296] Review Request: drpython - python IDE
https://bugzilla.redhat.com/show_bug.cgi?id=821296
--- Comment #13 from Adrian Alves ---
(In reply to comment #12)
> (In reply to comment #11)
>
> > > do you use vim ?
> > > http://vim.wikia.com/wiki/Converting_tabs_to_spaces
> > >
> > > :set expandtab (this is default code style now)
> > > :set tabstop=4 (also my default)
> > > :retab (and all tabs fixed)
>
> not fixed ,
>
> but rpm -ql drpython
> /%_iconsdir/drpython.png
> /%_iconsdir/hicolor/16x16/apps/drpython.png
> /%_iconsdir/hicolor/32x32/apps/drpython.png
> /%_iconsdir/hicolor/48x48/apps/drpython.png
> /%_liconsdir/drpython.png
> /%_miconsdir/drpython.png
>
> cd /etc/rpm/
> grep iconsdir *
>
> rpm -qf macros.jpackage
> jpackage-utils-1.7.5-15.fc16.x86_64
>
> or you put jpackage-utils-1.7.5-15.fc16.x86_64 in BuildRequires or change
> %_iconsdir %{_datadir}/icons
> %_miconsdir %{_datadir}/icons/mini
> %_liconsdir %{_datadir}/icons/large
New release with ur suggestions:
Spec URL: http://alvesadrian.fedorapeople.org/drpython.spec
SRPM URL: http://alvesadrian.fedorapeople.org/drpython-3.11.1-4.fc16.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.redhat.com/show_bug.cgi?id=818401
--- Comment #12 from pcpa ---
I addressed the fedora-review issues, but the unversioned .so
in %{_libdir}/0ad. If this really needs to be rpmlint silent,
I can work on making a fake -devel package and patch the
package to generate a versioned .so and link to it.
Note that this would not the only package that has "modules" or
libraries in %{_libdir}/*/lib*.so
Actually, I already reported a related issue about rpath to
upstream, to avoid needing special cases :-) at
http://trac.wildfiregames.com/ticket/1421
Updated package:
Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-r11863-3.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815624] Review Request: xedit - Simple text editor for X
https://bugzilla.redhat.com/show_bug.cgi?id=815624 --- Comment #12 from pcpa --- (In reply to comment #11) > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > Note: defattr() present in %files section. This is OK if packaging > for EPEL5. Otherwise not needed > > If you're building also for EPEL-5 please add %buildroot, %clean section and > remove file as the beginning of the %install section; otherwise please > remove %defattr in the %files section. I removed the defattr as it is redundant. > [!]: MUST If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %doc. > > The "COPYING" file is not included in the generated package. Added it to the package as well as other documentation files. > [!]: MUST License field in the package spec file matches the actual license. > > The "COPYING" file contains multiple licenses, are you sure a simple "MIT" > license is enough? The licenses are MIT or BSD-style without clauses. I also added GPLv2+ because of the int64 patch actually adapts code from libgcc. > [!]: SHOULD %check is present and all tests pass. > > A "make check" seems to be implemented in the makefile. It is a fallback that does nothing, but for the sake of review I added it :-) > [!]: SHOULD Packages should try to preserve timestamps of original installed > files. > > You can use this in the %install section: > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Added it. > [!]: SHOULD Latest version is packaged. > > I see version 1.2.0 in the xorg repository. Sorry for that, I had basically just copied the Mandriva spec and made some minor adjustments to it. > rpmlint output is ok: > $ rpmlint *rpm > 3 packages and 0 specfiles checked; 0 errors, 0 warnings. > > > Please correct the above and you're good to go! Thanks. I will probably need to wait a bit until a problem in libXaw is corrected, otherwise, xedit will crash most times, well any time some code path involving selections is exercised. I made a RFE about it at https://bugzilla.redhat.com/show_bug.cgi?id=824198 and rebuilt Xaw locally, as I use xedit for pretty much any text editing :-) New package Spec URL: http://fedorapeople.org/~pcpa/xedit.spec SRPM URL: http://fedorapeople.org/~pcpa/xedit-1.2.0-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #5 from Athmane Madjoudj --- Thank you, Kevin. (In reply to comment #4) > > Issues: > > 1. Not a blocker, but might consider shipping the xfce-notify-4.0/ theme too? > Also, lightdm is under review, so might be ready to ship it's theme? > I've included Xfce notify theme, I can add lightdm theme as after it gets approved but I think we'll loose fedora branding (background). > 2. If I use the method listed in the spec to get the source, I get: > shimmerproject-Greybird-v0.8.2-0-g10555c8.tar.gz > but you have > shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz > (they appear identical, perhaps your versioning is off in the spec?) > Fixed, upstream tagged 10555c8 commit as 0.8.2 (3 hours ago) https://github.com/shimmerproject/Greybird/tags Spec URL: http://athmane.fedorapeople.org/pkgs/greybird.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/greybird-0.8.2-3.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4095296 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #4 from Kevin Fenzi --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License GPLv2+ or CC-BY-SA OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Not a blocker, but might consider shipping the xfce-notify-4.0/ theme too? Also, lightdm is under review, so might be ready to ship it's theme? 2. If I use the method listed in the spec to get the source, I get: shimmerproject-Greybird-v0.8.2-0-g10555c8.tar.gz but you have shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz (they appear identical, perhaps your versioning is off in the spec?) 3. rpmlint says: greybird.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, animistic greybird.src: W: spelling-error %description -l en_US metacity -> meta city, meta-city, mendacity greybird.src: W: spelling-error %description -l en_US grey -> Grey, gray, trey greybird.src: W: spelling-error %description -l en_US ish -> is, sh, dish greybird.src: W: invalid-url Source0: shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz 5 packages and 0 specfiles checked; 0 errors, 5 warnings. All can be ignored. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819480] Review Request: limesurvey - a web-based survey application
https://bugzilla.redhat.com/show_bug.cgi?id=819480 --- Comment #14 from Kevin Fenzi --- Making some progress for sure here. ;) A few issues still however: 1) The limesurvey.conf for apache needs adjusting for the new /var/www/limesurvey area. It's still pointing to /usr/share/ and not working. For that matter, perhaps we could put all but the 3 directories that need to be writable back in /usr/share? or does that not work? 2) The link under /var/www/limesurvey/application/third_party/ for the php-gettext isn't working (because of the move to /var/www/limesurvey/) Now needs to be: 'ln -s ../../../../../usr/share/php/gettext/ ./php-gettext' 3) After fixing the above 2 items, the installer still seems to complain that 3 directories are "Found & Unwritable": /application/config /upload /templates So, perhaps it's looking for those in the wrong place? We need to get past that error to continue in the install. ;( -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822896] Review Request: pari-elldata - PARI/GP Computer Algebra System elliptic curves
https://bugzilla.redhat.com/show_bug.cgi?id=822896 --- Comment #9 from pcpa --- (In reply to comment #8) > > Do you mean these packages will be build requires of pari now? I > > see they could be useful in a very complete %check. > > Yes, that's the intention - see > https://bugzilla.redhat.com/show_bug.cgi?id=821191#c10 > > > I think the conflict does not matter much, as pari-gp is a pari > > subpackage. > > Don't know what you mean by that. I was wondering whether it was pari-gp > that used the data packages, or the underlying library "pari" - the conflict > should refer to the part of pari that actually uses the data. pari-gp should require the matching pari version. The code to handle it is actually in pari library, but the most common way to access it is from the gp command line. > > About data reuse, actually, sagemath ships elldata in a different > > format (not sure if complete and optimized for size, but a lot smaller), > > as well as it also creates a cremona_mini.db sqlite3 db during build. > > But that's derived from this package though, isn't it? Well, in sagemath it is maintained by the data author, but contents should be static, only how it is presented changes. In the case of pari-elldata, it is in a format that pari understands. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073
--- Comment #9 from Rex Dieter ---
ah, in that case,
find_lang %{name} --all-name --with-kde
to be on the safe side. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821296] Review Request: drpython - python IDE
https://bugzilla.redhat.com/show_bug.cgi?id=821296
--- Comment #12 from Sergio Monteiro Basto ---
(In reply to comment #11)
> > do you use vim ?
> > http://vim.wikia.com/wiki/Converting_tabs_to_spaces
> >
> > :set expandtab (this is default code style now)
> > :set tabstop=4 (also my default)
> > :retab (and all tabs fixed)
not fixed ,
but rpm -ql drpython
/%_iconsdir/drpython.png
/%_iconsdir/hicolor/16x16/apps/drpython.png
/%_iconsdir/hicolor/32x32/apps/drpython.png
/%_iconsdir/hicolor/48x48/apps/drpython.png
/%_liconsdir/drpython.png
/%_miconsdir/drpython.png
cd /etc/rpm/
grep iconsdir *
rpm -qf macros.jpackage
jpackage-utils-1.7.5-15.fc16.x86_64
or you put jpackage-utils-1.7.5-15.fc16.x86_64 in BuildRequires or change
%_iconsdir %{_datadir}/icons
%_miconsdir %{_datadir}/icons/mini
%_liconsdir %{_datadir}/icons/large
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799597] Review Request: php-pecl-xhprof - A Hierarchical Profiler for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=799597 --- Comment #12 from Remi Collet --- Thanks for the information. Done : http://pkgs.fedoraproject.org/gitweb/?p=php-pecl-xhprof.git;a=commitdiff;h=3003533307dc4b1290ba18038ca025416a92f417 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073
--- Comment #8 from Kevin Kofler ---
%find_lang %{name} is not going to work because %{name} uses a '-' rather than
an '_'. You'll have to use %find_lang kcm_fcitx. (Or maybe the package should
be called kcm_fcitx? But the tarball doesn't match that. We have this mess
about kcm-* vs. kcm_* because of Debian's restrictive package name policies
which ban underscores.)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822896] Review Request: pari-elldata - PARI/GP Computer Algebra System elliptic curves
https://bugzilla.redhat.com/show_bug.cgi?id=822896 --- Comment #8 from Paul Howarth --- (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > - Shipping the *.asc sig seems pretty meaningless to me. > > > > I just see it being used as an extra check that the tarball hasn't changed, > > (if we keep the signature in git) given that upstream's releases aren't > > versioned. > I guess you are aware, Fedora's git is automatically adding m5sums to > "sources"? True, but I guess the signature is a bit more obvious. > This would apply if you intend to push the tarball to git's lookaside cache. > > However, this would raise the next point, I don't know the answer to: Does > Fedora's git lookaside cache allow unversioned tarballs, rsp. can the > lookaside cache handle this? Yes: the URL to a tarball in the lookaside cache is: http://pkgs.fedoraproject.org/repo/pkgs So tarballs with the same name for the same package can co-exist as long as their md5sums are different, which is a pretty safe bet. (In reply to comment #7) > (In reply to comment #5) > > > > Only issue I see now is that it should have a "Requires: pari-gp" > > > for proper resolution of dependencies. > > > > Can't do that as it would lead to a circular build dependency for pari > > itself, and it's also conceivable that other software could use the same > > data without requiring pari-gp. I did add a "Conflicts: pari-gp < 2.2.11" as > > that's the oldest version that can use this data, though perhaps that should > > be "pari" rather than "pari-gp"? > > Do you mean these packages will be build requires of pari now? I > see they could be useful in a very complete %check. Yes, that's the intention - see https://bugzilla.redhat.com/show_bug.cgi?id=821191#c10 > I think the conflict does not matter much, as pari-gp is a pari > subpackage. Don't know what you mean by that. I was wondering whether it was pari-gp that used the data packages, or the underlying library "pari" - the conflict should refer to the part of pari that actually uses the data. > About data reuse, actually, sagemath ships elldata in a different > format (not sure if complete and optimized for size, but a lot smaller), > as well as it also creates a cremona_mini.db sqlite3 db during build. But that's derived from this package though, isn't it? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073
--- Comment #7 from Rex Dieter ---
Several suggestions:
1. replace
cat << EOF > %{name}.lang
%lang(zh) /usr/share/locale/zh_TW/LC_MESSAGES/kcm_fcitx.mo
%lang(zh) /usr/share/locale/zh_CN/LC_MESSAGES/kcm_fcitx.mo
EOF
with
%find_lang %{name}
2. in %build
you have
pushd build
but no matching
popd
3. (cosmetics, but shorter) in %install, replace
pushd build
make install DESTDIR=$RPM_BUILD_ROOT
popd
with
make install DESTDIR=$RPM_BUILD_ROOT -C build
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824083] New: Review Request: nyancat - A terminal Nyan Cat renderer
https://bugzilla.redhat.com/show_bug.cgi?id=824083 Bug ID: 824083 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: nyancat - A terminal Nyan Cat renderer Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: i...@ianweller.org Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://ianweller.fedorapeople.org/SRPMS/nyancat/1.0-1.20120522git5fe3de9.fc16/nyancat.spec SRPM URL: http://ianweller.fedorapeople.org/SRPMS/nyancat/1.0-1.20120522git5fe3de9.fc16/nyancat-1.0-1.20120522git5fe3de9.fc16.src.rpm Description: This is a simple telnet server / standalone application which renders the classic Nyan Cat (or "poptart cat") to your terminal. It makes use of various ANSI escape sequences to render color, or in the case of a VT220, simply dumps text to the screen. Fedora Account System Username: ianweller -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823873] Review Request: ThePowderToy - falling sand physics sandbox game
https://bugzilla.redhat.com/show_bug.cgi?id=823873 --- Comment #7 from Michael Cronenworth --- Any changes made to upstream's source should be kept as patches and applied during RPM build time instead of inside your source tarball. You should also send the patches to upstream in hope that they apply them so it benefits everyone, and so you do not have to maintain them. Ex: Patch0: settings.patch %prep %setup -q %patch0 -p1 FYI: Since this is your first package and I am not a sponsor, I cannot review your package, but these comments will help speed up the process once a sponsor sees this bug. I am looking forward to this being in Fedora. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821165] Review Request: fcitx-configtool - Gtk configuretool for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=821165 --- Comment #7 from Fedora Update System --- fcitx-configtool-0.4.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821165] Review Request: fcitx-configtool - Gtk configuretool for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=821165 --- Comment #6 from Fedora Update System --- fcitx-configtool-0.4.3-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-1.fc15 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821165] Review Request: fcitx-configtool - Gtk configuretool for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=821165 --- Comment #5 from Fedora Update System --- fcitx-configtool-0.4.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821165] Review Request: fcitx-configtool - Gtk configuretool for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=821165 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801064] Review Request: fcitx-ui-light - Light UI for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801064 --- Comment #8 from Fedora Update System --- fcitx-ui-light-0.1.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fcitx-ui-light-0.1.3-2.fc15 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801064] Review Request: fcitx-ui-light - Light UI for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801064 --- Comment #7 from Fedora Update System --- fcitx-ui-light-0.1.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-ui-light-0.1.3-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801064] Review Request: fcitx-ui-light - Light UI for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801064 --- Comment #6 from Fedora Update System --- fcitx-ui-light-0.1.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-ui-light-0.1.3-2.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801064] Review Request: fcitx-ui-light - Light UI for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801064 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801062] Review Request: fcitx-keyboard - X Keyboard integration with Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801062 --- Comment #8 from Fedora Update System --- fcitx-keyboard-0.1.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-keyboard-0.1.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801062] Review Request: fcitx-keyboard - X Keyboard integration with Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801062 --- Comment #7 from Fedora Update System --- fcitx-keyboard-0.1.3-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fcitx-keyboard-0.1.3-1.fc15 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801062] Review Request: fcitx-keyboard - X Keyboard integration with Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801062 --- Comment #6 from Fedora Update System --- fcitx-keyboard-0.1.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-keyboard-0.1.3-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801062] Review Request: fcitx-keyboard - X Keyboard integration with Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801062 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801053] Review Request: fcitx-chewing - Chewing Wrapper for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801053 --- Comment #8 from Fedora Update System --- fcitx-chewing-0.1.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-chewing-0.1.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801053] Review Request: fcitx-chewing - Chewing Wrapper for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801053 --- Comment #7 from Fedora Update System --- fcitx-chewing-0.1.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-chewing-0.1.1-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801053] Review Request: fcitx-chewing - Chewing Wrapper for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801053 --- Comment #6 from Fedora Update System --- fcitx-chewing-0.1.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fcitx-chewing-0.1.1-1.fc15 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801053] Review Request: fcitx-chewing - Chewing Wrapper for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801053 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824061] Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824061 --- Comment #3 from Kevin Fenzi --- Any particular reason you assigned this to me? I can try and help review, but I'm pretty busy and likely won't get to it very soon... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801059] Review Request: fcitx-fbterm - Fbterm Support for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801059 --- Comment #8 from Fedora Update System --- fcitx-fbterm-0.1.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-fbterm-0.1.4-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801059] Review Request: fcitx-fbterm - Fbterm Support for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801059 --- Comment #7 from Fedora Update System --- fcitx-fbterm-0.1.4-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-fbterm-0.1.4-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824061] Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824061 --- Comment #2 from Kevin Fenzi --- *** Bug 824063 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824063] Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824063 Kevin Fenzi changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2012-05-22 12:58:10 --- Comment #1 from Kevin Fenzi --- *** This bug has been marked as a duplicate of bug 824061 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819180] Review Request: kdesrc-build - A tool to allow you to easily build KDE from its source repositories
https://bugzilla.redhat.com/show_bug.cgi?id=819180 --- Comment #6 from Gregor Tätzner --- We have figured out all issues. So here is the new crispy and hot bugfix release. Spec URL: http://brummbq.fedorapeople.org/kdesrc-build.spec SRPM URL: http://brummbq.fedorapeople.org/kdesrc-build-1.15.1-1.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801059] Review Request: fcitx-fbterm - Fbterm Support for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801059 --- Comment #6 from Fedora Update System --- fcitx-fbterm-0.1.4-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fcitx-fbterm-0.1.4-1.fc15 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823873] Review Request: ThePowderToy - falling sand physics sandbox game
https://bugzilla.redhat.com/show_bug.cgi?id=823873 --- Comment #6 from Nazar Mishturak --- Well It is done. It has a desktop file. Settings are under ~/.powder. Spec URL: https://docs.google.com/open?id=0B_CR4N27LxsuV2VLbGZPQng0dUE SRPM URL: https://docs.google.com/open?id=0B_CR4N27LxsuVWFfd254VXRSS1U x86_64 RPM: https://docs.google.com/open?id=0B_CR4N27LxsuUEt5eFppbmV0Q2s Source URL: https://docs.google.com/open?id=0B_CR4N27LxsuTzNXRFVxNTc4YWs -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801059] Review Request: fcitx-fbterm - Fbterm Support for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801059 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073 --- Comment #6 from Liang Suilong --- I updated a new spec file and a new SRPM packages. Please continue to review it. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094928 SPEC: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx-0.3.3-1.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823886] Review Request: libusbx - Library for accessing USB devices from userspace
https://bugzilla.redhat.com/show_bug.cgi?id=823886 --- Comment #4 from Elad Alfassa --- If nobody else will pick this for review, I will review it later this week. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821247] Review Request: fcitx-table-other - Other tables for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=821247 --- Comment #2 from Liang Suilong --- Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094937 SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-table-other.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-table-other-0.1.0-1.fc16.src.rpm (In reply to comment #1) > Review:- > + koji scratch build for f18 -> > http://koji.fedoraproject.org/koji/taskinfo?taskID=4074057 > > + rpmlint on rpms gave > fcitx-table-other.src: W: spelling-error %description -l en_US ibus -> ibis, > bus, i bus > fcitx-table-other.src: W: strange-permission fcitx-table-other.spec 0775L > fcitx-table-other.src: W: invalid-url Source0: > http://fcitx.googlecode.com/files/fcitx-table-other-0.1.0.tar.xz HTTP Error > 404: Not Found > fcitx-table-other.noarch: W: spelling-error %description -l en_US ibus -> > ibis, bus, i bus > 2 packages and 0 specfiles checked; 0 errors, 4 warnings. > > > + Source verified with upstream as (sha1sum) > e3deab3d66f87321c1b1e71762e5a529eb2b324b > ../SOURCES/fcitx-table-other-0.1.0.tar.xz > e3deab3d66f87321c1b1e71762e5a529eb2b324b fcitx-table-other-0.1.0.tar.xz > > > Suggestions:- > 1) spec file got strange permissions. use "chmod 644 fcitx-table-other.spec" > and then build srpm and use it to import in Fedora. Fixed > > 2) License is not clear. COPYING says GPLv3+ whereas compose and emoji > tables are LGPLv2+ and LGPL > and spec then says GPLv2+ I contacted with the author. He said the pacakges is a fork from ibus-table-others. I checked the spec file of ibus-table-others and it is under GPLv3. So I think fcitx-table-other is under GPLv3+ is OK. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815001] Review Request: opennebula - Cloud computing tool to manage a distributed virtual data center to build private, public and hybrid IaaS clouds
https://bugzilla.redhat.com/show_bug.cgi?id=815001 --- Comment #7 from Shawn Starr --- Spoke to upstream, we will remove the SSH %post section completely and put info in documentation for user. I will clean up .spec accordingly for the other For OpenSSH we need it on hypervisors in order for the oneadmin user to execute commands on the hypervisor and the frontend itself. We will be switching to OpenNebula 3.6 and backporting to Fedora 17 after. Sunstone is a separate package in this .spec file, oZones support will be re-enabled / changed. They do however require opennebula to be installed for ruby/lib dependencies. I will fix the other issues also. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824063] New: Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824063 Bug ID: 824063 QA Contact: extras...@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: ke...@scrye.com Summary: Review Request: fcitx-unikey - Vietnamese Engine for Fcitx Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: liangsuil...@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824061] Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824061 --- Comment #1 from Liang Suilong --- (In reply to comment #0) > SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec > SRPM: > http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm > Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 > Description: > A Vietnamese engine for Fcitx that uses Unikey. I post a wrong SRPM URL. Here is a correct URL. SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801058] Review Request: fcitx-cloudpinyin - Cloudpinyin module for fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801058 Liang Suilong changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801058] Review Request: fcitx-cloudpinyin - Cloudpinyin module for fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801058 --- Comment #5 from Liang Suilong --- New Package SCM Request === Package Name: fcitx-cloudpinyin Short Description: Cloudpinyin module for fcitx Owners: liangsuilong Branches: f15 f16 f17 el6 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824061] New: Review Request: fcitx-unikey - Vietnamese Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824061 Bug ID: 824061 QA Contact: extras...@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: ke...@scrye.com Summary: Review Request: fcitx-unikey - Vietnamese Engine for Fcitx Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: liangsuil...@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823886] Review Request: libusbx - Library for accessing USB devices from userspace
https://bugzilla.redhat.com/show_bug.cgi?id=823886 --- Comment #3 from Hans de Goede --- (In reply to comment #1) > Not a review, just a comment: > Replace the URL feild with a URL that actually points to a libusbx > projectpage instead of libusb1 Oh, I thought I had fixed that, ah well will fix before import, or in the next revision of more issues are found. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824057] New: Review Request: fcitx-hangul - Hangul Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824057 Bug ID: 824057 QA Contact: extras...@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: fcitx-hangul - Hangul Engine for Fcitx Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: liangsuil...@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.1-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094896 Description: Fcitx-hangul is a Hangul engine wrapper for Fcitx. It Provides Korean input method from libhangul. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824052] New: Review Request: fcitx-m17n - M17n Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=824052 Bug ID: 824052 QA Contact: extras...@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: and...@beekhof.net Summary: Review Request: fcitx-m17n - M17n Engine for Fcitx Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: liangsuil...@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-m17n.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-m17n-0.1.2-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094875 Description: Fcitx-m17n is a M17n engine wrapper for Fcitx. It allows input of many languages using the input table maps from m17n-db. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822896] Review Request: pari-elldata - PARI/GP Computer Algebra System elliptic curves
https://bugzilla.redhat.com/show_bug.cgi?id=822896 --- Comment #7 from pcpa --- (In reply to comment #5) > > Only issue I see now is that it should have a "Requires: pari-gp" > > for proper resolution of dependencies. > > Can't do that as it would lead to a circular build dependency for pari > itself, and it's also conceivable that other software could use the same > data without requiring pari-gp. I did add a "Conflicts: pari-gp < 2.2.11" as > that's the oldest version that can use this data, though perhaps that should > be "pari" rather than "pari-gp"? Do you mean these packages will be build requires of pari now? I see they could be useful in a very complete %check. I think the conflict does not matter much, as pari-gp is a pari subpackage. About data reuse, actually, sagemath ships elldata in a different format (not sure if complete and optimized for size, but a lot smaller), as well as it also creates a cremona_mini.db sqlite3 db during build. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823886] Review Request: libusbx - Library for accessing USB devices from userspace
https://bugzilla.redhat.com/show_bug.cgi?id=823886 --- Comment #2 from Elad Alfassa --- Also, might be better to convert these files to UTF8 upstream and not at build time. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823886] Review Request: libusbx - Library for accessing USB devices from userspace
https://bugzilla.redhat.com/show_bug.cgi?id=823886 Elad Alfassa changed: What|Removed |Added CC||el...@doom.co.il --- Comment #1 from Elad Alfassa --- Not a review, just a comment: Replace the URL feild with a URL that actually points to a libusbx projectpage instead of libusb1 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815583] Review Request: ghc-edit-distance - Levenshtein and restricted Damerau-Levenshtein edit distances
https://bugzilla.redhat.com/show_bug.cgi?id=815583 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- ghc-edit-distance-0.2.1-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822881] Review Request: perl-Task-Kensho-Exceptions - A Glimpse at an Enlightened Perl (Exceptions)
https://bugzilla.redhat.com/show_bug.cgi?id=822881 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/Task/Kensho/Exceptions.pm. Ok. License verified from lib/Task/Kensho/Exceptions.pm. Ok. No XS code, noarch BuildArch is Ok. Description is Ok. Although this is dependency only meta package, run-requires are needed to pass build-time checks. Ok. TODO: I'm not sure how much helpful is MYMETA.yml file. It contains building instructions and data available form already installed POD. I recommend not to install it. All tests pass. Ok. $ rpmlint perl-Task-Kensho-Exceptions.spec ../SRPMS/perl-Task-Kensho-Exceptions-0.28-1.fc18.src.rpm ../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm drwxr-xr-x2 rootroot0 May 22 17:48 /usr/share/doc/perl-Task-Kensho-Exceptions-0.28 -rw-r--r--1 rootroot 3252 Mar 26 2011 /usr/share/doc/perl-Task-Kensho-Exceptions-0.28/Changes -rw-r--r--1 rootroot 613 May 22 17:48 /usr/share/doc/perl-Task-Kensho-Exceptions-0.28/MYMETA.yml -rw-r--r--1 rootroot 1485 Jan 20 2011 /usr/share/doc/perl-Task-Kensho-Exceptions-0.28/README -rw-r--r--1 rootroot 3361 May 22 17:48 /usr/share/man/man3/Task::Kensho::Exceptions.3pm.gz drwxr-xr-x2 rootroot0 May 22 17:48 /usr/share/perl5/vendor_perl/Task drwxr-xr-x2 rootroot0 May 22 17:48 /usr/share/perl5/vendor_perl/Task/Kensho -rw-r--r--1 rootroot 3295 Mar 26 2011 /usr/share/perl5/vendor_perl/Task/Kensho/Exceptions.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm |sort |uniq -c 1 perl(autodie) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(TryCatch) 1 perl(Try::Tiny) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Task::Kensho::Exceptions) = 0.28 1 perl-Task-Kensho-Exceptions = 0.28-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4094843). Ok. Package is line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818317] Review Request: php-channel-digitalsandwich - Adds digitalsandwich channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=818317 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- php-channel-digitalsandwich-1.3-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815678] Review Request: php-channel-phpqatools - Adds phpqatools channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=815678 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- php-channel-phpqatools-1.3-3.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822896] Review Request: pari-elldata - PARI/GP Computer Algebra System elliptic curves
https://bugzilla.redhat.com/show_bug.cgi?id=822896
--- Comment #6 from Ralf Corsepius ---
(In reply to comment #5)
> (In reply to comment #4)
> > - Shipping the *.asc sig seems pretty meaningless to me.
>
> I just see it being used as an extra check that the tarball hasn't changed,
> (if we keep the signature in git) given that upstream's releases aren't
> versioned.
I guess you are aware, Fedora's git is automatically adding m5sums to
"sources"?
This would apply if you intend to push the tarball to git's lookaside cache.
However, this would raise the next point, I don't know the answer to: Does
Fedora's git lookaside cache allow unversioned tarballs, rsp. can the lookaside
cache handle this?
> > - I would recommend to use "install -m xxx" instead of "mkdir + cp" in
> > %install.
> > This helps to avoid bad surprizes related to ownership/permissions/umasks.
>
> It's a bit awkward to do "install" recursively so instead I added a
> %{_fixperms} after the copy to ensure that the built package's permissions
> were sane.
OK with me.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
https://bugzilla.redhat.com/show_bug.cgi?id=810335 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:42:05 --- Comment #15 from Fedora Update System --- python-fabulous-0.1.5-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811782 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:40:40 --- Comment #10 from Fedora Update System --- python-tw2-sqla-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811739] Review Request: python-tw2-jqplugins-ui - jQuery UI for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811739 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:40:18 --- Comment #14 from Fedora Update System --- python-tw2-jqplugins-ui-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811759] Review Request: python-tw2-excanvas - Excanvas for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811759 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:39:50 --- Comment #9 from Fedora Update System --- python-tw2-excanvas-2.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 727004] Review Request: mimelib - A library for creating, parsing, and modifying MIME messages
https://bugzilla.redhat.com/show_bug.cgi?id=727004 Ian Weller changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Flags|fedora-review+ | Last Closed||2012-05-22 11:37:16 --- Comment #4 from Ian Weller --- Then it'll need a re-review, so I'm closing this ticket. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 720818] Review Request: python-tw2-core - Web widget creation toolkit based on TurboGears widgets
https://bugzilla.redhat.com/show_bug.cgi?id=720818 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:35:26 --- Comment #17 from Fedora Update System --- python-tw2-core-2.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811689] Review Request: python-tw2-forms - Forms for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811689 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:34:35 --- Comment #8 from Fedora Update System --- python-tw2-forms-2.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811769] Review Request: python-tw2-dynforms - Dynamic forms for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811769 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:34:17 --- Comment #10 from Fedora Update System --- python-tw2-dynforms-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810033] Review Request: python-virtualenvwrapper - Enhancements to virtualenv
https://bugzilla.redhat.com/show_bug.cgi?id=810033 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:32:27 --- Comment #14 from Fedora Update System --- python-virtualenvwrapper-3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.redhat.com/show_bug.cgi?id=818401
--- Comment #11 from pcpa ---
(In reply to comment #10)
> I just run fedora-review and this is issues sans those I waived out.
Thanks for the review!
> Issues:
> [!]: MUST Each %files section contains %defattr if rpm < 4.4
> Note: defattr() present in %files section. This is OK if packaging
> for EPEL5. Otherwise not needed
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
I will remove it for the next package.
> [!]: MUST Package contains a properly installed %{name}.desktop using
> desktop-
> file-install file if it is a GUI application.
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
I will add a call to desktop-file-validate and correct any problems
that arise.
> [!]: MUST Rpmlint output is silent.
>
> rpmlint 0ad-debuginfo-r11863-2.fc18.i686.rpm
>
> 0ad-debuginfo.i686: W: only-non-binary-in-usr-lib
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
> [!]: MUST Sources used to build the package match the upstream source, as
> provided in the spec URL.
> /tmp/818401/0ad-r11863-alpha-unix-build.tar.xz :
> MD5SUM this package : f42a2e18515cbcd48b99f0ea3796b3a4
> MD5SUM upstream package : f577f8d3a69146cfdc988a56f3caecd8
>
> See: http://fedoraproject.org/wiki/Packaging/SourceURL
I just did download it again to ensure it was not replaced by
upstream. I think your test may have donwloaded the tar.gz file,
did uncompress it, or did download some .html file...
$ LC_ALL=C wget
http://releases.wildfiregames.com/0ad-r11863-alpha-unix-build.tar.xz
--2012-05-22 11:50:53--
http://releases.wildfiregames.com/0ad-r11863-alpha-unix-build.tar.xz
Resolving releases.wildfiregames.com (releases.wildfiregames.com)...
92.243.18.55
Connecting to releases.wildfiregames.com
(releases.wildfiregames.com)|92.243.18.55|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location:
http://sourceforge.net/projects/zero-ad/files/releases/0ad-r11863-alpha-unix-build.tar.xz/download
[following]
--2012-05-22 11:50:54--
http://sourceforge.net/projects/zero-ad/files/releases/0ad-r11863-alpha-unix-build.tar.xz/download
Resolving sourceforge.net (sourceforge.net)... 216.34.181.60
Connecting to sourceforge.net (sourceforge.net)|216.34.181.60|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location:
http://downloads.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz?r=&ts=1337699972&use_mirror=tenet
[following]
--2012-05-22 11:50:55--
http://downloads.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz?r=&ts=1337699972&use_mirror=tenet
Resolving downloads.sourceforge.net (downloads.sourceforge.net)...
216.34.181.59
Connecting to downloads.sourceforge.net
(downloads.sourceforge.net)|216.34.181.59|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location:
http://tenet.dl.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz
[following]
--2012-05-22 11:50:55--
http://tenet.dl.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz
Resolving tenet.dl.sourceforge.net (tenet.dl.sourceforge.net)...
155.232.191.245, 2001:4200:fffc::245
Connecting to tenet.dl.sourceforge.net
(tenet.dl.sourceforge.net)|155.232.191.245|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 8657204 (8.3M) [application/octet-stream]
Saving to: `0ad-r11863-alpha-unix-build.tar.xz'
100%[==>] 8,657,204 1.13M/s in 12s
2012-05-22 11:51:09 (720 KB/s) - `0ad-r11863-alpha-unix-build.tar.xz' saved
[8657204/8657204]
$ md5sum 0ad-r11863-alpha-unix-build.tar.xz
f42a2e18515cbcd48b99f0ea3796b3a4 0ad-r11863-alpha-unix-build.tar.xz
> [!]: MUST Development (unversioned) .so files in -devel subpackage, if
> present.
> Note: 0ad-r11863-2.fc18.i686.rpm : /usr/lib/0ad/libAtlasUI.so
> 0ad-r11863-2.fc18.i686.rpm : /usr/lib/0ad/libCollada.so
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
I can check if reasonable to add a soversion to those libraries. But
they are not really meant to be in -devel packages, as no headers are
installed, and they are not in %_libdir on purpose.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807113] Review Request: zanata-util - Helper scripts for using Zanata
https://bugzilla.redhat.com/show_bug.cgi?id=807113 --- Comment #29 from Fedora Update System --- zanata-util-0.2.7-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807113] Review Request: zanata-util - Helper scripts for using Zanata
https://bugzilla.redhat.com/show_bug.cgi?id=807113 --- Comment #28 from Fedora Update System --- zanata-util-0.2.7-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724936] Review Request: python-mock - A Python Mocking and Patching Library for Testing
https://bugzilla.redhat.com/show_bug.cgi?id=724936 --- Comment #26 from Fedora Update System --- python-mock-0.8.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822881] Review Request: perl-Task-Kensho-Exceptions - A Glimpse at an Enlightened Perl (Exceptions)
https://bugzilla.redhat.com/show_bug.cgi?id=822881 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 788216] Review Request: python-elixir - Declarative mapper for SQLAlchemy
https://bugzilla.redhat.com/show_bug.cgi?id=788216 Toshio Ernie Kuratomi changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Flags|needinfo?(a.bad...@gmail.co | |m) | Last Closed||2012-05-22 11:15:18 --- Comment #8 from Toshio Ernie Kuratomi --- Seems this fell off my radar. Thanks for the ping. The package was unretired in the packagedb and should be in the repos. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #3 from Kevin Fenzi --- I'd be happy to review this and look at sponsoring you. ;) Look for a review soon... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org --- Comment #5 from Rex Dieter --- I notice too that the pkg summary/description doesn't match what's listed on http://code.google.com/p/fcitx/ the current ones don't mention input methods at all, and upstream site doesn't mention anything about service menus or GHNS -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073 --- Comment #5 from Rex Dieter --- I notice too that the pkg summary/description doesn't match what's listed on http://code.google.com/p/fcitx/ the current ones don't mention input methods at all, and upstream site doesn't mention anything about service menus or GHNS -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822896] Review Request: pari-elldata - PARI/GP Computer Algebra System elliptic curves
https://bugzilla.redhat.com/show_bug.cgi?id=822896
--- Comment #5 from Paul Howarth ---
(In reply to comment #3)
> For elldata it should be clear the source is GPL and the author
> is very active in sagemath development at least, but the other
> pari- packages may need further investigation. For example, there
> is no license information about the original data at
> http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/data/INDEX.html
I found something regarding the Echidna algorithms upon which the seadata file
is based (http://echidna.maths.usyd.edu.au/kohel/alg/index.html):
"This page hosts links to code and documentation in areas related to
research in number theory and arithmetic geometry developed in
association with research in this area, and made available under the
GNU Public License version 2 or higher (see GPL) and the GNU Free
Documentation License (see FDL), respectively"
Can't find any information about how the galdata file was produced but I don't
see any reason not to trust that upstream is entitled to publish it under the
terms of the GPL.
> Only issue I see now is that it should have a "Requires: pari-gp"
> for proper resolution of dependencies.
Can't do that as it would lead to a circular build dependency for pari itself,
and it's also conceivable that other software could use the same data without
requiring pari-gp. I did add a "Conflicts: pari-gp < 2.2.11" as that's the
oldest version that can use this data, though perhaps that should be "pari"
rather than "pari-gp"?
(In reply to comment #4)
> - Shipping the *.asc sig seems pretty meaningless to me.
I just see it being used as an extra check that the tarball hasn't changed, (if
we keep the signature in git) given that upstream's releases aren't versioned.
An aid to the package maintainer or anyone doing a downstream rebuild rather
than anything else.
> - I personally, would encourage you to use use %{?dist} in the %release tag.
> Sure, it's not mandatory and not using it helps avoiding rebuilds, if a
> package's contents doesn't change between Fedora/RHEL releases, however it
> also makes packages vulnerable to changes in rpm and to the file system
> layout between releases (A CentOS5's xxx-*.rpm is something entirely
> different than a Fedora 18's xxx-*.rpm, even though it's NEVR are identical).
Good point; I'd thought this package was a classic example of something that
wouldn't need a dist tag and could be inherited between releases without being
rebuilt but given the changes in rpm signature and compression formats over the
last few years, the dist tag is still useful even when the package content is
completely unchanged, so I've added on for the -3 release.
> - I would recommend to use "install -m xxx" instead of "mkdir + cp" in
> %install.
> This helps to avoid bad surprizes related to ownership/permissions/umasks.
It's a bit awkward to do "install" recursively so instead I added a
%{_fixperms} after the copy to ensure that the built package's permissions were
sane.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823989] Review Request: perl-Lexical-Var - Static variables without namespace pollution
https://bugzilla.redhat.com/show_bug.cgi?id=823989 Jitka Plesnikova changed: What|Removed |Added Priority|unspecified |medium -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823873] Review Request: ThePowderToy - falling sand physics sandbox game
https://bugzilla.redhat.com/show_bug.cgi?id=823873 Michael Schwendt changed: What|Removed |Added Blocks||177841 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817022] Review Request: perl-Test-Apocalypse - Apocalypse's favorite tests bundled into a simple interface
https://bugzilla.redhat.com/show_bug.cgi?id=817022 Bug 817022 depends on bug 816547, which changed state. Bug 816547 Summary: Review Request: perl-Test-NoBreakpoints - Test that files do not contain soft breakpoints https://bugzilla.redhat.com/show_bug.cgi?id=816547 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816547] Review Request: perl-Test-NoBreakpoints - Test that files do not contain soft breakpoints
https://bugzilla.redhat.com/show_bug.cgi?id=816547 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Test-NoBreakpoints-0.1 ||5-1.fc18 Resolution|--- |RAWHIDE Last Closed||2012-05-22 10:55:02 --- Comment #6 from Petr Pisar --- I can use the repository and build the package now too. However I still get the SOAP fault from pgkdb-cli. I think it happens only for recent packages with no bugs in Bugzilla. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823948] Review Request: perl-Lexical-SealRequireHints - Prevent leakage of lexical hints
https://bugzilla.redhat.com/show_bug.cgi?id=823948 Jitka Plesnikova changed: What|Removed |Added Blocks||823989 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823989] New: Review Request: perl-Lexical-Var - Static variables without namespace pollution
https://bugzilla.redhat.com/show_bug.cgi?id=823989 Bug ID: 823989 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Depends On: 823948 Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: perl-Lexical-Var - Static variables without namespace pollution Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: jples...@redhat.com Type: Bug Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://jplesnik.fedorapeople.org/perl-Lexical-Var/perl-Lexical-Var.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-Lexical-Var/perl-Lexical-Var-0.007-1.fc18.src.rpm Description: This module implements lexical scoping of static variables and subroutines. Although it can be used directly, it is mainly intended to be infrastructure for modules that manage namespaces. Fedora Account System Username: jples...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073
--- Comment #4 from Rex Dieter ---
Kcm's need a dependency:
# need kcmshell4 from kde(base)-runtime at least
Requires: kdebase-runtime%{?_kde4_version: >= %{_kde4_version}}
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=801073 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||656997 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823962] Review Request: apacheds-shared - Shared APIs of Apache Directory Project
https://bugzilla.redhat.com/show_bug.cgi?id=823962 gil cattaneo changed: What|Removed |Added Blocks||823967 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823964] Review Request: apacheds-ldap-client - ApacheDS LDAP Client API
https://bugzilla.redhat.com/show_bug.cgi?id=823964 gil cattaneo changed: What|Removed |Added Blocks||823967 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823959] Review Request: directory-project - Apache Directory Project Root pom
https://bugzilla.redhat.com/show_bug.cgi?id=823959 gil cattaneo changed: What|Removed |Added Blocks||823967 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823967] Review Request: apacheds - Apache Directory Server
https://bugzilla.redhat.com/show_bug.cgi?id=823967 gil cattaneo changed: What|Removed |Added Depends On||820300, 823959, 823962, ||823964 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822881] Review Request: perl-Task-Kensho-Exceptions - A Glimpse at an Enlightened Perl (Exceptions)
https://bugzilla.redhat.com/show_bug.cgi?id=822881 Bug 822881 depends on bug 822585, which changed state. Bug 822585 Summary: Review Request: perl-Module-Install-Repository - Automatically sets repository URL from svn/svk/Git checkout https://bugzilla.redhat.com/show_bug.cgi?id=822585 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
