[Bug 819687] Review Request: python-rtkit - Python Api for Request Tracker's REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=819687
--- Comment #8 from Tomas Dabašinskas ---
Jason,
Thanks for taking this review, I have updated the spec file as you suggested.
ran fedora-reveiw:
Issues:
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
package is not intended for EL5
Spec URL: https://github.com/downloads/T0MASD/python-rtkit/python-rtkit.spec
SRPM URL:
https://github.com/downloads/T0MASD/python-rtkit/python-rtkit-0.2.4-1.el6.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836163] Review Request: compton - Compositor for X
https://bugzilla.redhat.com/show_bug.cgi?id=836163 Peter Lemenkov changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Peter Lemenkov --- (In reply to comment #3) > New files: > Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/compton.spec > SRPM URL: > http://mariobl.fedorapeople.org/Review/SRPMS/compton-0-0.1. > 20120603gitd52f7a0.fc17.src.rpm Ok, looks good now. I even switched from good old xcompmgr / transset to this one. > Thanks for your hints. Additionally, I've used some tips from a user of > fedoraforum.de [1], regarding the version numbering. ... > [1] http://fedoraforum.de/viewtopic.php?f=49&t=22639&p=126443#p126439 Registerwalled. Anyway I don't see any other issues so this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817246] Review Request: icc-profiles-basiccolor-printing2009 - The OpenICC profiles from basICColor
https://bugzilla.redhat.com/show_bug.cgi?id=817246 Nicolas Chauvet (kwizart) changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Nicolas Chauvet (kwizart) --- Thx for the quick review! New Package SCM Request === Package Name: icc-profiles-basiccolor-printing2009 Short Description: Printing profiles according to ISO 12647-2. These are CMYK ICC profiles for ISO Printing conditions. Owners: kwizart Branches: f16 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783657] Review Request: fiwalk - Batch analysis of a disk image
https://bugzilla.redhat.com/show_bug.cgi?id=783657 Nicolas Chauvet (kwizart) changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2012-07-04 04:30:20 --- Comment #4 from Nicolas Chauvet (kwizart) --- Hi, Thx for the attempt to review, but this package will be merged in the next version of sleuthkit (already in fedora). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836756] Review Request: targetd - Service to make storage remotely configurable
https://bugzilla.redhat.com/show_bug.cgi?id=836756 Jiri Popelka changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jiri Popelka --- Everything looks OK now. This package is APPROVED ! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
https://bugzilla.redhat.com/show_bug.cgi?id=772766
Jiri Popelka changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|jpope...@redhat.com
Flags||fedora-review?
--- Comment #4 from Jiri Popelka ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
Python
[x]: MUST Python eggs must be built from source.
[x]: MUST Python eggs must not download any dependencies during the build
process.
You don't need to define python_sitelib macro, see
https://fedoraproject.org/wiki/Packaging:Python#Macros
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot}
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
MD5SUM this package : cf067e2abc091804385974dd146b2090
MD5SUM upstream package : cf067e2abc091804385974dd146b2090
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Dist tag is present.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
Issues:
[!]: MUST Package must own all directories that it creates.
Add
%dir %{_datadir}/%{name}
to %files
[!]: MUST Rpmlint output is silent.
stylus-toolbox.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/GladeWindow.py 0644L /usr/bin/env
I'd just remove the shebang during install.
stylus-toolbox.src: W: spelling-error %description -l en_US reult -> result, re
ult, re-ult
Fix this typo.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Brendan Jones changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Brendan Jones --- New Package SCM Request === Package Name: japa Short Description: JACK and ALSA Perceptual Analyser Owners: bsjones Branches: f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837584] New: Review Request: cargo-resources - Cargo Shared Resources
https://bugzilla.redhat.com/show_bug.cgi?id=837584 Bug ID: 837584 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: cargo-resources - Cargo Shared Resources Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/cargo-resources.spec SRPM URL: http://gil.fedorapeople.org/cargo-resources-1.2.2-1.fc16.src.rpm Description: Cargo Shared Resources (License files, Checkstyle configuration files, etc). Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 831975] Review Request: guacamole-common-js - The JavaScript library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=831975 Simone Caronni changed: What|Removed |Added Flags|fedora-review+ |fedora-review?, fedora-cvs? --- Comment #7 from Simone Caronni --- New Package SCM Request === Package Name: guacamole-common-js Short Description: The JavaScript library used by the Guacamole web application Owners: slaanesh Branches: f17 f16 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837587] New: Review Request: cargo-core - Cargo container wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=837587 Bug ID: 837587 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: cargo-core - Cargo container wrapper Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/cargo-core.spec SRPM URL: http://gil.fedorapeople.org/cargo-core-1.2.2-1.fc16.src.rpm Description: Cargo is a thin wrapper that allows you to manipulate Java EE containers in a standard way. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837584] Review Request: cargo-resources - Cargo Shared Resources
https://bugzilla.redhat.com/show_bug.cgi?id=837584 gil cattaneo changed: What|Removed |Added Blocks||837587 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837587] Review Request: cargo-core - Cargo container wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=837587 gil cattaneo changed: What|Removed |Added Depends On||837584 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837589] New: Review Request: cargo-extensions - Tools for manipulate Java EE containers
https://bugzilla.redhat.com/show_bug.cgi?id=837589 Bug ID: 837589 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: cargo-extensions - Tools for manipulate Java EE containers Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/cargo-extensions.spec SRPM URL: http://gil.fedorapeople.org/cargo-extensions-1.2.2-1.fc16.src.rpm Description: Cargo is a thin wrapper that allows you to manipulate Java EE containers in a standard way. Cargo Extensions provides the following Tools: * Ant tasks. * Maven plugin. These tools can be used in a standalone fashion or via various IDEs. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837587] Review Request: cargo-core - Cargo container wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=837587 gil cattaneo changed: What|Removed |Added Blocks||837589 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837584] Review Request: cargo-resources - Cargo Shared Resources
https://bugzilla.redhat.com/show_bug.cgi?id=837584 gil cattaneo changed: What|Removed |Added Blocks||837589 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837589] Review Request: cargo-extensions - Tools for manipulate Java EE containers
https://bugzilla.redhat.com/show_bug.cgi?id=837589 gil cattaneo changed: What|Removed |Added Depends On||837587, 837584 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 831975] Review Request: guacamole-common-js - The JavaScript library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=831975 Simone Caronni changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Simone Caronni --- Removed fedora-review+ by mistake. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789390] Review Request: aeolus - a synthesized organ for ALSA/JACK
https://bugzilla.redhat.com/show_bug.cgi?id=789390 --- Comment #4 from Brendan Jones --- Sorry for the delay - very busy at the moment SPEC: http://bsjones.fedorapeople.org/aeolus.spec SRPM: http://bsjones.fedorapeople.org/aeolus-0.8.4-4.fc16.src.rpm rpmlint /home/bsjones/rpmbuild/SRPMS/aeolus-0.8.4-4.fc17.src.rpm /home/bsjones/rpmbuild/RPMS/x86_64/aeolus-0.8.4-4.fc17.x86_64.rpm /home/bsjones/rpmbuild/RPMS/x86_64/aeolus-debuginfo-0.8.4-4.fc17.x86_64.rpm aeolus.src: W: spelling-error %description -l en_US reverb -> revere, revers, revert aeolus.x86_64: W: spelling-error %description -l en_US reverb -> revere, revers, revert aeolus.x86_64: W: shared-lib-calls-exit /usr/lib64/aeolus_x11.so exit@GLIBC_2.2.5 aeolus.x86_64: E: incorrect-fsf-address /usr/share/doc/aeolus-0.8.4/COPYING aeolus.x86_64: W: no-manual-page-for-binary aeolus 3 packages and 0 specfiles checked; 1 errors, 4 warnings. I can't change the COPYING file - the shared lib exit is OK - its a private library (even though I sonamed it because its in the ldconfig path). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834239] Review Request: monobristol - frontend for britsol in mono
https://bugzilla.redhat.com/show_bug.cgi?id=834239 Jørn Lomax changed: What|Removed |Added Attachment #594749|0 |1 is obsolete|| --- Comment #16 from Jørn Lomax --- Created attachment 596192 --> https://bugzilla.redhat.com/attachment.cgi?id=596192&action=edit patch for monoBRistol.desktop -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834239] Review Request: monobristol - frontend for britsol in mono
https://bugzilla.redhat.com/show_bug.cgi?id=834239 --- Comment #17 from Jørn Lomax --- New Package SCM Request === Package Name: monobristol Short Description: gui for bristol synthesizer written in mono Owners: jvlomax Branches:f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834239] Review Request: monobristol - frontend for britsol in mono
https://bugzilla.redhat.com/show_bug.cgi?id=834239 Jørn Lomax changed: What|Removed |Added Flags||fedora-review+, fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
https://bugzilla.redhat.com/show_bug.cgi?id=772766 --- Comment #5 from Mario Santagiuliana --- Spec URL: http://marionline.fedorapeople.org/packages/SPECS/stylus-toolbox.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/stylus-toolbox-0.2.7-2.fc16.src.rpm Fix: [makerpm@mariotuxbox ~]$ rpmlint /var/lib/mock/fedora-16-x86_64/result/*.rpm stylus-toolbox.noarch: W: spelling-error Summary(en_US) inkjet -> ink jet, ink-jet, trinket stylus-toolbox.noarch: W: spelling-error %description -l en_US inkjet -> ink jet, ink-jet, trinket stylus-toolbox.noarch: W: spelling-error %description -l en_US escputil -> pestilence stylus-toolbox.noarch: W: no-manual-page-for-binary stylus-toolbox stylus-toolbox.src: W: spelling-error Summary(en_US) inkjet -> ink jet, ink-jet, trinket stylus-toolbox.src: W: spelling-error %description -l en_US inkjet -> ink jet, ink-jet, trinket stylus-toolbox.src: W: spelling-error %description -l en_US escputil -> pestilence 2 packages and 0 specfiles checked; 0 errors, 7 warnings. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 740160] Review Request: discount - An implementation of the Markdown language in C
https://bugzilla.redhat.com/show_bug.cgi?id=740160 --- Comment #18 from Craig Barnes --- Thanks for the feedback. It appears that autoconf has never been a requirement of discount - not sure why I added that in there. I have removed this and also the unnecessary buildroot clean-up in the latest release. I should probably also note that I am maintaining the spec file in a different place now and that there has been one other release (2.1.3-4) between the latest (2.1.3-5) and the last one that I linked to above (2.1.3-3). I have retired the old link to avoid any confusion and will try to avoid moving things around in future. The spec is now at: https://raw.github.com/craigbarnes/packages/master/discount.spec and the SRPM: https://github.com/downloads/craigbarnes/packages/discount-2.1.3-5.fc17.src.rpm Also, in retrospect, the changes I made in 2.1.3-4 now seem a little hacky. Any feedback on that is appreciated. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 740160] Review Request: discount - An implementation of the Markdown language in C
https://bugzilla.redhat.com/show_bug.cgi?id=740160 --- Comment #19 from Craig Barnes --- Forget to mention, the patch is now at: https://raw.github.com/craigbarnes/packages/master/sources/discount/discount-ldconfig.patch -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
https://bugzilla.redhat.com/show_bug.cgi?id=772766 Jiri Popelka changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Jiri Popelka --- Also this: > You don't need to define python_sitelib macro, see > https://fedoraproject.org/wiki/Packaging:Python#Macros but that's not a blocker, so this package is APPROVED ! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822997] Review Request: erlang-eper - Erlang performance and debugging tools
https://bugzilla.redhat.com/show_bug.cgi?id=822997
Michel Alexandre Salim changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Michel Alexandre Salim ---
OK, I've just gone through the full review, results below. APPROVED - but
please remove the spec sections that are only needed for RHEL5 (see list of
issues below)
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[!]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec u
[Bug 835686] Review Request: wine-mono - Mono library required for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=835686 Andreas Bierfert changed: What|Removed |Added Blocks||834762 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
https://bugzilla.redhat.com/show_bug.cgi?id=772766 --- Comment #7 from Mario Santagiuliana --- Thank you for your review! I remove the macro: Spec URL: http://marionline.fedorapeople.org/packages/SPECS/stylus-toolbox.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/stylus-toolbox-0.2.7-3.fc16.src.rpm -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
https://bugzilla.redhat.com/show_bug.cgi?id=772766 Mario Santagiuliana changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mario Santagiuliana --- New Package SCM Request === Package Name: stylus-toolbox Short Description: A printer utility for Epson Stylus® inkjet printers Owners: marionline Branches: f16 f17 InitialCC: marionline -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834239] Review Request: monobristol - frontend for britsol in mono
https://bugzilla.redhat.com/show_bug.cgi?id=834239 Orcan Ogetbil changed: What|Removed |Added Flags|fedora-review+ | --- Comment #18 from Orcan Ogetbil --- I wonder how the flag got messed up. I guess it is me whose name is on the fedora-review+. Will try to fix. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834239] Review Request: monobristol - frontend for britsol in mono
https://bugzilla.redhat.com/show_bug.cgi?id=834239 Orcan Ogetbil changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834239] Review Request: monobristol - frontend for britsol in mono
https://bugzilla.redhat.com/show_bug.cgi?id=834239 Orcan Ogetbil changed: What|Removed |Added Assignee|nob...@fedoraproject.org|oget.fed...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823041] Review Request: php-symfony2-ClassLoader - Symfony2 ClassLoader Component
https://bugzilla.redhat.com/show_bug.cgi?id=823041 --- Comment #19 from Fedora Update System --- php-symfony2-ClassLoader-2.0.15-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-symfony2-ClassLoader-2.0.15-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823041] Review Request: php-symfony2-ClassLoader - Symfony2 ClassLoader Component
https://bugzilla.redhat.com/show_bug.cgi?id=823041 --- Comment #20 from Fedora Update System --- php-symfony2-ClassLoader-2.0.15-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-symfony2-ClassLoader-2.0.15-2.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823041] Review Request: php-symfony2-ClassLoader - Symfony2 ClassLoader Component
https://bugzilla.redhat.com/show_bug.cgi?id=823041 --- Comment #21 from Fedora Update System --- php-symfony2-ClassLoader-2.0.15-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-symfony2-ClassLoader-2.0.15-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 835686] Review Request: wine-mono - Mono library required for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=835686 --- Comment #10 from Andreas Bierfert --- incorrect-fsf-address reported upstream: http://bugs.winehq.org/show_bug.cgi?id=31121 http://fedora.lowlatency.de/review/wine-mono.spec http://fedora.lowlatency.de/review/wine-mono-0.0.4-7.fc17.src.rpm * Wed Jul 04 2012 Andreas Bierfert - 0.0.4-7 - add mingw-filesystem BR - fix header macro -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827167] Review Request: bumblebee - Bumblebee daemon
https://bugzilla.redhat.com/show_bug.cgi?id=827167 Laurent Boualit changed: What|Removed |Added CC||lolob...@gmail.com --- Comment #14 from Laurent Boualit --- Hi, someone is working on this here http://downloads.aelys-info.net/fedora/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837331] Review Request: nettle - A low-level cryptographic library
https://bugzilla.redhat.com/show_bug.cgi?id=837331
Jiri Popelka changed:
What|Removed |Added
CC||jpope...@redhat.com
Assignee|nob...@fedoraproject.org|jpope...@redhat.com
Flags||fedora-review?
--- Comment #2 from Jiri Popelka ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if present.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Missing:
BuildRequires: texinfo-tex
BuildRequires: texlive-dvips
BuildRequires: ghostscript
[!]: MUST Buildroot is not present
see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot}
see https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
see https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[-]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Rpmlint output is silent.
only some false-positives
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
MD5SUM this package : 450be8c4886d46c09f49f568ad6fa013
MD5SUM upstream package : 450be8c4886d46c09f49f568ad6fa013
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[!]: SHOULD Reviewer should test that the package builds in mock.
see the missing BuildRequires
[x]: SHOULD Dist tag is present.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD The placement of pkgconfig(.pc) files are correct.
[!]: SHOULD Scriptlets must be sane, if used.
Check https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo
I'd replace
Requires(post): /sbin/install-info
Requires(preun): /sbin/install-info
with
Requires(post): info
Requires(preun): info
and also the '.gz' seems to be redundant in %preun
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD %check is present and all tests pass.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
[Bug 827167] Review Request: bumblebee - Bumblebee daemon
https://bugzilla.redhat.com/show_bug.cgi?id=827167 --- Comment #15 from Gary Gatling --- Hi Laurent, Check out: http://techies.ncsu.edu/wiki/bumblebee Feel free to use any of those packages/specs at that aelys project. That is my test repo and early attempt at documentation. I am hoping to work some on bumblebee and VirtualGL spec files some today on my day off. :) Cheers, -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] New: Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=837666 Bug ID: 837666 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: shawn.iwin...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineCommon.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineCommon-2.2.2-1.fc17.src.rpm Description: The Doctrine Common project is a library that provides extensions to core PHP functionality. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=837666 Shawn Iwinski changed: What|Removed |Added Depends On||517641 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837668] New: Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer
https://bugzilla.redhat.com/show_bug.cgi?id=837668 Bug ID: 837668 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: shawn.iwin...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineDBAL.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineDBAL-2.2.2-1.fc17.src.rpm Description: Powerful database abstraction layer with many features for database schema introspection, schema management and PDO abstraction. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=837666 Shawn Iwinski changed: What|Removed |Added Blocks||837668 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823043] Review Request: php-symfony2-Console - Symfony2 Console Component
https://bugzilla.redhat.com/show_bug.cgi?id=823043 Shawn Iwinski changed: What|Removed |Added Blocks||837668 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer
https://bugzilla.redhat.com/show_bug.cgi?id=837668 Shawn Iwinski changed: What|Removed |Added Depends On||517641, 837666, 823043 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837669] New: Review Request: php-doctrine-DoctrineORM - Doctrine Object Relational Mapper
https://bugzilla.redhat.com/show_bug.cgi?id=837669 Bug ID: 837669 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: php-doctrine-DoctrineORM - Doctrine Object Relational Mapper Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: shawn.iwin...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineORM.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineORM-2.2.2-1.fc17.src.rpm Description: Object relational mapper (ORM) for PHP that sits on top of a powerful database abstraction layer (DBAL). One of its key features is the option to write database queries in a proprietary object oriented SQL dialect called Doctrine Query Language (DQL), inspired by Hibernate's HQL. This provides developers with a powerful alternative to SQL that maintains flexibility without requiring unnecessary code duplication. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer
https://bugzilla.redhat.com/show_bug.cgi?id=837668 Shawn Iwinski changed: What|Removed |Added Blocks||837669 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=837666 Shawn Iwinski changed: What|Removed |Added Blocks||837669 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823043] Review Request: php-symfony2-Console - Symfony2 Console Component
https://bugzilla.redhat.com/show_bug.cgi?id=823043 Shawn Iwinski changed: What|Removed |Added Blocks||837669 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817303] Review Request: php-symfony2-Yaml - Symfony2 Yaml Component
https://bugzilla.redhat.com/show_bug.cgi?id=817303 Shawn Iwinski changed: What|Removed |Added Blocks||837669 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837669] Review Request: php-doctrine-DoctrineORM - Doctrine Object Relational Mapper
https://bugzilla.redhat.com/show_bug.cgi?id=837669 Shawn Iwinski changed: What|Removed |Added Depends On||517641, 837666, 837668, ||823043, 817303 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=837666 --- Comment #1 from Shawn Iwinski --- rpmlint outputs the following error: php-doctrine-DoctrineCommon.noarch: E: incorrect-fsf-address /usr/share/doc/pear/DoctrineCommon/LICENSE There is only whitespace and mailing address differences. I will work with upstream to get this fixed. Is this a blocker until it is fixed upstream? http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is not clear if this is a blocker or not. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 835686] Review Request: wine-mono - Mono library required for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=835686 Michael Cronenworth changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Michael Cronenworth --- Looks good. The package wine-mono is APPROVED by mooninite -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer
https://bugzilla.redhat.com/show_bug.cgi?id=837668 --- Comment #1 from Shawn Iwinski --- rpmlint outputs the following: php-doctrine-DoctrineDBAL.noarch: E: script-without-shebang /usr/bin/doctrine-dbal.php php-doctrine-DoctrineDBAL.noarch: E: zero-length /usr/share/doc/pear/DoctrineDBAL/Doctrine/DBAL/README.markdown php-doctrine-DoctrineDBAL.noarch: E: incorrect-fsf-address /usr/share/doc/pear/DoctrineDBAL/LICENSE php-doctrine-DoctrineDBAL.noarch: W: no-manual-page-for-binary doctrine-dbal.php php-doctrine-DoctrineDBAL.noarch: W: no-manual-page-for-binary doctrine-dbal * I will fix script-without-shebang according to http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang * Since this is a PEAR package and all files are listed in package.xml, are zero-length errors required to be fixed? * incorrect-fsf-address: There is only whitespace and mailing address differences. I will work with upstream to get this fixed. Is this a blocker until it is fixed upstream? http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is not clear if this is a blocker or not. * I will ask upstream to fix no-manual-page-for-binary warnings -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 835686] Review Request: wine-mono - Mono library required for Wine
https://bugzilla.redhat.com/show_bug.cgi?id=835686 Andreas Bierfert changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Andreas Bierfert --- New Package SCM Request === Package Name: wine-mono Short Description: Mono library required for Wine Owners: awjb Branches: f17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837669] Review Request: php-doctrine-DoctrineORM - Doctrine Object Relational Mapper
https://bugzilla.redhat.com/show_bug.cgi?id=837669 --- Comment #1 from Shawn Iwinski --- rpmlint outputs the following: php-doctrine-DoctrineORM.noarch: E: script-without-shebang /usr/bin/doctrine.php php-doctrine-DoctrineORM.noarch: E: script-without-shebang /usr/bin/doctrine.bat php-doctrine-DoctrineORM.noarch: E: incorrect-fsf-address /usr/share/doc/pear/DoctrineORM/LICENSE php-doctrine-DoctrineORM.noarch: E: zero-length /usr/share/doc/pear/DoctrineORM/Doctrine/ORM/README.markdown php-doctrine-DoctrineORM.noarch: W: no-manual-page-for-binary doctrine.php php-doctrine-DoctrineORM.noarch: W: no-manual-page-for-binary doctrine.bat php-doctrine-DoctrineORM.noarch: W: no-manual-page-for-binary doctrine * I will fix script-without-shebang according to http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang * Since this is a PEAR package and all files are listed in package.xml, are zero-length errors required to be fixed? * incorrect-fsf-address: There is only whitespace and mailing address differences. I will work with upstream to get this fixed. Is this a blocker until it is fixed upstream? http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is not clear if this is a blocker or not. * I will ask upstream to fix no-manual-page-for-binary warnings Also, I will work with upstream to update their package.xml file so doctrine.bat only gets installed on Windows OS (using phprelease and installconditions) like several other PEAR packages do (phpci for example). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837331] Review Request: nettle - A low-level cryptographic library
https://bugzilla.redhat.com/show_bug.cgi?id=837331
--- Comment #3 from David Woodhouse ---
(In reply to comment #2)
> [!]: MUST All build dependencies are listed in BuildRequires, except for any
> that are listed in the exceptions section of Packaging Guidelines.
>
> Missing:
> BuildRequires: texinfo-tex
> BuildRequires: texlive-dvips
> BuildRequires: ghostscript
Added; thanks.
> [!]: MUST Buildroot is not present
> [!]: MUST Package has no %clean section with rm -rf %{buildroot}
> [!]: MUST Each %files section contains %defattr if rpm < 4.4
> [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
I believe these are incorrect. It does have a Buildroot tag, does have a %clean
section, does have %defattr in the %files sections, and does remove the
buildroot first thing in %install.
> [!]: SHOULD Reviewer should test that the package builds in mock.
http://koji.fedoraproject.org/koji/taskinfo?taskID=4218564
> [!]: SHOULD Scriptlets must be sane, if used.
>
> Check https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo
>
> I'd replace
> Requires(post): /sbin/install-info
> Requires(preun): /sbin/install-info
> with
> Requires(post): info
> Requires(preun): info
>
> and also the '.gz' seems to be redundant in %preun
All fixed, thanks.
Spec URL: http://david.woodhou.se/nettle.spec
SRPM URL: http://david.woodhou.se/nettle-2.4-2.fc15.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #6 from Darryl L. Pierce --- If the above changes are sufficient, could we wrap up the review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 Shawn Iwinski changed: What|Removed |Added CC||shawn.iwin...@gmail.com Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836163] Review Request: compton - Compositor for X
https://bugzilla.redhat.com/show_bug.cgi?id=836163 Mario Blättermann changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Mario Blättermann --- Thanks for your review. New Package SCM Request === Package Name: compton Short Description: Compositor for X Owners: mariobl Branches: f16 f17 el6 InitialCC: mariobl -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 Shawn Iwinski changed: What|Removed |Added Flags||needinfo?(fedora@famillecol ||let.com) --- Comment #2 from Shawn Iwinski --- htmlLawed documentation [1] says its' license is "LGPL license version 3 and GPL license version 2 or later", but the spec file has "LGPLv3+ and GPLv2+". Shouldn't the spec file have "LGPLv3 and GPLv2+" (no "+" for LGPL)? [1] http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/htmLawed_README.htm#s1.4 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann --- I'll do the review. BTW, nice to know that some other people are interested in to package dockapps for Fedora :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812659] Review Request: par - paragraph reformatter
https://bugzilla.redhat.com/show_bug.cgi?id=812659 --- Comment #8 from David Levine --- Added a fc17 src rpm, with contents identical to the fc16 src rpm: Spec URL: http://www.cs.wustl.edu/~levine/par/par-1.52-5.spec SRPM URL: http://www.cs.wustl.edu/~levine/par/par-1.52-5.fc17.src.rpm spot, will you have a chance to look at this? Thanks very much, David -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 Remi Collet changed: What|Removed |Added Flags|needinfo?(fedora@famillecol | |let.com)| --- Comment #3 from Remi Collet --- Hard to say if LGPL license version 3 and GPL license version 2 or later means (LGPL license version 3 and GPL license version 2) or later or LGPL license version 3 and (GPL license version 2 or later) I have ask upstream to clarify http://www.bioinformatics.org/phplabware/forum/viewtopic.php?pid=627#p627 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #4 from Remi Collet --- As http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/ says "free and licensed under LGPL v3 and GPL v2+" It seems + only apply to GPL. So https://github.com/remicollet/remirepo/commit/01690cde94c30acce0517a47375387af8b696e6d SRPM: http://rpms.famillecollet.com/SRPMS/php-htmLawed-1.1.11-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562
--- Comment #2 from Mario Blättermann ---
New scratch build (because yours was deleted):
http://koji.fedoraproject.org/koji/taskinfo?taskID=4218675
No recognizable issues from rpmlint:
$ rpmlint -i -v *
wmudmount.i686: I: checking
wmudmount.i686: I: enchant-dictionary-not-found en_US
A dictionary for the Enchant spell checking library is not available for the
language given in the info message. Spell checking will proceed with
rpmlint's built-in implementation for localized tags in this language. For
better spell checking results in this language, install the appropriate
dictionary that Enchant will use for this language, often for example
hunspell-* or aspell-*.
wmudmount.i686: I: checking-url http://sourceforge.net/projects/wmudmount/
(timeout 10 seconds)
wmudmount.src: I: checking
wmudmount.src: I: checking-url http://sourceforge.net/projects/wmudmount/
(timeout 10 seconds)
wmudmount.src: I: checking-url
http://downloads.sourceforge.net/wmudmount/wmudmount-1.13.tar.gz (timeout 10
seconds)
wmudmount.x86_64: I: checking
wmudmount.x86_64: I: checking-url http://sourceforge.net/projects/wmudmount/
(timeout 10 seconds)
wmudmount-debuginfo.i686: I: checking
wmudmount-debuginfo.i686: I: checking-url
http://sourceforge.net/projects/wmudmount/ (timeout 10 seconds)
wmudmount-debuginfo.x86_64: I: checking
wmudmount-debuginfo.x86_64: I: checking-url
http://sourceforge.net/projects/wmudmount/ (timeout 10 seconds)
wmudmount.spec: I: checking-url
http://downloads.sourceforge.net/wmudmount/wmudmount-1.13.tar.gz (timeout 10
seconds)
5 packages and 1 specfiles checked; 0 errors, 0 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[x] MUST: The file containing the text of the license(s) for the package
must be included in %doc.
See below.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
988955faca6db4f9c4d26f8b79a38744 wmudmount-1.13.tar.gz
988955faca6db4f9c4d26f8b79a38744 wmudmount-1.13.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- See Koji build above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: The spec file MUST handle locales properly.
[+] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
Exception for dockapps, which are gui apps, but no desktop file is needed
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[x] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
There's no license file in the package. You should inform upstream development
abou
[Bug 837686] New: Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Bug ID: 837686
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: python-tablib - Format agnostic
tabular data library (XLS, JSON, YAML, CSV)
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: rb...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://threebean.org/rpm/python-tablib.spec
SRPM URL:
http://threebean.org/rpm/python-tablib-0.9.11.20120702git752443f-1.fc17.src.rpm
Description: Tablib is a format-agnostic tabular dataset library, written in
Python.
Output formats supported:
- Excel (Sets + Books)
- JSON (Sets + Books)
- YAML (Sets + Books)
- HTML (Sets)
- TSV (Sets)
- CSV (Sets)
Fedora Account System Username: ralph
rpmlint output
--
--- ~/rpmbuild » rpmlint {SRPMS,SPECS}/python-tablib*
python-tablib.src: W: spelling-error %description -l en_US dataset -> data set,
data-set, database
python-tablib.src: W: invalid-url Source0:
tablib-0.9.11.20120702git752443f.tar.gz
SPECS/python-tablib.spec: W: invalid-url Source0:
tablib-0.9.11.20120702git752443f.tar.gz
1 packages and 1 specfiles checked; 0 errors, 3 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #5 from Shawn Iwinski --- EPEL 5 build seems to fail: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218696 I've run into this issue before when using a later SRPM for RHEL/EPEL 5 builds. Will the build succeed using "fedpkg build" from the "el5" repo branch? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837687] New: Review Request: python-cmd2 - Extra features for standard library's cmd module
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Bug ID: 837687
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: python-cmd2 - Extra features for
standard library's cmd module
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: rb...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://threebean.org/rpm/python-cmd2.spec
SRPM URL: http://threebean.org/rpm/python-cmd2-0.6.4-1.fc17.src.rpm
Description: Enhancements for standard library's cmd module.
Drop-in replacement adds several features for command-prompt tools:
* Searchable command history (commands: "hi", "li", "run")
* Load commands from file, save to file, edit commands in file
* Multi-line commands
* Case-insensitive commands
* Special-character shortcut commands (beyond cmd's "@" and "!")
* Settable environment parameters
* Parsing commands with flags
* > (filename), >> (filename) redirect output to file
* < (filename) gets input from file
* bare >, >>, < redirect to/from paste buffer
* accepts abbreviated commands when unambiguous
* `py` enters interactive Python console
* test apps against sample session transcript (see example/example.py)
Useable without modification anywhere cmd is used; simply import cmd2.Cmd
in place of cmd.Cmd.
See docs at http://packages.python.org/cmd2/
Fedora Account System Username: ralph
rpmlint output
--
--- ~/rpmbuild » rpmlint {SRPMS,SPECS}/python-cmd2*
python-cmd2.src: W: spelling-error Summary(en_US) cmd -> cm, cad, cod
python-cmd2.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod
python-cmd2.src: W: spelling-error %description -l en_US li -> lee, Li, lo
python-cmd2.src: W: spelling-error %description -l en_US cmd's -> cad's, cod's,
cud's
python-cmd2.src: W: spelling-error %description -l en_US filename -> file name,
file-name, filament
python-cmd2.src: W: spelling-error %description -l en_US py -> pt, p, y
python-cmd2.src: W: spelling-error %description -l en_US Cmd -> Cm, Cd, Cmdr
1 packages and 1 specfiles checked; 0 errors, 7 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] Review Request: python3-dateutil - Powerful extensions to the standard datetime module
https://bugzilla.redhat.com/show_bug.cgi?id=810859 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810859] Review Request: python3-dateutil - Powerful extensions to the standard datetime module
https://bugzilla.redhat.com/show_bug.cgi?id=810859 --- Comment #10 from Fedora Update System --- python3-dateutil-2.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python3-dateutil-2.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837688] New: Review Request: python-cliff - Command Line Interface Formulation Framework
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Bug ID: 837688
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: python-cliff - Command Line Interface
Formulation Framework
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: rb...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://threebean.org/rpm/python-cliff.spec
SRPM URL: http://threebean.org/rpm/python-cliff-1.0-1.fc17.src.rpm
Description:
cliff is a framework for building command line programs. It uses setuptools
entry points to provide subcommands, output formatters, and other
extensions.
Documentation for cliff is hosted on readthedocs.org at
http://readthedocs.org/docs/cliff/en/latest/
Fedora Account System Username: ralph
rpmlint
---
--- ~/rpmbuild » rpmlint {SPECS,SRPMS}/python-cliff*
python-cliff.src: W: spelling-error %description -l en_US setuptools -> setup
tools, setup-tools, toadstools
python-cliff.src: W: spelling-error %description -l en_US subcommands -> sub
commands, sub-commands, commands
python-cliff.src: W: spelling-error %description -l en_US formatters -> for
matters, for-matters, formatted
python-cliff.src: W: spelling-error %description -l en_US readthedocs ->
headteachers
1 packages and 1 specfiles checked; 0 errors, 4 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837688] Review Request: python-cliff - Command Line Interface Formulation Framework
https://bugzilla.redhat.com/show_bug.cgi?id=837688 Ralph Bean changed: What|Removed |Added Depends On||837687, 837686, 837087 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837687] Review Request: python-cmd2 - Extra features for standard library's cmd module
https://bugzilla.redhat.com/show_bug.cgi?id=837687 Ralph Bean changed: What|Removed |Added Blocks||837688 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837686] Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686 Ralph Bean changed: What|Removed |Added Blocks||837688 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #6 from Shawn Iwinski --- I'm assuming since the PHP version dependency is so low, and since you require php-ctype and php-pcre, you don't need to explicitly require php-common? Also, we should notify phpci upstream that there is a false positive of the session extension. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #7 from Remi Collet --- Hum... from a local generic srpm, succeed: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218766 From a local mock el5 result srpm, also succeed: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218770 From your build log DEBUG util.py:257: error: unpacking of archive failed on file /builddir/build/SOURCES/htmLawed.zip;4ff490d7: cpio: MD5 sum mismatch So I think to a temporary issue... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837689] New: Review Request: pkgwat - CLI tool for querying the fedora packages webapp
https://bugzilla.redhat.com/show_bug.cgi?id=837689
Bug ID: 837689
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: pkgwat - CLI tool for querying the
fedora packages webapp
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: rb...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://threebean.org/rpm/pkgwat.spec
SRPM URL: http://threebean.org/rpm/pkgwat-0.3-1.fc17.src.rpm
Description:
Pronounced "package WAT", pkgwat is a fast CLI tool for querying the fedora
packages webapp. https://apps.fedoraproject.org/packages/
You can make its search even better by helping us tag packages.
https://apps.fedoraproject.org/tagger
Fedora Account System Username: ralph
--- ~/rpmbuild » rpmlint {SPECS,SRPMS}/pkgwat*
pkgwat.src: W: spelling-error Summary(en_US) webapp -> web app, web-app, weapon
pkgwat.src: W: spelling-error %description -l en_US webapp -> web app, web-app,
weapon
1 packages and 1 specfiles checked; 0 errors, 2 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837432] Review Request: python-pkgwat-api - Python API for querying the fedora packages webapp
https://bugzilla.redhat.com/show_bug.cgi?id=837432 Ralph Bean changed: What|Removed |Added Blocks||837689 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837689] Review Request: pkgwat - CLI tool for querying the fedora packages webapp
https://bugzilla.redhat.com/show_bug.cgi?id=837689 Ralph Bean changed: What|Removed |Added Depends On||837688, 837432 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837688] Review Request: python-cliff - Command Line Interface Formulation Framework
https://bugzilla.redhat.com/show_bug.cgi?id=837688 Ralph Bean changed: What|Removed |Added Blocks||837689 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #8 from Remi Collet --- (In reply to comment #6) > I'm assuming since the PHP version dependency is so low, and since you > require php-ctype and php-pcre, you don't need to explicitly require > php-common? Yes. > Also, we should notify phpci upstream that there is a false positive of the > session extension. I don't see this... $ phpci print --report extension /usr/share/php/htmLawed/ --- EXTENSIONPECL VERSION COUNT --- Core4.0.0 27 ctype 4.0.4 3 pcre4.0.0 54 standard4.0.0 204 --- Have you run phpci on the full tree sources ? (htmLawedTest.php use session, but is only provided as %doc)? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562 --- Comment #3 from Andreas Bierfert --- I will query upstream, however, I understand the review guide/licensing guide so that only if a license file is included as its own file then the file must be included. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837686] Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686 Luke Macken changed: What|Removed |Added Status|NEW |ASSIGNED CC||lmac...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #9 from Shawn Iwinski --- (In reply to comment #8) > Have you run phpci on the full tree sources ? > (htmLawedTest.php use session, but is only provided as %doc)? Indeed I did. My mistake. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 --- Comment #10 from Shawn Iwinski --- Created attachment 596283 --> https://bugzilla.redhat.com/attachment.cgi?id=596283&action=edit Package review (initially generated by fedora-review 0.1.3) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562 Mario Blättermann changed: What|Removed |Added Flags||fedora-review+ --- Comment #4 from Mario Blättermann --- Ah, just seen in the packaging guidelines: MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. Means, your package is OK so far. This is because I use a custom review template, and this doesn't include the "and only if" clause. I've never reviewed a package before, which doesn't ship a COPYING or LICENSE file... However, for better reading you should drop libX11-devel from BR, but this doesn't affect that your package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Shawn Iwinski --- No issues detected === APPROVED === -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562 --- Comment #5 from Andreas Bierfert --- Thanks. I had the same problem when putting the package together. Never had a package w/o a license file before either... I have contacted upstream. Maybe this will be resolved with the next release. I will clean up the BR after import and before building. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562 Andreas Bierfert changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Andreas Bierfert --- New Package SCM Request === Package Name: wmudmount Short Description: A WindowMaker filesystem mounting dockapp using udisks Owners: awjb Branches: f17 f16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836587] Review Request: php-htmLawed - PHP code to purify and filter HTML
https://bugzilla.redhat.com/show_bug.cgi?id=836587 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Remi Collet --- Thanks for the quick review. New Package SCM Request === Package Name: php-htmLawed Short Description: PHP code to purify and filter HTML Owners: remi Branches: f16 f17 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837686] Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686
Luke Macken changed:
What|Removed |Added
Flags||needinfo?(rb...@redhat.com)
--- Comment #1 from Luke Macken ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[!]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GENERATED FILE", "*No copyright* UNKNOWN", "UNKNOWN", "LGPL (v2.1 or
later) (with incorrect FSF address)", "GPL (v2 or later)", "*No
copyright* Public domain", "BSD (4 clause)", "LGPL (v2.1 or later)
GENERATED FILE", "MIT/X11 (BSD like)", "LGPL (v2.1 or later)" For
detailed output of licensecheck see file:
/home/lmacken/code/github.com/FedoraReview/837686-python-
tablib/licensecheck.txt
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text fi
[Bug 837686] Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686 Ralph Bean changed: What|Removed |Added Flags|needinfo?(rb...@redhat.com) | --- Comment #2 from Ralph Bean --- Spec URL: http://threebean.org/rpm/python-tablib.spec SRPM URL: http://threebean.org/rpm/python-tablib-0.9.11.20120702git752443f-2.fc17.src.rpm ^^ updated spec with a comment pointing to the upstream bug for the patch. Note that upstream considers their bundling to be full forks and a part of their project. https://github.com/dreamhost/cliff/issues/13 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837686] Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV)
https://bugzilla.redhat.com/show_bug.cgi?id=837686 --- Comment #3 from Luke Macken --- Assuming those forked packages are kosher, then all of the MUST items are taken care of. The SHOULD's aren't a big deal, but there are a few simple rpmlint complaints that should probably get taken care of. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772766] Review Request: stylus-toolbox - A printer utility for Epson Stylus® inkjet printers
https://bugzilla.redhat.com/show_bug.cgi?id=772766 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). Richard, please take ownership of review BZs. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817246] Review Request: icc-profiles-basiccolor-printing2009 - The OpenICC profiles from basICColor
https://bugzilla.redhat.com/show_bug.cgi?id=817246 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 831975] Review Request: guacamole-common-js - The JavaScript library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=831975 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837694] New: Review Request: python-tahrir - Web app for interacting with openbadges
https://bugzilla.redhat.com/show_bug.cgi?id=837694 Bug ID: 837694 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: python-tahrir - Web app for interacting with openbadges Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: rossdy...@csh.rit.edu Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://www.csh.rit.edu/~rossdylan/rpms/tahrir-api/python-tahrir-api.spec SRPM URL: http://www.csh.rit.edu/~rossdylan/rpms/tahrir-api/python-tahrir-api-0.1.3.1-1.fc17.src.rpm Description: A pyramid web app for interacting with openbadges. Allows for the creation and tracking of new openbadges Fedora Account System Username: rossdylan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833562] Review Request: wmudmount - A WindowMaker filesystem mounting dockapp using udisks
https://bugzilla.redhat.com/show_bug.cgi?id=833562 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
