[Bug 847484] Review Request: mediawiki-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects
https://bugzilla.redhat.com/show_bug.cgi?id=847484 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #1 from Kevin Fenzi --- Note that in EPEL6 (which we use in Fedora Infrastructure) we are using the 'mediawiki119' package. So, if you want to maintain in both Fedora and EPEL6, we will need to complete this review for Fedora and do a new one for mediawiki119-HTTP302Found for EPEL6. Just let me know and I can review this and the EPEL6 one. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Rex Dieter changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Rex Dieter changed: What|Removed |Added Component|0x |Package Review Assignee|rdie...@math.unl.edu|nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Dan Mashal changed: What|Removed |Added CC||dw...@infradead.org Component|Package Review |0x Flags|fedora-review+ |fedora-cvs? --- Comment #14 from Dan Mashal --- New Package SCM Request === Package Name: mate-dialogs Short Description: Displays dialog boxes from shell scripts for MATE Desktop. Owners: vicodan raveit65 rdieter Branches: f16 f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847484] New: Review Request: mediawiki-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects
https://bugzilla.redhat.com/show_bug.cgi?id=847484 Bug ID: 847484 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: mediawiki-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: puiterw...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://puiterwijk.fedorapeople.org/packages/mediawiki-HTTP302Found/mediawiki-HTTP302Found.spec SRPM URL: http://puiterwijk.fedorapeople.org/packages/mediawiki-HTTP302Found/mediawiki-HTTP302Found-2.0-1.fc17.src.rpm Fedora Account System Username: puiterwijk Description: Pushes a HTTP code 302 (Found) to the browser when there is a redirect instead of handling it internally. The end user will not notice any difference (other than the address to the page having an ?rd=Redirecting_page bit at the end). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 --- Comment #13 from Dan Mashal --- k will fix that in the official build. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #19 from Dan Mashal --- J-P: Does the make file respect DESTDIR? That's a major blocker. + make install DESTDIR=/home/dan/rpmbuild/BUILDROOT/communi-1.1.0-1.fc17.x86_64 cd src/ && make -f Makefile install make[1]: Entering directory `/home/dan/rpmbuild/BUILD/communi-1.1.0/src' install -m 755 -p "../lib/libCommuni.so.1.2.0" "/usr/lib64/libCommuni.so.1.2.0" install: cannot remove `/usr/lib64/libCommuni.so.1.2.0': Permission denied make[1]: [install_target] Error 1 (ignored) ln -f -s "libCommuni.so.1.2.0" "/usr/lib64/libCommuni.so" ln: cannot remove `/usr/lib64/libCommuni.so': Permission denied make[1]: [install_target] Error 1 (ignored) ln -f -s "libCommuni.so.1.2.0" "/usr/lib64/libCommuni.so.1" ln: cannot remove `/usr/lib64/libCommuni.so.1': Permission denied make[1]: [install_target] Error 1 (ignored) ln -f -s "libCommuni.so.1.2.0" "/usr/lib64/libCommuni.so.1.2" ln: cannot remove `/usr/lib64/libCommuni.so.1.2': Permission denied make[1]: [install_target] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/irc.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/irc.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/irccommand.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/irccommand.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/irccodecplugin.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/irccodecplugin.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/ircglobal.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/ircglobal.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/ircmessage.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/ircmessage.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/ircsender.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/ircsender.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/ircsession.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/ircsession.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/ircutil.h /usr/include/Communi/ install: cannot remove `/usr/include/Communi/ircutil.h': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/Irc /usr/include/Communi/ install: cannot remove `/usr/include/Communi/Irc': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcCommand /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcCommand': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcCodecPlugin /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcCodecPlugin': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcGlobal /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcGlobal': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcMessage /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcMessage': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcSender /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcSender': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcSession /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcSession': Permission denied make[1]: [install_headers] Error 1 (ignored) install -m 644 -p /home/dan/rpmbuild/BUILD/communi-1.1.0/include/IrcUtil /usr/include/Communi/ install: cannot remove `/usr/include/Communi/IrcUtil': Permission denied make[1]: [install_headers] Error 1 (ignored) make[1]: Leaving directory `/home/dan/rpmbuild/BUILD/communi-1.1.0/src' cd src/plugins/ && make -f Makefile install make[1]: Entering directory `/home/dan/rpmbuild/BUILD/communi-1.1.0/src/plugins' cd uchardet/ && make -f Makefile install make[2]: Entering directory `/home/dan/rpmbuild/BUILD/communi-1.1.0/src/plugins/uchardet' install -m 755 -p "../../../plugins/communi/libuchardetplugin.so" "/usr/lib64/qt4/plugins/communi/libuchardetplu
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #18 from Dan Mashal --- Yes. It is. I've created my own tarball and spec file based off the original one. I'll post some notes shortly. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #17 from J-P Nurmi --- I believe that tarball is actually made by GitHub. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #16 from Dan Mashal --- J-P: There are some other issues that need to be fixed upstream. $tar -zxvf communi-1.1.0.tar.gz communi-communi-68ddd57/ This should NOT extract to this dir. This should extract to communi-1.1.0/ I will try and work around this and post a better spec and tarball. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #15 from Dan Mashal --- $ licensecheck -r . ./tests/auto/ircdecoder/tst_ircdecoder.cpp: UNKNOWN ./tests/auto/ircmessage/tst_ircmessage.cpp: UNKNOWN ./tests/auto/ircsession/tst_ircsession.cpp: UNKNOWN ./tests/auto/ircparser/tst_ircparser.cpp: UNKNOWN ./tests/auto/irccommand/tst_irccommand.cpp: UNKNOWN ./tests/auto/ircsender/tst_ircsender.cpp: UNKNOWN ./src/ircutil.cpp: LGPL (v2 or later) ./src/ircdecoder.cpp: LGPL (v2 or later) ./src/ircparser.cpp: LGPL (v2 or later) ./src/plugins/declarative/plugin.cpp: LGPL (v2 or later) ./src/plugins/uchardet/plugin.cpp: LGPL (v2 or later) ./src/plugins/icu/plugin.cpp: LGPL (v2 or later) ./src/ircsender.cpp: LGPL (v2 or later) ./src/3rdparty/uchardet-0.0.1/script/win32.sh: *No copyright* UNKNOWN ./src/3rdparty/uchardet-0.0.1/script/debug.sh: *No copyright* UNKNOWN ./src/3rdparty/uchardet-0.0.1/script/release.sh: *No copyright* UNKNOWN ./src/3rdparty/uchardet-0.0.1/src/nsSBCharSetProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/LangGreekModel.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/CharDistribution.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsGB2312Prober.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/LangHebrewModel.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsCharSetProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsCharSetProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/uchardet.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEUCTWProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsSBCharSetProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/LangHungarianModel.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEscSM.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/uchardet.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsMBCSSM.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEUCJPProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsLatin1Prober.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsBig5Prober.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsSBCSGroupProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEUCKRProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/LangCyrillicModel.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsCodingStateMachine.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEUCKRProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsUniversalDetector.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEscCharsetProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsGB2312Prober.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsUniversalDetector.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/LangThaiModel.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/JpCntx.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsMBCSGroupProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsHebrewProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEUCTWProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsSBCSGroupProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/CharDistribution.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsSJISProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEUCJPProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nscore.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsLatin1Prober.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsHebrewProber.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsEscCharsetProber.h: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsUTF8Prober.cpp: MPL (v1.1) GPL (unversioned/unknown version) ./src/3rdparty/uchardet-0.0.1/src/nsBig5Prober.cpp: MPL (v1.1) GPL (unversioned
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #14 from Dan Mashal --- My bad. I was doing it on the wrong VM. It works great now. Will update the review shortly here in a second. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Rex Dieter --- missed item 3, but close enough. :) APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #13 from J-P Nurmi --- Dan, either 'qmake' or 'qmake-qt4' needs to be available in PATH, or the location of qmake needs to be specified. I've added an error message to make it a bit more clear: ERROR: Unable to find qmake. Try ./configure -qmake /path/to/qmake. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #12 from Dan Mashal --- Thanks J-P. configure has a different issue now: [dan@Fedora17 communi]$ ./configure Running qmake: -r ./communi.pro ./configure: line 111: -r: command not found -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 --- Comment #11 from Dan Mashal --- I don't know how this got marked as a security response review, and I cannot remove it, just fyi in case anyone's wondering. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 --- Comment #10 from Dan Mashal --- Sorry, forgot to bump the release version in the url: Spec URL: http://vicodan.fedorapeople.org/matespec/mate-dialogs.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-dialogs-1.4.0-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Dan Mashal changed: What|Removed |Added Keywords||Security Group||security CC||security-response-team@redh ||at.com --- Comment #9 from Dan Mashal --- Fixed. Please review. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-dialogs.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-dialogs-1.4.0-1.fc17.src.rpm I've temporarily removed libmatenotify-devel so that package will build. I will readd it later. In regards to comments 7,8 I would rather just keep a short description right now. Thanks, Dan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=844080 Dan Mashal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #34 from Dan Mashal --- New Package SCM Request === Package Name: libmatecomponent Short Description: Libraries for matecomponent package of MATE-Desktop Owners: vicodan raveit65 rdieter Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=844080 --- Comment #33 from Dan Mashal --- Fixed prior concerns, and they will be in the first koji build. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150 --- Comment #12 from Dan Mashal --- nice. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799089] Review Request: dyninst - An API for Run-time Code Generation
https://bugzilla.redhat.com/show_bug.cgi?id=799089 --- Comment #14 from Frank Ch. Eigler --- Michal, Fedora does not normally backport brand new packages into existing releases. The dyninst package being used in rawhide is already a pre-release of upstream dyninst 8.0, so we wouldn't want such a prerelease to spread even wider. (You are of course welcome to grab the .src.rpm and build it for your own machines.) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: mate-desktop Short Description: Shared code among mate-panel, mate-session, caja, etc Owners: raveit65 rdieter vicodan Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799089] Review Request: dyninst - An API for Run-time Code Generation
https://bugzilla.redhat.com/show_bug.cgi?id=799089 Michal Ambroz changed: What|Removed |Added CC||re...@seznam.cz --- Comment #13 from Michal Ambroz --- Hi please do you plan to branch for f17 ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150
leigh scott changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from leigh scott ---
APPROVED - please add isa tag to libs sub-package when you import.
%package libs
Summary: Shared libraries for libmate-desktop
License: LGPLv2+
Group: Development/Libraries
Requires: %{name}%{?_isa} = %{version}-%{release}
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[-]: MUST Package does not contain kernel modules.
[-]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
[x]: MUST Development files must be in a -devel package
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* UNKNOWN", "*No copyright* GPL (v2 or later) (with
incorrect FSF address)", "LGPL (v2 or later) (with incorrect FSF address)
GENERATED FILE", "GPL (v2 or later)", "GPL (with incorrect FSF address)",
"GPL (with incorrect FSF address) GENERATED FILE", "LGPL (v2 or later)
(with incorrect FSF address)", "*No copyright* GENERATED FILE", "MIT/X11
(BSD like)" For detailed output of licensecheck see file:
/home/leigh/844150-mate-desktop/licensecheck.txt
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5)
Note: Only applicable for E
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 --- Comment #8 from Rex Dieter --- I agree with comment #7, except leave out ", but is intended to be saner" -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 --- Comment #7 from Wolfgang Ulbrich --- (In reply to comment #6) > wrong descrition,... mate dialogs is a fork of zenity. > gdialogs is a binary of zenity, which is remove in zenity to avoid perl deps. > You could also remove this binary in mate-dialogs savely. maybe use this Summary:Display dialog boxes from shell scripts %description mate-dialogs lets you display Gtk+ dialog boxes from the command line and through shell scripts. It is similar to gdialog, but is intended to be saner. It comes from the same family as dialog, Xdialog, and cdialog. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Wolfgang Ulbrich changed: What|Removed |Added CC||chat-to...@raveit.de --- Comment #6 from Wolfgang Ulbrich --- wrong descrition,... mate dialogs is a fork of zenity. gdialogs is a binary of zenity, which is remove in zenity to avoid perl deps. You could also remove this binary in mate-dialogs savely. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150
--- Comment #9 from Wolfgang Ulbrich ---
I've add your hints in new koji scratch build
%changelog
* Sat Aug 11 2012 Wolfgang Ulbrich - 1.4.1-8
- change file section for own directories
- change 'to avoid conflicts with gnome' part
- add libs subpackage for shared libraries
* Fri Aug 03 2012 Wolfgang Ulbrich - 1.4.1-7
- add desktop file install for mate-about.desktop
- add BuildRequires desktop-file-utils
- remove BuildRequires intltool gtk-doc
* Fri Aug 03 2012 Wolfgang Ulbrich - 1.4.1-6
- start initial for fedora
- remove unnecessary buildRequires
- Drop pycairo from Requires
- change --with-pnp-ids-path="/usr/share/hwdata/pnp.ids" to
- --with-pnp-ids-path="%%{_datadir}/hwdata/pnp.ids"
* Sun Dec 25 2011 Wolfgang Ulbrich - 1.1.0-1
- mate-desktop.spec based on gnome-desktop-2.32.0-9.fc16 spec
http://koji.fedoraproject.org/koji/taskinfo?taskID=4379669
SPEC: http://raveit65.fedorapeople.org/Mate-Desktop/f19/SPECS/mate-desktop.spec
SRPM:
http://raveit65.fedorapeople.org/Mate-Desktop/f19/SRPM/mate-desktop-1.4.1-8.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830277] Review Request: wmcoincoin - Funny dock-app for browsing and interact to XML board sites
https://bugzilla.redhat.com/show_bug.cgi?id=830277 Pierre changed: What|Removed |Added Flags||needinfo?(nobody@fedoraproj ||ect.org) --- Comment #15 from Pierre --- Upstream has released a new version of this software 2.6.1 that improve UTF8 compatibility and adding xdg-open choice for default webrowser (and removing useless entries like mozilla-firefox or mozilla) I have building rpm's for this version and updating .spec and .srpm files http://pierre80.fedorapeople.org/SPECS/wmcoincoin.spec http://pierre80.fedorapeople.org/SRPMS/wmcoincoin-2.6.1-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813842] Review Request: glfw , A cross-platform multimedia library
https://bugzilla.redhat.com/show_bug.cgi?id=813842 --- Comment #13 from MERCIER Jonathan --- spec: http://bioinfornatics.fedorapeople.org/glfw.spec srpms: http://bioinfornatics.fedorapeople.org/glfw-3.0-2.fc17.src.rpm $ rpmlint ~/rpmbuild/SPECS/glfw.spec /home/builder/rpmbuild/SPECS/glfw.spec: W: invalid-url Source0: glfw-20120810git2f095cc.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/SRPMS/glfw-3.0-2.fc17.src.rpm glfw.src: W: spelling-error Summary(fr) multi -> mufti, multiple glfw.src: W: spelling-error Summary(fr_FR) multi -> mufti, multiple glfw.src: W: spelling-error %description -l en_US multi -> mulch, mufti glfw.src: W: spelling-error %description -l fr_FR multi -> mufti, multiple glfw.src: W: invalid-url Source0: glfw-20120810git2f095cc.tar.xz 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint ~/rpmbuild/RPMS/x86_64/glfw-* glfw.x86_64: W: spelling-error Summary(fr) multi -> mufti, multiple glfw.x86_64: W: spelling-error Summary(fr_FR) multi -> mufti, multiple glfw.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti glfw.x86_64: W: spelling-error %description -l fr_FR multi -> mufti, multiple glfw-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 5 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=844080
--- Comment #32 from Wolfgang Ulbrich ---
(In reply to comment #29)
> You don't need the flags here (remove --disable-static from the autogen line)
>
>
> NOCONFIGURE=1 ./autogen.sh --disable-static
>
> as you specify it in %configure
>
> %configure --disable-static
Dan, if you use NOCONFIGURE=1 the configure part of ./autogen.sh is disable.
So it doesn't matter if you use a configure flag or not at this point, because
configure called by ./autogen.sh is disable.
But it looks better if you remove this ;)
Can you add from my comment 14
3. We need a provide under main package for future packages.
Provides: libmatecomponent-activation = %{version}-%{release}
and under -devel
Provides: libmatecomponent-activation-devel = %{version}-%{release}
because.
repoquery --whatrequires libmatecomponent-activation
python-mate-matecomponent-0:1.2.0-3.fc16.i686
python-mate-matecomponent-0:1.2.0-3.fc16.x86_64
python-mate-matecomponent-0:1.4.0-1.fc16.i686
python-mate-matecomponent-0:1.4.0-1.fc16.x86_64
python-mate is a future package we need for future mate-applets.
and also point 5 we need.
Thank you for your attention
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847457] New: Review Request: rubygem-transaction-simple - Simple object transaction support for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=847457 Bug ID: 847457 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: rubygem-transaction-simple - Simple object transaction support for Ruby Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: msu...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://miroslav.suchy.cz/fedora/rubygem-transaction-simple/rubygem-transaction-simple.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-transaction-simple/rubygem-transaction-simple-1.4.0-8.fc17.src.rpm Description: Transaction::Simple provides a generic way to add active transaction support to objects. The transaction methods added by this module will work with most objects, excluding those that cannot be Marshal-ed (bindings, procedure objects, IO instances, or singleton objects). Fedora Account System Username: msuchy -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845021] Review Request: rubygem-openshift-origin-auth-mongo - OpenShift plugin for mongo authentication service
https://bugzilla.redhat.com/show_bug.cgi?id=845021 --- Comment #19 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 760696] Review Request: rubygem-mongo - Ruby driver for the MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=760696 --- Comment #23 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #5 from Rex Dieter --- ok, consider comment #3 as part of formal review then. after that, we're *real* close. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=844080
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #31 from Rex Dieter ---
So, -libs dep on the main package needs to be *not* arch'd
Requires: %{name} = %{version}-%{release}
and the main pkg and -devel should have:
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
Please fix prior to doing any koji builds (or we can sort it together
post-review if you like).
leigh's recent comments are indeed valid, but doesn't rise to the level of
review blockers... I would appreciate those issues being dealt-with prior to
doing any official fedora builds too.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150 --- Comment #8 from Rex Dieter --- Oh, if there's shared libraries at work here, I'd suggest a separate -libs pkg for those (and makes it easier to highlight the licensing as a bonus). Doing so makes dealing with multilib issues easier. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150 leigh scott changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150
--- Comment #7 from leigh scott ---
Can you change the files section to
%files -f %{po_package}.lang
%doc AUTHORS COPYING COPYING.LIB NEWS README
%{_datadir}/applications/mate-about.desktop
%doc %{_mandir}/man1/mate-about.1*
# GPL
%{_bindir}/mate-about
# LGPL
%{_libdir}/libmate-desktop-2.so.*
%{_datadir}/mate/help/*/*/*.xml
%{_datadir}/omf/mate
%{_datadir}/mate-about
%files devel
%{_libdir}/libmate-desktop-2.so
%{_libdir}/pkgconfig/*
%{_includedir}/mate-desktop-2.0
%doc %{_datadir}/gtk-doc/html/mate-desktop
As I believe this package owns these directories
%{_datadir}/omf/mate
%{_datadir}/mate-about
%{_includedir}/mate-desktop-2.0
%{_datadir}/gtk-doc/html/mate-desktop
Also just cosmetic, try this as it looks better imo
# to avoid conflicts with gnome
mkdir $RPM_BUILD_ROOT%{_datadir}/omf/mate
mv -f $RPM_BUILD_ROOT%{_datadir}/omf/{fdl,gpl,lgpl}
$RPM_BUILD_ROOT%{_datadir}/omf/mate
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847268] Review Request: girara - Simple user interface library
https://bugzilla.redhat.com/show_bug.cgi?id=847268 --- Comment #2 from François Cami --- Thanks for the comments and suggestions. Updated SRPM and SPEC: Spec URL: http://fcami.fedorapeople.org/srpms/girara.spec SRPM URL: http://fcami.fedorapeople.org/srpms/girara-0.1.3-2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: communi - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #11 from J-P Nurmi --- I have pushed some build system fixes and improvements to communi/1.1: Fix shadow build https://github.com/communi/communi/commit/64330271f7bc81e886b1aaa1d77fe856eb152453 configure: pick qmake-qt4 if qmake doesn't exist https://github.com/communi/communi/commit/b731e0a5e93756d5f1a8661e8f646f7295368810 configure: run qmake recursively To ensure fresh makefiles across the whole project tree https://github.com/communi/communi/commit/772fa7178d615e01ec085594ae5f87d520781e5c Let me know if I can help with remaining packaging issues. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970
--- Comment #13 from Jørn Lomax ---
Seems like my laptop doesn't like doing reviews. Here is the full one:
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[ ]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Note: Unversioned so-files in non-devel package (fix or
explain):lv2-synthv1-0.0.9-0.2.svn762.fc17.i686.rpm :
/usr/lib/lv2/synthv1.lv2/synthv1.so
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) GENERATED FILE", "*No copyright* GENERATED FILE", "GPL
(v2 or later)" For detailed output of licensecheck see file:
/home/makerpm/rpmbuild/REVIEW/829970-synthv1/srpm/synthv1/licensecheck.txt
[ ]: MUST License file installed when any subpackage combination is installed.
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
inc
[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=846660 Ankur Sinha (FranciscoD) changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #4 from Ankur Sinha (FranciscoD) --- Rex, Please take over the review if you want to. I won't be able to review it in the near future unfortunately. Thanks. Ankur -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846597] Review Request: gooddata-cl - GoodData integration toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=846597 --- Comment #4 from Lubomir Rintel --- Builds fine now: http://koji.fedoraproject.org/koji/taskinfo?taskID=4378939 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847302] Review Request: ezmorph - Object transformation library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=847302 Lubomir Rintel changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Flags|fedora-cvs? | Last Closed||2012-08-11 05:36:30 --- Comment #6 from Lubomir Rintel --- Ignore the CVS request please, meanwhile the package got a maintainer, thankfully. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847302] Review Request: ezmorph - Object transformation library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=847302 Lubomir Rintel changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847302] Review Request: ezmorph - Object transformation library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=847302 --- Comment #5 from Lubomir Rintel --- Package Change Request == Package Name: ezmorph Owners: lkundrak Branches: f17 f18 el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847436] New: Review Request: spherical-cow-backgrounds - Spherical Cow desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=847436 Bug ID: 847436 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: spherical-cow-backgrounds - Spherical Cow desktop backgrounds Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: martin.sour...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://mso.fedorapeople.org/packages/SPECS/spherical-cow-backgrounds.spec SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/spherical-cow-backgrounds-17.90.2-1.fc17.src.rpm Description: This package contains desktop backgrounds for the Spherical Cow theme. Fedora Account System Username: mso Note: it's practically same as most previous releases, and it's directly based on beefy-miracle-backgrounds package. The package division: -single: common files for single-screen backgrounds, -gnome: files intended for gnome DE, -xfce: files intended for XFCE, -kde: files intended for KDE, main package: pulls everything. The URL isn't functional yet, but I hope to create the wiki page soon. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847435] New: Review Request: perl-X11-Protocol-Other - Miscellaneous X11::Protocol helpers
https://bugzilla.redhat.com/show_bug.cgi?id=847435 Bug ID: 847435 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: perl-X11-Protocol-Other - Miscellaneous X11::Protocol helpers Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: robinlee.s...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://cheeselee.fedorapeople.org/perl-X11-Protocol-Other.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-X11-Protocol-Other-18-1.fc17.src.rpm Description: These are some helper functions for X11::Protocol. Fedora Account System Username: cheeselee -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=844080 --- Comment #30 from Dan Mashal --- doesnt make a difference. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845852] Review Request: littleproxy - High Performance HTTP Proxy
https://bugzilla.redhat.com/show_bug.cgi?id=845852 --- Comment #8 from gil cattaneo --- no sorry i use the library only as build requires for question about usage see here https://groups.google.com/forum/#!forum/littleproxy -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
