[Bug 847517] Review Request: php-pear-Net-DNS2 - PHP Resolver library used to communicate with a DNS server

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847517

--- Comment #2 from Remi Collet fed...@famillecollet.com ---
On our request, upstream now provides LICENSE and tests, so update to 1.2.3
https://github.com/remicollet/remirepo/commit/2f145f1f69d15eadbd555b8b228f0666882c0574

http://rpms.famillecollet.com/SRPMS/php-pear-Net-DNS2-1.2.3-1.remi.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4401290

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #30 from Gregor Tätzner gre...@freenet.de ---
looks good, except that the file names still indicate a unmodified csync. If
Andreas is ever going to package stock csync, this will generate file
conflicts.

After all comment #20 from rdieter is still valid. You can try to patch the
CMakeLists.txt files to change the names of the generated libs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806516] Review Request: python-django-annoying - Eliminate annoying things in the Django framework

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806516

Praveen Kumar kumarpraveen.nit...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 830418] Review Request: python-django-avatar - A reusable django application for handling user avatars

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=830418

--- Comment #6 from Praveen Kumar kumarpraveen.nit...@gmail.com ---
Hi,

I am not able to figure out how to do that merge, there is another dev who made
some changes for django =1.4 suport.
https://github.com/ericflo/django-avatar/pull/37 
I need some guide here to make the correct changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848213] Review Request: cqrlog - An amateur radio contact logging program

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848213

--- Comment #3 from Eric Christensen e...@christensenplace.us ---
I see where I didn't properly handle the desktop file.  I'll fix that now and
upload the new SRPM and SPEC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=840244

--- Comment #10 from pcpa paulo.cesar.pereira.de.andr...@gmail.com ---
(In reply to comment #8)

 I noticed that the configure script reports that it cannot find tiffio.h,
 even though that file is in libtiff-devel.  Do you know what's going on
 there?

Actually, it only checks for tiff34/tiffio.h and if found, it will
link to -ltiff34, otherwise, it will include tiffio.h and link to
-ltiff. The what link to is defined in configure, and the source
that uses it is surf-1.0.6/image-formats/tiffprint.cc:

#ifdef TIFF_HEADER_34
#include tiff34/tiffio.h
#else
#include tiffio.h
#endif

So, the message in config.log is a bit misleading, but is the
expected result.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845934] Review Request: wt - C++ library for developing web applications

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845934

--- Comment #15 from Robin Lee robinlee.s...@gmail.com ---
The -doc subpackage should require -devel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847755

Bastien Nocera bnoc...@redhat.com changed:

   What|Removed |Added

 CC||bnoc...@redhat.com
   Assignee|nob...@fedoraproject.org|bnoc...@redhat.com

--- Comment #3 from Bastien Nocera bnoc...@redhat.com ---
Package Review
==

Key:
- = N/A
x = Pass
! = Fail

 C/C++ 
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if present.

 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot}
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm  4.4
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macro.
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint is run on all rpms the build produces.

gstreamer1-plugins-bad-free.src: W: spelling-error Summary(en_US) GStreamer -
G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.src: W: spelling-error %description -l en_US
GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.src: W: strange-permission gst-p-bad-cleanup.sh
0775L

Make that 755 instead.

gstreamer1-plugins-bad-free.src:18: W: macro-in-comment %{version}
gstreamer1-plugins-bad-free.src: W: invalid-url Source0:
gst-plugins-bad-free-0.11.93.tar.xz
gstreamer1-plugins-bad-free.x86_64: W: spelling-error Summary(en_US) GStreamer
- G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.x86_64: W: spelling-error %description -l en_US
GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/gstreamer-1.0/libgstvideoparsersbad.so ['/usr/lib64']
gstreamer1-plugins-bad-free.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/gstreamer-1.0/libgstcamerabin2.so ['/usr/lib64']

A couple of rpaths see:
https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath

gstreamer1-plugins-bad-free.x86_64: E: incorrect-fsf-address
/usr/share/doc/gstreamer1-plugins-bad-free-0.11.93/COPYING

Please file a bug

gstreamer1-plugins-bad-free-devel.x86_64: W: spelling-error %description -l
en_US GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free-extras.x86_64: W: spelling-error %description -l
en_US GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free-extras.x86_64: W: spelling-error %description -l
en_US gstreamer - streamer, g streamer, steamer
gstreamer1-plugins-bad-free-extras.x86_64: W: 

[Bug 848209] Review Request: geany-themes - A collection of syntax highlighting color schemes for Geany

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848209

Dominic Hopf dma...@fedoraproject.org changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #2 from Dominic Hopf dma...@fedoraproject.org ---
Thanks very much for this quick review Mario! :)


New Package SCM Request
===
Package Name: geany-themes
Short Description: A collection of syntax highlighting color schemes for Geany
Owners: dmaphy
Branches: f17 f18 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845934] Review Request: wt - C++ library for developing web applications

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845934

--- Comment #16 from Robin Lee robinlee.s...@gmail.com ---
It may be better to use absolute path for the links in -examples subpackage.
Since example may generate a Sqlite db file in the same directory, but the
directory is not writable for normal user, he/she may have to copy the whole
directory to another place and then the example run properly. But then relative
symlink will break.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 830593] Review Request: perl-B-Generate - Create your own op trees

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=830593

Iain Arnell iarn...@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(iarn...@gmail.com |
   |)   |

--- Comment #4 from Iain Arnell iarn...@gmail.com ---
Spec URL: http://fedorapeople.org/~iarnell/review/perl-B-Generate.spec
SRPM URL:
http://fedorapeople.org/~iarnell/review/perl-B-Generate-1.45-1.fc19.src.rpm
Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=4401531

Indeed it did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 830593] Review Request: perl-B-Generate - Create your own op trees

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=830593

Robin Lee robinlee.s...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #5 from Robin Lee robinlee.s...@gmail.com ---
Approved by cheeselee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847755

Brian Pepple bdpep...@gmail.com changed:

   What|Removed |Added

External Bug ID||GNOME Desktop 682158

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806516] Review Request: python-django-annoying - Eliminate annoying things in the Django framework

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806516

--- Comment #12 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847435] Review Request: perl-X11-Protocol-Other - Miscellaneous X11::Protocol helpers

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847435

--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #31 from Joseph Marrero jmarr...@gmail.com ---
I made 6 patches for the CMakeLists in the package, it builds and installs ok.

NEW SRPM:
http://jmarrero.fedorapeople.org/packages/owncloud-csync/owncloud-csync-0.50.8-7.fc17.src.rpm
NEW SPEC:
http://jmarrero.fedorapeople.org/packages/owncloud-csync/owncloud-csync.spec
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4401620


All old files are in:
http://jmarrero.fedorapeople.org/packages/owncloud-csync/old/*

Please let me know if there is anything else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848209] Review Request: geany-themes - A collection of syntax highlighting color schemes for Geany

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848209

--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #32 from Joseph Marrero jmarr...@gmail.com ---
Also I made this:
https://docs.google.com/folder/d/0B0IbyJGzQiLLRXBiZVRkMTk4bWc/edit

http://koji.fedoraproject.org/koji/taskinfo?taskID=4401292

This Is mirall with csync integrated as described here:
http://owncloud.org/dev/sync-clients/linux-build/

The thing with this is that it builds just fine in Koji. But when Installing
mirall-common installs just fine but when installing owncloud-client or mirall
then I get this:

Error: Package: mirall-1.0.5-3.fc17.x86_64 (/mirall-1.0.5-3.fc17.x86_64)
   Requires: libcsync.so.0()(64bit)
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest



I checked the spec there is not csync dep there and while building CMAKE find
csync libs and builds mirall and owncloud-client just fine.

But when Installing it complains about libcsync, in the above link It says that
if I build mirall this way there is no need to install csync on the machine.

Let me know what path to pursue
and what goes better along the guidelines of fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806516] Review Request: python-django-annoying - Eliminate annoying things in the Django framework

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806516

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806516] Review Request: python-django-annoying - Eliminate annoying things in the Django framework

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806516

--- Comment #13 from Fedora Update System upda...@fedoraproject.org ---
python-django-annoying-0.7.6-3.20120609hga0de8b.fc18 has been submitted as an
update for Fedora 18.
https://admin.fedoraproject.org/updates/python-django-annoying-0.7.6-3.20120609hga0de8b.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 753577] Review Request: gmsh - finite element grid generator

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=753577

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

  Flags||needinfo?(vasyu...@gmail.co
   ||m)

--- Comment #9 from Jason Tibbitts ti...@math.uh.edu ---
Haven't seen a bundling request filed yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848209] Review Request: geany-themes - A collection of syntax highlighting color schemes for Geany

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848209

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848209] Review Request: geany-themes - A collection of syntax highlighting color schemes for Geany

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848209

--- Comment #4 from Fedora Update System upda...@fedoraproject.org ---
geany-themes-1.22-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/geany-themes-1.22-1.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 840037] Review Request:rubygem-openshift-origin-node - Application container runtime for OpenShift

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=840037

--- Comment #14 from Tom spot Callaway tcall...@redhat.com ---
Is Brenton sponsored? I'll flip the flag when the FE-NEEDSPONSOR blocker is
gone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #33 from Rex Dieter rdie...@math.unl.edu ---
Since we're changing the library soname, you'll need to rebuild mirall against
the new one (else, it still wants the old name, as you discoverred).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #6 from Gregor Tätzner gre...@freenet.de ---
Very well, the objective is now to make use of the new owncloud-csync libs. For
that you have to patch the buildsys again. I've attached a small
patch...something in this way should do the job

And can you comment please on that BuildReq to xinetd?

(In reply to comment #5)
 asked uptream about the posiblity of moving /etc/exclude.lst to
 /etc/mirall/exclude.lst and adding versioning to the libs.
excellent

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #7 from Gregor Tätzner gre...@freenet.de ---
Created attachment 605354
  -- https://bugzilla.redhat.com/attachment.cgi?id=605354action=edit
lib rename patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #34 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #32)
 Also I made this:
 https://docs.google.com/folder/d/0B0IbyJGzQiLLRXBiZVRkMTk4bWc/edit
 
 http://koji.fedoraproject.org/koji/taskinfo?taskID=4401292
 
 This Is mirall with csync integrated as described here:
 http://owncloud.org/dev/sync-clients/linux-build/

Actually this is not about integrating csync into mirall (in other terms:
linking the csync lib statically). That page just describes how you can build
mirall without having to install the csync devel files system wide.
Nevertheless you would need libcsync at runtime in libdir. And thats your
problem here: rpm detects the runtime deps of mirall but can't find libcsync
(and libocsync is not suitable because you build mirall against libcsync)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #35 from Gregor Tätzner gre...@freenet.de ---
apart from that, please mark the doc packages as NoArch. just html stuff in
there

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #36 from Joseph Marrero jmarr...@gmail.com ---
Ok,
I will continue the path of creating the owncloud-csync and mirall packages
separate, doing the last build of owncloud-csync to mark NoArch the docs and
moving to mirall.

Let me know what else is needed to pass the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

--- Comment #37 from Rex Dieter rdie...@math.unl.edu ---
Ok, I'll do the formal review, since no one's assigned the bug or set the
review flag yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rdie...@math.unl.edu
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

--- Comment #8 from Rex Dieter rdie...@math.unl.edu ---
I'll do the formal review today, since no one's assigned the bug or set the
review flag yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847513] Review Request: librasterlite - Support Raster Data Sources within a SpatiaLite DB

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847513

--- Comment #2 from Volker Fröhlich volke...@gmx.at ---
Thanks a lot for noticing this! I had libspatialite built with coverage
profiling, which led to this problem. The current libspatialite build solves
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #38 from Joseph Marrero jmarr...@gmail.com ---
Added NoArch to the doc packages builded all OK :)

NEW SRPM:
http://jmarrero.fedorapeople.org/packages/owncloud-csync/owncloud-csync-0.50.8-8.fc17.src.rpm
NEW SPEC:
http://jmarrero.fedorapeople.org/packages/owncloud-csync/owncloud-csync.spec

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4401867

All old files are in:
http://jmarrero.fedorapeople.org/packages/owncloud-csync/old/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 843695] Review Request: gecode - Generic constraint development environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=843695

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m

--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4401812


$ rpmlint -i -v *
gecode.i686: I: checking
gecode.i686: I: checking-url http://www.gecode.org/ (timeout 10 seconds)
gecode.i686: W: shared-lib-calls-exit /usr/lib/libgecodegist.so.32.0
exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

gecode.i686: W: shared-lib-calls-exit /usr/lib/libgecodeflatzinc.so.32.0
exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

gecode.i686: W: shared-lib-calls-exit /usr/lib/libgecodedriver.so.32.0
exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

gecode.src: I: checking
gecode.src: I: checking-url http://www.gecode.org/ (timeout 10 seconds)
gecode.src: I: checking-url http://www.gecode.org/download/gecode-3.7.3.tar.gz
(timeout 10 seconds)
gecode.x86_64: I: checking
gecode.x86_64: I: checking-url http://www.gecode.org/ (timeout 10 seconds)
gecode.x86_64: W: shared-lib-calls-exit /usr/lib64/libgecodeflatzinc.so.32.0
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

gecode.x86_64: W: shared-lib-calls-exit /usr/lib64/libgecodedriver.so.32.0
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

gecode.x86_64: W: shared-lib-calls-exit /usr/lib64/libgecodegist.so.32.0
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

gecode-debuginfo.i686: I: checking
gecode-debuginfo.i686: I: checking-url http://www.gecode.org/ (timeout 10
seconds)
gecode-debuginfo.x86_64: I: checking
gecode-debuginfo.x86_64: I: checking-url http://www.gecode.org/ (timeout 10
seconds)
gecode-devel.i686: I: checking
gecode-devel.i686: I: checking-url http://www.gecode.org/ (timeout 10 seconds)
gecode-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

gecode-devel.i686: W: no-manual-page-for-binary fz
Each executable in standard binary directories should have a man page.

gecode-devel.i686: W: no-manual-page-for-binary mzn-gecode
Each executable in standard binary directories should have a man page.

gecode-devel.x86_64: I: checking
gecode-devel.x86_64: I: checking-url 

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+

--- Comment #39 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

sources: ok
$ md5sum *.bz2
322f6fa22ca0e8cd05f23dc0d075e7ca  csync-0.50.8.tar.bz2

licensing: ok

macros: ok

scriptlets: ok

builds/installs: ok

thanks, looks good now.


APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

Joseph Marrero jmarr...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
  Flags|fedora-review+  |fedora-review?, fedora-cvs?

--- Comment #40 from Joseph Marrero jmarr...@gmail.com ---
New Package SCM Request
===
Package Name: owncloud-csync
Short Description: a file synchroniser utility
Owners: jmarrero
Branches: f17 f18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845743

--- Comment #10 from Lameire Alexis alexisis-pristont...@hotmail.com ---
New Package SCM Request
===
Package Name: adobe-source-sans-pro-fonts
Short Description: A set of OpenType fonts designed for user interfaces
Owners: alexises
Branches: f16 f17 f18
InitialCC: fonts-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845743

Lameire Alexis alexisis-pristont...@hotmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806516] Review Request: python-django-annoying - Eliminate annoying things in the Django framework

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806516

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #14 from Fedora Update System upda...@fedoraproject.org ---
python-django-annoying-0.7.6-3.20120609hga0de8b.fc18 has been pushed to the
Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848209] Review Request: geany-themes - A collection of syntax highlighting color schemes for Geany

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848209

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #5 from Fedora Update System upda...@fedoraproject.org ---
geany-themes-1.22-1.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #9 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

sources: ok
$ md5sum mirall*.bz2
b7a96411f092bb16f88e3868a558032f  mirall-1.0.5.tar.bz2

1. MUST: build fails, currently does not build against the renamed
owncloud-csync, will need some variant of  the patch from comment #7

2. MUST: missing icon scriptlets for owncloud-client subpkg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #10 from Rex Dieter rdie...@math.unl.edu ---
oh,  and please document/justify (or remove) the following dependencies:
BuildRequires: inet
Requires: iproute
Requires: oxygen-icon-theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845696] Review Request: mate-screensaver - mate-screensaver

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845696

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Blocks||840149 (MATE-DE-tracker)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 840149] Tracker for MATE packages

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=840149

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Depends On||845696 (mate-screensaver)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847345] Review Request: libmatecanvas - MateCanvas widget

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847345

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Blocks||847173 (libmatecomponentui)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847173] Review Request: libmatecomponentui - Libmatecomponent user interface components

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847173

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Depends On||847345 (libmatecanvas)
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847901] Review Request: spamprobe - A Bayesian spam filter

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847901

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?

--- Comment #3 from Kevin Fenzi ke...@scrye.com ---
Look for a review on this hopefully later today...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849200] Review Request: connman - A daemon for managing internet connections on Linux

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849200

--- Comment #5 from Pavel Simerda psime...@redhat.com ---
Spec URL: http://data.pavlix.net/fedora/connman.spec
SRPM URL: data.pavlix.net/fedora/connman-1.5-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847901] Review Request: spamprobe - A Bayesian spam filter

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847901

--- Comment #4 from Kevin Fenzi ke...@scrye.com ---
Some general comments/suggestions/changes before the review: 

1. Please don't define %{prefix}

2. (not a blocker, but IMHO a good idea) consider using the dist tag on your
version
http://fedoraproject.org/wiki/Packaging:DistTag

3. If you can avoid using %makeinstall that would be good. See: 
http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

4. I'm assuming upstream releases packages in a post release a, b, c, d, way
right? 
If so, then your version is fine. If not you may want to look at: 
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages
and add a note/comment in the spec about what upstream does here. ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849200] Review Request: connman - A daemon for managing internet connections on Linux

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849200

--- Comment #6 from Pavel Simerda psime...@redhat.com ---
 - %{_includedir}/connman/ is unowned

Fixed.

 - Various scriptlets are wrong :
 %systemd_preun apache-httpd.service

Bad copy-pasting from wiki. Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849200] Review Request: connman - A daemon for managing internet connections on Linux

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849200

--- Comment #7 from Pavel Simerda psime...@redhat.com ---
Forget about these... will issue a new version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848353] Review Request: python-pthreading - Re-implement threading.Lock, RLock and Condition with libpthread

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848353

--- Comment #3 from Dan Kenigsberg dan...@redhat.com ---
Pierre, thanks for your review. Would you give it another round?

http://danken.fedorapeople.org/python-pthreading-0.1.1-2.fc16.src.rpm
http://danken.fedorapeople.org/python-pthreading.spec

I've fixed the fsf address upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849200] Review Request: connman - A daemon for managing internet connections on Linux

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849200

--- Comment #8 from Pavel Simerda psime...@redhat.com ---
 - license is not shipped with the rpms

Fixed.

 - there is a test suite shipped with connman, could it be run in %check 

I've looked at the tests directory and the tests actually seem to be intended
for manual run time testing, not automatic build time testing.

New build:

Spec: http://data.pavlix.net/fedora/connman.spec
SRPM: http://data.pavlix.net/fedora/connman-1.5-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #11 from Joseph Marrero jmarr...@gmail.com ---
Spec URL: http://jmarrero.fedorapeople.org/packages/mirall/mirall.spec
SRPM URL:
http://jmarrero.fedorapeople.org/packages/mirall/mirall-1.0.5-3.fc17.src.rpm

http://jmarrero.fedorapeople.org/packages/mirall/old/*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #12 from Rex Dieter rdie...@math.unl.edu ---
licensing: ok

scriptlets:  ok

macros: ok

3. SHOULD remove 
-DCMAKE_INSTALL_PREFIX=%{_prefix} -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir}
the default %cmake macro already includes these

otherwise, good work.  3 can be fixed post-review.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

Joseph Marrero jmarr...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?, fedora-cvs?

--- Comment #13 from Joseph Marrero jmarr...@gmail.com ---
New Package SCM Request
===
Package Name: mirall
Short Description: owncloud desktop client
Owners: jmarrero
Branches: f17 f18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849379] New: Review Request: graphite-web - A Django webapp for enterprise scalable realtime graphing

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849379

Bug ID: 849379
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: graphite-web - A Django webapp for
enterprise scalable realtime graphing
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: jonathanstef...@gmail.com
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL: http://jsteffan.fedorapeople.org/SPECS/graphite-web.spec
SRPM URL:
http://jsteffan.fedorapeople.org/SRPMS/graphite-web-0.9.10-1.fc17.src.rpm
Description:
Graphite consists of a storage backend and a web-based visualization frontend.
Client applications send streams of numeric time-series data to the Graphite
backend (called carbon), where it gets stored in fixed-size database files
similar in design to RRD. The web frontend provides user interfaces
for visualizing this data in graphs as well as a simple URL-based API for
direct graph generation.

Graphite's design is focused on providing simple interfaces (both to users and
applications), real-time visualization, high-availability, and enterprise
scalability.

Fedora Account System Username: jsteffan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849380] New: Review Request: python-carbon - Back-end data caching and persistence daemon for Graphite

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849380

Bug ID: 849380
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: python-carbon - Back-end data caching
and persistence daemon for Graphite
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: jonathanstef...@gmail.com
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL: http://jsteffan.fedorapeople.org/SPECS/python-carbon.spec
SRPM URL:
http://jsteffan.fedorapeople.org/SRPMS/python-carbon-0.9.10-1.fc17.src.rpm
Description:
Twisted daemon that listens for time-series data and writes this data
out to whisper databases, relays the data or aggregates the data.
Carbon is a data collection and storage agent.

Fedora Account System Username: jsteffan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849381] New: Review Request: python-whisper - Simple database library for storing time-series data

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849381

Bug ID: 849381
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: python-whisper - Simple database
library for storing time-series data
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: jonathanstef...@gmail.com
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL: http://jsteffan.fedorapeople.org/SPECS/python-whisper.spec
SRPM URL:
http://jsteffan.fedorapeople.org/SRPMS/python-whisper-0.9.10-1.fc17.src.rpm
Description: simple database library for storing time-series data (similar in
design to RRD)
Fedora Account System Username: jsteffan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849382] New: Review Request: python-bucky - CollectD and StatsD adapter for Graphite

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849382

Bug ID: 849382
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: python-bucky - CollectD and StatsD
adapter for Graphite
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: jonathanstef...@gmail.com
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL: http://jsteffan.fedorapeople.org/SPECS/python-bucky.spec
SRPM URL:
http://jsteffan.fedorapeople.org/SRPMS/python-bucky-0.2.2-1.fc17.src.rpm
Description: 
Bucky is a small server for collecting and translating metrics for
Graphite. It can current collect metric data from CollectD daemons
and from StatsD clients.

Fedora Account System Username: jsteffan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847419] Review request: mate-polkit - Integrates polkit with the MATE Desktop environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847419

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

--- Comment #1 from Rex Dieter rdie...@math.unl.edu ---
I  can review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847684] Review Request: mate-notification-daemon - Notification daemon for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847684

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847697

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

--- Comment #1 from Rex Dieter rdie...@math.unl.edu ---
I can review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847697

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #2 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

sources: ok
$ md5sum *.xz
225a2ce7672c2a236c3b7d01da95af5a  mate-backgrounds-1.4.0.tar.xz

licensing

1 SHOULD remove
BuildRequires: mate-conf-devel mate-corba-devel
these aren't needed (builds ok for me without these)

macros: mostly ok, except for:

2. SHOULD not  use undefined macro po_package, change
%find_lang %{po_package} --all-name
...
%files -f %{po_package}.lang

to
%find_lang %{name} --all-name
...
%files -f %{name}.lang

3. SHOULD:  dir /usr/share/pixmaps/backgrounds seems unowned.  mind either
owning this here too, or consider if it's possible to move
/usr/share/pixmaps/backgrounds/mate
to 
/usr/share/backgrounds/mate
to be closer to how gnome does things?  (fwiw, kde uses /usr/share/wallpapers)

scriptlets: ok (n/a)


fairly good and simple, APPROVED.

please address items 1-3 prior to doing any builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=817315

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-08-18 20:26:43

--- Comment #41 from Fedora Update System upda...@fedoraproject.org ---
megaglest-3.6.0.3-5.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=817315

--- Comment #42 from Fedora Update System upda...@fedoraproject.org ---
megaglest-3.6.0.3-5.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 842667] Review Request: simple - Asynchronous HTTP server for Java

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=842667

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-08-18 20:28:02

--- Comment #15 from Fedora Update System upda...@fedoraproject.org ---
simple-4.1.21-3.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 828544] Review Request: megaglest-data - Mega Glest data files

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=828544

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-08-18 20:28:13

--- Comment #20 from Fedora Update System upda...@fedoraproject.org ---
megaglest-data-3.6.0.3-3.fc17 has been pushed to the Fedora 17 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847419] Review request: mate-polkit - Integrates polkit with the MATE Desktop environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847419

--- Comment #2 from Rex Dieter rdie...@math.unl.edu ---
1.  SHOULD remove
BuildRequires: gtk+-devel
it's not needed

naming: ok

licensing: ok

sources: ok
md5sum *.xz
7eccae36af5f9ee0e38a569fcd34e395  mate-polkit-1.4.0.tar.xz

macros: ok

scriptlets: mostly ok

SHOULD: remove 
update-desktop-database  /dev/null || :
scriptlets, not needed here.

2.  -devel MUST own %{_includedir}/polkit-gtk-mate-1/ (and polkitgtkmate
subdir)

imo, replace
%{_includedir}/polkit-gtk-mate-1/polkitgtkmate/polkitgtkmate.h
%{_includedir}/polkit-gtk-mate-1/polkitgtkmate/polkitgtkmatetypes.h
%{_includedir}/polkit-gtk-mate-1/polkitgtkmate/polkitlockbutton.h
with just
%{_includedir}/polkit-gtk-mate-1/

3. SHOULD drop dup'd
%doc
statement in -devel subpkg

4. SHOULD add
Provides: PolicyKit-authentication-agent
to  match other policy kit providers (like gnome-polkit, polkit-kde)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 816071] Review Request: f3 - Utility to test for fake flash drives and cards

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=816071

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-08-18 20:28:59

--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
f3-2-2.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 828544] Review Request: megaglest-data - Mega Glest data files

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=828544

--- Comment #21 from Fedora Update System upda...@fedoraproject.org ---
megaglest-data-3.6.0.3-3.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847684] Review Request: mate-notification-daemon - Notification daemon for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847684

--- Comment #1 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

1.  SHOULD move
NOCONFIGURE=1 ./autogen.sh
to  %setup section

2. MUST not use undefined macro %po_package, either  define it or use %{name}
instead

3. SHOULD add
Provides: desktop-notification-daemon
(assuming it provides dbus service org.freedesktop.Notifications like kde's
knotify or gnome's notification-daemon)

4. SHOULD consider dropping -libs subpkg, I don't see any shared libraries in
use here, so
%files libs
%{_libdir}/mate-notification-daemon/
could probably just be folded into the main package.

licensing: ok

sources: ok
md5sum *.xz
83956e38caeec78634af379abc1b5787  mate-notification-daemon-1.4.0.tar.xz

scriptlets: ok

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823962] Review Request: apacheds-shared - Shared APIs of Apache Directory Project

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=823962

Matt Spaulding mspauldin...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #1 from Matt Spaulding mspauldin...@gmail.com ---
RPMLint Output:

apacheds-shared.noarch: W: spelling-error %description -l en_US embeddable -
embedded
apacheds-shared.src: W: spelling-error %description -l en_US embeddable -
embedded
apacheds-shared.src: W: invalid-url Source0:
apacheds-shared-0.9.19-src-svn.tar.gz
/home/mspaulding/rpmbuild/SPECS/apacheds-shared.spec: W: invalid-url Source0:
apacheds-shared-0.9.19-src-svn.tar.gz
3 packages and 1 specfiles checked; 0 errors, 4 warnings.


 Generic 
[x]: EXTRA Rpmlint is run on all installed packages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: MUST Sources contain only permissible code or content.
[-]: MUST Each %files section contains %defattr if rpm  4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc. [1]
[x]: MUST License field in the package spec file matches the actual license.
[2]
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL. [1]
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
 upstream.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL. [1]
[-]: SHOULD Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
 architectures.
[-]: SHOULD %check is present and all tests pass. [3]
[x]: SHOULD Packages should try to preserve timestamps of original installed
 files.
[x]: SHOULD Spec use %global 

[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845743

--- Comment #11 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848208] Review Request: owncloud-csync - a file synchroniser utility

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848208

--- Comment #41 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 848211] Review Request: mirall - owncloud desktop client

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=848211

--- Comment #14 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847684] Review Request: mate-notification-daemon - Notification daemon for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847684

--- Comment #2 from Dan Mashal dan.mas...@gmail.com ---
Fixed.

Spec URL:
http://vicodan.fedorapeople.org/matespec/mate-notification-daemon.spec
SRPM URL:
http://vicodan.fedorapeople.org/materpms/srpms/mate-notification-daemon-1.4.0-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847419] Review request: mate-polkit - Integrates polkit with the MATE Desktop environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847419

--- Comment #3 from Dan Mashal dan.mas...@gmail.com ---
Fixed:



Spec URL: http://vicodan.fedorapeople.org/matespec/mate-polkit.spec
SRPM URL:
http://vicodan.fedorapeople.org/materpms/srpms/mate-polkit-1.4.0-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847684] Review Request: mate-notification-daemon - Notification daemon for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847684

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #3 from Rex Dieter rdie...@math.unl.edu ---
Noticed some small  errors in scriptlets now too (sorry):

%pre
%gconf_schema_prepare
%{buildroot}/%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas

%post -p /sbin/ldconfig
/usr/bin/update-desktop-database /dev/null || :
/bin/touch --no-create %{_datadir}/icons/mate /dev/null || :
%gconf_schema_upgrade
%{buildroot}/%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas

%postun -p /sbin/ldconfig
/usr/bin/update-desktop-database /dev/null || :
%gconf_schema_remove
%{buildroot}/%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
/usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor /dev/null ||
:
fi

%posttrans
/usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor /dev/null || :

should be (something like):

%pre
%gconf_schema_prepare
%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas

%post
/usr/bin/update-desktop-database /dev/null || :
/bin/touch --no-create %{_datadir}/icons/mate /dev/null || :
%gconf_schema_upgrade
%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas

%postun
/usr/bin/update-desktop-database /dev/null || :
%gconf_schema_remove
%{_sysconfdir}/mateconf/schemas/mate-notification-daemon.schemas
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
/usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor /dev/null ||
:
fi

%posttrans
/usr/bin/gtk-update-icon-cache -f %{_datadir}/icons/hicolor /dev/null || :


please fix that prior to submitting any builds.



APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847697

Dan Mashal dan.mas...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #3 from Dan Mashal dan.mas...@gmail.com ---
New Package SCM Request
===
Package Name: mate-backgrounds
Short Description: Backgrounds for MATE Desktop
Owners: vicodan raveit65 rdieter
Branches: f16 f17 f18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847419] Review request: mate-polkit - Integrates polkit with the MATE Desktop environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847419

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #4 from Rex Dieter rdie...@math.unl.edu ---
there's still an extra
update-desktop-database  /dev/null || :
scriptlet, please remove that before doing any builds.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847419] Review request: mate-polkit - Integrates polkit with the MATE Desktop environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847419

--- Comment #5 from Dan Mashal dan.mas...@gmail.com ---
Fixed that. Thanks Rex.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847419] Review request: mate-polkit - Integrates polkit with the MATE Desktop environment

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847419

Dan Mashal dan.mas...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #6 from Dan Mashal dan.mas...@gmail.com ---
New Package SCM Request
===
Package Name: mate-polkit
Short Description: Integrates polkit with the MATE Desktop environment 
Owners: vicodan rdieter raveit65
Branches: f16 f17 18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847684] Review Request: mate-notification-daemon - Notification daemon for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847684

--- Comment #4 from Dan Mashal dan.mas...@gmail.com ---
Fixed that. Thanks Rex.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847684] Review Request: mate-notification-daemon - Notification daemon for MATE Desktop

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847684

Dan Mashal dan.mas...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #5 from Dan Mashal dan.mas...@gmail.com ---
New Package SCM Request
===
Package Name: mate-notification-daemon
Short Description: Notification daemon for MATE Desktop
Owners: vicodan rdieter raveit65
Branches: f16 f17 18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847345] Review Request: libmatecanvas - MateCanvas widget

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847345

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847345] Review Request: libmatecanvas - MateCanvas widget

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847345

--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
libmatecanvas-1.4.0-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libmatecanvas-1.4.0-6.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847345] Review Request: libmatecanvas - MateCanvas widget

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847345

--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
libmatecanvas-1.4.0-6.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libmatecanvas-1.4.0-6.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847643] Review Request: libmateweather - Libraries to allow MATE Desktop to display weather information

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847643

--- Comment #3 from Dan Mashal dan.mas...@gmail.com ---
Fixed.

Spec URL: http://vicodan.fedorapeople.org/matespec/libmateweather.spec
SRPM URL:
http://vicodan.fedorapeople.org/materpms/srpms/libmateweather-1.4.0-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 840149] Tracker for MATE packages

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=840149

Dan Mashal dan.mas...@gmail.com changed:

   What|Removed |Added

 Depends On|847725  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847725] Review Request: mate-window-manager - MATE Desktop window manager

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=847725

Dan Mashal dan.mas...@gmail.com changed:

   What|Removed |Added

 Blocks|840149 (MATE-DE-tracker)|
 Depends On|846660 (mate-dialogs)   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 846660] Review Request: mate-dialogs -- Display dialog boxes from shell scripts

2012-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=846660

Dan Mashal dan.mas...@gmail.com changed:

   What|Removed |Added

 Blocks|847725  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review