[Bug 849026] Review Request: jam-control - audioserver gui app
https://bugzilla.redhat.com/show_bug.cgi?id=849026 --- Comment #12 from Jørn Lomax northlo...@gmail.com --- I added pulseaudio to the requirements Spec URL: http://jvlomax.fedorapeople.org/jam-control.spec SRPM URL: http://jvlomax.fedorapeople.org/jam-control-1.01-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #15 from Jørn Lomax northlo...@gmail.com --- No problem, happy to be of assistance * This package is APPROVED* * -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847867] Review Request: julius - Large vocabulary continuous speech recognition (LVCSR) decoder software
https://bugzilla.redhat.com/show_bug.cgi?id=847867
Randall Randy Berry randyn3...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||randyn3...@gmail.com
Assignee|nob...@fedoraproject.org|randyn3...@gmail.com
Flags||fedora-review?
--- Comment #1 from Randall Randy Berry randyn3...@gmail.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see below).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines. Julius (https://fedoraproject.org/wiki/Licensing/Julius)
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package contains desktop file if it is a GUI application.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
zlib/libpng, MIT/X11 (BSD like) For detailed output of licensecheck
see file: /home/rberry/Fedora-Review/847867-julius/licensecheck.txt
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
Note: Upstream SHA256SUM check error
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #15 from Miroslav Suchý msu...@redhat.com --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Miroslav Suchý msu...@redhat.com --- New Package SCM Request === Package Name: spacewalk-setup-jabberd Short Description: Tools to setup jabberd for Spacewalk Owners: msuchy Branches: F-18, F-17, F-16, EL-6, EL-5 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852211] Review Request: dunst - dmenu-ish lightweight notification-daemon
https://bugzilla.redhat.com/show_bug.cgi?id=852211 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? --- Comment #1 from Petr Šabata psab...@redhat.com --- Taking the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852326] New: Review Request: powerpc-utils-python - python utilities for PowerPC systems
https://bugzilla.redhat.com/show_bug.cgi?id=852326 Bug ID: 852326 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: powerpc-utils-python - python utilities for PowerPC systems Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: lnyk...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://lnykryn.fedorapeople.org/powerpc-utils-python/powerpc-utils-python.spec SRPM URL: http://lnykryn.fedorapeople.org/powerpc-utils-python/powerpc-utils-python-1.2.1-1.fc16.src.rpm Description: Python based utilities for maintaining and servicing PowerPC systems. Fedora Account System Username: lnykryn -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852329] New: Review Request: vdsm-hooks - Virtual Desktop Server Manager Hooks
https://bugzilla.redhat.com/show_bug.cgi?id=852329 Bug ID: 852329 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: vdsm-hooks - Virtual Desktop Server Manager Hooks Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: fsimo...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://fsimonce.fedorapeople.org/vdsm-hooks/vdsm-hooks.spec SRPM URL: http://fsimonce.fedorapeople.org/vdsm-hooks/vdsm-hook-4.9.6-0.fc17.src.rpm Description: Virtual Desktop Server Manager Hooks Fedora Account System Username: fsimonce Branch: EL-6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852330] New: Review Request: hibernate4 - Relational persistence and query service
https://bugzilla.redhat.com/show_bug.cgi?id=852330 Bug ID: 852330 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: hibernate4 - Relational persistence and query service Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/hibernate4.spec SRPM URL: http://gil.fedorapeople.org/hibernate4-4.1.6-1.fc16.src.rpm Description: Hibernate is a powerful, ultra-high performance object/relational persistence and query service for Java. Hibernate lets you develop persistent objects following common Java idiom - including association, inheritance, polymorphism, composition and the Java collections framework. Extremely fine-grained, richly typed object models are possible. The Hibernate Query Language, designed as a minimal object-oriented extension to SQL, provides an elegant bridge between the object and relational worlds. Hibernate is now the most popular ORM solution for Java. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||852330 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852330] Review Request: hibernate4 - Relational persistence and query service
https://bugzilla.redhat.com/show_bug.cgi?id=852330 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||809950, 845540 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 809950] Review Request: gradle - Groovy based build system
https://bugzilla.redhat.com/show_bug.cgi?id=809950 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||852330 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852330] Review Request: hibernate4 - Relational persistence and query service
https://bugzilla.redhat.com/show_bug.cgi?id=852330 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845057] Review Request: perl-Sub-Exporter-Progressive - Only use Sub::Exporter if you need it
https://bugzilla.redhat.com/show_bug.cgi?id=845057 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845057] Review Request: perl-Sub-Exporter-Progressive - Only use Sub::Exporter if you need it
https://bugzilla.redhat.com/show_bug.cgi?id=845057 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Sub-Exporter-Progressive-0.001006-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Sub-Exporter-Progressive-0.001006-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845057] Review Request: perl-Sub-Exporter-Progressive - Only use Sub::Exporter if you need it
https://bugzilla.redhat.com/show_bug.cgi?id=845057 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- perl-Sub-Exporter-Progressive-0.001006-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Sub-Exporter-Progressive-0.001006-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845057] Review Request: perl-Sub-Exporter-Progressive - Only use Sub::Exporter if you need it
https://bugzilla.redhat.com/show_bug.cgi?id=845057 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Sub-Exporter-Progressive-0.001006-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Sub-Exporter-Progressive-0.001006-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845057] Review Request: perl-Sub-Exporter-Progressive - Only use Sub::Exporter if you need it
https://bugzilla.redhat.com/show_bug.cgi?id=845057 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-Sub-Exporter-Progressive-0.001006-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Sub-Exporter-Progressive-0.001006-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845057] Review Request: perl-Sub-Exporter-Progressive - Only use Sub::Exporter if you need it
https://bugzilla.redhat.com/show_bug.cgi?id=845057 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- perl-Sub-Exporter-Progressive-0.001006-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Sub-Exporter-Progressive-0.001006-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #2 from mahaveer darade mdar...@redhat.com --- Done. All the changes suggested in comment#1 are in-place below are new rpmlint logs. [root@mdarade guest]# rpmlint -i liblognorm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i liblognorm-0.3.4-2.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i liblognorm*x86_64*.rpm liblognorm-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. liblognorm-utils.x86_64: W: spelling-error Summary(en_US) Normalizer - Normalize, Normalizes, Normalized The value of this tag appears to be misspelled. Please double-check. liblognorm-utils.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. liblognorm-utils.x86_64: W: no-manual-page-for-binary normalizer Each executable in standard binary directories should have a man page. 4 packages and 0 specfiles checked; 0 errors, 4 warnings. [root@mdarade guest]# -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Brendan Jones brendan.jones...@gmail.com --- Thanks for the review! New Package SCM Request === Package Name: synthv1 Short Description: 4 oscillator subtractive polyphonic synthesizer Owners: bsjones Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mizde...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817779] Review Request: thunderbird-enigmail - Authentication and encryption extension for Mozilla Thunderbird
https://bugzilla.redhat.com/show_bug.cgi?id=817779 --- Comment #9 from Remi Collet fed...@famillecollet.com --- Update for Thunderbird 15.0 http://cvs.rpmfusion.org/viewvc/rpms/thunderbird-enigmail/devel/thunderbird-enigmail.spec?root=freer1=1.26r2=1.27view=patch -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 652987] Review Request: go - The Go programming language
https://bugzilla.redhat.com/show_bug.cgi?id=652987 --- Comment #59 from Renich Bon Ciric ren...@woralelandia.com --- is anybody working on this one? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 757156] Review Request: perl-Env-C - Get/Set/Unset Environment Variables on the C level
https://bugzilla.redhat.com/show_bug.cgi?id=757156 Paul Howarth p...@city-fan.org changed: What|Removed |Added Flags||needinfo?(k...@fi.muni.cz) --- Comment #19 from Paul Howarth p...@city-fan.org --- Jan, are you still interested in this package? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #3 from mahaveer darade mdar...@redhat.com --- Done. I have worked on all 3 suggestions and changes are in-place. Below is new SRPM link: http://siddharths.fedorapeople.org/mahaveer/SRPMS/libee-0.4.1-2.fc15.src.rpm Below are new rpmlint logs. [root@mdarade guest]# rpmlint -i libee.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i libee-0.4.1-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i libee-*.x86_64.rpm libee-devel.x86_64: W: spelling-error %description -l en_US rsyslog - serology The value of this tag appears to be misspelled. Please double-check. libee-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libee-utils.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libee-utils.x86_64: W: no-manual-page-for-binary libee-convert Each executable in standard binary directories should have a man page. 4 packages and 0 specfiles checked; 0 errors, 4 warnings. [root@mdarade guest]# -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #3 from mahaveer darade mdar...@redhat.com --- Forgot to mention updated link to SRPM so here it is: http://theinric.fedorapeople.org/liblognorm/liblognorm-0.3.4-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847817] Review Request: libestr - A library to handle strings
https://bugzilla.redhat.com/show_bug.cgi?id=847817 --- Comment #3 from mahaveer darade mdar...@redhat.com --- Done. Here are links to updated SPEC SRPM: http://siddharths.fedorapeople.org/mahaveer/SPECS/libestr.spec http://siddharths.fedorapeople.org/mahaveer/SRPMS/libestr-0.1.3-2.fc15.src.rpm Below are new rpmlint logs: [root@mdarade guest]# rpmlint -i libestr.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i libestr-0.1.3-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i libestr-*x86_64.rpm libestr-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 3 packages and 0 specfiles checked; 0 errors, 1 warnings. [root@mdarade guest]# -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] New: Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 Bug ID: 852416 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: pangox-compat - Compatibility library for pangox Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: pnem...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/pangox-compat.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/pangox-compat-0.0.1-1.fc17.src.rpm Description: This is a compatibility library providing the obsolete pangox library that is not shipped by Pango itself anymore. Fedora Account System Username: pnemade -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 --- Comment #1 from Parag pnem...@redhat.com --- koji scratch build - http://koji.fedoraproject.org/koji/taskinfo?taskID=4429668 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829038] Review Request: drupal6-freelinking - Freelinking module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=829038 --- Comment #3 from Anderson Silva ansi...@redhat.com --- the reason there is a different license is because the origianl LICENSE shipped from upstream contains the incorrect mailing address for the FSF which actually throws an error by rpmlint. I think the error is: E: incorrect-fsf-address -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829030] Review Request: drupal6-flag - Flag module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=829030 --- Comment #4 from Anderson Silva ansi...@redhat.com --- the reason there is a different license is because the origianl LICENSE shipped from upstream contains the incorrect mailing address for the FSF which actually throws an error by rpmlint. I think the error is: E: incorrect-fsf-address. I have already released several rpms with this kind of fix, I believe it was what I was told that needed to be done. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845769] Review Request: emacs-undo-tree - Treats undo history as a tree of changes
https://bugzilla.redhat.com/show_bug.cgi?id=845769 Sébastien Willmann sebastien.willm...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Sébastien Willmann sebastien.willm...@gmail.com --- New Package SCM Request === Package Name: emacs-undo-tree Short Description: Treats undo history as a tree of changes Owners: wilqu Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847867] Review Request: julius - Large vocabulary continuous speech recognition (LVCSR) decoder software
https://bugzilla.redhat.com/show_bug.cgi?id=847867 --- Comment #2 from Tom spot Callaway tcall...@redhat.com --- Hmm, I think that Source verification check failed because I didn't get the Source0 URL right. I've fixed it in -2. The SHA256SUM I get from julius-4.2.2.tar.gz is: f53caf18be4fb8266b988071855565dccb78c09f00f1d36a8e258b7be6b3cef5 (Which matches what I had before, so I'm thinking the review tool just blindly compared a 404 HTML download to the tarball. :) ) New SRPM: http://spot.fedorapeople.org/julius-4.2.2-2.fc17.src.rpm New Spec URL: http://spot.fedorapeople.org/julius.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 Sébastien Willmann sebastien.willm...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Sébastien Willmann sebastien.willm...@gmail.com --- New Package SCM Request === Package Name: emacs-goto-chg Short Description: Emacs add-on to go to last change in current buffer Owners: wilqu Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851859] Review Request: mana - Opensource 2D MMORPG platform client
https://bugzilla.redhat.com/show_bug.cgi?id=851859
--- Comment #8 from Martin Gieseking martin.giesek...@uos.de ---
Here comes the formal review of your package. There are some minor things left
that could be fixed easily.
If you don't have a sponsor yet, I can sponsor you if you're willing to do a
couple of informal reviews (aka simulated package reviews). Since you're
allowed to review and approve packages of other packagers once you're a member
of the packager group, it's important to practice the review procedure a bit.
For further information let's email privately.
Summary of the review results:
- Replace Opensource with Open source.
- In the %changelog, replace the single percent signs with double ones to
make rpmlint happy.
- The incorrect FSF addresses in the source files mentioned below should be
fixed upstream. That's not a blocker, though.
- Drop %{buildroot}/ from the rm statement in %prep. All paths are relative
to the root of decompressed tarball.
rm -rf %{buildroot}/libs/enet = rm -rf libs/enet
- There's a manpage (mana.6) present in docs/. It should be installed
properly in order to make use of it:
* add the following lines to the %install section:
install -D -p -m664 docs/%{name}.6 %{buildroot}/%{_mandir}/man6/%{name}.6
rm -f docs/%{name}.6
* add %{_mandir}/man6/%{name}.6* to %files
- Macros/Variables must be used consistently, so don't mix $RPM_BUILD_ROOT and
%{buildroot}. Choose one variant and stick with it.
= replace $RPM_BUILD_ROOT with %{buildroot}
--
$ rpmlint *.rpm
mana.i686: W: spelling-error Summary(en_US) Opensource - Open source,
Open-source, Outsource
mana.i686: W: spelling-error %description -l en_US eAthena - Athena, e Athena,
heathen
mana.i686: W: spelling-error %description -l en_US tmwAthena - Athena
mana.i686: W: dangling-symlink /usr/share/mana/data/fonts/dejavusans-bold.ttf
/usr/share/fonts/dejavu/DejaVuSans-Bold.ttf
mana.i686: W: dangling-symlink /usr/share/mana/data/fonts/dejavusans-mono.ttf
/usr/share/fonts/dejavu/DejaVuSansMono.ttf
mana.i686: W: dangling-symlink /usr/share/mana/data/fonts/dejavusans.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
mana.i686: W: no-manual-page-for-binary mana
mana.src: W: spelling-error Summary(en_US) Opensource - Open source,
Open-source, Outsource
mana.src: W: spelling-error %description -l en_US eAthena - Athena, e Athena,
heathen
mana.src: W: spelling-error %description -l en_US tmwAthena - Athena
mana.src:59: W: rpm-buildroot-usage %prep rm -rf %{buildroot}/libs/enet
mana.src:89: W: macro-in-%changelog %{mana}
mana.src:91: W: macro-in-%changelog %{optflags}
mana.src:94: W: macro-in-%changelog %cmake
mana.src:98: W: macro-in-%changelog %{name}
mana.src:99: W: macro-in-%changelog %defattr
mana-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/mana-0.6.1/src/gui/textpopup.h
mana-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/mana-0.6.1/src/chatlogger.h
mana-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/mana-0.6.1/src/gui/textpopup.cpp
mana-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/mana-0.6.1/src/chatlogger.cpp
3 packages and 0 specfiles checked; 4 errors, 16 warnings.
- dangling symlinks are expected and OK here
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+ according to source file headers
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ sha256sum mana-0.6.1.tar.gz*
b945cd3e32489dfa5b8e82d571cc11e0e5308576307fca4d8dd7cf3cf6ed8c55
mana-0.6.1.tar.gz
b945cd3e32489dfa5b8e82d571cc11e0e5308576307fca4d8dd7cf3cf6ed8c55
mana-0.6.1.tar.gz.upstream
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[+] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[Bug 851859] Review Request: mana - Opensource 2D MMORPG platform client
https://bugzilla.redhat.com/show_bug.cgi?id=851859 Martin Gieseking martin.giesek...@uos.de changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||177841 (FE-NEEDSPONSOR) Assignee|nob...@fedoraproject.org|martin.giesek...@uos.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com Assignee|nob...@fedoraproject.org|limburg...@gmail.com Flags||fedora-review? --- Comment #2 from Jon Ciesla limburg...@gmail.com --- Reviewing, I need this for gnugb. . . -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829038] Review Request: drupal6-freelinking - Freelinking module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=829038 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #4 from Troy Dawson tdaw...@redhat.com --- That was the only problem I found, so I approve this request. It would be a good idea to inform upstream of this license problem, if you haven't already. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829030] Review Request: drupal6-flag - Flag module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=829030 --- Comment #5 from Troy Dawson tdaw...@redhat.com --- That was the only problem I found, so I approve this request. It would be a good idea to inform upstream of this license problem, if you haven't already. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Good: - rpmlint checks return: pangox-compat.x86_64: W: conffile-without-noreplace-flag /etc/pango/pangox.aliases A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here pangox-compat.x86_64: E: incorrect-fsf-address /usr/share/doc/pangox-compat-0.0.1/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. pangox-compat-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 3 packages and 0 specfiles checked; 1 errors, 2 warnings. All ignorable given it's a compat package. - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream with sha512 - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Really clean, good. Working on mock build to confirm BRs. Will approve if that's good. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829030] Review Request: drupal6-flag - Flag module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=829030 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845769] Review Request: emacs-undo-tree - Treats undo history as a tree of changes
https://bugzilla.redhat.com/show_bug.cgi?id=845769 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Looks good, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 Parag pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Parag pnem...@redhat.com --- New Package SCM Request === Package Name: pangox-compat Short Description: Compatibility library for pangox Owners: pnemade Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox
https://bugzilla.redhat.com/show_bug.cgi?id=852416 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852211] Review Request: dunst - dmenu-ish lightweight notification-daemon
https://bugzilla.redhat.com/show_bug.cgi?id=852211 --- Comment #2 from Petr Šabata psab...@redhat.com --- * One of the files is distributed under the MIT/X license. Please, correct the License tag to BSD and MIT. * Respect Fedora %optflags/$RPM_OPT_FLAGS. * Use %global instead of %define. The rest of the package looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817533] Review Request: aether-ant-tasks - Ant tasks using Aether to resolve, install and deploy artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=817533 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tra...@redhat.com Assignee|nob...@fedoraproject.org|tra...@redhat.com Flags||fedora-review? --- Comment #2 from Tomas Radej tra...@redhat.com --- Taking the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 842570] Review Request: maven-script-interpreter - Maven Script Interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=842570 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|652183 (FE-JAVASIG) | Resolution|--- |NEXTRELEASE Last Closed||2012-08-28 10:44:53 --- Comment #10 from Tomas Radej tra...@redhat.com --- Package is in F18 stable, closing. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783656] Review Request: python-pybloomfiltermmap - A Bloom filter (bloomfilter) for Python built on mmap
https://bugzilla.redhat.com/show_bug.cgi?id=783656 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-pybloomfiltermmap-0.3.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-editdist-0.3-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome
https://bugzilla.redhat.com/show_bug.cgi?id=749608 --- Comment #12 from Praveen Kumar kumarpraveen.nit...@gmail.com --- ping? Can you please assign it to you and do further review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
--- Comment #9 from Kai Engert (:kaie) keng...@redhat.com ---
Wrong FSF addresses and missing man pages, no real problems.
I've mailed the upstream maintainer and asked to get the FSF license headers
updated in a future release.
Add the following line to %files:
%doc AUTHORS COPYING NEWS README TODO
I believe it's not as simple as you think,
because the upstream installation scripts don't install these files into the
area that will be used as the base for packaging.
I added copy commands to %install that copy those files to %{_docdir}/%{name}/
and added appropriate entries to %files
Change the license to GPLv3+ according to some file headers in the source
tarball.
Ok.
Don't forget to track your changes in the %changelog, as already mentioned.
ok
Updated:
Spec URL: http://kuix.de/fedora/ppm/prepaid-manager-applet.spec
SRPM URL:
http://kuix.de/fedora/ppm/prepaid-manager-applet-0.0.3.1-4.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851859] Review Request: mana - Opensource 2D MMORPG platform client
https://bugzilla.redhat.com/show_bug.cgi?id=851859 --- Comment #9 from Erik Schilling ablu.erikschill...@googlemail.com --- Hi, Thanks a lot for the review! I am part of upstream. I will fix this incorrect fsf warnings in upstream directly. Can you tell me how you ran rpmlint to make these show up btw? For me rpmlint does not show this warnings... Here is fixed specfile again: https://dl.dropbox.com/u/45541625/mana.spec The SRPM: https://dl.dropbox.com/u/45541625/mana-0.6.1-4.fc17.src.rpm koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=4430361 Regards, Erik --- Comment #10 from Martin Gieseking martin.giesek...@uos.de --- (In reply to comment #9) Thanks a lot for the review! You're welcome. I am part of upstream. I will fix this incorrect fsf warnings in upstream directly. OK, great. Can you tell me how you ran rpmlint to make these show up btw? For me rpmlint does not show this warnings... As you can see above, the messages are the results of checking the debuginfo package. Maybe you ran rpmlint only on the source rpm. It's important to check all built packages too. Here is fixed specfile again: https://dl.dropbox.com/u/45541625/mana.spec The SRPM: https://dl.dropbox.com/u/45541625/mana-0.6.1-4.fc17.src.rpm OK, I'll have a more detailed look later, and will approve it as soon as you've been sponsored. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome
https://bugzilla.redhat.com/show_bug.cgi?id=749608 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #12) ping? Can you please assign it to you and do further review? Be patient, such a ping within one day shouldn't be needed. I'm not online 24 hours a day. However, I take this for a full review. Maybe you have some time left to have a look at my open review requests: https://bugzilla.redhat.com/buglist.cgi?bug_status=NEWcomponent=Package%20Reviewemail1=mario.blaettermann%40gmail.comemailreporter1=1emailtype1=exactkeywords=keywords_type=allwordsproduct=Fedoraquery_format=advancedquery_format=advancedversion=rawhideorder=bug_idquery_based_on= -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851721] Review Request: perl-Net-Nessus-XMLRPC - Communicate with Nessus scanner(v4.2+) via XMLRPC
https://bugzilla.redhat.com/show_bug.cgi?id=851721 --- Comment #1 from Olivier Bilodeau oliv...@bottomlesspit.org --- I've made a few updates: - Added Provides: in the form of perl(Net::Nessus::XMLRPC) - Clarified license based on Packaging:Perl guidelines Updated spec and SRPM available at the same URL as given previously. Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4430937 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844740] Review Request: qmmp-plugin-pack - A set of extra plugins for Qmmp
https://bugzilla.redhat.com/show_bug.cgi?id=844740 --- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #12) btw, what about reviewing the rpmfusion part of this package? Never did a review at rpmfusion at all... I'll have a look at it. I think first I should become a rpmfusion packager, could need some time. Be patient. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852503] New: Review Request: perl-Net-Radius - Object-oriented Perl interface to RADIUS
https://bugzilla.redhat.com/show_bug.cgi?id=852503 Bug ID: 852503 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: perl-Net-Radius - Object-oriented Perl interface to RADIUS Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: oliv...@bottomlesspit.org Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: https://raw.github.com/inverse-inc/perl-Net-Radius.spec/master/perl-Net-Radius.spec SRPM URL: https://raw.github.com/inverse-inc/perl-Net-Radius.spec/master/perl-Net-Radius-2.103-1.fc17.src.rpm Description: Object-oriented Perl interface to RADIUS Fedora Account System Username: obilodeau Looking for sponsor and I have also submitted #851721 where I am also waiting for a sponsor. Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4430964 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852503] Review Request: perl-Net-Radius - Object-oriented Perl interface to RADIUS
https://bugzilla.redhat.com/show_bug.cgi?id=852503 Olivier Bilodeau oliv...@bottomlesspit.org changed: What|Removed |Added CC||perl-devel@lists.fedoraproj ||ect.org Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
--- Comment #10 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to comment #9)
Add the following line to %files:
%doc AUTHORS COPYING NEWS README TODO
I believe it's not as simple as you think,
because the upstream installation scripts don't install these files into the
area that will be used as the base for packaging.
I added copy commands to %install that copy those files to
%{_docdir}/%{name}/
and added appropriate entries to %files
Not needed at all. If you use that line as is, the %doc macro picks up the
appropriate files and puts them into the right folder automatically. In case of
that the install script from the tarball puts them anywhere else, just use the
%exclude macro in the file list to avoid installing duplicates.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 850789] Review Request: babeld - Ad-hoc network routing daemon
https://bugzilla.redhat.com/show_bug.cgi?id=850789 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- babeld-1.3.4-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- pykka-0.15-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851848] Review Request: mingw-harfbuzz - MinGW Windows Harfbuzz library
https://bugzilla.redhat.com/show_bug.cgi?id=851848 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- Package mingw-glib2-2.33.10-2.fc18, mingw-gtk3-3.5.12-1.fc18, mingw-pango-1.31.0-1.fc18, mingw-atk-2.5.4-1.fc18, mingw-harfbuzz-0.9.3-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mingw-glib2-2.33.10-2.fc18 mingw-gtk3-3.5.12-1.fc18 mingw-pango-1.31.0-1.fc18 mingw-atk-2.5.4-1.fc18 mingw-harfbuzz-0.9.3-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-12863/mingw-glib2-2.33.10-2.fc18,mingw-gtk3-3.5.12-1.fc18,mingw-pango-1.31.0-1.fc18,mingw-atk-2.5.4-1.fc18,mingw-harfbuzz-0.9.3-1.fc18 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #11 from Kai Engert (:kaie) keng...@redhat.com --- %doc AUTHORS COPYING NEWS README TODO I probably made a mistake in my earlier testing, I confirm it works now. Spec URL: http://kuix.de/fedora/ppm/prepaid-manager-applet.spec SRPM URL: http://kuix.de/fedora/ppm/prepaid-manager-applet-0.0.3.1-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 Sébastien Willmann sebastien.willm...@gmail.com changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-08-28 14:58:31 --- Comment #6 from Sébastien Willmann sebastien.willm...@gmail.com --- Build successful for all branches. Thanks for the reviews. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844173] Review Request: emacs-evil - Extensible vi layer for Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=844173 Bug 844173 depends on bug 845134, which changed state. Bug 845134 Summary: Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer https://bugzilla.redhat.com/show_bug.cgi?id=845134 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- emacs-goto-chg-1.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/emacs-goto-chg-1.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822889] Review Request: jasypt - Java Simplified Encryption
https://bugzilla.redhat.com/show_bug.cgi?id=822889 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added CC||mspauldin...@gmail.com --- Comment #1 from Matt Spaulding mspauldin...@gmail.com --- Hi Gil, I ran a mock build on this one and the build fails due to deps. It looks like apache-commons-codec has the wrong groupid. Please fix and I'll do a formal review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- emacs-goto-chg-1.4-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/emacs-goto-chg-1.4-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845134] Review Request: emacs-goto-chg - Emacs add-on to go to last change in current buffer
https://bugzilla.redhat.com/show_bug.cgi?id=845134 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- emacs-goto-chg-1.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/emacs-goto-chg-1.4-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846488] Review Request: babeltrace - Trace Viewer and Converter, mainly for the Common Trace Format
https://bugzilla.redhat.com/show_bug.cgi?id=846488 Erik Schilling ablu.erikschill...@googlemail.com changed: What|Removed |Added CC||ablu.erikschilling@googlema ||il.com --- Comment #1 from Erik Schilling ablu.erikschill...@googlemail.com --- Hi just a quick note: The %defattr lines can be dropped. Best regards Erik Schillig (Ablu) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847571] Review Request: python-tbgrep - Extract Python Tracebacks from text
https://bugzilla.redhat.com/show_bug.cgi?id=847571 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847571] Review Request: python-tbgrep - Extract Python Tracebacks from text
https://bugzilla.redhat.com/show_bug.cgi?id=847571 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-tbgrep-0.2.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-11990/python-tbgrep-0.2.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844150] Review Request: mate-desktop - Shared code among mate-panel, mate-session, caja, etc
https://bugzilla.redhat.com/show_bug.cgi?id=844150 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- mate-desktop-1.4.1-10.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/FEDORA-2012-12745/mate-desktop-1.4.1-10.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844173] Review Request: emacs-evil - Extensible vi layer for Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=844173 Bug 844173 depends on bug 845769, which changed state. Bug 845769 Summary: Review Request: emacs-undo-tree - Treats undo history as a tree of changes https://bugzilla.redhat.com/show_bug.cgi?id=845769 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845769] Review Request: emacs-undo-tree - Treats undo history as a tree of changes
https://bugzilla.redhat.com/show_bug.cgi?id=845769 Sébastien Willmann sebastien.willm...@gmail.com changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-08-28 15:44:22 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845769] Review Request: emacs-undo-tree - Treats undo history as a tree of changes
https://bugzilla.redhat.com/show_bug.cgi?id=845769 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- emacs-undo-tree-0.5.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/emacs-undo-tree-0.5.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845769] Review Request: emacs-undo-tree - Treats undo history as a tree of changes
https://bugzilla.redhat.com/show_bug.cgi?id=845769 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- emacs-undo-tree-0.5.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/emacs-undo-tree-0.5.3-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #12 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4432324
$ rpmlint -i -v *
prepaid-manager-applet.src: I: checking
prepaid-manager-applet.src: I: checking-url
https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds)
prepaid-manager-applet.src: I: checking-url
http://honk.sigxcpu.org/projects/ppm/tarballs/prepaid-manager-applet-0.0.3.1.tar.xz
(timeout 10 seconds)
prepaid-manager-applet.noarch: I: checking
prepaid-manager-applet.noarch: I: checking-url
https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds)
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/accountdb.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/provider.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/providerdb.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/modemproxy.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/prepaid-manager-applet.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: W: no-manual-page-for-binary
prepaid-manager-applet
Each executable in standard binary directories should have a man page.
prepaid-manager-applet.spec: I: checking-url
http://honk.sigxcpu.org/projects/ppm/tarballs/prepaid-manager-applet-0.0.3.1.tar.xz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 5 errors, 1 warnings.
No real issues. The wrong FSF addresses have been discussed earlier, and no man
page is no review blocker.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv3+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
76b2a5668f419dbfe889d84b54deb18d536c1b5c1f2d3970ca687290f1048f66
prepaid-manager-applet-0.0.3.1.tar.xz
76b2a5668f419dbfe889d84b54deb18d536c1b5c1f2d3970ca687290f1048f66
prepaid-manager-applet-0.0.3.1.tar.xz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla,
[Bug 850789] Review Request: babeld - Ad-hoc network routing daemon
https://bugzilla.redhat.com/show_bug.cgi?id=850789 --- Comment #14 from Michael Scherer m...@zarb.org --- Someone at work notified me that quagga already ship babel support, so there is a file conflict I missed. As a side note, maybe babeld is not so useful if there is already support in quagga ( even if I can understand that using babeld standalone would be easier than babeld + quagga ) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852232] Review Request: python-vaporize - library for the Rackspace Cloud
https://bugzilla.redhat.com/show_bug.cgi?id=852232 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- Some typos in the description: libarry library menas means Is it intended to go in EPEL 5? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845769] Review Request: emacs-undo-tree - Treats undo history as a tree of changes
https://bugzilla.redhat.com/show_bug.cgi?id=845769 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- emacs-undo-tree-0.5.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/emacs-undo-tree-0.5.3-2.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 850789] Review Request: babeld - Ad-hoc network routing daemon
https://bugzilla.redhat.com/show_bug.cgi?id=850789 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- I think it's inclusion is warranted, for those not wanting to use quagga. Which files conflict? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 850789] Review Request: babeld - Ad-hoc network routing daemon
https://bugzilla.redhat.com/show_bug.cgi?id=850789 --- Comment #16 from Michael Scherer m...@zarb.org --- File conflict : /lib/systemd/system/babeld.service /usr/sbin/babeld What annoy me is the huge code duplication, in fact. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810676] Review Request: aws - Ada Web Server (Web framework for Ada)
https://bugzilla.redhat.com/show_bug.cgi?id=810676 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Depends On||852543 (zlib-ada) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852543] New: Review Request: Zlib-Ada - an Ada binding to Zlib
https://bugzilla.redhat.com/show_bug.cgi?id=852543 Bug ID: 852543 Blocks: 810676 QA Contact: extras...@fedoraproject.org Severity: unspecified Whiteboard: NotReady Version: rawhide Priority: unspecified CC: nott...@redhat.com, package-review@lists.fedoraproject.org, pa...@zhukoff.net Assignee: nob...@fedoraproject.org Summary: Review Request: Zlib-Ada - an Ada binding to Zlib Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: bj...@xn--rombobjrn-67a.se Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora Zlib-Ada is a thick Ada binding to the popular compression/decompression library Zlib. Spec and source RPM coming soon. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 Bruno Wolff III br...@wolff.to changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time
https://bugzilla.redhat.com/show_bug.cgi?id=735554 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822889] Review Request: jasypt - Java Simplified Encryption
https://bugzilla.redhat.com/show_bug.cgi?id=822889 --- Comment #2 from gil cattaneo punto...@libero.it --- hi Matt, apache-commons-codec has something wrong ... Spec URL: http://gil.fedorapeople.org/jasypt/1/jasypt.spec SRPM URL: http://gil.fedorapeople.org/jasypt/1/jasypt-1.9.0-2.fc16.src.rpm - fixed apache-commons-codec gId thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
--- Comment #17 from Jerry James loganje...@gmail.com ---
Sorry for the delay, Paulo. There are just a few things to fix:
(1) https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net says
that the source URL ought to look like this:
Source0:http://downloads.sourceforge.net/surf/surf-%{version}.tar.gz
(2) Use either %{buildroot} or $RPM_BUILD_ROOT, not both.
(3) Some source files have executable bits set. See below.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), GPL (with incorrect
FSF address) For detailed output of licensecheck see file:
/home/jamesjer/840244-surf-geometry/licensecheck.txt
[!]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[x]: SHOULD If the source package does not include license text(s) as
[Bug 852558] New: Review Request: gnome-shell-extension-shellshape - A tiling window extension inspired by bluetile
https://bugzilla.redhat.com/show_bug.cgi?id=852558
Bug ID: 852558
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: gnome-shell-extension-shellshape - A
tiling window extension inspired by bluetile
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: rb...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://threebean.org/rpm/gnome-shell-extension-shellshape.spec
SRPM URL:
http://threebean.org/rpm/gnome-shell-extension-shellshape-0.5.1-1.fc17.src.rpm
Description: A powerful and easy to use tiling window extension for
gnome-shell, inspired by bluetile. See the extension homepage for a video of it
in action, plus instructions / key-bindings: http://gfxmonk.net/shellshape
Fedora Account System Username: ralph
rpmlint output
--
--- ~/rpmbuild » rpmlint {SPECS,SRPMS}/*shellshape*
/var/lib/mock/fedora*/result/*shellshape*.rpm
gnome-shell-extension-shellshape.src: W: spelling-error Summary(en_US) bluetile
- blue tile, blue-tile, bluet
gnome-shell-extension-shellshape.src: W: spelling-error %description -l en_US
bluetile - blue tile, blue-tile, bluet
gnome-shell-extension-shellshape.noarch: W: spelling-error Summary(en_US)
bluetile - blue tile, blue-tile, bluet
gnome-shell-extension-shellshape.noarch: W: spelling-error %description -l
en_US bluetile - blue tile, blue-tile, bluet
gnome-shell-extension-shellshape.noarch: W: no-documentation
gnome-shell-extension-shellshape.noarch: W: dangling-symlink
/usr/share/gnome-shell/extensions/shellsh...@gfxmonk.net/xdg/data/glib-2.0
/usr/share/glib-2.0
gnome-shell-extension-shellshape.noarch: W: dangling-symlink
/usr/share/gnome-shell/extensions/shellsh...@gfxmonk.net/xdg/data/icons
/usr/share/icons
gnome-shell-extension-shellshape.src: W: spelling-error Summary(en_US) bluetile
- blue tile, blue-tile, bluet
gnome-shell-extension-shellshape.src: W: spelling-error %description -l en_US
bluetile - blue tile, blue-tile, bluet
3 packages and 1 specfiles checked; 0 errors, 9 warnings.
koji - f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4432764
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822831] Review Request: gentlyweb-utils - Java utility library used by JoSQL for I/O
https://bugzilla.redhat.com/show_bug.cgi?id=822831 gil cattaneo punto...@libero.it changed: What|Removed |Added Summary|Review Request: |Review Request: |gentlyweb-utils - java |gentlyweb-utils - Java |utility library used by |utility library used by |josql |JoSQL for I/O -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822832] Review Request: josql - Library to apply SQL-like syntax to Java objects
https://bugzilla.redhat.com/show_bug.cgi?id=822832 gil cattaneo punto...@libero.it changed: What|Removed |Added Summary|Review Request: josql - |Review Request: josql - |library to apply SQL-like |Library to apply SQL-like |syntax to Java objects |syntax to Java objects -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830593] Review Request: perl-B-Generate - Create your own op trees
https://bugzilla.redhat.com/show_bug.cgi?id=830593 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-28 19:26:10 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-B-Generate-1.45-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823962] Review Request: apacheds-shared - Shared APIs of Apache Directory Project
https://bugzilla.redhat.com/show_bug.cgi?id=823962 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-28 19:26:29 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- apacheds-shared-0.9.19-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839142] Review Request: python-urllib2_kerberos - Kerberos over HTTP Negotiate/SPNEGO support for urllib2
https://bugzilla.redhat.com/show_bug.cgi?id=839142 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-28 19:28:03 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-urllib2_kerberos-0.1.6-6.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830593] Review Request: perl-B-Generate - Create your own op trees
https://bugzilla.redhat.com/show_bug.cgi?id=830593 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- perl-B-Generate-1.45-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
