[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

--- Comment #23 from Fedora Update System  ---
gnome-pie-0.5.3-2.20120826git1b93e1.fc18 has been submitted as an update for
Fedora 18.
https://admin.fedoraproject.org/updates/gnome-pie-0.5.3-2.20120826git1b93e1.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

--- Comment #22 from Fedora Update System  ---
gnome-pie-0.5.3-2.20120826git1b93e1.fc17 has been submitted as an update for
Fedora 17.
https://admin.fedoraproject.org/updates/gnome-pie-0.5.3-2.20120826git1b93e1.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 822831] Review Request: gentlyweb-utils - Java utility library used by JoSQL for I/O

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=822831

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:55:41

--- Comment #11 from Fedora Update System  ---
gentlyweb-utils-1.5-2.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 842386] Review Request: joystick - Enable joystick / game pad support

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=842386

--- Comment #13 from Fedora Update System  ---
joystick-support-1.0.0-4.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=784175

--- Comment #19 from Fedora Update System  ---
SuperLU-4.3-3.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=735554

--- Comment #16 from Fedora Update System  ---
floppy-support-1.0.0-4.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 783656] Review Request: python-pybloomfiltermmap - A Bloom filter (bloomfilter) for Python built on mmap

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=783656

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:54:02

--- Comment #10 from Fedora Update System  ---
python-pybloomfiltermmap-0.3.2-1.fc17 has been pushed to the Fedora 17 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 850791] Review Request: ahcpd - Ad-hoc network configuration daemon

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=850791

--- Comment #12 from Fedora Update System  ---
ahcpd-0.53-2.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 842386] Review Request: joystick - Enable joystick / game pad support

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=842386

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:53:15

--- Comment #12 from Fedora Update System  ---
joystick-support-1.0.0-4.fc17 has been pushed to the Fedora 17 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 825599] Review Request: samdump2 - Retrieves syskey and extracts hashes from Windows SAM hive

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=825599

--- Comment #9 from Fedora Update System  ---
samdump2-3.0.0-1.fc17 has been pushed to the Fedora 17 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=807479

--- Comment #23 from Fedora Update System  ---
spacewalk-setup-jabberd-1.8.5-1.fc17 has been pushed to the Fedora 17 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=807479

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:51:26

--- Comment #22 from Fedora Update System  ---
spacewalk-setup-jabberd-1.8.5-1.fc16 has been pushed to the Fedora 16 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 850791] Review Request: ahcpd - Ad-hoc network configuration daemon

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=850791

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:49:22

--- Comment #11 from Fedora Update System  ---
ahcpd-0.53-2.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 825599] Review Request: samdump2 - Retrieves syskey and extracts hashes from Windows SAM hive

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=825599

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:49:09

--- Comment #8 from Fedora Update System  ---
samdump2-3.0.0-1.fc16 has been pushed to the Fedora 16 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 822889] Review Request: jasypt - Java Simplified Encryption

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=822889

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:48:45

--- Comment #9 from Fedora Update System  ---
jasypt-1.9.0-2.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=784175

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:48:13

--- Comment #18 from Fedora Update System  ---
SuperLU-4.3-3.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 735554] Review Request: floppy-support - Load floppy driver at boot time

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=735554

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-09-08 22:46:47

--- Comment #15 from Fedora Update System  ---
floppy-support-1.0.0-4.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 809950] Review Request: gradle - Groovy based build system

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=809950

--- Comment #38 from gil cattaneo  ---
tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4469048

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

--- Comment #21 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855561] New: Review Request: mediawiki119-RSS - Displays one or more RSS feeds on a wiki page

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855561

Bug ID: 855561
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: mediawiki119-RSS - Displays one or
more RSS feeds on a wiki page
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: puiterw...@gmail.com
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL:
http://puiterwijk.fedorapeople.org/packages/mediawiki-RSS/mediawiki119-RSS.spec
SRPM URL:
http://puiterwijk.fedorapeople.org/packages/mediawiki-RSS/mediawiki119-RSS-2.16-1.fc17.src.rpm
Fedora Account System Username: puiterwijk
Description:
The RSS extension displays one or more RSS feeds
on a wiki page in a standard or user-definable format.
Since version 2.00, the extension is also compatible
with wiki-page-generated feeds (RSS or ATOM).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768894] Review Request: haven - Next Generation Backup System

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=768894

--- Comment #12 from Michael Schwendt  ---
When I wanted to take another look at it, it failed to build for Fedora 17 due
to the header changes in glib2 ("Only  can be included directly.").

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851800] Review Request: compiz - OpenGL window and compositing manager

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851800

--- Comment #4 from Wolfgang Ulbrich  ---
new starting point.

SPEC: http://raveit65.fedorapeople.org/compiz/SPEC/compiz.spec

SRPM: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-0.8.8-3.fc18.src.rpm

- initial for fedora
- remove kde stuff
- add comiz_mate_fork.patch
- add isa tags
- remove obsolete beryl stuff
- add mate-control-center dependencies
- remove %%defattr(-, root, root)
- remove rm -rf $RPM_BUILD_ROOT
- remove obsoletes BuildRoot: line
- change %%define to %%global
- fix mate-conf spriplets

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=818401

--- Comment #40 from pcpa  ---
Thanks for the review!

Updated package:

- Corrected the manual page group
- Made a symlink from 0ad to pyrogenesis manual page
- Followed my own advice in comments and reviewed/updated the manual page :-)
- Corrected some typos in the (manually written) manual page

Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-0.0.11-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - A unix password manager using standard tools

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

Michael Scherer  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #20 from Michael Scherer  ---
Christophe, I do not know why you are reset the fedora-review flag to '?', but
that's wrong :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855529] Review Request: pygrib - Python module for reading and writing GRIB (editions 1 and 2) files (2)

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855529

--- Comment #2 from jdekloe  ---
new versions of the SRPM and SPEC file are here:

Spec URL: http://jdekloe.nl/Fedora/pygrib.spec
SRPM URL: http://jdekloe.nl/Fedora/pygrib-1.9.4-3.fc17.src.rpm

Volker:

>Building with openjpeg works, locally on F16 as well as on F17

yes this is correct. It is pyproj that is the problem. This is not required for
building, but it is for running the module!

>I thought about spelling it "pre-cooked"!

A I see, so 'k' not 'ck'. I could not find it in my regular dictionary, but
according to some online dictionaries it should be without dash as well, so I
changed it into precooked ...

>To my knowledge, BRing grib_api-static and g2clib-static should be enough. No 
>>need to have grib_api-devel and g2clib-devel too.

Thanks for explaining. This actually was not obvious at all to me. Building the
c-code needs the header files which are part of the devel packages. Apparantly
this happens automatically if the static packages are BR'ed? I must have
overlooked the documentation section that explains this.
Anyway, I removed them and the package still builds alright.

>That comment doesn't make sense:

I tried to rephrase it.

> Devel packages always require the base package. You therefore mostly need to 
> > specify devel packages as BR.

Doesn't this contradict your suggestion above to remove the grib_api-devel and
g2clib-devel?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854837] inkscape-sozi - Inkscape extension for creating animated presentations

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854837

--- Comment #14 from Eduardo Echeverria  ---
Thank you very much Toshio and Itamar, in waiting for your valuable comments
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=818401

--- Comment #39 from Miroslav Suchý  ---
Oh, it should by just symlink to:
/usr/share/man/man1/pyrogenesis.1.gz -> 0ad.1.gz

And more precise it should not be in group:
  1 - Executable programs or shell commands
but in group
  6 - Games

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=818401

--- Comment #38 from Miroslav Suchý  ---
rpmlint warning:
0ad.x86_64: W: no-manual-page-for-binary pyrogenesis

Although, this is not blocker, but Debian has man page (written under GPLv2) so
you can use that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=818401

Miroslav Suchý  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|msu...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 784145] Review Request: libomxil-bellagio - OpenMAX Integration Layer

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=784145

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
  Flags|needinfo?(kwiz...@gmail.com |
   |)   |
Last Closed||2012-09-08 14:36:48

--- Comment #11 from Nicolas Chauvet (kwizart)  ---
Finally got the patch reworked (fix 32bit) and build.
Thx for the review and patches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - A unix password manager using standard tools

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

--- Comment #19 from Jason A. Donenfeld  ---
Great. Well, let's ship it then.

Thanks everyone for helping out and chiming in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - A unix password manager using standard tools

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

--- Comment #18 from Christophe Fergeau  ---
Scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=4467371
I ran a quick test by replacing the qdbus call with qdbusfoo, and this didn't
trigger any user-visible package-kit stuff, so it's probably only triggering in
interactive shells.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - A unix password manager using standard tools

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

Christophe Fergeau  changed:

   What|Removed |Added

  Flags|fedora-review+  |
  Flags||fedora-review?

--- Comment #17 from Christophe Fergeau  ---
Spec URL: http://teuf.fedorapeople.org/reviews/pass/pass.spec
SRPM URL: http://teuf.fedorapeople.org/reviews/pass/pass-1.1.4-1.fc17.src.rpm

Update to the 1.1.4 upstream release which ships a full GPLv2 copy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

Praveen Kumar  changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

--- Comment #20 from Praveen Kumar  ---
New Package SCM Request
===
Package Name: gnome-pie
Short Description: A visual application launcher for Gnome
Owners: kumarpraveen
Branches: f17 f18 devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855529] Review Request: pygrib - Python module for reading and writing GRIB (editions 1 and 2) files (2)

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855529

jdekloe  changed:

   What|Removed |Added

 CC||kloe0...@planet.nl

--- Comment #1 from jdekloe  ---
*** Bug 806037 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806037] Review Request: pygrib - Python module for reading and writing GRIB (editions 1 and 2) files

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806037

jdekloe  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2012-09-08 12:26:10

--- Comment #8 from jdekloe  ---
moved to my other bugzilla account

*** This bug has been marked as a duplicate of bug 855529 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806037] Review Request: pygrib - Python module for reading and writing GRIB (editions 1 and 2) files

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806037

Bug 806037 depends on bug 806040, which changed state.

Bug 806040 Summary: Review Request: pyproj - a python module that performs 
cartographic transformations and geodetic computations
https://bugzilla.redhat.com/show_bug.cgi?id=806040

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855528] Review Request: pyproj - a python module that performs cartographic transformations and geodetic computations (2)

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855528

jdekloe  changed:

   What|Removed |Added

 CC||kloe0...@planet.nl

--- Comment #1 from jdekloe  ---
*** Bug 806040 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806040] Review Request: pyproj - a python module that performs cartographic transformations and geodetic computations

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=806040

jdekloe  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2012-09-08 12:24:51

--- Comment #18 from jdekloe  ---
moved to my other bugzilla account

*** This bug has been marked as a duplicate of bug 855528 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855529] New: Review Request: pygrib - Python module for reading and writing GRIB (editions 1 and 2) files (2)

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855529

Bug ID: 855529
QA Contact: extras...@fedoraproject.org
  Severity: unspecified
   Version: rawhide
  Priority: unspecified
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: pygrib - Python module for reading and
writing GRIB (editions 1 and 2) files (2)
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Unspecified
  Reporter: josdek...@gmail.com
  Type: Bug
 Documentation: ---
  Hardware: Unspecified
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

copy of my request of 2012-03-22 13:55:10 EDT 
(this new bug is needed to allow moving this to the proper account that I wish
to use to maintain the package; there seems no other wy in bugzilla to do
this).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855528] New: Review Request: pyproj - a python module that performs cartographic transformations and geodetic computations (2)

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855528

Bug ID: 855528
QA Contact: extras...@fedoraproject.org
  Severity: unspecified
   Version: rawhide
  Priority: unspecified
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: pyproj - a python module that performs
cartographic transformations and geodetic computations
(2)
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Unspecified
  Reporter: josdek...@gmail.com
  Type: Bug
 Documentation: ---
  Hardware: Unspecified
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

copy of my request of 2012-03-22 13:59:51 EDT
(this new bug is needed to allow moving this to the proper account that I wish
to use to maintain the package; there seems no other wy in bugzilla to do
this).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854837] inkscape-sozi - Inkscape extension for creating animated presentations

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854837

Itamar Reis Peixoto  changed:

   What|Removed |Added

  Flags||fedora-review?
   Assignee|nob...@fedoraproject.org|ita...@ispbrasil.com.br

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854176] Review Request: python-django-admin-honeypot - A fake Django admin login screen to notify admins of attempted unauthorized access

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854176

Toshio Ernie Kuratomi  changed:

   What|Removed |Added

 CC||a.bad...@gmail.com

--- Comment #18 from Toshio Ernie Kuratomi  ---
itamarjp has agreed to mentor Eduardo.  I have sponsored him into the packager
group and itamar will be the primary contact for help learning how to package
for Fedora.  You can also contact me (abadger1999 on irc) if there's any
questions that itamar cannot answer.  I've asked Itamar to lend a hand in this
review so that he can better know where you need help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854837] inkscape-sozi - Inkscape extension for creating animated presentations

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854837

Toshio Ernie Kuratomi  changed:

   What|Removed |Added

 CC||a.bad...@gmail.com

--- Comment #13 from Toshio Ernie Kuratomi  ---
itamarjp has agreed to mentor you.  I will sponsor you into the packager group
and itamar will be your primary contact for help learning how to package for
Fedora.  You can also contact me (abadger1999 on irc) if there's any questions
that itamar cannot answer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - A unix password manager using standard tools

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

--- Comment #16 from Jason A. Donenfeld  ---
(In reply to comment #15)
> I have seen the shell magic for qdbus, but I am not sure this would interact
> badly with thing like PackageKit-command-not-found ( ie, that it will
> trigger package installation on file not found, using
> command_not_found_handle ). I think this should trigger just for interactive
> shell ( since that's in profile.d ), but that's something to take in account
> IMHO ( ie, someone with a wrongly configured system would face a issue ).

Can anyone test and confirm that god kills kittens here? If it's an issue, I'll
make an upstream change. If it only happens during gross misconfigurations,
I'll still probably change something, but not as immediately.


> But a review is not here to discuss upstream source, so if the license is
> added, the package is approved.

YAY!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=818401

--- Comment #37 from Bruno Wolff III  ---
Thanks for updating to alpha 11. It looks like it has lots of improvements over
alpha 10. Hopefully alpha 12 will have the AI performance fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823102] Review Request: 0ad-data - The Data Files for 0 AD

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=823102

--- Comment #1 from pcpa  ---
Updated to latest upstream alpha release:

Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-data-0.0.11-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854609] Review Request: python-moksha-hub - Hub components for Moksha

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854609

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854608] Review Request: python-moksha-wsgi - WSGI components for Moksha

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854608

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 749608] Review Request: gnome-pie - A visual application launcher for Gnome

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=749608

--- Comment #19 from Jon Ciesla  ---
No SCM request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818401] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=818401

--- Comment #36 from pcpa  ---
Updated to latest upstream alpha release:

Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-0.0.11-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 853553] Review Request: guayadeque - Audio player and organizer

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=853553

--- Comment #6 from MartinKG  ---
Sorry correct link again:

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/guayadeque/guayadeque-0.3.6-4.svn1830/guayadeque.spec?a=5VUFUh0smfQ

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/guayadeque/guayadeque-0.3.6-4.svn1830/guayadeque-0.3.6-4.svn1830.fc17.src.rpm?a=yfxHjA6eW1Y

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 853553] Review Request: guayadeque - Audio player and organizer

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=853553

--- Comment #5 from MartinKG  ---
Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/guayadeque/guayadeque-0.3.6-4.svn1830/guayadeque.spec?a=bOIAY1VMCsM

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/guayadeque/guayadeque-0.3.6-4.svn1830/guayadeque.spec?a=5VUFUh0smfQ

%changelog
* Sat Sep 8 2012 Martin Gansser  - 0.3.6-4.svn1830
- removed  gcc-c++ build requirement
- removed %%defattr from file section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854837] inkscape-sozi - Inkscape extension for creating animated presentations

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854837

Eduardo Echeverria  changed:

   What|Removed |Added

   Hardware|Unspecified |All

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 839056] Review Request: python-flake8 - code checking using pep8 and pyflakes

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=839056

--- Comment #4 from Matěj Cepl  ---
(In reply to comment #1)
> - License wise, the package looks fine but some file (ie: message.py) seems
> to come from another project/source. Could you just make sure there were
> also MIT ?

https://bitbucket.org/tarek/flake8/issue/26/unknown-source-of-some-files


> So to conclude:
> - rpmlint generates some error/warnings that could be fixed (at least the
> summary and the shebang ones)

> - Have you look at running the unit-tests provided during the build ?

Upgraded .spec file:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4466971
http://kojipkgs.fedoraproject.org//work/tasks/6972/4466972/python-flake8-1.4-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852503] Review Request: perl-Net-Radius - Object-oriented Perl interface to RADIUS

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852503

Eduardo Echeverria  changed:

   What|Removed |Added

 CC||echevemas...@gmail.com

--- Comment #1 from Eduardo Echeverria  ---
$ rpmlint -i perl-Net-Radius-2.103-1.fc17.src.rpm
perl-Net-Radius.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab:
line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

I am not sponsor so this is an informal review.

Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: EXTRA Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
 Note: defattr() present in %files section. This is OK if packaging
 for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package contains desktop file if it is a GUI application.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf is only needed if supporting EPEL5
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[ ]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
 Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD Buildroot is not present
 Note: Buildroot is not needed unless packager plans to package for EPEL5
[!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean is needed only if supporting EPEL5
[ ]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOUL

[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854764

--- Comment #3 from Michael Scherer  ---
What do you mean in a "nobase environnement" ?

As far as i know, we consider that that least group core would be installed, so
IMHO :
coreutils initscripts util-linux-ng and iproute are counted as being installed
on Fedora.

However, you are right for sed, as it doesn't seem to be there in minimal
install.

Regarding old EL5 stuff, there is :
rm -rf $RPM_BUILD_ROOT
in %install too.

And as i may not have been clear, the part :
%files
%if %{with_systemd}
%attr(0644,-,-) %{_unitdir}/stickshift-proxy.service
%attr(0644,-,-) %{_sysconfdir}/sysconfig/stickshift-proxy
%else
%attr(0750,-,-) %{_initddir}/stickshift-proxy
%endif
%attr(0755,-,-) %{_bindir}/stickshift-proxy-cfg
%dir %attr(0750,root,root) %{_localstatedir}/lib/stickshift/.stickshift-proxy.d
%attr(0640,-,-) %config(noreplace)
%{_sysconfdir}/stickshift/stickshift-proxy.cfg


would be cleaner as 

%files
%if %{with_systemd}
%{_unitdir}/stickshift-proxy.service
%{_sysconfdir}/sysconfig/stickshift-proxy
%else
%{_initddir}/stickshift-proxy
%endif
%{_bindir}/stickshift-proxy-cfg
%dir %attr(0750,-,-) %{_localstatedir}/lib/stickshift/.stickshift-proxy.d
%config(noreplace) %{_sysconfdir}/stickshift/stickshift-proxy.cfg

Since permissions are already set in the spec by install a few line before.

I do not understand when the config from /etc/ is copied to /var to be used by
the service, can you clarify that, and decide which one should be dropped (
because having 2 configuration when only one is used doesn't make sense ) ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 854837] inkscape-sozi - Inkscape extension for creating animated presentations

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854837

--- Comment #12 from Eduardo Echeverria  ---
New Spec and SRPM 
Spec URL: http://www.saef.com.ve/fedorarpm/sozi/5/inkscape-sozi.spec
SRPM URL:
http://www.saef.com.ve/fedorarpm/sozi/5/inkscape-sozi-12.05-5.fc17.src.rpm

#Koji Build f17 ##
http://koji.fedoraproject.org/koji/taskinfo?taskID=4466933
 Koji Build f18 ##
http://koji.fedoraproject.org/koji/taskinfo?taskID=4466935
 rpmlint SRPM 
$ rpmlint -i inkscape-sozi-12.05-5.fc17.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 rpmlint RPM 
$ rpmlint -i rpmlint -i inkscape-sozi-12.05-5.fc17.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - A unix password manager using standard tools

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

Michael Scherer  changed:

   What|Removed |Added

Summary|Review Request: pass - The  |Review Request: pass - A
   |standard unix password  |unix password manager using
   |manager |standard tools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855283] Review Request: pass - The standard unix password manager

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=855283

Michael Scherer  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #15 from Michael Scherer  ---
I have seen the shell magic for qdbus, but I am not sure this would interact
badly with thing like PackageKit-command-not-found ( ie, that it will trigger
package installation on file not found, using command_not_found_handle ). I
think this should trigger just for interactive shell ( since that's in
profile.d ), but that's something to take in account IMHO ( ie, someone with a
wrongly configured system would face a issue ).
But a review is not here to discuss upstream source, so if the license is
added, the package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851800] Review Request: compiz - OpenGL window and compositing manager

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851800

--- Comment #3 from leigh scott  ---
6.  remove

%clean
rm -rf $RPM_BUILD_ROOT

also remove this

rm -rf $RPM_BUILD_ROOT

from the %build & %install sections


7. remove  

%defattr(-, root, root)

From all the %files sections

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851800] Review Request: compiz - OpenGL window and compositing manager

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851800

--- Comment #2 from leigh scott  ---
1. remove this obsolete line

BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

2. I not happy with you using any gnome deps, please use
mate-control-center-devel instead.

BuildRequires:  mate-desktop-devel, control-center-devel, mate-conf-devel

3. Please remove all the commented (#) kde bits

4. This can go as well

# Make sure that former beryl users still have bling
Obsoletes: beryl-core

and this

Obsoletes: compiz < 0.5.2-8
Obsoletes: beryl-mate


5. The mate-conf scriptlets should be updated to current guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 834802] Review Request: rhythmcat2 - GTK+ frontend of RhythmCat2 Music Player

2012-09-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=834802

--- Comment #2 from Volker Fröhlich  ---
Why did you close the ticket?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review