[Bug 832068] Review Request: opus-tools - A set of tools for the opus audio codec

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=832068

Peter Robinson  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #7 from Peter Robinson  ---
Package Change Request
==
Package Name: opus-tools
New Branches: EL-6 EL-5
Owners: pbrobinson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744725] Review Request: opus - An audio codec for use in low-delay speech and audio communication

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=744725

Peter Robinson  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #7 from Peter Robinson  ---
Package Change Request
==
Package Name: opus
New Branches: EL-6 EL-5
Owners: pbrobinson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860518] Review Request: mate-panel - MATE Desktop panel applets

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860518

--- Comment #19 from Fedora Update System  ---
mate-panel-1.4.0-6.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860518] Review Request: mate-panel - MATE Desktop panel applets

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860518

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860521] Review Request: mate-session-manager - MATE Desktop session manager

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860521

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860521] Review Request: mate-session-manager - MATE Desktop session manager

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860521

--- Comment #13 from Fedora Update System  ---
mate-session-manager-1.4.0-4.fc17 has been pushed to the Fedora 17 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #8 from Fedora Update System  ---
tmw-music-0.3-5.fc17 has been pushed to the Fedora 17 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #20 from Fedora Update System  ---
python-odict-1.5.0-4.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/python-odict-1.5.0-4.el5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #19 from Fedora Update System  ---
python-odict-1.5.0-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-odict-1.5.0-4.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160

--- Comment #8 from Nathan Scott  ---
I've uploaded a new http://oss.sgi.com/~nathans/valkyrie-2.0.0-3.el6_3.src.rpm 
which should fix this new build issue.

Will discuss the FSF address with upstream (as well as asking re a man page).

thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #18 from Fedora Update System  ---
python-odict-1.5.0-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-odict-1.5.0-4.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 849026] Review Request: jam-control - audioserver gui app

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=849026

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?

--- Comment #13 from Mario Blättermann  ---
Taking this for a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m

--- Comment #7 from Mario Blättermann  ---
(In reply to comment #5)
> valkyrie.x86_64: E: incorrect-fsf-address
> ...
> Looks like the FSF address needs fixing.

Doesn't need to be fixed at all. All we have to do is to inform the upstream
people about that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 863145] Review Request: listadmin - Command line interface to mailman mailing lists

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=863145

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m
  Alias||listadmin

--- Comment #2 from Mario Blättermann  ---
$ rpmlint -i -v *
listadmin.noarch: I: checking
listadmin.noarch: W: spelling-error %description -l en_US cron -> corn, con,
crone
The value of this tag appears to be misspelled. Please double-check.

listadmin.noarch: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

listadmin.noarch: I: checking-url
http://heim.ifi.uio.no/kjetilho/hacks/#listadmin (timeout 10 seconds)
listadmin.noarch: W: manual-page-warning /usr/share/man/man1/listadmin.1.gz
214: warning: numeric expression expected (got `[')
This man page may contain problems that can cause it not to be formatted as
intended.

listadmin.noarch: W: manual-page-warning /usr/share/man/man1/listadmin.1.gz
217: warning: numeric expression expected (got `[')
This man page may contain problems that can cause it not to be formatted as
intended.

listadmin.noarch: W: manual-page-warning /usr/share/man/man1/listadmin.1.gz
219: warning: numeric expression expected (got `[')
This man page may contain problems that can cause it not to be formatted as
intended.

listadmin.noarch: W: manual-page-warning /usr/share/man/man1/listadmin.1.gz
222: warning: numeric expression expected (got `a')
This man page may contain problems that can cause it not to be formatted as
intended.

listadmin.src: I: checking
listadmin.src: W: spelling-error %description -l en_US cron -> corn, con, crone
The value of this tag appears to be misspelled. Please double-check.

listadmin.src: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

listadmin.src: I: checking-url http://heim.ifi.uio.no/kjetilho/hacks/#listadmin
(timeout 10 seconds)
listadmin.src: W: invalid-url Source0: listadmin-2.40.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

listadmin.spec: W: invalid-url Source0: listadmin-2.40.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

2 packages and 1 specfiles checked; 2 errors, 8 warnings.



Besides the warnings and errors from rpmlint, some more issues:

Perl is not needed as an explicit requirement. RPM found the following
dependencies automatically:

/usr/bin/perl  
perl  
perl(Data::Dumper)  
perl(Encode)  
perl(English)  
perl(Getopt::Long)  
perl(HTML::TokeParser)  
perl(I18N::Langinfo)  
perl(LWP::UserAgent)  
perl(MIME::Base64)  
perl(MIME::QuotedPrint)  
perl(Term::ReadLine)  
perl(Text::Reform)  
perl(strict)

The initial cleaning of $RPM_BUILD_ROOT in %install is obsolete, unless you
want to provide your package for EPEL 5. See
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines.

The man page is not to be considered as part of %doc. If there are no docs,
just omit the %doc macro. Moreover, replace the man page extension by * because
the compression format could change in the future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 859893] Review Request: perl-Test-Type - Functions to validate data types in test files

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=859893

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2012-10-04 17:37:02

--- Comment #6 from Emmanuel Seyman  ---
perl-Test-Type has been build on all branches and merged in rawhide.
Again, thank you, both of you, for contributing to this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

Mario Blättermann  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #9 from Mario Blättermann  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4561072

$ rpmlint -i -v *
python-slimit.src: I: checking
python-slimit.src: W: spelling-error Summary(en_US) minifier -> magnifier
The value of this tag appears to be misspelled. Please double-check.

python-slimit.src: W: spelling-error %description -l en_US minifier ->
magnifier
The value of this tag appears to be misspelled. Please double-check.

python-slimit.src: I: checking-url http://slimit.org/ (timeout 10 seconds)
python-slimit.src: I: checking-url
http://pypi.python.org/packages/source/s/slimit/slimit-0.7.4.zip (timeout 10
seconds)
python-slimit.noarch: I: checking
python-slimit.noarch: W: spelling-error Summary(en_US) minifier -> magnifier
The value of this tag appears to be misspelled. Please double-check.

python-slimit.noarch: W: spelling-error %description -l en_US minifier ->
magnifier
The value of this tag appears to be misspelled. Please double-check.

python-slimit.noarch: I: checking-url http://slimit.org/ (timeout 10 seconds)
python-slimit.noarch: W: no-manual-page-for-binary slimit
Each executable in standard binary directories should have a man page.

python-slimit.spec: I: checking-url
http://pypi.python.org/packages/source/s/slimit/slimit-0.7.4.zip (timeout 10
seconds)

2 packages and 1 specfiles checked; 0 errors, 5 warnings.

No recognizable issues so far.



-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
3916ff8b58545ee601d6fdc083dfd467f3709ea0f8e77ced35e1655e767496d7 
slimit-0.7.4.zip
3916ff8b58545ee601d6fdc083dfd467f3709ea0f8e77ced35e1655e767496d7 
slimit-0.7.4.zip.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: li

[Bug 859894] Review Request: perl-Test-Dist-VersionSync - Verify that all the modules in a distribution have the same version number

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=859894

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2012-10-04 17:16:44

--- Comment #4 from Emmanuel Seyman  ---
The module has been built on all branches and has been merged in Rawhide.

Robin, thank you for the review. Jon, thank you for the git repo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832068] Review Request: opus-tools - A set of tools for the opus audio codec

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=832068

--- Comment #6 from Jon Ciesla  ---
Already exists, submit a Package Change for new branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #17 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807867] Review Request: python-mdp - A modular toolkit for data processing in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=807867

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m

--- Comment #2 from Mario Blättermann  ---
(In reply to comment #1)
> (In reply to comment #0)
> > Spec URL: http://www.filedropper.com/python-mdp_1
> > SRPM URL: http://www.filedropper.com/python-mdp-32-1fc16src
> 
> They are gone. Please reupload.

Don't use such terrible file hosters. Use Dropbox or anything similar which
allows to download the files directly by clicking the links.

Moreover, you are not in the Package Maintainers group. Please add
FE-NEEDSPONSOR in the "Blocks" field. If you don't want to be sponsored to
become a package maintainer, let us know, then we close this review request as
FE-DEADREVIEW and free it for other packagers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744725] Review Request: opus - An audio codec for use in low-delay speech and audio communication

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=744725

--- Comment #6 from Jon Ciesla  ---
Already exists, submit a Change request for EL branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832068] Review Request: opus-tools - A set of tools for the opus audio codec

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=832068

Peter Robinson  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #5 from Peter Robinson  ---
New Package GIT Request
===
Package Name: opus-tools
Short Description: A set of tools for the opus audio codec
Owners: pbrobinson
Branches: F-17 F-16 EL-5 EL-6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 744725] Review Request: opus - An audio codec for use in low-delay speech and audio communication

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=744725

Peter Robinson  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #5 from Peter Robinson  ---
New Package GIT Request
===
Package Name: opus
Short Description: An audio codec for use in low-delay speech and audio
communication
Owners: pbrobinson
Branches: F-15 F-16 EL-5 EL-6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

--- Comment #8 from Stephen Gallagher  ---
python-odict has now been approved and built in rawhide. You can do a koji
scratch-build against it in about twenty minutes in the rawhide branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #16 from Stephen Gallagher  ---
Package Change Request
==
Package Name: python-odict
New Branches: f16 el6 el5
Owners: sgallagh echevemaster
InitialCC: echevemaster

Eduardo has volunteered to comaintain this package in additional branches.
Pardon for the earlier incorrect name. Bad zodbot lookup. Two Eduardo
Echeverrias

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851891] Review Request: wiki2beamer - Converts a simple wiki-like syntax to complex LaTeX beamer code

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851891

--- Comment #10 from Mario Blättermann  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560936


$ rpmlint -i -v *
wiki2beamer.src: I: checking
wiki2beamer.src: W: spelling-error Summary(en_US) beamer -> bearer, reamer,
beater
The value of this tag appears to be misspelled. Please double-check.

wiki2beamer.src: W: spelling-error %description -l en_US beamer -> bearer,
reamer, beater
The value of this tag appears to be misspelled. Please double-check.

wiki2beamer.src: W: spelling-error %description -l en_US preprocessor ->
processor, predecessor, process's
The value of this tag appears to be misspelled. Please double-check.

wiki2beamer.src: I: checking-url http://sourceforge.net/projects/wiki2beamer
(timeout 10 seconds)
wiki2beamer.src: I: checking-url
http://downloads.sourceforge.net/wiki2beamer/wiki2beamer-0.9.5.zip (timeout 10
seconds)
wiki2beamer.noarch: I: checking
wiki2beamer.noarch: W: spelling-error Summary(en_US) beamer -> bearer, reamer,
beater
The value of this tag appears to be misspelled. Please double-check.

wiki2beamer.noarch: W: spelling-error %description -l en_US beamer -> bearer,
reamer, beater
The value of this tag appears to be misspelled. Please double-check.

wiki2beamer.noarch: W: spelling-error %description -l en_US preprocessor ->
processor, predecessor, process's
The value of this tag appears to be misspelled. Please double-check.

wiki2beamer.noarch: I: checking-url http://sourceforge.net/projects/wiki2beamer
(timeout 10 seconds)
wiki2beamer.spec: I: checking-url
http://downloads.sourceforge.net/wiki2beamer/wiki2beamer-0.9.5.zip (timeout 10
seconds)
2 packages and 1 specfiles checked; 0 errors, 6 warnings.


Some ignorable spelling errors. No issues so far from rpmlint so far.
Nevertheless still some issues from my side:

Remove the %clean section because it is obsolete, unless you want to provide
your package for EPEL 5.

We don't need to declare the CFLAGS. There's no C code included in the tarball.

The README file has to be added to %doc.

Regarding your mail address, I sent a test mail to sdyr...@fedoraproject.org
recently. Once you've got it you may add it to the changelog. BTW, would be
nice and better readable to have an empty line between the changelog entries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Stephen Gallagher  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2012-10-04 16:35:24

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

Bug 862854 depends on bug 862853, which changed state.

Bug 862853 Summary: Review Request: python-odict - Ordered dictionary
https://bugzilla.redhat.com/show_bug.cgi?id=862853

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Stephen Gallagher  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #15 from Stephen Gallagher  ---
Package Change Request
==
Package Name: python-odict
New Branches: f16 el6 el5
Owners: sgallagh tato650
InitialCC: tato650

Eduardo has volunteered to comaintain this package in additional branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 842410] Review Request: kupfer - An interface for quick and convenient access to applications and their documents

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=842410

Martin Gieseking  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|martin.giesek...@uos.de
  Flags||fedora-review?

--- Comment #11 from Martin Gieseking  ---
OK, taking this one. Give me a couple of days to find some time to do the
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860518] Review Request: mate-panel - MATE Desktop panel applets

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860518

--- Comment #18 from Fedora Update System  ---
mate-panel-1.4.0-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-6.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860518] Review Request: mate-panel - MATE Desktop panel applets

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860518

--- Comment #17 from Fedora Update System  ---
mate-panel-1.4.0-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mate-panel-1.4.0-6.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860518] Review Request: mate-panel - MATE Desktop panel applets

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860518

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #14 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 842410] Review Request: kupfer - An interface for quick and convenient access to applications and their documents

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=842410

--- Comment #10 from Mario Blättermann  ---
OK, here we go:

Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/kupfer.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/kupfer-208-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Stephen Gallagher  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #13 from Stephen Gallagher  ---
New Package SCM Request
===
Package Name: python-odict
Short Description: Ordered dictionary
Owners: sgallagh
Branches: f18 f17
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Eduardo Echeverria  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #12 from Eduardo Echeverria  ---
Again, excuse me, and thank you for your patience:

Koji Build Rawhide (OK)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560545

Koji Build F18 (OK)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560565

Koji Build F17 (OK)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560740

Koji Build F16 (OK)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560837

Koji Build EL5 (with rpmbuild-md5) (OK)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560854

Koji Build EL6 (OK)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560841

Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "Unknown or generated". 1 files have unknown license. Detailed output of
 licensecheck in /home/makerpm/862853-python-odict/licensecheck.txt
Python License
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
 Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.

Python:
[x]: Package contains BR: python2-devel or python3-devel

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: Buildroot is not present
 Note: Buildroot: present but not needed
[-]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[?]: 

[Bug 851891] Review Request: wiki2beamer - Converts a simple wiki-like syntax to complex LaTeX beamer code

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851891

--- Comment #9 from Sebastian Dyroff  ---
I will add the email address . Should I do a version
bump just for this change? There may be more work. Or should i fix this first?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 720857] Review Request: datalog - A Lightweight Deductive Database using Datalog

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=720857

--- Comment #46 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 720857] Review Request: datalog - A Lightweight Deductive Database using Datalog

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=720857

John D. Ramsdell  changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

--- Comment #7 from Stephen Gallagher  ---
The spec file in the SRPM itself doesn't have the release tag as part of the
name. I just named it that way so you could do a diff of the -2 and -3 versions
easily if you wanted to see what I changed.

The package would use the correct spec naming when submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160

--- Comment #6 from Sebastian Dyroff  ---
Does still not work for me (f17). I even tried a koji scratch build for
rawhide, because I wanted to be sure that it is not my system. See
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560328

The build error is now:
utils/vk_config.cpp: In static member function 'static const QString&
VkCfg::tmpDir()':
utils/vk_config.cpp:125:25: error: 'getuid' was not declared in this scope

It builds on f16, see: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=4560328


Regards

Sebastian

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #11 from Eduardo Echeverria  ---
I sincerely apologize : (, rpmlint complains about the dots in the summary and
in the description. 
Did not mean to bother you
Right now I'm doing the review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

--- Comment #6 from Mario Blättermann  ---
Please don't attach the release tag to the spec file name. It's unnecessary
because we have the release tag in the file itself anyway. No matter for the
time being, I will wait in any case until python-odict is up, because I've
currently no Mock installation available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 859795] Review Request: sha - File hashing utility

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=859795

--- Comment #5 from Eduardo Echeverria  ---
I added the comment Guillermo:

Spec URL: http://echevemaster.fedorapeople.org/sha/3/sha.spec
SRPM URL: http://echevemaster.fedorapeople.org/sha/3/sha-1.0.4a-3.fc17.src.rpm

Best Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860521] Review Request: mate-session-manager - MATE Desktop session manager

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860521

--- Comment #12 from Fedora Update System  ---
mate-session-manager-1.4.0-4.fc18 has been submitted as an update for Fedora
18.
https://admin.fedoraproject.org/updates/mate-session-manager-1.4.0-4.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860521] Review Request: mate-session-manager - MATE Desktop session manager

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860521

--- Comment #11 from Fedora Update System  ---
mate-session-manager-1.4.0-4.fc17 has been submitted as an update for Fedora
17.
https://admin.fedoraproject.org/updates/mate-session-manager-1.4.0-4.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860521] Review Request: mate-session-manager - MATE Desktop session manager

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860521

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #10 from Stephen Gallagher  ---
The spec file in the SRPM *does* have the same name as the package. I just
renamed it in my fedorapeople space so that you could diff it to the previous
versions if you were so inclined. I'll attach a non-renamed version below.

I've removed the python macro and reordered the sections (though the latter I
think is a bit pedantic).

Spec:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict.spec

SRPM:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict-1.5.0-4.fc18.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4560445

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #9 from Eduardo Echeverria  ---
You have macro in comment too 
%{__python}, fix this please; 
Incorrect:
# Tests are broken upstream and also require unpackaged python-interlude
# Uncomment when fixed upstream
# %{__python} setup.py test -m odict.tests 

Correct:
# Tests are broken upstream and also require unpackaged python-interlude
# Uncomment when fixed upstream
# python setup.py test -m odict.tests

Please remove the last dot (.) of the description
Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #8 from Eduardo Echeverria  ---
Hi Stephen
the spec should have the same name of the package 
Incorrect: python-odict-3.spec
Correct: python-odict

something else
the section %check generally should be collocated after %build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

--- Comment #9 from Fedora Update System  ---
xkbset-0.5-2.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860697] Review Request: tmw - The Mana World is a 2D MMORPG

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860697

--- Comment #12 from Fedora Update System  ---
tmw-20110911-2.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860697] Review Request: tmw - The Mana World is a 2D MMORPG

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860697

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #7 from Fedora Update System  ---
tmw-music-0.3-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tmw-music-0.3-5.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #6 from Fedora Update System  ---
tmw-music-0.3-5.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/tmw-music-0.3-5.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #5 from Fedora Update System  ---
tmw-music-0.3-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tmw-music-0.3-5.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 863198] Review Request: gant - Groovy-based build system that uses Ant tasks

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=863198

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 863198] New: Review Request: gant - Groovy-based build system that uses Ant tasks

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=863198

Bug ID: 863198
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: gant - Groovy-based build system that
uses Ant tasks
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: punto...@libero.it
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL: http://gil.fedorapeople.org/gant.spec
SRPM URL: http://gil.fedorapeople.org/gant-1.9.8-1.fc16.src.rpm
Description: Gant is a tool for scripting Ant tasks using Groovy instead of XML
to
specify the logic. A Gant specification is a Groovy script and so can bring
all the power of Groovy to bear directly, something not possible with Ant
scripts. Whilst it might be seen as a competitor to Ant, Gant uses Ant tasks
for many of the actions, so Gant is really an alternative way of doing
things using Ant, but using a programming language rather than XML to
specify the rules.
Fedora Account System Username: gil
tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4559658

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858060] Review Request: qpid-snmpd - SNMP agent for qpid broker

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858060

--- Comment #15 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 850750] Review Request: python-warlock - Python object model built on top of JSON schema

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=850750

--- Comment #12 from Fedora Update System  ---
python-warlock-0.4.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-warlock-0.4.0-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858060] Review Request: qpid-snmpd - SNMP agent for qpid broker

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858060

Ernie  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #14 from Ernie  ---
New Package SCM Request
===
Package Name: qpid-snmpd
Short Description: SNMP agent for Amqp qpid broker
Owners: eallen
Branches: f16 f17 f18 el6
InitialCC: mcpierce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 831871] Review Request: openstack-swift-plugin-swift3 - The swift3 plugin for Openstack Swift

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=831871

--- Comment #9 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 831871] Review Request: openstack-swift-plugin-swift3 - The swift3 plugin for Openstack Swift

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=831871

Alan Pevec  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #8 from Alan Pevec  ---
Package Change Request
==
Package Name: openstack-swift-plugin-swift3
New Branches: el6
Owners: apevec zaitcev

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 863145] Review Request: listadmin - Command line interface to mailman mailing lists

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=863145

--- Comment #1 from Trever Fischer  ---
Koji build success: http://koji.fedoraproject.org/koji/taskinfo?taskID=4559331

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862160] Review Request: valkyrie - Graphical User Interface for Valgrind Suite

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862160

Thibault North  changed:

   What|Removed |Added

 CC||thibault.no...@gmail.com

--- Comment #5 from Thibault North  ---
Works for me (f16) with the following rpmlint output:
rpmlint -v /home/tnorth/rpmbuild/SRPMS/valkyrie-2.0.0-2.fc16.src.rpm
/home/tnorth/rpmbuild/RPMS/x86_64/valkyrie-2.0.0-2.fc16.x86_64.rpm
/home/tnorth/rpmbuild/RPMS/x86_64/valkyrie-debuginfo-2.0.0-2.fc16.x86_64.rpm
valkyrie.src: I: checking
valkyrie.src: I: checking-url http://www.valgrind.org/ (timeout 10 seconds)
valkyrie.src: I: checking-url
http://www.valgrind.org/downloads/valkyrie-2.0.0.tar.bz2 (timeout 10 seconds)
valkyrie.x86_64: I: checking
valkyrie.x86_64: I: checking-url http://www.valgrind.org/ (timeout 10 seconds)
valkyrie.x86_64: E: incorrect-fsf-address /usr/share/doc/valkyrie-2.0.0/COPYING
valkyrie.x86_64: W: no-manual-page-for-binary valkyrie
valkyrie.x86_64: W: install-file-in-docs /usr/share/doc/valkyrie-2.0.0/INSTALL
valkyrie-debuginfo.x86_64: I: checking
valkyrie-debuginfo.x86_64: I: checking-url http://www.valgrind.org/ (timeout 10
seconds)
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

Looks like the FSF address needs fixing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

--- Comment #7 from Stephen Gallagher  ---
Thanks for the additional review. Added.

Spec:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict-3.spec

SRPM:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict-1.5.0-3.fc18.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4559277

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 863145] New: Review Request: listadmin - Command line interface to mailman mailing lists

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=863145

Bug ID: 863145
QA Contact: extras...@fedoraproject.org
  Severity: medium
   Version: rawhide
  Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
  Assignee: nob...@fedoraproject.org
   Summary: Review Request: listadmin - Command line interface to
mailman mailing lists
Regression: ---
  Story Points: ---
Classification: Fedora
OS: Linux
  Reporter: wm...@wm161.net
  Type: ---
 Documentation: ---
  Hardware: All
Mount Type: ---
Status: NEW
 Component: Package Review
   Product: Fedora

Spec URL: http://wm161.net/~tdfischer/listadmin.spec
SRPM URL: http://wm161.net/~tdfischer/listadmin-2.40-1.fc17.src.rpm
Description:
Mailman has a friendly but rather awkward web interface for manipulating the 
queue of messages held for moderator approval. It is designed to keep user
interaction to a minimum, in theory you could run it from cron to prune the 
queue. It can use the score from a header added by SpamAssassin to filter, or
it
can match specific senders, subjects, or reasons.
Fedora Account System Username: tdfischer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

--- Comment #5 from Stephen Gallagher  ---
Updated spec replaces 'slimit' with %{pkgname}

Spec:
http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-3.spec

SRPM:
http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-0.7.4-3.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Eduardo Echeverria  changed:

   What|Removed |Added

  Flags|needinfo?(echevemaster@gmai |
   |l.com)  |

--- Comment #6 from Eduardo Echeverria  ---
Hi Sthepen

- If tests is are available they must be used, but this tests being broken, are
not available,  so you can ignore such. (You can add a comment in the spec)

- Add %clean section in the spec

After that,  I proceed to formal review

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 839649] Review Request: rubygem-rails_best_practices - a code metric tool for rails codes, written in Ruby.

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=839649

--- Comment #6 from Maros Zatko  ---
updated:
Spec URL: http://v3.sk/~hexo/rpm/rubygem-rails_best_practices.spec
SRPM URL:
http://v3.sk/~hexo/rpm/rubygem-rails_best_practices-1.10.1-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Stephen Gallagher  changed:

   What|Removed |Added

 Blocks||862854

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

Stephen Gallagher  changed:

   What|Removed |Added

 Depends On||862853

--- Comment #4 from Stephen Gallagher  ---
You can build it locally if you install the scratch build of python-odict from
BZ #862853

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #4 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Martin Gieseking  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #3 from Martin Gieseking  ---
Great. Thank you for the immediate review. Upstream is already informed about
the license issue, and will hopefully fix it shortly.


New Package SCM Request
===
Package Name: tmw-music
Short Description: Music files for The Mana World
Owners: mgieseki
Branches: f16 f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 842410] Review Request: kupfer - An interface for quick and convenient access to applications and their documents

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=842410

Martin Gieseking  changed:

   What|Removed |Added

 CC||martin.giesek...@uos.de

--- Comment #9 from Martin Gieseking  ---
Mario, have you been able to resolve the open issues? I could do the review if
you still intend to maintain the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844070] Review Request: AlsaMixer.app - Simple mixer application for ALSA drivers

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844070

Martin Gieseking  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||martin.giesek...@uos.de
   Assignee|nob...@fedoraproject.org|martin.giesek...@uos.de
  Flags||fedora-review?

--- Comment #1 from Martin Gieseking  ---
I take this tiny one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?

--- Comment #3 from Mario Blättermann  ---
(In reply to comment #2)
> I added a %check section to run the two tests in the tests/ directory that
> have a test_suite() defined. This adds a BuildRequires for python-ply and
> python-odict, the latter of which is under review in BZ #862853 so I cannot
> do a Koji build until that one is approved.
OK, then I'll wait until the depending package is available from the Koji
buildroot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

--- Comment #2 from Stephen Gallagher  ---
Thanks, I fixed up the spec file to include a %clean section, the %defattr as
well as the python sitelib/sitearch header.

I added a %check section to run the two tests in the tests/ directory that have
a test_suite() defined. This adds a BuildRequires for python-ply and
python-odict, the latter of which is under review in BZ #862853 so I cannot do
a Koji build until that one is approved.

Spec:
http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-2.spec

SRPM:
http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-0.7.4-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

--- Comment #8 from Fedora Update System  ---
xkbset-0.5-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/xkbset-0.5-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

--- Comment #7 from Fedora Update System  ---
xkbset-0.5-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/xkbset-0.5-2.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862853] Review Request: python-odict - Ordered dictionary

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862853

Stephen Gallagher  changed:

   What|Removed |Added

  Flags||needinfo?(echevemaster@gmai
   ||l.com)

--- Comment #5 from Stephen Gallagher  ---
Thank you for the review! Yes, the upstream tests are broken (and also require
network access) so I disabled them from the package build.

I wasn't initially targeting EPEL, but I don't see any reason not to add your
recommendations, so that's done.

Spec:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict-2.spec

SRPM:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict-1.5.0-2.fc18.src.rpm

Koji build:
http://sgallagh.fedorapeople.org/packagereview/python-odict/python-odict-1.5.0-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858381] Review Request: jogl2 - Java bindings for the OpenGL API

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858381

--- Comment #6 from gil cattaneo  ---
hi Clément
you should add BuildRequires: p7zip in spec file
thanks
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860521] Review Request: mate-session-manager - MATE Desktop session manager

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860521

--- Comment #10 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860518] Review Request: mate-panel - MATE Desktop panel applets

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860518

--- Comment #16 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 853694] Review Request: mate-control-center - MATE Desktop control center

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=853694

--- Comment #29 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=846913

--- Comment #35 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851641] Review Request: lprof - An open source color profiler that creates ICC compliant profiles

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851641

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m
 Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #7 from Mario Blättermann  ---
Lifting FE-NEEDSPONSOR, I'm sponsoring Sebastian.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862854] Review Request: python-slimit - JavaScript minifier written in Python

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862854

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m

--- Comment #1 from Mario Blättermann  ---
Is this intended to go into EPEL5? If yes, you have to add a %clean section and
the %defattr line in %files. If not, please remove the BuildRoot definition.

Moreover, you should run the tests in the slimit/tests folder if possible.
Place the appropriate commands in a %check section after %install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807432] Review Request: python-tate-bilinear-pairing - A Python 2/3 library for calculating Tate bilinear pairing

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=807432

--- Comment #6 from Mario Blättermann  ---
Any news...?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851891] Review Request: wiki2beamer - Converts a simple wiki-like syntax to complex LaTeX beamer code

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=851891

--- Comment #8 from Mario Blättermann  ---
(In reply to comment #5)
> I know, that a e-mail address needs to be included in the changelog. I do
> not have a fedoraproject alias. Should i insert a private address or is it
> ok, to insert the address later.

Either use your bugzilla address  or
 which you'll get automatically once you are a
packager.

I've added your FAS account to the packagers group. Once your package is
approved (which will happen soon) please add me as a comaintainer. Because I'm
not a provenpackager, I wouln't have access to this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Mario Blättermann  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #2 from Mario Blättermann  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4558266

$ rpmlint -i -v *
tmw-music.src: I: checking
tmw-music.src: I: checking-url http://themanaworld.org (timeout 10 seconds)
tmw-music.src: I: checking-url
http://downloads.sourceforge.net/themanaworld/TMW%20Music/0.3/tmwmusic-0.3.tar.gz
(timeout 10 seconds)
tmw-music.noarch: I: checking
tmw-music.noarch: I: checking-url http://themanaworld.org (timeout 10 seconds)
tmw-music.noarch: E: incorrect-fsf-address /usr/share/doc/tmw-music-0.3/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tmw-music.spec: I: checking-url
http://downloads.sourceforge.net/themanaworld/TMW%20Music/0.3/tmwmusic-0.3.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

No issues so far. As usual, don't touch the license file, but please inform the
upstream folks about the wrong FSF address.


-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
9c942b0f9a9a3692f2a0c80b0a7433d7b0adaa35e6c85eab26723299b6c9c4bb 
tmwmusic-0.3.tar.gz
9c942b0f9a9a3692f2a0c80b0a7433d7b0adaa35e6c85eab26723299b6c9c4bb 
tmwmusic-0.3.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[.] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation fil

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mario.blaetterm...@gmail.co
   ||m
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?

--- Comment #1 from Mario Blättermann  ---
Taking this for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 860697] Review Request: tmw - The Mana World is a 2D MMORPG

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=860697

--- Comment #11 from Mario Blättermann  ---
(In reply to comment #5)
> Thanks for the review, Mario. Would you mind to also have a look at the
> companion package tmw-music (bug 860703)? If you have an open review
> request, I could take it in return. 
OK, I'll have a look at it. A review swap is much appreciated, look here at my
open reviews:
https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&component=Package%20Review&email1=mario.blaettermann%40gmail.com&emailreporter1=1&emailtype1=exact&product=Fedora&query_format=advanced&query_format=advanced&version=rawhide&order=bug_id&list_id=633379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 862368] Review Request: xkbset - Tool to configure XKB extensions

2012-10-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=862368

Till Maas  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #5 from Till Maas  ---
New Package SCM Request
===
Package Name: xkbset
Short Description: Configure XKB extensions
Owners: till
Branches: f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >