[Bug 859032] Review Request: ghc-data-memocombinators - Combinators for building memo tables
https://bugzilla.redhat.com/show_bug.cgi?id=859032 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859032] Review Request: ghc-data-memocombinators - Combinators for building memo tables
https://bugzilla.redhat.com/show_bug.cgi?id=859032 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ghc-data-memocombinators-0.4.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-data-memocombinators-0.4.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859032] Review Request: ghc-data-memocombinators - Combinators for building memo tables
https://bugzilla.redhat.com/show_bug.cgi?id=859032 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ghc-data-memocombinators-0.4.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ghc-data-memocombinators-0.4.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864315] New: Review Request: lonote - Personal Notebook based on Qt Webkit
https://bugzilla.redhat.com/show_bug.cgi?id=864315 Bug ID: 864315 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: lonote - Personal Notebook based on Qt Webkit Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: robinlee.s...@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://cheeselee.fedorapeople.org/lonote.spec SRPM URL: http://cheeselee.fedorapeople.org/lonote-1.8.6-1.fc17.src.rpm Description: LoNote is a Note-Taking software based on Python3 and PyQt4. Each page is saved in HTML format and the program is actually a WYSIWYG HTML editor specialized for note-taking convenience. Fedora Account System Username: cheeselee -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 856238] Review Request: scratch - Programming language learning environment for stories, games, music and art
https://bugzilla.redhat.com/show_bug.cgi?id=856238
Michel Alexandre Salim michel+...@sylvestre.me changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #14 from Michel Alexandre Salim michel+...@sylvestre.me ---
Some minor issues with deprecated fields (e.g. BuildRoot, %clean) that only
apply to RHEL 5 or RHEL, but those are just cosmetic.
You probably should make the arch-specific subpackages depend on the main
Scratch package of the same archiecture -- see the [!] note below -- when
importing the package.
Other than that, package is fine -- APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
There's a pre-built image but this is normal for Smalltalk
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
squeak-cameraplugin, %package media, %package squeak-unicodeplugin,
%package i18n, %package image, %package projects, %package help, %package
squeak-wedoplugin, %package squeak-scratchplugin
For the noarch subpackages, this does not matter, but for the
arch-specific subpackages, maybe depending on scratch with the
same architecture would prevent problems if someone ever tries to
mix and match 32- and 64-bit Scratch plugins
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
MIT/X11 (BSD like), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in
/home/michel/sources/fedora/reviews/review-scratch/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build
[Bug 861893] Review Request: libmongo-client - Alternative C driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=861893 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 861893] Review Request: libmongo-client - Alternative C driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=861893 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- libmongo-client-0.1.5-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmongo-client-0.1.5-6.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864066] Review Request: libecb - Compiler built-ins
https://bugzilla.redhat.com/show_bug.cgi?id=864066 --- Comment #1 from Petr Pisar ppi...@redhat.com --- This package will go into F≥18 due to reverse dependencies. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 861893] Review Request: libmongo-client - Alternative C driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=861893 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- libmongo-client-0.1.5-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libmongo-client-0.1.5-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863719] Review Request: ivykis - Library for asynchronous I/O readiness notification
https://bugzilla.redhat.com/show_bug.cgi?id=863719 Jose Pedro Oliveira j...@di.uminho.pt changed: What|Removed |Added Blocks||700766 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863437] Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio
https://bugzilla.redhat.com/show_bug.cgi?id=863437 Christian Fredrik Kalager Schaller cscha...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Christian Fredrik Kalager Schaller cscha...@redhat.com --- No matter, Brian can add himself later on. Please go ahead and create the module without him on the cc list. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 Imre Farkas ifar...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Imre Farkas ifar...@redhat.com --- New Package SCM Request === Package Name: rubygem-simple_form Short Description: Flexible and powerful components to create forms Owners: ifarkas Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864334] New: Review Request: opensaml-java-parent - OpenSAML Java Parent
https://bugzilla.redhat.com/show_bug.cgi?id=864334 Bug ID: 864334 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: opensaml-java-parent - OpenSAML Java Parent Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mgold...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://goldmann.fedorapeople.org/package_review/opensaml-java-parent/4-1/opensaml-java-parent.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/opensaml-java-parent/4-1/opensaml-java-parent-4-1.fc17.src.rpm Fedora Account System Username: goldmann Description: This package contains the OpenSAML Java Parent Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4573338 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864334] Review Request: opensaml-java-parent - OpenSAML Java Parent
https://bugzilla.redhat.com/show_bug.cgi?id=864334 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864334] Review Request: opensaml-java-parent - OpenSAML Java Parent
https://bugzilla.redhat.com/show_bug.cgi?id=864334 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mizde...@redhat.com Assignee|nob...@fedoraproject.org|mizde...@redhat.com Flags||fedora-review? --- Comment #1 from Mikolaj Izdebski mizde...@redhat.com --- I am taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859586] Review Request: gsm-ussd - USSD query tool
https://bugzilla.redhat.com/show_bug.cgi?id=859586 --- Comment #19 from MartinKG mgans...@alice.de --- will do the review later that day. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863437] Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio
https://bugzilla.redhat.com/show_bug.cgi?id=863437 --- Comment #9 from Yanko Kaneti yan...@declera.com --- New Package SCM Request === Package Name: webrtc-audio-processing Short Description: Echo cancellation module for PulseAudio and others Owners: uraeus rishi Branches: f17 f18 InitialCC: bpepple rdieter -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862216] Review Request: libdivecomputer - Library for communication with dive computers
https://bugzilla.redhat.com/show_bug.cgi?id=862216 --- Comment #3 from Pierre-YvesChibon pin...@pingoured.fr --- Update: Spec URL: http://pingou.fedorapeople.org/RPMs//libdivecomputer.spec SRPM URL: http://pingou.fedorapeople.org/RPMs//libdivecomputer-0.2.0-2.fc17.src.rpm * Tue Oct 02 2012 Pierre-Yves Chibon pin...@pingoured.fr - 0.2.0-2 - Update License field from LGPLv2 to LGPLv2+ - Remove explicit Require to libusb1 - Remove the rm -rf RPM_BUILD_ROOT at the top of the install section (not needed anymore by modern rpm) - Remove the macros in comments -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862531] Review Request: jbossws-parent - JBossWS Parent
https://bugzilla.redhat.com/show_bug.cgi?id=862531 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862531] Review Request: jbossws-parent - JBossWS Parent
https://bugzilla.redhat.com/show_bug.cgi?id=862531 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- jbossws-parent-1.1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jbossws-parent-1.1.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862531] Review Request: jbossws-parent - JBossWS Parent
https://bugzilla.redhat.com/show_bug.cgi?id=862531 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- jbossws-parent-1.1.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jbossws-parent-1.1.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864334] Review Request: opensaml-java-parent - OpenSAML Java Parent
https://bugzilla.redhat.com/show_bug.cgi?id=864334
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Mikolaj Izdebski mizde...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[!]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[!]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX tarball generation or download is documented.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Java
[x]: MUST If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]:
[Bug 864334] Review Request: opensaml-java-parent - OpenSAML Java Parent
https://bugzilla.redhat.com/show_bug.cgi?id=864334 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Flags||fedora-cvs? --- Comment #3 from Marek Goldmann mgold...@redhat.com --- Thanks! New Package SCM Request === Package Name: opensaml-java-parent Short Description: OpenSAML Java Parent Owners: goldmann Branches: f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- libcommuni-1.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libcommuni-1.2.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #37 from Fedora Update System upda...@fedoraproject.org --- libcommuni-1.2.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libcommuni-1.2.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata
https://bugzilla.redhat.com/show_bug.cgi?id=737401 --- Comment #21 from Volker Fröhlich volke...@gmx.at --- Sorry, that was my mistake! I uploaded a spec file that had a draft patch to work around the proj problem. I removed it and it's building fine now: http://www.geofrogger.net/review/saga.spec http://www.geofrogger.net/review/saga-2.0.8-4.fc16.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=4573430 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863983] Review Request: ninja-ide - Ninja IDE for Python development
https://bugzilla.redhat.com/show_bug.cgi?id=863983 --- Comment #4 from Nikos Roussos ni...@roussos.cc --- Thanks for taking this I think I fixed all errors updated spec: http://comzeradd.fedorapeople.org/ninja-ide.spec SRPM: http://comzeradd.fedorapeople.org/ninja-ide-2.1.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739367] Review Request: php-pecl-mysqlnd-qc - A query cache plugin for mysqlnd
https://bugzilla.redhat.com/show_bug.cgi?id=739367 --- Comment #8 from Remi Collet fed...@famillecollet.com --- Even if I don't see in the Guidelines why this MUST be removed... (just that it is no more required, and will be ignored) Changes: https://github.com/remicollet/remirepo/commit/88966fcfacf680a8a54956a03e74381d90f2c314 https://github.com/remicollet/remirepo/commit/abe2d328f9dfe390f7ecaa3f5693017b927cfbfb New SRPM: http://rpms.famillecollet.com/SRPMS/php-pecl-mysqlnd-qc-1.1.1-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843775] Review Request: rubygem-temple - Template compilation framework in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=843775 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844070] Review Request: alsamixer-dockapp - Simple mixer application for ALSA drivers
https://bugzilla.redhat.com/show_bug.cgi?id=844070 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847794] Review Request: gl3n An OpenGL Mathematics library for D
https://bugzilla.redhat.com/show_bug.cgi?id=847794 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851279] Review Request: eucalyptus - Elastic Utility Computing Architecture
https://bugzilla.redhat.com/show_bug.cgi?id=851279 --- Comment #30 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852214] Review Request: overpass-fonts - Typeface based on the U.S. interstate highway road signage type system
https://bugzilla.redhat.com/show_bug.cgi?id=852214 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857487] Review Request: ht-alegreya-fonts - A Serif typeface originally intended for literature
https://bugzilla.redhat.com/show_bug.cgi?id=857487 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859586] Review Request: gsm-ussd - USSD query tool
https://bugzilla.redhat.com/show_bug.cgi?id=859586 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Review not complete. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability
https://bugzilla.redhat.com/show_bug.cgi?id=864125 Paul Flo Williams p...@frixxon.co.uk changed: What|Removed |Added CC||p...@frixxon.co.uk --- Comment #1 from Paul Flo Williams p...@frixxon.co.uk --- Please remember to place fonts-sig on the InitialCC for this one, thank you. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863437] Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio
https://bugzilla.redhat.com/show_bug.cgi?id=863437 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863769] Review Request: cura-tools - set of CLI tools for cura providers
https://bugzilla.redhat.com/show_bug.cgi?id=863769 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864089] Review Request: nemo-open-terminal - Nemo extension for an open terminal shortcut
https://bugzilla.redhat.com/show_bug.cgi?id=864089 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864334] Review Request: opensaml-java-parent - OpenSAML Java Parent
https://bugzilla.redhat.com/show_bug.cgi?id=864334 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859586] Review Request: gsm-ussd - USSD query tool
https://bugzilla.redhat.com/show_bug.cgi?id=859586 MartinKG mgans...@alice.de changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review- -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859586] Review Request: gsm-ussd - USSD query tool
https://bugzilla.redhat.com/show_bug.cgi?id=859586 --- Comment #21 from Ivan Romanov dr...@land.ru --- Martin, fedora‑review‑ means that a review fully failed and package won't be accepted. But you will continue review process so I think you should to use fedora‑review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857801] Review Request: TigerVNC EL5 - VNC remote display server/client
https://bugzilla.redhat.com/show_bug.cgi?id=857801 Adam Tkac at...@redhat.com changed: What|Removed |Added Status|CLOSED |ASSIGNED CC||at...@redhat.com Resolution|NOTABUG |--- Keywords||Reopened --- Comment #4 from Adam Tkac at...@redhat.com --- (In reply to comment #3) Have you spoken to the other tigervnc branch owners about this? I'm fine with the el5 branch. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- rubygem-simple_form-2.0.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-simple_form-2.0.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864432] New: Review Request: owasp-esapi-java - OWASP Enterprise Security API
https://bugzilla.redhat.com/show_bug.cgi?id=864432 Bug ID: 864432 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: owasp-esapi-java - OWASP Enterprise Security API Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mgold...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://goldmann.fedorapeople.org/package_review/owasp-esapi-java/2.0.1-1/owasp-esapi-java.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/owasp-esapi-java/2.0.1-1/owasp-esapi-java-2.0.1-1.fc17.src.rpm Fedora Account System Username: goldmann Description: OWASP ESAPI (The OWASP Enterprise Security API) is a free, open source, web application security control library that makes it easier for programmers to write lower-risk applications. The ESAPI for Java library is designed to make it easier for programmers to retrofit security into existing applications. ESAPI for Java also serves as a solid foundation for new development. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4573969 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864432] Review Request: owasp-esapi-java - OWASP Enterprise Security API
https://bugzilla.redhat.com/show_bug.cgi?id=864432 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- rubygem-simple_form-2.0.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-simple_form-2.0.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864464] New: Review Request: python-tox - virtualenv-based automation of test activities
https://bugzilla.redhat.com/show_bug.cgi?id=864464
Bug ID: 864464
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: python-tox - virtualenv-based
automation of test activities
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: mru...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://www.matthias-runge.de/fedora/python-tox.spec
SRPM URL: http://www.matthias-runge.de/fedora/python-tox-1.4.2-1.fc17.src.rpm
Description:
Tox as is a generic virtualenv management and test command line tool you
can use for:
- checking your package installs correctly with different Python versions
and interpreters
- running your tests in each of the environments, configuring your test tool
of choice
- acting as a frontend to Continuous Integration servers, greatly reducing
boilerplate and merging CI and shell-based testing.
Fedora Account System Username: mrunge
[mrunge@turing SPECS]$ rpmlint ./python-tox.spec
../SRPMS/python-tox-1.4.2-1.fc17.src.rpm
../RPMS/noarch/python3-tox-1.4.2-1.fc17.noarch.rpm
../RPMS/noarch/python-tox-1.4.2-1.fc17.noarch.rpm
./python-tox.spec:69: W: macro-in-comment %check
./python-tox.spec:70: W: macro-in-comment %{__python}
./python-tox.spec:71: W: macro-in-comment %{py3dir}
./python-tox.spec:72: W: macro-in-comment %{__python3}
python-tox.src: W: spelling-error Summary(en_US) virtualenv - virtual
python-tox.src: W: summary-not-capitalized C virtualenv-based automation of
test activities
python-tox.src: W: spelling-error %description -l en_US virtualenv - virtual
python-tox.src: W: spelling-error %description -l en_US frontend - fronted,
front end, front-end
python-tox.src:69: W: macro-in-comment %check
python-tox.src:70: W: macro-in-comment %{__python}
python-tox.src:71: W: macro-in-comment %{py3dir}
python-tox.src:72: W: macro-in-comment %{__python3}
python3-tox.noarch: W: spelling-error Summary(en_US) virtualenv - virtual
python3-tox.noarch: W: summary-not-capitalized C virtualenv-based automation of
test activities
python3-tox.noarch: W: spelling-error %description -l en_US virtualenv -
virtual
python3-tox.noarch: W: spelling-error %description -l en_US frontend -
fronted, front end, front-end
python-tox.noarch: W: spelling-error Summary(en_US) virtualenv - virtual
python-tox.noarch: W: summary-not-capitalized C virtualenv-based automation of
test activities
python-tox.noarch: W: spelling-error %description -l en_US virtualenv -
virtual
python-tox.noarch: W: spelling-error %description -l en_US frontend - fronted,
front end, front-end
python-tox.noarch: W: no-manual-page-for-binary tox
3 packages and 1 specfiles checked; 0 errors, 21 warnings.
I am fully aware of those warnings. Nevertheless, I'll keep the comments for
completeness there.
Koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=4574063
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- rubygem-simple_form-2.0.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-simple_form-2.0.3-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864481] New: Review Request: Django14 - A high-level Python Web framework
https://bugzilla.redhat.com/show_bug.cgi?id=864481 Bug ID: 864481 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: Django14 - A high-level Python Web framework Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mru...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://www.matthias-runge.de/fedora/Django14.spec SRPM URL: http://www.matthias-runge.de/fedora/Django14-1.4.1-1.el6.src.rpm Description: Django is a high-level Python Web framework that encourages rapid development and a clean, pragmatic design. It focuses on automating as much as possible and adhering to the DRY (Don't Repeat Yourself) principle. Fedora Account System Username: mrunge Please note, this version is intended for EPEL6 only, and there is also an older version not to be replaced. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864464] Review Request: python-tox - virtualenv-based automation of test activities
https://bugzilla.redhat.com/show_bug.cgi?id=864464 Adam Young ayo...@redhat.com changed: What|Removed |Added CC||ayo...@redhat.com --- Comment #1 from Adam Young ayo...@redhat.com --- This package is required for the Continuous Integration (CI) system of Openstack. The various projects are moving from using nosetests and a venv to tox in order to keep in sync with CI. Just confirmed that it builds on mine. Just needed to install the Python3 dependencies. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864464] Review Request: python-tox - virtualenv-based automation of test activities
https://bugzilla.redhat.com/show_bug.cgi?id=864464 --- Comment #2 from Adam Young ayo...@redhat.com --- Installed the RPM and attempted to run Tox for Keystone. Installed: python-tox.noarch 0:1.4.2-1.f17ayoung $ tox Traceback (most recent call last): File /usr/bin/tox, line 5, in module from pkg_resources import load_entry_point File /usr/lib/python3.2/site-packages/pkg_resources.py, line 2736, in module working_set.require(__requires__) File /usr/lib/python3.2/site-packages/pkg_resources.py, line 690, in require needed = self.resolve(parse_requirements(requirements)) File /usr/lib/python3.2/site-packages/pkg_resources.py, line 588, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: tox==1.4.2 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 734248] Review Request: apf - Adventure PHP Framework
https://bugzilla.redhat.com/show_bug.cgi?id=734248 --- Comment #10 from Reiner Rottmann rei...@rottmann.it --- Is there anything else I could do in order to get sponsored and to succeed with the Adventure PHP Framework review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability
https://bugzilla.redhat.com/show_bug.cgi?id=864125 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? | Flags||fedora-review+ --- Comment #2 from Parag AN(पराग) panem...@gmail.com --- Review:- + Koji scratch build for rawhide - koji.fedoraproject.org/koji/taskinfo?taskID=4574139 + rpmlint on rpms gave opendyslexic-fonts.src: W: invalid-url Source0: opendyslexic-20121008git0c6748ab6b.tar.bz2 2 packages and 0 specfiles checked; 0 errors, 1 warnings. == This warning is ok as git snapshot is used. + License is packaged and is Bitstream Vera and CC-BY + Follows fonts packaging guidelines. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864531] New: Review Request: opensaml-java - Java OpenSAML library
https://bugzilla.redhat.com/show_bug.cgi?id=864531 Bug ID: 864531 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: opensaml-java - Java OpenSAML library Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mgold...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-1/opensaml-java.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/opensaml-java/2.5.3-1/opensaml-java-2.5.3-1.fc17.src.rpm Fedora Account System Username: goldmann Description: OpenSAML is a set of open source C++ Java libraries meant to support developers working with the Security Assertion Markup Language (SAML). OpenSAML 2, the current version, supports SAML 1.0, 1.1, and 2.0. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864432] Review Request: owasp-esapi-java - OWASP Enterprise Security API
https://bugzilla.redhat.com/show_bug.cgi?id=864432 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||864531 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 860505] Review request: opensaml-java-openws - Java OpenWS library
https://bugzilla.redhat.com/show_bug.cgi?id=860505 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||864531 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864531] Review Request: opensaml-java - Java OpenSAML library
https://bugzilla.redhat.com/show_bug.cgi?id=864531 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Depends On||860505, 864432 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859819] Review Request: almas-mongolian-title-fonts - Mongolian Title font
https://bugzilla.redhat.com/show_bug.cgi?id=859819 Parag pnem...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ta...@redhat.com Flags||fedora-cvs? --- Comment #7 from Parag pnem...@redhat.com --- New Package SCM Request === Package Name: almas-mongolian-title-fonts Short Description: Mongolian Title font Owners: pnemade Branches: f18 InitialCC: fonts-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864535] New: Review Request: libvirt-designer - Libvirt configuration designer
https://bugzilla.redhat.com/show_bug.cgi?id=864535 Bug ID: 864535 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: libvirt-designer - Libvirt configuration designer Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mpriv...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://fedorapeople.org/~mprivozn/libvirt-designer/libvirt-designer.spec SRPM URL: http://fedorapeople.org/~mprivozn/libvirt-designer/libvirt-designer-0.0.1-1.fc19.zippy1349791557.src.rpm These URL are however just temporal. Like every libvirt-* package, the real SPEC is within git: http://libvirt.org/git/?p=libvirt-designer.git;a=blob;f=libvirt-designer.spec.in Description: The libvirt-designer package provides a library that integrates libosinfo and libvirt-gconfig. Given an operating system identifier and libvirt host capabilities, it queries the libosinfo database to determine optimal hardware configuration and uses this information to design suitable domain XML for running the OS as a guest. In a similar manner it facilitates the setup of guest hardware devices such as disks, network interfaces, video cards, etc. These APIs are inspired by experience creating internal APIs for similar tasks in the virt-install/virt-manager projects. Fedora Account System Username: mprivozn -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859819] Review Request: almas-mongolian-title-fonts - Mongolian Title font
https://bugzilla.redhat.com/show_bug.cgi?id=859819 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Flags||needinfo?(puntogil@libero.i ||t) --- Comment #2 from Mikolaj Izdebski mizde...@redhat.com --- Fails to build in rawhide mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=4574340 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864084] Review Request: maven-native - Compile c and c++ source under Maven
https://bugzilla.redhat.com/show_bug.cgi?id=864084 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added CC||mizde...@redhat.com --- Comment #1 from Mikolaj Izdebski mizde...@redhat.com --- Maven and C, nice :) Let me know once it builds in rawhide and I'll review this package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825347] Review Request: jersey - JAX-RS (JSR 311) production quality Reference Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=825347 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Flags||needinfo?(puntogil@libero.i ||t) --- Comment #6 from Mikolaj Izdebski mizde...@redhat.com --- Fails to build in rawhide mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=4574382 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839653] Review Request: rubygem-slim - Slim is a template language
https://bugzilla.redhat.com/show_bug.cgi?id=839653 --- Comment #6 from Maros Zatko mza...@redhat.com --- Thank you for review, there is a updated spec srpm. I don't run test suite because of missing dependencies. Spec URL: http://v3.sk/~hexo/rpm/rubygem-slim.spec SRPM URL: http://v3.sk/~hexo/rpm/rubygem-slim-1.2.2-3.fc17.src.rpm Description: Slim is a template language whose goal is reduce the syntax to the essential parts without becoming cryptic. Fedora Account System Username: mzatko -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825347] Review Request: jersey - JAX-RS (JSR 311) production quality Reference Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=825347 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|mizde...@redhat.com |nob...@fedoraproject.org Flags|needinfo?(puntogil@libero.i | |t) | --- Comment #7 from Mikolaj Izdebski mizde...@redhat.com --- I didn't see depends on the other reviews because they were added after I took the review. I'm releasing this review as it doesn't look like it has several missing dependencies for now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 --- Comment #3 from Mikolaj Izdebski mizde...@redhat.com --- This package depends on tanukisoft:wrapper, but currently nothing in fedora provides this artifact. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859586] Review Request: gsm-ussd - USSD query tool
https://bugzilla.redhat.com/show_bug.cgi?id=859586 MartinKG mgans...@alice.de changed: What|Removed |Added Flags|fedora-review- | Flags||fedora-review? --- Comment #22 from MartinKG mgans...@alice.de --- (In reply to comment #21) Ivan, of course, it's my first review. please have a little patience. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864432] Review Request: owasp-esapi-java - OWASP Enterprise Security API
https://bugzilla.redhat.com/show_bug.cgi?id=864432
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mizde...@redhat.com
Assignee|nob...@fedoraproject.org|mizde...@redhat.com
Flags||fedora-review?
--- Comment #1 from Mikolaj Izdebski mizde...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0) For detailed output of licensecheck see file:
/home/kojan/review/864432-owasp-esapi-java/licensecheck.txt
[x]: MUST License file installed when any subpackage combination is installed.
[!]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[!]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream
[Bug 837689] Review Request: pkgwat - CLI tool for querying the fedora packages webapp
https://bugzilla.redhat.com/show_bug.cgi?id=837689 --- Comment #10 from Ralph Bean rb...@redhat.com --- Well, python-prettytable-0.6 is in F18 and looks like it will never be in F17 due to some conflicts with the openstack stack. I just tried and the rpm builds, installs, and works in F18. Luke, would you mind picking up the review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864432] Review Request: owasp-esapi-java - OWASP Enterprise Security API
https://bugzilla.redhat.com/show_bug.cgi?id=864432 --- Comment #2 from Mikolaj Izdebski mizde...@redhat.com --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4574451 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857079] Review Request: fasterxml-oss-parent - FasterXML parent pom
https://bugzilla.redhat.com/show_bug.cgi?id=857079 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mizde...@redhat.com Assignee|nob...@fedoraproject.org|mizde...@redhat.com Flags||fedora-review? --- Comment #1 from Mikolaj Izdebski mizde...@redhat.com --- I am taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837584] Review Request: cargo-resources - Cargo Shared Resources
https://bugzilla.redhat.com/show_bug.cgi?id=837584 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mizde...@redhat.com Assignee|nob...@fedoraproject.org|mizde...@redhat.com Flags||fedora-review? --- Comment #3 from Mikolaj Izdebski mizde...@redhat.com --- I am taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857079] Review Request: fasterxml-oss-parent - FasterXML parent pom
https://bugzilla.redhat.com/show_bug.cgi?id=857079
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Mikolaj Izdebski mizde...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SHOULD SourceX tarball generation or download is documented.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Java
[x]: MUST If source tarball includes bundled jar/class files these need to be
removed prior
[Bug 863437] Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio
https://bugzilla.redhat.com/show_bug.cgi?id=863437 Debarshi Ray debars...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||debars...@redhat.com Resolution|--- |NEXTRELEASE Flags|fedora-cvs+ | Flags||fedora-cvs? Last Closed||2012-10-09 11:57:44 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863437] Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio
https://bugzilla.redhat.com/show_bug.cgi?id=863437 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Already done. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825347] Review Request: jersey - JAX-RS (JSR 311) production quality Reference Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=825347 --- Comment #8 from gil cattaneo punto...@libero.it --- depend on https://bugzilla.redhat.com/show_bug.cgi?id=859114 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843775] Review Request: rubygem-temple - Template compilation framework in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=843775 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- rubygem-temple-0.4.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-temple-0.4.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags|needinfo?(puntogil@libero.i | |t) | --- Comment #4 from gil cattaneo punto...@libero.it --- build fine also with java-service-wrapper but i dont know how fix the problem if use x86_64 arch in koji -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857079] Review Request: fasterxml-oss-parent - FasterXML parent pom
https://bugzilla.redhat.com/show_bug.cgi?id=857079 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: fasterxml-oss-parent Short Description: FasterXML parent pom Owners: gil Branches: f18 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857079] Review Request: fasterxml-oss-parent - FasterXML parent pom
https://bugzilla.redhat.com/show_bug.cgi?id=857079 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739367] Review Request: php-pecl-mysqlnd-qc - A query cache plugin for mysqlnd
https://bugzilla.redhat.com/show_bug.cgi?id=739367 Matthieu Saulnier casper.le.fan...@gmail.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #9 from Matthieu Saulnier casper.le.fan...@gmail.com --- Okay it is ready now - PACKAGE APPROVED - -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821146] Review Request: jruby-rack - Rack adapter for JRuby and Servlet Containers
https://bugzilla.redhat.com/show_bug.cgi?id=821146 Bug 821146 depends on bug 819583, which changed state. Bug 819583 Summary: add maven pom https://bugzilla.redhat.com/show_bug.cgi?id=819583 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 --- Comment #5 from Mikolaj Izdebski mizde...@redhat.com --- (In reply to comment #4) build fine also with java-service-wrapper but i dont know how fix the problem if use x86_64 arch in koji This will definitely have to be resolved. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859586] Review Request: gsm-ussd - USSD query tool
https://bugzilla.redhat.com/show_bug.cgi?id=859586
MartinKG mgans...@alice.de changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #23 from MartinKG mgans...@alice.de ---
Everything looks fine; I'm approving this package
APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in
/home/martin/rpmbuild/SPECS/859586-gsm-ussd/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
Perl:
[x]: Package contains the mandatory BuildRequires and Reguires:.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[!]: SourceX / PatchY prefixed with %{name}.
Note: Source0 (gsm-ussd_0.4.0-25.tar.gz)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec
[Bug 739367] Review Request: php-pecl-mysqlnd-qc - A query cache plugin for mysqlnd
https://bugzilla.redhat.com/show_bug.cgi?id=739367 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Remi Collet fed...@famillecollet.com --- Thanks for the review. New Package SCM Request === Package Name: php-pecl-mysqlnd-qc Short Description: A query cache plugin for mysqlnd Owners: remi Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739367] Review Request: php-pecl-mysqlnd-qc - A query cache plugin for mysqlnd
https://bugzilla.redhat.com/show_bug.cgi?id=739367 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- rubygem-simple_form-2.0.3-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859994] Review Request: rubygem-simple_form - Flexible and powerful components to create forms
https://bugzilla.redhat.com/show_bug.cgi?id=859994 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 --- Comment #38 from Fedora Update System upda...@fedoraproject.org --- libcommuni-1.2.0-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
https://bugzilla.redhat.com/show_bug.cgi?id=846913 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841746] Review Request: ghc-arrows - Classes that extend the Arrow class
https://bugzilla.redhat.com/show_bug.cgi?id=841746 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862531] Review Request: jbossws-parent - JBossWS Parent
https://bugzilla.redhat.com/show_bug.cgi?id=862531 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- jbossws-parent-1.1.0-1.fc18, jbossws-api-1.0.0-3.fc18, jbossws-spi-2.0.3-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841746] Review Request: ghc-arrows - Classes that extend the Arrow class
https://bugzilla.redhat.com/show_bug.cgi?id=841746 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ghc-arrows-0.4.4.0-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859032] Review Request: ghc-data-memocombinators - Combinators for building memo tables
https://bugzilla.redhat.com/show_bug.cgi?id=859032 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 862531] Review Request: jbossws-parent - JBossWS Parent
https://bugzilla.redhat.com/show_bug.cgi?id=862531 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 859032] Review Request: ghc-data-memocombinators - Combinators for building memo tables
https://bugzilla.redhat.com/show_bug.cgi?id=859032 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- ghc-data-memocombinators-0.4.3-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
