[Bug 881589] Review Request: leveldb-java - Port of LevelDB to Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881589 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||881590 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881590] Review Request: leveldbjni - A Java Native Interface to LevelDB
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881590 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||881608, 881589 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881587] Review Request: iq80-snappy - Port of Snappy to Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881587 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||881589 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881589] Review Request: leveldb-java - Port of LevelDB to Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881589 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||881587 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881431] Review Request: zathura-pdf-poppler - PDF support for zathura via poppler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881431 --- Comment #3 from François Cami f...@fcami.net --- zathura-devel-0.2.1 should be available in updates-testing for all currently supported Fedora releases. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881016] Review Request: rubygem-audited - Log all changes to your models
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881016 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Vít Ondruch vondr...@redhat.com --- Thank you for your review. New Package SCM Request === Package Name: rubygem-audited Short Description: Log all changes to your models Owners: vondruch Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851279] Review Request: eucalyptus - Elastic Utility Computing Architecture
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851279 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-29 04:00:41 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879435] Review Request: c-graph - an interactive package that demonstrates the mathematical operation of convolution
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879435 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Whiteboard|AwaitingSubmitter,NotReady |NotReady Last Closed||2012-11-29 04:00:28 --- Comment #7 from Susi Lehtola susi.leht...@iki.fi --- Paulo: please input your full name in bugzilla. And, as you should be aware, the review requests are person specific, so please open a new bug. This one is closed as WONTFIX. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 --- Comment #3 from Miroslav Suchý msu...@redhat.com --- According the code, it is expecting file simplecov_config. Please contact upstream what should be in that file. And either create it yourself and add it as Source1 or ask upstream to include it in gem. If tests are provided with gem, they should be run. And I would say this is blocker for this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832853] Review Request: java3d - Java 3D
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832853 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added CC||punto...@libero.it --- Comment #9 from Xavier Bachelot xav...@bachelot.org --- *** Bug 881586 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881586] Review Request: java3d - 3D Graphics API for the Java Platform
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881586 Xavier Bachelot xav...@bachelot.org changed: What|Removed |Added Status|NEW |CLOSED CC||xav...@bachelot.org Resolution|--- |DUPLICATE Last Closed||2012-11-29 04:42:47 --- Comment #1 from Xavier Bachelot xav...@bachelot.org --- There's already an open review ticket for this package. Please work with the other packager to merge differences in the 2 specs. Afaics, the other review is blocked for a license issue. *** This bug has been marked as a duplicate of bug 832853 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804344] Review Request: package-rename-task - Ant task to relocete code from on package tree to another.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=804344 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2012-11-29 04:48:30 --- Comment #3 from Marek Goldmann mgold...@redhat.com --- I don't think if this is still needed, closing. Please reopen if needed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880195] Review Request: python-di - Dependency injection library for python unittesters
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880195 --- Comment #2 from Martin Sivák msi...@redhat.com --- Thanks, new versions of the spec file and SRPM should be at the addresses in #1. I wasn't planning on providing it for EPEL 5 since I am using some new python features (functools) which were not available in 2.4. It might be possible to port it there though. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845115] Review request: python-django-recaptcha - A Django application for adding ReCAPTCHA to a form
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845115 --- Comment #9 from Bohuslav Slavek Kabrda bkab...@redhat.com --- Ping, any progress on this one? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825494] Review Request: cliquer - Find cliques in arbitrary weighted graphs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=825494 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878515] Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878515 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881016] Review Request: rubygem-audited - Log all changes to your models
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881016 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880763] Review Request: AudioCuesheetEditor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880763
--- Comment #2 from Christoph Wickert cwick...@fedoraproject.org ---
(In reply to comment #0)
./configure
make
make install
Hi Sven,
in an rpm spec file, you should use the %configure macro, see
https://fedoraproject.org/wiki/Packaging:RPMMacros
You also want to speed up the build by using more than one processor, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
And last but not least you want to preserve timestamps during install, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
This results in
%configure
make %{?_smp_mflags}
make install 'INSTALL=install -p'
Your package still needs a lot of work before it can be included in Fedora.
Please read https://fedoraproject.org/wiki/Packaging:Guidelines and try to
improve it. It's not that hard and you are doing fine. Keep up the good work!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786249] Review Request: rubygem-puppet-lint - Tool to verify the style of puppet manifests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=786249 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-29 07:07:49 --- Comment #20 from Bohuslav Slavek Kabrda bkab...@redhat.com --- The package has been built and pushed to stable, I'm closing this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840149] Tracker for MATE packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840149 markm marek7...@o2.pl changed: What|Removed |Added CC||marek7...@o2.pl --- Comment #23 from markm marek7...@o2.pl --- Not sure if it's a right place, I've just installed fresh Fedora 18 in a virtual machine, with Mate-Desktop selected as a DE, got open box installed with no applications - was quite surprised to see empty desktop with no icons, no information whatsoever. Expected mate-desktop to be fully functional desktop, not broken. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840149] Tracker for MATE packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840149 --- Comment #24 from markm marek7...@o2.pl --- (In reply to comment #23) Not sure if it's a right place, I've just installed fresh Fedora 18 in a virtual machine, with Mate-Desktop selected as a DE, got open box installed with no applications - was quite surprised to see empty desktop with no icons, no information whatsoever. Expected mate-desktop to be fully functional desktop, not broken. please ignore my comment, my bad - I must have selected open box instead of mate, tried again and all installed smoothly. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880763] Review Request: AudioCuesheetEditor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880763
--- Comment #3 from Antonio Trande trp...@katamail.com ---
(In reply to comment #2)
(In reply to comment #0)
This results in
%configure
make %{?_smp_mflags}
make install 'INSTALL=install -p'
Your package still needs a lot of work before it can be included in Fedora.
Please read https://fedoraproject.org/wiki/Packaging:Guidelines and try to
improve it. It's not that hard and you are doing fine. Keep up the good work!
Hi Christoph.
As I have seen, configure built with --config=RELEASE-x86 in default (the other
option is debug-x86) so, if I didn't understand fine, this rpm will be an i686
exclusively.
%configure doesn't work because it doesn't recognize
--build=x86_64-unknown-linux-gnu argument (unlike of ./configure).
Is possible the use of ExclusiveArch tag ?
Or are there other ways ?
Also for the first time I see a strange path like bin/Release/* that contains
file .png and .ico .
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832853] Review Request: java3d - Java 3D
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832853 --- Comment #10 from gil cattaneo punto...@libero.it --- there is someone want use this package for some nuclear facility? Spec URL: http://gil.fedorapeople.org/java3d.spec SRPM URL: http://gil.fedorapeople.org/java3d-1.5.2-1.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881431] Review Request: zathura-pdf-poppler - PDF support for zathura via poppler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881431 --- Comment #4 from François Cami f...@fcami.net --- Sorry, wrong url for the SRPM. SRPM URL: http://fcami.fedorapeople.org/srpms/zathura-pdf-poppler-0.2.1-2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881751] New: Review Request: rubygem-pdf-inspector - A tool for analyzing PDF output
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881751 Bug ID: 881751 Summary: Review Request: rubygem-pdf-inspector - A tool for analyzing PDF output Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jstri...@redhat.com Spec URL: http://data-strzibny.rhcloud.com/rubygem-pdf-inspector.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-pdf-inspector-1.0.2-1.fc17.src.rpm Description: This library provides a number of PDF::Reader[0] based tools for use in testing PDF output. Presently, the primary purpose of this tool is to support the tests found in Prawn[1], a pure Ruby PDF generation library. However, it may be useful to others, so we have made it available as a gem in its own right. [0] https://github.com/yob/pdf-reader [1] https://github.com/sandal/prawn Fedora Account System Username: jstribny Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4740723 Note: The gem doesn't come with a test suite, tested only using rpmlint, koji and mock --shell -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] New: Review Request: springframework-batch - Tools for enterprise batch or bulk processing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881753 Bug ID: 881753 Summary: Review Request: springframework-batch - Tools for enterprise batch or bulk processing Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: punto...@libero.it Spec URL: http://gil.fedorapeople.org/springframework-batch.spec SRPM URL: http://gil.fedorapeople.org/springframework-batch-2.1.9-1.fc16.src.rpm Description: Spring Batch provides tools for enterprise batch or bulk processing. It can be used to wire up jobs, and track their execution, or simply as an optimization for repetitive processing in a transactional environment. Spring Batch is part of the Spring Portfolio. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877152] Review Request: springframework-ws - Spring Web Services
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877152 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||881753 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881753 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||877152, 866239 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866239] Review Request: gemini-blueprint - Reference Implementation of the OSGi Blueprint Service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866239 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||881753 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845264] Review Request: maven-artifact-resolver - Maven Artifact Resolution API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845264 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-11-29 09:32:34 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 Mario Santagiuliana fed...@marionline.it changed: What|Removed |Added Summary|Review Request: |Review Request: |kcm-wacomtablet - KDE |kcm_wacomtablet - KDE |Control module for Wacom|Control module for Wacom |Graphictablets |Graphictablets --- Comment #6 from Mario Santagiuliana fed...@marionline.it --- I update the review request and here the new files: Spec URL: http://marionline.fedorapeople.org/packages/SPECS/kcm_wacomtablet.spec SRPM URL: http://marionline.fedorapeople.org/packages/SRPMS/kcm_wacomtablet-1.3.7-2.fc17.src.rpm Is now ok? Thank you very much :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 Mario Santagiuliana fed...@marionline.it changed: What|Removed |Added Alias||kcm_wacomtablet -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 --- Comment #7 from Rex Dieter rdie...@math.unl.edu --- Yes, thanks, looks good. please import/commit. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857484] Review Request: python-simplevisor - Python simple daemons supervisor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857484 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Tomas Radej tra...@redhat.com --- After discussion, I do not further object to these files being put in %doc. However, please ask upstream if they wish that the test files be installed in a distro package. If so, leave them unaffected. If not, you may remove them entirely. I will trust you that you change the macros before importing the package. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878515] Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878515] Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878515 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- rubygem-simplecov-html-0.7.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-simplecov-html-0.7.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878653
Mathieu Bridon boche...@fedoraproject.org changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #9 from Mathieu Bridon boche...@fedoraproject.org ---
First, taking the issues I had raised before.
[x]: Package requires other packages for directories it uses.
[!]: If the source package does not include the text of the license(s), the
packager should contact upstream and encourage them to correct this
mistake.
= Upstream has been notified, and the next release will include it, so this
will do.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package must own all directories that it creates.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
= As I said I wasn't sure about this, but I see you filtered the provides
out, so I trust you figured this was the right thing to do.
[-]: Scriptlets must be sane, if used.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.
[x] Rpmlint is silent (or as silent as reasonable)
The only other difference I see in the spec file is this:
-%if 0%{?fedora} 16
BuildRequires: libgnome-keyring-devel
-%else
-BuildRequires: gnome-keyring-devel
-%endif
= I hadn't seen that the first time, but this is a good change as F16 is EOL
soon anyway.
This new package fixes all issues I had found, and doesn't introduce any new
one, so I'm approving it.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881794] New: Review Request: c-graph - C-Graph is an abbreviation for Convolution Graph
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881794 Bug ID: 881794 Summary: Review Request: c-graph - C-Graph is an abbreviation for Convolution Graph Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: paulo.cesar.pereira.de.andr...@gmail.com Spec URL: http://pcpa.fedorapeople.org/c-graph.spec SRPM URL: http://pcpa.fedorapeople.org/c-graph-2.0-1.fc19.src.rpm Description: GNU C-Graph is a novel tool for visualizing the mathematical operation of convolution underlying natural phenomena susceptible to analysis in terms of engineering signals and systems theory. C-Graph is an abbreviation for Convolution Graph. The package is derived from the BSc. Honours dissertation in Electrical Engineering Interactive Computer Package Demonstrating: Sampling Convolution and the FFT, Adrienne Gaye Thompson, University of Aberdeen (1983). The package computes the linear convolution of two signals in the time domain then compares their circular convolution by demonstrating the convolution theorem. Each signal is modelled by a register of discrete values simulating samples of a signal, and the discrete Fourier transform (DFT) computed by means of the Fast Fourier Transform (FFT). GNU C-Graph is interactive, prompting the user to enter character or numerical values from the keyboard, dispensing with the learning curve for writing code. The software is an excellent tool for lecture demonstrations and lab work in the teaching of signals and systems theory. C-Graph is written in Fortran. Adrienne Gaye Thompson is the sole author of GNU C-Graph. Fedora Account System Username: pcpa -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 Mario Santagiuliana fed...@marionline.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mario Santagiuliana fed...@marionline.it --- New Package SCM Request === Package Name: kcm_wacomtablet Short Description: KDE Control module for Wacom Graphictablets Owners: marionline Branches: f16 f17 f18 InitialCC: rdieter kkofler -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879435] Review Request: c-graph - an interactive package that demonstrates the mathematical operation of convolution
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879435 --- Comment #8 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Thanks. I made a proper review request in #881794 Please consider reviewing it, it is a very simple package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825494] Review Request: cliquer - Find cliques in arbitrary weighted graphs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=825494 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- cliquer-1.21-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cliquer-1.21-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877763] Review Request: gnome-photos - Access, organize and share your photos on GNOME
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877763 --- Comment #7 from Mathieu Bridon boche...@fedoraproject.org --- (In reply to comment #6) I couldn't to use this application. When I started it it has no any photos and I couldn't find any way to add them. You need to have Tracker running and indexing your photos in ~/Pictures. There is no way to « add » pictures to it, it finds them automatically. In .spec you use https://live.gnome.org/Design/Apps/Photos but About of Gnome-Photos used https://live.gnome.org/GnomePhotos. Probably it should be fixed. I didn't know about this URL, so I used the other one. Fixed. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: GPL (v2 or later) (with incorrect FSF address), LGPL (v2 or later), GPL (v2 or later), Unknown or generated. 4 files have unknown license. Detailed output of licensecheck in /home/taurus/877763-gnome- photos/licensecheck.txt Use GPLv2+ and LGPLv2+ for License tag Good catch! Fixed. [!]: %check is present and all tests pass. I guess that's a note for Debarshi to add unit tests upstream. :P [!]: Packages should try to preserve timestamps of original installed files. Doh, I asked you to fix it in NetworkManager-l2tp and I can't do it properly in my own package. :) Fixed. - Spec URL: http://bochecha.fedorapeople.org/packages/gnome-photos.spec SRPM URL: http://bochecha.fedorapeople.org/packages/gnome-photos-3.7.2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501
--- Comment #2 from Troy Dawson tdaw...@redhat.com ---
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec
SRPM URL:
http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.7.3-2.fc18.src.rpm
rm -rf %{buildroot}%{gem_instdir}/.yardoc - Done
doc subpackage - Done
gem_extdir macro - Removed
Requires: rubygem(rubyforge) - Removed
Requires: rubygem(hoe) - Removed
Requires: rubygem(rdoc) - Removed
(in the Gemfile, it is correct, but the Gemfile.lock has them all just listed
as required. My mistake)
export CONFIGURE_ARGS ... - Removed
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 Mario Santagiuliana fed...@marionline.it changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-11-29 11:43:55 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881096] Review Request: packstack - Openstack Install utility
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=881096
Pádraig Brady pbr...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Pádraig Brady pbr...@redhat.com ---
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: make
i.e. remove make from buildrequires
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
i.e. add %doc LICENSE to %files
[!]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: packstack.spec should be openstack-packstack.spec
second line of description. s/variouse/various/
third line of description has a trailing space
s/186/188 in changelog
There are lots of hidden files in the tarball, including .git/ dirs
There are lots of scripts identified as such by
the first line being #!/usr/bin/env ... that are not executable
For example: parseyaml_spec.rb
If they're not meant to be executed directly, then
you could remove the first line upstream, or in the spec %prep do:
find nova -name \*.rb -exec sed -i '/\/usr\/bin\/env ruby/{d;q}' {} +
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- kcm_wacomtablet-1.3.7-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kcm_wacomtablet-1.3.7-2.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- kcm_wacomtablet-1.3.7-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kcm_wacomtablet-1.3.7-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878199] Review Request: kcm_wacomtablet - KDE Control module for Wacom Graphictablets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878199 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- kcm_wacomtablet-1.3.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kcm_wacomtablet-1.3.7-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881794] Review Request: c-graph - C-Graph is an abbreviation for Convolution Graph
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881794 Adrienne Thompson a...@codeartnow.com changed: What|Removed |Added CC||a...@codeartnow.com --- Comment #1 from Adrienne Thompson a...@codeartnow.com --- Summary/Short Description: GNU C-Graph: A tool for visualizing convolution. But I like Paulo's summary .:) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881903] New: Review Request: python-zope-interface4 - Forward compat package for Zope 3 Interface Infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881903 Bug ID: 881903 Summary: Review Request: python-zope-interface4 - Forward compat package for Zope 3 Interface Infrastructure Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Reporter: rb...@redhat.com Spec URL: http://ralph.fedorapeople.org//python-zope-interface4.spec SRPM URL: http://ralph.fedorapeople.org//python-zope-interface4-4.0.2-3.fc18.src.rpm Description: Interfaces are a mechanism for labeling objects as conforming to a given API or contract. This is a separate distribution of the zope.interface package used in Zope 3. This is a forward-compat package for epel6. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881903] Review Request: python-zope-interface4 - Forward compat package for Zope 3 Interface Infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881903 --- Comment #1 from Ralph Bean rb...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4741524 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881903] Review Request: python-zope-interface4 - Forward compat package for Zope 3 Interface Infrastructure
Product: Fedora EPEL https://bugzilla.redhat.com/show_bug.cgi?id=881903 Ralph Bean rb...@redhat.com changed: What|Removed |Added Component|Package Review |Package Review Version|rawhide |el6 Product|Fedora |Fedora EPEL -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880763] Review Request: AudioCuesheetEditor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880763 --- Comment #4 from Sven Baus s.bau...@gmx.net --- %configure doesn't work because it doesn't recognize --build=x86_64-unknown-linux-gnu argument (unlike of ./configure). Thats why I used ./configure. Is there a posibility to use %configure% without --build=x86_64-unknown-linux-gnu ? Also for the first time I see a strange path like bin/Release/* that contains file .png and .ico . I'm upstream of this software. I'm developing this software for linux and windows and thought it a good idea to have the ressources under the binary path. Is this bad coding? Also I'm not that familiar with makefiles,etc. I just used mdtools to generate the makefile automatically, and after some work, it worked :D. Thanks for you support to get this package into fedora ;). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878500] Review Request: rubygem-appraisal - Find out what your Ruby gems are worth
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878500 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Blocks||878556 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Depends On||878500 --- Comment #4 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-1.fc18.src.rpm Turns out I was just running the tests in the wrong directory and they can be run without the configuration file. Of course, now this depends on a package still under review, rubygem-appraisal. https://bugzilla.redhat.com/show_bug.cgi?id=878500 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854764 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854764 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854764 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- openshift-origin-port-proxy-1.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/openshift-origin-port-proxy-1.1.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-1.0.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-msg-broker-mcollective-1.0.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879879] Review Request: moodle-xs - A Course Management System
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879879
ben.har...@rackspace.com changed:
What|Removed |Added
CC||ben.har...@rackspace.com
--- Comment #1 from ben.har...@rackspace.com ---
Note that I am not a sponsor, but I starting some reviews in an effort to
become a packager.
Looking over your description and the source RPM, it is not clear to me the
issues you are having. It appears that your spec file is able to create plenty
of files and folders within /var:
#
$ cat /etc/issue
Fedora release 17 (Beefy Miracle)
Kernel \r on an \m (\l)
$ rpmbuild -bb SPECS/moodle-xs.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.UpeAWF
+ umask 022
+ cd /home/user/879879/user/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /home/user/879879/user/BUILD
+ rm -rf moodle-xs-1.9.5.xs1.15.g7c6a865
+ /usr/bin/gzip -dc
/home/user/879879/user/SOURCES/moodle-xs-1.9.5.xs1.15.g7c6a865.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd moodle-xs-1.9.5.xs1.15.g7c6a865
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ find . -type f '!' -name '*.pl' -exec chmod a-x '{}' ';'
+ find . -name '*.cgi' -exec chmod a+x '{}' ';'
+ chmod a+x admin/process_email.php
+ chmod a+x mod/chat/chatd.php
+ chmod a+x mod/wiki/ewiki/fragments/mkhuge
+ rm search/.cvsignore
+ sed -i 's/\r//' lib/adodb/license.txt
+ sed -i 's/\r//' lib/adodb/readme.txt
+ sed -i 's/\r//' lib/adodb/session/adodb-sess.txt
+ sed -i 's/\r//' lib/mp3player/readme.txt
+ sed -i 's/\r//' lib/pclzip/gnu-lgpl.txt
+ sed -i 's/\r//' lib/pclzip/readme.txt
+ sed -i 's/\r//' mod/wiki/ewiki/README
+ sed -i 's/\r//' mod/wiki/ewiki/README.de
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.fEdmYX
+ umask 022
+ cd /home/user/879879/user/BUILD
+ cd moodle-xs-1.9.5.xs1.15.g7c6a865
+ LANG=C
+ export LANG
+ unset DISPLAY
+ rm config-dist.php install.php COPYING.txt tags.txt filter/tex/mimetex.darwin
filter/tex/mimetex.exe filter/tex/mimetex.freebsd filter/tex/mimetex.linux
filter/tex/README.mimetex
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.7GA74f
+ umask 022
+ cd /home/user/879879/user/BUILD
+ '['
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64
'!=' / ']'
+ rm -rf
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64
++ dirname
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64
+ mkdir -p /home/user/879879/user/BUILDROOT
+ mkdir
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64
+ cd moodle-xs-1.9.5.xs1.15.g7c6a865
+ LANG=C
+ export LANG
+ unset DISPLAY
+ mkdir -p
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web
+ mkdir -p
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/lib/moodle
+ mkdir -p
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/log/moodle
+ mkdir -p
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/moodle/conf.d
+ cp -a Makefile README.txt admin auth backup blocks blog build-version
calendar course enrol error file.php files filter grade group help.php
index.php install iplookup lang lib local login message mnet mod my notes pix
question rpm rss search sso tag theme user userpix version.php
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web
+ rm
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/README.txt
+ rm -fr
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/install
+ install -p -D -m 0644 rpm/moodle.conf
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/httpd/conf.d/moodle.conf
+ install -p -D -m 0644 rpm/moodle-config.php
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/config.php
+ install -p -D -m 0644 rpm/moodle.cron
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/cron.d/moodle
+ install -p -D -m 0644 rpm/moodle.logrotate
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/logrotate.d/moodle
+ install -p -D -m 0755 rpm/moodle-cron
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/sbin/moodle-cron
+ install -p -D -m 0755 rpm/moodle.init
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/rc.d/init.d/moodle
+ rm -fr
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/rpm
+ rm
/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/Makefile
+ find
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 Hushan Jia hushan@gmail.com changed: What|Removed |Added Flags||needinfo?(mario.blaetterman ||n...@gmail.com) --- Comment #11 from Hushan Jia hushan@gmail.com --- Hi Mario, can you review the updated? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879879] Review Request: moodle-xs - A Course Management System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879879 --- Comment #2 from kparm...@myseneca.ca --- As per this line, + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web There should be created a directory under /var/www/ but when I check it's not there. I talked to the person at OLPC who said that it should be there. I am not sure if I should be able to see the directory when I create a package or not. I used rpmbuild -ba moodle.spec command to build this package. If I am not supposed to see a directory, then why do I receive errors when I run rpmlint on the package? Please check the output of my fedora-review, the errors are listed there. If you can provide me with a solution, I would try and fix those errors. Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880875] Review Request: python-fedmsg-meta-fedora-infrastructure - fedmsg metadata providers for Fedora Infrastructure's deployment
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880875 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||echevemas...@gmail.com QA Contact|extras...@fedoraproject.org |echevemas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880875] Review Request: python-fedmsg-meta-fedora-infrastructure - fedmsg metadata providers for Fedora Infrastructure's deployment
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880875
Eduardo Echeverria echevemas...@gmail.com changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|echevemas...@gmail.com
QA Contact|echevemas...@gmail.com |
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Ralph,
I'll take the review
Comments about rpmlint:
- spelling errors can be ignored
- Although the word 'fedmsg' can not capitalize, try to provide a summary that
does not generate this warning. I know this is not a 'MUST', but it does not
hurt to remove a warning in the rpmlint :)
BTW I notice that there a call to non-existing files in the template
MANIFEST.in
in the line
recursive-include fedmsg.d *.py
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/makerpm/880875-python-
fedmsg-meta-fedora-infrastructure/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
Note: Cannot find sources under BUILD (using prebuilt sources?)
[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot}
[Bug 872783] Review Request: Ray - Parallel genome assemblies for parallel DNA sequencing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872783 --- Comment #23 from Sébastien Boisvert s...@boisvert.info --- Spec URL: http://github.com/sebhtml/ray-packaging-for-Fedora/raw/2.1.0-5/Ray.spec SRPM URL: http://github.com/sebhtml/ray-packaging-for-Fedora/raw/2.1.0-5/Ray-2.1.0-5.fc17.src.rpm Description: Parallel genome assemblies for parallel DNA sequencing Fedora Account System Username: sebhtml Hello, I wrote the man page, help2man is not required anymore. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882084] New: Review Request: python-blessings - Python library for terminal coloring, styling, and positioning
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882084 Bug ID: 882084 Summary: Review Request: python-blessings - Python library for terminal coloring, styling, and positioning Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: dcall...@redhat.com Spec URL: http://fedorapeople.org/~dcallagh/python-blessings/python-blessings.spec SRPM URL: http://fedorapeople.org/~dcallagh/python-blessings/python-blessings-1.5-1.fc17.src.rpm Description: Blessings is a thin, practical wrapper around terminal coloring, styling, and positioning in Python. Fedora Account System Username: dcallagh -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882090] New: Review Request: python-nose-progressive - Nose plugin to show a progress bar and tracebacks during tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882090 Bug ID: 882090 Summary: Review Request: python-nose-progressive - Nose plugin to show a progress bar and tracebacks during tests Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: dcall...@redhat.com Spec URL: http://fedorapeople.org/~dcallagh/python-nose-progressive/python-nose-progressive.spec SRPM URL: http://fedorapeople.org/~dcallagh/python-nose-progressive/python-nose-progressive-1.3-1.fc17.src.rpm Description: nose-progressive is a nose plugin which displays progress in a stationary progress bar, freeing the rest of the screen (as well as the scrollback buffer) for the compact display of test failures, which it formats beautifully and usefully. It displays failures and errors as soon as they occur and avoids scrolling them off the screen in favor of less useful output. It also offers a number of other human-centric features to speed the debugging process. Fedora Account System Username: dcallagh -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879953] Review Request: xs-config - XS/XSX default configuration
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879953 zy...@myseneca.ca changed: What|Removed |Added CC||zy...@myseneca.ca --- Comment #2 from zy...@myseneca.ca --- I maybe contribute a little for the package. You can use this spec file: http://matrix.senecac.on.ca/~zyu26/olpc/xs-config.spec By this spec file: rpmlint -i ../SRPMS/xs-config-0.7.0.46.g9b886c8-2.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878515] Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878515 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- rubygem-simplecov-html-0.7.1-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878515] Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878515 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854764 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878236] Review Request: python-waitress - Waitress WSGI server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-waitress-0.8.2-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854764] Review Request:openshift-origin-port-proxy - Script to configure HAProxy to do port forwarding for OpenShift Origin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854764 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- openshift-origin-port-proxy-1.1.1-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881751] Review Request: rubygem-pdf-inspector - A tool for analyzing PDF output
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881751 Bohuslav Slavek Kabrda bkab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com Assignee|nob...@fedoraproject.org|bkab...@redhat.com Flags||fedora-review? --- Comment #1 from Bohuslav Slavek Kabrda bkab...@redhat.com --- I'll take this for a review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881751] Review Request: rubygem-pdf-inspector - A tool for analyzing PDF output
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881751 --- Comment #2 from Bohuslav Slavek Kabrda bkab...@redhat.com --- - rpmlint gives me: incorrect-fsf-address /usr/share/gems/gems/pdf-inspector-1.0.2/GPLv2, which means that the LICENSE file is probably older. Although this is not a showstopper, you should contact the upstream (or ideally send a pull request) to fix this. - Since this is a pure ruby Gem, it is not optimal to have runtime dependency on Ruby. When we have more Ruby interpreters (e.g. JRuby), this gem should also be usable with these. So please remove Requires: ruby, keeping only the runtime requirement on ruby(abi). - Please check the wordwrapping in description, it seems to be a little weird :) (word testing is on its own line, etc.) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 Ivan Romanov dr...@land.ru changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Ivan Romanov dr...@land.ru --- New Package SCM Request === Package Name: NetworkManager-l2tp Short Description: NetworkManager VPN plugin for l2tp Owners: ivanromanov Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878653
--- Comment #11 from Mathieu Bridon boche...@fedoraproject.org ---
(In reply to comment #10)
Branches: f17 f18 el6
The el6 is not going to work because you removed this:
-%if 0%{?fedora} 16
BuildRequires: libgnome-keyring-devel
-%else
-BuildRequires: gnome-keyring-devel
-%endif
You should add these lines back if you intend to have the package build on el6.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878500] Review Request: rubygem-appraisal - Find out what your Ruby gems are worth
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878500 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||msu...@redhat.com Assignee|nob...@fedoraproject.org|msu...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878653] Review Request: NetworkManager-l2tp - NetworkManager VPN plugin for l2tp
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878653 --- Comment #12 from Ivan Romanov dr...@land.ru --- I will use BuildRequires: gnome-keyring-devel for el6 branch -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
