[Bug 885825] Review Request: InsightToolkit - Insight Segmentation and Registration Toolkit (ITK)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885825

--- Comment #3 from Peter Lemenkov  ---
(In reply to comment #2)
> Ooops, forgot to check current reviews :) 

No problem )

> Unfortunately I'm not developing or using any medical applications, I wanted
> to package this, because I'm helping a friend of mine (who's not using
> Fedora) with packaging his medical app

I strongly encourage you to ask him/her to join Fedora Community! We're mostly
helpful and nice persons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BLzya2faCM&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 839649] Review Request: rubygem-rails_best_practices - a code metric tool for rails codes, written in Ruby.

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=839649

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com

--- Comment #9 from Vít Ondruch  ---
(In reply to comment #8)
> 5, Why do you list subfolders from
> %{gem_instdir}/spec/rails_best_practices/? Isn't enough to list it as one
> folder only?

I would put it differently. There is nothing wrong in listing subfolders. This
may help to assure, that the specific folders are included in package. However,
as it is done currently, only the files are owned by package, not the
directories itself. And that is wrong. This applies not just to
%{gem_instdir}/spec/ but to %{gem_instdir}/assets/ as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=quBUKsQrZK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 839649] Review Request: rubygem-rails_best_practices - a code metric tool for rails codes, written in Ruby.

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=839649

--- Comment #10 from Vít Ondruch  ---
(In reply to comment #8)
> 2, Get rid of 
> 
> Requires: ruby

Agree with this.

> BuildRequires: ruby

Don't fully agree. It is safer option to include BR: ruby ATM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lRWw623IXg&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818629] Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=818629

--- Comment #5 from Vít Ondruch  ---
Thank you for your review!



New Package SCM Request
===
Package Name: rubygem-delayed_job_active_record
Short Description: ActiveRecord back-end for DelayedJob
Owners: vondruch
Branches: 
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rEa9XIT1oa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818629] Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=818629

Vít Ondruch  changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IUOYPm6ceC&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 874743] Review Request: perl-Unicode-EastAsianWidth - East Asian Width properties

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874743

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
  Flags||fedora-review?

--- Comment #1 from Jitka Plesnikova  ---

Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[!]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
 Note: Source0 (Unicode-EastAsianWidth-1.33.tar.gz)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

= EXTRA items =

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[-]: Large data in /usr/share should live in a noarch subpackage if package is
 arched.

$ rpmlint perl-Unicode-EastAsianWidth.spec
perl-Unicode-EastAsianWidth-1.33-1.fc19.*rpm
perl-Unicode-EastAsianWidth.noarch: W: spelling-error %description -l en_US
http -> HTTP
perl-Unicode-EastAsianWi

[Bug 874743] Review Request: perl-Unicode-EastAsianWidth - East Asian Width properties

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874743

Jitka Plesnikova  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lnD2rx7NWT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885548] Review Request: perl-DateTime-Tiny - Date object, with as little code as possible

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885548

Jitka Plesnikova  changed:

   What|Removed |Added

 CC||jples...@redhat.com

--- Comment #1 from Jitka Plesnikova  ---
Invalid srpm URL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fuiMnzJVQJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #1 from Christophe Burgun  ---
Updating spec file with new pentobi version

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-1.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fTuCvfzXb4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #10 from Juan Manuel  ---
*
It is not a binary linking to any program or lib (apart from a real executable
utility linking to mythes trhough hunspell, keeping it arch specific instead of
fully noarch package), it is a shell script binary (#!/usr/bin/env bash).

Anyway, Requires cleaned, lynx and aspell added in Requires:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4778055

*
Accessing Your fedorapeople.org Space
- You must be sponsored in a group (other than the CLA groups)

I could keep trying to get access to any place like that but if the already
provided places don't work i can't seem to be able to provide such space. Try
to select "open file" instead of "save/save as" on browser dialog.

*
Spec URL: http://translateword.googlecode.com/files/tw.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-5.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wJnnjvSETH&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886022] New: Review Request: pyzy - The Chinese PinYin and Bopomofo conversion library

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886022

Bug ID: 886022
   Summary: Review Request: pyzy - The Chinese PinYin and Bopomofo
conversion library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: p...@redhat.com

Spec URL: http://pwu.fedorapeople.org/pyzy/pyzy.spec
SRPM URL: http://pwu.fedorapeople.org/pyzy/pyzy-0.1.0-2.fc17.src.rpm
Description: The Chinese Pinyin and Bopomofo conversion library.
Fedora Account System Username:pwu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DwBsDDREoQ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886022] Review Request: pyzy - The Chinese PinYin and Bopomofo conversion library

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886022

Peng Wu  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|panem...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=76MfRKkqHz&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 846662] Review Request: eclipse-ecf - Eclipse Communication Framework

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=846662

Krzysztof Daniel  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed|2012-08-09 03:47:09 |2012-12-11 05:53:29

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aDW0jn74OT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885548] Review Request: perl-DateTime-Tiny - Date object, with as little code as possible

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885548

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?

--- Comment #2 from Jitka Plesnikova  ---
Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

= EXTRA items =

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[-]: Large data in /usr/share should live in a noarch subpackage if package is
 arched.

$ rpmlint ./perl-DateTime-Tiny.spec ./perl-DateTime-Tiny-1.04-1.fc19.*.rpm
perl-DateTime-Tiny.noarch: E: description-line-too-long C DateTime::Tiny
implements an extremely lightweight object that represents a datetime.
perl-DateTime-Tiny.noarch: E: incorrect-fsf-address
/usr/share/doc/perl-DateTime-Tiny-1.04/LICENSE
perl-DateTime-Tiny.src: E: description-line-too-long C DateTime::Tiny
implements an extremely lightweight object that represents a datetime.
2 packages and 1 specfiles checked; 3 errors, 0 warnings.

TODO: Description lines must not exceed 79 characters. Please cut it to fit in
two lines.

$ rpm -qp --requires perl-DateTime-Tiny-1.04-1.fc19.noa

[Bug 885833] Review Request: tw - translate words into different languages

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #11 from Kevin Kofler  ---
> In "Requires", I consider that this should not go
> Requires:   sed
> Requires:   bash
> Requires:   gawk
> Requires:   coreutils

Uh, no, these are actually needed!

I think bash is only autodetected if you use #!/bin/bash directly rather than
#!/usr/bin/env bash. The others are definitely NOT autodetected, because
they're only called in the script, not linked by anything nor used as a #!
line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=THsZbW3byO&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #12 from Kevin Kofler  ---
(and there are NO implicit Requires, unlike BuildRequires, because you cannot
make any assumptions about user systems)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TQshlu9ox2&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rLqCYOK7nL&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187

--- Comment #31 from Fedora Update System  ---
openscad-2012.10.31-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/openscad-2012.10.31-5.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8ZWCEdWKgR&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187

--- Comment #32 from Fedora Update System  ---
openscad-2012.10.31-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/openscad-2012.10.31-5.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4utf3s68e2&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #3 from Zuzana  ---
- FAS username is sysl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mths9RGqkW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885548] Review Request: perl-DateTime-Tiny - Date object, with as little code as possible

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885548

--- Comment #3 from Robin Lee  ---
Spec URL: http://cheeselee.fedorapeople.org/perl-DateTime-Tiny.spec
SRPM URL:
http://cheeselee.fedorapeople.org/perl-DateTime-Tiny-1.04-2.fc18.src.rpm
Changes:
- Add requires perl(DateTime)
- Remove perl(Test::More) from Requires
- Fill description paragraph

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sbGMScdwno&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885833] Review Request: tw - translate words into different languages

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885833

--- Comment #13 from Juan Manuel  ---
* Do not assume anything about Requires.
Spec URL: http://translateword.googlecode.com/files/tw.spec
SRPM URL: http://translateword.googlecode.com/files/tw-0.9.4-6.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=j6PZvwYwtz&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 879614] Review Request: invokebinder - A Java DSL for binding method handles forward, rather than backward

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879614

--- Comment #2 from Mikolaj Izdebski  ---
Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: Pom files have correct add_maven_depmap call
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: If package contains pom.xml files install it (including depmaps) even
 when building with ant
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package

[Bug 818629] Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=818629

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5C6akixjJZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824052] Review Request: fcitx-m17n - M17n Engine for Fcitx

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=824052

--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OcpC2e1dDy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824061] Review Request: fcitx-unikey - Vietnamese Engine for Fcitx

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=824061

--- Comment #16 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=q792YtYVtw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #4 from Zuzana  ---
 - toilet 0.3 build requires new libcaca library still not packaged in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1xr0iueBDA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #2 from Christophe Burgun  ---
Add requires and some other changes (changelog)

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7Vd3S4O8s4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886103] New: Review Request: plexus-root-pom - Plexus Root POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886103

Bug ID: 886103
   Summary: Review Request: plexus-root-pom - Plexus Root POM file
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: unspecified
  Reporter: m...@redhat.com

Spec URL: http://people.redhat.com/msrb/plexus-root.spec 
SRPM URL: http://people.redhat.com/msrb/plexus-root-pom-1.0.3-1.fc19.src.rpm
Description: This package provides Plexus Root parent POM used by different
Plexus packages.
Fedora Account System Username: msrb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oGpSDHpaGg&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886104] New: Review Request: plexus-component-factories-pom - Plexus Component Factories POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886104

Bug ID: 886104
   Summary: Review Request: plexus-component-factories-pom -
Plexus Component Factories POM file
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: unspecified
  Reporter: m...@redhat.com

Spec URL: http://people.redhat.com/msrb/plexus-component-factories-pom.spec
SRPM URL:
http://people.redhat.com/msrb/plexus-component-factories-pom-1.0-0.1.alpha11.fc19.src.rpm
Description: This package provides Plexus Component Factories  parent POM used
by different Plexus packages.
Fedora Account System Username: msrb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=qTh66cyCEF&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886103] Review Request: plexus-root-pom - Plexus Root POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886103

Stanislav Ochotnicky  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||socho...@redhat.com
  Flags||fedora-review?

--- Comment #1 from Stanislav Ochotnicky  ---
I'll do the review & sponsorship process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Ys0Cqi5qE4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886104] Review Request: plexus-component-factories-pom - Plexus Component Factories POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886104

Stanislav Ochotnicky  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||socho...@redhat.com
  Flags||fedora-review?

--- Comment #1 from Stanislav Ochotnicky  ---
I'll do the review & sponsorship process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=E0kOzq2mzF&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886103] Review Request: plexus-root-pom - Plexus Root POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886103

Stanislav Ochotnicky  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|socho...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gE1oJAT6um&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886104] Review Request: plexus-component-factories-pom - Plexus Component Factories POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886104

Stanislav Ochotnicky  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|socho...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Yr46Slw1xT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847160] Review Request: eclipse-m2e-core - Maven integration for Eclipse

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=847160

--- Comment #14 from Gerard Ryan  ---
(In reply to comment #13)
> If you just set a version for that plugin, maybe it'll fix the issue.

That worked, thanks!

This is now ready for review.

SPEC URL:
http://galileo.fedorapeople.org/eclipse-m2e-core/1.2.0-1/eclipse-m2e-core.spec
SRPM URL:
http://galileo.fedorapeople.org/eclipse-m2e-core/1.2.0-1/eclipse-m2e-core-1.2.0-1.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ms6lNDGMoA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 846481] Review Request: cantata - Client for the Music Player Daemon (MPD)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=846481

Rex Dieter  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|alexisis-pristontale@hotmai |nob...@fedoraproject.org
   |l.com   |
  Flags|fedora-review?  |
  Flags|needinfo?(alexisis-pristont |
   |a...@hotmail.com)|

--- Comment #8 from Rex Dieter  ---
Following,
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

reviewer hasn't responded in over a month, resetting review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4weJlTyLiB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847160] Review Request: eclipse-m2e-core - Maven integration for Eclipse

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=847160

--- Comment #15 from Mikolaj Izdebski  ---
I also did a licensing review and checked for bundling libraries -- everything
is OK now. I also briefly it and basic functionality appears to be forking.

Great job!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7LRZUu17Fk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886112] New: Review Request: gwyddion - SPM analysis tool in gtk

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886112

Bug ID: 886112
   Summary: Review Request: gwyddion - SPM analysis tool in gtk
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: unspecified
  Reporter: lennart.fri...@kabelmail.de

There has already been an review request by upstream, see bug 187294.
But there were some issues about plug-ins.

In the current spec the plugin-modules for each language (perl,python,ruby) are
packaged separately and kept private in /usr/lib{64}/gwyddion. 
I would also make them public, if it is better from your point of view.

Well, this is my first package and i need a sponsor.

koji build against f18:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4778929

Spec URL:
https://raw.github.com/lennart0901/gwyddion-fedpack/master/gwyddion.spec
SRPM URL:
https://raw.github.com/lennart0901/gwyddion-fedpack/master/gwyddion-2.30-2.src.rpm
Description: Gwyddion is a modular SPM (Scanning Probe Microsopy) data
visualization and analysis tool written with Gtk+.
Fedora Account System Username: lennart0901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=veCE6Jfyxf&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885548] Review Request: perl-DateTime-Tiny - Date object, with as little code as possible

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885548

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #4 from Jitka Plesnikova  ---
Changes in spec:

-Requires:   perl(Test::More) >= 0.47
+Requires:   perl(DateTime)
> FIX: Add requires perl(DateTime) - ./lib/DateTime/Tiny.pm:355
> FIX: Remove perl(Test::More) from Requires, it is necessary only for 
> build-time.
Ok.

-DateTime::Tiny implements an extremely lightweight object that represents a
datetime.
+DateTime::Tiny implements an extremely lightweight object that represents a
+datetime.

> FIX: Description lines must not exceed 79 characters. Please cut it to fit in
> two lines.
Ok.


TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
%install.
TODO: Remove the deleting empty directories in %install section. This is
default behavior.

Please consider fixing 'TODO' items before submit.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kfgjoP98pv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Michael Scherer  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)

--- Comment #5 from Michael Scherer  ---
Since you are not in any packager group, could you please follow the step on 
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers ?

I have marked this bug as needing a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pMvQBwgCp5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886112] Review Request: gwyddion - SPM analysis tool in gtk

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886112

lennart.fri...@kabelmail.de changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=m4d1HRoOOT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 839649] Review Request: rubygem-rails_best_practices - a code metric tool for rails codes, written in Ruby.

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=839649

Josef Stribny  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VWje39jbDy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865976] Review Request: libsigrok - Basic hardware access drivers for logic analyzers

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=865976

Rex Dieter  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?

--- Comment #8 from Rex Dieter  ---
I can review today.

Alex, can you mention what your FAS username is (i'll need that to sponsor
you)?
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_a_Fedora_Account

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4veaoWOKfc&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=798071

--- Comment #11 from Rex Dieter  ---
A few initial comments:

1.  I see no URL: tag, and this
Source0: %{name}-%{version}.tar.gz
references no upstream.   Ideally, we'd have some URL: tag and fully-qualified
downloadable (and verifiable) source for this package.

If this is something that doesn't yet have an upstream, consider using
http://fedorahosted.org/

2.  you seem to create a lot of "here" documents, using
cat > exe/%{name}-helper 

[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=798071

--- Comment #12 from Rex Dieter  ---
Oh, I can't seem to find your FAS username mentioned here anywhere, please do,
i'll need that to sponsor you,
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_a_Fedora_Account

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BnATr1edUf&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886103] Review Request: plexus-root-pom - Plexus Root POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886103

Mikolaj Izdebski  changed:

   What|Removed |Added

 Blocks||866756

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=dhBW1XMJLj&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886104] Review Request: plexus-component-factories-pom - Plexus Component Factories POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886104

Mikolaj Izdebski  changed:

   What|Removed |Added

 Blocks||866756

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OtEzYcNNIk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 818629] Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=818629

Vít Ondruch  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2012-12-11 10:21:09

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bQonZRiSJ4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865976] Review Request: libsigrok - Basic hardware access drivers for logic analyzers

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=865976

--- Comment #9 from Alex G.  ---
FAS username: mrnuke

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AUX1ikuH9o&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 857440] Review Request: kio-upnp-ms - UPnP mediaserver kio slave

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=857440

Dan Mashal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dan.mas...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=JZy1GmZakv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 857440] Review Request: kio-upnp-ms - UPnP mediaserver kio slave

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=857440

Dan Mashal  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=muYnL4xImy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 857440] Review Request: kio-upnp-ms - UPnP mediaserver kio slave

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=857440

Dan Mashal  changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PWgAWTMvhf&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886104] Review Request: plexus-component-factories-pom - Plexus Component Factories POM file

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886104

--- Comment #2 from Stanislav Ochotnicky  ---
Since this is simple pom package I am going to skip fedora-review output and
just note problems with current version. rpmlint was clean

1. License

tag says ASL 2.0 but the pom.xml actually doesn't specify any license. *But*
the parent pom (org.codehaus.plexus:plexus) specifies license as ASL 2.0. I've
sent email to fedora-legal mailing list asking for this to be approved as a way
to identify licenses for pom files. I'll add link to the email once it's
approved by moderator

Also if you are going to add ASL license text, you can use full url in SourceX
instead of just in the comment

2. Source0 URL

For maven repositories we usually use direct links. In this case (you should
replace artifact names and versions with macros if possible)

http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-component-factories/1.0-alpha-11/plexus-component-factories-1.0-alpha-11.pom

3. prep stage
Instead of:
%prep
cp -p %{SOURCE0} ${RPM_BUILD_DIR}/pom.xml
cp -p %{SOURCE1} LICENS

do:
%prep
%setup -cT
cp -p %{SOURCE0} pom.xml
cp -p %{SOURCE1} LICENSE

4. mvn-rpmbuild verify

This should be in %check section, not %build

5. short_name usage

Macros for names are used when you repeatedly need to use part of a package
name during install/build phase. This is not really the case here so the macro
is just adding unneeded stuff to the specfile making it more complicated than
it needs to be. However see next point..

6. Upstream exists with different versions having different groupIds, you might
want to add "-a "plexus:%{short_name}" to make sure that we can resolve both
versions. I'd rename short_name to artifactId or something more clear

7. %files section 
Ideally files sections should be as specific as possible so that no new files
slip by accidentally. This is not really a dealbreaker for such a simple
package but keep it in mind for other packages. For this case ideal solution
is:
%files
%doc LICENSE
%{_mavenpomdir}/JPP-%{name}.pom
%{_mavendepmapfragdir}/%{name}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NqV6QamGsO&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 846481] Review Request: cantata - Client for the Music Player Daemon (MPD)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=846481

Dan Mashal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dan.mas...@gmail.com
   Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9cFFq0WwJa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 883501] Review Request: nepomuk-widgets - Nepomuk widgets collection

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=883501

Dan Mashal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dan.mas...@gmail.com
   Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=26psi74hPH&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886164] New: Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886164

Bug ID: 886164
   Summary: Review Request: python-dogpile-cache - A caching
front-end based on the Dogpile lock.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: unspecified
  Priority: unspecified
  Reporter: rb...@redhat.com


Spec URL: http://ralph.fedorapeople.org//python-dogpile-cache.spec
SRPM URL:
http://ralph.fedorapeople.org//python-dogpile-cache-0.4.0-1.fc18.src.rpm

Description:
A caching API built around the concept of a "dogpile lock", which allows
continued access to an expiring data value while a single thread generates
a new value.

dogpile.cache builds on the `dogpile.core
`_ locking system, which
implements the idea of "allow one creator to write while others read" in
the abstract.   Overall, dogpile.cache is intended as a replacement to the
`Beaker `_ caching system, the internals of
which are written by the same author.   All the ideas of Beaker which
"work" are re-implemented in dogpile.cache in a more efficient and succinct
manner, and all the cruft (Beaker's internals were first written in 2005)
relegated to the trash heap.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=12oLLmQJW5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886112] Review Request: gwyddion - SPM analysis tool in gtk

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886112

Peter Lemenkov  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)
 CC||y...@physics.muni.cz

--- Comment #1 from Peter Lemenkov  ---
*** Bug 187294 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cKjBPZkdsx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819919] Review Request: chicken-scheme - CHICKEN is a compiler for the Scheme programming language

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=819919

Alec Leamas  changed:

   What|Removed |Added

 Whiteboard||AwaitingSubmitter

--- Comment #5 from Alec Leamas  ---
Following the the procedure in comment #4: This review is stalled. Jessica,
please respond ASAP in this bug stating your intentions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=q52clUnOxz&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864125

Tom "spot" Callaway  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #4 from Tom "spot" Callaway  ---
New Package SCM Request
===
Package Name: opendyslexic-fonts
Short Description: Fonts designed for dyslexics and high readibility
Owners: spot
Branches: f16 f17 f18
InitialCC: fonts-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=D21nS0BiKb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864125

--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mmNDhkpKIv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501

Miroslav Suchý  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #10 from Miroslav Suchý  ---
I guess that you meant:
SRPM URL:
http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-2.fc18.src.rpm
(release is 2 instead of 1)
:)

Yes, that is good.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aXbZngBPfa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847160] Review Request: eclipse-m2e-core - Maven integration for Eclipse

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=847160

Gerard Ryan  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5sgOElz5df&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501

Troy Dawson  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #11 from Troy Dawson  ---
New Package SCM Request
===
Package Name: rubygem-ci_reporter
Short Description: Generate XML for continuous integration systems
Owners: tdawson
Branches: f18 f17
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8LODXT9nl0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501

--- Comment #12 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=b8xrGbTzGE&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

--- Comment #6 from Zuzana  ---
Ok thaks, 

Spec URL: http://jnovy.fedorapeople.org/toilet/toilet.spec
SRPM URL: http://jnovy.fedorapeople.org/toilet/toilet-0.2-0.2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vqC2oXavel&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835062

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
  Flags||fedora-cvs?

--- Comment #6 from Tom "spot" Callaway  ---
Package Change Request
==
Package Name: perl-Module-Install-ReadmeFromPod
New Branches: f16 f17 f18
Owners: jplesnik mmaslano ppisar psabata
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rfGv2xuPtf&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835804] Review Request: perl-Module-Install-ReadmeMarkdownFromPod - Create README.mkdn from POD

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835804

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #7 from Tom "spot" Callaway  ---
Package Change Request
==
Package Name: perl-Module-Install-ReadmeMarkdownFromPod
New Branches: f16 f17 f18
Owners: jplesnik mmaslano ppisar psabata
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9G4u0iWBHy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886192] New: Review Request: perl-Module-Package-Au - Reusable Module::Install bits

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886192

Bug ID: 886192
   Summary: Review Request: perl-Module-Package-Au - Reusable
Module::Install bits
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: tcall...@redhat.com

Spec URL: http://spot.fedorapeople.org/perl-Module-Package-Au.spec
SRPM URL:
http://spot.fedorapeople.org/perl-Module-Package-Au-0.01-1.fc18.src.rpm
Description: This module defines a set of standard configurations for
Makefile.PL
files based on Module::Package.
Fedora Account System Username: spot

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kts7TfFaAb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886192] Review Request: perl-Module-Package-Au - Reusable Module::Install bits

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886192

--- Comment #1 from Tom "spot" Callaway  ---
Ugh, wrong SRPM. Proper SRPM URL is:

SRPM URL: http://spot.fedorapeople.org/perl-Module-Package-Au-2-1.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=irWw9cGgRy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 874743] Review Request: perl-Unicode-EastAsianWidth - East Asian Width properties

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874743

Tom "spot" Callaway  changed:

   What|Removed |Added

 Blocks||886192

--- Comment #2 from Tom "spot" Callaway  ---
Nothing ever comes easy, does it? Good catch on the bundled bits. I've made one
new dependency package (perl-Module-Package-Au) to resolve this issue. The
other items are already in Fedora but only in rawhide
(perl-Module-Install-ReadmeFromPod and
perl-Module-Install-ReadmeMarkdownFromPod), so I've asked for them to be
branched for all active releases.

New SRPM:
http://spot.fedorapeople.org/perl-Unicode-EastAsianWidth-1.33-2.fc18.src.rpm
New SPEC: http://spot.fedorapeople.org/perl-Unicode-EastAsianWidth.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TrPG3X7smJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886192] Review Request: perl-Module-Package-Au - Reusable Module::Install bits

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886192

Tom "spot" Callaway  changed:

   What|Removed |Added

 Depends On||874743

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=FIyJFyWwQ6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835062

--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tsgb2apIrE&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835804] Review Request: perl-Module-Install-ReadmeMarkdownFromPod - Create README.mkdn from POD

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835804

--- Comment #8 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8mdgBxsGf6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880880

Remi Collet  changed:

   What|Removed |Added

 Attachment #661594||review?
  Flags||
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com

--- Comment #1 from Remi Collet  ---
Created attachment 661594
  --> https://bugzilla.redhat.com/attachment.cgi?id=661594&action=edit
php-scssphp-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 880880

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Rx8Nuv6MDR&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835051] Review Request: perl-Module-Install-AutoLicense - Module::Install extension to automatically generate LICENSE files

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835051

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #6 from Tom "spot" Callaway  ---
Package Change Request
==
Package Name: perl-Module-Install-AutoLicense
New Branches: f16 f17
Owners: jplesnik mmaslano ppisar psabata
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LfClMRStO4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 880880] Review Request: php-scssphp - A compiler for SCSS written in PHP

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880880

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?

--- Comment #2 from Remi Collet  ---
MUST:

- Please clarify License (with upstream).

Only MIT file is provided, GPLv3 only list in composer.json file...

I also think it will be great to have License header in each file.

- no need to requires php-common

only need extensions, php-common is only required for version checking

- fix the shebang

Currently, in requires: /usr/bin/env

#!/usr/bin/env php => #!/usr/bin/php

This will fix the missing dependency on php-cli.

SHOULD:

- Like for a previous review, could probably be simpler to include
%{libname}/scss.inc.php (without %{_datadir}/php) and override include_path for
phpunit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tZlrqqPQTq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835051] Review Request: perl-Module-Install-AutoLicense - Module::Install extension to automatically generate LICENSE files

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835051

--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=u7ny3lI61s&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 815018] Review Request: nodejs - javascript fast build framework

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=815018

--- Comment #60 from Stephen Gallagher  ---
This is the response I got back from the legal department (better than I had
hoped, too):


This is Free and GPL-Compatible. Use:
License: MITNFA


This license has now been added to
https://fedoraproject.org/wiki/Licensing:Main

So we're good to go on NPM when this package is finished. I'm just waiting on
the 'node' package to complete its rename and the release of Node.js 0.9.4
upstream (which should happen today or tomorrow according to bnoordhuis)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tiSEU2IpJW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=F4LQLk3bbX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878501] Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878501

--- Comment #13 from Fedora Update System  ---
rubygem-ci_reporter-1.8.2-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-ci_reporter-1.8.2-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ArBTuOD5cK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Jindrich Novy  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jn...@redhat.com
  Flags||fedora-review?

--- Comment #7 from Jindrich Novy  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=p21PWU7ag0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xvHIh6Frty&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864187

--- Comment #33 from Fedora Update System  ---
openscad-2012.10.31-5.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hztjgLnWT1&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886221] New: Review Request: python-dogpile-core - A 'dogpile' lock, typically used as a component of a larger caching solution

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886221

Bug ID: 886221
   Summary: Review Request: python-dogpile-core - A 'dogpile'
lock, typically used as a component of a larger
caching solution
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: unspecified
  Priority: unspecified
  Reporter: rb...@redhat.com


Spec URL: http://ralph.fedorapeople.org//python-dogpile-core.spec
SRPM URL:
http://ralph.fedorapeople.org//python-dogpile-core-0.4.0-2.fc18.src.rpm

Description:
A "dogpile" lock, one which allows a single thread to generate an expensive
resource while other threads use the "old" value, until the "new" value is
ready.

Dogpile is basically the locking code extracted from the Beaker package,
for simple and generic usage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xhqd1xVGj9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886221] Review Request: python-dogpile-core - A 'dogpile' lock, typically used as a component of a larger caching solution

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886221

--- Comment #1 from Ralph Bean  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=4780318

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VE1FjNMWYn&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886221] Review Request: python-dogpile-core - A 'dogpile' lock, typically used as a component of a larger caching solution

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886221

Ralph Bean  changed:

   What|Removed |Added

 Blocks||886164

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QSQGPxknkD&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886164] Review Request: python-dogpile-cache - A caching front-end based on the Dogpile lock.

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886164

Ralph Bean  changed:

   What|Removed |Added

 Depends On||886221

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cQMVsKRCsr&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 884759] Review Request: toilet - colorful ASCII art generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Jindrich Novy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||needinfo?(zidkova.zuzana@se
   ||znam.cz)

--- Comment #8 from Jindrich Novy  ---
rpmlint output on src.rpm:

$ rpmlint toilet-0.2-0.2.fc18.src.rpm 
toilet.src: W: spelling-error Summary(en_US) figlet -> filet, fillet, piglet
-> sane as it references figlet utility

toilet.src: W: summary-not-capitalized C figlet alternative
-> could you please rephrase the Summary in a way that it starts with a capital
letter?

toilet.src: W: spelling-error %description -l en_US ancronym -> acronym,
antonym
-> there seems to be a typo in %description here

toilet.src: W: spelling-error %description -l en_US libcaca -> biblical
-> sane, it's a library name

toilet.src: W: spelling-error %description -l en_US folowing -> flowing,
following, fol owing
-> seems that 'l' is missing in "following"

toilet.src: W: spelling-error %description -l en_US colour -> color, co lour,
co-lour
-> US English prefers "color"

toilet.src: W: spelling-error %description -l en_US smushing -> mushing,
smashing, shushing
-> not sure here but 

IMO the %description seems to me too verbose with a lot of duplicities. Could
you please reduce it?

Running rpmlint on built RPM reveals:
toilet.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1

So it seems it is better to own the man page like this in the %files section:
%{_mandir}/man1/%{name}*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XY9PqBhVv9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=798071

--- Comment #13 from Jon Chiappetta  ---
So, my FAS username is "fossjon" (I thought this procedure would have tied that
in somewhere but maybe I missed it). I updated the spec file and rpms based on
your suggestion which helped clean it up a bit more and rpmlint doesn't report
any errors on any of the files. 

Spec:
http://fossjon.fedorapeople.org/source/projects/specs/fedora-arm-installer.spec
SRPM:
http://fossjon.fedorapeople.org/packages/fedora-arm-installer/fedora-arm-installer-1.0.2-4.fc18.src.rpm
RPM:
http://fossjon.fedorapeople.org/packages/fedora-arm-installer/fedora-arm-installer-1.0.2-4.fc18.noarch.rpm

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HGSPExqs6I&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 873643] Review Request: php-pecl-uuid - Universally Unique Identifier extension for PHP

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=873643

--- Comment #11 from Fedora Update System  ---
php-pecl-uuid-1.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=JYwlK3s9ZX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 859504] Review Request: php-xcache - Fast, stable PHP opcode cacher

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=859504

--- Comment #17 from Fedora Update System  ---
php-xcache-3.0.0-1.el6.1 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rrGFZc0COm&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886230] New: Review Request: php-phpass - Portable password hashing framework for use in PHP applications

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886230

Bug ID: 886230
   Summary: Review Request: php-phpass - Portable password hashing
framework for use in PHP applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: gre...@freenet.de

Spec URL: http://brummbq.fedorapeople.org/php-phpass.spec
SRPM URL: http://brummbq.fedorapeople.org/php-phpass-0.3-1.fc17.src.rpm
Description:
phpass (pronounced "pH pass") is a portable public domain password hashing
framework for use in PHP applications. It is meant to work with PHP 3 and
above.

The preferred (most secure) hashing method supported by phpass is the
OpenBSD-style Blowfish-based bcrypt and known in PHP as CRYPT_BLOWFISH, with
a fallback to BSDI-style extended DES-based hashes, known in PHP as
CRYPT_EXT_DES, and a last resort fallback to MD5-based salted and variable
iteration count password hashes implemented in phpass
itself (also referred to as portable hashes).
Fedora Account System Username: brummbq

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oT5ZeiGlGX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 866156] Review Request: giada - audio looper for JACK

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866156

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MdIXDMlTWd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 866156] Review Request: giada - audio looper for JACK

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=866156

--- Comment #24 from Fedora Update System  ---
giada-0.5.4-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/giada-0.5.4-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rzPLMc7rV0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864125

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VF7hA0whJZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864125

--- Comment #6 from Fedora Update System  ---
opendyslexic-fonts-0.600-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/opendyslexic-fonts-0.600-1.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YAZZBgd3PJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864125

--- Comment #7 from Fedora Update System  ---
opendyslexic-fonts-0.600-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/opendyslexic-fonts-0.600-1.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fS48dzAyDS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864125

--- Comment #8 from Fedora Update System  ---
opendyslexic-fonts-0.600-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/opendyslexic-fonts-0.600-1.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TrQ8kok8Nd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886257] New: Review Request: fedora-upgrade - Upgrade Fedora to next version using yum upgrade

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886257

Bug ID: 886257
   Summary: Review Request: fedora-upgrade - Upgrade Fedora to
next version using yum upgrade
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: msu...@redhat.com

Spec URL: http://miroslav.suchy.cz/fedora/fedora-upgrade/fedora-upgrade.spec
SRPM URL:
http://miroslav.suchy.cz/fedora/fedora-upgrade/fedora-upgrade-18.3-1.fc18.src.rpm
Description: Upgrade Fedora to next version using yum upgrade

Fedora Account System Username: msuchy

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4780564

$ rpmlint /tmp/tito-build/fedora-upgrade-18.3-1.fc18.src.rpm
/tmp/tito-build/noarch/fedora-upgrade-18.3-1.fc18.noarch.rpm
fedora-upgrade.src: W: invalid-url Source0: fedora-upgrade-18.3.tar.gz
fedora-upgrade.noarch: E: explicit-lib-dependency libselinux-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QcDX6uppMP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835544] Review Request: perl-Pod-Markdown - Convert POD to Markdown

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=835544

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #7 from Tom "spot" Callaway  ---
Package Change Request
==
Package Name: perl-Pod-Markdown
New Branches: f16 f17 
Owners: jplesnik mmaslano ppisar psabata
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xae2Q4IBqW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review