[Bug 891152] Review Request: perl-Regexp-Assemble-Compressed - Assemble more compressed Regular Expression
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891152 Emmanuel Seyman emman...@seyman.fr changed: What|Removed |Added Status|NEW |ASSIGNED CC||emman...@seyman.fr Assignee|nob...@fedoraproject.org|emman...@seyman.fr Flags||fedora-review? --- Comment #1 from Emmanuel Seyman emman...@seyman.fr --- Taking. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=07x0ZlOynNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800105] Review Request: perl-Net-Google-Calendar - Programmatic access to Google's Calendar API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=800105 --- Comment #3 from Avi Alkalay avibra...@gmail.com --- Fixed. Please check updated SPEC at: http://avi.alkalay.net/software/perl-Net-Google-Calendar/ Thank you in advance for reviewing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5WYvoGGLQIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800105] Review Request: perl-Net-Google-Calendar - Programmatic access to Google's Calendar API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=800105 --- Comment #4 from Avi Alkalay avibra...@gmail.com --- Fixed. Please check updated SPEC at: http://avi.alkalay.net/software/perl-Net-Google-Calendar/ Thank you in advance for reviewing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vubVsM7e7Na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891195] nodejs-inherits - A tiny simple way to do classic inheritance in js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891195 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added CC||robinlee.s...@gmail.com --- Comment #1 from Robin Lee robinlee.s...@gmail.com --- A license text of WTFPL, not MIT, is included in upstream git repo. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RN3acFbME7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823338] Review Request: rubygem-moneta - unified interface for key/value stores
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823338 Josef Stribny jstri...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #15 from Josef Stribny jstri...@redhat.com --- Julian, they released Juno under Moneta in the end [1], but Chef finally dropped the dependency of Moneta [2] so we don't need to pack it for Chef 11 (next release). Perhaps you can close this bug for now as deferred. [1] https://github.com/opscode/chef/pull/552 [2] https://github.com/opscode/chef/pull/566 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JWpegUAs8Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891125] Review Request: zathura-djvu - DjVu support for zathura
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891125 --- Comment #10 from Michael Schwendt mschwe...@gmail.com --- size_t is defined in stddef.h header but also in stdlib.h stdlib.h includes stddef.h ;) For a temporary work-around such a detail doesn't really matter, though. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z4yF2XSwKqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891438] Review Request: openshift-origin-msg-common - Common msg components for OpenShift
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891438 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Assignee|nob...@fedoraproject.org|m...@zarb.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aHPM7QuWcTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823351 Josef Stribny jstri...@redhat.com changed: What|Removed |Added CC||jstri...@redhat.com Flags|needinfo?(jstribny@redhat.c | |om) | --- Comment #6 from Josef Stribny jstri...@redhat.com --- As Vit has already mentioned, I am looking into yajl-ruby to find a way to make it work with system yajl (which is one version ahead, but with patches from the patched lib included with yajl-ruby). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HaUKYfvDlqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890859] Review Request: scopy - Application to play to Italian card game Scopa
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890859 --- Comment #15 from Antonio Trande trp...@katamail.com --- I'm preparing the manpage in English and in Italian for ScoPy; I will insert them in the rpm package. I'm trying to contact the upstream too. Are there specific Guidelines for manpages ? It seems me that they are not mentioned in the Fedora Project wiki pages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FcPdl82aega=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889901] Review Request: lua-lgi - Lua bindings to GObject libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889901 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|socho...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7IBmY05l8ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891436] Review Request: lua-markdown - Markdown module for Lua
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891436 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flags||fedora-review? Status|NEW |ASSIGNED CC||socho...@redhat.com Assignee|nob...@fedoraproject.org|socho...@redhat.com --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com --- I'll review this -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kx5eYBbvmDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823343] Review Request: rubygem-net-ssh-multi - control multiple net::ssh connections via a single interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823343 Bug 823343 depends on bug 845305, which changed state. Bug 845305 Summary: rubygem-mocha-0.13.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=845305 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KSrn6Yoimia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863836] Review Request: NetworkManager-strongswan - NetworkManager VPN plugin for strongSwan
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863836 --- Comment #7 from Pavel Simerda psime...@redhat.com --- Hi, could you please point me to information about the relation between charon-nm in the strongswan-NetworkManager subpackage and the NetworkManager-strongswan package? Cheers, Pavel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CNK7kvphpKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887913] Review Request: perl-Math-Clipper - Polygon clipping in 2D
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887913 --- Comment #7 from Miro Hrončok m...@hroncok.cz --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Math-Clipper.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Math-Clipper-1.16-2.fc17.src.rpm - Removed META.json and xsp from doc - Specified version for polyclipping-devel BR - Specified version for perl(Module::Build::WithXSpp) BR - Removed perl(ExtUtils::XSpp) BR - Added BRs perl(XSLoader) and perl(constant) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6xXg64aGAka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891436] Review Request: lua-markdown - Markdown module for Lua
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891436
Stanislav Ochotnicky socho...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Stanislav Ochotnicky socho...@redhat.com ---
Summary: It's unfortunate that upstream uses unversioned filenames but package
itself is OK. It would be nice to use cp -p to preserve timestamps, but
that's extremely minor detail.
APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FESCO exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Resultdir need to be empty before review
[x]: Rpmlint is run on all rpms the build produces.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed files.
It would be nice to use cp -p
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live in a
[Bug 890859] Review Request: scopy - Application to play to Italian card game Scopa
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890859 --- Comment #16 from Michael Schwendt mschwe...@gmail.com --- There is just this, linked from the ReviewGuidelines page: | SHOULD: your package should contain man pages for binaries/scripts. | If it doesn't, work with upstream to add them where they make sense. | [32] It's a SHOULD, not a MUST, and the where they make sense is worth noting, too. The guidelines are weak at trying to answer the _why_ or _when_: | [32] http://fedoraproject.org/wiki/Packaging/Guidelines#Man_pages | | Man pages are the traditional method of getting help on a unix system. | Packages should contain man pages for all binaries/scripts. If it doesn't, | work with upstream to add them. Sometimes, other distributions (notably | Debian), have man pages for programs. You can use those as a starting point. Does /usr/bin/scopy take any command-line options at all? Else the man page might only mention few details, such as Author, Copyright/License and a brief description of what the program does. Perhaps a pointer at the HTML documentation and a hint that it is nothing like scp. *grin* If better than nothing is the only goal, someone may call such a manual helpful. I find it very unimportant. Sure, man scopy and man 6 scopy would work then, but if it were not available, that wouldn't be a big loss for a completely optional game package. IMO, a manual page for a game with a graphical user-interface, with documentation in HTML, and with RPM package details (description, license, URL, to name a few) doesn't make much sense. Translating the Italian documentation into English could be a more useful contribution to the Scopy project. As with other work, a manual page requires somebody to create/contribute the file(s) and keep them accurate during the life-time of the software/package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NH4g9uRqena=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890859] Review Request: scopy - Application to play to Italian card game Scopa
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890859 --- Comment #17 from Michael Schwendt mschwe...@gmail.com --- Btw, if I were the Scopy developer, I'd rather give it a longer file name, such as /usr/bin/scopy-card-game because I don't see any value in keeping it very short and ambiguous (- copy). ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aD0ZtMPESHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=868529
Petr Pisar ppi...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Petr Pisar ppi...@redhat.com ---
Spec file changes:
--- perl-ZMQ-LibZMQ2.spec.old 2012-11-01 13:17:28.0 +0100
+++ perl-ZMQ-LibZMQ2.spec 2012-12-28 01:28:47.0 +0100
@@ -1,6 +1,6 @@
Name: perl-ZMQ-LibZMQ2
Version:1.03
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Perl wrapper for the libzmq 2.x library
License:GPL+ or Artistic
@@ -11,19 +11,19 @@
BuildRequires: perl(AnyEvent)
BuildRequires: perl(Carp)
BuildRequires: perl(Cwd)
-BuildRequires: perl(Devel::CheckLib) = 0.4
BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Task::Weaken)
+BuildRequires: perl(File::Spec)
BuildRequires: perl(Test::Fatal)
BuildRequires: perl(Test::More) = 0.98
BuildRequires: perl(Test::Requires)
+BuildRequires: perl(Test::SharedFork)
BuildRequires: perl(Test::TCP) = 1.08
BuildRequires: perl(ZMQ::Constants) = 1.00
BuildRequires: zeromq-devel
-Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))
-Requires: perl(Task::Weaken)
-Requires: perl(ZMQ::Constants) = 1.00
+Requires: perl(:MODULE_COMPAT_%(eval `perl -V:version`; echo
$version))
+
+%{?perl_default_filter}
%description
The ZMQ::LibZMQ2 module is a wrapper of the 0MQ message passing library for
@@ -35,7 +35,7 @@
%setup -q -n ZMQ-LibZMQ2-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE=$RPM_OPT_FLAGS
+perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE=$RPM_OPT_FLAGS
make %{?_smp_mflags}
%install
@@ -43,7 +43,6 @@
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2/dev/null \;
%{_fixperms} $RPM_BUILD_ROOT/*
@@ -59,6 +58,9 @@
%changelog
+* Thu Dec 27 2012 Jose Pedro Oliveira jpo at di.uminho.pt - 1.03-2
+- Handle review itens (#868529)
+
* Wed Oct 17 2012 Jose Pedro Oliveira jpo at di.uminho.pt - 1.03-1
- First Fedora release.
TODO: You can replace %{__perl} macros with plain perl.
Ok.
TODO: Remove deleting empty directories in %install section. Current build
system does not leave empty directories.
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2/dev/null \;
Ok.
FIX: Remove bundled inc/* modules or specify all needed dependencies. E.g.
Makefile.PL calls use_xshelper from inc/Module/Install/XSUtil.pm that calls
use_ppport() which uses Devel::PPPort.
This is provided by perl now. Ok.
TODO: Build-require `perl(base)' (lib/ZMQ/LibZMQ2.pm:3).
TODO: Build-require `perl(Exporter)' (lib/ZMQ/LibZMQ2.pm:3).
TODO: Build-require `perl(XSLoader)' (lib/ZMQ/LibZMQ2.pm:4).
TODO: Build-require `perl(constant)' (lib/ZMQ/LibZMQ2.pm:12).
Not addressed. Ok.
FIX: Build-require `perl(File::Spec)' (t/100_basic.t:3).
+BuildRequires: perl(File::Spec)
Ok.
TODO: Build-require `perl(Storable)' (t/100_basic.t:8).
Not addressed. Ok.
FIX: Build-require `perl(Test::SharedFork)' (t/104_ipc.t:3).
+BuildRequires: perl(Test::SharedFork)
Ok.
TODO: Build-require `perl(File::Temp)' (t/104_ipc.t:4).
Not addressed. Ok.
FIX: Do not (build-)require `perl(Task::Weaken)', it's not needed anywhere.
-BuildRequires: perl(Task::Weaken)
-Requires: perl(Task::Weaken)
Ok.
FIX: Do not build-require `perl(Devel::CheckLib)' as it is bundled under inc
directory, or unbundle the module.
-BuildRequires: perl(Devel::CheckLib) = 0.4
Ok.
FIX: Do not export private library LibZMQ2.so.
+%{?perl_default_filter}
Ok.
FIX: Do not run-require `perl(Task::Weaken)'.
$ rpm -q --requires -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-2.fc19.x86_64.rpm
| sort | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.14)(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libzmq.so.1()(64bit)
1 perl(base)
1 perl(constant)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.16.2)
1 perl(strict)
1 perl(XSLoader)
1 perl(ZMQ::Constants)
1 rpmlib(CompressedFileNames) = 3.0.4-1
1 rpmlib(FileDigests) = 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) = 4.0-1
1 rpmlib(PayloadIsXz) = 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
TODO: Do not require unversioned `perl(ZMQ::Constants)'.
Not addressed. Ok.
FIX: Do not export private library LibZMQ2.so.
$ rpm -q --provides -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-2.fc19.x86_64.rpm
| sort | uniq -c
1 perl(ZMQ::LibZMQ2) = 1.03
1 perl-ZMQ-LibZMQ2 = 1.03-2.fc19
1 perl-ZMQ-LibZMQ2(x86-64) = 1.03-2.fc19
Binary provides are Ok.
$ rpmlint perl-ZMQ-LibZMQ2.spec ../SRPMS/perl-ZMQ-LibZMQ2-1.03-2.fc19.src.rpm
[Bug 890859] Review Request: scopy - Application to play to Italian card game Scopa
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890859 --- Comment #18 from Antonio Trande trp...@katamail.com --- (In reply to comment #16) There is just this, linked from the ReviewGuidelines page: | SHOULD: your package should contain man pages for binaries/scripts. | If it doesn't, work with upstream to add them where they make sense. | [32] It's a SHOULD, not a MUST, and the where they make sense is worth noting, too. The guidelines are weak at trying to answer the _why_ or _when_: | [32] http://fedoraproject.org/wiki/Packaging/Guidelines#Man_pages | | Man pages are the traditional method of getting help on a unix system. | Packages should contain man pages for all binaries/scripts. If it doesn't, | work with upstream to add them. Sometimes, other distributions (notably | Debian), have man pages for programs. You can use those as a starting point. Does /usr/bin/scopy take any command-line options at all? Else the man page might only mention few details, such as Author, Copyright/License and a brief description of what the program does. Perhaps a pointer at the HTML documentation and a hint that it is nothing like scp. *grin* If better than nothing is the only goal, someone may call such a manual helpful. I find it very unimportant. Sure, man scopy and man 6 scopy would work then, but if it were not available, that wouldn't be a big loss for a completely optional game package. Hi Michael. Thank you again for your availability. I don't know how much this game is known out of Italy; this is main reason because I thought to translate in English its documentation. The knowledge of this game and of its rules is fundamental to know how it works. IMO, a manual page for a game with a graphical user-interface, with documentation in HTML, and with RPM package details (description, license, URL, to name a few) doesn't make much sense. Translating the Italian documentation into English could be a more useful contribution to the Scopy project. This could be another valid option. I'm waiting to know how upstream evaluates all that. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sGnWwhy2xxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883472] Review Request: lnst - Linux Network Stack Test
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=883472
--- Comment #2 from Radek Pazdera rpazd...@redhat.com ---
(In reply to comment #1)
# Turn off the brp-python-bytecompile script
%global __os_install_post %(echo '%{__os_install_post}' |
sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')
As package spec files are like source code, it would be good to add the
comment _why_ you turn off the byte-compilation. You do explain that in the
review request, but not in the spec file.
You're right, it should be explained in the spec file as well. I added the
comment.
Requires: python2 = 2.6
Such an explicit dependency doesn't work well, since there is an automatic
dependency on a specific python(abi) version. This explicit one would be
inaccurate and superfluous.
http://fedoraproject.org/wiki/Packaging:Python
Oh, I'm sorry, I must have missed that. I changed it to require python2 only.
BuildRequires: python2-devel = 2.6, python3-devel, systemd-units
Both Python versions? The spec file doesn't handle that.
I had to include python3-devel for the py_byte_compile macro. It is not used
anything else. I might have missed here something too. Is there any way to
get the macro without the necessity to require python3-devel?
These cause several unowned directories:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
%{_mandir}/man1/%{name}-ctl.1.gz
%{_mandir}/man1/%{name}-slave.1.gz
Many reviewers here point out that it may be more future-proof/versatile to
use a wildcard to allow for a changed/reconfigured compression technique:
I fixed these as well.
Thank you very much for your comments! I really appreciate your help.
I fixed them and will repost the updated spec and srcrpm shortly.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Xsh81IycjFa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 Jose Pedro Oliveira j...@di.uminho.pt changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jose Pedro Oliveira j...@di.uminho.pt --- New Package SCM Request === Package Name: perl-ZMQ-LibZMQ2 Short Description: Perl wrapper for the libzmq 2.x library Owners: jpo Branches: f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WlDdcgdhRGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883472] Review Request: lnst - Linux Network Stack Test
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883472 --- Comment #3 from Radek Pazdera rpazd...@redhat.com --- Reposting the SRCRPM and SPEC with fixes of the mistakes Michael pointed out. I also added proper handling of the systemd service for lnst-slave that was missing in the previous version. Spec URL: http://www.stud.fit.vutbr.cz/~xpazde00/soubory/v2/lnst.spec SRPM URL: http://www.stud.fit.vutbr.cz/~xpazde00/soubory/v2/lnst-0.1-2.20121204git.fc19.src.rpm --- koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4835856 --- rpmlint output: $ rpmlint lnst.spec lnst-0.1-2.20121204git.fc19.src.rpm lnst-common-0.1-2.20121204git.fc19.noarch.rpm lnst-ctl-0.1-2.20121204git.fc19.noarch.rpm lnst-slave-0.1-2.20121204git.fc19.noarch.rpm lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/sockopt_utils.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/max_groups.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/parameters_igmp.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/igmp_utils.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_source_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_source_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_block_source.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/multicast_utils.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/client/send_simple.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_block_source.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/parameters_multicast.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_ttl.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/client/send_igmp_query.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_simple.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_loop.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_if.c 4 packages and 1 specfiles checked; 0 errors, 18 warnings. These warnings are explained in the original post above. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FxNQrCdlPYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773346] Review Request: intel-gen4asm - Compile an assembly language for the Intel 965
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=773346 --- Comment #2 from Nicolas Chauvet (kwizart) kwiz...@gmail.com --- Spec URL: http://kwizart.fedorapeople.org/review/intel-gen4asm.spec SRPM URL: http://kwizart.fedorapeople.org/review/intel-gen4asm-1.3-1.fc19.src.rpm Description: Compile an assembly language for the Intel 965 Changelog: Update to 1.3 Koji rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4836034 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=88GomPvNAYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770534] Review Request: rubygem-imagesize - Measure image size(GIF, PNG, JPEG ,,, etc)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=770534 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- (In reply to comment #7) Also, the packaged version is 0.1.1 while the latest version is 1.1.1 in Rubygems.org. Well, this is image_size, not imagesize, however I will check it later. Anyway I will push this (imagesize) into Fedora. Thank you for info. New Package SCM Request === Package Name: rubygem-imagesize Short Description: Measure image size(GIF, PNG, JPEG ,,, etc) Owners: mtasaka Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QPtxY1kLBba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770534] Review Request: rubygem-imagesize - Measure image size(GIF, PNG, JPEG ,,, etc)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=770534 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V0Qbmyocsfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DAofVuBTjma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891312] Review Request: ldapdiff - Tool for incremental LDAP directory updates based on ldif files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891312 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uOzNOFRx6la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MYMsQ9yDQNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- perl-ZMQ-LibZMQ2-1.03-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-ZMQ-LibZMQ2-1.03-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rmGKAhbPvya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- perl-ZMQ-LibZMQ2-1.03-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-ZMQ-LibZMQ2-1.03-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XCrHZFbf5Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836368] Review Request: rubygem-bicho - Library to access Bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836368
--- Comment #15 from Mamoru TASAKA mtas...@fedoraproject.org ---
Umm... there are some issues I did not notice before.
Not sure why I missed them, however anyway:
* Non-equality dependency
- Well, I did not know that rpm accepts something like
Requires: rubygem(inifile) *=* 0.4.1 (not = but
=), however I don't think this is a normal usage on
rpm.
Note that rpm -qp --requires rubygem-bicho-0.0.6-2.1.fc17.src.rpm
shows rubygem(inifile) = 0.4.1, so = is actually
regarded as = (by rpm) currently.
* Unsatisfied dependency
- Well, bicho requiers inifile no less than 0.4.1 and less than
0.5 (according to metadata), however rubygem-inifile imported
into Fedora is 2.0.2, so rubygem-bicho (built from this package)
won't work. Please fix dependency for inifile.
! Note that you have to modify dependency not on rpm spec file,
but also on %gem_spec file included in rubygem-bicho binary rpm.
? (Question) test result on %check
- From build log, test result on %check looks like:
--
+ ruby -Ilib test/helper.rb test/test_novell_plugin.rb test/test_query.rb
Run options:
# Running tests:
Finished tests in 0.000805s, 0. tests/s, 0. assertions/s.
0 tests, 0 assertions, 0 failures, 0 errors, 0 skips
--
Note 0 tests. I don't regard this as a blocker for this review,
however please recheck this.
* Build failure
- This srpm does not build on koji (for F-19). at least
BR: rubygem(minitest) or so is needed. ref:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4836144
* File list
- The following entry
--
%{gem_instdir}/test
%exclude %{gem_instdir}/test
--
on the _same_ binary rpm is confusing. The latter entry
(i.e. only %exclude ... line) is enough.
* Installing original gem, not regenerated gem
- In %build:
--
%build
gem build %{gem_name}.gemspec
gem install --local \
--install-dir .%{gem_dir} \
--bindir .%{_bindir} \
--force \
%{SOURCE0}
--
Well, using %{SOURCE0} (i.e. original gem file) here
is not what ruby packaging guideline requests. Use
regenerated gem file here
(see: example written on:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Building_gems
)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ztPsHbfgVwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891312] Review Request: ldapdiff - Tool for incremental LDAP directory updates based on ldif files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891312 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Flags|fedora-cvs+ | Flags||fedora-cvs? Last Closed||2013-01-03 11:31:49 --- Comment #6 from Nicolas Chauvet (kwizart) kwiz...@gmail.com --- imported and built, thx! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vbB9rhFocpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891312] Review Request: ldapdiff - Tool for incremental LDAP directory updates based on ldif files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891312 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags|fedora-cvs? | --- Comment #7 from Mamoru TASAKA mtas...@fedoraproject.org --- (Just unsetting fedora-cvs flag: no longer needed) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hdReEaDpaba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875353] Review Request: mfiler4 - 2 pane file manager with a embedded shell
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875353 Bug 875353 depends on bug 875352, which changed state. Bug 875352 Summary: Review Request: xyzsh - Interactive shell and text processing tool https://bugzilla.redhat.com/show_bug.cgi?id=875352 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0xhj1DMidLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773346] Review Request: intel-gen4asm - Compile an assembly language for the Intel 965
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=773346 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org --- Confirmed that at least this builds on F-18 koji build and can be installed. Taking. I would appreciate it if you would review my review request bug 875353. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r8mvmrCNMTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887846] Review Request: perl-Math-Geometry-Voronoi - Compute Voronoi diagrams from sets of points
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mZm40LZFwaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887846] Review Request: perl-Math-Geometry-Voronoi - Compute Voronoi diagrams from sets of points
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Geometry-Voronoi-1.3-7.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Math-Geometry-Voronoi-1.3-7.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=khRxsLoNPSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887846] Review Request: perl-Math-Geometry-Voronoi - Compute Voronoi diagrams from sets of points
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Geometry-Voronoi-1.3-7.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Math-Geometry-Voronoi-1.3-7.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vjaestmfoVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890830] Review Request: perl-Math-Factor-XS - Factorize numbers and calculate matching multiplications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890830 --- Comment #6 from Miro Hrončok mhron...@redhat.com --- I might need to put that hack back, asi it seems Koji is still using Module::Build 0.38: https://koji.fedoraproject.org/koji/taskinfo?taskID=4836469 Module::Build version 0.40 required--this is only version 0.38 at ./Build line 41. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qg33pfItkQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890830] Review Request: perl-Math-Factor-XS - Factorize numbers and calculate matching multiplications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890830 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ws8bu9G0tQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890830] Review Request: perl-Math-Factor-XS - Factorize numbers and calculate matching multiplications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890830 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Factor-XS-0.40-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Math-Factor-XS-0.40-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=67SxcotQv6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890831] Review Request: perl-Math-Prime-XS - Detect and calculate prime numbers with deterministic tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890831 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VDtOewrbUpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890831] Review Request: perl-Math-Prime-XS - Detect and calculate prime numbers with deterministic tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890831 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Prime-XS-0.26-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Math-Prime-XS-0.26-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dz2m8oOMAza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890831] Review Request: perl-Math-Prime-XS - Detect and calculate prime numbers with deterministic tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890831 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Prime-XS-0.26-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Math-Prime-XS-0.26-6.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=75cEMDdy2sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890830] Review Request: perl-Math-Factor-XS - Factorize numbers and calculate matching multiplications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890830 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Factor-XS-0.40-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Math-Factor-XS-0.40-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FIbLQhfcSga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876405] Review Request: perl-Module-Build-WithXSpp - XS++ enhanced flavor of Module::Build
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876405 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ce2kRmEyhsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876405] Review Request: perl-Module-Build-WithXSpp - XS++ enhanced flavor of Module::Build
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876405 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-Module-Build-WithXSpp-0.12-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Module-Build-WithXSpp-0.12-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e4bWsV4N2Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891366] Review Request: linuxconsoletools - Tools for connecting joysticks legacy devices to the kernel's input subsystem
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891366 --- Comment #2 from Petr Šabata psab...@redhat.com --- You don't seem to respect Fedora %optflags in your package. Is there a reason for that? I haven't found any other issues besides this one and would gladly approve this package once you react to the above. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B5ugHBWLWNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823352] Review Request: rubygem-chef - a client for the Chef config management system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823352 Bug 823352 depends on bug 823338, which changed state. Bug 823338 Summary: Review Request: rubygem-moneta - unified interface for key/value stores https://bugzilla.redhat.com/show_bug.cgi?id=823338 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DEFERRED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fXaBSLxc28a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823338] Review Request: rubygem-moneta - unified interface for key/value stores
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823338 Julian C. Dunn jd...@aquezada.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed||2013-01-03 12:53:23 --- Comment #16 from Julian C. Dunn jd...@aquezada.com --- Josef, I agree with you -- I will close this as DEFERRED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gBi3LP8d5ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891366] Review Request: linuxconsoletools - Tools for connecting joysticks legacy devices to the kernel's input subsystem
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891366 --- Comment #3 from Jaromír Cápík jca...@redhat.com --- Thx for mentioning that ... fixed in the 3rd release Spec URL: http://jcapik.fedorapeople.org/files/linuxconsoletools/3/linuxconsoletools.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GZOJqpxGO6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891366] Review Request: linuxconsoletools - Tools for connecting joysticks legacy devices to the kernel's input subsystem
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891366 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Petr Šabata psab...@redhat.com --- Ok, good. Don't forget to kill 'joystick' properly too :) Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ls4xYasb11a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891701] New: Review Request: amuleadunanza - File sharing client compatible with eDonkey
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891701 Bug ID: 891701 Summary: Review Request: amuleadunanza - File sharing client compatible with eDonkey Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: lorenzo.dal...@gmail.com Spec URL: http://lorenzodalrio.fedorapeople.org/amuleadunanza.spec SRPM URL: http://lorenzodalrio.fedorapeople.org/amuleadunanza-2012.1-2.fc17.src.rpm Description: aMuleAdunanzA is the mod of aMule dedicated to Fastweb ISP users. aMule is an easy to use multi-platform client for ED2K Peer-to-Peer Network. It is a fork of xMule, whis was based on eMule for Windows. aMule currently supports (but is not limited to) the following platforms: Linux, *BSD and MacOS X. Fedora Account System Username: lorenzodalrio Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4836577 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iD9WkN4Zjna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823343] Review Request: rubygem-net-ssh-multi - control multiple net::ssh connections via a single interface
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823343 --- Comment #2 from Julian C. Dunn jd...@aquezada.com --- Here is a revised SPEC and SRPM for review. I have unified the build on Fedora and EPEL6. http://jdunn.fedorapeople.org/rubygem-net-ssh-multi/rubygem-net-ssh-multi.spec http://jdunn.fedorapeople.org/rubygem-net-ssh-multi/rubygem-net-ssh-multi-1.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wlnKh5Z0DQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891366] Review Request: linuxconsoletools - Tools for connecting joysticks legacy devices to the kernel's input subsystem
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891366 Jaromír Cápík jca...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jaromír Cápík jca...@redhat.com --- New Package SCM Request === Package Name: linuxconsoletools Short Description: Tools for connecting joysticks legacy devices to the kernel's input subsystem Owners: jcapik Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vuDc8LkjqDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891366] Review Request: linuxconsoletools - Tools for connecting joysticks legacy devices to the kernel's input subsystem
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891366 Jaromír Cápík jca...@redhat.com changed: What|Removed |Added Blocks||875604 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XgntphSewZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891366] Review Request: linuxconsoletools - Tools for connecting joysticks legacy devices to the kernel's input subsystem
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891366 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BuAnJpjcS7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hR7XvLXzYSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-sensitivetickets-plugin-0.21-2.20121220svn.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CPT92OMzola=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-sensitivetickets-plugin-0.21-2.20121220svn.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=saRbnqhekua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/trac-sensitivetickets-plugin-0.21-2.20121220svn.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qlH6KicEjna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848144] Review Request: SDL2 A cross-platform multimedia library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=848144
--- Comment #8 from Michael Schwendt mschwe...@gmail.com ---
Created attachment 672205
-- https://bugzilla.redhat.com/attachment.cgi?id=672205action=edit
spec cleanup
* The linked spec file is an older one. The src.rpm is much newer.
* As I've noticed lots of no results for the various checks during the
configure step, I skimmed over the spec file and fixed several minor issues.
The diff should be self-explaining.
* SDL2-devel.x86_64 will conflict with SDL2-devel.i686 due to the sdl2-config
script
* .pc file:
$ pkg-config sdl2 --libs
-Wl,-rpath,/usr/lib64 -lSDL2 -lpthread
It includes duplicated -lpthread options and another -lSDL2 in the .private
section:
$ grep pth /usr/lib64/pkgconfig/sdl2.pc
Libs: -L${libdir} -Wl,-rpath,${libdir} -lSDL2 -lpthread
Libs.private: -lSDL2 -lpthread -lm -ldl -lpthread
* Several build requirements seem to be missing. The test programs in the
test subdirectory fail to build due to that.
* If this SDL2 is rebuilt with added BuildRequires, the tests can be built,
too.
The resulting binary rpm is missing shared library dependencies. Oh, the libs
are loaded dynamically by SDL - run-time RPM dependencies will be needed for
them, too, however, probably not limited to these:
$ grep DYNA config.status
D[SDL_AUDIO_DRIVER_ALSA_DYNAMIC]= \libasound.so.2\
D[SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC]= \libpulse-simple.so.0\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC]= \libX11.so.6\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC_XEXT]= \libXext.so.6\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC_XCURSOR]= \libXcursor.so.1\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC_XINERAMA]= \libXinerama.so.1\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC_XINPUT2]= \libXi.so.6\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC_XRANDR]= \libXrandr.so.2\
D[SDL_VIDEO_DRIVER_X11_DYNAMIC_XVIDMODE]= \libXxf86vm.so.1\
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=MkDpI0aQOZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891739] New: Review Request: trac-CGit-plugin - Replace the trac browser by CGit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891739 Bug ID: 891739 Summary: Review Request: trac-CGit-plugin - Replace the trac browser by CGit Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: puiterw...@gmail.com Spec URL: http://puiterwijk.fedorapeople.org/packages/trac-CGit-plugin/trac-CGit-plugin.spec SRPM URL: http://puiterwijk.fedorapeople.org/packages/trac-CGit-plugin/trac-CGit-plugin-1.0.5-1.fc17.src.rpm Fedora Account System Username: puiterwijk Description: Replace the trac browser by cgit. Configure the url in the cgit ini panel and TracCGit will replace the trac source browser (provided you have a working cgit installation setup). Plain and simple. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mfQ4BYDbwUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891739] Review Request: trac-CGit-plugin - Replace the trac browser by CGit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891739 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ke...@scrye.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hLPrmjvOkya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891768] New: Review Request: openshift-origin-util - Utility scripts for the OpenShift Origin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891768 Bug ID: 891768 Summary: Review Request: openshift-origin-util - Utility scripts for the OpenShift Origin Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: tdaw...@redhat.com Spec URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-util.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-util-1.0.3-2.fc18.src.rpm Description: This package contains a set of utility scripts for the OpenShift broker and node. Fedora Account System Username: tdawson maxamillion -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vqekMBGx6ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 876405] Review Request: perl-Module-Build-WithXSpp - XS++ enhanced flavor of Module::Build
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876405 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Module-Build-WithXSpp-0.12-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Module-Build-WithXSpp-0.12-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pWMg9Fhgxga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891152] Review Request: perl-Regexp-Assemble-Compressed - Assemble more compressed Regular Expression
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891152
Emmanuel Seyman emman...@seyman.fr changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Emmanuel Seyman emman...@seyman.fr ---
=== KEY ===
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4837659
[x] Rpmlint output:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
None specified, default used.
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
2efc433126074474087631dd1cfb0762 Regexp-Assemble-Compressed-0.02.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: fedora-rawhide-x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4837659
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass
All tests successful.
Files=2, Tests=23, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.12 cusr 0.01
csys = 0.16 CPU)
Result: PASS
All in all, a good job.
You might want to consider setting $RELEASE_TESTING to something so as to run
the tests in xt/ as well as t/ but I'm not going to block on this.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=oHcvimBweWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qz4HgKrb2ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868529] Review Request: perl-ZMQ-LibZMQ2 - Perl wrapper for the libzmq 2.x library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-ZMQ-LibZMQ2-1.03-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MCIODPpFpNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890830] Review Request: perl-Math-Factor-XS - Factorize numbers and calculate matching multiplications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890830 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8jv5eSTpVda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890830] Review Request: perl-Math-Factor-XS - Factorize numbers and calculate matching multiplications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890830 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Factor-XS-0.40-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LGQsDRqIc5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aiFMCxXMkda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887543] Review Request: trac-sensitivetickets-plugin - Plugin for Trac that enables sensitive tickets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887543 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- trac-sensitivetickets-plugin-0.21-2.20121220svn.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Iyy92zxMYLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887846] Review Request: perl-Math-Geometry-Voronoi - Compute Voronoi diagrams from sets of points
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TIar1I2P3fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887846] Review Request: perl-Math-Geometry-Voronoi - Compute Voronoi diagrams from sets of points
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Geometry-Voronoi-1.3-7.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2oeN1rlAiZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890831] Review Request: perl-Math-Prime-XS - Detect and calculate prime numbers with deterministic tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890831 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LbSsKXZGfSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890831] Review Request: perl-Math-Prime-XS - Detect and calculate prime numbers with deterministic tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890831 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Math-Prime-XS-0.26-6.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1jcZRm5fdka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880716] Review Request: knot - Authoritative DNS server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880716 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=17YSBXq2tSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880716] Review Request: knot - Authoritative DNS server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880716 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- knot-1.1.3-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W10KQ4svBna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891195] nodejs-inherits - A tiny simple way to do classic inheritance in js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891195 --- Comment #2 from T.C. Hollingsworth tchollingswo...@gmail.com --- (In reply to comment #1) A license text of WTFPL, not MIT, is included in upstream git repo. Fixed, thanks. Spec: http://patches.fedorapeople.org/npm/nodejs-inherits.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-inherits-1.0.0-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TOe3QpGOjSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891739] Review Request: trac-CGit-plugin - Replace the trac browser by CGit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891739 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #1 from Kevin Fenzi ke...@scrye.com --- I'll try and review this tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=goYEWNeFmEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891152] Review Request: perl-Regexp-Assemble-Compressed - Assemble more compressed Regular Expression
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891152 --- Comment #3 from Mathieu Bridon boche...@fedoraproject.org --- Thanks for the review Emmanuel! New Package SCM Request === Package Name: perl-Regexp-Assemble-Compressed Short Description: Assemble more compressed Regular Expression Owners: bochecha Branches: devel InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aigiRigbJFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891152] Review Request: perl-Regexp-Assemble-Compressed - Assemble more compressed Regular Expression
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891152 Mathieu Bridon boche...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EeXe0tApOba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
