[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Remi Collet --- Thanks for the fast review. New Package SCM Request === Package Name: php-pear-File-Fstab Short Description: Read and write fstab files Owners: remi Branches: f17 f18 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ccqj2jAODa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 Johan Cwiklinski changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Johan Cwiklinski --- php-common requirement is a false positive here. Requires are correct. Package traball is missing LICENSE file, but that is already reported upstream, and LICENSE file is provided. Issues that has been fixed in the specfile has been reported upstream. Well, guidelines are followed, no blocker :) * APPROVED * -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0KKxFCk2nW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 --- Comment #3 from Johan Cwiklinski --- Here is the phpci extensions report output: BASE: /home/builder/894100-php-pear-File-Fstab/srpm-unpacked/File_Fstab-2.0.3 --- PHP COMPAT INFO EXTENSION SUMMARY --- EXTENSION EXT min/Max PHP min/Max COUNT --- Core 4.0.0 4.0.0 31 pcre 0.0 4.0.0 2 standard 4.0.7 4.0.0 18 --- A TOTAL OF 3 EXTENSIONS WERE FOUND REQUIRED PHP 4.0.0 (MIN) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gCNqPU8iKl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854176] Review Request: python-django-admin-honeypot - A fake Django admin login screen to notify admins of attempted unauthorized access
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=854176 --- Comment #34 from Eduardo Echeverria --- Package Change Request == Package Name: python-django-admin-honeypot New Branches: f18 Owners: echevemaster -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7LraaBxdxo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 --- Comment #2 from Johan Cwiklinski --- Created attachment 676697 --> https://bugzilla.redhat.com/attachment.cgi?id=676697&action=edit fedora-review results -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QqEVnZ1msd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #26 from Fedora Update System --- duff-0.5.2-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/duff-0.5.2-5.fc16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WdCUXzX6O3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #25 from Fedora Update System --- duff-0.5.2-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/duff-0.5.2-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=izYqZrPAUG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857639] Review Request: duff - Quickly find duplicate files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857639 --- Comment #24 from Fedora Update System --- duff-0.5.2-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/duff-0.5.2-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tesmYo9THJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892625] Review Request: resiprocate - SIP reference implementation, SIP proxy, TURN server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892625 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com Assignee|nob...@fedoraproject.org|lemen...@gmail.com Flags||fedora-review? --- Comment #4 from Peter Lemenkov --- I'll review it and I'll sponsor you as well. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gaOOHJhm88&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863796] Review Request: printrun - RepRap printer interface and tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Pete Travis changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|m...@petetravis.com Whiteboard|| NotReady Flags||needinfo+ Flags||needinfo?(mhroncok@redhat.c ||om) --- Comment #12 from Pete Travis --- Hey Miro, I'd like to tackle this review, assuming you have a sponsor. Please bear with me - I'm new at this, but I'm not afraid to ask for help :) A couple comments after a quick look: Cited license is AGPLv3, but the included COPYING file is GPLv3. These should match. Not all included files use the same licence, and some files do not declare a license. The relationship between `printrun` and `skeinforge` is a little confusing. The SPEC for printrun looks like it is working with skeinforge files and directories. You'll want to make sure there are no conflicts between these related packages. There are no upstream URLs for Source1, Source2, Source3. All sources should have a valid URL. You're using the generated pronterface.lang with the common package; it should probably go with the pronterface files rpmlint complains about macros in changelog; you probably don't need to be so specific about the change made. The locales loop is failing in my build log, you should investigate. I hope this helps get the ball rolling, will check in again soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tI8x3wkM73&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892682] Review Request: sugar-fototoon - A cartoon creating game for Sugar
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892682 --- Comment #3 from Kalpa Welivitigoda --- Thanks Mario. Unknown package group warning is common for all sugar packages. Please find the modified files. Spec URL: http://callkalpa.fedorapeople.org/sugar-fototoon/sugar-fototoon.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-fototoon/sugar-fototoon-13-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RSIh5VMOne&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799701] Review Request: logkeys - Linux keylogger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799701 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #5 from Ankur Sinha (FranciscoD) --- Hi Brendan, Francois, I seem to have somehow missed this bug. I'll update it over the weekend. Thanks for the ping. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kCaiu6Gvli&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833164] Review Request: python-pyudev - udev bindings for python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=833164 Simon Green changed: What|Removed |Added CC||lw...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3voU3xYsk4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724869] Review Request: python-flask-oauth - Adds OAuth support to Flask
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724869 François Cami changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 18:20:51 --- Comment #5 from François Cami --- Built and shipped, closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=620TlYAir5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724006] Review Request: python-flask-wtf - Simple integration of Flask and WTForms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724006 Bug 724006 depends on bug 725139, which changed state. Bug 725139 Summary: Review Request: lastuser - User management application https://bugzilla.redhat.com/show_bug.cgi?id=725139 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XQNPp50lQy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725139] Review Request: lastuser - User management application
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=725139 François Cami changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 18:18:42 --- Comment #10 from François Cami --- Built and shipped. Closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZMryttwaFK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724869] Review Request: python-flask-oauth - Adds OAuth support to Flask
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724869 Bug 724869 depends on bug 725139, which changed state. Bug 725139 Summary: Review Request: lastuser - User management application https://bugzilla.redhat.com/show_bug.cgi?id=725139 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LCmfux7wyT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724864] Review Request: python-flask-openid - OpenID support for Flask
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724864 Bug 724864 depends on bug 725139, which changed state. Bug 725139 Summary: Review Request: lastuser - User management application https://bugzilla.redhat.com/show_bug.cgi?id=725139 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T0hK939zQY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724874] Review Request: python-flask-lastuser - Flask extension for LastUser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724874 François Cami changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 18:15:57 --- Comment #5 from François Cami --- Built and shipped. Closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6mf9xoVYwr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894176] Review Request: wbox - HTTP testing tool and configuration-less HTTP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894176 Eduardo Echeverria changed: What|Removed |Added CC||echevemas...@gmail.com --- Comment #2 from Eduardo Echeverria --- Fabian you're packager, Why the flag FE-NEEDSPONSOR? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o1HYQwkvD4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 722713] Review Request: pyace - Optimal route search in a complete graph
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=722713 François Cami changed: What|Removed |Added Status|NEW |CLOSED CC||f...@fcami.net Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review? | Last Closed||2013-01-10 18:10:05 --- Comment #26 from François Cami --- Mauricio is marked inactive in FAS and has not answered for more than a week. Closing (see https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lREJ4h8Eu9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891177] nodejs-ansi - Node.js native addon build tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891177 Michael Scherer changed: What|Removed |Added CC||m...@zarb.org Assignee|nob...@fedoraproject.org|m...@zarb.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BRM7tpwV1i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891206] nodejs-mkdirp - Recursively mkdir, like `mkdir -p`
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891206 Michael Scherer changed: What|Removed |Added Assignee|nob...@fedoraproject.org|m...@zarb.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fv6uo0rP8D&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845689] Review Request: python-django-setuptest - python-django-setuptest
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845689 François Cami changed: What|Removed |Added Status|NEW |CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 17:50:23 --- Comment #10 from François Cami --- Luis, please close the bug yourself next time, or better yet, use bodhi's built-in bugzilla management. See: https://fedoraproject.org/wiki/Bodhi Package built and shipped. Closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7yo1mPyrS4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724857] Review Request: python-blinker - Fast, simple object-to-object and broadcast signaling
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724857 François Cami changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 17:31:28 --- Comment #6 from François Cami --- Built and shipped, closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kMflv0yoMJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891170] Review Request: e_dbus - Wrappers around D-Bus for EFL based applications
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891170
leigh scott changed:
What|Removed |Added
CC||leigh123li...@googlemail.co
||m
--- Comment #1 from leigh scott ---
Hi,
I believe the pkgconfig requirement should be removed from the -devel
subpackage as per guidelines.
also this requirement need s changing from
Requires: %{name} = %{version}-%{release}
to
Requires: %{name}%{?_isa} = %{version}-%{release}
In the %install section please change
%make_install
to
make install DESTDIR=%{buildroot}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=p0ennFfoWm&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769056] Review Request: wbox - HTTP testing tool and configuration-less HTTP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=769056 Fabian Affolter changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Comment #8 from Fabian Affolter --- *** This bug has been marked as a duplicate of bug 894176 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XnQYabzkTF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894176] Review Request: wbox - HTTP testing tool and configuration-less HTTP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894176 Fabian Affolter changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) CC||athma...@gmail.com --- Comment #1 from Fabian Affolter --- *** Bug 769056 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EDcOR7Ht9r&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894176] Review Request: wbox - HTTP testing tool and configuration-less HTTP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894176 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Alias||wbox -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WC0zfY0fZZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891295] Review Request: enlightenment - The window manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891295 leigh scott changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ir5SQHzxPT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769056] Review Request: wbox - HTTP testing tool and configuration-less HTTP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=769056 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch Alias|wbox| -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nrGhi54nIA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894176] New: Review Request: wbox - HTTP testing tool and configuration-less HTTP server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894176 Bug ID: 894176 Summary: Review Request: wbox - HTTP testing tool and configuration-less HTTP server Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: m...@fabian-affolter.ch Spec URL: http://fab.fedorapeople.org/packages/SRPMS/wbox.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/wbox-5-4.fc17.src.rpm Project URL: http://www.hping.org/wbox/ Description: Wbox aims to help you having fun while testing HTTP related stuff. You can use it to perform many tasks, including the following. * Benchmarking how much time it takes to generate content for your web application. * Web server and web application stressing. * Testing virtual domains configuration without the need to alter your local resolver. * Check if your redirects are working correctly emitting the right HTTP code. * Test if the HTTP compression is working and if it is actually serving pages faster. * Use it as a configuration-less HTTP server to share files! Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4856163 rpmlint output: [fab@laptop11 SRPMS]$ rpmlint wbox-5-4.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@laptop11 x86_64]$ rpmlint wbox* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=La9rAbiQwQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894163] Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894163 Shawn Iwinski changed: What|Removed |Added Blocks|893708 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KLP02fC9y9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894167] Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894167 Shawn Iwinski changed: What|Removed |Added CC||siwin...@redhat.com --- Comment #1 from Shawn Iwinski --- *** Bug 894163 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WduWVnQsAz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894163] Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894163 Shawn Iwinski changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2013-01-10 16:41:38 --- Comment #1 from Shawn Iwinski --- Submitted under wrong account *again*. SORRY! *** This bug has been marked as a duplicate of bug 894167 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9rlibqajic&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894167] Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894167 Shawn Iwinski changed: What|Removed |Added CC||fed...@famillecollet.com Blocks||893708 Alias||php-PsrLog -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=35r5gt7pUb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894163] Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894163 Shawn Iwinski changed: What|Removed |Added Alias|php-PsrLog | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wXhyUbl0dJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799701] Review Request: logkeys - Linux keylogger
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799701 François Cami changed: What|Removed |Added CC||f...@fcami.net Flags||needinfo?(sanjay.ankur@gmai ||l.com) --- Comment #4 from François Cami --- FranciscoD, could you please update your SPEC according to Brendan's comments? Otherwise we might consider this as stalled. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NtsqYhtr96&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863796] Review Request: printrun - RepRap printer interface and tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #11 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/printrun-0.0-15.20121103git6fa4766.fc18.src.rpm Corrected SRPM link -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YBeNbq2dVt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894167] New: Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894167 Bug ID: 894167 Summary: Review Request: php-PsrLog - Common interface for logging libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: shawn.iwin...@gmail.com Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PsrLog.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PsrLog-1.0.0-1.fc17.src.rpm Description: This package holds all interfaces/classes/traits related to PSR-3 (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md). Note that this is not a logger of its own. It is merely an interface that describes a logger. See the specification for more details. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R9tiEuX96h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 724006] Review Request: python-flask-wtf - Simple integration of Flask and WTForms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=724006 François Cami changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 16:37:30 --- Comment #5 from François Cami --- Built and shipped in Fedora. Closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JA3R3qw2t3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 723966] Review Request: python-wtforms - Forms validation and rendering library for python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=723966 Bug 723966 depends on bug 724006, which changed state. Bug 724006 Summary: Review Request: python-flask-wtf - Simple integration of Flask and WTForms https://bugzilla.redhat.com/show_bug.cgi?id=724006 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HGYHeonlaA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890872] Review Request: OpenTK - C# library that wraps OpenGL, OpenCL and OpenAL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890872 --- Comment #4 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/OpenTK.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/OpenTK-0.0-4.20130108svn3126.fc18.src.rpm New revision -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AI1UxHMmRk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 --- Comment #14 from Fedora Update System --- seam-solder-3.1.1-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jjcmf9hENm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pthh9SZiG3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889901] Review Request: lua-lgi - Lua bindings to GObject libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889901 --- Comment #12 from Fedora Update System --- lua-lgi-0.6.2-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tfeSZgtTa0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889901] Review Request: lua-lgi - Lua bindings to GObject libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889901 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i8NSWMXsh9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894163] Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894163 Shawn Iwinski changed: What|Removed |Added CC||fed...@famillecollet.com Blocks||893708 Alias||php-PsrLog -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gchGv1zvzw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894163] New: Review Request: php-PsrLog - Common interface for logging libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894163 Bug ID: 894163 Summary: Review Request: php-PsrLog - Common interface for logging libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: siwin...@redhat.com Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PsrLog.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PsrLog-1.0.0-1.fc17.src.rpm Description: This package holds all interfaces/classes/traits related to PSR-3 (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md). Note that this is not a logger of its own. It is merely an interface that describes a logger. See the specification for more details. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HbgIDhJTlB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 727911] Review Request: funnel - Handling submissions of talks and voting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=727911 François Cami changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||f...@fcami.net Resolution|--- |CURRENTRELEASE Last Closed||2013-01-10 16:07:07 --- Comment #5 from François Cami --- funnel is in Fedora. Closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pUyC9Jl4LA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851804] Review Request: compiz-plugins-extra - Additional Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851804 --- Comment #5 from Wolfgang Ulbrich --- a scratch build works fine against f19, i used the latest srpm from fedorapeople. http://koji.fedoraproject.org/koji/taskinfo?taskID=4855939 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wbpFwBRrOt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892682] Review Request: sugar-fototoon - A cartoon creating game for Sugar
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892682 --- Comment #2 from Mario Blättermann --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855915 Rpmlint is silent so far, besides a warning about unknown package group. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EFJavbWggg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891240] nodejs-which - A JavaScript implementation of the 'which' command
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891240
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Summary OK.
TODO: Description might be longer. Consider something as: "This Node.JS module
is a JavaScript implementation of the standard Unix 'which' command. It tells
you which XXX will be run when you do MAGIC" (I am not familiar with the MAGIC,
you might be :P)
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-which-1.0.5-3.fc18.src.rpm
../RPMS/noarch/nodejs-which-1.0.5-3.fc18.noarch.rpm
nodejs-which.noarch: W: only-non-binary-in-usr-lib
nodejs-which.noarch: W: dangling-relative-symlink /usr/bin/which.nodejs
../node_modules/bin/which
nodejs-which.noarch: W: no-manual-page-for-binary which.nodejs
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
FIX: Bad symlink: /usr/bin/which.nodejs ../node_modules/bin/which
Should link to ../lib/node_modules/...
I suppose ../lib/node_modules/which/bin/which
TODO: Consider working with upstream to add a manpage.
All others are false positive.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE: MIT. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/which-1.0.5.tgz
e26f39d7b152c700636472ab4da57bfb9af17972c49a9e2a06f9ff347d8fad42
../SOURCES/which-1.0.5.tgz
$ spectool -g nodejs-which.spec
Getting http://registry.npmjs.org/which/-/which-1.0.5.tgz to ./which-1.0.5.tgz
$ sha256sum which-1.0.5.tgz
e26f39d7b152c700636472ab4da57bfb9af17972c49a9e2a06f9ff347d8fad42
which-1.0.5.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-which-1.0.5-3.fc18.noarch.rpm
lrwxrwxrwx1 rootroot 25 led 10 20:41
/usr/bin/which.nodejs -> ../node_modules/bin/which
drwxr-xr-x2 rootroot0 led 10 20:41
/usr/lib/node_modules/which
drwxr-xr-x2 rootroot0 led 10 20:41
/usr/lib/node_modules/which/node_modules
-rw-r--r--1 rootroot 435 bře 2 2012
/usr/lib/node_modules/which/package.json
-rw-r--r--1 rootroot 3002 bře 2 2012
/usr/lib/node_modules/which/which.js
drwxr-xr-x2 rootroot0 led 10 20:41
/usr/share/doc/nodejs-which-1.0.5
-rw-r--r--1 rootroot 1092 zář 23 2011
/usr/share/doc/nodejs-which-1.0.5/LICENSE
-rw-r--r--1 rootroot 199 srp 7 2011
/usr/share/doc/nodejs-which-1.0.5/README.md
Perms OK
FIX: There is no /usr/lib/node_modules/which/bin/which !
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
Please,
[Bug 891237] nodejs-slide - A flow control library that fits in a slideshow
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891237 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PicHtexiDd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UZMfJrElzA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5LEtd93SdG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891205] nodejs-minimatch - JavaScript glob matcher
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891205 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X9YHHPmivX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891176] nodejs-abbrev - Abbreviation calculator for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891176 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6TkvzaGmpG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892682] Review Request: sugar-fototoon - A cartoon creating game for Sugar
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892682
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #1 from Mario Blättermann ---
BuildRequires: python
That's strange. Usually, a Python package needs either python2-devel or
python3-devel as build requirement. Have you tried to build it in Mock or on
the Koji build server?
rm -rf $RPM_BUILD_ROOT
%{__python} ./setup.py install --prefix=%{buildroot}/%{_prefix}
Don't mix $RPM_BUILD_ROOT and %{buildroot}.
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root,-)
This is obsolete for ages, unless your package points to EPEL5.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=M0aHA0QiA1&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891237] nodejs-slide - A flow control library that fits in a slideshow
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891237 --- Comment #8 from T.C. Hollingsworth --- (In reply to comment #7) > No problem, if you are bored waiting for reviews, take one of mine: > https://fedoraproject.org/wiki/Features/3D_Printing#Dependencies I intend to take several of yours when I get a chance. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sbRYsLoyp1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891237] nodejs-slide - A flow control library that fits in a slideshow
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891237 --- Comment #7 from Miro Hrončok --- (In reply to comment #5) > Thanks for the review! No problem, if you are bored waiting for reviews, take one of mine: https://fedoraproject.org/wiki/Features/3D_Printing#Dependencies Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kO1gORHXqT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891205] nodejs-minimatch - JavaScript glob matcher
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891205 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-minimatch Short Description: JavaScript glob matcher Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=obhuDJbVfF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893866
--- Comment #3 from Michael Scherer ---
Also, it doesn't build on mock on my f18
cc -DCHROMEOS_ENVIRONMENT -Wall -Werror -DNDEBUG
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/firmware/include
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/firmware/stub/include
-I./include
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/firmware/lib/include
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/firmware/lib/cgptlib/include
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/firmware/lib/cryptolib/include
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/firmware/lib/tpm_lite/include
-I/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/host/include -MMD -MF
/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/build/utility/dump_kernel_config.d
dump_kernel_config_main.c -o
/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/build/utility/dump_kernel_config
\
/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/build/vboot_host.a
/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/build/libdump_kernel_config.a
-lcrypto
bmpblk_utility.cc: In member function 'void
vboot_reference::BmpBlockUtil::load_yaml_config(const char*)':
bmpblk_utility.cc:102:61: error: format '%u' expects argument of type 'unsigned
int', but argument 2 has type 'std::vector >::size_type
{aka long unsigned int}' [-Werror=format]
bmpblk_utility.cc:106:59: error: format '%u' expects argument of type 'unsigned
int', but argument 2 has type 'std::map,
vboot_reference::ImageConfig>::size_type {aka long unsigned int}'
[-Werror=format]
bmpblk_utility.cc:117:61: error: format '%u' expects argument of type 'unsigned
int', but argument 2 has type 'std::map,
vboot_reference::ScreenConfig>::size_type {aka long unsigned int}'
[-Werror=format]
bmpblk_utility.cc: In member function 'void
vboot_reference::BmpBlockUtil::pack_bmpblock()':
bmpblk_utility.cc:595:70: error: format '%u' expects argument of type 'unsigned
int', but argument 3 has type 'std::basic_string::size_type {aka long
unsigned int}' [-Werror=format]
bmpblk_utility.cc:607:59: error: format '%u' expects argument of type 'unsigned
int', but argument 3 has type 'std::basic_string::size_type {aka long
unsigned int}' [-Werror=format]
cc1plus: all warnings being treated as errors
make[1]: Leaving directory
`/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/utility'
make[1]: ***
[/builddir/build/BUILD/vboot-utils-20130109gite8cfa31/build/utility/bmpblk_utility.o]
Error 1
make: *** [all] Error 2
erreur : Mauvais statut de sortie pour /var/tmp/rpm-tmp.KWRVaz (%build)
Erreur de construction de RPM :
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=swglc4ZBWp&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891237] nodejs-slide - A flow control library that fits in a slideshow
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891237 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-slide Short Description: A flow control library that fits in a slideshow Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oskSIErO18&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866 Michael Scherer changed: What|Removed |Added CC||m...@zarb.org --- Comment #2 from Michael Scherer --- Hi, a few notes : - the patches are not documented, and should mention how they were sent upstream ( if done ) - there is no comment on how the tarball got generated - why does it requires this : BuildRequires:glibc-static - the package do not seems to use the %optflag macro, and so not use the regular build option. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oyq623AjP4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891237] nodejs-slide - A flow control library that fits in a slideshow
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891237 --- Comment #5 from T.C. Hollingsworth --- Sorry, must have missed this bug when I was updating them yesterday. For the record, the updated version is at: Spec: http://patches.fedorapeople.org/npm/nodejs-slide.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-slide-1.1.3-4.fc17.src.rpm Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tla9SA0DOo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 --- Comment #5 from Miro Hrončok --- I cannot see TAP review request. Is it a huge scope like npm, or it is single package (or with only a few deps)? If it is simple, file the request and I can do do review, so you can inlude tests to other pakages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ctqs4GmGVK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891176] nodejs-abbrev - Abbreviation calculator for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891176 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-abbrev Short Description: Abbreviation calculator for Node.js Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=57CXoH16Ob&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891240] nodejs-which - A JavaScript implementation of the 'which' command
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891240 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hhRhO4w758&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-glob Short Description: A little globber for Node.js Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pNLqIcG1NJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0eMOoGGYp6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 --- Comment #4 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-read-package-json Short Description: npm's package.json parser Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fAg5Vp3iV0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891197] nodejs-init-package-json - A node module to get your node module started
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891197
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-init-package-json-0.0.7-2.fc18.src.rpm
../RPMS/noarch/nodejs-init-package-json-0.0.7-2.fc18.noarch.rpm
nodejs-init-package-json.src: W: spelling-error %description -l en_US metadata
-> meta data, meta-data, metatarsi
nodejs-init-package-json.noarch: W: spelling-error %description -l en_US
metadata -> meta data, meta-data, metatarsi
nodejs-init-package-json.noarch: W: only-non-binary-in-usr-lib
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/read-package-json
/usr/lib/node_modules/read-package-json
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/read
/usr/lib/node_modules/read
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/promzard
/usr/lib/node_modules/promzard
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/semver
/usr/lib/node_modules/semver
2 packages and 0 specfiles checked; 0 errors, 7 warnings.
All are false positive. Symlinks OK, package requires (among others)
npm(read-package-json), npm(semver), npm(promzard), npm(read). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in package.json: BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/init-package-json-0.0.7.tgz
49bb2b928df52c81ae832afa97c7ded5e63a9cd9062109c06bd864e055e99386
../SOURCES/init-package-json-0.0.7.tgz
$ wget
https://registry.npmjs.org/init-package-json/-/init-package-json-0.0.7.tgz
--no-check-certificate
$ sha256sum init-package-json-0.0.7.tgz
49bb2b928df52c81ae832afa97c7ded5e63a9cd9062109c06bd864e055e99386
init-package-json-0.0.7.tgz
OK
FIX: The Source0 URL should use http, not https
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-init-package-json-0.0.7-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 20:20
/usr/lib/node_modules/init-package-json
-rw-r--r--1 rootroot 4695 lis 8 00:00
/usr/lib/node_modules/init-package-json/default-input.js
-rw-r--r--1 rootroot 3048 čec 24 10:16
/usr/lib/node_modules/init-package-json/init-package-json.js
drwxr-xr-x2 rootroot0 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules
lrwxrwxrwx1 rootroot 30 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules/promzard ->
/usr/lib/node_modules/promzard
lrwxrwxrwx1 rootroot 26 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules/read ->
/usr/lib/node_modules/read
lrwxrwxrwx1 rootroot 39 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules/read-package-json ->
/usr/lib/node_modules/read-package-json
lrwxrwxrwx1 rootroot 28 led 10 20:20
/usr/lib/node_modules/init-package-json/no
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 --- Comment #3 from T.C. Hollingsworth --- Tests are currently disabled since TAP is not yet packaged for Fedora. I'll enable them once the necessary packages are approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gQfSJxp373&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891197] nodejs-init-package-json - A node module to get your node module started
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891197 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1XQ1awXrbs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891226
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-read-package-json-0.1.12-2.fc18.src.rpm
../RPMS/noarch/nodejs-read-package-json-0.1.12-2.fc18.noarch.rpm
nodejs-read-package-json.src: W: spelling-error Summary(en_US) npm's -> Np's
nodejs-read-package-json.src: W: summary-not-capitalized C npm's package.json
parser
nodejs-read-package-json.src: W: spelling-error %description -l en_US npm ->
pm, rpm, ppm
nodejs-read-package-json.noarch: W: spelling-error Summary(en_US) npm's -> Np's
nodejs-read-package-json.noarch: W: summary-not-capitalized C npm's
package.json parser
nodejs-read-package-json.noarch: W: spelling-error %description -l en_US npm ->
pm, rpm, ppm
nodejs-read-package-json.noarch: W: only-non-binary-in-usr-lib
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/glob
/usr/lib/node_modules/glob
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/slide
/usr/lib/node_modules/slide
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/semver
/usr/lib/node_modules/semver
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/lru-cache
/usr/lib/node_modules/lru-cache
2 packages and 0 specfiles checked; 0 errors, 11 warnings.
All are false positive. Symlinks OK, package requires (among others) npm(glob),
npm(slide), npm(semver), npm(lru-cache). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE: BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/read-package-json-0.1.12.tgz
c2367e09e9b7733ee10e32745091dc34b465ba31e5bf66269865edae91966f9b
../SOURCES/read-package-json-0.1.12.tgz
$ spectool -g nodejs-read-package-json.spec
Getting
http://registry.npmjs.org/read-package-json/-/read-package-json-0.1.12.tgz to
./read-package-json-0.1.12.tgz
$ sha256sum read-package-json-0.1.12.tgz
c2367e09e9b7733ee10e32745091dc34b465ba31e5bf66269865edae91966f9b
read-package-json-0.1.12.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p
../RPMS/noarch/nodejs-read-package-json-0.1.12-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 19:59
/usr/lib/node_modules/read-package-json
drwxr-xr-x2 rootroot0 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules
lrwxrwxrwx1 rootroot 26 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/glob ->
/usr/lib/node_modules/glob
lrwxrwxrwx1 rootroot 31 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/lru-cache ->
/usr/lib/node_modules/lru-cache
lrwxrwxrwx1 rootroot 28 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/semver ->
/usr/lib/node_modules/semver
lrwxrwxrwx1 rootroot 27 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/slide ->
/usr/lib/node_
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kRkgfm3NT4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891190
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-fstream-0.1.21-2.fc18.src.rpm
../RPMS/noarch/nodejs-fstream-0.1.21-2.fc18.noarch.rpm
nodejs-fstream.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-fstream.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-fstream.src: W: spelling-error %description -l en_US symlink -> slinky
nodejs-fstream.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-fstream.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-fstream.noarch: W: spelling-error %description -l en_US symlink ->
slinky
nodejs-fstream.noarch: W: only-non-binary-in-usr-lib
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/rimraf /usr/lib/node_modules/rimraf
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/inherits
/usr/lib/node_modules/inherits
2 packages and 0 specfiles checked; 0 errors, 11 warnings.
All are false positive. Symlinks OK, package requires (among others)
npm(graceful-fs), npm(inherits), npm(mkdirp), npm(rimraf). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
MUST: The License field in the package spec file must match the actual license.
FIX: License in spec is MIT, but LICENSE file says BSD.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/fstream-0.1.21.tgz
31ebe4997ffdf91cb6542a5067c4226ab301292e3d87c79da539c828403022ca
../SOURCES/fstream-0.1.21.tgz
$ spectool -g nodejs-fstream.spec
$ sha256sum fstream-0.1.21.tgz
31ebe4997ffdf91cb6542a5067c4226ab301292e3d87c79da539c828403022ca
fstream-0.1.21.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-fstream-0.1.21-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 19:41
/usr/lib/node_modules/fstream
-rw-r--r--1 rootroot 1120 lis 19 2011
/usr/lib/node_modules/fstream/fstream.js
drwxr-xr-x2 rootroot0 led 10 19:41
/usr/lib/node_modules/fstream/lib
-rw-r--r--1 rootroot 2210 pro 28 01:57
/usr/lib/node_modules/fstream/lib/abstract.js
-rw-r--r--1 rootroot 1652 pro 28 01:57
/usr/lib/node_modules/fstream/lib/collect.js
-rw-r--r--1 rootroot 6394 pro 28 01:57
/usr/lib/node_modules/fstream/lib/dir-reader.js
-rw-r--r--1 rootroot 4504 pro 28 01:57
/usr/lib/node_modules/fstream/lib/dir-writer.js
-rw-r--r--1 rootroot 3861 pro 28 01:57
/usr/lib/node_modules/fstream/lib/file-reader.js
-rw-r--r--1 rootroot 2396 pro 28 01:57
/usr/lib/node_modules/fstream/lib/file-writer.js
-rw-r--r--1 rootroot 632 pro 28 01:57
/usr/lib/node_modules/fstream/lib/get-type.js
-rw-r--r--1
[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=798071 --- Comment #14 from Jon Chiappetta --- Sorry for the minor update but I made a temporary folder with the current spec file so that when I reorganize my backup stuff I don't have to keep updating links. Spec: http://fossjon.fedorapeople.org/review/fedora-arm-installer.spec SRPM: http://fossjon.fedorapeople.org/packages/fedora-arm-installer/fedora-arm-installer-1.0.2-4.fc18.src.rpm RPM: http://fossjon.fedorapeople.org/packages/fedora-arm-installer/fedora-arm-installer-1.0.2-4.fc18.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=goKf6k5gWR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894119] Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894119 Matias Kreder changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BwtFfHOONA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894119] New: Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894119 Bug ID: 894119 Summary: Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: del...@fedoraproject.org Spec URL: http://delete.fedorapeople.org/vert.x/vert.x.spec SRPM URL: http://delete.fedorapeople.org/vert.x/vert.x-1.3.0.final-1.fc19.src.rpm Description: Vert.x is an event driven application framework that runs on the JVM - a run-time with real concurrency and unrivalled performance. Vert.x then exposes the API in Ruby, Java, Groovy, JavaScript and Python. You can check examples at http://vertx.io/examples.html or take a look at the vertx documentation at http://vertx.io/docs.html Fedora Account System Username: delete This is my first package, I need a sponsor. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855700 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bXsqRJyRY3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891190 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AYRblcX1Qo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891193
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-glob-3.1.14-2.fc18.src.rpm
../RPMS/noarch/nodejs-glob-3.1.14-2.fc18.noarch.rpm
nodejs-glob.src: W: spelling-error Summary(en_US) globber -> glibber, lobber,
gobbler
nodejs-glob.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-glob.src: W: spelling-error %description -l en_US minimatch -> mini
match, mini-match, mismatch
nodejs-glob.noarch: W: spelling-error Summary(en_US) globber -> glibber,
lobber, gobbler
nodejs-glob.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-glob.noarch: W: only-non-binary-in-usr-lib
nodejs-glob.noarch: W: dangling-symlink
/usr/lib/node_modules/glob/node_modules/minimatch
/usr/lib/node_modules/minimatch
nodejs-glob.noarch: W: dangling-symlink
/usr/lib/node_modules/glob/node_modules/inherits /usr/lib/node_modules/inherits
nodejs-glob.noarch: W: dangling-symlink
/usr/lib/node_modules/glob/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
2 packages and 0 specfiles checked; 0 errors, 9 warnings.
All are false positive. Symlinks OK, package requires (among others)
npm(graceful-fs), npm(inherits), npm(minimatch). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE, BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/glob-3.1.14.tgz
957a06bbea0ff6ea03527ac7b59a3f9b9856874716600a69a05965f7e18f501a
../SOURCES/glob-3.1.14.tgz
$ spectool -g nodejs-glob.spec
Getting http://registry.npmjs.org/glob/-/glob-3.1.14.tgz to ./glob-3.1.14.tgz
$ sha256sum glob-3.1.14.tgz
957a06bbea0ff6ea03527ac7b59a3f9b9856874716600a69a05965f7e18f501a
glob-3.1.14.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-glob-3.1.14-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/lib/node_modules/glob
-rw-r--r--1 rootroot16753 říj 15 17:33
/usr/lib/node_modules/glob/glob.js
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/lib/node_modules/glob/node_modules
lrwxrwxrwx1 rootroot 33 led 10 19:14
/usr/lib/node_modules/glob/node_modules/graceful-fs ->
/usr/lib/node_modules/graceful-fs
lrwxrwxrwx1 rootroot 30 led 10 19:14
/usr/lib/node_modules/glob/node_modules/inherits ->
/usr/lib/node_modules/inherits
lrwxrwxrwx1 rootroot 31 led 10 19:14
/usr/lib/node_modules/glob/node_modules/minimatch ->
/usr/lib/node_modules/minimatch
-rw-r--r--1 rootroot 548 říj 15 17:34
/usr/lib/node_modules/glob/package.json
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/share/doc/nodejs-glob-3.1.14
-rw-r--r--1 rootroot 1310 čec 24 03:27
/usr/share/doc/nodejs-glob-3.1.14/LICENSE
-rw-r--r--1 rootroot 9042 srp 6 23:05
/usr/share/doc/nodejs-glob-3.1.14/README.md
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/share/doc/nodejs-glob-3.1.14/examples
-rw-r--r
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gVPIgZMN9X&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #10 from Wolfgang Ulbrich --- sorry, wrong Package Change Request Package Change Request == Package Name: emerald-themes New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jbkNtGd8rQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zFstVRHG4I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oP3vSb0J9Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891210] nodejs-nopt - Node.js option parsing
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891210
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-nopt-2.0.0-2.fc18.src.rpm
../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm
nodejs-nopt.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nopt.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nopt.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-nopt.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nopt.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nopt.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-nopt.noarch: W: only-non-binary-in-usr-lib
nodejs-nopt.noarch: W: dangling-relative-symlink /usr/bin/nopt
../node_modules/nopt/bin/nopt.js
nodejs-nopt.noarch: W: dangling-symlink
/usr/lib/node_modules/nopt/node_modules/abbrev /usr/lib/node_modules/abbrev
nodejs-nopt.noarch: W: no-manual-page-for-binary nopt
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
FIX: The symlink goes to /usr/node_modules/nopt/bin/nopt.js, should go to
/usr/lib/node_modules/nopt/bin/nopt.js
TODO: If you think it is helpful, work with upstream to add the manpage
All others are false positive.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE, MIT. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/nopt-2.0.0.tgz
112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5
../SOURCES/nopt-2.0.0.tgz
$ spectool -g nodejs-nopt.spec
Getting http://registry.npmjs.org/nopt/-/nopt-2.0.0.tgz to ./nopt-2.0.0.tgz
$ sha256sum nopt-2.0.0.tgz
112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5
nopt-2.0.0.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm
lrwxrwxrwx1 rootroot 32 led 10 19:01
/usr/bin/nopt -> ../node_modules/nopt/bin/nopt.js
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt/bin
-rwxr-xr-x1 rootroot 1277 čec 6 2011
/usr/lib/node_modules/nopt/bin/nopt.js
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt/lib
-rw-r--r--1 rootroot15520 čec 24 00:34
/usr/lib/node_modules/nopt/lib/nopt.js
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt/node_modules
lrwxrwxrwx1 rootroot 28 led 10 19:01
/usr/lib/node_modules/nopt/node_modules/abbrev -> /usr/lib/node_modules/abbrev
-rw-r--r--1 rootroot 499 čec 24 00:36
/usr/lib/node_modules/nopt/package.json
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/share/doc/nodejs-nopt-2.0.0
-rw-r--r--1 rootroot 1092 kvě 13 2011
/usr/share/doc/nodejs-nopt-2.0.0/LICENSE
-rw-r--r--1 rootroot 7610 říj 14 2011
/usr/share/doc/
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #8 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ssg5qwLdFd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891210] nodejs-nopt - Node.js option parsing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891210 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ej8HgIxnMY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891176] nodejs-abbrev - Abbreviation calculator for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891176
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-abbrev-1.0.4-1.src.rpm
../RPMS/noarch/nodejs-abbrev-1.0.4-1.noarch.rpm
nodejs-abbrev.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-abbrev.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-abbrev.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
All false positives.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE, MIT. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/abbrev-1.0.4.tgz
8dc0f480571a4a19e74f1abd4f31f6a70f94953d1ccafa16ed1a544a19a6f3a8
../SOURCES/abbrev-1.0.4.tgz
$ spectool -g nodejs-abbrev.spec
Getting http://registry.npmjs.org/abbrev/-/abbrev-1.0.4.tgz to
./abbrev-1.0.4.tgz
$ sha256sum abbrev-1.0.4.tgz
8dc0f480571a4a19e74f1abd4f31f6a70f94953d1ccafa16ed1a544a19a6f3a8
abbrev-1.0.4.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-abbrev-1.0.4-1.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/lib/node_modules/abbrev
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/lib/node_modules/abbrev/lib
-rw-r--r--1 rootroot 2769 led 9 01:02
/usr/lib/node_modules/abbrev/lib/abbrev.js
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/lib/node_modules/abbrev/node_modules
-rw-r--r--1 rootroot 390 led 9 01:02
/usr/lib/node_modules/abbrev/package.json
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/share/doc/nodejs-abbrev-1.0.4
-rw-r--r--1 rootroot 1092 kvě 13 2011
/usr/share/doc/nodejs-abbrev-1.0.4/LICENSE
-rw-r--r--1 rootroot 499 říj 4 2010
/usr/share/doc/nodejs-abbrev-1.0.4/README.md
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=VPvHjqa4Bo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 Johan Cwiklinski changed: What|Removed |Added CC||jo...@x-tnd.be Assignee|nob...@fedoraproject.org|jo...@x-tnd.be Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bVy5SXMxAx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 --- Comment #1 from Remi Collet --- Sorry, Spec URL: https://raw.github.com/remicollet/remirepo/1eff2458ecb9eb1b73218a4888dcba0a6766e802/php/pear/php-pear-File-Fstab/php-pear-File-Fstab.spec Notes : - target Fedora, EL-5, EL-6 - new dependency of horde 5.0.3 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=87cQHC7btL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] New: Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 Bug ID: 894100 Summary: Review Request: php-pear-File-Fstab - Read and write fstab files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: fed...@famillecollet.com Spec URL: https://raw.github.com/remicollet/remirepo/1eff2458ecb9eb1b73218a4888dcba0a6766e802/php/horde/php-horde-horde/php-horde-horde.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pear-File-Fstab-2.0.3-1.remi.src.rpm Description: File_Fstab is an easy-to-use package which can read & write UNIX fstab files. It presents a pleasant object-oriented interface to the fstab. Features: * Supports blockdev, label, and UUID specification of mount device. * Extendable to parse non-standard fstab formats by defining a new Entry class for that format. * Easily examine and set mount options for an entry. * Stable, functional interface. * Fully documented with PHPDoc. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SmkYHcbSJi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891176] nodejs-abbrev - Abbreviation calculator for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891176 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pt9zGvtBWR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851814
leigh scott changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #7 from leigh scott ---
APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/emerald-themes
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[?]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/leigh/851814-emerald-themes/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/emerald-themes
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[?]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[?]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[?]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #6 from leigh scott --- You have a missing buildrequires autoconf + /usr/bin/bzip2 -dc /builddir/build/SOURCES/emerald-themes-0.5.2.tar.bz2 + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd emerald-themes-0.5.2 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + autoreconf -v --install /var/tmp/rpm-tmp.0LjNdY: line 37: autoreconf: command not found error: Bad exit status from /var/tmp/rpm-tmp.0LjNdY (%prep) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HpwaDjoXrW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: mariadb - A community developed branch of MySQL database
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #27 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cN8qSIQl1V&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #5 from Wolfgang Ulbrich --- Thank you for those hints. %changelog * Thu Jan 10 2013 Wolfgang Ulbrich - 1:0.5.2-8 - own directory - use new upstream package for rpm - generate configure - drop unnecessary command to remove import.sh - remove files with 'bak' instead of '~' - drop unnecessary 'chmod' command new successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855521 Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/emerald-themes.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/emerald-themes-0.5.2-8.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YFCMiqgaW8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877167] Dead Review Request: matefaenza-icon-theme - MATE Desktop faenza compilation theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877167 leigh scott changed: What|Removed |Added Summary|Review Request: |Dead Review Request: |matefaenza-icon-theme - |matefaenza-icon-theme - |MATE Desktop faenza |MATE Desktop faenza |compilation theme |compilation theme -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DVPtba1CMI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
