[Bug 891202] nodejs-lru-cache - A cache object that deletes the least recently used items
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891202 --- Comment #2 from T.C. Hollingsworth --- This version should fix the identified issues. Spec: http://patches.fedorapeople.org/npm/nodejs-lru-cache.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-lru-cache-2.2.1-2.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854332 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KEtt2uoZjZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891236] nodejs-sigmund - Quick and dirty signatures for Objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891236 --- Comment #2 from T.C. Hollingsworth --- Thanks for taking this! This version should correct the identified issues: Spec: http://patches.fedorapeople.org/npm/nodejs-sigmund.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-sigmund-1.0.0-2.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854414 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KdKDpGvtwH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891238] nodejs-tar - tar for node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891238 --- Comment #5 from T.C. Hollingsworth --- (In reply to comment #4) > Issues: > === > - Package doesn't install properly. > Note: Installation errors (see attachment) I assume this is because of the missing deps? The deps appear correct and matched by packages under review. > - Old EL5ims, but packager want to have it in EPEL5 > - Url for upstream is https://github.com/isaacs/node-tar Fixed. This version also includes fixes for issues identified in other reviews. Spec: http://patches.fedorapeople.org/npm/nodejs-tar.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-tar-0.1.14-3.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854430 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nTaMgiJrUB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891240] nodejs-which - A JavaScript implementation of the 'which' command
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891240 --- Comment #1 from T.C. Hollingsworth --- Updated with empty %build sections and other issues found in various reviews. Spec: http://patches.fedorapeople.org/npm/nodejs-which.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-which-1.0.5-3.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4854399 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dSqI8Jfg6v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891175] node-gyp - Node.js native addon build tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891175 Bug 891175 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tKM6mV45bj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 Bug 891193 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XxP7o0RStg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891215] nodejs-npm-registry-client - Client for the npm registry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891215 Bug 891215 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hktDuScQs2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891195] nodejs-inherits - A tiny simple way to do classic inheritance in js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891195 T.C. Hollingsworth changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-01-10 03:20:51 --- Comment #7 from T.C. Hollingsworth --- Built for rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=4854452 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N5GIGRNAj8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 Bug 891193 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PbWXTfPkcc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891181] nodejs-block-stream - A stream of blocks
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891181 Bug 891181 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SWPhhLUCSt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891190 Bug 891190 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SNdrpnEp9Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891212] nodejs-npmconf - The config thing npm uses
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891212 Bug 891212 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DKRUI9wdGh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891192] nodejs-fstream-npm - An fstream class for creating npm packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891192 Bug 891192 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dNJUGzmjaP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891238] nodejs-tar - tar for node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891238 Bug 891238 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YVTPhRsPmn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891171] Review Request: npm - Node.js package manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891171 Bug 891171 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bYST9AW2R7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891238] nodejs-tar - tar for node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891238 Bug 891238 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cWcHU8Lek4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891212] nodejs-npmconf - The config thing npm uses
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891212 Bug 891212 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9lSn0m249K&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891192] nodejs-fstream-npm - An fstream class for creating npm packages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891192 Bug 891192 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J5mYJY7R60&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891194] nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891194 T.C. Hollingsworth changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #10 from T.C. Hollingsworth --- Builds are failing due to a missing epoch in a nodejs update I pushed earlier. I'll retry tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z5o5IOZsQX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891171] Review Request: npm - Node.js package manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891171 Bug 891171 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eQQXxrCYlE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891181] nodejs-block-stream - A stream of blocks
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891181 Bug 891181 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KvPOLIKobt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891171] Review Request: npm - Node.js package manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891171 Bug 891171 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wSujDxm3DM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 Bug 891193 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e6JPnBNkNR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891175] node-gyp - Node.js native addon build tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891175 Bug 891175 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hTfboTJUmo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891194] nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891194 T.C. Hollingsworth changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-01-10 03:19:05 --- Comment #9 from T.C. Hollingsworth --- Built for rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=4854434 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A6sTccSUOz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891171] Review Request: npm - Node.js package manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891171 Bug 891171 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FBevWbwcdk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891190 Bug 891190 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PnoL25EWHa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891190 Bug 891190 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zfTYMieD9y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891195] nodejs-inherits - A tiny simple way to do classic inheritance in js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891195 T.C. Hollingsworth changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #8 from T.C. Hollingsworth --- Builds are failing due to a forgotten epoch in the v8 dependency introduced in a nodejs update I pushed earlier. I'll retry tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W5tgy8AAYJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 Bug 891193 depends on bug 891195, which changed state. Bug 891195 Summary: nodejs-inherits - A tiny simple way to do classic inheritance in js https://bugzilla.redhat.com/show_bug.cgi?id=891195 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TUZUnrLYME&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891215] nodejs-npm-registry-client - Client for the npm registry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891215 Bug 891215 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rxSPLGiLEP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891190 Bug 891190 depends on bug 891194, which changed state. Bug 891194 Summary: nodejs-graceful-fs - 'fs' module with incremental back-off on EMFILE https://bugzilla.redhat.com/show_bug.cgi?id=891194 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0XnvFHVS1y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891238] nodejs-tar - tar for node
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891238 --- Comment #6 from Michael Scherer --- Yep, that's the missing deps. But as I started on the review, I prefered to paste it as ASAP rather than waiting and forgetting. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i0IDFoCOL0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891173] opener - Opens stuff, like webpages and files and executables
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891173 --- Comment #3 from T.C. Hollingsworth --- (In reply to comment #2) > Shouldn't it be called nodejs-opener ? Well this ships a binary you can call, so that's why I didn't prefix it, but this one could go either way, really. Probably should add nodejs- since it's kind of generic. Anyway, here's the fixed version for %build, etc for now: Spec: http://patches.fedorapeople.org/npm/opener.spec SRPM: http://patches.fedorapeople.org/npm/opener-1.3.0-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qgcjMStoOd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891171] Review Request: npm - Node.js package manager
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891171 --- Comment #4 from T.C. Hollingsworth --- New upstream release + %build section and other fixes for issues identified in other reviews Spec: http://patches.fedorapeople.org/npm/npm.spec SRPM: http://patches.fedorapeople.org/npm/npm-1.2.0-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MNKCsIGlhi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836368] Review Request: rubygem-bicho - Library to access Bugzilla
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836368 --- Comment #17 from Mamoru TASAKA --- For -2.2: * Non-equality dependency - Please fix the line below, too. --- Requires: rubygem(highline) "=>" 1.6.2 --- * Unsatisfied dependency - As I said in the comment 15 (but "not on" should be read as "not only on", sorry), you have to modify gemspec file, too. Currently: --- [mtasaka@localhost ~]$ rpm -q rubygem-bicho rubygem-bicho-0.0.6-2.2.fc.noarch [mtasaka@localhost ~]$ ruby -e "require 'bicho'" /usr/share/rubygems/rubygems/dependency.rb:247:in `to_specs': Could not find inifile (~> 0.4.1) amongst [RubyInline-3.11.0, ZenTest-4.6.2, abstract-1.0.0, actionmailer-3.2.8, actionpack-3.2.8, , zoom-0.4.1] (Gem::LoadError) from /usr/share/rubygems/rubygems/specification.rb:777:in `block in activate_dependencies' from /usr/share/rubygems/rubygems/specification.rb:766:in `each' from /usr/share/rubygems/rubygems/specification.rb:766:in `activate_dependencies' from /usr/share/rubygems/rubygems/specification.rb:750:in `activate' from /usr/share/rubygems/rubygems.rb:212:in `rescue in try_activate' from /usr/share/rubygems/rubygems.rb:209:in `try_activate' from /usr/share/rubygems/rubygems/custom_require.rb:59:in `rescue in require' from /usr/share/rubygems/rubygems/custom_require.rb:35:in `require' from -e:1:in `' --- * File list - Rakefile still seems to be installed in -doc. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NFvjPs1leX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891205] nodejs-minimatch - JavaScript glob matcher
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891205 Miro Hrončok changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Miro Hrončok --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fCvjzM1vnN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891237] nodejs-slide - A flow control library that fits in a slideshow
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891237 Miro Hrončok changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Miro Hrončok --- Reading spec only, as you didn't provide new links. All FIXes fixed. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m8O7sln3UN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877651 --- Comment #30 from Paulo Andrade --- (In reply to comment #16) > Have you applied for bundling exceptions for cython, ipython, and pexpect? Exception has been granted for 6 month ipython and pexect only if no solution can be found: https://fedorahosted.org/fpc/ticket/238 It should be 6 months for ipython but depending on flow of review I can at least experiment on backporting the ipython patches targeted to sagemath 5.6. Unfortunately, probably will need to use the bundled pexpect. I did mail the pexpect author but got no response, and started a small thread about in at https://groups.google.com/forum/?fromgroups=#!topic/sage-devel/_tEyhHq7Vwg -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6amzvdfl00&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893465] Review Request: siddhanta-fonts - Devanagari script font for Sanskrit, Vedic, Hindi, Nepali languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893465 --- Comment #1 from Parag --- https://fedoraproject.org/wiki/Siddhanta_fonts -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YlyNPhvg9q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851814
--- Comment #4 from leigh scott ---
Please fix
MD5-sum check
-
http://cgit.compiz.org/fusion/decorators/emerald-themes/snapshot/emerald-themes-0.5.2.tar.bz2
:
CHECKSUM(SHA256) this package :
1c2c77a0fff352569a2f013e8b6c1fd99e2b6f9185c9a64d2cf2e918d9de4841
CHECKSUM(SHA256) upstream package :
146b97129675a83cd532646a0a7232ccee222caaa5bb32f802dfd8e7ee34eaac
diff -r also reports differences
And also change from
%files
%doc ChangeLog COPYING README
%{_datadir}/emerald/*
to
%files
%doc ChangeLog COPYING README
%{_datadir}/emerald/themes/
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=URDQESBVsv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891999] Review Request: lua-penlight - Penlight Lua Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999 --- Comment #4 from Stanislav Ochotnicky --- Package now fails to build (during tests): lua: run.lua:3: module 'lfs' not found Seems like tests should only be enabled when docs are built as well -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i18gpMCnPe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851806] Review Request: ccsm - Plugin and configuration tool - Compiz Fusion Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851806 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z0cYNffM6H&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851812] Review Request: compiz-manager - A wrapper script to start compiz with proper options
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851812 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iiRLUq6XHe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891207] nodejs-mute-stream - Basic pass-through stream, but when muted, the bytes are dropped
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891207 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yf3Wew5MJP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891223] nodejs-read - An implementation of read(1) for node programs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891223 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D7yU0Xlz0i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891999] Review Request: lua-penlight - Penlight Lua Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999 --- Comment #5 from Thomas Moschny --- Sorry, forgot one BR. Spec URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight.spec SRPM URL: http://thm.fedorapeople.org/lua-penlight/lua-penlight-1.0.3-3.a.fc17.src.rpm %changelog * Thu Jan 10 2013 Thomas Moschny <..> - 1.0.3-3.a - Add BR on lua-filesystem (needed when running the tests). - Fix line-endings for the examples. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V5QPavLnZq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891999] Review Request: lua-penlight - Penlight Lua Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999 Stanislav Ochotnicky changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Stanislav Ochotnicky --- Very nice, thanks for taking the issues up with upstream as well. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m33Ec875E4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851804] Review Request: compiz-plugins-extra - Additional Compiz Fusion plugins for Compiz
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851804 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|leigh123li...@googlemail.co |mario.blaetterm...@gmail.co |m |m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sqmAyo6foP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875150
--- Comment #21 from Honza Horak ---
Created attachment 676314
--> https://bugzilla.redhat.com/attachment.cgi?id=676314&action=edit
Changes made in spec file
(In reply to comment #13)
> [!]: License field in the package spec file matches the actual license.
> Looking at the README and the result of fedora-review's licensecheck
> (will attach) it seems there could be also LGPLv2 and/or BSD licensed files.
> Could you check it ?
Some of the files indeed are under LGPLv2, respectively BSD license. I've
included also corresponding license files, but I'm not sure what to do with two
identical license files (COPYING.Percona and COPYING.Google) -- both BSD
license, but with different copyright authority. I've included both, but I'm
not sure if this is a correct solution. If anybody knows better how to handle
it, just let me know.
(In reply to comment #15)
> 2) Given that mariadb won't be available for F17 you don't need to check
> whether macroized systemd scriptlets exist (they do in F18+)
>
> - %if 0%{?systemd_post:1}
> - %systemd_post mysqld.service
> - %else
> - if [ $1 = 1 ]; then
> -# Initial installation
> -/bin/systemctl daemon-reload >/dev/null 2>&1 || :
> - fi
> - %endif
> + %systemd_post mysqld.service
Even if mariadb won't be officially in F17-, some users may want to build it
there on their own, so I'd better keep the backward compatible macro there for
the time F17 is supported. I've added a comment about the reason into the spec.
The rest issues should be fixed, I'm attaching a diff for easier check.
Also the links are updated:
Spec URL: http://hhorak.fedorapeople.org/mariadb-review/mariadb.spec
SRPM URL:
http://hhorak.fedorapeople.org/mariadb-review/mariadb-5.5.28a-5.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=q0ZpOrH932&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875308] Review Request: mate-menu-editor - MATE Desktop menu editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875308 --- Comment #4 from David Xie --- Created attachment 676367 --> https://bugzilla.redhat.com/attachment.cgi?id=676367&action=edit Spec file for mate-menu-editor v1.5.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pVTuasUIZa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #22 from Jiri Popelka --- (In reply to comment #21) > ... but I'm not sure what to do with > two identical license files (COPYING.Percona and COPYING.Google) -- both BSD > license, but with different copyright authority. I've included both ... I'd do the same. > Even if mariadb won't be officially in F17-, some users may want to build it > there on their own, so I'd better keep the backward compatible macro there Fair enough. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dqS9ylOH0Z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 Jiri Popelka changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #23 from Jiri Popelka --- I haven't spotted any more problems so I consider this package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LdzEyxfmSC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866901] Review Request: gogui - GUI to play game of Go
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #25 from Christophe Burgun --- Spec has been updated with your recommendations (see changelog) New links : SPEC : http://jouty.fedorapeople.org/gogui.spec SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-10.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CRkhZxSOLT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875308] Review Request: mate-menu-editor - MATE Desktop menu editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875308 leigh scott changed: What|Removed |Added CC|leigh123li...@googlemail.co | |m | Assignee|leigh123li...@googlemail.co |nob...@fedoraproject.org |m | Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uOiPp3qOzq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875308] Review Request: mate-menu-editor - MATE Desktop menu editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875308 leigh scott changed: What|Removed |Added Status|ASSIGNED|NEW CC||leigh123li...@googlemail.co ||m -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SxZucBUULl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785460] Review Request: php-horde-Horde-Mime - Horde MIME Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785460 --- Comment #2 from Remi Collet --- Please update to 2.0.x Please also consider php 5.5 patch attached in http://bugs.horde.org/ticket/11913 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AlZzsTXLwX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785486] Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785486 --- Comment #2 from Remi Collet --- Please update to 2.0.x Please also consider php 5.5 patch attached to http://bugs.horde.org/ticket/11943 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gJuwSkA2QV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888840] Review Request: maven-dependency-analyzer - Maven dependency analyzer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=40 Mikolaj Izdebski changed: What|Removed |Added Status|NEW |CLOSED CC||mizde...@redhat.com Resolution|--- |NEXTRELEASE Last Closed||2013-01-10 10:20:53 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3tuvrrdyEx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883472] Review Request: lnst - Linux Network Stack Test
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883472 --- Comment #5 from Radek Pazdera --- Alright :). I removed the dependency on python3-devel and used the macros instead. Thanks again! Spec URL: http://www.stud.fit.vutbr.cz/~xpazde00/soubory/v3/lnst.spec SRPM URL: http://www.stud.fit.vutbr.cz/~xpazde00/soubory/v3/lnst-0.1-3.20121204git.fc19.src.rpm --- koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855315 --- rpmlint output: rpmlint lnst.spec lnst-0.1-3.20121204git.fc19.src.rpm lnst-common-0.1-3.20121204git.fc19.noarch.rpm lnst-ctl-0.1-3.20121204git.fc19.noarch.rpm lnst-slave-0.1-3.20121204git.fc19.noarch.rpm lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/sockopt_utils.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/max_groups.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/igmp_utils.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_source_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/parameters_igmp.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_source_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_block_source.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_membership.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/multicast_utils.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/client/send_simple.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_block_source.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/parameters_multicast.h lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_ttl.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/client/send_igmp_query.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/server/recv_simple.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_loop.c lnst-ctl.noarch: W: devel-file-in-non-devel-package /usr/share/lnst/test_tools/multicast/offline/sockopt_if.c 4 packages and 1 specfiles checked; 0 errors, 18 warnings. These warnings are explained in the original review request above. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FsGcDQoEUy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 Honza Horak changed: What|Removed |Added Flags||fedora-cvs? --- Comment #24 from Honza Horak --- New Package SCM Request === Package Name: mariadb Short Description: A community developed branch of MySQL database Owners: hhorak tgl Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OZj2FGHu8L&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877167] Review Request: matefaenza-icon-theme - MATE Desktop faenza compilation theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877167 David Xie changed: What|Removed |Added CC||david.script...@gmail.com --- Comment #10 from David Xie --- (In reply to comment #9) > Here we go :-) > > > Spec URL: > http://leigh123linux.fedorapeople.org/pub/review/mate-icon-theme-faenza/2/ > matefaenza-icon-theme.spec > > > SRPM URL: > http://leigh123linux.fedorapeople.org/pub/review/mate-icon-theme-faenza/2/ > matefaenza-icon-theme-1.5.0-2.fc17.src.rpm Can't see them, page 404. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cLo0VBIF43&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891999] Review Request: lua-penlight - Penlight Lua Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999 Thomas Moschny changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Thomas Moschny --- Thanks again for the review! New Package SCM Request === Package Name: lua-penlight Short Description: Penlight Lua Libraries Owners: thm Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qBlBCp1AS0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #25 from Jon Ciesla --- Summary and request name mismatch, please correct. Also, no need to request f19, devel branch is automatic. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9309pabHCd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891999] Review Request: lua-penlight - Penlight Lua Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891999 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yFxuf3gXE4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: mariadb - A community developed branch of MySQL database
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 Honza Horak changed: What|Removed |Added Summary|Review Request: MariaDB - |Review Request: mariadb - A |An enhanced drop-in |community developed branch |replacement for MySQL |of MySQL database -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Bks0JzN9i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: mariadb - A community developed branch of MySQL database
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 Honza Horak changed: What|Removed |Added Flags||fedora-cvs? --- Comment #26 from Honza Horak --- New Package SCM Request === Package Name: mariadb Short Description: A community developed branch of MySQL database Owners: hhorak tgl Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mr9YZicMiR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877167] Review Request: matefaenza-icon-theme - MATE Desktop faenza compilation theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877167 leigh scott changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2013-01-10 11:23:49 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AObX0X54iO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870133] Review Request: maven-file-management - Maven Shared File Management API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870133 Michal Srb changed: What|Removed |Added CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZYeTzZUy50&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877167] Dead Review Request: matefaenza-icon-theme - MATE Desktop faenza compilation theme
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877167 leigh scott changed: What|Removed |Added Summary|Review Request: |Dead Review Request: |matefaenza-icon-theme - |matefaenza-icon-theme - |MATE Desktop faenza |MATE Desktop faenza |compilation theme |compilation theme -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DVPtba1CMI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #5 from Wolfgang Ulbrich --- Thank you for those hints. %changelog * Thu Jan 10 2013 Wolfgang Ulbrich - 1:0.5.2-8 - own directory - use new upstream package for rpm - generate configure - drop unnecessary command to remove import.sh - remove files with 'bak' instead of '~' - drop unnecessary 'chmod' command new successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855521 Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/emerald-themes.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/emerald-themes-0.5.2-8.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YFCMiqgaW8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875150] Review Request: mariadb - A community developed branch of MySQL database
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #27 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cN8qSIQl1V&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #6 from leigh scott --- You have a missing buildrequires autoconf + /usr/bin/bzip2 -dc /builddir/build/SOURCES/emerald-themes-0.5.2.tar.bz2 + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd emerald-themes-0.5.2 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + autoreconf -v --install /var/tmp/rpm-tmp.0LjNdY: line 37: autoreconf: command not found error: Bad exit status from /var/tmp/rpm-tmp.0LjNdY (%prep) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HpwaDjoXrW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851814
leigh scott changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #7 from leigh scott ---
APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/emerald-themes
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[?]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/leigh/851814-emerald-themes/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/emerald-themes
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[?]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[?]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[?]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX
[Bug 891176] nodejs-abbrev - Abbreviation calculator for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891176 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pt9zGvtBWR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] New: Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 Bug ID: 894100 Summary: Review Request: php-pear-File-Fstab - Read and write fstab files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: fed...@famillecollet.com Spec URL: https://raw.github.com/remicollet/remirepo/1eff2458ecb9eb1b73218a4888dcba0a6766e802/php/horde/php-horde-horde/php-horde-horde.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pear-File-Fstab-2.0.3-1.remi.src.rpm Description: File_Fstab is an easy-to-use package which can read & write UNIX fstab files. It presents a pleasant object-oriented interface to the fstab. Features: * Supports blockdev, label, and UUID specification of mount device. * Extendable to parse non-standard fstab formats by defining a new Entry class for that format. * Easily examine and set mount options for an entry. * Stable, functional interface. * Fully documented with PHPDoc. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SmkYHcbSJi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 --- Comment #1 from Remi Collet --- Sorry, Spec URL: https://raw.github.com/remicollet/remirepo/1eff2458ecb9eb1b73218a4888dcba0a6766e802/php/pear/php-pear-File-Fstab/php-pear-File-Fstab.spec Notes : - target Fedora, EL-5, EL-6 - new dependency of horde 5.0.3 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=87cQHC7btL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894100 Johan Cwiklinski changed: What|Removed |Added CC||jo...@x-tnd.be Assignee|nob...@fedoraproject.org|jo...@x-tnd.be Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bVy5SXMxAx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891176] nodejs-abbrev - Abbreviation calculator for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891176
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-abbrev-1.0.4-1.src.rpm
../RPMS/noarch/nodejs-abbrev-1.0.4-1.noarch.rpm
nodejs-abbrev.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-abbrev.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-abbrev.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
All false positives.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE, MIT. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/abbrev-1.0.4.tgz
8dc0f480571a4a19e74f1abd4f31f6a70f94953d1ccafa16ed1a544a19a6f3a8
../SOURCES/abbrev-1.0.4.tgz
$ spectool -g nodejs-abbrev.spec
Getting http://registry.npmjs.org/abbrev/-/abbrev-1.0.4.tgz to
./abbrev-1.0.4.tgz
$ sha256sum abbrev-1.0.4.tgz
8dc0f480571a4a19e74f1abd4f31f6a70f94953d1ccafa16ed1a544a19a6f3a8
abbrev-1.0.4.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-abbrev-1.0.4-1.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/lib/node_modules/abbrev
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/lib/node_modules/abbrev/lib
-rw-r--r--1 rootroot 2769 led 9 01:02
/usr/lib/node_modules/abbrev/lib/abbrev.js
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/lib/node_modules/abbrev/node_modules
-rw-r--r--1 rootroot 390 led 9 01:02
/usr/lib/node_modules/abbrev/package.json
drwxr-xr-x2 rootroot0 led 10 18:35
/usr/share/doc/nodejs-abbrev-1.0.4
-rw-r--r--1 rootroot 1092 kvě 13 2011
/usr/share/doc/nodejs-abbrev-1.0.4/LICENSE
-rw-r--r--1 rootroot 499 říj 4 2010
/usr/share/doc/nodejs-abbrev-1.0.4/README.md
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=VPvHjqa4Bo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891210] nodejs-nopt - Node.js option parsing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891210 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ej8HgIxnMY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #8 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ssg5qwLdFd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891210] nodejs-nopt - Node.js option parsing
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891210
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-nopt-2.0.0-2.fc18.src.rpm
../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm
nodejs-nopt.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nopt.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nopt.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-nopt.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nopt.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nopt.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm
nodejs-nopt.noarch: W: only-non-binary-in-usr-lib
nodejs-nopt.noarch: W: dangling-relative-symlink /usr/bin/nopt
../node_modules/nopt/bin/nopt.js
nodejs-nopt.noarch: W: dangling-symlink
/usr/lib/node_modules/nopt/node_modules/abbrev /usr/lib/node_modules/abbrev
nodejs-nopt.noarch: W: no-manual-page-for-binary nopt
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
FIX: The symlink goes to /usr/node_modules/nopt/bin/nopt.js, should go to
/usr/lib/node_modules/nopt/bin/nopt.js
TODO: If you think it is helpful, work with upstream to add the manpage
All others are false positive.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE, MIT. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/nopt-2.0.0.tgz
112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5
../SOURCES/nopt-2.0.0.tgz
$ spectool -g nodejs-nopt.spec
Getting http://registry.npmjs.org/nopt/-/nopt-2.0.0.tgz to ./nopt-2.0.0.tgz
$ sha256sum nopt-2.0.0.tgz
112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5
nopt-2.0.0.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm
lrwxrwxrwx1 rootroot 32 led 10 19:01
/usr/bin/nopt -> ../node_modules/nopt/bin/nopt.js
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt/bin
-rwxr-xr-x1 rootroot 1277 čec 6 2011
/usr/lib/node_modules/nopt/bin/nopt.js
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt/lib
-rw-r--r--1 rootroot15520 čec 24 00:34
/usr/lib/node_modules/nopt/lib/nopt.js
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/lib/node_modules/nopt/node_modules
lrwxrwxrwx1 rootroot 28 led 10 19:01
/usr/lib/node_modules/nopt/node_modules/abbrev -> /usr/lib/node_modules/abbrev
-rw-r--r--1 rootroot 499 čec 24 00:36
/usr/lib/node_modules/nopt/package.json
drwxr-xr-x2 rootroot0 led 10 19:01
/usr/share/doc/nodejs-nopt-2.0.0
-rw-r--r--1 rootroot 1092 kvě 13 2011
/usr/share/doc/nodejs-nopt-2.0.0/LICENSE
-rw-r--r--1 rootroot 7610 říj 14 2011
/usr/share/doc/
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oP3vSb0J9Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zFstVRHG4I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #10 from Wolfgang Ulbrich --- sorry, wrong Package Change Request Package Change Request == Package Name: emerald-themes New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jbkNtGd8rQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gVPIgZMN9X&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891193
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-glob-3.1.14-2.fc18.src.rpm
../RPMS/noarch/nodejs-glob-3.1.14-2.fc18.noarch.rpm
nodejs-glob.src: W: spelling-error Summary(en_US) globber -> glibber, lobber,
gobbler
nodejs-glob.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-glob.src: W: spelling-error %description -l en_US minimatch -> mini
match, mini-match, mismatch
nodejs-glob.noarch: W: spelling-error Summary(en_US) globber -> glibber,
lobber, gobbler
nodejs-glob.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-glob.noarch: W: only-non-binary-in-usr-lib
nodejs-glob.noarch: W: dangling-symlink
/usr/lib/node_modules/glob/node_modules/minimatch
/usr/lib/node_modules/minimatch
nodejs-glob.noarch: W: dangling-symlink
/usr/lib/node_modules/glob/node_modules/inherits /usr/lib/node_modules/inherits
nodejs-glob.noarch: W: dangling-symlink
/usr/lib/node_modules/glob/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
2 packages and 0 specfiles checked; 0 errors, 9 warnings.
All are false positive. Symlinks OK, package requires (among others)
npm(graceful-fs), npm(inherits), npm(minimatch). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE, BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/glob-3.1.14.tgz
957a06bbea0ff6ea03527ac7b59a3f9b9856874716600a69a05965f7e18f501a
../SOURCES/glob-3.1.14.tgz
$ spectool -g nodejs-glob.spec
Getting http://registry.npmjs.org/glob/-/glob-3.1.14.tgz to ./glob-3.1.14.tgz
$ sha256sum glob-3.1.14.tgz
957a06bbea0ff6ea03527ac7b59a3f9b9856874716600a69a05965f7e18f501a
glob-3.1.14.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-glob-3.1.14-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/lib/node_modules/glob
-rw-r--r--1 rootroot16753 říj 15 17:33
/usr/lib/node_modules/glob/glob.js
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/lib/node_modules/glob/node_modules
lrwxrwxrwx1 rootroot 33 led 10 19:14
/usr/lib/node_modules/glob/node_modules/graceful-fs ->
/usr/lib/node_modules/graceful-fs
lrwxrwxrwx1 rootroot 30 led 10 19:14
/usr/lib/node_modules/glob/node_modules/inherits ->
/usr/lib/node_modules/inherits
lrwxrwxrwx1 rootroot 31 led 10 19:14
/usr/lib/node_modules/glob/node_modules/minimatch ->
/usr/lib/node_modules/minimatch
-rw-r--r--1 rootroot 548 říj 15 17:34
/usr/lib/node_modules/glob/package.json
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/share/doc/nodejs-glob-3.1.14
-rw-r--r--1 rootroot 1310 čec 24 03:27
/usr/share/doc/nodejs-glob-3.1.14/LICENSE
-rw-r--r--1 rootroot 9042 srp 6 23:05
/usr/share/doc/nodejs-glob-3.1.14/README.md
drwxr-xr-x2 rootroot0 led 10 19:14
/usr/share/doc/nodejs-glob-3.1.14/examples
-rw-r--r
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891190 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AYRblcX1Qo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894119] New: Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894119 Bug ID: 894119 Summary: Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: del...@fedoraproject.org Spec URL: http://delete.fedorapeople.org/vert.x/vert.x.spec SRPM URL: http://delete.fedorapeople.org/vert.x/vert.x-1.3.0.final-1.fc19.src.rpm Description: Vert.x is an event driven application framework that runs on the JVM - a run-time with real concurrency and unrivalled performance. Vert.x then exposes the API in Ruby, Java, Groovy, JavaScript and Python. You can check examples at http://vertx.io/examples.html or take a look at the vertx documentation at http://vertx.io/docs.html Fedora Account System Username: delete This is my first package, I need a sponsor. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855700 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bXsqRJyRY3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894119] Review Request: vert.x - Framework for JavaScript, CoffeeScript, Ruby, Python, Groovy and Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894119 Matias Kreder changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BwtFfHOONA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798071] Review Request: fedora-arm-installer - Writes binary image files to any specified block device
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=798071 --- Comment #14 from Jon Chiappetta --- Sorry for the minor update but I made a temporary folder with the current spec file so that when I reorganize my backup stuff I don't have to keep updating links. Spec: http://fossjon.fedorapeople.org/review/fedora-arm-installer.spec SRPM: http://fossjon.fedorapeople.org/packages/fedora-arm-installer/fedora-arm-installer-1.0.2-4.fc18.src.rpm RPM: http://fossjon.fedorapeople.org/packages/fedora-arm-installer/fedora-arm-installer-1.0.2-4.fc18.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=goKf6k5gWR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891190] nodejs-fstream - Advanced file system stream things
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891190
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-fstream-0.1.21-2.fc18.src.rpm
../RPMS/noarch/nodejs-fstream-0.1.21-2.fc18.noarch.rpm
nodejs-fstream.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-fstream.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-fstream.src: W: spelling-error %description -l en_US symlink -> slinky
nodejs-fstream.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-fstream.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-fstream.noarch: W: spelling-error %description -l en_US symlink ->
slinky
nodejs-fstream.noarch: W: only-non-binary-in-usr-lib
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/rimraf /usr/lib/node_modules/rimraf
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/inherits
/usr/lib/node_modules/inherits
2 packages and 0 specfiles checked; 0 errors, 11 warnings.
All are false positive. Symlinks OK, package requires (among others)
npm(graceful-fs), npm(inherits), npm(mkdirp), npm(rimraf). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
MUST: The License field in the package spec file must match the actual license.
FIX: License in spec is MIT, but LICENSE file says BSD.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/fstream-0.1.21.tgz
31ebe4997ffdf91cb6542a5067c4226ab301292e3d87c79da539c828403022ca
../SOURCES/fstream-0.1.21.tgz
$ spectool -g nodejs-fstream.spec
$ sha256sum fstream-0.1.21.tgz
31ebe4997ffdf91cb6542a5067c4226ab301292e3d87c79da539c828403022ca
fstream-0.1.21.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-fstream-0.1.21-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 19:41
/usr/lib/node_modules/fstream
-rw-r--r--1 rootroot 1120 lis 19 2011
/usr/lib/node_modules/fstream/fstream.js
drwxr-xr-x2 rootroot0 led 10 19:41
/usr/lib/node_modules/fstream/lib
-rw-r--r--1 rootroot 2210 pro 28 01:57
/usr/lib/node_modules/fstream/lib/abstract.js
-rw-r--r--1 rootroot 1652 pro 28 01:57
/usr/lib/node_modules/fstream/lib/collect.js
-rw-r--r--1 rootroot 6394 pro 28 01:57
/usr/lib/node_modules/fstream/lib/dir-reader.js
-rw-r--r--1 rootroot 4504 pro 28 01:57
/usr/lib/node_modules/fstream/lib/dir-writer.js
-rw-r--r--1 rootroot 3861 pro 28 01:57
/usr/lib/node_modules/fstream/lib/file-reader.js
-rw-r--r--1 rootroot 2396 pro 28 01:57
/usr/lib/node_modules/fstream/lib/file-writer.js
-rw-r--r--1 rootroot 632 pro 28 01:57
/usr/lib/node_modules/fstream/lib/get-type.js
-rw-r--r--1
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kRkgfm3NT4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891226
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-read-package-json-0.1.12-2.fc18.src.rpm
../RPMS/noarch/nodejs-read-package-json-0.1.12-2.fc18.noarch.rpm
nodejs-read-package-json.src: W: spelling-error Summary(en_US) npm's -> Np's
nodejs-read-package-json.src: W: summary-not-capitalized C npm's package.json
parser
nodejs-read-package-json.src: W: spelling-error %description -l en_US npm ->
pm, rpm, ppm
nodejs-read-package-json.noarch: W: spelling-error Summary(en_US) npm's -> Np's
nodejs-read-package-json.noarch: W: summary-not-capitalized C npm's
package.json parser
nodejs-read-package-json.noarch: W: spelling-error %description -l en_US npm ->
pm, rpm, ppm
nodejs-read-package-json.noarch: W: only-non-binary-in-usr-lib
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/glob
/usr/lib/node_modules/glob
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/slide
/usr/lib/node_modules/slide
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/semver
/usr/lib/node_modules/semver
nodejs-read-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/read-package-json/node_modules/lru-cache
/usr/lib/node_modules/lru-cache
2 packages and 0 specfiles checked; 0 errors, 11 warnings.
All are false positive. Symlinks OK, package requires (among others) npm(glob),
npm(slide), npm(semver), npm(lru-cache). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE: BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/read-package-json-0.1.12.tgz
c2367e09e9b7733ee10e32745091dc34b465ba31e5bf66269865edae91966f9b
../SOURCES/read-package-json-0.1.12.tgz
$ spectool -g nodejs-read-package-json.spec
Getting
http://registry.npmjs.org/read-package-json/-/read-package-json-0.1.12.tgz to
./read-package-json-0.1.12.tgz
$ sha256sum read-package-json-0.1.12.tgz
c2367e09e9b7733ee10e32745091dc34b465ba31e5bf66269865edae91966f9b
read-package-json-0.1.12.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p
../RPMS/noarch/nodejs-read-package-json-0.1.12-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 19:59
/usr/lib/node_modules/read-package-json
drwxr-xr-x2 rootroot0 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules
lrwxrwxrwx1 rootroot 26 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/glob ->
/usr/lib/node_modules/glob
lrwxrwxrwx1 rootroot 31 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/lru-cache ->
/usr/lib/node_modules/lru-cache
lrwxrwxrwx1 rootroot 28 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/semver ->
/usr/lib/node_modules/semver
lrwxrwxrwx1 rootroot 27 led 10 19:59
/usr/lib/node_modules/read-package-json/node_modules/slide ->
/usr/lib/node_
[Bug 891197] nodejs-init-package-json - A node module to get your node module started
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891197 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1XQ1awXrbs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 --- Comment #3 from T.C. Hollingsworth --- Tests are currently disabled since TAP is not yet packaged for Fedora. I'll enable them once the necessary packages are approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gQfSJxp373&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891197] nodejs-init-package-json - A node module to get your node module started
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891197
Miro Hrončok changed:
What|Removed |Added
Flags||needinfo?(tchollingsworth@g
||mail.com)
--- Comment #2 from Miro Hrončok ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-init-package-json-0.0.7-2.fc18.src.rpm
../RPMS/noarch/nodejs-init-package-json-0.0.7-2.fc18.noarch.rpm
nodejs-init-package-json.src: W: spelling-error %description -l en_US metadata
-> meta data, meta-data, metatarsi
nodejs-init-package-json.noarch: W: spelling-error %description -l en_US
metadata -> meta data, meta-data, metatarsi
nodejs-init-package-json.noarch: W: only-non-binary-in-usr-lib
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/read-package-json
/usr/lib/node_modules/read-package-json
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/read
/usr/lib/node_modules/read
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/promzard
/usr/lib/node_modules/promzard
nodejs-init-package-json.noarch: W: dangling-symlink
/usr/lib/node_modules/init-package-json/node_modules/semver
/usr/lib/node_modules/semver
2 packages and 0 specfiles checked; 0 errors, 7 warnings.
All are false positive. Symlinks OK, package requires (among others)
npm(read-package-json), npm(semver), npm(promzard), npm(read). OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in package.json: BSD. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/init-package-json-0.0.7.tgz
49bb2b928df52c81ae832afa97c7ded5e63a9cd9062109c06bd864e055e99386
../SOURCES/init-package-json-0.0.7.tgz
$ wget
https://registry.npmjs.org/init-package-json/-/init-package-json-0.0.7.tgz
--no-check-certificate
$ sha256sum init-package-json-0.0.7.tgz
49bb2b928df52c81ae832afa97c7ded5e63a9cd9062109c06bd864e055e99386
init-package-json-0.0.7.tgz
OK
FIX: The Source0 URL should use http, not https
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-init-package-json-0.0.7-2.fc18.noarch.rpm
drwxr-xr-x2 rootroot0 led 10 20:20
/usr/lib/node_modules/init-package-json
-rw-r--r--1 rootroot 4695 lis 8 00:00
/usr/lib/node_modules/init-package-json/default-input.js
-rw-r--r--1 rootroot 3048 čec 24 10:16
/usr/lib/node_modules/init-package-json/init-package-json.js
drwxr-xr-x2 rootroot0 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules
lrwxrwxrwx1 rootroot 30 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules/promzard ->
/usr/lib/node_modules/promzard
lrwxrwxrwx1 rootroot 26 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules/read ->
/usr/lib/node_modules/read
lrwxrwxrwx1 rootroot 39 led 10 20:20
/usr/lib/node_modules/init-package-json/node_modules/read-package-json ->
/usr/lib/node_modules/read-package-json
lrwxrwxrwx1 rootroot 28 led 10 20:20
/usr/lib/node_modules/init-package-json/no
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 --- Comment #4 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-read-package-json Short Description: npm's package.json parser Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fAg5Vp3iV0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891226] nodejs-read-package-json - npm's package.json parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891226 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0eMOoGGYp6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891193] nodejs-glob - A little globber
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891193 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-glob Short Description: A little globber for Node.js Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pNLqIcG1NJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
