[Bug 895921] Review Request: php-horde-Horde-Timezone - Timezone library

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895921

--- Comment #1 from Remi Collet  ---
New version

Spec URL:
https://raw.github.com/remicollet/remirepo/4c87bb22a7524ae482ddf89d1887358c522ba25a/php/horde/php-horde-Horde-Timezone/php-horde-Horde-Timezone.spec
SRPM URL:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Timezone-1.0.2-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=E56wzENoMX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874677

--- Comment #3 from Remi Collet  ---
Yes Horde_Core is not yet submitted (working on unbundling some JS libraries)

New version

Spec:
https://raw.github.com/remicollet/remirepo/df3df1c66c5ccd3b049577ede032ac40bbabcc41/php/horde/php-horde-Horde-Rpc/php-horde-Horde-Rpc.spec
Srpm:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Rpc-2.0.3-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MquQfALpPl&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 874688] Review Request: php-horde-Horde-Ldap - Horde LDAP libraries

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874688

--- Comment #1 from Remi Collet  ---
New version

Spec:
https://raw.github.com/remicollet/remirepo/3a8226fa9198aa2b54d16236c08f599598c8e037/php/horde/php-horde-Horde-Ldap/php-horde-Horde-Ldap.spec
Srpm:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Ldap-2.0.2-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3DxKbOupYo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895622

--- Comment #1 from Remi Collet  ---
New version

Spec:
https://raw.github.com/remicollet/remirepo/3a8226fa9198aa2b54d16236c08f599598c8e037/php/horde/php-horde-Horde-Mime-Viewer/php-horde-Horde-Mime-Viewer.spec
Srpm:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Mime-Viewer-2.0.3-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=dpAAbVUOik&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894570] Review Request: php-horde-Horde-Editor - Horde Editor API

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894570

--- Comment #1 from Remi Collet  ---
New version
Spec:
https://raw.github.com/remicollet/remirepo/3a8226fa9198aa2b54d16236c08f599598c8e037/php/horde/php-horde-Horde-Editor/php-horde-Horde-Editor.spec
Srpm:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Editor-2.0.2-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=CKIIyctbGg&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905742] Review Request: -

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905742

Eduardo Echeverria  changed:

   What|Removed |Added

 CC||echevemas...@gmail.com

--- Comment #1 from Eduardo Echeverria  ---
https://fedoraproject.org/wiki/Package_Review_Process#Contributor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BVuPYObqUm&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #9 from Eduardo Echeverria  ---
Wesley:

Sorry for delay, I had a busy few days

(In reply to comment #7)
> Upstream now accepts Fedora bugs.
> 
> http://wiki.go-docky.com/index.php?title=Plank:Introduction#Reporting_Bugs

Are good news !!

About versioning. 
- Current development version is 0.2.0
- rev is in this case 734 
therefore, the versioning should be: 0.2.0-0.1.20130124bzr734 
and the release number increment every time you make changes in the spec: 
e.g.
0.2.0-0.2.20130124bzr734  
0.2.0-0.3.20130124bzr734 
and so on
in the spec: 
%global bzrid 734
%global checkout 20130124bzr%{bzrid}
Name:   plank
Version:0.2.0
Release:0.1.%{checkout}%{?dist}
Source0:plank-%{version}.%{bzrid}.tar.xz

About @shared-lib-calls-exit 
this is no review blocker,  .But it is worth to inform the upstream about that.
(and fix it soon)

Let's review

rpmlint plank plank-devel plank-debuginfo
plank.x86_64: W: spelling-error Summary(en_US) docky -> dock, docks, dorky
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libgthread-2.0.so.0
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/librt.so.1
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libatk-1.0.so.0
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libcairo-gobject.so.2
plank.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libplank.so.0.0.0
/lib64/libpthread.so.0

See
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency

objdump -p libplank.so.0.0.0 | grep NEEDED
  NEEDED   libm.so.6
  NEEDED   libgthread-2.0.so.0
  NEEDED   librt.so.1 *
  NEEDED   libbamf3.so.0
  NEEDED   libwnck-3.so.0
  NEEDED   libgtk-3.so.0
  NEEDED   libgdk-3.so.0
  NEEDED   libatk-1.0.so.0 * 
  NEEDED   libgio-2.0.so.0
  NEEDED   libpangocairo-1.0.so.0
  NEEDED   libgdk_pixbuf-2.0.so.0
  NEEDED   libcairo-gobject.so.2 *
  NEEDED   libpango-1.0.so.0
  NEEDED   libcairo.so.2
  NEEDED   libgee.so.2
  NEEDED   libgobject-2.0.so.0
  NEEDED   libglib-2.0.so.0
  NEEDED   libX11.so.6
  NEEDED   libpthread.so.0 *
  NEEDED   libc.so.6

- (nonblocker) You might mention to upstream the various warnings

Drawing/DockSurface.vala:366.32-366.51: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread ()
Drawing/DockSurface.vala:375.10-375.29: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread ()
Drawing/DockSurface.vala:492.32-492.51: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread ()
Drawing/DockSurface.vala:515.10-515.29: warning: GLib.Thread.create has been
deprecated since 2.32. Use new Thread ()
Drawing/DrawingService.vala:54.49-54.77: warning:
GLib.FILE_ATTRIBUTE_THUMBNAIL_PATH has been deprecated since vala-0.16. Use
FileAttribute.THUMBNAIL_PATH
Factories/AbstractMain.vala:271.4-271.15: warning: `null' incompatible with
return type `string[]`
return null;

Items/ApplicationDockItem.vala:442.52-442.87: warning:
GLib.FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE has been deprecated since vala-0.16.
Use FileAttribute.STANDARD_CONTENT_TYPE
Items/FileDockItem.vala:294.52-294.79: warning:
GLib.FILE_ATTRIBUTE_STANDARD_NAME has been deprecated since vala-0.16. Use
FileAttribute.STANDARD_NAME
Items/FileDockItem.vala:295.8-295.40: warning:
GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN has been deprecated since vala-0.16. Use
FileAttribute.STANDARD_IS_HIDDEN
Items/FileDockItem.vala:296.8-296.37: warning:
GLib.FILE_ATTRIBUTE_ACCESS_CAN_READ has been deprecated since vala-0.16. Use
FileAttribute.ACCESS_CAN_READ
DockItems.vala:388.42-388.69: warning: GLib.FILE_ATTRIBUTE_STANDARD_NAME has
been deprecated since vala-0.16. Use FileAttribute.STANDARD_NAME
DockItems.vala:388.79-388.111: warning: GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN
has been deprecated since vala-0.16. Use FileAttribute.STANDARD_IS_HIDDEN
DockItems.vala:224.77-224.104: warning: GLib.FILE_ATTRIBUTE_STANDARD_NAME has
been deprecated since vala-0.16. Use FileAttribute.STANDARD_NAME
DockItems.vala:224.114-224.146: warning: GLib.FILE_ATTRIBUTE_STANDARD_IS_HIDDEN
has been deprecated since vala-0.16. Use FileAttribute.STANDARD_IS_HIDDEN
Services/WindowControl.vala:124.3-124.41: warning: method
`Plank.Services.Windows.WindowControl.has_minimized_window' never used
public static bool has_minimized_window (Bamf.Application app)
^^^
Services/WindowControl.vala:166.3-166.50: warning: method
`Plank.Services.Windows.WindowControl.get_windows' never used
public static ArrayList get_windows (Bamf.Application app)
^^^

[Bug 894482] Review Request: rubygem-openshift-origin-auth-kerberos - OpenShift plugin for kerberos auth service

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894482

Bohuslav "Slavek" Kabrda  changed:

   What|Removed |Added

 CC||bkab...@redhat.com

--- Comment #10 from Bohuslav "Slavek" Kabrda  ---
Hey Troy,
the specfile really seems to be strange, to say the least.
Comments for the first condition that Vit has mentioned:
- %scl shouldn't actually be defined in the specfile, it should be left to
ruby193-build to be present in minimal buildroot.
- Defining %scl_prefix is wrong. If ruby193-build is in minimal buildroot, it
will draw in scl-utils-build and %scl_prefix will be defined. You really
shouldn't hack these things like that.
The another condition:
- Please don't do that. Again, that is supposed to be solved by those packages
being/not being present in the minimal buildroot. The general idea of SCLs is
that you can build the same SRPM and get SCL or non-SCL RPMs, based on the
buildroot you use. By hardcoding the rhel conditionals, you break this.

Some more comments:
- %{?scl:%scl_prefix} in Requires and BuildRequires can be shortened to
%{?scl_prefix}
- The two Requires without %{?scl:%scl_prefix} seem to be suspicious. I'd say
that if you build this for ruby193 SCL, this gem won't be able to use them, as
they won't be in GEM_PATH (because they're not SCL).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=WmHZpiiDuK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905742] New: Review Request: -

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905742

Bug ID: 905742
   Summary: Review Request:  - 
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: unspecified
  Reporter: brianhur...@yahoo.com

Spec URL:

SRPM URL: 
Description: 
Fedora Account System Username: brianhurren

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MKBLeb4h1C&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 877694] Review Request: hidapi - Library for communicating with USB and Bluetooth HID devices

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877694

Ian Weller  changed:

   What|Removed |Added

 CC||i...@ianweller.org
  Flags||needinfo?(ozan.caglayan@gma
   ||il.com)

--- Comment #2 from Ian Weller  ---
Hi Ozan,

Are you still interested in packaging hidapi? I need this for another package
I'm working on getting into Fedora.

If not, let me know and I'll work on this.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9MRS9Dbhwl&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847160] Review Request: eclipse-m2e-core - Maven integration for Eclipse

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=847160

--- Comment #30 from Fedora Update System  ---
eclipse-m2e-core-1.2.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/eclipse-m2e-core-1.2.0-4.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mYCkg4RcQj&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 901365] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901365

--- Comment #10 from Yohan Graterol  ---
thanks for the review

New Package SCM Request
===
Package Name: python-mongoengine
Short Description: A Python Document-Object Mapper for working with MongoDB
Owners: yograterol echevemaster
Branches: f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=I5a4UT5scu&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 901365] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901365

Yohan Graterol  changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ABkUHrAYjU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891171] Review Request: npm - Node.js package manager

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891171

--- Comment #18 from Fedora Update System  ---
nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18,
nodejs-async-0.1.22-3.fc18, nodejs-glob-3.1.14-2.fc18,
nodejs-inherits-1.0.0-6.fc18, nodejs-graceful-fs-1.1.14-2.fc18,
nodejs-minimatch-0.2.9-2.fc18, nodejs-mkdirp-0.3.4-2.fc18,
nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18,
nodejs-read-installed-0.0.4-2.fc18, nodejs-read-package-json-0.1.12-2.fc18,
nodejs-retry-0.6.0-2.fc18, nodejs-rimraf-2.1.1-2.fc18,
nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18,
nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18,
nodejs-nopt-2.0.0-3.fc18, nodejs-lru-cache-2.2.1-2.fc18,
nodejs-mime-1.2.7-2.fc18, nodejs-init-package-json-0.0.7-3.fc18,
nodejs-fstream-0.1.21-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18,
nodejs-proto-list-1.2.2-2.fc18, nodejs-npm-registry-client-0.2.11-2.fc18,
nodejs-form-data-0.0.6-2.fc18, nodejs-which-1.0.5-4.fc18,
nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18,
nodejs-yamlish-0.0.5-1.fc18, nodejs-once-1.1.1-2.fc18,
nodejs-lockfile-0.2.1-2.fc18, nodejs-ini-1.0.5-2.fc18,
nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18,
nodejs-block-stream-0.0.6-4.fc18, nodejs-config-chain-1.1.3-3.fc18,
nodejs-fstream-npm-0.1.3-2.fc18, nodejs-npmconf-0.0.16-3.fc18,
nodejs-npmlog-0.0.2-2.fc18, nodejs-charm-0.1.0-1.fc18, node-gyp-0.8.2-3.fc18,
nodejs-tar-0.1.14-3.fc18, npm-1.2.1-2.fc18, nodejs-opener-1.3.0-4.fc18,
nodejs-semver-1.1.2-1.fc18, nodejs-tobi-cookie-0.3.2-2.fc18,
nodejs-fstream-ignore-0.0.5-4.fc18 has been pushed to the Fedora 18 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vhzMJTZRNp&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891171] Review Request: npm - Node.js package manager

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891171

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=09CAGmoHio&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891175] node-gyp - Node.js native addon build tool

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891175

--- Comment #14 from Fedora Update System  ---
nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18,
nodejs-async-0.1.22-3.fc18, nodejs-glob-3.1.14-2.fc18,
nodejs-inherits-1.0.0-6.fc18, nodejs-graceful-fs-1.1.14-2.fc18,
nodejs-minimatch-0.2.9-2.fc18, nodejs-mkdirp-0.3.4-2.fc18,
nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18,
nodejs-read-installed-0.0.4-2.fc18, nodejs-read-package-json-0.1.12-2.fc18,
nodejs-retry-0.6.0-2.fc18, nodejs-rimraf-2.1.1-2.fc18,
nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18,
nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18,
nodejs-nopt-2.0.0-3.fc18, nodejs-lru-cache-2.2.1-2.fc18,
nodejs-mime-1.2.7-2.fc18, nodejs-init-package-json-0.0.7-3.fc18,
nodejs-fstream-0.1.21-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18,
nodejs-proto-list-1.2.2-2.fc18, nodejs-npm-registry-client-0.2.11-2.fc18,
nodejs-form-data-0.0.6-2.fc18, nodejs-which-1.0.5-4.fc18,
nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18,
nodejs-yamlish-0.0.5-1.fc18, nodejs-once-1.1.1-2.fc18,
nodejs-lockfile-0.2.1-2.fc18, nodejs-ini-1.0.5-2.fc18,
nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18,
nodejs-block-stream-0.0.6-4.fc18, nodejs-config-chain-1.1.3-3.fc18,
nodejs-fstream-npm-0.1.3-2.fc18, nodejs-npmconf-0.0.16-3.fc18,
nodejs-npmlog-0.0.2-2.fc18, nodejs-charm-0.1.0-1.fc18, node-gyp-0.8.2-3.fc18,
nodejs-tar-0.1.14-3.fc18, npm-1.2.1-2.fc18, nodejs-opener-1.3.0-4.fc18,
nodejs-semver-1.1.2-1.fc18, nodejs-tobi-cookie-0.3.2-2.fc18,
nodejs-fstream-ignore-0.0.5-4.fc18 has been pushed to the Fedora 18 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bGE60P5wlk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891175] node-gyp - Node.js native addon build tool

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891175

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9kapULz7Im&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891189] nodejs-form-data - A module to create readable "multipart/form-data" streams

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891189

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HKDJO1hQIo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891189] nodejs-form-data - A module to create readable "multipart/form-data" streams

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891189

--- Comment #6 from Fedora Update System  ---
nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18,
nodejs-async-0.1.22-3.fc18, nodejs-glob-3.1.14-2.fc18,
nodejs-inherits-1.0.0-6.fc18, nodejs-graceful-fs-1.1.14-2.fc18,
nodejs-minimatch-0.2.9-2.fc18, nodejs-mkdirp-0.3.4-2.fc18,
nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18,
nodejs-read-installed-0.0.4-2.fc18, nodejs-read-package-json-0.1.12-2.fc18,
nodejs-retry-0.6.0-2.fc18, nodejs-rimraf-2.1.1-2.fc18,
nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18,
nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18,
nodejs-nopt-2.0.0-3.fc18, nodejs-lru-cache-2.2.1-2.fc18,
nodejs-mime-1.2.7-2.fc18, nodejs-init-package-json-0.0.7-3.fc18,
nodejs-fstream-0.1.21-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18,
nodejs-proto-list-1.2.2-2.fc18, nodejs-npm-registry-client-0.2.11-2.fc18,
nodejs-form-data-0.0.6-2.fc18, nodejs-which-1.0.5-4.fc18,
nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18,
nodejs-yamlish-0.0.5-1.fc18, nodejs-once-1.1.1-2.fc18,
nodejs-lockfile-0.2.1-2.fc18, nodejs-ini-1.0.5-2.fc18,
nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18,
nodejs-block-stream-0.0.6-4.fc18, nodejs-config-chain-1.1.3-3.fc18,
nodejs-fstream-npm-0.1.3-2.fc18, nodejs-npmconf-0.0.16-3.fc18,
nodejs-npmlog-0.0.2-2.fc18, nodejs-charm-0.1.0-1.fc18, node-gyp-0.8.2-3.fc18,
nodejs-tar-0.1.14-3.fc18, npm-1.2.1-2.fc18, nodejs-opener-1.3.0-4.fc18,
nodejs-semver-1.1.2-1.fc18, nodejs-tobi-cookie-0.3.2-2.fc18,
nodejs-fstream-ignore-0.0.5-4.fc18 has been pushed to the Fedora 18 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=X3uzwvuVy4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891215] nodejs-npm-registry-client - Client for the npm registry

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891215

--- Comment #7 from Fedora Update System  ---
nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18,
nodejs-async-0.1.22-3.fc18, nodejs-glob-3.1.14-2.fc18,
nodejs-inherits-1.0.0-6.fc18, nodejs-graceful-fs-1.1.14-2.fc18,
nodejs-minimatch-0.2.9-2.fc18, nodejs-mkdirp-0.3.4-2.fc18,
nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18,
nodejs-read-installed-0.0.4-2.fc18, nodejs-read-package-json-0.1.12-2.fc18,
nodejs-retry-0.6.0-2.fc18, nodejs-rimraf-2.1.1-2.fc18,
nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18,
nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18,
nodejs-nopt-2.0.0-3.fc18, nodejs-lru-cache-2.2.1-2.fc18,
nodejs-mime-1.2.7-2.fc18, nodejs-init-package-json-0.0.7-3.fc18,
nodejs-fstream-0.1.21-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18,
nodejs-proto-list-1.2.2-2.fc18, nodejs-npm-registry-client-0.2.11-2.fc18,
nodejs-form-data-0.0.6-2.fc18, nodejs-which-1.0.5-4.fc18,
nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18,
nodejs-yamlish-0.0.5-1.fc18, nodejs-once-1.1.1-2.fc18,
nodejs-lockfile-0.2.1-2.fc18, nodejs-ini-1.0.5-2.fc18,
nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18,
nodejs-block-stream-0.0.6-4.fc18, nodejs-config-chain-1.1.3-3.fc18,
nodejs-fstream-npm-0.1.3-2.fc18, nodejs-npmconf-0.0.16-3.fc18,
nodejs-npmlog-0.0.2-2.fc18, nodejs-charm-0.1.0-1.fc18, node-gyp-0.8.2-3.fc18,
nodejs-tar-0.1.14-3.fc18, npm-1.2.1-2.fc18, nodejs-opener-1.3.0-4.fc18,
nodejs-semver-1.1.2-1.fc18, nodejs-tobi-cookie-0.3.2-2.fc18,
nodejs-fstream-ignore-0.0.5-4.fc18 has been pushed to the Fedora 18 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pOgydn0kAa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891215] nodejs-npm-registry-client - Client for the npm registry

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891215

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NWcizUtfpu&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891186] nodejs-couch-login - A module for doing logged-in requests to a couchdb server

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891186

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Vi8aHhWVV0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891186] nodejs-couch-login - A module for doing logged-in requests to a couchdb server

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891186

--- Comment #9 from Fedora Update System  ---
nodejs-abbrev-1.0.4-2.fc18, nodejs-ansi-0.1.2-4.fc18,
nodejs-async-0.1.22-3.fc18, nodejs-glob-3.1.14-2.fc18,
nodejs-inherits-1.0.0-6.fc18, nodejs-graceful-fs-1.1.14-2.fc18,
nodejs-minimatch-0.2.9-2.fc18, nodejs-mkdirp-0.3.4-2.fc18,
nodejs-mute-stream-0.0.3-3.fc18, nodejs-read-1.0.4-4.fc18,
nodejs-read-installed-0.0.4-2.fc18, nodejs-read-package-json-0.1.12-2.fc18,
nodejs-retry-0.6.0-2.fc18, nodejs-rimraf-2.1.1-2.fc18,
nodejs-slide-1.1.3-4.fc18, nodejs-uid-number-0.0.3-4.fc18,
nodejs-sigmund-1.0.0-2.fc18, nodejs-osenv-0.0.3-2.fc18,
nodejs-nopt-2.0.0-3.fc18, nodejs-lru-cache-2.2.1-2.fc18,
nodejs-mime-1.2.7-2.fc18, nodejs-init-package-json-0.0.7-3.fc18,
nodejs-fstream-0.1.21-3.fc18, nodejs-delayed-stream-0.0.5-2.fc18,
nodejs-proto-list-1.2.2-2.fc18, nodejs-npm-registry-client-0.2.11-2.fc18,
nodejs-form-data-0.0.6-2.fc18, nodejs-which-1.0.5-4.fc18,
nodejs-chownr-0.0.1-6.fc18, nodejs-opts-1.2.2-2.fc18,
nodejs-yamlish-0.0.5-1.fc18, nodejs-once-1.1.1-2.fc18,
nodejs-lockfile-0.2.1-2.fc18, nodejs-ini-1.0.5-2.fc18,
nodejs-couch-login-0.1.15-2.fc18, nodejs-archy-0.0.2-5.fc18,
nodejs-block-stream-0.0.6-4.fc18, nodejs-config-chain-1.1.3-3.fc18,
nodejs-fstream-npm-0.1.3-2.fc18, nodejs-npmconf-0.0.16-3.fc18,
nodejs-npmlog-0.0.2-2.fc18, nodejs-charm-0.1.0-1.fc18, node-gyp-0.8.2-3.fc18,
nodejs-tar-0.1.14-3.fc18, npm-1.2.1-2.fc18, nodejs-opener-1.3.0-4.fc18,
nodejs-semver-1.1.2-1.fc18, nodejs-tobi-cookie-0.3.2-2.fc18,
nodejs-fstream-ignore-0.0.5-4.fc18 has been pushed to the Fedora 18 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TXj430Nt7k&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858058] Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858058

--- Comment #9 from Fedora Update System  ---
mingw-qt5-qtbase-5.0.0-3.fc18, mingw-angleproject-0-0.3.svn1561.20121214.fc18
has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=yJJpo2XXh7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858058] Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858058

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hZ4ImsGPmS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904841] Review Request: ino - Command line toolkit for working with Arduino hardware

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904841

Miro Hrončok  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #8 from Miro Hrončok  ---
New Package SCM Request
===
Package Name: ino
Short Description: Command line toolkit for working with Arduino hardware
Owners: churchyard patches
Branches: f17 f18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XMHrV2aLnE&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 889167] Review Request: netatalk-3.0.1

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=889167

Bob Gustafson  changed:

   What|Removed |Added

 CC||bob...@rcn.com

--- Comment #5 from Bob Gustafson  ---
I just built netatalk 3.0.2 from the SRPM.

It builds and installs and seems to run (not configured correctly yet by me).

The netatalk.service file is not copied to the /etc/systemd/system directory.

Also, the /etc/netatalk directory is not created or populated with sample
files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ljKGlkzLcw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905681] Review Request: ultimaker-marlin-firmware - Ultimaker firmware for the 3D printer

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905681

Miro Hrončok  changed:

   What|Removed |Added

 CC||tchollingswo...@gmail.com
 Depends On||904841, 891556

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wAuQ9NIdIS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905681] Review Request: ultimaker-marlin-firmware - Ultimaker firmware for the 3D printer

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905681

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||901659

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XJSlTHepKx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904841] Review Request: ino - Command line toolkit for working with Arduino hardware

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904841

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||905681

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nZ1eITcXSU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904841] Review Request: ino - Command line toolkit for working with Arduino hardware

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904841

T.C. Hollingsworth  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #7 from T.C. Hollingsworth  ---
This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EpdiTPjXkX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905681] New: Review Request: ultimaker-marlin-firmware - Ultimaker firmware for the 3D printer

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905681

Bug ID: 905681
   Summary: Review Request: ultimaker-marlin-firmware - Ultimaker
firmware for the 3D printer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: mhron...@redhat.com

Spec URL:
https://github.com/hroncok/SPECS/raw/master/ultimaker-marlin-firmware.spec
SRPM URL:
https://github.com/downloads/hroncok/SPECS/ultimaker-marlin-firmware-12.12-0.2.RC1.fc18.src.rpm
Description: Ultimaker firmware for the 3D printer
Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IuC7HKzbdZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904841] Review Request: ino - Command line toolkit for working with Arduino hardware

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904841

Miro Hrončok  changed:

   What|Removed |Added

  Flags|needinfo?(mhroncok@redhat.c |
   |om) |

--- Comment #6 from Miro Hrončok  ---
Spec URL: https://raw.github.com/hroncok/SPECS/master/ino.spec
SRPM URL: https://github.com/downloads/hroncok/SPECS/ino-0.3.5-1.fc18.src.rpm

- New version with license file
- Removed empty hidden files
- Require arduino -> arduino-core

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=iGxAlDX3UV&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893866

William Cohen  changed:

   What|Removed |Added

 CC||wco...@redhat.com

--- Comment #7 from William Cohen  ---
The package plays with CFLAGS. It would be nice if that it just used the Fedora
supplied CFLAGS.  In the rpmlint results see that it isn't using the '-g' and
there isn't any debuginfo information to strip out:

vboot-utils-debuginfo.armv7hl: E: debuginfo-without-sources

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3JgMRrgexU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893866

--- Comment #6 from William Cohen  ---
Created attachment 690051
  --> https://bugzilla.redhat.com/attachment.cgi?id=690051&action=edit
Remove a couple minor rpmlint warnings

This patch fixes a couple a warning about mixing spaces and tabs and the
incoherent changelog entry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tbkTynzaby&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904798] Review Request: sfact - Converts 3D model into G-Code for RepRap

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904798

--- Comment #7 from Miro Hrončok  ---
I have read the e-mail about this when it was posted, but I've forgot it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VDeuwZQtYI&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904798] Review Request: sfact - Converts 3D model into G-Code for RepRap

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904798

Miro Hrončok  changed:

   What|Removed |Added

  Flags|needinfo?(mhroncok@redhat.c |
   |om) |

--- Comment #6 from Miro Hrončok  ---
Spec URL: https://raw.github.com/hroncok/SPECS/master/sfact.spec
SRPM URL:
https://github.com/downloads/hroncok/SPECS/sfact-0.0-2.20130128gitbc56c68.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5Dzu7GlcAX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 859246] Review Request: cmap - Adobe pdf character mapping data

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=859246

--- Comment #2 from Ben Rosser  ---
I've removed the redundancies and other inconsistencies. I also changed the
version and release tags to reflect the date I originally checked the package
out; I'm not entirely sure I've done this properly... is it supposed to be:

Version: 0
Release: 1.%{snapshot}%{?dist}

Where %{snapshot} is the snapshot date (and 1 is the release number)?

Anyway, here's the updated spec and RPM:

Spec File: http://venus.arosser.com/fedora/cmap/cmap.spec
Source RPM:
http://venus.arosser.com/fedora/cmap/cmap-0-1.20120920snap.fc18.src.rpm

The texlive package seems to use the "ac16", etc. subdirectories, so it
probably wouldn't be too drastic a change to pull in this package.

I'll email both the texlive and poppler maintainers about how to integrate this
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HuuCh8LHtB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

--- Comment #8 from Robert Dyer  ---
The upstream installation instructions no longer reference GTK2.

http://wiki.go-docky.com/index.php?title=Plank:Installing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XJBu3kBvJZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 896193] Review Request: plank - A port of docky to Vala

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896193

Robert Dyer  changed:

   What|Removed |Added

 CC||psyb...@gmail.com

--- Comment #7 from Robert Dyer  ---
Upstream now accepts Fedora bugs.

http://wiki.go-docky.com/index.php?title=Plank:Introduction#Reporting_Bugs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=e2sEvBg24A&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893866

--- Comment #5 from Jon Disnard  ---
I have updated the spec file and source RPM for your evaluation:

SPEC FILE:
http://dl.dropbox.com/u/41369/fedora/SPECS/vboot-utils.spec


SOURCE RPM:
http://dl.dropbox.com/u/41369/fedora/SRPMS/vboot-utils-20130129git68f54d4-1.fc18.src.rpm


Please let me know if the SPEC file can improve.

Thanks in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Rl9tG4L9Ox&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905389] Review Request: rubygem-json15 - JSON implementation in Ruby (version 1.5.x)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905389

--- Comment #2 from Ingvar Hagelund  ---
Vít,

I have no other use for this package than as a requisite for vagrant, #905396.

Next upstream release of vagrant will have fixed this. Current git master can
use the json gem that is in f18.

So, should I just wait for upstream?

Ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3mJw9sahmw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886552] Review Request: python-stevedore - Manage dynamic plugins for Python applications

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886552

--- Comment #18 from Fedora Update System  ---
python-stevedore-0.8-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=uUlFfCW5AQ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894100

--- Comment #15 from Fedora Update System  ---
php-pear-File-Fstab-2.0.3-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=iRuuV08z37&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894100] Review Request: php-pear-File-Fstab - Read and write fstab files

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894100

--- Comment #14 from Fedora Update System  ---
php-pear-File-Fstab-2.0.3-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5Ska0IfQBR&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 855605] Review Request: hexchat - GTK IRC Client

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=855605

--- Comment #34 from Fedora Update System  ---
hexchat-2.9.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jhwmXwzl8a&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891215] nodejs-npm-registry-client - Client for the npm registry

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891215

Bug 891215 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0j9bxZWMFq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891186] nodejs-couch-login - A module for doing logged-in requests to a couchdb server

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891186

Bug 891186 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MMMNcEQiXt&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891215] nodejs-npm-registry-client - Client for the npm registry

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891215

Bug 891215 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=uaiuiI4WMs&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891175] node-gyp - Node.js native addon build tool

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891175

Bug 891175 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=N4RqkpvTSy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891229] nodejs-request - Simplified HTTP request client

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891229

T.C. Hollingsworth  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |---
   Keywords||Reopened

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AqHVQLVVYm&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891171] Review Request: npm - Node.js package manager

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891171

Bug 891171 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lt189seiWI&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891175] node-gyp - Node.js native addon build tool

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891175

Bug 891175 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=w3237orJLb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891186] nodejs-couch-login - A module for doing logged-in requests to a couchdb server

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891186

Bug 891186 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hrOBXcTOe6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891229] nodejs-request - Simplified HTTP request client

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891229

T.C. Hollingsworth  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-01-29 14:45:44

--- Comment #25 from T.C. Hollingsworth  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=4912716

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=u1cxSoFRJU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891171] Review Request: npm - Node.js package manager

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891171

Bug 891171 depends on bug 891229, which changed state.

Bug 891229 Summary: nodejs-request - Simplified HTTP request client
https://bugzilla.redhat.com/show_bug.cgi?id=891229

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ko039ufkuw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891996] Review Request: lua-ldoc - Lua documentation generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891996

--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bJ7tL3P5He&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891996] Review Request: lua-ldoc - Lua documentation generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891996

Thomas Moschny  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #4 from Thomas Moschny  ---
Thanks for the review!

New Package SCM Request
===
Package Name: lua-ldoc
Short Description: Lua documentation generator
Owners: thm
Branches: f16 f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=w6uiMDffQP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904798] Review Request: sfact - Converts 3D model into G-Code for RepRap

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904798

T.C. Hollingsworth  changed:

   What|Removed |Added

  Flags||needinfo?(mhroncok@redhat.c
   ||om)

--- Comment #5 from T.C. Hollingsworth  ---
Okay, the difference here is that fedora-review mockbuilds in rawhide, and
rawhide has some changes in %doc handling.

See:
http://article.gmane.org/gmane.linux.redhat.fedora.devel/173464
http://rpm.org/ticket/858

Please use one of the described solutions to ensure your package builds on both
Rawhide and whichever Fedora releases you want to support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nmBz80Ifvh&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905615] New: Review Request: gammaray - A tool for examining internals of Qt applications

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905615

Bug ID: 905615
   Summary: Review Request: gammaray - A tool for examining
internals of Qt applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: dvra...@redhat.com

Spec URL: http://people.fedoraproject.org/~dvratil/spec/gammaray.spec
SRPM URL:
http://people.fedoraproject.org/~dvratil/spec/gammaray-1.3.0-1.fc18.src.rpm
(226M)
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4912393

Description: A tool to poke around in a Qt-application and also to manipulate
the application to some extent. It uses various DLL injection
techniques to hook into an application at run-time and provide
access to a lot of interesting information.

Fedora Account System Username: dvratil


The package needs Qt sources in order to have access to some private headers
and sources that are not available in qt-devel and qt-devel-private

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jqG6tiHuzK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 857724] Review Request: php53-simplepie.spec - Simple RSS Library in PHP

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=857724

--- Comment #17 from Patrick C. F. Ernzer  ---
(In reply to comment #16)
> You have to wait for php-IDNA_Convert-0.8.0-1.el5 or pull it from
> epel-testing.

Thanks. With php-IDNA_Convert-0.8.0-1.el5 I was able to install
php53-simplepie-1.3.1-5.el5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=h6rhvc3ux5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

--- Comment #8 from Fedora Update System  ---
crrcsim-0.9.12-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/crrcsim-0.9.12-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rElai7a029&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

--- Comment #9 from Fedora Update System  ---
crrcsim-0.9.12-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/crrcsim-0.9.12-2.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=J1crcKpTDW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HVnYLFPorX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 892335] Review Request: AudioCuesheetEditor (v0.2.1)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892335

--- Comment #20 from Sven Baus  ---
(In reply to comment #19)
Ok, I have been able to do some more optimization as you offered. Thank you.
Only 2 more thing are open:


> > %{_libdir}/%{name}/*
> 
> * Are you aware of the Mono Packaging Guidelines?
> 
>https://fedoraproject.org/wiki/Packaging:Guidelines
>-> https://fedoraproject.org/wiki/Packaging:Mono

What exactly do you mean? AudioCuesheetEditor binaries and stuff will be stored
under %{_libdir}/%{name}/*, so why not use wildcards? Or what is the major
problem here?


> > There is also this warning: 
> 
>   AudioCuesheetEditor.src: W: strange-permission AudioCuesheetEditor.spec
> 0777L
> 
> $ rpmls -p AudioCuesheetEditor-0.2.1-1.fc17.src.rpm
> -rw-rw-r--  AudioCuesheetEditor-src-v0.2.1.tar.gz
> -rwxrwxrwx  AudioCuesheetEditor.spec

Sorry, that was because of my build. I build under a different user, will be
removed, if the package can go on ;).

Thanks for helping me.

Greetings
Sven

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1ZxlWS6alT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MZSbXyGWvP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

Damian Wrobel  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #6 from Damian Wrobel  ---
New Package SCM Request
===
Package Name: crrcsim
Short Description: Model-Airplane Flight Simulation Program
Owners: dwrobel
Branches: f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=POw6MF5Ebw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894482] Review Request: rubygem-openshift-origin-auth-kerberos - OpenShift plugin for kerberos auth service

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894482

--- Comment #9 from Troy Dawson  ---
Hi Vit,

How is the SCL intended to work?

This is how the upstream vendor (OpenShift) got it to work for them.  As far as
I know, OpenShift is the only project activily using SCL.  But if there is
another active project successfully using SCL, please point me to them and I
can work with OpenShift so they implement SCL in the approved manner.

I would like to keep out spec as close as possible with the upstream vendor. 
If I were to remove all the scl stuff, it would affect much more than the two
sections that you pointed out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Fn2vT739yF&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903829] Review Request: perl-Time-Interval - Convert seconds to human readable form

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903829

--- Comment #7 from Petr Šabata  ---
Seems okay now (just the perl macro on the MODULE_COMPAT line...).

(In reply to comment #5)
>  * Sent query to Time-Interval maintainer. Interestingly, someone has asked
> this same question to him few years ago, although he looks active other Perl
> package maintainer, Time-Interval license still is not updated :) 

I see
https://rt.cpan.org/Public/Bug/Display.html?id=43024

I can't approve the review until the licensing issue is cleared up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0jzyfkoJlG&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894482] Review Request: rubygem-openshift-origin-auth-kerberos - OpenShift plugin for kerberos auth service

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894482

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com

--- Comment #8 from Vít Ondruch  ---
Hi Troy,

Not sure what was your intention, but the firs four lines:

%if 0%{?fedora}%{?rhel} <= 6
%global scl ruby193
%global scl_prefix ruby193-
%endif

they should not be in the spec in Fedora, EPEL nor for RHEL. Please remove them
from the spec file. This is not how SCL was intended to work and moreover, it
is against fedora's and EPEL's guidelines.

Actually the same applies for the following lines:

%if 0%{?fedora}%{?rhel} <= 6
BuildRequires:  ruby193-build
BuildRequires:  scl-utils-build
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0BfGp7OvcJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #6 from Petr Šabata  ---
I see you also added the Data::Dumper dependency.  Its only used in the dump()
subroutine which is not called from the tests at all.  You may drop this again
:)

And again, that %{__perl} macro in MODULE_COMPAT...

Not approving yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Bp0IPsZK4X&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905389] Review Request: rubygem-json15 - JSON implementation in Ruby (version 1.5.x)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905389

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com

--- Comment #1 from Vít Ondruch  ---
I am wondering if there is any reason to not move to the latest json, except
that something is written in vagrant's .gemspec file? Have you tried to ask
upstream and possibly solve this issue?

Also, if this is intended to be dependency of vagrant, it might be useful to
make this issue block the vagrant review.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=KrmK7aLCKv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 887611] Review Request: vdr-vnsiserver - VDR plugin to handle XBMC clients via VNSI

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887611

--- Comment #19 from Mohamed El Morabity  ---
> (In reply to comment #17)
> > - is there any reason you base your plugin on a git commit? Using the latest
> > tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC,
> > with no particular issue.
> 
> You are right, I will change this. At the time I first wrote the SPEC file,
> there was no tag at all. This is why I choose the git commit to get a stable
> base. However, there is indeed a problem with RC3 (see
> https://github.com/opdenkamp/xbmc-pvr-addons/issues/160 for the description
> and solution). However, I would like to follow the "official" plugin instead
> of any feature clones of others. So I stay with RC3 until Frodo 12 and the
> addon come out officially.
The issue you reported with HDTV is probably a good reason to use a snapshot
version of the plugin instead of the last stable tag, unless a backport is
possible and not too complicated.
I'd like to reproduce this issue, I realize I haven't tested yet HDTV on DVB-T.
I'll try tonight...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=FkiPzPgctj&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904328

Petr Šabata  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #5 from Petr Šabata  ---
Removing FE-NEEDSPONSOR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=D4MI2vZakE&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903829] Review Request: perl-Time-Interval - Convert seconds to human readable form

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903829

Petr Šabata  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #6 from Petr Šabata  ---
Removing FE-NEEDSPONSOR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=asXo8DJp0d&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904329] Review Request: perl-Data-Validate-Domain - Domain validation methods

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904329

Petr Šabata  changed:

   What|Removed |Added

 CC||psab...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #2 from Petr Šabata  ---
Removing FE-NEEDSPONSOR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=dlDtq2losb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904330] Review Request: perl-Data-Validate-IP - Ipv4 and ipv6 validation methods

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904330

Petr Šabata  changed:

   What|Removed |Added

 CC||psab...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #2 from Petr Šabata  ---
Removing FE-NEEDSPONSOR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=RNOQXLCeX7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904331] Review Request: perl-Shell - Run shell commands transparently within perl

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904331

Petr Šabata  changed:

   What|Removed |Added

 CC||psab...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #2 from Petr Šabata  ---
Removing FE-NEEDSPONSOR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=P4dB0jRPHd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903826] Review Request: perl-Net-Domain-TLD - Work with TLD names

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903826

Petr Šabata  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #7 from Petr Šabata  ---
Sponsored.  Approving.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sBGHhy8zJ1&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903824

Petr Šabata  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #10 from Petr Šabata  ---
Sure, just update the reviews you've submitted.

By the way, I've just sponsored you into the packager group.
Now you can submit the SCM request for your approved packages:
http://fedoraproject.org/wiki/Package_SCM_admin_requests

Please, mention me (psabata) as one of the owners and put "perl-sig" in the
InitialCC field too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0kBXnUIZwJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903826] Review Request: perl-Net-Domain-TLD - Work with TLD names

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903826

--- Comment #6 from Petr Šabata  ---
You could also drop the %{__perl} macro on the MODULE_COMPAT line.
Anyway, the package looks good and I'll approve it once you get sponsored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Qw7iw8GTJs&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

Miroslav Lichvar  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #5 from Miroslav Lichvar  ---
Looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=njQuAoBSPq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #9 from Normunds  ---
Thanks a lot for your comments. Is it OK if I re-check spec files and re-create
packages after I have time to digest your comment about Requires and
BuildRequires? Or I should notify you for another review cycle?

Thanks and best regards.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DWtDd57PSP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524

--- Comment #4 from Damian Wrobel  ---
Dependency and noarch for -doc added:

Spec URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/crrcsim.spec
SRPM URL:
http://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/crrcsim-0.9.12-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=UBdRGWS9qn&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #8 from Petr Šabata  ---
About the new package -- I see you also added the pragmas deps.  That's
alright.  You can also remove the perl macro on the MODULE_COMPAT line, by the
way.

Anyhow, the package looks good now and I'll approve it once I sponsor you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=L8xQbLpGE5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 887611] Review Request: vdr-vnsiserver - VDR plugin to handle XBMC clients via VNSI

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887611

--- Comment #18 from Till Bubeck  ---
Mohamed,

Thanks for reviewing the package. I will post an updated version soon.

(In reply to comment #17)
> - is there any reason you base your plugin on a git commit? Using the latest
> tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC,
> with no particular issue.

You are right, I will change this. At the time I first wrote the SPEC file,
there was no tag at all. This is why I choose the git commit to get a stable
base. However, there is indeed a problem with RC3 (see
https://github.com/opdenkamp/xbmc-pvr-addons/issues/160 for the description and
solution). However, I would like to follow the "official" plugin instead of any
feature clones of others. So I stay with RC3 until Frodo 12 and the addon come
out officially.

> - vdr-devel provides many useful RPM macros (see /etc/rpm/macros.vdr) you
> should use instead of those you set on your .spec file:

Thanks for that. I will use it.

> - Is there a reason you add extra flags to %{optflags}? I can understand
> -fPIC is needed, but what about all the others?

I will check the others and enter the reasone into the SPEC file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cI9PCNlb4P&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903824] Review Request: perl-Convert-Age - converts integer seconds into a compact form and back

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903824

--- Comment #7 from Petr Šabata  ---
(In reply to comment #6)
> Could you help me to fully understand how Requires and BuildRequires are
> used in Fedora?
> 
> 1) If I enter put requirement in Requires, it will be automatically used
> also as BuildRequire. Do I understand this correctly?

No, those two are unrelated.

> 2) In bug 904328 you mentioned that Some requirements are not needed in
> Requires field because rpmbuild automatically detects those requirements.
> How can I detect what rpmbuild detects?

The easiest and most reliable way is to build the package and check the
resulting binary (not SRPM) for dependencies, e.g.

rpm -q --requires -p your-package-1.2-3.fc19.noarch.rpm

Currently, in case of perl packages, rpmbuild parses the packaged modules and
tries to guess the perl() style dependencies.  It works rather well for most
cases and therefore you don't need to manually specify them in your spec file
(usually).

> 3) In bug 903826 you asked me to add build time dependency perl(base),
> perl(constant) which actually is Perl pragma not module. When should I add
> Perl pragmas like perl(warnings) and perl(strict) to Requires, when
> shouldn't?

Surprise, they're modules! :)

https://metacpan.org/module/base
https://metacpan.org/module/constant

And requiring true pragmas wouldn't hurt (rpmbuild actually does that too)
either since they are listed among the 'perl' package provides --

$ rpm -q --provides perl|grep -E '^perl\((strict|warnings)\)'
perl(strict) = 1.07
perl(warnings) = 1.13

-- but given that they are and most likely always be parts of perl, I don't
find it necessary.  Some people build-require them explicitly, though.

> 4) Shouldn't it be more correct to put all module requirements to Requires
> field and all testing requirements to BuildRequires filed (if 1st is true)?

See 1).  The reason why I urge you to add runtime dependencies as buildrequires
is that they are actually used during the test phase -- in most cases the
module is loaded, e.g. via use_ok() or other means.  Of course you always have
to see the actual test code.

Generally, for buildtime deps ("BuildRequires"):
1. Check the Makefile.PL or Build.PL, whatever the project uses, and add the
file's dependencies to your BRs.
2. If you're running the test suite, check and add the direct test file
dependencies.
3. If you're running the test suite, check and add the dependencies of modules
tested by the test suite too.

For runtime deps ("Requires"):
1. Build the package and see the resulting binary RPM's "requires" and compare
it with what's actually written in the packaged code.  If something is missing,
add it explicitly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=erXrHhYuWe&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904798] Review Request: sfact - Converts 3D model into G-Code for RepRap

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904798

--- Comment #4 from Miro Hrončok  ---
Ah, wrong section.

Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.b4eTZC
+ umask 022
+ cd /home/churchyard/rpmbuild/BUILD
+ cd SFACT-89e1e76d35899ad21516a2facc75df274c5550e1
+
DOCDIR=/home/churchyard/rpmbuild/BUILDROOT/sfact-0.0-1.20121114git89e1e76.fc18.x86_64/usr/share/doc/sfact-0.0
+ export DOCDIR
+ /usr/bin/mkdir -p
/home/churchyard/rpmbuild/BUILDROOT/sfact-0.0-1.20121114git89e1e76.fc18.x86_64/usr/share/doc/sfact-0.0
+ cp -pr 'SFACT Readme.txt'
/home/churchyard/rpmbuild/BUILDROOT/sfact-0.0-1.20121114git89e1e76.fc18.x86_64/usr/share/doc/sfact-0.0
+ exit 0

I thing, that there is a problem with space in filename, maybe (but I don't
know why) this

%doc SFACT\ Readme.txt

does work as escaping the space at my machine, but not at yours?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gDv10esk2L&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 877651] Review Request: sagemath - A free open-source mathematics software system

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651

Paulo Andrade  changed:

   What|Removed |Added

 Depends On||905420

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ud9kZ82Oee&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 901594] Review Request: php-password-compat - PHP password_* function for PHP 5.3 and 5.4

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901594

--- Comment #14 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kbTbA2CBWB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891229] nodejs-request - Simplified HTTP request client

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891229

--- Comment #24 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DQnrmc2iJg&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905024] Review Request: bind10 - The Berkeley Internet Name Domain 10 (BIND10) DNS and DHCP suite

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905024

Tomas Hozza  changed:

   What|Removed |Added

 CC||tho...@redhat.com
   Assignee|nob...@fedoraproject.org|tho...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=d2nWlG3IGK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 887611] Review Request: vdr-vnsiserver - VDR plugin to handle XBMC clients via VNSI

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887611

Mohamed El Morabity  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com

--- Comment #17 from Mohamed El Morabity  ---
I'd be glad to review this package. I see also no problem to include this
package in the official repositories.

Some comments:
- is there any reason you base your plugin on a git commit? Using the latest
tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC,
with no particular issue.

- vdr-devel provides many useful RPM macros (see /etc/rpm/macros.vdr) you
should use instead of those you set on your .spec file:
  %{plugindir} --> %{vdr_plugindir}
  %{apiver}--> %{vdr_apiversion}
  %{configdir} --> %{vdr_configdir}

- Is there a reason you add extra flags to %{optflags}? I can understand -fPIC
is needed, but what about all the others?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=C44pJkx6lP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904843] Review Request: acpica-tools - ACPICA tools for the development and debug of ACPI tables

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904843

--- Comment #11 from Michael Schwendt  ---
Cut'n'paste error in my previous comment:

> There, for updates of the package, you would bump the  "0." and/or ...

... bump the value at the right of "0." and/or ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=e7iA1Z0N31&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 904843] Review Request: acpica-tools - ACPICA tools for the development and debug of ACPI tables

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904843

--- Comment #10 from Michael Schwendt  ---
> On f18, if I do "yum list iasl", I get 20100528-6. 

> Could you please explain the "too low" part?

Sure. You somehow miss the %{?dist} macro at the end of the Release tag. The
value the macro expands to is not ignored during RPM version comparison:

  # rpm --eval %dist
  .fc19

  # yum list iasl|grep ^iasl
  iasl.x86_64   20120913-6.fc19   
rawhide

  # rpmdev-vercmp 20120913-6.fc19 20120913-6
  20120913-6.fc19 > 20120913-6

> what should the version be?

Either "<=" the latest EVR from Rawhide or "<" the next higher Release value,
i.e. either

  Obsoletes:  iasl <= 20120913-6.fc19
or
  Obsoletes:  iasl < 20120913-7

[...]

> Provides:   iasl > 20120913-6

Very unusual. Rather:
Provides: iasl = %{version}-%{release}

[...]

> I will need to do is provide a patch to the pmtools
> package so that they also use alternatives

Ah, that makes sense, of course.


> This is indeed a snapshot, so the version is now 20130123git,

For a snapshot, you would need to adhere to the following guideline

  https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

| There are several cases where upstream is not providing the source
| to you in an upstream tarball. In these cases you must document how
| to generate the tarball used in the rpm either through a spec file
| comment or a script included as a separate SourceX:. 

because the URL you've constructed results in "404 not found", as well as the
Packaging Naming Guidelines for snapshot packages (which Antonio has pointed
at):

  Version: 20130117

Which is the last official release of the source tarball, because typically one
doesn't "make up" own Version numbers, even if it may be possible to predict
the next version. And

  Release: 1.20130123git%{?dist}

to apply Fedora's naming guidelines for post-release snapshot packages:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages

Alternatively, if you would insist on predicting the next officially released
version, you could apply the pre-release snapshot naming guidelines (which
isn't prettier however because for newer snapshots you would change also the
Version tag, not just the Release):

  Version: 20130123
  Release: 0.1.20130123git%{?dist}

There, for updates of the package, you would bump the  "0." and/or the snapshot
date. For a future officially released tarball, you would update Version and
reset Release back to "1%{?dist}".

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
|
| If the snapshot package is considered a "pre-release package",
| you should follow the guidelines listed in Pre-Release Packages
| for snapshot packages,

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BXRnX5AmAK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905396] New: Review Request: rubygem-vagrant - Provisioning and deployment of virtual instances

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905396

Bug ID: 905396
   Summary: Review Request: rubygem-vagrant - Provisioning and
deployment of virtual instances
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: ing...@linpro.no

Spec URL: http://users.linpro.no/ingvar/vagrant/f18/specs/rubygem-vagrant.spec
SRPM URL:
http://users.linpro.no/ingvar/vagrant/f18/src/rubygem-vagrant-1.0.6-1.fc18.src.rpm

Description: 

Vagrant offers scripted provisioning and deployment of virtual instances,
removing the well-known "but it works om my laptop" obstacle. Vagrant is
well-known and much used and praised in the devops community. Its home page is
http://vagrantup.com/

While VirtualBox is the current supported target, future versions of vagrant
may support other hypervizors as well, including kvm. Being in itself free
software under the MIT license, I think vagrant could be included in fedora.

While an upstream rpm exists (putting all dependent packages in /opt) a native
fedora package of vagrant was missing. So I wrapped one up. It depends on the
following packages missing from fedora 18:

rubygem-log4r >= 1.1.9 < 2.0.0
  Fix: Build new package. Package review: bz #905240

rubygem-childprocess >=0.3.1 < 0.4.0 (0.3.6 in rawhide)
  Fix: Grab 0.3.6 package from rawhide

rubygem-json >= 1.5.1, < 1.6.0 (1.6.5 in f18, 1.9.1 in rawhide)
  Fix: Build rubygem-json15, roughly based on current package.
  Package review: bz #905389.

rubygem-net-ssh >= 2.2.2 < 2.3.0 (2.2.1 in rawhide)
  Fix: Build 2.2.2 package based on current package.
  Update request: bz #905393

yum repo with prebuilt packages for f17 and f18 available here:
http://users.linpro.no/ingvar/vagrant/

Package description from the specfile:

Vagrant offers scripted provisioning and deployment of virtual
instances. While VirtualBox is the main target, future versions may
support other hypervizors as well.

The vision of the project is to create a tool to transparently manage
all the complex parts of modern development within a virtual
environment without affecting the everyday workflow of the developer
too much. A long term goal is moving all development into virtualized
environments by making it easier to do so than not to. Additionally,
work is ongoing to have Vagrant run identically on every major
consumer OS platform (Linux, Mac OS X, and Windows).


Fedora Account System Username: ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Tp2Qty9pvN&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 905389] New: Review Request: rubygem-json15 - JSON implementation in Ruby (version 1.5.x)

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905389

Bug ID: 905389
   Summary: Review Request: rubygem-json15 - JSON implementation
in Ruby (version 1.5.x)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Reporter: ing...@linpro.no

Spec URL: http://users.linpro.no/ingvar/vagrant/f18/specs/rubygem-json15.spec
SRPM URL:
http://users.linpro.no/ingvar/vagrant/f18/src/rubygem-json15-1.5.4-1.fc18.src.rpm

Description:
In my quest to build a native package of vagrant, I needed rubygem-json-1.5.x.
Current Fedoras have moved past this months ago (atm, f18 has 1.6.5, rawhide
has 1.7.5). So I wrapped a versioned package rubygem-json15.

The package description will be the same as in the current version:

This is a implementation of the JSON specification according
to RFC 4627 in Ruby.
You can think of it as a low fat alternative to XML,
if you want to store data to disk or transmit it over
a network rather than use a verbose markup language.

See also #905240

Fedora Account System Username: ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9m3Uqltq8A&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 891996] Review Request: lua-ldoc - Lua documentation generator

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891996

Stanislav Ochotnicky  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #3 from Stanislav Ochotnicky  ---

Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

Issues:
- License file installed when any subpackage combination is installed.
  doc subpackage doesn't include COPYING file

- Patches link to upstream bugs/comments/lists or are otherwise justified.
  bonus points for contacting upstream about this

I'm approving the package, just fix the licensing in doc subpackage before
pushing to repos.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: If the package is under multiple licenses, the licensing breakdown must
 be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.

[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outsi

[Bug 895541] Review Request: ptbl - Periodic Table

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895541

--- Comment #45 from Michael Schwendt  ---
> changeing the content of source is discouraged. 

Of course, but when you modified the 1.0 source tarball, you could have
released it as 1.0.1, saving the extra work for the added files in the spec
file.

;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VvssznGvWA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895541] Review Request: ptbl - Periodic Table

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895541

--- Comment #44 from RudraB  ---
(In reply to comment #43)
> As you are upstream, why are the man page and the desktop file not part of
> the standard distribution tarball?

Since this is my first project(both as a packager and upstreamer), initially
there is no man/desktop file(I had help as the style of gnome). I add them
later to meet the requirement of fedora. Now, once the evolution started,
changeing the content of source is discouraged. That is why it is what it is.
Once the review is over (and if it is selected, ahem), I will create a update
soon, with those changes.

> 
> The %install section looks a bit messed up. Please remove empty statements
> such as
>  find %{buildroot} -type f 
> and the line continuations from
>  desktop-file-install --dir=%{buildroot}%{_datadir}/applications %{SOURCE2}
> as you are using longer lines than that just below.
> 
> As you are using desktop-file-install, there's no need to run
>  desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
> 
> 
> Also the statement
>  rm -vf %{buildroot}%{_datadir}/images/ptbl.png
>  install -p -D -m 0644 images/*
> %{buildroot}%{_datadir}/gnome/help/ptbl-manual/C/images/%{name}.png
>  install -p -D -m 0644 images/* %{buildroot}%{_datadir}/pixmaps/%{name}.png
> 
> is rather odd. First of all, the use of the * wildcard would suggest that
> there are many files to install, but from the syntax it seems that it's just
> a single file. Why not type out the full filename (which probably is just
> pbtl.png)?
> 
> Note that the -v and -f flags to rm are somewhat unnecessary, as the rm
> command is still shown in the rpmbuild output.
> 
> **
> 
> You are mixing ptbl and %{name}, which is bad style. Please choose a single
> form and stick with it.
> 
> **
> 
> In the %files section
>  %{_datadir}/gnome/help/ptbl-manual/C/images/%{name}.png
> makes the RPM package own just that file, but the RPM also creates the
> directories
>  %{_datadir}/gnome/help/ptbl-manual/
>  %{_datadir}/gnome/help/ptbl-manual/C/
>  %{_datadir}/gnome/help/ptbl-manual/C/images/
> which end up unowned. Changing the statement to 
>  %{_datadir}/gnome/help/ptbl-manual
> or preferably
>   %{_datadir}/gnome/help/ptbl-manual/
> for the sake of clarity will fix this issue.
> 
> **
> 
> Lastly, the %changelog is a wall of text. Please separate the entries with a
> single blank line.

Noted. I have changed spec as suggested. Looks prettier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=j0mXohWYVq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review