[Bug 845890] Review Request: python-django-tinymce - TinyMCE form field editor for Django applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845890 Matthias Runge changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #12 from Matthias Runge --- Package Change Request == Package Name: python-django-tinymce New Branches: el6 Owners: mrunge ralph -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yGdT9o3LAV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906442] Review Request: gimp-normalmap - Plugin that enabled the creation of normal maps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906442 --- Comment #9 from Fedora Update System --- gimp-normalmap-1.2.3-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dnOeTkgJOW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906442] Review Request: gimp-normalmap - Plugin that enabled the creation of normal maps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906442 --- Comment #10 from Fedora Update System --- gimp-normalmap-1.2.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gimp-normalmap-1.2.3-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vbA4IwKjor&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906255] Review Request: ibus-kkc - Japanese Kana Kanji input method for ibus
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906255 Jens Petersen changed: What|Removed |Added Alias||ibus-kkc -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cZLG5KNoGp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906248] Review Request: libkkc - Japanese Kana Kanji conversion library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906248 Jens Petersen changed: What|Removed |Added Alias||libkkc -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gwAqUaTQIG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908594] New: Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908594 Bug ID: 908594 Summary: Review Request: jgettext - An ANTLR-based parser and generator for GNU Gettext PO/POT in Java Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: pahu...@redhat.com Spec URL: http://fedorapeople.org/~pahuang/jgettext.spec SRPM URL: http://fedorapeople.org/~pahuang/jgettext-0.12-1.fc17.src.rpm Description: JGettext includes an ANTLR-based parser for GNU Gettext PO/POT files and a PO/POT generator as well. It's written in Java. Fedora Account System Username: pahuang -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lQqK6Lokqz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908168] Review Request: openprops - A fork of java.util.Properties from OpenJDK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908168 --- Comment #5 from Patrick Huang --- upstream changed. Updated spec file. Spec URL: http://fedorapeople.org/~pahuang/openprops.spec SRPM URL: http://fedorapeople.org/~pahuang/openprops-0.6-3.fc17.src.rpm f18 success build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4935415 f19 success build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4935440 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qe4pjcuLNW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882619] Review Request: steadyflow - Simple download manager for GNOME
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882619 --- Comment #6 from Fedora Update System --- steadyflow-0.2.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/steadyflow-0.2.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yiWqbNoyfJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882619] Review Request: steadyflow - Simple download manager for GNOME
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882619 --- Comment #7 from Fedora Update System --- steadyflow-0.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/steadyflow-0.2.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FwlCWBAv5V&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882619] Review Request: steadyflow - Simple download manager for GNOME
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882619 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=srMFguSczR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901419] Review Request: perl-Lingua-Identify - Language identification
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901419 Mathieu Bridon changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Mathieu Bridon --- Thanks for the review Petr! New Package SCM Request === Package Name: perl-Lingua-Identify Short Description: Language identification Owners: bochecha Branches: devel InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fQG4pfqwzT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891873] Review Request: perl-Net-IDN-Nameprep - Stringprep Profile for Internationalized Domain Names (RFC 3491)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891873 Mathieu Bridon changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-02-06 22:52:13 --- Comment #13 from Mathieu Bridon --- Thanks for the Git process, Jon. Package built in Rawhide, closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uixI60L25f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892433] Review Request: perl-ParseUtil-Domain - Utility for parsing a domain name into its components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892433 Bug 892433 depends on bug 891873, which changed state. Bug 891873 Summary: Review Request: perl-Net-IDN-Nameprep - Stringprep Profile for Internationalized Domain Names (RFC 3491) https://bugzilla.redhat.com/show_bug.cgi?id=891873 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZxuHTrcEvx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885344] Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885344 --- Comment #13 from Fedora Update System --- php-guzzle-Guzzle-3.1.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-guzzle-Guzzle-3.1.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2GCCVw1C2v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885344] Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885344 --- Comment #12 from Fedora Update System --- php-guzzle-Guzzle-3.1.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-guzzle-Guzzle-3.1.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GD1ysPcBIi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885344] Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885344 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zaD4aVHH2j&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904862] Review Request: php-EasyRdf - A PHP library designed to make it easy to consume and produce RDF
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904862 --- Comment #13 from Fedora Update System --- php-EasyRdf-0.7.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-EasyRdf-0.7.2-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TR2h0J5nXM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904862] Review Request: php-EasyRdf - A PHP library designed to make it easy to consume and produce RDF
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904862 --- Comment #14 from Fedora Update System --- php-EasyRdf-0.7.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-EasyRdf-0.7.2-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J8wuPrbxIN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904862] Review Request: php-EasyRdf - A PHP library designed to make it easy to consume and produce RDF
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904862 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kP7EwM2LcN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891952 Miro Hrončok changed: What|Removed |Added Flags|needinfo?(ppi...@redhat.com | |) | Flags|needinfo?(mhroncok@redhat.c | |om) | --- Comment #16 from Miro Hrončok --- Sorry, I've missed that rpmlint output is separated to source and installed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oqVjKYQwKC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891952 Miro Hrončok changed: What|Removed |Added Flags||needinfo?(ppi...@redhat.com ||) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=doxasDZpbC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891952 --- Comment #15 from T.C. Hollingsworth --- I meant this one: perl-ExtUtils-Typemaps.src: E: specfile-error warning: bogus date in %changelog: Tue Sep 28 2012 Miro Hrončok 3.15-10 The 28th was a Friday. ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GVCEVOgWhm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891952 --- Comment #14 from Miro Hrončok --- (In reply to comment #13) > [!]: rpmlint output is not clean. > > See the rpmlint section at the bottom of the review for details. All false positives, as you also agree. > False positives. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wsysiyDIfF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891952
T.C. Hollingsworth changed:
What|Removed |Added
Flags||needinfo?(mhroncok@redhat.c
||om)
--- Comment #13 from T.C. Hollingsworth ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: NEEDS WORK
Issues =
[!]: Obsoletes/Provides needed in F18 so as not to break upgrade path.
[!]: This package will generate Conflicts in F18+.
Please file a ticket with release engineering after review approval to
ensure this package is blocked in F18+.
https://fedorahosted.org/rel-eng/newticket
[!]: rpmlint output is not clean.
See the rpmlint section at the bottom of the review for details.
Things to Consider
[ ]: This package does not include a license file.
Consider querying upstream to include one.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[!]: Changelog in prescribed format.
See rpmlint warnings below.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/fedora/patches/FedoraReview/891952-perl-ExtUtils-
Typemaps/licensecheck.txt
License "same as Perl itself" == GPL+ or Artisitic so OK
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
This package will generate Conflicts and should be blocked in F18+.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Reguires:.
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[!]: If the source package does not include license text(s) as a separate
[Bug 908049] Review Request: python-django-longerusername - Make django auth.user username field longer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908049 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Ralph Bean --- New Package SCM Request === Package Name: python-django-longerusername Short Description: Make django auth.user username field longer Owners: ralph Branches: f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6tip3Ah06S&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785494] Review Request: php-horde-Horde-Compress - Horde Compression API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785494 Nick Bebout changed: What|Removed |Added Alias|horde-compress |Horde_Compress --- Comment #7 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-2.0.3-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jS5JE4Y9SM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785492] Review Request: php-horde-Horde-Controller - Horde Controller libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785492 Nick Bebout changed: What|Removed |Added Alias|horde-controller|Horde_Controller --- Comment #4 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Controller-2.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OrS8r2xKcR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785457] Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785457 --- Comment #10 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Text-Flowed-2.0.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WxHMVCHYh4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785452] Review Request: php-horde-Horde-Stream-Filter - Horde Stream filters
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785452 --- Comment #8 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter-2.0.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vne442dxAE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785476] Review Request: php-horde-Horde-Serialize - Data Encapulation API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785476 --- Comment #8 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Serialize.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Serialize-2.0.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X6dBUBfFYj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785469] Review Request: php-horde-Horde-LoginTasks - Horde Login Tasks System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785469 --- Comment #10 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-LoginTasks-2.0.2-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SvQlGycsAJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785475] Review Request: php-horde-Horde-Lock - Horde Resource Locking System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785475 --- Comment #6 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Lock.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Lock-2.0.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=01Od5lG9xz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785468] Review Request: php-horde-Horde-Image - Horde Image API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785468 --- Comment #7 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Image.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Image-2.0.3-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m7SdimkfKV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908089] Review Request: ipopt - Large-scale optimisation solver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908089 --- Comment #6 from Antonio Trande --- (In reply to comment #5) > I did not actually test it, but it is ipopt is supposed to > work with the solver as an external module; need to check > how it handles it. > > A quick googling shows that mumps and metis are not > in fedora due to uncertainty of licenses: > > mumps (actually, should be doable, the review > submitter just did leave it to anybody else > willing to work on it, and it is already accepted > in debian/ubuntu): > https://bugzilla.redhat.com/show_bug.cgi?id=566750 Sincerely I didn't understand which is the problem with MUMPS. It is public domain (http://mumps.enseeiht.fr/index.php?page=credits) and 'public domain' is accepted by Fedora (http://fedoraproject.org/wiki/Licensing:Main). As I can also read by Tom's comment: https://bugzilla.redhat.com/show_bug.cgi?id=566750#c10 > metis (another issue, should talk with upstream IMO, > and get a clean statement about it, also check if > available in other distros): > https://bugzilla.redhat.com/show_bug.cgi?id=715314 > This seems to me more complicate but I read: https://projects.coin-or.org/BuildTools/browser/ThirdParty/Metis/trunk/INSTALL.Metis and http://glaros.dtc.umn.edu/gkhome/metis/metis/faq?q=metis/metis/faq#distribute -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n991ptdtmj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891952 Miro Hrončok changed: What|Removed |Added Flags|needinfo?(mhroncok@redhat.c | |om) | Flags||needinfo?(ppi...@redhat.com ||) --- Comment #12 from Miro Hrončok --- (In reply to comment #11) > FPC has spoken: > https://fedorahosted.org/fpc/ticket/241#comment:4 > > Please work with the Perl SIG to get the proper Obsoletes/Provides in the > Perl SRPM. I'll proceed with the review shortly. Petr, could you do it, or I have to ask someone else? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fIifc6Gwvo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785446] Review Request: php-horde-Horde-Argv - Horde command-line argument parsing package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785446 --- Comment #14 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv-2.0.4-4.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IfdUeHKC0h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785444] Review Request: php-horde-Horde-Alarm - Horde Alarm Libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785444 --- Comment #10 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Alarm-2.0.3-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lvj2nzmiBq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908493] Review Request: python-django-discover-runner - A Django test runner based on unittest2's test discovery
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908493 Matthias Runge changed: What|Removed |Added Blocks||905380 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4xW2IsKPKm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908493] New: Review Request: python-django-discover-runner - A Django test runner based on unittest2's test discovery
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908493 Bug ID: 908493 Summary: Review Request: python-django-discover-runner - A Django test runner based on unittest2's test discovery Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: mru...@redhat.com Spec URL: http://www.matthias-runge.de/fedora/python-django-discover-runner.spec SRPM URL: http://www.matthias-runge.de/fedora/python-django-discover-runner-0.3-1.fc18.src.rpm Description: An alternative Django TEST_RUNNER which uses the unittest2 test discovery from a base path specified in the settings, or any other module or package specified to the test management command -- including app tests. Fedora Account System Username: mrunge rpmlint SPECS/python-django-discover-runner.spec RPMS/noarch/python-django-discover-runner-0.3-1.fc18.noarch.rpm SRPMS/python-django-discover-runner-0.3-1.fc18.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Koji scratchbuild is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=4934166 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I6b4lyms5k&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901451] Review Request: nodejs-amdefine - Provide AMD's define() API for declaring modules in the AMD format
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901451 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L8CSRXQioz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901451] Review Request: nodejs-amdefine - Provide AMD's define() API for declaring modules in the AMD format
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901451 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from T.C. Hollingsworth --- New Package SCM Request === Package Name: nodejs-amdefine Short Description: Provide AMD's define() API for declaring modules in the AMD format Owners: patches Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u10nwCzBj5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908114] Review Request: python-pillow - Python image processing library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908114 --- Comment #2 from Sandro Mani --- Spec URL: http://smani.fedorapeople.org/python-pillow.spec SRPM URL: http://smani.fedorapeople.org/python-pillow-1.7.8-90.1.fc19.src.rpm Upstreamed all upstreamable patches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IBzxCXasSM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891952] Review Request: perl-ExtUtils-Typemaps - Reads, modifies, creates and writes Perl XS typemap files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891952 --- Comment #11 from T.C. Hollingsworth --- FPC has spoken: https://fedorahosted.org/fpc/ticket/241#comment:4 Please work with the Perl SIG to get the proper Obsoletes/Provides in the Perl SRPM. I'll proceed with the review shortly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GtSsiDxe38&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904331] Review Request: perl-Shell - Run shell commands transparently within perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904331 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qcoJ8xoIcy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904329] Review Request: perl-Data-Validate-Domain - Domain validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VdyBZXbvLk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903829] Review Request: perl-Time-Interval - Convert seconds to human readable form
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829 --- Comment #19 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oS8qCM8w3b&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904329] Review Request: perl-Data-Validate-Domain - Domain validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329 --- Comment #6 from Normunds --- New Package SCM Request === Package Name: perl-Data-Validate-Domain Short Description: Domain validation methods Perl module Owners: normunds psabata Branches: f16 f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xOPh4blSEo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904331] Review Request: perl-Shell - Run shell commands transparently within perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904331 --- Comment #8 from Normunds --- New Package SCM Request === Package Name: perl-Shell Short Description: Run shell commands transparently within perl Owners: normunds psabata Branches: f16 f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=25IXJuzBiP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903829] Review Request: perl-Time-Interval - Convert seconds to human readable form
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829 --- Comment #18 from Normunds --- New Package SCM Request === Package Name: perl-Time-Interval Short Description: Perl module that converts time intervals of days, hours, minutes, and seconds Owners: normunds psabata Branches: f16 f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Egkft6OA8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904329] Review Request: perl-Data-Validate-Domain - Domain validation methods
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904329 Normunds changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a0KgiJjmte&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904331] Review Request: perl-Shell - Run shell commands transparently within perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904331 Normunds changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Normunds --- Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZjruH4EhB0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903829] Review Request: perl-Time-Interval - Convert seconds to human readable form
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829 Normunds changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Normunds --- Thanks for your help and support :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UbrKblfYwj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908089] Review Request: ipopt - Large-scale optimisation solver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908089 --- Comment #5 from Paulo Andrade --- I did not actually test it, but it is ipopt is supposed to work with the solver as an external module; need to check how it handles it. A quick googling shows that mumps and metis are not in fedora due to uncertainty of licenses: mumps (actually, should be doable, the review submitter just did leave it to anybody else willing to work on it, and it is already accepted in debian/ubuntu): https://bugzilla.redhat.com/show_bug.cgi?id=566750 metis (another issue, should talk with upstream IMO, and get a clean statement about it, also check if available in other distros): https://bugzilla.redhat.com/show_bug.cgi?id=715314 I absolutely do not suggested opening a ticket in fpc (it should be a last resort and usually only when needing a different version from a system package), but to continue on the mumps and metis review requests for now. Mumps should be the easiest, and after that, I ipopt would need to have something like a buildrequires on mumps-devel. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=amhgGbZdSz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908049] Review Request: python-django-longerusername - Make django auth.user username field longer
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908049
Matthias Runge changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #4 from Matthias Runge ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/mrunge/review/908049-python-django-
longerusername/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test th
[Bug 866901] Review Request: gogui - GUI to play game of Go
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #30 from Pierre-YvesChibon --- (In reply to comment #28) > (In reply to comment #27) > > Gogui don't require gnugo > > You can use GoGui without any Go engine as a SGF viewer/editor or as a > > local Go board for playing games between humans. > > However its main use is as a GUI for Go engines so i have include a new > > patch who add a second desktop for gnugo if he is installed. > I don't think this patch is a good idea I agree on this, I think providing the .desktop file as Source1 would be nicer. > unless you explicitely set gnugo as > a Requires. What would happen if I launched gogui through this new desktop > entry, without having gnugo installed? If my reading of the description of the TryExec key in the desktop file is correct, nothing should happen. (source: http://standards.freedesktop.org/autostart-spec/autostart-spec-latest.html) > By the way, as I told you several weeks ago on IRC, please use macros > provided by jpackage-utils to generate executable wrappers: >https://fedoraproject.org/wiki/Packaging:Java#Wrapper_Scripts > To my opinion, it's safer and easier to maintain than patching the launcher > scripts provided upstream with complicated sed queries. Not a blocker, but I clearly agree on this to :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B0ZWLK2UvS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866901] Review Request: gogui - GUI to play game of Go
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #29 from Mohamed El Morabity --- More comments: >>> %description -l fr_FR "fr_FR" is maybe a little bit too restrictive, "fr" may be enough. I don't think your package description is specific to France. >>> BuildRequires:... libxslt-devel, libxml2-devel ... Are those BR really required? They're quite strange for a Java program which doesn't build JNI bits. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X8T0XSvOKm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905848] Review Request: perl-Term-UI - Term::ReadLine user interface made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905848 Petr Šabata changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #1 from Petr Šabata --- Everything seems good. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qElvKTjpr3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866901] Review Request: gogui - GUI to play game of Go
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #28 from Mohamed El Morabity --- (In reply to comment #27) > Gogui don't require gnugo > You can use GoGui without any Go engine as a SGF viewer/editor or as a > local Go board for playing games between humans. > However its main use is as a GUI for Go engines so i have include a new > patch who add a second desktop for gnugo if he is installed. I don't think this patch is a good idea, unless you explicitely set gnugo as a Requires. What would happen if I launched gogui through this new desktop entry, without having gnugo installed? Such a patch is probably superfluous for gogui. The description of gogui is clear enough to imply it's GTP client, after all. By the way, as I told you several weeks ago on IRC, please use macros provided by jpackage-utils to generate executable wrappers: https://fedoraproject.org/wiki/Packaging:Java#Wrapper_Scripts To my opinion, it's safer and easier to maintain than patching the launcher scripts provided upstream with complicated sed queries. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mskMjKjT2b&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905848] Review Request: perl-Term-UI - Term::ReadLine user interface made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905848 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lqzDCvvNPS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901419] Review Request: perl-Lingua-Identify - Language identification
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901419 Petr Šabata changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Petr Šabata --- Ok, looks good now. Text::ExtractWords is in Rawhide now too :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W4Vu4tmfil&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908089] Review Request: ipopt - Large-scale optimisation solver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908089 --- Comment #4 from Antonio Trande --- (In reply to comment #3) > I have the full list of my coin-or- review requests > at #894610; it is not the full list of coin-or projects > but matches the contents of the "CoinAll" tarball. > > coin-or-Ipopt is one of the few without dependencies, > but I did not add ThirdParty contents. This should > be carefully reviewed, and still, should not bundle > mumps and metis, not without fpc approval; should > check what is already in fedora, and if missing, > make separate review requests. > > I am happily willing to help on whatever I can > to have it packaged in fedora. Hi Paulo. Only difference between 'ipopt' and 'coin-or-Ipopt' is ThirdParty content; but ThirdParty seems necessary to use Ascend (Bug 908088) with Ipopt (http://ascend4.org/IPOPT#Building_IPOPT). > This should be carefully reviewed, and still, should not bundle mumps and > >metis, not without fpc approval So should I open a ticket on https://fedorahosted.org/fpc/report/3 ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ExZHh7pcTs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903829] Review Request: perl-Time-Interval - Convert seconds to human readable form
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903829 Petr Šabata changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #16 from Petr Šabata --- Alright, approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9K95zgn4zT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866901] Review Request: gogui - GUI to play game of Go
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #27 from Christophe Burgun --- Hi Pierre-Yves, Gogui don't require gnugo You can use GoGui without any Go engine as a SGF viewer/editor or as a local Go board for playing games between humans. However its main use is as a GUI for Go engines so i have include a new patch who add a second desktop for gnugo if he is installed. So user can use it or not. New links : SPEC : http://jouty.fedorapeople.org/gogui.spec SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-11.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CALBu1h4i0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907756] Review Request: cloud-utils - cloud image management utilities
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907756 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | --- Comment #9 from Tom "spot" Callaway --- This method and wording of attribution for GPLv3 is word-for-word how the GPLv3 license text advises you to do it. See: "How to Apply These Terms to Your New Programs" in http://www.gnu.org/licenses/gpl-3.0.txt Lifting FE-Legal -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=42QpmtQYov&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808350] Review Request: racket - Scheme Interpreter (Replacement for plt-scheme)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=808350 --- Comment #16 from Jerry James --- If the mprotect() calls cannot be folded into mmap() calls, then an alternative is to talk to the SELinux people about writing policy for racket that allows it to call mprotect() with PROT_EXEC. I had to do that for the gcl package. Gcl allocates blocks of memory, then repurposes those blocks, so sometimes they need to be executable and sometimes not. There is no way to avoid using mprotect() to flip PROT_EXEC on and off with its memory management scheme, so we wrote a policy to create a gcl_exec_t type to allow that. I don't recommend it, but it is a possible avenue to take if all else fails. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mcb8g1EhU8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785457] Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785457 --- Comment #9 from Remi Collet --- To be consistent, also BuildRequires: php-common >= 5.3.0 BuildRequires: php-pear(PEAR) >= 1.7.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DeCVLekmy1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908090] Review Request: xgraph - XGraph with animation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090 --- Comment #4 from Antonio Trande --- (In reply to comment #3) > Hi Michael. > > (In reply to comment #2) > > > http://kojipkgs.fedoraproject.org//work/tasks/1205/4931205/build.log > > > > > gcc -DHAVE_CONFIG_H -I. -Wall -g-MT xgraph.o -MD -MP -MF > > > .deps/xgraph.Tpo -c -o xgraph.o xgraph.c > > > > Can you make it build with global %optflags? > > > > make fails: No, I'm wrong. :P http://koji.fedoraproject.org/koji/taskinfo?taskID=4933428 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m2Ch4ePJcO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785457] Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785457 --- Comment #7 from Remi Collet --- Created attachment 694003 --> https://bugzilla.redhat.com/attachment.cgi?id=694003&action=edit php-horde-Horde-Text-Flowed-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785457 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MHleGNL5Gc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785457] Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785457 Remi Collet changed: What|Removed |Added Flags||fedora-review? --- Comment #8 from Remi Collet --- [!]: License field in the package spec file matches the actual license. LGPLv2 (not LGPLv2+) [!]: Requires correct, justified where necessary. php-cre php-pear(PEAR) >= 1.7.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xzcMJWTcFW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785457] Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785457 Remi Collet changed: What|Removed |Added Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #6 from Remi Collet --- Created attachment 694002 --> https://bugzilla.redhat.com/attachment.cgi?id=694002&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vjZgtYpuz6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908389] New: Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908389 Bug ID: 908389 Summary: Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: fed...@famillecollet.com Spec URL: https://raw.github.com/remicollet/remirepo/18ab908da4541dc434f864322768b773cd7cc52b/php/horde/php-horde-Horde-Text-Filter/php-horde-Horde-Text-Filter.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Text-Filter-2.0.4-3.remi.src.rpm Description: Common methods for fitering and converting text. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6OzyPqHY7f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785457] Review Request: php-horde-Horde-Text-Flowed - Horde API for flowed text as per RFC 3676
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785457 Remi Collet changed: What|Removed |Added Blocks||908389 (Horde_Text_Filter) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yzP3R1xNxb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908389] Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908389 Remi Collet changed: What|Removed |Added Depends On||785457 (horde-text-flowed) Alias||Horde_Text_Filter -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AcDz2Ge8mg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895622 Remi Collet changed: What|Removed |Added Depends On|785486 (horde-text-filter) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FA6CPUmUvs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895184 Bug 895184 depends on bug 785486, which changed state. Bug 785486 Summary: Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API https://bugzilla.redhat.com/show_bug.cgi?id=785486 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2pWidIgBnw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895184 Remi Collet changed: What|Removed |Added Depends On|785486 (horde-text-filter) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fZX2WC1ysO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785486] Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785486 Remi Collet changed: What|Removed |Added Blocks|895184 | |(Text_Filter_Csstidy), | |895622 (Horde_Mime_Viewer), | |908329 (Horde_Core) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fzWpMmp1Cj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908329 Remi Collet changed: What|Removed |Added Depends On|785486 (horde-text-filter) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VHqbDjzavR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908090] Review Request: xgraph - XGraph with animation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090 --- Comment #3 from Antonio Trande --- Hi Michael. (In reply to comment #2) > > http://kojipkgs.fedoraproject.org//work/tasks/1205/4931205/build.log > > > gcc -DHAVE_CONFIG_H -I. -Wall -g-MT xgraph.o -MD -MP -MF > > .deps/xgraph.Tpo -c -o xgraph.o xgraph.c > > Can you make it build with global %optflags? > make fails: ... configure: creating ./config.status config.status: creating Makefile config.status: creating autoconf.h config.status: executing depfiles commands + export CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic + CFLAGS=-O2 /var/tmp/rpm-tmp.domHUw: line 51: export: `-g': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-pipe': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-Wall': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-Wp,-D_FORTIFY_SOURCE=2': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-fexceptions': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-fstack-protector': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `--param=ssp-buffer-size=4': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-m64': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-mtune=generic': not a valid identifier error: Bad exit status from /var/tmp/rpm-tmp.domHUw (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.domHUw (%build) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0pXI59KqIq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908329 Remi Collet changed: What|Removed |Added Depends On||908389 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rkIXeHljal&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908389] Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908389 Remi Collet changed: What|Removed |Added Blocks||895184 ||(Text_Filter_Csstidy), ||895622 (Horde_Mime_Viewer), ||908329 (Horde_Core) CC||n...@fedoraproject.org --- Comment #1 from Remi Collet --- *** Bug 785486 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HRt1JZHSXt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895622 Bug 895622 depends on bug 785486, which changed state. Bug 785486 Summary: Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API https://bugzilla.redhat.com/show_bug.cgi?id=785486 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WyiEkJRPcf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785486] Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785486 Remi Collet changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2013-02-06 10:18:42 --- Comment #6 from Remi Collet --- Will also submit this one *** This bug has been marked as a duplicate of bug 908389 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gtayksn7Vl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908329 Bug 908329 depends on bug 785486, which changed state. Bug 785486 Summary: Review Request: php-horde-Horde-Text-Filter - Horde Text Filter API https://bugzilla.redhat.com/show_bug.cgi?id=785486 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Co7tRB4LIf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895184 Remi Collet changed: What|Removed |Added Depends On||908389 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IKqCW6Zh83&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895622 Remi Collet changed: What|Removed |Added Depends On||908389 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K02IAEUWZ1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886300] Review Request: sino - High performance text search engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886300
--- Comment #5 from François Cami ---
Hi Pavel,
Thank you very much for taking this review!
* dependency on perl-devel
=> fixed.
* MODULE_COMPAT_* dependency
=> fixed.
* sino/sinomake are statically linked
=> this is how upstream builds. I plan to switch these binaries to dynamic
linking at some point.
* Explicit library dependency shouldn't be needed [2]. If yes, the %{_isa}
should be given & comment added.
=> I am not sure of the line where this should be changed :/
* No subpackage -> subpackage dependancy is given (except the lib one). Is
that
correct?
=> I think so.
* %post, %postun, %posttrans -n perl-sinoAPI -p /sbin/ldconfig
=> removed.
* Your hacks for so library may look ugly, would it be possible to be
solved upstream?
=> I wish, but I am pretty sure upstream needs to make sure nothing is
broken on other UNIX like Solaris, and I do not have a Solaris test box. The
alternative is to ship the static library and I would rather not do that...
(and yes, the hack is ugly).
* 'mv -f lib/libsino.so lib/libsino.so.3' redundant
=> I needed to move it out of the way, I switched to 'rm -f'.
* license of malloc.c seems to be not GPLv3+ and this file seems to be unused
=> Good catch, added rm -f at the end of prep.
* Manual page for sinodisp is not found (...) I can't find any documentation on
this!
=> Sorry, I should have fixed it earlier. The documentation is at the
beginning of sinodisp.c, so I now extract that and create a sinodisp.txt file
which is installed by the sino-cgi package as documentation. I moved the
sinodisp binary to /var/www/cgi-bin because that's where it really belongs.
Nits:
* I would comment the patches a little. Downstream/upstream, etc.
=> for now nothing's been upstreamed, but I noted what could, and could not
be upstreamed, in the new spec.
* consider adding -p to install command (preserve timestamps)
=> done.
* IIRC, defattr is not needed even in EPEL5, version in RHEL5 is 4.4.2.3.
=> removed. thanks.
Thank you!
Spec URL: http://fcami.fedorapeople.org/srpms/sino.spec
SRPM URL: http://fcami.fedorapeople.org/srpms/sino-3.1.21-3.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=G1ahyUCapi&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907478] Review Request: rubypick - Stub to allow choosing Ruby runtime
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907478 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wWqDIHyFHV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907478] Review Request: rubypick - Stub to allow choosing Ruby runtime
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907478 Vít Ondruch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Vít Ondruch --- Thank you Slavek, I appreciate your determination. New Package SCM Request === Package Name: rubypick Short Description: Stub to allow choosing Ruby runtime Owners: vondruch Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WYF8QTCoyM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808350] Review Request: racket - Scheme Interpreter (Replacement for plt-scheme)
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=808350
Travis Suel changed:
What|Removed |Added
CC||travis.bugzi...@gmail.com
--- Comment #15 from Travis Suel ---
That lead me to src/racket/src/salloc.c where HAVE_MMAP_PROTECT is used, and
specifically to this code segment starting on line 1299 (in void*
scheme_malloc_gcable_code()):
{
int r;
r = mprotect ((void *) page, length, PROT_READ | PROT_WRITE | PROT_EXEC);
if (r == -1) {
scheme_log_abort("mprotect for generate-code page failed; aborting");
}
}
It appears to be that call to mprotect() causing the SELinux trouble and the
mock build failures (the same errors as in comment 5). At least that's the
only place that seems to produce the error message "mprotect for generate-code
page failed; aborting".
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=kgIeJbz8Qv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889546] Review Request: ovirt-guest-agent - oVirt Guest Agent
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889546 --- Comment #5 from Vinzenz Feenstra --- New version (1.0.6-3): Spec URL: http://evilissimo.fedorapeople.org/specs/ovirt-guest-agent/ovirt-guest-agent.spec SRPM URL: http://evilissimo.fedorapeople.org/specs/ovirt-guest-agent/ovirt-guest-agent-1.0.6-3.fc17.src.rpm Changes: * Tue Jan 22 2013 Vinzenz Feenstra - 1.0.6-3 - All config files are now 'noreplace' - Refreshing the gtk icon cache during installation - The package is not modifying the kdmrc any longer - Using new systemd macros where appropriate Koji Scratch Builds: f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4933162 f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4933163 rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4933161 RPM lint warnings: ~/rpmbuild/RPMS$ rpmlint `find -name ovirt-guest-agent*-1.0.6-3*` # No need for documentation ovirt-guest-agent-gdm-plugin.x86_64: W: no-documentation ovirt-guest-agent-kdm-plugin.x86_64: W: no-documentation ovirt-guest-agent-pam-module.x86_64: W: no-documentation # service unit ovirt-guest-agent-common.noarch: W: only-non-binary-in-usr-lib # ovirtagent is the user gid for this package (uid/gid 175) ovirt-guest-agent-common.noarch: W: non-standard-uid /var/log/ovirt-guest-agent ovirtagent ovirt-guest-agent-common.noarch: W: non-standard-gid /var/log/ovirt-guest-agent ovirtagent # We have our own log rotate ovirt-guest-agent-common.noarch: W: log-files-without-logrotate /var/log/ovirt-guest-agent 5 packages and 0 specfiles checked; 0 errors, 7 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SxObFt22L4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844621] Review Request: perl-Log-Contextual - Simple logging interface with a contextual log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=844621 --- Comment #8 from Jon Ciesla --- Unsetting cvs flag. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ClFkCKzu87&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844670] Review Request: perl-Task-Kensho-Logging - A Glimpse at an Enlightened Perl (Logging)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=844670 Bug 844670 depends on bug 844621, which changed state. Bug 844621 Summary: Review Request: perl-Log-Contextual - Simple logging interface with a contextual log https://bugzilla.redhat.com/show_bug.cgi?id=844621 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lE6saXRU5t&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 844621] Review Request: perl-Log-Contextual - Simple logging interface with a contextual log
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=844621 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Log-Contextual-0.00430 ||0-1.fc19 Resolution|--- |RAWHIDE Flags|fedora-cvs+ | Flags||fedora-cvs? Last Closed||2013-02-06 09:44:04 --- Comment #7 from Jitka Plesnikova --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bc8gcMLN4G&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904862] Review Request: php-EasyRdf - A PHP library designed to make it easy to consume and produce RDF
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904862 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2DIhjdBkDm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885344] Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885344 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hPs3Vm2YnQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908371] Review Request: php-horde-Horde-Text-Diff - Engine for performing and rendering text diffs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908371 Remi Collet changed: What|Removed |Added CC||n...@fedoraproject.org --- Comment #1 from Remi Collet --- *** Bug 785485 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VbgviFnmqh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885344] Review Request: php-guzzle-Guzzle - PHP HTTP client library and framework for building RESTful web service clients
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885344 Shawn Iwinski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Shawn Iwinski --- THANKS for the review! New Package SCM Request === Package Name: php-guzzle-Guzzle Short Description: PHP HTTP client library and framework for building RESTful web service clients Owners: siwinski Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cis83lm14V&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908371] Review Request: php-horde-Horde-Text-Diff - Engine for performing and rendering text diffs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908371 Remi Collet changed: What|Removed |Added Alias||Horde_Text_Diff -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pWXm1YWJh8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785485] Review Request: php-horde-Horde-Text-Diff - Engine for performing and rendering text diffs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785485 Remi Collet changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2013-02-06 09:33:46 --- Comment #1 from Remi Collet --- Will submit this one *** This bug has been marked as a duplicate of bug 908371 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ud5MIuBiH1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
