[Bug 927550] New: Review Request: pycdf - A python interface to the Unidata netCDF library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927550

Bug ID: 927550
   Summary: Review Request: pycdf - A python interface to the
Unidata netCDF library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sanjay.an...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://ankursinha.fedorapeople.org/pycdf/pycdf.spec
SRPM URL: http://ankursinha.fedorapeople.org/pycdf/pycdf-0.6.3b-1.fc20.src.rpm
Description: 

pycdf is a python interface to the Unidata netCDF library.  It provides an
almost complete coverage of the netCDF C API, wrapping it  inside easy to use
python classes.


Fedora Account System Username: ankursinha

[ankur@dhcppc1  SRPMS]$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ./pycdf-0.6.3b-1.fc18.src.rpm
../SPECS/pycdf.spec
pycdf.src: W: spelling-error Summary(en_US) netCDF -> netted
pycdf.src: W: spelling-error %description -l en_US netCDF -> netted
pycdf.x86_64: W: spelling-error Summary(en_US) netCDF -> netted
pycdf.x86_64: W: spelling-error %description -l en_US netCDF -> netted
pycdf-doc.noarch: W: spelling-error %description -l en_US netCDF -> netted
pycdf.src: W: spelling-error Summary(en_US) netCDF -> netted
pycdf.src: W: spelling-error %description -l en_US netCDF -> netted
5 packages and 1 specfiles checked; 0 errors, 7 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OeqVrWKJN3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927550] Review Request: pycdf - A python interface to the Unidata netCDF library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927550

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

  Alias||pycdf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YovoI2yGKF&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 923035] Review Request: pybrain - The python machine learning library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923035

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Depends On||927550 (pycdf)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7UUo0swX6m&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927550] Review Request: pycdf - A python interface to the Unidata netCDF library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927550

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Blocks||923035 (pybrain)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7xTWliB4MO&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 926062] Review Request: qpdfview - Qt-based PDF viewer

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=926062

Eugene A. Pivnev  changed:

   What|Removed |Added

 Whiteboard||Trivial

--- Comment #3 from Eugene A. Pivnev  ---
New version (0.4.1-1).

SPEC: http://tieugene.fedorapeople.org/qpdfview/qpdfview.spec
SRPM: http://tieugene.fedorapeople.org/qpdfview/qpdfview-0.4.1-1.fc18.src.rpm

Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5173684
http://koji.fedoraproject.org/koji/taskinfo?taskID=5173696
http://koji.fedoraproject.org/koji/taskinfo?taskID=5173714
http://koji.fedoraproject.org/koji/taskinfo?taskID=5173727
http://koji.fedoraproject.org/koji/taskinfo?taskID=5173732

rpmlint:
bash-4.2$ rpmlint ~/rpmbuild/SPECS/qpdfview.spec
~/rpmbuild/RPMS/i686/qpdfview-0.4.1-1.fc18.i686.rpm
~/rpmbuild/SRPMS/qpdfview-0.4.1-1.fc18.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=qX1FTSuH29&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 836840] Review Request: gtkradiant - level design program for videogames

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836840

--- Comment #15 from Hans de Goede  ---
Hi Alberto,

(In reply to comment #14)
> Hi Hans, thanks anyway for your answer.

Cool to see that you're pursuing getting gtkradiant into Fedora!

> I revised my spec and now I think is better than before.

Yes much better, but still a lot of work todo.

> The build is made through scons, but, and this is the first doubt, every
> time I start the rpmbuild process, scons seek and download the whole games
> archive from the svn server of the project:
> svn.icculus.org/gtkradiant-gamepacks/
> I think isn't normal during the creation of an rpm leave download data from
> the internet. I think I should make an archive of files and patch the
> sources to avoid download things from the net, shouldn't I?

There are a number of problems here:

1) It should not download those gamepacks during the build

2) I wonder what the license on these gamepacks are, chances are that these
packs are not licensed under a FOSS license, in which case they should not be
packaged at all. Instead you can provide the user with a download script to
download them for the user + a README.fedora explaning this. Or you could
do a wrapper script around the gtkradiant binary which will ask the user if it
is ok to do the download automatically when the user starts gtkradiant for
the first time. Try "yum install vavoom" and then run doom-shareware as an
example of this.

3) If I'm wrong and these gamepacks are under a FOSS license they should
really be packaged in a separate gtkradiant-data.src.rpm

As for how to stop scons from doing the download, have you tried removing the
setup target from the scons invocation ?

> Another problem.. I discovered that the scons process builds, besides
> gtkradiant itself, two libraries, libpng and libjpeg. As described in the fp
> wiki, I shouldn't include bundled libraries in my rpm, so in my spec I
> removed them in the %install section, but I think I also should remove their
> creation, to speed up the build.

Yes this is the 2nd big problem you will need to solve, you should remove
these libraries from the extracted source tree in %prep to make sure that
the system version of the libraries and their headers is used during the
build.

You will then of course also need to fix any scons errors from when it tries
to build / install them anyways.

> Here is what the upstream said about the embedded libraries:
> http://icculus.org/pipermail/gtkradiant/2012-September/011823.html -->
> ".. The slightly less common deps (png and jpeg libraries, some old version)
> are bundled in to make it simple."
> 
> How can I avoid the build of unneeded libraries? I think I should edit
> config.py, around this point
> (https://github.com/TTimo/GtkRadiant/blob/master/config.py#L251),

Yes you will probably need to do something like that.

> think should be made a deep work on it, which I am not able to do.
> I've also added the two libraries needed in the Requires tags (libpng12 and
> libjpeg-turbo), obtained with 'yum provides libpng.so.? libjpeg.so.62', and
> rpmlint complains these are explicit-lib-dependencies. Is this an issue or
> should I simply leave
> Requires: libpng.so.3
> Requires: libjpeg.so.62

There is no need to add these Requires when you've build the binary against
the system copies of the libraries by removing the included copies in %prep
then rpm will pick up the Requires automatically.

> During the build I've noticed rpmbuild would create strange folders in
> /usr/lib/debug/blabla.. and so I've added
> %global debug_package %{nil}
> at the top of my spec. Is this ok?

No, rpm will automatically create a gtkradiant-debuginfo sub-package where
these files will get added too, this can then later be used to debug problems
with gtkradiant. So you should NOT have a "%global debug_package%{nil}"
in your specfile.

One last small thing I noticed, currently you have:
%global releaseno   6

And:

Release:%{version2}.%{releaseno}%{?dist}

You've the releaseno and version2 the wrong way around, see:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

Also I would not use a global for releaseno, people expect to find (and modify
if they change your package) the releaseno in the Release field, So I would
just use:

Release:6.%{version2}%{?dist}

Regards,

Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=czZUxOwkVf&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903713] Review Request: perl-Log-Message-Simple - Simplified interface to Log::Message

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903713

--- Comment #4 from Petr Pisar  ---
Waiting on unblocking .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=E6xIifZZsv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 924310] Review Request: mate-document-viewer - Document viewer

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924310

Dan Mashal  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HFbwz91RPX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 922165] Review Request: openstack-ceilometer - OpenStack measurement collection service

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=922165

Pádraig Brady  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #11 from Pádraig Brady  ---
New Package SCM Request
===
Package Name: openstack-ceilometer
Short Description: OpenStack measurement collection service
Owners: pbrady
Branches: f17 f18 f19 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SjVCDpA6se&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927427] Review Request: rtstool - Command-line interface for rtslib

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927427

Mark McLoughlin  changed:

   What|Removed |Added

 CC||mar...@redhat.com
   Assignee|nob...@fedoraproject.org|mar...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lTYwr9MJgq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 920309] Review Request: ocl-icd - OpenCL ICD Bindings

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920309

Peter Lemenkov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #3 from Peter Lemenkov  ---
Regarding tarball regeneration - that's not a big deal anyway, so I won't
insist here. All other issues were fixed.

OK, I don't see any other issues so this package is


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oWfelf6KaD&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927427] Review Request: rtstool - Command-line interface for rtslib

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927427

Mark McLoughlin  changed:

   What|Removed |Added

  Flags||needinfo?(ehar...@redhat.co
   ||m)

--- Comment #1 from Mark McLoughlin  ---
Looks good to me, except because this is a pre-release, you should include the
'a3' in the release field rather than the version field - i.e. we might have
this series of versions:

  python-rtstool-0.1-0.1.a3
  python-rtstool-0.1-0.2.a3
  python-rtstool-0.1-0.3.b1
  python-rtstool-0.1-1
  python-rtstool-0.2-0.1.a1

See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning



Detailed review:

Package Review
==

Key:
[x] = Automatic Pass
[y] = Manual Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[y]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[y]: Package contains no bundled libraries without FPC exception.
[y]: Changelog in prescribed format.
[y]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[y]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[!]: Package complies to the Packaging Guidelines
[y]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "AGPL". 1 files have unknown license. Detailed output of licensecheck in
 /home/markmc/trash/927427-python-rtstool/licensecheck.txt
[y]: Package consistently uses macro is (instead of hard-coded directory
 names).
[y]: Package is named according to the Package Naming Guidelines.
[y]: Package does not generate any conflict.
[y]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[y]: Package must own all directories that it creates.
[y]: Package does not own files or directories owned by other packages.
[y]: Requires correct, justified where necessary.
[y]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
 Note: Documentation size is 40960 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).

Python:
[y]: Python eggs must not download any dependencies during the build process.
[y]: A package which is used by another package via an egg interface should
 provide egg info.
[y]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[y]: Package functions as described.
[y]: Latest version is packaged.
[y]: Package does not include license text files separate from upstream.
[y]: Description and summary 

[Bug 927611] New: Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611

Bug ID: 927611
   Summary: Review Request: pyode - Open-source Python bindings
for The Open Dynamics Engine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sanjay.an...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://ankursinha.fedorapeople.org/pyode/pyode.spec
SRPM URL: http://ankursinha.fedorapeople.org/pyode/pyode-1.2.0-1.fc20.src.rpm

Description: 
A set of open-source Python bindings for The Open Dynamics Engine, an
open-source physics engine. PyODE also includes an XODE parser


Fedora Account System Username: ankursinha

[ankur@dhcppc1  SRPMS]$ rpmlint ../SPECS/pyode.spec
./pyode-1.2.0-1.fc18.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm  
  ../SPECS/pyode.spec: W: invalid-url Source0:
http://downloads.sourceforge.net/pyode/PyODE-snapshot-2010-03-22.tar.gz timed
out
pyode.src: W: invalid-url URL: http://pyode.sourceforge.net/ 
pyode.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 3 warnings.
[ankur@dhcppc1  SRPMS]$

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gekvOoFFWH&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

  Alias||pyode

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7Fxe4JH5yd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 923035] Review Request: pybrain - The python machine learning library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923035

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Depends On||927611 (pyode)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=l8pzl2Z0cx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Blocks||923035 (pybrain)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DxQZB7jlUf&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785460] Review Request: php-horde-Horde-Mime - Horde MIME Library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785460

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com

--- Comment #5 from Remi Collet  ---
Created attachment 716472
  --> https://bugzilla.redhat.com/attachment.cgi?id=716472&action=edit
phpci.log

phpci version 2.14.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=k4eiXH133b&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785460] Review Request: php-horde-Horde-Mime - Horde MIME Library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785460

--- Comment #6 from Remi Collet  ---
Created attachment 716473
  --> https://bugzilla.redhat.com/attachment.cgi?id=716473&action=edit
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785460

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=11489ckmsu&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785460] Review Request: php-horde-Horde-Mime - Horde MIME Library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785460

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?

--- Comment #7 from Remi Collet  ---
- MUST:

[!]: License field in the package spec file matches the actual license.

Please correct License (with the comment) :

# lib/Horde/Mime.php is BSD and LGPLv2
# other files are LGPLv2
License: LGPLv2 and BSD

- SHOULD

[!]: Requires correct, justified where necessary.
A typo in the Requires list.
BuildRequires:  php-pear(PEAR) >= 1.7.0
Listed twice should be 
Requires:  php-pear(PEAR) >= 1.7.0

- COULD

[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required

As Buildroot is not present, both could be clean (not a blocker)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nmfXuGPQmW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927427] Review Request: rtstool - Command-line interface for rtslib

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927427

Pádraig Brady  changed:

   What|Removed |Added

 CC||p...@draigbrady.com

--- Comment #2 from Pádraig Brady  ---
s|/usr/bin|%{_bindir}|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mbbRNTTZYa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785473] Review Request: php-horde-Horde-Perms - Horde Permissions System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785473

--- Comment #4 from Remi Collet  ---
Please update to latest version (2.1.0) and fix the License, I will do the
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TNwRCrhKPg&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927877] New: Review Request: naga - Simplified Java NIO asynchronous sockets

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927877

Bug ID: 927877
   Summary: Review Request: naga - Simplified Java NIO
asynchronous sockets
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: susi.leht...@iki.fi
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/naga.spec

SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/naga-3.0-1.82svn.fc18.src.rpm

Description:
Naga aims to be a very small NIO library that provides a handful of
java classes to wrap the usual Socket and ServerSocket with
asynchronous NIO counterparts (similar to NIO2 planned for Java 1.7).

All of this is driven from a single thread, making it useful for both
client (e.g. allowing I/O to be done in the AWT-thread without any
need for threads) and server programming (1 thread for all connections
instead of 2 threads/connection).

Internally Naga is a straightforward NIO implementation without any
threads or event-queues thrown in, it is "just the NIO-stuff", to let
you build things on top of it.

Naga contains the code needed to get NIO up and running without having
to code partially read buffers and setting various selection key
flags.


Fedora Account System Username: jussilehtola


This is necessary to update JMol to version 13.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kfWuc755W7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927877] Review Request: naga - Simplified Java NIO asynchronous sockets

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927877

Susi Lehtola  changed:

   What|Removed |Added

 Blocks||927873

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZNIGnqrani&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927879] New: Review Request: jspecview - JAVA applets for the display of JCAMP-DX and AnIML/CML spectral files

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927879

Bug ID: 927879
   Summary: Review Request: jspecview - JAVA applets for the
display of JCAMP-DX and AnIML/CML spectral files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: susi.leht...@iki.fi
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: 
http://theory.physics.helsinki.fi/~jzlehtol/rpms/jspecview.spec

SRPM URL: 
http://theory.physics.helsinki.fi/~jzlehtol/rpms/jspecview-2-1.1158svn.fc18.src.rpm

Description: 
The JSpecView Project provides JAVA applets for the display of
JCAMP-DX and AnIML/CML spectral files.

Fedora Account System Username: jussilehtola

This package is necessary for updating JMol to version 13.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=77j4SHFt2g&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927879] Review Request: jspecview - JAVA applets for the display of JCAMP-DX and AnIML/CML spectral files

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927879

Susi Lehtola  changed:

   What|Removed |Added

 Blocks||927873

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Uq9R19OwD2&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 922165] Review Request: openstack-ceilometer - OpenStack measurement collection service

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=922165

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |
  Flags||fedora-cvs+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XYR036t2zT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 922165] Review Request: openstack-ceilometer - OpenStack measurement collection service

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=922165

--- Comment #12 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XpJxZ97qZK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 926763] Review Request: trac-authopenid-plugin - Provide OpenID authentication for Trac

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=926763

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |
  Flags||fedora-cvs+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YFkA5VTjDQ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 926763] Review Request: trac-authopenid-plugin - Provide OpenID authentication for Trac

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=926763

--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8kmzue0HOx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785495] Review Request: php-horde-Horde-Data - Horde Data API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785495

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com

--- Comment #8 from Remi Collet  ---
Created attachment 716498
  --> https://bugzilla.redhat.com/attachment.cgi?id=716498&action=edit
phpci.log

phpci version 2.14.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=zbaPXhBzim&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785495] Review Request: php-horde-Horde-Data - Horde Data API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785495

--- Comment #9 from Remi Collet  ---
Created attachment 716499
  --> https://bugzilla.redhat.com/attachment.cgi?id=716499&action=edit
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785495

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4arMkmGy3Y&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785495] Review Request: php-horde-Horde-Data - Horde Data API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785495

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?

--- Comment #10 from Remi Collet  ---
MUST

[!]: License field in the package spec file matches the actual license.
LGPLv2

[!] Package installs properly.
Requiert : php-pear(pear.horde.org/Horde_Icalendar) >= 2.0.0
=> wait for dependencies before import

COULD (not a blocker, and I don't really care)

[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ylBzjKXGC3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] New: Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Bug ID: 927883
   Summary: Review Request: python-defusedxml - XML bomb
protection for Python stdlib modules
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: https://raw.github.com/hroncok/SPECS/master/python-defusedxml.spec
SRPM URL:
https://github.com/downloads/hroncok/SPECS/python-defusedxml-0.4-1.fc18.src.rpm

Description:

The defusedxml package contains several Python-only workarounds and fixes for
denial of service and other vulnerabilities in Python's XML libraries. In order
to benefit from the protection you just have to import and use the listed
functions / classes from the right defusedxml module instead of the original
module.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9E2NmVJrZa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||923738

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Lo3vF1BSUX&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 923959] Review Request: JOrtho - A spell checker for Java

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923959

hannes  changed:

   What|Removed |Added

 CC||mizde...@redhat.com

--- Comment #2 from hannes  ---
TODO:
Update the license to reflect the license of the dictionary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MUAiUJUzgG&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927894] New: Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927894

Bug ID: 927894
   Summary: Review Request: php-horde-Horde-SyncMl - Horde_SyncMl
provides an API for processing SyncML requests
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL:
https://raw.github.com/remicollet/remirepo/7d083ad8c3d6d68894a0e816f3da881d0febfa96/php/horde/php-horde-Horde-SyncMl/php-horde-Horde-SyncMl.spec
SRPM URL:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-SyncMl-2.0.3-2.remi.src.rpm
Description: 
Classes for implementing a SyncML server.

Fedora Account System Username: remi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bFIj96Teoe&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 871197] Review Request: catkin - Official build system of ROS

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=871197

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

Summary|Review Request: |Review Request: catkin -
   |python-catkin - Official|Official build system of
   |build system of ROS |ROS
  Alias||catkin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=zKt26MgoZI&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785442] Review Request: php-horde-Horde-Date - Horde Date package

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785442

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=6uZZA7zSdU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785424] Review Request: php-channel-horde - Adds pear.horde.org channel to PEAR

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785424

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=RErUGtwqSn&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785439] Review Request: php-horde-Horde-Util - Horde Utility Libraries

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785439

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=s97tUCE1Gv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785432] Review Request: php-horde-Horde-Translation - Horde translation library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785432

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=62Sul1WRQ5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874677

Remi Collet  changed:

   What|Removed |Added

 Depends On|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZLYpKmRXIB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785455] Review Request: php-horde-Horde-Support - Horde support package

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785455

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=iOWylIo5Ec&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785480

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NSWKGkeH4I&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785477] Review Request: php-horde-Horde-Icalendar - iCalendar API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785477

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=e0NvqKEgO0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785483] Review Request: php-horde-Horde-SyncMl - API for processing SyncML requests

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785483

Remi Collet  changed:

   What|Removed |Added

 Blocks|874677 (Horde_Rpc)  |
 Depends On|785477 (Horde_Icalendar),   |
   |785424 (horde-channel), |
   |785432 (Horde_Translation), |
   |785439 (Horde_Util), 785442 |
   |(Horde_Date), 785455|
   |(Horde_Support), 785480 |
   |(Horde_Log), 908357 |
   |(Horde_Xml_Wbxml)   |
  Alias|Horde_SyncMl|

--- Comment #1 from Remi Collet  ---
As this one is not ready, I will submit new version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VToqqhFWOs&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908357] Review Request: php-horde-Horde-Xml-Wbxml - Provides an API for encoding and decoding WBXML documents

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908357

Remi Collet  changed:

   What|Removed |Added

 Blocks|785483  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=qMzfgy7hvl&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785439] Review Request: php-horde-Horde-Util - Horde Utility Libraries

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785439

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gDaig5oY0c&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785477] Review Request: php-horde-Horde-Icalendar - iCalendar API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785477

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8kno47WxHz&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874677

Remi Collet  changed:

   What|Removed |Added

 Depends On||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kVL8keI97y&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927894

Remi Collet  changed:

   What|Removed |Added

 CC||n...@fedoraproject.org
 Blocks||874677 (Horde_Rpc)
 Depends On||785477 (Horde_Icalendar),
   ||785424 (horde-channel),
   ||785432 (Horde_Translation),
   ||785439 (Horde_Util), 785442
   ||(Horde_Date), 785455
   ||(Horde_Support), 785480
   ||(Horde_Log), 908357
   ||(Horde_Xml_Wbxml)
  Alias||Horde_SyncMl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1h4Jj0OQ1r&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785455] Review Request: php-horde-Horde-Support - Horde support package

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785455

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LmAMNDofT8&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785432] Review Request: php-horde-Horde-Translation - Horde translation library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785432

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nVyN1b1mqi&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785424] Review Request: php-channel-horde - Adds pear.horde.org channel to PEAR

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785424

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8vuekLlPuO&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908357] Review Request: php-horde-Horde-Xml-Wbxml - Provides an API for encoding and decoding WBXML documents

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908357

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YDxatsBDRy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785483] Review Request: php-horde-Horde-SyncMl - API for processing SyncML requests

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785483

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2013-03-26 09:04:47

--- Comment #2 from Remi Collet  ---


*** This bug has been marked as a duplicate of bug 927894 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Fhc7CbSh5p&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927894] Review Request: php-horde-Horde-SyncMl - Horde_SyncMl provides an API for processing SyncML requests

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927894

--- Comment #1 from Remi Collet  ---
*** Bug 785483 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rBALwnhh0V&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785442] Review Request: php-horde-Horde-Date - Horde Date package

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785442

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=H5vUpbXlMG&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785480

Remi Collet  changed:

   What|Removed |Added

 Blocks||927894 (Horde_SyncMl)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LjFByCgS4P&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 926763] Review Request: trac-authopenid-plugin - Provide OpenID authentication for Trac

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=926763

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=UKfcbm0Iws&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 926763] Review Request: trac-authopenid-plugin - Provide OpenID authentication for Trac

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=926763

--- Comment #7 from Fedora Update System  ---
trac-authopenid-plugin-0.4.2-1.el6 has been submitted as an update for Fedora
EPEL 6.
https://admin.fedoraproject.org/updates/trac-authopenid-plugin-0.4.2-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LtUD29mIPl&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927903] New: Review Request: php-horde-Horde-Notification - Horde Notification System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927903

Bug ID: 927903
   Summary: Review Request: php-horde-Horde-Notification - Horde
Notification System
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL:
https://raw.github.com/remicollet/remirepo/086b119f8f2097ba2cebaec5aad884c5880c6d6e/php/horde/php-horde-Horde-Notification/php-horde-Horde-Notification.spec
SRPM URL:
http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Notification-2.0.1-2.remi.src.rpm
Description:
A library implementing a subject-observer pattern for raising and showing
messages of different types and to different listeners.


Fedora Account System Username: remim

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=e8nEudB3PV&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 834478] Review Request: php-horde-Horde-Notification - Horde Notification System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=834478

Remi Collet  changed:

   What|Removed |Added

  Alias|Horde_Notification  |

--- Comment #1 from Remi Collet  ---
As this package is not ready, I will submit the latest version to review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=a0MnWeoQtD&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908329

Remi Collet  changed:

   What|Removed |Added

 Depends On||927903 (Horde_Notification)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=I1qaJcFGD3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927903] Review Request: php-horde-Horde-Notification - Horde Notification System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927903

Remi Collet  changed:

   What|Removed |Added

 CC||n...@fedoraproject.org
 Blocks||908329 (Horde_Core)
  Alias||Horde_Notification

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NN7LRTLiWk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=908329

Remi Collet  changed:

   What|Removed |Added

 Depends On|834478  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9xK6kp3ZQr&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927903] Review Request: php-horde-Horde-Notification - Horde Notification System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927903

--- Comment #1 from Remi Collet  ---
*** Bug 834478 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Mu3WSeTPfK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 834478] Review Request: php-horde-Horde-Notification - Horde Notification System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=834478

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks|908329 (Horde_Core) |
 Resolution|--- |DUPLICATE
Last Closed||2013-03-26 09:21:51

--- Comment #2 from Remi Collet  ---


*** This bug has been marked as a duplicate of bug 927903 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9lgdirrhZo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927457] Review Request: HTTPie - A Curl-like tool for humans

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927457

Ralph Bean  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rb...@redhat.com
   Assignee|nob...@fedoraproject.org|rb...@redhat.com
  Flags||fedora-review?

--- Comment #1 from Ralph Bean  ---
Preliminary comments


[-]: httpie contains an implementation of a Pygments theme for the solarized
 color scheme.  This has been done before elsewhere
 (https://pypi.python.org/pypi/pygments-style-solarized) but httpie has
 its own implementation -- it is not bundling.
[!]: httpie support python3 out of the box.  It is not required, but you might
 add a python3-httpie subpackage (with a %{_bindir}/python3-http
 executable).  That you *ought* to do this is not a part of the packaging
 guidelines, but is instead a pet project of mine.  ;)  It does
 not block package approval.
[!]: You should make the file/folder ownership in %{python_sitelib} more
 explicit (for future readers).  Try using the following two lines:

%{python_sitelib}/%{name}/
%{python_sitelib}/%{name}-%{version}*

[!]: If you plan to package this for el5, you can leave the defattr.
 However, I bet that's not the case since a %clean section and removal
 of the buildroot at install time are not present.  Please remove the
 defattr (or vice versa).
[!]: Buildroot: present but not needed

Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "Unknown or generated". 1 files have unknown license. Detailed output of
 licensecheck in /home/threebean/927457-httpie/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[

[Bug 785474] Review Request: php-horde-Horde-Prefs - Horde Preferences API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785474

--- Comment #3 from Remi Collet  ---
Please update to latest version (2.3.2) and I will quickly do the review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QQDzY9j10U&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=871197

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

Summary|Review Request: catkin -|Review Request: catkin -
   |Official build system of|Collection of CMake macros
   |ROS |for ROS

--- Comment #8 from Ankur Sinha (FranciscoD)  ---
Errors have been corrected.

rpmlint:

[ankur@dhcppc1  SRPMS]$ rpmlint ../SPECS/catkin.spec
./catkin-0.4.5-5.gitd4f1f24.fc18.src.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
../SPECS/catkin.spec: W: invalid-url Source0:
ros-catkin-0.4.5-0-gd4f1f24.tar.gz
catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz
catkin.noarch: W: no-manual-page-for-binary catkin_install_parse
catkin.noarch: W: no-manual-page-for-binary git-catkin
catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all
catkin.noarch: W: no-manual-page-for-binary catkin-version
catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack
catkin.noarch: W: no-manual-page-for-binary catkin-bump-version
catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace
catkin.noarch: W: no-manual-page-for-binary catkin-topological-order
catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz
catkin-devel.noarch: W: no-documentation
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.sh.installable.in 0644L /bin/sh
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.sh.installable.in.etc 0644L /bin/sh
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.zsh.installable.in 0644L /bin/zsh
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.bash.installable.in 0644L /bin/bash
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.bash.buildspace.in 0644L /bin/bash
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/update_project_index.py.in 0644L /usr/bin/env
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.sh.buildspace.in 0644L /bin/sh
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/templates/setup.zsh.buildspace.in 0644L /bin/zsh
catkin-devel.noarch: E: non-executable-script
/usr/share/catkin/cmake/interrogate_setup_dot_py.py 0644L /usr/bin/env
4 packages and 1 specfiles checked; 9 errors, 12 warnings.
[ankur@dhcppc1  SRPMS]$

The *.in files are okay I guess. Although, the templates would've been better
without shebangs. What about the one py file? :/

That's all I can find. The rest looks okay. I can't quite figure out what this
one py file does. Does it need to have the shebang? I checked up. Py files in
/usr/share have their shebangs removed.

Thanks,
Warm regards,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1PkAGqk4sI&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785477] Review Request: php-horde-Horde-Icalendar - iCalendar API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785477

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com

--- Comment #2 from Remi Collet  ---
Created attachment 716524
  --> https://bugzilla.redhat.com/attachment.cgi?id=716524&action=edit
phpci.log

phpci version 2.14.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vJNd7dHDv8&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785477] Review Request: php-horde-Horde-Icalendar - iCalendar API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785477

--- Comment #3 from Remi Collet  ---
Created attachment 716525
  --> https://bugzilla.redhat.com/attachment.cgi?id=716525&action=edit
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785477

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QItRhyFlJ0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 785477] Review Request: php-horde-Horde-Icalendar - iCalendar API

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785477

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?

--- Comment #4 from Remi Collet  ---
MUST

[!]: License field in the package spec file matches the actual license.
LGPLv2

SHOULD (but worth it as we have a blocker)

[!]: Latest version is packaged.
[!]: %check is present and all tests pass.
version 2.0.4 is relesased which fix tests

COULD (not a blocker, really)

[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed

As Buildroot is removed, both can be removed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SFUMXgqjvA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 910154] Review Request: buddycloud-http-api - The buddycloud HTTP API service for buddycloud-server

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910154

Bug 910154 depends on bug 910147, which changed state.

Bug 910147 Summary: Review Request: nodejs-node-xmpp - Idiomatic XMPP client, 
component and server library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=910147

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hNtu6CVZlT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 911022] Review Request: buddycloud-server - The buddycloud channels service for XMPP implemented in Node.js

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911022

Bug 911022 depends on bug 910147, which changed state.

Bug 910147 Summary: Review Request: nodejs-node-xmpp - Idiomatic XMPP client, 
component and server library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=910147

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EC0tboHchk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910147

Jamie Nguyen  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-03-26 09:50:15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8ZXn8k9PiO&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911024

Jamie Nguyen  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-03-26 09:50:22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QF5mnQOkvS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 911037] Review Request: nodejs-jsconfig - Asynchronous configuration loader with cli support

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911037

Bug 911037 depends on bug 911024, which changed state.

Bug 911024 Summary: Review Request: nodejs-cli - Node.js module for rapidly 
building command line apps
https://bugzilla.redhat.com/show_bug.cgi?id=911024

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gaNfmxnsS4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851683] Review Request: mingw-gconf2 - MinGW Windows port of the GNOME 2.x Desktop Configuration Database System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851683

--- Comment #5 from greg.helli...@gmail.com ---
New SRPM:
http://dl.thehellings.com/mingw32/gconf2/mingw-GConf2-3.2.6-2.fc18.src.rpm
New Spec file: http://dl.thehellings.com/mingw32/gconf2/mingw-GConf2.spec

I renamed it to GConf2.

I removed the ChangeLog file, as iconv was choking on what seemed to be
perfectly good characters and kalev suggested just ditching that file on IRC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pPSYZ50Job&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851683] Review Request: mingw-GConf2 - MinGW Windows port of the GNOME 2.x Desktop Configuration Database System

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851683

greg.helli...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |mingw-gconf2 - MinGW|mingw-GConf2 - MinGW
   |Windows port of the GNOME   |Windows port of the GNOME
   |2.x Desktop Configuration   |2.x Desktop Configuration
   |Database System |Database System
  Alias|mingw-gconf2|mingw-GConf2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AiVDkOE2pR&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858068] Review Request: mingw-qt5-qtjsbackend - Qt5 for Windows - QtJsBackend component

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858068

greg.helli...@gmail.com changed:

   What|Removed |Added

 CC||greg.helli...@gmail.com
   Assignee|nob...@fedoraproject.org|greg.helli...@gmail.com
  Flags||fedora-review?

--- Comment #3 from greg.helli...@gmail.com ---
Taking for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=S4skGWbDJ7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927917] New: Review Request: qpid-proton-c - A high performance, lightweight messaging library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927917

Bug ID: 927917
   Summary: Review Request: qpid-proton-c - A high performance,
lightweight messaging library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dpie...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://mcpierce.fedorapeople.org/rpms/qpid-proton-c.spec
SRPM URL:
http://mcpierce.fedorapeople.org/rpms/qpid-proton-c-0.4-2.fc18.src.rpm
Description: Proton is a high performance, lightweight messaging library. It
can be used in the widest range of messaging applications including brokers,
client libraries, routers, bridges, proxies, and more. Proton is based on the
AMQP 1.0 messaging standard. Using Proton it is trivial to integrate with the
AMQP 1.0 ecosystem from any platform, environment, or language.
Fedora Account System Username: mcpierce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7FfxWigeLj&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927917] Package Rename Review Request: qpid-proton-c - A high performance, lightweight messaging library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927917

Darryl L. Pierce  changed:

   What|Removed |Added

Summary|Review Request: |Package Rename Review
   |qpid-proton-c - A high  |Request: qpid-proton-c - A
   |performance, lightweight|high performance,
   |messaging library   |lightweight messaging
   ||library

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bvR399tvxa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927917] Package Rename Review Request: qpid-proton-c - A high performance, lightweight messaging library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927917

--- Comment #1 from Darryl L. Pierce  ---
This is a package RENAME request: qpid-proton --> qpid-proton-c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=eARnRp45I7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927920] New: Review Request: php-pecl-msgpack - API for communicating with MessagePack serialization

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927920

Bug ID: 927920
   Summary: Review Request: php-pecl-msgpack - API for
communicating with MessagePack serialization
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL:
https://raw.github.com/remicollet/remirepo/a812488534ff942c46640583225acb86f5165b1c/php/pecl/php-pecl-msgpack/php-pecl-msgpack.spec
SRPM URL:
http://rpms.famillecollet.com/SRPMS/php-pecl-msgpack-0.5.5-2.remi.src.rpm
Description: 
This extension provide API for communicating with MessagePack serialization.

MessagePack is an efficient binary serialization format. It lets you exchange
data among multiple languages like JSON but it's faster and smaller.
For example, small integers (like flags or error code) are encoded into a
single byte, and typical short strings only require an extra byte in addition
to the strings themselves.

If you ever wished to use JSON for convenience (storing an image with metadata)
but could not for technical reasons (encoding, size, speed...), MessagePack is
a perfect replacement.

This extension is still EXPERIMENTAL.

Fedora Account System Username: remi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cpRLAWMLnN&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858068] Review Request: mingw-qt5-qtjsbackend - Qt5 for Windows - QtJsBackend component

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858068

greg.helli...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #4 from greg.helli...@gmail.com ---
$ rpmlint mingw-qt5-qtjsbackend.spec 
mingw-qt5-qtjsbackend.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtjsbackend.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtjsbackend.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtjsbackend.spec:26: W: macro-in-comment %{snapshot_rev}
0 packages and 1 specfiles checked; 0 errors, 4 warnings.

These are fine, as they're relics of the pre-release like in qt5base

$ rpmlint mingw-qt5-qtjsbackend-5.0.1-1.fc19.src.rpm 
mingw-qt5-qtjsbackend.src: E: unknown-key GPG#9b393ae8
mingw-qt5-qtjsbackend.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtjsbackend.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtjsbackend.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtjsbackend.src:26: W: macro-in-comment %{snapshot_rev}
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

I believe the GPG error

$ rpmlint
results_mingw-qt5-qtjsbackend/5.0.1/1.fc18/mingw32-qt5-qtjsbackend-5.0.1-1.fc18.noarch.rpm
results_mingw-qt5-qtjsbackend/5.0.1/1.fc18/mingw64-qt5-qtjsbackend-5.0.1-1.fc18.noarch.rpm
mingw32-qt5-qtjsbackend.noarch: W: no-documentation
mingw32-qt5-qtjsbackend.noarch: E: zero-length
/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/Qt5V8.pc
mingw64-qt5-qtjsbackend.noarch: W: no-documentation
mingw64-qt5-qtjsbackend.noarch: E: zero-length
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/Qt5V8.pc
2 packages and 0 specfiles checked; 2 errors, 2 warnings.

Warning is fine because it depends on the parent package which does have
documentation. The errors likely need to be reported upstream.


$ rpm -q --requires mingw32-qt5-qtjsbackend
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libstdc++-6.dll)
mingw32(msvcrt.dll)
mingw32(winmm.dll)
mingw32(ws2_32.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --requires mingw64-qt5-qtjsbackend
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(kernel32.dll)
mingw64(libgcc_s_sjlj-1.dll)
mingw64(libstdc++-6.dll)
mingw64(msvcrt.dll)
mingw64(winmm.dll)
mingw64(ws2_32.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --provides mingw32-qt5-qtjsbackend
mingw32-qt5-qtjsbackend = 5.0.1-1.fc18
mingw32(qt5v8.dll)

$ rpm -q --provides mingw64-qt5-qtjsbackend
mingw64-qt5-qtjsbackend = 5.0.1-1.fc18
mingw64(qt5v8.dll)


$ wget --quiet
http://releases.qt-project.org/qt5/5.0.1/submodules_tar/qtjsbackend-opensource-src-5.0.1.tar.xz
-O - | md5sum
af5ccb9d5ab589df03eb0b12fb5ab4cd  -
$ md5sum
qtjsbackend-opensource-src-5.0.1.tar.xzaf5ccb9d5ab589df03eb0b12fb5ab4cd 
qtjsbackend-opensource-src-5.0.1.tar.xz
af5ccb9d5ab589df03eb0b12fb5ab4cd  qtjsbackend-opensource-src-5.0.1.tar.xz


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal


I don't think the missing GPG key is a problem, as I believe that indicates I
simply have not imported it to my keychain. The 0-length pkgconfig files seem
to be an issue, though. I don't see you manually installing those, so it should
probably be reported upstream? Otherwise, everything looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sMotY7oLxT&a=cc_unsubscribe

[Bug 923163] Review request: gnome-weather - A Weather application for GNOME

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923163

--- Comment #9 from Cosimo Cecchi  ---
(In reply to comment #8)

> So, right now the only remaining problem that I can see is the provides on
> libgd.so:
> libgd.so()(64bit)
> 
> As it is, if another package requires libgd.so (either because it was
> erroneously dynamically linked, or because a requires had not been properly
> filtered out), then gnome-weather would satisfy as a dependency of that
> package as far as RPM is concerned, which would be wrong.
> 
> Adding the following two lines before %description does the trick:
> %filter_provides_in %{_libdir}/%{name}/.*\.so$
> %filter_setup

Thanks, makes sense; I updated the spec and SRPM to include this. Updated files
at the same location.

Spec URL: http://people.gnome.org/~cosimoc/gnome-weather/gnome-weather.spec
SRPM URL:
http://people.gnome.org/~cosimoc/gnome-weather/gnome-weather-3.7.92-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=s0VieTIbew&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875856

--- Comment #5 from Chris Tyler  ---
Updated package.

Spec URL:
http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info.spec
SRPM URL:
http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info-0.2-1.fc18.src.rpm

Changes:
- systemd scriptlets added
- updated scripts to use 'ip addr' instead of 'ifconfig' on F18+
- fixed up dependencies

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=srxiseVGJ3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927427] Review Request: rtstool - Command-line interface for rtslib

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927427

Eric Harney  changed:

   What|Removed |Added

  Flags|needinfo?(ehar...@redhat.co |
   |m)  |

--- Comment #3 from Eric Harney  ---
Thanks for the review, I updated the versioning and used %{_bindir}.

New spec: http://fedorapeople.org/~eharney/python-rtstool/python-rtstool.spec
New SRPM:
http://fedorapeople.org/~eharney/python-rtstool/python-rtstool-0.1-0.1.a3.f18.src.rpm

(Prior files under http://fedorapeople.org/~eharney/python-rtstool/old/)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Vue0fINsxt&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 825347] Review Request: jersey - JAX-RS (JSR 311) production quality Reference Implementation

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=825347

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||m...@redhat.com
   Assignee|nob...@fedoraproject.org|m...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GKGJH6AV5Q&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927427] Review Request: rtstool - Command-line interface for rtslib

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927427

Mark McLoughlin  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #4 from Mark McLoughlin  ---
Looks good, thanks Eric

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2nxT1TwyCa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844721] Review request: python-django-flash - A Django extension to provide support for Rails-like flash

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=844721

--- Comment #17 from Bohuslav "Slavek" Kabrda  ---
Hmm, weird. Mockbuild gives me

DEBUG: Patch #0 (python-django-flash-settings.patch):
DEBUG: + /usr/bin/cat
/builddir/build/SOURCES/python-django-flash-settings.patch
DEBUG: + /usr/bin/patch -p1 --fuzz=0
DEBUG: can't find file to patch at input line 3
DEBUG: Perhaps you used the wrong -p or --strip option?
DEBUG: The text leading up to this was:
DEBUG: --
DEBUG: |--- settings.py.orig2013-03-25 10:31:41.756017345 -0500
DEBUG: |+++ settings.py2013-03-25 10:32:00.787016418 -0500
DEBUG: --

Are you sure you posted link to the correct RPM?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tdbVCAIQoP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Bohuslav "Slavek" Kabrda  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|bkab...@redhat.com
  Flags||fedora-review?

--- Comment #1 from Bohuslav "Slavek" Kabrda  ---
I'll review this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hHQ6OtDlyz&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927917] Package Rename Review Request: qpid-proton-c - A high performance, lightweight messaging library

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927917

Darryl L. Pierce  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED
Last Closed||2013-03-26 11:58:27

--- Comment #2 from Darryl L. Pierce  ---
Closing this. We can instead get by with subpackages that do what we want.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LOo9eHWnJe&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 924822] Review Request: perl-File-Temp - Return name and handle of a temporary file safely

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924822

Petr Šabata  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||psab...@redhat.com
   Assignee|nob...@fedoraproject.org|psab...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hFPXmnKpHd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 924822] Review Request: perl-File-Temp - Return name and handle of a temporary file safely

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924822

Petr Šabata  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #2 from Petr Šabata  ---
No issues at all, approving.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=qEGVmQrUKb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 924782] Review Request: perl-File-Path - Create or remove directory trees

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924782

Petr Šabata  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||psab...@redhat.com
   Assignee|nob...@fedoraproject.org|psab...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=l2kCNEu4b2&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927427] Review Request: rtstool - Command-line interface for rtslib

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927427

Eric Harney  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #5 from Eric Harney  ---
New Package SCM Request
===
Package Name: python-rtstool
Short Description: Command-line interface for rtslib
Owners: eharney
Branches: f18 f19
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=CDsO1oLvaI&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2013-03-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Bohuslav "Slavek" Kabrda  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #2 from Bohuslav "Slavek" Kabrda  ---
I can't find anything wrong with this package. Rpmlint is silent (except of
some typical "spelling-errors") and the package follows all guidelines.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3D0QS5c0Rw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >