[Bug 915005] Review Request: qt5-qttools - Qt5 - QtTool components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915005 --- Comment #8 from Gregor Tätzner gre...@freenet.de --- - if possible remove libtools archive from qtools-static: -rw-r--r-- /usr/lib64/libQt5UiTools.la - I think you should restict the buildreq to qtbase-devel further. We saw what happens if you use the wrong version -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r7S2TbP2Vda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951360] New: Review Request: nodejs-uglify-js - JavaScript parser/compressor/beautifier
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951360 Bug ID: 951360 Summary: Review Request: nodejs-uglify-js - JavaScript parser/compressor/beautifier Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: thr...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~humaton/nodejs-uglify-js.spec SRPM URL: http://fedorapeople.org/~humaton/nodejs-uglify-js-2.2.5-1.fc19.src.rpm Description: This package implements a general-purpose JavaScript parser/compressor/beautifier toolkit. It is developed on NodeJS, but it should work on any JavaScript platform supporting the CommonJS module system. Fedora Account System Username: humaton -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9xJ9BJfCw2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #6 from Gregor Tätzner gre...@freenet.de --- doesn't build on rawhide. I get a build log of 65 mb containing messages like this: generated/InspectorTypeBuilder.h:3180:25: warning: typedef 'dummycannot_cast' locally defined but not used [-Wunused-local-typedefs] COMPILE_ASSERT(sizeof(Error) == sizeof(InspectorObject), cannot_cast); There is also this configure warning: Encountered 1 configuration warning(s): ! QtQuick module not found, QML APIs will not be built I suppose we don't want to waive on any of them. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xm3V4iNTKEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #7 from Gregor Tätzner gre...@freenet.de --- oh wait, I think my build run out of space. Need to try later again... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AR0yEgvGAIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950907] Review Request: python-jedi - Python auto-completion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=950907 --- Comment #4 from Robert Kuska rku...@redhat.com --- - For first, I am sorry for misleading comment about tests. Proper way to do this is checkout the source code, make archive and add it as another Source into spec. Check this [1] for an inspiration. - I can't approve broken package, according the info you provided, some tests fail. [1] http://pkgs.fedoraproject.org/cgit/rubygem-activesupport.git/tree/rubygem-activesupport.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M8Cl7NuERIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905255
--- Comment #46 from Simone Caronni negativ...@gmail.com ---
For the font, you need also to delete it from the current release; when you'll
be updating the package upstream and thus generate a new package, you can
remove the line.
--- open-vm-tools.spec.old2013-04-12 08:46:27.422858942 +0200
+++ open-vm-tools.spec2013-04-12 08:59:51.521904690 +0200
@@ -85,6 +85,7 @@
%prep
%setup -q -n %{name}-%{version}-%{toolsbuild}
+rm -f docs/api/build/FreeSans.ttf
%build
# open-vm-tools source has some warnings generated because
Let's wait a moment on the FESCo decision on whether to start it at boot or not
in Fedora. If such is the case; here is the patch for Fedora 17:
--- open-vm-tools.spec.old2013-04-12 08:46:27.422858942 +0200
+++ open-vm-tools.spec2013-04-12 08:47:09.976766695 +0200
@@ -129,7 +129,7 @@
/usr/sbin/ldconfig
if [ $1 -eq 1 ] ; then
# Initial installation
-/bin/systemctl daemon-reload /dev/null 21 || :
+/bin/systemctl enable %{toolsdaemon}.service /dev/null 21 || :
fi
%preun
For Fedora 18 the systemd macro does not change and vmtoolsd needs to be added
to the presets (already asked on FESCo ticket).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vMiEGSob8Ua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #47 from Simone Caronni negativ...@gmail.com --- (In reply to comment #45) I think we will have to remove this file from open-vm-tools source itself. The main page of the project gives the idea that is totally abandoned, showing releases and VMWare events from 2010. While on the contrary releases have been frequent, with the one currently reviewed here being only 4 months old: http://sourceforge.net/projects/open-vm-tools/files/open-vm-tools/stable-9.2.x/ When creating the new source release for the removal of the ttf file and adding the kernel modules information to the README file, can I ask you to update the website? :D Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ugtvYro3uxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #23 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=71294name=libzen-0.4.28-5.fc19.R.src.rpm All done. Old %changelog entries will be removed later. All links direct. Or you want link without ? and ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4htooXRE2Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #48 from Richard W.M. Jones rjo...@redhat.com --- FYI: The ttf file is created by doxygen. It's not part of open-vm-tools, but copied from /usr/share/fonts/gnu-free from the existing system (package 'gnu-free-sans-fonts' on Fedora). Furthermore the doxygen.css file uses this font (although it has fallbacks). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0L7eSZcW42a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951396] New: Review Request: perl-JSON-Pointer - Perl implementation of JSON Pointer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951396 Bug ID: 951396 Summary: Review Request: perl-JSON-Pointer - Perl implementation of JSON Pointer Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://ppisar.fedorapeople.org/perl-JSON-Pointer/perl-JSON-Pointer.spec SRPM URL: http://ppisar.fedorapeople.org/perl-JSON-Pointer/perl-JSON-Pointer-0.01-1.fc20.src.rpm Description: This library is implemented JSON Pointer draft version 9 http://tools.ietf.org/html/draft-ietf-appsawg-json-pointer-09 and some useful operators from JSON Patch draft version 10 http://tools.ietf.org/html/draft-ietf-appsawg-json-patch-10. JSON Pointer is available to identify a specified value, and it is similar to XPath. Please see the both of specifications for details. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z3wsN9wjYma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=905255
--- Comment #49 from Simone Caronni negativ...@gmail.com ---
Oops, you're right, the rm line should be in the %build or %install section.
--- open-vm-tools.spec.old2013-04-12 08:46:27.422858942 +0200
+++ open-vm-tools.spec2013-04-12 10:29:41.633744622 +0200
@@ -107,6 +107,7 @@
# Remove unnecessary files from packaging
find %{buildroot}/%{_libdir} -name '*.la' -delete
rm -fr %{buildroot}/%{_defaultdocdir}
+rm -f docs/api/build/FreeSans.ttf
%if 0%{?fedora} || 0%{?rhel} = 7
@@ -129,7 +130,7 @@
/usr/sbin/ldconfig
if [ $1 -eq 1 ] ; then
# Initial installation
-/bin/systemctl daemon-reload /dev/null 21 || :
+/bin/systemctl enable %{toolsdaemon}.service /dev/null 21 || :
fi
%preun
btw Fedora already has that font by default in package gnu-free-sans-fonts.
Should we add gnu-free-sans-fonts as BuildRequires? Koji does not give any
error when building the current package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=2iAxEllYkpa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #50 from Richard W.M. Jones rjo...@redhat.com --- If Koji doesn't give an error, then don't worry about it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0PydniEUfya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #51 from Simone Caronni negativ...@gmail.com --- Off Topic: Ravindra, I don't have any problem on the systems I tested onto; and the code seems in good shape, but is anybody taking seriously the sourceforge pages and website? There are 170 bugs reported for the tools and no one is assigned: http://sourceforge.net/tracker/?group_id=204462atid=989708 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iKrQs4Q6eAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949073] Review Request: check-mk - A new general purpose Nagios-plugin for retrieving data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949073 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- check-mk-1.2.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/check-mk-1.2.2-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qczqAK3Glma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949073] Review Request: check-mk - A new general purpose Nagios-plugin for retrieving data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949073 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- check-mk-1.2.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/check-mk-1.2.2-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7NWoeKb6Sha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904843] Review Request: acpica-tools - ACPICA tools for the development and debug of ACPI tables
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=904843
--- Comment #25 from Peter Robinson pbrobin...@gmail.com ---
Further investigation on my part has me convinced that ExcludeArch is still
the proper way to go. Neither PPC, Sparc or s390 (of any flavor) provide
or support ACPI in any meaningful way. It's just simply not the way these
systems work on boot. Therefore, providing support for them in this package
is essentially meaningless; you wouldn't be able to use any of the results
produced.
The following is probably the best way to handle it because if you do
ExcludeArch it won't take into account other bringups (Tile/MIPS/jcm) that
people way wish to do in the future.
ExclusiveArch: %{ix86} x86_64 %{arm}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=gj8GI5km7ua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857992] Review Request: JQuery - Fast, concise library that simplifies how you use JavaScript
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857992 --- Comment #9 from Gregor Tätzner gre...@freenet.de --- @T.C. Are you planning to package nodejs-grunt* (also grunt-init, grunt-cli). I've looked briefly over them and I worry that not all nodejs deps for grunt are fulfilled in fedora 18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fn0fJTvbFTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929214] Review Request: php-pear-Net-IMAP - Provides an implementation of the IMAP protocol
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929214 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- php-pear-Net-IMAP-1.1.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-pear-Net-IMAP-1.1.2-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JDib0ljfTga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948275] Review Request: php-phpunit-Version - Managing the version number of Git-hosted PHP projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948275 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- php-phpunit-Version-1.0.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-phpunit-Version-1.0.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3JJh4JgiX7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927920] Review Request: php-pecl-msgpack - API for communicating with MessagePack serialization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927920 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- php-pecl-msgpack-0.5.5-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-pecl-msgpack-0.5.5-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8oV9omJk1Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] New: Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 Bug ID: 951496 Summary: Review Request: gimplensfun - gimp plugin to correct lens distortion Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: graham_al...@hotmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://grahamwhiteuk.fedorapeople.org/gimplensfun/gimplensfun.spec SRPM URL: http://grahamwhiteuk.fedorapeople.org/gimplensfun/gimplensfun-0.2.2-1.fc18.src.rpm Description: GimpLensfun is a Gimp plugin to correct lens distortion using the lensfun library and database. Fedora Account System Username: grahamwhiteuk Other Notes: my first review request ticket so sponsorship required (no sponsor yet identified) Introduction: I am new to the Fedora project outside of my company (IBM) but have been active with Red Hat based distributions since the year 2000. I was certified RHCE on Red Hat 7 in 2001. I think it's about time I gave something back so I'm starting with this simple package that I find extremely useful and build for myself at home. I currently lead our internal project to deliver Fedora to desktop machines inside the company so very familiar with building RPMS, mock and koji already. Professionally, I have worked in internal Linux support, High Performance Clustering, our Linux Integration Centre and Emerging Technologies (http://www.linkedin.com/in/grahamwhiteuk). I have occasionally blogged about Fedora on the Internet (http://gibbalog.blogspot.co.uk/search/label/fedora). You can also find me on Twitter (https://twitter.com/graham_alton) or chat to me on Freenode (Gibba). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gase5OxwBCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 Graham White graham_al...@hotmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ngNmZgVCbEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946856] Review Request: spectrwm - Minimalist tiling window manager written in C
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856 --- Comment #8 from Lokesh Mandvekar l...@buffalo.edu --- Spot, I overlooked quite a few things in the previous version. Should be fixed now. Please take a look: Spec URL: https://github.com/lsm5/rpmbuild/blob/master/SPECS/spectrwm.spec SRPM URL: https://github.com/lsm5/rpmbuild/blob/master/SRPMS/spectrwm-2.2.0-2.fc20.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5244867 $ rpmlint SRPMS/spectrwm-2.2.0-3.fc20.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/x86_64/spectrwm-2.2.0-3.fc20.x86_64.rpm spectrwm.x86_64: E: invalid-soname /usr/lib64/libswmhack.so.0.0 swm_hack.so 1 packages and 0 specfiles checked; 1 errors, 0 warnings. $ rpmlint RPMS/x86_64/spectrwm-devel-2.2.0-3.fc20.x86_64.rpm spectrwm-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint SPECS/spectrwm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Could you checkout the patch for -Wl,-soname and let me know if I'm doing it right? https://github.com/lsm5/rpmbuild/blob/master/SOURCES/spectrwm-2.2.0-versioned-shared-lib.patch Also, I'm not sure what to include in spectrwm-devel documentation. Is it ok to leave it blank? spectrwm now includes man pages in documentation. The .h files used by the lib file get installed via the dependencies itself. The only .h file in spectrwm itself is version.h which doesn't look to be installed on other distros, so I'm guessing it isn't really needed. Let me know if there's something I'm missing here. The upstream Makefile doesn't worry about the spectrwm.desktop file. Looks like they leave it to the user to take care of it (asked this on their IRC too, and nobody cared much about this file). I'm able to use spectrwm without it, so I think it's safe to ignore it (unless another user would want it). Thanks, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7BCoFbW3xNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946856] Review Request: spectrwm - Minimalist tiling window manager written in C
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856 --- Comment #9 from Lokesh Mandvekar l...@buffalo.edu --- Correction: New SRPM URL: https://github.com/lsm5/rpmbuild/blob/master/SRPMS/spectrwm-2.2.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RLJlrH1wMza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951360] Review Request: nodejs-uglify-js - JavaScript parser/compressor/beautifier
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951360 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com Assignee|nob...@fedoraproject.org|socho...@redhat.com Flags||fedora-review? --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com --- I'll review this -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PJYC9bB2PEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951250] Review Request: R-sandwich - Robust Covariance Matrix Estimators
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951250 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X0gQSOZl0ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951250] Review Request: R-sandwich - Robust Covariance Matrix Estimators
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951250 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5QvsnpnsQya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913367] Review Request: gpick - Advanced color picker
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913367
--- Comment #4 from Eugene A. Pivnev ti.eug...@gmail.com ---
BUGS:
* %description: Description is smaller then Summary.
* %post, %postun: /bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
|| : is hack. Add hicolor-icon-theme to BuildRequires and Requires.
* %files: As Fedora puts documents into %{_docdir}/%{name}-%{version} - replace
current %doc expression with share/doc/gpick/copyright (patching SConstruct
befor, naturally).
Issues (not blockers):
* Separate expressions inside sections something different then sections
between each other. E.g. - double CR between sections and one CR between
expression. Or one CR and no CR respectively.
* You can replace BRs with rpmname-independent expressions:
dbus-glib-devel = pkgconfig(dbus-glib-1)
gtk2-devel = pkgconfig(gtk+-2.0)
lua-devel = pkgconfig(lua)
expat-devel = pkgconfig(expat)
* You can replace export ... scons... with one line: scons ... CFLAGS=...
CXXFLAGS=...
* You can replace %{_usr} with %{_prefix}
Questions:
* Why lemon is needed? I created package without it.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=7m9DQiq89na=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951360] Review Request: nodejs-uglify-js - JavaScript parser/compressor/beautifier
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951360
--- Comment #2 from Stanislav Ochotnicky socho...@redhat.com ---
Few points before I start complete review:
* package doesn't build in mock. Please verify packages in mock before
submitting reviews
* Requires on nodejs and npm are most likely bogus. Requires on nodejs engine
is generated automatically, and npm is most likely not needed for package to
work correctly (or is it?)
* Why would cp -pr %{nodejs_sitelib} . in check be needed?
* Just for the record (this doesn't affect the review but FYI) following parts
are not needed in Fedora/EL6+:
* rm -rf %{buildroot}
* whole %clean section
* %defattr(-,root,root,-) (unless you really want to change defaults)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=U0Srb2BPNOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951360] Review Request: nodejs-uglify-js - JavaScript parser/compressor/beautifier
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951360
--- Comment #3 from Tomas Hrcka thr...@redhat.com ---
(In reply to comment #2)
Few points before I start complete review:
* package doesn't build in mock. Please verify packages in mock before
submitting reviews
I will.
* Requires on nodejs and npm are most likely bogus. Requires on nodejs
engine is generated automatically, and npm is most likely not needed for
package to work correctly (or is it?)
You are right removing them from spec file
* Why would cp -pr %{nodejs_sitelib} . in check be needed?
Because npm modules are linked to the root dir of the module. Otherwise tests
will not run because of missing dependencies.
* Just for the record (this doesn't affect the review but FYI) following
parts
are not needed in Fedora/EL6+:
* rm -rf %{buildroot}
* whole %clean section
* %defattr(-,root,root,-) (unless you really want to change defaults)
Going to update spec and re-upload
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=QZllyYumZJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913367] Review Request: gpick - Advanced color picker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913367 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|ti.eug...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ItFHpjcJF0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871204] Review Request: urdfdom-headers - The URDF (U-Robot Description Format) headers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871204 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SxLxzSq8uda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871204] Review Request: urdfdom-headers - The URDF (U-Robot Description Format) headers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871204 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- urdfdom-headers-0.2.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/urdfdom-headers-0.2.2-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o89w49ceqIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ONhYQjPd11a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/catkin-0.4.5-6.gitd4f1f24.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2t8Iyo27oMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/catkin-0.4.5-6.gitd4f1f24.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f5sLHH6zOBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951360] Review Request: nodejs-uglify-js - JavaScript parser/compressor/beautifier
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951360 --- Comment #4 from Tomas Hrcka thr...@redhat.com --- new versions of spec file and srpm Spec URL: http://fedorapeople.org/~humaton/nodejs-uglify-js.spec SRPM URL: http://fedorapeople.org/~humaton/nodejs-uglify-js-2.2.5-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EQ9WchKuesa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913367] Review Request: gpick - Advanced color picker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913367 --- Comment #5 from Rex Dieter rdie...@math.unl.edu --- Re comment #4 the BUGS: suggestion about icon-related %post,%postun scriptlets is invalid, please see: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache (in particular, the scriptlet's here are valid, and adding an extra Requires: hicolor-icon-theme is not, since gtk2 already pulls that in) While we're on non-blocker topics: my own pet-peave... I'd suggest removing from Summary/description the text written in C++ using GTK+ toolkit. End users don't need to know or care what language or toolkit is used. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LI1M6OWSiBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951582] New: Review Request: psi4 - An ab initio quantum chemistry package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951582
Bug ID: 951582
Summary: Review Request: psi4 - An ab initio quantum chemistry
package
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: susi.leht...@iki.fi
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Category: ---
Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/psi4.spec
SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/psi4-4.0-0.1.b4.fc18.src.rpm
Description:
PSI4 is an open-source suite of ab initio quantum chemistry programs
designed for efficient, high-accuracy simulations of a variety of
molecular properties. We can routinely perform computations with more
than 2500 basis functions running serially or in parallel.
Fedora Account System Username: jussilehtola
rpmlint output:
psi4.src: W: spelling-error Summary(en_US) initio - initiation
psi4.src: W: spelling-error %description -l en_US initio - initiation
psi4.src:2: W: configure-without-libdir-spec
psi4.src:11: W: macro-in-comment %{version}
psi4.src:127: W: macro-in-comment %{_target_platform}
psi4.x86_64: W: spelling-error Summary(en_US) initio - initiation
psi4.x86_64: W: spelling-error %description -l en_US initio - initiation
psi4.x86_64: W: no-documentation
psi4.x86_64: W: no-manual-page-for-binary psi4
psi4-data.noarch: W: no-documentation
psi4-data.noarch: E: non-executable-script /usr/share/psi/python/pep8.py 0644L
/usr/bin/python
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/chartab.cc
psi4-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2.h
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/rep.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_Heff_doubles.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_Heff.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_t1_amps.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_Heff_singles.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_t2_amps.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/petitelist.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/corrtab.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/mp2_ccsd_add_matrices.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_add_matrices.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/maketab.cc
psi4-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/psi4.0b4/src/bin/psimrcc/idmrpt2_f_int.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/pointgrp.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/shellrotation.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/irrep.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/fjt.cc
psi4-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/psi4.0b4/src/lib/libmints/symop.cc
psi4-devel.x86_64: W: no-documentation
psi4-devel.x86_64: E: zero-length /usr/include/psi4/libyeti/dataimpl.h
6 packages and 0 specfiles checked; 21 errors, 12 warnings.
The warnings are spurious, and I have adressed the errors in the upstream
development tree, which will solve them when a new tarball is released.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=lTBlilQ1Jba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951582] Review Request: psi4 - An ab initio quantum chemistry package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951582 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Alias||psi4 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Fr1EaXc5Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Alias||libint2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n0mwUadavSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927877] Review Request: naga - Simplified Java NIO asynchronous sockets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927877 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Alias||naga -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hLoHt28bcna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927879] Review Request: jspecview - JAVA applets for the display of JCAMP-DX and AnIML/CML spectral files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927879 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Alias||jspecview -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EjNY5AeHNZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736870] Review Request: netcdf4-python - Python/numpy interface to netCDF
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=736870 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LooWHuTc7Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741626] Review Request: packmol - Packing optimization for molecular dynamics simulations
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=741626 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NKMS5ka20aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742605] Review Request: netcdf-cxx4 - netCDF-4 C++ library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=742605 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sd3OotreXEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 744334] Review Request: netcdf-fortran - Fortran libraries for netCDF-4
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=744334 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L76Dia3Og3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742610] Review Request: netcdf-cxx - Legacy netCDF C++ library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=742610 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=52QY1klhqba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811661] Review Request: scirenderer - A Java rendering library based on JoGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=811661 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2sKSQQzzp2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903380] Review Request: libint2 - A library for efficient evaluation of electron repulsion integrals
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903380 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks||505154 (FE-SCITECH) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AKFrBJn5qTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927879] Review Request: jspecview - JAVA applets for the display of JCAMP-DX and AnIML/CML spectral files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927879 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks||505154 (FE-SCITECH) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i3Cdj6M5Qaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927877] Review Request: naga - Simplified Java NIO asynchronous sockets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927877 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Blocks||505154 (FE-SCITECH) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rZURCElZ6Ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 greg.helli...@gmail.com changed: What|Removed |Added CC||greg.helli...@gmail.com Assignee|nob...@fedoraproject.org|greg.helli...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z693lMF0Fla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858074
greg.helli...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from greg.helli...@gmail.com ---
Your Spec file URL above doesn't work for me, so I just went off the one in the
.src.rpm file
$ rpmlint mingw-qt5-qtquick1.spec
mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{snapshot_rev}
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpmlint mingw-qt5-qtquick1-5.0.1-1.fc19.src.rpm
mingw-qt5-qtquick1.src: E: unknown-key GPG#9b393ae8
mingw-qt5-qtquick1.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtquick1.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtquick1.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtquick1.src:26: W: macro-in-comment %{snapshot_rev}
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
$ rpmlint results_mingw-qt5-qtquick1/5.0.1/1.fc18/mingw{32,64}*
mingw32-qt5-qtquick1.noarch: W: no-documentation
mingw32-qt5-qtquick1-debuginfo.noarch: E: debuginfo-without-sources
mingw64-qt5-qtquick1.noarch: W: no-documentation
mingw64-qt5-qtquick1-debuginfo.noarch: E: debuginfo-without-sources
4 packages and 0 specfiles checked; 2 errors, 2 warnings.
$ rpm -q --requires mingw32-qt5-qtquick1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
mingw32-crt
mingw32-filesystem = 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libglesv2.dll)
mingw32(libstdc++-6.dll)
mingw32(msvcrt.dll)
mingw32(qt5core.dll)
mingw32(qt5declarative.dll)
mingw32(qt5gui.dll)
mingw32(qt5network.dll)
mingw32(qt5opengl.dll)
mingw32(qt5script.dll)
mingw32(qt5sql.dll)
mingw32(qt5widgets.dll)
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --requires mingw64-qt5-qtquick1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
mingw64-crt
mingw64-filesystem = 83
mingw64(kernel32.dll)
mingw64(libglesv2.dll)
mingw64(libstdc++-6.dll)
mingw64(msvcrt.dll)
mingw64(qt5core.dll)
mingw64(qt5declarative.dll)
mingw64(qt5gui.dll)
mingw64(qt5network.dll)
mingw64(qt5opengl.dll)
mingw64(qt5script.dll)
mingw64(qt5sql.dll)
mingw64(qt5widgets.dll)
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --provides mingw32-qt5-qtquick1
mingw32-qt5-qtquick1 = 5.0.1-1.fc18
mingw32(qt5declarative.dll)
mingw32(qmldbg_inspector.dll)
mingw32(qmldbg_tcp_qtdeclarative.dll)
mingw32(qmlfolderlistmodelplugin.dll)
mingw32(qmlgesturesplugin.dll)
mingw32(qmlparticlesplugin.dll)
mingw32(qmlshadersplugin.dll)
$ rpm -q --provides mingw64-qt5-qtquick1
mingw64-qt5-qtquick1 = 5.0.1-1.fc18
mingw64(qt5declarative.dll)
mingw64(qmldbg_inspector.dll)
mingw64(qmldbg_tcp_qtdeclarative.dll)
mingw64(qmlfolderlistmodelplugin.dll)
mingw64(qmlgesturesplugin.dll)
mingw64(qmlparticlesplugin.dll)
mingw64(qmlshadersplugin.dll)
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem = 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem = 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
All of the warnings and the dependency difference have been addressed in other
qt5 reviews.
Approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pV0gDm6vCLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 greg.helli...@gmail.com changed: What|Removed |Added CC||greg.helli...@gmail.com Assignee|nob...@fedoraproject.org|greg.helli...@gmail.com Flags||fedora-review? --- Comment #3 from greg.helli...@gmail.com --- Taking for review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EhX8VPVLI4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 greg.helli...@gmail.com changed: What|Removed |Added CC||greg.helli...@gmail.com Assignee|nob...@fedoraproject.org|greg.helli...@gmail.com Flags||fedora-review? --- Comment #3 from greg.helli...@gmail.com --- Taking for review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=weduUwoiTga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- catkin-0.4.5-6.gitd4f1f24.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s1l5lBc6Vka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871197] Review Request: catkin - Collection of CMake macros for ROS
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kGloptihu8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871204] Review Request: urdfdom-headers - The URDF (U-Robot Description Format) headers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871204 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0Oj5juwIPQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871204] Review Request: urdfdom-headers - The URDF (U-Robot Description Format) headers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871204 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- urdfdom-headers-0.2.2-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=85lqYQLScna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858064
--- Comment #4 from greg.helli...@gmail.com ---
$ rpmlint mingw-qt5-qtdeclarative.spec
mingw-qt5-qtdeclarative.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtdeclarative.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtdeclarative.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtdeclarative.spec:26: W: macro-in-comment %{snapshot_rev}
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpmlint mingw-qt5-qtdeclarative-5.0.1-1.fc19.src.rpm
mingw-qt5-qtdeclarative.src: E: unknown-key GPG#9b393ae8
mingw-qt5-qtdeclarative.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtdeclarative.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtdeclarative.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtdeclarative.src:26: W: macro-in-comment %{snapshot_rev}
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
$ rpmlint results_mingw-qt5-qtdeclarative/5.0.1/1.fc18/mingw{32,64}*
mingw32-qt5-qtdeclarative.noarch: W: no-documentation
mingw32-qt5-qtdeclarative-debuginfo.noarch: E: debuginfo-without-sources
mingw64-qt5-qtdeclarative.noarch: W: no-documentation
mingw64-qt5-qtdeclarative-debuginfo.noarch: E: debuginfo-without-sources
4 packages and 0 specfiles checked; 2 errors, 2 warnings.
$ rpm -q --requires mingw32-qt5-qtdeclarative
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
mingw32-crt
mingw32-filesystem = 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libglesv2.dll)
mingw32(libstdc++-6.dll)
mingw32(msvcrt.dll)
mingw32(qt5core.dll)
mingw32(qt5gui.dll)
mingw32(qt5network.dll)
mingw32(qt5qml.dll)
mingw32(qt5quick.dll)
mingw32(qt5quickparticles.dll)
mingw32(qt5quicktest.dll)
mingw32(qt5sql.dll)
mingw32(qt5test.dll)
mingw32(qt5v8.dll)
mingw32(qt5widgets.dll)
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --requires mingw64-qt5-qtdeclarative
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
mingw64-crt
mingw64-filesystem = 83
mingw64(kernel32.dll)
mingw64(libglesv2.dll)
mingw64(libstdc++-6.dll)
mingw64(msvcrt.dll)
mingw64(qt5core.dll)
mingw64(qt5gui.dll)
mingw64(qt5network.dll)
mingw64(qt5qml.dll)
mingw64(qt5quick.dll)
mingw64(qt5quickparticles.dll)
mingw64(qt5quicktest.dll)
mingw64(qt5sql.dll)
mingw64(qt5test.dll)
mingw64(qt5v8.dll)
mingw64(qt5widgets.dll)
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --provides mingw32-qt5-qtdeclarative
mingw32-qt5-qtdeclarative = 5.0.1-1.fc18
mingw32(qt5qml.dll)
mingw32(qt5quick.dll)
mingw32(qt5quickparticles.dll)
mingw32(qt5quicktest.dll)
mingw32(qtaccessiblequick.dll)
mingw32(qmldbg_qtquick2.dll)
mingw32(qmldbg_tcp.dll)
mingw32(qmlfolderlistmodelplugin.dll)
mingw32(qtquick2plugin.dll)
mingw32(qmllocalstorageplugin.dll)
mingw32(particlesplugin.dll)
mingw32(windowplugin.dll)
mingw32(qmltestplugin.dll)
$ rpm -q --provides mingw64-qt5-qtdeclarative
mingw64-qt5-qtdeclarative = 5.0.1-1.fc18
mingw64(qt5qml.dll)
mingw64(qt5quick.dll)
mingw64(qt5quickparticles.dll)
mingw64(qt5quicktest.dll)
mingw64(qtaccessiblequick.dll)
mingw64(qmldbg_qtquick2.dll)
mingw64(qmldbg_tcp.dll)
mingw64(qmlfolderlistmodelplugin.dll)
mingw64(qtquick2plugin.dll)
mingw64(qmllocalstorageplugin.dll)
mingw64(particlesplugin.dll)
mingw64(windowplugin.dll)
mingw64(qmltestplugin.dll)
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem = 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem = 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
All these warnings and errors have been addressed elsewhere in the Qt5 reviews.
Approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PjnnlzfSoga=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 greg.helli...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4k99mgUpgqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858082
--- Comment #4 from greg.helli...@gmail.com ---
$ rpmlint mingw-qt5-qttranslations.spec
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev}
0 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpmlint mingw-qt5-qttranslations-5.0.1-1.fc19.src.rpm
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev}
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpmlint results_mingw-qt5-qttranslations/5.0.1/1.fc18/mingw{32,64}*
mingw32-qt5-qttranslations.noarch: W: no-documentation
mingw32-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package
mingw64-qt5-qttranslations.noarch: W: no-documentation
mingw64-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package
4 packages and 0 specfiles checked; 2 errors, 2 warnings.
Since there is no binary portion to this package, it appears you should disable
building of the debuginfo packages.
$ rpm -q --requires mingw32-qt5-qttranslations
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --requires mingw64-qt5-qttranslations
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(PayloadIsXz) = 5.2-1
$ rpm -q --provides mingw32-qt5-qttranslations
mingw32-qt5-qttranslations = 5.0.1-1.fc18
$ rpm -q --provides mingw64-qt5-qttranslations
mingw64-qt5-qttranslations = 5.0.1-1.fc18
$ wget --quiet
http://releases.qt-project.org/qt5/5.0.1/submodules_tar/qttranslations-opensource-src-5.0.1.tar.xz
-O - | md5sum
de27f8384296e366e454754b69197634 -
$ md5sum qttranslations-opensource-src-5.0.1.tar.xz
de27f8384296e366e454754b69197634 qttranslations-opensource-src-5.0.1.tar.xz
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem = 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem = 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[!] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
I believe the debug package can be suppressed as there is no binary code which
includes debug symbols here.
Additionally, this package is, by its very nature, a translations package. Yet
you're not using the find_lang macro. Does it not support .qm files? Does it
need to be updated to include these files as well, or are qm files considered
too app specific for that?
You note that the BR for mingw32-qt-qmake and mingw64-qt-qmake are Temporary
until lrelease-qt5 is built. I don't see a native package for those yet, but I
see mingw{32,64}-qt5-qttools-lrelease. Is the native package built and ready
yet? If not, you might note what issue # will see it completed in the spec file
for sanity's sake.
The rest of the issues have been addressed elsewhere in mingw-qt5 reviews.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fSNZqvLswZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949154] Review Request: qlipper - Qt-based clipboard history
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949154 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- I can review... 1. MUST fix license, recommend using: License: GPLv3+ since it's a mixture of BSD and GPLv2+ and GPLv3+ $ licensecheck -r * build/CMakeFiles/2.8.10.2/CompilerIdC/CMakeCCompilerId.c: *No copyright* UNKNOWN macosx/strip_bundle.sh: *No copyright* UNKNOWN qkeysequencewidget/qkeysequencewidget.h: BSD (3 clause) qkeysequencewidget/qkeysequencewidget.cpp: BSD (3 clause) qkeysequencewidget/qkeysequencewidget_p.h: BSD (3 clause) qmenuview/qmenuview_p.h: GPL (v3 or later) qmenuview/qmenuview.h: GPL (v3 or later) qmenuview/qmenuview.cpp: GPL (v3 or later) src/qlippertypes.h: *No copyright* UNKNOWN src/qlipperpreferencesdialog.h: GPL src/qlipperpreferences.h: GPL src/qlippernetwork.cpp: GPL src/qlipperpreferences.cpp: GPL src/qlippermodel.h: GPL src/qlippermodel.cpp: GPL src/qlipperitem.h: GPL src/qlippernetwork.h: GPL src/qlippermenuview.cpp: GPL src/qlippermenuview.h: GPL src/config.h: GPL src/main.cpp: GPL src/qlipperpreferencesdialog.cpp: GPL src/qlippersystray.cpp: GPL src/qlipperitem.cpp: GPL src/qlippersystray.h: GPL sources: ok e5e256de9b8ea07e237bde9b8e3ceb75 qlipper-2.0.1.tar.bz2 2. SHOULD drop from %build: -DCMAKE_INSTALL_PREFIX=/usr this is redundant and already included in %cmake macro macros: ok builds/installs: ok scriptlets: n/a (none) 3. SHOULD drop and cross-platform from %description, it doesn't add any value, imo the rest is a fairly simple package, I see no other issues. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HPfVvWflFya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #8 from Gregor Tätzner gre...@freenet.de --- (In reply to comment #6) There is also this configure warning: Encountered 1 configuration warning(s): ! QtQuick module not found, QML APIs will not be built Oh yes, adding qtdeclarative to buildreq did the trick, though I'm getting unpackaged file errors now ;) DEBUG: error: Installed (but unpackaged) file(s) found: DEBUG: /usr/lib64/qt5/qml/QtWebKit/experimental/libqmlwebkitexperimentalplugin.so DEBUG:/usr/lib64/qt5/qml/QtWebKit/experimental/qmldir DEBUG:/usr/lib64/qt5/qml/QtWebKit/libqmlwebkitplugin.so DEBUG:/usr/lib64/qt5/qml/QtWebKit/qmldir DEBUG: Installed (but unpackaged) file(s) found: DEBUG: /usr/lib64/qt5/qml/QtWebKit/experimental/libqmlwebkitexperimentalplugin.so DEBUG:/usr/lib64/qt5/qml/QtWebKit/experimental/qmldir DEBUG:/usr/lib64/qt5/qml/QtWebKit/libqmlwebkitplugin.so DEBUG:/usr/lib64/qt5/qml/QtWebKit/qmldir -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QRa73RFm52a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 Gregor Tätzner gre...@freenet.de changed: What|Removed |Added Blocks||915006 (qt5-qtwebkit) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PdG9JNngzha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 Gregor Tätzner gre...@freenet.de changed: What|Removed |Added Depends On||915909 (qt5-qtdeclarative) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PDBdmb0KNca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891941] Review Request: istatd - Daemon serving statistics to your iStat iPhone application
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891941
--- Comment #5 from Tomasz Torcz zdzi...@irc.pl ---
Almost perfect, but rpmlint errors now:
istatd.spec:43: E: hardcoded-library-path in %{_prefix}/lib/tmpfiles.d
istatd.spec:45: E: hardcoded-library-path in
%{_prefix}/lib/tmpfiles.d/istatd.conf
istatd.spec:74: E: hardcoded-library-path in
%{_prefix}/lib/tmpfiles.d/istatd.conf
please uset %{_tmpfilesdir} macro instead of %{_prefix}/lib/tmpfiles.d.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=kS7BVspzJka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946856] Review Request: spectrwm - Minimalist tiling window manager written in C
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856 --- Comment #10 from Tom spot Callaway tcall...@redhat.com --- That patch isn't correct. You want the line to look like this: $(CC) -Wl,-soname,libswmhack.so.0 -shared -fpic -o libswmhack.so.$(LVERS) swm_hack.so $(LDADD) You might not want to hardcode it like that, since it uses a variable for the full versioning, but you might need to create a new makefile variable that just has the major soversion. You can leave the -devel package without docs, thats fine. Also, if none of the .h files are useful, you can ignore them. (Same for the .desktop file). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=04brOKxeYWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #9 from Rex Dieter rdie...@math.unl.edu --- Good catch, I'll add the optional builddep and feature in the next pkg iteration. In the meantime, I'd prefer if we could focus on review blockers... ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Oz7ezX58EOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- Rats, hit a conflict today working on 5.0.2: file /usr/bin/qmlplugindump from install of qt5-qtdeclarative-5.0.2-1.fc18.x86_64 conflicts with file from package qt-devel-1:4.8.4-14.fc18.x86_64 Anyway, work in progress: Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative-5.0.2-1.fc18.src.rpm %changelog * Thu Apr 11 2013 Rex Dieter rdie...@fedoraproject.org 5.0.2-1 - 5.0.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IQYRfSR7VKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 Gregor Tätzner gre...@freenet.de changed: What|Removed |Added CC||gre...@freenet.de Assignee|nob...@fedoraproject.org|gre...@freenet.de -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xc5pxUC9fna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891941] Review Request: istatd - Daemon serving statistics to your iStat iPhone application
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891941 --- Comment #6 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- Modified to use correct tmpfiles.d macro. Spec URL: http://lorenzodalrio.fedorapeople.org/istatd.spec SRPM URL: http://lorenzodalrio.fedorapeople.org/istatd-0.5.8-4.fc18.src.rpm Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5246379 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N2neo81B6Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #52 from Ravindra Kumar ravindraku...@vmware.com --- I had noticed that web site has gone bit old, but the main reason for that is there are not many new exciting things there to update. Once we package it in Fedora and RHEL, we will have things to update on the web site. Regarding bugs, all 170 are not open bugs. If you filter by open status, you would find much less of them. Richard, if doxygen is copying the font, do we really need to remove the font file? I would prefer to leave it there if doxygen wants it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7wqZxO4IXfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 --- Comment #2 from Rex Dieter rdie...@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtdeclarative-5.0.2-2.fc18.src.rpm %changelog * Fri Apr 12 2013 Rex Dieter rdie...@fedoraproject.org 5.0.2-2 - fix conflicts with qt4-devel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CBFe5vMAdxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #4 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- New Package SCM Request === Package Name: mingw-qt5-qtquick1 Short Description: Qt5 for Windows - QtQuick1 component Owners: epienbro Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1ZaOK6uJita=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0MR0phS2Vda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vz07lDxCK4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #5 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- New Package SCM Request === Package Name: mingw-qt5-qtdeclarative Short Description: Qt5 for Windows - QtDeclarative component Owners: epienbro Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WSu27bpOWja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nOrOUgHfXoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yT0fmdRZKCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905255] Review Request: open-vm-tools - Open Virtual Machine Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #53 from Richard W.M. Jones rjo...@redhat.com --- The font file seems fine. I would not remove it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WUWgeFT20Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903428
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr
||a...@gmail.com
Flags||fedora-review?
--- Comment #1 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
The package is quite simple so I do not expect to
find any major issues, at first my considerations
are:
I see you made the manual page based on
http://clc.cs.uiowa.edu/lfsc/readme-lfsc.txt
I suggest adding it to sources, no need to install as
%doc, to work as a kind of reminder to validate the manual
page is up to dade when updating the package.
[!]: %check is present and all tests pass.
Please add a simple %check section with a basic validation
that the package works as expected.
Full fedora-review text follows:
---%---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/pcpa/903428-lfsc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927477
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr
||a...@gmail.com
Flags||fedora-review?
--- Comment #2 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
Any reason to not buildrequires doxygen and generate doc,
maybe a better option than making README.md %doc?
By just running doxygen in the topdir, ignoring the latex subdir:
$ find BUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/ | wc
-l
242
$ du -sh BUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/
2.1MBUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/
and loading
file:///home/pcpa/rpmbuild/BUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/index.html
in firefox, it looks like to be desirable to have a -doc subpackage.
Is there any prevision of an official release? I see only
\section sec-licensing Licensing in remake.cpp with version
information. Is this correct?
--- Full fedora-review text follows ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/pcpa/927477-remake/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #10 from Rex Dieter rdie...@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.2-2.fc18.src.rpm %changelog * Fri Apr 12 2013 Rex Dieter rdie...@fedoraproject.org 5.0.2-2 - BR: qt5-qtdeclarative-devel Can no longer do a scratch build, due to qt5-qtdeclarative not being available yet. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xNk24MoiApa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UszULoGl7Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|fedora-mingw@lists.fedorapr | |oject.org | Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gyilDYKcDPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtquick1-5.0.1-1.fc19,mingw-qt5-qtdeclarative-5.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-qt5-qtquick1-5.0.1-1.fc19,mingw-qt5-qtdeclarative-5.0.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BtYZK2t8ICa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtquick1-5.0.1-1.fc19,mingw-qt5-qtdeclarative-5.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-qt5-qtquick1-5.0.1-1.fc19,mingw-qt5-qtdeclarative-5.0.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v2eMWjmgDha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] New: Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 Bug ID: 951711 Summary: Review Request: impressjs - Javascript presentation framework Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: rb...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://ralph.fedorapeople.org//impressjs.spec SRPM URL: http://ralph.fedorapeople.org//impressjs-0.5.3-120130412gitgedff5a0.fc18.src.rpm Description: It's a presentation framework based on the power of CSS3 transforms and transitions in modern browsers and inspired by the idea behind prezi.com. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jnupqb9tyra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951711] Review Request: impressjs - Javascript presentation framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951711 --- Comment #1 from Ralph Bean rb...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5246952 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RURVj4HCXRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtdeclarative-5.0.1-1.fc18,mingw-qt5-qtquick1-5.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-qt5-qtdeclarative-5.0.1-1.fc18,mingw-qt5-qtquick1-5.0.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ayx2xMc3EZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtdeclarative-5.0.1-1.fc18,mingw-qt5-qtquick1-5.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-qt5-qtdeclarative-5.0.1-1.fc18,mingw-qt5-qtquick1-5.0.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pX4WexTmIGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787834] Review Request: fishpoll - Daemon and Client to run scripts when triggered from the network
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=787834 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-12 20:12:12 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cAhSyj2HKda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787834] Review Request: fishpoll - Daemon and Client to run scripts when triggered from the network
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=787834 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- fishpoll-0.1.6-4.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UJpSdBrt5oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927883 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-defusedxml-0.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=my8ks07hyHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950639] Review Request: c-ares19 - A library that performs asynchronous DNS operations
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=950639 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-0.10.3-2.el6.1, libuv-0.10.3-2.el6, http-parser-2.0-4.20121128gitcd01361.el6, c-ares19-1.9.1-4.el6.3 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aFp4Phtzsha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950639] Review Request: c-ares19 - A library that performs asynchronous DNS operations
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=950639 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XuUFiGyDSNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787834] Review Request: fishpoll - Daemon and Client to run scripts when triggered from the network
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=787834 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- fishpoll-0.1.6-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IKql58tUDoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877651] Review Request: sagemath - A free open-source mathematics software system
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877651
--- Comment #61 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
(In reply to comment #60)
I won't post the full output of fedora-review again, just a short list of
items to be addressed. We're almost there!
First, lrslib is listed as a Requires. The lrslib package contains only the
library. It looks like the lrs program is needed by
sage/geometry/polyhedron/base.py. In that case, the Requires should be for
lrslib-utils instead.
Fixed.
Second, the license breakdown still needs to be explained in a comment:
https://fedoraproject.org/wiki/Packaging:
LicensingGuidelines#Multiple_Licensing_Scenarios
I know you said the license breakdown is available elsewhere, but it needs
to appear in the spec file, too.
I belive I was missing only the comment about the breakdown before
the License tag line, so, should be fixed now.
I am a bit unsure if using GPL is valid as license, but I added it
due to (http://www.wrongway.org/?rubiksource):
---%---
The source code for my various rubik solvers are freely available. They are,
for the moment, released GPL (e.g., free to distribute and modify but it and
its derivitives must always remain free and open source).
---%---
Third, I did not make my meaning clear with the comment about one-line
scripts. You should have this:
%post sagetex -p %{_bindir}/mktexlsr
%postun sagetex -p %{_bindir}/mktexlsr
Note the use of -p. That allows RPM to invoke the program directly, rather
than spawning a shell to run the contents of the script. See
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax.
Fixed.
Fourth, there is some new output from rpmlint that should be reviewed. Can
you take a look at these to see which are real issues that need to be
addressed?
sagemath-core.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libcsage.so.0 /lib64/libm.so.6
I prefer to keep this in case there are a few of these python modules
$ rpm -ql sagemath-core | grep '.so$' | wc -l
339
that do not really need to link to libcsage.so
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/server/notebook/compress/all.py
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/misc/test_cpickle_sage.py
Removed in %install for the sake of silencing the warning.
sagemath-core.x86_64: W: dangling-symlink /usr/lib64/sagemath/devel/sage
/usr/lib64/python2.7/site-packages
Fixed by moving the symlink to the -devel package.
sagemath-core.x86_64: E: zero-length
/usr/lib64/python2.7/site-packages/sage/libs/pari/to_gen.pxi
sagemath-data-extcode.noarch: W: dangling-symlink
/usr/share/sagemath/extcode/sage /usr/lib64/python2.7/site-packages
I reworked the requires to have the symlink owned by the
sagemath-data package, and add explicitly requires to the
main package from sagemath-data. But it appears to not
silence the warning, as I thought it was caused by the
case of:
a.bin - requires package that provides /lib/foo
a.noarch - has symlink to /lib/foo
a.bin - requires a.noarch
a.noarch - does not require a.bin
so, what I did was to make a.noarch require a.bin , but
the warning remained.
sagemath-doc.noarch: W: only-non-binary-in-usr-lib
sagemath-doc.noarch: W: doc-file-dependency
/usr/share/doc/sagemath-5.8/common/update-python-inv.sh /usr/bin/env
sagemath-doc.noarch: W: doc-file-dependency
/usr/share/doc/sagemath-5.8/common/builder.py /usr/bin/env
These are kind of documentation files also, that happen to be usable
as scripts. Documentation is not supposed to be regenerated from
installed packages, but possible with some tweaks.
sagemath-doc-en.noarch: W: spurious-executable-perm
/usr/share/doc/sagemath-5.8/en/prep/media/Rplot001.png
Fixed.
sagemath-data.noarch: W: dangerous-command-in-%pretrans mv
sagemath-doc.noarch: W: dangerous-command-in-%pretrans mv
sagemath-notebook.x86_64: W: dangerous-command-in-%postun rm
sagemath-notebook.x86_64: W: dangerous-command-in-%posttrans ln
I am keeping these a bit more for the sake of making clean upgrades
after changing base dir to %{_libdir} for arch specific files, and
after changing doc/data subpackages to noarch. This should be the
last build with it, as I assume people using my f18 repository
have upgraded to the latest version.
This should not go in the final package. Just remind me, or
yourself if you wish about ensuring those pretrans and posttrans
are removed once the package is approved :-)
sagemath-rubiks.x86_64: W: spelling-error %description -l en_US contributers
- contributes, contributors, contribute rs
This is text from sagemath spkg.txt, I changed the spec for the
sake of not having this warning again.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Cka0BCFziha=cc_unsubscribe
___
package-review mailing list
