[Bug 928226] Review Request: libmwaw: import library for some old mac text documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928226 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Flags|fedora-review+ | Flags||fedora-review? Last Closed||2013-04-28 02:21:19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4DINOGduR7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957436] New: Review Request: lookat - User-Friendly Text File Viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957436 Bug ID: 957436 Summary: Review Request: lookat - User-Friendly Text File Viewer Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://cicku.me/lookat.spec SRPM URL: http://cicku.me/lookat-1.4.2-1.fc20.src.rpm Description: lookat is a program to view text files and manual pages. It is designed to be more user-friendly than more conventional text viewers such as less. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cTjA4oh0Lwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957436] Review Request: lookat - User-Friendly Text File Viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957436 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rpJS12Ol1na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879932] Review Request: SocketW - It is a streaming socket C++ library designed to be easy to use
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879932 --- Comment #5 from Volker Fröhlich volke...@gmx.at --- The latest SRPM is not available. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hfUHobhWNMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879932] Review Request: SocketW - It is a streaming socket C++ library designed to be easy to use
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879932 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Sorry. Reuploaded. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=drjndNpQCaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950296] Review Request: repsurgeon - A tool for doing surgical operations on repositories
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=950296 --- Comment #3 from Christopher Meng cicku...@gmail.com --- New upstream release again: Spec URL: http://cicku.me/reposurgeon.spec SRPM URL: http://cicku.me/reposurgeon-2.37-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qDvX2yjkpaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928541 --- Comment #3 from Juan Orti Alcaine juan.o...@miceliux.com --- (In reply to comment #2) Issues: === - Large documentation must go in a -doc subpackage. Note: Documentation size is 1105920 bytes in 158 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Please build the documentation in HTML, on %build, after you may delete file hidden (.buildinfo). In %doc, remove docs, and write docs/path/folder/built. Regards! Thank you for your comment. I have created the doc subpackage. Spec URL: http://jorti.fedorapeople.org/stem/python-stem.spec SRPM URL: http://jorti.fedorapeople.org/stem/python-stem-1.0.1-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UXirVpYwoZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956304] Review Request: fts - File Transfer Service V3
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956304 Dominik 'Rathann' Mierzejewski domi...@greysector.net changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #1 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Taking this review. I will sponsor Michał. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DkevnncFi1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879932] Review Request: SocketW - It is a streaming socket C++ library designed to be easy to use
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879932 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lmQFFPfBcja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957465] New: Review Request: minised - A smaller, cheaper, faster SED implementation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957465 Bug ID: 957465 Summary: Review Request: minised - A smaller, cheaper, faster SED implementation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://cicku.me/minised.spec SRPM URL: http://cicku.me/minised-1.14-1.fc20.src.rpm Description: This is a smaller, cheaper, faster SED implementation. Minix uses it. GNU used to use it, until they built their own sed around an extended (some would say over-extended) regexp package. For embedded use we searched for a tiny sed implementation especially for use with the dietlibc and found Eric S. Raymond's sed implementation quite handy. Though it suffered several bugs and was not under active maintenance anymore. After sending a bunch of fixes we agreed to continue maintaining this lovely, historic sed implementation. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9b5OLwtXWga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957465] Review Request: minised - A smaller, cheaper, faster SED implementation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957465 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gvuVLgxm8ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957466] New: Review Request: perl-Test-FailWarnings - Add test failures if warnings are caught
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957466
Bug ID: 957466
Summary: Review Request: perl-Test-FailWarnings - Add test
failures if warnings are caught
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: emman...@seyman.fr
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Category: ---
Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings-0.003-1.fc18.src.rpm
Description:
This module hooks $SIG{__WARN__} and converts warnings to Test::More's
fail() calls. It is designed to be used with done_testing, when you don't
need to know the test count in advance.
Fedora Account System Username: eseyman
Builds in mock; rpmlint is silent.
This package is needed to update perl-Test-Type to the latest version.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nTbw9YKBvia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #42 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #41)
Brendan:
No translations found for --with-qt in
/home/bsjones/rpmbuild/BUILDROOT/razorqt-0.5.2-4.fc18.x86_64
Your %find_lang syntax is wrong, the order of the parameters matters.
Try:
%find_lang razorqt --with-qt --without-mo
You tested too old sources.
http://tieugene.fedorapeople.org/rpms/razorqt.lang/razorqt-0.5.2-6.spec :
for i in `cat %{SOURCE1}`; do %find_lang $i --with-qt --without-mo; done
%files autosuspend -f razor-autosuspend.lang -f
razor-config-autosuspend.lang
This is not going to work, you can use only one -f file.
1. As for
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Handling_Locale_Files
:
%files -f %{name}.lang -f bar.lang
2. Anyway - I tried to add lang to lib subpackage:
%fileslibs -f librazorqt.lang
And no one can find this library.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=qLM1bP8lzba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957471] New: Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957471 Bug ID: 957471 Summary: Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://cicku.me/ssh-installkeys.spec SRPM URL: http://cicku.me/ssh-installkeys-1.8-1.fc20.src.rpm Description: This script tries to export ssh public keys to a specified site. It will walk you through generating key pairs if it doesn't find any to export. It handles all the fiddly details like making sure local and remote permissions are correct, and tells you what it's doing if it has to change anything. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6iY3ppTGHBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957471 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6KKhiE1j2Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879932] Review Request: SocketW - It is a streaming socket C++ library designed to be easy to use
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879932
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from Volker Fröhlich volke...@gmx.at ---
That piece of software is from 2003. I can see you're packaging it because
rigsofrods requires it, but I'm a bit skeptic. It might be worth convincing
upstream to turn away from it.
Try to preserve the header timestamps by adding -p to install -c -m 644 *.h
$(PREFIX_H) in src/Makefile
There's a compiler warning you might be able to solve. The exit call in the
library and the outdated FSF postal address in the license file should also be
addressed upstream. Given the age of this library, that's probably hopeless.
You could use the name macro for the patches.
Consider to wrap the long changelog lines
Scriptlets (post, postun) are commonly placed after the install section, but
that's probably just convention.
APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
PPC and ARM succeed
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated, *No copyright* LGPL (v2.1 or later). 2 files
have unknown license. Detailed output of licensecheck in /home/makerpm
/review-SocketW/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 133120 bytes in 19 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds
[Bug 875692] Review Request: karaf - A lightweight OSGi based run-time
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875692 --- Comment #1 from gil cattaneo punto...@libero.it --- This version require jline2 = 2.5, newer relase requires apache aries = 1.0.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W22hKLGrqna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956304] Review Request: fts - File Transfer Service V3
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956304
Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|domi...@greysector.net
--- Comment #2 from Dominik 'Rathann' Mierzejewski domi...@greysector.net ---
Initial comments:
0. Is this package EPEL-only? I see chkconfig and service command usage, but no
corresponding SystemD commands.
1. Package doesn't build in EPEL-6 x86_64 mock:
cd /builddir/build/BUILD/fts-0.0.1/build/src/common /usr/lib64/ccache/c++
-Dfts_common_EXPORTS -DWITH_IPV6 -DOPENSSL_THREADS -DWITH_OPE
NSSL -DNDEBUG -DSOCKET_CLOSE_ON_EXIT -D_REENTRANT
-DBOOST_DATE_TIME_HAS_REENTRANT_STD_FUNCTIONS -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -
fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-findirect-inlining -ftree-switch-conversion -ftree-builtin-ca
ll-dce -fconserve-stack -Wno-long-long -Wconversion -Wuninitialized
-Wno-deprecated-declarations -fno-strict-aliasing -Wextra -Wall -D_FOR
TIFY_SOURCE=2 -fstack-protector-all -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -O3 -DNDEBUG -fPIC
-I/builddir/build/BUILD/fts-0.0.1/build/
src/common -I/builddir/build/BUILD/fts-0.0.1/src/common
-I/builddir/build/BUILD/fts-0.0.1/src
-I/builddir/build/BUILD/fts-0.0.1/build/src -I
/builddir/build/BUILD/fts-0.0.1/src/common/. -o
CMakeFiles/fts_common.dir/producer.cpp.o -c
/builddir/build/BUILD/fts-0.0.1/src/common/pro
ducer.cpp
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: In function 'void
cancelTransfer()':
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:300: error:
'gfal2_cancel' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: At global scope:
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:484: error: ISO C++
forbids declaration of 'gfalt_event_t' with no type
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:484: error: expected ','
or '...' before 'e'
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: In function 'void
event_logger(int)':
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:489: error: 'e' was not
declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:491: error: 'udata' was
not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:502: error:
'GFAL_EVENT_TRANSFER_ENTER' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:505: error:
'GFAL_EVENT_TRANSFER_EXIT' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:510: error:
'GFAL_EVENT_CHECKSUM_ENTER' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:510: error:
'GFAL_EVENT_SOURCE' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:512: error:
'GFAL_EVENT_CHECKSUM_EXIT' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:515: error:
'GFAL_EVENT_DESTINATION' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:520: error:
'GFAL_EVENT_PREPARE_ENTER' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:522: error:
'GFAL_EVENT_PREPARE_EXIT' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:525: error:
'GFAL_EVENT_CLOSE_ENTER' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:527: error:
'GFAL_EVENT_CLOSE_EXIT' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: At global scope:
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:484: warning: unused
parameter 'gfalt_event_t'
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp: In function 'int
main(int, char**)':
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:723: error:
'gfalt_set_event_callback' was not declared in this scope
/builddir/build/BUILD/fts-0.0.1/src/url-copy/main.cpp:1127: error:
'gfal2_release_file' was not declared in this scope
make[2]: *** [src/url-copy/CMakeFiles/fts_url_copy.dir/main.cpp.o] Error 1
and there are missing build dependencies if I try to build on EPEL-5:
Error: No Package found for activemq-cpp-library
Error: No Package found for libcurl-devel
Error: No Package found for pugixml-devel
I suggest sorting the BuildRequires and Requires entries alphabetically for
easier maintenance.
2. Please explain the need to use these non-standard options for compilation:
-findirect-inlining -ftree-switch-conversion -ftree-builtin-call-dce
-fconserve-stack -fno-strict-aliasing
3. The descriptions of the (sub)packages are insufficient in detail and should
be more verbose.
4. %{python_sitearch}/fts seems to unowned.
5. I see several files in %{_docdir}/fts3. That's not a standard location for
documentation. Are these essential to the functioning of the software? Does
something
[Bug 956304] Review Request: fts - File Transfer Service V3
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956304 --- Comment #3 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Also, please start Release: numbering from 1. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FveaXqbIXFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956525] Review Request: xorg-x11-drv-opentegra - open source NVidia Tegra driver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956525 --- Comment #2 from Nicolas Chauvet (kwizart) kwiz...@gmail.com --- This is what should be changed in order to avoid the 00-opentegra.conf http://gitorious.org/thierryreding/xserver/commit/184335e5442bb347cea5d4599da88c74562d0c4d -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a7ObZIUkgpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955781] Review Request: datagrepper - A webapp to query fedmsg history
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=955781 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #1 from Michael Scherer m...@zarb.org --- Hi, python policy requires to be explicit on python version for -devel ( ie python2-devel, or python3-devel ) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jnQmggQC32a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #43 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #41)
Then you can use:
%files autosuspend -f razor-autosuspend.lang
and everything will work fine.
Trivial test (for http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec):
code
--- razorqt.spec.orig2013-04-28 14:09:01.752525655 +0400
+++ razorqt.spec2013-04-28 15:11:08.544630933 +0400
@@ -522,9 +522,9 @@
%{_datadir}/razor/razor-power/
%{_datadir}/applications/razor-power.desktop
-%files runner
+%files runner -f razor-runner.lang
%{_bindir}/razor-runner
-%{_datadir}/razor/razor-runner/
+%dir %{_datadir}/razor/razor-runner/
%{_sysconfdir}/xdg/autostart/razor-runner.desktop
%files session
/code
Result:
Error: Package: razorqt-0.5.2-5.fc18.i686 (/razorqt-0.5.2-5.fc18.i686)
Requires: razorqt-runner = 0.5.2-5.fc18
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=BfFvjvEjMJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821296] Review Request: drpython - python IDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821296 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #14 from Christopher Meng cicku...@gmail.com --- What's the current status? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cGB3bChmcVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837450] Review Request: android - Google Android Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837450 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #2 from Christopher Meng cicku...@gmail.com --- What's the current status? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eabZA9G5UYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870996] Review Request: osgi-resource-locator - OSGi resource locator bundle
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870996 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/osgi-resource-locator.spec SRPM URL: http://gil.fedorapeople.org/osgi-resource-locator-1.0.1-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KYV6ww7SYra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870997] Review Request: tiger-types - Type arithmetic library for Java5
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870997 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/tiger-types.spec SRPM URL: http://gil.fedorapeople.org/tiger-types-1.4-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7979ZpsEiXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954040] Review Request: libcangjie - CangJie Input Method Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954040 Michael Scherer m...@zarb.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Michael Scherer m...@zarb.org --- ok, seems good, so approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OuLnsAJhTBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821296] Review Request: drpython - python IDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821296 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added CC|ser...@serjux.com | --- Comment #15 from Sergio Monteiro Basto ser...@serjux.com --- I'm out for now -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8f1sUc6faHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954040] Review Request: libcangjie - CangJie Input Method Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954040 Mathieu Bridon boche...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Mathieu Bridon boche...@fedoraproject.org --- Thanks for the review Michael! New Package SCM Request === Package Name: libcangjie Short Description: CangJie Input Method Library Owners: bochecha Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k27hExSgW6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955781] Review Request: datagrepper - A webapp to query fedmsg history
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=955781
Michael Scherer m...@zarb.org changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|m...@zarb.org
Flags||fedora-review?
--- Comment #2 from Michael Scherer m...@zarb.org ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
- Config file not marked as noreplace
- missing License in tarball, should be asked upstream
- why does it have his own user created in %post ?
- no need for macro pyver and python_sitelib since that's supported on RHEL6
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 8 files have unknown license. Detailed output of
licensecheck in
/home/misc/checkout/git/FedoraReview/955781-datagrepper/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/datagrepper/
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BVmbbOCaJLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871018] Review Request: glassfish-hk2 - Hundred Kilobytes Kernel
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871018 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/glassfish-hk2.spec SRPM URL: http://gil.fedorapeople.org/glassfish-hk2-2.1.92-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fPcWyxiwuXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837450] Review Request: android - Google Android Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837450 --- Comment #3 from gil cattaneo punto...@libero.it --- sorry i dont understand your question regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cwBQXVfwMYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837450] Review Request: android - Google Android Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837450 --- Comment #4 from Christopher Meng cicku...@gmail.com --- (In reply to comment #3) sorry i dont understand your question regards I mean has someone reviewed your ticket? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pMrinsaS8va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949302] Review Request:python-optcomplete - Shell Completion Self-Generator for Python
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=949302
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5310234
$ rpmlint -i -v *
python3-optcomplete.noarch: I: checking
python3-optcomplete.noarch: W: spelling-error %description -l en_US optparse -
opt parse, opt-parse, sparse
The value of this tag appears to be misspelled. Please double-check.
python3-optcomplete.noarch: I: checking-url http://furius.ca/optcomplete
(timeout 10 seconds)
python-optcomplete.src: I: checking
python-optcomplete.src: W: spelling-error %description -l en_US optparse - opt
parse, opt-parse, sparse
The value of this tag appears to be misspelled. Please double-check.
python-optcomplete.src: I: checking-url http://furius.ca/optcomplete (timeout
10 seconds)
python-optcomplete.src: W: invalid-url Source0: python-optcomplete-1.2.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
python-optcomplete.noarch: I: checking
python-optcomplete.noarch: W: spelling-error %description -l en_US optparse -
opt parse, opt-parse, sparse
The value of this tag appears to be misspelled. Please double-check.
python-optcomplete.noarch: I: checking-url http://furius.ca/optcomplete
(timeout 10 seconds)
python-optcomplete.spec: W: invalid-url Source0: python-optcomplete-1.2.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
3 packages and 1 specfiles checked; 0 errors, 5 warnings.
The same as for the initial package version.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Dropped from the package, the tarball ships the GPL instead of BSD.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
The checksums differ, but this is a common problem with Mercurial or any other
VCS checkouts.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a
[Bug 837450] Review Request: android - Google Android Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837450 --- Comment #5 from gil cattaneo punto...@libero.it --- no, until now. thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xsXGiK1RBYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] New: Review Request: rf - read feeds from any source
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957520 Bug ID: 957520 Summary: Review Request: rf - read feeds from any source Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: juanmabcm...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://juanmabc.fedorapeople.org/packages/rf/rf.spec SRPM URL: http://juanmabc.fedorapeople.org/packages/rf/rf-0.4.12-1.fc18.src.rpm Description: command line scriptable feed reader with default feeds ( http://code.google.com/p/readfeed ) Fedora Account System Username: juanmabc -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L1dC98iyy7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957527] New: Review Request: unifying-receiver-udev - udev rules for user access to Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957527 Bug ID: 957527 Summary: Review Request: unifying-receiver-udev - udev rules for user access to Logitech Unifying Receiver Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: e...@brouhaha.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~brouhaha/unifying-receiver-udev/unifying-receiver-udev.spec SRPM URL: http://fedorapeople.org/~brouhaha/unifying-receiver-udev/unifying-receiver-udev-0.1-1.fc17.src.rpm Description: Udev rules to allow user access to the Logitech Unifying Receiver, e.g., for use with ltunify, pairing_tool, or Solaar. Fedora Account System Username: brouhaha This package is intended for use with ltunify and solaar packages, review requests for which are being separately submitted. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8lKx07aXjra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bjSaT9uuRua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871203] Review Request: console-bridge - Lightweight set of macros used for reporting information in libraries
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871203 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- console-bridge-0.1.4-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/console-bridge-0.1.4-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aknYkjGtKva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957529] New: Review Request: solaar - Device manager for Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957529 Bug ID: 957529 Summary: Review Request: solaar - Device manager for Logitech Unifying Receiver Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: e...@brouhaha.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~brouhaha/solaar/solaar.spec SRPM URL: http://fedorapeople.org/~brouhaha/solaar/solaar-0.8.7-1.fc17.src.rpm Description: Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals. It is able to pair/unpair devices to the receiver, and for most devices read battery status. It comes in two flavors, command-line and GUI. Both are able to list the devices paired to a Unifying Receiver, show detailed info for each device, and also pair/unpair supported devices with the receiver. Fedora Account System Username: brouhaha Spec has a dependency on unifying-receiver-udev package, for which review request #957527 has been separately submitted. However, it is also possible to force installation of the solaar package without the unifying-receiver-udev package (using the --nodeps option to rpm), and to run the solaar-cli utility as root. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TmxqKxWfbsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108
--- Comment #5 from Antonio Trande anto.tra...@gmail.com ---
- 'libjpeg-turbo-devel' is missing among BuildRequires
- Your package doesn't build in mock on rawhide, it needs 'automake17'.
Also,
- there are some warnings during configure tasks:
configure.in:34: installing './config.guess'
configure.in:34: installing './config.sub'
configure.in:30: installing './install-sh'
configure.in:30: installing './missing'
Makefile.am: installing './INSTALL'
Makefile.am: installing './COPYING' using GNU General Public License v3 file
Makefile.am: Consider adding the COPYING file to the version control system
Makefile.am: for your code, to avoid questions about which license your
project uses
gap/Makefile.am: installing './depcomp'
Symlinking file mkinstalldirs
Symlinking file po/Makefile.in.in
Please add the files
codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
progtest.m4
from the /usr/share/aclocal directory to your autoconf macro directory
or directly to your aclocal.m4 file.
You will also need config.guess and config.sub, which you can get from
ftp://ftp.gnu.org/pub/gnu/config/.
checking for a BSD-compatible install... /usr/bin/install -c
...
These latest two points must be taken in consideration in my opinion,
especially for next rebuildings. You should re-configure locally makefile
instead to use autogen.sh that runs --configure-- command already before
%configure macro during RPM building.
- %{_datadir}/locale/*/*/*
It is not necessary when you already use %files -f gimp20-gap.lang
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nuoi3kLKmUa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957528] New: Review Request: ltunify - Command line utility for Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957528 Bug ID: 957528 Summary: Review Request: ltunify - Command line utility for Logitech Unifying Receiver Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: e...@brouhaha.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~brouhaha/ltunify/ltunify.spec SRPM URL: http://fedorapeople.org/~brouhaha/ltunify/ltunify-0.1-1.fc17.src.rpm Description: ltunify allows pairing, unpairing, and listing information about devices uses a Logitech Unifying Receiver. Fedora Account System Username: brouhaha Spec has a dependency on unifying-receiver-udev package, for which review request #957527 has been separately submitted. However, it is also possible to force installation of the ltunify package without the unifying-receiver-udev package (using the --nodeps option to rpm), and to run the utility as root. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZdGiUTRV9Da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885833] Review Request: tw - translate words into different languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885833 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- tw-0.9.16-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/tw-0.9.16-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LXCwdjYBnQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885833] Review Request: tw - translate words into different languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885833 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- tw-0.9.16-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/tw-0.9.16-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9He3s04pspa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885833] Review Request: tw - translate words into different languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885833 --- Comment #37 from Fedora Update System upda...@fedoraproject.org --- tw-0.9.16-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/tw-0.9.16-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kM0RtGxMDwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 689476] Review Request: dvipng114 - Converts DVI files to PNG/GIF format
Product: Fedora EPEL https://bugzilla.redhat.com/show_bug.cgi?id=689476 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added CC||package-review@lists.fedora ||project.org Component|Package Review |Package Review Version|rawhide |el5 Product|Fedora |Fedora EPEL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TNiraSDF1Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717473] Review Request: SeqAn - Biological sequence analysis library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=717473 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flags||needinfo?(bl...@verdurin.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fjQLicMxFMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956931] Review Request: homerun - Application Launcher for KDE
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956931
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
BuildRequires: gettext-devel
For getting the translated *.mo files, an application usually doesn't need
gettext-devel. Just gettext should be sufficient here.
%{_kde4_appsdir}/plasma/
This folder is already owned by kdelibs and kde-workspace. Are there reasons to
let co-own this folder by your package? If not, add a * at the end of the line
to get ownership only for the folder contents.
%{_kde4_libdir}/libhomerun.so.0
%{_kde4_libdir}/libhomerun.so.0.0.0
Would it make sense to provide a -libs package which contain these files?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=U7prVUUY2Wa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928541 --- Comment #4 from Yohan Graterol yohangratero...@gmail.com --- Your package have a fail! = SHOULD items = Generic: [!]: Uses parallel make. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w5qhr6JrFLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957529] Review Request: solaar - Device manager for Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957529 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED CC||susi.leht...@iki.fi Assignee|nob...@fedoraproject.org|susi.leht...@iki.fi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=odFmvO1mlsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957527] Review Request: unifying-receiver-udev - udev rules for user access to Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957527 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED CC||susi.leht...@iki.fi Assignee|nob...@fedoraproject.org|susi.leht...@iki.fi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EovMJqw4zPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957528] Review Request: ltunify - Command line utility for Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957528 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED CC||susi.leht...@iki.fi Assignee|nob...@fedoraproject.org|susi.leht...@iki.fi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l2FcaTcDHVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957529] Review Request: solaar - Device manager for Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957529 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qfN39GwYTga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957527] Review Request: unifying-receiver-udev - udev rules for user access to Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957527 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mb3GycXThSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957528] Review Request: ltunify - Command line utility for Logitech Unifying Receiver
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957528 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nAHOtCNUtza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917329] Review Request: python-listquote - Functions for Lists, Quotes and CSVs
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=917329
--- Comment #9 from Yohan Graterol yohangratero...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live
[Bug 917329] Review Request: python-listquote - Functions for Lists, Quotes and CSVs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917329 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jZGXJoqD7aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917329] Review Request: python-listquote - Functions for Lists, Quotes and CSVs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917329 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EDHUQiaMy2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928541 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TsmSOHVomla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QQ1D5rkGxra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=916432
--- Comment #6 from Yohan Graterol yohangratero...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 5 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D1WYT3qnN9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917329] Review Request: python-listquote - Functions for Lists, Quotes and CSVs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917329 Conrad Meyer kon...@tylerc.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Conrad Meyer kon...@tylerc.org --- Thanks, Yohan! New Package SCM Request === Package Name: python-listquote Short Description: Functions for Lists, Quotes and CSVs Owners: konradm Branches: f19 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TQCxC6IoW8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928541 --- Comment #5 from Juan Orti Alcaine juan.o...@miceliux.com --- Updated for parallel make Spec URL: http://jorti.fedorapeople.org/stem/python-stem.spec SRPM URL: http://jorti.fedorapeople.org/stem/python-stem-1.0.1-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KdUpamjcera=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885833] Review Request: tw - translate words into different languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885833 --- Comment #38 from Kevin Kofler ke...@tigcc.ticalc.org --- Please DO NOT reference the review request on every single update of the package. Doing so only makes sense for the initial newpackage update. Once the package is in (i.e. the initial update is pushed), the review request is closed and further updates need not and should not reference it anymore. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aWheloxGDRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=928541
--- Comment #6 from Yohan Graterol yohangratero...@gmail.com ---
Juan, here is the formal review.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-stem , python-stem-doc
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928541 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tEptr7JG6Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] New: Review Request: base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 Bug ID: 957544 Summary: Review Request: base64 - Java class for encoding and decoding Base64 notation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://gil.fedorapeople.org/base64.spec SRPM URL: http://gil.fedorapeople.org/base64-2.3.8-1.fc18.src.rpm Description: Base64 is a Public Domain Java class for encoding and decoding Base64 notation. There are one-liner convenience methods as well as Input and Output Streams. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eIy184lgCKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||957544 --- Comment #18 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/java-xmlbuilder.spec SRPM URL: http://gil.fedorapeople.org/java-xmlbuilder-0.6-1.fc18.src.rpm - update to 0.6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c8tsjlvqhQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||836945 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lb26v2gSO0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 732577] Review Request: c-icap - An icap server implementation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=732577 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2013-04-28 18:43:46 --- Comment #4 from Jason Tibbitts ti...@math.uh.edu --- No response in ages; I'm just going to close this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eB7mvbPpWta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956737] Review Request: recoverjpeg - Recover jpeg pictures and mov movies from damaged devices
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956737 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added CC||m...@fabian-affolter.ch Blocks||563471 (FE-SECLAB) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QKLVM5qxgqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 758472] Review Request: Equalizer - Middleware to create and deploy parallel OpenGL-based applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=758472 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flags||needinfo?(jskarvad@redhat.c ||om) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qMkxnkhZSaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 768662] Review Request: DWFToolkit - DWF Toolkit provides APIs for reading and writing 3D DWF from any application
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=768662 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Whiteboard||BuildFails -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0ReDzEEEa3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770765] Review Request: python3-modgrammar - Modular grammar-parsing engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=770765 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u4AjXtcvq3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769958] Review Request: eqp - Automated theorem prover for first-order equational logic
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=769958 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #7 from Jason Tibbitts ti...@math.uh.edu --- As far as I can tell, this is still blocked on legal issues, so adding the FE-Legal blocker. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fbAEovKU6ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=657w0XSJLpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- pyode-1.2.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kx83fP7MPLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- pyode-1.2.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=88vhpYF7Bva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- pyode-1.2.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sWd9deGOy4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- pyode-1.2.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nN3YjCkMksa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949302] Review Request:python-optcomplete - Shell Completion Self-Generator for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949302 --- Comment #4 from Orion Poplawski or...@cora.nwra.com --- * Sun Apr 28 2013 Orion Poplawski or...@cora.nwra.com - 1.2-0.3.20130428hg9583af7 - Update to latest hg version - Re-add COPYING http://www.cora.nwra.com/~orion/fedora/python-optcomplete-1.2-0.3.20130428hg9583af7.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=swbU7e2Mxza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949302] Review Request:python-optcomplete - Shell Completion Self-Generator for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949302 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Orion Poplawski or...@cora.nwra.com --- New Package SCM Request === Package Name: python-optcomplete Short Description: Shell Completion Self-Generator for Python Owners: orion Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lf3u3DGgpRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] New: Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 Bug ID: 957568 Summary: Review Request: python-carddav - Python CardDAV client compatible with mutt Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: puiterw...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://puiterwijk.fedorapeople.org//python-carddav.spec SRPM URL: http://puiterwijk.fedorapeople.org//python-carddav-0.4.1-1.fc18.src.rpm Description: Python library and front-end for syncing CardDAV -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZNc9c4koEOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5311136 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JCKCZmugpZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927877] Review Request: naga - Simplified Java NIO asynchronous sockets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927877 Eric Smith e...@brouhaha.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||e...@brouhaha.com Assignee|nob...@fedoraproject.org|e...@brouhaha.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rzLjCcESIpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927879] Review Request: jspecview - JAVA applets for the display of JCAMP-DX and AnIML/CML spectral files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927879 Eric Smith e...@brouhaha.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||e...@brouhaha.com Assignee|nob...@fedoraproject.org|e...@brouhaha.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bqZX5Kk6gOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951582] Review Request: psi4 - An ab initio quantum chemistry package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951582 Eric Smith e...@brouhaha.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||e...@brouhaha.com Assignee|nob...@fedoraproject.org|e...@brouhaha.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vHB00PGb8Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892988] Review Request: linenoise - Minimal replacement for readline
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892988 --- Comment #8 from Dan Callaghan dcall...@redhat.com --- (In reply to comment #7) please also build this package on F18 Sure thing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zIlMFhxsP4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892988] Review Request: linenoise - Minimal replacement for readline
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892988 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- linenoise-0-3.git7946e2c.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/linenoise-0-3.git7946e2c.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J0pSpFE0Lda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947450] Review Request: perl-ExtUtils-Helpers - Various portability utilities for module builders
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947450 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-28 23:24:27 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QFS50Gdoija=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947450] Review Request: perl-ExtUtils-Helpers - Various portability utilities for module builders
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947450 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-ExtUtils-Helpers-0.019-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UWxW07Lcz3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947455] Review Request: perl-Module-Build-Tiny - A tiny replacement for Module::Build
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947455 Bug 947455 depends on bug 947450, which changed state. Bug 947450 Summary: Review Request: perl-ExtUtils-Helpers - Various portability utilities for module builders https://bugzilla.redhat.com/show_bug.cgi?id=947450 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4fcOeuSyJpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947453] Review Request: perl-ExtUtils-BuildRC - A reader for Build.PL configuration files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947453 Bug 947453 depends on bug 947450, which changed state. Bug 947450 Summary: Review Request: perl-ExtUtils-Helpers - Various portability utilities for module builders https://bugzilla.redhat.com/show_bug.cgi?id=947450 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lrbH1fbtZwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891461] Review Request: phantomjs - Headless WebKit with a JavaScript API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891461 --- Comment #14 from Sergio Monteiro Basto ser...@serjux.com --- Hi , I try do more work on this phantomjs, but not finish so we should add : +BuildRequires: qcommandline-devel +BuildRequires: linenoise-devel +BuildRequires: coffee-script +# remove source bundle +rm -rf src/qt +rm -rf src/qcommandline +rm -rf src/linenoise +rm -rf src/ghostdriver +rm -rf src/breakpad +rm -rf src/coffee-script +#rm -rf src/mongoose and patch with backup help on update the patch for new releases +%patch1 -p1 -b .giflib +%patch2 -p1 -b .mongoose +%patch3 -p1 -b .breakpad +%patch4 -p1 -b .qt +%patch5 -p1 -b .gifwriter I upload my state of art to http://www.serjux.com/phantomjs/stateofart/ maybe just next week I continue -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1RHm8H1rsba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957573] New: Review Request: php-aws-sdk - amazon web services sdk for php
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957573 Bug ID: 957573 Summary: Review Request: php-aws-sdk - amazon web services sdk for php Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jmarr...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://jmarrero.fedorapeople.org/packages/php-aws-sdk/php-aws-sdk.spec SRPM URL: http://jmarrero.fedorapeople.org/packages/php-aws-sdk/php-aws-sdk-1.6.2-1.fc19.src.rpm Description: Amazon webservices framework for php Fedora Account System Username: jmarrero -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xUi2iETVTza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955781] Review Request: datagrepper - A webapp to query fedmsg history
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=955781 --- Comment #3 from Ralph Bean rb...@redhat.com --- In response to one of the comments: - why does it have his own user created in %post ? This is so that mod_wsgi can run processes as this user. This is for separation for security, so that if one mod_wsgi process is compromised, it cannot as easily access data available to other web applications on the same server. The other comments look correct and should be easy to fix in a second review release. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O9H9i52puRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957573] Review Request: php-aws-sdk - amazon web services sdk for php
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957573 --- Comment #1 from Joseph Marrero jmarr...@gmail.com --- successful koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5311290 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3aKb8FrrPva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956066] Review Request: python-gevent-websocket - Websocket handler for the gevent pywsgi server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956066 --- Comment #2 from Matej Stuchlik mstuc...@redhat.com --- Missing python-setuptools from BuildRequires, seems fine otherwise. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n4ZrQ5IDX0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
