[Bug 910237] Review Request: php-horde-Horde-Itip - iTip invitation response handling
https://bugzilla.redhat.com/show_bug.cgi?id=910237 --- Comment #2 from Remi Collet fed...@famillecollet.com --- Update to 2.0.5 Spec: https://raw.github.com/remicollet/remirepo/7906b53830a1d2b0e6be890bac80d6357a9730ed/php/horde/php-horde-Horde-Itip/php-horde-Horde-Itip.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Itip-2.0.5-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mDvAuisfcUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962651] Re-Review Request: bamf - Application matching framework
https://bugzilla.redhat.com/show_bug.cgi?id=962651 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Flags||needinfo? --- Comment #5 from Michel Alexandre Salim michel+...@sylvestre.me --- Hi both, bamf 0.3.6 requires Vala 0.20, which is why it does not build on F18. Do you want to just base the review on bamf 0.3.6? I won't do a major update on F18 as it's already released, and we don't want to break dependent apps (in this case gnome-pie), we just need to get bamf unblocked so we can actually build gnome-pie against it Could one of you do a formal review? Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lu5KqYK7WLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949038] Review Request: php-horde-horde - Horde Application Framework
https://bugzilla.redhat.com/show_bug.cgi?id=949038 --- Comment #2 from Remi Collet fed...@famillecollet.com --- Update to 5.0.5 Spec: https://github.com/remicollet/remirepo/blob/8e963fbb8b3fb7321d778668d080f77c27b312aa/php/horde/php-horde-horde/php-horde-horde.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-horde-5.0.5-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WHUUXgv6cba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 861498] Review Request: jdbi - A SQL convenience library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=861498 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/jdbi.spec SRPM URL: http://gil.fedorapeople.org/jdbi-2.49-1.fc18.src.rpm - update to 2.49 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JNDSP8vX4ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821283] Review Request: gsbase - A collection of java utility classes
https://bugzilla.redhat.com/show_bug.cgi?id=821283 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: gsbase Short Description: A collection of java utility classes Owners: gil Branches: f18 f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5cxQVdy2Aha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967401] Review Request: vmtouch - Portable file system cache diagnostics and control
https://bugzilla.redhat.com/show_bug.cgi?id=967401
--- Comment #2 from Robin Lee robinlee.s...@gmail.com ---
(In reply to Douglas Schilling Landgraf from comment #1)
Hi Robin,
I have few questions:
1)
BuildRequires: /usr/bin/dos2unix
BuildRequires: /usr/bin/mac2unix
What about replace with:
BuildRequires: dos2unix ?
$ rpm -qf /usr/bin/dos2unix
dos2unix-6.0.1-1.fc18.x86_64
$ rpm -qf /usr/bin/mac2unix
dos2unix-6.0.1-1.fc18.x86_64
What I actually use are the two commands, I don't have to care about what
package that provides those commands. Yum would find out the package.
2)
%build
cc %{optflags} -o %{name} %{name}.c
Why not make %{?_smp_mflags} ?
https://fedoraproject.org/wiki/PackagingGuidelines#Parallel_make
Vmtouch is built from a single source file. And the upstream Makefile doesn't
accept optflags setting. So I compile it directly with cc.
Thanks
Douglas
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=v60R0qKbF6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969723] Review Request: tlsdate - Secure parasitic rdate replacement
https://bugzilla.redhat.com/show_bug.cgi?id=969723 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||puiterw...@gmail.com Assignee|nob...@fedoraproject.org|puiterw...@gmail.com --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- I will review this. My first finding is that you have packaged 0.0.7, but this is not yet released. Do you have the actual URL where you downloaded the archive from? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BhUYBz24iia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969723] Review Request: tlsdate - Secure parasitic rdate replacement
https://bugzilla.redhat.com/show_bug.cgi?id=969723 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added CC||pwout...@redhat.com Flags||needinfo?(pwouters@redhat.c ||om) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xRuFdqcYO8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969763] New: Review Request: taudem - Terrain Analysis Using Digital Elevation Models
https://bugzilla.redhat.com/show_bug.cgi?id=969763 Bug ID: 969763 Summary: Review Request: taudem - Terrain Analysis Using Digital Elevation Models Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: volke...@gmx.at QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://www.geofrogger.net/review/taudem.spec SRPM URL: http://www.geofrogger.net/review/taudem-5.2-1.fc18.src.rpm Description: TauDEM (Terrain Analysis Using Digital Elevation Models) is a suite of Digital Elevation Model (DEM) tools for the extraction and analysis of hydrologic information from topography as represented by a DEM. Fedora Account System Username: volter I'm not totally sure about the sub-package layout and the MPI naming suffix. There's no serial version and only one supported MPI implementation. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SGAiiN9JWRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969773] New: Review Request: deltaspike - Portable CDI extensions
https://bugzilla.redhat.com/show_bug.cgi?id=969773 Bug ID: 969773 Summary: Review Request: deltaspike - Portable CDI extensions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/deltaspike.spec SRPM URL: http://gil.fedorapeople.org/deltaspike-0.3-0.1.incubating.fc18.src.rpm Description: DeltaSpike consist of a number of portable CDI extensions that provide useful features for Java application developers. Fedora Account System Username: gil Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5453589 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LXk8O4wWosa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968136] Review Request: camel - Apache Camel integration framework
https://bugzilla.redhat.com/show_bug.cgi?id=968136 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||969773, 969769 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CXwKlULjcra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969773] Review Request: deltaspike - Portable CDI extensions
https://bugzilla.redhat.com/show_bug.cgi?id=969773 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||968136 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2XINao1gfMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969700] Review Request: libccp4 - Library providing specific CCP4 functionality
https://bugzilla.redhat.com/show_bug.cgi?id=969700 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- $ rpmlint -i -v * libccp4.src: I: checking libccp4.src: W: spelling-error %description -l en_US keyworded - key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US subcomponents - sub components, sub-components, subcontinents The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US datasets - data sets, data-sets, databases The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US centred - centered, cent red, cent-red The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US syminfo - misinform The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US sgtbx - Sgt The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US cctbx - CCTV The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US resizable - re sizable, re-sizable, resealable The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US resized - resided, re sized, re-sized The value of this tag appears to be misspelled. Please double-check. libccp4.src: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4.src:12: W: unversioned-explicit-obsoletes gpp4 The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. libccp4.src: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/libccp4-6.3.1.tar.gz (timeout 10 seconds) libccp4.i686: I: checking libccp4.i686: W: spelling-error %description -l en_US keyworded - key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US subcomponents - sub components, sub-components, subcontinents The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US datasets - data sets, data-sets, databases The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US centred - centered, cent red, cent-red The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US syminfo - misinform The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US sgtbx - Sgt The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US cctbx - CCTV The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US resizable - re sizable, re-sizable, resealable The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US resized - resided, re sized, re-sized The value of this tag appears to be misspelled. Please double-check. libccp4.i686: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4.i686: W: obsolete-not-provided gpp4 If a package is obsoleted by a compatible replacement, the obsoleted package should also be provided in order to not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the Provides. libccp4.i686: W: shared-lib-calls-exit /usr/lib/libccp4c.so.0.0.0 exit@GLIBC_2.0 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. libccp4.x86_64: I: checking libccp4.x86_64: W: spelling-error %description -l en_US keyworded - key worded, key-worded, keyword ed The value of this
[Bug 915864] Review Request: oat - Attestation Service Host Agent based on OpenAttestation SDK
https://bugzilla.redhat.com/show_bug.cgi?id=915864 --- Comment #38 from Gang Wei gang@intel.com --- New Package SCM Request === Package Name: oat Short Description: package for OpenAttestation project Owners: gwei3 Branches: f19 InitialCC: gwei3 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ALPPPtATVAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #16 from Mario Blättermann mario.blaetterm...@gmail.com --- Just a reminder... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0W3v1JU3rXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827101] Review Request: trayer-srg - a small gtk2 systray
https://bugzilla.redhat.com/show_bug.cgi?id=827101 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2013-06-02 06:39:15 --- Comment #12 from Mario Blättermann mario.blaetterm...@gmail.com --- This ticket seems to be dead, so I will close it now as FE-DEADREVIEW. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wKevuy3WC3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823227] Review Request: skype4py - Skype API wrapper for Python
https://bugzilla.redhat.com/show_bug.cgi?id=823227 --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to Peter Lemenkov from comment #1) I wonder how can this package be useful w/o Skype installed (which isn't available in Fedora for obvious reasons). Indeed, it doesn't work without Skype. But it needs python2-devel as a build requirement only. I think it will be merely a playground for developers who work with the Skype API, so it would be useful, though. Not for end users, admittedly, unless they install Skype itself. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0TNEDNVoGqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728956] Review Request: php-virt-control - PHP-based virtual machine controller tool
https://bugzilla.redhat.com/show_bug.cgi?id=728956 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||minov...@redhat.com Flags||needinfo?(minovotn@redhat.c ||om) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZsNULPavwaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858066] Review Request: mingw-qt5-qtgraphicaleffects - Qt5 for Windows - QtGraphicalEffects component
https://bugzilla.redhat.com/show_bug.cgi?id=858066 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Thanks for the review! New Package SCM Request === Package Name: mingw-qt5-qtgraphicaleffects Short Description: Qt5 for Windows - QtGraphicalEffects component Owners: epienbro Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=spm1OpdEtDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967357] Review Request: python-phyghtmap - Generate OSM contour lines from NASA SRTM data
https://bugzilla.redhat.com/show_bug.cgi?id=967357 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- python-devel is deprecated, use python2-devel instead: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires python-setuptools-devel is a virtual package which points to python-setuptools. Would be better to use the real one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nAnOoWF8MSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866260] Review Request: juel - Java Unified Expression Language Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=866260 gil cattaneo punto...@libero.it changed: What|Removed |Added Summary|Review Request: juel - Java |Review Request: juel - Java |Unified Expression Language |Unified Expression Language ||Implementation --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/juel.spec SRPM URL: http://gil.fedorapeople.org/juel-2.2.6-1.fc18.src.rpm - update to 2.2.6 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5453687 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qvm7JKvIVPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967289] Review Request: python-plyvel - Python interface to the LevelDB embedded database library
https://bugzilla.redhat.com/show_bug.cgi?id=967289
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5453670
$ rpmlint -i -v *
python3-plyvel.i686: I: checking
python3-plyvel.i686: I: checking-url https://github.com/wbolster/plyvel
(timeout 10 seconds)
python3-plyvel.x86_64: I: checking
python3-plyvel.x86_64: I: checking-url https://github.com/wbolster/plyvel
(timeout 10 seconds)
python-plyvel.src: I: checking
python-plyvel.src: I: checking-url https://github.com/wbolster/plyvel (timeout
10 seconds)
python-plyvel.src:85: W: macro-in-comment %else
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-plyvel.src:87: W: macro-in-comment %endif
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-plyvel.src: I: checking-url
http://pypi.python.org/packages/source/p/plyvel/plyvel-0.2.tar.gz (timeout 10
seconds)
python-plyvel.i686: I: checking
python-plyvel.i686: I: checking-url https://github.com/wbolster/plyvel (timeout
10 seconds)
python-plyvel.x86_64: I: checking
python-plyvel.x86_64: I: checking-url https://github.com/wbolster/plyvel
(timeout 10 seconds)
python-plyvel-debuginfo.i686: I: checking
python-plyvel-debuginfo.i686: I: checking-url
https://github.com/wbolster/plyvel (timeout 10 seconds)
python-plyvel-debuginfo.x86_64: I: checking
python-plyvel-debuginfo.x86_64: I: checking-url
https://github.com/wbolster/plyvel (timeout 10 seconds)
python-plyvel.spec:85: W: macro-in-comment %else
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-plyvel.spec:87: W: macro-in-comment %endif
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-plyvel.spec: I: checking-url
http://pypi.python.org/packages/source/p/plyvel/plyvel-0.2.tar.gz (timeout 10
seconds)
7 packages and 1 specfiles checked; 0 errors, 4 warnings.
Only the macro-in-comment warnings need to be fixed (not blocking the review)
by prepending a second %.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum *
aba7752e0401719bc60aeeda8e103a4eaf52e384e8c03d63d9a2f4835cbf08de
plyvel-0.2.tar.gz
aba7752e0401719bc60aeeda8e103a4eaf52e384e8c03d63d9a2f4835cbf08de
plyvel-0.2.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[Bug 964318] Review Request: python-vm-builder - Ubuntu's vmbuilder
https://bugzilla.redhat.com/show_bug.cgi?id=964318
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
python-devel is deprecated, use python2-devel instead:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
%build
# Remove CFLAGS=... for noarch packages (unneeded)
Well, it is convenient to use the spec template provided by rpmdev-newspec, but
you should consider to do what it proposes. Remove the CFLAGS statement because
your package is noarch.
%{_sysconfdir}/vmbuilder/* means your package doesn't own the folder, just the
containing files. Please use %{_sysconfdir}/vmbuilder to also own the folder.
The GPL forces us (and also upstream developers) to ship the license text
within a package. Please add the plain text version:
http://www.gnu.org/licenses/gpl.txt
Instead of repeating the summary once again, you could use a more specific
description from Launchpad:
Install virtual machines in a snap without ever actually booting a virtual
machine.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=p44a1Y9vkBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967357] Review Request: python-phyghtmap - Generate OSM contour lines from NASA SRTM data
https://bugzilla.redhat.com/show_bug.cgi?id=967357 --- Comment #3 from Volker Fröhlich volke...@gmx.at --- Thanks for noticing, updated: Spec URL: http://www.geofrogger.net/review/python-phyghtmap.spec SRPM URL: http://www.geofrogger.net/review/python-phyghtmap-1.45-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bneL0EfWwEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821296] Review Request: drpython - python IDE
https://bugzilla.redhat.com/show_bug.cgi?id=821296
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #16 from Mario Blättermann mario.blaetterm...@gmail.com ---
For SourceForge stuff, use the following download location:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.zip
See http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net for more
info.
python-devel is deprecated, use python2-devel instead:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
$ rpmlint -i -v *spec
drpython.spec:3: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 2)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
I recommend to use spaces only, then your spec looks the same in every text
editor.
BuildRequires:python
doesn't make sense, because we need the development files of Python
explicitely. Can be safely dropped from BR.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Ltqkc3wMOda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917191] Review Request: awake - A command to 'wake on LAN' a remote host
https://bugzilla.redhat.com/show_bug.cgi?id=917191 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #2 from Fabian Affolter m...@fabian-affolter.ch --- Thanks for the review, Björn. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hvgWqiYlgCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917191] Review Request: awake - A command to 'wake on LAN' a remote host
https://bugzilla.redhat.com/show_bug.cgi?id=917191 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Fabian Affolter m...@fabian-affolter.ch --- New Package SCM Request === Package Name: awake Short Description: A command to 'wake on LAN' a remote host Owners: fab Branches: F18 F19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UVXMFHCeTKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967403] Review Request: python-tvrage - Python client for the tvrage.com XML API
https://bugzilla.redhat.com/show_bug.cgi?id=967403 --- Comment #5 from Christopher Meng cicku...@gmail.com --- Fixed. NEW Spec URL: http://cicku.me/python-tvrage.spec NEW SRPM URL: http://cicku.me/python-tvrage-0.4.1-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l1DlkbZezIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745515] Review Request: yuicompressor - Tool that supports the compression of both JavaScript and CSS files
https://bugzilla.redhat.com/show_bug.cgi?id=745515 --- Comment #24 from Ville Skyttä ville.sky...@iki.fi --- The BuildRequires and Requires are still rhino = 1.7R3-2, should they be R4? At least when running on F-17 (with rhino-1.7R3-4.fc17.noarch), the test case noted in comment 1 still exhibits a bug, although a different one than before: $ echo /* hello */ | yuicompressor --type js Exception in thread main java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at com.yahoo.platform.yui.compressor.Bootstrap.main(Bootstrap.java:21) Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 at java.util.ArrayList.rangeCheck(ArrayList.java:604) at java.util.ArrayList.get(ArrayList.java:382) at com.yahoo.platform.yui.compressor.JavaScriptCompressor.getToken(JavaScriptCompressor.java:581) at com.yahoo.platform.yui.compressor.JavaScriptCompressor.printSymbolTree(JavaScriptCompressor.java:1097) at com.yahoo.platform.yui.compressor.JavaScriptCompressor.compress(JavaScriptCompressor.java:559) at com.yahoo.platform.yui.compressor.YUICompressor.main(YUICompressor.java:186) ... 5 more -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FvHmUVXs46a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745515] Review Request: yuicompressor - Tool that supports the compression of both JavaScript and CSS files
https://bugzilla.redhat.com/show_bug.cgi?id=745515 --- Comment #25 from Ville Skyttä ville.sky...@iki.fi --- Also, this version doesn't preserve the C-style comments starting with /*! as documented. The old 2.4.7 version I'm using locally does. https://github.com/yui/yuicompressor/blob/master/README.md $ cat t.js /*! Hello, this comment should be preserved. */ var a; $ yuicompressor t.js var a; -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G1tQok1P9Sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967357] Review Request: python-phyghtmap - Generate OSM contour lines from NASA SRTM data
https://bugzilla.redhat.com/show_bug.cgi?id=967357
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5453736
$ rpmlint -i -v *
python-phyghtmap.src: I: checking
python-phyghtmap.src: I: checking-url http://katze.tfiu.de/projects/phyghtmap/
(timeout 10 seconds)
python-phyghtmap.src: I: checking-url
http://katze.tfiu.de/projects/phyghtmap/phyghtmap_1.45.orig.tar.gz (timeout 10
seconds)
python-phyghtmap.noarch: I: checking
python-phyghtmap.noarch: E: explicit-lib-dependency python-matplotlib
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
python-phyghtmap.noarch: I: checking-url
http://katze.tfiu.de/projects/phyghtmap/ (timeout 10 seconds)
python-phyghtmap.spec: I: checking-url
http://katze.tfiu.de/projects/phyghtmap/phyghtmap_1.45.orig.tar.gz (timeout 10
seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
The error is ignorable, rpm didn't found this dependency automatically:
$ rpm -qpR python-phyghtmap-1.45-2.fc20.noarch.rpm
/usr/bin/python
numpy
python(abi) = 2.7
python-BeautifulSoup
python-matplotlib
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PartialHardlinkSets) = 4.0.4-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(PayloadIsXz) = 5.2-1
No further objections from my side.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum *
f820d5e367a8098ad6aae447b78166b049b87924ef97ff6fc74269ea21358387
phyghtmap_1.45.orig.tar.gz
f820d5e367a8098ad6aae447b78166b049b87924ef97ff6fc74269ea21358387
phyghtmap_1.45.orig.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A
[Bug 969812] New: Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Bug ID: 969812 Summary: Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://cicku.me/hg-git.spec SRPM URL: http://cicku.me/hg-git-0.4.0-1.fc20.src.rpm Description: This is the Hg-Git plugin for Mercurial, adding the ability to push and pull to/from a Git server repository from Hg. This means you can collaborate on Git based projects from Hg, or use a Git server as a collaboration point for a team with developers using both Git and Hg. It can also convert commits/changesets losslessly from one system to another, so you can push via an Hg repository and another Hg client can pull it and their changeset node ids will be identical - Mercurial data does not get lost in translation. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D8b5th37b0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967357] Review Request: python-phyghtmap - Generate OSM contour lines from NASA SRTM data
https://bugzilla.redhat.com/show_bug.cgi?id=967357 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Volker Fröhlich volke...@gmx.at --- Thank you, Mario! New Package SCM Request === Package Name: python-phyghtmap Short Description: Generate OSM contour lines from NASA SRTM data Owners: volter Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WNEVmM00B5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912048] Review Request: mpDris2 - Provide MPRIS 2 support to mpd
https://bugzilla.redhat.com/show_bug.cgi?id=912048 Gianluca Sforna gia...@gmail.com changed: What|Removed |Added CC||gia...@gmail.com Assignee|nob...@fedoraproject.org|gia...@gmail.com Flags||fedora-review? Status|NEW |ASSIGNED --- Comment #1 from Gianluca Sforna gia...@gmail.com --- A friend asked me to package this, since you already submitted it I will review this instead :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y4KkjCSf83a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967357] Review Request: python-phyghtmap - Generate OSM contour lines from NASA SRTM data
https://bugzilla.redhat.com/show_bug.cgi?id=967357 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flags|fedora-cvs? | --- Comment #6 from Volker Fröhlich volke...@gmx.at --- Hm, is that actually a module, thus it falls under the naming guideline of prefixing python-? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XUpToZjbrYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967357] Review Request: python-phyghtmap - Generate OSM contour lines from NASA SRTM data
https://bugzilla.redhat.com/show_bug.cgi?id=967357
--- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to Volker Fröhlich from comment #6)
Hm, is that actually a module, thus it falls under the naming guideline of
prefixing python-?
It stores files under %{python_sitelib} so I recognize it as a Python module.
Due to this structure other Python software can use it, too. Well, it has a
executable file in /usr/bin (which uses the underlying Python module anyway),
but this is secondary in this case.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fTgLnP7gjua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745515] Review Request: yuicompressor - Tool that supports the compression of both JavaScript and CSS files
https://bugzilla.redhat.com/show_bug.cgi?id=745515
--- Comment #26 from gil cattaneo punto...@libero.it ---
work fine also with rhino = 1.7R3, and i have intention of import also for F18
the errors seem caused by empty js file...
in my system work fine
yuicompressor --type js cssmin.js
var
YAHOO=YAHOO||{};YAHOO.compressor=YAHOO.compressor||{};YAHOO.compressor._extractDataUrls=function(i,d){var
g=i.length-1,l=0,n,h,a,e,k=[],c,b,f,j=/url\(\s*([']?)data\:/gi;while((c=j.exec(i))!==null){n=c.index+4;a=c[1];if(a.length===0){a=)}e=false;h=j.lastIndex-1;while(e===falseh+1=g){h=i.indexOf(a,h+1);if((h0)(i.charAt(h-1)!==\)){e=true;if()!=a){h=i.indexOf(),h)}}}k.push(i.substring(l,c.index));if(e){f=i.substring(n,h);f=f.replace(/\s+/g,);d.push(f);b=url(___YUICSSMIN_PRESERVED_TOKEN_+(d.length-1)+___);k.push(b);l=h+1}else{k.push(i.substring(c.index,j.lastIndex));l=j.lastIndex}}k.push(i.substring(l));return
k.join()};YAHOO.compressor._compressHexColors=function(d){var
e=/(\=\s*?[']?)?#([0-9a-f])([0-9a-f])([0-9a-f])([0-9a-f])([0-9a-f])([0-9a-f])(\}|[^0-9a-f{][^{]*?\})/gi,a,c=0,b,f=[];while((a=e.exec(d))!==null){f.push(d.substring(c,a.index));b=a[1];if(b){f.push(a[1]+#+(a[2]+a[3]+a[4]+a[5]+a[6]+a[7]))}else{if(a[2].toLowerCase()==a[3].toLowerCase()a[4].toLowerCase()==a[5].toLowerCase()a[6].toLowerCase()==a[7].toLowerCase()){f.push(#+(a[3]+a[5]+a[7]).toLowerCase())}else{f.push(#+(a[2]+a[3]+a[4]+a[5]+a[6]+a[7]).toLowerCase())}}c=e.lastIndex=e.lastIndex-a[8].length}f.push(d.substring(c));return
f.join()};YAHOO.compressor.cssmin=function(e,g){var
k=0,d=0,c=0,h=0,a=[],f=[],b=,l=e.length,j=;e=this._extractDataUrls(e,a);while((k=e.indexOf(/*,k))=0){d=e.indexOf(*/,k+2);if(d0){d=l}b=e.slice(k+2,d);f.push(b);e=e.slice(0,k+2)+___YUICSSMIN_PRESERVE_CANDIDATE_COMMENT_+(f.length-1)+___+e.slice(d);k+=2}e=e.replace(/(([^\\]|\\.|\\)*)|('([^\\']|\\.|\\)*')/g,function(o){var
p,m,n=o.substring(0,1);o=o.slice(1,-1);if(o.indexOf(___YUICSSMIN_PRESERVE_CANDIDATE_COMMENT_)=0){for(p=0,m=f.length;pm;p=p+1){o=o.replace(___YUICSSMIN_PRESERVE_CANDIDATE_COMMENT_+p+___,f[p])}}o=o.replace(/progid:DXImageTransform\.Microsoft\.Alpha\(Opacity=/gi,alpha(opacity=);a.push(o);return
n+___YUICSSMIN_PRESERVED_TOKEN_+(a.length-1)+___+n});for(c=0,h=f.length;ch;c=c+1){b=f[c];j=___YUICSSMIN_PRESERVE_CANDIDATE_COMMENT_+c+___;if(b.charAt(0)===!){a.push(b);e=e.replace(j,___YUICSSMIN_PRESERVED_TOKEN_+(a.length-1)+___);continue}if(b.charAt(b.length-1)===\){a.push(\);e=e.replace(j,___YUICSSMIN_PRESERVED_TOKEN_+(a.length-1)+___);c=c+1;a.push();e=e.replace(___YUICSSMIN_PRESERVE_CANDIDATE_COMMENT_+c+___,___YUICSSMIN_PRESERVED_TOKEN_+(a.length-1)+___);continue}if(b.length===0){k=e.indexOf(j);if(k2){if(e.charAt(k-3)===){a.push();e=e.replace(j,___YUICSSMIN_PRESERVED_TOKEN_+(a.length-1)+___)}}}e=e.replace(/*+j+*/,)}e=e.replace(/\s+/g,
);e=e.replace(/(^|\})(([^\{:])+:)+([^\{]*\{)/g,function(i){return
i.replace(:,___YUICSSMIN_PSEUDOCLASSCOLON___)});e=e.replace(/\s+([!{};:+\(\)\],])/g,$1);e=e.replace(/___YUICSSMIN_PSEUDOCLASSCOLON___/g,:);e=e.replace(/:first-(line|letter)(\{|,)/gi,function(m,i,n){return:first-+i.toLowerCase()+
+n});e=e.replace(/\*\/ /g,*/);e=e.replace(/^(.*)(@charset)(
[^]*;)/gi,function(m,i,o,n){return
o.toLowerCase()+n+i});e=e.replace(/^((\s*)(@charset)(
[^;]+;\s*))+/gi,function(m,i,p,o,n){return
p+o.toLowerCase()+n});e=e.replace(/\band\(/gi,and
();e=e.replace(/@(font-face|import|(?:-(?:atsc|khtml|moz|ms|o|wap|webkit)-)?keyframe|media|page|namespace)/gi,function(m,i){return@+i.toLowerCase()});e=e.replace(/:(active|after|before|checked|disabled|empty|enabled|first-(?:child|of-type)|focus|hover|last-(?:child|of-type)|link|only-(?:child|of-type)|root|:selection|target|visited)/gi,function(m,i){return:+i.toLowerCase()});e=e.replace(/:(lang|not|nth-child|nth-last-child|nth-last-of-type|nth-of-type|(?:-(?:moz|webkit)-)?any)\(/gi,function(m,i){return:+i.toLowerCase()+(});e=e.replace(/([:,\(
]\s*)(attr|color-stop|from|rgba|to|url|(?:-(?:atsc|khtml|moz|ms|o|wap|webkit)-)?(?:calc|max|min|(?:repeating-)?(?:linear|radial)-gradient)|-webkit-gradient)/gi,function(m,i,n){return
i+n.toLowerCase()});e=e.replace(/([!{}:;+\(\[,])\s+/g,$1);e=e.replace(/;+\}/g,});e=e.replace(/(^|[^0-9])(?:0?\.)?0(?:px|em|%|in|cm|mm|pc|pt|ex|deg|g?rad|m?s|k?hz)/gi,$10);e=e.replace(/:0
0 0 0(;|\})/g,:0$1);e=e.replace(/:0 0 0(;|\})/g,:0$1);e=e.replace(/:0
0(;|\})/g,:0$1);e=e.replace(/(background-position|transform-origin|webkit-transform-origin|moz-transform-origin|o-transform-origin|ms-transform-origin):0(;|\})/gi,function(m,n,i){return
n.toLowerCase()+:0
0+i});e=e.replace(/(:|\s)0+\.(\d+)/g,$1.$2);e=e.replace(/rgb\s*\(\s*([0-9,\s]+)\s*\)/gi,function(){var
[Bug 967403] Review Request: python-tvrage - Python client for the tvrage.com XML API
https://bugzilla.redhat.com/show_bug.cgi?id=967403
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5453845
$ rpmlint -i -v *
python-tvrage.noarch: I: checking
python-tvrage.noarch: W: spelling-error %description -l en_US com's - con's,
om's, come's
The value of this tag appears to be misspelled. Please double-check.
python-tvrage.noarch: W: spelling-error %description -l en_US api - pi, ape,
apt
The value of this tag appears to be misspelled. Please double-check.
python-tvrage.noarch: I: checking-url
https://pypi.python.org/pypi/python-tvrage (timeout 10 seconds)
python-tvrage.src: I: checking
python-tvrage.src: W: spelling-error %description -l en_US com's - con's,
om's, come's
The value of this tag appears to be misspelled. Please double-check.
python-tvrage.src: W: spelling-error %description -l en_US api - pi, ape, apt
The value of this tag appears to be misspelled. Please double-check.
python-tvrage.src: I: checking-url https://pypi.python.org/pypi/python-tvrage
(timeout 10 seconds)
python-tvrage.src: I: checking-url
https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz
(timeout 10 seconds)
python-tvrage.spec: I: checking-url
https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Nothing of interest anymore.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum *
f8a530376c5cf1bc573d1945a8504c3394b228c731a3eff5100c705997a72063
python-tvrage-0.4.1.tar.gz
f8a530376c5cf1bc573d1945a8504c3394b228c731a3eff5100c705997a72063
python-tvrage-0.4.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
[Bug 821455] Review Request: python-trml2pdf12 - Tiny RML2PDF is a tool to easily create PDF documents without programming
https://bugzilla.redhat.com/show_bug.cgi?id=821455 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- The spec file link is not usable. Please use a location which is directly downloadable, such as your Fedorapeople webspace, Dropbox or anything else. Or at least, the raw file link from GitHub: https://raw.github.com/ciupicri/rpmbuild/rename-egg/SPECS/python-trml2pdf12.spec The python-imaging package is actually deprecated, it is only provided virtually by python-pillow (and python3-pillow appropriately). Make sure your package works with Pillow. See http://fedoraproject.org/wiki/Features/Pillow for more information. There's an example patch which I've got last year for one of my packages (bug #895783). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LjHwUKE5AGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882481] Review Request: python-doit - Automation Tool
https://bugzilla.redhat.com/show_bug.cgi?id=882481 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #18 from Mario Blättermann mario.blaetterm...@gmail.com --- The files LICENSE and README should appear in both python2 and python3 versions. One can install them independently from each other, so the python3 package would remain without license declaration and basic docs. TODO.txt should be added to the -docs subpackage. Or another way for the docs: Move all doc files to the -docs package and mark it as required by the python2 and python3 packages. This way the docs would be always present, independently from which python version is used. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NJZc9Gzct5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852232] Review Request: python-vaporize - library for the Rackspace Cloud
https://bugzilla.redhat.com/show_bug.cgi?id=852232 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||dbr...@fedoraproject.org, ||mario.blaetterm...@gmail.co ||m Flags||needinfo?(dbruno@fedoraproj ||ect.org) --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- Is this review ticket still alive? If yes, please provide a fixed version, and I will do the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rxLEeK72XVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852254] Review Request: python-clouddns - Python interface to Rackspace Cloud DNS
https://bugzilla.redhat.com/show_bug.cgi?id=852254 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||dbr...@fedoraproject.org, ||mario.blaetterm...@gmail.co ||m Flags||needinfo?(dbruno@fedoraproj ||ect.org) --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- Ping again, eight months after my last one. Is this ticket still alive? If yes, please provide new files within a reasońable time frame. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xeHaz13GwZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969820] Review Request: jclouds - Concurrent API for Cloud Services
https://bugzilla.redhat.com/show_bug.cgi?id=969820 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||887146 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yhf8Jp4fdAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969820] New: Review Request: jclouds - Concurrent API for Cloud Services
https://bugzilla.redhat.com/show_bug.cgi?id=969820 Bug ID: 969820 Summary: Review Request: jclouds - Concurrent API for Cloud Services Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jclouds.spec SRPM URL: http://gil.fedorapeople.org/jclouds-1.5.10-1.fc18.src.rpm Description: jclouds is an open source library that helps you get started in the cloud and reuse your java and clojure development skills. jclouds API allows you freedom to use portable abstractions or cloud-specific features. jclouds provides test support of 30 cloud providers and cloud software stacks, including Amazon, GoGrid, Ninefold, vCloud, OpenStack, and Azure. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AYufqOm7w1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 887146] Review Request: rocoto - Expanded properties file parsing for Google Guice
https://bugzilla.redhat.com/show_bug.cgi?id=887146 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||969820 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L2MYinpcKZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=888385
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
The tarball contains an upstream egg, you have to delete it before building the
package so that it gets rebuilt:
%prep
%setup -q -n Yapsy-%{version}-pythons2n3
rm -rf *.egg-info
See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
info.
Don't mix %{buildroot} and $RPM_BUILD_ROOT in the same spec file.
$ rpmlint -i -v *
python-yapsy.src: I: checking
python-yapsy.src: W: spelling-error %description -l en_US customised -
customized, customize, accustomed
The value of this tag appears to be misspelled. Please double-check.
Please fix the spelling error:
customised → customized
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=bbO3PXOA1ja=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969823] New: Review Request: nodejs-moment - Parse, manipulate and display dates
https://bugzilla.redhat.com/show_bug.cgi?id=969823 Bug ID: 969823 Summary: Review Request: nodejs-moment - Parse, manipulate and display dates Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jamieli...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-moment.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-moment-2.0.0-1.fc19.src.rpm Fedora Account System Username: jamielinux Description: Parse, manipulate and display dates -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5107FHdLGba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969823] Review Request: nodejs-moment - Parse, manipulate and display dates
https://bugzilla.redhat.com/show_bug.cgi?id=969823 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||956806 (nodejs-reviews), ||911022 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6wmDfh5XACa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911022] Review Request: buddycloud-server - The buddycloud channels service for XMPP implemented in Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911022 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||969823 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eFp8A876Sea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969827] New: Review Request: nodejs-pubcontrol - HTTP Extensible Pubsub Control Protocol (EPCP) library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969827 Bug ID: 969827 Summary: Review Request: nodejs-pubcontrol - HTTP Extensible Pubsub Control Protocol (EPCP) library for Node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jamieli...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-pubcontrol.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-pubcontrol-0.3.2-1.fc19.src.rpm Fedora Account System Username: jamielinux Description: HTTP Extensible Pubsub Control Protocol (EPCP) library for Node.js. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bmDkxYL3kAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910154] Review Request: buddycloud-http-api - The buddycloud HTTP API service for buddycloud-server
https://bugzilla.redhat.com/show_bug.cgi?id=910154 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||969827 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZlsMeNXgcTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969827] Review Request: nodejs-pubcontrol - HTTP Extensible Pubsub Control Protocol (EPCP) library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969827 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||956806 (nodejs-reviews), ||910154 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W79tMLfwf7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958344] Review Request: python-extras - Useful extra bits for Python
https://bugzilla.redhat.com/show_bug.cgi?id=958344 --- Comment #23 from Pádraig Brady p...@draigbrady.com --- Sorry Jerry. I really didn't want you to offend you in any way. It's just that this package was blocking a bunch of stuff and I wanted to be sure it was submitted. The couple of days I think we gained was important IMHO. Please feel free to hit me up for review requests/swaps or whatever... thanks, Pádraig. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BRCmQ1ZmZda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969830] Review Request: nodejs-grip - Generic Realtime Intermediary Protocol (GRIP) library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969830 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||969827, 956806 ||(nodejs-reviews), 910154 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bjKKSxkQcja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969830] New: Review Request: nodejs-grip - Generic Realtime Intermediary Protocol (GRIP) library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969830 Bug ID: 969830 Summary: Review Request: nodejs-grip - Generic Realtime Intermediary Protocol (GRIP) library for Node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jamieli...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-grip.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-grip-0.1.5-1.fc19.src.rpm Fedora Account System Username: jamielinux Description: Generic Realtime Intermediary Protocol (GRIP) library for Node.js. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XQKKf6JRPia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910154] Review Request: buddycloud-http-api - The buddycloud HTTP API service for buddycloud-server
https://bugzilla.redhat.com/show_bug.cgi?id=910154 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||969830 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f4Lfffkp6Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969827] Review Request: nodejs-pubcontrol - HTTP Extensible Pubsub Control Protocol (EPCP) library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=969827 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||969830 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rye70Xt4I8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912048] Review Request: mpDris2 - Provide MPRIS 2 support to mpd
https://bugzilla.redhat.com/show_bug.cgi?id=912048 --- Comment #2 from Gianluca Sforna gia...@gmail.com --- Basic things first. Even if the tarball is called mpDris2 I would still prefer to call the package (and spec file) all lowercase. I checked and other distros are already doing that, makes it easier for command line users to get it right. Package builds in mock for Fedora 19, rpmlint on the results says: rpmlint /var/lib/mock/fedora-19-x86_64/result/*.rpm mpDris2.noarch: W: spelling-error Summary(en_US) mpd - mod, mp, pd mpDris2.noarch: W: spelling-error %description -l en_US mpd - mod, mp, pd mpDris2.noarch: W: non-conffile-in-etc /etc/xdg/autostart/mpDris2.desktop mpDris2.noarch: W: no-manual-page-for-binary mpDris2 mpDris2.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/mpDris2.mo mpDris2.src: W: spelling-error Summary(en_US) mpd - mod, mp, pd mpDris2.src: W: spelling-error %description -l en_US mpd - mod, mp, pd 2 packages and 0 specfiles checked; 0 errors, 7 warnings. We can pretty much ignore spelling warnings. the .desktop in /etc/xdg/autostart is better to be marked as %config(noreplace). AFAIK, this is not on the guidelines but if an admin changes the file he expects changes to be preserved on upgrades (see for instance bug #842318) Language file, even if it's only one, must be handled by %find_lang as shown in: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files Please fix these points and I think we are all set to approve the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yuJABxfd99a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969820] Review Request: jclouds - Concurrent API for Cloud Services
https://bugzilla.redhat.com/show_bug.cgi?id=969820 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cuZ1D1cPzpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969718] Review Request: pbuilder - Personal package builder for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=969718 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Depends On||961141 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RISH9Mf0NJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961141] Review Request: debhelper - Helper programs for debian/rules
https://bugzilla.redhat.com/show_bug.cgi?id=961141 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Blocks|591388 |969718 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LG7QLdMuMRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969718] Review Request: pbuilder - Personal package builder for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=969718 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Depends On||591389 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GjAKuTTjraa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969718] Review Request: pbuilder - Personal package builder for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=969718 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Depends On||591192 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dZPflXkaSda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968136] Review Request: camel - Apache Camel integration framework
https://bugzilla.redhat.com/show_bug.cgi?id=968136 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||969820 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TJLizOpeKFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969820] Review Request: jclouds - Concurrent API for Cloud Services
https://bugzilla.redhat.com/show_bug.cgi?id=969820 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||968136 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rpKviIFpbDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034
Rich Mattes richmat...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||richmat...@gmail.com
Flags||fedora-review?
--- Comment #1 from Rich Mattes richmat...@gmail.com ---
I'll take this review.
Initial comments:
1. It's probably better to use the real upstream repository instead of the
archives loaded to pypi. The pypi archives don't have any documentation. Real
upstream is at https://github.com/ros-infrastructure/catkin_pkg/tags, and the
github source URL guidelines and the snapshot package naming guidelines apply.
2. Unless you're targeting el5, you probably don't need the python-site* at the
top of the spec. These are defined on el6 and fedora.
Fedora-review, finished by me:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (3 clause), Unknown or generated. 5 files have unknown license.
Detailed output of licensecheck in /home/rich/tmp/926034-python-
catkin_pkg/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]:
[Bug 858067] Review Request: mingw-qt5-qtimageformats - Qt5 for Windows - QtImageFormats component
https://bugzilla.redhat.com/show_bug.cgi?id=858067 --- Comment #6 from Erik van Pienbroek erik-fed...@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtimageformats/mingw-qt5-qtimageformats.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtimageformats/5.0.2/2.fc20/src/mingw-qt5-qtimageformats-5.0.2-2.fc20.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=153 * Sun Jun 02 2013 Erik van Pienbroek epien...@fedoraproject.org - 5.0.2-2 - Added license files -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uLlH25dYVoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745515] Review Request: yuicompressor - Tool that supports the compression of both JavaScript and CSS files
https://bugzilla.redhat.com/show_bug.cgi?id=745515 --- Comment #27 from Ville Skyttä ville.sky...@iki.fi --- It would be helpful if you used the same test files I've shown when showing that it works on your system -- cssmin.js doesn't seem to have anything to do with them. Neither of the files I've shown are empty BTW (one has only comments, the other comments and code) so I don't understand what the comment about an empty file means. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uET43ykNkUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957715] Review Request: gamgi - Build, View and Analyse Atomic Structures
https://bugzilla.redhat.com/show_bug.cgi?id=957715 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #1 from Volker Fröhlich volke...@gmx.at --- + /usr/bin/patch -p1 -b --suffix .x86_64 --fuzz=0 patching file src/make_local Hunk #1 FAILED at 18. 1 out of 1 hunk FAILED -- saving rejects to file src/make_local.rej error: Bad exit status from /var/tmp/rpm-tmp.DyTG09 (%prep) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7SUpfolleQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745515] Review Request: yuicompressor - Tool that supports the compression of both JavaScript and CSS files
https://bugzilla.redhat.com/show_bug.cgi?id=745515 --- Comment #28 from gil cattaneo punto...@libero.it --- $ echo /* hello */ | yuicompressor --type js isnt a js file (it is not nothing) and is empty and consequently fails -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rXRP8ErsW6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969848] New: Review Request: python-catkin-sphinx - Sphinx plugins for Catkin projects
https://bugzilla.redhat.com/show_bug.cgi?id=969848 Bug ID: 969848 Summary: Review Request: python-catkin-sphinx - Sphinx plugins for Catkin projects Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: richmat...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://rmattes.fedorapeople.org/RPMS/catkin-sphinx/python-catkin-sphinx.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/catkin-sphinx/python-catkin-sphinx-0.2.1-1.20130602gitc00d68b.fc19.src.rpm Description: Sphinx plugins for Catkin projects. Fedora Account System Username: rmattes rpmlint: $ rpmlint python-catkin-sphinx.spec ../RPMS/noarch/python-catkin-sphinx-0.2.1-1.20130602gitc00d68b.fc19.noarch.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YfTep58faAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882481] Review Request: python-doit - Automation Tool
https://bugzilla.redhat.com/show_bug.cgi?id=882481 --- Comment #19 from Christopher Meng cicku...@gmail.com --- (In reply to Mario Blättermann from comment #18) The files LICENSE and README should appear in both python2 and python3 versions. One can install them independently from each other, so the python3 package would remain without license declaration and basic docs. TODO.txt should be added to the -docs subpackage. Or another way for the docs: Move all doc files to the -docs package and mark it as required by the python2 and python3 packages. This way the docs would be always present, independently from which python version is used. Nice suggestion. BTW, this package seems has test problem during %check section, can we ignore this section? I need this package for another package, so... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EuO0qdfpxZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967403] Review Request: python-tvrage - Python client for the tvrage.com XML API
https://bugzilla.redhat.com/show_bug.cgi?id=967403 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: python-tvrage Short Description: Python client for the tvrage.com XML API Owners: cicku Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1zrJushSbJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957715] Review Request: gamgi - Build, View and Analyse Atomic Structures
https://bugzilla.redhat.com/show_bug.cgi?id=957715 --- Comment #2 from Christopher Meng cicku...@gmail.com --- (In reply to Volker Fröhlich from comment #1) + /usr/bin/patch -p1 -b --suffix .x86_64 --fuzz=0 patching file src/make_local Hunk #1 FAILED at 18. 1 out of 1 hunk FAILED -- saving rejects to file src/make_local.rej error: Bad exit status from /var/tmp/rpm-tmp.DyTG09 (%prep) Hi, This package has some known problems and a newer version just released. I'll update it later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ThqNhdC14Aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968253] Review Request: profile-sync-daemon - Offload browser profiles to RAM for speed a wear reduction
https://bugzilla.redhat.com/show_bug.cgi?id=968253 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #4 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: profile-sync-daemon Short Description: Offload browser profiles to RAM for speed a wear reduction Owners: cicku Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a68DY901yEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954074] Review Request: remotebox - Open Source VirtualBox Client with Remote Management
https://bugzilla.redhat.com/show_bug.cgi?id=954074
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich volke...@gmx.at ---
error: (will be fatal in the future): value remotebox.png for key Icon in
group Desktop Entry is an icon name with an extension, but there should be no
extension as described in the Icon Theme Specification if the value is not an
absolute path
Did you try to submit the desktop file? Did you ask them to include a license
file yet?
Please give a rationale for AutoReq: no.
I'd suggest to use the _prefix and _docdir macros in your sed invocations.
You're not owning %{_datadir}/%{name}. Make %{_datadir}/%{name}/*
%{_datadir}/%{name}. That'll do!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0HERSqvIKMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954074] Review Request: remotebox - Open Source VirtualBox Client with Remote Management
https://bugzilla.redhat.com/show_bug.cgi?id=954074 --- Comment #2 from Volker Fröhlich volke...@gmx.at --- I noticed that the file remotebox states Licenced under the terms of the GPL. This statement should better include the version. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3taiotFCada=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] New: Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Bug ID: 969850 Summary: Review Request: python-rosdistro - File format for managing ROS Distributions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: richmat...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://rmattes.fedorapeople.org/RPMS/rosdistro/python-rosdistro.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/rosdistro/python-rosdistro-0.2.8-1.20130602git6e83551.fc19.src.rpm Description: The rosdistro tool allows you to get access to the full dependency tree and the vcs information of all packages and repositories. To increase performance, the rosdistro tool will automatically look for a cache file on your local disk. If no cache file is found locally, it will try to download the latest cache file from the server. The cache files are only used to improve performance, and are not needed to get correct results. rosdistro will automatically go to github to find any dependencies that are not part of the cache file. Note that operation without a cache file can be very slow, depending on your own internet connection and the response times of github. The rosdistro tool will always write the latest dependency information to a local cache file, to speed up performance for the next query. Fedora Account System Username: rmattes rpmlint: $ rpmlint python-rosdistro.spec ../RPMS/noarch/python-rosdistro-0.2.8-1.20130602git6e83551.fc19.noarch.rpm python-rosdistro.noarch: W: spelling-error %description -l en_US vcs - vs, cs, vacs python-rosdistro.noarch: W: spelling-error %description -l en_US github - git hub, git-hub, thuggish python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_reformat python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_build_cache 1 packages and 1 specfiles checked; 0 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nseWjzmZ1ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Depends On||969848 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zN96qAwmFfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969848] Review Request: python-catkin-sphinx - Sphinx plugins for Catkin projects
https://bugzilla.redhat.com/show_bug.cgi?id=969848 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Blocks||969850 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ic1VC94L3Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962029] Review Request: libdbusmenu - A library that pulling out some code out of indicator-applet
https://bugzilla.redhat.com/show_bug.cgi?id=962029 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- libdbusmenu-12.10.2-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OcZsm2YHnGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745515] Review Request: yuicompressor - Tool that supports the compression of both JavaScript and CSS files
https://bugzilla.redhat.com/show_bug.cgi?id=745515 --- Comment #29 from gil cattaneo punto...@libero.it --- (In reply to Ville Skyttä from comment #25) Also, this version doesn't preserve the C-style comments starting with /*! as documented. The old 2.4.7 version I'm using locally does. isnt this version is our rhino which dont support c-style... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WBUxADadAfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967659] Review Request: robojournal - cross-platform journal/diary tool
https://bugzilla.redhat.com/show_bug.cgi?id=967659 --- Comment #3 from Will Kraft pwiz...@gmail.com --- I have successfully built RPMS of the main executable and its documentation with Koji: http://kojipkgs.fedoraproject.org//work/tasks/2715/5452715/robojournal-0.4.1-1.fc18.i686.rpm http://kojipkgs.fedoraproject.org//work/tasks/2714/5452714/robojournal-0.4.1-1.fc18.x86_64.rpm http://kojipkgs.fedoraproject.org//work/tasks/3158/5453158/robojournal-doc-0.4.1-1.fc18.noarch.rpm Once again, I am seeking a sponsor for this package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Btqw3N6kVqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968253] Review Request: profile-sync-daemon - Offload browser profiles to RAM for speed a wear reduction
https://bugzilla.redhat.com/show_bug.cgi?id=968253 --- Comment #5 from gray...@archlinux.us --- Thank you all for prompt action. I'm very excited to have this accepted. An important note: we merged the many Makefile.xxx into a single one with v5.36 which I just pushed. This requires a minor modification to profile-sync-daemon.spec which I propose in the linked patch: https://gist.github.com/graysky2/5694913 Full diff if you are interested: https://github.com/graysky2/profile-sync-daemon/compare/v5.35...v5.36 Regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8sc3cmNSvoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969877] New: Review Request: rubygem-timers - Schedule procs to run after a certain time, or at periodic intervals
https://bugzilla.redhat.com/show_bug.cgi?id=969877 Bug ID: 969877 Summary: Review Request: rubygem-timers - Schedule procs to run after a certain time, or at periodic intervals Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: axill...@archlinux.gr QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org This is my first package and I am seeking a sponsor. Fedora Account System Username: axilleas Spec URL: https://github.com/axilleas/fedora/raw/master/packages/rubygem-timers/rubygem-timers.spec SRPM URL: https://github.com/axilleas/fedora/blob/master/packages/rubygem-timers/rubygem-timers-1.1.0-1.fc19.src.rpm?raw=true -- Other useful logs: rpmbuild: https://github.com/axilleas/fedora/raw/master/packages/rubygem-timers/rpmbuild mock: https://github.com/axilleas/fedora/raw/master/packages/rubygem-timers/mock rpmlint: https://github.com/axilleas/fedora/raw/master/packages/rubygem-timers/rpmlint Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5447148 -- Description: Pure Ruby timer collections. Schedule several procs to fire after configurable delays or at periodic intervals. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XeHjKAuvM3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969877] Review Request: rubygem-timers - Schedule procs to run after a certain time, or at periodic intervals
https://bugzilla.redhat.com/show_bug.cgi?id=969877 Axilleas Pipinellis axill...@archlinux.gr changed: What|Removed |Added Version|rawhide |19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vQDnRDNrwia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969877] Review Request: rubygem-timers - Schedule procs to run after a certain time, or at periodic intervals
https://bugzilla.redhat.com/show_bug.cgi?id=969877 Axilleas Pipinellis axill...@archlinux.gr changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=986tq55p2ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858067] Review Request: mingw-qt5-qtimageformats - Qt5 for Windows - QtImageFormats component
https://bugzilla.redhat.com/show_bug.cgi?id=858067 Sandro Mani manisan...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Sandro Mani manisan...@gmail.com --- Approved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=85WHFUquXNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967289] Review Request: python-plyvel - Python interface to the LevelDB embedded database library
https://bugzilla.redhat.com/show_bug.cgi?id=967289 Dan Callaghan dcall...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Dan Callaghan dcall...@redhat.com --- (In reply to Mario Blättermann from comment #1) Only the macro-in-comment warnings need to be fixed (not blocking the review) by prepending a second %. Will do, thanks Mario. New Package SCM Request === Package Name: python-plyvel Short Description: Python interface to the LevelDB embedded database library Owners: dcallagh Branches: f17 f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GI5MNGddSFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=962612 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iwPNrFGWvTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=962612 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- python-requests-kerberos-0.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-requests-kerberos-0.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3CGzf2G2Fia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=962612 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- python-requests-kerberos-0.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-requests-kerberos-0.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xFDSfyFBeFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=962612 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-requests-kerberos-0.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-requests-kerberos-0.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jTAHuElczQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests
https://bugzilla.redhat.com/show_bug.cgi?id=962612 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-requests-kerberos-0.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-requests-kerberos-0.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R6SfR3vK1ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920436] Review Request: rubygem-bootstrap-sass - Bootstrap, converted to Sass
https://bugzilla.redhat.com/show_bug.cgi?id=920436 --- Comment #9 from Mamoru TASAKA mtas...@fedoraproject.org --- I will close this bug if no response from the reporter is received within one week. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UAbJDjjElZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591332] Review Request: debconf - Debian configuration management system
https://bugzilla.redhat.com/show_bug.cgi?id=591332 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- debconf-1.5.49-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/debconf-1.5.49-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Llcd9w7l99a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591332] Review Request: debconf - Debian configuration management system
https://bugzilla.redhat.com/show_bug.cgi?id=591332 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- debconf-1.5.49-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/debconf-1.5.49-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4NY9aczXApa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962651] Re-Review Request: bamf - Application matching framework
https://bugzilla.redhat.com/show_bug.cgi?id=962651
Praveen Kumar kumarpraveen.nit...@gmail.com changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|kumarpraveen.nitdgp@gmail.c
||om
Flags|needinfo? |
Flags||fedora-review?
--- Comment #6 from Praveen Kumar kumarpraveen.nit...@gmail.com ---
Hi Michel,
I already did a formal review, is below issues resolved? As you said we don't
have to provide a major update for f18, just have to unblock it for dependent
applications. I assigned it to myself now.
Issues:
===
- Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/bamf
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
- Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
- Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
- License field in the package spec file matches the actual license.
It should be v2+ and v3+.
GPL (v2 or later)
-
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-application-private.h
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-tab.c
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-tab.h
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-view-private.h
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/ltmain.sh
GPL (v3 or later)
-
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/tests/libbamf/test-libbamf.c
/var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/tests/libbamf/test-matcher.c
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=kYcNk8KueRa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH
https://bugzilla.redhat.com/show_bug.cgi?id=923564 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|NetworkManager-ssh-0.0.3-0. |NetworkManager-ssh-0.0.3-0. |8.20130419git3d5321b.fc19 |8.20130419git3d5321b.fc18 --- Comment #45 from Fedora Update System upda...@fedoraproject.org --- NetworkManager-ssh-0.0.3-0.8.20130419git3d5321b.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=REHE2n1okza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924279] Review Request: mate-character-map - Unicode character picker and font browser
https://bugzilla.redhat.com/show_bug.cgi?id=924279 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|mate-character-map-1.6.0-4. |mate-character-map-1.6.0-4. |fc19|fc18 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- mate-character-map-1.6.0-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7RCHbryNzRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
