[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973904

--- Comment #2 from Christopher Meng  ---
(In reply to Remi Collet from comment #1)
> QUick notes:
> 
> %package -n devel
> 
> Need to remove the -n

Fixed.

> BuildRequires:
> 
> Why openldap-devel (don't see any ldap stuff in this package, no lber.h,
> ldap.h or ldif.h include)
> Why expat-devel... (no expat.h include)
> 
> => Ok, both are used in the result .so but can probably be omitted, no
> include of the provided headers, and will be pulled by apr.

Removed.

> Auto dependencies are broken.
> Setting right to 755 the library should solves this.

Which library?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aXJ6BLDYb9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 882474] Review Request: spymemcached - Java client for memcached

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=882474

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||spymemcached-2.8.12-1.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:52:23

--- Comment #9 from Fedora Update System  ---
spymemcached-2.8.12-1.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4x8IyPaBTa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 968136] Review Request: camel - Apache Camel integration framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=968136

Bug 968136 depends on bug 882474, which changed state.

Bug 882474 Summary: Review Request: spymemcached - Java client for memcached
https://bugzilla.redhat.com/show_bug.cgi?id=882474

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AZYlqrDeOI&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 882475] Review Request: cas-client - Jasig CAS Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=882475

Bug 882475 depends on bug 882474, which changed state.

Bug 882474 Summary: Review Request: spymemcached - Java client for memcached
https://bugzilla.redhat.com/show_bug.cgi?id=882474

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PIdUwL5M8K&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973904

--- Comment #1 from Remi Collet  ---
QUick notes:

%package -n devel

Need to remove the -n

BuildRequires:

Why openldap-devel (don't see any ldap stuff in this package, no lber.h, ldap.h
or ldif.h include)
Why expat-devel... (no expat.h include)

=> Ok, both are used in the result .so but can probably be omitted, no include
of the provided headers, and will be pulled by apr.

Auto dependencies are broken.
Setting right to 755 the library should solves this.

%files
%{_libdir}/*.so.*

I don't really like too large wildcard.
%{_libdir}/libserf-1.so.0*

As this is more explicit, it will also help to detect any soname change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=s2MGgrFn3y&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 968229] Review Request: python-testresources - Testresources, a pyunit extension for managing expensive test resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=968229

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-testresources-0.2.7-
   ||3.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:47:07

--- Comment #11 from Fedora Update System  ---
python-testresources-0.2.7-3.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZropptfTvv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908842] Review Request: python-subunit - Python implementation of subunit test streaming protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=908842

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-subunit-0.0.12-5.fc1
   ||9
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:46:42

--- Comment #32 from Fedora Update System  ---
python-subunit-0.0.12-5.fc19 has been pushed to the Fedora 19 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=S5Gqxg7Vd9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 967482] Review Request: tcpcopy - An online request replication tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967482

--- Comment #8 from Christopher Meng  ---
NEW SPEC URL: http://cicku.me/tcpcopy.spec
NEW SRPM URL: http://cicku.me/tcpcopy-0.8.0-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xpTV8rQ3Pi&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 913200] Review Request: python-testrepository - A repository of test results

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=913200

Bug 913200 depends on bug 908842, which changed state.

Bug 908842 Summary: Review Request: python-subunit - Python implementation of 
subunit test streaming protocol
https://bugzilla.redhat.com/show_bug.cgi?id=908842

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oDPh79FGKb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 961404] Review Request: mingw-gtkspellmm30 - MinGW Windows GtkSpellmm library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=961404

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||mingw-gtkspellmm30-3.0.2-1.
   ||fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:44:00

--- Comment #9 from Fedora Update System  ---
mingw-gtkspellmm30-3.0.2-1.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5d8IQ6gBWZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973349] Review Request: checksec - Tool to check system for binary-hardening

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973349

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|checksec-1.5-1.fc18 |checksec-1.5-1.fc19

--- Comment #15 from Fedora Update System  ---
checksec-1.5-1.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=uIumy1h8DT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 867287] Review Request: glite-jobid-api-cpp - C++ API handling gLite jobid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=867287

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||glite-jobid-api-cpp-1.3.6-2
   ||.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:41:29

--- Comment #13 from Fedora Update System  ---
glite-jobid-api-cpp-1.3.6-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=T6AAJqbdDL&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 967403] Review Request: python-tvrage - Python client for the tvrage.com XML API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967403

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-tvrage-0.4.1-3.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:39:08

--- Comment #12 from Fedora Update System  ---
python-tvrage-0.4.1-3.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YthOjoYBed&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858066] Review Request: mingw-qt5-qtgraphicaleffects - Qt5 for Windows - QtGraphicalEffects component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=858066

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||mingw-qt5-qtimageformats-5.
   ||0.2-2.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:38:26

--- Comment #14 from Fedora Update System  ---
mingw-qt5-qtimageformats-5.0.2-2.fc19,
mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19,
mingw-qt5-qttranslations-5.0.2-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bAVjHXROed&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=858082

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||mingw-qt5-qtimageformats-5.
   ||0.2-2.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:38:18

--- Comment #14 from Fedora Update System  ---
mingw-qt5-qtimageformats-5.0.2-2.fc19,
mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19,
mingw-qt5-qttranslations-5.0.2-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DOi21GJn5G&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858067] Review Request: mingw-qt5-qtimageformats - Qt5 for Windows - QtImageFormats component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=858067

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||mingw-qt5-qtimageformats-5.
   ||0.2-2.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:38:35

--- Comment #13 from Fedora Update System  ---
mingw-qt5-qtimageformats-5.0.2-2.fc19,
mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19,
mingw-qt5-qttranslations-5.0.2-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=S5UTPlEkSP&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=964143

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-testscenarios-0.4-2.
   ||fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:37:22

--- Comment #9 from Fedora Update System  ---
python-testscenarios-0.4-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oW8bQxXa5Q&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970035] Review Request: libnm-qt - Qt-only wrapper for NetworkManager DBus API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970035

Bug 970035 depends on bug 970034, which changed state.

Bug 970034 Summary: Review Request: libmm-qt - Qt-only wrapper for ModemManager 
DBus API
https://bugzilla.redhat.com/show_bug.cgi?id=970034

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=49xjOvn9Zx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970036] Review Request: kde-plasma-nm - Plasma applet written in QML for managing network connections

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970036

Bug 970036 depends on bug 970035, which changed state.

Bug 970035 Summary: Review Request: libnm-qt - Qt-only wrapper for 
NetworkManager DBus API
https://bugzilla.redhat.com/show_bug.cgi?id=970035

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1HmlGMGKg4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970034] Review Request: libmm-qt - Qt-only wrapper for ModemManager DBus API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970034

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||kde-plasma-nm-0.9.3.0-1.201
   ||30604git649e5f4.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:35:13

--- Comment #9 from Fedora Update System  ---
kde-plasma-nm-0.9.3.0-1.20130604git649e5f4.fc19,
libnm-qt-0.9.8-1.20130527git0dd3793.fc19,
libmm-qt-0.6.0-1.20130422git657646b.fc19 has been pushed to the Fedora 19
stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EAN4JPj2iU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 867282] Review Request: glite-jobid-api-c - C library handling gLite jobid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=867282

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||glite-jobid-api-c-2.2.9-1.f
   ||c19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:34:37

--- Comment #10 from Fedora Update System  ---
glite-jobid-api-c-2.2.9-1.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=RthqZfeRVw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970036] Review Request: kde-plasma-nm - Plasma applet written in QML for managing network connections

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970036

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||kde-plasma-nm-0.9.3.0-1.201
   ||30604git649e5f4.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:35:34

--- Comment #10 from Fedora Update System  ---
kde-plasma-nm-0.9.3.0-1.20130604git649e5f4.fc19,
libnm-qt-0.9.8-1.20130527git0dd3793.fc19,
libmm-qt-0.6.0-1.20130422git657646b.fc19 has been pushed to the Fedora 19
stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cQ5ntQbnIe&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970035] Review Request: libnm-qt - Qt-only wrapper for NetworkManager DBus API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970035

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||kde-plasma-nm-0.9.3.0-1.201
   ||30604git649e5f4.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:35:24

--- Comment #10 from Fedora Update System  ---
kde-plasma-nm-0.9.3.0-1.20130604git649e5f4.fc19,
libnm-qt-0.9.8-1.20130527git0dd3793.fc19,
libmm-qt-0.6.0-1.20130422git657646b.fc19 has been pushed to the Fedora 19
stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xBWtLE9wld&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 867287] Review Request: glite-jobid-api-cpp - C++ API handling gLite jobid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=867287

Bug 867287 depends on bug 867282, which changed state.

Bug 867282 Summary: Review Request: glite-jobid-api-c - C library handling 
gLite jobid
https://bugzilla.redhat.com/show_bug.cgi?id=867282

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vA5KbwqldJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967568

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||mintmenu-5.4.9-6.fc19
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:34:27

--- Comment #15 from Fedora Update System  ---
mintmenu-5.4.9-6.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wEuFYSQASk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973696] Review Request: php-pecl-jsonc - Support for JSON serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973696

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #3 from Remi Collet  ---
Great thanks for the fast review


New Package SCM Request
===
Package Name: php-pecl-jsonc
Short Description: Support for JSON serialization
Owners: remi
Branches: f19
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=py79Gw5KN5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973696] Review Request: php-pecl-jsonc - Support for JSON serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973696

Jan Kaluža  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #2 from Jan Kaluža  ---
The packaged has passed the review. Commented fedora-review output:

> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://fedoraproject.org/wiki/Packaging:Guidelines

You stated you will change php package properly to fix the conflicts during the
installation. In this case it's not blocker.

> - Package requires php-common instead of php.
>   See: http://fedoraproject.org/wiki/Packaging:PHP

This is not required for PECL packages according to guidelines. So it's OK too.

> 
> = MUST items =
> 
> C/C++:
> [ ]: Package does not contain kernel modules.
> [ ]: Package contains no static executables.
> [ ]: Development (unversioned) .so files in -devel subpackage, if present.
>  Note: Unversioned so-files in private %_libdir subdirectory (see
>  attachment). Verify they are not in ld path.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> 
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.
> [ ]: %build honors applicable compiler flags or justifies otherwise.
> [ ]: Package contains no bundled libraries without FPC exception.
> [ ]: Changelog in prescribed format.
> [ ]: Sources contain only permissible code or content.
> [ ]: Package contains desktop file if it is a GUI application.
> [ ]: Development files must be in a -devel package
> [ ]: Package requires other packages for directories it uses.
> [ ]: Package uses nothing in %doc for runtime.
> [ ]: Package is not known to require ExcludeArch.
> [ ]: Package complies to the Packaging Guidelines
> [ ]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses found:
>  "MIT/X11 (BSD like)", "Unknown or generated", "PHP (v3.01)". 40 files
>  have unknown license. Detailed output of licensecheck in
>  /home/hanzz/test/973696-php-pecl-jsonc/licensecheck.txt

There are files licensed under MIT, but they are not used to build binary
package, so it's OK.

> [ ]: License file installed when any subpackage combination is installed.
> [ ]: Package consistently uses macro is (instead of hard-coded directory
>  names).
> [ ]: Package is named according to the Package Naming Guidelines.
> [ ]: Package does not generate any conflict.
> [ ]: Package obeys FHS, except libexecdir and /usr/target.
> [ ]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
> [ ]: Package must own all directories that it creates.
> [ ]: Package does not own files or directories owned by other packages.
> [ ]: Requires correct, justified where necessary.
> [ ]: Spec file is legible and written in American English.
> [ ]: Package contains systemd file(s) if in need.
> [ ]: Useful -debuginfo package or justification otherwise.
> [ ]: Large documentation must go in a -doc subpackage.
>  Note: Documentation size is 10240 bytes in 3 files.
> [x]: All build dependencies are listed in BuildRequires, except for any that
>  are listed in the exceptions section of Packaging Guidelines.
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>  beginning of %install.
> [x]: %config files are marked noreplace or the reason is justified.
> [x]: Each %files section contains %defattr if rpm < 4.4
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Fully versioned dependency in subpackages, if present.
> [x]: If (and only if) the source package includes the text of the license(s)
>  in its own file, then that file, containing the text of the license(s)
>  for the package is included in %doc.
> [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>  work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: No %config files under /usr.
> [x]: Package do not use a name that already exist
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as provided
>  in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>  %{name}.spec.
> [x]: File names are valid UTF-8.

[Bug 973349] Review Request: checksec - Tool to check system for binary-hardening

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973349

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||checksec-1.5-1.fc18
 Resolution|--- |ERRATA
Last Closed||2013-06-13 02:11:17

--- Comment #14 from Fedora Update System  ---
checksec-1.5-1.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OLEBUQY0OR&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 962029] Review Request: libdbusmenu - A library that pulling out some code out of indicator-applet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=962029

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|libdbusmenu-12.10.2-3.fc17  |libdbusmenu-12.10.2-3.fc18

--- Comment #19 from Fedora Update System  ---
libdbusmenu-12.10.2-3.fc18 has been pushed to the Fedora 18 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0jENc544Ca&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 958344] Review Request: python-extras - Useful extra bits for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=958344

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|python-extras-0.0.3-2.fc19  |python-extras-0.0.3-2.fc18

--- Comment #25 from Fedora Update System  ---
python-extras-0.0.3-2.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GhGgVMKT5p&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=962612

--- Comment #11 from Fedora Update System  ---
python-requests-kerberos-0.3-1.fc17 has been pushed to the Fedora 17 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5RzpFPL5Qk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 882476] Review Request: openid4java - This library allows you to OpenID-enable your Java webapp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=882476

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|openid4java-0.9.8-1.fc19|openid4java-0.9.8-1.fc18

--- Comment #10 from Fedora Update System  ---
openid4java-0.9.8-1.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Vwh45wCao0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973041] Review Request: perl-CPANPLUS-Dist-Build - Module::Build extension for CPANPLUS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973041

--- Comment #10 from Petr Pisar  ---
Waiting on unblocking the package in F19
.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=J5TkYjhRHo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973041] Review Request: perl-CPANPLUS-Dist-Build - Module::Build extension for CPANPLUS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973041

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-CPANPLUS-Dist-Build-0.
   ||70-1.fc20

--- Comment #9 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fXZSnPw8sY&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 962612] Review Request: python-requests-kerberos - A Kerberos authentication handler for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=962612

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-requests-kerberos-0.
   ||3-1.fc18
 Resolution|--- |ERRATA
Last Closed||2013-06-13 01:59:35

--- Comment #10 from Fedora Update System  ---
python-requests-kerberos-0.3-1.fc18 has been pushed to the Fedora 18 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=yh4CXCozXM&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821283] Review Request: gsbase - A collection of java utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821283

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|gsbase-2.0.1-1.fc19 |gsbase-2.0.1-1.fc18

--- Comment #10 from Fedora Update System  ---
gsbase-2.0.1-1.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Q0TN4r7xQ4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 962029] Review Request: libdbusmenu - A library that pulling out some code out of indicator-applet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=962029

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|libdbusmenu-12.10.2-3.fc19  |libdbusmenu-12.10.2-3.fc17

--- Comment #18 from Fedora Update System  ---
libdbusmenu-12.10.2-3.fc17 has been pushed to the Fedora 17 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=daNs0XubO3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 822832] Review Request: josql - Library to apply SQL-like syntax to Java objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=822832

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|josql-2.2-1.fc19|josql-2.2-1.fc18

--- Comment #10 from Fedora Update System  ---
josql-2.2-1.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=I7G8MJojkE&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973904] New: Review Request: libserf - High-Performance Asynchronous HTTP Client Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973904

Bug ID: 973904
   Summary: Review Request: libserf - High-Performance
Asynchronous HTTP Client Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: cicku...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://cicku.me/libserf.spec 
SRPM URL: http://cicku.me/libserf-1.2.1-1.fc20.src.rpm
Description: The serf library is a C-based HTTP client library built upon the
Apache Portable Runtime (APR) library. It multiplexes connections, running the
read/write communication asynchronously. Memory copies and transformations are
kept to a minimum to provide high performance operation.
Fedora Account System Username: cicku

NOTE: This package actually contains a patch which just applied by
upstream, but I dropped it as this patch seems not important in Fedora, we can
build with gssapi support without this patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QVRDeHj4Fn&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973696] Review Request: php-pecl-jsonc - Support for JSON serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973696

Jan Kaluža  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jkal...@redhat.com
   Assignee|nob...@fedoraproject.org|jkal...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8PZgXYVwVc&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973793] Review Request: python-martian - A library to grok configuration from Python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973793

Eduardo Echeverria  changed:

   What|Removed |Added

 CC||echevemas...@gmail.com

--- Comment #1 from Eduardo Echeverria  ---
Hi Marcelo, the package looks good, I can sponsor you, but first I would like
to see him involved in some informal review. Please let me know when you do the
review.

Cheers.-

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Pk6XoRvkBQ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903246] Review Request: cpopen - Creates a subprocess in simpler safer manner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=903246

--- Comment #11 from Douglas Schilling Landgraf  ---
Hi Yaniv,

(In reply to Yaniv Bronhaim from comment #10)
> fixed spec: 
> http://bronhaim.fedorapeople.org/python-cpopen-1.2.2-1.fc17.src.rpm
> http://bronhaim.fedorapeople.org/python-cpopen.spec
> 
> 1. fixed changelog dates 
> 2. added "provides_exclude_from" for shared library
> 3. added doc files to tar

Your new spec/src.rpm looks good. Do you have informal reviews to share? 


Thanks
Douglas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sPoEjjHjaw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957471

Christopher Meng  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #7 from Christopher Meng  ---
New Package SCM Request
===
Package Name: ssh-installkeys
Short Description: A tool for installing ssh keys on remote sites
Owners: cicku
Branches: f18 f19 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=R9C3ySU2aW&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973868] Re-Review Request: lifeograph - A diary program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973868

--- Comment #1 from Ankur Sinha (FranciscoD)  ---
SRPMs updated. The macro in comment warnings are now gone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PnL1SnEUSU&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973868] New: Re-Review Request: lifeograph - A diary program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973868

Bug ID: 973868
   Summary: Re-Review Request: lifeograph - A diary program
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sanjay.an...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://ankursinha.fedorapeople.org/Lifeograph/lifeograph.spec
SRPM URL:
http://ankursinha.fedorapeople.org/Lifeograph/lifeograph-0.11.1-1.fc19.src.rpm

Description: 
Lifeograph is a diary program to take personal notes on life. It has all
essential functionality expected in a diary program and strives to have
a clean and streamlined user interface.


Fedora Account System Username: ankursinha

Additional info:

[asinha@localhost  SPECS]$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ./lifeograph.spec
lifeograph.src:33: W: macro-in-comment %{optflags}
lifeograph.x86_64: W: no-manual-page-for-binary lifeograph
./lifeograph.spec:33: W: macro-in-comment %{optflags}
3 packages and 1 specfiles checked; 0 errors, 3 warnings.

An f19 x86_64 rpm can be found here:
http://ankursinha.fedorapeople.org/Lifeograph/lifeograph-0.11.1-1.fc19.x86_64.rpm

It's a deprecated package:
https://admin.fedoraproject.org/pkgdb/acls/bugs/lifeograph

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jGZMUNrnOa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973853] Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

Eric Christensen  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #6 from Eric Christensen  ---
New Package SCM Request
===
Package Name: create-tx-configuration
Short Description: An easy way to create Transifex client configuration files
Owners: sparks
Branches: f18 f19
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tAkPM0HBjl&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973853] Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

--- Comment #5 from Ian Weller  ---
(In reply to Ian Weller from comment #4)
> [ ]: %check is present and all tests pass.
> [ ]: Packages should try to preserve timestamps of original installed files.

I can't read, these both are fine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YzDbGptfXq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973853] Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

Ian Weller  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|i...@ianweller.org
  Flags||fedora-review+

--- Comment #4 from Ian Weller  ---
Review below. Fix the rm -rf %{buildroot} and the License tag bit when you
commit. Otherwise APPROVED.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.

ian's note: actual license is AGPLv3+

[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /us

[Bug 973853] Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

--- Comment #3 from Eric Christensen  ---
Spec URL: http://sparks.fedorapeople.org/Packages/create-tx-configuration.spec
SRPM URL:
http://sparks.fedorapeople.org/Packages/create-tx-configuration-0.2-2.fc18.src.rpm
Description: This script creates Transifex client configuration files based on
POT files in the local pot/ directory.  This is useful for Publican-based
documents that will be translated.
Fedora Account System Username: sparks

$ rpmlint
/var/lib/mock/fedora-18-x86_64/result/create-tx-configuration-0.2-2.fc18.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nRJMj2mrYd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973853] Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

Ian Weller  changed:

   What|Removed |Added

 CC||i...@ianweller.org

--- Comment #2 from Ian Weller  ---
(In reply to Eric Christensen from comment #1)
> I believe the warning is a false positive.  The source man page is not
> executable.

install defaults to 755, so use -m to change the permissions.

You need to add the -p option to install to preserve timestamps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=FK7UBRUxZd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 736861] Review Request: hgview - A fast Mercurial log navigator for qt4 or curses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=736861

--- Comment #18 from Mads Kiilerich  ---
(In reply to Björn Esser from comment #17)

>   ---> you should probably just split into two pkgs:

Thank you for the opinion and advice.

I am still convinced that curses should be a separate package. Installing
hgview-curses can take 7.5 MB on disk including the dependencies.

> - Package contains BR: python2-devel

Right. The guidelines has changed since the package was created.

> - update-desktop-database is invoked when required
>   Note: desktop file(s) in hgview
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

The package has no icons - only a pixmap. That section do thus not apply.

You mean
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database ? No
- the .desktop file has no MimeType.

> - Packages should try to preserve timestamps of original installed files.
> 
>   ---> -install -m 644 -D %{SOURCE1} ...
>+install -pDm 0644 %{SOURCE1} ...

That is a file I created by converting the favicon from upstreams website. The
"original" timestamp is completely irrelevant. The guidelines says "consider".
But ok.

> [!]: Rpmlint is run on all installed packages.
>  Note: Mock build failed
...
> Installation errors
> ---
> INFO: mock.py version 1.1.32 starting...
...
> INFO: installing package(s):
> /home/bjoern.esser/fedora/review/736861-hgview/results/hgview-1.7.1-3.fc20.
> noarch.rpm
> ERROR: Command failed: 
>  # ['/usr/bin/yum', '--installroot',
> '/var/lib/mock/fedora-rawhide-x86_64/root/', 'install',
> '/home/bjoern.esser/fedora/review/736861-hgview/results/hgview-1.7.1-3.fc20.
> noarch.rpm', '--setopt=tsflags=nocontexts']
> Error: Package: hgview-1.7.1-3.fc20.noarch (/hgview-1.7.1-3.fc20.noarch)
>Requires: hgview-common = 1.7.1-3.fc20
>  You could try using --skip-broken to work around the problem
>  You could try running: rpm -Va --nofiles --nodigest

You said that before, and I pointed out that the command you show is attempting
do do an invalid installation - that is not a mock build.

Please explain what you are trying to do, what you are doing, and why you think
that is the right thing to do.


Spec URL: http://kiilerix.fedorapeople.org/hgview.spec
SRPM URL: http://kiilerix.fedorapeople.org/hgview-1.7.1-4.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NEYcKjqovw&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973853] Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

--- Comment #1 from Eric Christensen  ---
$ rpmlint /var/lib/mock/fedora-18-x86_64/result/create-tx-configuration*
create-tx-configuration.noarch: W: spurious-executable-perm
/usr/share/man/man1/create-tx-configuration.1.gz
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

I believe the warning is a false positive.  The source man page is not
executable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZUyAIeEzSH&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973853] New: Review Request: create-tx-configuration - An easy way to create Transifex client configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973853

Bug ID: 973853
   Summary: Review Request: create-tx-configuration - An easy way
to create Transifex client configuration files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: spa...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://sparks.fedorapeople.org/Packages/create-tx-configuration.spec
SRPM URL:
http://sparks.fedorapeople.org/Packages/create-tx-configuration-0.2-1.fc18.src.rpm
Description: This script creates Transifex client configuration files based on
POT files in the local pot/ directory.  This is useful for Publican-based
documents that will be translated.
Fedora Account System Username: sparks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VbtsSmsZGk&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957471

Douglas Schilling Landgraf  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1qAGcpyhf7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957471

Douglas Schilling Landgraf  changed:

   What|Removed |Added

  Flags||fedora-review+

--- Comment #6 from Douglas Schilling Landgraf  ---

> Oops, I did quick review, before I approve please see my comments:
> 
> could you please add Buildrequires for python devel? 
> Please check:
> http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

Looking twice it's not required indeed, the script is not building you are
good. 

Final Status: APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IkfCUL9qco&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957471

Douglas Schilling Landgraf  changed:

   What|Removed |Added

  Flags|fedora-review+  |

--- Comment #5 from Douglas Schilling Landgraf  ---

> 
> Final status: APPROVED.

Oops, I did quick review, before I approve please see my comments:

could you please add Buildrequires for python devel? 
Please check:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jMU2OLOycb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957471

--- Comment #4 from Douglas Schilling Landgraf  ---
Reviewed manually + fedora-review version 0.4.1 b2e211f 

[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review

Rpmlint
---
Checking: ssh-installkeys-1.8-2.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)

# rpmlint ssh-installkeys
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[OK] MUST: The package must be named according to the Package Naming Guidelines
.

[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.

[OK] MUST: The package must meet the Packaging Guidelines .

[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines

[OK] MUST: The License field in the package spec file must match the actual
license

[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.

[OK] MUST: The spec file must be written in American English.

[OK] MUST: The spec file for the package MUST be legible

[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.

  CHECKSUM(SHA256) this package :
72c5f55cf3159a19476876f1c84071827be0738e4fd34801ef9252ffebc0fb98
  CHECKSUM(SHA256) upstream package :
72c5f55cf3159a19476876f1c84071827be0738e4fd34801ef9252ffebc0fb98


[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.

[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

[OK] MUST: Packages must NOT bundle copies of system libraries

[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. 

[OK] MUST: Permissions on files must be set properly. 

[OK] MUST: Each package must consistently use macros. 

[OK] MUST: The package must contain code, or permissable content.

[OK] MUST: All filenames in rpm packages must be valid UTF-8. 

[OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec
file

[OK] SHOULD: Sources can be downloaded from URI in Source: tag

[OK] SHOULD: Reviewer should test that the package builds in mock.

[OK] SHOULD: Buildroot is not present

[OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)

[OK] SHOULD: Dist tag is present.

[OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.

[OK] SHOULD: Uses parallel make.

[OK] SHOULD: SourceX tarball generation or download is documented.

[OK] SHOULD: SourceX is a working URL.

[OK] SHOULD: Spec use %global instead of %define.

Final status: APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=BdHPBuxCsS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957471] Review Request: ssh-installkeys - A tool for installing ssh keys on remote sites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=957471

Douglas Schilling Landgraf  changed:

   What|Removed |Added

  Flags||fedora-review+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=6YbntlfeFS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973305] Review Request: drupal7-views_rss - Provides a views plugin that allows fields in RSS feeds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973305

Shawn Iwinski  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #2 from Shawn Iwinski  ---
THANKS for the review!


New Package SCM Request
===
Package Name: drupal7-views_rss
Short Description: Provides a views plugin that allows fields in RSS feeds
Owners: siwinski asrob
Branches: f17 f18 f19 el5 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mDOrQxYQHc&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=837668

--- Comment #15 from Fedora Update System  ---
php-doctrine-DoctrineDBAL-2.3.4-2.el6 has been submitted as an update for
Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-doctrine-DoctrineDBAL-2.3.4-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=eBPpH5lHJ3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=837668

--- Comment #14 from Fedora Update System  ---
php-doctrine-DoctrineDBAL-2.3.4-2.fc18 has been submitted as an update for
Fedora 18.
https://admin.fedoraproject.org/updates/php-doctrine-DoctrineDBAL-2.3.4-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2hAq7wn2yL&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=837668

--- Comment #13 from Fedora Update System  ---
php-doctrine-DoctrineDBAL-2.3.4-2.fc19 has been submitted as an update for
Fedora 19.
https://admin.fedoraproject.org/updates/php-doctrine-DoctrineDBAL-2.3.4-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ktgD8hXyXB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 837668] Review Request: php-doctrine-DoctrineDBAL - Doctrine Database Abstraction Layer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=837668

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lETOFShwag&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972719

--- Comment #5 from Douglas Schilling Landgraf  ---
Hi Tomasz,

(In reply to Tomasz Torcz from comment #0)
> Spec URL: http://ttorcz.fedorapeople.org/nicstat.spec
> SRPM URL: http://ttorcz.fedorapeople.org/nicstat-1.92-1.fc18.src.rpm
> Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=5487158
> Description: nicstat is a Solaris and Linux command-line that prints out
> network statistics for all network interface cards (NICs), including
> packets, kilobytes per second, average packet sizes and more.
> It was developed by Tim Cook and Brendan Gregg, both formerly of Sun
> Microsystems.
> Fedora Account System Username: ttorcz

Rpmlint is sharing the message below: 
 W: invalid-url URL: http://nicstat.sourceforge.net HTTP Error 403: Forbidden
Note: You can check this warning message with fedora-review tool or manually
using rpmlint against rpm/src.rpm):

Do you mind to give a new try with:
URL:http://sourceforge.net/projects/%{name} 

After that your package should be good.

Thanks
Douglas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sRwMeBeudL&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972719

Douglas Schilling Landgraf  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #4 from Douglas Schilling Landgraf  ---
Hi,

(In reply to Yaniv Bronhaim from comment #3)
> As part of 1.92-2 you should modify the README file. And if you already
> modify it you should also:
> 1. split the README and AUTHORS, it's more common. 
> 2. remove the .txt suffix (also from LICENSE.txt and ChangeLog.txt)
> 3. Make the spec URL fits the README URL.

Yaniv thanks for your informal review and suggestions. 
Tomasz, all suggestions shared by Yaniv are not blockers but you can
suggest/handle them with upstream developers, for example, opening a
ticket/bugzilla and update your package again when they release a new version.
My next comment in this bugzilla will be my review.

Cheers
Douglas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=exlEqWFu6x&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 950281] Review Request: golang - The Go Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=950281

--- Comment #23 from Adam Goode  ---
Hmmm. Sorry about this. Do you mind opening a new bug to track this problem? I
will try to look at it in the meantime but it is easier for me if it's in
another bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=KE9mBC1xoZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 969209] Review Request: nx-libs - NX X11 protocol compression libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=969209

--- Comment #5 from Orion Poplawski  ---
(In reply to Mario Ceresa from comment #3)
> Okay, I point out some potential issues:
> 
> * mock fails to install the package:
> 
> Error: Package: x2goagent-3.5.0.20-3.fc20.x86_64
> (/x2goagent-3.5.0.20-3.fc20.x86_64)
> Requires: x2goserver

x2goserver and x2goagent each require each other at run-time, so this is
expected.

> * rpmlint is not silent:
> 
> - Several non standard executable permission (0775L) on libraries. Not sure
> if it's intentional

Nope, fixed.

> - Several only-non-binary-in-usr-lib

Bug in rpmlint, see bug 483199

> - Several devel-file-in-non-devel-package

Fixed

> - Others: 
> 
> nx-libs.x86_64: W: self-obsoletion nx <= 3.5.0.20-3.fc20 obsoletes nx =
> 3.5.0.20-3.fc20
> nx-libs.x86_64: W: self-obsoletion nx(x86-64) <= 3.5.0.20-3.fc20 obsoletes
> nx(x86-64) = 3.5.0.20-3.fc20

Fixed

> nx-libs.x86_64: E: no-binary

nx-libs is kind of just a container.

> nx-libs.x86_64: W: non-conffile-in-etc /etc/ld.so.conf.d/nx-libs-x86_64.conf

Fixed.

> nx-libs.x86_64: E: incorrect-fsf-address
> /usr/share/doc/nx-libs-3.5.0.20/LICENSE

Fixed.

> libXcomp.x86_64: E: missing-call-to-setgroups /usr/lib64/nx/libXcomp.so.3.5.0

Hmm, this is an odd one...

> nx-devel.x86_64: W: no-dependency-on nx/nx-libs/libnx

Fixed.

> nx-fontconfig-devel.x86_64: W: no-dependency-on
> nx-fontconfig/nx-fontconfig-libs/libnx-fontconfig
> nx-freetype2-devel.x86_64: W: no-dependency-on
> nx-freetype2/nx-freetype2-libs/libnx-freetype2

Fixed the naming.

> nxagent.x86_64: E: missing-call-to-setgroups /usr/lib64/nx/bin/nxagent

Ah, okay, looking into it.

> x2goagent.x86_64: W: dangling-relative-symlink /usr/lib64/x2go/bin/x2goagent
> ../../nx/bin/nxagent
> 
> * there are unversioned so-files:
> libNX_X11: /usr/lib64/nx/X11/libximcp.so
> libNX_X11: /usr/lib64/nx/X11/libxlcDef.so
> libNX_X11: /usr/lib64/nx/X11/libxlcUTF8Load.so
> libNX_X11: /usr/lib64/nx/X11/libxlibi18n.so
> libNX_X11: /usr/lib64/nx/X11/libxlocale.so
> libNX_X11: /usr/lib64/nx/X11/libxomGeneric.so
> 
> However, they seem private, so maybe it is not an issue

These are links to versioned files.


http://www.cora.nwra.com/~orion/fedora/nx/nx-libs.spec
http://www.cora.nwra.com/~orion/fedora/nx/nx-libs-3.5.0.20-4.fc18.src.rpm

* Tue Jun 11 2013 Orion Poplawski  - 3.5.0.20-4
- Fix 775 library permissions
- Move nx/X11 .so files to -devel
- Fix nx obsoletes
- Mark ld.so.conf.d files config(noreplace)
- Fix requires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IEgvjR9aBN&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 948589] Review Request: bookkeeper - Apache BookKeeper sub-project of ZooKeeper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=948589

--- Comment #19 from Fedora Update System  ---
bookkeeper-4.2.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/bookkeeper-4.2.1-1.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XpPnVRoFRY&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 972477] Review Request: fido - A multi-threaded file watch utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972477

Roman Mohr  changed:

   What|Removed |Added

 Depends On||973822

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Y2M9kWFA5y&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 917149] Review Request: openshift-origin-node-proxy - Routing proxy for OpenShift Origin Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=917149

--- Comment #1 from Troy Dawson  ---
Spec URL:
http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-proxy.spec
SRPM URL:
http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-proxy-0.9.2-1.fc20.src.rpm

- Updated to latest stable version, 0.9.2.
- Patched logrotate to use systemctl instead of service

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MryjNcqAxr&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 950281] Review Request: golang - The Go Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=950281

Paul P Komkoff Jr  changed:

   What|Removed |Added

 CC||i...@stingr.net

--- Comment #22 from Paul P Komkoff Jr  ---
Is it me or it doesn't work? If I just install golang, then export
GOPATH=/my/path
go install bla/bla it can't import pretty much anything system because sources
are not installed. If I install golang-godoc with it, it does
load cmd/cgo: package cmd/cgo: open /usr/lib64/golang/src/cmd/cgo: no such file
or directory

if I do CGO_ENABLED=0, it
CGO_ENABLED=0 go install bla/bla
go install errors: open /usr/lib64/golang/pkg/linux_amd64/errors.a: permission
denied
go install sync: open /usr/lib64/golang/pkg/linux_amd64/sync.a: permission
denied
go install unicode/utf8: open /usr/lib64/golang/pkg/linux_amd64/unicode/utf8.a:
permission denied
go install sort: open /usr/lib64/golang/pkg/linux_amd64/sort.a: permission
denied
go install unicode/utf16: open
/usr/lib64/golang/pkg/linux_amd64/unicode/utf16.a: permission denied
go install crypto/subtle: open
/usr/lib64/golang/pkg/linux_amd64/crypto/subtle.a: permission denied
go install unicode: open /usr/lib64/golang/pkg/linux_amd64/unicode.a:
permission denied

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=YLxSdso18R&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973349] Review Request: checksec - Tool to check system for binary-hardening

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973349

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #13 from Fedora Update System  ---
checksec-1.5-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=F7vqQ3DUbe&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 948589] Review Request: bookkeeper - Apache BookKeeper sub-project of ZooKeeper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=948589

--- Comment #18 from gil cattaneo  ---
sorry!
yes, fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZGvPhXPxuv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970576] Review Request: hsqldb1 - HyperSQL Database Engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970576

--- Comment #4 from Fedora Update System  ---
hsqldb1-1.8.1.3-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/hsqldb1-1.8.1.3-1.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=J0NgAxb8Gq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970576] Review Request: hsqldb1 - HyperSQL Database Engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970576

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3CsmMAEAXq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823122] Review Request: zookeeper - A high-performance coordination service for distributed applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823122

--- Comment #26 from Fedora Update System  ---
zookeeper-3.4.5-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/zookeeper-3.4.5-5.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Y2Znd9f3Ag&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823122] Review Request: zookeeper - A high-performance coordination service for distributed applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823122

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tht2IW9xST&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 880387] Review Request: python-pymongo - Python driver for MongoDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=880387

--- Comment #22 from Fedora Update System  ---
python-pymongo-2.5.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-pymongo-2.5.2-1.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=G8Mc2BTWfZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=858127

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #15 from Fedora Update System  ---
groovy18-1.8.9-2.fc19 has been pushed to the Fedora 19 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MP5OL7xsx6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973793] Review Request: python-martian - A library to grok configuration from Python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973793

Marcelo Barbosa  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3C3Gr1IdE2&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

--- Comment #5 from Mario Blättermann  ---
See also
https://lists.fedoraproject.org/pipermail/packaging/2013-June/009205.html.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=RSX66ocf6A&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

--- Comment #4 from Mario Blättermann  ---
Thanks for your quick response. I will provide new files once I know about how
to handle kbuildsycoca.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HzztmvW16a&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 965007] Review Request: gedit-trailsave - Gedit plugin who strip trailing whitespace on save

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=965007

--- Comment #10 from Guillaume Kulakowski  ---
I look other Gedit plugin and no plugin is noarch because gedit is not noarch.
Gedit take .plugin in /usr/lib64/gedit/plugins and can take other file in
/usr/share/gedit plugin.

Are you sure for the Germán's recommandation about noarch ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rHIbLWDCZA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973793] New: Review Request: python-martian - A library to grok configuration from Python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973793

Bug ID: 973793
   Summary: Review Request: python-martian - A library to grok
configuration from Python code
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: unspecified
  Assignee: nob...@fedoraproject.org
  Reporter: fireman...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org

Spec URL: http://firemanxbr.fedorapeople.org/python-martian/python-martian.spec
SRPM URL:
http://firemanxbr.fedorapeople.org/python-martian/python-martian-0.14-1.fc19.src.rpm
Description: A library that allows the embedding of configuration information
in
Python code. Martian can then grok the system and do the appropriate
configuration registrations. One example of a system that uses Martian
is the system where it originated: Grok
Fedora Account System Username: firemanxbr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cH1oFGBTQq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 972477] Review Request: fido - A multi-threaded file watch utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972477

--- Comment #12 from Björn Esser  ---
(In reply to Roman Mohr from comment #11)
> I just discovered a few minutes ago, that siege (also from the same author)
> which is already in fedora also includes lib/joedog.
> 
>...
>
> The library is in all of the GPLv2 projects of the author. I have checked
> them, they have all the same license in the header.
> 
> So I think the cleanest solution is, that I contact the author and the
> maintainer of siege and we will create a separate package for the library,
> what do you think?

Hello Roman!

Nice work!

For siege you should follow the instructions from the wiki:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#When_a_Bundled_Library_is_Discovered_Post-Review

Yes, you should contact upstream and (if you want to) work with him on shipping
a shared lib.so seperated from his other sources.

Cheers,
  Björn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0iThVYkWo4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 972477] Review Request: fido - A multi-threaded file watch utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972477

--- Comment #11 from Roman Mohr  ---
(In reply to Björn Esser from comment #9)
> (In reply to Björn Esser from comment #8)
> > [!]: %build honors applicable compiler flags or justifies otherwise.
> > 
> >  ---> {C,LD}FLAGS possibly ignored by Makefile; GOT is still writeable
> >   caused by "partial RELRO", complete RELRO needs
> > `-Wl,-z,relro,-z,now`
> >   doesn't build PIE, although %global _hardened_build 1 is in spec
> > 
> >   `hardening-check --verbose fido`
> >   fido:
> >Position Independent Executable: no, normal executable!
> >...
> >Immediate binding: no, not found!
> > 
> >   see attached build.log
> 
> Upstream's way to build the binary is the key to this:  Makefile compiles a
> STATIC-lib and links this into the sbin-exec, which makes real, useful
> hardening impossible.  Static libs can't be build as PIE and linked with
> -z,now, afaik.
> 
> You should work out a way, with upstream, avoiding this static-lib during
> build;  either it should build a shlib and link this or just building the
> sbin-exec from all single objects.

I just discovered a few minutes ago, that siege (also from the same author)
which is already in fedora also includes lib/joedog.

(In reply to Terje Røsten from comment #10)
> Some of the functions on lib/ are simple/unneeded(?), building a static lib
> for these seems like overkill.

Yes most of these functions are just convenience wrappers of the author, but I
think I have no choice, as the library is also in another package and I already
found critical bugs in there.

(In reply to Björn Esser from comment #8)
> [?]: Package complies to the Packaging Guidelines
> 
>  ---> needs check for bundled libs, esp. files with license differing
>   from upstream

The library is in all of the GPLv2 projects of the author. I have checked them,
they have all the same license in the header.


So I think the cleanest solution is, that I contact  the author and the
maintainer of siege and we will create a separate package for the library, what
do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1d78RdIpZ7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973159] Review Request: libguac-client-ssh - SSH support for guacd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973159

Mario Blättermann  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #5 from Mario Blättermann  ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5496684

$ rpmlint -i -v *libguac-client-ssh.src: I: checking
libguac-client-ssh.src: W: spelling-error Summary(en_US) guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.src: W: spelling-error %description -l en_US guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.src: I: checking-url http://guac-dev.org/ (timeout 10
seconds)
libguac-client-ssh.src: I: checking-url
http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10
seconds)
libguac-client-ssh.i686: I: checking
libguac-client-ssh.i686: W: spelling-error Summary(en_US) guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.i686: W: spelling-error %description -l en_US guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.i686: I: checking-url http://guac-dev.org/ (timeout 10
seconds)
libguac-client-ssh.i686: W: devel-file-in-non-devel-package
/usr/lib/libguac-client-ssh.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

libguac-client-ssh.x86_64: I: checking
libguac-client-ssh.x86_64: W: spelling-error Summary(en_US) guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.x86_64: W: spelling-error %description -l en_US guacd ->
guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.x86_64: I: checking-url http://guac-dev.org/ (timeout 10
seconds)
libguac-client-ssh.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libguac-client-ssh.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

libguac-client-ssh-debuginfo.i686: I: checking
libguac-client-ssh-debuginfo.i686: I: checking-url http://guac-dev.org/
(timeout 10 seconds)
libguac-client-ssh-debuginfo.x86_64: I: checking
libguac-client-ssh-debuginfo.x86_64: I: checking-url http://guac-dev.org/
(timeout 10 seconds)
libguac-client-ssh.spec: I: checking-url
http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10
seconds)
5 packages and 1 specfiles checked; 0 errors, 8 warnings.


The license is now fully canonical, also the length of the description lines.
OK, here we go:

-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MPLv1.1 or GPL+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
3ba240031304de56e7f48a59c6d40ffdeb0fd7a5bba905d4b289844d645812db 
libguac-client-ssh-0.8.0.tar.gz
3ba240031304de56e7f48a59c6d40ffdeb0fd7a5bba905d4b289844d645812db 
libguac-client-ssh-0.8.0.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be place

[Bug 948589] Review Request: bookkeeper - Apache BookKeeper sub-project of ZooKeeper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=948589

--- Comment #17 from Björn Esser  ---
(In reply to Fedora Update System from comment #16)
> hsqldb1-1.8.1.3-1.fc19 has been submitted as an update for Fedora 19.
> https://admin.fedoraproject.org/updates/hsqldb1-1.8.1.3-1.fc19

This is Bug 948589 - Review Request: bookkeeper - Apache BookKeeper sub-project
of ZooKeeper! You possibly mixed up bug#?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fKCwEOYVhm&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

--- Comment #3 from Björn Esser  ---
First view at spec:

-%global mainver 1.7
-%global gitver 18437d0
-
 Name:   kde-plasma-applicationname
-Version:%{mainver}g%{gitver}
+Version:1.7
 Release:1%{?dist}
 Summary:QML plasmoid to display the application title of the focused
window

 License:LGPLv2+
-URL:https://github.com/ascarpino/applicationname-plasmoid
-# https://github.com/ascarpino/applicationname-plasmoid/tarball/%{mainver}
-Source0:ascarpino-applicationname-plasmoid-1.7-0-g18437d0.tar.gz
+URL: https://github.com/scarpin0/applicationname-plasmoid
+Source0:
https://github.com/scarpin0/applicationname-plasmoid/archive/%{version}.tar.gz#/%{name}-{version}.tar.gz

Given URL and comment for tarball is invalid (404), according to
http://kde-apps.org/content/show.php/Application%20Name%20Plasmoid?content=154324
it's the mentioned above.

Please fix, and I'll review again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kP33sV2LY9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

Björn Esser  changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kZdopQWiuy&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

Björn Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bjoern.es...@gmail.com
 Blocks|201449 (FE-DEADREVIEW)  |
   Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pHqsN2xxI4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 948589] Review Request: bookkeeper - Apache BookKeeper sub-project of ZooKeeper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=948589

--- Comment #16 from Fedora Update System  ---
hsqldb1-1.8.1.3-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/hsqldb1-1.8.1.3-1.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ozSXra9ESa&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 948589] Review Request: bookkeeper - Apache BookKeeper sub-project of ZooKeeper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=948589

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VhMa05i7gZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

--- Comment #2 from Mario Blättermann  ---
OK, I'm back again. I can't dispense of this package, so I want to have it in
Fedora. The file links are still available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=me62vsH7Ke&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 889723] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=889723

Björn Esser  changed:

   What|Removed |Added

 Blocks|973780  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TDLW03XokT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

Björn Esser  changed:

   What|Removed |Added

 Depends On|889723  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=h7z5dqJfY1&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

--- Comment #1 from Björn Esser  ---
*** Bug 889723 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2wGXXXvMF8&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 889723] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=889723

Björn Esser  changed:

   What|Removed |Added

 CC||bjoern.es...@gmail.com
 Resolution|NOTABUG |DUPLICATE

--- Comment #2 from Björn Esser  ---


*** This bug has been marked as a duplicate of bug 973780 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=luwfHIbqpZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 973780] New: Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=973780

Bug ID: 973780
   Summary: Review Request: kde-plasma-applicationname - QML
plasmoid to display the application title of the
focused window
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mario.blaetterm...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: ke...@tigcc.ticalc.org, nott...@redhat.com,
package-review@lists.fedoraproject.org
Depends On: 889723
Blocks: 656997 (kde-reviews), 201449 (FE-DEADREVIEW)

+++ This bug was initially created as a clone of Bug #889723 +++

Spec URL:
http://mariobl.fedorapeople.org/Review/SPECS/kde-plasma-applicationname.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/kde-plasma-applicationname-1.7g18437d0-1.fc18.src.rpm
Description:
A QML plasmoid to display the application name of the focused window.

Features:
* Shows the application name of the focused windows
* Shows the activity name if no window is focused
* Optionally, it shows the window title (enable this option in the settings)
Fedora Account System Username: mariobl

I was wondering if kbuildsycoca4 is in the right place. Actually, the
instructions at
https://github.com/ascarpino/applicationname-plasmoid/wiki/Install append this
command to the installation chain. Maybe it has to be launched each time the
package is installed or uninstalled? Then I would run it via %post and %postun.
Explanations are very welcome.

--- Additional comment from Mario Blättermann on 2013-01-26 14:11:42 CET ---

I'm no longer interested to maintain this package. Closing it as FE-DEADREVIEW.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=RmfEvLLBs4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 889723] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=889723

Mario Blättermann  changed:

   What|Removed |Added

 Blocks||973780

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ayOBB4woHc&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review