[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #3 from Remi Collet fed...@famillecollet.com --- Thanks for the review New Package SCM Request === Package Name: php-pecl-redis Short Description: Extension for communicating with the Redis key-value store Owners: remi Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=okgaEbTuGra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Tomasz Torcz zdzi...@irc.pl --- New Package SCM Request === Package Name: nicstat Short Description: CLI utility that prints out network statistics for all network interface Owners: ttorcz Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ukl8VMnJlFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974720] Review Request: ghc-SafeSemaphore - Much safer replacement for QSemN, QSem, and SampleVar
https://bugzilla.redhat.com/show_bug.cgi?id=974720
Jens Petersen peter...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags||fedora-review+
--- Comment #2 from Jens Petersen peter...@redhat.com ---
BTW the spec url and srpm spec file are different but the differences
are only in the descriptions, changelog and release.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Static libraries in -static subpackage, if present.
Note: Archive *.a files found in ghc-SafeSemaphore-devel
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
SafeSemaphore-devel
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 706560 bytes in 36 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[Bug 974720] Review Request: ghc-SafeSemaphore - Much safer replacement for QSemN, QSem, and SampleVar
https://bugzilla.redhat.com/show_bug.cgi?id=974720 --- Comment #3 from Jens Petersen peter...@redhat.com --- (In reply to Jens Petersen from comment #2) Issues: === - Static libraries in -static subpackage, if present. Note: Archive *.a files found in ghc-SafeSemaphore-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries This is normal for Haskell ghc libraries. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GM7R8SeP5Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 838780] Review Request: ghc-shakespeare-text - Interpolation with quasi-quotation
https://bugzilla.redhat.com/show_bug.cgi?id=838780
Jens Petersen peter...@redhat.com changed:
What|Removed |Added
Whiteboard|Notready|
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #8 from Jens Petersen peter...@redhat.com ---
Thanks - looks okay now.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Static libraries in -static subpackage, if present.
Note: Archive *.a files found in ghc-shakespeare-text-devel
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
This is normal for Haskell ghc libraries.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
shakespeare-text-devel
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 122880 bytes in 17 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]:
[Bug 970556] Review Request: maven-stapler-plugin - Maven plugin for Stapler
https://bugzilla.redhat.com/show_bug.cgi?id=970556 --- Comment #3 from Michal Srb m...@redhat.com --- Updated version: Spec URL: http://msrb.fedorapeople.org/review/2/maven-stapler-plugin.spec SRPM URL: http://msrb.fedorapeople.org/review/2/maven-stapler-plugin-1.16-2.fc20.src.rpm Added BR: ezmorph -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JXc0gdZ1OVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967659] Review Request: robojournal - cross-platform journal/diary tool
https://bugzilla.redhat.com/show_bug.cgi?id=967659
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
CC||mschwe...@gmail.com
--- Comment #4 from Michael Schwendt mschwe...@gmail.com ---
* Try to do a self-review of your package with the help of the following page:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
[ https://fedoraproject.org/wiki/Join_the_package_collection_maintainers ]
[ https://fedoraproject.org/wiki/Category:Package_Maintainers ]
* Run rpmlint -I on all packages, the src.rpm *and* the built rpms. Apply
fixes for obvious errors/warnings, ignore false positives, preferably comment
on what rpmlint reports.
* A brief look at the spec file:
Summary:Free journal software for everyone
Summary: Cross-platform journal/diary tool
would do a better job at summing up what the package offers.
BuildRequires: qt, qt-assistant, qt-mysql, qt-devel, qt-webkit,
qt-webkit-devel, patch
1) patch is available in the minimum build environment already and need not
be specified as BuildRequires:
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
2) Double-check the others for redundancies. At least qt and qt-webkit will
be available as dependencies of qt-devel and qt-webkit-devel already.
# Apply standard Fedora patch so the app compiles properly
patch Makefile fedora_build.patch
Hmmm, this is fragile. First of all, it would be more normal to apply patches
in %prep (after %setup) via %patchX and to add them as PatchX tags in the spec
file. But since the patch file is included in the tarball, applying it manually
is acceptable. Secondly, applying a patch manually in %build like it is done
here breaks --short-circuit -bc rpmbuilds. So, apply patches in %prep.
Requires: qt, qt-assistant, qt-mysql, qt-webkit
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
make
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
strip robojournal
Don't strip any files yourself. That breaks generation of -debuginfo packages.
rpmlint will notice that, too.
https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages
#install files manually because make install doesn't work
with rpmbuild in this case.
_What_ doesn't work?
%post
mandb -p
To be deleted. Packages don't do that.
%clean
make distclean
To be deleted. make distclean is also not what %clean is used for.
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
%{_datadir}/applications/robojournal.desktop
You need to _use_ desktop-file-utils inside the spec file when packaging
.desktop files:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
%{_datadir}/menu/robojournal
The directory /usr/share/menu doesn't exist yet in Fedora filesystem packages,
and this package doesn't include it either. What is it used for? Isn't it
specific to Debian based systems?
$ repoquery --whatprovides /usr/share/menu
luckybackup-0:0.4.7-3.fc19.x86_64
%{_mandir}/man7/robojournal.7.gz
%{_mandir}/man7/robojournal.7* would be cleaner, since it allows for a
changed/customised/dropped compression technique.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=dIeJaVKy28a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974145] Review Request: bluez5 - Bluetooth v5 utilities
https://bugzilla.redhat.com/show_bug.cgi?id=974145
--- Comment #3 from Björn Esser bjoern.es...@gmail.com ---
Created attachment 761959
-- https://bugzilla.redhat.com/attachment.cgi?id=761959action=edit
improvements for spec-file
Hi Don!
Just took a deeper look inside spec-file:
* arch-conditionals on BRs:
%ifnarch s390 s390x
BuildRequires: libusbx-devel
%endif
--- There's a discussion around on f-packaging ml. [1]
You should possibly track where it'll lead to and
act on this accordingly.
Some changes I'd propose (as in attached patch):
-Source: http://www.kernel.org/pub/linux/bluetooth/bluez-%{version}.tar.xz
+Source0: http://www.kernel.org/pub/linux/bluetooth/bluez-%{version}.tar.xz
Just cosmetic...
-BuildRequires: git
-BuildRequires: flex
-BuildRequires: dbus-devel = 0.90
-BuildRequires: libusb-devel, glib2-devel
+BuildRequires: git flex dbus-devel
+BuildRequires: libusb-devel glib2-devel
reduced lines, dbus-devel has more recent ver in F17+, so no need for explicit
min-version.
-BuildRequires: libtool autoconf automake
+BuildRequires: libtool
autotools are pulled on libtool requires.
-Requires: bluez5-libs = %{version}-%{release}
+Requires: bluez5-libs%{?_isa} = %{version}-%{release}
requires should be arched, when package is arched as well.
-Requires: dbus = 0.60
dbus is added from autorequires
-Requires: hwdata = 0.215
+Requires: hwdata
hwdata has more recent ver in F17+, so no need for explicit min-version.
-Obsoletes: bluez
...
+Obsoletes: bluez = 4.94-4
...
reduce rpmlint complains...
-Requires: hwdata = 0.215
-Requires(preun): /bin/systemctl
-Requires(post): /bin/systemctl
+# conditional and %%else and be safely removed, if not intended for F18
+%if 0%{?fedora} = 18 || 0%{?rhel} = 7
+%{systemd_requires}
+%else
+Requires(post): systemd-units
+Requires(preun): systemd-units
+Requires(postun): systemd-units
+%endif
+# conditional and %%else and be safely removed, if not intended for F18
+%if 0%{?fedora} = 18 || 0%{?rhel} = 7
+%post
+%systemd_post bluetooth.service
+
+%preun
+%systemd_preun bluetooth.service
+
+%postun
+%systemd_postun_with_restart bluetooth.service
+%else
There are special systemd-macros avail on F18+
-- hcitool
...
+- hcitool
...
mixed use of spaces and tabs...
-make V=1
+make V=1 %{?_smp_mflags}
enable parallel build
-make install DESTDIR=$RPM_BUILD_ROOT
+%make_install
exchanged with macro, not mandatory
/sbin/ldconfig -n %{buildroot}%{_libdir}
What is this used for?
-%triggerun -- bluez 4.94-4
-/bin/systemctl --no-reload enable bluetooth.service /dev/null 21 || :
+%triggerun -- bluez = 4.94-4
+if /sbin/chkconfig --level 5 bluetooth ; then
+/bin/systemctl --no-reload enable bluetooth.service /dev/null 21 ||
:
+fi
+
+%post libs -p /sbin/ldconfig
respect admin's sysconfig on upgrade-path. only enable service by default, if
was so before.
generally I made some simplifications in spec, too, but don't want to comment
here, since will spam the list with not really useful comments...
[1] https://lists.fedoraproject.org/pipermail/packaging/2013-June/009206.html
If you want, I can take full review.
Cheers,
Björn
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UAuTbNmzmJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921797] Review Request: pypolicyd-spf - SPF Policy Server for Postfix (Python implementation)
https://bugzilla.redhat.com/show_bug.cgi?id=921797 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #23 from Michael Schwendt mschwe...@gmail.com --- Packages aren't sponsored, people are. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=43DlCNFw8ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974852] Review Request: fish - A Friendly Interactive SHell
https://bugzilla.redhat.com/show_bug.cgi?id=974852 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added CC||mschwe...@gmail.com --- Comment #1 from Michael Schwendt mschwe...@gmail.com --- Note that it's a retired (deprecated) package due to lack of a maintainer and will need to be unretired. http://pkgs.fedoraproject.org/cgit/fish.git/ - http://pkgs.fedoraproject.org/cgit/fish.git/plain/dead.package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ADQL4oOhm1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974852] Review Request: fish - A Friendly Interactive SHell
https://bugzilla.redhat.com/show_bug.cgi?id=974852 --- Comment #2 from Michael Schwendt mschwe...@gmail.com --- http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Deprecated_Package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B6L1S2TkQda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971244] Review Request: adevs - C++ library for constructing discrete event simulation
https://bugzilla.redhat.com/show_bug.cgi?id=971244 --- Comment #4 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to Jan Kaluža from comment #3) OK, thanks, please name the documentation subpackage as 'doc', not 'docs': http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation Also I would prefer all the docs to be placed in the directory: /usr/share/doc/adevs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7vLvLAFaW6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894482] Review Request: rubygem-openshift-origin-auth-kerberos - OpenShift plugin for kerberos auth service
https://bugzilla.redhat.com/show_bug.cgi?id=894482
--- Comment #17 from Vít Ondruch vondr...@redhat.com ---
(In reply to Troy Dawson from comment #16)
- Reworked the doc section
-- added noarch
--- I put this in, but isn't this redundant because the package itself is a
noarch?
Oh, sorry ... you are right. I did not realized that. My bad.
* Is the %{gem_instdir}/conf worth of keeping?
- Since its content is already copied into /etc, is the folder worth of
keeping? Just asking ...
- Reworked %build section
-- Yes, it was originally that way because it is supposed to build on RHEL6.
-- It just looks to ugly to have the if statement, and since this will not
be going into EPEL6, I did a complete replacement with the %gem_install
macro.
Well, you can always define the macro on top of the .spec file, if not
available. That is IMO a bit better approach, since you don't pollute whole
.spec file with ifdefs, there would be just one section on top.
-- Side note. I would love for that to make it into the RHEL6
rubygems-devel package. It is so much cleaner.
Yay, me too. I am trying to push PMs as much as I can, but still not sure if my
effort will be successful in near future :/
- Macroize /etc
-- This is due to the scl macro's. If we use the %{_sysconfdir} variable,
scl changes that from /etc/ to /opt/rh/version/root/etc/ while then breaks
everything.
As guidelines strongly encourages usage of macros [1], I must strongly
encourage you to use them as well.
BTW, are you aware of %{_root_sysconfdir} SCL macro? You might try to redefine
%{_sysconfdir} back to %{_root_sysconfdir} for SCL build or something less
magical, i.e. define new constant which will differ for SCL and non-SCL builds.
Actually, on second look, you are installing there just some .example file, not
actual configuration, so not sure if it wouldn't be better to entirely forget
about installing it into /etc and you would have this issue solved as well as
the %{gem_instdir}/conf issue and you would get rid of
rubygem-openshift-origin-auth-kerberos-doc.noarch: W: non-conffile-in-etc
/etc/openshift/plugins.d/openshift-origin-auth-kerberos.conf.example rpmlint
warning.
* The runtime dependencies are not fulfilled
- I observe following error:
irb(main):002:0 require 'openshift-origin-auth-kerberos'
Gem::LoadError: Could not find 'moped' (~ 1.4.2) - did find: [moped-1.5.0]
- It seems that we have in fedora newer version of rubygem-moped then OO
needs.
* Description
- Isn't the description too brief? It even does not mention OpenShift,
although one could deduce it from the package name. Please consider to
provide better description.
[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=50ZBjuGvega=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832853] Review Request: java3d - Java 3D
https://bugzilla.redhat.com/show_bug.cgi?id=832853 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added CC||susi.leht...@iki.fi --- Comment #19 from Susi Lehtola susi.leht...@iki.fi --- (In reply to Harvey Harrison from comment #17) Updating status, I've removed the Java3d core dependency from j3dutils for all but one class which I'm still working one. The class in question is com.sun.j3d.internal.Distance which is a collection of static math functions ported from the 'Wild Magic' library according to the file header. Once this is removed, Java3d and vecmath should be OK to go into fedora. Vecmath is already in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wd6XgbiHRja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #26 from Darryl L. Pierce dpie...@redhat.com --- Package Change Request == Package Name: perl-qpid New Branches: el5 el6 Owners: mcpierce -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eOep134YTsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974145] Review Request: bluez5 - Bluetooth v5 utilities
https://bugzilla.redhat.com/show_bug.cgi?id=974145 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Attachment #761959|0 |1 is obsolete|| Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com --- Comment #4 from Björn Esser bjoern.es...@gmail.com --- Created attachment 762006 -- https://bugzilla.redhat.com/attachment.cgi?id=762006action=edit improvements for spec-file with proper upgrade-path Forgot to encounter a proper upgrade-path from old bluez, but here comes now. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dYdP6UlLM1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736861] Review Request: hgview - A fast Mercurial log navigator for qt4 or curses
https://bugzilla.redhat.com/show_bug.cgi?id=736861
--- Comment #19 from Björn Esser bjoern.es...@gmail.com ---
Created attachment 762010
-- https://bugzilla.redhat.com/attachment.cgi?id=762010action=edit
improvements for spec-file
(In reply to Mads Kiilerich from comment #18)
Thank you for the opinion and advice.
I am still convinced that curses should be a separate package. Installing
hgview-curses can take 7.5 MB on disk including the dependencies.
The other way round one can argue about hgview pulling in half-a-desktop,
even if user just needs/wants ncurses interface, e.g. on terminal-only machine.
So I though a bit about it and come in with another aproach making both sides
happy, I hope.
When you have a look at the attached patch, you'll see I changed package-order
a bit. There are three pkgs now: hgview (is what was former -common) depending
hgview-ui and hgview-{curses,qt} providing hgview-ui, requiring hgview.
This results in
a) the user can choose which ui to install
b) even just installing hgview will install an ui, so we have a working base
install. Yum should be smart enough to pull in the
cheaper = less bandwith/disk ui.
What's your opinion to this?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=YPbCgt5n0za=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #27 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7wKFUACyrQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pq8gxJ7B65a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852214] Review Request: overpass-fonts - Typeface based on the U.S. interstate highway road signage type system
https://bugzilla.redhat.com/show_bug.cgi?id=852214 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nbCxfB6JBFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852214] Review Request: overpass-fonts - Typeface based on the U.S. interstate highway road signage type system
https://bugzilla.redhat.com/show_bug.cgi?id=852214 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vAs9BJhuPea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v4jdHhbyYwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wUQP5l5Zxua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911025] Review Request: nodejs-collections - Data structures with idiomatic JavaScript collection interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=911025 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3J58N5sxgVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911025] Review Request: nodejs-collections - Data structures with idiomatic JavaScript collection interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=911025 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ilVTmPjNlia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911029] Review Request: nodejs-dep-graph - Node.js module for simple dependency graph management in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=911029 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oYnwTQkcEPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911034] Review Request: nodejs-i - Custom inflections for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911034 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KDbVY4JInca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911034] Review Request: nodejs-i - Custom inflections for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911034 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pH5kfDLE9Ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911029] Review Request: nodejs-dep-graph - Node.js module for simple dependency graph management in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=911029 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9OXxkZCBb5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911035] Review Request: nodejs-isodate - JavaScript ISO 8601 date/time parser for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911035 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7APe7cdLYma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911035] Review Request: nodejs-isodate - JavaScript ISO 8601 date/time parser for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911035 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mc1w9VI3tNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911038] Review Request: nodejs-mimeparse - A Node.js module with basic functions for handling mime-types
https://bugzilla.redhat.com/show_bug.cgi?id=911038 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lgtEfpPV8Ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911038] Review Request: nodejs-mimeparse - A Node.js module with basic functions for handling mime-types
https://bugzilla.redhat.com/show_bug.cgi?id=911038 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IHYUEhWcp5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970556] Review Request: maven-stapler-plugin - Maven plugin for Stapler
https://bugzilla.redhat.com/show_bug.cgi?id=970556
gil cattaneo punto...@libero.it changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from gil cattaneo punto...@libero.it ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in maven-
stapler-plugin-javadoc
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), BSD (2 clause), Unknown or generated. 5 files have
unknown license.
CDDL: src/main/java/org/kohsuke/stapler/AptMojo.java
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=771U4wfZ0Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DqSPwwSpC7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kN9cfyJRava=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HJEGqZNKpYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0hl04t3OrOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tcKGBRTPgca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window
https://bugzilla.redhat.com/show_bug.cgi?id=973780 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mTqfG533SEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window
https://bugzilla.redhat.com/show_bug.cgi?id=973780 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CwRSaGH6eva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970556] Review Request: maven-stapler-plugin - Maven plugin for Stapler
https://bugzilla.redhat.com/show_bug.cgi?id=970556 Michal Srb m...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Michal Srb m...@redhat.com --- Thanks for the review, I will fix the license tag. New Package SCM Request === Package Name: maven-stapler-plugin Short Description: Maven plugin for Stapler Owners: msrb sochotni tradej mizdebsk Branches: f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hLJADmJ8Ica=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=973904 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QXTaC5uhGKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=973904 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O8BuTng28ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QveVShgUdpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KopZW4KIXJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970556] Review Request: maven-stapler-plugin - Maven plugin for Stapler
https://bugzilla.redhat.com/show_bug.cgi?id=970556 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ftsFnHe6Mga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 970556] Review Request: maven-stapler-plugin - Maven plugin for Stapler
https://bugzilla.redhat.com/show_bug.cgi?id=970556 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yebq6YlPV9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Unretired, please take ownership in pkgdb and submit a Package Change request for additional branches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FqF4ggCiHfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736861] Review Request: hgview - A fast Mercurial log navigator for qt4 or curses
https://bugzilla.redhat.com/show_bug.cgi?id=736861 --- Comment #20 from Mads Kiilerich m...@kiilerich.com --- (In reply to Björn Esser from comment #19) The other way round one can argue about hgview pulling in half-a-desktop, even if user just needs/wants ncurses interface, e.g. on terminal-only machine. If the user wants hgview-curses without the qt stuff in hgview then he just installs hgview-curses. What's your opinion to this? My opinion is that you are proposing changes that might be another valid way to do this packaging but wouldn't improve the packaging. Thanks for sharing your opinion, but it is hardly relevant for a review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UWlfiAFylha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3jABF2ZhWra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971244] Review Request: adevs - C++ library for constructing discrete event simulation
https://bugzilla.redhat.com/show_bug.cgi?id=971244 --- Comment #5 from Jan Kaluža jkal...@redhat.com --- Spec URL: http://jkaluza.fedorapeople.org/adevs.spec SRPM URL: http://jkaluza.fedorapeople.org/adevs-2.6-3.fc18.src.rpm Should be fixed there ^. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wMFORvfR2ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Package Change Request == Package Name: lifeograph New Branches: f18 f19 Owners: ankursinha InitialCC: Taken ownership. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7YSjpxdQXDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- nicstat-1.92-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nicstat-1.92-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W47BhA37N5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tdxtdboYgZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- nicstat-1.92-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nicstat-1.92-5.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SZd1JljqOBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6czJAl7lzpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973868] Re-Review Request: lifeograph - A diary program
https://bugzilla.redhat.com/show_bug.cgi?id=973868 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jujZ5ufFhqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736861] Review Request: hgview - A fast Mercurial log navigator for qt4 or curses
https://bugzilla.redhat.com/show_bug.cgi?id=736861
Björn Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #21 from Björn Esser bjoern.es...@gmail.com ---
Package is fine.
#
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- update-desktop-database is invoked when required
Note: desktop file(s) in hgview
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
--- false positive: icon is installed as pixmap.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 8 files have unknown
license. Detailed output of licensecheck in
/home/bjoern.esser/fedora/review/736861-hgview/licensecheck.txt
--- License-Tag is fine.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]:
[Bug 975041] New: Review Request: sblim-sfcCommon
https://bugzilla.redhat.com/show_bug.cgi?id=975041 Bug ID: 975041 Summary: Review Request: sblim-sfcCommon Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: vcrho...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://vcrhonek.fedorapeople.org/sblim-sfcCommon/sblim-sfcCommon.spec SRPM URL: http://vcrhonek.fedorapeople.org/sblim-sfcCommon/sblim-sfcCommon-1.0.1-1.fc18.src.rpm Description: Common library for sblim-sfcb and sblim-sfcc -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NMDvnJ6CpIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919592] Review Request: cxmanage - a tool to manage Calxeda servers
https://bugzilla.redhat.com/show_bug.cgi?id=919592 --- Comment #3 from Jeff Bastian jbast...@redhat.com --- I have updated the package with the latest version from upstream to cxmanage-0.8.2 Spec URL: http://people.redhat.com/~jbastian/cxmanage/specs/cxmanage.spec SRPM URL: http://people.redhat.com/~jbastian/cxmanage/Fedora18/cxmanage-0.8.2-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ccZsaJm2cIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919591] Review Request: python-pyipmi - an IPMI module for Python
https://bugzilla.redhat.com/show_bug.cgi?id=919591 --- Comment #5 from Jeff Bastian jbast...@redhat.com --- I have updated the python-pyipmi package to the latest version from upstream python-pyipmi-0.7.1 Spec URL: http://people.redhat.com/~jbastian/cxmanage/specs/python-pyipmi.spec SRPM URL: http://people.redhat.com/~jbastian/cxmanage/Fedora18/python-pyipmi-0.7.1-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jk7JGaAE0ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830869] Review Request: hpl - A Portable Implementation of the High-Performance Linpack Benchmark
https://bugzilla.redhat.com/show_bug.cgi?id=830869 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #5 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to Jason Tibbitts from comment #4) Spec URL: http://jskarvad.fedorapeople.org/hpl/hpl.spec SRPM URL: http://jskarvad.fedorapeople.org/hpl/hpl-2.1-2.fc18.src.rpm I'm slightly confused; does this not support serial mode at all (i.e. can it run without MPI)? I was not able to compile it without MPI, it seems to be mandatory. It would probably require more patching to make it optional. Also, I'm not seeing the -common package which the guidelines mandate. (It does look like those guidelines, or at least the examples, need fixing now that we don't ship lam.) Added. I don't understand why you play sed games with _smp_mflags instead of just calling make without passing _smp_mflags. What benefit is there from calling make -j1 instead of just calling make? And even if there was something, why not then actually call make -j1 instead of cooking up a macro that does the same thing? The most safe way to work with probably any _smp_mflags value, e.g. it would handle any possible future extensions of these flags. Maybe a bit over-engineered, so I made it simple as proposed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XGApKjYJcsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966732] Review Request: mailman3-fedmsg-plugin - Emit fedmsg messages from mailman3
https://bugzilla.redhat.com/show_bug.cgi?id=966732 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-06-17 09:54:54 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L06iqbq4cza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749291] Review Request: dpm-xrootd - xroot interface to the Disk Pool Manager (DPM)
https://bugzilla.redhat.com/show_bug.cgi?id=749291 Adrien Devresse ade...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2013-06-17 10:11:07 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l6g6pIHScPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749291] Review Request: dpm-xrootd - xroot interface to the Disk Pool Manager (DPM)
https://bugzilla.redhat.com/show_bug.cgi?id=749291 Adrien Devresse ade...@gmail.com changed: What|Removed |Added Resolution|NOTABUG |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZkPcDAAtHza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883413] Review Request: java-dirq - Directory based queue
https://bugzilla.redhat.com/show_bug.cgi?id=883413 Adrien Devresse ade...@gmail.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-06-17 10:11:37 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HuvdBM3xE6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-grokmirror-0.3.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-grokmirror-0.3.4-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fiUJfagO1Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=md5Q3VDk36a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-grokmirror-0.3.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-grokmirror-0.3.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DujyYbKIWpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-grokmirror-0.3.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-grokmirror-0.3.4-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8QLwDuZgota=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971244] Review Request: adevs - C++ library for constructing discrete event simulation
https://bugzilla.redhat.com/show_bug.cgi?id=971244 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #6 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to Jan Kaluža from comment #5) Thanks, giving it fedora review +. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DwmeUItcQ0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971244] Review Request: adevs - C++ library for constructing discrete event simulation
https://bugzilla.redhat.com/show_bug.cgi?id=971244 Jan Kaluža jkal...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jan Kaluža jkal...@redhat.com --- New Package SCM Request === Package Name: adevs Short Description: C++ library for constructing discrete event simulation Owners: jkaluza Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pw3j2Q8Ce7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832853] Review Request: java3d - Java 3D
https://bugzilla.redhat.com/show_bug.cgi?id=832853 --- Comment #20 from Eric Smith space...@gmail.com --- And the work I did on packaging upstream Java3d, and more recently on Harvey's fork, has been based on using the existing Fedora vecmath package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lAEeqduBNNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974348] Review Request: python-itsdangerous - Python library for passing trusted data to untrusted environments
https://bugzilla.redhat.com/show_bug.cgi?id=974348 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Ricky Elrod rel...@redhat.com --- Looks good. Look forward to having this so I can update Flask. :) APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ncwx8VFe6aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pyglet-1.2-0.5.alpha1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jZOVcpRKe0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #14 from Michael Schwendt mschwe...@gmail.com --- Alejandro, you can Take ownership in pkgdb now thanks to Kevin Fenzi. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EB9IICYghca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Alejandro, you now own the devel branch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ip9OgOrFbNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971244] Review Request: adevs - C++ library for constructing discrete event simulation
https://bugzilla.redhat.com/show_bug.cgi?id=971244 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6JS6ciFDYQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971244] Review Request: adevs - C++ library for constructing discrete event simulation
https://bugzilla.redhat.com/show_bug.cgi?id=971244 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ecbunT7FmYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: python-pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- python-pyglet-1.2-0.5.alpha1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pyglet-1.2-0.5.alpha1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5JUOYKNwhKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971049] Review Request: davix - Toolkit for Http-based file management
https://bugzilla.redhat.com/show_bug.cgi?id=971049 --- Comment #5 from Adrien Devresse ade...@gmail.com --- Adrien, you forgot to update the changelog in the spec file. Done New Updates : Spec : http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/davix.spec SRPM: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgutil/tar/davix-0.2.2-1.el5.centos.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Biuevn06v8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qY70ibzLnua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- php-pecl-redis-2.2.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-pecl-redis-2.2.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9ZiiJL0QeHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- php-pecl-redis-2.2.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-pecl-redis-2.2.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SaZDDIDRvDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958129] Review Request: php-pecl-redis - Extension for communicating with the Redis key-value store
https://bugzilla.redhat.com/show_bug.cgi?id=958129 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- php-pecl-redis-2.2.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pecl-redis-2.2.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q502rGBQaRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- nicstat-1.92-5.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RwTbrePJJea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-grokmirror-0.3.4-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pq4UtiNdOPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=973904 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- Package libserf-1.2.1-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing libserf-1.2.1-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-11042/libserf-1.2.1-3.fc19 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qhgdaeGBEna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- syntaxhighlighter-3.0.83-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/syntaxhighlighter-3.0.83-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SeoPW6WElaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YGc4bmsgOwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- syntaxhighlighter-3.0.83-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/syntaxhighlighter-3.0.83-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6rerFyJ5zja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972605] Review Request: ghc-extensible-exceptions - Extensible exceptions
https://bugzilla.redhat.com/show_bug.cgi?id=972605
Shakthi Kannan shakthim...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Shakthi Kannan shakthim...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
extensible-exceptions-devel
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 194560 bytes in 17 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- syntaxhighlighter-3.0.83-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/syntaxhighlighter-3.0.83-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GQSPnhcIoBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 838780] Review Request: ghc-shakespeare-text - Interpolation with quasi-quotation
https://bugzilla.redhat.com/show_bug.cgi?id=838780 Ben Boeckel maths...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Ben Boeckel maths...@gmail.com --- New Package SCM Request === Package Name: ghc-shakespeare-text Short Description: Interpolation with quasi-quotation Owners: mathstuf Branches: f18 f19 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rzbwM7OyDCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974720] Review Request: ghc-SafeSemaphore - Much safer replacement for QSemN, QSem, and SampleVar
https://bugzilla.redhat.com/show_bug.cgi?id=974720 Ben Boeckel maths...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Ben Boeckel maths...@gmail.com --- New Package SCM Request === Package Name: ghc-SafeSemaphore Short Description: Much safer replacement for QSemN, QSem, and SampleVar Owners: mathstuf Branches: f18 f19 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=miCiJlx6Pra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 838780] Review Request: ghc-shakespeare-text - Interpolation with quasi-quotation
https://bugzilla.redhat.com/show_bug.cgi?id=838780 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TfyQ9MLe4Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 838780] Review Request: ghc-shakespeare-text - Interpolation with quasi-quotation
https://bugzilla.redhat.com/show_bug.cgi?id=838780 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tQ3w9d3Z1Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974720] Review Request: ghc-SafeSemaphore - Much safer replacement for QSemN, QSem, and SampleVar
https://bugzilla.redhat.com/show_bug.cgi?id=974720 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aELfuSdNgua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
