[Bug 986172] Review Request: jackson-databind - General data-binding package for Jackson (2.x)
https://bugzilla.redhat.com/show_bug.cgi?id=986172 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hDrwJtKWHG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986170] Review Request: jackson-core - Core part of Jackson
https://bugzilla.redhat.com/show_bug.cgi?id=986170 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qL26l1Lab3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986175] Review Request: jackson-module-jaxb-annotations - JAXB annotations support for Jackson (2.x)
https://bugzilla.redhat.com/show_bug.cgi?id=986175 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i9buq4DUvh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986165] Review Request: jackson-annotations - Core annotations for Jackson data processor
https://bugzilla.redhat.com/show_bug.cgi?id=986165 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wKK4yZkGov&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986175] New: Review Request: jackson-module-jaxb-annotations - JAXB annotations support for Jackson (2.x)
https://bugzilla.redhat.com/show_bug.cgi?id=986175 Bug ID: 986175 Summary: Review Request: jackson-module-jaxb-annotations - JAXB annotations support for Jackson (2.x) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jackson-module-jaxb-annotations.spec SRPM URL: http://gil.fedorapeople.org/jackson-module-jaxb-annotations-2.2.2-1.fc19.src.rpm Description: Support for using JAXB annotations as an alternative to "native" Jackson annotations, for configuring data binding. Fedora Account System Username: gil This is a re-review request for a package rename, jackson2-module-jaxb-annotations -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4intjvTYdg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986172] New: Review Request: jackson-databind - General data-binding package for Jackson (2.x)
https://bugzilla.redhat.com/show_bug.cgi?id=986172 Bug ID: 986172 Summary: Review Request: jackson-databind - General data-binding package for Jackson (2.x) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jackson-databind.spec SRPM URL: http://gil.fedorapeople.org/jackson-databind-2.2.2-1.fc19.src.rpm Description: General data-binding functionality for Jackson: works on core streaming API. Fedora Account System Username: gil This is a re-review request for a package rename, jackson2-databind -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fk862eqBG9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986170] New: Review Request: jackson-core - Core part of Jackson
https://bugzilla.redhat.com/show_bug.cgi?id=986170 Bug ID: 986170 Summary: Review Request: jackson-core - Core part of Jackson Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jackson-core.spec SRPM URL: http://gil.fedorapeople.org/jackson-core-2.2.2-1.fc19.src.rpm Description: Core part of Jackson that defines Streaming API as well as basic shared abstractions. Fedora Account System Username: gil This is a re-review request for a package rename, jackson2-core -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aOxjiArp32&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986165] New: Review Request: jackson-annotations - Core annotations for Jackson data processor
https://bugzilla.redhat.com/show_bug.cgi?id=986165 Bug ID: 986165 Summary: Review Request: jackson-annotations - Core annotations for Jackson data processor Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jackson-annotations.spec SRPM URL: http://gil.fedorapeople.org/jackson-annotations-2.2.2-1.fc19.src.rpm Description: Core annotations used for value types, used by Jackson data-binding package. Fedora Account System Username: gil This is a re-review request for a package rename, jackson2-annotations -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ej1nuO5ZDk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984800] Review Request: ghc-monad-logger - Monads for logging messages
https://bugzilla.redhat.com/show_bug.cgi?id=984800 --- Comment #6 from Jens Petersen --- imported to master -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3guKTOM1Z0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984796] Review Request: ghc-cookie - HTTP cookie parsing and rendering
https://bugzilla.redhat.com/show_bug.cgi?id=984796 --- Comment #6 from Jens Petersen --- committed to master -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BzcsZR0ZIO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985247] Review Request: jackson-jaxrs-providers - Jackson JAX-RS providers
https://bugzilla.redhat.com/show_bug.cgi?id=985247 gil cattaneo changed: What|Removed |Added Summary|Review Request: |Review Request: |jackson2-jaxrs-providers - |jackson-jaxrs-providers - |Jackson JAX-RS providers|Jackson JAX-RS providers --- Comment #3 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/jackson-jaxrs-providers.spec SRPM URL: http://gil.fedorapeople.org/jackson-jaxrs-providers-2.2.2-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hhACPCAvUv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984791] Review Request: ghc-attoparsec-conduit - Consume attoparsec parsers via conduit
https://bugzilla.redhat.com/show_bug.cgi?id=984791 --- Comment #6 from Jens Petersen --- Imported to git. Will build after koji outage is over tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=al36NbFO1O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878421] Review Request: rubygem-bundler_ext - Load system gems via Bundler DSL
https://bugzilla.redhat.com/show_bug.cgi?id=878421
Bohuslav "Slavek" Kabrda changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(bkab...@redhat.co |
|m) |
--- Comment #14 from Bohuslav "Slavek" Kabrda ---
(In reply to Ken Dreyer from comment #13)
> Hi Slavek, I know you have a lot on your plate, so if you would like to hand
> the review over to Christopher or myself, please un-assign this review.
Huh, sorry, I totally forgot I'm assigned to this.
The package looks fine, just a small comment - is "0%{?rhel:1}" really
necessary? Wouldn't "0%{?rhel}" suffice? (same applies to "0%{fedora:1}")
But this is just a nit and the package is ok otherwise, so APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=olBqXMDKZq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985967] Review Request: python-arc - Autotest RPC Client libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=985967
Christopher Meng changed:
What|Removed |Added
CC||cicku...@gmail.com
Blocks||177841 (FE-NEEDSPONSOR)
--- Comment #2 from Christopher Meng ---
You forgot to block needsponsor. No problem.
I honestly think that you can drop this:
%define shortname arc
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif
If you are still interested in EPEL5.
And a question is here, will you push the package to a very old system?
I'm waiting for your answer(this will affect the spec issue.)
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=TGX0neWxnA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973493] (Re-)Review Request: mpich - A high-performance implementation of MPI
https://bugzilla.redhat.com/show_bug.cgi?id=973493 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Christopher Meng --- Yes I know these handy problems. SO approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CQDe8TiXgj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985232] Review Request: jackson-dataformat-xml - XML data binding extension for Jackson
https://bugzilla.redhat.com/show_bug.cgi?id=985232 gil cattaneo changed: What|Removed |Added Summary|Review Request: |Review Request: |jackson2-dataformat-xml - |jackson-dataformat-xml - |XML data binding extension |XML data binding extension |for Jackson |for Jackson --- Comment #2 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/jackson-dataformat-xml.spec SRPM URL: http://gil.fedorapeople.org/jackson-dataformat-xml-2.2.2-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=09HtlHUtME&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985231] Review Request: jackson-dataformat-smile - Support for reading and writing Smile encoded data
https://bugzilla.redhat.com/show_bug.cgi?id=985231 gil cattaneo changed: What|Removed |Added Summary|Review Request: |Review Request: |jackson2-dataformat-smile - |jackson-dataformat-smile - |Support for reading and |Support for reading and |writing Smile encoded data |writing Smile encoded data --- Comment #2 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/jackson-dataformat-smile.spec SRPM URL: http://gil.fedorapeople.org/jackson-dataformat-smile-2.2.2-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LHMkccGvz9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 983901] Review Request: ghc-path-pieces - Components of paths
https://bugzilla.redhat.com/show_bug.cgi?id=983901 --- Comment #6 from Jens Petersen --- imported to master branch -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fOqcq9qmB4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984700] Review Request: sddm - QML based X11 desktop manager
https://bugzilla.redhat.com/show_bug.cgi?id=984700 --- Comment #9 from Christopher Meng --- No problems here. Only 1 thing, you should add README and CONTRIBUTORS and especially COPYING as %doc. Once you upload the -4 spec, I'll approve. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nbWUNMtuCe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889261] Review Request: globus-gram-job-manager-lsf - Globus Toolkit - LSF Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=889261 --- Comment #12 from Mattias Ellert --- Hi again Sorry for the delay. I found this new guideline about banning isa from BR so extremely stupid that I thought I would make an attempt to have it revoked before deliberately crippling the spec file. Unfortunately FPC is not very responsive and my ticket just sits there without any action taken. Anyway, this is a battle I will have to have with FPC and not with you, so here is a new version of the package complying to the new guideline: Spec URL: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-lsf.spec SRPM URL: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-lsf-1.1-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2ZwFm0ZfUl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889262] Review Request: globus-gridmap-verify-myproxy-callout - Globus Toolkit - Globus gridmap myproxy callout
https://bugzilla.redhat.com/show_bug.cgi?id=889262 --- Comment #7 from Mattias Ellert --- Hi again Sorry for the delay. I found this new guideline about banning isa from BR so extremely stupid that I thought I would make an attempt to have it revoked before deliberately crippling the spec file. Unfortunately FPC is not very responsive and my ticket just sits there without any action taken. Anyway, this is a battle I will have to have with FPC and not with you, so here is a new version of the package complying to the new guideline: Spec URL: http://www.grid.tsl.uu.se/review/globus-gridmap-verify-myproxy-callout.spec SRPM URL: http://www.grid.tsl.uu.se/review/globus-gridmap-verify-myproxy-callout-1.0-4.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7vitHCAECY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878421] Review Request: rubygem-bundler_ext - Load system gems via Bundler DSL
https://bugzilla.redhat.com/show_bug.cgi?id=878421 Christopher Meng changed: What|Removed |Added Flags||needinfo?(bkab...@redhat.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WZBGRGBM8f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 981834] Review Request: patool - A portable archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=981834 Christopher Meng changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=khKyrTccD4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977638] Review Request: python-espeak - Python bindings for espeak
https://bugzilla.redhat.com/show_bug.cgi?id=977638 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #8 from Christopher Meng --- Please remove buildroot tag. I think you copied the spec for opensuse, as Fedora seldom has packages using %fdupes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iZe4Xzky8S&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977638] Review Request: python-espeak - Python bindings for espeak
https://bugzilla.redhat.com/show_bug.cgi?id=977638 --- Comment #7 from Eduardo Mayorga Téllez --- rpmlint error fixed https://dl.dropboxusercontent.com/u/29661704/2/python-espeak.spec https://dl.dropboxusercontent.com/u/29661704/2/python-espeak-0.4-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NwuB4bjNqP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985917] Review Request: gnotime - Tracks and reports time spent
https://bugzilla.redhat.com/show_bug.cgi?id=985917 --- Comment #2 from Jon Ciesla --- No, it's in BuildRequires, and RPM will pick up the solib. It's better to let RPM handle Requires whenever possible. http://fedoraproject.org/wiki/Packaging:Guidelines#Requires -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0zfhigdaPN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985917] Review Request: gnotime - Tracks and reports time spent
https://bugzilla.redhat.com/show_bug.cgi?id=985917 Peter Ajamian changed: What|Removed |Added CC||pe...@pajamian.dhs.org --- Comment #1 from Peter Ajamian --- Don't we need compat-gtkhtml314 as a Requires in the spec? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L1BAcKho9t&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950699] Review Request: python-path - A python module wrapper for os.path
https://bugzilla.redhat.com/show_bug.cgi?id=950699 Christopher Meng changed: What|Removed |Added Severity|medium |urgent -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2gblk9ZFMJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985065] Review Request: peg-solitaire - Board game played with pegs
https://bugzilla.redhat.com/show_bug.cgi?id=985065 --- Comment #8 from Christopher Meng --- (In reply to Mario Blättermann from comment #6) > (In reply to Mario Blättermann from comment #5) > > OK, then it has to be changed in the wiki. There must not be a difference > > between the "law" and the "practice". And in no case we may assume that an > > "experienced packager" knows about that. Then we could also assume a lot of > > more things, and we could shrink the guidelines to a minimum. > > Sorry for the blurb... Just found the correct usage in the scriptlets > collection [1]: > > "Use this when a desktop entry has a 'MimeType key." > > But it is somewhat strage, though. Such a hint should be in the packaging > guidelines, not in the scriptlets collection only. > > [1] > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database Yep, you can raise a ticket to FPC later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ULqnZYm2sP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950699] Review Request: python-path - A python module wrapper for os.path
https://bugzilla.redhat.com/show_bug.cgi?id=950699 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo?(lxt...@gmail.com) --- Comment #12 from Christopher Meng --- Hi reporter, 1. You pushed package to update-testing but not stable after months, this is very bad; 2. You didn't create the package for rawhide, this is very bad again. 3. If you cannot have time to maintain it, I can help. I've just request commit access to comaintain it. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YxBGM4jiNL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950699] Review Request: python-path - A python module wrapper for os.path
https://bugzilla.redhat.com/show_bug.cgi?id=950699 Dan Callaghan changed: What|Removed |Added CC||lxt...@gmail.com Flags||needinfo?(lxt...@gmail.com) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HxnuvoTqIH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985065] Review Request: peg-solitaire - Board game played with pegs
https://bugzilla.redhat.com/show_bug.cgi?id=985065
--- Comment #7 from Kevin Kofler ---
> %find_lang -f solitari.lang --with-qt --without-mo
That's not valid %find_lang syntax. Try:
%find_lang solitari --with-qt --without-mo
In the %files list, you'll want to list:
%dir %{_datadir}/games/peg-solitaire/locales/
%{_datadir}/games/peg-solitaire/locales/solitari.qm
directly and add -f solitary.lang for the rest.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=uYckHKQvne&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #2 from Tom "spot" Callaway --- The content is not clearly licensed, but the files themselves are probably not copyrightable in the US. That said, I think I'd prefer asking upstream what they intend for the license on these files to be, and then mark the package accordingly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L3GfEJ2QGD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Till Maas changed: What|Removed |Added Alias||dtv-scan-tables -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A3Xiizai1g&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Till Maas changed: What|Removed |Added CC||opensou...@till.name Blocks||952326, 182235 (FE-Legal) --- Comment #1 from Till Maas --- Please see bug 952326, comment 7 and following for license questions. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fHpZ8RtqDG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] New: Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Bug ID: 986051 Summary: Review Request: dtv-scan-tables - Digital TV scan tables Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: opensou...@till.name QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://till.fedorapeople.org/review/dtv-scan-tables.spec SRPM URL: http://till.fedorapeople.org/review/dtv-scan-tables-0-1.20130703gitd913405.fc19.src.rpm Description: Digital TV scan tables Fedora Account System Username: till -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eAakJYJ7Cg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878421] Review Request: rubygem-bundler_ext - Load system gems via Bundler DSL
https://bugzilla.redhat.com/show_bug.cgi?id=878421 --- Comment #13 from Ken Dreyer --- Hi Slavek, I know you have a lot on your plate, so if you would like to hand the review over to Christopher or myself, please un-assign this review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mg7Gsgu9VA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973493] (Re-)Review Request: mpich - A high-performance implementation of MPI
https://bugzilla.redhat.com/show_bug.cgi?id=973493 --- Comment #4 from Deji Akingunola --- (In reply to Christopher Meng from comment #2) > Wow.. > > Many unused-direct-shlib-dependency problems... > > See the attachment. Thanks for taking time to review the package. I have fixed the 'unused-direct-shlib-dependency' and many of the other reported rpmlint warnings. I believe most of the other watnings/errors can be safely ignored, especially these; >>> mpich.i686: E: invalid-locale-man-dir /usr/share/man/mpich/man1/mpicc.1.gz mpich.i686: W: file-not-in-%lang /usr/share/man/mpich/man1/mpicc.1.gz >>> The packaging behaviour in these cases are in accordance with the Fedora MPI packaging guidelines (see http://fedoraproject.org/wiki/Packaging:MPI#Packaging_of_MPI_compilers). Updated spec and srpm files are available at; Spec URL: http://deji.fedorapeople.org/mpich.spec SRPM URL: http://deji.fedorapeople.org/mpich-3.0.4-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nKdAFxgRik&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985440] Review Request: cinnamon-settings-daemon - The daemon sharing settings from CINNAMON to GTK+/KDE applications
https://bugzilla.redhat.com/show_bug.cgi?id=985440 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7IIFdMl2Il&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985440] Review Request: cinnamon-settings-daemon - The daemon sharing settings from CINNAMON to GTK+/KDE applications
https://bugzilla.redhat.com/show_bug.cgi?id=985440 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bZ7jXetgLW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985440] Review Request: cinnamon-settings-daemon - The daemon sharing settings from CINNAMON to GTK+/KDE applications
https://bugzilla.redhat.com/show_bug.cgi?id=985440 leigh scott changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from leigh scott --- New Package SCM Request === Package Name: cinnamon-settings-daemon Short Description: The daemon sharing settings from CINNAMON to GTK+/KDE applications Owners: leigh123linux Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Um2AJSBJe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985087] Review Request: hadoop - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=985087 Björn Esser changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com --- Comment #4 from Björn Esser --- I'll take this for review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y2woeARBMl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985440] Review Request: cinnamon-settings-daemon - The daemon sharing settings from CINNAMON to GTK+/KDE applications
https://bugzilla.redhat.com/show_bug.cgi?id=985440
Wolfgang Ulbrich changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Wolfgang Ulbrich ---
Package APPROVED !
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- update-desktop-database is invoked when required
Note: desktop file(s) in cinnamon-settings-daemon
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
This is a fault postive and we can ignore it, no desktop file has an mine type.
- Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
cinnamon-settings-daemon doesn't have a gui, so we can ignore this!
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/xdg/autostart/cinnamon-fallback-
mount-helper.desktop %config
/etc/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism.conf
%config /etc/xdg/autostart/cinnamon-settings-daemon.desktop
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: glib-compile-schemas is run if required
Note: gschema file(s) in cinnamon-settings-daemon, cinnamon-settings-
daemon-updates
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "LGPL
(v2 or later) (with incorrect FSF address)", "GPL (v2 or later) (with
incorrect FSF address)", "LGPL (v2.1 or later)". 33 files have unknown
license. Detailed output of licensecheck in /home/rave/985440-cinnamon-
settings-daemon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked when required
Note: icons in cinnamon-settings-daemon
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Pa
[Bug 982588] Review Request: radicale - A simple CalDAV (calendar) and CardDAV (contact) server
https://bugzilla.redhat.com/show_bug.cgi?id=982588 Till Maas changed: What|Removed |Added CC||opensou...@till.name --- Comment #2 from Till Maas --- *** Bug 922276 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MGVFyaJAQP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 922276] Review Request: Radicale - CalDAV (calendar) and CardDAV (contact) server
https://bugzilla.redhat.com/show_bug.cgi?id=922276 Till Maas changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2013-07-18 14:31:54 --- Comment #2 from Till Maas --- *** This bug has been marked as a duplicate of bug 982588 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C1fU5VVZOA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985065] Review Request: peg-solitaire - Board game played with pegs
https://bugzilla.redhat.com/show_bug.cgi?id=985065 --- Comment #6 from Mario Blättermann --- (In reply to Mario Blättermann from comment #5) > OK, then it has to be changed in the wiki. There must not be a difference > between the "law" and the "practice". And in no case we may assume that an > "experienced packager" knows about that. Then we could also assume a lot of > more things, and we could shrink the guidelines to a minimum. Sorry for the blurb... Just found the correct usage in the scriptlets collection [1]: "Use this when a desktop entry has a 'MimeType key." But it is somewhat strage, though. Such a hint should be in the packaging guidelines, not in the scriptlets collection only. [1] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H1DODnOvlN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985065] Review Request: peg-solitaire - Board game played with pegs
https://bugzilla.redhat.com/show_bug.cgi?id=985065 --- Comment #5 from Mario Blättermann --- (In reply to Kevin Kofler from comment #4) > As for the other 2 points, unfortunately, there are some differences between > what is written in the wiki and what is actually true in practice (and all > experienced packagers know): > > > Moreover, the scriptlet doesn't contain anything about mime types. It's only > > for updating the desktop database. > > Actually, update-desktop-database is only needed if the .desktop file claims > any MIME types, otherwise it does nothing (and just wastes the user's time). > OK, then it has to be changed in the wiki. There must not be a difference between the "law" and the "practice". And in no case we may assume that an "experienced packager" knows about that. Then we could also assume a lot of more things, and we could shrink the guidelines to a minimum. > > Please read the comment. The find_lang macro is useful and applicable when > > gettext (or even the qt translation chain) places the language files in > > /usr/share/locale/language_code/LC_MESSAGES/*. > > Actually, it looks for the files with a "find" in the whole RPM_BUILD_ROOT, > so it doesn't matter where they are. Please try it (but don't forget the > --with-qt --without-mo switches if this is using Qt rather than gettext > translations), it should work. OK, I didn't know about the --without-mo switch. It's the first time I work on non-gettext stuff. I've added the macro with the following line: %find_lang -f solitari.lang --with-qt --without-mo But I get this error: + /usr/lib/rpm/find-lang.sh /home/mariobl/rpmbuild/BUILDROOT/peg-solitaire-2.0-3.fc19.x86_64 -f solitari.lang --with-qt --without-mo No translations found for -f in /home/mariobl/rpmbuild/BUILDROOT/peg-solitaire-2.0-3.fc19.x86_64 The problem is, we don't have files named solitari.qm in separate folders for each supported language. All the qm files are in a single folder with the following naming scheme: $ rpm -ql peg-solitaire ... /usr/share/games/peg-solitaire/locales /usr/share/games/peg-solitaire/locales/solitari.qm /usr/share/games/peg-solitaire/locales/solitari_ca_ES.qm /usr/share/games/peg-solitaire/locales/solitari_de_DE.qm /usr/share/games/peg-solitaire/locales/solitari_en_EN.qm /usr/share/games/peg-solitaire/locales/solitari_en_US.qm /usr/share/games/peg-solitaire/locales/solitari_es_ES.qm /usr/share/games/peg-solitaire/locales/solitari_eu_ES.qm /usr/share/games/peg-solitaire/locales/solitari_fr_FR.qm /usr/share/games/peg-solitaire/locales/solitari_gl_ES.qm /usr/share/games/peg-solitaire/locales/solitari_it_IT.qm /usr/share/games/peg-solitaire/locales/solitari_pl_PL.qm /usr/share/games/peg-solitaire/locales/solitari_pt_BR.qm /usr/share/games/peg-solitaire/locales/solitari_pt_PT.qm As another attempt I tried to use a wildcard (solitari*.lang), but it failed again. The guideline says: "Keep in mind that usage of %find_lang in packages containing locales is a MUST." But is it really worth the effort to patch the package to get this script working? Well, we use find_lang to avoid mistakes such as wrong folder ownerships and writing the translation files in a long list [1]. But peg-solitaire behaves different from the usual way, we should keep this in mind. And if I'm really forced to use it, my knowledge is probably too poor to patch the sources in a way that it works. BTW, some of the translations are made by an automatized tool like Google Translator and are of bad quality, at least the German one. This is another reason to avoid the effort. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Why_do_we_need_to_use_.25find_lang.3F -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nJIyeQydA5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985967] Review Request: python-arc - Autotest RPC Client libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=985967 --- Comment #1 from Cleber Rodrigues --- This is very first version of the package submitted to Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JlLKYRFTjd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985967] New: Review Request: python-arc - Autotest RPC Client libraries and tools
https://bugzilla.redhat.com/show_bug.cgi?id=985967 Bug ID: 985967 Summary: Review Request: python-arc - Autotest RPC Client libraries and tools Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cr...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://raw.github.com/clebergnu/arc/master/python-arc.spec SRPM URL: http://www.tallawa.org/python-arc-0.2.0-1.fc20.src.rpm Description: Autotest RPC Client is a pure Python library that servers as the client part of Autotest's server interface. It aims to be portable and only depend on Python's Standard Library. Fedora Account System Username: cleber -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9CThY5mamR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 978010] Review Request: perl-Wx-GLCanvas - Interface to wxWidgets' OpenGL canvas
https://bugzilla.redhat.com/show_bug.cgi?id=978010 --- Comment #3 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/perl-Wx-GLCanvas.spec SRPM URL: http://churchyard.fedorapeople.org/SRPMS/perl-Wx-GLCanvas-0.09-2.fc19.src.rpm I've redone BRs. The protip with Test::NeedsDisplay destroys the package. It forces the installation to use /usr/local -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n0I9FcMcYP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-07-18 11:19:41 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MsNGqZBJls&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985440] Review Request: cinnamon-settings-daemon - The daemon sharing settings from CINNAMON to GTK+/KDE applications
https://bugzilla.redhat.com/show_bug.cgi?id=985440
--- Comment #3 from leigh scott ---
(In reply to Wolfgang Ulbrich from comment #2)
> rpmlint.text
>
> Checking: cinnamon-settings-daemon-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm
> cinnamon-settings-daemon-devel-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm
>
> cinnamon-settings-daemon-updates-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm
> cinnamon-settings-daemon.x86_64: W: spelling-error %description -l en_US
> keybindings -> key bindings, key-bindings, bindings
> cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc
> /etc/xdg/autostart/cinnamon-settings-daemon.desktop
> cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc
> /etc/xdg/autostart/cinnamon-fallback-mount-helper.desktop
> cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc
> /etc/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism.conf
>
> Please use
> %config(noreplace)
> %{_sysconfdir}/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism.
> conf
This isn't a user configuration file and shouldn't have (noreplace) tag
>
> cinnamon-settings-daemon-devel.x86_64: W: no-documentation
> cinnamon-settings-daemon-devel.x86_64: E: incorrect-fsf-address
> /usr/include/cinnamon-settings-daemon-3.0/cinnamon-settings-daemon/cinnamon-
> settings-plugin.h
>
> Please notice upstream about this and all the others incorrect-fsf-address
> errors.
I will file a Br
>
> cinnamon-settings-daemon-devel.x86_64: E: non-executable-script
> /usr/share/cinnamon-settings-daemon-3.0/input-device-example.sh 0644L /bin/sh
>
> Please fix it and add a executable bit !
It's just an example file and doesn't have any function.
>
> cinnamon-settings-daemon-updates.x86_64: W: no-documentation
> 3 packages and 0 specfiles checked; 2 errors, 6 warnings.
>
> Issues:
> ===
> - update-desktop-database is invoked when required
> Note: desktop file(s) in cinnamon-settings-daemon
> See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
>
> This is a fault postive and we can ignore it, no desktop file has an mine
> type.
>
> - Package installs a %{name}.desktop using desktop-file-install if there is
> such a file.
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
>
> Use desktop-file-install or destop-file-validate commands to install/verify
> the destop files.
>
> [-]: Development (unversioned) .so files in -devel subpackage, if present.
> Note: Unversioned so-files in private %_libdir subdirectory (see
> attachment). Verify they are not in ld path.
>
> Unversioned so-files
>
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/liba11y-keyboard.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/liba11y-settings.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libbackground.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libclipboard.so
> cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcolor.so
> cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcsd.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libcsdwacom.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libcursor.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libhousekeeping.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libkeyboard.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libmedia-keys.so
> cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libmouse.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/liborientation.so
> cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libpower.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libprint-notifications.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libscreensaver-proxy.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libsmartcard.so
> cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libsound.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libxrandr.so
> cinnamon-settings-daemon:
> /usr/lib64/cinnamon-settings-daemon-3.0/libxsettings.so
> cinnamon-settings-daemon-updates:
> /usr/lib64/cinnamon-settings-daemon-3.0/libupdates.so
The unversioned .so are plugins
>
> Let us talk in irc why they are not versioned!
>
> Ok, that's all for the moment, pls fix it and i will do the final review.
SPEC URL:
http://leigh123linux.fedorapeople.org/pub/review/cinnamon-settings-daemon/2/cinnamon-settings-daemon.spec
SRPM URL:
http://leigh123linux.fedorapeople.org/pub/review/cinnamon-settings-daemon/2/cinnamon-settings-daemon-1.0.0-0.2.git42cc1ce.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0a
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 --- Comment #12 from Fedora Update System --- python-dropbox-1.6-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-dropbox-1.6-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GHFxLH5e3C&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 --- Comment #11 from Fedora Update System --- python-dropbox-1.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-dropbox-1.6-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FvYX3XTFnv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i9CiORDlFA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PJCp0OAmC4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vWUwRg79Mb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985915] Review Request: perl-BSSolv - A new approach to package dependency solving
https://bugzilla.redhat.com/show_bug.cgi?id=985915 Miroslav Suchý changed: What|Removed |Added Depends On||985905 --- Comment #2 from Miroslav Suchý --- > So this package basically bundles libsolv? Yes, unless bug 985905 is resolved. > Where do the perl files come from? from: https://github.com/openSUSE/open-build-service/tree/master/src/backend I will add comment into spec about that. Unfortunatelly there is no ultimate source just for standalone package. And BSSolv is BR for obs-server, where it is included in upstream, so we will have problem with bootstraping. >You shouldn't BR perl-devel or gcc-c++. ok -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZaOXvKLxoB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from gil cattaneo --- New Package SCM Request === Package Name: mybatis-generator Short Description: A code generator for MyBatis and iBATIS Owners: gil slaanesh InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9nuStQT2YR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 Simone Caronni changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Simone Caronni --- Very good, thanks! Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FAt8rPuL6h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 --- Comment #10 from Miro Hrončok --- Thanks Mario, Jon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1VVx2A9Y3N&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zoCyEAyn2O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B9JmjbYpf9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 981834] Review Request: patool - A portable archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=981834 --- Comment #11 from Antonio Trande --- Is there any news? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yq2aqCSGCs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982336] Review Request: python-dropbox - Official Dropbox REST API Client
https://bugzilla.redhat.com/show_bug.cgi?id=982336 Miro Hrončok changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Miro Hrončok --- New Package SCM Request === Package Name: python-dropbox Short Description: Official Dropbox REST API Client Owners: churchyard Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h6CCqhOLKM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985915] Review Request: perl-BSSolv - A new approach to package dependency solving
https://bugzilla.redhat.com/show_bug.cgi?id=985915 Petr Šabata changed: What|Removed |Added CC||psab...@redhat.com --- Comment #1 from Petr Šabata --- So this package basically bundles libsolv? Where do the perl files come from? You shouldn't BR perl-devel or gcc-c++. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MkAF3uvZeZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985916] New: Review Request: compat-gtkhtml314 - GtkHTML library
https://bugzilla.redhat.com/show_bug.cgi?id=985916 Bug ID: 985916 Summary: Review Request: compat-gtkhtml314 - GtkHTML library Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: limburg...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Description: GtkHTML is a lightweight HTML rendering/printing/editing engine. It was originally based on KHTMLW, but is now being developed independently of it. SPEC: http://fedorapeople.org/~limb/review/compat-gtkhtml314/compat-gtkhtml314.spec SRPM: http://fedorapeople.org/~limb/review/compat-gtkhtml314/compat-gtkhtml314-3.32.2-2.fc19.src.rpm This is needed for the unretirement of gnotime. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8A4ANGQ7T7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985916] Review Request: compat-gtkhtml314 - GtkHTML library
https://bugzilla.redhat.com/show_bug.cgi?id=985916 Jon Ciesla changed: What|Removed |Added Blocks||985917 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9w5OsYeyv1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985917] New: Review Request: gnotime - Tracks and reports time spent
https://bugzilla.redhat.com/show_bug.cgi?id=985917 Bug ID: 985917 Summary: Review Request: gnotime - Tracks and reports time spent Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: limburg...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Description: A combination of stop-watch, diary, consultant billing system, and project manager. Gnotime allows you to track the amount of time you spend on a task, associate a memo with it, set a billing rate, print an invoice, as well as track the status of other projects. Some people may remember Gnotime in its previous incarnations as GTT (Gnome Time Tracker) when it was part of the Gnome Utils package. It has been split out, renamed, and greatly enhanced since then. SPEC: http://fedorapeople.org/~limb/review/gnotime/gnotime.spec SRPM: http://fedorapeople.org/~limb/review/gnotime/gnotime-2.4.1-1.fc19.src.rpm This is an un-retirement re-review, this was dropped in Fedora 15. This requires compat-gtkhtml314. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nE2JQ5XFqI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985917] Review Request: gnotime - Tracks and reports time spent
https://bugzilla.redhat.com/show_bug.cgi?id=985917 Jon Ciesla changed: What|Removed |Added Depends On||985916 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LgLim7JZFn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 --- Comment #6 from gil cattaneo --- (In reply to Simone Caronni from comment #4) > Another thing, can BuildRequires from line 27 to 31 be specified in the form > mvn(xxxì:xxx)? isn't really essential, i think, e.g. maven-local i don't know if it has references as mvn(xxxì:xxx) regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iP8PWjJlDp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985915] New: Review Request: perl-BSSolv - A new approach to package dependency solving
https://bugzilla.redhat.com/show_bug.cgi?id=985915 Bug ID: 985915 Summary: Review Request: perl-BSSolv - A new approach to package dependency solving Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: msu...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://miroslav.suchy.cz/fedora/perl-BSSolv/perl-BSSolv.spec SRPM URL: http://miroslav.suchy.cz/fedora/perl-BSSolv/perl-BSSolv-0.18.2-2.git228d412.fc19.src.rpm Description: Using a Satisfyability Solver to compute package dependencies. Fedora Account System Username: msuchy koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5627553 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ym3wdQehWO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854
--- Comment #5 from gil cattaneo ---
(In reply to Simone Caronni from comment #3)
> Can you explain line 21-23 of the spec file? Is mvn(org.hsqldb:hsqldb) a
> requirement for mybatis-generator-maven-plugin?
>
> If it is, then it should be added into the "%package maven-plugin" section
> as "Requires:".
>
> Apart from this, it seems good to go.
for this module the plugin is configured so,
and uses the dependencies listed in ...
i dont know if for other projects can be the same
mybatis-generator-systests-mybatis3/pom.xml
org.mybatis.generator
mybatis-generator-maven-plugin
${project.version}
Generate MyBatis Artifacts
generate
classpath:mbg/test/common/scripts/CreateDB.sql
org.hsqldb.jdbcDriver
jdbc:hsqldb:mem:aname
sa
true
org.hsqldb
hsqldb
${hsqldb.version}
org.mybatis.generator
mybatis-generator-systests-common
${project.version}
org.mybatis.generator
mybatis-generator-core
${project.version}
net.sourceforge.cobertura
cobertura
${cobertura.version}
Spec URL: http://gil.fedorapeople.org/mybatis-generator.spec
SRPM URL: http://gil.fedorapeople.org/mybatis-generator-1.3.2-1.fc19.src.rpm
- fix wrong file end of line encoding
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=3KYhwsUy6Q&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913574] Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window
https://bugzilla.redhat.com/show_bug.cgi?id=913574 --- Comment #5 from Frantisek Kluknavsky --- glib-compile-schemas (package glib2) produces identical gschemas.compiled from packaged org.gnome.shell.extensions.per-window-keyboard-layout.gschema.xml -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vHCUtmZMfX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 --- Comment #4 from Simone Caronni --- Another thing, can BuildRequires from line 27 to 31 be specified in the form mvn(xxxì:xxx)? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m5myKwiFv6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 913574] Review Request: gnome-shell-extension-per-window-keyboard-layout - Remembers keyboard layout for each window
https://bugzilla.redhat.com/show_bug.cgi?id=913574 Frantisek Kluknavsky changed: What|Removed |Added CC||fkluk...@redhat.com --- Comment #4 from Frantisek Kluknavsky --- rpmlint ./gnome-shell-extension-per-window-keyboard-layout-4-0.git047684044b.fc19.src.rpm gnome-shell-extension-per-window-keyboard-layout.src: W: strange-permission gnome-shell-extension-per-window-keyboard-layout.spec 0640L gnome-shell-extension-per-window-keyboard-layout.src: W: invalid-url Source0: gnome-shell-extension-per-window-input-source-master.zip rpmlint ./gnome-shell-extension-per-window-keyboard-layout-4-0.git047684044b.fc19.noarch.rpm gnome-shell-extension-per-window-keyboard-layout.noarch: W: incoherent-version-in-changelog 0.20130416-0 ['4-0.git047684044b.fc19', '4-0.git047684044b'] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. schemas/gschemas.compiled ?All program binaries and program libraries included in Fedora packages must be built from the source code that is included in the source package. Content binaries (such as .pdf, .png, .ps files) are not required to be rebuilt from the source code. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p3wa1f9cS6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 --- Comment #3 from Simone Caronni --- Can you explain line 21-23 of the spec file? Is mvn(org.hsqldb:hsqldb) a requirement for mybatis-generator-maven-plugin? If it is, then it should be added into the "%package maven-plugin" section as "Requires:". Apart from this, it seems good to go. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tpAJNdpfG7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854
--- Comment #2 from Simone Caronni ---
(In reply to Simone Caronni from comment #1)
> Issues:
> ===
> - Fully versioned dependency in subpackages, if present.
> Note: Missing: Requires: %{name} = %{version}-%{release} in mybatis-
> generator-maven-plugin, mybatis-generator-systests-common, mybatis-
> generator-systests-mybatis3
This can be ignored, dependencies are generated from maven build tools.
> = SHOULD items =
> [!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> Note: Found : Packager: Simone Caronni
This is me, just my local .rpmmacros spec file.
> Rpmlint
> ---
> mybatis-generator.noarch: W: spelling-error Summary(en_US) iBATIS ->
> Batista, batiste
> mybatis-generator.noarch: W: spelling-error %description -l en_US iBATIS ->
> Batista, batiste
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/NOTICE
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/releasing.txt
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/todo.txt
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/ReleaseNotes.txt
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/LICENSE
> mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/NOTICE
> mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/LICENSE
> mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-common-1.3.2/NOTICE
> mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-common-1.3.2/LICENSE
> mybatis-generator-systests-mybatis3.noarch: W:
> wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/NOTICE
> mybatis-generator-systests-mybatis3.noarch: W:
> wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/LICENSE
> mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-javadoc-1.3.2/NOTICE
> mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-javadoc-1.3.2/LICENSE
> 5 packages and 0 specfiles checked; 0 errors, 15 warnings.
These can be ignored.
> Rpmlint (installed packages)
>
> # rpmlint mybatis-generator-systests-common mybatis-generator-javadoc
> mybatis-generator-maven-plugin mybatis-generator
> mybatis-generator-systests-mybatis3
> mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-common-1.3.2/NOTICE
> mybatis-generator-systests-common.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-common-1.3.2/LICENSE
> mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-javadoc-1.3.2/NOTICE
> mybatis-generator-javadoc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-javadoc-1.3.2/LICENSE
> mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/NOTICE
> mybatis-generator-maven-plugin.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-maven-plugin-1.3.2/LICENSE
> mybatis-generator.noarch: W: spelling-error Summary(en_US) iBATIS ->
> Batista, batiste
> mybatis-generator.noarch: W: spelling-error %description -l en_US iBATIS ->
> Batista, batiste
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/NOTICE
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/releasing.txt
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/todo.txt
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/ReleaseNotes.txt
> mybatis-generator.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-1.3.2/LICENSE
> mybatis-generator-systests-mybatis3.noarch: W:
> wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/NOTICE
> mybatis-generator-systests-mybatis3.noarch: W:
> wrong-file-end-of-line-encoding
> /usr/share/doc/mybatis-generator-systests-mybatis3-1.3.2/LICENSE
> 5 packages and 0 specfiles checked; 0 errors, 15 warnings.
> # echo 'rpmlint-done:'
Same errors, can be ignored.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854
--- Comment #1 from Simone Caronni ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Fully versioned dependency in subpackages, if present.
Note: Missing: Requires: %{name} = %{version}-%{release} in mybatis-
generator-maven-plugin, mybatis-generator-systests-common, mybatis-
generator-systests-mybatis3
See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mybatis-
generator-maven-plugin , mybatis-generator-systests-common , mybatis-
generator-systests-mybatis3 , mybatis-generator-javadoc
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)".
61 files have unknown license. Detailed output of licensecheck in
/home/slaanesh/Documents/fedora/985854-mybatis-generator/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 102400 bytes in 11 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]:
[Bug 985440] Review Request: cinnamon-settings-daemon - The daemon sharing settings from CINNAMON to GTK+/KDE applications
https://bugzilla.redhat.com/show_bug.cgi?id=985440
--- Comment #2 from Wolfgang Ulbrich ---
rpmlint.text
Checking: cinnamon-settings-daemon-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm
cinnamon-settings-daemon-devel-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm
cinnamon-settings-daemon-updates-1.0.0-0.1.git42cc1ce.fc20.x86_64.rpm
cinnamon-settings-daemon.x86_64: W: spelling-error %description -l en_US
keybindings -> key bindings, key-bindings, bindings
cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/cinnamon-settings-daemon.desktop
cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/cinnamon-fallback-mount-helper.desktop
cinnamon-settings-daemon.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism.conf
Please use
%config(noreplace)
%{_sysconfdir}/dbus-1/system.d/org.cinnamon.SettingsDaemon.DateTimeMechanism.conf
cinnamon-settings-daemon-devel.x86_64: W: no-documentation
cinnamon-settings-daemon-devel.x86_64: E: incorrect-fsf-address
/usr/include/cinnamon-settings-daemon-3.0/cinnamon-settings-daemon/cinnamon-settings-plugin.h
Please notice upstream about this and all the others incorrect-fsf-address
errors.
cinnamon-settings-daemon-devel.x86_64: E: non-executable-script
/usr/share/cinnamon-settings-daemon-3.0/input-device-example.sh 0644L /bin/sh
Please fix it and add a executable bit !
cinnamon-settings-daemon-updates.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 2 errors, 6 warnings.
Issues:
===
- update-desktop-database is invoked when required
Note: desktop file(s) in cinnamon-settings-daemon
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
This is a fault postive and we can ignore it, no desktop file has an mine type.
- Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
Use desktop-file-install or destop-file-validate commands to install/verify the
destop files.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Unversioned so-files
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/liba11y-keyboard.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/liba11y-settings.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libbackground.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libclipboard.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcolor.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcsd.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libcsdwacom.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libcursor.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libhousekeeping.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libkeyboard.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libmedia-keys.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libmouse.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/liborientation.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libpower.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libprint-notifications.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libscreensaver-proxy.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libsmartcard.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libsound.so
cinnamon-settings-daemon: /usr/lib64/cinnamon-settings-daemon-3.0/libxrandr.so
cinnamon-settings-daemon:
/usr/lib64/cinnamon-settings-daemon-3.0/libxsettings.so
cinnamon-settings-daemon-updates:
/usr/lib64/cinnamon-settings-daemon-3.0/libupdates.so
Let us talk in irc why they are not versioned!
Ok, that's all for the moment, pls fix it and i will do the final review.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=1oe0yP4hK5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904634] Review Request: mingw-sword - MinGW build of a cross-platform scripture text library
https://bugzilla.redhat.com/show_bug.cgi?id=904634 --- Comment #3 from greg.helli...@gmail.com --- Whoops! Fixed that now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yb3Ji3T0aN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 985854] Review Request: mybatis-generator - A code generator for MyBatis and iBATIS
https://bugzilla.redhat.com/show_bug.cgi?id=985854 Simone Caronni changed: What|Removed |Added Status|NEW |ASSIGNED CC||negativ...@gmail.com Assignee|nob...@fedoraproject.org|negativ...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=09MCE1ETlD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #10 from Fedora Update System --- python-catkin_pkg-0.1.18-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-catkin_pkg-0.1.18-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U2SqrDzjB6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #9 from Fedora Update System --- python-catkin_pkg-0.1.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-catkin_pkg-0.1.18-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SRy461vUDx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8qmfagB9xi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969877] Review Request: rubygem-timers - Pure Ruby one-shot and periodic timers
https://bugzilla.redhat.com/show_bug.cgi?id=969877 --- Comment #14 from Vít Ondruch --- (In reply to Axilleas Pipinellis from comment #11) > Also some packages I want to submit depend on newer gems than what packaged > in Fedora. What can I do in such cases? Contact the author? > > eg. Fedora has multi_json 1.7.1 whereas I need >= 1.7.2. I have a working > spec with latest 1.7.7, though. The best is to open bug with update request and justification. Sometimes, there are already bugs filled by upstream release monitoring [1], so you can bump the maintainer there. BTW it is good idea to add into upstream release monitoring all your packages, so you are informed about new releases. [1] https://fedoraproject.org/wiki/Upstream_release_monitoring -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7qZciW4BUm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969877] Review Request: rubygem-timers - Pure Ruby one-shot and periodic timers
https://bugzilla.redhat.com/show_bug.cgi?id=969877 Vít Ondruch changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #13 from Vít Ondruch --- As I already noted, this package looks good, so I APPROVE it. Please proceed with SCM request [1, 2] and import this package to Fedora. You can also finish the rubygem-rugged review now. [1] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner [2] https://fedoraproject.org/wiki/Package_SCM_admin_requests -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o32LCZmVka&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904634] Review Request: mingw-sword - MinGW build of a cross-platform scripture text library
https://bugzilla.redhat.com/show_bug.cgi?id=904634 Marc-Andre Lureau changed: What|Removed |Added CC||marcandre.lur...@redhat.com --- Comment #2 from Marc-Andre Lureau --- The spec is not world readable, please fix permissions :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y7pW2Dndi0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984800] Review Request: ghc-monad-logger - Monads for logging messages
https://bugzilla.redhat.com/show_bug.cgi?id=984800 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QtWNcHx0rJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984800] Review Request: ghc-monad-logger - Monads for logging messages
https://bugzilla.redhat.com/show_bug.cgi?id=984800 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6DOW2bsMcc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984796] Review Request: ghc-cookie - HTTP cookie parsing and rendering
https://bugzilla.redhat.com/show_bug.cgi?id=984796 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2nAJrDUphk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969877] Review Request: rubygem-timers - Pure Ruby one-shot and periodic timers
https://bugzilla.redhat.com/show_bug.cgi?id=969877 --- Comment #12 from Vít Ondruch --- You shown good understanding in packaging, so lets move forward. I sponsored you into packagers group. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kwcxmDTaj7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984796] Review Request: ghc-cookie - HTTP cookie parsing and rendering
https://bugzilla.redhat.com/show_bug.cgi?id=984796 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J9lLlOZYXR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984791] Review Request: ghc-attoparsec-conduit - Consume attoparsec parsers via conduit
https://bugzilla.redhat.com/show_bug.cgi?id=984791 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8kBZZE82zz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984791] Review Request: ghc-attoparsec-conduit - Consume attoparsec parsers via conduit
https://bugzilla.redhat.com/show_bug.cgi?id=984791 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ACEreZW11p&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 983901] Review Request: ghc-path-pieces - Components of paths
https://bugzilla.redhat.com/show_bug.cgi?id=983901 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MF7anpDZMM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 983901] Review Request: ghc-path-pieces - Components of paths
https://bugzilla.redhat.com/show_bug.cgi?id=983901 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mdzVxtHDH5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pINfB0v7Wo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926034] Review Request: python-catkin_pkg - Library for retrieving information about catkin packages
https://bugzilla.redhat.com/show_bug.cgi?id=926034 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lXEpdtgq6k&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 983961] Review Request: pyqt-mail-checker -- tray Applet should periodic check for new messages (kdelib-less)
https://bugzilla.redhat.com/show_bug.cgi?id=983961 --- Comment #8 from Fl@sh --- > You've mixed 2 styles for build root tag. > > Should only use macro style or variable style. > SPEC: https://raw.github.com/F1ash/pyqt-mail-checker/2.0.1/pyqt-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/7155/5627155/pyqt-mail-checker-2.0.1-4.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1LhbYu2F8u&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
