[Bug 988193] Review Request: elementary-xfce-icon-theme - elementary-xfce-icon-theme
https://bugzilla.redhat.com/show_bug.cgi?id=988193 hannes johannes.l...@googlemail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from hannes johannes.l...@googlemail.com --- New Package SCM Request === Package Name: elementary-xfce-icon-theme Short Description: Icons for Xfce based on the elementary Project Icon Theme Owners: hannes Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DM4lj0PE92a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 755510] Review Request: gnome-shell-extension-system-monitor-applet - Gnome shell system monitor extension
https://bugzilla.redhat.com/show_bug.cgi?id=755510 --- Comment #52 from nicolas.vievi...@univ-valenciennes.fr --- Steven, Thank you for your constant support. As I said in my previous post, I want to go further in this process. But last months have been heavy loaded in life and at work. From today and for the next 3 weeks, I will be on vacation (family and kids - departure within 5 minutes) with no Internet connection at all. I'll execute the reviews you asked me for on my return (and an update of the package too). Thank you so much for your patience. Cordially, -- NVieville -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d4OhQfPyuRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987622] Review Request: python-behave - Tools for the behaviour-driven development, Python style
https://bugzilla.redhat.com/show_bug.cgi?id=987622 Vadim Rutkovsky vrutk...@redhat.com changed: What|Removed |Added CC||vrutk...@redhat.com --- Comment #2 from Vadim Rutkovsky vrutk...@redhat.com --- Behave on py3 still has numerous issues, tracking bug is https://github.com/behave/behave/issues/119 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wcBjftMB0ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982161] Review Request: python-kapteyn - The Kapteyn Python Astronomy package
https://bugzilla.redhat.com/show_bug.cgi?id=982161 --- Comment #10 from Michael Schwendt bugs.mich...@gmx.net --- A lot is documented in the guidelines. In particular, these two apply: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Forking https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions The second one asks many questions. Try to get some answers. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4qSiLpGUjwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952229] Review Request: canl-c++ - EMI Common Authentication library - bindings for C++
https://bugzilla.redhat.com/show_bug.cgi?id=952229 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Keywords|Reopened| Status|ASSIGNED|ON_QA --- Comment #24 from Björn Esser bjoern.es...@gmail.com --- (In reply to Mattias Ellert from comment #23) Sorry, I didn't notice this comment. It was added only 1½ day before the bug was closed by bodhi, Thanks for the reminder. np. You're welcome. Since you pushed a fixed version, all is fine now. :) Make sure to close this bug, when updates are pushed to their repos. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oEXngImO9za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890771] Review Request: edje - Abstract GUI layout and animation object library
https://bugzilla.redhat.com/show_bug.cgi?id=890771 --- Comment #10 from Dan Mashal dan.mas...@gmail.com --- (In reply to Michael Scherer from comment #9) Sorry for the delay - the requires are stil redundant ( ie eval-devel among others ) Tried to minimize this. - /usr/share/mime is still unowned Hopefully fixed - there is no fully versioned dependency in subpackages for edje-utils Any advice? - still not note for the make test Elaborate? - License tag is still wrong Fixed. - package is likely still not installable in rawhide Should be now. Will be uploading new srpm/spec shortly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NUTl9t6kIHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895149] Review Request: qtchooser - Qt Chooser
https://bugzilla.redhat.com/show_bug.cgi?id=895149
Dan Mashal dan.mas...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review? |fedora-review+
--- Comment #8 from Dan Mashal dan.mas...@gmail.com ---
APPROVED. Looks fine here. Tested, and installed properly on a rawhide box.
I will leave it up to Rex's good and proven judgement as to why this package
should be in Fedora.
Rex, please review the shoulds.
Licensing looks OK.
Go on.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided in
the spec URL.
Note: Check did not completechecksum differs and there are problems running
diff. Please verify manually.
See: http://fedoraproject.org/wiki/Packaging/SourceURL
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[ ]: Package complies to the Packaging Guidelines
[ ]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2 files have unknown license. Detailed output of
licensecheck in /home/dan/895149-qtchooser/licensecheck.txt
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[ ]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[!]: Spec use %global instead of %define.
Note: %define git g980c64c
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from
[Bug 915903] Review Request: qt5-qtjsbackend - Qt5 - QtJSBackend component
https://bugzilla.redhat.com/show_bug.cgi?id=915903 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Assignee|jrez...@redhat.com |dan.mas...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PuHrRcXEcma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915903] Review Request: qt5-qtjsbackend - Qt5 - QtJSBackend component
https://bugzilla.redhat.com/show_bug.cgi?id=915903
Dan Mashal dan.mas...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Dan Mashal dan.mas...@gmail.com ---
Looks fine, please update the packages to FC20 and make sure they install and
work there before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[ ]: Package complies to the Packaging Guidelines
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (3 clause), BSD (2 clause), Unknown or generated. 33 files have
unknown license. Detailed output of licensecheck in
/home/dan/915903-qt5-qtjsbackend/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[ ]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 71680 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Scriptlets must be sane, if used.
[ ]: Description and
[Bug 958585] Review Request: mosquitto - An Open Source MQTT v3.1 Broker
https://bugzilla.redhat.com/show_bug.cgi?id=958585 --- Comment #3 from Rich Mattes richmat...@gmail.com --- I unbundled uthash and fixed the unsued shlib dependency error by adding -Wl,--as-needed to the LDFLAGS for the build. I will contact upstream about working on a fix for the missing call to setgroups. Updated packages can be found here Spec URL: http://rmattes.fedorapeople.org/RPMS/mosquitto/mosquitto.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/mosquitto/mosquitto-1.1.3-2.fc19.src.rpm $ rpmlint mosquitto.spec ../RPMS/x86_64/mosquitto*1.1.3-2* mosquitto.x86_64: E: missing-call-to-setgroups /usr/sbin/mosquitto 3 packages and 1 specfiles checked; 1 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BJlb166UJAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928584] Review Request: ros-std_msgs - Standard ROS Messages
https://bugzilla.redhat.com/show_bug.cgi?id=928584 --- Comment #7 from Rich Mattes richmat...@gmail.com --- Basically, the python and lisp compontents are the generated messages. They are required during runtime for any python or lisp program that needs the messages, though not every ROS program will need one or both of them. I think it would be possible to split them out into something like package-python-msgs and package-lisp-msgs, but I'm not convinced it's worth the effort. As far as /usr/share/common-lisp/ros goes, I'm not sure we can use that folder as per [1]. I think I may have to change the way that catkin is installing the lisp messages so that it lands in a packagename subfolder (or maybe we can just move the ros/ folder into common-lisp/source and have ros-release own it) You're right about requiring the runtime genpy and genlisp libraries: all the python getnpy messages import genpy. I'm not sure about lisp, and it looks like the c++ generated headers require headers from roscpp_core-devel. I'll update the Requires accordingly. I don't think egg-info needs to be generated; that guideline is only for when upstream does generate it, which isn't the case here. [1] http://fedoraproject.org/wiki/Packaging:Lisp#Install_location_and_hooking_into_the_common-lisp-controller -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a3RBUGmnV2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961419] Review Request: anet - Ada Networking Library
https://bugzilla.redhat.com/show_bug.cgi?id=961419 --- Comment #4 from Björn Persson bj...@xn--rombobjrn-67a.se --- Yes, now I can use %doc. (The documentation does get divided into two directories, anet and anet-devel, which is unnecessary but not a big problem.) https://www.rombobjörn.se/packages/anet-0.2.2-2/anet.spec https://www.rombobjörn.se/packages/anet-0.2.2-2/anet-0.2.2-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ykmr6T6viIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library
https://bugzilla.redhat.com/show_bug.cgi?id=988866 --- Comment #1 from Remi Collet fed...@famillecollet.com --- Update to 1.7.2 Spec: https://raw.github.com/remicollet/remirepo/1a411ba23962e14ca0cbcf11c9fefe138d091e5c/php/pecl/php-pecl-event/php-pecl-event.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.2-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Dtd9liS6iga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928584] Review Request: ros-std_msgs - Standard ROS Messages
https://bugzilla.redhat.com/show_bug.cgi?id=928584 --- Comment #8 from Rich Mattes richmat...@gmail.com --- Update: Spec URL: http://rmattes.fedorapeople.org/rospackages/std-msgs/ros-std_msgs.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/std-msgs/ros-std_msgs-0.4.11-3.20130605gitde0dcf1.fc19.src.rpm I tried to address the concerns you mentioned above, and I also tried to conform to the common-lisp packaging guidelines $ rpmlint ros-std_msgs.spec ../../RPMS/noarch/ros-std_msgs*-0.4.11-3* ros-std_msgs.noarch: W: spelling-error %description -l en_US msgs - mags, megs, mugs ros-std_msgs.noarch: W: spelling-error %description -l en_US multiarrays - multiracial ros-std_msgs.noarch: W: no-documentation ros-std_msgs.noarch: E: zero-length /usr/share/std_msgs/msg/Empty.msg ros-std_msgs-devel.noarch: W: spelling-error Summary(en_US) msgs - mags, megs, mugs ros-std_msgs-devel.noarch: W: spelling-error %description -l en_US msgs - mags, megs, mugs ros-std_msgs-devel.noarch: W: no-documentation 2 packages and 1 specfiles checked; 1 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YMm61iSEYha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977208] Review Request: Phalcon - A web framework implemented as a C extension
https://bugzilla.redhat.com/show_bug.cgi?id=977208 --- Comment #26 from Roman Mohr ro...@fenkhuber.at --- The official github tag is not commit b72745 used by us. I am quite sure that you are using an old archive. Please place the correct source tar.gz in your SOURCES folder. Well, actually, we're using a tag now: v1.2.0. Also, I am using the spectool you taught me. Good, I just wanted to make sure this is the case. I re-did the patch and I had to comment out several more Db tests; as well as some Collections and stuff. Anyway, the patch is remade in the SRPM and it now builds correctly. I still think that you mixed up some patches. Anyway I am glad it works for you. I have uploaded a new spec patch with - improved description - removed CFLAGS - improved (architecture independent) builddir detection - removed architecture limitation There is just one point left in my eyes: I see no reason why phalcon should not run on ppc and arm. If you know of any reason then readd the exclusive arch directive and add a comment why it won't run. I've emailed the author regarding these issues. I, also, asked his help in reviewing the review; so he can clarify any pending points (like the CFLAGS) and other matters. Good to hear that you are in close contact with upstream. Once you have your answeres we can finalize the specs. (btw. 32bit and 64bit build directory does not mean that a software is just meant for x86 cpu's and on github you can read Phalcon PHP is written in C with platform independence in mind. As a result, Phalcon PHP is available on Microsoft Windows, GNU/Linux, Mac OS X, which sounds for me like it schould used wherever possible. And you can trust me, the cflags are just optimization flags ;) ). Thank you once again. I appreciate your great effort and patience. Just drop me a note when you have some more infos. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RnzeKO0Twda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: varnish-vmod-querystring - QueryString VMOD for Varnish
https://bugzilla.redhat.com/show_bug.cgi?id=953514 --- Comment #9 from Ingvar Hagelund ing...@linpro.no --- I'll have a look at this, and varnish 3.0.4 after my summer's vacation. Too little time to do packaging this summer. Ingvar -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TUyyBugysMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 728956] Review Request: php-virt-control - PHP-based virtual machine controller tool
https://bugzilla.redhat.com/show_bug.cgi?id=728956 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC|mario.blaetterm...@gmail.co | |m | Assignee|mario.blaetterm...@gmail.co |nob...@fedoraproject.org |m | Flags|fedora-review? | |needinfo?(minovotn@redhat.c | |om) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LeNEauKwhsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870853] Review Request: haven - Next Generation Backup System
https://bugzilla.redhat.com/show_bug.cgi?id=870853 --- Comment #4 from Davide Benini dben...@gmail.com --- Koji scratch build info for the latest Fedora releases: * Fedora 18 http://koji.fedoraproject.org/koji/taskinfo?taskID=5642342 * Fedora 19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5656767 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=scYicj7XE6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987622] Review Request: python-behave - Tools for the behaviour-driven development, Python style
https://bugzilla.redhat.com/show_bug.cgi?id=987622 --- Comment #3 from Matěj Cepl mc...@redhat.com --- New version is http://mcepl.fedorapeople.org/tmp/python-behave.spec and http://mcepl.fedorapeople.org/tmp/python-behave-1.2.3-2.el7.src.rpm (of course, building of the package depends on python-parse and thus bug 987619, but I guess it shouldn't make it impossible to make a review, right?) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=feV8swx5cua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804125] Review Request: rdkit - A toolkit for cheminformatics and machine learning
https://bugzilla.redhat.com/show_bug.cgi?id=804125 --- Comment #13 from Gianluca Sforna gia...@gmail.com --- http://giallu.fedorapeople.org/rdkit.spec http://giallu.fedorapeople.org/rdkit-2013.06.1-1.fc19.src.rpm Updated to latest release, includes suggestions from Christopher -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FcOuUx2R5ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989265] New: Review Request: dtdparser - A Java DTD Parser
https://bugzilla.redhat.com/show_bug.cgi?id=989265 Bug ID: 989265 Summary: Review Request: dtdparser - A Java DTD Parser Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ger...@ryan.lt QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://galileo.fedorapeople.org/dtdparser/dtdparser.spec SRPM URL: http://galileo.fedorapeople.org/dtdparser/dtdparser-1.21-9.fc19.src.rpm Description: DTD parsers for Java seem to be pretty scarce. That's probably because DTD isn't valid XML. At some point, if/when XML Schema becomes widely accepted, no one will need DTD parsers anymore. Until then, you can use this library to parse a DTD. Fedora Account System Username: galileo This was a dead package that I need to bring back as an indirect dependency for JBoss Tools (smooks requires it, which is a dependency of jboss-wise-core, which eclipse-jbosstools 4.1.0 will need). Repo at https://github.com/grdryn/dtdparser-rpm might help reviewer to see what has changed. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5669879 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QK9unNHKbVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989265] Review Request: dtdparser - A Java DTD Parser
https://bugzilla.redhat.com/show_bug.cgi?id=989265 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||652183 (FE-JAVASIG), 989106 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0EKnKowMdQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989266] New: Review Request: smooks - Smooks Framework
https://bugzilla.redhat.com/show_bug.cgi?id=989266 Bug ID: 989266 Summary: Review Request: smooks - Smooks Framework Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ger...@ryan.lt QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://galileo.fedorapeople.org/smooks/1.5.1-1/smooks.spec SRPM URL: http://galileo.fedorapeople.org/smooks/1.5.1-1/smooks-1.5.1-1.fc19.src.rpm Description: Smooks is an extensible framework for building applications for processing XML and non XML data (CSV, EDI, Java etc) using Java. Fedora Account System Username: galileo This is a dependency for eclipse-jbosstools 4.1.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T0YaHWXlPNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989266] Review Request: smooks - Smooks Framework
https://bugzilla.redhat.com/show_bug.cgi?id=989266 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||652183 (FE-JAVASIG), 989106 Depends On||989265 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ojUISoNzK7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989265] Review Request: dtdparser - A Java DTD Parser
https://bugzilla.redhat.com/show_bug.cgi?id=989265 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||989266 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xnHk55hppLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989014] Review Request: jdf-stacks-client - JBoss Stacks Parser
https://bugzilla.redhat.com/show_bug.cgi?id=989014 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- jdf-stacks-client-1.0.1-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6jSq9huIz9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989112] Review Request: gmqcc - Improved Quake C Compiler
https://bugzilla.redhat.com/show_bug.cgi?id=989112 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- gmqcc-0.2.9-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0V1EGBZwhVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917191] Review Request: awake - A command to 'wake on LAN' a remote host
https://bugzilla.redhat.com/show_bug.cgi?id=917191 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- awake-1.0-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MeTVovJqvXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870853] Review Request: haven - Next Generation Backup System
https://bugzilla.redhat.com/show_bug.cgi?id=870853 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #5 from Christopher Meng cicku...@gmail.com --- I'll take an informal review. 1. Why not nameing it safehaven but haven? 2. %define _hardened_build 1 should be %global _hardened_build 1 3. Can you ask upstream to avoid using %global _configure ../../configure mkdir -p build/standard build/gtkgui build/full cd build/standard %configure --disable-ext2fs --disable-gmime --without-postgresql? I think this is not cmake, why should we burden ourselves? 4. I think you should add requires of main package for all subpackages. 5. Once you've done the 4, you should remove subpackages' %doc README COPYING As these doc should only present one time in main package. 6. You shouldn't create a new tarball when the download URL is available. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vhr5TKL1HQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986608] Review Request: weasyprint - Utility and Python library to render HTML and CSS to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=986608 --- Comment #8 from Christopher Meng cicku...@gmail.com --- Package is fine, only one question: tests/test_web/run.py:#!/usr/bin/env python In the past I think we shouldn't let env works, we should use /usr/bin/python. But can you tell me if this time is OK? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=egRUAKtk77a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804125] Review Request: rdkit - A toolkit for cheminformatics and machine learning
https://bugzilla.redhat.com/show_bug.cgi?id=804125
--- Comment #14 from Christopher Meng cicku...@gmail.com ---
Hi,
First, becasue F20 will use unversioned docdir name, in your global field you
should modify
%global docdir %{_docdir}/%{name}-%{version}
Also %{docdir}/README should be changed to %{_pkgdocdir}/README
Then, cmake has %cmake macro, you should rpm -E %cmake and find if the macro
can replace 6 lines of options.
Next, Remove rm -rf %{buildroot} in %install
Last, are these %{_libdir}/*.cmake needed?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=9dY9ko20lEa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989069] Review Request: python-uri-templates - A Python implementation of URI Template
https://bugzilla.redhat.com/show_bug.cgi?id=989069 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Blocks||989068 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=la1z5HSpsoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989068] Review Request: google-api-python-client - Google APIs Client Library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=989068 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Depends On||989069 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vAiJ1uI7CKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986608] Review Request: weasyprint - Utility and Python library to render HTML and CSS to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=986608 --- Comment #9 from Eric Smith space...@gmail.com --- Spec URL: http://fedorapeople.org/~brouhaha/weasyprint/weasyprint.spec SRPM URL: http://fedorapeople.org/~brouhaha/weasyprint/weasyprint-0.19.2-3.fc19.src.rpm I'm not sure whether the policy on /usr/bin/env was actually adopted, but I've updated the spec to eliminate both uses of it. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EK0OImmIsMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986608] Review Request: weasyprint - Utility and Python library to render HTML and CSS to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=986608 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Christopher Meng cicku...@gmail.com --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9x2VkX8J8Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/joyce-2.2.5-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gJlgRsLbsna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/joyce-2.2.5-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IkRnB3ghcSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xbbek13Hw3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989069] Review Request: python-uri-templates - A Python implementation of URI Template
https://bugzilla.redhat.com/show_bug.cgi?id=989069 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review+ --- Comment #1 from Christopher Meng cicku...@gmail.com --- A suggestion, use https://pypi.python.org/packages/source/u/uritemplate/uritemplate-0.5.2.tar.gz as source ;) You don't need to waste 2 lines. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1GooOCHg03a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986608] Review Request: weasyprint - Utility and Python library to render HTML and CSS to PDF
https://bugzilla.redhat.com/show_bug.cgi?id=986608 Eric Smith space...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Eric Smith space...@gmail.com --- New Package SCM Request === Package Name: weasyprint Short Description: Utility and Python library to render HTML and CSS to PDF Owners: brouhaha Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Oi78f7ZrDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989069] Review Request: python-uri-templates - A Python implementation of URI Template
https://bugzilla.redhat.com/show_bug.cgi?id=989069 --- Comment #2 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- (In reply to Christopher Meng from comment #1) A suggestion, use https://pypi.python.org/packages/source/u/uritemplate/uritemplate-0.5.2.tar. gz as source ;) You don't need to waste 2 lines. APPROVED. Thanks for the review Christoph. Is it OK if I continue to track github? pypi tends to get out of date rather quickly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UN4xW57qqNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989069] Review Request: python-uri-templates - A Python implementation of URI Template
https://bugzilla.redhat.com/show_bug.cgi?id=989069 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- New Package SCM Request === Package Name: python-uri-templates Short Description: A Python implementation of URI Template Owners: ankursinha Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QqQQ05WKb3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989069] Review Request: python-uri-templates - A Python implementation of URI Template
https://bugzilla.redhat.com/show_bug.cgi?id=989069 --- Comment #4 from Christopher Meng cicku...@gmail.com --- No problem. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D0q12run0Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957053] Review Request: groonga-normalizer-mysql - MySQL compatible normalizer plugin for groonga
https://bugzilla.redhat.com/show_bug.cgi?id=957053 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cnLPUYFarPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827167] Review Request: bumblebee - Bumblebee daemon
https://bugzilla.redhat.com/show_bug.cgi?id=827167 --- Comment #28 from Gary Gatling gsgat...@ncsu.edu --- Hello. Using systemd macros I cannot get this to work correctly. The problem seems to be with this command: if [ $1 -eq 1 ] ; then # Initial installation /usr/bin/systemctl preset bumblebeed.service /dev/null 21 || : fi Which I think is expanded from %systemd_post bumblebeed.service After I install the package, the bumblebeed service is not running and I have to start it by hand every time I wish to use my nvidia graphics card with the following command: [root@localhost ~]# systemctl start bumblebeed.service I need for this service to be enabled and running by default after it is installed so I don't have to do that. How do I do that using approved of methods? Is there some other daemon that also includes upstart and systemd init scripts I could look at as an example? Is there a centralized list of services that bumblebeed need to be added to to make it auto startup? Thank you for your time and consideration. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DmwrBv6XI8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989297] New: Review Request: fdm - A simple lightweight tool of fetching, filtering and delivering emails
https://bugzilla.redhat.com/show_bug.cgi?id=989297 Bug ID: 989297 Summary: Review Request: fdm - A simple lightweight tool of fetching, filtering and delivering emails Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://cicku.me/fdm.spec SRPM URL: http://cicku.me/fdm-1.7-1.fc20.src.rpm Description: fdm is a program to fetch mail and deliver it in various ways depending on a user-supplied ruleset. Mail may be fetched from stdin, IMAP or POP3 servers, or from local maildirs, and filtered based on whether it matches a regexp, its size or age, or the output of a shell command. It can be rewritten by an external process, dropped, left on the server or delivered into maildirs, mboxes, to a file or pipe, or any combination. fdm is designed to be lightweight but powerful, with a compact but clear configuration syntax. It is primarily designed for single-user uses but may also be configured to deliver mail in a multi-user setup. In this case, it uses privilege separation to minimise the amount of code running as root. Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LUq9UMqz7xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957053] Review Request: groonga-normalizer-mysql - MySQL compatible normalizer plugin for groonga
https://bugzilla.redhat.com/show_bug.cgi?id=957053 --- Comment #4 from Christopher Meng cicku...@gmail.com --- /var/tmp/rpm-tmp.zY5nBW: line 60: --disable-static: command not found Fedora 20 rawhide reports error happened. I'm not sure if this error is related to recent changes in RPM. My suggestion: Use: %configure --disable-static -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rzr0t9xu3la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961419] Review Request: anet - Ada Networking Library
https://bugzilla.redhat.com/show_bug.cgi?id=961419 --- Comment #5 from Christopher Meng cicku...@gmail.com --- Only this: anet.i686: I: enchant-dictionary-not-found sv And, where is Ahven? Will you package it? If not I will package it ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OiMpMkpHaYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989325] New: Review Request: libgme - Video game music file emulation/playback library
https://bugzilla.redhat.com/show_bug.cgi?id=989325 Bug ID: 989325 Summary: Review Request: libgme - Video game music file emulation/playback library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cicku...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://cicku.me/libgme.spec SRPM URL: http://cicku.me/libgme-0.6.0-1.fc20.src.rpm Description: Game Music Emu is a collection of video game music file emulators that support the following formats and systems: - AY: ZX Spectrum/Amstrad CPC - GBS: Nintendo Game Boy - GYM: Sega Genesis/Mega Drive - HES: NEC TurboGrafx-16/PC Engine - KSS: MSX Home Computer/other Z80 systems (doesn't support FM sound) - NSF/NSFE: Nintendo NES/Famicom (with VRC 6, Namco 106, and FME-7 sound) - SAP: Atari systems using POKEY sound chip - SPC: Super Nintendo/Super Famicom - VGM/VGZ: Sega Master System/Mark III, Sega Genesis/Mega Drive,BBC Micro Features: - Can be used in C and C++ code - High emphasis has been placed on making the library very easy to use - One set of common functions work with all emulators the same way - Several code examples, including music player using SDL - Portable code for use on any system with modern or older C++ compilers - Adjustable output sample rate using quality band-limited resampling - Uniform access to text information fields and track timing information - End-of-track fading and automatic look ahead silence detection - Treble/bass and stereo echo for AY/GBS/HES/KSS/NSF/NSFE/SAP/VGM - Tempo can be adjusted and individual voices can be muted while playing - Can read music data from file, memory, or custom reader function/class - Can access track information without having to load into full emulator - M3U track listing support for multi-track formats - Modular design allows elimination of unneeded emulators/features Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LUSV3TwvYta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969417] Review Request: aime - An application embeddable programming language interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=969417
Eric Smith space...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Eric Smith space...@gmail.com ---
There are two issues:
* must notify upstream of incorrect GPL address (many files with GPLv2)
* should update to latest upstream (aime-6.20130713)
Provided that you notify upstream of the incorrect GPL address, this
package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: Texinfo files are properly installed
Note: Texinfo .info file(s) in aime
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), GPL (v2 or later),
GPL (v3 or later). Detailed output of licensecheck in
/home/eric/fedpkg/969417-aime/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported
[Bug 989297] Review Request: fdm - A simple lightweight tool of fetching, filtering and delivering emails
https://bugzilla.redhat.com/show_bug.cgi?id=989297 HAYASHI Kentaro ken...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ken...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=udMGeNg8VBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989297] Review Request: fdm - A simple lightweight tool of fetching, filtering and delivering emails
https://bugzilla.redhat.com/show_bug.cgi?id=989297 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added CC||echevemas...@gmail.com --- Comment #1 from Eduardo Echeverria echevemas...@gmail.com --- HAYASHI, please assign to you the ticket, not only put the flag in ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DDRTAUcwPCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java
https://bugzilla.redhat.com/show_bug.cgi?id=849496 --- Comment #4 from Dan Callaghan dcall...@redhat.com --- (In reply to gil cattaneo from comment #3) excuse me, which version of Fedora you want to use this package? I'm not sure I understand the question... I was planning to build this for all current Fedora releases (F18 and newer I suppose, since F17 is almost EOL). But I still haven't had a chance to look into the test failures related to netty from comment 2. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NE9GcZhXiIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989297] Review Request: fdm - A simple lightweight tool of fetching, filtering and delivering emails
https://bugzilla.redhat.com/show_bug.cgi?id=989297 HAYASHI Kentaro ken...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ken...@gmail.com --- Comment #2 from HAYASHI Kentaro ken...@gmail.com --- Ah! Eduardo Echeverria, Thank you pointed out! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zfh35ceIWfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
